Re: Backporting for 1.625.3 has started

2015-11-25 Thread ogondza
Backported JENKINS-31649. Thanks Jesse.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/322e0560-ec6e-4b27-9b47-4f8fd26a0891%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Backporting for 1.625.3 has started

2015-11-24 Thread 'Jesse Glick' via Jenkins Developers
On Tue, Nov 24, 2015 at 7:04 AM, ogondza  wrote:
> I do not consider JENKINS-31718 to be a serious candidate for .3 as will
> likely not make it to the core when LTS is released

We can push it to `master` today. I would urge you to reconsider. This
is a potentially serious regression introduced in .2. Regressions
should be exempt from the soak period requirement IMO.

I also advocate for JENKINS-31649 to be included and will work on a
matching fix with test to `workflow-plugin`.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3MstZkiqMXAPv%3DGegTG8jhnUXp3Bq20Fo0A%3DzCUc7VGw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: Backporting for 1.625.3 has started

2015-11-24 Thread Stephen Connolly
What was your reason for rejecting JENKINS-31649? I suspect not fixing it
could be causing issues for plugins that track upstream blockers

On 24 November 2015 at 10:08, oliver gondža  wrote:

> Hi,
>
> Backporting for next LTS release is on. The RC will be published
> 2015-11-25.
>
> Candidates: https://issues.jenkins-ci.org/issues/?filter=12146
> Fixed:
> https://issues.jenkins-ci.org/issues/?jql=labels%20%3D%201.625.3-fixed
> Rejected:
> https://issues.jenkins-ci.org/issues/?jql=labels%20%3D%201.625.3-rejected
> --
> oliver
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/op.x8lnsfp1sbfict%40dhcp-10-40-2-236.brq.redhat.com
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMzQcKHPUeULxfJ%3DLGWb_4ZGmUMYC2YOfqmicfux0bx6rw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: Backporting for 1.625.3 has started

2015-11-24 Thread Stephen Connolly
FYI we will also likely want the fix for JENKINS-31718 if we can get it
confirmed today.

On 24 November 2015 at 10:31, Stephen Connolly <
stephen.alan.conno...@gmail.com> wrote:

> What was your reason for rejecting JENKINS-31649? I suspect not fixing it
> could be causing issues for plugins that track upstream blockers
>
> On 24 November 2015 at 10:08, oliver gondža  wrote:
>
>> Hi,
>>
>> Backporting for next LTS release is on. The RC will be published
>> 2015-11-25.
>>
>> Candidates: https://issues.jenkins-ci.org/issues/?filter=12146
>> Fixed:
>> https://issues.jenkins-ci.org/issues/?jql=labels%20%3D%201.625.3-fixed
>> Rejected:
>> https://issues.jenkins-ci.org/issues/?jql=labels%20%3D%201.625.3-rejected
>> --
>> oliver
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/op.x8lnsfp1sbfict%40dhcp-10-40-2-236.brq.redhat.com
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMw3vh%2BCYH_A4mg0HX4-wG9F9YFL-Ee%3Dmfd_%2BWYiY-dhdA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: Backporting for 1.625.3 has started

2015-11-24 Thread Daniel Beck

On 24.11.2015, at 11:31, Stephen Connolly  
wrote:

> What was your reason for rejecting JENKINS-31649?

If I had to guess I'd say no soaking. This hasn't even been released in main 
line yet (no 1.639 this week).

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/FC1EE375-DD59-4219-A55E-03D17FA07C04%40beckweb.net.
For more options, visit https://groups.google.com/d/optout.


Re: Backporting for 1.625.3 has started

2015-11-24 Thread Stephen Connolly
Well I would argue that it should be more seriously considered... I view
31718 and 31649 as fixing issues that are subtly more serious than people
might initially suspect.

The fix for 31649 I feel is sufficiently low risk that we can and I believe
should go ahead with it.

The fix for 31718 - assuming that we get confirmation from Oleg - is
another one that should probably go in... either that or a release of
remoting with PR#41 reverted but I think PR#65 is less risk (assuming that
it works that is)

On 24 November 2015 at 10:52, Daniel Beck  wrote:

>
> On 24.11.2015, at 11:31, Stephen Connolly 
> wrote:
>
> > What was your reason for rejecting JENKINS-31649?
>
> If I had to guess I'd say no soaking. This hasn't even been released in
> main line yet (no 1.639 this week).
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/FC1EE375-DD59-4219-A55E-03D17FA07C04%40beckweb.net
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMyicm7s54N1iiH_jbWeSh8DH2e_hLHWsQ0hGhYJ3ra1NA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: Backporting for 1.625.3 has started

2015-11-24 Thread ogondza
As Daniel said, none of the issues was released in any weekly. I agree 
JENKINS-31649 is of low risk so I am opened to backport it. Although, the 
priority is only major, not many votes, not clear who is affected, no 
unittests.

I do not consider JENKINS-31718 to be a serious candidate for .3 as will 
likely not make it to the core when LTS is released, not even talking about 
any soakng...

--
oliver

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/f493f38a-73d5-4ab7-afec-adfb063e82cb%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.