Re: OutOfMem error from test harness test after Jelly changes ??
On Friday, June 27, 2014 3:11:07 PM UTC+1, Tom Fennelly wrote: On Tuesday, June 24, 2014 11:30:43 PM UTC+1, Jesse Glick wrote: Is there some new JavaScript which is trying to load HTML content from the page for some reason? I was going to reply and say no, but decided to check and yes, there is a call to layoutUpdateCallback.call() on that branch. That change was a straggler I meant to remove with some other JS changes that were on an earlier form of that branch. I ditched that branch anyway, but will check and see if that call was the root cause of it failing nearly every time. Assuming it is, I'd still wonder if it's worth leaving the explicit -Xmx setting on surfire because, as I said in the original email, I was getting the very occasional OOM error on that same test so it seems borderline anyway. Removing that layoutUpdateCallback.call() call didn't fix the issue i.e. still get OOM exceptions with that changeset. There were other errors that I haven't looked into yet. I will chase this further if we think it makes sense. Or, we just decide to remove or leave that -Xmx setting. If we remove it we can always deal with potential OOM issues down the road if they come back. -- You received this message because you are subscribed to the Google Groups Jenkins Developers group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: OutOfMem error from test harness test after Jelly changes ??
On Tuesday, June 24, 2014 11:30:43 PM UTC+1, Jesse Glick wrote: Is there some new JavaScript which is trying to load HTML content from the page for some reason? I was going to reply and say no, but decided to check and yes, there is a call to layoutUpdateCallback.call() on that branch. That change was a straggler I meant to remove with some other JS changes that were on an earlier form of that branch. I ditched that branch anyway, but will check and see if that call was the root cause of it failing nearly every time. Assuming it is, I'd still wonder if it's worth leaving the explicit -Xmx setting on surfire because, as I said in the original email, I was getting the very occasional OOM error on that same test so it seems borderline anyway. -- You received this message because you are subscribed to the Google Groups Jenkins Developers group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: OutOfMem error from test harness test after Jelly changes ??
On Tue, 24 Jun 2014 01:14:04 +0200, Tom Fennelly tom.fenne...@gmail.com wrote: After making a series of Jelly script changes, I'm now getting regular OOM failures from AbstractProjectTest.testConfiguringBlockBuildWhenUpstreamBuildingRoundtrip (in the test harness) Here's the branch https://github.com/tfennelly/jenkins/tree/icons-via-css. I can solve by setting -Xmx256 for the surefire plugin in test/pom.ml. I was getting the odd OOM failure from this test before these changes. Maybe this has just pushed it over the edge. Anything else I should try? Without seeing full stack trace it seems to be cased by WebClient reading whole config page into memory. So I would say after your change it serves more content than it used to. Not sure if this is expected for your change. -- oliver -- You received this message because you are subscribed to the Google Groups Jenkins Developers group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: OutOfMem error from test harness test after Jelly changes ??
I think setting the minimum memory to Xmx256 is ok. Am 24.06.2014 um 08:39 schrieb oliver gondža ogon...@gmail.com: On Tue, 24 Jun 2014 01:14:04 +0200, Tom Fennelly tom.fenne...@gmail.com wrote: After making a series of Jelly script changes, I'm now getting regular OOM failures from AbstractProjectTest.testConfiguringBlockBuildWhenUpstreamBuildingRoundtrip (in the test harness) Here's the branch https://github.com/tfennelly/jenkins/tree/icons-via-css. I can solve by setting -Xmx256 for the surefire plugin in test/pom.ml. I was getting the odd OOM failure from this test before these changes. Maybe this has just pushed it over the edge. Anything else I should try? Without seeing full stack trace it seems to be cased by WebClient reading whole config page into memory. So I would say after your change it serves more content than it used to. Not sure if this is expected for your change. -- oliver -- You received this message because you are subscribed to the Google Groups Jenkins Developers group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. signature.asc Description: Message signed with OpenPGP using GPGMail
Re: OutOfMem error from test harness test after Jelly changes ??
Yeah, I think it's just a simple case of these changes blowing the memory profile of the test over the edge of what's available to the vm. As I said... I saw a few random failures on this test in the last week. I'll pull that change out into a separate fix. -- You received this message because you are subscribed to the Google Groups Jenkins Developers group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: OutOfMem error from test harness test after Jelly changes ??
Sorry... here's the trace... java.lang.OutOfMemoryError: Java heap space at java.util.Arrays.copyOf(Arrays.java:2734) at java.util.Vector.ensureCapacityHelper(Vector.java:226) at java.util.Vector.addElement(Vector.java:573) at org.apache.xml.dtm.ref.dom2dtm.DOM2DTM.addNode(DOM2DTM.java:246) at org.apache.xml.dtm.ref.dom2dtm.DOM2DTM.nextNode(DOM2DTM.java:542) at org.apache.xml.dtm.ref.dom2dtm.DOM2DTM.getHandleFromNode(DOM2DTM.java:679) at org.apache.xml.dtm.ref.dom2dtm.DOM2DTM.getHandleOfNode(DOM2DTM.java:731) at org.apache.xml.dtm.ref.DTMManagerDefault.getDTMHandleFromNode(DTMManagerDefault.java:573) at org.apache.xpath.XPathContext.getDTMHandleFromNode(XPathContext.java:184) at com.gargoylesoftware.htmlunit.html.xpath.XPathUtils.evaluateXPath(XPathUtils.java:129) at com.gargoylesoftware.htmlunit.html.xpath.XPathUtils.getByXPath(XPathUtils.java:72) at com.gargoylesoftware.htmlunit.javascript.host.html.HTMLCollection.computeElements(HTMLCollection.java:249) at com.gargoylesoftware.htmlunit.javascript.host.html.HTMLCollection.getElements(HTMLCollection.java:236) at com.gargoylesoftware.htmlunit.javascript.host.html.HTMLCollection.get(HTMLCollection.java:223) at net.sourceforge.htmlunit.corejs.javascript.ScriptableObject.getProperty(ScriptableObject.java:1881) at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.getObjectIndex(ScriptRuntime.java:1497) at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.getObjectIndex(ScriptRuntime.java:1482) at net.sourceforge.htmlunit.corejs.javascript.Interpreter.interpretLoop(Interpreter.java:1452) at net.sourceforge.htmlunit.corejs.javascript.Interpreter.interpret(Interpreter.java:879) at net.sourceforge.htmlunit.corejs.javascript.InterpretedFunction.call(InterpretedFunction.java:164) at net.sourceforge.htmlunit.corejs.javascript.NativeArray.iterativeMethod(NativeArray.java:1484) at net.sourceforge.htmlunit.corejs.javascript.NativeArray.execIdCall(NativeArray.java:335) at net.sourceforge.htmlunit.corejs.javascript.IdFunctionObject.call(IdFunctionObject.java:129) at net.sourceforge.htmlunit.corejs.javascript.Interpreter.interpretLoop(Interpreter.java:1722) at net.sourceforge.htmlunit.corejs.javascript.Interpreter.interpret(Interpreter.java:879) at net.sourceforge.htmlunit.corejs.javascript.InterpretedFunction.call(InterpretedFunction.java:164) at net.sourceforge.htmlunit.corejs.javascript.ContextFactory.doTopCall(ContextFactory.java:427) at com.gargoylesoftware.htmlunit.javascript.HtmlUnitContextFactory.doTopCall(HtmlUnitContextFactory.java:263) at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.doTopCall(ScriptRuntime.java:3058) at net.sourceforge.htmlunit.corejs.javascript.InterpretedFunction.call(InterpretedFunction.java:162) at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine.callFunction(JavaScriptEngine.java:486) at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine$6.doRun(JavaScriptEngine.java:451) -- You received this message because you are subscribed to the Google Groups Jenkins Developers group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: OutOfMem error from test harness test after Jelly changes ??
On Tue, Jun 24, 2014 at 4:19 AM, Tom Fennelly tom.fenne...@gmail.com wrote: at com.gargoylesoftware.htmlunit.javascript.host.html.HTMLCollection.computeElements(HTMLCollection.java:249) at com.gargoylesoftware.htmlunit.javascript.host.html.HTMLCollection.getElements(HTMLCollection.java:236) at com.gargoylesoftware.htmlunit.javascript.host.html.HTMLCollection.get(HTMLCollection.java:223) at net.sourceforge.htmlunit.corejs.javascript.ScriptableObject.getProperty(ScriptableObject.java:1881) Is there some new JavaScript which is trying to load HTML content from the page for some reason? -- You received this message because you are subscribed to the Google Groups Jenkins Developers group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
