Re: Rechecking Pull Requests

[Oleg Nenashev]

The plugin will not work as is for jobs in the GitHub org folder:
https://github.com/jenkinsci/github-pr-comment-build-plugin/issues/1 . In
the case of ci.jenkins.io, it means it will not work for plugins (but will
work for the core and many other repos, and it is already great). A fix
would be greatly appreciated.

I agree we should consider installing it and configuring for something like
"/jenkins rebuild"

On Sun, Oct 6, 2019, 15:33 Jesse Glick  wrote:

> On Sun, Oct 6, 2019 at 2:59 AM Parichay Barpanda
>  wrote:
> > https://github.com/jenkinsci/github-pr-comment-build-plugin. Take a
> look at it, either decide to implement this feature in GitHub Branch Source
> or use this plugin.
>
> Have not tried it myself, but sounds useful; certainly more friendly
> than the existing workarounds described by Mark and Gavin. Feel free
> to file an `INFRA` ticket to install and configure this plugin on
> ci.jenkins.io.
>
> --
> You received this message because you are subscribed to a topic in the
> Google Groups "Jenkins Developers" group.
> To unsubscribe from this topic, visit
> https://groups.google.com/d/topic/jenkinsci-dev/GvvB0PyoNJA/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3d__Ft6Xdco9dg5bGB0UJ1cKe-7h4bS3H0-N9kfk2UcA%40mail.gmail.com
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLBBX4kdD0zxvvRLY6aL6iLHS7u7z-G-v_M_%3DNeDR%2BLHvQ%40mail.gmail.com.

Re: Rechecking Pull Requests

[Jesse Glick]

On Sun, Oct 6, 2019 at 2:59 AM Parichay Barpanda
 wrote:
> https://github.com/jenkinsci/github-pr-comment-build-plugin. Take a look at 
> it, either decide to implement this feature in GitHub Branch Source or use 
> this plugin.

Have not tried it myself, but sounds useful; certainly more friendly
than the existing workarounds described by Mark and Gavin. Feel free
to file an `INFRA` ticket to install and configure this plugin on
ci.jenkins.io.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3d__Ft6Xdco9dg5bGB0UJ1cKe-7h4bS3H0-N9kfk2UcA%40mail.gmail.com.

Re: Rechecking Pull Requests

[Parichay Barpanda]

Hi Oleg,

For implementing the same feature for GitLab Branch Source Plugin, I took
some inspiration from one of the existing plugin for GitHub Branch Source
https://github.com/jenkinsci/github-pr-comment-build-plugin. Take a look at
it, either decide to implement this feature in GitHub Branch Source or use
this plugin. In case of implementation I can help, let me know.

Regards,
Parichay

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAD0DWAO5p0xq6Nxbt_po_GgFCq1g-h_xkYuo3zpEpMOgGBoVPg%40mail.gmail.com.

Re: Rechecking Pull Requests

[Oleg Nenashev]

Yes, no way to retrigger builds now excwpt reopening PRs unfortunately (unless 
you are a co.ienkins.io admin)

I want to add support of a "/jenkins rebuild" comment command to GitHub Branch 
Source to fix it

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/6adf8fb6-56f1-423c-961c-4916b7ca4428%40googlegroups.com.

Re: Rechecking Pull Requests

[Mez Pahlan]

I've come to the conclusion that there is no way to do this. You can't 
select Build Now from the Jenkins Infra CI build site (probably to protect 
against spam usage which is fair enough) and nor do you have this on 
Github. So you need to create a new "event" in the PR as described above. 

Whilst it is really frustrating that the build has failed due to no fault 
of your own and that this causes a big red cross to appear, it was 
explained to me that these builds are meaningless and don't *actually* block 
your PR. You can ignore the result of the CI build and merge *if you feel 
it is safe*.

What I would like, given this, is for Jenkins Infra CI builds to send back 
not a build failure but something like *build unstable* if that is possible 
and detect when a build failure is caused by a bad PR or by bad 
infrastructure. If a human can read the logs and determine this then surely 
it is possible to do automatically. Maybe that would be a happy middle 
ground between (what seems to be to me) 90% successful infrastructure 
builds and 10% failures unrelated to your PR. What I would do instead is 
run mvn clean install locally and confirm the build. And maybe a message to 
that effect would be good too.

On Saturday, 5 October 2019 03:28:48 UTC+1, Gavin Mogan wrote:
>
> A lot of people is close the pr. Then wait like 30 seconds. And reopen it.
>
> On Fri., Oct. 4, 2019, 6:56 p.m. Mark Waite,  > wrote:
>
>> The simplest technique for me has been to use `git commit --amend` on the 
>> most recent commit, then force push that change to the repository.  There 
>> is almost always something that I can improve about the last commit in a 
>> pull request.
>>
>> On Fri, Oct 4, 2019 at 7:45 PM Richard Bywater > > wrote:
>>
>>> Hi
>>>
>>> One of my pull requests failed on ci.jenkins.io due to what looks like 
>>> an infrastructure issue ( 
>>> https://ci.jenkins.io/job/Plugins/job/htmlpublisher-plugin/view/change-requests/job/PR-48/3/console
>>>  
>>> )
>>>
>>> Is there a way of getting it to re-run the build job on the PR as I 
>>> don't seem to have access to "Build Now" on the Jenkins infrastructure and 
>>> Github doesn't seem to have a "recheck" option either. 
>>>
>>> Ideally I'd really love to not have to create a dummy commit to do it as 
>>> that doesn't really seem like a very good way of getting around the issue 
>>> of jobs that fail due to infrastructure issues.
>>>
>>> Thanks
>>> Richard.
>>>
>>> -- 
>>> You received this message because you are subscribed to the Google 
>>> Groups "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to jenkin...@googlegroups.com .
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAAy0hwfoQdE%3Dr03LTgqC9_0XvnhgnAVTC4kNPftE6n7jCPV40A%40mail.gmail.com
>>>  
>>> 
>>> .
>>>
>>
>>
>> -- 
>> Thanks!
>> Mark Waite
>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkin...@googlegroups.com .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtEUqBFdHCmubyfkojveMs2Z4hsOXpk9SfU29-tYX%3D%2BJuw%40mail.gmail.com
>>  
>> 
>> .
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/6eafa9bb-6f0e-4268-9438-1808080fcd3c%40googlegroups.com.

Re: Rechecking Pull Requests

[Gavin]

A lot of people is close the pr. Then wait like 30 seconds. And reopen it.

On Fri., Oct. 4, 2019, 6:56 p.m. Mark Waite, 
wrote:

> The simplest technique for me has been to use `git commit --amend` on the
> most recent commit, then force push that change to the repository.  There
> is almost always something that I can improve about the last commit in a
> pull request.
>
> On Fri, Oct 4, 2019 at 7:45 PM Richard Bywater  wrote:
>
>> Hi
>>
>> One of my pull requests failed on ci.jenkins.io due to what looks like
>> an infrastructure issue (
>> https://ci.jenkins.io/job/Plugins/job/htmlpublisher-plugin/view/change-requests/job/PR-48/3/console
>> )
>>
>> Is there a way of getting it to re-run the build job on the PR as I don't
>> seem to have access to "Build Now" on the Jenkins infrastructure and Github
>> doesn't seem to have a "recheck" option either.
>>
>> Ideally I'd really love to not have to create a dummy commit to do it as
>> that doesn't really seem like a very good way of getting around the issue
>> of jobs that fail due to infrastructure issues.
>>
>> Thanks
>> Richard.
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAAy0hwfoQdE%3Dr03LTgqC9_0XvnhgnAVTC4kNPftE6n7jCPV40A%40mail.gmail.com
>> 
>> .
>>
>
>
> --
> Thanks!
> Mark Waite
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtEUqBFdHCmubyfkojveMs2Z4hsOXpk9SfU29-tYX%3D%2BJuw%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_Duva7csdSsTcLs_cNb2VQVgcq9mBcmtcQTggVzpDo5CPnw%40mail.gmail.com.

Re: Rechecking Pull Requests

[Mark Waite]

The simplest technique for me has been to use `git commit --amend` on the
most recent commit, then force push that change to the repository.  There
is almost always something that I can improve about the last commit in a
pull request.

On Fri, Oct 4, 2019 at 7:45 PM Richard Bywater  wrote:

> Hi
>
> One of my pull requests failed on ci.jenkins.io due to what looks like an
> infrastructure issue (
> https://ci.jenkins.io/job/Plugins/job/htmlpublisher-plugin/view/change-requests/job/PR-48/3/console
> )
>
> Is there a way of getting it to re-run the build job on the PR as I don't
> seem to have access to "Build Now" on the Jenkins infrastructure and Github
> doesn't seem to have a "recheck" option either.
>
> Ideally I'd really love to not have to create a dummy commit to do it as
> that doesn't really seem like a very good way of getting around the issue
> of jobs that fail due to infrastructure issues.
>
> Thanks
> Richard.
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAAy0hwfoQdE%3Dr03LTgqC9_0XvnhgnAVTC4kNPftE6n7jCPV40A%40mail.gmail.com
> 
> .
>


-- 
Thanks!
Mark Waite

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtEUqBFdHCmubyfkojveMs2Z4hsOXpk9SfU29-tYX%3D%2BJuw%40mail.gmail.com.