[JIRA] (JENKINS-42401) crash when enabling or disabling JMS Messaging Plugin trigger on an existing Pipeline job
Title: Message Title Dan C updated an issue Jenkins / JENKINS-42401 crash when enabling or disabling JMS Messaging Plugin trigger on an existing Pipeline job Change By: Dan C Summary: crash when enabling or disabling JMS Messaging Plugin not compatible with trigger on an existing Pipeline jobs job Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42401) JMS Messaging Plugin not compatible with Pipeline jobs
Title: Message Title Dan C commented on JENKINS-42401 Re: JMS Messaging Plugin not compatible with Pipeline jobs I noticed this problem only happens when enabling the CI trigger on an existing pipeline job. It works if I create the pipeline job with the CI trigger enabled from the beginning. If I try to remove the CI trigger from an existing job then there is a different, but maybe related, failure: javax.servlet.ServletException: java.lang.NullPointerException at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:796) at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876) at org.kohsuke.stapler.MetaClass$5.doDispatch(MetaClass.java:236) at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:58) at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:746) at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876) at org.kohsuke.stapler.Stapler.invoke(Stapler.java:649) at org.kohsuke.stapler.Stapler.service(Stapler.java:238) at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:812) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1669) at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:135) at hudson.plugins.greenballs.GreenBallFilter.doFilter(GreenBallFilter.java:59) at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:132) at net.bull.javamelody.MonitoringFilter.doFilter(MonitoringFilter.java:201) at net.bull.javamelody.MonitoringFilter.doFilter(MonitoringFilter.java:178) at net.bull.javamelody.PluginMonitoringFilter.doFilter(PluginMonitoringFilter.java:85) at org.jvnet.hudson.plugins.monitoring.HudsonMonitoringFilter.doFilter(HudsonMonitoringFilter.java:104) at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:132) at hudson.util.PluginServletFilter.doFilter(PluginServletFilter.java:126) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652) at hudson.security.csrf.CrumbFilter.doFilter(CrumbFilter.java:49) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:84) at hudson.security.UnwrapSecurityExceptionFilter.doFilter(UnwrapSecurityExceptionFilter.java:51) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at jenkins.security.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:117) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at org.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:125) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at org.acegisecurity.ui.rememberme.RememberMeProcessingFilter.doFilter(RememberMeProcessingFilter.java:142) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at org.acegisecurity.ui.AbstractProcessingFilter.doFilter(AbstractProcessingFilter.java:271) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at jenkins.security.BasicHeaderProcessor.doFilter(BasicHeaderProcessor.java:93) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at org.acegisecurity.context.HttpSessionContextIntegrationFilter.doFilter(HttpSessionContextIntegrationFilter.java:249) at
[JIRA] (JENKINS-42401) JMS Messaging Plugin not compatible with Pipeline jobs
Title: Message Title Dan C created an issue Jenkins / JENKINS-42401 JMS Messaging Plugin not compatible with Pipeline jobs Issue Type: Bug Assignee: Scott Hebert Components: jms-messaging-plugin Created: 2017/Mar/01 1:57 PM Environment: Jenkins 2.32.2, Pipeline 2.4, jms-messaging-plugin 1.0.9, RHEL7. Priority: Major Reporter: Dan C Enabling JMS messaging trigger on a Pipeline job fails with the following stack trace: javax.servlet.ServletException: java.lang.ClassCastException: org.jenkinsci.plugins.workflow.job.WorkflowJob cannot be cast to hudson.model.AbstractProject at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:796) at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876) at org.kohsuke.stapler.MetaClass$5.doDispatch(MetaClass.java:236) at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:58) at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:746) at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876) at org.kohsuke.stapler.Stapler.invoke(Stapler.java:649) at org.kohsuke.stapler.Stapler.service(Stapler.java:238) at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:812) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1669) at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:135) at hudson.plugins.greenballs.GreenBallFilter.doFilter(GreenBallFilter.java:59) at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:132) at
[JIRA] (JENKINS-38974) Comment Added event crashes with NullPointerException
Title: Message Title Dan C commented on JENKINS-38974 Re: Comment Added event crashes with NullPointerException BTW the above commit from Andres Rodriguez seems to be totally unrelated... Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38974) Comment Added event crashes with NullPointerException
Title: Message Title Dan C commented on JENKINS-38974 Re: Comment Added event crashes with NullPointerException Here is a PR including reproducer: https://github.com/jenkinsci/gerrit-trigger-plugin/pull/301 Not sure if that's really the best place for the test though... Also, this has the downside of still requiring every job definition to be re-saved in order to avoid the NPE. I wonder if it might also be worthwhile to be defensive on the opposite side when handling the comment-added event, to use PLAIN if the option is set to null? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38974) Comment Added event crashes with NullPointerException
Title: Message Title Dan C commented on JENKINS-38974 Re: Comment Added event crashes with NullPointerException Scratch that... doesn't require every job to be re-saved, I didn't realise that that readResolve() method magically fixes up any existing job definitions when the plugin is upgraded. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38912) SEVERE: Exception thrown during event handling
Title: Message Title Dan C commented on JENKINS-38912 Re: SEVERE: Exception thrown during event handling Looks like a dupe of JENKINS-38974 ? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38974) Comment Added event crashes with NullPointerException
Title: Message Title
Dan C commented on JENKINS-38974
Re: Comment Added event crashes with NullPointerException
The problem seems to be that is missing from existing job definitions. It's also not filled in by the plugin when an XML job definition is saved (for example when using Jenkins Job Builder, which doesn't generate any of the *ParameterMode elements). When that option is missing from the job definition the getter is returning null which means that commentTextMode is null in this block:
if (event instanceof CommentAdded) {
String comment = ((CommentAdded)event).getComment();
if (comment != null) {
commentTextMode.setOrCreateParameterValue(GERRIT_EVENT_COMMENT_TEXT,
parameters, comment, ParameterMode.PlainMode.TEXT, escapeQuotes);
}
}
I see that in commit e94a36e0 there is some special handling for changeSubjectParameterMode, when it was added, to ensure that the default is filled in to the job definition. I guess a similar thing should have been done for commentTextParameterMode.
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from
[JIRA] [gerrit-trigger-plugin] (JENKINS-27559) NullPointerException in Revision.containsBranchName with Gerrit Trigger choosing strategy and build any branch
Dan C
updated JENKINS-27559
NullPointerException in Revision.containsBranchName with Gerrit Trigger choosing strategy and build any branch
Change By:
Dan C
(24/Mar/15 5:37 AM)
Description:
JobisconfiguredtouseGitwithGerritTriggerchoosingstrategy.Remotenameisgerrit,refspecis:
{{
+refs/heads/*:refs/remotes/gerrit/*$GERRIT_REFSPEC
}}
.Configuredtomergewith
{{
$GERRIT_BRANCH
}}
andcalculatechangelogagainst
{{
$GERRIT_BRANCH
}}
.WhenusingtheGerritTriggerchoosingstrategy,branchestobuildismeaningless,soIleftitatthedefault**.HoweverthatcausesthefollowingNPE.Changingthebranchestobuildtoavalidbranchnamelikemasterfixestheproblem.{code}RetriggeredbyuserdcallaghforGerrit:http://gerrit.beaker-project.org/4092insilentmode.[EnvInject]-Loadingnodeenvironmentvariables.Buildinginworkspace/var/lib/jenkins/jobs/restraint-review-checks/workspaceselectedGitinstallationdoesnotexists.UsingDefaultgitrev-parse--is-inside-work-tree#timeout=10FetchingchangesfromtheremoteGitrepositorygitconfigremote.gerrit.urlssh://jenk...@gerrit.beaker-project.org:29418/restraint#timeout=10Fetchingupstreamchangesfromssh://jenk...@gerrit.beaker-project.org:29418/restraintgit--version#timeout=10usingGIT_SSHtosetcredentialsgit-ccore.askpass=truefetch--tags--progreh://jenk...@gerrit.beaker-project.org:29418/restraint+refs/heads/*:refs/remotes/gerrit/*refs/changes/92/4092/1gitrev-parse918d97ecf9cf9fac9ff26a15531e975bde64f4ed^{commit}#timeout=10FATAL:nulljava.lang.NullPointerException athudson.plugins.git.Revision.containsBranchName(Revision.java:104) athudson.plugins.git.extensions.impl.PreBuildMerge.decorateRevisionToBuild(PreBuildMerge.java:57) athudson.plugins.git.GitSCM.determineRevisionToBuild(GitSCM.java:925) athudson.plugins.git.GitSCM.checkout(GitSCM.java:1017) athudson.scm.SCM.checkout(SCM.java:484) athudson.model.AbstractProject.checkout(AbstractProject.java:1270) athudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:609) atjenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) athudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:531) athudson.model.Run.execute(Run.java:1751) athudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) athudson.model.ResourceController.execute(ResourceController.java:89) athudson.model.Executor.run(Executor.java:240)Finished:FAILURE{code}
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [gerrit-trigger-plugin] (JENKINS-27559) NullPointerException in Revision.containsBranchName with Gerrit Trigger choosing strategy and build any branch
Dan C
created JENKINS-27559
NullPointerException in Revision.containsBranchName with Gerrit Trigger choosing strategy and build any branch
Issue Type:
Bug
Assignee:
rsandell
Components:
gerrit-trigger-plugin
Created:
24/Mar/15 5:36 AM
Description:
Job is configured to use Git with Gerrit Trigger choosing strategy. Remote name is gerrit, refspec is: +refs/heads/:refs/remotes/gerrit/ $GERRIT_REFSPEC. Configured to merge with $GERRIT_BRANCH and calculate changelog against $GERRIT_BRANCH.
When using the Gerrit Trigger choosing strategy, "branches to build" is meaningless, so I left it at the default "**". However that causes the following NPE.
Changing the "branches to build" to a valid branch name like "master" fixes the problem.
Retriggered by user dcallagh for Gerrit: http://gerrit.beaker-project.org/4092 in silent mode.
[EnvInject] - Loading node environment variables.
Building in workspace /var/lib/jenkins/jobs/restraint-review-checks/workspace
selected Git installation does not exists. Using Default
git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
git config remote.gerrit.url ssh://jenk...@gerrit.beaker-project.org:29418/restraint # timeout=10
Fetching upstream changes from ssh://jenk...@gerrit.beaker-project.org:29418/restraint
git --version # timeout=10
using GIT_SSH to set credentials
git -c core.askpass=true fetch --tags --progress ssh://jenk...@gerrit.beaker-project.org:29418/restraint +refs/heads/*:refs/remotes/gerrit/* refs/changes/92/4092/1
git rev-parse 918d97ecf9cf9fac9ff26a15531e975bde64f4ed^{commit} # timeout=10
FATAL: null
java.lang.NullPointerException
at hudson.plugins.git.Revision.containsBranchName(Revision.java:104)
at hudson.plugins.git.extensions.impl.PreBuildMerge.decorateRevisionToBuild(PreBuildMerge.java:57)
at hudson.plugins.git.GitSCM.determineRevisionToBuild(GitSCM.java:925)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1017)
at hudson.scm.SCM.checkout(SCM.java:484)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1270)
at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:609)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:531)
at hudson.model.Run.execute(Run.java:1751)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:89)
at hudson.model.Executor.run(Executor.java:240)
Finished: FAILURE
Environment:
Jenkins 1.605, Git plugin 2.3.5, Gerrit Trigger plugin 2.12.0
Project:
Jenkins
Priority:
Minor
Reporter:
Dan C
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [beaker-builder-plugin] (JENKINS-27003) NullPointerException XMLEscapingVariableResolver.java:15
Dan C commented on JENKINS-27003 NullPointerException XMLEscapingVariableResolver.java:15 https://github.com/vjuranek/beaker-builder-plugin/pull/3 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [beaker-builder-plugin] (JENKINS-27003) NullPointerException XMLEscapingVariableResolver.java:15
Dan C created JENKINS-27003 NullPointerException XMLEscapingVariableResolver.java:15 Issue Type: Bug Assignee: Dan C Components: beaker-builder-plugin Created: 18/Feb/15 6:26 AM Description: FATAL: null java.lang.NullPointerException at org.jenkinsci.plugins.beakerbuilder.XMLEscapingVariableResolver.resolve(XMLEscapingVariableResolver.java:15) at org.jenkinsci.plugins.beakerbuilder.XMLEscapingVariableResolver.resolve(XMLEscapingVariableResolver.java:5) at hudson.Util.replaceMacro(Util.java:160) at org.jenkinsci.plugins.beakerbuilder.JobSource.createDefaultJobFile(JobSource.java:65) at org.jenkinsci.plugins.beakerbuilder.FileJobSource.createJobFile(FileJobSource.java:53) at org.jenkinsci.plugins.beakerbuilder.BeakerBuilder.prepareJob(BeakerBuilder.java:130) at org.jenkinsci.plugins.beakerbuilder.BeakerBuilder.perform(BeakerBuilder.java:77) at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20) at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:770) at hudson.model.Build$BuildExecution.build(Build.java:199) at hudson.model.Build$BuildExecution.doRun(Build.java:160) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:533) at hudson.model.Run.execute(Run.java:1745) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:89) at hudson.model.Executor.run(Executor.java:240) I'm guessing the inner VariableResolver can return null from .resolve() if the variable was undefined. Environment: Plugin version 1.6 Project: Jenkins Priority: Minor Reporter: Dan C This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
