Re: Review Request JDK-8182416: Clean up module-info.java like move requires transitive adjacent to exports

[Alan Bateman]

On 17/06/2017 16:19, Mandy Chung wrote:

On Jun 17, 2017, at 7:26 AM, Alan Bateman  wrote:

On 17/06/2017 07:27, Mandy Chung wrote:

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182416/webrev.00/

This patch cleans up module-info.java mainly moving requires transitive
before exports, group exports/opens (packages) together and uses/provides
(services) next.

Document if a module is upgradeable.

jdeps —-generate-module-info is also updated to list requires transitive
before exports.


This looks okay to me, I just wonder if jdk.xml.ws and jdk.xml.bind modules 
need the upgradeable note given that they aren't standard modules.


Good point and will drop that sentence.
  

A minor nit in java.corba where it has "This ...". All the others have a 
space.


Fixed.


For jdeps then should it emit a blank line between the groupings to be 
consistent with the proposed layout?

Updated webrev:

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182416/webrev.01/


Looks good.

-Alan

Re: Review Request JDK-8182416: Clean up module-info.java like move requires transitive adjacent to exports

[Mandy Chung]

> On Jun 17, 2017, at 7:26 AM, Alan Bateman  wrote:
> 
> On 17/06/2017 07:27, Mandy Chung wrote:
>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182416/webrev.00/
>> 
>> This patch cleans up module-info.java mainly moving requires transitive
>> before exports, group exports/opens (packages) together and uses/provides
>> (services) next.
>> 
>> Document if a module is upgradeable.
>> 
>> jdeps —-generate-module-info is also updated to list requires transitive
>> before exports.
>> 
> This looks okay to me, I just wonder if jdk.xml.ws and jdk.xml.bind modules 
> need the upgradeable note given that they aren't standard modules.
> 

Good point and will drop that sentence.
 
> A minor nit in java.corba where it has "This ...". All the others have a 
> space.
> 

Fixed.

> For jdeps then should it emit a blank line between the groupings to be 
> consistent with the proposed layout?

Updated webrev:

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182416/webrev.01/

Mandy

hg: jigsaw/jake/jaxp: 2 new changesets

[alan . bateman]

Changeset: f0eb5431121e
Author:joehw
Date:  2017-06-15 12:40 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/f0eb5431121e

8182111: Package summary is missing in jdk.xml.dom module
Reviewed-by: mchung

+ src/jdk.xml.dom/share/classes/org/w3c/dom/css/package-info.java
+ src/jdk.xml.dom/share/classes/org/w3c/dom/html/package-info.java
+ src/jdk.xml.dom/share/classes/org/w3c/dom/stylesheets/package-info.java
+ src/jdk.xml.dom/share/classes/org/w3c/dom/xpath/package-info.java

Changeset: e3909ee97599
Author:alanb
Date:  2017-06-17 15:37 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/e3909ee97599

Merge

hg: jigsaw/jake/langtools: 5 new changesets

[alan . bateman]

Changeset: bbb3a10fce39
Author:jjg
Date:  2017-06-15 14:45 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/bbb3a10fce39

8181825: Add tool and services information to module summary
Reviewed-by: mchung, rfield

! src/jdk.compiler/share/classes/com/sun/tools/javac/Main.java
+ src/jdk.compiler/share/classes/com/sun/tools/javac/package-info.java
! src/jdk.compiler/share/classes/module-info.java
! src/jdk.javadoc/share/classes/module-info.java
! src/jdk.jdeps/share/classes/module-info.java
! src/jdk.jshell/share/classes/module-info.java

Changeset: 15ebbc892255
Author:jjg
Date:  2017-06-16 15:29 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/15ebbc892255

8182406: Add missing legal file for jquery
Reviewed-by: mchung

+ src/jdk.javadoc/share/legal/jquery.md

Changeset: abaedfca9e3e
Author:alanb
Date:  2017-06-16 09:21 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/abaedfca9e3e

8181087: Module system implementation refresh (6/2017)
Reviewed-by: jjg
Contributed-by: alan.bate...@oracle.com, jan.lah...@oracle.com

! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/file/Locations.java
! 
src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties
! src/jdk.jdeps/share/classes/module-info.java
+ 
test/tools/javac/diags/examples/PackageClashFromRequiresInUnnamed/PackageClashFromRequiresInUnnamed.java
+ 
test/tools/javac/diags/examples/PackageClashFromRequiresInUnnamed/modulepath/lib1x/exported/Api1.java
+ 
test/tools/javac/diags/examples/PackageClashFromRequiresInUnnamed/modulepath/lib1x/module-info.java
+ 
test/tools/javac/diags/examples/PackageClashFromRequiresInUnnamed/modulepath/lib2x/exported/Api2.java
+ 
test/tools/javac/diags/examples/PackageClashFromRequiresInUnnamed/modulepath/lib2x/module-info.java
! test/tools/javac/modules/AutomaticModules.java
! test/tools/javac/modules/PackageConflictTest.java

Changeset: cbabd54a029b
Author:alanb
Date:  2017-06-17 08:02 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/cbabd54a029b

Merge

! src/jdk.jdeps/share/classes/module-info.java

Changeset: 3938af370ffd
Author:alanb
Date:  2017-06-17 15:33 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/3938af370ffd

Merge

! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/file/Locations.java
! 
src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties
! src/jdk.compiler/share/classes/module-info.java
! src/jdk.javadoc/share/classes/module-info.java
! src/jdk.jdeps/share/classes/module-info.java
! src/jdk.jshell/share/classes/module-info.java
! test/tools/javac/modules/AutomaticModules.java
! test/tools/javac/modules/PackageConflictTest.java

hg: jigsaw/jake/hotspot: 11 new changesets

[alan . bateman]

Changeset: 79b6a9bd5c3b
Author:fyang
Date:  2017-06-10 16:01 +0800
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/79b6a9bd5c3b

8181906: AArch64: port bugfix for 7009641 to AArch64
Summary: Allocation in the code cache returns NULL instead of failing the 
entire VM
Reviewed-by: aph
Contributed-by: teng...@linaro.org

! src/cpu/aarch64/vm/vtableStubs_aarch64.cpp

Changeset: 29467418d0ca
Author:rbackman
Date:  2017-06-02 11:26 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/29467418d0ca

8180197: Failing assert: id must be initialized
Reviewed-by: kvn, kbarrett

! src/share/vm/compiler/compileBroker.cpp

Changeset: 7107dccce2b2
Author:dlong
Date:  2017-06-13 10:27 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/7107dccce2b2

8181757: NonNMethod heap in segmented CodeCache is not scanned in some cases
8171365: nsk/jvmti/scenarios/events/EM04/em04t001: many errors for missed events
Reviewed-by: thartmann, kvn

! src/share/vm/code/codeCache.cpp
! src/share/vm/code/codeCache.hpp

Changeset: d7709f2d4bd3
Author:sspitsyn
Date:  2017-06-13 16:19 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/d7709f2d4bd3

8178054: [TESTBUG] Need test for JVM TI IsModifiableModule
Summary: Add new test hotspot/test/serviceability/jvmti/GetNamedModule
Reviewed-by: alanb, iignatyev

! make/test/JtregNative.gmk
! test/serviceability/jvmti/GetNamedModule/MyPackage/GetNamedModuleTest.java
+ 
test/serviceability/jvmti/IsModifiableModule/MyPackage/IsModifiableModuleTest.java
+ test/serviceability/jvmti/IsModifiableModule/libIsModifiableModuleTest.c

Changeset: 5e54f0bcf4ef
Author:sspitsyn
Date:  2017-06-13 23:22 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/5e54f0bcf4ef

Merge


Changeset: 232d93f11c49
Author:lana
Date:  2017-06-15 17:43 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/232d93f11c49

Merge


Changeset: 5347a840127d
Author:dnsimon
Date:  2017-06-16 12:18 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/5347a840127d

8182310: [AOT][JVMCI] Get host class of VM anonymous class
Summary: Add missing JVMCI functionality
Reviewed-by: dlong, kvn

! 
src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/CompilerToVM.java
! 
src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedObjectTypeImpl.java
! 
src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedPrimitiveType.java
! 
src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/ResolvedJavaType.java
! src/share/vm/jvmci/jvmciCompilerToVM.cpp
! 
test/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestResolvedJavaType.java

Changeset: 409ae96e9140
Author:poonam
Date:  2017-06-16 22:10 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/409ae96e9140

8178536: OOM ERRORS + SERVICE-THREAD TAKES A PROCESSOR TO 100%
Summary: Clear the pending OOM exception in SensorInfo::trigger()
Reviewed-by: mchung, dcubed

! src/share/vm/services/lowMemoryDetector.cpp

Changeset: 0d4a6056e3cc
Author:alanb
Date:  2017-06-16 09:20 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/0d4a6056e3cc

8181087: Module system implementation refresh (6/2017)
Reviewed-by: sspitsyn, hseigel

! make/symbols/symbols-unix
! src/share/vm/classfile/modules.cpp
! src/share/vm/classfile/modules.hpp
! src/share/vm/prims/jvm.cpp
! src/share/vm/prims/jvm.h
! src/share/vm/prims/whitebox.cpp
! src/share/vm/runtime/arguments.cpp
- test/runtime/modules/JVMAddModulePackage.java
! test/runtime/modules/ModuleHelper.java
! test/runtime/modules/java.base/java/lang/ModuleHelper.java

Changeset: 032a5041e20a
Author:alanb
Date:  2017-06-17 08:03 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/032a5041e20a

Merge

- test/runtime/modules/JVMAddModulePackage.java

Changeset: e2fda2cd1cac
Author:alanb
Date:  2017-06-17 15:35 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/e2fda2cd1cac

Merge

! make/symbols/symbols-unix
! make/test/JtregNative.gmk
! src/share/vm/classfile/modules.cpp
! src/share/vm/classfile/modules.hpp
! src/share/vm/prims/jvm.cpp
! src/share/vm/prims/jvm.h
! src/share/vm/prims/whitebox.cpp
! src/share/vm/runtime/arguments.cpp
! 
test/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestResolvedJavaType.java
! test/runtime/modules/ModuleHelper.java
! test/runtime/modules/java.base/java/lang/ModuleHelper.java

hg: jigsaw/jake/jdk: 20 new changesets

[alan . bateman]

Changeset: e8f3a872e69a
Author:psandoz
Date:  2017-06-12 14:30 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/e8f3a872e69a

8181442: Deprecate sun.misc.Unsafe.defineClass
Reviewed-by: shade, mchung

! src/jdk.unsupported/share/classes/sun/misc/Unsafe.java

Changeset: 573efb47b310
Author:vinnie
Date:  2017-06-13 13:31 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/573efb47b310

8181978: Keystore probing mechanism fails for large PKCS12 keystores
Reviewed-by: mullan

! src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java
+ test/sun/security/pkcs12/ProbeLargeKeystore.java

Changeset: 9b69584ea554
Author:dl
Date:  2017-06-13 09:13 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/9b69584ea554

8181104: Fix specs for updateAndGet and related methods
Reviewed-by: martin, psandoz, dholmes, chegar

! src/java.base/share/classes/java/lang/invoke/VarHandle.java
! src/java.base/share/classes/java/util/concurrent/atomic/AtomicInteger.java
! 
src/java.base/share/classes/java/util/concurrent/atomic/AtomicIntegerArray.java
! 
src/java.base/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java
! src/java.base/share/classes/java/util/concurrent/atomic/AtomicLong.java
! src/java.base/share/classes/java/util/concurrent/atomic/AtomicLongArray.java
! 
src/java.base/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java
! src/java.base/share/classes/java/util/concurrent/atomic/AtomicReference.java
! 
src/java.base/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java
! 
src/java.base/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java

Changeset: 0ffdaa7668ad
Author:mchung
Date:  2017-06-13 10:44 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/0ffdaa7668ad

8182029: Make the top-level docs index.html to a HTML-level redirect to the API 
overview page
Reviewed-by: alanb, erikj, ihse

! make/ModuleTools.gmk
- make/src/classes/build/tools/docs/GenDocsBundlePage.java
- make/src/classes/build/tools/docs/docs-bundle-page.html
- make/src/classes/build/tools/docs/docs-module-groups.properties

Changeset: 59902f12fb70
Author:bpb
Date:  2017-06-13 13:43 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/59902f12fb70

6791812: (file spec) Incompatible File.lastModified() and setLastModified() for 
negative time
Summary: Amend verbiage describing return value to explain negative values.
Reviewed-by: rriggs, smarks

! src/java.base/share/classes/java/io/File.java

Changeset: 6391a43c89ee
Author:mchung
Date:  2017-06-14 09:21 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/6391a43c89ee

8182137: Missing permissions in deprivileged java.xml.bind and java.xml.ws 
modules
Reviewed-by: alanb, mullan

! src/java.base/share/lib/security/default.policy

Changeset: e43d0498a4ac
Author:lancea
Date:  2017-06-14 12:46 -0400
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/e43d0498a4ac

8181832: Broken link in javax/sql/rowset/spi/package-summary.html
Reviewed-by: alanb, mchung

! src/java.sql.rowset/share/classes/javax/sql/rowset/spi/package.html

Changeset: 6b8f8ab175ff
Author:lana
Date:  2017-06-15 17:43 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/6b8f8ab175ff

Merge

- make/src/classes/build/tools/docs/GenDocsBundlePage.java
- make/src/classes/build/tools/docs/docs-bundle-page.html
- make/src/classes/build/tools/docs/docs-module-groups.properties

Changeset: 28d099962ee2
Author:mchung
Date:  2017-06-15 11:54 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/28d099962ee2

8182032: Make java.compiler upgradeable
Reviewed-by: alanb, erikj

+ test/jdk/modules/etc/UpgradeableModules.java
! test/jdk/modules/etc/VerifyModuleDelegation.java

Changeset: dfeb383db3bb
Author:herrick
Date:  2017-06-15 15:03 -0400
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/dfeb383db3bb

8181821: Broken link in javadoc for JSObject.getWindow
Reviewed-by: mchung

! src/jdk.jsobject/share/classes/netscape/javascript/JSObject.java

Changeset: 82ed25c3cea9
Author:ksrini
Date:  2017-06-15 14:27 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/82ed25c3cea9

8182185: Add Copyright notices to pack 200 spec
Reviewed-by: mchung

! src/java.base/share/classes/java/util/jar/Pack200.java

Changeset: e23c712e1d94
Author:poonam
Date:  2017-06-16 22:10 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/e23c712e1d94

8178536: OOM ERRORS + SERVICE-THREAD TAKES A PROCESSOR TO 100%
Summary: Clear the pending OOM exception in SensorInfo::trigger()
Reviewed-by: mchung, dcubed

! src/java.management/share/classes/sun/management/MemoryPoolImpl.java

Changeset: bec8ca52804c
Author:smarks
Date:  2017-05-19 14:46 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/bec8ca52804c

8177788: migrate collections technotes/guides into 

hg: jigsaw/jake/corba: 2 new changesets

[alan . bateman]

Changeset: e68b042f7130
Author:msheppar
Date:  2017-06-16 20:37 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/corba/rev/e68b042f7130

8181836: BadKindHelper.html and BoundsHelper.html contains broken link in the 
javadoc
Reviewed-by: chegar

! src/java.corba/share/classes/org/omg/CORBA/BoundsHelper.java
! src/java.corba/share/classes/org/omg/CORBA/ORBPackage/InvalidNameHelper.java
! src/java.corba/share/classes/org/omg/CORBA/TypeCodePackage/BadKindHelper.java
! src/java.corba/share/classes/org/omg/CORBA/TypeCodePackage/BoundsHelper.java

Changeset: 285a1a834027
Author:alanb
Date:  2017-06-17 15:37 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/corba/rev/285a1a834027

Merge

hg: jigsaw/jake: 7 new changesets

[alan . bateman]

Changeset: 35f50e9952e4
Author:mchung
Date:  2017-06-13 10:44 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/35f50e9952e4

8182029: Make the top-level docs index.html to a HTML-level redirect to the API 
overview page
Reviewed-by: alanb, erikj, ihse

! make/Docs.gmk

Changeset: e73b6959f72d
Author:lana
Date:  2017-06-15 17:43 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/e73b6959f72d

Merge


Changeset: e5c8a9c39558
Author:mchung
Date:  2017-06-15 11:54 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/e5c8a9c39558

8182032: Make java.compiler upgradeable
Reviewed-by: alanb, erikj

! make/CreateJmods.gmk
! make/common/Modules.gmk

Changeset: ce42e2c57dc7
Author:ihse
Date:  2017-06-16 11:41 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/ce42e2c57dc7

8179556: Add specs copyright file
Reviewed-by: erikj

! make/Docs.gmk

Changeset: 3474cd74
Author:alanb
Date:  2017-06-16 09:20 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/3474cd74

8181087: Module system implementation refresh (6/2017)
Reviewed-by: sspitsyn, hseigel

! test/lib/sun/hotspot/WhiteBox.java

Changeset: 83d12a7fae3d
Author:alanb
Date:  2017-06-17 08:02 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/83d12a7fae3d

Merge


Changeset: 30106266e9e8
Author:alanb
Date:  2017-06-17 15:32 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/30106266e9e8

Merge

! make/CreateJmods.gmk
! make/Docs.gmk
! make/common/Modules.gmk
! test/lib/sun/hotspot/WhiteBox.java

hg: jigsaw/jake/jaxws: 2 new changesets

[alan . bateman]

Changeset: c9b85ef1567e
Author:lancea
Date:  2017-06-16 19:12 -0400
URL:   http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/c9b85ef1567e

8182405: add legal file for freebxml
Reviewed-by: mchung

+ src/jdk.xml.bind/share/legal/freebxml.md

Changeset: e8582f469c79
Author:alanb
Date:  2017-06-17 15:38 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/e8582f469c79

Merge

Re: Review Request JDK-8182416: Clean up module-info.java like move requires transitive adjacent to exports

[Alan Bateman]

On 17/06/2017 07:27, Mandy Chung wrote:

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182416/webrev.00/

This patch cleans up module-info.java mainly moving requires transitive
before exports, group exports/opens (packages) together and uses/provides
(services) next.

Document if a module is upgradeable.

jdeps —-generate-module-info is also updated to list requires transitive
before exports.

This looks okay to me, I just wonder if jdk.xml.ws and jdk.xml.bind 
modules need the upgradeable note given that they aren't standard modules.


A minor nit in java.corba where it has "This ...". All the others 
have a space.


For jdeps then should it emit a blank line between the groupings to be 
consistent with the proposed layout?


-Alan

Re: Review Request JDK-8182416: Clean up module-info.java like move requires transitive adjacent to exports

[Lance Andersen]

The changes looked fine Mandy.  Nice that everything is consistent 

best
lance
> On Jun 17, 2017, at 2:27 AM, Mandy Chung  wrote:
> 
> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182416/webrev.00/
> 
> This patch cleans up module-info.java mainly moving requires transitive
> before exports, group exports/opens (packages) together and uses/provides
> (services) next.
> 
> Document if a module is upgradeable.
> 
> jdeps —-generate-module-info is also updated to list requires transitive
> before exports.
> 
> Mandy

 
  

 Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com 

Review Request JDK-8182416: Clean up module-info.java like move requires transitive adjacent to exports

[Mandy Chung]

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182416/webrev.00/

This patch cleans up module-info.java mainly moving requires transitive
before exports, group exports/opens (packages) together and uses/provides
(services) next.

Document if a module is upgradeable.

jdeps —-generate-module-info is also updated to list requires transitive
before exports.

Mandy