Re: [Jmol-developers] Call to jmolApplet with AppletID = 0 does not generate jmolApplet0, but some other jmolAppletXX...
Yes, that would work, but I'm trying to avoid using any of the internals of Jmol.js in the code for Sage, in case we decide to change the internals. I think the culprit is the test in _jmolApplet to see whether a value was passed in the appletID. I believe a value of zero in appletID returns a false in the if statement, while non-zero #s and strings work fine. I don't think that behavior matches the documented behavior of the call. However, I didn't want to check in a fix without making sure what the behavior is supposed to be and that it won't mess up some other expected behavior. Jonathan On Oct 11, 2010, at 10:55 PM, Robert Hanson wrote: Jonathan, if it's important to you to have the applets come in as applet 0, then what you should do is use _jmol.appletCount = 0 and then go from there. On Mon, Oct 11, 2010 at 8:39 PM, Jonathan Gutow gu...@uwosh.edu wrote: I think this is an issue for Angel. When I make the following call on a page that has other applets on it after having destroyed jmolApplet0 to save memory. It creates an applet that is not given the name jmolApplet0. I think we are running up against a misinterpretation of 0 in the tests near the beginning of _jmolApplet. The call is jmolApplet([width,height], scriptStr,n); //where n = 0, verified by properly setting some other variables. This is the last of the fixes for the Jmol in Sage interface update. A workaround I would like to avoid is to send the zero in quotes (ie. 0). Things work as expected for n =1 or greater. Jonathan Dr. Jonathan H. Gutow Chemistry Departmentgu...@uwosh.edu UW-Oshkosh Office: 920-424-1326 800 Algoma BoulevardFAX:920-424-2042 Oshkosh, WI 54901 http://www.uwosh.edu/facstaff/gutow -- Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb ___ Jmol-developers mailing list Jmol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jmol-developers -- Robert M. Hanson Professor of Chemistry St. Olaf College 1520 St. Olaf Ave. Northfield, MN 55057 http://www.stolaf.edu/people/hansonr phone: 507-786-3107 If nature does not answer first what we want, it is better to take what answer we get. -- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900 -- Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb ___ Jmol-developers mailing list Jmol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jmol-developers Dr. Jonathan H. Gutow Chemistry Department gu...@uwosh.edu UW-Oshkosh Office:920-424-1326 800 Algoma Boulevard FAX:920-424-2042 Oshkosh, WI 54901 http://www.uwosh.edu/facstaff/gutow -- Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb ___ Jmol-developers mailing list Jmol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jmol-developers
Re: [Jmol-developers] Call to jmolApplet with AppletID = 0 does not generate jmolApplet0, but some other jmolAppletXX...
Jonathan, That was fixed long ago. Are you using http://jmol.svn.sourceforge.net/viewvc/jmol/trunk/Jmol/appletweb/Jmol.js ? * *Bob On Tue, Oct 12, 2010 at 7:53 AM, Jonathan Gutow gu...@uwosh.edu wrote: Yes, that would work, but I'm trying to avoid using any of the internals of Jmol.js in the code for Sage, in case we decide to change the internals. I think the culprit is the test in _jmolApplet to see whether a value was passed in the appletID. I believe a value of zero in appletID returns a false in the if statement, while non-zero #s and strings work fine. I don't think that behavior matches the documented behavior of the call. However, I didn't want to check in a fix without making sure what the behavior is supposed to be and that it won't mess up some other expected behavior. Jonathan On Oct 11, 2010, at 10:55 PM, Robert Hanson wrote: Jonathan, if it's important to you to have the applets come in as applet 0, then what you should do is use _jmol.appletCount = 0 and then go from there. On Mon, Oct 11, 2010 at 8:39 PM, Jonathan Gutow gu...@uwosh.edu wrote: I think this is an issue for Angel. When I make the following call on a page that has other applets on it after having destroyed jmolApplet0 to save memory. It creates an applet that is not given the name jmolApplet0. I think we are running up against a misinterpretation of 0 in the tests near the beginning of _jmolApplet. The call is jmolApplet([width,height], scriptStr,n); //where n = 0, verified by properly setting some other variables. This is the last of the fixes for the Jmol in Sage interface update. A workaround I would like to avoid is to send the zero in quotes (ie. 0). Things work as expected for n =1 or greater. Jonathan Dr. Jonathan H. Gutow Chemistry Departmentgu...@uwosh.edu UW-Oshkosh Office: 920-424-1326 800 Algoma BoulevardFAX:920-424-2042 Oshkosh, WI 54901 http://www.uwosh.edu/facstaff/gutow -- Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb ___ Jmol-developers mailing list Jmol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jmol-developers -- Robert M. Hanson Professor of Chemistry St. Olaf College 1520 St. Olaf Ave. Northfield, MN 55057 http://www.stolaf.edu/people/hansonr phone: 507-786-3107 If nature does not answer first what we want, it is better to take what answer we get. -- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900 -- Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb ___ Jmol-developers mailing list Jmol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jmol-developers Dr. Jonathan H. Gutow Chemistry Department gu...@uwosh.edu UW-Oshkosh Office:920-424-1326 800 Algoma Boulevard FAX:920-424-2042 Oshkosh, WI 54901 http://www.uwosh.edu/facstaff/gutow -- Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb ___ Jmol-developers mailing list Jmol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jmol-developers -- Robert M. Hanson Professor of Chemistry St. Olaf College 1520 St. Olaf Ave. Northfield, MN 55057 http://www.stolaf.edu/people/hansonr phone: 507-786-3107 If nature does not answer first what we want, it is better to take what answer we get. -- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900 -- Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5,
Re: [Jmol-developers] Call to jmolApplet with AppletID = 0 does not generate jmolApplet0, but some other jmolAppletXX...
I'll double check. I thought so. I'll probably get back to it this evening. Jonathan On Oct 12, 2010, at 8:00 AM, Robert Hanson wrote: Jonathan, That was fixed long ago. Are you using http://jmol.svn.sourceforge.net/viewvc/jmol/trunk/Jmol/appletweb/Jmol.js ? Bob On Tue, Oct 12, 2010 at 7:53 AM, Jonathan Gutow gu...@uwosh.edu wrote: Yes, that would work, but I'm trying to avoid using any of the internals of Jmol.js in the code for Sage, in case we decide to change the internals. I think the culprit is the test in _jmolApplet to see whether a value was passed in the appletID. I believe a value of zero in appletID returns a false in the if statement, while non-zero #s and strings work fine. I don't think that behavior matches the documented behavior of the call. However, I didn't want to check in a fix without making sure what the behavior is supposed to be and that it won't mess up some other expected behavior. Jonathan On Oct 11, 2010, at 10:55 PM, Robert Hanson wrote: Jonathan, if it's important to you to have the applets come in as applet 0, then what you should do is use _jmol.appletCount = 0 and then go from there. On Mon, Oct 11, 2010 at 8:39 PM, Jonathan Gutow gu...@uwosh.edu wrote: I think this is an issue for Angel. When I make the following call on a page that has other applets on it after having destroyed jmolApplet0 to save memory. It creates an applet that is not given the name jmolApplet0. I think we are running up against a misinterpretation of 0 in the tests near the beginning of _jmolApplet. The call is jmolApplet([width,height], scriptStr,n); //where n = 0, verified by properly setting some other variables. This is the last of the fixes for the Jmol in Sage interface update. A workaround I would like to avoid is to send the zero in quotes (ie. 0). Things work as expected for n =1 or greater. Jonathan Dr. Jonathan H. Gutow Chemistry Departmentgu...@uwosh.edu UW-Oshkosh Office: 920-424-1326 800 Algoma BoulevardFAX:920-424-2042 Oshkosh, WI 54901 http://www.uwosh.edu/facstaff/gutow -- Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb ___ Jmol-developers mailing list Jmol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jmol-developers -- Robert M. Hanson Professor of Chemistry St. Olaf College 1520 St. Olaf Ave. Northfield, MN 55057 http://www.stolaf.edu/people/hansonr phone: 507-786-3107 If nature does not answer first what we want, it is better to take what answer we get. -- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900 -- Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb ___ Jmol-developers mailing list Jmol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jmol-developers Dr. Jonathan H. Gutow Chemistry Department gu...@uwosh.edu UW-Oshkosh Office: 920-424-1326 800 Algoma Boulevard FAX:920-424-2042 Oshkosh, WI 54901 http://www.uwosh.edu/facstaff/gutow -- Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb ___ Jmol-developers mailing list Jmol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jmol-developers -- Robert M. Hanson Professor of Chemistry St. Olaf College 1520 St. Olaf Ave. Northfield, MN 55057 http://www.stolaf.edu/people/hansonr phone: 507-786-3107 If nature does not answer first what we want, it is better to take what answer we get. -- Josiah Willard Gibbs, Lecture XXX, Monday, February 5,
Re: [Jmol-developers] Call to jmolApplet with AppletID = 0 does not generate jmolApplet0, but some other jmolAppletXX...
Jonathan, I know what you mean. The idea is that zero may be taken as false (no id provided). However, my test now seems to behave (12.1.14) The line in Jmol.js that does the trick says nameSuffix == undefined (nameSuffix = appletCount); but I really don't understand how this code works. What exact code are you using to destroy and recreate the applet? I have tried function destroy() { document.getElementById(cont).innerHTML=; } function create() { jmolSetDocument(0) document.getElementById(cont).innerHTML = jmolApplet([width,height], scriptStr, n) } where cont is a div containing the applet -- Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb ___ Jmol-developers mailing list Jmol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jmol-developers
Re: [Jmol-developers] Call to jmolApplet with AppletID = 0 does not generate jmolApplet0, but some other jmolAppletXX...
Let me check that I didn't accidentally pick up an outdated Jmol.js, I should get a chance this evening (its on my home computer). That line doesn't look like what I remember. Thanks for looking into it. If we've got a fixed version already, then I'm in good shape. Jonathan On Oct 12, 2010, at 1:41 PM, Angel Herráez wrote: Jonathan, I know what you mean. The idea is that zero may be taken as false (no id provided). However, my test now seems to behave (12.1.14) The line in Jmol.js that does the trick says nameSuffix == undefined (nameSuffix = appletCount); but I really don't understand how this code works. What exact code are you using to destroy and recreate the applet? I have tried function destroy() { document.getElementById(cont).innerHTML=; } function create() { jmolSetDocument(0) document.getElementById(cont).innerHTML = jmolApplet([width,height], scriptStr, n) } where cont is a div containing the applet -- Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb ___ Jmol-developers mailing list Jmol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jmol-developers Dr. Jonathan H. Gutow Chemistry Department gu...@uwosh.edu UW-Oshkosh Office:920-424-1326 800 Algoma Boulevard FAX:920-424-2042 Oshkosh, WI 54901 http://www.uwosh.edu/facstaff/gutow -- Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb ___ Jmol-developers mailing list Jmol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jmol-developers
Re: [Jmol-developers] Call to jmolApplet with AppletID = 0 does not generate jmolApplet0, but some other jmolAppletXX...
2010/10/12 Angel Herráez angel.herr...@uah.es Jonathan, I know what you mean. The idea is that zero may be taken as false (no id provided). However, my test now seems to behave (12.1.14) The line in Jmol.js that does the trick says nameSuffix == undefined (nameSuffix = appletCount); but I really don't understand how this code works. It says: If nameSuffix is undefined, then assign the value of appletCount to nameSuffix. What exact code are you using to destroy and recreate the applet? I have tried function destroy() { document.getElementById(cont).innerHTML=; } function create() { jmolSetDocument(0) document.getElementById(cont).innerHTML = jmolApplet([width,height], scriptStr, n) } where cont is a div containing the applet -- Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb ___ Jmol-developers mailing list Jmol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jmol-developers -- Robert M. Hanson Professor of Chemistry St. Olaf College 1520 St. Olaf Ave. Northfield, MN 55057 http://www.stolaf.edu/people/hansonr phone: 507-786-3107 If nature does not answer first what we want, it is better to take what answer we get. -- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900 -- Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb___ Jmol-developers mailing list Jmol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jmol-developers
Re: [Jmol-developers] Call to jmolApplet with AppletID = 0 does not generate jmolApplet0, but some other jmolAppletXX...
Bob, This still doesn't work as it interprets a numeric zero as undefined. Turning the zero into a string representation of zero causes the proper naming to be used. You may be running up against the fact that different browsers return different things. I've found I have to check for undefined, 'undefined', null and 'null' to cover all the browser variants. How about: if (!nameSuffix nameSuffix!=0) nameSuffix = appletCount; Jonathan On Oct 12, 2010, at 5:19 PM, Robert Hanson wrote: 2010/10/12 Angel Herráez angel.herr...@uah.es Jonathan, I know what you mean. The idea is that zero may be taken as false (no id provided). However, my test now seems to behave (12.1.14) The line in Jmol.js that does the trick says nameSuffix == undefined (nameSuffix = appletCount); but I really don't understand how this code works. It says: If nameSuffix is undefined, then assign the value of appletCount to nameSuffix. What exact code are you using to destroy and recreate the applet? I have tried function destroy() { document.getElementById(cont).innerHTML=; } function create() { jmolSetDocument(0) document.getElementById(cont).innerHTML = jmolApplet([width,height], scriptStr, n) } where cont is a div containing the applet -- Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb ___ Jmol-developers mailing list Jmol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jmol-developers -- Robert M. Hanson Professor of Chemistry St. Olaf College 1520 St. Olaf Ave. Northfield, MN 55057 http://www.stolaf.edu/people/hansonr phone: 507-786-3107 If nature does not answer first what we want, it is better to take what answer we get. -- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900 -- Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb ___ Jmol-developers mailing list Jmol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jmol-developers Dr. Jonathan H. Gutow Chemistry Departmentgu...@uwosh.edu UW-Oshkosh Office: 920-424-1326 800 Algoma BoulevardFAX:920-424-2042 Oshkosh, WI 54901 http://www.uwosh.edu/facstaff/gutow -- Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb___ Jmol-developers mailing list Jmol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jmol-developers
Re: [Jmol-developers] Call to jmolApplet with AppletID = 0 does not generate jmolApplet0, but some other jmolAppletXX...
impossible. zero is zero, not undefined. On Tue, Oct 12, 2010 at 6:54 PM, Jonathan Gutow gu...@uwosh.edu wrote: Bob, This still doesn't work as it interprets a numeric zero as undefined. Turning the zero into a string representation of zero causes the proper naming to be used. You may be running up against the fact that different browsers return different things. I've found I have to check for undefined, 'undefined', null and 'null' to cover all the browser variants. How about: if (!nameSuffix nameSuffix!=0) nameSuffix = appletCount; Jonathan On Oct 12, 2010, at 5:19 PM, Robert Hanson wrote: 2010/10/12 Angel Herráez angel.herr...@uah.es Jonathan, I know what you mean. The idea is that zero may be taken as false (no id provided). However, my test now seems to behave (12.1.14) The line in Jmol.js that does the trick says nameSuffix == undefined (nameSuffix = appletCount); but I really don't understand how this code works. It says: If nameSuffix is undefined, then assign the value of appletCount to nameSuffix. What exact code are you using to destroy and recreate the applet? I have tried function destroy() { document.getElementById(cont).innerHTML=; } function create() { jmolSetDocument(0) document.getElementById(cont).innerHTML = jmolApplet([width,height], scriptStr, n) } where cont is a div containing the applet -- Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb ___ Jmol-developers mailing list Jmol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jmol-developers -- Robert M. Hanson Professor of Chemistry St. Olaf College 1520 St. Olaf Ave. Northfield, MN 55057 http://www.stolaf.edu/people/hansonr phone: 507-786-3107 If nature does not answer first what we want, it is better to take what answer we get. -- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900 -- Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb ___ Jmol-developers mailing list Jmol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jmol-developers Dr. Jonathan H. Gutow Chemistry Departmentgu...@uwosh.edu UW-Oshkosh Office: 920-424-1326 800 Algoma BoulevardFAX:920-424-2042 Oshkosh, WI 54901 http://www.uwosh.edu/facstaff/gutow -- Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb ___ Jmol-developers mailing list Jmol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jmol-developers -- Robert M. Hanson Professor of Chemistry St. Olaf College 1520 St. Olaf Ave. Northfield, MN 55057 http://www.stolaf.edu/people/hansonr phone: 507-786-3107 If nature does not answer first what we want, it is better to take what answer we get. -- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900 -- Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb___ Jmol-developers mailing list Jmol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jmol-developers