Re: PROPOSAL: stop recording 'executing update-status hook'
What would happen if the update-status hook hangs here? I know it only is supposed to be for short-duration status messages (but charm bugs are known to happen). In addition, it will also block other hooks/actions from happening until completed and it will remain in a stuck state with the status reporting as "all good". Is there some middle ground rather than not exposing that the unit is working in this situation? Not to be a nay-sayer just want it more thoroughly looked at from a user's least surprise in not-great situations where the deployment is wedged. We would not know that from the status right? Only from the debug-log. On May 19, 2017 3:46 AM, "John Meinel"wrote: > All agents start up in DEBUG until they can talk to the controller and > read what the current logging config is set to. Otherwise you wouldn't be > able to debug startup issues. > That said, I think there was a request to cache the last-known value in > agent.conf which would let restarts be less noisy. > > John > =:-> > > > On Fri, May 19, 2017 at 12:23 PM, Samuel Cozannet < > samuel.cozan...@canonical.com> wrote: > >> +1 >> >> Maybe one good thing would also be removing the default --debug flag from >> all juju machine startup scripts. >> It seems hard coded, and requires edition on most deployment. >> >> ++ >> Sam >> >> >> On May 19, 2017 10:12, "Adam Collard" wrote: >> >> On Fri, 19 May 2017 at 03:14 Tim Penhey wrote: >> >>> Hi folks, >>> >>> Currently juju will update the status of any hook execution for any unit >>> to show that it is busy doing things. This was all well and good until >>> we do things based on time. >>> >>> Every five minutes (or so) each unit will have the update-status hook >>> executed to allow the unit to set or update the workload status based on >>> what is currently going on with that unit. >>> >>> Since all hook executions are stored, this means that the >>> show-status-log will show the unit jumping from executing update-status >>> to ready and back every five minutes. >>> >>> The proposal is to special case the update-status hook and show in >>> status (or the status-log) that the hook is being executed. debug-log >>> will continue to show the hook executing if you are looking. >>> >>> This will reduce noise in the status-log, simplify some of our code >>> around dealing with status-log, and reduce load on controllers looking >>> after hundreds or thousands of units. >>> >> >> +1 >> >> >> -- >> Juju mailing list >> j...@lists.ubuntu.com >> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailm >> an/listinfo/juju >> >> >> >> -- >> Juju mailing list >> j...@lists.ubuntu.com >> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailm >> an/listinfo/juju >> >> > > -- > Juju-dev mailing list > Juju-dev@lists.ubuntu.com > Modify settings or unsubscribe at: https://lists.ubuntu.com/ > mailman/listinfo/juju-dev > > -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: PROPOSAL: stop recording 'executing update-status hook'
All agents start up in DEBUG until they can talk to the controller and read what the current logging config is set to. Otherwise you wouldn't be able to debug startup issues. That said, I think there was a request to cache the last-known value in agent.conf which would let restarts be less noisy. John =:-> On Fri, May 19, 2017 at 12:23 PM, Samuel Cozannet < samuel.cozan...@canonical.com> wrote: > +1 > > Maybe one good thing would also be removing the default --debug flag from > all juju machine startup scripts. > It seems hard coded, and requires edition on most deployment. > > ++ > Sam > > > On May 19, 2017 10:12, "Adam Collard"wrote: > > On Fri, 19 May 2017 at 03:14 Tim Penhey wrote: > >> Hi folks, >> >> Currently juju will update the status of any hook execution for any unit >> to show that it is busy doing things. This was all well and good until >> we do things based on time. >> >> Every five minutes (or so) each unit will have the update-status hook >> executed to allow the unit to set or update the workload status based on >> what is currently going on with that unit. >> >> Since all hook executions are stored, this means that the >> show-status-log will show the unit jumping from executing update-status >> to ready and back every five minutes. >> >> The proposal is to special case the update-status hook and show in >> status (or the status-log) that the hook is being executed. debug-log >> will continue to show the hook executing if you are looking. >> >> This will reduce noise in the status-log, simplify some of our code >> around dealing with status-log, and reduce load on controllers looking >> after hundreds or thousands of units. >> > > +1 > > > -- > Juju mailing list > j...@lists.ubuntu.com > Modify settings or unsubscribe at: https://lists.ubuntu.com/mailm > an/listinfo/juju > > > > -- > Juju mailing list > j...@lists.ubuntu.com > Modify settings or unsubscribe at: https://lists.ubuntu.com/ > mailman/listinfo/juju > > -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: PROPOSAL: stop recording 'executing update-status hook'
+1 On Fri, May 19, 2017 at 4:13 AM, Tim Penheywrote: > Hi folks, > > Currently juju will update the status of any hook execution for any unit > to show that it is busy doing things. This was all well and good until we > do things based on time. > > Every five minutes (or so) each unit will have the update-status hook > executed to allow the unit to set or update the workload status based on > what is currently going on with that unit. > > Since all hook executions are stored, this means that the show-status-log > will show the unit jumping from executing update-status to ready and back > every five minutes. > > The proposal is to special case the update-status hook and show in status > (or the status-log) that the hook is being executed. debug-log will > continue to show the hook executing if you are looking. > > This will reduce noise in the status-log, simplify some of our code around > dealing with status-log, and reduce load on controllers looking after > hundreds or thousands of units. > > Is anyone opposed to this change? > > Tim > > -- > Juju-dev mailing list > Juju-dev@lists.ubuntu.com > Modify settings or unsubscribe at: https://lists.ubuntu.com/mailm > an/listinfo/juju-dev > -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: PROPOSAL: stop recording 'executing update-status hook'
On Fri, 19 May 2017 at 03:14 Tim Penheywrote: > Hi folks, > > Currently juju will update the status of any hook execution for any unit > to show that it is busy doing things. This was all well and good until > we do things based on time. > > Every five minutes (or so) each unit will have the update-status hook > executed to allow the unit to set or update the workload status based on > what is currently going on with that unit. > > Since all hook executions are stored, this means that the > show-status-log will show the unit jumping from executing update-status > to ready and back every five minutes. > > The proposal is to special case the update-status hook and show in > status (or the status-log) that the hook is being executed. debug-log > will continue to show the hook executing if you are looking. > > This will reduce noise in the status-log, simplify some of our code > around dealing with status-log, and reduce load on controllers looking > after hundreds or thousands of units. > +1 -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Weekly Development Summary
Hi folks That time of the week again - almost beer o'clock for those of us in Aus/NZ timezones - and also time to recap on the happenings in the land of Juju development over the past 7 days. We're working hard to get a Juju 2.2 out the door. The week saw a release of 2.2 beta4 which included usability improvements to actions, openstack and oracle providers. Focus this week has been on squashing a number of stakeholder bugs and CI test failures. We aim to release an RC in a week or so all going well. A couple of key development highlights apart from the usual fare of bug fixes include: - close to finishing improvements to how Juju storage operates - expect a snap early next week to try out the feature which is targetted for Juju 2.3. You will gain the ability to destroy a unit but leave its storage behind; this storage can then be attached to a different unit or re-used when deploying a new application instance. - all of the CI and QA tools and scripts and test frameworks have been moved across from Launchpad to live under the Juju repo on github. This is part of the ongoing process to revamp and improve our test infrastructure to make everything more robust and maintainable, and make writing CI tests as easy as possible. - model migration improvements so that things play nicely together in a JAAS world in addition to individual controllers Quick links: Work Pending: https://github.com/juju/juju/pulls Recent commits: https://github.com/juju/juju/commits/develop -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: PROPOSAL: stop recording 'executing update-status hook'
On 19 May 2017 at 03:13, Tim Penheywrote: > Hi folks, > > Currently juju will update the status of any hook execution for any unit to > show that it is busy doing things. This was all well and good until we do > things based on time. > > Every five minutes (or so) each unit will have the update-status hook > executed to allow the unit to set or update the workload status based on > what is currently going on with that unit. > > Since all hook executions are stored, this means that the show-status-log > will show the unit jumping from executing update-status to ready and back > every five minutes. > > The proposal is to special case the update-status hook and show in status > (or the status-log) that the hook is being executed. debug-log will continue > to show the hook executing if you are looking. Presumably you mean *not* show in status here? -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev