Re: [JPP-Devel] SVN: [6134] core/trunk/src

2019-02-23 Thread Michaël Michaud 

Hi,

Stefan, I don't know how the server ensure backward compatibility, but I 
think that in OpenJUMP, the version always represent the version given 
in the request through the version parameter


url?SERVICE=WMS&*VERSION*=1.3.0

This version is chosen by the user in URLWizardPanel and is used by 
WMService to build the getCapability request, then to  build a 
MapRequest. But the MapRequest is built with the same version as the 
WMService and I'm not sure that it makes sense to build the MapRequest 
with another version. So I'm not sure that MapRequest needs a "version" 
attribute at all. This is probably the same for WMSLegend and WMSLayer.


@Jukka : as it concerns WMS usage, maybe you can tell us if WMS_1_1_1 is 
still a good default option. When I connect to our service in France, I 
know I must use the WMS_1_3_0 protocol, but if I let the WMS_1_1_1 the 
getCapability will return more layers, including layers I'm not allowed 
to read (may also be a server side problem)


Michaël


Le 22/02/2019 à 14:51, Stefan Steiniger a écrit :
Uhm... a service may be backward compatible and can therefore support 
different request versions? - just guessing ;)


On Fri, Feb 22, 2019, 10:42 Michaël Michaud, 
mailto:m.michael.mich...@orange.fr>> wrote:


Ede,

This value is not used. WMSRequest version is initialized from
WMService
version. Not sure why version is an attribute of both WMService and
WMSRequest.

I just was adviced from my IDE. Let me have a deeper look. I subclass
could use the previous default value if it does not use super() in
constructor, but I can't see any reason to encourage it...

Michaël

Le 22/02/2019 à 11:08, edgar.sol...@web.de
 a écrit :
> hey Mike,
>
> can you tell me why you removed the default value for 'version'
below? ..ede
>
> On 22.02.2019 08:35, jump-pilot-svn--- via Jump-pilot-devel wrote:
>> Modified:
core/trunk/src/com/vividsolutions/wms/AbstractWMSRequest.java
>> ===
>> ---
core/trunk/src/com/vividsolutions/wms/AbstractWMSRequest.java  
2019-02-21 07:21:47 UTC (rev 6133)
>> +++
core/trunk/src/com/vividsolutions/wms/AbstractWMSRequest.java  
2019-02-22 07:35:16 UTC (rev 6134)
> SNIP
>> @@ -25,12 +21,11 @@
>>   import com.vividsolutions.jump.util.FileUtil;
>>   import com.vividsolutions.jump.workbench.Logger;
>>   import
com.vividsolutions.jump.workbench.ui.network.ProxySettingsOptionsPanel;
>> -import
com.vividsolutions.jump.workbench.ui.plugin.PersistentBlackboardPlugIn;
>>
>>   abstract public class AbstractWMSRequest implements WMSRequest {
>>
>>     protected WMService service;
>> -  protected String version = WMService.WMS_1_1_1;
>> +  protected String version;
>>     protected HttpURLConnection con = null;
>
>
> ___
> Jump-pilot-devel mailing list
> Jump-pilot-devel@lists.sourceforge.net

> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>


___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net

https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel



___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Re: [JPP-Devel] SVN: [6134] core/trunk/src

2019-02-22 Thread Stefan Steiniger 
Uhm... a service may be backward compatible and can therefore support
different request versions? - just guessing ;)

On Fri, Feb 22, 2019, 10:42 Michaël Michaud, 
wrote:

> Ede,
>
> This value is not used. WMSRequest version is initialized from WMService
> version. Not sure why version is an attribute of both WMService and
> WMSRequest.
>
> I just was adviced from my IDE. Let me have a deeper look. I subclass
> could use the previous default value if it does not use super() in
> constructor, but I can't see any reason to encourage it...
>
> Michaël
>
> Le 22/02/2019 à 11:08, edgar.sol...@web.de a écrit :
> > hey Mike,
> >
> > can you tell me why you removed the default value for 'version' below?
> ..ede
> >
> > On 22.02.2019 08:35, jump-pilot-svn--- via Jump-pilot-devel wrote:
> >> Modified: core/trunk/src/com/vividsolutions/wms/AbstractWMSRequest.java
> >> ===
> >> --- core/trunk/src/com/vividsolutions/wms/AbstractWMSRequest.java
> 2019-02-21 07:21:47 UTC (rev 6133)
> >> +++ core/trunk/src/com/vividsolutions/wms/AbstractWMSRequest.java
> 2019-02-22 07:35:16 UTC (rev 6134)
> > SNIP
> >> @@ -25,12 +21,11 @@
> >>   import com.vividsolutions.jump.util.FileUtil;
> >>   import com.vividsolutions.jump.workbench.Logger;
> >>   import
> com.vividsolutions.jump.workbench.ui.network.ProxySettingsOptionsPanel;
> >> -import
> com.vividsolutions.jump.workbench.ui.plugin.PersistentBlackboardPlugIn;
> >>
> >>   abstract public class AbstractWMSRequest implements WMSRequest {
> >>
> >> protected WMService service;
> >> -  protected String version = WMService.WMS_1_1_1;
> >> +  protected String version;
> >> protected HttpURLConnection con = null;
> >
> >
> > ___
> > Jump-pilot-devel mailing list
> > Jump-pilot-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
> >
>
>
> ___
> Jump-pilot-devel mailing list
> Jump-pilot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>
___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Re: [JPP-Devel] SVN: [6134] core/trunk/src

2019-02-22 Thread Michaël Michaud 

Ede,

This value is not used. WMSRequest version is initialized from WMService 
version. Not sure why version is an attribute of both WMService and 
WMSRequest.


I just was adviced from my IDE. Let me have a deeper look. I subclass 
could use the previous default value if it does not use super() in 
constructor, but I can't see any reason to encourage it...


Michaël

Le 22/02/2019 à 11:08, edgar.sol...@web.de a écrit :

hey Mike,

can you tell me why you removed the default value for 'version' below? ..ede

On 22.02.2019 08:35, jump-pilot-svn--- via Jump-pilot-devel wrote:

Modified: core/trunk/src/com/vividsolutions/wms/AbstractWMSRequest.java
===
--- core/trunk/src/com/vividsolutions/wms/AbstractWMSRequest.java   
2019-02-21 07:21:47 UTC (rev 6133)
+++ core/trunk/src/com/vividsolutions/wms/AbstractWMSRequest.java   
2019-02-22 07:35:16 UTC (rev 6134)

SNIP

@@ -25,12 +21,11 @@
  import com.vividsolutions.jump.util.FileUtil;
  import com.vividsolutions.jump.workbench.Logger;
  import com.vividsolutions.jump.workbench.ui.network.ProxySettingsOptionsPanel;
-import com.vividsolutions.jump.workbench.ui.plugin.PersistentBlackboardPlugIn;

  abstract public class AbstractWMSRequest implements WMSRequest {

protected WMService service;
-  protected String version = WMService.WMS_1_1_1;
+  protected String version;
protected HttpURLConnection con = null;



___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel




___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Re: [JPP-Devel] SVN: [6134] core/trunk/src

2019-02-22 Thread edgar . soldin 
hey Mike,

can you tell me why you removed the default value for 'version' below? ..ede

On 22.02.2019 08:35, jump-pilot-svn--- via Jump-pilot-devel wrote:
> Modified: core/trunk/src/com/vividsolutions/wms/AbstractWMSRequest.java
> ===
> --- core/trunk/src/com/vividsolutions/wms/AbstractWMSRequest.java 
> 2019-02-21 07:21:47 UTC (rev 6133)
> +++ core/trunk/src/com/vividsolutions/wms/AbstractWMSRequest.java 
> 2019-02-22 07:35:16 UTC (rev 6134)
SNIP
>
> @@ -25,12 +21,11 @@
>  import com.vividsolutions.jump.util.FileUtil;
>  import com.vividsolutions.jump.workbench.Logger;
>  import 
> com.vividsolutions.jump.workbench.ui.network.ProxySettingsOptionsPanel;
> -import 
> com.vividsolutions.jump.workbench.ui.plugin.PersistentBlackboardPlugIn;
>
>  abstract public class AbstractWMSRequest implements WMSRequest {
>
>protected WMService service;
> -  protected String version = WMService.WMS_1_1_1;
> +  protected String version;
>protected HttpURLConnection con = null;



___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

[JPP-Devel] SVN: [6134] core/trunk/src

2019-02-21 Thread jump-pilot-svn--- via Jump-pilot-devel 
Revision: 6134
  http://sourceforge.net/p/jump-pilot/code/6134
Author:   michaudm
Date: 2019-02-22 07:35:16 + (Fri, 22 Feb 2019)
Log Message:
---
Fix bad error management introduced in last commit

Modified Paths:
--
core/trunk/src/com/vividsolutions/jump/workbench/model/WMSLayer.java

core/trunk/src/com/vividsolutions/jump/workbench/ui/plugin/wms/URLWizardPanel.java
core/trunk/src/com/vividsolutions/wms/AbstractWMSRequest.java
core/trunk/src/com/vividsolutions/wms/FeatureInfoRequest.java
core/trunk/src/com/vividsolutions/wms/WMSRequest.java
core/trunk/src/com/vividsolutions/wms/WMService.java
core/trunk/src/com/vividsolutions/wms/ui/WMSViewer.java
core/trunk/src/org/openjump/core/ui/plugin/wms/WMSLegendPlugIn.java

Modified: core/trunk/src/com/vividsolutions/jump/workbench/model/WMSLayer.java
===
--- core/trunk/src/com/vividsolutions/jump/workbench/model/WMSLayer.java
2019-02-21 07:21:47 UTC (rev 6133)
+++ core/trunk/src/com/vividsolutions/jump/workbench/model/WMSLayer.java
2019-02-22 07:35:16 UTC (rev 6134)
@@ -38,8 +38,6 @@
 import java.lang.ref.Reference;
 import java.lang.ref.SoftReference;
 import java.net.URL;
-import java.security.KeyManagementException;
-import java.security.NoSuchAlgorithmException;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
@@ -86,13 +84,13 @@
   }
 
   public WMSLayer(LayerManager layerManager, String serverURL, String srs,
-  List layerNames, String format, String version) throws 
IOException, KeyManagementException, NoSuchAlgorithmException {
+  List layerNames, String format, String version) throws 
IOException {
 this(layerManager, initializedService(serverURL, version), srs, layerNames,
 format);
   }
 
   private static WMService initializedService(String serverURL, String version)
-  throws IOException, KeyManagementException, NoSuchAlgorithmException {
+  throws IOException {
 WMService initializedService = new WMService(serverURL, version);
 initializedService.initialize();
 return initializedService;
@@ -152,7 +150,7 @@
 this.alpha = alpha;
   }
 
-  public Image createImage(LayerViewPanel panel) throws IOException, 
KeyManagementException, NoSuchAlgorithmException {
+  public Image createImage(LayerViewPanel panel) throws IOException {
 
 MapRequest request = createRequest(panel);
 URL newURL = request.getURL();
@@ -183,7 +181,7 @@
 return new BoundingBox(srs, e);
   }
 
-  public MapRequest createRequest(LayerViewPanel panel) throws IOException, 
KeyManagementException, NoSuchAlgorithmException {
+  public MapRequest createRequest(LayerViewPanel panel) throws IOException {
 MapRequest request = getService().createMapRequest();
 request.setBoundingBox(toBoundingBox(srs, panel.getViewport()
 .getEnvelopeInModelCoordinates()));
@@ -243,7 +241,7 @@
 return blackboard;
   }
 
-  public WMService getService() throws IOException, KeyManagementException, 
NoSuchAlgorithmException {
+  public WMService getService() throws IOException {
 if (service == null) {
   Assert.isTrue(serverURL != null);
   setService(initializedService(serverURL, wmsVersion));
@@ -283,7 +281,7 @@
   envelope.expandToInclude(bb.getEnvelope());
 }
   }
-} catch (IOException|KeyManagementException|NoSuchAlgorithmException e) {
+} catch (IOException e) {
   Logger
   .error(
   "WMSLayer envelope calculation failed."

Modified: 
core/trunk/src/com/vividsolutions/jump/workbench/ui/plugin/wms/URLWizardPanel.java
===
--- 
core/trunk/src/com/vividsolutions/jump/workbench/ui/plugin/wms/URLWizardPanel.java
  2019-02-21 07:21:47 UTC (rev 6133)
+++ 
core/trunk/src/com/vividsolutions/jump/workbench/ui/plugin/wms/URLWizardPanel.java
  2019-02-22 07:35:16 UTC (rev 6134)
@@ -40,8 +40,6 @@
 import java.awt.event.ActionListener;
 import java.io.IOException;
 import java.net.URL;
-import java.security.KeyManagementException;
-import java.security.NoSuchAlgorithmException;
 import java.util.Arrays;
 import java.util.LinkedHashMap;
 import java.util.LinkedHashSet;
@@ -54,7 +52,6 @@
 import javax.swing.JPanel;
 import javax.swing.JRadioButton;
 
-import org.deegree.security.drm.ManagementException;
 import org.openjump.core.ui.plugin.wms.AddWmsLayerWizard;
 import org.openjump.util.UriUtil;
 
@@ -66,7 +63,6 @@
 import com.vividsolutions.jump.workbench.ui.wizard.CancelNextException;
 import com.vividsolutions.jump.workbench.ui.wizard.WizardPanelV2;
 import com.vividsolutions.wms.MapImageFormatChooser;
-import com.vividsolutions.wms.WMSException;
 import com.vividsolutions.wms.WMService;
 
 public class URLWizardPanel extends JPanel implements WizardPanelV2 {
@@ -160,7 +156,7 @@
 return I18N.get(I18N_PREFIX +