Re: undefined reference to `__aeabi_uldivmod' after 25c13324d03d ("IB/mlx5: Add steering SW ICM device memory type")
CC current 0day kbuild test maintainers Philip and Rong. -fengguang On Tue, May 14, 2019 at 11:49:18PM -0700, Nathan Chancellor wrote: On Wed, May 15, 2019 at 08:42:13AM +0200, Arnd Bergmann wrote: On Wed, May 15, 2019 at 8:40 AM Nathan Chancellor wrote: > On Wed, May 15, 2019 at 08:31:49AM +0200, Arnd Bergmann wrote: > > On Wed, May 15, 2019 at 7:04 AM Leon Romanovsky wrote: > > > On Tue, May 14, 2019 at 09:32:02PM -0300, Jason Gunthorpe wrote: > > > > On Tue, May 14, 2019 at 12:45:10PM -0700, Nathan Chancellor wrote: > > > > > Hi all, > > > > > > > > > > I checked the RDMA mailing list and trees and I haven't seen this > > > > > reported/fixed yet (forgive me if it has) but when building for arm32 > > > > > with multi_v7_defconfig and the following configs (distilled from > > > > > allyesconfig): > > > > > > > > > > CONFIG_INFINIBAND=y > > > > > CONFIG_INFINIBAND_ON_DEMAND_PAGING=y > > > > > CONFIG_INFINIBAND_USER_ACCESS=y > > > > > CONFIG_MLX5_CORE=y > > > > > CONFIG_MLX5_INFINIBAND=y > > > > > > > > > > The following link time errors occur: > > > > > > > > > > arm-linux-gnueabi-ld: drivers/infiniband/hw/mlx5/main.o: in function `mlx5_ib_alloc_dm': > > > > > main.c:(.text+0x60c): undefined reference to `__aeabi_uldivmod' > > > > > arm-linux-gnueabi-ld: drivers/infiniband/hw/mlx5/cmd.o: in function `mlx5_cmd_alloc_sw_icm': > > > > > cmd.c:(.text+0x6d4): undefined reference to `__aeabi_uldivmod' > > > > > arm-linux-gnueabi-ld: drivers/infiniband/hw/mlx5/cmd.o: in function `mlx5_cmd_dealloc_sw_icm': > > > > > cmd.c:(.text+0x9ec): undefined reference to `__aeabi_uldivmod' > > > > > > > > Fengguang, I'm surprised that 0-day didn't report this earlier.. > > > > > > I got many successful emails after I pushed this patch to 0-day testing. > > > > The long division warnings can compiler specific, and depend on certain > > optimization options, as compilers can optimize out certain divisions and > > replace them with multiplications and/or shifts, or prove that they can be > > replaced with a 32-bit division. If this is a case that gcc manages to > > optimize but clang does not, it might be worth looking into whether an > > optimization can be added to clang, in addition to improving the source. > > While I did run initially run into this with clang, the errors above are > with gcc (mainly to show this was going to be a universal problem and > not just something with clang). Which gcc version did you use here? Anything particularly old or particularly new? I think 0-day is on a fairly recent gcc-8, but not the latest gcc-9 release. 8.2.0 it seems (I've been meaning to build from the 9.x branch though since it appears that Arch's arm-linux-gnueabi-gcc isn't going to get updated since it's in the AUR).
[kbuild] [netdev-next:master 16/16] drivers/net/ethernet/intel/i40e/i40e_debugfs.c:832 i40e_dbg_dump_desc() warn: possible memory leak of 'ring'
tree: git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next.git
master
head: e6c97234d1b18d4751671df15d52e29daa8a7ba8
commit: e6c97234d1b18d4751671df15d52e29daa8a7ba8 [16/16] i40e: Reduce stack in
i40e_dbg_dump_desc
New smatch warnings:
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:832 i40e_dbg_dump_desc() warn:
possible memory leak of 'ring'
Old smatch warnings:
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:107 i40e_dbg_dump_read() warn:
maybe return -EFAULT instead of the bytes remaining?
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:357 i40e_dbg_command_read()
warn: maybe return -EFAULT instead of the bytes remaining?
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:386 i40e_dbg_dump_vsi_seid()
warn: this array is probably non-NULL. 'vsi-active_vlans'
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:991 i40e_dbg_command_write()
warn: maybe return -EFAULT instead of the bytes remaining?
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:1971 i40e_dbg_netdev_ops_read()
warn: maybe return -EFAULT instead of the bytes remaining?
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:2005 i40e_dbg_netdev_ops_write()
warn: maybe return -EFAULT instead of the bytes remaining?
vim +/ring +832 drivers/net/ethernet/intel/i40e/i40e_debugfs.c
68bf94aa Shannon Nelson 2014-01-15 816
d[%03i] = 0x%016llx 0x%016llx\n,
68bf94aa Shannon Nelson 2014-01-15 817
i, rxd-read.pkt_addr,
68bf94aa Shannon Nelson 2014-01-15 818
rxd-read.hdr_addr);
68bf94aa Shannon Nelson 2014-01-15 819 } else {
e6c97234 Joe Perches 2014-11-18 820 rxd =
I40E_RX_DESC(ring, i);
02e9c290 Jesse Brandeburg 2013-09-11 821
dev_info(pf-pdev-dev,
02e9c290 Jesse Brandeburg 2013-09-11 822
d[%03i] = 0x%016llx 0x%016llx 0x%016llx 0x%016llx\n,
68bf94aa Shannon Nelson 2014-01-15 823
i, rxd-read.pkt_addr,
68bf94aa Shannon Nelson 2014-01-15 824
rxd-read.hdr_addr,
68bf94aa Shannon Nelson 2014-01-15 825
rxd-read.rsvd1, rxd-read.rsvd2);
68bf94aa Shannon Nelson 2014-01-15 826 }
02e9c290 Jesse Brandeburg 2013-09-11 827 }
02e9c290 Jesse Brandeburg 2013-09-11 828 } else if (cnt == 3) {
e6c97234 Joe Perches 2014-11-18 829 if (desc_n =
ring-count || desc_n 0) {
02e9c290 Jesse Brandeburg 2013-09-11 830
dev_info(pf-pdev-dev,
02e9c290 Jesse Brandeburg 2013-09-11 831
descriptor %d not found\n, desc_n);
02e9c290 Jesse Brandeburg 2013-09-11 @832 return;
02e9c290 Jesse Brandeburg 2013-09-11 833 }
68bf94aa Shannon Nelson 2014-01-15 834 if (!is_rx_ring) {
e6c97234 Joe Perches 2014-11-18 835 txd =
I40E_TX_DESC(ring, desc_n);
02e9c290 Jesse Brandeburg 2013-09-11 836
dev_info(pf-pdev-dev,
68bf94aa Shannon Nelson 2014-01-15 837vsi =
%02i tx ring = %02i d[%03i] = 0x%016llx 0x%016llx\n,
68bf94aa Shannon Nelson 2014-01-15 838
vsi_seid, ring_id, desc_n,
68bf94aa Shannon Nelson 2014-01-15 839
txd-buffer_addr, txd-cmd_type_offset_bsz);
68bf94aa Shannon Nelson 2014-01-15 840 } else if (sizeof(union
i40e_rx_desc) ==
---
0-DAY kernel test infrastructureOpen Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
Re: [kbuild] [next:master 11322/11577] drivers/input/touchscreen/elants_i2c.c:877 elants_i2c_irq() warn: missing break? reassigning 'ts-state'
On Wed, Dec 10, 2014 at 01:24:10PM +0300, Dan Carpenter wrote: This is a false positive. On Wed, Dec 10, 2014 at 02:36:50AM +0800, kbuild test robot wrote: 66aee900 Scott Liu 2014-11-19 861 /* fall through */ Smatch should eventually be updated to grep for the fall through comments... It'd be convenient for me to grep that fall through in scripts. Shall I do it? Thanks, Fengguang ___ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman/listinfo/kbuild
Re: [kbuild] [next:master 1093/6788] net/mac80211/rc80211_minstrel_ht.c:255 minstrel_ht_sort_best_tp_rates() error: buffer overflow 'tp_list' 2 = 3
On Mon, Nov 17, 2014 at 11:36:37AM +0300, Dan Carpenter wrote:
Fengguang, this seems to be a very old version of linux-next?
It's 3 days ago, the HEAD commit is
commit d7e5a72b951a4ef6d97b2aa43cad37f237ba8030
Author: Stephen Rothwell s...@canb.auug.org.au
AuthorDate: Fri Nov 14 19:23:08 2014 +1100
Commit: Stephen Rothwell s...@canb.auug.org.au
CommitDate: Fri Nov 14 19:23:08 2014 +1100
Add linux-next specific files for 20141114
Signed-off-by: Stephen Rothwell s...@canb.auug.org.au
Thanks,
Fengguang
On Sat, Nov 15, 2014 at 07:32:54AM +0800, kbuild test robot wrote:
TO: Karl Beldan karl.bel...@rivierawaves.com
CC: Johannes Berg johannes.b...@intel.com
tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: d7e5a72b951a4ef6d97b2aa43cad37f237ba8030
commit: d4d141cae804a430054f4138fa177229114f203a [1093/6788] mac80211:
minstrel_ht: Increase the range of handled rate indexes
:: branch date: 15 hours ago
:: commit date: 4 weeks ago
net/mac80211/rc80211_minstrel_ht.c:255 minstrel_ht_sort_best_tp_rates()
error: buffer overflow 'tp_list' 2 = 3
net/mac80211/rc80211_minstrel_ht.c:256 minstrel_ht_sort_best_tp_rates()
error: buffer overflow 'tp_list' 2 = 3
net/mac80211/rc80211_minstrel_ht.c:270 minstrel_ht_sort_best_tp_rates()
warn: buffer overflow 'tp_list' 2 = 2
net/mac80211/rc80211_minstrel_ht.c:274 minstrel_ht_sort_best_tp_rates()
error: buffer overflow 'tp_list' 2 = 3
net/mac80211/rc80211_minstrel_ht.c:340 minstrel_ht_assign_best_tp_rates()
error: buffer overflow 'tmp_cck_tp_rate' 2 = 3
git remote add next
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update next
git checkout d4d141cae804a430054f4138fa177229114f203a
vim +/tp_list +255 net/mac80211/rc80211_minstrel_ht.c
5935839a Thomas Huehn 2014-09-09 249
5935839a Thomas Huehn 2014-09-09 250 cur_group = index /
MCS_GROUP_RATES;
5935839a Thomas Huehn 2014-09-09 251 cur_idx = index %
MCS_GROUP_RATES;
5935839a Thomas Huehn 2014-09-09 252 cur_thr =
mi-groups[cur_group].rates[cur_idx].cur_tp;
5935839a Thomas Huehn 2014-09-09 253 cur_prob =
mi-groups[cur_group].rates[cur_idx].probability;
5935839a Thomas Huehn 2014-09-09 254
5935839a Thomas Huehn 2014-09-09 @255 tmp_group = tp_list[j - 1] /
MCS_GROUP_RATES;
5935839a Thomas Huehn 2014-09-09 @256 tmp_idx = tp_list[j - 1] %
MCS_GROUP_RATES;
5935839a Thomas Huehn 2014-09-09 257 tmp_thr =
mi-groups[tmp_group].rates[tmp_idx].cur_tp;
5935839a Thomas Huehn 2014-09-09 258 tmp_prob =
mi-groups[tmp_group].rates[tmp_idx].probability;
5935839a Thomas Huehn 2014-09-09 259
5935839a Thomas Huehn 2014-09-09 260 while (j 0 (cur_thr
tmp_thr ||
5935839a Thomas Huehn 2014-09-09 261 (cur_thr == tmp_thr
cur_prob tmp_prob))) {
5935839a Thomas Huehn 2014-09-09 262 j--;
5935839a Thomas Huehn 2014-09-09 263 tmp_group = tp_list[j -
1] / MCS_GROUP_RATES;
5935839a Thomas Huehn 2014-09-09 264 tmp_idx = tp_list[j -
1] % MCS_GROUP_RATES;
5935839a Thomas Huehn 2014-09-09 265 tmp_thr =
mi-groups[tmp_group].rates[tmp_idx].cur_tp;
5935839a Thomas Huehn 2014-09-09 266 tmp_prob =
mi-groups[tmp_group].rates[tmp_idx].probability;
5935839a Thomas Huehn 2014-09-09 267 }
5935839a Thomas Huehn 2014-09-09 268
5935839a Thomas Huehn 2014-09-09 269 if (j MAX_THR_RATES - 1) {
5935839a Thomas Huehn 2014-09-09 @270 memmove(tp_list[j +
1], tp_list[j], (sizeof(*tp_list) *
5935839a Thomas Huehn 2014-09-09 271 (MAX_THR_RATES -
(j + 1;
5935839a Thomas Huehn 2014-09-09 272 }
5935839a Thomas Huehn 2014-09-09 273 if (j MAX_THR_RATES)
5935839a Thomas Huehn 2014-09-09 @274 tp_list[j] = index;
5935839a Thomas Huehn 2014-09-09 275 }
5935839a Thomas Huehn 2014-09-09 276
5935839a Thomas Huehn 2014-09-09 277 /*
5935839a Thomas Huehn 2014-09-09 278 * Find and set the topmost
probability rate per sta and per group
5935839a Thomas Huehn 2014-09-09 279 */
5935839a Thomas Huehn 2014-09-09 280 static void
d4d141ca Karl Beldan 2014-10-20 281
minstrel_ht_set_best_prob_rate(struct minstrel_ht_sta *mi, u16 index)
5935839a Thomas Huehn 2014-09-09 282 {
5935839a Thomas Huehn 2014-09-09 283 struct minstrel_mcs_group_data
*mg;
5935839a Thomas Huehn 2014-09-09 284 struct minstrel_rate_stats *mr;
5935839a Thomas Huehn 2014-09-09 285 int tmp_group, tmp_idx, tmp_tp,
tmp_prob, max_tp_group;
5935839a Thomas Huehn 2014-09-09 286
5935839a Thomas Huehn 2014-09-09 287 mg = mi-groups[index /
MCS_GROUP_RATES];
5935839a Thomas Huehn 2014-09-09 288 mr = mg-rates[index %
MCS_GROUP_RATES];
5935839a
Re: [kbuild] [next:master 1093/6788] net/mac80211/rc80211_minstrel_ht.c:255 minstrel_ht_sort_best_tp_rates() error: buffer overflow 'tp_list' 2 = 3
On Mon, Nov 17, 2014 at 12:56:08PM +0300, Dan Carpenter wrote: On Mon, Nov 17, 2014 at 05:32:33PM +0800, Fengguang Wu wrote: On Mon, Nov 17, 2014 at 11:36:37AM +0300, Dan Carpenter wrote: Fengguang, this seems to be a very old version of linux-next? It's 3 days ago, the HEAD commit is commit d7e5a72b951a4ef6d97b2aa43cad37f237ba8030 Author: Stephen Rothwell s...@canb.auug.org.au AuthorDate: Fri Nov 14 19:23:08 2014 +1100 Commit: Stephen Rothwell s...@canb.auug.org.au CommitDate: Fri Nov 14 19:23:08 2014 +1100 Add linux-next specific files for 20141114 Signed-off-by: Stephen Rothwell s...@canb.auug.org.au The line numbers match. It has to be next-20141104 or earlier (one month ago). Yes the commit d4d141cae804a430054f4138fa177229114f203a is one month ago. The context source code is using output of that commit: git show d4d141cae804a430054f4138fa177229114f203a:net/mac80211/rc80211_minstrel_ht.c Thanks, Fengguang ___ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman/listinfo/kbuild
Re: [kbuild] [PATCH] iio: adc: fix platform_no_drv_owner.cocci warnings (fwd)
Hi Julia,
On Thu, Nov 13, 2014 at 11:26:23AM +0100, Julia Lawall wrote:
Is there any way that we can improve this process? At the moment, I just
take the message I get and forward it.
How about always send the patches to public LKML, with you in the CC list?
Thanks,
Fengguang
-- Forwarded message --
Date: Thu, 13 Nov 2014 10:19:13 +
From: Lee Jones lee.jo...@linaro.org
To: Julia Lawall julia.law...@lip6.fr
Cc: kbuild test robot fengguang...@intel.com,
Jacob Pan jacob.jun@linux.intel.com, kbu...@01.org
Subject: Re: [PATCH] iio: adc: fix platform_no_drv_owner.cocci warnings
On Tue, 11 Nov 2014, Julia Lawall wrote:
The owner field is no longer required. Please consider applying the
patch.
I don't know about Jonathan, but I can't take patches like this. They
need to be correctly formatted and sent as a proper patch:
On Tue, 11 Nov 2014, kbuild test robot wrote:
TO: Jacob Pan jacob.jun@linux.intel.com
CC: Lee Jones lee.jo...@linaro.org
drivers/iio/adc/axp288_adc.c:246:3-8: No need to set .owner here. The
core will do it.
Incorrect $SUBJECT line for the subsystem.
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
CC: Jacob Pan jacob.jun@linux.intel.com
Adding a Cc: tag for yourself in a commit log is not good practice.
Signed-off-by: Fengguang Wu fengguang...@intel.com
---
Please take the patch only if it's a positive warning. Thanks!
axp288_adc.c |1 -
1 file changed, 1 deletion(-)
--- a/drivers/iio/adc/axp288_adc.c
+++ b/drivers/iio/adc/axp288_adc.c
@@ -243,7 +243,6 @@ static struct platform_driver axp288_adc
.remove = axp288_adc_remove,
.driver = {
.name = axp288_adc,
- .owner = THIS_MODULE,
},
};
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
Re: [kbuild] [PATCH] iio: adc: fix platform_no_drv_owner.cocci warnings (fwd)
On Thu, Nov 13, 2014 at 02:12:33PM +0100, Julia Lawall wrote: On Thu, 13 Nov 2014, Dan Carpenter wrote: On Thu, Nov 13, 2014 at 01:45:39PM +0100, Julia Lawall wrote: But overall the problem is for the lower confidence ones how to get the patch to the developer in the form that they want. Is the idea that there are some lines that I should be removing (To, CC, and the file and line generated by Coccinelle)? Should I forward instead of replying? Fengguang and I use mutt. In mutt you can just edit the original message, change the from and to headers, chop out the meta comments about when the code was committed and resend. That's much more awkward for non mutt users though... I don't think I would have any problem doing these things. I would just have to know to do them. My vision was that kbuild was automatic, I would check whether the proposed change was OK, and the developers would take it from there. If I should be producing a patch that they should apply directly than that's OK as well. The only question is who should the message be From (ie patch author)? Me? Fengguang? There isn't really a person associated with it. If you edit and forward out the email, the author should be you not me. I'm a robot, after all. ;) Thanks, Fengguang ___ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman/listinfo/kbuild
Re: [kbuild] [PATCH] iio: adc: fix platform_no_drv_owner.cocci warnings (fwd)
On Thu, Nov 13, 2014 at 04:29:15PM +0300, Dan Carpenter wrote: On Thu, Nov 13, 2014 at 09:20:16PM +0800, Fengguang Wu wrote: I'm a robot, after all. ;) Heh. One time I was credited to as: Reported-by: The Intel Backend And I had to tell them that I might be a backend, but I work for Oracle. That is amusing. :) Regards, Fengguang ___ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [PATCH] PCI: fix simple_return.cocci warnings
drivers/pci/pci.c:1015:1-2: WARNING: end returns can be simpified Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci Signed-off-by: Fengguang Wu fengguang...@intel.com --- Please take the patch only if it's a positive warning. Thanks! pci.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -1012,11 +1012,7 @@ int pci_save_state(struct pci_dev *dev) if (i != 0) return i; - i = pci_save_vc_state(dev); - if (i != 0) - return i; - - return 0; + return pci_save_vc_state(dev); } EXPORT_SYMBOL(pci_save_state); ___ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman/listinfo/kbuild
Re: [kbuild] [ljones-mfd:for-mfd-next-v3.19 86/92] drivers/mfd/syscon.c:89:1-8: WARNING: invalid free of devm_ allocated data
On Wed, Oct 08, 2014 at 03:12:46PM +0530, Pankaj Dubey wrote: Hi, Subject: Re: [ljones-mfd:for-mfd-next-v3.19 86/92] drivers/mfd/syscon.c:89:1-8: WARNING: invalid free of devm_ allocated data For some reason I wasn't able to clone this tree, so I don't know whether there is a real bug or a false positive. But it maybe worth looking into. Looks like MFD tree has been moved to new location, and you should be able to clone it from: git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git Sorry I'm using the old URL to do reporting. Updated the URL, thank you! Thanks, Fengguang ___ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman/listinfo/kbuild
Re: [kbuild] [platform-drivers-x86:testing 8/8] drivers/platform/x86/toshiba_acpi.c:1352 toshiba_touchpad_store() warn: was intended here instead of ||?
On Wed, Sep 10, 2014 at 07:59:17AM -0700, Darren Hart wrote:
On 9/10/14, 0:12, Dan Carpenter dan.carpen...@oracle.com wrote:
tree:
git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git
testing
head: 58e642de0a6fba870c2bba86f3e92c68df1fd42e
commit: 58e642de0a6fba870c2bba86f3e92c68df1fd42e [8/8] toshiba_acpi:
Change touchpad store to check for invalid values
drivers/platform/x86/toshiba_acpi.c:1352 toshiba_touchpad_store() warn:
was intended here instead of ||?
Fengguang,
What is this checking for? It was supposed to be a ||, but I'm wondering
what triggered this report?
It looks like an smatch warning. The reason should be, this || test
combination is always true:
(state != 0 || state != 1)
Thanks,
Fengguang
git remote add platform-drivers-x86
git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git
git remote update platform-drivers-x86
git checkout 58e642de0a6fba870c2bba86f3e92c68df1fd42e
vim +1352 drivers/platform/x86/toshiba_acpi.c
360f0f39d Azael Avalos 2014-03-25 1336
360f0f39d Azael Avalos 2014-03-25 1337 return sprintf(buf, %i\n,
time HCI_MISC_SHIFT);
360f0f39d Azael Avalos 2014-03-25 1338 }
360f0f39d Azael Avalos 2014-03-25 1339
9d8658acd Azael Avalos 2014-03-25 1340 static ssize_t
toshiba_touchpad_store(struct device *dev,
9d8658acd Azael Avalos 2014-03-25 1341
struct
device_attribute *attr,
9d8658acd Azael Avalos 2014-03-25 1342
const char *buf,
size_t count)
9d8658acd Azael Avalos 2014-03-25 1343 {
9d8658acd Azael Avalos 2014-03-25 1344 struct toshiba_acpi_dev
*toshiba = dev_get_drvdata(dev);
9d8658acd Azael Avalos 2014-03-25 1345 int state;
58e642de0 Azael Avalos 2014-09-05 1346 int ret;
9d8658acd Azael Avalos 2014-03-25 1347
9d8658acd Azael Avalos 2014-03-25 1348 /* Set the TouchPad on/off, 0 -
Disable | 1 - Enable */
58e642de0 Azael Avalos 2014-09-05 1349 ret = kstrtoint(buf, 0, state);
58e642de0 Azael Avalos 2014-09-05 1350 if (ret)
58e642de0 Azael Avalos 2014-09-05 1351 return ret;
58e642de0 Azael Avalos 2014-09-05 @1352 if (state != 0 || state != 1)
58e642de0 Azael Avalos 2014-09-05 1353 return -EINVAL;
58e642de0 Azael Avalos 2014-09-05 1354
58e642de0 Azael Avalos 2014-09-05 1355 ret =
toshiba_touchpad_set(toshiba, state);
58e642de0 Azael Avalos 2014-09-05 1356 if (ret)
58e642de0 Azael Avalos 2014-09-05 1357 return ret;
9d8658acd Azael Avalos 2014-03-25 1358
9d8658acd Azael Avalos 2014-03-25 1359 return count;
9d8658acd Azael Avalos 2014-03-25 1360 }
---
0-DAY kernel build testing backend Open Source Technology
Center
http://lists.01.org/mailman/listinfo/kbuild Intel
Corporation
--
Darren Hart Open Source Technology Center
darren.h...@intel.com Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
Re: [kbuild] [linuxtv-media:devel 497/499] drivers/media/platform/s5p-mfc/s5p_mfc.c:454:2-5: WARNING: Use BUG_ON
Hi Mauro, On Wed, Aug 27, 2014 at 02:31:37PM -0300, Mauro Carvalho Chehab wrote: Hi Fengguang, Not sure why, but I didn't receive this e-mail (or other emails in this thread). It's a manual check process rather than an email problem. The TO/CC you see lie in the email body. The original email is sent to the kbuild list for manual checking. We do such check for all low confident static check warnings. Julia and Dan are actively looking at these reports and will forward the ones that worth more attention to the relevant people. Thanks, Fengguang Em Wed, 27 Aug 2014 19:07:45 +0200 (CEST) Julia Lawall julia.law...@lip6.fr escreveu: The bug_on one doesn't look like a good idea, but the returnvar one would make the code a little simpler. julia On Thu, 28 Aug 2014, kbuild test robot wrote: TO: Mauro Carvalho Chehab m.che...@samsung.com CC: linux-me...@vger.kernel.org Hi Mauro, First bad commit (maybe != root cause): tree: git://linuxtv.org/media_tree.git devel head: 38a0731165250a0a77eff7b90ea3156d44cc7d66 commit: 7155043c2d027c9c848c3d09badb5af2894ed652 [497/499] [media] enable COMPILE_TEST for media drivers :: branch date: 19 hours ago :: commit date: 19 hours ago drivers/media/platform/s5p-mfc/s5p_mfc.c:454:2-5: WARNING: Use BUG_ON drivers/media/platform/s5p-mfc/s5p_mfc.c:333:3-6: WARNING: Use BUG_ON drivers/media/platform/s5p-mfc/s5p_mfc.c:406:2-5: WARNING: Use BUG_ON drivers/media/platform/s5p-mfc/s5p_mfc.c:548:3-6: WARNING: Use BUG_ON drivers/media/platform/s5p-mfc/s5p_mfc.c:556:3-6: WARNING: Use BUG_ON drivers/media/platform/s5p-mfc/s5p_mfc.c:509:2-5: WARNING: Use BUG_ON drivers/media/platform/s5p-mfc/s5p_mfc.c:634:4-7: WARNING: Use BUG_ON -- drivers/media/platform/davinci/vpfe_capture.c:946:5-8: Unneeded variable: ret. Return 0 on line 951 Please consider folding the attached diff :-) --- 0-DAY kernel build testing backend Open Source Technology Center http://lists.01.org/mailman/listinfo/kbuild Intel Corporation ___ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman/listinfo/kbuild
Re: [kbuild] [gpio:for-next 14/19] drivers/gpio/gpiolib-sysfs.c:817:7-11: ERROR: iterator variable bound on line 816 cannot be NULL
On Wed, Jul 23, 2014 at 10:10:10AM +0200, Julia Lawall wrote: On Wed, 23 Jul 2014, Dan Carpenter wrote: On Wed, Jul 23, 2014 at 01:41:33PM +0800, Fengguang Wu wrote: Hi Alexandre, On Wed, Jul 23, 2014 at 02:19:38PM +0900, Alexandre Courbot wrote: Oh, nice one. Linus, do you need a fixup patch? PS: for some reason the kbuild mails seem to not arrive on my end despite being the main recipient (this is the first mail I received about this issue). They are not even showing up in my spam folder. Any idea how I could debug this? The TO/CC is in the email body rather than email head. :) It's a low confident warning, so is first sent to the kbuild list for manual check: https://lists.01.org/pipermail/kbuild/2014-July/001629.html Julia noticed it and added you to the CC list. Julia, I never get your emails so I sometimes send duplicate reports. Yes, I don't understand this. I just take the headers as I see them and add the people listed in the body of the message. I don't remove anything. Dan Carpenter is in the header CC list. I wonder if it's the kbuild list that removed the CC to Dan. But still, Dan should be subscribed to the kbuild list (kbu...@01.org) and hence being implicitly CCed? Thanks, Fengguang Are other people forwarding the manual check emails? I am the only person who CC's the kbuild list, I think? regards, dan carpenter ___ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman/listinfo/kbuild
Re: [kbuild] [pm:bleeding-edge 36/63] drivers/idle/intel_idle.c:754:5-42: code aligned with following code on line 755
CC Len Brown for possible bugs. Thank you, Julia!
On Tue, Apr 08, 2014 at 02:36:55PM +0200, Julia Lawall wrote:
I don't know how the code should be, but it does not look right as it is.
julia
On Tue, 8 Apr 2014, kbuild test robot wrote:
TO: Len Brown len.br...@intel.com
tree: git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git
bleeding-edge
head: 25839f9c0694ba91c691fd22c99106d7093f4182
commit: 0138d8f0755b5b28d0acdb0a758bcfcaf441fc58 [36/63] intel_idle:
fine-tune IVT residency targets
:: branch date: 55 minutes ago
:: commit date: 4 days ago
drivers/idle/intel_idle.c:754:5-42: code aligned with following code on
line 755
git remote add pm
git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git
git remote update pm
git checkout 0138d8f0755b5b28d0acdb0a758bcfcaf441fc58
vim +754 drivers/idle/intel_idle.c
0138d8f0 Len Brown 2014-04-04 748
for_each_online_cpu(cpu) {
0138d8f0 Len Brown 2014-04-04 749 package_num =
topology_physical_package_id(cpu);
0138d8f0 Len Brown 2014-04-04 750 if (package_num
+ 1 num_sockets) {
0138d8f0 Len Brown 2014-04-04 751
num_sockets = package_num + 1;
0138d8f0 Len Brown 2014-04-04 752
0138d8f0 Len Brown 2014-04-04 753 if
(num_sockets 4)
0138d8f0 Len Brown 2014-04-04 @754
cpuidle_state_table = ivt_cstates_8s;
0138d8f0 Len Brown 2014-04-04 @755
return;
0138d8f0 Len Brown 2014-04-04 756 }
0138d8f0 Len Brown 2014-04-04 757 }
0138d8f0 Len Brown 2014-04-04 758
---
0-DAY kernel build testing backend Open Source Technology
Center
http://lists.01.org/mailman/listinfo/kbuild Intel
Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [bluetooth:master 390/432] net/bluetooth/hci_core.c:940:7-14: WARNING opportunity for memdup_user
Hi Andre,
FYI, there are coccinelle warnings in
tree:
git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git
master
head: 2e2336445e696805b40d6a13cf25f26d49e20069
commit: 7d474e06ef8ee3941a4a0dcb824b8e3006f25d3e [390/432] Bluetooth: Add
le_auto_conn file on debugfs
net/bluetooth/hci_core.c:940:7-14: WARNING opportunity for memdup_user
vim +940 net/bluetooth/hci_core.c
7d474e06 Andre Guedes 2014-02-26 924 struct seq_file *sf =
file-private_data;
7d474e06 Andre Guedes 2014-02-26 925 struct hci_dev *hdev = sf-private;
7d474e06 Andre Guedes 2014-02-26 926 u8 auto_connect = 0;
7d474e06 Andre Guedes 2014-02-26 927 bdaddr_t addr;
7d474e06 Andre Guedes 2014-02-26 928 u8 addr_type;
7d474e06 Andre Guedes 2014-02-26 929 char *buf;
7d474e06 Andre Guedes 2014-02-26 930 int err = 0;
7d474e06 Andre Guedes 2014-02-26 931 int n;
7d474e06 Andre Guedes 2014-02-26 932
7d474e06 Andre Guedes 2014-02-26 933 /* Don't allow partial write */
7d474e06 Andre Guedes 2014-02-26 934 if (*offset != 0)
7d474e06 Andre Guedes 2014-02-26 935 return -EINVAL;
7d474e06 Andre Guedes 2014-02-26 936
7d474e06 Andre Guedes 2014-02-26 937 if (count 3)
7d474e06 Andre Guedes 2014-02-26 938 return -EINVAL;
7d474e06 Andre Guedes 2014-02-26 939
7d474e06 Andre Guedes 2014-02-26 @940 buf = kzalloc(count, GFP_KERNEL);
7d474e06 Andre Guedes 2014-02-26 941 if (!buf)
7d474e06 Andre Guedes 2014-02-26 942 return -ENOMEM;
7d474e06 Andre Guedes 2014-02-26 943
7d474e06 Andre Guedes 2014-02-26 944 if (copy_from_user(buf, data, count)) {
7d474e06 Andre Guedes 2014-02-26 945 err = -EFAULT;
7d474e06 Andre Guedes 2014-02-26 946 goto done;
7d474e06 Andre Guedes 2014-02-26 947 }
7d474e06 Andre Guedes 2014-02-26 948
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
Re: [kbuild] [bluetooth:master 390/432] net/bluetooth/hci_core.c:940:7-14: WARNING opportunity for memdup_user
Julia,
Just sent it out, thank you for looking into the warnings!
Thanks,
Fengguang
On Wed, Mar 19, 2014 at 05:53:33AM -0400, Julia Lawall wrote:
You can pass the suggestion along to the developers.
julia
On Wed, 19 Mar 2014, kbuild test robot wrote:
TO: Andre Guedes andre.gue...@openbossa.org
CC: Marcel Holtmann mar...@holtmann.org
Hi Andre,
FYI, there are coccinelle warnings in
tree:
git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git
master
head: 2e2336445e696805b40d6a13cf25f26d49e20069
commit: 7d474e06ef8ee3941a4a0dcb824b8e3006f25d3e [390/432] Bluetooth: Add
le_auto_conn file on debugfs
:: branch date: 13 hours ago
:: commit date: 3 weeks ago
net/bluetooth/hci_core.c:940:7-14: WARNING opportunity for memdup_user
git remote add bluetooth
git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git
git remote update bluetooth
git checkout 7d474e06ef8ee3941a4a0dcb824b8e3006f25d3e
vim +940 net/bluetooth/hci_core.c
7d474e06 Andre Guedes 2014-02-26 924 struct seq_file *sf =
file-private_data;
7d474e06 Andre Guedes 2014-02-26 925 struct hci_dev *hdev =
sf-private;
7d474e06 Andre Guedes 2014-02-26 926 u8 auto_connect = 0;
7d474e06 Andre Guedes 2014-02-26 927 bdaddr_t addr;
7d474e06 Andre Guedes 2014-02-26 928 u8 addr_type;
7d474e06 Andre Guedes 2014-02-26 929 char *buf;
7d474e06 Andre Guedes 2014-02-26 930 int err = 0;
7d474e06 Andre Guedes 2014-02-26 931 int n;
7d474e06 Andre Guedes 2014-02-26 932
7d474e06 Andre Guedes 2014-02-26 933 /* Don't allow partial write */
7d474e06 Andre Guedes 2014-02-26 934 if (*offset != 0)
7d474e06 Andre Guedes 2014-02-26 935 return -EINVAL;
7d474e06 Andre Guedes 2014-02-26 936
7d474e06 Andre Guedes 2014-02-26 937 if (count 3)
7d474e06 Andre Guedes 2014-02-26 938 return -EINVAL;
7d474e06 Andre Guedes 2014-02-26 939
7d474e06 Andre Guedes 2014-02-26 @940 buf = kzalloc(count,
GFP_KERNEL);
7d474e06 Andre Guedes 2014-02-26 941 if (!buf)
7d474e06 Andre Guedes 2014-02-26 942 return -ENOMEM;
7d474e06 Andre Guedes 2014-02-26 943
7d474e06 Andre Guedes 2014-02-26 944 if (copy_from_user(buf, data,
count)) {
7d474e06 Andre Guedes 2014-02-26 945 err = -EFAULT;
7d474e06 Andre Guedes 2014-02-26 946 goto done;
7d474e06 Andre Guedes 2014-02-26 947 }
7d474e06 Andre Guedes 2014-02-26 948
---
0-DAY kernel build testing backend Open Source Technology
Center
http://lists.01.org/mailman/listinfo/kbuild Intel
Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [robclark:cold-fusion 32/34] drivers/gpu/drm/drm_crtc.c:4991:16-23: WARNING opportunity for memdup_user
Hi Ville,
FYI, there are coccinelle warnings in
tree: git://people.freedesktop.org/~robclark/linux cold-fusion
head: f390d4060deb9d2140b61802f21a8ef0f206427d
commit: a7866076ac14b9d0f80e8306c7ab4110a808df5b [32/34] drm: Atomic modeset
ioctl
drivers/gpu/drm/drm_crtc.c:4991:16-23: WARNING opportunity for memdup_user
vim +4991 drivers/gpu/drm/drm_crtc.c
a7866076 Ville Syrjälä 2012-05-16 4975 goto
out;
a7866076 Ville Syrjälä 2012-05-16 4976 }
a7866076 Ville Syrjälä 2012-05-16 4977
a7866076 Ville Syrjälä 2012-05-16 4978 if
(!drm_property_change_is_valid(prop, prop_value)) {
a7866076 Ville Syrjälä 2012-05-16 4979 ret =
-EINVAL;
a7866076 Ville Syrjälä 2012-05-16 4980 goto
out;
a7866076 Ville Syrjälä 2012-05-16 4981 }
a7866076 Ville Syrjälä 2012-05-16 4982
a7866076 Ville Syrjälä 2012-05-16 4983 if
((prop-flags DRM_MODE_PROP_BLOB) prop_value) {
a7866076 Ville Syrjälä 2012-05-16 4984
uint64_t blob_ptr;
a7866076 Ville Syrjälä 2012-05-16 4985
a7866076 Ville Syrjälä 2012-05-16 4986 if
(get_user(blob_ptr, blob_values_ptr + copied_blobs)) {
a7866076 Ville Syrjälä 2012-05-16 4987
ret = -EFAULT;
a7866076 Ville Syrjälä 2012-05-16 4988
goto out;
a7866076 Ville Syrjälä 2012-05-16 4989 }
a7866076 Ville Syrjälä 2012-05-16 4990
a7866076 Ville Syrjälä 2012-05-16 @4991
blob_data = kmalloc(prop_value, GFP_KERNEL);
a7866076 Ville Syrjälä 2012-05-16 4992 if
(!blob_data) {
a7866076 Ville Syrjälä 2012-05-16 4993
ret = -ENOMEM;
a7866076 Ville Syrjälä 2012-05-16 4994
goto out;
a7866076 Ville Syrjälä 2012-05-16 4995 }
a7866076 Ville Syrjälä 2012-05-16 4996
a7866076 Ville Syrjälä 2012-05-16 4997 if
(copy_from_user(blob_data, (void __user *)(unsigned long)blob_ptr, prop_value))
{
a7866076 Ville Syrjälä 2012-05-16 4998
kfree(blob_data);
a7866076 Ville Syrjälä 2012-05-16 4999
ret = -EFAULT;
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [omap-audio:next-bnw/ti-audio-next_3.13 18/32] sound/soc/soc-fw.c:945:9-16: ERROR: se is NULL but dereferenced.
Hi Liam,
FYI, there are coccinelle warnings in
tree: git://gitorious.org/omap-audio/linux-audio next-bnw/ti-audio-next_3.13
head: 5c517d04526a7a8958de552411d83a45c289484b
commit: 7c6163f44cd6b375b3077ab566cf0e461474640b [18/32] ASoC: firmware: Add
support for dynamic components
sound/soc/soc-fw.c:945:9-16: ERROR: se is NULL but dereferenced.
--
sound/soc/soc-fw.c:1425:8-9: ERROR: reference preceded by free on line 1425
sound/soc/soc-fw.c:1465:8-9: ERROR: reference preceded by free on line 1465
--
sound/soc/soc-fw.c:1510:6-8: ERROR: invalid reference to the index variable
of the iterator on line 1495
sound/soc/soc-fw.c:1430:6-8: ERROR: invalid reference to the index variable
of the iterator on line 1415
sound/soc/soc-fw.c:1470:6-8: ERROR: invalid reference to the index variable
of the iterator on line 1455
There is a problem. The goto is on line 869.
julia
vim +945 sound/soc/soc-fw.c
7c6163f4 Liam Girdwood 2012-12-05 929 goto err_se;
7c6163f4 Liam Girdwood 2012-12-05 930 }
7c6163f4 Liam Girdwood 2012-12-05 931
7c6163f4 Liam Girdwood 2012-12-05 932 err =
soc_fw_init_kcontrol(sfw, kc);
7c6163f4 Liam Girdwood 2012-12-05 933 if (err 0) {
7c6163f4 Liam Girdwood 2012-12-05 934
dev_err(sfw-dev, ASoC: failed to init %s\n,
7c6163f4 Liam Girdwood 2012-12-05 935
ec-hdr.name);
7c6163f4 Liam Girdwood 2012-12-05 936 goto err_se;
7c6163f4 Liam Girdwood 2012-12-05 937 }
7c6163f4 Liam Girdwood 2012-12-05 938 }
7c6163f4 Liam Girdwood 2012-12-05 939 return kc;
7c6163f4 Liam Girdwood 2012-12-05 940
7c6163f4 Liam Girdwood 2012-12-05 941 err_se:
7c6163f4 Liam Girdwood 2012-12-05 942 kfree(kc);
7c6163f4 Liam Girdwood 2012-12-05 943
7c6163f4 Liam Girdwood 2012-12-05 944 /* free values and texts */
7c6163f4 Liam Girdwood 2012-12-05 @945 if (se-dvalues)
7c6163f4 Liam Girdwood 2012-12-05 946 kfree(se-dvalues);
7c6163f4 Liam Girdwood 2012-12-05 947 for (i = 0; i ec-max; i++)
7c6163f4 Liam Girdwood 2012-12-05 948 kfree(se-dtexts[i]);
7c6163f4 Liam Girdwood 2012-12-05 949
7c6163f4 Liam Girdwood 2012-12-05 950 kfree(se);
7c6163f4 Liam Girdwood 2012-12-05 951
7c6163f4 Liam Girdwood 2012-12-05 952 return NULL;
7c6163f4 Liam Girdwood 2012-12-05 953 }
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [usb:usb-next 42/203] drivers/usb/gadget/f_fs.c:863:1-7: preceding lock on line 781
Hi Robert,
FYI, there are coccinelle warnings in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next
head: 7338a0659365ec0fbdc6f79de8b9fba2280fd155
commit: 2e4c7553cd6f9c68bb741582dcb614edcbeca70f [42/203] usb: gadget: f_fs:
add aio support
drivers/usb/gadget/f_fs.c:863:1-7: preceding lock on line 781
The problem seems to be the in then branch of the if starting on 797.
julia
vim +863 drivers/usb/gadget/f_fs.c
ddf8abd2 Michal Nazarewicz 2010-05-05 775
7fa68034 Michal Nazarewicz 2013-12-09 776 /* We will be using request */
7fa68034 Michal Nazarewicz 2013-12-09 777 ret =
ffs_mutex_lock(epfile-mutex, file-f_flags O_NONBLOCK);
7fa68034 Michal Nazarewicz 2013-12-09 778 if (unlikely(ret))
7fa68034 Michal Nazarewicz 2013-12-09 779 goto error;
ddf8abd2 Michal Nazarewicz 2010-05-05 780
7fa68034 Michal Nazarewicz 2013-12-09 @781
spin_lock_irq(epfile-ffs-eps_lock);
ddf8abd2 Michal Nazarewicz 2010-05-05 782
7fa68034 Michal Nazarewicz 2013-12-09 783 if (epfile-ep != ep) {
7fa68034 Michal Nazarewicz 2013-12-09 784 /* In the meantime,
endpoint got disabled or changed. */
7fa68034 Michal Nazarewicz 2013-12-09 785 ret = -ESHUTDOWN;
7fa68034 Michal Nazarewicz 2013-12-09 786
spin_unlock_irq(epfile-ffs-eps_lock);
7fa68034 Michal Nazarewicz 2013-12-09 787 } else if (halt) {
7fa68034 Michal Nazarewicz 2013-12-09 788 /* Halt */
ddf8abd2 Michal Nazarewicz 2010-05-05 789 if (likely(epfile-ep
== ep) !WARN_ON(!ep-ep))
ddf8abd2 Michal Nazarewicz 2010-05-05 790
usb_ep_set_halt(ep-ep);
ddf8abd2 Michal Nazarewicz 2010-05-05 791
spin_unlock_irq(epfile-ffs-eps_lock);
ddf8abd2 Michal Nazarewicz 2010-05-05 792 ret = -EBADMSG;
ddf8abd2 Michal Nazarewicz 2010-05-05 793 } else {
ddf8abd2 Michal Nazarewicz 2010-05-05 794 /* Fire the request */
2e4c7553 Robert Baldyga2014-02-10 795 struct usb_request *req;
ddf8abd2 Michal Nazarewicz 2010-05-05 796
2e4c7553 Robert Baldyga2014-02-10 797 if (io_data-aio) {
2e4c7553 Robert Baldyga2014-02-10 798 req =
usb_ep_alloc_request(ep-ep, GFP_KERNEL);
2e4c7553 Robert Baldyga2014-02-10 799 if
(unlikely(!req))
2e4c7553 Robert Baldyga2014-02-10 800 goto
error;
ddf8abd2 Michal Nazarewicz 2010-05-05 801
2e4c7553 Robert Baldyga2014-02-10 802 req-buf =
data;
2e4c7553 Robert Baldyga2014-02-10 803 req-length =
io_data-len;
ddf8abd2 Michal Nazarewicz 2010-05-05 804
2e4c7553 Robert Baldyga2014-02-10 805 io_data-buf =
data;
2e4c7553 Robert Baldyga2014-02-10 806 io_data-ep =
ep-ep;
2e4c7553 Robert Baldyga2014-02-10 807 io_data-req =
req;
ddf8abd2 Michal Nazarewicz 2010-05-05 808
2e4c7553 Robert Baldyga2014-02-10 809 req-context =
io_data;
2e4c7553 Robert Baldyga2014-02-10 810 req-complete =
ffs_epfile_async_io_complete;
2e4c7553 Robert Baldyga2014-02-10 811
2e4c7553 Robert Baldyga2014-02-10 812 ret =
usb_ep_queue(ep-ep, req, GFP_ATOMIC);
2e4c7553 Robert Baldyga2014-02-10 813 if
(unlikely(ret)) {
2e4c7553 Robert Baldyga2014-02-10 814
usb_ep_free_request(ep-ep, req);
2e4c7553 Robert Baldyga2014-02-10 815 goto
error;
2e4c7553 Robert Baldyga2014-02-10 816 }
2e4c7553 Robert Baldyga2014-02-10 817 ret =
-EIOCBQUEUED;
2e4c7553 Robert Baldyga2014-02-10 818
2e4c7553 Robert Baldyga2014-02-10 819
spin_unlock_irq(epfile-ffs-eps_lock);
ddf8abd2 Michal Nazarewicz 2010-05-05 820 } else {
2e4c7553 Robert Baldyga2014-02-10 821
DECLARE_COMPLETION_ONSTACK(done);
2e4c7553 Robert Baldyga2014-02-10 822
2e4c7553 Robert Baldyga2014-02-10 823 req = ep-req;
2e4c7553 Robert Baldyga2014-02-10 824 req-buf =
data;
2e4c7553 Robert Baldyga2014-02-10 825 req-length =
io_data-len;
2e4c7553 Robert Baldyga2014-02-10 826
2e4c7553 Robert Baldyga2014-02-10 827 req-context =
done;
2e4c7553 Robert Baldyga2014-02-10 828 req-complete =
ffs_epfile_io_complete;
2e4c7553 Robert Baldyga2014-02-10 829
2e4c7553 Robert Baldyga2014-02-10 830 ret =
usb_ep_queue(ep-ep, req, GFP_ATOMIC);
2e4c7553 Robert Baldyga2014-02-10 831
2e4c7553 Robert Baldyga2014-02-10 832
spin_unlock_irq(epfile-ffs-eps_lock);
2e4c7553 Robert Baldyga
[kbuild] [drm-intel:drm-intel-nightly 388/398] drivers/gpu/drm/i915/i915_irq.c:3065:5-40: duplicated argument to or |
Hi Imre,
tree: git://anongit.freedesktop.org/drm-intel drm-intel-nightly
head: 51e06d413a6a8ccdf0f407b4abe76b774ac050c6
commit: e0e33f8ff6f0b6d286afc314802be4993341bd47 [388/398] drm/i915: vlv:
factor out valleyview_display_irq_install
drivers/gpu/drm/i915/i915_irq.c:3065:5-40: duplicated argument to or |
It's just a constant. It doesn't need to be there twice.
julia
vim +3065 drivers/gpu/drm/i915/i915_irq.c
e0e33f8f Imre Deak 2014-03-04 3059 static void
valleyview_display_irqs_uninstall(struct drm_i915_private *dev_priv)
e0e33f8f Imre Deak 2014-03-04 3060 {
e0e33f8f Imre Deak 2014-03-04 3061 u32 pipestat_mask;
e0e33f8f Imre Deak 2014-03-04 3062 u32 iir_mask;
e0e33f8f Imre Deak 2014-03-04 3063
e0e33f8f Imre Deak 2014-03-04 3064 iir_mask = I915_DISPLAY_PORT_INTERRUPT |
e0e33f8f Imre Deak 2014-03-04 @3065
I915_DISPLAY_PIPE_A_EVENT_INTERRUPT |
e0e33f8f Imre Deak 2014-03-04 3066
I915_DISPLAY_PIPE_A_EVENT_INTERRUPT;
e0e33f8f Imre Deak 2014-03-04 3067
e0e33f8f Imre Deak 2014-03-04 3068 dev_priv-irq_mask |= iir_mask;
e0e33f8f Imre Deak 2014-03-04 3069 I915_WRITE(VLV_IER,
~dev_priv-irq_mask);
e0e33f8f Imre Deak 2014-03-04 3070 I915_WRITE(VLV_IMR, dev_priv-irq_mask);
e0e33f8f Imre Deak 2014-03-04 3071 I915_WRITE(VLV_IIR, iir_mask);
e0e33f8f Imre Deak 2014-03-04 3072 I915_WRITE(VLV_IIR, iir_mask);
e0e33f8f Imre Deak 2014-03-04 3073 POSTING_READ(VLV_IIR);
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
Re: [kbuild] drivers/pwm/pwm-lp3943.c:85:1-6: WARNING: invalid free of devm_ allocated data
[CC author and committer]
On Sun, Mar 02, 2014 at 02:41:11PM +0100, Julia Lawall wrote:
This seems to be a false positive - there is another initialize and free
flow of control that is parallel to the probe function one that contains
the call to devm_kzalloc. On the other hand, the remove function of the
driver just calls the generic remove function defined in
drivers/pwm/core.c. The dataflow is somewhat complex, so I am not sure to
understand everything. But the developer could perhaps double check that
the devm allocated data does not end up in the argument of kfree in the
function free_pwms defined in drivers/pwm/core.c.
julia
On Sun, 2 Mar 2014, kbuild test robot wrote:
TO: Milo Kim milo@ti.com
CC: Lee Jones lee.jo...@linaro.org
Hi Milo,
FYI, there are coccinelle warnings in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 55de1ed2f597646c6c7f0bbe2da1680c760b0d40
commit: af66b3c0934e350059646651958306565313e145 pwm: Add LP3943 PWM driver
date: 6 weeks ago
:: branch date: 9 hours ago
:: commit date: 6 weeks ago
drivers/pwm/pwm-lp3943.c:85:1-6: WARNING: invalid free of devm_
allocated data
git remote add linus
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout af66b3c0934e350059646651958306565313e145
vim +85 drivers/pwm/pwm-lp3943.c
af66b3c0 Milo Kim 2013-12-06 69return PTR_ERR(pwm_map);
af66b3c0 Milo Kim 2013-12-06 70
af66b3c0 Milo Kim 2013-12-06 71return pwm_set_chip_data(pwm, pwm_map);
af66b3c0 Milo Kim 2013-12-06 72 }
af66b3c0 Milo Kim 2013-12-06 73
af66b3c0 Milo Kim 2013-12-06 74 static void lp3943_pwm_free_map(struct
lp3943_pwm *lp3943_pwm,
af66b3c0 Milo Kim 2013-12-06 75struct
lp3943_pwm_map *pwm_map)
af66b3c0 Milo Kim 2013-12-06 76 {
af66b3c0 Milo Kim 2013-12-06 77struct lp3943 *lp3943 =
lp3943_pwm-lp3943;
af66b3c0 Milo Kim 2013-12-06 78int i, offset;
af66b3c0 Milo Kim 2013-12-06 79
af66b3c0 Milo Kim 2013-12-06 80for (i = 0; i pwm_map-num_outputs;
i++) {
af66b3c0 Milo Kim 2013-12-06 81offset = pwm_map-output[i];
af66b3c0 Milo Kim 2013-12-06 82clear_bit(offset,
lp3943-pin_used);
af66b3c0 Milo Kim 2013-12-06 83}
af66b3c0 Milo Kim 2013-12-06 84
af66b3c0 Milo Kim 2013-12-06 @85kfree(pwm_map);
af66b3c0 Milo Kim 2013-12-06 86 }
af66b3c0 Milo Kim 2013-12-06 87
af66b3c0 Milo Kim 2013-12-06 88 static void lp3943_pwm_free(struct
pwm_chip *chip, struct pwm_device *pwm)
af66b3c0 Milo Kim 2013-12-06 89 {
af66b3c0 Milo Kim 2013-12-06 90struct lp3943_pwm *lp3943_pwm =
to_lp3943_pwm(chip);
af66b3c0 Milo Kim 2013-12-06 91struct lp3943_pwm_map *pwm_map =
pwm_get_chip_data(pwm);
af66b3c0 Milo Kim 2013-12-06 92
af66b3c0 Milo Kim 2013-12-06 93lp3943_pwm_free_map(lp3943_pwm,
pwm_map);
---
0-DAY kernel build testing backend Open Source Technology
Center
http://lists.01.org/mailman/listinfo/kbuild Intel
Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [kas:thp/pc/v7/p2-mmap 27/30] mm/huge_memory.c:1241 do_huge_pmd_wp_page() warn: inconsistent returns
Hi Kirill,
FYI, there are new smatch warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/kas/linux.git
thp/pc/v7/p2-mmap
head: f53193d553d85e8b00728b27429ea051ecfc5588
commit: 0ec0a16ada33dcda18a596df87326e0dbef2af6c [27/30] thp: handle
write-protect exception to file-backed huge pages
mm/huge_memory.c:1241 do_huge_pmd_wp_page() warn: inconsistent returns
spin_lock:ptl: locked (1149) unlocked (1156 [1], 1238 [s32min-s32max], 1238
[s32min-s32max], 1238 [s32min-s32max], 1241 [s32min-s32max], 1241 [0])
vim +1241 mm/huge_memory.c
71e3aac07 Andrea Arcangeli 2011-01-13 1143 ret |= VM_FAULT_WRITE;
71e3aac07 Andrea Arcangeli 2011-01-13 1144 goto out_unlock;
71e3aac07 Andrea Arcangeli 2011-01-13 1145 }
0ec0a16ad Kirill A. Shutemov 2013-03-13 1146
0ec0a16ad Kirill A. Shutemov 2013-03-13 1147 if ((vma-vm_flags
(VM_WRITE|VM_SHARED)) == (VM_WRITE|VM_SHARED)) {
0ec0a16ad Kirill A. Shutemov 2013-03-13 1148 pte_t __unused;
0ec0a16ad Kirill A. Shutemov 2013-03-13 @1149 return
do_wp_page_shared(mm, vma, address, pmd, page,
0ec0a16ad Kirill A. Shutemov 2013-03-13 1150 NULL,
ptl, __unused, orig_pmd);
0ec0a16ad Kirill A. Shutemov 2013-03-13 1151 }
71e3aac07 Andrea Arcangeli 2011-01-13 1152 get_page(page);
c4088ebdc Kirill A. Shutemov 2013-11-14 1153 spin_unlock(ptl);
93b4796de Kirill A. Shutemov 2012-12-12 1154 alloc:
0ec0a16ad Kirill A. Shutemov 2013-03-13 1155 if
(unlikely(anon_vma_prepare(vma)))
0ec0a16ad Kirill A. Shutemov 2013-03-13 1156 return VM_FAULT_OOM;
0ec0a16ad Kirill A. Shutemov 2013-03-13 1157
71e3aac07 Andrea Arcangeli 2011-01-13 1158 if
(transparent_hugepage_enabled(vma)
71e3aac07 Andrea Arcangeli 2011-01-13 1159
!transparent_hugepage_debug_cow())
0bbbc0b33 Andrea Arcangeli 2011-01-13 1160 new_page =
alloc_hugepage_vma(transparent_hugepage_defrag(vma),
cc5d462f7 Andi Kleen 2011-03-22 1161
vma, haddr, numa_node_id(), 0);
71e3aac07 Andrea Arcangeli 2011-01-13 1162 else
71e3aac07 Andrea Arcangeli 2011-01-13 1163 new_page = NULL;
71e3aac07 Andrea Arcangeli 2011-01-13 1164
71e3aac07 Andrea Arcangeli 2011-01-13 1165 if (unlikely(!new_page)) {
eecc1e426 Hugh Dickins 2014-01-12 1166 if (!page) {
93b4796de Kirill A. Shutemov 2012-12-12 1167 ret =
do_huge_pmd_wp_zero_page_fallback(mm, vma,
3ea41e621 Kirill A. Shutemov 2012-12-12 1168
address, pmd, orig_pmd, haddr);
93b4796de Kirill A. Shutemov 2012-12-12 1169 } else {
93b4796de Kirill A. Shutemov 2012-12-12 1170 ret =
do_huge_pmd_wp_page_fallback(mm, vma, address,
93b4796de Kirill A. Shutemov 2012-12-12 1171
pmd, orig_pmd, page, haddr);
93b4796de Kirill A. Shutemov 2012-12-12 1172 if (ret
VM_FAULT_OOM)
93b4796de Kirill A. Shutemov 2012-12-12 1173
split_huge_page(page);
93b4796de Kirill A. Shutemov 2012-12-12 1174 put_page(page);
93b4796de Kirill A. Shutemov 2012-12-12 1175 }
17766dde3 David Rientjes 2013-09-12 1176
count_vm_event(THP_FAULT_FALLBACK);
71e3aac07 Andrea Arcangeli 2011-01-13 1177 goto out;
71e3aac07 Andrea Arcangeli 2011-01-13 1178 }
71e3aac07 Andrea Arcangeli 2011-01-13 1179
b9bbfbe30 Andrea Arcangeli 2011-01-13 1180 if
(unlikely(mem_cgroup_newpage_charge(new_page, mm, GFP_KERNEL))) {
b9bbfbe30 Andrea Arcangeli 2011-01-13 1181 put_page(new_page);
93b4796de Kirill A. Shutemov 2012-12-12 1182 if (page) {
93b4796de Kirill A. Shutemov 2012-12-12 1183
split_huge_page(page);
93b4796de Kirill A. Shutemov 2012-12-12 1184 put_page(page);
93b4796de Kirill A. Shutemov 2012-12-12 1185 }
17766dde3 David Rientjes 2013-09-12 1186
count_vm_event(THP_FAULT_FALLBACK);
b9bbfbe30 Andrea Arcangeli 2011-01-13 1187 ret |= VM_FAULT_OOM;
b9bbfbe30 Andrea Arcangeli 2011-01-13 1188 goto out;
b9bbfbe30 Andrea Arcangeli 2011-01-13 1189 }
b9bbfbe30 Andrea Arcangeli 2011-01-13 1190
17766dde3 David Rientjes 2013-09-12 1191 count_vm_event(THP_FAULT_ALLOC);
17766dde3 David Rientjes 2013-09-12 1192
eecc1e426 Hugh Dickins 2014-01-12 1193 if (!page)
93b4796de Kirill A. Shutemov 2012-12-12 1194
clear_huge_page(new_page, haddr, HPAGE_PMD_NR);
93b4796de Kirill A. Shutemov 2012-12-12 1195 else
93b4796de Kirill A. Shutemov 2012-12-12 1196
copy_user_huge_page(new_page, page, haddr, vma, HPAGE_PMD_NR);
71e3aac07 Andrea Arcangeli 2011-01-13 1197 __SetPageUptodate(new_page);
71e3aac07 Andrea Arcangeli 2011-01-13 1198
2ec74c3ef Sagi Grimberg 2012-10-08 1199 mmun_start = haddr;
2ec74c3ef Sagi
[kbuild] [nouveau:drm-nouveau-next 62/68] drivers/gpu/drm/nouveau/nouveau_display.c:683:1-7: preceding lock on line 612
It looks like a bug, due to the following line:
bbc63196 Christian Engelmayer 2013-12-29 621 goto fail_free;
julia
tree: git://git.freedesktop.org/git/nouveau/linux-2.6 drm-nouveau-next
head: 1139ffb96b3f4e8be9006552d2dd4d302d62c2ee
commit: d5c1e84b3a130f0743b218b33ff7d9cb493ab5b4 [62/68] drm/nouveau: hold
mutex while syncing to kernel channel
drivers/gpu/drm/nouveau/nouveau_display.c:683:1-7: preceding lock on line 612
vim +683 drivers/gpu/drm/nouveau/nouveau_display.c
d5c1e84b Maarten Lankhorst2014-01-14 606 if (new_bo != old_bo) {
d5c1e84b Maarten Lankhorst2014-01-14 607 ret =
nouveau_bo_pin(new_bo, TTM_PL_FLAG_VRAM);
d5c1e84b Maarten Lankhorst2014-01-14 608 if (ret)
d5c1e84b Maarten Lankhorst2014-01-14 609 goto fail_free;
d5c1e84b Maarten Lankhorst2014-01-14 610 }
d5c1e84b Maarten Lankhorst2014-01-14 611
d5c1e84b Maarten Lankhorst2014-01-14 @612 mutex_lock(chan-cli-mutex);
d5c1e84b Maarten Lankhorst2014-01-14 613
eae389f9 Ben Skeggs 2013-11-13 614 /* synchronise rendering
channel with the kernel's channel */
eae389f9 Ben Skeggs 2013-11-13 615
spin_lock(new_bo-bo.bdev-fence_lock);
eae389f9 Ben Skeggs 2013-11-13 616 fence =
nouveau_fence_ref(new_bo-bo.sync_obj);
eae389f9 Ben Skeggs 2013-11-13 617
spin_unlock(new_bo-bo.bdev-fence_lock);
eae389f9 Ben Skeggs 2013-11-13 618 ret = nouveau_fence_sync(fence,
chan);
2fd04c81 Ben Skeggs 2013-11-21 619 nouveau_fence_unref(fence);
eae389f9 Ben Skeggs 2013-11-13 620 if (ret)
bbc63196 Christian Engelmayer 2013-12-29 621 goto fail_free;
b580c9e2 Maarten Lankhorst2013-06-27 622
07ad6ca0 Ben Skeggs 2013-11-13 623 ret =
ttm_bo_reserve(old_bo-bo, true, false, false, NULL);
060810d7 Ben Skeggs 2013-07-08 624 if (ret)
060810d7 Ben Skeggs 2013-07-08 625 goto fail_unpin;
b580c9e2 Maarten Lankhorst2013-06-27 626
b580c9e2 Maarten Lankhorst2013-06-27 627 /* Initialize a page flip
struct */
b580c9e2 Maarten Lankhorst2013-06-27 628 *s = (struct
nouveau_page_flip_state)
b580c9e2 Maarten Lankhorst2013-06-27 629 { { }, event,
nouveau_crtc(crtc)-index,
b580c9e2 Maarten Lankhorst2013-06-27 630 fb-bits_per_pixel,
fb-pitches[0], crtc-x, crtc-y,
b580c9e2 Maarten Lankhorst2013-06-27 631 new_bo-bo.offset };
b580c9e2 Maarten Lankhorst2013-06-27 632
332b242f Francisco Jerez 2010-10-20 633 /* Emit a page flip */
77145f1c Ben Skeggs 2012-07-31 634 if
(nv_device(drm-device)-card_type = NV_50) {
b9d9dcda Ben Skeggs 2013-11-11 635 ret =
nv50_display_flip_next(crtc, fb, chan, swap_interval);
060810d7 Ben Skeggs 2013-07-08 636 if (ret)
d7117e0d Ben Skeggs 2011-02-07 637 goto
fail_unreserve;
78ae0ad4 Ben Skeggs 2013-08-21 638 } else {
78ae0ad4 Ben Skeggs 2013-08-21 639 struct nv04_display
*dispnv04 = nv04_display(dev);
b9d9dcda Ben Skeggs 2013-11-11 640 int head =
nouveau_crtc(crtc)-index;
b9d9dcda Ben Skeggs 2013-11-11 641
b9d9dcda Ben Skeggs 2013-11-11 642 if (swap_interval) {
b9d9dcda Ben Skeggs 2013-11-11 643 ret =
RING_SPACE(chan, 8);
b9d9dcda Ben Skeggs 2013-11-11 644 if (ret)
b9d9dcda Ben Skeggs 2013-11-11 645 goto
fail_unreserve;
b9d9dcda Ben Skeggs 2013-11-11 646
b9d9dcda Ben Skeggs 2013-11-11 647
BEGIN_NV04(chan, NvSubImageBlit, 0x012c, 1);
b9d9dcda Ben Skeggs 2013-11-11 648 OUT_RING
(chan, 0);
b9d9dcda Ben Skeggs 2013-11-11 649
BEGIN_NV04(chan, NvSubImageBlit, 0x0134, 1);
b9d9dcda Ben Skeggs 2013-11-11 650 OUT_RING
(chan, head);
b9d9dcda Ben Skeggs 2013-11-11 651
BEGIN_NV04(chan, NvSubImageBlit, 0x0100, 1);
b9d9dcda Ben Skeggs 2013-11-11 652 OUT_RING
(chan, 0);
b9d9dcda Ben Skeggs 2013-11-11 653
BEGIN_NV04(chan, NvSubImageBlit, 0x0130, 1);
b9d9dcda Ben Skeggs 2013-11-11 654 OUT_RING
(chan, 0);
b9d9dcda Ben Skeggs 2013-11-11 655 }
b9d9dcda Ben Skeggs 2013-11-11 656
b9d9dcda Ben Skeggs 2013-11-11 657 nouveau_bo_ref(new_bo,
dispnv04-image[head]);
d7117e0d Ben Skeggs 2011-02-07 658 }
d7117e0d Ben Skeggs 2011-02-07 659
332b242f Francisco Jerez 2010-10-20 660 ret =
nouveau_page_flip_emit(chan, old_bo, new_bo, s, fence);
77145f1c Ben Skeggs 2012-07-31 661 mutex_unlock(chan-cli-mutex);
332b242f Francisco Jerez
[kbuild] [nfs:testing 27/27] fs/nfs/nfs4client.c:552:1-7: preceding lock on line 501
Hi Trond,
It looks like it would be worth checking. I don't know what the
intent is.
- julia
tree: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git testing
head: 58e6318220d4e3607922e01c897543a6bddd55e6
commit: 58e6318220d4e3607922e01c897543a6bddd55e6 [27/27] NFSv4.1: Handle errors
correctly in nfs41_walk_client_list
fs/nfs/nfs4client.c:552:1-7: preceding lock on line 501
vim +552 fs/nfs/nfs4client.c
7b1f1fd1 Trond Myklebust 2013-04-05 495
7b1f1fd1 Trond Myklebust 2013-04-05 496if (prev)
7b1f1fd1 Trond Myklebust 2013-04-05 497
nfs_put_client(prev);
7b1f1fd1 Trond Myklebust 2013-04-05 498prev = pos;
7b1f1fd1 Trond Myklebust 2013-04-05 499
7b1f1fd1 Trond Myklebust 2013-04-05 500status =
nfs_wait_client_init_complete(pos);
7b1f1fd1 Trond Myklebust 2013-04-05 @501
spin_lock(nn-nfs_client_lock);
7b1f1fd1 Trond Myklebust 2013-04-05 502if (status 0)
58e63182 Trond Myklebust 2014-01-17 503goto
out;
58e63182 Trond Myklebust 2014-01-17 504status =
-NFS4ERR_STALE_CLIENTID;
7b1f1fd1 Trond Myklebust 2013-04-05 505}
7b1f1fd1 Trond Myklebust 2013-04-05 506if (pos-cl_cons_state
!= NFS_CS_READY)
05f4c350 Chuck Lever 2012-09-14 507continue;
05f4c350 Chuck Lever 2012-09-14 508
05f4c350 Chuck Lever 2012-09-14 509if (pos-rpc_ops !=
new-rpc_ops)
05f4c350 Chuck Lever 2012-09-14 510continue;
05f4c350 Chuck Lever 2012-09-14 511
05f4c350 Chuck Lever 2012-09-14 512if (pos-cl_proto !=
new-cl_proto)
05f4c350 Chuck Lever 2012-09-14 513continue;
05f4c350 Chuck Lever 2012-09-14 514
05f4c350 Chuck Lever 2012-09-14 515if
(pos-cl_minorversion != new-cl_minorversion)
05f4c350 Chuck Lever 2012-09-14 516continue;
05f4c350 Chuck Lever 2012-09-14 517
05f4c350 Chuck Lever 2012-09-14 518if (pos-cl_clientid !=
new-cl_clientid)
05f4c350 Chuck Lever 2012-09-14 519continue;
05f4c350 Chuck Lever 2012-09-14 520
05f4c350 Chuck Lever 2012-09-14 521
atomic_inc(pos-cl_count);
05f4c350 Chuck Lever 2012-09-14 522
spin_unlock(nn-nfs_client_lock);
05f4c350 Chuck Lever 2012-09-14 523
05f4c350 Chuck Lever 2012-09-14 524if (prev)
05f4c350 Chuck Lever 2012-09-14 525
nfs_put_client(prev);
4ae19c2d Trond Myklebust 2013-01-18 526prev = pos;
05f4c350 Chuck Lever 2012-09-14 527
05f4c350 Chuck Lever 2012-09-14 528status =
nfs4_proc_setclientid_confirm(pos, clid, cred);
4ae19c2d Trond Myklebust 2013-01-18 529switch (status) {
4ae19c2d Trond Myklebust 2013-01-18 530case
-NFS4ERR_STALE_CLIENTID:
4ae19c2d Trond Myklebust 2013-01-18 531break;
4ae19c2d Trond Myklebust 2013-01-18 532case 0:
05f4c350 Chuck Lever 2012-09-14 533
nfs4_swap_callback_idents(pos, new);
05f4c350 Chuck Lever 2012-09-14 534
4ae19c2d Trond Myklebust 2013-01-18 535prev = NULL;
05f4c350 Chuck Lever 2012-09-14 536*result = pos;
05f4c350 Chuck Lever 2012-09-14 537dprintk(NFS:
-- %s using nfs_client = %p ({%d})\n,
05f4c350 Chuck Lever 2012-09-14 538
__func__, pos, atomic_read(pos-cl_count));
4ae19c2d Trond Myklebust 2013-01-18 539default:
4ae19c2d Trond Myklebust 2013-01-18 540goto out;
05f4c350 Chuck Lever 2012-09-14 541}
05f4c350 Chuck Lever 2012-09-14 542
05f4c350 Chuck Lever 2012-09-14 543
spin_lock(nn-nfs_client_lock);
05f4c350 Chuck Lever 2012-09-14 544}
4ae19c2d Trond Myklebust 2013-01-18 545
spin_unlock(nn-nfs_client_lock);
05f4c350 Chuck Lever 2012-09-14 546
202c312d Trond Myklebust 2013-01-18 547/* No match found. The server
lost our clientid */
4ae19c2d Trond Myklebust 2013-01-18 548 out:
05f4c350 Chuck Lever 2012-09-14 549if (prev)
05f4c350 Chuck Lever 2012-09-14 550nfs_put_client(prev);
4ae19c2d Trond Myklebust 2013-01-18 551dprintk(NFS: -- %s status =
%d\n, __func__, status);
4ae19c2d Trond Myklebust 2013-01-18 @552return status;
05f4c350 Chuck Lever 2012-09-14 553 }
05f4c350 Chuck Lever 2012-09-14 554
05f4c350 Chuck Lever 2012-09-14 555 #ifdef CONFIG_NFS_V4_1
---
0-DAY kernel build testing backend Open Source Technology Center
[kbuild] [nfc-next:master 16/19] drivers/nfc/nfcmrvl/main.c:100 nfcmrvl_nci_register_dev() warn: possible memory leak of 'priv'
TO: Amitkumar Karwar akar...@marvell.com
CC: Samuel Ortiz sa...@linux.intel.com
CC: Bing Zhao bz...@marvell.com
Hi Amitkumar,
FYI, there are new smatch warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/sameo/nfc-next.git master
head: b711ad524bf5a6a078c4d0a1a44ca1db204802f6
commit: f26e30cc6b50ba81e30ca3016c29ad4b48b93eaa [16/19] NFC: nfcmrvl: Initial
commit for Marvell NFC driver
:: branch date: 62 minutes ago
:: commit date: 18 hours ago
drivers/nfc/nfcmrvl/main.c:100 nfcmrvl_nci_register_dev() warn: possible memory
leak of 'priv'
git remote add nfc-next
git://git.kernel.org/pub/scm/linux/kernel/git/sameo/nfc-next.git
git remote update nfc-next
git checkout f26e30cc6b50ba81e30ca3016c29ad4b48b93eaa
vim +/priv +100 drivers/nfc/nfcmrvl/main.c
f26e30cc Amitkumar Karwar 2014-01-06 84 if (!priv)
f26e30cc Amitkumar Karwar 2014-01-06 85 return ERR_PTR(-ENOMEM);
f26e30cc Amitkumar Karwar 2014-01-06 86
f26e30cc Amitkumar Karwar 2014-01-06 87 priv-drv_data = drv_data;
f26e30cc Amitkumar Karwar 2014-01-06 88 priv-if_ops = ops;
f26e30cc Amitkumar Karwar 2014-01-06 89 priv-dev = dev;
f26e30cc Amitkumar Karwar 2014-01-06 90
f26e30cc Amitkumar Karwar 2014-01-06 91 protocols = NFC_PROTO_JEWEL_MASK
f26e30cc Amitkumar Karwar 2014-01-06 92 | NFC_PROTO_MIFARE_MASK
| NFC_PROTO_FELICA_MASK
f26e30cc Amitkumar Karwar 2014-01-06 93 |
NFC_PROTO_ISO14443_MASK
f26e30cc Amitkumar Karwar 2014-01-06 94 |
NFC_PROTO_ISO14443_B_MASK
f26e30cc Amitkumar Karwar 2014-01-06 95 |
NFC_PROTO_NFC_DEP_MASK;
f26e30cc Amitkumar Karwar 2014-01-06 96
f26e30cc Amitkumar Karwar 2014-01-06 97 priv-ndev =
nci_allocate_device(nfcmrvl_nci_ops, protocols, 0, 0);
f26e30cc Amitkumar Karwar 2014-01-06 98 if (!priv-ndev) {
f26e30cc Amitkumar Karwar 2014-01-06 99 nfc_err(dev,
nci_allocate_device failed);
f26e30cc Amitkumar Karwar 2014-01-06 @100 return ERR_PTR(-ENOMEM);
f26e30cc Amitkumar Karwar 2014-01-06 101 }
f26e30cc Amitkumar Karwar 2014-01-06 102
f26e30cc Amitkumar Karwar 2014-01-06 103 nci_set_drvdata(priv-ndev,
priv);
f26e30cc Amitkumar Karwar 2014-01-06 104
f26e30cc Amitkumar Karwar 2014-01-06 105 rc =
nci_register_device(priv-ndev);
f26e30cc Amitkumar Karwar 2014-01-06 106 if (rc) {
f26e30cc Amitkumar Karwar 2014-01-06 107 nfc_err(dev,
nci_register_device failed %d, rc);
f26e30cc Amitkumar Karwar 2014-01-06 108
nci_free_device(priv-ndev);
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [mmotm:master 57/301] fs/ocfs2/stack_user.c:938 get_protocol_version() warn: impossible condition '(pv.pv_minor 0) = (0-255 0)'
TO: Goldwyn Rodrigues rgold...@suse.de
CC: Johannes Weiner han...@cmpxchg.org
CC: Dan Carpenter dan.carpen...@oracle.com
CC: Andrew Morton a...@linux-foundation.org
Hi Goldwyn,
FYI, there are new smatch warnings show up in
tree: git://git.cmpxchg.org/linux-mmotm.git master
head: ea9a4ca49de541e9527af16c68714b73960e01ec
commit: 61017daffedfb2caf6eb990e136803d0e538ffb9 [57/301] ocfs2: use the new
DLM operation callbacks while requesting new lockspace
:: branch date: 10 hours ago
:: commit date: 10 hours ago
New smatch warnings:
fs/ocfs2/stack_user.c:938 get_protocol_version() warn: impossible condition
'(pv.pv_minor 0) = (0-255 0)'
Old smatch warnings:
fs/ocfs2/stack_user.c:392 ocfs2_control_do_setnode_msg() warn: impossible
condition '(nodenum ((~0 1))) = (s32min-s32max s32max)'
fs/ocfs2/stack_user.c:473 ocfs2_control_do_down_msg() warn: impossible
condition '(nodenum ((~0 1))) = (s32min-s32max s32max)'
git remote add mmotm git://git.cmpxchg.org/linux-mmotm.git
git remote update mmotm
git checkout 61017daffedfb2caf6eb990e136803d0e538ffb9
vim +938 fs/ocfs2/stack_user.c
61017daf Goldwyn Rodrigues 2013-12-16 922
ocfs2_user_plugin.sp_max_proto.pv_minor;
61017daf Goldwyn Rodrigues 2013-12-16 923
61017daf Goldwyn Rodrigues 2013-12-16 924 lc-oc_version_lksb.sb_lvbptr =
lc-oc_lvb;
61017daf Goldwyn Rodrigues 2013-12-16 925 ret = version_lock(conn,
DLM_LOCK_EX,
61017daf Goldwyn Rodrigues 2013-12-16 926
DLM_LKF_VALBLK|DLM_LKF_NOQUEUE);
61017daf Goldwyn Rodrigues 2013-12-16 927 if (!ret) {
61017daf Goldwyn Rodrigues 2013-12-16 928
conn-cc_version.pv_major = running_proto.pv_major;
61017daf Goldwyn Rodrigues 2013-12-16 929
conn-cc_version.pv_minor = running_proto.pv_minor;
61017daf Goldwyn Rodrigues 2013-12-16 930
version_to_lvb(running_proto, lc-oc_lvb);
61017daf Goldwyn Rodrigues 2013-12-16 931 version_lock(conn,
DLM_LOCK_PR, DLM_LKF_CONVERT|DLM_LKF_VALBLK);
61017daf Goldwyn Rodrigues 2013-12-16 932 } else if (ret == -EAGAIN) {
61017daf Goldwyn Rodrigues 2013-12-16 933 ret =
version_lock(conn, DLM_LOCK_PR, DLM_LKF_VALBLK);
61017daf Goldwyn Rodrigues 2013-12-16 934 if (ret)
61017daf Goldwyn Rodrigues 2013-12-16 935 goto out;
61017daf Goldwyn Rodrigues 2013-12-16 936
lvb_to_version(lc-oc_lvb, pv);
61017daf Goldwyn Rodrigues 2013-12-16 937
61017daf Goldwyn Rodrigues 2013-12-16 @938 if (pv.pv_minor 0) {
61017daf Goldwyn Rodrigues 2013-12-16 939 ret = -ERANGE;
61017daf Goldwyn Rodrigues 2013-12-16 940 goto out;
61017daf Goldwyn Rodrigues 2013-12-16 941 }
61017daf Goldwyn Rodrigues 2013-12-16 942 if ((pv.pv_major !=
running_proto.pv_major) ||
61017daf Goldwyn Rodrigues 2013-12-16 943
(pv.pv_minor running_proto.pv_minor)) {
61017daf Goldwyn Rodrigues 2013-12-16 944 ret = -EINVAL;
61017daf Goldwyn Rodrigues 2013-12-16 945 goto out;
61017daf Goldwyn Rodrigues 2013-12-16 946 }
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [congwang:tc-filter 1/1] net/sched/cls_api.c:204:1-20: iterator with update on line 212
TO: Cong Wang xiyou.wangc...@gmail.com
Hi Cong,
FYI, there are coccinelle warnings in
tree: git://github.com/congwang/linux.git tc-filter
head: a23c9ea150ab7ab963338fe53ebc023d94578c80
commit: a23c9ea150ab7ab963338fe53ebc023d94578c80 [1/1] sched: switch to
standard struct list_head
:: branch date: 9 days ago
:: commit date: 9 days ago
net/sched/cls_api.c:204:1-20: iterator with update on line 212
git remote add congwang git://github.com/congwang/linux.git
git remote update congwang
git checkout a23c9ea150ab7ab963338fe53ebc023d94578c80
vim +204 net/sched/cls_api.c
^1da177e Linus Torvalds 2005-04-16 198 chain = cops-tcf_chain(q, cl);
^1da177e Linus Torvalds 2005-04-16 199 err = -EINVAL;
^1da177e Linus Torvalds 2005-04-16 200 if (chain == NULL)
^1da177e Linus Torvalds 2005-04-16 201 goto errout;
^1da177e Linus Torvalds 2005-04-16 202
^1da177e Linus Torvalds 2005-04-16 203 /* Check the chain for
existence of proto-tcf with this priority */
a23c9ea1 Cong Wang 2013-12-06 @204 list_for_each_entry(tp, chain,
head) {
a23c9ea1 Cong Wang 2013-12-06 205 back =
list_next_entry(tp, head);
^1da177e Linus Torvalds 2005-04-16 206 if (tp-prio = prio) {
^1da177e Linus Torvalds 2005-04-16 207 if (tp-prio ==
prio) {
cc7ec456 Eric Dumazet 2011-01-19 208 if
(!nprio ||
cc7ec456 Eric Dumazet 2011-01-19 209
(tp-protocol != protocol protocol))
^1da177e Linus Torvalds 2005-04-16 210
goto errout;
^1da177e Linus Torvalds 2005-04-16 211 } else
^1da177e Linus Torvalds 2005-04-16 @212 tp =
NULL;
^1da177e Linus Torvalds 2005-04-16 213 break;
^1da177e Linus Torvalds 2005-04-16 214 }
^1da177e Linus Torvalds 2005-04-16 215 }
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [target:for-next 13/14] drivers/target/target_core_alua.c:473:32: sparse: dubious: !x y
TO: Hannes Reinecke h...@suse.de
Hi Hannes,
FYI, there are new sparse warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git
for-next
head: 31cf8df68491eb8bc2f07912e0e14f61e18f39fd
commit: 923aacab87ba24cc42b5c3ccd29b5ef769b46e12 [13/14] target_core_alua:
Referrals infrastructure
reproduce: make C=1 CF=-D__CHECK_ENDIAN__
:: branch date: 4 hours ago
:: commit date: 5 hours ago
drivers/target/target_core_alua.c:473:32: sparse: dubious: !x y
drivers/target/target_core_alua.c: In function
'core_alua_state_lba_dependent':
drivers/target/target_core_alua.c:473:6: warning: suggest parentheses around
operand of '!' or change '' to '' or '!' to '~' [-Wparentheses]
if (!cmd-se_cmd_flags SCF_SCSI_DATA_CDB)
^
git remote add target
git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git
git remote update target
git checkout 923aacab87ba24cc42b5c3ccd29b5ef769b46e12
vim +473 drivers/target/target_core_alua.c
c66ac9db Nicholas Bellinger 2010-12-17 457 */
c66ac9db Nicholas Bellinger 2010-12-17 458 cmd-se_cmd_flags |=
SCF_ALUA_NON_OPTIMIZED;
c66ac9db Nicholas Bellinger 2010-12-17 459 cmd-alua_nonop_delay =
nonop_delay_msecs;
c66ac9db Nicholas Bellinger 2010-12-17 460 return 0;
c66ac9db Nicholas Bellinger 2010-12-17 461 }
c66ac9db Nicholas Bellinger 2010-12-17 462
923aacab Hannes Reinecke2013-12-17 463 static inline int
core_alua_state_lba_dependent(
923aacab Hannes Reinecke2013-12-17 464 struct se_cmd *cmd,
923aacab Hannes Reinecke2013-12-17 465 struct t10_alua_tg_pt_gp
*tg_pt_gp,
923aacab Hannes Reinecke2013-12-17 466 u8 *alua_ascq)
923aacab Hannes Reinecke2013-12-17 467 {
923aacab Hannes Reinecke2013-12-17 468 struct se_device *dev =
cmd-se_dev;
923aacab Hannes Reinecke2013-12-17 469 u32 segment_size, segment_mult,
sectors;
923aacab Hannes Reinecke2013-12-17 470 u64 lba;
923aacab Hannes Reinecke2013-12-17 471
923aacab Hannes Reinecke2013-12-17 472 /* Only need to check for cdb
actually containing LBAs */
923aacab Hannes Reinecke2013-12-17 @473 if (!cmd-se_cmd_flags
SCF_SCSI_DATA_CDB)
923aacab Hannes Reinecke2013-12-17 474 return 0;
923aacab Hannes Reinecke2013-12-17 475
923aacab Hannes Reinecke2013-12-17 476
spin_lock(dev-t10_alua.lba_map_lock);
923aacab Hannes Reinecke2013-12-17 477 segment_size =
dev-t10_alua.lba_map_segment_size;
923aacab Hannes Reinecke2013-12-17 478 segment_mult =
dev-t10_alua.lba_map_segment_multiplier;
923aacab Hannes Reinecke2013-12-17 479 sectors = cmd-data_length /
dev-dev_attrib.block_size;
923aacab Hannes Reinecke2013-12-17 480
923aacab Hannes Reinecke2013-12-17 481 lba = cmd-t_task_lba;
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [cortex:dropmachtimexh-merged 4004/4263] fs/kernfs/dir.c:388:6: sparse: context imbalance in 'kernfs_addrm_start' - wrong count at exit
TO: Tejun Heo t...@kernel.org
CC: Greg Kroah-Hartman gre...@linuxfoundation.org
Hi Tejun,
FYI, there are new sparse warnings show up in
tree: git://git.pengutronix.de/git/ukl/linux-2.6.git dropmachtimexh-merged
head: ab679990ac95d4bdc48c4241944ebf91aed11359
commit: c637b8acbe079edb477d887041755b489036f146 [4004/4263] kernfs:
s/sysfs/kernfs/ in internal functions and whatever is left
reproduce: make C=1 CF=-D__CHECK_ENDIAN__
:: branch date: 4 hours ago
:: commit date: 2 days ago
fs/kernfs/dir.c:388:6: sparse: context imbalance in 'kernfs_addrm_start' -
wrong count at exit
fs/kernfs/dir.c:515:9: sparse: context imbalance in 'kernfs_addrm_finish' -
wrong count at exit
git remote add cortex git://git.pengutronix.de/git/ukl/linux-2.6.git
git remote update cortex
git checkout c637b8acbe079edb477d887041755b489036f146
vim +/kernfs_addrm_start +388 fs/kernfs/dir.c
fd7b9f7b9 Tejun Heo 2013-11-28 210 {
324a56e16 Tejun Heo 2013-12-11 211 if (kn) {
adc5e8b58 Tejun Heo 2013-12-11 212
WARN_ON(!atomic_read(kn-count));
adc5e8b58 Tejun Heo 2013-12-11 213 atomic_inc(kn-count);
fd7b9f7b9 Tejun Heo 2013-11-28 214 }
fd7b9f7b9 Tejun Heo 2013-11-28 215 }
fd7b9f7b9 Tejun Heo 2013-11-28 @216 EXPORT_SYMBOL_GPL(kernfs_get);
fd7b9f7b9 Tejun Heo 2013-11-28 217
fd7b9f7b9 Tejun Heo 2013-11-28 218 /**
324a56e16 Tejun Heo 2013-12-11 219 * kernfs_put - put a reference count on a
kernfs_node
324a56e16 Tejun Heo 2013-12-11 220 * @kn: the target kernfs_node
fd7b9f7b9 Tejun Heo 2013-11-28 221 *
324a56e16 Tejun Heo 2013-12-11 222 * Put a reference count of @kn and
destroy it if it reached zero.
fd7b9f7b9 Tejun Heo 2013-11-28 223 */
324a56e16 Tejun Heo 2013-12-11 224 void kernfs_put(struct kernfs_node *kn)
fd7b9f7b9 Tejun Heo 2013-11-28 225 {
324a56e16 Tejun Heo 2013-12-11 226 struct kernfs_node *parent;
ba7443bc6 Tejun Heo 2013-11-28 227 struct kernfs_root *root;
fd7b9f7b9 Tejun Heo 2013-11-28 228
adc5e8b58 Tejun Heo 2013-12-11 229 if (!kn ||
!atomic_dec_and_test(kn-count))
fd7b9f7b9 Tejun Heo 2013-11-28 230 return;
324a56e16 Tejun Heo 2013-12-11 231 root = kernfs_root(kn);
fd7b9f7b9 Tejun Heo 2013-11-28 232 repeat:
fd7b9f7b9 Tejun Heo 2013-11-28 233 /* Moving/renaming is always done while
holding reference.
adc5e8b58 Tejun Heo 2013-12-11 234 * kn-parent won't change beneath us.
fd7b9f7b9 Tejun Heo 2013-11-28 235 */
adc5e8b58 Tejun Heo 2013-12-11 236 parent = kn-parent;
fd7b9f7b9 Tejun Heo 2013-11-28 237
c637b8acb Tejun Heo 2013-12-11 238 WARN(!(kn-flags KERNFS_REMOVED),
kernfs: free using entry: %s/%s\n,
c637b8acb Tejun Heo 2013-12-11 239 parent ? parent-name : ,
kn-name);
324a56e16 Tejun Heo 2013-12-11 240
df23fc39b Tejun Heo 2013-12-11 241 if (kernfs_type(kn) == KERNFS_LINK)
adc5e8b58 Tejun Heo 2013-12-11 242
kernfs_put(kn-symlink.target_kn);
df23fc39b Tejun Heo 2013-12-11 243 if (kernfs_type(kn) KERNFS_COPY_NAME)
adc5e8b58 Tejun Heo 2013-12-11 244 kfree(kn-name);
adc5e8b58 Tejun Heo 2013-12-11 245 if (kn-iattr) {
adc5e8b58 Tejun Heo 2013-12-11 246 if (kn-iattr-ia_secdata)
adc5e8b58 Tejun Heo 2013-12-11 247
security_release_secctx(kn-iattr-ia_secdata,
adc5e8b58 Tejun Heo 2013-12-11 248
kn-iattr-ia_secdata_len);
adc5e8b58 Tejun Heo 2013-12-11 249
simple_xattrs_free(kn-iattr-xattrs);
2322392b0 Tejun Heo 2013-11-23 250 }
adc5e8b58 Tejun Heo 2013-12-11 251 kfree(kn-iattr);
adc5e8b58 Tejun Heo 2013-12-11 252 ida_simple_remove(root-ino_ida,
kn-ino);
a797bfc30 Tejun Heo 2013-12-11 253 kmem_cache_free(kernfs_node_cache, kn);
fd7b9f7b9 Tejun Heo 2013-11-28 254
324a56e16 Tejun Heo 2013-12-11 255 kn = parent;
324a56e16 Tejun Heo 2013-12-11 256 if (kn) {
adc5e8b58 Tejun Heo 2013-12-11 257 if
(atomic_dec_and_test(kn-count))
ba7443bc6 Tejun Heo 2013-11-28 258 goto repeat;
ba7443bc6 Tejun Heo 2013-11-28 259 } else {
324a56e16 Tejun Heo 2013-12-11 260 /* just released the root kn,
free @root too */
bc73d Tejun Heo 2013-11-28 261 ida_destroy(root-ino_ida);
ba7443bc6 Tejun Heo 2013-11-28 262 kfree(root);
ba7443bc6 Tejun Heo 2013-11-28 263 }
fd7b9f7b9 Tejun Heo 2013-11-28 264 }
fd7b9f7b9 Tejun Heo 2013-11-28 265 EXPORT_SYMBOL_GPL(kernfs_put);
fd7b9f7b9 Tejun Heo 2013-11-28 266
c637b8acb Tejun Heo 2013-12-11 267 static int kernfs_dop_delete(const struct
dentry *dentry)
fd7b9f7b9 Tejun Heo 2013-11-28 268 {
324a56e16 Tejun Heo 2013-12-11 269 struct kernfs_node *kn =
dentry-d_fsdata;
df23fc39b Tejun Heo 2013-12-11 270 return !(kn !(kn-flags
KERNFS_REMOVED));
fd7b9f7b9 Tejun Heo 2013-11-28 271 }
fd7b9f7b9 Tejun Heo 2013-11-28 272
c637b8acb Tejun Heo 2013-12-11 273 static int
[kbuild] [congwang:skb-list 14/15] net/sctp/ulpqueue.c:251 sctp_ulpq_tail_event() warn: variable dereferenced before check 'skb_head' (see line 202)
TO: Cong Wang xiyou.wangc...@gmail.com
Hi Cong,
FYI, there are new smatch warnings show up in
tree: git://github.com/congwang/linux.git skb-list
head: e7811ec4ea33fd15022c153a097a912688b41a88
commit: 9d6173771628f20a167b1be94a2d3fb0ef580c66 [14/15] fixup
:: branch date: 88 minutes ago
:: commit date: 89 minutes ago
net/sctp/ulpqueue.c:251 sctp_ulpq_tail_event() warn: variable dereferenced
before check 'skb_head' (see line 202)
net/sctp/ulpqueue.c:268 sctp_ulpq_tail_event() warn: variable dereferenced
before check 'skb_head' (see line 202)
git remote add congwang git://github.com/congwang/linux.git
git remote update congwang
git checkout 9d6173771628f20a167b1be94a2d3fb0ef580c66
vim +/skb_head +251 net/sctp/ulpqueue.c
9d617377 Cong Wang 2013-12-13 196struct sk_buff_head buf_list;
9d617377 Cong Wang 2013-12-13 197struct list_head *skb_head;
8728b834 David S. Miller 2005-08-09 198struct sk_buff *skb =
sctp_event2skb(event);
^1da177e Linus Torvalds 2005-04-16 199int clear_pd = 0;
^1da177e Linus Torvalds 2005-04-16 200
9d617377 Cong Wang 2013-12-13 201skb_head = skb-list.prev;
9d617377 Cong Wang 2013-12-13 @202buf_list.head = *skb_head;
^1da177e Linus Torvalds 2005-04-16 203/* If the socket is just going
to throw this away, do not
^1da177e Linus Torvalds 2005-04-16 204 * even try to deliver it.
^1da177e Linus Torvalds 2005-04-16 205 */
^1da177e Linus Torvalds 2005-04-16 206if (sock_flag(sk, SOCK_DEAD) ||
(sk-sk_shutdown RCV_SHUTDOWN))
^1da177e Linus Torvalds 2005-04-16 207goto out_free;
^1da177e Linus Torvalds 2005-04-16 208
^1da177e Linus Torvalds 2005-04-16 209/* Check if the user wishes to
receive this event. */
^1da177e Linus Torvalds 2005-04-16 210if
(!sctp_ulpevent_is_enabled(event, sctp_sk(sk)-subscribe))
^1da177e Linus Torvalds 2005-04-16 211goto out_free;
^1da177e Linus Torvalds 2005-04-16 212
^1da177e Linus Torvalds 2005-04-16 213/* If we are in partial
delivery mode, post to the lobby until
^1da177e Linus Torvalds 2005-04-16 214 * partial delivery is cleared,
unless, of course _this_ is
^1da177e Linus Torvalds 2005-04-16 215 * the association the cause of
the partial delivery.
^1da177e Linus Torvalds 2005-04-16 216 */
^1da177e Linus Torvalds 2005-04-16 217
b6e1331f Vlad Yasevich 2007-04-20 218if
(atomic_read(sctp_sk(sk)-pd_mode) == 0) {
^1da177e Linus Torvalds 2005-04-16 219queue =
sk-sk_receive_queue;
b6e1331f Vlad Yasevich 2007-04-20 220} else {
b6e1331f Vlad Yasevich 2007-04-20 221if (ulpq-pd_mode) {
b6e1331f Vlad Yasevich 2007-04-20 222/* If the
association is in partial delivery, we
b6e1331f Vlad Yasevich 2007-04-20 223 * need to
finish delivering the partially processed
b6e1331f Vlad Yasevich 2007-04-20 224 * packet
before passing any other data. This is
b6e1331f Vlad Yasevich 2007-04-20 225 * because we
don't truly support stream interleaving.
b6e1331f Vlad Yasevich 2007-04-20 226 */
b6e1331f Vlad Yasevich 2007-04-20 227if
((event-msg_flags MSG_NOTIFICATION) ||
b6e1331f Vlad Yasevich 2007-04-20 228
(SCTP_DATA_NOT_FRAG ==
b6e1331f Vlad Yasevich 2007-04-20 229
(event-msg_flags SCTP_DATA_FRAG_MASK)))
b6e1331f Vlad Yasevich 2007-04-20 230queue =
sctp_sk(sk)-pd_lobby;
b6e1331f Vlad Yasevich 2007-04-20 231else {
b6e1331f Vlad Yasevich 2007-04-20 232
clear_pd = event-msg_flags MSG_EOR;
b6e1331f Vlad Yasevich 2007-04-20 233queue =
sk-sk_receive_queue;
b6e1331f Vlad Yasevich 2007-04-20 234}
b6e1331f Vlad Yasevich 2007-04-20 235} else {
b6e1331f Vlad Yasevich 2007-04-20 236/*
b6e1331f Vlad Yasevich 2007-04-20 237 * If fragment
interleave is enabled, we
25985edc Lucas De Marchi 2011-03-30 238 * can queue
this to the receive queue instead
b6e1331f Vlad Yasevich 2007-04-20 239 * of the lobby.
b6e1331f Vlad Yasevich 2007-04-20 240 */
b6e1331f Vlad Yasevich 2007-04-20 241if
(sctp_sk(sk)-frag_interleave)
b6e1331f Vlad Yasevich 2007-04-20 242queue =
sk-sk_receive_queue;
b6e1331f Vlad Yasevich 2007-04-20 243else
b6e1331f Vlad Yasevich 2007-04-20 244queue =
sctp_sk(sk)-pd_lobby;
^1da177e Linus Torvalds 2005-04-16 245
[kbuild] [btrfs:for-linus 126/126] fs/btrfs/send.c:4725 btrfs_ioctl_send() warn: math in access_ok() is dangerous ' * arg-clone_sources_count'
TO: Dan Carpenter dan.carpen...@oracle.com
CC: Chris Mason chris.ma...@fusionio.com
Hi Dan,
FYI, there are new smatch warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git
for-linus
head: 700ff4f095d78af0998953e922e041d75254518b
commit: 700ff4f095d78af0998953e922e041d75254518b [126/126] Btrfs: fix
access_ok() check in btrfs_ioctl_send()
:: branch date: 2 hours ago
:: commit date: 2 hours ago
fs/btrfs/send.c:4725 btrfs_ioctl_send() warn: math in access_ok() is dangerous
' * arg-clone_sources_count'
git remote add btrfs
git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git
git remote update btrfs
git checkout 700ff4f095d78af0998953e922e041d75254518b
vim +4725 fs/btrfs/send.c
139f807a Josef Bacik 2013-05-20 4709 } else {
139f807a Josef Bacik 2013-05-20 4710 ret =
btrfs_commit_transaction(trans, send_root);
139f807a Josef Bacik 2013-05-20 4711 if (ret)
139f807a Josef Bacik 2013-05-20 4712 goto
out;
139f807a Josef Bacik 2013-05-20 4713 }
139f807a Josef Bacik 2013-05-20 4714 } else {
139f807a Josef Bacik 2013-05-20 4715
up_read(send_root-fs_info-extent_commit_sem);
139f807a Josef Bacik 2013-05-20 4716 }
139f807a Josef Bacik 2013-05-20 4717
31db9f7c Alexander Block 2012-07-25 4718 arg = memdup_user(arg_,
sizeof(*arg));
31db9f7c Alexander Block 2012-07-25 4719 if (IS_ERR(arg)) {
31db9f7c Alexander Block 2012-07-25 4720 ret = PTR_ERR(arg);
31db9f7c Alexander Block 2012-07-25 4721 arg = NULL;
31db9f7c Alexander Block 2012-07-25 4722 goto out;
31db9f7c Alexander Block 2012-07-25 4723 }
31db9f7c Alexander Block 2012-07-25 4724
31db9f7c Alexander Block 2012-07-25 @4725 if (!access_ok(VERIFY_READ,
arg-clone_sources,
700ff4f0 Dan Carpenter 2013-01-10 4726
sizeof(*arg-clone_sources) *
700ff4f0 Dan Carpenter 2013-01-10 4727
arg-clone_sources_count)) {
31db9f7c Alexander Block 2012-07-25 4728 ret = -EFAULT;
31db9f7c Alexander Block 2012-07-25 4729 goto out;
31db9f7c Alexander Block 2012-07-25 4730 }
31db9f7c Alexander Block 2012-07-25 4731
c2c71324 Stefan Behrens 2013-04-10 4732 if (arg-flags
~BTRFS_SEND_FLAG_MASK) {
cb95e7bf Mark Fasheh 2013-02-04 4733 ret = -EINVAL;
:: The code at line 4725 was first introduced by commit
:: 31db9f7c23fbf7e95026143f79645de6507b583b Btrfs: introduce BTRFS_IOC_SEND
for btrfs send/receive
:: TO: Alexander Block abloc...@googlemail.com
:: CC: Alexander Block abloc...@googlemail.com
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [net-next:master 82/83] drivers/net/wireless/rtlwifi/cam.c:328 rtl_cam_del_entry() error: we previously assumed 'sta_addr' could be null (see line 324)
TO: Joe Perches j...@perches.com
Hi Joe,
FYI, there are new smatch warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head: 5824d2d16d39a9c57aa3bacf955fbd0c2134061f
commit: 2c722fe1c821a100ca87fcc36e90a9bceb497c7c [82/83] etherdevice: Optimize
a few is_foo_ether_addr functions
:: branch date: 2 hours ago
:: commit date: 2 hours ago
drivers/net/wireless/rtlwifi/cam.c:328 rtl_cam_del_entry() error: we previously
assumed 'sta_addr' could be null (see line 324)
git remote add net-next
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
git remote update net-next
git checkout 2c722fe1c821a100ca87fcc36e90a9bceb497c7c
vim +/sta_addr +328 drivers/net/wireless/rtlwifi/cam.c
46a6272c Chaoming_Li 2011-04-25 318 void rtl_cam_del_entry(struct
ieee80211_hw *hw, u8 *sta_addr)
46a6272c Chaoming_Li 2011-04-25 319 {
46a6272c Chaoming_Li 2011-04-25 320struct rtl_priv *rtlpriv = rtl_priv(hw);
46a6272c Chaoming_Li 2011-04-25 321u32 bitmap;
46a6272c Chaoming_Li 2011-04-25 322u8 i, *addr;
46a6272c Chaoming_Li 2011-04-25 323
46a6272c Chaoming_Li 2011-04-25 @324if (NULL == sta_addr) {
f30d7507 Joe Perches 2012-01-04 325RT_TRACE(rtlpriv, COMP_SEC,
DBG_EMERG, sta_addr is NULL\n);
46a6272c Chaoming_Li 2011-04-25 326}
46a6272c Chaoming_Li 2011-04-25 327
68e052d5 Joe Perches 2012-03-17 @328if (is_zero_ether_addr(sta_addr)) {
46a6272c Chaoming_Li 2011-04-25 329RT_TRACE(rtlpriv, COMP_SEC,
DBG_EMERG,
68e052d5 Joe Perches 2012-03-17 330 sta_addr is %pM\n,
sta_addr);
46a6272c Chaoming_Li 2011-04-25 331return;
:: The code at line 328 was first introduced by commit
:: 68e052d500b7dea51beb6252a73293b62c5de035 rtlwifi: Use
is_zero_ether_addr, remove line continuation
:: TO: Joe Perches j...@perches.com
:: CC: John W. Linville linvi...@tuxdriver.com
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [wireless-next:master 86/110] drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:570 rtl92c_dm_dig() warn: add some parenthesis here?
TO: Larry Finger larry.fin...@lwfinger.net
CC: John W. Linville linvi...@tuxdriver.com
Hi Larry,
FYI, there are new smatch warnings show up in
tree:
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next.git master
head: e08fd975bf26aa8063cadd245817e042f570472d
commit: 796e453436b183057e2d7d9b2bcff88d0bf53ba7 [86/110] rtlwifi: rtl8192c:
Update dynamic gain calculations
:: branch date: 2 days ago
:: commit date: 2 days ago
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:570 rtl92c_dm_dig() warn: add
some parenthesis here?
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:570 rtl92c_dm_dig() warn:
maybe use instead of
git remote add wireless-next
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next.git
git remote update wireless-next
git checkout 796e453436b183057e2d7d9b2bcff88d0bf53ba7
vim +570 drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
796e4534 Larry Finger 2013-11-18 554 dm_digtable-curmultista_cstate =
DIG_MULTISTA_DISCONNECT;
796e4534 Larry Finger 2013-11-18 555
8c96fcf7 Larry Finger 2011-02-11 556 rtl92c_dm_initial_gain_sta(hw);
8c96fcf7 Larry Finger 2011-02-11 557 rtl92c_dm_initial_gain_multi_sta(hw);
8c96fcf7 Larry Finger 2011-02-11 558
rtl92c_dm_cck_packet_detection_thresh(hw);
8c96fcf7 Larry Finger 2011-02-11 559
da17fcff Larry Finger 2012-10-25 560 dm_digtable-presta_cstate =
dm_digtable-cursta_cstate;
8c96fcf7 Larry Finger 2011-02-11 561
8c96fcf7 Larry Finger 2011-02-11 562 }
8c96fcf7 Larry Finger 2011-02-11 563
8c96fcf7 Larry Finger 2011-02-11 564 static void rtl92c_dm_dig(struct
ieee80211_hw *hw)
8c96fcf7 Larry Finger 2011-02-11 565 {
8c96fcf7 Larry Finger 2011-02-11 566 struct rtl_priv *rtlpriv = rtl_priv(hw);
8c96fcf7 Larry Finger 2011-02-11 567
7ea47240 Larry Finger 2011-02-19 568 if (rtlpriv-dm.dm_initialgain_enable
== false)
8c96fcf7 Larry Finger 2011-02-11 569 return;
796e4534 Larry Finger 2013-11-18 @570 if (!rtlpriv-dm.dm_flag
DYNAMIC_FUNC_DIG)
8c96fcf7 Larry Finger 2011-02-11 571 return;
8c96fcf7 Larry Finger 2011-02-11 572
8c96fcf7 Larry Finger 2011-02-11 573 rtl92c_dm_ctrl_initgain_by_twoport(hw);
8c96fcf7 Larry Finger 2011-02-11 574 }
8c96fcf7 Larry Finger 2011-02-11 575
8c96fcf7 Larry Finger 2011-02-11 576 static void
rtl92c_dm_init_dynamic_txpower(struct ieee80211_hw *hw)
8c96fcf7 Larry Finger 2011-02-11 577 {
8c96fcf7 Larry Finger 2011-02-11 578 struct rtl_priv *rtlpriv = rtl_priv(hw);
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [linuxtv-media:master 486/499] drivers/media/media-entity.c:238:17: sparse: Variable length array is used.
TO: Sakari Ailus sakari.ai...@iki.fi
CC: Mauro Carvalho Chehab m.che...@samsung.com
CC: Laurent Pinchart laurent.pinch...@ideasonboard.com
Hi Sakari,
FYI, there are new sparse warnings show up in
tree: git://linuxtv.org/media_tree.git master
head: 3f823e094b935c1882605f8720336ee23433a16d
commit: de49c285a3604955dcbf746edd871f2a4f128122 [486/499] [media] media: Check
for active links on pads with MEDIA_PAD_FL_MUST_CONNECT flag
reproduce: make C=1 CF=-D__CHECK_ENDIAN__
:: branch date: 56 minutes ago
:: commit date: 2 hours ago
drivers/media/media-entity.c:80:1: sparse: symbol
'__ksymtab_media_entity_init' was not declared. Should it be static?
drivers/media/media-entity.c:87:1: sparse: symbol
'__ksymtab_media_entity_cleanup' was not declared. Should it be static?
drivers/media/media-entity.c:151:1: sparse: symbol
'__ksymtab_media_entity_graph_walk_start' was not declared. Should it be static?
drivers/media/media-entity.c:205:1: sparse: symbol
'__ksymtab_media_entity_graph_walk_next' was not declared. Should it be static?
drivers/media/media-entity.c:238:17: sparse: Variable length array is used.
drivers/media/media-entity.c:239:17: sparse: Variable length array is used.
drivers/media/media-entity.c:323:1: sparse: symbol
'__ksymtab_media_entity_pipeline_start' was not declared. Should it be static?
drivers/media/media-entity.c:354:1: sparse: symbol
'__ksymtab_media_entity_pipeline_stop' was not declared. Should it be static?
drivers/media/media-entity.c:381:1: sparse: symbol
'__ksymtab_media_entity_get' was not declared. Should it be static?
drivers/media/media-entity.c:399:1: sparse: symbol
'__ksymtab_media_entity_put' was not declared. Should it be static?
drivers/media/media-entity.c:465:1: sparse: symbol
'__ksymtab_media_entity_create_link' was not declared. Should it be static?
drivers/media/media-entity.c:503:1: sparse: symbol
'__ksymtab___media_entity_remove_links' was not declared. Should it be static?
drivers/media/media-entity.c:515:1: sparse: symbol
'__ksymtab_media_entity_remove_links' was not declared. Should it be static?
drivers/media/media-entity.c:609:1: sparse: symbol
'__ksymtab_media_entity_setup_link' was not declared. Should it be static?
drivers/media/media-entity.c:637:1: sparse: symbol
'__ksymtab_media_entity_find_link' was not declared. Should it be static?
drivers/media/media-entity.c:669:1: sparse: symbol
'__ksymtab_media_entity_remote_pad' was not declared. Should it be static?
git remote add linuxtv-media git://linuxtv.org/media_tree.git
git remote update linuxtv-media
git checkout de49c285a3604955dcbf746edd871f2a4f128122
vim +238 drivers/media/media-entity.c
53e269c1 Laurent Pinchart 2009-12-09 74 pads[i].entity = entity;
53e269c1 Laurent Pinchart 2009-12-09 75 pads[i].index = i;
53e269c1 Laurent Pinchart 2009-12-09 76 }
53e269c1 Laurent Pinchart 2009-12-09 77
53e269c1 Laurent Pinchart 2009-12-09 78 return 0;
53e269c1 Laurent Pinchart 2009-12-09 79 }
53e269c1 Laurent Pinchart 2009-12-09 @80 EXPORT_SYMBOL_GPL(media_entity_init);
53e269c1 Laurent Pinchart 2009-12-09 81
53e269c1 Laurent Pinchart 2009-12-09 82 void
53e269c1 Laurent Pinchart 2009-12-09 83 media_entity_cleanup(struct
media_entity *entity)
53e269c1 Laurent Pinchart 2009-12-09 84 {
53e269c1 Laurent Pinchart 2009-12-09 85 kfree(entity-links);
53e269c1 Laurent Pinchart 2009-12-09 86 }
53e269c1 Laurent Pinchart 2009-12-09 87
EXPORT_SYMBOL_GPL(media_entity_cleanup);
53e269c1 Laurent Pinchart 2009-12-09 88
a5ccc48a Sakari Ailus 2010-03-07 89 /*
-
a5ccc48a Sakari Ailus 2010-03-07 90 * Graph traversal
a5ccc48a Sakari Ailus 2010-03-07 91 */
a5ccc48a Sakari Ailus 2010-03-07 92
a5ccc48a Sakari Ailus 2010-03-07 93 static struct media_entity *
a5ccc48a Sakari Ailus 2010-03-07 94 media_entity_other(struct
media_entity *entity, struct media_link *link)
a5ccc48a Sakari Ailus 2010-03-07 95 {
a5ccc48a Sakari Ailus 2010-03-07 96 if (link-source-entity ==
entity)
a5ccc48a Sakari Ailus 2010-03-07 97 return
link-sink-entity;
a5ccc48a Sakari Ailus 2010-03-07 98 else
a5ccc48a Sakari Ailus 2010-03-07 99 return
link-source-entity;
a5ccc48a Sakari Ailus 2010-03-07 100 }
a5ccc48a Sakari Ailus 2010-03-07 101
a5ccc48a Sakari Ailus 2010-03-07 102 /* push an entity to traversal stack
*/
a5ccc48a Sakari Ailus 2010-03-07 103 static void stack_push(struct
media_entity_graph *graph,
a5ccc48a Sakari Ailus 2010-03-07 104 struct
media_entity *entity)
a5ccc48a Sakari Ailus 2010-03-07 105 {
a5ccc48a Sakari Ailus 2010-03-07 106 if (graph-top ==
MEDIA_ENTITY_ENUM_MAX_DEPTH - 1) {
a5ccc48a Sakari Ailus 2010-03-07 107
[kbuild] [xhci:for-usb-next-queue 24/114] drivers/usb/storage/uas.c:97:13: sparse: context imbalance in 'uas_unlink_data_urbs' - unexpected unlock
TO: Hans de Goede hdego...@redhat.com
Hi Hans,
FYI, there are new sparse warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git
for-usb-next-queue
head: 9efbd3928c794930d8208c8f9c9de288116dc93a
commit: dce5c24711247bc2b904114a63f6973e59dce735 [24/114] uas: Avoid
unnecessary unlock / lock calls around unlink_data_urbs
reproduce: make C=1 CF=-D__CHECK_ENDIAN__
:: branch date: 26 hours ago
:: commit date: 2 weeks ago
drivers/usb/storage/uas.c:97:13: sparse: context imbalance in
'uas_unlink_data_urbs' - unexpected unlock
git remote add xhci git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git
git remote update xhci
git checkout dce5c24711247bc2b904114a63f6973e59dce735
vim +/uas_unlink_data_urbs +97 drivers/usb/storage/uas.c
115bb1ff Matthew Wilcox 2010-10-07 81 struct urb *data_in_urb;
115bb1ff Matthew Wilcox 2010-10-07 82 struct urb *data_out_urb;
20587806 Gerd Hoffmann 2013-09-13 83 struct list_head work;
ffaffbf2 Gerd Hoffmann 2013-09-13 84 struct list_head dead;
115bb1ff Matthew Wilcox 2010-10-07 85 };
115bb1ff Matthew Wilcox 2010-10-07 86
115bb1ff Matthew Wilcox 2010-10-07 87 /* I hate forward declarations, but I
actually have a loop */
115bb1ff Matthew Wilcox 2010-10-07 88 static int uas_submit_urbs(struct
scsi_cmnd *cmnd,
115bb1ff Matthew Wilcox 2010-10-07 89 struct
uas_dev_info *devinfo, gfp_t gfp);
ea9da1c7 Sarah Sharp2011-12-02 90 static void uas_do_work(struct
work_struct *work);
4c456971 Gerd Hoffmann 2012-11-30 91 static int uas_try_complete(struct
scsi_cmnd *cmnd, const char *caller);
b4470f51 Gerd Hoffmann 2013-09-13 92 static void
uas_configure_endpoints(struct uas_dev_info *devinfo);
b4470f51 Gerd Hoffmann 2013-09-13 93 static void uas_free_streams(struct
uas_dev_info *devinfo);
ffaffbf2 Gerd Hoffmann 2013-09-13 94 static void uas_log_cmd_state(struct
scsi_cmnd *cmnd, const char *caller);
115bb1ff Matthew Wilcox 2010-10-07 95
dce5c247 Hans de Goede 2013-10-17 96 /* Must be called with devinfo-lock
held, will temporary unlock the lock */
aa8f6123 Gerd Hoffmann 2012-11-30 @97 static void
uas_unlink_data_urbs(struct uas_dev_info *devinfo,
dce5c247 Hans de Goede 2013-10-17 98 struct
uas_cmd_info *cmdinfo,
dce5c247 Hans de Goede 2013-10-17 99
unsigned long *lock_flags)
aa8f6123 Gerd Hoffmann 2012-11-30 100 {
b06e48af Gerd Hoffmann 2012-11-30 101 /*
b06e48af Gerd Hoffmann 2012-11-30 102 * The UNLINK_DATA_URBS flag
makes sure uas_try_complete
b06e48af Gerd Hoffmann 2012-11-30 103 * (called by urb completion)
doesn't release cmdinfo
b06e48af Gerd Hoffmann 2012-11-30 104 * underneath us.
b06e48af Gerd Hoffmann 2012-11-30 105 */
:: The code at line 97 was first introduced by commit:
:: aa8f612 uas: new function to cancel data urbs
:: TO: Gerd Hoffmann kra...@redhat.com
:: CC: Greg Kroah-Hartman gre...@linuxfoundation.org
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [xhci:for-usb-next-queue 1/3] drivers/usb/core/hub.c:4324 hub_port_init() warn: possible memory leak of 'buf'
TO: Dan Williams dan.j.willi...@intel.com
CC: Sarah Sharp sarah.a.sh...@linux.intel.com
Hi Dan,
FYI, there are new smatch warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git
for-usb-next-queue
head: efc18c9c490303deed1e39c12a54cc41290a20ca
commit: 1e6ed41e7e296928c380edba3f710c65f7ddb50d [1/3] usb: xhci: change
enumeration scheme to 'new scheme' by default
:: branch date: 58 minutes ago
:: commit date: 30 hours ago
drivers/usb/core/hub.c:4324 hub_port_init() warn: possible memory leak of 'buf'
git remote add xhci git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git
git remote update xhci
git checkout 1e6ed41e7e296928c380edba3f710c65f7ddb50d
vim +/buf +4324 drivers/usb/core/hub.c
d9b2099c Sarah Sharp 2012-02-20 4308
udev-lpm_capable = usb_device_supports_lpm(udev);
51e0a012 Sarah Sharp 2012-02-20 4309
usb_set_lpm_parameters(udev);
51e0a012 Sarah Sharp 2012-02-20 4310 }
1ff4df56 Andiry Xu2011-09-23 4311 }
3148bf04 Andiry Xu2011-09-23 4312
^1da177e Linus Torvalds 2005-04-16 4313 retval = 0;
48f24970 Alek Du 2010-06-04 4314 /* notify HCD that we have a
device connected and addressed */
48f24970 Alek Du 2010-06-04 4315 if (hcd-driver-update_device)
48f24970 Alek Du 2010-06-04 4316
hcd-driver-update_device(hcd, udev);
890dae88 Mathias Nyman2013-09-30 4317
hub_set_initial_usb2_lpm_policy(udev);
^1da177e Linus Torvalds 2005-04-16 4318 fail:
4326ed0b Alan Stern 2007-07-30 4319 if (retval) {
^1da177e Linus Torvalds 2005-04-16 4320 hub_port_disable(hub,
port1, 0);
3b29b68b Alan Stern 2011-02-22 4321 update_devnum(udev,
devnum);/* for disconnect processing */
4326ed0b Alan Stern 2007-07-30 4322 }
4186ecf8 Arjan van de Ven 2006-01-11 4323
mutex_unlock(usb_address0_mutex);
^1da177e Linus Torvalds 2005-04-16 @4324 return retval;
^1da177e Linus Torvalds 2005-04-16 4325 }
^1da177e Linus Torvalds 2005-04-16 4326
^1da177e Linus Torvalds 2005-04-16 4327 static void
^1da177e Linus Torvalds 2005-04-16 4328 check_highspeed (struct usb_hub
*hub, struct usb_device *udev, int port1)
^1da177e Linus Torvalds 2005-04-16 4329 {
^1da177e Linus Torvalds 2005-04-16 4330 struct usb_qualifier_descriptor
*qual;
^1da177e Linus Torvalds 2005-04-16 4331 int
status;
^1da177e Linus Torvalds 2005-04-16 4332
:: The code at line 4324 was first introduced by commit:
:: 1da177e Linux-2.6.12-rc2
:: TO: Linus Torvalds torva...@ppc970.osdl.org
:: CC: Linus Torvalds torva...@ppc970.osdl.org
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [wireless-next:master 33/59] drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c:1393:2-56: code aligned with following code on line 1394
TO: Hante Meuleman meule...@broadcom.com
CC: John W. Linville linvi...@tuxdriver.com
CC: Arend van Spriel ar...@broadcom.com
Hi Hante,
FYI, there are coccinelle warnings in
tree:
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next.git master
head: 4b074b07625f603d40d4d04937f8874a00415dc4
commit: 1e86d69662d7d86360624f74bbe1b5fa1b8ffb13 [33/59] brcmfmac: Update
fwsignal to fix out of order tx.
:: branch date: 49 minutes ago
:: commit date: 49 minutes ago
drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c:1393:2-56: code aligned
with following code on line 1394
git remote add wireless-next
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next.git
git remote update wireless-next
git checkout 1e86d69662d7d86360624f74bbe1b5fa1b8ffb13
vim +1393 drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
84bcc0c3 Arend van Spriel 2013-04-03 1387 }
84bcc0c3 Arend van Spriel 2013-04-03 1388
84bcc0c3 Arend van Spriel 2013-04-03 1389 entry-generation = genbit;
84bcc0c3 Arend van Spriel 2013-04-03 1390
2747e5f7 Hante Meuleman 2013-06-06 1391 ret =
brcmf_proto_hdrpull(fws-drvr, false, ifidx, skb);
2747e5f7 Hante Meuleman 2013-06-06 1392 if (ret == 0)
1e86d696 Hante Meuleman 2013-11-29 @1393
brcmf_skb_htod_tag_set_field(skb, GENERATION, genbit);
1e86d696 Hante Meuleman 2013-11-29 @1394
brcmf_skbcb(skb)-htod_seq = seq;
1e86d696 Hante Meuleman 2013-11-29 1395 if
(brcmf_skb_htod_seq_get_field(skb, FROMFW)) {
1e86d696 Hante Meuleman 2013-11-29 1396
brcmf_skb_htod_seq_set_field(skb, FROMDRV, 1);
1e86d696 Hante Meuleman 2013-11-29 1397
brcmf_skb_htod_seq_set_field(skb, FROMFW, 0);
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [scsi:misc 44/45] drivers/scsi/scsi_sysfs.c:312 store_shost_eh_deadline() warn: impossible condition '(deadline * 250 (~0)) = (0-u32max u32max)'
TO: Ren Mingxin re...@cn.fujitsu.com
CC: James Bottomley jbottom...@parallels.com
CC: Hannes Reinecke h...@suse.de
Hi Ren,
FYI, there are new smatch warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc
head: d9aa722cd2a0cf694b9eed8212a0e62212606a8f
commit: 6b3c67e6499b961038d53164e86684c8e770b4fb [44/45] [SCSI] Set the minimum
valid value of 'eh_deadline' as 0
:: branch date: 2 days ago
:: commit date: 2 days ago
New smatch warnings:
drivers/scsi/scsi_sysfs.c:312 store_shost_eh_deadline() warn: impossible
condition '(deadline * 250 (~0)) = (0-u32max u32max)'
Old smatch warnings:
drivers/scsi/scsi_sysfs.c:87 check_set() error: strncmp() '-' too small (2 vs
20)
git remote add scsi git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git
git remote update scsi
git checkout 6b3c67e6499b961038d53164e86684c8e770b4fb
vim +312 drivers/scsi/scsi_sysfs.c
b4562022 Hannes Reinecke 2013-10-23 296 store_shost_eh_deadline(struct device
*dev, struct device_attribute *attr,
b4562022 Hannes Reinecke 2013-10-23 297const char *buf, size_t
count)
b4562022 Hannes Reinecke 2013-10-23 298 {
b4562022 Hannes Reinecke 2013-10-23 299struct Scsi_Host *shost =
class_to_shost(dev);
b4562022 Hannes Reinecke 2013-10-23 300int ret = -EINVAL;
6b3c67e6 Ren Mingxin 2013-11-11 301unsigned long deadline, flags;
b4562022 Hannes Reinecke 2013-10-23 302
b4562022 Hannes Reinecke 2013-10-23 303if (shost-transportt
shost-transportt-eh_strategy_handler)
b4562022 Hannes Reinecke 2013-10-23 304return ret;
b4562022 Hannes Reinecke 2013-10-23 305
6b3c67e6 Ren Mingxin 2013-11-11 306if (!strncmp(buf, off,
strlen(off)))
6b3c67e6 Ren Mingxin 2013-11-11 307deadline = -1;
6b3c67e6 Ren Mingxin 2013-11-11 308else {
6b3c67e6 Ren Mingxin 2013-11-11 309ret = kstrtoul(buf, 10,
deadline);
6b3c67e6 Ren Mingxin 2013-11-11 310if (ret)
6b3c67e6 Ren Mingxin 2013-11-11 311return ret;
6b3c67e6 Ren Mingxin 2013-11-11 @312if (deadline * HZ
UINT_MAX)
6b3c67e6 Ren Mingxin 2013-11-11 313return -EINVAL;
6b3c67e6 Ren Mingxin 2013-11-11 314}
6b3c67e6 Ren Mingxin 2013-11-11 315
6b3c67e6 Ren Mingxin 2013-11-11 316
spin_lock_irqsave(shost-host_lock, flags);
6b3c67e6 Ren Mingxin 2013-11-11 317if
(scsi_host_in_recovery(shost))
6b3c67e6 Ren Mingxin 2013-11-11 318ret = -EBUSY;
6b3c67e6 Ren Mingxin 2013-11-11 319else {
6b3c67e6 Ren Mingxin 2013-11-11 320if (deadline == -1)
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [staging:opw-next 264/499] drivers/staging/ft1000/ft1000-usb/ft1000_hw.c:1151 ft1000_proc_drvmsg() warn: returning -1 instead of -ENOMEM is sloppy
TO: Kelley Nielsen kelley...@gmail.com
CC: Greg Kroah-Hartman gre...@linuxfoundation.org
Hi Kelley,
FYI, there are new smatch warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
opw-next
head: 4f317748f2660cb62bcf43aac368aa42dbeb2b78
commit: 46d981557b7429b2d03c56634f11cffe5cd8ed97 [264/499] staging: ft1000:
STATUS defines completely removed
:: branch date: 11 days ago
:: commit date: 3 weeks ago
New smatch warnings:
drivers/staging/ft1000/ft1000-usb/ft1000_hw.c:1151 ft1000_proc_drvmsg() warn:
returning -1 instead of -ENOMEM is sloppy
Old smatch warnings:
drivers/staging/ft1000/ft1000-usb/ft1000_hw.c:543 ft1000_copy_down_pkt() error:
usb_fill_bulk_urb() 'pFt1000Dev-tx_buf' too small (4096 vs 4100)
git remote add staging
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
git remote update staging
git checkout 46d981557b7429b2d03c56634f11cffe5cd8ed97
vim +1151 drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
6d2b6721 Marek Belisko 2011-03-10 1135u16 msgtype;
6d2b6721 Marek Belisko 2011-03-10 1136u16 tempword;
1b8a3012 Marek Belisko 2010-10-15 1137struct media_msg *pmediamsg;
369e857e Marek Belisko 2010-10-15 1138struct dsp_init_msg
*pdspinitmsg;
e09aee2a Marek Belisko 2010-10-15 1139struct drv_msg *pdrvmsg;
6d2b6721 Marek Belisko 2011-03-10 1140u16 i;
b13e39b2 Marek Belisko 2010-10-15 1141struct pseudo_hdr *ppseudo_hdr;
6d2b6721 Marek Belisko 2011-03-10 1142u16 *pmsg;
46d98155 Kelley Nielsen 2013-10-30 1143int status;
6d2b6721 Marek Belisko 2011-03-10 1144union {
6d2b6721 Marek Belisko 2011-03-10 1145u8 byte[2];
6d2b6721 Marek Belisko 2011-03-10 1146u16 wrd;
6d2b6721 Marek Belisko 2011-03-10 1147} convert;
f7c1be0c Marek Belisko 2010-09-22 1148
6d2b6721 Marek Belisko 2011-03-10 1149char *cmdbuffer = kmalloc(1600,
GFP_KERNEL);
6d2b6721 Marek Belisko 2011-03-10 1150if (!cmdbuffer)
46d98155 Kelley Nielsen 2013-10-30 @1151return -1;
bf3146c8 Greg Kroah-Hartman 2010-09-22 1152
6d2b6721 Marek Belisko 2011-03-10 1153status =
ft1000_read_dpram32(dev, 0x200, cmdbuffer, size);
bf3146c8 Greg Kroah-Hartman 2010-09-22 1154
bf3146c8 Greg Kroah-Hartman 2010-09-22 1155 #ifdef JDEBUG
6d2b6721 Marek Belisko 2011-03-10 1156
DEBUG(ft1000_proc_drvmsg:cmdbuffer\n);
6d2b6721 Marek Belisko 2011-03-10 1157for (i = 0; i size; i += 5) {
6d2b6721 Marek Belisko 2011-03-10 1158if ((i + 5) size)
6d2b6721 Marek Belisko 2011-03-10 1159DEBUG(0x%x,
0x%x, 0x%x, 0x%x, 0x%x\n, cmdbuffer[i],
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [staging:staging-next 32/89] drivers/staging/dwc2/hcd_intr.c:2062 dwc2_handle_hcd_intr() warn: impossible condition '(!dwc2_is_controller_alive(hsotg) 0) = (0-1 0)'
TO: Paul Zimmerman paul.zimmer...@synopsys.com
CC: Greg Kroah-Hartman gre...@linuxfoundation.org
Hi Paul,
FYI, there are new smatch warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-next
head: 06749f192b740651302a84273707d0b66749d126
commit: 057715f280f6f242dab649e4923866fd236723d5 [32/89] staging: dwc2: rename
dwc2_check_core_status()
:: branch date: 4 hours ago
:: commit date: 7 days ago
drivers/staging/dwc2/hcd_intr.c:2062 dwc2_handle_hcd_intr() warn: impossible
condition '(!dwc2_is_controller_alive(hsotg) 0) = (0-1 0)'
git remote add staging
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
git remote update staging
git checkout 057715f280f6f242dab649e4923866fd236723d5
vim +2062 drivers/staging/dwc2/hcd_intr.c
b49977a6 Matthijs Kooijman 2013-04-10 2046
b49977a6 Matthijs Kooijman 2013-04-10 2047 dev_vdbg(hsotg-dev,
HAINT=%08x\n, haint);
b49977a6 Matthijs Kooijman 2013-04-10 2048 }
7359d482 Paul Zimmerman2013-03-11 2049
7359d482 Paul Zimmerman2013-03-11 2050 for (i = 0; i
hsotg-core_params-host_channels; i++) {
7359d482 Paul Zimmerman2013-03-11 2051 if (haint (1 i))
7359d482 Paul Zimmerman2013-03-11 2052
dwc2_hc_n_intr(hsotg, i);
7359d482 Paul Zimmerman2013-03-11 2053 }
7359d482 Paul Zimmerman2013-03-11 2054 }
7359d482 Paul Zimmerman2013-03-11 2055
7359d482 Paul Zimmerman2013-03-11 2056 /* This function handles
interrupts for the HCD */
ca18f4a6 Matthijs Kooijman 2013-04-25 2057 irqreturn_t
dwc2_handle_hcd_intr(struct dwc2_hsotg *hsotg)
7359d482 Paul Zimmerman2013-03-11 2058 {
b49977a6 Matthijs Kooijman 2013-04-10 2059 u32 gintsts, dbg_gintsts;
6aafb003 Matthijs Kooijman 2013-04-25 2060 irqreturn_t retval = IRQ_NONE;
7359d482 Paul Zimmerman2013-03-11 2061
057715f2 Paul Zimmerman2013-11-22 @2062 if
(!dwc2_is_controller_alive(hsotg) 0) {
057715f2 Paul Zimmerman2013-11-22 2063 dev_warn(hsotg-dev,
Controller is dead\n);
6aafb003 Matthijs Kooijman 2013-04-25 2064 return retval;
7359d482 Paul Zimmerman2013-03-11 2065 }
7359d482 Paul Zimmerman2013-03-11 2066
7359d482 Paul Zimmerman2013-03-11 2067 spin_lock(hsotg-lock);
7359d482 Paul Zimmerman2013-03-11 2068
7359d482 Paul Zimmerman2013-03-11 2069 /* Check if HOST Mode */
7359d482 Paul Zimmerman2013-03-11 2070 if (dwc2_is_host_mode(hsotg)) {
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [userns:userns-always-map-user-v145 22/67] net/unix/af_unix.c:1216:9: sparse: context imbalance in 'do_unix_stream_connect' - different lock contexts for basic block
TO: Eric W. Biederman ebied...@xmission.com Hi Eric, FYI, there are new sparse warnings show up in tree: git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git userns-always-map-user-v145 head: e92b94442a922b60b8e5e28f4f639f2dd42e759c commit: 61fd3332febe1c20bd1ac0a738e83ac30e35b5d4 [22/67] net: Allow opening an af_unix socket reproduce: make C=1 CF=-D__CHECK_ENDIAN__ :: branch date: 5 hours ago :: commit date: 5 hours ago net/unix/af_unix.c:120:1: sparse: symbol '__ksymtab_unix_socket_table' was not declared. Should it be static? net/unix/af_unix.c:122:1: sparse: symbol '__ksymtab_unix_table_lock' was not declared. Should it be static? net/unix/af_unix.c:199:1: sparse: symbol '__ksymtab_unix_peer_get' was not declared. Should it be static? net/unix/af_unix.c:2185:1: sparse: symbol '__ksymtab_unix_inq_len' was not declared. Should it be static? net/unix/af_unix.c:2191:1: sparse: symbol '__ksymtab_unix_outq_len' was not declared. Should it be static? net/unix/af_unix.c:933:13: sparse: context imbalance in 'unix_state_double_lock' - wrong count at exit net/unix/af_unix.c:951:17: sparse: context imbalance in 'unix_state_double_unlock' - unexpected unlock net/unix/af_unix.c:1041:54: sparse: context imbalance in 'unix_wait_for_peer' - unexpected unlock net/unix/af_unix.c:1216:9: sparse: context imbalance in 'do_unix_stream_connect' - different lock contexts for basic block net/unix/af_unix.c:1664:9: sparse: context imbalance in 'unix_dgram_sendmsg' - different lock contexts for basic block git remote add userns git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git git remote update userns git checkout 61fd3332febe1c20bd1ac0a738e83ac30e35b5d4 vim +/do_unix_stream_connect +1216 net/unix/af_unix.c 1c92b4e5 David S. Miller 2007-05-31 1200 unix_state_unlock(sk); ^1da177e Linus Torvalds2005-04-16 1201 ^1da177e Linus Torvalds2005-04-16 1202 /* take ten and and send info to listening sock */ ^1da177e Linus Torvalds2005-04-16 1203 spin_lock(other-sk_receive_queue.lock); ^1da177e Linus Torvalds2005-04-16 1204 __skb_queue_tail(other-sk_receive_queue, skb); ^1da177e Linus Torvalds2005-04-16 1205 spin_unlock(other-sk_receive_queue.lock); 1c92b4e5 David S. Miller 2007-05-31 1206 unix_state_unlock(other); ^1da177e Linus Torvalds2005-04-16 1207 other-sk_data_ready(other, 0); ^1da177e Linus Torvalds2005-04-16 1208 sock_put(other); ^1da177e Linus Torvalds2005-04-16 1209 return 0; ^1da177e Linus Torvalds2005-04-16 1210 ^1da177e Linus Torvalds2005-04-16 1211 out_unlock: ^1da177e Linus Torvalds2005-04-16 1212 if (other) 1c92b4e5 David S. Miller 2007-05-31 1213 unix_state_unlock(other); ^1da177e Linus Torvalds2005-04-16 1214 ^1da177e Linus Torvalds2005-04-16 1215 out: 40d6 Wei Yongjun 2009-02-25 @1216 kfree_skb(skb); ^1da177e Linus Torvalds2005-04-16 1217 if (newsk) ^1da177e Linus Torvalds2005-04-16 1218 unix_release_sock(newsk, 0); ^1da177e Linus Torvalds2005-04-16 1219 if (other) ^1da177e Linus Torvalds2005-04-16 1220 sock_put(other); ^1da177e Linus Torvalds2005-04-16 1221 return err; ^1da177e Linus Torvalds2005-04-16 1222 } ^1da177e Linus Torvalds2005-04-16 1223 61fd3332 Eric W. Biederman 2012-10-10 1224 static struct sock *unix_stream_open_find_other(struct socket *sock, void *data) :: The code at line 1216 was first introduced by commit: :: 40d unix: remove some pointless conditionals before kfree_skb() :: TO: Wei Yongjun yj...@cn.fujitsu.com :: CC: David S. Miller da...@davemloft.net --- 0-DAY kernel build testing backend Open Source Technology Center http://lists.01.org/mailman/listinfo/kbuild Intel Corporation ___ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [userns:userns-always-map-user-v145 67/67] ipc/namespace.c:88:61: sparse: context imbalance in 'free_ipcs' - different lock contexts for basic block
TO: Eric W. Biederman ebied...@xmission.com
Hi Eric,
FYI, there are new sparse warnings show up in
tree:
git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git
userns-always-map-user-v145
head: e92b94442a922b60b8e5e28f4f639f2dd42e759c
commit: e92b94442a922b60b8e5e28f4f639f2dd42e759c [67/67] namespaces: Use
task_lock and not rcu to protect nsproxy
reproduce: make C=1 CF=-D__CHECK_ENDIAN__
:: branch date: 10 hours ago
:: commit date: 10 hours ago
fs/namespace.c:46:1: sparse: symbol '__ksymtab_fs_kobj' was not declared.
Should it be static?
fs/namespace.c:242:1: sparse: symbol '__ksymtab___mnt_is_readonly' was not
declared. Should it be static?
fs/namespace.c:352:1: sparse: symbol '__ksymtab_mnt_want_write' was not
declared. Should it be static?
fs/namespace.c:376:1: sparse: symbol '__ksymtab_mnt_clone_write' was not
declared. Should it be static?
fs/namespace.c:412:1: sparse: symbol '__ksymtab_mnt_want_write_file' was not
declared. Should it be static?
fs/namespace.c:442:1: sparse: symbol '__ksymtab_mnt_drop_write' was not
declared. Should it be static?
fs/namespace.c:453:1: sparse: symbol '__ksymtab_mnt_drop_write_file' was not
declared. Should it be static?
fs/namespace.c:828:1: sparse: symbol '__ksymtab_vfs_kern_mount' was not
declared. Should it be static?
fs/namespace.c:971:1: sparse: symbol '__ksymtab_mntput' was not declared.
Should it be static?
fs/namespace.c:979:1: sparse: symbol '__ksymtab_mntget' was not declared.
Should it be static?
fs/namespace.c:987:1: sparse: symbol '__ksymtab_mnt_pin' was not declared.
Should it be static?
fs/namespace.c:999:1: sparse: symbol '__ksymtab_mnt_unpin' was not declared.
Should it be static?
fs/namespace.c:1027:1: sparse: symbol '__ksymtab_generic_show_options' was
not declared. Should it be static?
fs/namespace.c:1047:1: sparse: symbol '__ksymtab_save_mount_options' was not
declared. Should it be static?
fs/namespace.c:1051:23: sparse: incorrect type in initializer (different
address spaces)
fs/namespace.c:1051:23:expected char *old
fs/namespace.c:1051:23:got char [noderef] asn:4*s_options
fs/namespace.c:1058:1: sparse: symbol '__ksymtab_replace_mount_options' was
not declared. Should it be static?
fs/namespace.c:1127:1: sparse: symbol '__ksymtab_may_umount_tree' was not
declared. Should it be static?
fs/namespace.c:1154:1: sparse: symbol '__ksymtab_may_umount' was not
declared. Should it be static?
fs/namespace.c:2126:1: sparse: symbol '__ksymtab_mnt_set_expiry' was not
declared. Should it be static?
fs/namespace.c:2165:1: sparse: symbol '__ksymtab_mark_mounts_for_expiry' was
not declared. Should it be static?
fs/namespace.c:2562:1: sparse: symbol '__ksymtab_mount_subtree' was not
declared. Should it be static?
fs/namespace.c:2628:1: sparse: symbol '__ksymtab_path_is_under' was not
declared. Should it be static?
fs/namespace.c:2830:1: sparse: symbol '__ksymtab_kern_mount_data' was not
declared. Should it be static?
fs/namespace.c:2841:1: sparse: symbol '__ksymtab_kern_unmount' was not
declared. Should it be static?
include/linux/rcupdate.h:322:30: sparse: context imbalance in
'legitimize_mnt' - unexpected unlock
--
ipc/namespace.c:88:61: sparse: context imbalance in 'free_ipcs' - different
lock contexts for basic block
git remote add userns
git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git
git remote update userns
git checkout e92b94442a922b60b8e5e28f4f639f2dd42e759c
vim +/free_ipcs +88 ipc/namespace.c
01b8b07a Pierre Peiffer 2008-02-08 72 * @ids: the table of ipcs to free
01b8b07a Pierre Peiffer 2008-02-08 73 * @free: the function called to free
each individual ipc
01b8b07a Pierre Peiffer 2008-02-08 74 *
01b8b07a Pierre Peiffer 2008-02-08 75 * Called for each kind of ipc when an
ipc_namespace exits.
01b8b07a Pierre Peiffer 2008-02-08 76 */
01b8b07a Pierre Peiffer 2008-02-08 77 void free_ipcs(struct ipc_namespace
*ns, struct ipc_ids *ids,
01b8b07a Pierre Peiffer 2008-02-08 78void (*free)(struct
ipc_namespace *, struct kern_ipc_perm *))
01b8b07a Pierre Peiffer 2008-02-08 79 {
01b8b07a Pierre Peiffer 2008-02-08 80 struct kern_ipc_perm *perm;
01b8b07a Pierre Peiffer 2008-02-08 81 int next_id;
01b8b07a Pierre Peiffer 2008-02-08 82 int total, in_use;
01b8b07a Pierre Peiffer 2008-02-08 83
d9a605e4 Davidlohr Bueso 2013-09-11 84 down_write(ids-rwsem);
01b8b07a Pierre Peiffer 2008-02-08 85
01b8b07a Pierre Peiffer 2008-02-08 86 in_use = ids-in_use;
01b8b07a Pierre Peiffer 2008-02-08 87
01b8b07a Pierre Peiffer 2008-02-08 @88 for (total = 0, next_id = 0;
total in_use; next_id++) {
01b8b07a Pierre Peiffer 2008-02-08 89 perm =
idr_find(ids-ipcs_idr, next_id);
01b8b07a Pierre Peiffer 2008-02-08 90 if (perm == NULL)
01b8b07a Pierre Peiffer
[kbuild] [target:mfc_target 32/41] drivers/target/mlx4_fc/mfc_rfci.c:825:2: sparse: FIXME: Fix tag leak
TO: Nicholas Bellinger n...@linux-iscsi.org
Hi Nicholas,
FYI, there are new sparse warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git
mfc_target
head: b4867b474e8e243e4c9a92b0aeb63110792b27a9
commit: b2729c977922eece6ad7f92e009367954bd07fd6 [32/41] mfc_target: Add WIP
mfc_fcp_scsi_rx code
reproduce: make C=1 CF=-D__CHECK_ENDIAN__
:: branch date: 26 hours ago
:: commit date: 7 weeks ago
drivers/target/mlx4_fc/mfc_rfci.c:825:2: sparse: FIXME: Fix tag leak
drivers/target/mlx4_fc/mfc_rfci.c:872:2: sparse: FIXME: Fix tag leak
drivers/target/mlx4_fc/mfc_rfci.c:59:4: sparse: symbol 'fc_fid_flogi' was
not declared. Should it be static?
drivers/target/mlx4_fc/mfc_rfci.c:566:5: sparse: symbol 'mlx4_do_rfci_xmit'
was not declared. Should it be static?
drivers/target/mlx4_fc/mfc_rfci.c:834:23: sparse: cast from restricted __be32
drivers/target/mlx4_fc/mfc_rfci.c:834:23: sparse: incorrect type in argument
1 (different base types)
drivers/target/mlx4_fc/mfc_rfci.c:834:23:expected unsigned int
[unsigned] [usertype] val
drivers/target/mlx4_fc/mfc_rfci.c:834:23:got restricted __be32
[usertype] fc_dl
drivers/target/mlx4_fc/mfc_rfci.c:834:23: sparse: cast from restricted __be32
drivers/target/mlx4_fc/mfc_rfci.c:834:23: sparse: cast from restricted __be32
drivers/target/mlx4_fc/mfc_rfci.c:834:23: sparse: cast from restricted __be32
drivers/target/mlx4_fc/mfc_rfci.c:834:23: sparse: cast from restricted __be32
drivers/target/mlx4_fc/mfc_rfci.c:834:21: sparse: incorrect type in
assignment (different base types)
drivers/target/mlx4_fc/mfc_rfci.c:834:21:expected unsigned int
[unsigned] data_length
drivers/target/mlx4_fc/mfc_rfci.c:834:21:got restricted __be32
[usertype] noident
drivers/target/mlx4_fc/mfc_rfci.c: In function 'mfc_handle_prli':
drivers/target/mlx4_fc/mfc_rfci.c:759:22: warning: unused variable 'tpg'
[-Wunused-variable]
struct mlx4_fc_tpg *tpg;
^
drivers/target/mlx4_fc/mfc_rfci.c: In function 'mfc_fcp_scsi_rx':
drivers/target/mlx4_fc/mfc_rfci.c:825:2: warning: #warning FIXME: Fix tag
leak [-Wcpp]
#warning FIXME: Fix tag leak
^
drivers/target/mlx4_fc/mfc_rfci.c:872:2: warning: #warning FIXME: Fix tag
leak [-Wcpp]
#warning FIXME: Fix tag leak
^
drivers/target/mlx4_fc/mfc_rfci.c: In function 'mfc_frame_send':
drivers/target/mlx4_fc/mfc_rfci.c:1023:23: warning: unused variable 'msg'
[-Wunused-variable]
struct fip_vlan_res *msg;
^
drivers/target/mlx4_fc/mfc_rfci.c:825:2: warning: #warning FIXME: Fix tag
leak [-Wcpp]
#warning FIXME: Fix tag leak
^
drivers/target/mlx4_fc/mfc_rfci.c:872:2: warning: #warning FIXME: Fix tag
leak [-Wcpp]
#warning FIXME: Fix tag leak
^
git remote add target
git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git
git remote update target
git checkout b2729c977922eece6ad7f92e009367954bd07fd6
vim +825 drivers/target/mlx4_fc/mfc_rfci.c
b2729c97 Nicholas Bellinger 2013-10-09 819 ts-remote_exch_id =
ntohs(fh-fh_ox_id);
b2729c97 Nicholas Bellinger 2013-10-09 820
b2729c97 Nicholas Bellinger 2013-10-09 821 ts-local_exch_id =
mfc_bitmap_slot_alloc(vhba-fexch_bm, 0);
b2729c97 Nicholas Bellinger 2013-10-09 822 if (ts-local_exch_id == -1) {
b2729c97 Nicholas Bellinger 2013-10-09 823 pr_err(No free
exchange on vhba=%d port=%d\n,
b2729c97 Nicholas Bellinger 2013-10-09 824 vhba-idx,
vhba-mfc_port-port);
b2729c97 Nicholas Bellinger 2013-10-09 @825 #warning FIXME: Fix tag leak
b2729c97 Nicholas Bellinger 2013-10-09 826 return;
b2729c97 Nicholas Bellinger 2013-10-09 827 }
b2729c97 Nicholas Bellinger 2013-10-09 828
b2729c97 Nicholas Bellinger 2013-10-09 829 fexch =
vhba-fexch[ts-local_exch_id];
b2729c97 Nicholas Bellinger 2013-10-09 830 fexch-context = (void *)ts;
b2729c97 Nicholas Bellinger 2013-10-09 831
b2729c97 Nicholas Bellinger 2013-10-09 832 se_cmd = mfc_cmd-se_cmd;
b2729c97 Nicholas Bellinger 2013-10-09 833 unpacked_lun =
scsilun_to_int(fcp-fc_lun);
b2729c97 Nicholas Bellinger 2013-10-09 @834 data_length = htonl(fcp-fc_dl);
b2729c97 Nicholas Bellinger 2013-10-09 835
b2729c97 Nicholas Bellinger 2013-10-09 836 switch (fcp-fc_flags
(FCP_CFL_RDDATA | FCP_CFL_WRDATA)) {
b2729c97 Nicholas Bellinger 2013-10-09 837 case 0:
b2729c97 Nicholas Bellinger 2013-10-09 838 data_dir = DMA_NONE;
b2729c97 Nicholas Bellinger 2013-10-09 839 break;
b2729c97 Nicholas Bellinger 2013-10-09 840 case FCP_CFL_RDDATA:
b2729c97 Nicholas Bellinger 2013-10-09 841 data_dir =
DMA_FROM_DEVICE;
b2729c97 Nicholas Bellinger 2013-10-09 842 break;
b2729c97 Nicholas Bellinger 2013-10-09 843 case FCP_CFL_WRDATA:
b2729c97 Nicholas Bellinger 2013-10-09 844 data_dir =
DMA_TO_DEVICE;
b2729c97
[kbuild] [target:mfc_target 33/41] drivers/target/mlx4_fc/mlx4_fc_fabric.c:195:2: sparse: FIXME: Fill in rest of *ts for RDMA_READ
TO: Nicholas Bellinger n...@linux-iscsi.org
Hi Nicholas,
FYI, there are new sparse warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git
mfc_target
head: b4867b474e8e243e4c9a92b0aeb63110792b27a9
commit: b71c1e8158939553084bc8c898dbdd278ec7fb32 [33/41] mfc_target: Add WIP
data_in+status+write_pending callbacks
reproduce: make C=1 CF=-D__CHECK_ENDIAN__
:: branch date: 26 hours ago
:: commit date: 7 weeks ago
drivers/target/mlx4_fc/mlx4_fc_fabric.c:195:2: sparse: FIXME: Fill in rest
of *ts for RDMA_READ
drivers/target/mlx4_fc/mlx4_fc_fabric.c:230:2: sparse: FIXME: Fill in rest
of *ts for RDMA_WRITE
drivers/target/mlx4_fc/mlx4_fc_fabric.c:235:2: sparse: FIXME: Fill in rest
of *ts for SCSI response
drivers/target/mlx4_fc/mlx4_fc_fabric.c:250:2: sparse: FIXME: Fill in rest
of *ts for SCSI response
drivers/target/mlx4_fc/mlx4_fc_fabric.c: In function 'mlx4_fc_write_pending':
drivers/target/mlx4_fc/mlx4_fc_fabric.c:195:2: warning: #warning FIXME: Fill
in rest of *ts for RDMA_READ [-Wcpp]
#warning FIXME: Fill in rest of *ts for RDMA_READ
^
drivers/target/mlx4_fc/mlx4_fc_fabric.c: In function 'mlx4_fc_queue_data_in':
drivers/target/mlx4_fc/mlx4_fc_fabric.c:230:2: warning: #warning FIXME: Fill
in rest of *ts for RDMA_WRITE [-Wcpp]
#warning FIXME: Fill in rest of *ts for RDMA_WRITE
^
drivers/target/mlx4_fc/mlx4_fc_fabric.c:235:2: warning: #warning FIXME: Fill
in rest of *ts for SCSI response [-Wcpp]
#warning FIXME: Fill in rest of *ts for SCSI response
^
drivers/target/mlx4_fc/mlx4_fc_fabric.c: In function 'mlx4_fc_queue_status':
drivers/target/mlx4_fc/mlx4_fc_fabric.c:250:2: warning: #warning FIXME: Fill
in rest of *ts for SCSI response [-Wcpp]
#warning FIXME: Fill in rest of *ts for SCSI response
^
git remote add target
git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git
git remote update target
git checkout b71c1e8158939553084bc8c898dbdd278ec7fb32
vim +195 drivers/target/mlx4_fc/mlx4_fc_fabric.c
adbbf0eb Nicholas Bellinger 2013-07-29 189 {
b71c1e81 Nicholas Bellinger 2013-10-09 190 struct mfc_cmd *mfc_cmd =
container_of(se_cmd, struct mfc_cmd, se_cmd);
b71c1e81 Nicholas Bellinger 2013-10-09 191 struct trans_start *ts =
mfc_cmd-ts;
b71c1e81 Nicholas Bellinger 2013-10-09 192 struct mfc_vhba *vhba =
se_cmd-se_sess-fabric_sess_ptr;
b71c1e81 Nicholas Bellinger 2013-10-09 193 int rc;
b71c1e81 Nicholas Bellinger 2013-10-09 194
b71c1e81 Nicholas Bellinger 2013-10-09 @195 #warning FIXME: Fill in rest of
*ts for RDMA_READ
b71c1e81 Nicholas Bellinger 2013-10-09 196 rc = mfc_send_data(vhba, ts);
b71c1e81 Nicholas Bellinger 2013-10-09 197 if (rc)
b71c1e81 Nicholas Bellinger 2013-10-09 198 return rc;
b71c1e81 Nicholas Bellinger 2013-10-09 199
adbbf0eb Nicholas Bellinger 2013-07-29 200 return 0;
adbbf0eb Nicholas Bellinger 2013-07-29 201 }
adbbf0eb Nicholas Bellinger 2013-07-29 202
adbbf0eb Nicholas Bellinger 2013-07-29 203 int
mlx4_fc_write_pending_status(struct se_cmd *se_cmd)
adbbf0eb Nicholas Bellinger 2013-07-29 204 {
adbbf0eb Nicholas Bellinger 2013-07-29 205 return 0;
adbbf0eb Nicholas Bellinger 2013-07-29 206 }
adbbf0eb Nicholas Bellinger 2013-07-29 207
adbbf0eb Nicholas Bellinger 2013-07-29 208 void
mlx4_fc_set_default_node_attrs(struct se_node_acl *nacl)
adbbf0eb Nicholas Bellinger 2013-07-29 209 {
adbbf0eb Nicholas Bellinger 2013-07-29 210 return;
adbbf0eb Nicholas Bellinger 2013-07-29 211 }
adbbf0eb Nicholas Bellinger 2013-07-29 212
adbbf0eb Nicholas Bellinger 2013-07-29 213 u32 mlx4_fc_get_task_tag(struct
se_cmd *se_cmd)
adbbf0eb Nicholas Bellinger 2013-07-29 214 {
adbbf0eb Nicholas Bellinger 2013-07-29 215 return 0;
adbbf0eb Nicholas Bellinger 2013-07-29 216 }
adbbf0eb Nicholas Bellinger 2013-07-29 217
adbbf0eb Nicholas Bellinger 2013-07-29 218 int mlx4_fc_get_cmd_state(struct
se_cmd *se_cmd)
adbbf0eb Nicholas Bellinger 2013-07-29 219 {
adbbf0eb Nicholas Bellinger 2013-07-29 220 return 0;
adbbf0eb Nicholas Bellinger 2013-07-29 221 }
adbbf0eb Nicholas Bellinger 2013-07-29 222
adbbf0eb Nicholas Bellinger 2013-07-29 223 int mlx4_fc_queue_data_in(struct
se_cmd *se_cmd)
adbbf0eb Nicholas Bellinger 2013-07-29 224 {
b71c1e81 Nicholas Bellinger 2013-10-09 225 struct mfc_cmd *mfc_cmd =
container_of(se_cmd, struct mfc_cmd, se_cmd);
b71c1e81 Nicholas Bellinger 2013-10-09 226 struct trans_start *ts =
mfc_cmd-ts;
b71c1e81 Nicholas Bellinger 2013-10-09 227 struct mfc_vhba *vhba =
se_cmd-se_sess-fabric_sess_ptr;
b71c1e81 Nicholas Bellinger 2013-10-09 228 int rc;
b71c1e81 Nicholas Bellinger 2013-10-09 229
b71c1e81 Nicholas Bellinger 2013-10-09 230 #warning FIXME: Fill in rest of
*ts for RDMA_WRITE
b71c1e81 Nicholas Bellinger 2013-10-09 231 rc = mfc_send_data(vhba, ts);
b71c1e81 Nicholas Bellinger 2013-10-09 232
[kbuild] [target:mfc_target 41/41] drivers/target/mlx4_fc/mfc_rfci.c:987:3-34: code aligned with following code on line 988
TO: Vu Pham v...@mellanox.com Hi Vu, FYI, there are coccinelle warnings in tree: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git mfc_target head: b4867b474e8e243e4c9a92b0aeb63110792b27a9 commit: b4867b474e8e243e4c9a92b0aeb63110792b27a9 [41/41] mfc_target: WIP check initiator node acl with right mac :: branch date: 27 hours ago :: commit date: 27 hours ago drivers/target/mlx4_fc/mfc_rfci.c:987:3-34: code aligned with following code on line 988 git remote add target git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git git remote update target git checkout b4867b474e8e243e4c9a92b0aeb63110792b27a9 vim +987 drivers/target/mlx4_fc/mfc_rfci.c adbbf0eb Nicholas Bellinger 2013-07-29 981 if (!rc) adbbf0eb Nicholas Bellinger 2013-07-29 982 goto free_packet; e1ac4848 Vu Pham2013-10-08 983 break; e1ac4848 Vu Pham2013-10-08 984 e1ac4848 Vu Pham2013-10-08 985 case FC_RCTL_ELS_REQ: e1ac4848 Vu Pham2013-10-08 986 if (fc_frame_payload_op(fp) == ELS_PRLI) b4867b47 Vu Pham2013-11-08 @987 rc = mfc_handle_prli(fp, vhba); b4867b47 Vu Pham2013-11-08 @988 if (rc) b4867b47 Vu Pham2013-11-08 989 goto free_packet; e1ac4848 Vu Pham2013-10-08 990 break; e1ac4848 Vu Pham2013-10-08 991 --- 0-DAY kernel build testing backend Open Source Technology Center http://lists.01.org/mailman/listinfo/kbuild Intel Corporation ___ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman/listinfo/kbuild
