[kbuild] [android-goldfish:android-5.4 8/9] fs/sdcardfs/main.c:174:14: warning: struct member 'sdcardfs_mount_private::dev_name' is never used.
CC: kbuild-...@lists.01.org
TO: "Alistair, Delva,"
tree: https://android.googlesource.com/kernel/goldfish android-5.4
head: f8aa5f514ccb2ded066fe47f6fd571fe016ca648
commit: ed21d463f856dfad55dc05afd8b7ff3232e9109b [8/9] Revert "ANDROID:
sdcardfs: remove sdcardfs from system"
:: branch date: 13 hours ago
:: commit date: 15 hours ago
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
cppcheck warnings: (new ones prefixed by >>)
In file included from fs/sdcardfs/main.c:
>> fs/sdcardfs/main.c:174:14: warning: struct member
>> 'sdcardfs_mount_private::dev_name' is never used. [unusedStructMember]
const char *dev_name;
^
>> fs/sdcardfs/main.c:175:8: warning: struct member
>> 'sdcardfs_mount_private::raw_data' is never used. [unusedStructMember]
void *raw_data;
^
--
>> fs/sdcardfs/lookup.c:54:7: warning: Variable 'info' is reassigned a value
>> before the old one has been used. [redundantAssignment]
info = kmem_cache_zalloc(sdcardfs_dentry_cachep, GFP_ATOMIC);
^
fs/sdcardfs/lookup.c:51:0: note: Variable 'info' is reassigned a value
before the old one has been used.
struct sdcardfs_dentry_info *info = SDCARDFS_D(dentry);
^
fs/sdcardfs/lookup.c:54:7: note: Variable 'info' is reassigned a value
before the old one has been used.
info = kmem_cache_zalloc(sdcardfs_dentry_cachep, GFP_ATOMIC);
^
git remote add android-goldfish https://android.googlesource.com/kernel/goldfish
git remote update android-goldfish
git checkout ed21d463f856dfad55dc05afd8b7ff3232e9109b
vim +174 fs/sdcardfs/main.c
ed21d463f856df Alistair Delva 2020-06-02 171
ed21d463f856df Alistair Delva 2020-06-02 172 struct sdcardfs_mount_private {
ed21d463f856df Alistair Delva 2020-06-02 173 struct vfsmount *mnt;
ed21d463f856df Alistair Delva 2020-06-02 @174 const char *dev_name;
ed21d463f856df Alistair Delva 2020-06-02 @175 void *raw_data;
ed21d463f856df Alistair Delva 2020-06-02 176 };
ed21d463f856df Alistair Delva 2020-06-02 177
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [android-common:android-5.4 3/3] fs/namei.c:811:17-24: ERROR: reference preceded by free on line 799
CC: kbuild-...@lists.01.org
TO: cros-kernel-buildrepo...@googlegroups.com
tree: https://android.googlesource.com/kernel/common android-5.4
head: ff2d9520b4aa4a23e2c9e37b6a5ca255d6f5715e
commit: ff2d9520b4aa4a23e2c9e37b6a5ca255d6f5715e [3/3] ANDROID: Add a
tracepoint for mapping inode to full path
:: branch date: 5 months ago
:: commit date: 5 months ago
config: x86_64-randconfig-c002-20200602 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Julia Lawall
coccinelle warnings: (new ones prefixed by >>)
>> fs/namei.c:811:17-24: ERROR: reference preceded by free on line 799
git remote add android-common https://android.googlesource.com/kernel/common
git remote update android-common
git checkout ff2d9520b4aa4a23e2c9e37b6a5ca255d6f5715e
vim +811 fs/namei.c
ff2d9520b4aa4a Joel Fernandes 2019-03-14 777
ff2d9520b4aa4a Joel Fernandes 2019-03-14 778 static void
success_walk_trace(struct nameidata *nd)
ff2d9520b4aa4a Joel Fernandes 2019-03-14 779 {
ff2d9520b4aa4a Joel Fernandes 2019-03-14 780 struct path *pt = >path;
ff2d9520b4aa4a Joel Fernandes 2019-03-14 781 struct inode *i = nd->inode;
ff2d9520b4aa4a Joel Fernandes 2019-03-14 782 char buf[INIT_PATH_SIZE],
*try_buf;
ff2d9520b4aa4a Joel Fernandes 2019-03-14 783 int cur_path_size;
ff2d9520b4aa4a Joel Fernandes 2019-03-14 784 char *p;
ff2d9520b4aa4a Joel Fernandes 2019-03-14 785
ff2d9520b4aa4a Joel Fernandes 2019-03-14 786 /* When eBPF/ tracepoint is
disabled, keep overhead low. */
ff2d9520b4aa4a Joel Fernandes 2019-03-14 787 if (!trace_inodepath_enabled())
ff2d9520b4aa4a Joel Fernandes 2019-03-14 788 return;
ff2d9520b4aa4a Joel Fernandes 2019-03-14 789
ff2d9520b4aa4a Joel Fernandes 2019-03-14 790 /* First try stack allocated
buffer. */
ff2d9520b4aa4a Joel Fernandes 2019-03-14 791 try_buf = buf;
ff2d9520b4aa4a Joel Fernandes 2019-03-14 792 cur_path_size = INIT_PATH_SIZE;
ff2d9520b4aa4a Joel Fernandes 2019-03-14 793
ff2d9520b4aa4a Joel Fernandes 2019-03-14 794 while (cur_path_size <=
PATH_MAX) {
ff2d9520b4aa4a Joel Fernandes 2019-03-14 795 /* Free previous heap
allocation if we are now trying
ff2d9520b4aa4a Joel Fernandes 2019-03-14 796* a second or later
heap allocation.
ff2d9520b4aa4a Joel Fernandes 2019-03-14 797*/
ff2d9520b4aa4a Joel Fernandes 2019-03-14 798 if (try_buf != buf)
ff2d9520b4aa4a Joel Fernandes 2019-03-14 @799 kfree(try_buf);
ff2d9520b4aa4a Joel Fernandes 2019-03-14 800
ff2d9520b4aa4a Joel Fernandes 2019-03-14 801 /* All but the first
alloc are on the heap. */
ff2d9520b4aa4a Joel Fernandes 2019-03-14 802 if (cur_path_size !=
INIT_PATH_SIZE) {
ff2d9520b4aa4a Joel Fernandes 2019-03-14 803 try_buf =
kmalloc(cur_path_size, GFP_KERNEL);
ff2d9520b4aa4a Joel Fernandes 2019-03-14 804 if (!try_buf) {
ff2d9520b4aa4a Joel Fernandes 2019-03-14 805 try_buf
= buf;
ff2d9520b4aa4a Joel Fernandes 2019-03-14 806
sprintf(try_buf, "error:buf_alloc_failed");
ff2d9520b4aa4a Joel Fernandes 2019-03-14 807 break;
ff2d9520b4aa4a Joel Fernandes 2019-03-14 808 }
ff2d9520b4aa4a Joel Fernandes 2019-03-14 809 }
ff2d9520b4aa4a Joel Fernandes 2019-03-14 810
ff2d9520b4aa4a Joel Fernandes 2019-03-14 @811 p = d_path(pt, try_buf,
cur_path_size);
ff2d9520b4aa4a Joel Fernandes 2019-03-14 812
ff2d9520b4aa4a Joel Fernandes 2019-03-14 813 if (!IS_ERR(p)) {
ff2d9520b4aa4a Joel Fernandes 2019-03-14 814 char *end =
mangle_path(try_buf, p, "\n");
ff2d9520b4aa4a Joel Fernandes 2019-03-14 815
ff2d9520b4aa4a Joel Fernandes 2019-03-14 816 if (end) {
ff2d9520b4aa4a Joel Fernandes 2019-03-14 817
try_buf[end - try_buf] = 0;
ff2d9520b4aa4a Joel Fernandes 2019-03-14 818 break;
ff2d9520b4aa4a Joel Fernandes 2019-03-14 819 } else {
ff2d9520b4aa4a Joel Fernandes 2019-03-14 820 /* On
mangle errors, double path size
ff2d9520b4aa4a Joel Fernandes 2019-03-14 821* till
PATH_MAX.
ff2d9520b4aa4a Joel Fernandes 2019-03-14 822*/
ff2d9520b4aa4a Joel Fernandes 2019-03-14 823
cur_path_size = cur_path_size << 1;
ff2d9520b4aa4a Joel Fernandes 2019-03-14 824
continue;
ff2d9520b4aa4a Joel Fernandes 2019-03-14 825 }
ff2d9520b4aa4a Joel Fernandes 2019-03-14 826 }
ff2d9520b4aa4a Joel Fernandes 2019-03-14 827
ff2d9520b4aa4a Joel Fernandes 2019-03-14 828 if (PTR_ERR(p) ==
-ENAMETOOLONG)
[kbuild] [rcu:dev.2020.05.26b 59/70] kernel/rcu/refperf.c:391 main_func() error: we previously assumed 'buf' could be null (see line 348)
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: "Paul, E., McKenney,"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
dev.2020.05.26b
head: 795279db1396bf66621fa3f343fa990fe543b89e
commit: 7e2a6278a303f510883b32c1ac2d5ea7351b7e1d [59/70] refperf: Dynamically
allocate experiment-summary output buffer
:: branch date: 6 days ago
:: commit date: 6 days ago
config: x86_64-randconfig-m001-20200602 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
smatch warnings:
kernel/rcu/refperf.c:391 main_func() error: we previously assumed 'buf' could
be null (see line 348)
#
https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git/commit/?id=7e2a6278a303f510883b32c1ac2d5ea7351b7e1d
git remote add rcu
https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
git remote update rcu
git checkout 7e2a6278a303f510883b32c1ac2d5ea7351b7e1d
vim +/buf +391 kernel/rcu/refperf.c
786a2549774369 Joel Fernandes (Google 2020-05-25 325)
786a2549774369 Joel Fernandes (Google 2020-05-25 326) // The main_func is the
main orchestrator, it performs a bunch of
786a2549774369 Joel Fernandes (Google 2020-05-25 327) // experiments. For
every experiment, it orders all the readers
786a2549774369 Joel Fernandes (Google 2020-05-25 328) // involved to start
and waits for them to finish the experiment. It
786a2549774369 Joel Fernandes (Google 2020-05-25 329) // then reads their
timestamps and starts the next experiment. Each
786a2549774369 Joel Fernandes (Google 2020-05-25 330) // experiment
progresses from 1 concurrent reader to N of them at which
786a2549774369 Joel Fernandes (Google 2020-05-25 331) // point all the
timestamps are printed.
786a2549774369 Joel Fernandes (Google 2020-05-25 332) static int
main_func(void *arg)
786a2549774369 Joel Fernandes (Google 2020-05-25 333) {
7e2a6278a303f5 Paul E. McKenney2020-05-25 334 bool errexit =
false;
786a2549774369 Joel Fernandes (Google 2020-05-25 335) int exp, r;
786a2549774369 Joel Fernandes (Google 2020-05-25 336) char buf1[64];
7e2a6278a303f5 Paul E. McKenney2020-05-25 337 char *buf;
e4c9f422a8f55a Paul E. McKenney2020-05-25 338 u64 *result_avg;
786a2549774369 Joel Fernandes (Google 2020-05-25 339)
786a2549774369 Joel Fernandes (Google 2020-05-25 340)
set_cpus_allowed_ptr(current, cpumask_of(nreaders % nr_cpu_ids));
786a2549774369 Joel Fernandes (Google 2020-05-25 341)
set_user_nice(current, MAX_NICE);
786a2549774369 Joel Fernandes (Google 2020-05-25 342)
0df40fd6b88e49 Paul E. McKenney2020-05-25 343 if (holdoff)
0df40fd6b88e49 Paul E. McKenney2020-05-25 344
schedule_timeout_interruptible(holdoff * HZ);
786a2549774369 Joel Fernandes (Google 2020-05-25 345)
VERBOSE_PERFOUT("main_func task started");
e4c9f422a8f55a Paul E. McKenney2020-05-25 346 result_avg =
kzalloc(nruns * sizeof(*result_avg), GFP_KERNEL);
7e2a6278a303f5 Paul E. McKenney2020-05-25 347 buf =
kzalloc(64 + nruns * 32, GFP_KERNEL);
7e2a6278a303f5 Paul E. McKenney2020-05-25 @348 if (!result_avg
|| !buf) {
e4c9f422a8f55a Paul E. McKenney2020-05-25 349
VERBOSE_PERFOUT_ERRSTRING("out of memory");
7e2a6278a303f5 Paul E. McKenney2020-05-25 350 errexit
= true;
7e2a6278a303f5 Paul E. McKenney2020-05-25 351 }
786a2549774369 Joel Fernandes (Google 2020-05-25 352)
atomic_inc(_init);
786a2549774369 Joel Fernandes (Google 2020-05-25 353)
786a2549774369 Joel Fernandes (Google 2020-05-25 354) // Wait for all
threads to start.
786a2549774369 Joel Fernandes (Google 2020-05-25 355)
wait_event(main_wq, atomic_read(_init) == (nreaders + 1));
786a2549774369 Joel Fernandes (Google 2020-05-25 356)
786a2549774369 Joel Fernandes (Google 2020-05-25 357) // Start exp
readers up per experiment
e4c9f422a8f55a Paul E. McKenney2020-05-25 358 for (exp = 0;
exp < nruns && !torture_must_stop(); exp++) {
7e2a6278a303f5 Paul E. McKenney2020-05-25 359 if
(errexit)
e4c9f422a8f55a Paul E. McKenney2020-05-25 360
break;
786a2549774369 Joel Fernandes (Google 2020-05-25 361) if
(torture_must_stop())
786a2549774369 Joel Fernandes (Google 2020-05-25 362)
goto end;
786a2549774369 Joel Fernandes (Google 2020-05-25 363)
e4c9f422a8f55a Paul E. McKenney2020-05-25 364
reset_readers();
e4c9f422a8f55a Paul E. McKenney2020-05-25 365
atomic_set(_exp, nreaders);
786a2549774369 Joel Fernandes
[kbuild] [dhowells-fs:fscache-iter 22/62] include/linux/fscache.h:80:30: sparse: sparse: don't know how to apply mode to unsigned int enum fscache_cookie_stage
CC: kbuild-...@lists.01.org
TO: "David, Howells,"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
fscache-iter
head: b4a9eadc021941103fd0c925e7e7b38516ffaf39
commit: 5db57596b0d3e5e78f7202dd50a58cc154f66b7c [22/62] fscache: Replace the
object management state machine
:: branch date: 6 days ago
:: commit date: 6 days ago
config: x86_64-randconfig-s022-20200602 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout 5db57596b0d3e5e78f7202dd50a58cc154f66b7c
# save the attached .config to linux build tree
make W=1 C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
>> include/linux/fscache.h:80:30: sparse: sparse: don't know how to apply mode
>> to unsigned int enum fscache_cookie_stage
#
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/commit/?id=5db57596b0d3e5e78f7202dd50a58cc154f66b7c
git remote add dhowells-fs
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
git remote update dhowells-fs
git checkout 5db57596b0d3e5e78f7202dd50a58cc154f66b7c
vim +80 include/linux/fscache.h
2d6fff63703739 David Howells 2009-04-03 68
5db57596b0d3e5 David Howells 2020-02-06 69 /*
5db57596b0d3e5 David Howells 2020-02-06 70 * Data object state.
5db57596b0d3e5 David Howells 2020-02-06 71 */
5db57596b0d3e5 David Howells 2020-02-06 72 enum fscache_cookie_stage {
5db57596b0d3e5 David Howells 2020-02-06 73 FSCACHE_COOKIE_STAGE_QUIESCENT,
/* The cookie is uncached */
5db57596b0d3e5 David Howells 2020-02-06 74
FSCACHE_COOKIE_STAGE_INITIALISING, /* The in-memory structs are being
inited */
5db57596b0d3e5 David Howells 2020-02-06 75
FSCACHE_COOKIE_STAGE_LOOKING_UP,/* The cache object is being looked up
*/
5db57596b0d3e5 David Howells 2020-02-06 76
FSCACHE_COOKIE_STAGE_NO_DATA_YET, /* The cache has no data, read to
network */
5db57596b0d3e5 David Howells 2020-02-06 77 FSCACHE_COOKIE_STAGE_ACTIVE,
/* The cache is active, readable and writable */
5db57596b0d3e5 David Howells 2020-02-06 78
FSCACHE_COOKIE_STAGE_INVALIDATING, /* The cache is being invalidated */
5db57596b0d3e5 David Howells 2020-02-06 79 FSCACHE_COOKIE_STAGE_DEAD,
/* The cache object is dead */
5db57596b0d3e5 David Howells 2020-02-06 @80 } __attribute__((mode(byte)));
5db57596b0d3e5 David Howells 2020-02-06 81
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [lkundrak-linux-mmp:lr/ariel 65/67] sound/soc/codecs/88ce156-codec.c:1274:1-6: WARNING: invalid free of devm_ allocated data
CC: kbuild-...@lists.01.org
TO: "Lubomir, Rintel,"
tree: git://git.kernel.org/pub/scm/linux/kernel/git/lkundrak/linux-mmp.git
lr/ariel
head: 744209eb6a53c65c03de1214febd58adbad72853
commit: 2e9965325fb254f4792fb2b6b086b12dc63f891c [65/67] p4
:: branch date: 11 hours ago
:: commit date: 11 hours ago
config: sparc-randconfig-c024-20200602 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Julia Lawall
coccinelle warnings: (new ones prefixed by >>)
>> sound/soc/codecs/88ce156-codec.c:1274:1-6: WARNING: invalid free of devm_
>> allocated data
#
https://git.kernel.org/pub/scm/linux/kernel/git/lkundrak/linux-mmp.git/commit/?id=2e9965325fb254f4792fb2b6b086b12dc63f891c
git remote add lkundrak-linux-mmp
git://git.kernel.org/pub/scm/linux/kernel/git/lkundrak/linux-mmp.git
git remote update lkundrak-linux-mmp
git checkout 2e9965325fb254f4792fb2b6b086b12dc63f891c
vim +1274 sound/soc/codecs/88ce156-codec.c
27998497039d25 Lubomir Rintel 2020-05-24 1245
2e9965325fb254 Lubomir Rintel 2020-05-24 1246 static int
ce156_i2c_probe(struct i2c_client *i2c)
27998497039d25 Lubomir Rintel 2020-05-24 1247 {
27998497039d25 Lubomir Rintel 2020-05-24 1248 struct ce156_private
*ce156_priv;
27998497039d25 Lubomir Rintel 2020-05-24 1249 int ret;
27998497039d25 Lubomir Rintel 2020-05-24 1250
27998497039d25 Lubomir Rintel 2020-05-24 1251 printk(KERN_INFO
"CE156: register i2c driver successfully\n");
27998497039d25 Lubomir Rintel 2020-05-24 1252
2e9965325fb254 Lubomir Rintel 2020-05-24 1253 ce156_priv =
devm_kzalloc(>dev, sizeof(struct ce156_private), GFP_KERNEL);
27998497039d25 Lubomir Rintel 2020-05-24 1254 if (ce156_priv == NULL)
27998497039d25 Lubomir Rintel 2020-05-24 1255 return -ENOMEM;
27998497039d25 Lubomir Rintel 2020-05-24 1256
3c683b56c7a576 Lubomir Rintel 2020-05-24 1257 ce156_priv->regmap =
devm_regmap_init_i2c(i2c, _regmap);
3c683b56c7a576 Lubomir Rintel 2020-05-24 1258 if
(IS_ERR(ce156_priv->regmap)) {
3c683b56c7a576 Lubomir Rintel 2020-05-24 1259 ret =
PTR_ERR(ce156_priv->regmap);
3c683b56c7a576 Lubomir Rintel 2020-05-24 1260
dev_err(>dev, "Failed to allocate regmap (%d)\n", ret);
3c683b56c7a576 Lubomir Rintel 2020-05-24 1261 return ret;
3c683b56c7a576 Lubomir Rintel 2020-05-24 1262 }
3c683b56c7a576 Lubomir Rintel 2020-05-24 1263
40169b41e2e888 Lubomir Rintel 2020-05-24 1264 ret =
devm_snd_soc_register_component(>dev, _component_dev_ce156,
_dai, 1);
27998497039d25 Lubomir Rintel 2020-05-24 1265
27998497039d25 Lubomir Rintel 2020-05-24 1266 if (ret) {
27998497039d25 Lubomir Rintel 2020-05-24 1267
printk(KERN_INFO "CE156: Failed to register codec\n");
27998497039d25 Lubomir Rintel 2020-05-24 1268 goto out;
27998497039d25 Lubomir Rintel 2020-05-24 1269 }
27998497039d25 Lubomir Rintel 2020-05-24 1270
27998497039d25 Lubomir Rintel 2020-05-24 1271 return ret;
27998497039d25 Lubomir Rintel 2020-05-24 1272
27998497039d25 Lubomir Rintel 2020-05-24 1273 out:
27998497039d25 Lubomir Rintel 2020-05-24 @1274 kfree(ce156_priv);
27998497039d25 Lubomir Rintel 2020-05-24 1275 return -EINVAL;
27998497039d25 Lubomir Rintel 2020-05-24 1276 }
27998497039d25 Lubomir Rintel 2020-05-24 1277
:: The code at line 1274 was first introduced by commit
:: 27998497039d2518d34ba88ddd721c2290a2e162 XXX 88CE156
:: TO: Lubomir Rintel
:: CC: Lubomir Rintel
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] drivers/usb/gadget/legacy/raw_gadget.c:102 raw_event_queue_fetch() warn: inconsistent returns 'queue->sema'.
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: "Andrey, Konovalov,"
CC: Felipe Balbi
CC: "Greg Kroah-Hartman"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: f359287765c04711ff54fbd11645271d8e5ff763
commit: f2c2e717642c66f7fe7e5dd69b2e8ff5849f4d10 usb: gadget: add raw-gadget
interface
date: 3 months ago
:: branch date: 6 hours ago
:: commit date: 3 months ago
config: x86_64-randconfig-m001-20200602 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
New smatch warnings:
drivers/usb/gadget/legacy/raw_gadget.c:102 raw_event_queue_fetch() warn:
inconsistent returns 'queue->sema'.
Old smatch warnings:
drivers/usb/gadget/legacy/raw_gadget.c:397 raw_ioctl_init() warn: maybe return
-EFAULT instead of the bytes remaining?
drivers/usb/gadget/legacy/raw_gadget.c:512 raw_ioctl_event_fetch() warn: maybe
return -EFAULT instead of the bytes remaining?
drivers/usb/gadget/legacy/raw_gadget.c:535 raw_ioctl_event_fetch() warn: maybe
return -EFAULT instead of the bytes remaining?
drivers/usb/gadget/legacy/raw_gadget.c:546 raw_alloc_io_data() error: passing
non negative 8 to ERR_PTR
drivers/usb/gadget/legacy/raw_gadget.c:668 raw_ioctl_ep0_read() warn: maybe
return -EFAULT instead of the bytes remaining?
drivers/usb/gadget/legacy/raw_gadget.c:962 raw_ioctl_ep_read() warn: maybe
return -EFAULT instead of the bytes remaining?
#
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f2c2e717642c66f7fe7e5dd69b2e8ff5849f4d10
git remote add linus
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout f2c2e717642c66f7fe7e5dd69b2e8ff5849f4d10
vim +102 drivers/usb/gadget/legacy/raw_gadget.c
f2c2e717642c66 Andrey Konovalov 2020-02-24 80
f2c2e717642c66 Andrey Konovalov 2020-02-24 81 static struct usb_raw_event
*raw_event_queue_fetch(
f2c2e717642c66 Andrey Konovalov 2020-02-24 82
struct raw_event_queue *queue)
f2c2e717642c66 Andrey Konovalov 2020-02-24 83 {
f2c2e717642c66 Andrey Konovalov 2020-02-24 84 unsigned long flags;
f2c2e717642c66 Andrey Konovalov 2020-02-24 85 struct usb_raw_event
*event;
f2c2e717642c66 Andrey Konovalov 2020-02-24 86
f2c2e717642c66 Andrey Konovalov 2020-02-24 87 /*
f2c2e717642c66 Andrey Konovalov 2020-02-24 88 * This function can be
called concurrently. We first check that
f2c2e717642c66 Andrey Konovalov 2020-02-24 89 * there's at least one
event queued by decrementing the semaphore,
f2c2e717642c66 Andrey Konovalov 2020-02-24 90 * and then take the
lock to protect queue struct fields.
f2c2e717642c66 Andrey Konovalov 2020-02-24 91 */
f2c2e717642c66 Andrey Konovalov 2020-02-24 92 if
(down_interruptible(>sema))
f2c2e717642c66 Andrey Konovalov 2020-02-24 93 return NULL;
f2c2e717642c66 Andrey Konovalov 2020-02-24 94
spin_lock_irqsave(>lock, flags);
f2c2e717642c66 Andrey Konovalov 2020-02-24 95 if
(WARN_ON(!queue->size))
f2c2e717642c66 Andrey Konovalov 2020-02-24 96 return NULL;
f2c2e717642c66 Andrey Konovalov 2020-02-24 97 event =
queue->events[0];
f2c2e717642c66 Andrey Konovalov 2020-02-24 98 queue->size--;
f2c2e717642c66 Andrey Konovalov 2020-02-24 99
memmove(>events[0], >events[1],
f2c2e717642c66 Andrey Konovalov 2020-02-24 100
queue->size * sizeof(queue->events[0]));
f2c2e717642c66 Andrey Konovalov 2020-02-24 101
spin_unlock_irqrestore(>lock, flags);
f2c2e717642c66 Andrey Konovalov 2020-02-24 @102 return event;
f2c2e717642c66 Andrey Konovalov 2020-02-24 103 }
f2c2e717642c66 Andrey Konovalov 2020-02-24 104
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [lkundrak-linux-mmp:lr/ariel 61/67] sound/soc/codecs/88ce156-codec.c:1341:5-8: Unneeded variable: "ret". Return "0" on line 1390
CC: kbuild-...@lists.01.org TO: "Lubomir, Rintel," tree: git://git.kernel.org/pub/scm/linux/kernel/git/lkundrak/linux-mmp.git lr/ariel head: 744209eb6a53c65c03de1214febd58adbad72853 commit: 27998497039d2518d34ba88ddd721c2290a2e162 [61/67] XXX 88CE156 :: branch date: 9 hours ago :: commit date: 9 hours ago config: sparc-randconfig-c024-20200602 (attached as .config) compiler: sparc64-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot Reported-by: Julia Lawall coccinelle warnings: (new ones prefixed by >>) >> sound/soc/codecs/88ce156-codec.c:1341:5-8: Unneeded variable: "ret". Return >> "0" on line 1390 Please review and possibly fold the followup patch. --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] arch/x86/kernel/ftrace.c:371:59: sparse: sparse: subtraction of functions? Share your drugs
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: "Peter, Zijlstra,"
CC: Ingo Molnar
CC: Miroslav Benes
CC: Alexandre Chartre
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: f359287765c04711ff54fbd11645271d8e5ff763
commit: 0298739b7983cf9bf4fcfb4bfb815c539bdb87ca x86,ftrace: Fix
ftrace_regs_caller() unwind
date: 6 weeks ago
:: branch date: 4 hours ago
:: commit date: 6 weeks ago
config: x86_64-randconfig-s021-20200602 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout 0298739b7983cf9bf4fcfb4bfb815c539bdb87ca
# save the attached .config to linux build tree
make W=1 C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
>> arch/x86/kernel/ftrace.c:371:59: sparse: sparse: subtraction of functions?
>> Share your drugs
arch/x86/kernel/ftrace.c:40:5: sparse: sparse: context imbalance in
'ftrace_arch_code_modify_prepare' - wrong count at exit
arch/x86/kernel/ftrace.c:53:5: sparse: sparse: context imbalance in
'ftrace_arch_code_modify_post_process' - wrong count at exit
#
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0298739b7983cf9bf4fcfb4bfb815c539bdb87ca
git remote add linus
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout 0298739b7983cf9bf4fcfb4bfb815c539bdb87ca
vim +371 arch/x86/kernel/ftrace.c
d2a68c4effd821 Steven Rostedt (VMware 2018-12-08 311)
aec0be2d6e9f02 Steven Rostedt (Red Hat 2014-11-18 312) static unsigned long
aec0be2d6e9f02 Steven Rostedt (Red Hat 2014-11-18 313)
create_trampoline(struct ftrace_ops *ops, unsigned int *tramp_size)
f3bea49115b21e Steven Rostedt (Red Hat 2014-07-02 314) {
f3bea49115b21e Steven Rostedt (Red Hat 2014-07-02 315)unsigned long
start_offset;
f3bea49115b21e Steven Rostedt (Red Hat 2014-07-02 316)unsigned long
end_offset;
f3bea49115b21e Steven Rostedt (Red Hat 2014-07-02 317)unsigned long
op_offset;
768ae4406a5cab Peter Zijlstra 2019-08-26 318 unsigned long
call_offset;
f3bea49115b21e Steven Rostedt (Red Hat 2014-07-02 319)unsigned long
offset;
3c0dab44e22782 Nadav Amit 2019-04-25 320 unsigned long
npages;
f3bea49115b21e Steven Rostedt (Red Hat 2014-07-02 321)unsigned long
size;
d2a68c4effd821 Steven Rostedt (VMware 2018-12-08 322)unsigned long
retq;
f3bea49115b21e Steven Rostedt (Red Hat 2014-07-02 323)unsigned long
*ptr;
f3bea49115b21e Steven Rostedt (Red Hat 2014-07-02 324)void
*trampoline;
d2a68c4effd821 Steven Rostedt (VMware 2018-12-08 325)void *ip;
f3bea49115b21e Steven Rostedt (Red Hat 2014-07-02 326)/* 48 8b 15
is movq (%rip), %rdx */
f3bea49115b21e Steven Rostedt (Red Hat 2014-07-02 327)unsigned const
char op_ref[] = { 0x48, 0x8b, 0x15 };
f3bea49115b21e Steven Rostedt (Red Hat 2014-07-02 328)union
ftrace_op_code_union op_ptr;
f3bea49115b21e Steven Rostedt (Red Hat 2014-07-02 329)int ret;
f3bea49115b21e Steven Rostedt (Red Hat 2014-07-02 330)
f3bea49115b21e Steven Rostedt (Red Hat 2014-07-02 331)if (ops->flags
& FTRACE_OPS_FL_SAVE_REGS) {
f3bea49115b21e Steven Rostedt (Red Hat 2014-07-02 332)
start_offset = (unsigned long)ftrace_regs_caller;
f3bea49115b21e Steven Rostedt (Red Hat 2014-07-02 333)
end_offset = (unsigned long)ftrace_regs_caller_end;
f3bea49115b21e Steven Rostedt (Red Hat 2014-07-02 334)
op_offset = (unsigned long)ftrace_regs_caller_op_ptr;
768ae4406a5cab Peter Zijlstra 2019-08-26 335
call_offset = (unsigned long)ftrace_regs_call;
f3bea49115b21e Steven Rostedt (Red Hat 2014-07-02 336)} else {
f3bea49115b21e Steven Rostedt (Red Hat 2014-07-02 337)
start_offset = (unsigned long)ftrace_caller;
0298739b7983cf Peter Zijlstra 2020-04-01 338
end_offset = (unsigned long)ftrace_caller_end;
f3bea49115b21e Steven Rostedt (Red Hat 2014-07-02 339)
op_offset = (unsigned long)ftrace_caller_op_ptr;
768ae4406a5cab Peter Zijlstra 2019-08-26 340
call_offset = (unsigned long)ftrace_call;
f3bea49115b21e Steven Rostedt (Red Hat 2014-07-02 341)}
f3bea49115b21e Steven Rostedt (Red Hat 2014-07-02 342)
f3bea49115b21e Steven Rostedt (Red Hat 2014-07-02 343)size =
end_offset - start_offset;
f3bea49115b21e Steven Rostedt (Red Hat 2014-07-02 344)
f3bea49115b21e Steven Rostedt (Red Hat 2014-07-02 345)/*
f3bea49115b21e Steven Rostedt (Red Hat 2014-07-02 346)
[kbuild] [linux-review:John-Fastabend/fix-ktls-with-sk_skb_verdict-programs/20200601-011016 1888/1896] kernel/bpf/ringbuf.c:332:13: sparse: sparse: context imbalance in '__bpf_ringbuf_reserve' - diffe
CC: kbuild-...@lists.01.org
TO: "Andrii, Nakryiko,"
CC: Daniel Borkmann
tree:
https://github.com/0day-ci/linux/commits/John-Fastabend/fix-ktls-with-sk_skb_verdict-programs/20200601-011016
head: 782773c4c3638155ca2955789a3f70e090afc347
commit: 35dd30a79d27f96ab5ca28e65a869ed9e611af69 [1888/1896] bpf: Implement BPF
ring buffer and verifier support for it
:: branch date: 35 hours ago
:: commit date: 4 days ago
config: microblaze-randconfig-s031-20200602 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout 35dd30a79d27f96ab5ca28e65a869ed9e611af69
# save the attached .config to linux build tree
make W=1 C=1 ARCH=microblaze CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
>> kernel/bpf/ringbuf.c:332:13: sparse: sparse: context imbalance in
>> '__bpf_ringbuf_reserve' - different lock contexts for basic block
#
https://github.com/0day-ci/linux/commit/35dd30a79d27f96ab5ca28e65a869ed9e611af69
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 35dd30a79d27f96ab5ca28e65a869ed9e611af69
vim +/__bpf_ringbuf_reserve +332 kernel/bpf/ringbuf.c
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 331
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 @332 static void
*__bpf_ringbuf_reserve(struct bpf_ringbuf *rb, u64 size)
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 333 {
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 334 unsigned long cons_pos,
prod_pos, new_prod_pos, flags;
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 335 u32 len, pg_off;
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 336 struct bpf_ringbuf_hdr
*hdr;
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 337
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 338 if (unlikely(size >
RINGBUF_MAX_RECORD_SZ))
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 339 return NULL;
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 340
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 341 len = round_up(size +
BPF_RINGBUF_HDR_SZ, 8);
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 342 cons_pos =
smp_load_acquire(>consumer_pos);
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 343
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 344 if (in_nmi()) {
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 345 if
(!spin_trylock_irqsave(>spinlock, flags))
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 346 return
NULL;
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 347 } else {
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 348
spin_lock_irqsave(>spinlock, flags);
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 349 }
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 350
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 351 prod_pos =
rb->producer_pos;
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 352 new_prod_pos = prod_pos
+ len;
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 353
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 354 /* check for out of
ringbuf space by ensuring producer position
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 355 * doesn't advance more
than (ringbuf_size - 1) ahead
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 356 */
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 357 if (new_prod_pos -
cons_pos > rb->mask) {
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 358
spin_unlock_irqrestore(>spinlock, flags);
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 359 return NULL;
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 360 }
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 361
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 362 hdr = (void *)rb->data
+ (prod_pos & rb->mask);
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 363 pg_off =
bpf_ringbuf_rec_pg_off(rb, hdr);
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 364 hdr->len = size |
BPF_RINGBUF_BUSY_BIT;
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 365 hdr->pg_off = pg_off;
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 366
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 367 /* pairs with
consumer's smp_load_acquire() */
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 368
smp_store_release(>producer_pos, new_prod_pos);
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 369
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 370
spin_unlock_irqrestore(>spinlock, flags);
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 371
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 372 return (void *)hdr +
BPF_RINGBUF_HDR_SZ;
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 373 }
35dd30a79d27f9 Andrii Nakryiko 2020-05-29 374
---
0-DAY CI Kernel T
[kbuild] [yao:perf-intel-next 27/113] arch/x86/events/intel/uncore.c:1600 check_discovery_table() error: uninitialized symbol 'dvsec'.
CC: kbuild-...@lists.01.org
TO: "Kan, Liang,"
tree: yao/perf-intel-next
head: 36086096ecdcd11f5dfc73d2780537e2483ac70b
commit: 7033482bbd4f555901cbe7f5e8fbcc8a2618851f [27/113]
perf/x86/intel/uncore: Check discovery tables
:: branch date: 7 days ago
:: commit date: 7 weeks ago
config: i386-randconfig-m021-20200602 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
smatch warnings:
arch/x86/events/intel/uncore.c:1600 check_discovery_table() error:
uninitialized symbol 'dvsec'.
git remote add yao git://bee.sh.intel.com/git/jinyao/linux.git
git remote update yao
git checkout 7033482bbd4f555901cbe7f5e8fbcc8a2618851f
vim +/dvsec +1600 arch/x86/events/intel/uncore.c
7033482bbd4f55 Kan Liang 2020-04-13 1586
7033482bbd4f55 Kan Liang 2020-04-13 1587 bool __init
check_discovery_table(void)
7033482bbd4f55 Kan Liang 2020-04-13 1588 {
7033482bbd4f55 Kan Liang 2020-04-13 1589 struct uncore_discovery_table
*table;
7033482bbd4f55 Kan Liang 2020-04-13 1590 struct pci_dev *dev = NULL;
7033482bbd4f55 Kan Liang 2020-04-13 1591 int dvsec, logical_die = 0;
7033482bbd4f55 Kan Liang 2020-04-13 1592 u32 val, entry_id, bir;
7033482bbd4f55 Kan Liang 2020-04-13 1593 bool ret = false;
7033482bbd4f55 Kan Liang 2020-04-13 1594
7033482bbd4f55 Kan Liang 2020-04-13 1595 /*
7033482bbd4f55 Kan Liang 2020-04-13 1596* Check the existence of
discovery table by searching all PCI devices
7033482bbd4f55 Kan Liang 2020-04-13 1597* for unique capability ID.
7033482bbd4f55 Kan Liang 2020-04-13 1598*/
7033482bbd4f55 Kan Liang 2020-04-13 1599 while ((dev =
pci_get_device(PCI_VENDOR_ID_INTEL, PCI_ANY_ID, dev)) != NULL) {
7033482bbd4f55 Kan Liang 2020-04-13 @1600 while ((dvsec =
pci_find_next_ext_capability(dev, dvsec, UNCORE_EXT_CAP_ID_DISCOVERY))) {
7033482bbd4f55 Kan Liang 2020-04-13 1601
pci_read_config_dword(dev, dvsec + UNCORE_DISCOVERY_DVSEC_OFFSET, );
7033482bbd4f55 Kan Liang 2020-04-13 1602 entry_id = val
& UNCORE_DISCOVERY_DVSEC_ID_MASK;
7033482bbd4f55 Kan Liang 2020-04-13 1603 if (entry_id ==
UNCORE_DISCOVERY_DVSEC_ID_PMON) {
7033482bbd4f55 Kan Liang 2020-04-13 1604 table =
kmalloc(sizeof(struct uncore_discovery_table), GFP_KERNEL);
7033482bbd4f55 Kan Liang 2020-04-13 1605 if
(!table)
7033482bbd4f55 Kan Liang 2020-04-13 1606
continue;
7033482bbd4f55 Kan Liang 2020-04-13 1607
pci_read_config_dword(dev, dvsec + UNCORE_DISCOVERY_DVSEC2_OFFSET, );
7033482bbd4f55 Kan Liang 2020-04-13 1608 bir =
val & UNCORE_DISCOVERY_DVSEC2_BIR_MASK;
7033482bbd4f55 Kan Liang 2020-04-13 1609
table->domain = pci_domain_nr(dev->bus);
7033482bbd4f55 Kan Liang 2020-04-13 1610
table->bus = dev->bus->number;
7033482bbd4f55 Kan Liang 2020-04-13 1611
table->devfn = dev->devfn;
7033482bbd4f55 Kan Liang 2020-04-13 1612
table->bar_offset = 0x10 + (bir * 4);
7033482bbd4f55 Kan Liang 2020-04-13 1613
table->die = logical_die++;
7033482bbd4f55 Kan Liang 2020-04-13 1614 if
(discovery_table_pci2phy_map_init(dev, table->die)) {
7033482bbd4f55 Kan Liang 2020-04-13 1615
kfree(table);
7033482bbd4f55 Kan Liang 2020-04-13 1616
continue;
7033482bbd4f55 Kan Liang 2020-04-13 1617 }
7033482bbd4f55 Kan Liang 2020-04-13 1618
list_add_tail(>list, _table);
7033482bbd4f55 Kan Liang 2020-04-13 1619 ret =
true;
7033482bbd4f55 Kan Liang 2020-04-13 1620
continue;
7033482bbd4f55 Kan Liang 2020-04-13 1621 }
7033482bbd4f55 Kan Liang 2020-04-13 1622 }
7033482bbd4f55 Kan Liang 2020-04-13 1623 }
7033482bbd4f55 Kan Liang 2020-04-13 1624 pci_dev_put(dev);
7033482bbd4f55 Kan Liang 2020-04-13 1625
7033482bbd4f55 Kan Liang 2020-04-13 1626
fill_up_pbus_to_physid_mapping(true);
7033482bbd4f55 Kan Liang 2020-04-13 1627
7033482bbd4f55 Kan Liang 2020-04-13 1628 return ret;
7033482bbd4f55 Kan Liang 2020-04-13 1629 }
7033482bbd4f55 Kan Liang 2020-04-13 1630
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] kernel/bpf/cgroup.c:455 __cgroup_bpf_attach() error: we previously assumed 'link' could be null (see line 430)
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: "Andrii, Nakryiko,"
CC: Alexei Starovoitov
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: f359287765c04711ff54fbd11645271d8e5ff763
commit: af6eea57437a830293eab56246b6025cc7d46ee7 bpf: Implement bpf_link-based
cgroup BPF program attachment
date: 9 weeks ago
:: branch date: 4 hours ago
:: commit date: 9 weeks ago
config: i386-randconfig-m021-20200602 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
smatch warnings:
kernel/bpf/cgroup.c:455 __cgroup_bpf_attach() error: we previously assumed
'link' could be null (see line 430)
#
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=af6eea57437a830293eab56246b6025cc7d46ee7
git remote add linus
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout af6eea57437a830293eab56246b6025cc7d46ee7
vim +/link +455 kernel/bpf/cgroup.c
af6eea57437a83 Andrii Nakryiko2020-03-29 399
3007098494bec6 Daniel Mack2016-11-23 400 /**
af6eea57437a83 Andrii Nakryiko2020-03-29 401 * __cgroup_bpf_attach() -
Attach the program or the link to a cgroup, and
3007098494bec6 Daniel Mack2016-11-23 402 *
propagate the change to descendants
3007098494bec6 Daniel Mack2016-11-23 403 * @cgrp: The cgroup which
descendants to traverse
324bda9e6c5add Alexei Starovoitov 2017-10-02 404 * @prog: A program to attach
af6eea57437a83 Andrii Nakryiko2020-03-29 405 * @link: A link to attach
7dd68b3279f179 Andrey Ignatov 2019-12-18 406 * @replace_prog: Previously
attached program to replace if BPF_F_REPLACE is set
324bda9e6c5add Alexei Starovoitov 2017-10-02 407 * @type: Type of attach
operation
1832f4ef5867fd Valdis Kletnieks 2019-01-29 408 * @flags: Option flags
3007098494bec6 Daniel Mack2016-11-23 409 *
af6eea57437a83 Andrii Nakryiko2020-03-29 410 * Exactly one of @prog or
@link can be non-null.
3007098494bec6 Daniel Mack2016-11-23 411 * Must be called with
cgroup_mutex held.
3007098494bec6 Daniel Mack2016-11-23 412 */
af6eea57437a83 Andrii Nakryiko2020-03-29 413 int
__cgroup_bpf_attach(struct cgroup *cgrp,
af6eea57437a83 Andrii Nakryiko2020-03-29 414 struct
bpf_prog *prog, struct bpf_prog *replace_prog,
af6eea57437a83 Andrii Nakryiko2020-03-29 415 struct
bpf_cgroup_link *link,
324bda9e6c5add Alexei Starovoitov 2017-10-02 416 enum
bpf_attach_type type, u32 flags)
3007098494bec6 Daniel Mack2016-11-23 417 {
7dd68b3279f179 Andrey Ignatov 2019-12-18 418 u32 saved_flags =
(flags & (BPF_F_ALLOW_OVERRIDE | BPF_F_ALLOW_MULTI));
324bda9e6c5add Alexei Starovoitov 2017-10-02 419 struct list_head *progs
= >bpf.progs[type];
324bda9e6c5add Alexei Starovoitov 2017-10-02 420 struct bpf_prog
*old_prog = NULL;
8bad74f9840f87 Roman Gushchin 2018-09-28 421 struct
bpf_cgroup_storage *storage[MAX_BPF_CGROUP_STORAGE_TYPE],
8bad74f9840f87 Roman Gushchin 2018-09-28 422
*old_storage[MAX_BPF_CGROUP_STORAGE_TYPE] = {NULL};
af6eea57437a83 Andrii Nakryiko2020-03-29 423 struct bpf_prog_list
*pl;
324bda9e6c5add Alexei Starovoitov 2017-10-02 424 int err;
324bda9e6c5add Alexei Starovoitov 2017-10-02 425
7dd68b3279f179 Andrey Ignatov 2019-12-18 426 if (((flags &
BPF_F_ALLOW_OVERRIDE) && (flags & BPF_F_ALLOW_MULTI)) ||
7dd68b3279f179 Andrey Ignatov 2019-12-18 427 ((flags &
BPF_F_REPLACE) && !(flags & BPF_F_ALLOW_MULTI)))
324bda9e6c5add Alexei Starovoitov 2017-10-02 428 /* invalid
combination */
324bda9e6c5add Alexei Starovoitov 2017-10-02 429 return -EINVAL;
af6eea57437a83 Andrii Nakryiko2020-03-29 @430 if (link && (prog ||
replace_prog))
af6eea57437a83 Andrii Nakryiko2020-03-29 431 /* only either
link or prog/replace_prog can be specified */
af6eea57437a83 Andrii Nakryiko2020-03-29 432 return -EINVAL;
af6eea57437a83 Andrii Nakryiko2020-03-29 433 if (!!replace_prog !=
!!(flags & BPF_F_REPLACE))
af6eea57437a83 Andrii Nakryiko2020-03-29 434 /* replace_prog
implies BPF_F_REPLACE, and vice versa */
af6eea57437a83 Andrii Nakryiko2020-03-29 435 return -EINVAL;
324bda9e6c5add Alexei Starovoitov 2017-10-02 436
9fab329d6a04c0 Andrey Ignatov 2019-12-18 437 if
(!hierarchy_allows_attach(cgrp, type))
7f677633379b4a Alexei Starovoitov 2017-02-10 438 return -EPERM;
7f677633379b4a Alexei Starovoitov 2017-02-10 439
7dd68b3279f179 Andrey Ignatov 2019-12-
[kbuild] [linux-next:master 6222/14131] drivers/usb/chipidea/udc.c:477:26: sparse: sparse: bad assignment (+=) to restricted __le32
CC: kbuild-...@lists.01.org TO: "Peter, Chen," CC: Jun Li tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: e7b08814b16b80a0bf76eeca16317f8c2ed23b8c commit: e48aa1eb443f80fc6953734c805add4fb694b835 [6222/14131] usb: chipidea: udc: add software sg list support :: branch date: 4 days ago :: commit date: 4 weeks ago config: nios2-randconfig-s032-20200602 (attached as .config) compiler: nios2-linux-gcc (GCC) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.1-243-gc100a7ab-dirty git checkout e48aa1eb443f80fc6953734c805add4fb694b835 # save the attached .config to linux build tree make W=1 C=1 ARCH=nios2 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) >> drivers/usb/chipidea/udc.c:477:26: sparse: sparse: bad assignment (+=) to >> restricted __le32 include/asm-generic/io.h:179:15: sparse: sparse: cast to restricted __le32 include/asm-generic/io.h:225:22: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned int [usertype] value @@ got restricted __le32 [usertype] @@ include/asm-generic/io.h:225:22: sparse: expected unsigned int [usertype] value include/asm-generic/io.h:225:22: sparse: got restricted __le32 [usertype] include/asm-generic/io.h:179:15: sparse: sparse: cast to restricted __le32 include/asm-generic/io.h:225:22: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned int [usertype] value @@ got restricted __le32 [usertype] @@ include/asm-generic/io.h:225:22: sparse: expected unsigned int [usertype] value include/asm-generic/io.h:225:22: sparse: got restricted __le32 [usertype] include/asm-generic/io.h:179:15: sparse: sparse: cast to restricted __le32 include/asm-generic/io.h:225:22: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned int [usertype] value @@ got restricted __le32 [usertype] @@ include/asm-generic/io.h:225:22: sparse: expected unsigned int [usertype] value include/asm-generic/io.h:225:22: sparse: got restricted __le32 [usertype] include/asm-generic/io.h:179:15: sparse: sparse: cast to restricted __le32 include/asm-generic/io.h:179:15: sparse: sparse: cast to restricted __le32 include/asm-generic/io.h:225:22: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned int [usertype] value @@ got restricted __le32 [usertype] @@ include/asm-generic/io.h:225:22: sparse: expected unsigned int [usertype] value include/asm-generic/io.h:225:22: sparse: got restricted __le32 [usertype] include/asm-generic/io.h:179:15: sparse: sparse: cast to restricted __le32 include/asm-generic/io.h:179:15: sparse: sparse: cast to restricted __le32 include/asm-generic/io.h:225:22: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned int [usertype] value @@ got restricted __le32 [usertype] @@ include/asm-generic/io.h:225:22: sparse: expected unsigned int [usertype] value include/asm-generic/io.h:225:22: sparse: got restricted __le32 [usertype] include/asm-generic/io.h:179:15: sparse: sparse: cast to restricted __le32 include/asm-generic/io.h:225:22: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned int [usertype] value @@ got restricted __le32 [usertype] @@ include/asm-generic/io.h:225:22: sparse: expected unsigned int [usertype] value include/asm-generic/io.h:225:22: sparse: got restricted __le32 [usertype] include/asm-generic/io.h:179:15: sparse: sparse: cast to restricted __le32 include/asm-generic/io.h:179:15: sparse: sparse: cast to restricted __le32 include/asm-generic/io.h:179:15: sparse: sparse: cast to restricted __le32 include/asm-generic/io.h:225:22: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned int [usertype] value @@ got restricted __le32 [usertype] @@ include/asm-generic/io.h:225:22: sparse: expected unsigned int [usertype] value include/asm-generic/io.h:225:22: sparse: got restricted __le32 [usertype] include/asm-generic/io.h:179:15: sparse: sparse: cast to restricted __le32 include/asm-generic/io.h:179:15: sparse: sparse: cast to restricted __le32 include/asm-generic/io.h:179:15: sparse: sparse: cast to restricted __le32 include/asm-generic/io.h:225:22: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned int [usertype] value @@ got restricted __le32 [usertype] @@ include/asm-generic/io.h:225:22: sparse: expected unsigned int [usertype] value include/asm-generic/io.h:225:22: spars
[kbuild] [lkundrak-linux-mmp:lr/mmp3-thermal-v1 2/2] drivers/thermal/mmp3_thermal.c:65:3-9: preceding lock on line 59
CC: kbuild-...@lists.01.org
TO: "Lubomir, Rintel,"
tree: git://git.kernel.org/pub/scm/linux/kernel/git/lkundrak/linux-mmp.git
lr/mmp3-thermal-v1
head: 17256e30675ba9df02daa0722a6f1d35996322fe
commit: 17256e30675ba9df02daa0722a6f1d35996322fe [2/2] thermal driver
:: branch date: 6 weeks ago
:: commit date: 6 weeks ago
config: arm-randconfig-c003-20200602 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Julia Lawall
coccinelle warnings: (new ones prefixed by >>)
>> drivers/thermal/mmp3_thermal.c:65:3-9: preceding lock on line 59
#
https://git.kernel.org/pub/scm/linux/kernel/git/lkundrak/linux-mmp.git/commit/?id=17256e30675ba9df02daa0722a6f1d35996322fe
git remote add lkundrak-linux-mmp
git://git.kernel.org/pub/scm/linux/kernel/git/lkundrak/linux-mmp.git
git remote update lkundrak-linux-mmp
git checkout 17256e30675ba9df02daa0722a6f1d35996322fe
vim +65 drivers/thermal/mmp3_thermal.c
17256e30675ba9 Lubomir Rintel 2019-08-12 52
17256e30675ba9 Lubomir Rintel 2019-08-12 53 static unsigned long
read_temperature_sensor(struct mmp3_thermal *priv, int range, int index)
17256e30675ba9 Lubomir Rintel 2019-08-12 54 {
17256e30675ba9 Lubomir Rintel 2019-08-12 55 int i, j, gray;
17256e30675ba9 Lubomir Rintel 2019-08-12 56 unsigned long temp;
17256e30675ba9 Lubomir Rintel 2019-08-12 57 u32 val;
17256e30675ba9 Lubomir Rintel 2019-08-12 58
17256e30675ba9 Lubomir Rintel 2019-08-12 @59
mutex_lock(_thermal_sensor_mutex);
17256e30675ba9 Lubomir Rintel 2019-08-12 60
17256e30675ba9 Lubomir Rintel 2019-08-12 61 val = readl(priv->regs + index);
17256e30675ba9 Lubomir Rintel 2019-08-12 62
17256e30675ba9 Lubomir Rintel 2019-08-12 63 if (val & TEMP_EN_WDOG) {
17256e30675ba9 Lubomir Rintel 2019-08-12 64 if ((range == HIRANGE)
== ((val & TEMP_LOWRANGE) == 0))
17256e30675ba9 Lubomir Rintel 2019-08-12 @65 return 0;
17256e30675ba9 Lubomir Rintel 2019-08-12 66 }
17256e30675ba9 Lubomir Rintel 2019-08-12 67
17256e30675ba9 Lubomir Rintel 2019-08-12 68 if (range == HIRANGE) {
17256e30675ba9 Lubomir Rintel 2019-08-12 69 val &= ~TEMP_LOWRANGE;
17256e30675ba9 Lubomir Rintel 2019-08-12 70 } else {
17256e30675ba9 Lubomir Rintel 2019-08-12 71 val |= TEMP_LOWRANGE;
17256e30675ba9 Lubomir Rintel 2019-08-12 72 }
17256e30675ba9 Lubomir Rintel 2019-08-12 73
17256e30675ba9 Lubomir Rintel 2019-08-12 74 val &= ~TEMP_START;
17256e30675ba9 Lubomir Rintel 2019-08-12 75 writel(val, priv->regs + index);
17256e30675ba9 Lubomir Rintel 2019-08-12 76 usleep_range(300, 1000);
17256e30675ba9 Lubomir Rintel 2019-08-12 77
17256e30675ba9 Lubomir Rintel 2019-08-12 78 for (i = 0; i < 10; i++) {
17256e30675ba9 Lubomir Rintel 2019-08-12 79 writel(val |
TEMP_START, priv->regs + index);
17256e30675ba9 Lubomir Rintel 2019-08-12 80 for (j = 0; j < 10;
j++) {
17256e30675ba9 Lubomir Rintel 2019-08-12 81
usleep_range(300, 1000);
17256e30675ba9 Lubomir Rintel 2019-08-12 82 if
(readl(priv->regs + index) & TEMP_STATUS)
17256e30675ba9 Lubomir Rintel 2019-08-12 83 goto
done;
17256e30675ba9 Lubomir Rintel 2019-08-12 84 }
17256e30675ba9 Lubomir Rintel 2019-08-12 85 usleep_range(300, 1000);
17256e30675ba9 Lubomir Rintel 2019-08-12 86 writel(val, priv->regs
+ index);
17256e30675ba9 Lubomir Rintel 2019-08-12 87 }
17256e30675ba9 Lubomir Rintel 2019-08-12 88 done:
17256e30675ba9 Lubomir Rintel 2019-08-12 89
17256e30675ba9 Lubomir Rintel 2019-08-12 90 if (i == 10) {
17256e30675ba9 Lubomir Rintel 2019-08-12 91 printk(KERN_ERR
"mmp3_thermal: timeout reading sensor %d, range %d\n",
17256e30675ba9 Lubomir Rintel 2019-08-12 92 index, range);
17256e30675ba9 Lubomir Rintel 2019-08-12 93 writel(val, priv->regs
+ index);
17256e30675ba9 Lubomir Rintel 2019-08-12 94 temp = 0; // filtering
may fix this
17256e30675ba9 Lubomir Rintel 2019-08-12 95 } else {
17256e30675ba9 Lubomir Rintel 2019-08-12 96 gray = readl(priv->regs
+ index) & TEMP_TEMP_VALUE_MASK;
17256e30675ba9 Lubomir Rintel 2019-08-12 97 temp =
gray_to_temp[range][gray];
17256e30675ba9 Lubomir Rintel 2019-08-12 98 }
17256e30675ba9 Lubomir Rintel 2019-08-12 99
17256e30675ba9 Lubomir Rintel 2019-08-12 100
mutex_unlock(_thermal_sensor_mutex);
17256e30675ba9 Lubomir Rintel 2019-08-12 101
17256e30675ba9 Lubomir Rintel 2019-08-12 102 return temp;// return value
is tenths, C
17256e30675ba9 Lubomir Rintel 2019-08-12 103 }
17256e30675ba9 Lubomir Rintel 2019-08-12 104
---
0-DAY CI Kernel Test Service, Intel Corporation
ht
[kbuild] [linux-stable-rc:linux-4.19.y 6643/9999] kernel/sched/cpufreq.c:79:18: sparse: struct update_util_data [noderef] *
CC: kbuild-...@lists.01.org
TO: "Rafael, J., Wysocki,"
CC: "Greg Kroah-Hartman"
tree:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.19.y
head: 47f49ba00628e7ce16eda75304e947f7ddb149d1
commit: e82f0540a020da549702e042bbfbe633d6175ac1 [6643/] cpufreq: Avoid
leaving stale IRQ work items during CPU offline
:: branch date: 4 hours ago
:: commit date: 5 months ago
config: i386-randconfig-s001-20200601 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout e82f0540a020da549702e042bbfbe633d6175ac1
# save the attached .config to linux build tree
make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
kernel/sched/cpufreq.c:79:18: sparse: sparse: incompatible types in
comparison expression (different address spaces):
>> kernel/sched/cpufreq.c:79:18: sparse:struct update_util_data [noderef]
>> *
>> kernel/sched/cpufreq.c:79:18: sparse:struct update_util_data *
#
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=e82f0540a020da549702e042bbfbe633d6175ac1
git remote add linux-stable-rc
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git remote update linux-stable-rc
git checkout e82f0540a020da549702e042bbfbe633d6175ac1
vim +79 kernel/sched/cpufreq.c
e82f0540a020da Rafael J. Wysocki 2019-12-11 65
e82f0540a020da Rafael J. Wysocki 2019-12-11 66 /**
e82f0540a020da Rafael J. Wysocki 2019-12-11 67 * cpufreq_this_cpu_can_update
- Check if cpufreq policy can be updated.
e82f0540a020da Rafael J. Wysocki 2019-12-11 68 * @policy: cpufreq policy to
check.
e82f0540a020da Rafael J. Wysocki 2019-12-11 69 *
e82f0540a020da Rafael J. Wysocki 2019-12-11 70 * Return 'true' if:
e82f0540a020da Rafael J. Wysocki 2019-12-11 71 * - the local and remote CPUs
share @policy,
e82f0540a020da Rafael J. Wysocki 2019-12-11 72 * -
dvfs_possible_from_any_cpu is set in @policy and the local CPU is not going
e82f0540a020da Rafael J. Wysocki 2019-12-11 73 * offline (in which case it
is not expected to run cpufreq updates any more).
e82f0540a020da Rafael J. Wysocki 2019-12-11 74 */
e82f0540a020da Rafael J. Wysocki 2019-12-11 75 bool
cpufreq_this_cpu_can_update(struct cpufreq_policy *policy)
e82f0540a020da Rafael J. Wysocki 2019-12-11 76 {
e82f0540a020da Rafael J. Wysocki 2019-12-11 77 return
cpumask_test_cpu(smp_processor_id(), policy->cpus) ||
e82f0540a020da Rafael J. Wysocki 2019-12-11 78
(policy->dvfs_possible_from_any_cpu &&
e82f0540a020da Rafael J. Wysocki 2019-12-11 @79
rcu_dereference_sched(*this_cpu_ptr(_update_util_data)));
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] kernel/trace/ftrace.c:7171 pid_open() error: uninitialized symbol 'seq_ops'.
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: "Steven, Rostedt, (VMware),"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 9bf9511e3d9f328c03f6f79bfb741c3d18f2f2c0
commit: b3b1e6ededa4337940adba6cf06e8351056e3097 ftrace: Create
set_ftrace_notrace_pid to not trace tasks
date: 9 weeks ago
:: branch date: 70 minutes ago
:: commit date: 9 weeks ago
config: mips-randconfig-m031-20200601 (attached as .config)
compiler: mipsel-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
smatch warnings:
kernel/trace/ftrace.c:7171 pid_open() error: uninitialized symbol 'seq_ops'.
#
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b3b1e6ededa4337940adba6cf06e8351056e3097
git remote add linus
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout b3b1e6ededa4337940adba6cf06e8351056e3097
vim +/seq_ops +7171 kernel/trace/ftrace.c
b3b1e6ededa4337 Steven Rostedt (VMware 2020-03-19 7146)
b3b1e6ededa4337 Steven Rostedt (VMware 2020-03-19 7147) static int
pid_open(struct inode *inode, struct file *file, int type)
756d17ee7ee4fbc jo...@redhat.com 2009-10-13 7148 {
b3b1e6ededa4337 Steven Rostedt (VMware 2020-03-19 7149) const struct
seq_operations *seq_ops;
345ddcc882d8896 Steven Rostedt (Red Hat 2016-04-22 7150) struct
trace_array *tr = inode->i_private;
345ddcc882d8896 Steven Rostedt (Red Hat 2016-04-22 7151) struct seq_file
*m;
756d17ee7ee4fbc jo...@redhat.com 2009-10-13 7152 int ret = 0;
756d17ee7ee4fbc jo...@redhat.com 2009-10-13 7153
8530dec63e7b486 Steven Rostedt (VMware 2019-10-11 7154) ret =
tracing_check_open_get_tr(tr);
8530dec63e7b486 Steven Rostedt (VMware 2019-10-11 7155) if (ret)
8530dec63e7b486 Steven Rostedt (VMware 2019-10-11 7156) return
ret;
345ddcc882d8896 Steven Rostedt (Red Hat 2016-04-22 7157)
756d17ee7ee4fbc jo...@redhat.com 2009-10-13 7158 if
((file->f_mode & FMODE_WRITE) &&
756d17ee7ee4fbc jo...@redhat.com 2009-10-13 7159
(file->f_flags & O_TRUNC))
b3b1e6ededa4337 Steven Rostedt (VMware 2020-03-19 7160)
ftrace_pid_reset(tr, type);
b3b1e6ededa4337 Steven Rostedt (VMware 2020-03-19 7161)
b3b1e6ededa4337 Steven Rostedt (VMware 2020-03-19 7162) switch (type) {
b3b1e6ededa4337 Steven Rostedt (VMware 2020-03-19 7163) case TRACE_PIDS:
b3b1e6ededa4337 Steven Rostedt (VMware 2020-03-19 7164) seq_ops
= _pid_sops;
b3b1e6ededa4337 Steven Rostedt (VMware 2020-03-19 7165) break;
b3b1e6ededa4337 Steven Rostedt (VMware 2020-03-19 7166) case
TRACE_NO_PIDS:
b3b1e6ededa4337 Steven Rostedt (VMware 2020-03-19 7167) seq_ops
= _no_pid_sops;
b3b1e6ededa4337 Steven Rostedt (VMware 2020-03-19 7168) break;
b3b1e6ededa4337 Steven Rostedt (VMware 2020-03-19 7169) }
756d17ee7ee4fbc jo...@redhat.com 2009-10-13 7170
b3b1e6ededa4337 Steven Rostedt (VMware 2020-03-19 @7171) ret =
seq_open(file, seq_ops);
345ddcc882d8896 Steven Rostedt (Red Hat 2016-04-22 7172) if (ret < 0) {
345ddcc882d8896 Steven Rostedt (Red Hat 2016-04-22 7173)
trace_array_put(tr);
345ddcc882d8896 Steven Rostedt (Red Hat 2016-04-22 7174) } else {
345ddcc882d8896 Steven Rostedt (Red Hat 2016-04-22 7175) m =
file->private_data;
345ddcc882d8896 Steven Rostedt (Red Hat 2016-04-22 7176) /* copy
tr over to seq ops */
345ddcc882d8896 Steven Rostedt (Red Hat 2016-04-22 7177)
m->private = tr;
345ddcc882d8896 Steven Rostedt (Red Hat 2016-04-22 7178) }
756d17ee7ee4fbc jo...@redhat.com 2009-10-13 7179
756d17ee7ee4fbc jo...@redhat.com 2009-10-13 7180 return ret;
756d17ee7ee4fbc jo...@redhat.com 2009-10-13 7181 }
756d17ee7ee4fbc jo...@redhat.com 2009-10-13 7182
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [linux-next:master 5169/14131] drivers/firmware/efi/libstub/efi-stub-helper.c:390:44: sparse: expected unsigned short const [usertype] *optstr
CC: kbuild-...@lists.01.org
TO: "Arvind, Sankar,"
CC: Ard Biesheuvel
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: e7b08814b16b80a0bf76eeca16317f8c2ed23b8c
commit: f61900fd0ebf6c6b91719d63272a54f4d11051df [5169/14131] efi/libstub:
Unify initrd loading across architectures
:: branch date: 3 days ago
:: commit date: 5 weeks ago
config: i386-randconfig-s031-20200601 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout f61900fd0ebf6c6b91719d63272a54f4d11051df
# save the attached .config to linux build tree
make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
drivers/firmware/efi/libstub/efi-stub-helper.c:390:44: sparse: sparse:
incorrect type in argument 2 (different type sizes) @@ expected unsigned
short const [usertype] *optstr @@ got char * @@
>> drivers/firmware/efi/libstub/efi-stub-helper.c:390:44: sparse: expected
>> unsigned short const [usertype] *optstr
>> drivers/firmware/efi/libstub/efi-stub-helper.c:390:44: sparse: got char *
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=f61900fd0ebf6c6b91719d63272a54f4d11051df
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout f61900fd0ebf6c6b91719d63272a54f4d11051df
vim +390 drivers/firmware/efi/libstub/efi-stub-helper.c
f61900fd0ebf6c6 Arvind Sankar 2020-04-30 376
f61900fd0ebf6c6 Arvind Sankar 2020-04-30 377 static
f61900fd0ebf6c6 Arvind Sankar 2020-04-30 378 efi_status_t
efi_load_initrd_cmdline(efi_loaded_image_t *image,
f61900fd0ebf6c6 Arvind Sankar 2020-04-30 379
unsigned long *load_addr,
f61900fd0ebf6c6 Arvind Sankar 2020-04-30 380
unsigned long *load_size,
f61900fd0ebf6c6 Arvind Sankar 2020-04-30 381
unsigned long soft_limit,
f61900fd0ebf6c6 Arvind Sankar 2020-04-30 382
unsigned long hard_limit)
f61900fd0ebf6c6 Arvind Sankar 2020-04-30 383 {
f61900fd0ebf6c6 Arvind Sankar 2020-04-30 384 if
(!IS_ENABLED(CONFIG_EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER) ||
f61900fd0ebf6c6 Arvind Sankar 2020-04-30 385 (IS_ENABLED(CONFIG_X86) &&
(!efi_is_native() || image == NULL))) {
f61900fd0ebf6c6 Arvind Sankar 2020-04-30 386 *load_addr = *load_size
= 0;
f61900fd0ebf6c6 Arvind Sankar 2020-04-30 387 return EFI_SUCCESS;
f61900fd0ebf6c6 Arvind Sankar 2020-04-30 388 }
f61900fd0ebf6c6 Arvind Sankar 2020-04-30 389
f61900fd0ebf6c6 Arvind Sankar 2020-04-30 @390 return
handle_cmdline_files(image, L"initrd=", sizeof(L"initrd=") - 2,
f61900fd0ebf6c6 Arvind Sankar 2020-04-30 391
soft_limit, hard_limit,
f61900fd0ebf6c6 Arvind Sankar 2020-04-30 392
load_addr, load_size);
f61900fd0ebf6c6 Arvind Sankar 2020-04-30 393 }
f61900fd0ebf6c6 Arvind Sankar 2020-04-30 394
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] drivers/most/core.c:1287 most_register_interface() error: we previously assumed 'iface' could be null (see line 1285)
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: "Christian, Gromm,"
CC: "Greg Kroah-Hartman"
Hi Christian,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162
commit: b276527539188f1f61c082ebef27803db93e536d staging: most: move core files
out of the staging area
date: 10 weeks ago
:: branch date: 19 hours ago
:: commit date: 10 weeks ago
config: mips-randconfig-m031-20200601 (attached as .config)
compiler: mipsel-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/most/core.c:1287 most_register_interface() error: we previously assumed
'iface' could be null (see line 1285)
#
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b276527539188f1f61c082ebef27803db93e536d
git remote add linus
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout b276527539188f1f61c082ebef27803db93e536d
vim +/iface +1287 drivers/most/core.c
4d5f022f3a664e drivers/staging/most/core.c Christian Gromm
2017-11-21 1271
57562a72414ca3 drivers/staging/most/mostcore/core.c Christian Gromm
2015-07-24 1272 /**
57562a72414ca3 drivers/staging/most/mostcore/core.c Christian Gromm
2015-07-24 1273 * most_register_interface - registers an interface with core
b7937dc41362f7 drivers/staging/most/core.c Christian Gromm
2017-11-21 1274 * @iface: device interface
57562a72414ca3 drivers/staging/most/mostcore/core.c Christian Gromm
2015-07-24 1275 *
57562a72414ca3 drivers/staging/most/mostcore/core.c Christian Gromm
2015-07-24 1276 * Allocates and initializes a new interface instance and all
of its channels.
57562a72414ca3 drivers/staging/most/mostcore/core.c Christian Gromm
2015-07-24 1277 * Returns a pointer to kobject or an error pointer.
57562a72414ca3 drivers/staging/most/mostcore/core.c Christian Gromm
2015-07-24 1278 */
4d5f022f3a664e drivers/staging/most/core.c Christian Gromm
2017-11-21 1279 int most_register_interface(struct most_interface *iface)
57562a72414ca3 drivers/staging/most/mostcore/core.c Christian Gromm
2015-07-24 1280 {
57562a72414ca3 drivers/staging/most/mostcore/core.c Christian Gromm
2015-07-24 1281unsigned int i;
57562a72414ca3 drivers/staging/most/mostcore/core.c Christian Gromm
2015-07-24 1282int id;
fcb7fad82e23f6 drivers/staging/most/core.c Christian Gromm
2017-11-21 1283struct most_channel *c;
57562a72414ca3 drivers/staging/most/mostcore/core.c Christian Gromm
2015-07-24 1284
57562a72414ca3 drivers/staging/most/mostcore/core.c Christian Gromm
2015-07-24 @1285if (!iface || !iface->enqueue || !iface->configure ||
57562a72414ca3 drivers/staging/most/mostcore/core.c Christian Gromm
2015-07-24 1286!iface->poison_channel || (iface->num_channels >
MAX_CHANNELS)) {
6a82c775812944 drivers/staging/most/core.c Christian Gromm
2020-01-23 @1287dev_err(iface->dev, "Bad interface or channel
overflow\n");
4d5f022f3a664e drivers/staging/most/core.c Christian Gromm
2017-11-21 1288return -EINVAL;
57562a72414ca3 drivers/staging/most/mostcore/core.c Christian Gromm
2015-07-24 1289}
57562a72414ca3 drivers/staging/most/mostcore/core.c Christian Gromm
2015-07-24 1290
57562a72414ca3 drivers/staging/most/mostcore/core.c Christian Gromm
2015-07-24 1291id = ida_simple_get(_id, 0, 0, GFP_KERNEL);
57562a72414ca3 drivers/staging/most/mostcore/core.c Christian Gromm
2015-07-24 1292if (id < 0) {
b7935e52dd9869 drivers/staging/most/core.c Christian Gromm
2020-01-23 1293dev_err(iface->dev, "Failed to allocate device
ID\n");
4d5f022f3a664e drivers/staging/most/core.c Christian Gromm
2017-11-21 1294return id;
57562a72414ca3 drivers/staging/most/mostcore/core.c Christian Gromm
2015-07-24 1295}
57562a72414ca3 drivers/staging/most/mostcore/core.c Christian Gromm
2015-07-24 1296
9136fccf38a7aa drivers/staging/most/core.c Christian Gromm
2017-11-21 1297iface->p = kzalloc(sizeof(*iface->p), GFP_KERNEL);
9136fccf38a7aa drivers/staging/most/core.c Christian Gromm
2017-11-21 1298if (!iface->p) {
b7382d44a530cd drivers/staging/most/mostcore/core.c Christian Gromm
2015-12-22 1299ida_simple_remove(_id, id);
4d5f022f3a664e drivers/staging/most/core.c Christian Gromm
2017-11-21 1300return -ENOMEM;
57562a72414ca3 drivers/staging/most/mostcore/core.c Christian Gromm
[kbuild] [rdma:wip/jgg-for-next 81/231] drivers/infiniband/core/cm.c:2043:12: sparse: sparse: context imbalance in 'cm_req_handler' - different lock contexts for basic block
CC: kbuild-...@lists.01.org
CC: Doug Ledford
CC: Jason Gunthorpe
CC: linux-r...@vger.kernel.org
TO: "Jason, Gunthorpe,"
CC: Leon Romanovsky
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git
wip/jgg-for-next
head: 70ae395550333607bda245db5270211b6ef8ab00
commit: e83f195aa45c1ffd73b3a950a887e41c260cf194 [81/231] RDMA/cm: Pull
duplicated code into cm_queue_work_unlock()
:: branch date: 2 hours ago
:: commit date: 3 weeks ago
config: microblaze-randconfig-s032-20200601 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout e83f195aa45c1ffd73b3a950a887e41c260cf194
# save the attached .config to linux build tree
make W=1 C=1 ARCH=microblaze CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
include/linux/byteorder/big_endian.h:8:2: sparse: sparse: inconsistent
configuration, needs CONFIG_CPU_BIG_ENDIAN
drivers/infiniband/core/cm.c:1297:21: sparse: sparse: cast from restricted
__be32
drivers/infiniband/core/cm.c:936:24: sparse: sparse: context imbalance in
'cm_queue_work_unlock' - unexpected unlock
>> drivers/infiniband/core/cm.c:2043:12: sparse: sparse: context imbalance in
>> 'cm_req_handler' - different lock contexts for basic block
drivers/infiniband/core/cm.c:2422:12: sparse: sparse: context imbalance in
'cm_rep_handler' - different lock contexts for basic block
drivers/infiniband/core/cm.c:2533:12: sparse: sparse: context imbalance in
'cm_establish_handler' - different lock contexts for basic block
>> drivers/infiniband/core/cm.c:2556:12: sparse: sparse: context imbalance in
>> 'cm_rtu_handler' - different lock contexts for basic block
drivers/infiniband/core/cm.c:2770:12: sparse: sparse: context imbalance in
'cm_dreq_handler' - different lock contexts for basic block
drivers/infiniband/core/cm.c:2847:12: sparse: sparse: context imbalance in
'cm_drep_handler' - different lock contexts for basic block
drivers/infiniband/core/cm.c:2995:12: sparse: sparse: context imbalance in
'cm_rej_handler' - wrong count at exit
drivers/infiniband/core/cm.c:3153:12: sparse: sparse: context imbalance in
'cm_mra_handler' - different lock contexts for basic block
drivers/infiniband/core/cm.c:3271:12: sparse: sparse: context imbalance in
'cm_lap_handler' - different lock contexts for basic block
>> drivers/infiniband/core/cm.c:3360:12: sparse: sparse: context imbalance in
>> 'cm_apr_handler' - different lock contexts for basic block
>> drivers/infiniband/core/cm.c:3405:12: sparse: sparse: context imbalance in
>> 'cm_timewait_handler' - different lock contexts for basic block
#
https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?id=e83f195aa45c1ffd73b3a950a887e41c260cf194
git remote add rdma
https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git
git remote update rdma
git checkout e83f195aa45c1ffd73b3a950a887e41c260cf194
vim +/cm_req_handler +2043 drivers/infiniband/core/cm.c
3971c9f6dbf26f Sean Hefty 2007-12-10 2042
a977049dacdef6 Hal Rosenstock 2005-07-27 @2043 static int
cm_req_handler(struct cm_work *work)
a977049dacdef6 Hal Rosenstock 2005-07-27 2044 {
a977049dacdef6 Hal Rosenstock 2005-07-27 2045 struct
cm_id_private *cm_id_priv, *listen_cm_id_priv;
a977049dacdef6 Hal Rosenstock 2005-07-27 2046 struct
cm_req_msg *req_msg;
d8966fcd4c2570 Dasaratharaman Chandramouli 2017-04-29 2047 const struct
ib_global_route *grh;
a8872d53e9b7fc Parav Pandit2018-06-19 2048 const struct
ib_gid_attr *gid_attr;
a977049dacdef6 Hal Rosenstock 2005-07-27 2049 int ret;
a977049dacdef6 Hal Rosenstock 2005-07-27 2050
a977049dacdef6 Hal Rosenstock 2005-07-27 2051 req_msg =
(struct cm_req_msg *)work->mad_recv_wc->recv_buf.mad;
a977049dacdef6 Hal Rosenstock 2005-07-27 2052
c206f8bad15d30 Jason Gunthorpe 2020-03-10 2053 cm_id_priv =
c206f8bad15d30 Jason Gunthorpe 2020-03-10 2054
cm_alloc_id_priv(work->port->cm_dev->ib_device, NULL, NULL);
c206f8bad15d30 Jason Gunthorpe 2020-03-10 2055 if
(IS_ERR(cm_id_priv))
c206f8bad15d30 Jason Gunthorpe 2020-03-10 2056 return
PTR_ERR(cm_id_priv);
a977049dacdef6 Hal Rosenstock 2005-07-27 2057
91b60a7128d962 Jason Gunthorpe 2020-01-16 2058
cm_id_priv->id.remote_id =
91b60a7128d962 Jason Gunthorpe 2020-01-16 2059
cpu_to_be32(IBA_GET(CM_REQ_LOCAL_COMM_ID, req_msg));
c206f8bad15d30 Jason Gunthorpe 2020-03-10 2060
[kbuild] [linux-next:master 3942/14131] drivers/char/random.c:2117:35: sparse: expected int ( [usertype] *proc_handler )( ... )
CC: kbuild-...@lists.01.org
TO: "Christoph, Hellwig,"
CC: Al Viro
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: e7b08814b16b80a0bf76eeca16317f8c2ed23b8c
commit: 32927393dc1ccd60fb2bdc05b9e8e88753761469 [3942/14131] sysctl: pass
kernel pointers to ->proc_handler
:: branch date: 3 days ago
:: commit date: 5 weeks ago
config: i386-randconfig-s002-20200601 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout 32927393dc1ccd60fb2bdc05b9e8e88753761469
# save the attached .config to linux build tree
make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
drivers/char/random.c:2100:50: sparse: sparse: incorrect type in argument 3
(different address spaces) @@ expected void * @@ got void [noderef]
*buffer @@
drivers/char/random.c:2100:50: sparse: expected void *
drivers/char/random.c:2100:50: sparse: got void [noderef] *buffer
drivers/char/random.c:2117:35: sparse: sparse: incorrect type in initializer
(incompatible argument 3 (different address spaces)) @@ expected int (
[usertype] *proc_handler )( ... ) @@ got int ( * )( ... ) @@
>> drivers/char/random.c:2117:35: sparse: expected int ( [usertype]
>> *proc_handler )( ... )
drivers/char/random.c:2117:35: sparse: got int ( * )( ... )
--
drivers/cdrom/cdrom.c:3597:42: sparse: sparse: incorrect type in argument 3
(different address spaces) @@ expected void * @@ got void [noderef]
*buffer @@
>> drivers/cdrom/cdrom.c:3597:42: sparse: expected void *
drivers/cdrom/cdrom.c:3597:42: sparse: got void [noderef] *buffer
drivers/cdrom/cdrom.c:3665:35: sparse: sparse: incorrect type in initializer
(incompatible argument 3 (different address spaces)) @@ expected int (
[usertype] *proc_handler )( ... ) @@ got int ( * )( ... ) @@
drivers/cdrom/cdrom.c:3665:35: sparse: expected int ( [usertype]
*proc_handler )( ... )
drivers/cdrom/cdrom.c:3665:35: sparse: got int ( * )( ... )
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=32927393dc1ccd60fb2bdc05b9e8e88753761469
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout 32927393dc1ccd60fb2bdc05b9e8e88753761469
vim +2117 drivers/char/random.c
a283b5c459784f H. Peter Anvin2013-09-10 2102
^1da177e4c3f41 Linus Torvalds2005-04-16 2103 static int sysctl_poolsize =
INPUT_POOL_WORDS * 32;
a151427ed08695 Joe Perches 2013-06-13 2104 extern struct ctl_table
random_table[];
a151427ed08695 Joe Perches 2013-06-13 2105 struct ctl_table
random_table[] = {
^1da177e4c3f41 Linus Torvalds2005-04-16 2106 {
^1da177e4c3f41 Linus Torvalds2005-04-16 2107 .procname
= "poolsize",
^1da177e4c3f41 Linus Torvalds2005-04-16 2108 .data
= _poolsize,
^1da177e4c3f41 Linus Torvalds2005-04-16 2109 .maxlen
= sizeof(int),
^1da177e4c3f41 Linus Torvalds2005-04-16 2110 .mode
= 0444,
6d4561110a3e9f Eric W. Biederman 2009-11-16 2111 .proc_handler
= proc_dointvec,
^1da177e4c3f41 Linus Torvalds2005-04-16 2112 },
^1da177e4c3f41 Linus Torvalds2005-04-16 2113 {
^1da177e4c3f41 Linus Torvalds2005-04-16 2114 .procname
= "entropy_avail",
^1da177e4c3f41 Linus Torvalds2005-04-16 2115 .maxlen
= sizeof(int),
^1da177e4c3f41 Linus Torvalds2005-04-16 2116 .mode
= 0444,
a283b5c459784f H. Peter Anvin2013-09-10 @2117 .proc_handler
= proc_do_entropy,
^1da177e4c3f41 Linus Torvalds2005-04-16 2118 .data
= _pool.entropy_count,
^1da177e4c3f41 Linus Torvalds2005-04-16 2119 },
^1da177e4c3f41 Linus Torvalds2005-04-16 2120 {
^1da177e4c3f41 Linus Torvalds2005-04-16 2121 .procname
= "write_wakeup_threshold",
2132a96f66b6b4 Greg Price2013-12-06 2122 .data
= _write_wakeup_bits,
^1da177e4c3f41 Linus Torvalds2005-04-16 2123 .maxlen
= sizeof(int),
^1da177e4c3f41 Linus Torvalds2005-04-16 2124 .mode
= 0644,
6d4561110a3e9f Eric W. Biederman 2009-11-16 2125 .proc_handler
= proc_dointvec_minmax,
^1da177e4c3f41 Linus Torvalds2005-04-16 2126 .extra1
= _write_thresh,
^1da177e4c3f41 Linus Torvalds2005-04-16 2127 .extra2
= _write_thresh,
^1da177e4c3f41
[kbuild] [linux-next:master 4096/14131] net/bridge/br_mrp.c:109:21: sparse: expected unsigned short [usertype] seq_id
CC: kbuild-...@lists.01.org TO: "Horatiu, Vultur," tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: e7b08814b16b80a0bf76eeca16317f8c2ed23b8c commit: 9a9f26e8f7ea300e8efffcae036dbef239be433a [4096/14131] bridge: mrp: Connect MRP API with the switchdev API :: branch date: 3 days ago :: commit date: 5 weeks ago config: microblaze-randconfig-s032-20200601 (attached as .config) compiler: microblaze-linux-gcc (GCC) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.1-243-gc100a7ab-dirty git checkout 9a9f26e8f7ea300e8efffcae036dbef239be433a # save the attached .config to linux build tree make W=1 C=1 ARCH=microblaze CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) include/linux/byteorder/big_endian.h:8:2: sparse: sparse: inconsistent configuration, needs CONFIG_CPU_BIG_ENDIAN net/bridge/br_mrp.c:86:18: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] @@ got restricted __be16 [usertype] @@ net/bridge/br_mrp.c:86:18: sparse: expected unsigned short [usertype] net/bridge/br_mrp.c:86:18: sparse: got restricted __be16 [usertype] net/bridge/br_mrp.c:109:21: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] seq_id @@ got restricted __be16 [usertype] @@ >> net/bridge/br_mrp.c:109:21: sparse: expected unsigned short [usertype] >> seq_id net/bridge/br_mrp.c:109:21: sparse: got restricted __be16 [usertype] net/bridge/br_mrp.c:130:19: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] prio @@ got restricted __be16 [usertype] @@ >> net/bridge/br_mrp.c:130:19: sparse: expected unsigned short [usertype] >> prio net/bridge/br_mrp.c:130:19: sparse: got restricted __be16 [usertype] net/bridge/br_mrp.c:132:24: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] port_role @@ got restricted __be16 [usertype] @@ >> net/bridge/br_mrp.c:132:24: sparse: expected unsigned short [usertype] >> port_role net/bridge/br_mrp.c:132:24: sparse: got restricted __be16 [usertype] net/bridge/br_mrp.c:133:20: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] state @@ got restricted __be16 [usertype] @@ >> net/bridge/br_mrp.c:133:20: sparse: expected unsigned short [usertype] >> state net/bridge/br_mrp.c:133:20: sparse: got restricted __be16 [usertype] net/bridge/br_mrp.c:134:26: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] transitions @@ got restricted __be16 [usertype] @@ >> net/bridge/br_mrp.c:134:26: sparse: expected unsigned short [usertype] >> transitions net/bridge/br_mrp.c:134:26: sparse: got restricted __be16 [usertype] net/bridge/br_mrp.c:135:24: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] timestamp @@ got restricted __be32 [usertype] @@ >> net/bridge/br_mrp.c:135:24: sparse: expected unsigned int [usertype] >> timestamp >> net/bridge/br_mrp.c:135:24: sparse: got restricted __be32 [usertype] net/bridge/br_mrp.c:234:23: sparse: sparse: incorrect type in argument 1 (different modifiers) @@ expected struct list_head *entry @@ got struct list_head [noderef] * @@ net/bridge/br_mrp.c:234:23: sparse: expected struct list_head *entry net/bridge/br_mrp.c:234:23: sparse: got struct list_head [noderef] * net/bridge/br_mrp.c:279:28: sparse: sparse: incorrect type in argument 1 (different modifiers) @@ expected struct list_head *new @@ got struct list_head [noderef] * @@ net/bridge/br_mrp.c:279:28: sparse: expected struct list_head *new net/bridge/br_mrp.c:279:28: sparse: got struct list_head [noderef] * net/bridge/br_mrp.c:279:40: sparse: sparse: incorrect type in argument 2 (different modifiers) @@ expected struct list_head *head @@ got struct list_head [noderef] * @@ net/bridge/br_mrp.c:279:40: sparse: expected struct list_head *head net/bridge/br_mrp.c:279:40: sparse: got struct list_head [noderef] * net/bridge/br_mrp.c:296:6: sparse: sparse: symbol 'br_mrp_port_del' was not declared. Should it be static? net/bridge/br_mrp.c:543:5: sparse: sparse: symbol 'br_mrp_process' was not declared. Should it be static? net/bridge/br_mrp.c:558:29: sparse: sparse: incorrect type in argument 1 (different modifiers) @@ expected struct list_head const *head @@ g
[kbuild] [linux-next:master 4070/14131] kernel/rcu/tasks.h:824:17: sparse: sparse: dubious: x & !y
CC: kbuild-...@lists.01.org
TO: "Paul, E., McKenney,"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: e7b08814b16b80a0bf76eeca16317f8c2ed23b8c
commit: 7e3b70e0703b48e120c3f5e65498790341120fad [4070/14131] rcu-tasks: Handle
the running-offline idle-task special case
:: branch date: 3 days ago
:: commit date: 5 weeks ago
config: i386-randconfig-s002-20200601 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout 7e3b70e0703b48e120c3f5e65498790341120fad
# save the attached .config to linux build tree
make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
kernel/rcu/tasks.h:418:6: sparse: sparse: symbol 'rcu_tasks_postscan' was
not declared. Should it be static?
kernel/rcu/tasks.h:715:20: sparse: sparse: symbol 'rcu_trace_lock_map' was
not declared. Should it be static?
kernel/rcu/tasks.h:722:10: sparse: sparse: symbol 'trc_n_readers_need_end'
was not declared. Should it be static?
kernel/rcu/tasks.h:723:1: sparse: sparse: symbol 'trc_wait' was not
declared. Should it be static?
kernel/rcu/tasks.h:743:6: sparse: sparse: symbol
'rcu_read_unlock_trace_special' was not declared. Should it be static?
>> kernel/rcu/tasks.h:824:17: sparse: sparse: dubious: x & !y
kernel/rcu/tasks.h:1108:6: sparse: sparse: symbol
'synchronize_rcu_tasks_trace' was not declared. Should it be static?
kernel/rcu/tasks.h:1121:6: sparse: sparse: symbol 'rcu_barrier_tasks_trace'
was not declared. Should it be static?
kernel/rcu/tasks.h:1153:6: sparse: sparse: symbol
'show_rcu_tasks_gp_kthreads' was not declared. Should it be static?
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=7e3b70e0703b48e120c3f5e65498790341120fad
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout 7e3b70e0703b48e120c3f5e65498790341120fad
vim +824 kernel/rcu/tasks.h
d5f177d35c2442 Paul E. McKenney 2020-03-09 815
d5f177d35c2442 Paul E. McKenney 2020-03-09 816 /* Callback function for
scheduler to check locked-down task. */
d5f177d35c2442 Paul E. McKenney 2020-03-09 817 static bool
trc_inspect_reader(struct task_struct *t, void *arg)
d5f177d35c2442 Paul E. McKenney 2020-03-09 818 {
7d0c9c50c5a109 Paul E. McKenney 2020-03-19 819 int cpu = task_cpu(t);
7d0c9c50c5a109 Paul E. McKenney 2020-03-19 820 bool in_qs = false;
7e3b70e0703b48 Paul E. McKenney 2020-03-22 821 bool ofl =
cpu_is_offline(cpu);
7d0c9c50c5a109 Paul E. McKenney 2020-03-19 822
7d0c9c50c5a109 Paul E. McKenney 2020-03-19 823 if (task_curr(t)) {
7e3b70e0703b48 Paul E. McKenney 2020-03-22 @824
WARN_ON_ONCE(ofl & !is_idle_task(t));
7e3b70e0703b48 Paul E. McKenney 2020-03-22 825
7d0c9c50c5a109 Paul E. McKenney 2020-03-19 826 // If no chance
of heavyweight readers, do it the hard way.
7e3b70e0703b48 Paul E. McKenney 2020-03-22 827 if (!ofl &&
!IS_ENABLED(CONFIG_TASKS_TRACE_RCU_READ_MB))
7d0c9c50c5a109 Paul E. McKenney 2020-03-19 828 return
false;
7d0c9c50c5a109 Paul E. McKenney 2020-03-19 829
7d0c9c50c5a109 Paul E. McKenney 2020-03-19 830 // If
heavyweight readers are enabled on the remote task,
7d0c9c50c5a109 Paul E. McKenney 2020-03-19 831 // we can
inspect its state despite its currently running.
7d0c9c50c5a109 Paul E. McKenney 2020-03-19 832 // However, we
cannot safely change its state.
7e3b70e0703b48 Paul E. McKenney 2020-03-22 833 if (!ofl && //
Check for "running" idle tasks on offline CPUs.
7e3b70e0703b48 Paul E. McKenney 2020-03-22 834
!rcu_dynticks_zero_in_eqs(cpu, >trc_reader_nesting))
7d0c9c50c5a109 Paul E. McKenney 2020-03-19 835 return
false; // No quiescent state, do it the hard way.
7d0c9c50c5a109 Paul E. McKenney 2020-03-19 836 in_qs = true;
7d0c9c50c5a109 Paul E. McKenney 2020-03-19 837 } else {
7d0c9c50c5a109 Paul E. McKenney 2020-03-19 838 in_qs =
likely(!t->trc_reader_nesting);
7d0c9c50c5a109 Paul E. McKenney 2020-03-19 839 }
d5f177d35c2442 Paul E. McKenney 2020-03-09 840
d5f177d35c2442 Paul E. McKenney 2020-03-09 841 // Mark as checked.
Because this is called from the grace-period
d5f177d35c2442 Paul E. McKenney 2020-03-09 842 // kthread, also remove
the task from the holdout list.
d5f177d35c2442 Paul E. McKenney 2020-03-09 843 t->trc_reader_checked =
true;
d5f177d35c2442 Paul E. McKenney
[kbuild] [linux-next:master 3942/14131] net/core/sysctl_net_core.c:129:42: sparse: got void *buffer
CC: kbuild-...@lists.01.org
TO: "Christoph, Hellwig,"
CC: Al Viro
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: e7b08814b16b80a0bf76eeca16317f8c2ed23b8c
commit: 32927393dc1ccd60fb2bdc05b9e8e88753761469 [3942/14131] sysctl: pass
kernel pointers to ->proc_handler
:: branch date: 3 days ago
:: commit date: 5 weeks ago
config: i386-randconfig-s001-20200601 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout 32927393dc1ccd60fb2bdc05b9e8e88753761469
# save the attached .config to linux build tree
make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
net/core/sysctl_net_core.c:129:42: sparse: sparse: incorrect type in
argument 1 (different address spaces) @@ expected char const [noderef]
*buf @@ got void *buffer @@
net/core/sysctl_net_core.c:129:42: sparse: expected char const [noderef]
*buf
>> net/core/sysctl_net_core.c:129:42: sparse: got void *buffer
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=32927393dc1ccd60fb2bdc05b9e8e88753761469
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout 32927393dc1ccd60fb2bdc05b9e8e88753761469
vim +129 net/core/sysctl_net_core.c
99bbc70741903c Willem de Bruijn 2013-05-20 116
fe2c6338fd2c6f Joe Perches 2013-06-11 117 static int
flow_limit_cpu_sysctl(struct ctl_table *table, int write,
32927393dc1ccd Christoph Hellwig 2020-04-24 118
void *buffer, size_t *lenp, loff_t *ppos)
99bbc70741903c Willem de Bruijn 2013-05-20 119 {
99bbc70741903c Willem de Bruijn 2013-05-20 120struct sd_flow_limit
*cur;
99bbc70741903c Willem de Bruijn 2013-05-20 121struct softnet_data *sd;
99bbc70741903c Willem de Bruijn 2013-05-20 122cpumask_var_t mask;
99bbc70741903c Willem de Bruijn 2013-05-20 123int i, len, ret = 0;
99bbc70741903c Willem de Bruijn 2013-05-20 124
99bbc70741903c Willem de Bruijn 2013-05-20 125if
(!alloc_cpumask_var(, GFP_KERNEL))
99bbc70741903c Willem de Bruijn 2013-05-20 126return -ENOMEM;
99bbc70741903c Willem de Bruijn 2013-05-20 127
99bbc70741903c Willem de Bruijn 2013-05-20 128if (write) {
99bbc70741903c Willem de Bruijn 2013-05-20 @129ret =
cpumask_parse_user(buffer, *lenp, mask);
99bbc70741903c Willem de Bruijn 2013-05-20 130if (ret)
99bbc70741903c Willem de Bruijn 2013-05-20 131goto
done;
99bbc70741903c Willem de Bruijn 2013-05-20 132
99bbc70741903c Willem de Bruijn 2013-05-20 133
mutex_lock(_limit_update_mutex);
99bbc70741903c Willem de Bruijn 2013-05-20 134len =
sizeof(*cur) + netdev_flow_limit_table_len;
99bbc70741903c Willem de Bruijn 2013-05-20 135
for_each_possible_cpu(i) {
99bbc70741903c Willem de Bruijn 2013-05-20 136sd =
_cpu(softnet_data, i);
99bbc70741903c Willem de Bruijn 2013-05-20 137cur =
rcu_dereference_protected(sd->flow_limit,
99bbc70741903c Willem de Bruijn 2013-05-20 138
lockdep_is_held(_limit_update_mutex));
99bbc70741903c Willem de Bruijn 2013-05-20 139if (cur
&& !cpumask_test_cpu(i, mask)) {
99bbc70741903c Willem de Bruijn 2013-05-20 140
RCU_INIT_POINTER(sd->flow_limit, NULL);
99bbc70741903c Willem de Bruijn 2013-05-20 141
synchronize_rcu();
99bbc70741903c Willem de Bruijn 2013-05-20 142
kfree(cur);
99bbc70741903c Willem de Bruijn 2013-05-20 143} else
if (!cur && cpumask_test_cpu(i, mask)) {
5b59d467ad9ff9 Eric Dumazet 2013-12-18 144
cur = kzalloc_node(len, GFP_KERNEL,
5b59d467ad9ff9 Eric Dumazet 2013-12-18 145
cpu_to_node(i));
99bbc70741903c Willem de Bruijn 2013-05-20 146
if (!cur) {
99bbc70741903c Willem de Bruijn 2013-05-20 147
/* not unwinding previous changes */
99bbc70741903c Willem de Bruijn 2013-05-20 148
ret = -ENOMEM;
99bbc70741903c Willem de Bruijn 2013-05-20 149
goto write_unlock;
99bbc70741903c Willem de Bruijn 2013-05-20 150
}
99bbc70741903c Willem de Bruijn 2013-05-20 151
[kbuild] [linux-next:master 465/14131] include/asm-generic/bitops/instrumented-lock.h:40:25: sparse: sparse: context imbalance in 'dm_exception_table_unlock' - unexpected unlock
CC: kbuild-...@lists.01.org
TO: "Marco, Elver,"
CC: Ingo Molnar
CC: "Paul E. McKenney"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: e7b08814b16b80a0bf76eeca16317f8c2ed23b8c
commit: 27f937cc810aef63b0752f5bfbf383390dd076a1 [465/14131] asm-generic,
kcsan: Add KCSAN instrumentation for bitops
:: branch date: 3 days ago
:: commit date: 2 months ago
config: x86_64-randconfig-s022-20200601 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout 27f937cc810aef63b0752f5bfbf383390dd076a1
# save the attached .config to linux build tree
make W=1 C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
drivers/md/dm-snap.c:642:13: sparse: sparse: context imbalance in
'dm_exception_table_lock' - wrong count at exit
>> include/asm-generic/bitops/instrumented-lock.h:40:25: sparse: sparse:
>> context imbalance in 'dm_exception_table_unlock' - unexpected unlock
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=27f937cc810aef63b0752f5bfbf383390dd076a1
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout 27f937cc810aef63b0752f5bfbf383390dd076a1
vim +/dm_exception_table_unlock +40
include/asm-generic/bitops/instrumented-lock.h
81d2c6f81996e0 Daniel Axtens 2019-08-20 28
81d2c6f81996e0 Daniel Axtens 2019-08-20 29 /**
81d2c6f81996e0 Daniel Axtens 2019-08-20 30 * __clear_bit_unlock - Clears a
bit in memory
81d2c6f81996e0 Daniel Axtens 2019-08-20 31 * @nr: Bit to clear
81d2c6f81996e0 Daniel Axtens 2019-08-20 32 * @addr: Address to start
counting from
81d2c6f81996e0 Daniel Axtens 2019-08-20 33 *
81d2c6f81996e0 Daniel Axtens 2019-08-20 34 * This is a non-atomic operation
but implies a release barrier before the
81d2c6f81996e0 Daniel Axtens 2019-08-20 35 * memory operation. It can be
used for an unlock if no other CPUs can
81d2c6f81996e0 Daniel Axtens 2019-08-20 36 * concurrently modify other bits
in the word.
81d2c6f81996e0 Daniel Axtens 2019-08-20 37 */
81d2c6f81996e0 Daniel Axtens 2019-08-20 38 static inline void
__clear_bit_unlock(long nr, volatile unsigned long *addr)
81d2c6f81996e0 Daniel Axtens 2019-08-20 39 {
27f937cc810aef Marco Elver 2020-01-21 @40 instrument_write(addr +
BIT_WORD(nr), sizeof(long));
81d2c6f81996e0 Daniel Axtens 2019-08-20 41 arch___clear_bit_unlock(nr,
addr);
81d2c6f81996e0 Daniel Axtens 2019-08-20 42 }
81d2c6f81996e0 Daniel Axtens 2019-08-20 43
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [linux-next:master 4817/14131] drivers/net/ethernet/broadcom/genet/bcmgenet.c:688:24: sparse: expected unsigned short [usertype] val_16
CC: kbuild-...@lists.01.org
TO: "Doug, Berger,"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: e7b08814b16b80a0bf76eeca16317f8c2ed23b8c
commit: 3e370952287c55e5fd240cb8bb41ef8acff8829d [4817/14131] net: bcmgenet:
add support for ethtool rxnfc flows
:: branch date: 3 days ago
:: commit date: 5 weeks ago
config: i386-randconfig-s001-20200601 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout 3e370952287c55e5fd240cb8bb41ef8acff8829d
# save the attached .config to linux build tree
make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
drivers/net/ethernet/broadcom/genet/bcmgenet.c:688:24: sparse: sparse:
incorrect type in assignment (different base types) @@ expected unsigned
short [usertype] val_16 @@ got restricted __be16 [usertype] @@
>> drivers/net/ethernet/broadcom/genet/bcmgenet.c:688:24: sparse: expected
>> unsigned short [usertype] val_16
drivers/net/ethernet/broadcom/genet/bcmgenet.c:688:24: sparse: got
restricted __be16 [usertype]
drivers/net/ethernet/broadcom/genet/bcmgenet.c:782:5: sparse: sparse: symbol
'bcmgenet_hfb_add_filter' was not declared. Should it be static?
include/linux/netdevice.h:4052:20: sparse: sparse: shift count is negative
(-1)
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=3e370952287c55e5fd240cb8bb41ef8acff8829d
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout 3e370952287c55e5fd240cb8bb41ef8acff8829d
vim +688 drivers/net/ethernet/broadcom/genet/bcmgenet.c
3e370952287c55 Doug Berger 2020-04-29 631
3e370952287c55 Doug Berger 2020-04-29 632 static int
bcmgenet_hfb_create_rxnfc_filter(struct bcmgenet_priv *priv,
3e370952287c55 Doug Berger 2020-04-29 633
struct bcmgenet_rxnfc_rule *rule)
3e370952287c55 Doug Berger 2020-04-29 634 {
3e370952287c55 Doug Berger 2020-04-29 635 struct ethtool_rx_flow_spec *fs
= >fs;
3e370952287c55 Doug Berger 2020-04-29 636 int err = 0, offset = 0,
f_length = 0;
3e370952287c55 Doug Berger 2020-04-29 637 u16 val_16, mask_16;
3e370952287c55 Doug Berger 2020-04-29 638 u8 val_8, mask_8;
3e370952287c55 Doug Berger 2020-04-29 639 size_t size;
3e370952287c55 Doug Berger 2020-04-29 640 u32 *f_data;
3e370952287c55 Doug Berger 2020-04-29 641
3e370952287c55 Doug Berger 2020-04-29 642 f_data =
kcalloc(priv->hw_params->hfb_filter_size, sizeof(u32),
3e370952287c55 Doug Berger 2020-04-29 643 GFP_KERNEL);
3e370952287c55 Doug Berger 2020-04-29 644 if (!f_data)
3e370952287c55 Doug Berger 2020-04-29 645 return -ENOMEM;
3e370952287c55 Doug Berger 2020-04-29 646
3e370952287c55 Doug Berger 2020-04-29 647 if (fs->flow_type &
FLOW_MAC_EXT) {
3e370952287c55 Doug Berger 2020-04-29 648
bcmgenet_hfb_insert_data(f_data, 0,
3e370952287c55 Doug Berger 2020-04-29 649
>h_ext.h_dest, >m_ext.h_dest,
3e370952287c55 Doug Berger 2020-04-29 650
sizeof(fs->h_ext.h_dest));
3e370952287c55 Doug Berger 2020-04-29 651 }
3e370952287c55 Doug Berger 2020-04-29 652
3e370952287c55 Doug Berger 2020-04-29 653 if (fs->flow_type & FLOW_EXT) {
3e370952287c55 Doug Berger 2020-04-29 654 if
(fs->m_ext.vlan_etype ||
3e370952287c55 Doug Berger 2020-04-29 655 fs->m_ext.vlan_tci)
{
3e370952287c55 Doug Berger 2020-04-29 656
bcmgenet_hfb_insert_data(f_data, 12,
3e370952287c55 Doug Berger 2020-04-29 657
>h_ext.vlan_etype,
3e370952287c55 Doug Berger 2020-04-29 658
>m_ext.vlan_etype,
3e370952287c55 Doug Berger 2020-04-29 659
sizeof(fs->h_ext.vlan_etype));
3e370952287c55 Doug Berger 2020-04-29 660
bcmgenet_hfb_insert_data(f_data, 14,
3e370952287c55 Doug Berger 2020-04-29 661
>h_ext.vlan_tci,
3e370952287c55 Doug Berger 2020-04-29 662
>m_ext.vlan_tci,
3e370952287c55 Doug Berger 2020-04-29 663
sizeof(fs->h_ext.vlan_tci));
3e370952287c55 Doug Berger 2020-04-29 664 offset +=
VLAN_HLEN;
3e370952287c55 Doug Berger 2020-04-29 665 f_length +=
DIV_ROUND_UP(VLAN_HLEN, 2);
3e370952287
[kbuild] security/keys/keyring.c:93:27: sparse: expected long ( *read )( ... )
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: "Waiman, Long,"
CC: David Howells
CC: Jarkko Sakkinen
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162
commit: d3ec10aa95819bff18a0d936b18884c7816d0914 KEYS: Don't write out to
userspace while holding key semaphore
date: 9 weeks ago
:: branch date: 16 hours ago
:: commit date: 9 weeks ago
config: i386-randconfig-s001-20200601 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout d3ec10aa95819bff18a0d936b18884c7816d0914
# save the attached .config to linux build tree
make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
security/keys/keyring.c:93:27: sparse: sparse: incorrect type in initializer
(incompatible argument 2 (different address spaces)) @@ expected long (
*read )( ... ) @@ got long ( * )( ... ) @@
>> security/keys/keyring.c:93:27: sparse: expected long ( *read )( ... )
security/keys/keyring.c:93:27: sparse: got long ( * )( ... )
security/keys/keyring.c:469:21: sparse: sparse: dereference of noderef
expression
security/keys/keyring.c:1234:5: sparse: sparse: context imbalance in
'__key_link_lock' - wrong count at exit
security/keys/keyring.c:1256:5: sparse: sparse: context imbalance in
'__key_move_lock' - wrong count at exit
security/keys/keyring.c:1396:9: sparse: sparse: context imbalance in
'__key_link_end' - wrong count at exit
security/keys/keyring.c:1459:9: sparse: sparse: context imbalance in
'key_link' - wrong count at exit
security/keys/keyring.c:1467:12: sparse: sparse: context imbalance in
'__key_unlink_lock' - wrong count at exit
security/keys/keyring.c:1520:9: sparse: sparse: context imbalance in
'__key_unlink_end' - wrong count at exit
security/keys/keyring.c:1540:5: sparse: sparse: context imbalance in
'key_unlink' - wrong count at exit
security/keys/keyring.c:1585:5: sparse: sparse: context imbalance in
'key_move' - different lock contexts for basic block
#
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d3ec10aa95819bff18a0d936b18884c7816d0914
git remote add linus
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout d3ec10aa95819bff18a0d936b18884c7816d0914
vim +93 security/keys/keyring.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 68
^1da177e4c3f41 Linus Torvalds 2005-04-16 69 /*
973c9f4f49ca96 David Howells 2011-01-20 70 * The keyring key type
definition. Keyrings are simply keys of this type and
973c9f4f49ca96 David Howells 2011-01-20 71 * can be treated as ordinary
keys in addition to having their own special
973c9f4f49ca96 David Howells 2011-01-20 72 * operations.
^1da177e4c3f41 Linus Torvalds 2005-04-16 73 */
5d19e20b534ff4 David Howells 2014-07-18 74 static int
keyring_preparse(struct key_preparsed_payload *prep);
5d19e20b534ff4 David Howells 2014-07-18 75 static void
keyring_free_preparse(struct key_preparsed_payload *prep);
^1da177e4c3f41 Linus Torvalds 2005-04-16 76 static int
keyring_instantiate(struct key *keyring,
cf7f601c067994 David Howells 2012-09-13 77 struct
key_preparsed_payload *prep);
31204ed925b067 David Howells 2006-06-26 78 static void keyring_revoke(struct
key *keyring);
^1da177e4c3f41 Linus Torvalds 2005-04-16 79 static void
keyring_destroy(struct key *keyring);
^1da177e4c3f41 Linus Torvalds 2005-04-16 80 static void
keyring_describe(const struct key *keyring, struct seq_file *m);
^1da177e4c3f41 Linus Torvalds 2005-04-16 81 static long keyring_read(const
struct key *keyring,
^1da177e4c3f41 Linus Torvalds 2005-04-16 82 char __user
*buffer, size_t buflen);
^1da177e4c3f41 Linus Torvalds 2005-04-16 83
^1da177e4c3f41 Linus Torvalds 2005-04-16 84 struct key_type key_type_keyring
= {
^1da177e4c3f41 Linus Torvalds 2005-04-16 85.name = "keyring",
b2a4df200d570b David Howells 2013-09-24 86.def_datalen= 0,
5d19e20b534ff4 David Howells 2014-07-18 87.preparse =
keyring_preparse,
5d19e20b534ff4 David Howells 2014-07-18 88.free_preparse =
keyring_free_preparse,
^1da177e4c3f41 Linus Torvalds 2005-04-16 89.instantiate=
keyring_instantiate,
31204ed925b067 David Howells 2006-06-26 90.revoke =
keyring_revoke,
^1da177e4c3f41 Linus Torvalds 2005-04-16 91.destroy=
keyring_destroy,
^1da177e4c3f41 Linus Torvalds 2005-04-16 92.describe =
keyring_describe,
^1da177e4c3f41 Linus Torvalds 2005-04-16 @93.read = keyring_read,
^1da177e4c3f41 Linus Torvalds 2
[kbuild] arch/x86/ia32/ia32_signal.c:350:9: sparse: expected void const volatile [noderef] *
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: "Al, Viro,"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162
commit: 57d563c8292569f2849569853e846bf740df5032 x86: ia32_setup_rt_frame():
consolidate uaccess areas
date: 10 weeks ago
:: branch date: 15 hours ago
:: commit date: 10 weeks ago
config: x86_64-randconfig-s021-20200601 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout 57d563c8292569f2849569853e846bf740df5032
# save the attached .config to linux build tree
make W=1 C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
arch/x86/ia32/ia32_signal.c:350:9: sparse: sparse: cast removes address
space '' of expression
arch/x86/ia32/ia32_signal.c:350:9: sparse: sparse: incorrect type in
argument 1 (different address spaces) @@ expected void const volatile
[noderef] * @@ got unsigned long long [usertype] * @@
>> arch/x86/ia32/ia32_signal.c:350:9: sparse: expected void const volatile
>> [noderef] *
>> arch/x86/ia32/ia32_signal.c:350:9: sparse: got unsigned long long
>> [usertype] *
arch/x86/ia32/ia32_signal.c:350:9: sparse: sparse: cast removes address
space '' of expression
arch/x86/ia32/ia32_signal.c:350:9: sparse: sparse: cast removes address
space '' of expression
arch/x86/ia32/ia32_signal.c:350:9: sparse: sparse: cast removes address
space '' of expression
arch/x86/ia32/ia32_signal.c:350:9: sparse: sparse: cast removes address
space '' of expression
arch/x86/ia32/ia32_signal.c:350:9: sparse: sparse: cast removes address
space '' of expression
arch/x86/ia32/ia32_signal.c:350:9: sparse: sparse: cast removes address
space '' of expression
arch/x86/ia32/ia32_signal.c:350:9: sparse: sparse: cast removes address
space '' of expression
arch/x86/ia32/ia32_signal.c:350:9: sparse: sparse: cast removes address
space '' of expression
arch/x86/ia32/ia32_signal.c:350:9: sparse: sparse: cast removes address
space '' of expression
#
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=57d563c8292569f2849569853e846bf740df5032
git remote add linus
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout 57d563c8292569f2849569853e846bf740df5032
vim +350 arch/x86/ia32/ia32_signal.c
^1da177e4c3f41 arch/x86_64/ia32/ia32_signal.c Linus Torvalds2005-04-16 299
235b80226b986d arch/x86/ia32/ia32_signal.cAl Viro 2012-11-09 300
int ia32_setup_rt_frame(int sig, struct ksignal *ksig,
^1da177e4c3f41 arch/x86_64/ia32/ia32_signal.c Linus Torvalds2005-04-16 301
compat_sigset_t *set, struct pt_regs *regs)
^1da177e4c3f41 arch/x86_64/ia32/ia32_signal.c Linus Torvalds2005-04-16 302
{
3b0d29ee1c73b6 arch/x86/ia32/ia32_signal.cHiroshi Shimamoto 2008-12-17 303
struct rt_sigframe_ia32 __user *frame;
af65d64845a90c arch/x86/ia32/ia32_signal.cRoland McGrath2008-01-30 304
void __user *restorer;
44a1d996325982 arch/x86/ia32/ia32_signal.cAl Viro 2020-02-15 305
void __user *fp = NULL;
^1da177e4c3f41 arch/x86_64/ia32/ia32_signal.c Linus Torvalds2005-04-16 306
57d563c8292569 arch/x86/ia32/ia32_signal.cAl Viro 2020-02-15 307
/* unsafe_put_user optimizes that into a single 8 byte store */
99b9cdf758af70 arch/x86/ia32/ia32_signal.cThomas Gleixner 2008-01-30 308
static const struct {
99b9cdf758af70 arch/x86/ia32/ia32_signal.cThomas Gleixner 2008-01-30 309
u8 movl;
99b9cdf758af70 arch/x86/ia32/ia32_signal.cThomas Gleixner 2008-01-30 310
u32 val;
99b9cdf758af70 arch/x86/ia32/ia32_signal.cThomas Gleixner 2008-01-30 311
u16 int80;
9cc3c49ed1b1db arch/x86/ia32/ia32_signal.cHiroshi Shimamoto 2008-11-11 312
u8 pad;
99b9cdf758af70 arch/x86/ia32/ia32_signal.cThomas Gleixner 2008-01-30 313
} __attribute__((packed)) code = {
99b9cdf758af70 arch/x86/ia32/ia32_signal.cThomas Gleixner 2008-01-30 314
0xb8,
99b9cdf758af70 arch/x86/ia32/ia32_signal.cThomas Gleixner 2008-01-30 315
__NR_ia32_rt_sigreturn,
99b9cdf758af70 arch/x86/ia32/ia32_signal.cThomas Gleixner 2008-01-30 316
0x80cd,
99b9cdf758af70 arch/x86/ia32/ia32_signal.cThomas Gleixner 2008-01-30 317
0,
99b9cdf758af70 arch/x86/ia32/ia32_signal.cThomas Gleixner 2008-01-30 318
};
99b9cdf758af70 arch/x86/ia32/ia32_signal.cThomas Gleixner 2008-01-30 319
44
[kbuild] block/partitions/core.c:173 check_partition() warn: passing zero to 'ERR_PTR'
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: "Christoph, Hellwig,"
CC: Jens Axboe
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162
commit: 387048bf67eeff8bdf7c2a41b03b48230a88b3d3 block: merge
partition-generic.c and check.c
date: 10 weeks ago
:: branch date: 15 hours ago
:: commit date: 10 weeks ago
config: mips-randconfig-m031-20200601 (attached as .config)
compiler: mipsel-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
smatch warnings:
block/partitions/core.c:173 check_partition() warn: passing zero to 'ERR_PTR'
#
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=387048bf67eeff8bdf7c2a41b03b48230a88b3d3
git remote add linus
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout 387048bf67eeff8bdf7c2a41b03b48230a88b3d3
vim +/ERR_PTR +173 block/partitions/core.c
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 115
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 116
static struct parsed_partitions *check_partition(struct gendisk *hd,
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 117
struct block_device *bdev)
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 118 {
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 119
struct parsed_partitions *state;
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 120
int i, res, err;
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 121
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 122
state = allocate_partitions(hd);
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 123
if (!state)
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 124
return NULL;
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 125
state->pp_buf = (char *)__get_free_page(GFP_KERNEL);
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 126
if (!state->pp_buf) {
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 127
free_partitions(state);
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 128
return NULL;
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 129
}
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 130
state->pp_buf[0] = '\0';
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 131
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 132
state->bdev = bdev;
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 133
disk_name(hd, 0, state->name);
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 134
snprintf(state->pp_buf, PAGE_SIZE, " %s:", state->name);
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 135
if (isdigit(state->name[strlen(state->name)-1]))
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 136
sprintf(state->name, "p");
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 137
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 138
i = res = err = 0;
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 139
while (!res && check_part[i]) {
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 140
memset(state->parts, 0, state->limit * sizeof(state->parts[0]));
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 141
res = check_part[i++](state);
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 142
if (res < 0) {
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 143
/*
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 144
* We have hit an I/O error which we don't report now.
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 145
* But record it, and let the others do their job.
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 146
*/
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 147
err = res;
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 148
res = 0;
387048bf67eeff block/partitions/core.c Christoph Hellwig 2020-03-24 149
}
387048bf67eeff block/partitions/cor
[kbuild] [linux-next:master 4817/14131] drivers/net/ethernet/broadcom/genet/bcmgenet.c:688:24: sparse: got restricted __be16 [usertype]
CC: kbuild-...@lists.01.org
TO: "Doug, Berger,"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: e7b08814b16b80a0bf76eeca16317f8c2ed23b8c
commit: 3e370952287c55e5fd240cb8bb41ef8acff8829d [4817/14131] net: bcmgenet:
add support for ethtool rxnfc flows
:: branch date: 3 days ago
:: commit date: 5 weeks ago
config: i386-randconfig-s001-20200601 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout 3e370952287c55e5fd240cb8bb41ef8acff8829d
# save the attached .config to linux build tree
make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
drivers/net/ethernet/broadcom/genet/bcmgenet.c:688:24: sparse: sparse:
incorrect type in assignment (different base types) @@ expected unsigned
short [usertype] val_16 @@ got restricted __be16 [usertype] @@
drivers/net/ethernet/broadcom/genet/bcmgenet.c:688:24: sparse: expected
unsigned short [usertype] val_16
>> drivers/net/ethernet/broadcom/genet/bcmgenet.c:688:24: sparse: got
>> restricted __be16 [usertype]
drivers/net/ethernet/broadcom/genet/bcmgenet.c:782:5: sparse: sparse: symbol
'bcmgenet_hfb_add_filter' was not declared. Should it be static?
include/linux/netdevice.h:4052:20: sparse: sparse: shift count is negative
(-1)
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=3e370952287c55e5fd240cb8bb41ef8acff8829d
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout 3e370952287c55e5fd240cb8bb41ef8acff8829d
vim +688 drivers/net/ethernet/broadcom/genet/bcmgenet.c
3e370952287c55 Doug Berger 2020-04-29 631
3e370952287c55 Doug Berger 2020-04-29 632 static int
bcmgenet_hfb_create_rxnfc_filter(struct bcmgenet_priv *priv,
3e370952287c55 Doug Berger 2020-04-29 633
struct bcmgenet_rxnfc_rule *rule)
3e370952287c55 Doug Berger 2020-04-29 634 {
3e370952287c55 Doug Berger 2020-04-29 635 struct ethtool_rx_flow_spec *fs
= >fs;
3e370952287c55 Doug Berger 2020-04-29 636 int err = 0, offset = 0,
f_length = 0;
3e370952287c55 Doug Berger 2020-04-29 637 u16 val_16, mask_16;
3e370952287c55 Doug Berger 2020-04-29 638 u8 val_8, mask_8;
3e370952287c55 Doug Berger 2020-04-29 639 size_t size;
3e370952287c55 Doug Berger 2020-04-29 640 u32 *f_data;
3e370952287c55 Doug Berger 2020-04-29 641
3e370952287c55 Doug Berger 2020-04-29 642 f_data =
kcalloc(priv->hw_params->hfb_filter_size, sizeof(u32),
3e370952287c55 Doug Berger 2020-04-29 643 GFP_KERNEL);
3e370952287c55 Doug Berger 2020-04-29 644 if (!f_data)
3e370952287c55 Doug Berger 2020-04-29 645 return -ENOMEM;
3e370952287c55 Doug Berger 2020-04-29 646
3e370952287c55 Doug Berger 2020-04-29 647 if (fs->flow_type &
FLOW_MAC_EXT) {
3e370952287c55 Doug Berger 2020-04-29 648
bcmgenet_hfb_insert_data(f_data, 0,
3e370952287c55 Doug Berger 2020-04-29 649
>h_ext.h_dest, >m_ext.h_dest,
3e370952287c55 Doug Berger 2020-04-29 650
sizeof(fs->h_ext.h_dest));
3e370952287c55 Doug Berger 2020-04-29 651 }
3e370952287c55 Doug Berger 2020-04-29 652
3e370952287c55 Doug Berger 2020-04-29 653 if (fs->flow_type & FLOW_EXT) {
3e370952287c55 Doug Berger 2020-04-29 654 if
(fs->m_ext.vlan_etype ||
3e370952287c55 Doug Berger 2020-04-29 655 fs->m_ext.vlan_tci)
{
3e370952287c55 Doug Berger 2020-04-29 656
bcmgenet_hfb_insert_data(f_data, 12,
3e370952287c55 Doug Berger 2020-04-29 657
>h_ext.vlan_etype,
3e370952287c55 Doug Berger 2020-04-29 658
>m_ext.vlan_etype,
3e370952287c55 Doug Berger 2020-04-29 659
sizeof(fs->h_ext.vlan_etype));
3e370952287c55 Doug Berger 2020-04-29 660
bcmgenet_hfb_insert_data(f_data, 14,
3e370952287c55 Doug Berger 2020-04-29 661
>h_ext.vlan_tci,
3e370952287c55 Doug Berger 2020-04-29 662
>m_ext.vlan_tci,
3e370952287c55 Doug Berger 2020-04-29 663
sizeof(fs->h_ext.vlan_tci));
3e370952287c55 Doug Berger 2020-04-29 664 offset +=
VLAN_HLEN;
3e370952287c55 Doug Berger 2020-04-29 665 f_length +=
DIV_ROUND_UP(VLAN_HLEN, 2);
3e370952287
[kbuild] fs/xfs/xfs_log_cil.c:1065:9: sparse: sparse: context imbalance in 'xfs_log_commit_cil' - unexpected unlock
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: "Dave, Chinner,"
CC: "Darrick J. Wong"
CC: Allison Collins
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162
commit: 0e7ab7efe77451cba4cbecb6c9f5ef83cf32b36b xfs: Throttle commits on
delayed background CIL push
date: 9 weeks ago
:: branch date: 15 hours ago
:: commit date: 9 weeks ago
config: ia64-randconfig-s032-20200601 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout 0e7ab7efe77451cba4cbecb6c9f5ef83cf32b36b
# save the attached .config to linux build tree
make W=1 C=1 ARCH=ia64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
fs/xfs/xfs_log_cil.c:899:1: sparse: sparse: context imbalance in
'xlog_cil_push_background' - wrong count at exit
>> fs/xfs/xfs_log_cil.c:1065:9: sparse: sparse: context imbalance in
>> 'xfs_log_commit_cil' - unexpected unlock
#
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0e7ab7efe77451cba4cbecb6c9f5ef83cf32b36b
git remote add linus
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout 0e7ab7efe77451cba4cbecb6c9f5ef83cf32b36b
vim +/xfs_log_commit_cil +1065 fs/xfs/xfs_log_cil.c
2c6e24ce1aa6b3 Dave Chinner 2013-10-15 997
a44f13edf0ebb4 Dave Chinner 2010-08-24 998 /*
a44f13edf0ebb4 Dave Chinner 2010-08-24 999 * Commit a transaction with
the given vector to the Committed Item List.
a44f13edf0ebb4 Dave Chinner 2010-08-24 1000 *
a44f13edf0ebb4 Dave Chinner 2010-08-24 1001 * To do this, we need to
format the item, pin it in memory if required and
a44f13edf0ebb4 Dave Chinner 2010-08-24 1002 * account for the space
used by the transaction. Once we have done that we
a44f13edf0ebb4 Dave Chinner 2010-08-24 1003 * need to release the
unused reservation for the transaction, attach the
a44f13edf0ebb4 Dave Chinner 2010-08-24 1004 * transaction to the
checkpoint context so we carry the busy extents through
a44f13edf0ebb4 Dave Chinner 2010-08-24 1005 * to checkpoint completion,
and then unlock all the items in the transaction.
a44f13edf0ebb4 Dave Chinner 2010-08-24 1006 *
a44f13edf0ebb4 Dave Chinner 2010-08-24 1007 * Called with the context
lock already held in read mode to lock out
a44f13edf0ebb4 Dave Chinner 2010-08-24 1008 * background commit,
returns without it held once background commits are
a44f13edf0ebb4 Dave Chinner 2010-08-24 1009 * allowed again.
a44f13edf0ebb4 Dave Chinner 2010-08-24 1010 */
c6f9726444c8f8 Jie Liu 2014-02-07 1011 void
a44f13edf0ebb4 Dave Chinner 2010-08-24 1012 xfs_log_commit_cil(
a44f13edf0ebb4 Dave Chinner 2010-08-24 1013 struct xfs_mount
*mp,
a44f13edf0ebb4 Dave Chinner 2010-08-24 1014 struct xfs_trans
*tp,
a44f13edf0ebb4 Dave Chinner 2010-08-24 1015 xfs_lsn_t
*commit_lsn,
70393313dd0b26 Christoph Hellwig 2015-06-04 1016 bool
regrant)
a44f13edf0ebb4 Dave Chinner 2010-08-24 1017 {
f7bdf03a99efc0 Mark Tinguely 2012-06-14 1018 struct xlog
*log = mp->m_log;
991aaf65ff0add Dave Chinner 2013-08-12 1019 struct xfs_cil
*cil = log->l_cilp;
195cd83d1b8835 Christoph Hellwig 2019-06-28 1020 struct xfs_log_item
*lip, *next;
f990fc5ad13b8f Shan Hai 2017-06-14 1021 xfs_lsn_t
xc_commit_lsn;
a44f13edf0ebb4 Dave Chinner 2010-08-24 1022
b1c5ebb21301fc Dave Chinner 2016-07-22 1023 /*
b1c5ebb21301fc Dave Chinner 2016-07-22 1024* Do all necessary
memory allocation before we lock the CIL.
b1c5ebb21301fc Dave Chinner 2016-07-22 1025* This ensures the
allocation does not deadlock with a CIL
b1c5ebb21301fc Dave Chinner 2016-07-22 1026* push in memory
reclaim (e.g. from kswapd).
b1c5ebb21301fc Dave Chinner 2016-07-22 1027*/
b1c5ebb21301fc Dave Chinner 2016-07-22 1028
xlog_cil_alloc_shadow_bufs(log, tp);
b1c5ebb21301fc Dave Chinner 2016-07-22 1029
f5baac354db8b6 Dave Chinner 2013-08-12 1030 /* lock out background
commit */
991aaf65ff0add Dave Chinner 2013-08-12 1031
down_read(>xc_ctx_lock);
d1583a3833290a Dave Chinner 2010-09-24 1032
991aaf65ff0add Dave Chinner 2013-08-12 1033
xlog_cil_insert_items(log, tp);
a44f13edf0ebb4 Dave Chinner 2010-08-24 1034
f990fc5ad13b8f Shan Hai 2017-06-14 1035 xc_commit_lsn =
cil->xc_ctx->sequen
[kbuild] [linux-next:master 3942/14131] net/core/neighbour.c:3460:5: sparse: int extern [addressable] [signed] [toplevel] neigh_proc_dointvec( ... )
CC: kbuild-...@lists.01.org TO: "Christoph, Hellwig," CC: Al Viro tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: e7b08814b16b80a0bf76eeca16317f8c2ed23b8c commit: 32927393dc1ccd60fb2bdc05b9e8e88753761469 [3942/14131] sysctl: pass kernel pointers to ->proc_handler :: branch date: 3 days ago :: commit date: 5 weeks ago config: i386-randconfig-s002-20200601 (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.1-243-gc100a7ab-dirty git checkout 32927393dc1ccd60fb2bdc05b9e8e88753761469 # save the attached .config to linux build tree make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) net/core/neighbour.c:3460:5: sparse: sparse: symbol 'neigh_proc_dointvec' redeclared with different type (incompatible argument 3 (different address spaces)): >> net/core/neighbour.c:3460:5: sparse:int extern [addressable] [signed] >> [toplevel] neigh_proc_dointvec( ... ) >> include/net/neighbour.h:394:5: sparse: note: previously declared as: include/net/neighbour.h:394:5: sparse:int extern [addressable] [signed] [toplevel] neigh_proc_dointvec( ... ) net/core/neighbour.c:3470:5: sparse: sparse: symbol 'neigh_proc_dointvec_jiffies' redeclared with different type (incompatible argument 3 (different address spaces)): >> net/core/neighbour.c:3470:5: sparse:int extern [addressable] [signed] >> [toplevel] neigh_proc_dointvec_jiffies( ... ) include/net/neighbour.h:396:5: sparse: note: previously declared as: >> include/net/neighbour.h:396:5: sparse:int extern [addressable] [signed] >> [toplevel] neigh_proc_dointvec_jiffies( ... ) net/core/neighbour.c:3490:5: sparse: sparse: symbol 'neigh_proc_dointvec_ms_jiffies' redeclared with different type (incompatible argument 3 (different address spaces)): net/core/neighbour.c:3490:5: sparse:int extern [addressable] [signed] [toplevel] neigh_proc_dointvec_ms_jiffies( ... ) include/net/neighbour.h:399:5: sparse: note: previously declared as: include/net/neighbour.h:399:5: sparse:int extern [addressable] [signed] [toplevel] neigh_proc_dointvec_ms_jiffies( ... ) net/core/neighbour.c:348:12: sparse: sparse: context imbalance in '__neigh_ifdown' - wrong count at exit net/core/neighbour.c:803:9: sparse: sparse: context imbalance in 'pneigh_ifdown_and_unlock' - unexpected unlock -- drivers/char/random.c:2100:50: sparse: sparse: incorrect type in argument 3 (different address spaces) @@ expected void * @@ got void [noderef] *buffer @@ >> drivers/char/random.c:2100:50: sparse: expected void * drivers/char/random.c:2100:50: sparse: got void [noderef] *buffer drivers/char/random.c:2117:35: sparse: sparse: incorrect type in initializer (incompatible argument 3 (different address spaces)) @@ expected int ( [usertype] *proc_handler )( ... ) @@ got int ( * )( ... ) @@ drivers/char/random.c:2117:35: sparse: expected int ( [usertype] *proc_handler )( ... ) >> drivers/char/random.c:2117:35: sparse: got int ( * )( ... ) -- net/ipv6/ndisc.c:1850:55: sparse: sparse: incorrect type in argument 3 (different address spaces) @@ expected void [noderef] *buffer @@ got void *buffer @@ >> net/ipv6/ndisc.c:1850:55: sparse: expected void [noderef] *buffer net/ipv6/ndisc.c:1850:55: sparse: got void *buffer net/ipv6/ndisc.c:1854:51: sparse: sparse: incorrect type in argument 3 (different address spaces) @@ expected void [noderef] *buffer @@ got void *buffer @@ net/ipv6/ndisc.c:1854:51: sparse: expected void [noderef] *buffer net/ipv6/ndisc.c:1854:51: sparse: got void *buffer net/ipv6/ndisc.c:1859:54: sparse: sparse: incorrect type in argument 3 (different address spaces) @@ expected void [noderef] *buffer @@ got void *buffer @@ net/ipv6/ndisc.c:1859:54: sparse: expected void [noderef] *buffer net/ipv6/ndisc.c:1859:54: sparse: got void *buffer net/ipv6/ndisc.c:1838:5: sparse: sparse: symbol 'ndisc_ifinfo_sysctl_change' redeclared with different type (incompatible argument 3 (different address spaces)): net/ipv6/ndisc.c:1838:5: sparse:int extern [addressable] [signed] [toplevel] ndisc_ifinfo_sysctl_change( ... ) include/net/ndisc.h:496:5: sparse: note: previously declared as: include/net/ndisc.h:496:5: sparse:int extern [addressable] [signed] [toplevel] ndisc_ifinfo_sysctl_change( ... ) include/net/addrconf.h:478:36: sparse: sparse: restricted __be32 degrades to integer # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=32927393dc1ccd60fb2bdc05b9e8e88753761469 git remote add linu
[kbuild] [linux-next:master 2996/14131] sound/soc/fsl/fsl_asrc.c:1050:60: sparse: got restricted snd_pcm_format_t *
CC: kbuild-...@lists.01.org
TO: "Shengjiu, Wang,"
CC: Mark Brown
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: e7b08814b16b80a0bf76eeca16317f8c2ed23b8c
commit: 4520af41fd21863d026d53c7e1eb987509cb3c24 [2996/14131] ASoC: fsl_asrc:
Support new property fsl,asrc-format
:: branch date: 3 days ago
:: commit date: 6 weeks ago
config: openrisc-randconfig-s031-20200601 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout 4520af41fd21863d026d53c7e1eb987509cb3c24
# save the attached .config to linux build tree
make W=1 C=1 ARCH=openrisc CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
sound/soc/fsl/fsl_asrc.c:1050:60: sparse: sparse: incorrect type in argument
3 (different base types) @@ expected unsigned int [usertype] *out_value @@
got restricted snd_pcm_format_t * @@
sound/soc/fsl/fsl_asrc.c:1050:60: sparse: expected unsigned int
[usertype] *out_value
>> sound/soc/fsl/fsl_asrc.c:1050:60: sparse: got restricted
>> snd_pcm_format_t *
sound/soc/fsl/fsl_asrc.c:1073:47: sparse: sparse: restricted
snd_pcm_format_t degrades to integer
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=4520af41fd21863d026d53c7e1eb987509cb3c24
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout 4520af41fd21863d026d53c7e1eb987509cb3c24
vim +1050 sound/soc/fsl/fsl_asrc.c
3117bb3109dc22 Nicolin Chen 2014-07-29 933
3117bb3109dc22 Nicolin Chen 2014-07-29 934 static int fsl_asrc_probe(struct
platform_device *pdev)
3117bb3109dc22 Nicolin Chen 2014-07-29 935 {
3117bb3109dc22 Nicolin Chen 2014-07-29 936 struct device_node *np =
pdev->dev.of_node;
7470704d8b425c Shengjiu Wang 2020-04-16 937 struct fsl_asrc *asrc;
3117bb3109dc22 Nicolin Chen 2014-07-29 938 struct resource *res;
3117bb3109dc22 Nicolin Chen 2014-07-29 939 void __iomem *regs;
3117bb3109dc22 Nicolin Chen 2014-07-29 940 int irq, ret, i;
c05f10f28ef697 Shengjiu Wang 2019-12-04 941 u32 map_idx;
3117bb3109dc22 Nicolin Chen 2014-07-29 942 char tmp[16];
4520af41fd2186 Shengjiu Wang 2020-04-16 943 u32 width;
3117bb3109dc22 Nicolin Chen 2014-07-29 944
7470704d8b425c Shengjiu Wang 2020-04-16 945 asrc = devm_kzalloc(>dev,
sizeof(*asrc), GFP_KERNEL);
7470704d8b425c Shengjiu Wang 2020-04-16 946 if (!asrc)
3117bb3109dc22 Nicolin Chen 2014-07-29 947 return -ENOMEM;
3117bb3109dc22 Nicolin Chen 2014-07-29 948
7470704d8b425c Shengjiu Wang 2020-04-16 949 asrc->pdev = pdev;
3117bb3109dc22 Nicolin Chen 2014-07-29 950
3117bb3109dc22 Nicolin Chen 2014-07-29 951 /* Get the addresses and IRQ */
3117bb3109dc22 Nicolin Chen 2014-07-29 952 res =
platform_get_resource(pdev, IORESOURCE_MEM, 0);
3117bb3109dc22 Nicolin Chen 2014-07-29 953 regs =
devm_ioremap_resource(>dev, res);
3117bb3109dc22 Nicolin Chen 2014-07-29 954 if (IS_ERR(regs))
3117bb3109dc22 Nicolin Chen 2014-07-29 955 return PTR_ERR(regs);
3117bb3109dc22 Nicolin Chen 2014-07-29 956
7470704d8b425c Shengjiu Wang 2020-04-16 957 asrc->paddr = res->start;
3117bb3109dc22 Nicolin Chen 2014-07-29 958
7470704d8b425c Shengjiu Wang 2020-04-16 959 asrc->regmap =
devm_regmap_init_mmio_clk(>dev, "mem", regs,
3117bb3109dc22 Nicolin Chen 2014-07-29 960
_asrc_regmap_config);
7470704d8b425c Shengjiu Wang 2020-04-16 961 if (IS_ERR(asrc->regmap)) {
3117bb3109dc22 Nicolin Chen 2014-07-29 962 dev_err(>dev,
"failed to init regmap\n");
7470704d8b425c Shengjiu Wang 2020-04-16 963 return
PTR_ERR(asrc->regmap);
3117bb3109dc22 Nicolin Chen 2014-07-29 964 }
3117bb3109dc22 Nicolin Chen 2014-07-29 965
3117bb3109dc22 Nicolin Chen 2014-07-29 966 irq = platform_get_irq(pdev, 0);
cf9441adb1a355 Stephen Boyd 2019-07-30 967 if (irq < 0)
3117bb3109dc22 Nicolin Chen 2014-07-29 968 return irq;
3117bb3109dc22 Nicolin Chen 2014-07-29 969
3117bb3109dc22 Nicolin Chen 2014-07-29 970 ret =
devm_request_irq(>dev, irq, fsl_asrc_isr, 0,
7470704d8b425c Shengjiu Wang 2020-04-16 971
dev_name(>dev), asrc);
3117bb3109dc22 Nicolin Chen 2014-07-29 972 if (ret) {
3117bb3109dc22 Nicolin Chen 2014-07-29 973 dev_err(>dev,
"failed to claim irq %u: %d\n", irq, ret);
3117bb3109dc22 Nicolin Chen 2014-07-29 974 return ret;
3117bb3109dc22 Nicolin Chen 2014-07-29 975 }
3117bb3109dc22 Nicolin Chen 2014
[kbuild] drivers/net/dsa/bcm_sf2_cfp.c:890:21: sparse: got restricted __be32
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: "Florian, Fainelli,"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162
commit: 8b3abe304c5f1057b7bac70fd5576dfa67e3e2b3 net: dsa: bcm_sf2: Support
specifying VLAN tag egress rule
date: 9 weeks ago
:: branch date: 14 hours ago
:: commit date: 9 weeks ago
config: x86_64-randconfig-s022-20200601 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout 8b3abe304c5f1057b7bac70fd5576dfa67e3e2b3
# save the attached .config to linux build tree
make W=1 C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
drivers/net/dsa/bcm_sf2_cfp.c:352:44: sparse: sparse: incorrect type in
initializer (different base types) @@ expected restricted __be16 [usertype]
vlan_m_tci @@ got int @@
drivers/net/dsa/bcm_sf2_cfp.c:352:44: sparse: expected restricted __be16
[usertype] vlan_m_tci
drivers/net/dsa/bcm_sf2_cfp.c:352:44: sparse: got int
drivers/net/dsa/bcm_sf2_cfp.c:633:43: sparse: sparse: incorrect type in
initializer (different base types) @@ expected restricted __be16 [usertype]
vlan_m_tci @@ got int @@
drivers/net/dsa/bcm_sf2_cfp.c:633:43: sparse: expected restricted __be16
[usertype] vlan_m_tci
drivers/net/dsa/bcm_sf2_cfp.c:633:43: sparse: got int
drivers/net/dsa/bcm_sf2_cfp.c:890:21: sparse: sparse: cast from restricted
__be32
drivers/net/dsa/bcm_sf2_cfp.c:890:21: sparse: sparse: incorrect type in
argument 1 (different base types) @@ expected unsigned int [usertype] val
@@ got restricted __be32 @@
drivers/net/dsa/bcm_sf2_cfp.c:890:21: sparse: expected unsigned int
[usertype] val
>> drivers/net/dsa/bcm_sf2_cfp.c:890:21: sparse: got restricted __be32
drivers/net/dsa/bcm_sf2_cfp.c:890:21: sparse: sparse: cast from restricted
__be32
drivers/net/dsa/bcm_sf2_cfp.c:890:21: sparse: sparse: cast from restricted
__be32
drivers/net/dsa/bcm_sf2_cfp.c:890:21: sparse: sparse: cast from restricted
__be32
drivers/net/dsa/bcm_sf2_cfp.c:890:21: sparse: sparse: cast from restricted
__be32
drivers/net/dsa/bcm_sf2_cfp.c:890:21: sparse: sparse: restricted __be32
degrades to integer
#
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8b3abe304c5f1057b7bac70fd5576dfa67e3e2b3
git remote add linus
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout 8b3abe304c5f1057b7bac70fd5576dfa67e3e2b3
vim +890 drivers/net/dsa/bcm_sf2_cfp.c
ba0696c22e7c5b Florian Fainelli 2017-10-20 845
ce24b08a2e6f7c Florian Fainelli 2018-11-06 846 static int
bcm_sf2_cfp_rule_insert(struct dsa_switch *ds, int port,
3306145866b62f Florian Fainelli 2017-10-20 847
struct ethtool_rx_flow_spec *fs)
3306145866b62f Florian Fainelli 2017-10-20 848 {
3306145866b62f Florian Fainelli 2017-10-20 849 struct bcm_sf2_priv
*priv = bcm_sf2_to_priv(ds);
68bb8ea8ad0d49 Vivien Didelot 2019-10-21 850 s8 cpu_port =
dsa_to_port(ds, port)->cpu_dp->index;
8a75f4f2acd78a Florian Fainelli 2018-08-07 851 __u64 ring_cookie =
fs->ring_cookie;
8b3abe304c5f10 Florian Fainelli 2020-03-30 852 struct
switchdev_obj_port_vlan vlan;
3306145866b62f Florian Fainelli 2017-10-20 853 unsigned int queue_num,
port_num;
8b3abe304c5f10 Florian Fainelli 2020-03-30 854 u16 vid;
ce24b08a2e6f7c Florian Fainelli 2018-11-06 855 int ret;
ae7a5aff783c79 Florian Fainelli 2018-11-06 856
8a75f4f2acd78a Florian Fainelli 2018-08-07 857 /* This rule is a
Wake-on-LAN filter and we must specifically
8a75f4f2acd78a Florian Fainelli 2018-08-07 858 * target the CPU port
in order for it to be working.
8a75f4f2acd78a Florian Fainelli 2018-08-07 859 */
8a75f4f2acd78a Florian Fainelli 2018-08-07 860 if (ring_cookie ==
RX_CLS_FLOW_WAKE)
8a75f4f2acd78a Florian Fainelli 2018-08-07 861 ring_cookie =
cpu_port * SF2_NUM_EGRESS_QUEUES;
8a75f4f2acd78a Florian Fainelli 2018-08-07 862
3306145866b62f Florian Fainelli 2017-10-20 863 /* We do not support
discarding packets, check that the
3306145866b62f Florian Fainelli 2017-10-20 864 * destination port is
enabled and that we are within the
3306145866b62f Florian Fainelli 2017-10-20 865 * number of ports
supported by the switch
3306145866b62f Florian Fainelli 2017-10-20 866 */
8a75f4f2acd78a Florian Fainelli 2018-08-07 867 port_num = ring_cookie
/ SF2_NUM_EGRESS_QUEUES;
3306145866b62f Florian Fainelli 2017-10-20 868
8a75f4f2
[kbuild] drivers/net/dsa/bcm_sf2_cfp.c:890:21: sparse: expected unsigned int [usertype] val
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: "Florian, Fainelli,"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162
commit: 8b3abe304c5f1057b7bac70fd5576dfa67e3e2b3 net: dsa: bcm_sf2: Support
specifying VLAN tag egress rule
date: 9 weeks ago
:: branch date: 14 hours ago
:: commit date: 9 weeks ago
config: x86_64-randconfig-s022-20200601 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout 8b3abe304c5f1057b7bac70fd5576dfa67e3e2b3
# save the attached .config to linux build tree
make W=1 C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
drivers/net/dsa/bcm_sf2_cfp.c:352:44: sparse: sparse: incorrect type in
initializer (different base types) @@ expected restricted __be16 [usertype]
vlan_m_tci @@ got int @@
drivers/net/dsa/bcm_sf2_cfp.c:352:44: sparse: expected restricted __be16
[usertype] vlan_m_tci
drivers/net/dsa/bcm_sf2_cfp.c:352:44: sparse: got int
drivers/net/dsa/bcm_sf2_cfp.c:633:43: sparse: sparse: incorrect type in
initializer (different base types) @@ expected restricted __be16 [usertype]
vlan_m_tci @@ got int @@
drivers/net/dsa/bcm_sf2_cfp.c:633:43: sparse: expected restricted __be16
[usertype] vlan_m_tci
drivers/net/dsa/bcm_sf2_cfp.c:633:43: sparse: got int
drivers/net/dsa/bcm_sf2_cfp.c:890:21: sparse: sparse: cast from restricted
__be32
drivers/net/dsa/bcm_sf2_cfp.c:890:21: sparse: sparse: incorrect type in
argument 1 (different base types) @@ expected unsigned int [usertype] val
@@ got restricted __be32 @@
>> drivers/net/dsa/bcm_sf2_cfp.c:890:21: sparse: expected unsigned int
>> [usertype] val
drivers/net/dsa/bcm_sf2_cfp.c:890:21: sparse: got restricted __be32
drivers/net/dsa/bcm_sf2_cfp.c:890:21: sparse: sparse: cast from restricted
__be32
drivers/net/dsa/bcm_sf2_cfp.c:890:21: sparse: sparse: cast from restricted
__be32
drivers/net/dsa/bcm_sf2_cfp.c:890:21: sparse: sparse: cast from restricted
__be32
drivers/net/dsa/bcm_sf2_cfp.c:890:21: sparse: sparse: cast from restricted
__be32
drivers/net/dsa/bcm_sf2_cfp.c:890:21: sparse: sparse: restricted __be32
degrades to integer
#
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8b3abe304c5f1057b7bac70fd5576dfa67e3e2b3
git remote add linus
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout 8b3abe304c5f1057b7bac70fd5576dfa67e3e2b3
vim +890 drivers/net/dsa/bcm_sf2_cfp.c
ba0696c22e7c5b Florian Fainelli 2017-10-20 845
ce24b08a2e6f7c Florian Fainelli 2018-11-06 846 static int
bcm_sf2_cfp_rule_insert(struct dsa_switch *ds, int port,
3306145866b62f Florian Fainelli 2017-10-20 847
struct ethtool_rx_flow_spec *fs)
3306145866b62f Florian Fainelli 2017-10-20 848 {
3306145866b62f Florian Fainelli 2017-10-20 849 struct bcm_sf2_priv
*priv = bcm_sf2_to_priv(ds);
68bb8ea8ad0d49 Vivien Didelot 2019-10-21 850 s8 cpu_port =
dsa_to_port(ds, port)->cpu_dp->index;
8a75f4f2acd78a Florian Fainelli 2018-08-07 851 __u64 ring_cookie =
fs->ring_cookie;
8b3abe304c5f10 Florian Fainelli 2020-03-30 852 struct
switchdev_obj_port_vlan vlan;
3306145866b62f Florian Fainelli 2017-10-20 853 unsigned int queue_num,
port_num;
8b3abe304c5f10 Florian Fainelli 2020-03-30 854 u16 vid;
ce24b08a2e6f7c Florian Fainelli 2018-11-06 855 int ret;
ae7a5aff783c79 Florian Fainelli 2018-11-06 856
8a75f4f2acd78a Florian Fainelli 2018-08-07 857 /* This rule is a
Wake-on-LAN filter and we must specifically
8a75f4f2acd78a Florian Fainelli 2018-08-07 858 * target the CPU port
in order for it to be working.
8a75f4f2acd78a Florian Fainelli 2018-08-07 859 */
8a75f4f2acd78a Florian Fainelli 2018-08-07 860 if (ring_cookie ==
RX_CLS_FLOW_WAKE)
8a75f4f2acd78a Florian Fainelli 2018-08-07 861 ring_cookie =
cpu_port * SF2_NUM_EGRESS_QUEUES;
8a75f4f2acd78a Florian Fainelli 2018-08-07 862
3306145866b62f Florian Fainelli 2017-10-20 863 /* We do not support
discarding packets, check that the
3306145866b62f Florian Fainelli 2017-10-20 864 * destination port is
enabled and that we are within the
3306145866b62f Florian Fainelli 2017-10-20 865 * number of ports
supported by the switch
3306145866b62f Florian Fainelli 2017-10-20 866 */
8a75f4f2acd78a Florian Fainelli 2018-08-07 867 port_num = ring_cookie
/ SF2_NUM_EGRESS_QUEUES;
3306145866b62f Florian Fainelli 2017-10-20 868
[kbuild] [rdma-rdma:for-next 81/228] drivers/infiniband/core/cm.c:2533:12: sparse: sparse: context imbalance in 'cm_establish_handler' - different lock contexts for basic block
CC: kbuild-...@lists.01.org
TO: "Jason, Gunthorpe,"
CC: Leon Romanovsky
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next
head: 0258b569a53b87742104a3ecb1d1204d5974a28b
commit: e83f195aa45c1ffd73b3a950a887e41c260cf194 [81/228] RDMA/cm: Pull
duplicated code into cm_queue_work_unlock()
:: branch date: 3 days ago
:: commit date: 3 weeks ago
config: i386-randconfig-s001-20200601 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout e83f195aa45c1ffd73b3a950a887e41c260cf194
# save the attached .config to linux build tree
make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
drivers/infiniband/core/cm.c:1297:21: sparse: sparse: cast from restricted
__be32
drivers/infiniband/core/cm.c:936:24: sparse: sparse: context imbalance in
'cm_queue_work_unlock' - unexpected unlock
drivers/infiniband/core/cm.c:2043:12: sparse: sparse: context imbalance in
'cm_req_handler' - different lock contexts for basic block
drivers/infiniband/core/cm.c:2422:12: sparse: sparse: context imbalance in
'cm_rep_handler' - different lock contexts for basic block
>> drivers/infiniband/core/cm.c:2533:12: sparse: sparse: context imbalance in
>> 'cm_establish_handler' - different lock contexts for basic block
drivers/infiniband/core/cm.c:2556:12: sparse: sparse: context imbalance in
'cm_rtu_handler' - different lock contexts for basic block
drivers/infiniband/core/cm.c:2770:12: sparse: sparse: context imbalance in
'cm_dreq_handler' - different lock contexts for basic block
drivers/infiniband/core/cm.c:2847:12: sparse: sparse: context imbalance in
'cm_drep_handler' - different lock contexts for basic block
drivers/infiniband/core/cm.c:2995:12: sparse: sparse: context imbalance in
'cm_rej_handler' - wrong count at exit
drivers/infiniband/core/cm.c:3153:12: sparse: sparse: context imbalance in
'cm_mra_handler' - different lock contexts for basic block
drivers/infiniband/core/cm.c:3271:12: sparse: sparse: context imbalance in
'cm_lap_handler' - different lock contexts for basic block
drivers/infiniband/core/cm.c:3360:12: sparse: sparse: context imbalance in
'cm_apr_handler' - different lock contexts for basic block
drivers/infiniband/core/cm.c:3405:12: sparse: sparse: context imbalance in
'cm_timewait_handler' - different lock contexts for basic block
#
https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?id=e83f195aa45c1ffd73b3a950a887e41c260cf194
git remote add rdma-rdma
https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git
git remote update rdma-rdma
git checkout e83f195aa45c1ffd73b3a950a887e41c260cf194
vim +/cm_establish_handler +2533 drivers/infiniband/core/cm.c
a977049dacdef6 Hal Rosenstock 2005-07-27 2532
a977049dacdef6 Hal Rosenstock 2005-07-27 @2533 static int
cm_establish_handler(struct cm_work *work)
a977049dacdef6 Hal Rosenstock 2005-07-27 2534 {
a977049dacdef6 Hal Rosenstock 2005-07-27 2535 struct cm_id_private
*cm_id_priv;
a977049dacdef6 Hal Rosenstock 2005-07-27 2536
e1444b5a163e81 Sean Hefty 2006-11-28 2537 /* See comment in
cm_establish about lookup. */
a977049dacdef6 Hal Rosenstock 2005-07-27 2538 cm_id_priv =
cm_acquire_id(work->local_id, work->remote_id);
a977049dacdef6 Hal Rosenstock 2005-07-27 2539 if (!cm_id_priv)
a977049dacdef6 Hal Rosenstock 2005-07-27 2540 return -EINVAL;
a977049dacdef6 Hal Rosenstock 2005-07-27 2541
24be6e81c78314 Sean Hefty 2007-06-18 2542
spin_lock_irq(_id_priv->lock);
a977049dacdef6 Hal Rosenstock 2005-07-27 2543 if
(cm_id_priv->id.state != IB_CM_ESTABLISHED) {
24be6e81c78314 Sean Hefty 2007-06-18 2544
spin_unlock_irq(_id_priv->lock);
a977049dacdef6 Hal Rosenstock 2005-07-27 2545 goto out;
a977049dacdef6 Hal Rosenstock 2005-07-27 2546 }
a977049dacdef6 Hal Rosenstock 2005-07-27 2547
34816ad98efe4d Sean Hefty 2005-10-25 2548
ib_cancel_mad(cm_id_priv->av.port->mad_agent, cm_id_priv->msg);
e83f195aa45c1f Jason Gunthorpe 2020-05-06 2549
cm_queue_work_unlock(cm_id_priv, work);
a977049dacdef6 Hal Rosenstock 2005-07-27 2550 return 0;
a977049dacdef6 Hal Rosenstock 2005-07-27 2551 out:
a977049dacdef6 Hal Rosenstock 2005-07-27 2552 cm_deref_id(cm_id_priv);
a977049dacdef6 Hal Rosenstock 2005-07-27 2553 return -EINVAL;
a977049dacdef6 Hal Rosenstock 2005-07-27 2554 }
a977049dacdef6 Hal Rosenstock 2005-07-27 2555
:: The code at line 2533 was first introduced by commit
:: a977049dacdef6a9e69fb4872b42a68e93a69956 [PATCH] I
[kbuild] [linux-next:master 3191/14131] drivers/net/ethernet/mscc/ocelot_flower.c:184:54: sparse: got restricted __be16 [usertype]
CC: kbuild-...@lists.01.org
TO: "Vladimir, Oltean,"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: e7b08814b16b80a0bf76eeca16317f8c2ed23b8c
commit: 86b956de119c09818d0aabaf668280d8e4bd0d4b [3191/14131] net: mscc:
ocelot: support matching on EtherType
:: branch date: 3 days ago
:: commit date: 6 weeks ago
config: openrisc-randconfig-s031-20200601 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout 86b956de119c09818d0aabaf668280d8e4bd0d4b
# save the attached .config to linux build tree
make W=1 C=1 ARCH=openrisc CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
drivers/net/ethernet/mscc/ocelot_flower.c:184:54: sparse: sparse: incorrect
type in assignment (different base types) @@ expected unsigned short
[usertype] @@ got restricted __be16 [usertype] @@
drivers/net/ethernet/mscc/ocelot_flower.c:184:54: sparse: expected
unsigned short [usertype]
>> drivers/net/ethernet/mscc/ocelot_flower.c:184:54: sparse: got restricted
>> __be16 [usertype]
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=86b956de119c09818d0aabaf668280d8e4bd0d4b
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout 86b956de119c09818d0aabaf668280d8e4bd0d4b
vim +184 drivers/net/ethernet/mscc/ocelot_flower.c
fe3490e6107e10 Horatiu Vultur2019-05-31 48
f9e30088d20016 Pablo Neira Ayuso 2019-07-09 49 static int
ocelot_flower_parse(struct flow_cls_offload *f,
ce6659c55b7dad Vladimir Oltean 2020-02-29 50
struct ocelot_ace_rule *ace)
fe3490e6107e10 Horatiu Vultur2019-05-31 51 {
f9e30088d20016 Pablo Neira Ayuso 2019-07-09 52struct flow_rule *rule
= flow_cls_offload_flow_rule(f);
fe3490e6107e10 Horatiu Vultur2019-05-31 53struct flow_dissector
*dissector = rule->match.dissector;
86b956de119c09 Vladimir Oltean 2020-04-20 54u16 proto =
ntohs(f->common.protocol);
86b956de119c09 Vladimir Oltean 2020-04-20 55bool match_protocol =
true;
fe3490e6107e10 Horatiu Vultur2019-05-31 56
fe3490e6107e10 Horatiu Vultur2019-05-31 57if
(dissector->used_keys &
fe3490e6107e10 Horatiu Vultur2019-05-31 58
~(BIT(FLOW_DISSECTOR_KEY_CONTROL) |
fe3490e6107e10 Horatiu Vultur2019-05-31 59
BIT(FLOW_DISSECTOR_KEY_BASIC) |
fe3490e6107e10 Horatiu Vultur2019-05-31 60
BIT(FLOW_DISSECTOR_KEY_PORTS) |
fe3490e6107e10 Horatiu Vultur2019-05-31 61
BIT(FLOW_DISSECTOR_KEY_VLAN) |
fe3490e6107e10 Horatiu Vultur2019-05-31 62
BIT(FLOW_DISSECTOR_KEY_IPV4_ADDRS) |
fe3490e6107e10 Horatiu Vultur2019-05-31 63
BIT(FLOW_DISSECTOR_KEY_IPV6_ADDRS) |
fe3490e6107e10 Horatiu Vultur2019-05-31 64
BIT(FLOW_DISSECTOR_KEY_ETH_ADDRS))) {
fe3490e6107e10 Horatiu Vultur2019-05-31 65return
-EOPNOTSUPP;
fe3490e6107e10 Horatiu Vultur2019-05-31 66}
fe3490e6107e10 Horatiu Vultur2019-05-31 67
fe3490e6107e10 Horatiu Vultur2019-05-31 68if
(flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_CONTROL)) {
fe3490e6107e10 Horatiu Vultur2019-05-31 69struct
flow_match_control match;
fe3490e6107e10 Horatiu Vultur2019-05-31 70
fe3490e6107e10 Horatiu Vultur2019-05-31 71
flow_rule_match_control(rule, );
fe3490e6107e10 Horatiu Vultur2019-05-31 72}
fe3490e6107e10 Horatiu Vultur2019-05-31 73
fe3490e6107e10 Horatiu Vultur2019-05-31 74if
(flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_ETH_ADDRS)) {
fe3490e6107e10 Horatiu Vultur2019-05-31 75struct
flow_match_eth_addrs match;
fe3490e6107e10 Horatiu Vultur2019-05-31 76
fe3490e6107e10 Horatiu Vultur2019-05-31 77/* The hw
support mac matches only for MAC_ETYPE key,
fe3490e6107e10 Horatiu Vultur2019-05-31 78 * therefore if
other matches(port, tcp flags, etc) are added
fe3490e6107e10 Horatiu Vultur2019-05-31 79 * then just
bail out
fe3490e6107e10 Horatiu Vultur2019-05-31 80 */
fe3490e6107e10 Horatiu Vultur2019-05-31 81if
((dissector->used_keys &
fe3490e6107e10 Horatiu Vultur2019-05-31 82
(BIT(FLOW_DISSECTOR_KEY_ETH_ADDRS) |
fe3490e6107e10 Horatiu Vultur2019-05-31 83
BIT(FLOW_DISSECTOR_KEY_BASIC) |
fe3490e6107e10 Horatiu Vultur2019-05-31 84
BIT(FLOW_DISSECTOR_KEY_CON
[kbuild] [kdave:for-5.8 2/133] fs/btrfs/locking.c:534:22: sparse: sparse: context imbalance in 'btrfs_lock_root_node' - wrong count at exit
CC: kbuild-...@lists.01.org
TO: "Jules, Irenge,"
CC: David Sterba
tree: https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.8
head: 2166e5edce9ac1edf3b113d6091ef72fcac2d6c4
commit: 78d933c79cb649906577715af15400c7724ca633 [2/133] btrfs: add missing
annotation for btrfs_tree_lock()
:: branch date: 4 days ago
:: commit date: 7 days ago
config: x86_64-randconfig-s022-20200601 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout 78d933c79cb649906577715af15400c7724ca633
# save the attached .config to linux build tree
make W=1 C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
include/linux/kasan-checks.h:38:20: sparse: sparse: context imbalance in
'btrfs_set_lock_blocking_read' - unexpected unlock
fs/btrfs/locking.c:232:41: sparse: sparse: context imbalance in
'btrfs_set_lock_blocking_write' - unexpected unlock
fs/btrfs/locking.c:247:6: sparse: sparse: context imbalance in
'btrfs_tree_read_lock' - different lock contexts for basic block
fs/btrfs/locking.c:288:5: sparse: sparse: context imbalance in
'btrfs_tree_read_lock_atomic' - different lock contexts for basic block
fs/btrfs/locking.c:310:5: sparse: sparse: context imbalance in
'btrfs_try_tree_read_lock' - different lock contexts for basic block
fs/btrfs/locking.c:335:5: sparse: sparse: context imbalance in
'btrfs_try_tree_write_lock' - different lock contexts for basic block
include/linux/kasan-checks.h:38:20: sparse: sparse: context imbalance in
'btrfs_tree_read_unlock' - unexpected unlock
fs/btrfs/locking.c:129:9: sparse: sparse: context imbalance in
'btrfs_tree_unlock' - unexpected unlock
>> fs/btrfs/locking.c:534:22: sparse: sparse: context imbalance in
>> 'btrfs_lock_root_node' - wrong count at exit
#
https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git/commit/?id=78d933c79cb649906577715af15400c7724ca633
git remote add kdave
https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git
git remote update kdave
git checkout 78d933c79cb649906577715af15400c7724ca633
vim +/btrfs_lock_root_node +534 fs/btrfs/locking.c
b908c334e7a419 David Sterba 2020-02-05 527
b908c334e7a419 David Sterba 2020-02-05 528 /*
b908c334e7a419 David Sterba 2020-02-05 529 * Loop around taking references
on and locking the root node of the tree until
b908c334e7a419 David Sterba 2020-02-05 530 * we end up with a lock on the
root node.
b908c334e7a419 David Sterba 2020-02-05 531 *
b908c334e7a419 David Sterba 2020-02-05 532 * Return: root extent buffer with
write lock held
b908c334e7a419 David Sterba 2020-02-05 533 */
b908c334e7a419 David Sterba 2020-02-05 @534 struct extent_buffer
*btrfs_lock_root_node(struct btrfs_root *root)
b908c334e7a419 David Sterba 2020-02-05 535 {
b908c334e7a419 David Sterba 2020-02-05 536 struct extent_buffer *eb;
b908c334e7a419 David Sterba 2020-02-05 537
b908c334e7a419 David Sterba 2020-02-05 538 while (1) {
b908c334e7a419 David Sterba 2020-02-05 539 eb =
btrfs_root_node(root);
b908c334e7a419 David Sterba 2020-02-05 540 btrfs_tree_lock(eb);
b908c334e7a419 David Sterba 2020-02-05 541 if (eb == root->node)
b908c334e7a419 David Sterba 2020-02-05 542 break;
b908c334e7a419 David Sterba 2020-02-05 543 btrfs_tree_unlock(eb);
b908c334e7a419 David Sterba 2020-02-05 544 free_extent_buffer(eb);
b908c334e7a419 David Sterba 2020-02-05 545 }
b908c334e7a419 David Sterba 2020-02-05 546 return eb;
b908c334e7a419 David Sterba 2020-02-05 547 }
b908c334e7a419 David Sterba 2020-02-05 548
:: The code at line 534 was first introduced by commit
:: b908c334e7a419e5cd08a45d31284b4a93de3bd7 btrfs: move root node locking
helpers to locking.c
:: TO: David Sterba
:: CC: David Sterba
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [linux-next:master 10504/14131] net/ipv6/mcast.c:606:34: sparse: expected void [noderef] *to
CC: kbuild-...@lists.01.org
TO: "Al, Viro,"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: e7b08814b16b80a0bf76eeca16317f8c2ed23b8c
commit: 931ca7ab7fe804d77bc6952f1512950c0d870f26 [10504/14131] ip*_mc_gsfget():
lift copyout of struct group_filter into callers
:: branch date: 3 days ago
:: commit date: 12 days ago
config: microblaze-randconfig-s032-20200601 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout 931ca7ab7fe804d77bc6952f1512950c0d870f26
# save the attached .config to linux build tree
make W=1 C=1 ARCH=microblaze CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
include/linux/byteorder/big_endian.h:8:2: sparse: sparse: inconsistent
configuration, needs CONFIG_CPU_BIG_ENDIAN
net/ipv6/mcast.c:606:34: sparse: sparse: incorrect type in argument 1
(different address spaces) @@ expected void [noderef] *to @@
got struct __kernel_sockaddr_storage *p @@
>> net/ipv6/mcast.c:606:34: sparse: expected void [noderef] *to
net/ipv6/mcast.c:606:34: sparse: got struct __kernel_sockaddr_storage *p
net/ipv6/mcast.c:549:5: sparse: sparse: symbol 'ip6_mc_msfget' redeclared
with different type (incompatible argument 3 (different address spaces)):
net/ipv6/mcast.c:549:5: sparse:int extern [addressable] [signed]
[toplevel] ip6_mc_msfget( ... )
>> include/net/ipv6.h:1140:5: sparse: note: previously declared as:
include/net/ipv6.h:1140:5: sparse:int extern [addressable] [signed]
[toplevel] ip6_mc_msfget( ... )
net/ipv6/mcast.c:259:25: sparse: sparse: context imbalance in
'ip6_mc_find_dev_rcu' - different lock contexts for basic block
net/ipv6/mcast.c:453:9: sparse: sparse: context imbalance in 'ip6_mc_source'
- unexpected unlock
net/ipv6/mcast.c:542:9: sparse: sparse: context imbalance in
'ip6_mc_msfilter' - unexpected unlock
net/ipv6/mcast.c:589:21: sparse: sparse: context imbalance in
'ip6_mc_msfget' - unexpected unlock
net/ipv6/mcast.c:2700:25: sparse: sparse: context imbalance in
'igmp6_mc_get_next' - unexpected unlock
net/ipv6/mcast.c:2722:9: sparse: sparse: context imbalance in
'igmp6_mc_get_idx' - wrong count at exit
net/ipv6/mcast.c:2749:9: sparse: sparse: context imbalance in
'igmp6_mc_seq_stop' - unexpected unlock
net/ipv6/mcast.c:2821:31: sparse: sparse: context imbalance in
'igmp6_mcf_get_next' - unexpected unlock
net/ipv6/mcast.c:2853:9: sparse: sparse: context imbalance in
'igmp6_mcf_get_idx' - wrong count at exit
net/ipv6/mcast.c:2870:9: sparse: sparse: context imbalance in
'igmp6_mcf_seq_next' - wrong count at exit
net/ipv6/mcast.c:2883:17: sparse: sparse: context imbalance in
'igmp6_mcf_seq_stop' - unexpected unlock
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=931ca7ab7fe804d77bc6952f1512950c0d870f26
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout 931ca7ab7fe804d77bc6952f1512950c0d870f26
vim +606 net/ipv6/mcast.c
^1da177e4c3f41 Linus Torvalds2005-04-16 548
^1da177e4c3f41 Linus Torvalds2005-04-16 549 int ip6_mc_msfget(struct sock
*sk, struct group_filter *gsf,
931ca7ab7fe804 Al Viro 2020-03-29 550struct sockaddr_storage
*p)
^1da177e4c3f41 Linus Torvalds2005-04-16 551 {
^1da177e4c3f41 Linus Torvalds2005-04-16 552int err, i, count,
copycount;
b71d1d426d263b Eric Dumazet 2011-04-22 553const struct in6_addr
*group;
^1da177e4c3f41 Linus Torvalds2005-04-16 554struct ipv6_mc_socklist
*pmc;
^1da177e4c3f41 Linus Torvalds2005-04-16 555struct inet6_dev *idev;
^1da177e4c3f41 Linus Torvalds2005-04-16 556struct ipv6_pinfo
*inet6 = inet6_sk(sk);
^1da177e4c3f41 Linus Torvalds2005-04-16 557struct ip6_sf_socklist
*psl;
3b1e0a655f8eba YOSHIFUJI Hideaki 2008-03-26 558struct net *net =
sock_net(sk);
^1da177e4c3f41 Linus Torvalds2005-04-16 559
^1da177e4c3f41 Linus Torvalds2005-04-16 560group = &((struct
sockaddr_in6 *)>gf_group)->sin6_addr;
^1da177e4c3f41 Linus Torvalds2005-04-16 561
^1da177e4c3f41 Linus Torvalds2005-04-16 562if
(!ipv6_addr_is_multicast(group))
^1da177e4c3f41 Linus Torvalds2005-04-16 563return -EINVAL;
^1da177e4c3f41 Linus Torvalds2005-04-16 564
96b52e61be1ad4 Eric Dumazet 2010-06-07 565rcu_read_lock();
96b52e61be1ad4 Eric Dumazet 2010-06-07 566idev =
ip6_mc_find_dev_rcu(net, group, gsf->gf_interface);
^1da177e4c3f41 Linus Torvalds2005-04-16 567
96b52e61be1ad4 Eric Duma
[kbuild] [linux-next:master 3942/14131] drivers/cdrom/cdrom.c:3597:42: sparse: got void [noderef] *buffer
CC: kbuild-...@lists.01.org
TO: "Christoph, Hellwig,"
CC: Al Viro
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: e7b08814b16b80a0bf76eeca16317f8c2ed23b8c
commit: 32927393dc1ccd60fb2bdc05b9e8e88753761469 [3942/14131] sysctl: pass
kernel pointers to ->proc_handler
:: branch date: 3 days ago
:: commit date: 5 weeks ago
config: i386-randconfig-s001-20200601 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout 32927393dc1ccd60fb2bdc05b9e8e88753761469
# save the attached .config to linux build tree
make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
drivers/cdrom/cdrom.c:3597:42: sparse: sparse: incorrect type in argument 3
(different address spaces) @@ expected void * @@ got void [noderef]
*buffer @@
drivers/cdrom/cdrom.c:3597:42: sparse: expected void *
>> drivers/cdrom/cdrom.c:3597:42: sparse: got void [noderef] *buffer
drivers/cdrom/cdrom.c:3665:35: sparse: sparse: incorrect type in initializer
(incompatible argument 3 (different address spaces)) @@ expected int (
[usertype] *proc_handler )( ... ) @@ got int ( * )( ... ) @@
drivers/cdrom/cdrom.c:3665:35: sparse: expected int ( [usertype]
*proc_handler )( ... )
>> drivers/cdrom/cdrom.c:3665:35: sparse: got int ( * )( ... )
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=32927393dc1ccd60fb2bdc05b9e8e88753761469
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout 32927393dc1ccd60fb2bdc05b9e8e88753761469
vim +3597 drivers/cdrom/cdrom.c
554988d6fe3697 Dave Young2007-06-19 3519
90a3b89e00658b Joe Perches 2014-06-06 3520 static int
cdrom_sysctl_info(struct ctl_table *ctl, int write,
^1da177e4c3f41 Linus Torvalds2005-04-16 3521
void __user *buffer, size_t *lenp, loff_t *ppos)
^1da177e4c3f41 Linus Torvalds2005-04-16 3522 {
^1da177e4c3f41 Linus Torvalds2005-04-16 3523 int pos;
^1da177e4c3f41 Linus Torvalds2005-04-16 3524 char *info =
cdrom_sysctl_settings.info;
554988d6fe3697 Dave Young2007-06-19 3525 const int max_size =
sizeof(cdrom_sysctl_settings.info);
^1da177e4c3f41 Linus Torvalds2005-04-16 3526
^1da177e4c3f41 Linus Torvalds2005-04-16 3527 if (!*lenp || (*ppos &&
!write)) {
^1da177e4c3f41 Linus Torvalds2005-04-16 3528 *lenp = 0;
^1da177e4c3f41 Linus Torvalds2005-04-16 3529 return 0;
^1da177e4c3f41 Linus Torvalds2005-04-16 3530 }
^1da177e4c3f41 Linus Torvalds2005-04-16 3531
554988d6fe3697 Dave Young2007-06-19 3532
mutex_lock(_mutex);
^1da177e4c3f41 Linus Torvalds2005-04-16 3533
554988d6fe3697 Dave Young2007-06-19 3534 pos = sprintf(info,
"CD-ROM information, " VERSION "\n");
^1da177e4c3f41 Linus Torvalds2005-04-16 3535
554988d6fe3697 Dave Young2007-06-19 3536 if
(cdrom_print_info("\ndrive name:\t", 0, info, , CTL_NAME))
554988d6fe3697 Dave Young2007-06-19 3537 goto done;
554988d6fe3697 Dave Young2007-06-19 3538 if
(cdrom_print_info("\ndrive speed:\t", 0, info, , CTL_SPEED))
554988d6fe3697 Dave Young2007-06-19 3539 goto done;
554988d6fe3697 Dave Young2007-06-19 3540 if
(cdrom_print_info("\ndrive # of slots:", 0, info, , CTL_SLOTS))
554988d6fe3697 Dave Young2007-06-19 3541 goto done;
554988d6fe3697 Dave Young2007-06-19 3542 if
(cdrom_print_info("\nCan close tray:\t",
554988d6fe3697 Dave Young2007-06-19 3543
CDC_CLOSE_TRAY, info, , CTL_CAPABILITY))
554988d6fe3697 Dave Young2007-06-19 3544 goto done;
554988d6fe3697 Dave Young2007-06-19 3545 if
(cdrom_print_info("\nCan open tray:\t",
554988d6fe3697 Dave Young2007-06-19 3546
CDC_OPEN_TRAY, info, , CTL_CAPABILITY))
554988d6fe3697 Dave Young2007-06-19 3547 goto done;
554988d6fe3697 Dave Young2007-06-19 3548 if
(cdrom_print_info("\nCan lock tray:\t",
554988d6fe3697 Dave Young2007-06-19 3549
CDC_LOCK, info, , CTL_CAPABILITY))
554988d6fe3697 Dave Young2007-06-19 3550 goto done;
554988d6fe3697 Dave Young2007-06-19 3551 if
(cdrom_print_info("\nCan change speed:",
554988d6fe3697 Dave
[kbuild] [linux-next:master 3942/14131] net/core/sysctl_net_core.c:129:42: sparse: expected char const [noderef] *buf
CC: kbuild-...@lists.01.org
TO: "Christoph, Hellwig,"
CC: Al Viro
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: e7b08814b16b80a0bf76eeca16317f8c2ed23b8c
commit: 32927393dc1ccd60fb2bdc05b9e8e88753761469 [3942/14131] sysctl: pass
kernel pointers to ->proc_handler
:: branch date: 3 days ago
:: commit date: 5 weeks ago
config: ia64-randconfig-s032-20200601 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout 32927393dc1ccd60fb2bdc05b9e8e88753761469
# save the attached .config to linux build tree
make W=1 C=1 ARCH=ia64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
net/core/sysctl_net_core.c:129:42: sparse: sparse: incorrect type in
argument 1 (different address spaces) @@ expected char const [noderef]
*buf @@ got void *buffer @@
>> net/core/sysctl_net_core.c:129:42: sparse: expected char const [noderef]
>> *buf
net/core/sysctl_net_core.c:129:42: sparse: got void *buffer
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=32927393dc1ccd60fb2bdc05b9e8e88753761469
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout 32927393dc1ccd60fb2bdc05b9e8e88753761469
vim +129 net/core/sysctl_net_core.c
99bbc70741903c Willem de Bruijn 2013-05-20 116
fe2c6338fd2c6f Joe Perches 2013-06-11 117 static int
flow_limit_cpu_sysctl(struct ctl_table *table, int write,
32927393dc1ccd Christoph Hellwig 2020-04-24 118
void *buffer, size_t *lenp, loff_t *ppos)
99bbc70741903c Willem de Bruijn 2013-05-20 119 {
99bbc70741903c Willem de Bruijn 2013-05-20 120struct sd_flow_limit
*cur;
99bbc70741903c Willem de Bruijn 2013-05-20 121struct softnet_data *sd;
99bbc70741903c Willem de Bruijn 2013-05-20 122cpumask_var_t mask;
99bbc70741903c Willem de Bruijn 2013-05-20 123int i, len, ret = 0;
99bbc70741903c Willem de Bruijn 2013-05-20 124
99bbc70741903c Willem de Bruijn 2013-05-20 125if
(!alloc_cpumask_var(, GFP_KERNEL))
99bbc70741903c Willem de Bruijn 2013-05-20 126return -ENOMEM;
99bbc70741903c Willem de Bruijn 2013-05-20 127
99bbc70741903c Willem de Bruijn 2013-05-20 128if (write) {
99bbc70741903c Willem de Bruijn 2013-05-20 @129ret =
cpumask_parse_user(buffer, *lenp, mask);
99bbc70741903c Willem de Bruijn 2013-05-20 130if (ret)
99bbc70741903c Willem de Bruijn 2013-05-20 131goto
done;
99bbc70741903c Willem de Bruijn 2013-05-20 132
99bbc70741903c Willem de Bruijn 2013-05-20 133
mutex_lock(_limit_update_mutex);
99bbc70741903c Willem de Bruijn 2013-05-20 134len =
sizeof(*cur) + netdev_flow_limit_table_len;
99bbc70741903c Willem de Bruijn 2013-05-20 135
for_each_possible_cpu(i) {
99bbc70741903c Willem de Bruijn 2013-05-20 136sd =
_cpu(softnet_data, i);
99bbc70741903c Willem de Bruijn 2013-05-20 137cur =
rcu_dereference_protected(sd->flow_limit,
99bbc70741903c Willem de Bruijn 2013-05-20 138
lockdep_is_held(_limit_update_mutex));
99bbc70741903c Willem de Bruijn 2013-05-20 139if (cur
&& !cpumask_test_cpu(i, mask)) {
99bbc70741903c Willem de Bruijn 2013-05-20 140
RCU_INIT_POINTER(sd->flow_limit, NULL);
99bbc70741903c Willem de Bruijn 2013-05-20 141
synchronize_rcu();
99bbc70741903c Willem de Bruijn 2013-05-20 142
kfree(cur);
99bbc70741903c Willem de Bruijn 2013-05-20 143} else
if (!cur && cpumask_test_cpu(i, mask)) {
5b59d467ad9ff9 Eric Dumazet 2013-12-18 144
cur = kzalloc_node(len, GFP_KERNEL,
5b59d467ad9ff9 Eric Dumazet 2013-12-18 145
cpu_to_node(i));
99bbc70741903c Willem de Bruijn 2013-05-20 146
if (!cur) {
99bbc70741903c Willem de Bruijn 2013-05-20 147
/* not unwinding previous changes */
99bbc70741903c Willem de Bruijn 2013-05-20 148
ret = -ENOMEM;
99bbc70741903c Willem de Bruijn 2013-05-20 149
goto write_unlock;
99bbc70741903c Willem de Bruijn 2013-05-20 150
}
99bbc70741903c Willem de Bruijn 2013-05-20 151
[kbuild] drivers/net/dsa/bcm_sf2_cfp.c:350:44: sparse: expected restricted __be16 [usertype] vlan_m_tci
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: "Florian, Fainelli,"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162
commit: 7555020c44db75a0d934dffc0aa6c678b52b2a13 net: dsa: bcm_sf2: Add support
for matching VLAN TCI
date: 9 weeks ago
:: branch date: 12 hours ago
:: commit date: 9 weeks ago
config: x86_64-randconfig-s022-20200601 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout 7555020c44db75a0d934dffc0aa6c678b52b2a13
# save the attached .config to linux build tree
make W=1 C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
drivers/net/dsa/bcm_sf2_cfp.c:350:44: sparse: sparse: incorrect type in
initializer (different base types) @@ expected restricted __be16 [usertype]
vlan_m_tci @@ got int @@
>> drivers/net/dsa/bcm_sf2_cfp.c:350:44: sparse: expected restricted __be16
>> [usertype] vlan_m_tci
drivers/net/dsa/bcm_sf2_cfp.c:350:44: sparse: got int
drivers/net/dsa/bcm_sf2_cfp.c:631:43: sparse: sparse: incorrect type in
initializer (different base types) @@ expected restricted __be16 [usertype]
vlan_m_tci @@ got int @@
drivers/net/dsa/bcm_sf2_cfp.c:631:43: sparse: expected restricted __be16
[usertype] vlan_m_tci
drivers/net/dsa/bcm_sf2_cfp.c:631:43: sparse: got int
#
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7555020c44db75a0d934dffc0aa6c678b52b2a13
git remote add linus
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout 7555020c44db75a0d934dffc0aa6c678b52b2a13
vim +350 drivers/net/dsa/bcm_sf2_cfp.c
bc3fc44c12d6a4 Florian Fainelli 2017-10-20 343
3306145866b62f Florian Fainelli 2017-10-20 344 static int
bcm_sf2_cfp_ipv4_rule_set(struct bcm_sf2_priv *priv, int port,
3306145866b62f Florian Fainelli 2017-10-20 345
unsigned int port_num,
3306145866b62f Florian Fainelli 2017-10-20 346
unsigned int queue_num,
3306145866b62f Florian Fainelli 2017-10-20 347
struct ethtool_rx_flow_spec *fs)
3306145866b62f Florian Fainelli 2017-10-20 348 {
e4f7ef54cbd8c8 Pablo Neira Ayuso 2019-02-02 349struct
ethtool_rx_flow_spec_input input = {};
7555020c44db75 Florian Fainelli 2020-03-30 @350__be16 vlan_tci = 0 ,
vlan_m_tci = 0x;
3306145866b62f Florian Fainelli 2017-10-20 351const struct
cfp_udf_layout *layout;
3306145866b62f Florian Fainelli 2017-10-20 352unsigned int slice_num,
rule_index;
e4f7ef54cbd8c8 Pablo Neira Ayuso 2019-02-02 353struct
ethtool_rx_flow_rule *flow;
e4f7ef54cbd8c8 Pablo Neira Ayuso 2019-02-02 354struct
flow_match_ipv4_addrs ipv4;
e4f7ef54cbd8c8 Pablo Neira Ayuso 2019-02-02 355struct flow_match_ports
ports;
e4f7ef54cbd8c8 Pablo Neira Ayuso 2019-02-02 356struct flow_match_ip ip;
3306145866b62f Florian Fainelli 2017-10-20 357u8 ip_proto, ip_frag;
3306145866b62f Florian Fainelli 2017-10-20 358u8 num_udf;
3306145866b62f Florian Fainelli 2017-10-20 359u32 reg;
3306145866b62f Florian Fainelli 2017-10-20 360int ret;
7318166cacad15 Florian Fainelli 2017-01-30 361
7318166cacad15 Florian Fainelli 2017-01-30 362switch (fs->flow_type &
~FLOW_EXT) {
7318166cacad15 Florian Fainelli 2017-01-30 363case TCP_V4_FLOW:
7318166cacad15 Florian Fainelli 2017-01-30 364ip_proto =
IPPROTO_TCP;
7318166cacad15 Florian Fainelli 2017-01-30 365break;
7318166cacad15 Florian Fainelli 2017-01-30 366case UDP_V4_FLOW:
7318166cacad15 Florian Fainelli 2017-01-30 367ip_proto =
IPPROTO_UDP;
7318166cacad15 Florian Fainelli 2017-01-30 368break;
7318166cacad15 Florian Fainelli 2017-01-30 369default:
7318166cacad15 Florian Fainelli 2017-01-30 370return -EINVAL;
7318166cacad15 Florian Fainelli 2017-01-30 371}
7318166cacad15 Florian Fainelli 2017-01-30 372
7c3125f0a6ebc1 Florian Fainelli 2019-12-20 373ip_frag =
!!(be32_to_cpu(fs->h_ext.data[0]) & 1);
3306145866b62f Florian Fainelli 2017-10-20 374
7555020c44db75 Florian Fainelli 2020-03-30 375/* Extract VLAN TCI */
7555020c44db75 Florian Fainelli 2020-03-30 376if (fs->flow_type &
FLOW_EXT) {
7555020c44db75 Florian Fainelli 2020-03-30 377vlan_tci =
fs->h_ext.vlan_tci;
7555020c44db75 Florian Fainelli 2020-03-30 378vlan_m_tci =
fs->m_ext.vla
[kbuild] [linux-next:master 5305/14131] net/sched/cls_api.c:3719:9: sparse: sparse: context imbalance in 'tc_setup_flow_action' - different lock contexts for basic block
CC: kbuild-...@lists.01.org
TO: "Po, Liu,"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: e7b08814b16b80a0bf76eeca16317f8c2ed23b8c
commit: d29bdd69ecdd70e8e3c2268fc8e188d6ab55e54a [5305/14131] net: schedule:
add action gate offloading
:: branch date: 3 days ago
:: commit date: 4 weeks ago
config: i386-randconfig-s001-20200601 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout d29bdd69ecdd70e8e3c2268fc8e188d6ab55e54a
# save the attached .config to linux build tree
make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
net/sched/cls_api.c:270:22: sparse: sparse: incorrect type in assignment
(different base types) @@ expected restricted __be16 [usertype] protocol @@
got unsigned int [usertype] protocol @@
net/sched/cls_api.c:270:22: sparse: expected restricted __be16
[usertype] protocol
net/sched/cls_api.c:270:22: sparse: got unsigned int [usertype] protocol
net/sched/cls_api.c:1727:16: sparse: sparse: incompatible types in
comparison expression (different address spaces):
net/sched/cls_api.c:1727:16: sparse:struct tcf_proto *
net/sched/cls_api.c:1727:16: sparse:struct tcf_proto [noderef] *
net/sched/cls_api.c:1827:20: sparse: sparse: incompatible types in
comparison expression (different address spaces):
net/sched/cls_api.c:1827:20: sparse:struct tcf_proto [noderef] *
net/sched/cls_api.c:1827:20: sparse:struct tcf_proto *
net/sched/cls_api.c:1789:25: sparse: sparse: incompatible types in
comparison expression (different address spaces):
net/sched/cls_api.c:1789:25: sparse:struct tcf_proto [noderef] *
net/sched/cls_api.c:1789:25: sparse:struct tcf_proto *
net/sched/cls_api.c:1809:16: sparse: sparse: incompatible types in
comparison expression (different address spaces):
net/sched/cls_api.c:1809:16: sparse:struct tcf_proto *
net/sched/cls_api.c:1809:16: sparse:struct tcf_proto [noderef] *
net/sched/cls_api.c:1874:25: sparse: sparse: restricted __be16 degrades to
integer
net/sched/cls_api.c:2538:50: sparse: sparse: restricted __be16 degrades to
integer
>> net/sched/cls_api.c:3719:9: sparse: sparse: context imbalance in
>> 'tc_setup_flow_action' - different lock contexts for basic block
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=d29bdd69ecdd70e8e3c2268fc8e188d6ab55e54a
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout d29bdd69ecdd70e8e3c2268fc8e188d6ab55e54a
vim +/tc_setup_flow_action +3719 net/sched/cls_api.c
d29bdd69ecdd70 Po Liu 2020-05-01 3550
3a7b68617de749 Pablo Neira Ayuso2019-02-02 3551 int
tc_setup_flow_action(struct flow_action *flow_action,
b15e7a6e8d31d6 Vlad Buslov 2020-02-17 3552
const struct tcf_exts *exts)
3a7b68617de749 Pablo Neira Ayuso2019-02-02 3553 {
7a47281439ba00 Vlad Buslov 2020-02-17 3554struct
tc_action *act;
9838b20a7fb28c Vlad Buslov 2019-08-26 3555int i, j, k,
err = 0;
3a7b68617de749 Pablo Neira Ayuso2019-02-02 3556
0dfb2d82af4cd7 Jakub Kicinski 2020-03-19 3557
BUILD_BUG_ON(TCA_ACT_HW_STATS_ANY != FLOW_ACTION_HW_STATS_ANY);
0dfb2d82af4cd7 Jakub Kicinski 2020-03-19 3558
BUILD_BUG_ON(TCA_ACT_HW_STATS_IMMEDIATE != FLOW_ACTION_HW_STATS_IMMEDIATE);
0dfb2d82af4cd7 Jakub Kicinski 2020-03-19 3559
BUILD_BUG_ON(TCA_ACT_HW_STATS_DELAYED != FLOW_ACTION_HW_STATS_DELAYED);
44f8658017419d Jiri Pirko 2020-03-07 3560
3a7b68617de749 Pablo Neira Ayuso2019-02-02 3561if (!exts)
3a7b68617de749 Pablo Neira Ayuso2019-02-02 3562return
0;
3a7b68617de749 Pablo Neira Ayuso2019-02-02 3563
3a7b68617de749 Pablo Neira Ayuso2019-02-02 3564j = 0;
3a7b68617de749 Pablo Neira Ayuso2019-02-02 3565
tcf_exts_for_each_action(i, act, exts) {
3a7b68617de749 Pablo Neira Ayuso2019-02-02 3566struct
flow_action_entry *entry;
3a7b68617de749 Pablo Neira Ayuso2019-02-02 3567
3a7b68617de749 Pablo Neira Ayuso2019-02-02 3568entry =
_action->entries[j];
7a47281439ba00 Vlad Buslov 2020-02-17 3569
spin_lock_bh(>tcfa_lock);
2008495d81159a Jiri Pirko 2020-02-25 3570err =
tcf_act_get_cookie(entry, act);
2008495d81159a Jiri Pirko 2020-02-25 3571if (err)
2008495d81159a Jiri Pi
[kbuild] arch/x86/ia32/ia32_signal.c:350:9: sparse: sparse: cast removes address space '' of expression
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: "Al, Viro,"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162
commit: 57d563c8292569f2849569853e846bf740df5032 x86: ia32_setup_rt_frame():
consolidate uaccess areas
date: 10 weeks ago
:: branch date: 9 hours ago
:: commit date: 10 weeks ago
config: x86_64-randconfig-s021-20200601 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout 57d563c8292569f2849569853e846bf740df5032
# save the attached .config to linux build tree
make W=1 C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
>> arch/x86/ia32/ia32_signal.c:350:9: sparse: sparse: cast removes address
>> space '' of expression
arch/x86/ia32/ia32_signal.c:350:9: sparse: sparse: incorrect type in
argument 1 (different address spaces) @@ expected void const volatile
[noderef] * @@ got unsigned long long [usertype] * @@
arch/x86/ia32/ia32_signal.c:350:9: sparse: expected void const volatile
[noderef] *
arch/x86/ia32/ia32_signal.c:350:9: sparse: got unsigned long long
[usertype] *
>> arch/x86/ia32/ia32_signal.c:350:9: sparse: sparse: cast removes address
>> space '' of expression
>> arch/x86/ia32/ia32_signal.c:350:9: sparse: sparse: cast removes address
>> space '' of expression
>> arch/x86/ia32/ia32_signal.c:350:9: sparse: sparse: cast removes address
>> space '' of expression
>> arch/x86/ia32/ia32_signal.c:350:9: sparse: sparse: cast removes address
>> space '' of expression
>> arch/x86/ia32/ia32_signal.c:350:9: sparse: sparse: cast removes address
>> space '' of expression
>> arch/x86/ia32/ia32_signal.c:350:9: sparse: sparse: cast removes address
>> space '' of expression
>> arch/x86/ia32/ia32_signal.c:350:9: sparse: sparse: cast removes address
>> space '' of expression
>> arch/x86/ia32/ia32_signal.c:350:9: sparse: sparse: cast removes address
>> space '' of expression
>> arch/x86/ia32/ia32_signal.c:350:9: sparse: sparse: cast removes address
>> space '' of expression
#
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=57d563c8292569f2849569853e846bf740df5032
git remote add linus
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout 57d563c8292569f2849569853e846bf740df5032
vim +350 arch/x86/ia32/ia32_signal.c
^1da177e4c3f41 arch/x86_64/ia32/ia32_signal.c Linus Torvalds2005-04-16 299
235b80226b986d arch/x86/ia32/ia32_signal.cAl Viro 2012-11-09 300
int ia32_setup_rt_frame(int sig, struct ksignal *ksig,
^1da177e4c3f41 arch/x86_64/ia32/ia32_signal.c Linus Torvalds2005-04-16 301
compat_sigset_t *set, struct pt_regs *regs)
^1da177e4c3f41 arch/x86_64/ia32/ia32_signal.c Linus Torvalds2005-04-16 302
{
3b0d29ee1c73b6 arch/x86/ia32/ia32_signal.cHiroshi Shimamoto 2008-12-17 303
struct rt_sigframe_ia32 __user *frame;
af65d64845a90c arch/x86/ia32/ia32_signal.cRoland McGrath2008-01-30 304
void __user *restorer;
44a1d996325982 arch/x86/ia32/ia32_signal.cAl Viro 2020-02-15 305
void __user *fp = NULL;
^1da177e4c3f41 arch/x86_64/ia32/ia32_signal.c Linus Torvalds2005-04-16 306
57d563c8292569 arch/x86/ia32/ia32_signal.cAl Viro 2020-02-15 307
/* unsafe_put_user optimizes that into a single 8 byte store */
99b9cdf758af70 arch/x86/ia32/ia32_signal.cThomas Gleixner 2008-01-30 308
static const struct {
99b9cdf758af70 arch/x86/ia32/ia32_signal.cThomas Gleixner 2008-01-30 309
u8 movl;
99b9cdf758af70 arch/x86/ia32/ia32_signal.cThomas Gleixner 2008-01-30 310
u32 val;
99b9cdf758af70 arch/x86/ia32/ia32_signal.cThomas Gleixner 2008-01-30 311
u16 int80;
9cc3c49ed1b1db arch/x86/ia32/ia32_signal.cHiroshi Shimamoto 2008-11-11 312
u8 pad;
99b9cdf758af70 arch/x86/ia32/ia32_signal.cThomas Gleixner 2008-01-30 313
} __attribute__((packed)) code = {
99b9cdf758af70 arch/x86/ia32/ia32_signal.cThomas Gleixner 2008-01-30 314
0xb8,
99b9cdf758af70 arch/x86/ia32/ia32_signal.cThomas Gleixner 2008-01-30 315
__NR_ia32_rt_sigreturn,
99b9cdf758af70 arch/x86/ia32/ia32_signal.cThomas Gleixner 2008-01-30 316
0x80cd,
99b9cdf758af70 arch/x86/ia32/ia32_signal.cThomas Gleixner 2008-01-30 317
0,
99b9cdf758af70 arch/x86/ia32/ia32_signal.cThomas Gleix
[kbuild] net/netlink/af_netlink.c:2585:13: sparse: sparse: context imbalance in 'netlink_seq_start' - wrong count at exit
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: "Jules, Irenge,"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162
commit: 64fbca011976ce1564f191f4154e4a6ade25779a net: Add missing annotation
for *netlink_seq_start()
date: 3 months ago
:: branch date: 9 hours ago
:: commit date: 3 months ago
config: i386-randconfig-s002-20200601 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout 64fbca011976ce1564f191f4154e4a6ade25779a
# save the attached .config to linux build tree
make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
net/netlink/af_netlink.c:2543:13: sparse: sparse: context imbalance in
'netlink_walk_start' - wrong count at exit
net/netlink/af_netlink.c:2549:13: sparse: sparse: context imbalance in
'netlink_walk_stop' - unexpected unlock
>> net/netlink/af_netlink.c:2585:13: sparse: sparse: context imbalance in
>> 'netlink_seq_start' - wrong count at exit
#
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=64fbca011976ce1564f191f4154e4a6ade25779a
git remote add linus
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout 64fbca011976ce1564f191f4154e4a6ade25779a
vim +/netlink_seq_start +2585 net/netlink/af_netlink.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 2584
56d28b1e921b57 Herbert Xu 2015-02-04 @2585 static void
*netlink_seq_start(struct seq_file *seq, loff_t *posp)
64fbca011976ce Jules Irenge 2020-03-11 2586 __acquires(RCU)
56d28b1e921b57 Herbert Xu 2015-02-04 2587 {
56d28b1e921b57 Herbert Xu 2015-02-04 2588 struct nl_seq_iter
*iter = seq->private;
56d28b1e921b57 Herbert Xu 2015-02-04 2589 void *obj =
SEQ_START_TOKEN;
56d28b1e921b57 Herbert Xu 2015-02-04 2590 loff_t pos;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2591
56d28b1e921b57 Herbert Xu 2015-02-04 2592 iter->link = 0;
56d28b1e921b57 Herbert Xu 2015-02-04 2593
abf9979f7ef34e Taehee Yoo 2019-06-10 2594
netlink_walk_start(iter);
56d28b1e921b57 Herbert Xu 2015-02-04 2595
56d28b1e921b57 Herbert Xu 2015-02-04 2596 for (pos = *posp; pos
&& obj && !IS_ERR(obj); pos--)
56d28b1e921b57 Herbert Xu 2015-02-04 2597 obj =
__netlink_seq_next(seq);
56d28b1e921b57 Herbert Xu 2015-02-04 2598
56d28b1e921b57 Herbert Xu 2015-02-04 2599 return obj;
56d28b1e921b57 Herbert Xu 2015-02-04 2600 }
56d28b1e921b57 Herbert Xu 2015-02-04 2601
:: The code at line 2585 was first introduced by commit
:: 56d28b1e921b57b918a0ae6b13a1671115fe788d netlink: Use rhashtable walk
iterator
:: TO: Herbert Xu
:: CC: David S. Miller
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [block:async-readahead 15/20] fs/nfs/read.c:405:5: sparse: int extern [addressable] [signed] [toplevel] nfs_readpages( ... )
CC: kbuild-...@lists.01.org
TO: "Jens, Axboe,"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
async-readahead
head: 77ca3affd737b5ca9f4222ead263a55b5a663e79
commit: ed611876580275e085cba3bb9c1f948ad5d882ab [15/20] fs: make
aops->readpages() take kiocb argument
:: branch date: 4 hours ago
:: commit date: 6 hours ago
config: i386-randconfig-s002-20200601 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout ed611876580275e085cba3bb9c1f948ad5d882ab
# save the attached .config to linux build tree
make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
>> fs/nfs/file.c:515:22: sparse: sparse: incorrect type in initializer
>> (incompatible argument 1 (different base types)) @@ expected int (
>> *readpages )( ... ) @@ got int ( * )( ... ) @@
>> fs/nfs/file.c:515:22: sparse: expected int ( *readpages )( ... )
>> fs/nfs/file.c:515:22: sparse: got int ( * )( ... )
--
fs/nfs/read.c:405:5: sparse: sparse: symbol 'nfs_readpages' redeclared with
different type (incompatible argument 1 (different base types)):
>> fs/nfs/read.c:405:5: sparse:int extern [addressable] [signed] [toplevel]
>> nfs_readpages( ... )
>> include/linux/nfs_fs.h:553:13: sparse: note: previously declared as:
>> include/linux/nfs_fs.h:553:13: sparse:int extern [addressable] [signed]
>> [toplevel] nfs_readpages( ... )
#
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?id=ed611876580275e085cba3bb9c1f948ad5d882ab
git remote add block
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
git remote update block
git checkout ed611876580275e085cba3bb9c1f948ad5d882ab
vim +405 fs/nfs/read.c
^1da177e4c3f41 Linus Torvalds2005-04-16 404
ed611876580275 Jens Axboe2020-05-31 @405 int nfs_readpages(struct
kiocb *kiocb, struct address_space *mapping,
^1da177e4c3f41 Linus Torvalds2005-04-16 406struct
list_head *pages, unsigned nr_pages)
^1da177e4c3f41 Linus Torvalds2005-04-16 407 {
ed611876580275 Jens Axboe2020-05-31 408struct file *filp =
kiocb->ki_filp;
8b09bee3083897 Trond Myklebust 2007-04-02 409struct
nfs_pageio_descriptor pgio;
a7d42ddb309972 Weston Andros Adamson 2014-09-19 410struct nfs_pgio_mirror
*pgm;
^1da177e4c3f41 Linus Torvalds2005-04-16 411struct nfs_readdesc
desc = {
8b09bee3083897 Trond Myklebust 2007-04-02 412.pgio = ,
^1da177e4c3f41 Linus Torvalds2005-04-16 413};
^1da177e4c3f41 Linus Torvalds2005-04-16 414struct inode *inode =
mapping->host;
8b09bee3083897 Trond Myklebust 2007-04-02 415unsigned long npages;
5f004cf2aa8494 Trond Myklebust 2006-09-14 416int ret = -ESTALE;
^1da177e4c3f41 Linus Torvalds2005-04-16 417
1e8968c5b05823 Niels de Vos 2013-12-17 418dprintk("NFS:
nfs_readpages (%s/%Lu %d)\n",
^1da177e4c3f41 Linus Torvalds2005-04-16 419
inode->i_sb->s_id,
1e8968c5b05823 Niels de Vos 2013-12-17 420
(unsigned long long)NFS_FILEID(inode),
^1da177e4c3f41 Linus Torvalds2005-04-16 421
nr_pages);
91d5b47023b608 Chuck Lever 2006-03-20 422nfs_inc_stats(inode,
NFSIOS_VFSREADPAGES);
^1da177e4c3f41 Linus Torvalds2005-04-16 423
5f004cf2aa8494 Trond Myklebust 2006-09-14 424if (NFS_STALE(inode))
5f004cf2aa8494 Trond Myklebust 2006-09-14 425goto out;
5f004cf2aa8494 Trond Myklebust 2006-09-14 426
^1da177e4c3f41 Linus Torvalds2005-04-16 427if (filp == NULL) {
d530838bfa507d Trond Myklebust 2005-11-04 428desc.ctx =
nfs_find_open_context(inode, NULL, FMODE_READ);
^1da177e4c3f41 Linus Torvalds2005-04-16 429if (desc.ctx ==
NULL)
^1da177e4c3f41 Linus Torvalds2005-04-16 430return
-EBADF;
^1da177e4c3f41 Linus Torvalds2005-04-16 431} else
cd3758e37ddea6 Trond Myklebust 2007-08-10 432desc.ctx =
get_nfs_open_context(nfs_file_open_context(filp));
9a9fc1c03315f1 David Howells 2009-04-03 433
9a9fc1c03315f1 David Howells 2009-04-03 434/* attempt to read as
many of the pages as possible from the cache
9a9fc1c03315f1 David Howells 2009-04-03 435 * - this returns
-ENOBUFS immediately if the cookie is negative
9a9fc1c03315f1 David Howells 2009-04-03 436 */
9a9fc1c03315f1 David Howells 2009-04-03 437ret =
nfs_
[kbuild] Re: [PATCH RFC] seccomp: Implement syscall isolation based on memory areas
CC: kbuild-...@lists.01.org In-Reply-To: <20200530055953.817666-1-kris...@collabora.com> References: <20200530055953.817666-1-kris...@collabora.com> TO: Gabriel Krisman Bertazi Hi Gabriel, [FYI, it's a private test report for your RFC patch.] [auto build test WARNING on tip/x86/core] [also build test WARNING on linus/master v5.7 next-20200529] [cannot apply to asm-generic/master linux/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Gabriel-Krisman-Bertazi/seccomp-Implement-syscall-isolation-based-on-memory-areas/20200601-014401 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 9cb1fd0efd195590b828b9b865421ad345a4a145 :: branch date: 7 hours ago :: commit date: 7 hours ago config: arm-randconfig-c024-20200531 (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot Reported-by: Julia Lawall coccinelle warnings: (new ones prefixed by >>) >> kernel/seccomp.c:939:2-5: WARNING: Use BUG_ON instead of if condition >> followed by BUG. Please make sure the condition has no side effects (see conditional BUG_ON definition in include/asm-generic/bug.h) Please review and possibly fold the followup patch. --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] Re: [Intel-gfx] [PATCH v1] drm/i915: Fix wrong CDCLK adjustment changes
CC: kbuild-...@lists.01.org
In-Reply-To: <20200526094852.6967-1-stanislav.lisovs...@intel.com>
References: <20200526094852.6967-1-stanislav.lisovs...@intel.com>
TO: Stanislav Lisovskiy
TO: intel-...@lists.freedesktop.org
CC: ch...@chris-wilson.co.uk
Hi Stanislav,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-tip/drm-tip]
[also build test WARNING on drm-intel/drm-intel-next-queued]
[cannot apply to drm-intel/for-linux-next v5.7-rc7 next-20200529]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Stanislav-Lisovskiy/drm-i915-Fix-wrong-CDCLK-adjustment-changes/20200526-180642
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
:: branch date: 6 days ago
:: commit date: 6 days ago
config: i386-randconfig-m021-20200531 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/gpu/drm/i915/display/intel_bw.c:453 skl_bw_calc_min_cdclk() error:
uninitialized symbol 'pipe'.
#
https://github.com/0day-ci/linux/commit/21b0324886122a396687d977d67eb6ce3caf2b17
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 21b0324886122a396687d977d67eb6ce3caf2b17
vim +/pipe +453 drivers/gpu/drm/i915/display/intel_bw.c
366b6200f76e0f Jani Nikula 2019-08-06 430
cd19154608610a Stanislav Lisovskiy 2020-05-20 431 int
skl_bw_calc_min_cdclk(struct intel_atomic_state *state)
cd19154608610a Stanislav Lisovskiy 2020-05-20 432 {
cd19154608610a Stanislav Lisovskiy 2020-05-20 433 struct drm_i915_private
*dev_priv = to_i915(state->base.dev);
cac91e671ad5dc Stanislav Lisovskiy 2020-05-22 434 struct intel_bw_state
*new_bw_state = NULL;
cac91e671ad5dc Stanislav Lisovskiy 2020-05-22 435 struct intel_bw_state
*old_bw_state = NULL;
cd19154608610a Stanislav Lisovskiy 2020-05-20 436 const struct
intel_crtc_state *crtc_state;
cd19154608610a Stanislav Lisovskiy 2020-05-20 437 struct intel_crtc *crtc;
cd19154608610a Stanislav Lisovskiy 2020-05-20 438 int max_bw = 0;
cd19154608610a Stanislav Lisovskiy 2020-05-20 439 int slice_id;
21b0324886122a Stanislav Lisovskiy 2020-05-26 440 enum pipe pipe;
cac91e671ad5dc Stanislav Lisovskiy 2020-05-22 441 int i;
cd19154608610a Stanislav Lisovskiy 2020-05-20 442
cd19154608610a Stanislav Lisovskiy 2020-05-20 443
for_each_new_intel_crtc_in_state(state, crtc, crtc_state, i) {
cd19154608610a Stanislav Lisovskiy 2020-05-20 444 enum plane_id
plane_id;
cd19154608610a Stanislav Lisovskiy 2020-05-20 445 struct
intel_dbuf_bw *crtc_bw;
cd19154608610a Stanislav Lisovskiy 2020-05-20 446
cd19154608610a Stanislav Lisovskiy 2020-05-20 447 new_bw_state =
intel_atomic_get_bw_state(state);
cd19154608610a Stanislav Lisovskiy 2020-05-20 448 if
(IS_ERR(new_bw_state))
cd19154608610a Stanislav Lisovskiy 2020-05-20 449 return
PTR_ERR(new_bw_state);
cd19154608610a Stanislav Lisovskiy 2020-05-20 450
21b0324886122a Stanislav Lisovskiy 2020-05-26 451 old_bw_state =
intel_atomic_get_old_bw_state(state);
21b0324886122a Stanislav Lisovskiy 2020-05-26 452
21b0324886122a Stanislav Lisovskiy 2020-05-26 @453 crtc_bw =
_bw_state->dbuf_bw[pipe];
cd19154608610a Stanislav Lisovskiy 2020-05-20 454
cd19154608610a Stanislav Lisovskiy 2020-05-20 455
memset(_bw->used_bw, 0, sizeof(crtc_bw->used_bw));
cd19154608610a Stanislav Lisovskiy 2020-05-20 456
cd19154608610a Stanislav Lisovskiy 2020-05-20 457
for_each_plane_id_on_crtc(crtc, plane_id) {
cd19154608610a Stanislav Lisovskiy 2020-05-20 458 const
struct skl_ddb_entry *plane_alloc =
cd19154608610a Stanislav Lisovskiy 2020-05-20 459
_state->wm.skl.plane_ddb_y[plane_id];
cd19154608610a Stanislav Lisovskiy 2020-05-20 460 const
struct skl_ddb_entry *uv_plane_alloc =
cd19154608610a Stanislav Lisovskiy 2020-05-20 461
_state->wm.skl.plane_ddb_uv[plane_id];
cd19154608610a Stanislav Lisovskiy 2020-05-20 462
unsigned int data_rate = crtc_state->data_rate[plane_id];
cd19154608610a Stanislav Lisovskiy 2020-05-20 463
unsigned int dbuf_mask = 0;
cd19154608610a Stanislav Lisovskiy 2020-05-20 464
cd19154608610a Stanislav Lisovskiy 2020-05-20 465
dbuf_mask |= skl_ddb_dbuf_slice_mask(dev_priv, plane_alloc);
cd19154608610a Stanislav Lisovskiy 2020-05-20 466
dbu
[kbuild] drivers/infiniband/core/cm.c:882:19-29: ERROR: function cm_finalize_id called on line 2136 inside lock on line 2135 but uses GFP_KERNEL
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: "Jason, Gunthorpe,"
CC: Leon Romanovsky
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: bdc48fa11e46f867ea4d75fa59ee87a7f48be144
commit: c206f8bad15d30f1e35821c21a2fb146e4668ebf RDMA/cm: Make it clearer how
concurrency works in cm_req_handler()
date: 3 months ago
:: branch date: 3 hours ago
:: commit date: 3 months ago
config: arc-randconfig-c021-20200531 (attached as .config)
compiler: arc-elf-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Julia Lawall
coccinelle warnings: (new ones prefixed by >>)
>> drivers/infiniband/core/cm.c:882:19-29: ERROR: function cm_finalize_id
>> called on line 2136 inside lock on line 2135 but uses GFP_KERNEL
#
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c206f8bad15d30f1e35821c21a2fb146e4668ebf
git remote add linus
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout c206f8bad15d30f1e35821c21a2fb146e4668ebf
vim +882 drivers/infiniband/core/cm.c
98f67156a80f37 Jason Gunthorpe 2020-03-10 874
98f67156a80f37 Jason Gunthorpe 2020-03-10 875 /*
98f67156a80f37 Jason Gunthorpe 2020-03-10 876 * Make the ID visible to the
MAD handlers and other threads that use the
98f67156a80f37 Jason Gunthorpe 2020-03-10 877 * xarray.
98f67156a80f37 Jason Gunthorpe 2020-03-10 878 */
98f67156a80f37 Jason Gunthorpe 2020-03-10 879 static void
cm_finalize_id(struct cm_id_private *cm_id_priv)
98f67156a80f37 Jason Gunthorpe 2020-03-10 880 {
98f67156a80f37 Jason Gunthorpe 2020-03-10 881
xa_store_irq(_id_table, cm_local_id(cm_id_priv->id.local_id),
98f67156a80f37 Jason Gunthorpe 2020-03-10 @882
cm_id_priv, GFP_KERNEL);
98f67156a80f37 Jason Gunthorpe 2020-03-10 883 }
98f67156a80f37 Jason Gunthorpe 2020-03-10 884
:: The code at line 882 was first introduced by commit
:: 98f67156a80f37db70ec64787020b1f9bc8aea8c RDMA/cm: Simplify establishing
a listen cm_id
:: TO: Jason Gunthorpe
:: CC: Jason Gunthorpe
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] Re: [PATCH v6] drm/ioctl: Add a ioctl to set and get a label on GEM objects
CC: kbuild-...@lists.01.org
In-Reply-To: <20200528170604.22476-1-rohan.g...@collabora.com>
References: <20200528170604.22476-1-rohan.g...@collabora.com>
TO: Rohan Garg
TO: dri-de...@lists.freedesktop.org
CC: ker...@collabora.com
CC: emil.l.veli...@gmail.com
Hi Rohan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-exynos/exynos-drm-next]
[also build test WARNING on drm-intel/for-linux-next
tegra-drm/drm/tegra/for-next drm-tip/drm-tip linus/master v5.7-rc7
next-20200529]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Rohan-Garg/drm-ioctl-Add-a-ioctl-to-set-and-get-a-label-on-GEM-objects/20200531-000134
base: https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git
exynos-drm-next
:: branch date: 16 hours ago
:: commit date: 16 hours ago
config: i386-randconfig-m021-20200531 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
New smatch warnings:
drivers/gpu/drm/drm_gem.c:1004 drm_gem_get_label() warn: maybe return -EFAULT
instead of the bytes remaining?
Old smatch warnings:
drivers/gpu/drm/drm_gem.c:910 drm_gem_open_ioctl() warn: inconsistent returns
'dev->object_name_lock'.
#
https://github.com/0day-ci/linux/commit/174b10d2bdba06efe773aa0d09e682a57a00ec67
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 174b10d2bdba06efe773aa0d09e682a57a00ec67
vim +1004 drivers/gpu/drm/drm_gem.c
174b10d2bdba06 Rohan Garg 2020-05-28 978
174b10d2bdba06 Rohan Garg 2020-05-28 979 int drm_gem_get_label(struct
drm_device *dev, struct drm_file *file_priv,
174b10d2bdba06 Rohan Garg 2020-05-28 980struct
drm_handle_label *args)
174b10d2bdba06 Rohan Garg 2020-05-28 981 {
174b10d2bdba06 Rohan Garg 2020-05-28 982 struct drm_gem_object *gem_obj;
174b10d2bdba06 Rohan Garg 2020-05-28 983 int len, ret;
174b10d2bdba06 Rohan Garg 2020-05-28 984
174b10d2bdba06 Rohan Garg 2020-05-28 985 gem_obj =
drm_gem_object_lookup(file_priv, args->handle);
174b10d2bdba06 Rohan Garg 2020-05-28 986 if (!gem_obj) {
174b10d2bdba06 Rohan Garg 2020-05-28 987 DRM_DEBUG("Failed to
look up GEM BO %d\n", args->handle);
174b10d2bdba06 Rohan Garg 2020-05-28 988 return -ENOENT;
174b10d2bdba06 Rohan Garg 2020-05-28 989 }
174b10d2bdba06 Rohan Garg 2020-05-28 990
174b10d2bdba06 Rohan Garg 2020-05-28 991 if (!gem_obj->label) {
174b10d2bdba06 Rohan Garg 2020-05-28 992 args->label = NULL;
174b10d2bdba06 Rohan Garg 2020-05-28 993 args->len = 0;
174b10d2bdba06 Rohan Garg 2020-05-28 994 return 0;
174b10d2bdba06 Rohan Garg 2020-05-28 995 }
174b10d2bdba06 Rohan Garg 2020-05-28 996
174b10d2bdba06 Rohan Garg 2020-05-28 997 mutex_lock(_obj->bo_lock);
174b10d2bdba06 Rohan Garg 2020-05-28 998 len = strlen(gem_obj->label);
174b10d2bdba06 Rohan Garg 2020-05-28 999 ret =
copy_to_user(u64_to_user_ptr(args->label), gem_obj->label,
174b10d2bdba06 Rohan Garg 2020-05-28 1000
min(args->len, len));
174b10d2bdba06 Rohan Garg 2020-05-28 1001 mutex_unlock(_obj->bo_lock);
174b10d2bdba06 Rohan Garg 2020-05-28 1002 args->len = len;
174b10d2bdba06 Rohan Garg 2020-05-28 1003 drm_gem_object_put(gem_obj);
174b10d2bdba06 Rohan Garg 2020-05-28 @1004 return ret;
174b10d2bdba06 Rohan Garg 2020-05-28 1005 }
174b10d2bdba06 Rohan Garg 2020-05-28 1006 EXPORT_SYMBOL(drm_gem_get_label);
174b10d2bdba06 Rohan Garg 2020-05-28 1007
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] Re: [PATCH v4] drivers: most: add USB adapter driver
CC: kbuild-...@lists.01.org
In-Reply-To: <1590585268-25423-1-git-send-email-christian.gr...@microchip.com>
References: <1590585268-25423-1-git-send-email-christian.gr...@microchip.com>
TO: Christian Gromm
TO: gre...@linuxfoundation.org
CC: Christian Gromm
CC: driverdev-de...@linuxdriverproject.org
CC: linux-...@vger.kernel.org
Hi Christian,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
[also build test WARNING on linus/master v5.7-rc7 next-20200529]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Christian-Gromm/drivers-most-add-USB-adapter-driver/20200527-211740
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
36cf583eaff3458abbfac144c5e4d417a23fa1a1
:: branch date: 4 days ago
:: commit date: 4 days ago
config: x86_64-randconfig-m001-20200531 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/most/most_usb.c:220 get_stream_frame_size() error: uninitialized symbol
'frame_size'.
#
https://github.com/0day-ci/linux/commit/0ea547bd5c23af58b60f907ee741a02bb1488a4e
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 0ea547bd5c23af58b60f907ee741a02bb1488a4e
vim +/frame_size +220 drivers/most/most_usb.c
0ea547bd5c23af Christian Gromm 2020-05-27 186
0ea547bd5c23af Christian Gromm 2020-05-27 187 /**
0ea547bd5c23af Christian Gromm 2020-05-27 188 * get_stream_frame_size -
calculate frame size of current configuration
0ea547bd5c23af Christian Gromm 2020-05-27 189 * @dev: device structure
0ea547bd5c23af Christian Gromm 2020-05-27 190 * @cfg: channel configuration
0ea547bd5c23af Christian Gromm 2020-05-27 191 */
0ea547bd5c23af Christian Gromm 2020-05-27 192 static unsigned int
get_stream_frame_size(struct device *dev,
0ea547bd5c23af Christian Gromm 2020-05-27 193
struct most_channel_config *cfg)
0ea547bd5c23af Christian Gromm 2020-05-27 194 {
0ea547bd5c23af Christian Gromm 2020-05-27 195 unsigned int frame_size;
0ea547bd5c23af Christian Gromm 2020-05-27 196 unsigned int sub_size =
cfg->subbuffer_size;
0ea547bd5c23af Christian Gromm 2020-05-27 197
0ea547bd5c23af Christian Gromm 2020-05-27 198 if (!sub_size) {
0ea547bd5c23af Christian Gromm 2020-05-27 199 dev_warn(dev,
"Misconfig: Subbuffer size zero.\n");
0ea547bd5c23af Christian Gromm 2020-05-27 200 return 0;
0ea547bd5c23af Christian Gromm 2020-05-27 201 }
0ea547bd5c23af Christian Gromm 2020-05-27 202 switch (cfg->data_type)
{
0ea547bd5c23af Christian Gromm 2020-05-27 203 case MOST_CH_ISOC:
0ea547bd5c23af Christian Gromm 2020-05-27 204 frame_size =
AV_PACKETS_PER_XACT * sub_size;
0ea547bd5c23af Christian Gromm 2020-05-27 205 break;
0ea547bd5c23af Christian Gromm 2020-05-27 206 case MOST_CH_SYNC:
0ea547bd5c23af Christian Gromm 2020-05-27 207 if
(cfg->packets_per_xact == 0) {
0ea547bd5c23af Christian Gromm 2020-05-27 208
dev_warn(dev, "Misconfig: Packets per XACT zero\n");
0ea547bd5c23af Christian Gromm 2020-05-27 209
frame_size = 0;
0ea547bd5c23af Christian Gromm 2020-05-27 210 } else if
(cfg->packets_per_xact == 0xFF) {
0ea547bd5c23af Christian Gromm 2020-05-27 211
frame_size = (USB_MTU / sub_size) * sub_size;
0ea547bd5c23af Christian Gromm 2020-05-27 212 } else {
0ea547bd5c23af Christian Gromm 2020-05-27 213
frame_size = cfg->packets_per_xact * sub_size;
0ea547bd5c23af Christian Gromm 2020-05-27 214 }
0ea547bd5c23af Christian Gromm 2020-05-27 215 break;
0ea547bd5c23af Christian Gromm 2020-05-27 216 default:
0ea547bd5c23af Christian Gromm 2020-05-27 217 dev_warn(dev,
"Query frame size of non-streaming channel\n");
0ea547bd5c23af Christian Gromm 2020-05-27 218 break;
0ea547bd5c23af Christian Gromm 2020-05-27 219 }
0ea547bd5c23af Christian Gromm 2020-05-27 @220 return frame_size;
0ea547bd5c23af Christian Gromm 2020-05-27 221 }
0ea547bd5c23af Christian Gromm 2020-05-27 222
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing
[kbuild] [linux-next:master 11624/14131] drivers/leds/leds-aw2013.c:402 aw2013_probe() warn: inconsistent returns 'chip->mutex'.
CC: kbuild-...@lists.01.org
TO: "Nikita, Travkin,"
CC: Pavel Machek
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: e7b08814b16b80a0bf76eeca16317f8c2ed23b8c
commit: 59ea3c9faf3235b66bc31ca883d59ce58b8b2b27 [11624/14131] leds: add aw2013
driver
:: branch date: 2 days ago
:: commit date: 6 days ago
config: arc-randconfig-m031-20200531 (attached as .config)
compiler: arc-elf-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/leds/leds-aw2013.c:402 aw2013_probe() warn: inconsistent returns
'chip->mutex'.
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=59ea3c9faf3235b66bc31ca883d59ce58b8b2b27
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout 59ea3c9faf3235b66bc31ca883d59ce58b8b2b27
vim +402 drivers/leds/leds-aw2013.c
59ea3c9faf3235 Nikita Travkin 2020-05-11 327
59ea3c9faf3235 Nikita Travkin 2020-05-11 328 static int aw2013_probe(struct
i2c_client *client)
59ea3c9faf3235 Nikita Travkin 2020-05-11 329 {
59ea3c9faf3235 Nikita Travkin 2020-05-11 330 struct aw2013 *chip;
59ea3c9faf3235 Nikita Travkin 2020-05-11 331 int ret;
59ea3c9faf3235 Nikita Travkin 2020-05-11 332 unsigned int chipid;
59ea3c9faf3235 Nikita Travkin 2020-05-11 333
59ea3c9faf3235 Nikita Travkin 2020-05-11 334 chip =
devm_kzalloc(>dev, sizeof(*chip), GFP_KERNEL);
59ea3c9faf3235 Nikita Travkin 2020-05-11 335 if (!chip)
59ea3c9faf3235 Nikita Travkin 2020-05-11 336 return -ENOMEM;
59ea3c9faf3235 Nikita Travkin 2020-05-11 337
59ea3c9faf3235 Nikita Travkin 2020-05-11 338 mutex_init(>mutex);
59ea3c9faf3235 Nikita Travkin 2020-05-11 339 mutex_lock(>mutex);
59ea3c9faf3235 Nikita Travkin 2020-05-11 340
59ea3c9faf3235 Nikita Travkin 2020-05-11 341 chip->client = client;
59ea3c9faf3235 Nikita Travkin 2020-05-11 342 i2c_set_clientdata(client,
chip);
59ea3c9faf3235 Nikita Travkin 2020-05-11 343
59ea3c9faf3235 Nikita Travkin 2020-05-11 344 chip->regmap =
devm_regmap_init_i2c(client, _regmap_config);
59ea3c9faf3235 Nikita Travkin 2020-05-11 345 if (IS_ERR(chip->regmap)) {
59ea3c9faf3235 Nikita Travkin 2020-05-11 346 ret =
PTR_ERR(chip->regmap);
59ea3c9faf3235 Nikita Travkin 2020-05-11 347 dev_err(>dev,
"Failed to allocate register map: %d\n",
59ea3c9faf3235 Nikita Travkin 2020-05-11 348 ret);
59ea3c9faf3235 Nikita Travkin 2020-05-11 349 goto error;
59ea3c9faf3235 Nikita Travkin 2020-05-11 350 }
59ea3c9faf3235 Nikita Travkin 2020-05-11 351
59ea3c9faf3235 Nikita Travkin 2020-05-11 352 chip->vcc_regulator =
devm_regulator_get(>dev, "vcc");
59ea3c9faf3235 Nikita Travkin 2020-05-11 353 ret =
PTR_ERR_OR_ZERO(chip->vcc_regulator);
59ea3c9faf3235 Nikita Travkin 2020-05-11 354 if (ret) {
59ea3c9faf3235 Nikita Travkin 2020-05-11 355 if (ret !=
-EPROBE_DEFER)
59ea3c9faf3235 Nikita Travkin 2020-05-11 356
dev_err(>dev,
59ea3c9faf3235 Nikita Travkin 2020-05-11 357 "Failed
to request regulator: %d\n", ret);
59ea3c9faf3235 Nikita Travkin 2020-05-11 358 goto error;
59ea3c9faf3235 Nikita Travkin 2020-05-11 359 }
59ea3c9faf3235 Nikita Travkin 2020-05-11 360
59ea3c9faf3235 Nikita Travkin 2020-05-11 361 ret =
regulator_enable(chip->vcc_regulator);
59ea3c9faf3235 Nikita Travkin 2020-05-11 362 if (ret) {
59ea3c9faf3235 Nikita Travkin 2020-05-11 363 dev_err(>dev,
59ea3c9faf3235 Nikita Travkin 2020-05-11 364 "Failed to
enable regulator: %d\n", ret);
59ea3c9faf3235 Nikita Travkin 2020-05-11 365 goto error;
59ea3c9faf3235 Nikita Travkin 2020-05-11 366 }
59ea3c9faf3235 Nikita Travkin 2020-05-11 367
59ea3c9faf3235 Nikita Travkin 2020-05-11 368 ret = regmap_read(chip->regmap,
AW2013_RSTR, );
59ea3c9faf3235 Nikita Travkin 2020-05-11 369 if (ret) {
59ea3c9faf3235 Nikita Travkin 2020-05-11 370 dev_err(>dev,
"Failed to read chip ID: %d\n",
59ea3c9faf3235 Nikita Travkin 2020-05-11 371 ret);
59ea3c9faf3235 Nikita Travkin 2020-05-11 372 goto error_reg;
59ea3c9faf3235 Nikita Travkin 2020-05-11 373 }
59ea3c9faf3235 Nikita Travkin 2020-05-11 374
59ea3c9faf3235 Nikita Travkin 2020-05-11 375 if (chipid !=
AW2013_RSTR_CHIP_ID) {
59ea3c9faf3235 Nikita Travkin 2020-05-11 376 dev_err(>dev,
"Chip reported wrong ID: %x\n",
59ea3c9faf3235 Nikita Travkin 2020-05-11 377 chipid);
59ea3c9faf3235 Nikita Travkin 2020-05-11 378 ret = -ENODEV;
59ea3c9faf3235 Nikita Travkin 2020-05-11 379 goto error_reg;
59ea3c9faf3235 Nikita Tra
[kbuild] [linux-next:master 12331/14131] drivers/staging/most/usb/usb.c:220 get_stream_frame_size() error: uninitialized symbol 'frame_size'.
CC: kbuild-...@lists.01.org
TO: "Christian, Gromm,"
CC: "Greg Kroah-Hartman"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: e7b08814b16b80a0bf76eeca16317f8c2ed23b8c
commit: 2c069b61a843dc9c3d2296b54c4baa9730286530 [12331/14131] staging: most:
usb: return 0 instead of variable
:: branch date: 2 days ago
:: commit date: 4 days ago
config: x86_64-randconfig-m001-20200531 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/staging/most/usb/usb.c:220 get_stream_frame_size() error: uninitialized
symbol 'frame_size'.
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=2c069b61a843dc9c3d2296b54c4baa9730286530
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout 2c069b61a843dc9c3d2296b54c4baa9730286530
vim +/frame_size +220 drivers/staging/most/usb/usb.c
e33269f60ae114 drivers/staging/most/hdm-usb/hdm_usb.c Andrey Shvetsov
2016-10-25 186
a4198cdf0c3460 drivers/staging/most/hdm-usb/hdm_usb.c Christian Gromm
2015-07-24 187 /**
a4198cdf0c3460 drivers/staging/most/hdm-usb/hdm_usb.c Christian Gromm
2015-07-24 188 * get_stream_frame_size - calculate frame size of current
configuration
1c538a417977ec drivers/staging/most/usb/usb.c Christian Gromm
2020-05-27 189 * @dev: device structure
a4198cdf0c3460 drivers/staging/most/hdm-usb/hdm_usb.c Christian Gromm
2015-07-24 190 * @cfg: channel configuration
a4198cdf0c3460 drivers/staging/most/hdm-usb/hdm_usb.c Christian Gromm
2015-07-24 191 */
1c538a417977ec drivers/staging/most/usb/usb.c Christian Gromm
2020-05-27 192 static unsigned int get_stream_frame_size(struct device *dev,
1c538a417977ec drivers/staging/most/usb/usb.c Christian Gromm
2020-05-27 193 struct most_channel_config
*cfg)
a4198cdf0c3460 drivers/staging/most/hdm-usb/hdm_usb.c Christian Gromm
2015-07-24 194 {
2c069b61a843dc drivers/staging/most/usb/usb.c Christian Gromm
2020-05-27 195 unsigned int frame_size;
a4198cdf0c3460 drivers/staging/most/hdm-usb/hdm_usb.c Christian Gromm
2015-07-24 196 unsigned int sub_size = cfg->subbuffer_size;
a4198cdf0c3460 drivers/staging/most/hdm-usb/hdm_usb.c Christian Gromm
2015-07-24 197
a4198cdf0c3460 drivers/staging/most/hdm-usb/hdm_usb.c Christian Gromm
2015-07-24 198 if (!sub_size) {
62573221240fdf drivers/staging/most/usb/usb.c Christian Gromm
2020-05-15 199 dev_warn(dev, "Misconfig: Subbuffer size zero.\n");
2c069b61a843dc drivers/staging/most/usb/usb.c Christian Gromm
2020-05-27 200 return 0;
a4198cdf0c3460 drivers/staging/most/hdm-usb/hdm_usb.c Christian Gromm
2015-07-24 201 }
a4198cdf0c3460 drivers/staging/most/hdm-usb/hdm_usb.c Christian Gromm
2015-07-24 202 switch (cfg->data_type) {
0540609fe217c3 drivers/staging/most/hdm-usb/hdm_usb.c Andrey Shvetsov
2016-09-21 203 case MOST_CH_ISOC:
a4198cdf0c3460 drivers/staging/most/hdm-usb/hdm_usb.c Christian Gromm
2015-07-24 204 frame_size = AV_PACKETS_PER_XACT * sub_size;
a4198cdf0c3460 drivers/staging/most/hdm-usb/hdm_usb.c Christian Gromm
2015-07-24 205 break;
a4198cdf0c3460 drivers/staging/most/hdm-usb/hdm_usb.c Christian Gromm
2015-07-24 206 case MOST_CH_SYNC:
a4198cdf0c3460 drivers/staging/most/hdm-usb/hdm_usb.c Christian Gromm
2015-07-24 207 if (cfg->packets_per_xact == 0) {
62573221240fdf drivers/staging/most/usb/usb.c Christian Gromm
2020-05-15 208 dev_warn(dev, "Misconfig: Packets per XACT
zero\n");
a4198cdf0c3460 drivers/staging/most/hdm-usb/hdm_usb.c Christian Gromm
2015-07-24 209 frame_size = 0;
9deba73de56ce5 drivers/staging/most/hdm-usb/hdm_usb.c Christian Gromm
2015-10-21 210 } else if (cfg->packets_per_xact == 0xFF) {
a4198cdf0c3460 drivers/staging/most/hdm-usb/hdm_usb.c Christian Gromm
2015-07-24 211 frame_size = (USB_MTU / sub_size) * sub_size;
9deba73de56ce5 drivers/staging/most/hdm-usb/hdm_usb.c Christian Gromm
2015-10-21 212 } else {
a4198cdf0c3460 drivers/staging/most/hdm-usb/hdm_usb.c Christian Gromm
2015-07-24 213 frame_size = cfg->packets_per_xact * sub_size;
9deba73de56ce5 drivers/staging/most/hdm-usb/hdm_usb.c Christian Gromm
2015-10-21 214 }
a4198cdf0c3460 drivers/staging/most/hdm-usb/hdm_usb.c Christian Gromm
2015-07-24 215 break;
a4198cdf0c3460 drivers/staging/most/hdm-usb/hdm_usb.c Christian Gromm
2015-07-24 216 default:
62573221240fdf drivers/staging/most/usb/usb.c Christian Gromm
2020-05-15 217 dev_warn(dev, "Query frame size of non-streaming
channe
[kbuild] Re: [Intel-gfx] [PATCH] drm/i915: Track i915_vma with its own reference counter
CC: kbuild-...@lists.01.org
In-Reply-To: <20200528211547.29392-1-ch...@chris-wilson.co.uk>
References: <20200528211547.29392-1-ch...@chris-wilson.co.uk>
TO: Chris Wilson
TO: intel-...@lists.freedesktop.org
CC: Chris Wilson
Hi Chris,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-tip/drm-tip]
[cannot apply to drm-intel/for-linux-next v5.7-rc7 next-20200529]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-Track-i915_vma-with-its-own-reference-counter/20200531-021238
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
:: branch date: 5 hours ago
:: commit date: 5 hours ago
config: i386-randconfig-c001-20200531 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Julia Lawall
coccinelle warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/i915/i915_vma.c:1063:5-24: atomic_dec_and_test variation
>> before object free at line 1072.
drivers/gpu/drm/i915/i915_vma.c:843:47-48: atomic_add_unless
#
https://github.com/0day-ci/linux/commit/51c8e14b179d9348ce97abfaa5f80a65dc244f2f
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 51c8e14b179d9348ce97abfaa5f80a65dc244f2f
vim +1063 drivers/gpu/drm/i915/i915_vma.c
51c8e14b179d93 Chris Wilson 2020-05-28 1044
51c8e14b179d93 Chris Wilson 2020-05-28 1045 void i915_vma_close(struct
i915_vma *vma)
3365e2268b6bc3 Chris Wilson 2018-05-03 1046 {
51c8e14b179d93 Chris Wilson 2020-05-28 1047struct i915_vma_clock *clock =
>vm->gt->vma_clock;
51c8e14b179d93 Chris Wilson 2020-05-28 1048
3365e2268b6bc3 Chris Wilson 2018-05-03 1049/*
3365e2268b6bc3 Chris Wilson 2018-05-03 1050 * We defer actually closing,
unbinding and destroying the VMA until
3365e2268b6bc3 Chris Wilson 2018-05-03 1051 * the next idle point, or if
the object is freed in the meantime. By
3365e2268b6bc3 Chris Wilson 2018-05-03 1052 * postponing the unbind, we
allow for it to be resurrected by the
3365e2268b6bc3 Chris Wilson 2018-05-03 1053 * client, avoiding the work
required to rebind the VMA. This is
3365e2268b6bc3 Chris Wilson 2018-05-03 1054 * advantageous for DRI, where
the client/server pass objects
3365e2268b6bc3 Chris Wilson 2018-05-03 1055 * between themselves,
temporarily opening a local VMA to the
3365e2268b6bc3 Chris Wilson 2018-05-03 1056 * object, and then closing it
again. The same object is then reused
3365e2268b6bc3 Chris Wilson 2018-05-03 1057 * on the next frame (or two,
depending on the depth of the swap queue)
3365e2268b6bc3 Chris Wilson 2018-05-03 1058 * causing us to rebind the VMA
once more. This ends up being a lot
3365e2268b6bc3 Chris Wilson 2018-05-03 1059 * of wasted work for the
steady state.
3365e2268b6bc3 Chris Wilson 2018-05-03 1060 */
50689771c8f073 Chris Wilson 2020-04-22 1061
50689771c8f073 Chris Wilson 2020-04-22 1062
GEM_BUG_ON(!atomic_read(>open_count));
51c8e14b179d93 Chris Wilson 2020-05-28 @1063if
(atomic_dec_and_lock(>open_count, >lock)) {
51c8e14b179d93 Chris Wilson 2020-05-28 1064
GEM_BUG_ON(i915_vma_is_closed(vma));
51c8e14b179d93 Chris Wilson 2020-05-28 1065if
(object_inuse(vma->obj)) {
51c8e14b179d93 Chris Wilson 2020-05-28 1066
i915_vma_get(vma);
51c8e14b179d93 Chris Wilson 2020-05-28 1067
list_add(>closed_link, >age[0]);
50689771c8f073 Chris Wilson 2020-04-22 1068}
51c8e14b179d93 Chris Wilson 2020-05-28 1069
spin_unlock(>lock);
3365e2268b6bc3 Chris Wilson 2018-05-03 1070
51c8e14b179d93 Chris Wilson 2020-05-28 1071if
(!list_empty(>closed_link))
51c8e14b179d93 Chris Wilson 2020-05-28 @1072
schedule_delayed_work(>work,
51c8e14b179d93 Chris Wilson 2020-05-28 1073
round_jiffies_up_relative(HZ));
51c8e14b179d93 Chris Wilson 2020-05-28 1074}
3365e2268b6bc3 Chris Wilson 2018-05-03 1075
51c8e14b179d93 Chris Wilson 2020-05-28 1076i915_vma_put(vma);
3365e2268b6bc3 Chris Wilson 2018-05-03 1077 }
155ab8836caa69 Chris Wilson 2019-06-06 1078
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [dhowells-fs:afs-operation 22/27] fs/afs/callback.c:74:38: sparse: sparse: context imbalance in 'afs_lookup_volume_rcu' - different lock contexts for basic block
CC: kbuild-...@lists.01.org
TO: "David, Howells,"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
afs-operation
head: 0295d9a491871fb70f3e5792955d8ae0801a7ae5
commit: 44f32d4b0c05e78ca628dc52f04d86ec98da1e95 [22/27] afs: Reorganise volume
and server trees to be rooted on the cell
:: branch date: 30 hours ago
:: commit date: 30 hours ago
config: parisc-randconfig-s031-20200531 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout 44f32d4b0c05e78ca628dc52f04d86ec98da1e95
# save the attached .config to linux build tree
make W=1 C=1 ARCH=parisc CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
>> fs/afs/callback.c:74:38: sparse: sparse: context imbalance in
>> 'afs_lookup_volume_rcu' - different lock contexts for basic block
#
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/commit/?id=44f32d4b0c05e78ca628dc52f04d86ec98da1e95
git remote add dhowells-fs
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
git remote update dhowells-fs
git checkout 44f32d4b0c05e78ca628dc52f04d86ec98da1e95
vim +/afs_lookup_volume_rcu +74 fs/afs/callback.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 58
fc7e32d8695359 David Howells 2020-03-27 59 /*
44f32d4b0c05e7 David Howells 2020-04-30 60 * Look up a volume by volume ID
under RCU conditions.
fc7e32d8695359 David Howells 2020-03-27 61 */
44f32d4b0c05e7 David Howells 2020-04-30 62 static struct afs_volume
*afs_lookup_volume_rcu(struct afs_cell *cell,
fc7e32d8695359 David Howells 2020-03-27 63
afs_volid_t vid)
fc7e32d8695359 David Howells 2020-03-27 64 {
44f32d4b0c05e7 David Howells 2020-04-30 65struct afs_volume *volume =
NULL;
fc7e32d8695359 David Howells 2020-03-27 66struct rb_node *p;
fc7e32d8695359 David Howells 2020-03-27 67int seq = 0;
fc7e32d8695359 David Howells 2020-03-27 68
fc7e32d8695359 David Howells 2020-03-27 69do {
fc7e32d8695359 David Howells 2020-03-27 70/* Unfortunately,
rbtree walking doesn't give reliable results
fc7e32d8695359 David Howells 2020-03-27 71 * under just the RCU
read lock, so we have to check for
fc7e32d8695359 David Howells 2020-03-27 72 * changes.
fc7e32d8695359 David Howells 2020-03-27 73 */
44f32d4b0c05e7 David Howells 2020-04-30 @74
read_seqbegin_or_lock(>volume_lock, );
fc7e32d8695359 David Howells 2020-03-27 75
44f32d4b0c05e7 David Howells 2020-04-30 76p =
rcu_dereference_raw(cell->volumes.rb_node);
fc7e32d8695359 David Howells 2020-03-27 77while (p) {
44f32d4b0c05e7 David Howells 2020-04-30 78volume =
rb_entry(p, struct afs_volume, cell_node);
fc7e32d8695359 David Howells 2020-03-27 79
44f32d4b0c05e7 David Howells 2020-04-30 80if (volume->vid
< vid)
fc7e32d8695359 David Howells 2020-03-27 81p =
rcu_dereference_raw(p->rb_left);
44f32d4b0c05e7 David Howells 2020-04-30 82else if
(volume->vid > vid)
fc7e32d8695359 David Howells 2020-03-27 83p =
rcu_dereference_raw(p->rb_right);
fc7e32d8695359 David Howells 2020-03-27 84else
fc7e32d8695359 David Howells 2020-03-27 85break;
44f32d4b0c05e7 David Howells 2020-04-30 86volume = NULL;
fc7e32d8695359 David Howells 2020-03-27 87}
fc7e32d8695359 David Howells 2020-03-27 88
44f32d4b0c05e7 David Howells 2020-04-30 89} while
(need_seqretry(>volume_lock, seq));
fc7e32d8695359 David Howells 2020-03-27 90
44f32d4b0c05e7 David Howells 2020-04-30 91
done_seqretry(>volume_lock, seq);
44f32d4b0c05e7 David Howells 2020-04-30 92return volume;
fc7e32d8695359 David Howells 2020-03-27 93 }
fc7e32d8695359 David Howells 2020-03-27 94
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [jlayton:ceph-fscache-iter 76/77] fs/ceph/addr.c:225 ceph_fsreq_issue_op() error: uninitialized symbol 'err'.
CC: kbuild-...@lists.01.org
TO: "Jeff, Layton,"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlayton/linux.git
ceph-fscache-iter
head: ce11bedb85675dee88f70d28fc09cb5bca59c73e
commit: abd9e1c4c6c6d86ef46c1782a886b52f09d87ebb [76/77] ceph: convert
writepage over to new helper
:: branch date: 2 days ago
:: commit date: 2 days ago
config: x86_64-randconfig-m001-20200529 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
New smatch warnings:
fs/ceph/addr.c:225 ceph_fsreq_issue_op() error: uninitialized symbol 'err'.
fs/ceph/addr.c:1356 writeback_older_snapc() error: potentially dereferencing
uninitialized 'oldest'.
Old smatch warnings:
fs/ceph/addr.c:432 start_read() warn: should 'nr_pages << 12' be a 64 bit type?
fs/ceph/addr.c:468 start_read() warn: should 'nr_pages << 12' be a 64 bit type?
fs/ceph/addr.c:2044 __ceph_pool_perm_get() error: we previously assumed
'pool_ns' could be null (see line 2033)
include/linux/ceph/string_table.h:46 ceph_compare_string() error: we previously
assumed 'cs' could be null (see line 41)
#
https://git.kernel.org/pub/scm/linux/kernel/git/jlayton/linux.git/commit/?id=abd9e1c4c6c6d86ef46c1782a886b52f09d87ebb
git remote add jlayton
https://git.kernel.org/pub/scm/linux/kernel/git/jlayton/linux.git
git remote update jlayton
git checkout abd9e1c4c6c6d86ef46c1782a886b52f09d87ebb
vim +/err +225 fs/ceph/addr.c
1d3576fd10f0d7 Sage Weil 2009-10-06 187
e4de9a35b08dcf Jeff Layton 2020-05-21 188 static void
ceph_fsreq_issue_op(struct fscache_io_request *fsreq)
e4de9a35b08dcf Jeff Layton 2020-05-21 189 {
e4de9a35b08dcf Jeff Layton 2020-05-21 190 struct ceph_fsc_request *cfreq
= container_of(fsreq,
e4de9a35b08dcf Jeff Layton 2020-05-21 191
struct ceph_fsc_request,
e4de9a35b08dcf Jeff Layton 2020-05-21 192
fsc_req);
e4de9a35b08dcf Jeff Layton 2020-05-21 193 struct ceph_osd_request *req =
>osd_req;
e4de9a35b08dcf Jeff Layton 2020-05-21 194 struct ceph_fs_client *fsc =
req->r_priv;
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 195 struct ceph_inode_info *ci =
ceph_inode(fsreq->mapping->host);
e4de9a35b08dcf Jeff Layton 2020-05-21 196 int err;
e4de9a35b08dcf Jeff Layton 2020-05-21 197
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 198 if (ci->i_inline_version !=
CEPH_INLINE_NONE) {
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 199 /*
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 200 * Uptodate inline data
should have been added
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 201 * into page cache
while getting Fcr caps.
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 202 */
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 203 if (fsreq->pos == 0)
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 204 err = -EINVAL;
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 205 goto out;
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 206 }
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 207
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 208 /* FIXME: in read-for-write
case, don't issue a read if the write will
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 209 *cover the whole page.
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 210 */
e4de9a35b08dcf Jeff Layton 2020-05-21 211 err =
ceph_osdc_start_request(req->r_osdc, req, false);
e4de9a35b08dcf Jeff Layton 2020-05-21 212 if (!err)
e4de9a35b08dcf Jeff Layton 2020-05-21 213 err =
ceph_osdc_wait_request(req->r_osdc, req);
e4de9a35b08dcf Jeff Layton 2020-05-21 214
e4de9a35b08dcf Jeff Layton 2020-05-21 215
ceph_update_read_latency(>mdsc->metric, req->r_start_latency,
e4de9a35b08dcf Jeff Layton 2020-05-21 216
req->r_end_latency, err);
e4de9a35b08dcf Jeff Layton 2020-05-21 217
e4de9a35b08dcf Jeff Layton 2020-05-21 218 /* no object means success but
no data */
e4de9a35b08dcf Jeff Layton 2020-05-21 219 if (err == -ENOENT)
e4de9a35b08dcf Jeff Layton 2020-05-21 220 err = 0;
e4de9a35b08dcf Jeff Layton 2020-05-21 221 else if (err == -EBLACKLISTED)
e4de9a35b08dcf Jeff Layton 2020-05-21 222 fsc->blacklisted = true;
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 223 out:
e4de9a35b08dcf Jeff Layton 2020-05-21 224 dout("readpage result %d\n",
err);
e4de9a35b08dcf Jeff Layton 2020-05-21 @225 fsreq->error = err;
e4de9a35b08dcf Jeff Layton 2020-05-21 226 if (fsreq->io_done)
e4de9a35b08dcf Jeff Layton 2020-05-21 227 fsreq->io_done(fsreq);
e4de9a35b08dcf Jeff Layton 2020-05-21 228 }
e4de9a35b08dcf Jeff Layton 2020-05-21 229
:: The code at line 225 was first introduced by commit
:: e4de9a35b08dcfef40ba1
[kbuild] Re: [PATCH 1/2] tracing: Move synthetic events to a separate file
CC: kbuild-...@lists.01.org
In-Reply-To:
<9fc01420bdbf756ef3f8267b33aff6de2e6f2b60.1590608239.git.zanu...@kernel.org>
References:
<9fc01420bdbf756ef3f8267b33aff6de2e6f2b60.1590608239.git.zanu...@kernel.org>
TO: Tom Zanussi
Hi Tom,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tip/perf/core]
[also build test WARNING on trace/for-next linus/master v5.7-rc7 next-20200529]
[cannot apply to linux/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Tom-Zanussi/tracing-Make-synthetic-events-a-separate-option/20200528-035736
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
c50c75e9b87946499a62bffc021e95c87a1d57cd
:: branch date: 3 days ago
:: commit date: 3 days ago
config: i386-randconfig-m021-20200529 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
smatch warnings:
kernel/trace/trace_events_synth.c:604 register_synth_event() warn: passing a
valid pointer to 'PTR_ERR'
#
https://github.com/0day-ci/linux/commit/09cc706157bf55e5f7e0a29222b5c5c5ca9f420c
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 09cc706157bf55e5f7e0a29222b5c5c5ca9f420c
vim +/PTR_ERR +604 kernel/trace/trace_events_synth.c
09cc706157bf55 Tom Zanussi 2020-05-27 589
09cc706157bf55 Tom Zanussi 2020-05-27 590 static int
register_synth_event(struct synth_event *event)
09cc706157bf55 Tom Zanussi 2020-05-27 591 {
09cc706157bf55 Tom Zanussi 2020-05-27 592 struct trace_event_call *call =
>call;
09cc706157bf55 Tom Zanussi 2020-05-27 593 int ret = 0;
09cc706157bf55 Tom Zanussi 2020-05-27 594
09cc706157bf55 Tom Zanussi 2020-05-27 595 event->call.class =
>class;
09cc706157bf55 Tom Zanussi 2020-05-27 596 event->class.system =
kstrdup(SYNTH_SYSTEM, GFP_KERNEL);
09cc706157bf55 Tom Zanussi 2020-05-27 597 if (!event->class.system) {
09cc706157bf55 Tom Zanussi 2020-05-27 598 ret = -ENOMEM;
09cc706157bf55 Tom Zanussi 2020-05-27 599 goto out;
09cc706157bf55 Tom Zanussi 2020-05-27 600 }
09cc706157bf55 Tom Zanussi 2020-05-27 601
09cc706157bf55 Tom Zanussi 2020-05-27 602 event->tp =
alloc_synth_tracepoint(event->name);
09cc706157bf55 Tom Zanussi 2020-05-27 603 if (IS_ERR(event->tp)) {
09cc706157bf55 Tom Zanussi 2020-05-27 @604 ret =
PTR_ERR(event->tp);
09cc706157bf55 Tom Zanussi 2020-05-27 605 event->tp = NULL;
09cc706157bf55 Tom Zanussi 2020-05-27 606 goto out;
09cc706157bf55 Tom Zanussi 2020-05-27 607 }
09cc706157bf55 Tom Zanussi 2020-05-27 608
09cc706157bf55 Tom Zanussi 2020-05-27 609
INIT_LIST_HEAD(>class->fields);
09cc706157bf55 Tom Zanussi 2020-05-27 610 call->event.funcs =
_event_funcs;
09cc706157bf55 Tom Zanussi 2020-05-27 611 call->class->fields_array =
synth_event_fields_array;
09cc706157bf55 Tom Zanussi 2020-05-27 612
09cc706157bf55 Tom Zanussi 2020-05-27 613 ret =
register_trace_event(>event);
09cc706157bf55 Tom Zanussi 2020-05-27 614 if (!ret) {
09cc706157bf55 Tom Zanussi 2020-05-27 615 ret = -ENODEV;
09cc706157bf55 Tom Zanussi 2020-05-27 616 goto out;
09cc706157bf55 Tom Zanussi 2020-05-27 617 }
09cc706157bf55 Tom Zanussi 2020-05-27 618 call->flags =
TRACE_EVENT_FL_TRACEPOINT;
09cc706157bf55 Tom Zanussi 2020-05-27 619 call->class->reg =
trace_event_reg;
09cc706157bf55 Tom Zanussi 2020-05-27 620 call->class->probe =
trace_event_raw_event_synth;
09cc706157bf55 Tom Zanussi 2020-05-27 621 call->data = event;
09cc706157bf55 Tom Zanussi 2020-05-27 622 call->tp = event->tp;
09cc706157bf55 Tom Zanussi 2020-05-27 623
09cc706157bf55 Tom Zanussi 2020-05-27 624 ret =
trace_add_event_call(call);
09cc706157bf55 Tom Zanussi 2020-05-27 625 if (ret) {
09cc706157bf55 Tom Zanussi 2020-05-27 626 pr_warn("Failed to
register synthetic event: %s\n",
09cc706157bf55 Tom Zanussi 2020-05-27 627
trace_event_name(call));
09cc706157bf55 Tom Zanussi 2020-05-27 628 goto err;
09cc706157bf55 Tom Zanussi 2020-05-27 629 }
09cc706157bf55 Tom Zanussi 2020-05-27 630
09cc706157bf55 Tom Zanussi 2020-05-27 631 ret =
set_synth_event_print_fmt(call);
09cc706157bf55 Tom Zanussi 2020-05-27 632 if (ret < 0) {
09cc706157bf55 Tom Zanussi 2020-05-27 633
trace_remove_event_call(call);
09cc706157bf55 Tom Zanussi 2020-05-27 634 goto err;
0
[kbuild] kernel/trace/trace_events_trigger.c:1564:21-25: ERROR: invalid reference to the index variable of the iterator on line 1550
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: "Masami, Hiramatsu,"
CC: "Steven Rostedt (VMware)"
CC: Tom Zanussi
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 86852175b016f0c6873dcbc24b93d12b7b246612
commit: aeed8aa3874dc15b9d82a6fe796fd7cfbb684448 tracing: trigger: Replace
unneeded RCU-list traversals
date: 5 months ago
:: branch date: 14 hours ago
:: commit date: 5 months ago
config: x86_64-randconfig-c002-20200529 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Julia Lawall
coccinelle warnings: (new ones prefixed by >>)
>> kernel/trace/trace_events_trigger.c:1564:21-25: ERROR: invalid reference to
>> the index variable of the iterator on line 1550
kernel/trace/trace_events_trigger.c:600:21-25: ERROR: invalid reference to
the index variable of the iterator on line 590
#
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=aeed8aa3874dc15b9d82a6fe796fd7cfbb684448
git remote add linus
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout aeed8aa3874dc15b9d82a6fe796fd7cfbb684448
vim +1564 kernel/trace/trace_events_trigger.c
7862ad1846e994 Tom Zanussi 2013-10-24 1537
d0bad49bb0a094 Tom Zanussi 2016-03-03 1538 void
event_enable_unregister_trigger(char *glob,
7862ad1846e994 Tom Zanussi 2013-10-24 1539
struct event_trigger_ops *ops,
7862ad1846e994 Tom Zanussi 2013-10-24 1540
struct event_trigger_data *test,
7f1d2f8210195c Steven Rostedt (Red Hat 2015-05-05 1541)
struct trace_event_file *file)
7862ad1846e994 Tom Zanussi 2013-10-24 1542 {
7862ad1846e994 Tom Zanussi 2013-10-24 1543struct
enable_trigger_data *test_enable_data = test->private_data;
7862ad1846e994 Tom Zanussi 2013-10-24 1544struct
enable_trigger_data *enable_data;
7862ad1846e994 Tom Zanussi 2013-10-24 1545struct
event_trigger_data *data;
7862ad1846e994 Tom Zanussi 2013-10-24 1546bool
unregistered = false;
7862ad1846e994 Tom Zanussi 2013-10-24 1547
aeed8aa3874dc1 Masami Hiramatsu 2019-12-20 1548
lockdep_assert_held(_mutex);
aeed8aa3874dc1 Masami Hiramatsu 2019-12-20 1549
aeed8aa3874dc1 Masami Hiramatsu 2019-12-20 @1550
list_for_each_entry(data, >triggers, list) {
7862ad1846e994 Tom Zanussi 2013-10-24 1551
enable_data = data->private_data;
7862ad1846e994 Tom Zanussi 2013-10-24 1552if
(enable_data &&
d0bad49bb0a094 Tom Zanussi 2016-03-03 1553
(data->cmd_ops->trigger_type ==
d0bad49bb0a094 Tom Zanussi 2016-03-03 1554
test->cmd_ops->trigger_type) &&
7862ad1846e994 Tom Zanussi 2013-10-24 1555
(enable_data->file == test_enable_data->file)) {
7862ad1846e994 Tom Zanussi 2013-10-24 1556
unregistered = true;
7862ad1846e994 Tom Zanussi 2013-10-24 1557
list_del_rcu(>list);
7862ad1846e994 Tom Zanussi 2013-10-24 1558
trace_event_trigger_enable_disable(file, 0);
4e4a4d75700da6 Tom Zanussi 2015-11-23 1559
update_cond_flag(file);
7862ad1846e994 Tom Zanussi 2013-10-24 1560
break;
7862ad1846e994 Tom Zanussi 2013-10-24 1561}
7862ad1846e994 Tom Zanussi 2013-10-24 1562}
7862ad1846e994 Tom Zanussi 2013-10-24 1563
7862ad1846e994 Tom Zanussi 2013-10-24 @1564if
(unregistered && data->ops->free)
7862ad1846e994 Tom Zanussi 2013-10-24 1565
data->ops->free(data->ops, data);
7862ad1846e994 Tom Zanussi 2013-10-24 1566 }
7862ad1846e994 Tom Zanussi 2013-10-24 1567
:: The code at line 1564 was first introduced by commit
:: 7862ad1846e994574cb47dc503cc2b1646ea6593 tracing: Add 'enable_event' and
'disable_event' event trigger commands
:: TO: Tom Zanussi
:: CC: Steven Rostedt
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] Re: [PATCH] ceph: show max caps in debugfs caps file
CC: kbuild-...@lists.01.org
In-Reply-To: <20200521093845.15101-1-gmayy...@gmail.com>
References: <20200521093845.15101-1-gmayy...@gmail.com>
TO: Yanhu Cao
TO: jlay...@kernel.org
CC: idryo...@gmail.com
CC: ceph-de...@vger.kernel.org
CC: linux-ker...@vger.kernel.org
CC: Yanhu Cao
Hi Yanhu,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on ceph-client/for-linus]
[also build test WARNING on v5.7-rc7 next-20200529]
[cannot apply to sage-ceph/for-linus]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Yanhu-Cao/ceph-show-max-caps-in-debugfs-caps-file/20200521-190841
base: https://github.com/ceph/ceph-client.git for-linus
:: branch date: 9 days ago
:: commit date: 9 days ago
config: x86_64-randconfig-m001-20200529 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
smatch warnings:
fs/ceph/debugfs.c:151 caps_show() warn: excess argument passed to 'seq_printf'
#
https://github.com/0day-ci/linux/commit/d35440110f623b99d201f15fa3cc062a35dc6373
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout d35440110f623b99d201f15fa3cc062a35dc6373
vim +/seq_printf +151 fs/ceph/debugfs.c
ff4a80bf2d3f80 Jeff Layton 2019-04-24 136
76aa844d5b2fb8 Sage Weil2009-10-06 137 static int caps_show(struct
seq_file *s, void *p)
76aa844d5b2fb8 Sage Weil2009-10-06 138 {
3d14c5d2b6e15c Yehuda Sadeh 2010-04-06 139 struct ceph_fs_client *fsc =
s->private;
ff4a80bf2d3f80 Jeff Layton 2019-04-24 140 struct ceph_mds_client *mdsc =
fsc->mdsc;
d35440110f623b Yanhu Cao2020-05-21 141 int total, avail, used, max,
reserved, min, i;
3a3430affce5de Jeff Layton 2019-11-20 142 struct cap_wait *cw;
76aa844d5b2fb8 Sage Weil2009-10-06 143
d35440110f623b Yanhu Cao2020-05-21 144 ceph_reservation_status(fsc,
, , , ,
d35440110f623b Yanhu Cao2020-05-21 145
, );
76aa844d5b2fb8 Sage Weil2009-10-06 146 seq_printf(s, "total\t\t%d\n"
76aa844d5b2fb8 Sage Weil2009-10-06 147"avail\t\t%d\n"
76aa844d5b2fb8 Sage Weil2009-10-06 148"used\t\t%d\n"
85ccce43a3fc15 Sage Weil2010-02-17 149"reserved\t%d\n"
ff4a80bf2d3f80 Jeff Layton 2019-04-24 150"min\t\t%d\n\n",
d35440110f623b Yanhu Cao2020-05-21 @151total, avail, used,
max, reserved, min);
ff4a80bf2d3f80 Jeff Layton 2019-04-24 152 seq_printf(s, "ino
issued implemented\n");
ff4a80bf2d3f80 Jeff Layton 2019-04-24 153 seq_printf(s,
"---\n");
ff4a80bf2d3f80 Jeff Layton 2019-04-24 154
ff4a80bf2d3f80 Jeff Layton 2019-04-24 155 mutex_lock(>mutex);
ff4a80bf2d3f80 Jeff Layton 2019-04-24 156 for (i = 0; i <
mdsc->max_sessions; i++) {
ff4a80bf2d3f80 Jeff Layton 2019-04-24 157 struct ceph_mds_session
*session;
ff4a80bf2d3f80 Jeff Layton 2019-04-24 158
ff4a80bf2d3f80 Jeff Layton 2019-04-24 159 session =
__ceph_lookup_mds_session(mdsc, i);
ff4a80bf2d3f80 Jeff Layton 2019-04-24 160 if (!session)
ff4a80bf2d3f80 Jeff Layton 2019-04-24 161 continue;
ff4a80bf2d3f80 Jeff Layton 2019-04-24 162
mutex_unlock(>mutex);
ff4a80bf2d3f80 Jeff Layton 2019-04-24 163
mutex_lock(>s_mutex);
ff4a80bf2d3f80 Jeff Layton 2019-04-24 164
ceph_iterate_session_caps(session, caps_show_cb, s);
ff4a80bf2d3f80 Jeff Layton 2019-04-24 165
mutex_unlock(>s_mutex);
ff4a80bf2d3f80 Jeff Layton 2019-04-24 166
ceph_put_mds_session(session);
ff4a80bf2d3f80 Jeff Layton 2019-04-24 167
mutex_lock(>mutex);
ff4a80bf2d3f80 Jeff Layton 2019-04-24 168 }
ff4a80bf2d3f80 Jeff Layton 2019-04-24 169 mutex_unlock(>mutex);
ff4a80bf2d3f80 Jeff Layton 2019-04-24 170
3a3430affce5de Jeff Layton 2019-11-20 171 seq_printf(s,
"\n\nWaiters:\n\n");
3a3430affce5de Jeff Layton 2019-11-20 172 seq_printf(s, "tgid ino
need want\n");
3a3430affce5de Jeff Layton 2019-11-20 173 seq_printf(s,
"-\n");
3a3430affce5de Jeff Layton 2019-11-20 174
3a3430affce5de Jeff Layton 2019-11-20 175
spin_lock(>caps_list_lock);
3a3430affce5de Jeff Layton 2019-11-20 176 list_for_each_entry(cw,
>cap_wait_list, list) {
3a3
[kbuild] Re: [PATCH] vdpa: bypass waking up vhost_woker for vdpa vq kick
CC: kbuild-...@lists.01.org
In-Reply-To: <1590471145-4436-1-git-send-email-lingshan@intel.com>
References: <1590471145-4436-1-git-send-email-lingshan@intel.com>
TO: Zhu Lingshan
TO: m...@redhat.com
TO: k...@vger.kernel.org
TO: virtualizat...@lists.linux-foundation.org
TO: linux-ker...@vger.kernel.org
TO: net...@vger.kernel.org
TO: jasow...@redhat.com
CC: l...@redhat.com
CC: dan.d...@intel.com
CC: cunming.li...@intel.com
CC: Zhu Lingshan
Hi Zhu,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on vhost/linux-next]
[also build test WARNING on v5.7-rc7 next-20200529]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Zhu-Lingshan/vdpa-bypass-waking-up-vhost_woker-for-vdpa-vq-kick/20200526-133819
base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
:: branch date: 4 days ago
:: commit date: 4 days ago
config: x86_64-randconfig-m001-20200529 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/vhost/vdpa.c:348 vhost_vdpa_set_vring_kick() error: uninitialized
symbol 'r'.
#
https://github.com/0day-ci/linux/commit/a84ddbf1ef29f18aafb2bb8a93bcedd4a29a967d
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout a84ddbf1ef29f18aafb2bb8a93bcedd4a29a967d
vim +/r +348 drivers/vhost/vdpa.c
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 315
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 316 static long
vhost_vdpa_set_vring_kick(struct vhost_virtqueue *vq,
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 317
void __user *argp)
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 318 {
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 319 bool pollstart = false,
pollstop = false;
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 320 struct file *eventfp, *filep =
NULL;
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 321 struct vhost_vring_file f;
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 322 long r;
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 323
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 324 if (copy_from_user(, argp,
sizeof(f)))
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 325 return -EFAULT;
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 326
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 327 eventfp = f.fd == -1 ? NULL :
eventfd_fget(f.fd);
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 328 if (IS_ERR(eventfp)) {
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 329 r = PTR_ERR(eventfp);
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 330 return r;
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 331 }
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 332
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 333 if (eventfp != vq->kick) {
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 334 pollstop = (filep =
vq->kick) != NULL;
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 335 pollstart = (vq->kick =
eventfp) != NULL;
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 336 } else
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 337 filep = eventfp;
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 338
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 339 if (pollstop && vq->handle_kick)
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 340
vhost_vdpa_poll_stop(vq);
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 341
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 342 if (filep)
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 343 fput(filep);
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 344
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 345 if (pollstart &&
vq->handle_kick)
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 346 r =
vhost_vdpa_poll_start(vq);
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 347
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 @348 return r;
a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 349 }
4c8cf31885f69e Tiwei Bie2020-03-26 350
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] Re: [PATCH v3 4/7] watchdog: dw_wdt: Support devices with non-fixed TOP values
CC: kbuild-...@lists.01.org
In-Reply-To: <20200526154123.24402-5-sergey.se...@baikalelectronics.ru>
References: <20200526154123.24402-5-sergey.se...@baikalelectronics.ru>
TO: Serge Semin
Hi Serge,
I love your patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on hwmon/hwmon-next soc/for-next linus/master v5.7-rc7
next-20200529]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Serge-Semin/watchdog-dw_wdt-Take-Baikal-T1-DW-WDT-peculiarities-into-account/20200526-234657
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
:: branch date: 3 days ago
:: commit date: 3 days ago
config: i386-randconfig-m021-20200528 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/watchdog/dw_wdt.c:124 dw_wdt_get_min_timeout() error: buffer overflow
'dw_wdt->timeouts' 16 <= 16 (assuming for loop doesn't break)
drivers/watchdog/dw_wdt.c:147 dw_wdt_get_timeout() error: buffer overflow
'dw_wdt->timeouts' 16 <= 16 (assuming for loop doesn't break)
#
https://github.com/0day-ci/linux/commit/2d6c220c0b6cbc1fd04065b904a6a2f0bfe086e7
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 2d6c220c0b6cbc1fd04065b904a6a2f0bfe086e7
vim +124 drivers/watchdog/dw_wdt.c
2d6c220c0b6cbc Serge Semin 2020-05-26 110
2d6c220c0b6cbc Serge Semin 2020-05-26 111 static unsigned int
dw_wdt_get_min_timeout(struct dw_wdt *dw_wdt)
c9353ae1c69ba1 Jamie Iles 2011-01-24 112 {
2d6c220c0b6cbc Serge Semin 2020-05-26 113 int idx;
2d6c220c0b6cbc Serge Semin 2020-05-26 114
2d6c220c0b6cbc Serge Semin 2020-05-26 115 /*
2d6c220c0b6cbc Serge Semin 2020-05-26 116 * We'll find a timeout greater
or equal to one second anyway because
2d6c220c0b6cbc Serge Semin 2020-05-26 117 * the driver probe would have
failed if there was none.
2d6c220c0b6cbc Serge Semin 2020-05-26 118 */
2d6c220c0b6cbc Serge Semin 2020-05-26 119 for (idx = 0; idx <
DW_WDT_NUM_TOPS; ++idx) {
2d6c220c0b6cbc Serge Semin 2020-05-26 120 if
(dw_wdt->timeouts[idx].sec)
2d6c220c0b6cbc Serge Semin 2020-05-26 121 break;
2d6c220c0b6cbc Serge Semin 2020-05-26 122 }
c9353ae1c69ba1 Jamie Iles 2011-01-24 123
2d6c220c0b6cbc Serge Semin 2020-05-26 @124 return
dw_wdt->timeouts[idx].sec;
2d6c220c0b6cbc Serge Semin 2020-05-26 125 }
2d6c220c0b6cbc Serge Semin 2020-05-26 126
2d6c220c0b6cbc Serge Semin 2020-05-26 127 static unsigned int
dw_wdt_get_max_timeout_ms(struct dw_wdt *dw_wdt)
2d6c220c0b6cbc Serge Semin 2020-05-26 128 {
2d6c220c0b6cbc Serge Semin 2020-05-26 129 struct dw_wdt_timeout *timeout
= _wdt->timeouts[DW_WDT_NUM_TOPS - 1];
2d6c220c0b6cbc Serge Semin 2020-05-26 130 u64 msec;
2d6c220c0b6cbc Serge Semin 2020-05-26 131
2d6c220c0b6cbc Serge Semin 2020-05-26 132 msec = (u64)timeout->sec *
MSEC_PER_SEC + timeout->msec;
2d6c220c0b6cbc Serge Semin 2020-05-26 133
2d6c220c0b6cbc Serge Semin 2020-05-26 134 return msec < UINT_MAX ? msec :
UINT_MAX;
2d6c220c0b6cbc Serge Semin 2020-05-26 135 }
2d6c220c0b6cbc Serge Semin 2020-05-26 136
2d6c220c0b6cbc Serge Semin 2020-05-26 137 static unsigned int
dw_wdt_get_timeout(struct dw_wdt *dw_wdt)
2d6c220c0b6cbc Serge Semin 2020-05-26 138 {
2d6c220c0b6cbc Serge Semin 2020-05-26 139 int top_val =
readl(dw_wdt->regs + WDOG_TIMEOUT_RANGE_REG_OFFSET) & 0xF;
2d6c220c0b6cbc Serge Semin 2020-05-26 140 int idx;
2d6c220c0b6cbc Serge Semin 2020-05-26 141
2d6c220c0b6cbc Serge Semin 2020-05-26 142 for (idx = 0; idx <
DW_WDT_NUM_TOPS; ++idx) {
2d6c220c0b6cbc Serge Semin 2020-05-26 143 if
(dw_wdt->timeouts[idx].top_val == top_val)
2d6c220c0b6cbc Serge Semin 2020-05-26 144 break;
2d6c220c0b6cbc Serge Semin 2020-05-26 145 }
2d6c220c0b6cbc Serge Semin 2020-05-26 146
2d6c220c0b6cbc Serge Semin 2020-05-26 @147 return
dw_wdt->timeouts[idx].sec;
c9353ae1c69ba1 Jamie Iles 2011-01-24 148 }
c9353ae1c69ba1 Jamie Iles 2011-01-24 149
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [ext4:dev 43/50] fs/ext4/mballoc.c:2209:9: sparse: sparse: context imbalance in 'ext4_mb_good_group_nolock' - different lock contexts for basic block
CC: kbuild-...@lists.01.org
CC: linux-e...@vger.kernel.org
TO: "Ritesh, Harjani,"
CC: "Theodore Ts'o"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
head: 38bd76b9696c5582dcef4ab1af437e0666021f65
commit: bf53b03e9d2ac23fb4a3e639fe023f5f1af607b0 [43/50] ext4: mballoc: use
lock for checking free blocks while retrying
:: branch date: 21 hours ago
:: commit date: 22 hours ago
config: x86_64-randconfig-s022-20200529 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
git checkout bf53b03e9d2ac23fb4a3e639fe023f5f1af607b0
# save the attached .config to linux build tree
make W=1 C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
>> fs/ext4/mballoc.c:2209:9: sparse: sparse: context imbalance in
>> 'ext4_mb_good_group_nolock' - different lock contexts for basic block
#
https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git/commit/?id=bf53b03e9d2ac23fb4a3e639fe023f5f1af607b0
git remote add ext4
https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git
git remote update ext4
git checkout bf53b03e9d2ac23fb4a3e639fe023f5f1af607b0
vim +/ext4_mb_good_group_nolock +2209 fs/ext4/mballoc.c
9e467ce0e92226 Ritesh Harjani 2020-05-20 2169
9e467ce0e92226 Ritesh Harjani 2020-05-20 2170 /*
9e467ce0e92226 Ritesh Harjani 2020-05-20 2171 * This could return negative
error code if something goes wrong
9e467ce0e92226 Ritesh Harjani 2020-05-20 2172 * during ext4_mb_init_group().
This should not be called with
9e467ce0e92226 Ritesh Harjani 2020-05-20 2173 * ext4_lock_group() held.
9e467ce0e92226 Ritesh Harjani 2020-05-20 2174 */
9e467ce0e92226 Ritesh Harjani 2020-05-20 2175 static int
ext4_mb_good_group_nolock(struct ext4_allocation_context *ac,
9e467ce0e92226 Ritesh Harjani 2020-05-20 2176
ext4_group_t group, int cr)
9e467ce0e92226 Ritesh Harjani 2020-05-20 2177 {
9e467ce0e92226 Ritesh Harjani 2020-05-20 2178 struct ext4_group_info
*grp = ext4_get_group_info(ac->ac_sb, group);
bf53b03e9d2ac2 Ritesh Harjani 2020-05-20 2179 struct super_block *sb
= ac->ac_sb;
bf53b03e9d2ac2 Ritesh Harjani 2020-05-20 2180 bool should_lock =
ac->ac_flags & EXT4_MB_STRICT_CHECK;
9e467ce0e92226 Ritesh Harjani 2020-05-20 2181 ext4_grpblk_t free;
9e467ce0e92226 Ritesh Harjani 2020-05-20 2182 int ret = 0;
9e467ce0e92226 Ritesh Harjani 2020-05-20 2183
bf53b03e9d2ac2 Ritesh Harjani 2020-05-20 2184 if (should_lock)
bf53b03e9d2ac2 Ritesh Harjani 2020-05-20 2185
ext4_lock_group(sb, group);
9e467ce0e92226 Ritesh Harjani 2020-05-20 2186 free = grp->bb_free;
9e467ce0e92226 Ritesh Harjani 2020-05-20 2187 if (free == 0)
9e467ce0e92226 Ritesh Harjani 2020-05-20 2188 goto out;
9e467ce0e92226 Ritesh Harjani 2020-05-20 2189 if (cr <= 2 && free <
ac->ac_g_ex.fe_len)
9e467ce0e92226 Ritesh Harjani 2020-05-20 2190 goto out;
9e467ce0e92226 Ritesh Harjani 2020-05-20 2191 if
(unlikely(EXT4_MB_GRP_BBITMAP_CORRUPT(grp)))
9e467ce0e92226 Ritesh Harjani 2020-05-20 2192 goto out;
bf53b03e9d2ac2 Ritesh Harjani 2020-05-20 2193 if (should_lock)
bf53b03e9d2ac2 Ritesh Harjani 2020-05-20 2194
ext4_unlock_group(sb, group);
9e467ce0e92226 Ritesh Harjani 2020-05-20 2195
9e467ce0e92226 Ritesh Harjani 2020-05-20 2196 /* We only do this if
the grp has never been initialized */
9e467ce0e92226 Ritesh Harjani 2020-05-20 2197 if
(unlikely(EXT4_MB_GRP_NEED_INIT(grp))) {
9e467ce0e92226 Ritesh Harjani 2020-05-20 2198 ret =
ext4_mb_init_group(ac->ac_sb, group, GFP_NOFS);
9e467ce0e92226 Ritesh Harjani 2020-05-20 2199 if (ret)
9e467ce0e92226 Ritesh Harjani 2020-05-20 2200 return
ret;
9e467ce0e92226 Ritesh Harjani 2020-05-20 2201 }
9e467ce0e92226 Ritesh Harjani 2020-05-20 2202
bf53b03e9d2ac2 Ritesh Harjani 2020-05-20 2203 if (should_lock)
bf53b03e9d2ac2 Ritesh Harjani 2020-05-20 2204
ext4_lock_group(sb, group);
9e467ce0e92226 Ritesh Harjani 2020-05-20 2205 ret =
ext4_mb_good_group(ac, group, cr);
9e467ce0e92226 Ritesh Harjani 2020-05-20 2206 out:
bf53b03e9d2ac2 Ritesh Harjani 2020-05-20 2207 if (should_lock)
bf53b03e9d2ac2 Ritesh Harjani 2020-05-20 2208
ext4_unlock_group(sb, group);
9e467ce0e92226 Ritesh Harjani 2020-05-20 @2209 return ret;
c9de560ded61fa Alex Tomas 2008-01-29 2210 }
c9de560ded61fa Alex Tomas 2008-
[kbuild] Re: [PATCH 1/4] scsi: convert target lookup to xarray
CC: kbuild-...@lists.01.org
In-Reply-To: <20200527141400.58087-2-h...@suse.de>
References: <20200527141400.58087-2-h...@suse.de>
TO: Hannes Reinecke
TO: "Martin K. Petersen"
CC: Christoph Hellwig
CC: Doug Gilbert
CC: Daniel Wagner
CC: James Bottomley
CC: linux-s...@vger.kernel.org
CC: Hannes Reinecke
Hi Hannes,
I love your patch! Perhaps something to improve:
[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on scsi/for-next v5.7-rc7 next-20200529]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Hannes-Reinecke/scsi-use-xarray-for-devices-and-targets/20200527-231824
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
:: branch date: 2 days ago
:: commit date: 2 days ago
config: x86_64-randconfig-m001-20200529 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/scsi/scsi_scan.c:482 scsi_alloc_target() warn: inconsistent returns
'*shost->host_lock'.
drivers/scsi/scsi_scan.c:482 scsi_alloc_target() warn: inconsistent returns
'flags'.
#
https://github.com/0day-ci/linux/commit/45b149b239ea9a86968ddbd8ecda1e6c44937b68
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 45b149b239ea9a86968ddbd8ecda1e6c44937b68
vim +482 drivers/scsi/scsi_scan.c
e63ed0d7a98014 James Bottomley2014-01-21 379
884d25cc4fda20 James Bottomley2006-09-05 380 /**
884d25cc4fda20 James Bottomley2006-09-05 381 * scsi_alloc_target -
allocate a new or find an existing target
884d25cc4fda20 James Bottomley2006-09-05 382 * @parent: parent
of the target (need not be a scsi host)
884d25cc4fda20 James Bottomley2006-09-05 383 * @channel: target
channel number (zero if no channels)
884d25cc4fda20 James Bottomley2006-09-05 384 * @id: target
id number
884d25cc4fda20 James Bottomley2006-09-05 385 *
884d25cc4fda20 James Bottomley2006-09-05 386 * Return an existing
target if one exists, provided it hasn't already
884d25cc4fda20 James Bottomley2006-09-05 387 * gone into STARGET_DEL
state, otherwise allocate a new target.
884d25cc4fda20 James Bottomley2006-09-05 388 *
884d25cc4fda20 James Bottomley2006-09-05 389 * The target is
returned with an incremented reference, so the caller
884d25cc4fda20 James Bottomley2006-09-05 390 * is responsible for
both reaping and doing a last put
884d25cc4fda20 James Bottomley2006-09-05 391 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 392 static struct
scsi_target *scsi_alloc_target(struct device *parent,
^1da177e4c3f41 Linus Torvalds 2005-04-16 393
int channel, uint id)
^1da177e4c3f41 Linus Torvalds 2005-04-16 394 {
^1da177e4c3f41 Linus Torvalds 2005-04-16 395 struct Scsi_Host *shost
= dev_to_shost(parent);
^1da177e4c3f41 Linus Torvalds 2005-04-16 396 struct device *dev =
NULL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 397 unsigned long flags;
^1da177e4c3f41 Linus Torvalds 2005-04-16 398 const int size =
sizeof(struct scsi_target)
^1da177e4c3f41 Linus Torvalds 2005-04-16 399 +
shost->transportt->target_size;
5c44cd2afad3f7 james.sm...@emulex.com 2005-06-10 400 struct scsi_target
*starget;
^1da177e4c3f41 Linus Torvalds 2005-04-16 401 struct scsi_target
*found_target;
e63ed0d7a98014 James Bottomley2014-01-21 402 int error, ref_got;
45b149b239ea9a Hannes Reinecke2020-05-27 403 unsigned long tid;
^1da177e4c3f41 Linus Torvalds 2005-04-16 404
24669f75a3231f Jes Sorensen 2006-01-16 405 starget = kzalloc(size,
GFP_KERNEL);
^1da177e4c3f41 Linus Torvalds 2005-04-16 406 if (!starget) {
cadbd4a5e36dde Harvey Harrison2008-07-03 407 printk(KERN_ERR
"%s: allocation failure\n", __func__);
^1da177e4c3f41 Linus Torvalds 2005-04-16 408 return NULL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 409 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 410 dev = >dev;
^1da177e4c3f41 Linus Torvalds 2005-04-16 411 device_initialize(dev);
e63ed0d7a98014 James Bottomley2014-01-21 412
kref_init(>reap_ref);
^1da177e4c3f41 Linus Torvalds 2005-04-16 413 dev->parent =
get_device(parent);
71610f55fa4db6 Kay Sievers2008-12-03 414 dev_set_name(dev,
"target%d:%d:%d", shost->host_no, channel, id);
b0ed43360fdca2
[kbuild] [dhowells-fs:afs-operation 20/27] fs/afs/vl_alias.c:318:8-17: ERROR: reference preceded by free on line 316
CC: kbuild-...@lists.01.org
TO: "David, Howells,"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
afs-operation
head: 028362346b339f27505b0eb27e7c7f68cd0fc8b9
commit: 298b5d29c83596b495250fdcc97d16183f67b895 [20/27] afs: Detect cell
aliases 3 - YFS Cells with a canonical cell name op
:: branch date: 6 hours ago
:: commit date: 6 hours ago
config: nds32-randconfig-c021-20200529 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Julia Lawall
coccinelle warnings: (new ones prefixed by >>)
>> fs/afs/vl_alias.c:318:8-17: ERROR: reference preceded by free on line 316
#
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/commit/?id=298b5d29c83596b495250fdcc97d16183f67b895
git remote add dhowells-fs
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
git remote update dhowells-fs
git checkout 298b5d29c83596b495250fdcc97d16183f67b895
vim +318 fs/afs/vl_alias.c
298b5d29c83596b David Howells 2020-04-27 299
298b5d29c83596b David Howells 2020-04-27 300 static int
yfs_check_canonical_cell_name(struct afs_cell *cell, struct key *key)
298b5d29c83596b David Howells 2020-04-27 301 {
298b5d29c83596b David Howells 2020-04-27 302 struct afs_cell *master;
298b5d29c83596b David Howells 2020-04-27 303 char *cell_name;
298b5d29c83596b David Howells 2020-04-27 304
298b5d29c83596b David Howells 2020-04-27 305 cell_name =
afs_vl_get_cell_name(cell, key);
298b5d29c83596b David Howells 2020-04-27 306 if (IS_ERR(cell_name))
298b5d29c83596b David Howells 2020-04-27 307 return
PTR_ERR(cell_name);
298b5d29c83596b David Howells 2020-04-27 308
298b5d29c83596b David Howells 2020-04-27 309 if (strcmp(cell_name,
cell->name) == 0) {
298b5d29c83596b David Howells 2020-04-27 310 kfree(cell_name);
298b5d29c83596b David Howells 2020-04-27 311 return 0;
298b5d29c83596b David Howells 2020-04-27 312 }
298b5d29c83596b David Howells 2020-04-27 313
298b5d29c83596b David Howells 2020-04-27 314 master =
afs_lookup_cell(cell->net, cell_name, strlen(cell_name),
298b5d29c83596b David Howells 2020-04-27 315NULL,
false);
298b5d29c83596b David Howells 2020-04-27 @316 kfree(cell_name);
298b5d29c83596b David Howells 2020-04-27 317 if (IS_ERR(master)) {
298b5d29c83596b David Howells 2020-04-27 @318 kfree(cell_name);
298b5d29c83596b David Howells 2020-04-27 319 return PTR_ERR(master);
298b5d29c83596b David Howells 2020-04-27 320 }
298b5d29c83596b David Howells 2020-04-27 321
298b5d29c83596b David Howells 2020-04-27 322 cell->alias_of = master; /*
Transfer our ref */
298b5d29c83596b David Howells 2020-04-27 323 return 1;
298b5d29c83596b David Howells 2020-04-27 324 }
298b5d29c83596b David Howells 2020-04-27 325
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] drivers/phy/cadence/phy-cadence-torrent.c:138:9: sparse: sparse: cast removes address space '' of expression
CC: kbuild-...@lists.01.org CC: linux-ker...@vger.kernel.org TO: Yuti Amonkar CC: Kishon Vijay Abraham I tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: b0c3ba31be3e45a130e13b278cf3b90f69bda6f6 commit: c589e7014ffc78a46e4793e2110cbf3b0dd476a1 phy: cadence-dp: Rename to phy-cadence-torrent date: 10 weeks ago :: branch date: 21 hours ago :: commit date: 10 weeks ago config: m68k-randconfig-s031-20200528 (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.1-240-gf0fe1cd9-dirty git checkout c589e7014ffc78a46e4793e2110cbf3b0dd476a1 # save the attached .config to linux build tree make W=1 C=1 ARCH=m68k CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) >> drivers/phy/cadence/phy-cadence-torrent.c:138:9: sparse: sparse: cast >> removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:187:9: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:191:9: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:376:15: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:376:15: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:403:9: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:405:15: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:405:15: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:412:9: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:415:9: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:417:15: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:417:15: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:424:9: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:210:15: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:210:15: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:232:9: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:233:9: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:234:9: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:235:9: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:236:9: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:237:9: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:238:9: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:239:9: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:240:9: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:241:9: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:242:9: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:243:9: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:244:9: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:245:9: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:246:9: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:247:9: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:248:9: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:249:9: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:251:9: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:252:9: sparse: sparse: cast removes address space '' of expression drivers/phy/cadence/phy-cadence-torrent.c:253:9: sp
[kbuild] Re: [PATCH] Bluetooth: Acquire sk_lock.slock without disabling interrupts
CC: kbuild-...@lists.01.org
In-Reply-To: <20200527193919.1655228-1-bige...@linutronix.de>
References: <20200527193919.1655228-1-bige...@linutronix.de>
TO: Sebastian Andrzej Siewior
TO: linux-blueto...@vger.kernel.org
CC: Marcel Holtmann
CC: Johan Hedberg
CC: Thomas Gleixner
CC: "Luis Claudio R . Goncalves"
CC: Sebastian Andrzej Siewior
Hi Sebastian,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on v5.7-rc7 next-20200526]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Sebastian-Andrzej-Siewior/Bluetooth-Acquire-sk_lock-slock-without-disabling-interrupts/20200528-034222
base:
https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git
master
:: branch date: 9 hours ago
:: commit date: 9 hours ago
config: i386-randconfig-s001-20200528 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-240-gf0fe1cd9-dirty
# save the attached .config to linux build tree
make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
>> net/bluetooth/rfcomm/sock.c:64:13: sparse: sparse: context imbalance in
>> 'rfcomm_sk_state_change' - wrong count at exit
#
https://github.com/0day-ci/linux/commit/dc48a377813eebe5a9e4818d98f51df0da9476fc
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout dc48a377813eebe5a9e4818d98f51df0da9476fc
vim +/rfcomm_sk_state_change +64 net/bluetooth/rfcomm/sock.c
^1da177e4c3f41 Linus Torvalds2005-04-16 63
^1da177e4c3f41 Linus Torvalds2005-04-16 @64 static void
rfcomm_sk_state_change(struct rfcomm_dlc *d, int err)
^1da177e4c3f41 Linus Torvalds2005-04-16 65 {
^1da177e4c3f41 Linus Torvalds2005-04-16 66struct sock *sk
= d->owner, *parent;
fad003b6c8e3d9 Gustavo Padovan 2010-08-14 67
^1da177e4c3f41 Linus Torvalds2005-04-16 68if (!sk)
^1da177e4c3f41 Linus Torvalds2005-04-16 69return;
^1da177e4c3f41 Linus Torvalds2005-04-16 70
^1da177e4c3f41 Linus Torvalds2005-04-16 71BT_DBG("dlc %p
state %ld err %d", d, d->state, err);
^1da177e4c3f41 Linus Torvalds2005-04-16 72
dc48a377813eeb Sebastian Andrzej Siewior 2020-05-27 73
spin_lock_bh(>sk_lock.slock);
^1da177e4c3f41 Linus Torvalds2005-04-16 74
^1da177e4c3f41 Linus Torvalds2005-04-16 75if (err)
^1da177e4c3f41 Linus Torvalds2005-04-16 76
sk->sk_err = err;
^1da177e4c3f41 Linus Torvalds2005-04-16 77
^1da177e4c3f41 Linus Torvalds2005-04-16 78sk->sk_state =
d->state;
^1da177e4c3f41 Linus Torvalds2005-04-16 79
^1da177e4c3f41 Linus Torvalds2005-04-16 80parent =
bt_sk(sk)->parent;
^1da177e4c3f41 Linus Torvalds2005-04-16 81if (parent) {
^1da177e4c3f41 Linus Torvalds2005-04-16 82if
(d->state == BT_CLOSED) {
^1da177e4c3f41 Linus Torvalds2005-04-16 83
sock_set_flag(sk, SOCK_ZAPPED);
^1da177e4c3f41 Linus Torvalds2005-04-16 84
bt_accept_unlink(sk);
^1da177e4c3f41 Linus Torvalds2005-04-16 85}
676d23690fb62b David S. Miller 2014-04-11 86
parent->sk_data_ready(parent);
^1da177e4c3f41 Linus Torvalds2005-04-16 87} else {
^1da177e4c3f41 Linus Torvalds2005-04-16 88if
(d->state == BT_CONNECTED)
94a86df0108255 Marcel Holtmann 2013-10-13 89
rfcomm_session_getaddr(d->session,
94a86df0108255 Marcel Holtmann 2013-10-13 90
_pi(sk)->src, NULL);
^1da177e4c3f41 Linus Torvalds2005-04-16 91
sk->sk_state_change(sk);
^1da177e4c3f41 Linus Torvalds2005-04-16 92}
^1da177e4c3f41 Linus Torvalds2005-04-16 93
dc48a377813eeb Sebastian Andrzej Siewior 2020-05-27 94
spin_lock_bh(>sk_lock.slock);
^1da177e4c3f41 Linus Torvalds2005-04-16 95
^1da177e4c3f41 Linus Torvalds2005-04-16 96if (parent &&
sock_flag(sk, SOCK_ZAPPED)) {
^1da177e4c3f41 Linus Torvalds2005-
[kbuild] Re: [PATCH] gpiolib: split character device into gpiolib-cdev
CC: kbuild-...@lists.01.org In-Reply-To: <20200527154005.6827-1-warthog...@gmail.com> References: <20200527154005.6827-1-warthog...@gmail.com> TO: Kent Gibson TO: linux-ker...@vger.kernel.org TO: linux-g...@vger.kernel.org TO: bgolaszew...@baylibre.com TO: linus.wall...@linaro.org CC: Kent Gibson Hi Kent, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on v5.7-rc5] [cannot apply to gpio/for-next linus/master linux/master v5.7-rc7 v5.7-rc6 next-20200526] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Kent-Gibson/gpiolib-split-character-device-into-gpiolib-cdev/20200528-35 base:2ef96a5bb12be62ef75b5828c0aab838ebb29cb8 :: branch date: 12 hours ago :: commit date: 12 hours ago config: mips-randconfig-c022-20200527 (attached as .config) compiler: mipsel-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot Reported-by: Julia Lawall coccinelle warnings: (new ones prefixed by >>) >> drivers/gpio/gpiolib-cdev.c:1043:7-23: WARNING: gpio_fileops: .read() has >> stream semantic; safe to change nonseekable_open -> stream_open. Please review and possibly fold the followup patch. --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [PATCH] gpiolib: fix stream_open.cocci warnings
CC: kbuild-...@lists.01.org In-Reply-To: <20200527154005.6827-1-warthog...@gmail.com> References: <20200527154005.6827-1-warthog...@gmail.com> TO: Kent Gibson TO: linux-ker...@vger.kernel.org TO: linux-g...@vger.kernel.org TO: bgolaszew...@baylibre.com TO: linus.wall...@linaro.org CC: Kent Gibson From: kbuild test robot drivers/gpio/gpiolib-cdev.c:1043:7-23: WARNING: gpio_fileops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. Generated by: scripts/coccinelle/api/stream_open.cocci CC: Kent Gibson Signed-off-by: kbuild test robot --- url: https://github.com/0day-ci/linux/commits/Kent-Gibson/gpiolib-split-character-device-into-gpiolib-cdev/20200528-35 base:2ef96a5bb12be62ef75b5828c0aab838ebb29cb8 :: branch date: 12 hours ago :: commit date: 12 hours ago Please take the patch only if it's a positive warning. Thanks! gpiolib-cdev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpio/gpiolib-cdev.c +++ b/drivers/gpio/gpiolib-cdev.c @@ -1040,7 +1040,7 @@ static int gpio_chrdev_open(struct inode get_device(>dev); filp->private_data = priv; - ret = nonseekable_open(inode, filp); + ret = stream_open(inode, filp); if (ret) goto out_unregister_notifier; ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] Re: [PATCH 1/4] scsi: convert target lookup to xarray
CC: kbuild-...@lists.01.org
In-Reply-To: <20200527141400.58087-2-h...@suse.de>
References: <20200527141400.58087-2-h...@suse.de>
TO: Hannes Reinecke
TO: "Martin K. Petersen"
CC: Christoph Hellwig
CC: Doug Gilbert
CC: Daniel Wagner
CC: James Bottomley
CC: linux-s...@vger.kernel.org
CC: Hannes Reinecke
Hi Hannes,
I love your patch! Perhaps something to improve:
[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on scsi/for-next v5.7-rc7 next-20200526]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Hannes-Reinecke/scsi-use-xarray-for-devices-and-targets/20200527-231824
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
:: branch date: 12 hours ago
:: commit date: 12 hours ago
config: i386-randconfig-s001-20200528 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-240-gf0fe1cd9-dirty
# save the attached .config to linux build tree
make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
>> drivers/scsi/scsi_scan.c:392:27: sparse: sparse: context imbalance in
>> 'scsi_alloc_target' - different lock contexts for basic block
#
https://github.com/0day-ci/linux/commit/45b149b239ea9a86968ddbd8ecda1e6c44937b68
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 45b149b239ea9a86968ddbd8ecda1e6c44937b68
vim +/scsi_alloc_target +392 drivers/scsi/scsi_scan.c
e63ed0d7a98014 James Bottomley2014-01-21 379
884d25cc4fda20 James Bottomley2006-09-05 380 /**
884d25cc4fda20 James Bottomley2006-09-05 381 * scsi_alloc_target -
allocate a new or find an existing target
884d25cc4fda20 James Bottomley2006-09-05 382 * @parent: parent
of the target (need not be a scsi host)
884d25cc4fda20 James Bottomley2006-09-05 383 * @channel: target
channel number (zero if no channels)
884d25cc4fda20 James Bottomley2006-09-05 384 * @id: target
id number
884d25cc4fda20 James Bottomley2006-09-05 385 *
884d25cc4fda20 James Bottomley2006-09-05 386 * Return an existing
target if one exists, provided it hasn't already
884d25cc4fda20 James Bottomley2006-09-05 387 * gone into STARGET_DEL
state, otherwise allocate a new target.
884d25cc4fda20 James Bottomley2006-09-05 388 *
884d25cc4fda20 James Bottomley2006-09-05 389 * The target is
returned with an incremented reference, so the caller
884d25cc4fda20 James Bottomley2006-09-05 390 * is responsible for
both reaping and doing a last put
884d25cc4fda20 James Bottomley2006-09-05 391 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 @392 static struct
scsi_target *scsi_alloc_target(struct device *parent,
^1da177e4c3f41 Linus Torvalds 2005-04-16 393
int channel, uint id)
^1da177e4c3f41 Linus Torvalds 2005-04-16 394 {
^1da177e4c3f41 Linus Torvalds 2005-04-16 395 struct Scsi_Host *shost
= dev_to_shost(parent);
^1da177e4c3f41 Linus Torvalds 2005-04-16 396 struct device *dev =
NULL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 397 unsigned long flags;
^1da177e4c3f41 Linus Torvalds 2005-04-16 398 const int size =
sizeof(struct scsi_target)
^1da177e4c3f41 Linus Torvalds 2005-04-16 399 +
shost->transportt->target_size;
5c44cd2afad3f7 james.sm...@emulex.com 2005-06-10 400 struct scsi_target
*starget;
^1da177e4c3f41 Linus Torvalds 2005-04-16 401 struct scsi_target
*found_target;
e63ed0d7a98014 James Bottomley2014-01-21 402 int error, ref_got;
45b149b239ea9a Hannes Reinecke2020-05-27 403 unsigned long tid;
^1da177e4c3f41 Linus Torvalds 2005-04-16 404
24669f75a3231f Jes Sorensen 2006-01-16 405 starget = kzalloc(size,
GFP_KERNEL);
^1da177e4c3f41 Linus Torvalds 2005-04-16 406 if (!starget) {
cadbd4a5e36dde Harvey Harrison2008-07-03 407 printk(KERN_ERR
"%s: allocation failure\n", __func__);
^1da177e4c3f41 Linus Torvalds 2005-04-16 408 return NULL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 409 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 410 dev = >dev;
^1da177e4c3f41 Linus Torvalds 2005-04-16 411 device_initialize(dev);
e63ed0d7a98014 James Bottomley2014-01-21 412
kref_init(>reap_ref);
^1da177e4c3f41 Linus Torva
[kbuild] Re: [PATCH v3 03/11] md/raid5: allocate and free pages of r5pages
CC: kbuild-...@lists.01.org In-Reply-To: <20200527131933.34400-4-yuyu...@huawei.com> References: <20200527131933.34400-4-yuyu...@huawei.com> TO: Yufen Yu TO: s...@kernel.org CC: linux-r...@vger.kernel.org CC: ne...@suse.com CC: guoqing.ji...@cloud.ionos.com CC: col...@suse.de CC: x...@redhat.com CC: hout...@huawei.com CC: yuyu...@huawei.com Hi Yufen, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on cryptodev/master] [also build test WARNING on crypto/master linus/master v5.7-rc7 next-20200526] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Yufen-Yu/md-raid5-set-STRIPE_SIZE-as-a-configurable-value/20200527-212526 base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master :: branch date: 9 hours ago :: commit date: 9 hours ago config: sparc64-randconfig-c023-20200527 (attached as .config) compiler: sparc64-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot Reported-by: Julia Lawall coccinelle warnings: (new ones prefixed by >>) >> drivers/md/raid5.c:2191:2-7: WARNING: NULL check before some freeing >> functions is not needed. Please review and possibly fold the followup patch. --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [PATCH] md/raid5: fix ifnullfree.cocci warnings
CC: kbuild-...@lists.01.org
In-Reply-To: <20200527131933.34400-4-yuyu...@huawei.com>
References: <20200527131933.34400-4-yuyu...@huawei.com>
TO: Yufen Yu
TO: s...@kernel.org
CC: linux-r...@vger.kernel.org
CC: ne...@suse.com
CC: guoqing.ji...@cloud.ionos.com
CC: col...@suse.de
CC: x...@redhat.com
CC: hout...@huawei.com
CC: yuyu...@huawei.com
From: kbuild test robot
drivers/md/raid5.c:2191:2-7: WARNING: NULL check before some freeing functions
is not needed.
NULL check before some freeing functions is not needed.
Based on checkpatch warning
"kfree(NULL) is safe this check is probably not required"
and kfreeaddr.cocci by Julia Lawall.
Generated by: scripts/coccinelle/free/ifnullfree.cocci
CC: Yufen Yu
Signed-off-by: kbuild test robot
---
url:
https://github.com/0day-ci/linux/commits/Yufen-Yu/md-raid5-set-STRIPE_SIZE-as-a-configurable-value/20200527-212526
base:
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
:: branch date: 9 hours ago
:: commit date: 9 hours ago
Please take the patch only if it's a positive warning. Thanks!
raid5.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -2187,8 +2187,7 @@ static void raid_run_ops(struct stripe_h
static void free_stripe(struct kmem_cache *sc, struct stripe_head *sh)
{
- if (sh->pages.page)
- kfree(sh->pages.page);
+ kfree(sh->pages.page);
if (sh->ppl_page)
__free_page(sh->ppl_page);
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] Re: [PATCH 7/8] drm/msm/dpu: add SM8150 to hw catalog
CC: kbuild-...@lists.01.org
In-Reply-To: <20200526032235.21930-8-jonat...@marek.ca>
References: <20200526032235.21930-8-jonat...@marek.ca>
TO: Jonathan Marek
TO: freedr...@lists.freedesktop.org
CC: Rob Clark
CC: Sean Paul
CC: David Airlie
CC: Daniel Vetter
CC: Shubhashree Dhar
CC: Raviteja Tamatam
CC: Kalyan Thota
CC: Thomas Gleixner
CC: Stephen Boyd
Hi Jonathan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.7-rc7]
[cannot apply to next-20200526]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Jonathan-Marek/Initial-SM8150-and-SM8250-DPU-bringup/20200526-112725
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
9cb1fd0efd195590b828b9b865421ad345a4a145
:: branch date: 32 hours ago
:: commit date: 32 hours ago
config: arm64-randconfig-s031-20200527 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-240-gf0fe1cd9-dirty
# save the attached .config to linux build tree
make W=1 C=1 ARCH=arm64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:98:26: sparse: sparse:
undefined identifier 'DPU_SSPP_SMART_DMA_V2_5'
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:96:10: sparse: sparse:
Initializer entry defined twice
>> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:104:10: sparse: also
>> defined here
#
https://github.com/0day-ci/linux/commit/6a90302321af832ea18679e1b29b0301caade709
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 6a90302321af832ea18679e1b29b0301caade709
vim +104 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
7bdc0c4b812602f Kalyan Thota 2019-11-25 92
6a90302321af832 Jonathan Marek 2020-05-25 93 static const struct dpu_caps
sm8150_dpu_caps = {
6a90302321af832 Jonathan Marek 2020-05-25 94 .max_mixer_width =
DEFAULT_DPU_OUTPUT_LINE_WIDTH,
6a90302321af832 Jonathan Marek 2020-05-25 95 .max_mixer_blendstages
= 0xb,
6a90302321af832 Jonathan Marek 2020-05-25 96 .max_linewidth = 4096,
6a90302321af832 Jonathan Marek 2020-05-25 97 .qseed_type =
DPU_SSPP_SCALER_QSEED3,
6a90302321af832 Jonathan Marek 2020-05-25 98 .smart_dma_rev =
DPU_SSPP_SMART_DMA_V2_5,
6a90302321af832 Jonathan Marek 2020-05-25 99 .ubwc_version =
DPU_HW_UBWC_VER_30,
6a90302321af832 Jonathan Marek 2020-05-25 100 .has_src_split = true,
6a90302321af832 Jonathan Marek 2020-05-25 101 .has_dim_layer = true,
6a90302321af832 Jonathan Marek 2020-05-25 102 .has_idle_pc = true,
6a90302321af832 Jonathan Marek 2020-05-25 103 .has_3d_merge = true,
6a90302321af832 Jonathan Marek 2020-05-25 @104 .max_linewidth = 4096,
6a90302321af832 Jonathan Marek 2020-05-25 105 .pixel_ram_size =
DEFAULT_PIXEL_RAM_SIZE,
6a90302321af832 Jonathan Marek 2020-05-25 106 .max_hdeci_exp =
MAX_HORZ_DECIMATION,
6a90302321af832 Jonathan Marek 2020-05-25 107 .max_vdeci_exp =
MAX_VERT_DECIMATION,
6a90302321af832 Jonathan Marek 2020-05-25 108 };
6a90302321af832 Jonathan Marek 2020-05-25 109
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [linux-next:master 11987/12912] net/netfilter/nf_conntrack_core.c:2068 __nf_conntrack_update() error: uninitialized symbol 'ctinfo'.
CC: kbuild-...@lists.01.org
TO: Pablo Neira Ayuso
CC: Florian Westphal
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: b0523c7b1c9d0edcd6c0fe6d2cb558a9ad5c60a8
commit: ee04805ff54a63ffd90bc6749ebfe73473734ddb [11987/12912] netfilter:
conntrack: make conntrack userspace helpers work again
:: branch date: 16 hours ago
:: commit date: 32 hours ago
config: i386-randconfig-m021-20200527 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
New smatch warnings:
net/netfilter/nf_conntrack_core.c:2068 __nf_conntrack_update() error:
uninitialized symbol 'ctinfo'.
net/netfilter/nf_conntrack_core.c:2117 nf_confirm_cthelper() warn: unsigned
'protoff' is never less than zero.
Old smatch warnings:
net/netfilter/nf_conntrack_core.c:1314 early_drop() error: uninitialized symbol
'bucket'.
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ee04805ff54a63ffd90bc6749ebfe73473734ddb
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout ee04805ff54a63ffd90bc6749ebfe73473734ddb
vim +/ctinfo +2068 net/netfilter/nf_conntrack_core.c
9fb9cbb1082d6b3 Yasuyuki Kozakai 2005-11-09 2018
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2019 static int
__nf_conntrack_update(struct net *net, struct sk_buff *skb,
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2020
struct nf_conn *ct)
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2021 {
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2022 struct
nf_conntrack_tuple_hash *h;
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2023 struct
nf_conntrack_tuple tuple;
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2024 enum ip_conntrack_info
ctinfo;
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2025 struct nf_nat_hook
*nat_hook;
6816d931cab0090 Florian Westphal 2018-06-29 2026 unsigned int status;
6816d931cab0090 Florian Westphal 2018-06-29 2027 int dataoff;
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2028 u16 l3num;
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2029 u8 l4num;
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2030
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2031 l3num = nf_ct_l3num(ct);
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2032
6816d931cab0090 Florian Westphal 2018-06-29 2033 dataoff =
get_l4proto(skb, skb_network_offset(skb), l3num, );
6816d931cab0090 Florian Westphal 2018-06-29 2034 if (dataoff <= 0)
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2035 return -1;
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2036
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2037 if
(!nf_ct_get_tuple(skb, skb_network_offset(skb), dataoff, l3num,
303e0c5589592e4 Florian Westphal 2019-01-15 2038
l4num, net, ))
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2039 return -1;
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2040
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2041 if (ct->status &
IPS_SRC_NAT) {
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2042
memcpy(tuple.src.u3.all,
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2043
ct->tuplehash[IP_CT_DIR_ORIGINAL].tuple.src.u3.all,
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2044
sizeof(tuple.src.u3.all));
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2045 tuple.src.u.all
=
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2046
ct->tuplehash[IP_CT_DIR_ORIGINAL].tuple.src.u.all;
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2047 }
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2048
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2049 if (ct->status &
IPS_DST_NAT) {
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2050
memcpy(tuple.dst.u3.all,
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2051
ct->tuplehash[IP_CT_DIR_ORIGINAL].tuple.dst.u3.all,
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2052
sizeof(tuple.dst.u3.all));
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2053 tuple.dst.u.all
=
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2054
ct->tuplehash[IP_CT_DIR_ORIGINAL].tuple.dst.u.all;
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2055 }
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2056
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2057 h =
nf_conntrack_find_get(net, nf_ct_zone(ct), );
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2058 if (!h)
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2059 return 0;
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2060
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2061 /* Store
[kbuild] [linux-next:master 11987/12912] net/netfilter/nf_conntrack_core.c:2117:6-13: WARNING: Unsigned expression compared with zero: protoff < 0
CC: kbuild-...@lists.01.org
TO: Pablo Neira Ayuso
CC: Florian Westphal
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: b0523c7b1c9d0edcd6c0fe6d2cb558a9ad5c60a8
commit: ee04805ff54a63ffd90bc6749ebfe73473734ddb [11987/12912] netfilter:
conntrack: make conntrack userspace helpers work again
:: branch date: 13 hours ago
:: commit date: 29 hours ago
config: microblaze-randconfig-c022-20200526 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Julia Lawall
coccinelle warnings: (new ones prefixed by >>)
>> net/netfilter/nf_conntrack_core.c:2117:6-13: WARNING: Unsigned expression
>> compared with zero: protoff < 0
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ee04805ff54a63ffd90bc6749ebfe73473734ddb
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout ee04805ff54a63ffd90bc6749ebfe73473734ddb
vim +2117 net/netfilter/nf_conntrack_core.c
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2086
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2087 /* This packet is coming
from userspace via nf_queue, complete the packet
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2088 * processing after the
helper invocation in nf_confirm().
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2089 */
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2090 static int
nf_confirm_cthelper(struct sk_buff *skb, struct nf_conn *ct,
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2091
enum ip_conntrack_info ctinfo)
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2092 {
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2093 const struct
nf_conntrack_helper *helper;
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2094 const struct
nf_conn_help *help;
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2095 unsigned int protoff;
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2096
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2097 help = nfct_help(ct);
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2098 if (!help)
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2099 return 0;
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2100
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2101 helper =
rcu_dereference(help->helper);
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2102 if (!(helper->flags &
NF_CT_HELPER_F_USERSPACE))
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2103 return 0;
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2104
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2105 switch
(nf_ct_l3num(ct)) {
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2106 case NFPROTO_IPV4:
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2107 protoff =
skb_network_offset(skb) + ip_hdrlen(skb);
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2108 break;
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2109 #if IS_ENABLED(CONFIG_IPV6)
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2110 case NFPROTO_IPV6: {
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2111 __be16 frag_off;
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2112 u8 pnum;
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2113
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2114 pnum =
ipv6_hdr(skb)->nexthdr;
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2115 protoff =
ipv6_skip_exthdr(skb, sizeof(struct ipv6hdr), ,
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2116
_off);
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 @2117 if (protoff < 0
|| (frag_off & htons(~0x7)) != 0)
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2118 return
0;
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2119 break;
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2120 }
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2121 #endif
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2122 default:
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2123 return 0;
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2124 }
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2125
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2126 if
(test_bit(IPS_SEQ_ADJUST_BIT, >status) &&
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2127
!nf_is_loopback_packet(skb)) {
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2128 if
(!nf_ct_seq_adjust(skb, ct, ctinfo, protoff)) {
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2129
NF_CT_STAT_INC_ATOMIC(nf_ct_net(ct), drop);
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2130 return
-1;
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2131
[kbuild] [linux-next:master 10689/12912] drivers/infiniband/hw/hfi1/netdev_rx.c:335 hfi1_netdev_free() error: use free_netdev() here instead of kfree(dd->dummy_netdev)
CC: kbuild-...@lists.01.org
TO: Grzegorz Andrejczuk
CC: Jason Gunthorpe
CC: Mike Marciniszyn
CC: Dennis Dalessandro
CC: Sadanand Warrier
CC: Kaike Wan
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: b0523c7b1c9d0edcd6c0fe6d2cb558a9ad5c60a8
commit: 370caa5b5880cd988645735c2d5d1d597c258e39 [10689/12912] IB/hfi1: Add rx
functions for dummy netdev
:: branch date: 7 hours ago
:: commit date: 5 days ago
config: x86_64-randconfig-m001-20200526 (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/infiniband/hw/hfi1/netdev_rx.c:335 hfi1_netdev_free() error: use
free_netdev() here instead of kfree(dd->dummy_netdev)
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=370caa5b5880cd988645735c2d5d1d597c258e39
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout 370caa5b5880cd988645735c2d5d1d597c258e39
vim +335 drivers/infiniband/hw/hfi1/netdev_rx.c
370caa5b5880cd9 Grzegorz Andrejczuk 2020-05-11 327
370caa5b5880cd9 Grzegorz Andrejczuk 2020-05-11 328 void
hfi1_netdev_free(struct hfi1_devdata *dd)
370caa5b5880cd9 Grzegorz Andrejczuk 2020-05-11 329 {
370caa5b5880cd9 Grzegorz Andrejczuk 2020-05-11 330 struct hfi1_netdev_priv
*priv;
370caa5b5880cd9 Grzegorz Andrejczuk 2020-05-11 331
370caa5b5880cd9 Grzegorz Andrejczuk 2020-05-11 332 if (dd->dummy_netdev) {
370caa5b5880cd9 Grzegorz Andrejczuk 2020-05-11 333 priv =
hfi1_netdev_priv(dd->dummy_netdev);
370caa5b5880cd9 Grzegorz Andrejczuk 2020-05-11 334 dd_dev_info(dd,
"hfi1 netdev freed\n");
370caa5b5880cd9 Grzegorz Andrejczuk 2020-05-11 @335
kfree(dd->dummy_netdev);
370caa5b5880cd9 Grzegorz Andrejczuk 2020-05-11 336
dd->dummy_netdev = NULL;
370caa5b5880cd9 Grzegorz Andrejczuk 2020-05-11 337 }
370caa5b5880cd9 Grzegorz Andrejczuk 2020-05-11 338 }
370caa5b5880cd9 Grzegorz Andrejczuk 2020-05-11 339
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [linux-next:master 12558/12912] net/ipv4/tcp_ipv4.c:576 tcp_v4_err() error: uninitialized symbol 'skb'.
CC: kbuild-...@lists.01.org
TO: Eric Dumazet
CC: "Maciej Żenczykowski"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: b0523c7b1c9d0edcd6c0fe6d2cb558a9ad5c60a8
commit: 45af29ca761c275e350cca659856bc56f1035ef9 [12558/12912] tcp: allow
traceroute -Mtcp for unpriv users
:: branch date: 6 hours ago
:: commit date: 16 hours ago
config: i386-randconfig-m021-20200526 (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
smatch warnings:
net/ipv4/tcp_ipv4.c:576 tcp_v4_err() error: uninitialized symbol 'skb'.
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=45af29ca761c275e350cca659856bc56f1035ef9
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout 45af29ca761c275e350cca659856bc56f1035ef9
vim +/skb +576 net/ipv4/tcp_ipv4.c
26e3736090e103 Eric Dumazet 2015-03-22 405
^1da177e4c3f41 Linus Torvalds2005-04-16 406 /*
^1da177e4c3f41 Linus Torvalds2005-04-16 407 * This routine is called by
the ICMP module when it gets some
^1da177e4c3f41 Linus Torvalds2005-04-16 408 * sort of error condition.
If err < 0 then the socket should
^1da177e4c3f41 Linus Torvalds2005-04-16 409 * be closed and the error
returned to the user. If err > 0
^1da177e4c3f41 Linus Torvalds2005-04-16 410 * it's just the icmp type <<
8 | icmp code. After adjustment
^1da177e4c3f41 Linus Torvalds2005-04-16 411 * header points to the first
8 bytes of the tcp header. We need
^1da177e4c3f41 Linus Torvalds2005-04-16 412 * to find the appropriate
port.
^1da177e4c3f41 Linus Torvalds2005-04-16 413 *
^1da177e4c3f41 Linus Torvalds2005-04-16 414 * The locking strategy used
here is very "optimistic". When
^1da177e4c3f41 Linus Torvalds2005-04-16 415 * someone else accesses the
socket the ICMP is just dropped
^1da177e4c3f41 Linus Torvalds2005-04-16 416 * and for some paths there
is no check at all.
^1da177e4c3f41 Linus Torvalds2005-04-16 417 * A more general error queue
to queue errors for later handling
^1da177e4c3f41 Linus Torvalds2005-04-16 418 * is probably better.
^1da177e4c3f41 Linus Torvalds2005-04-16 419 *
^1da177e4c3f41 Linus Torvalds2005-04-16 420 */
^1da177e4c3f41 Linus Torvalds2005-04-16 421
32bbd8793f24b0 Stefano Brivio2018-11-08 422 int tcp_v4_err(struct sk_buff
*icmp_skb, u32 info)
^1da177e4c3f41 Linus Torvalds2005-04-16 423 {
b71d1d426d263b Eric Dumazet 2011-04-22 424const struct iphdr *iph
= (const struct iphdr *)icmp_skb->data;
4d1a2d9ec1c17d Damian Lukowski 2009-08-26 425struct tcphdr *th =
(struct tcphdr *)(icmp_skb->data + (iph->ihl << 2));
f1ecd5d9e73666 Damian Lukowski 2009-08-26 426struct
inet_connection_sock *icsk;
^1da177e4c3f41 Linus Torvalds2005-04-16 427struct tcp_sock *tp;
^1da177e4c3f41 Linus Torvalds2005-04-16 428struct inet_sock *inet;
4d1a2d9ec1c17d Damian Lukowski 2009-08-26 429const int type =
icmp_hdr(icmp_skb)->type;
4d1a2d9ec1c17d Damian Lukowski 2009-08-26 430const int code =
icmp_hdr(icmp_skb)->code;
^1da177e4c3f41 Linus Torvalds2005-04-16 431struct sock *sk;
f1ecd5d9e73666 Damian Lukowski 2009-08-26 432struct sk_buff *skb;
0a672f74131dd6 Yuchung Cheng 2014-05-11 433struct request_sock
*fastopen;
9a568de4818dea Eric Dumazet 2017-05-16 434u32 seq, snd_una;
9a568de4818dea Eric Dumazet 2017-05-16 435s32 remaining;
9a568de4818dea Eric Dumazet 2017-05-16 436u32 delta_us;
^1da177e4c3f41 Linus Torvalds2005-04-16 437int err;
4d1a2d9ec1c17d Damian Lukowski 2009-08-26 438struct net *net =
dev_net(icmp_skb->dev);
^1da177e4c3f41 Linus Torvalds2005-04-16 439
26e3736090e103 Eric Dumazet 2015-03-22 440sk =
__inet_lookup_established(net, _hashinfo, iph->daddr,
26e3736090e103 Eric Dumazet 2015-03-22 441
th->dest, iph->saddr, ntohs(th->source),
3fa6f616a7a4d0 David Ahern 2017-08-07 442
inet_iif(icmp_skb), 0);
^1da177e4c3f41 Linus Torvalds2005-04-16 443if (!sk) {
5d3848bc33b7d1 Eric Dumazet 2016-04-27 444
__ICMP_INC_STATS(net, ICMP_MIB_INERRORS);
32bbd8793f24b0 Stefano Brivio2018-11-08 445return -ENOENT;
^1da177e4c3f41 Linus Torvalds2005-04-16 446}
^1da177e4c3f41 Linus Torvalds2005-04-16 447if (sk->sk_state ==
TCP_TIME_WAIT) {
9469c7b4aa210c YOSHIFUJI Hideaki 2006-10-10 448
inet_twsk_put(inet_twsk(sk));
32bbd8793f24b0 Stefano
[kbuild] net/dsa/tag_8021q.c:109 dsa_8021q_restore_pvid() error: uninitialized symbol 'pvid'.
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Vladimir Oltean
CC: Andrew Lunn
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 9cb1fd0efd195590b828b9b865421ad345a4a145
commit: c80ed84e76886487703bf04b38ce10e92e2d6e26 net: dsa: tag_8021q: Fix
dsa_8021q_restore_pvid for an absent pvid
date: 6 months ago
:: branch date: 32 hours ago
:: commit date: 6 months ago
config: x86_64-randconfig-m001-20200526 (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
smatch warnings:
net/dsa/tag_8021q.c:109 dsa_8021q_restore_pvid() error: uninitialized symbol
'pvid'.
#
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c80ed84e76886487703bf04b38ce10e92e2d6e26
git remote add linus
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout c80ed84e76886487703bf04b38ce10e92e2d6e26
vim +/pvid +109 net/dsa/tag_8021q.c
f9bbe4477c30ec Vladimir Oltean 2019-05-05 95
5f33183b7fdfeb Vladimir Oltean 2019-08-30 96 static int
dsa_8021q_restore_pvid(struct dsa_switch *ds, int port)
5f33183b7fdfeb Vladimir Oltean 2019-08-30 97 {
5f33183b7fdfeb Vladimir Oltean 2019-08-30 98 struct bridge_vlan_info
vinfo;
5f33183b7fdfeb Vladimir Oltean 2019-08-30 99 struct net_device
*slave;
5f33183b7fdfeb Vladimir Oltean 2019-08-30 100 u16 pvid;
5f33183b7fdfeb Vladimir Oltean 2019-08-30 101 int err;
5f33183b7fdfeb Vladimir Oltean 2019-08-30 102
5f33183b7fdfeb Vladimir Oltean 2019-08-30 103 if
(!dsa_is_user_port(ds, port))
5f33183b7fdfeb Vladimir Oltean 2019-08-30 104 return 0;
5f33183b7fdfeb Vladimir Oltean 2019-08-30 105
5f33183b7fdfeb Vladimir Oltean 2019-08-30 106 slave =
ds->ports[port].slave;
5f33183b7fdfeb Vladimir Oltean 2019-08-30 107
5f33183b7fdfeb Vladimir Oltean 2019-08-30 108 err =
br_vlan_get_pvid(slave, );
c80ed84e768864 Vladimir Oltean 2019-11-16 @109 if (!pvid || err < 0)
5f33183b7fdfeb Vladimir Oltean 2019-08-30 110 /* There is no
pvid on the bridge for this port, which is
5f33183b7fdfeb Vladimir Oltean 2019-08-30 111 * perfectly
valid. Nothing to restore, bye-bye!
5f33183b7fdfeb Vladimir Oltean 2019-08-30 112 */
5f33183b7fdfeb Vladimir Oltean 2019-08-30 113 return 0;
5f33183b7fdfeb Vladimir Oltean 2019-08-30 114
5f33183b7fdfeb Vladimir Oltean 2019-08-30 115 err =
br_vlan_get_info(slave, pvid, );
5f33183b7fdfeb Vladimir Oltean 2019-08-30 116 if (err < 0) {
5f33183b7fdfeb Vladimir Oltean 2019-08-30 117
dev_err(ds->dev, "Couldn't determine PVID attributes\n");
5f33183b7fdfeb Vladimir Oltean 2019-08-30 118 return err;
5f33183b7fdfeb Vladimir Oltean 2019-08-30 119 }
5f33183b7fdfeb Vladimir Oltean 2019-08-30 120
5f33183b7fdfeb Vladimir Oltean 2019-08-30 121 return
dsa_port_vid_add(>ports[port], pvid, vinfo.flags);
5f33183b7fdfeb Vladimir Oltean 2019-08-30 122 }
5f33183b7fdfeb Vladimir Oltean 2019-08-30 123
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] Re: [PATCH v9 07/14] KVM: Don't allocate dirty bitmap if dirty ring is enabled
CC: kbuild-...@lists.01.org
In-Reply-To: <20200523225659.1027044-8-pet...@redhat.com>
References: <20200523225659.1027044-8-pet...@redhat.com>
TO: Peter Xu
TO: linux-ker...@vger.kernel.org
TO: k...@vger.kernel.org
CC: Vitaly Kuznetsov
CC: Alex Williamson
CC: "Michael S . Tsirkin"
CC: Paolo Bonzini
CC: "Dr . David Alan Gilbert"
CC: Christophe de Dinechin
CC: Jason Wang
CC: Kevin Tian
CC: pet...@redhat.com
Hi Peter,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on vhost/linux-next]
[also build test WARNING on linus/master v5.7-rc7]
[cannot apply to kvm/linux-next tip/auto-latest linux/master next-20200522]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Peter-Xu/KVM-Dirty-ring-interface/20200524-070926
base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
:: branch date: 2 days ago
:: commit date: 2 days ago
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
cppcheck warnings: (new ones prefixed by >>)
>> arch/x86/kvm/mmu/mmu.c:1280:3: warning: Returning an integer in a function
>> with pointer return type is not portable. [CastIntegerToAddressAtReturn]
return false;
^
arch/x86/kvm/mmu/mmu.c:3725:9: warning: Redundant initialization for 'root'.
The initialized value is overwritten before it is read.
[redundantInitialization]
root = __pa(sp->spt);
^
arch/x86/kvm/mmu/mmu.c:3715:15: note: root is initialized
hpa_t root = vcpu->arch.mmu->pae_root[i];
^
arch/x86/kvm/mmu/mmu.c:3725:9: note: root is overwritten
root = __pa(sp->spt);
^
arch/x86/kvm/mmu/mmu.c:3769:8: warning: Redundant initialization for 'root'.
The initialized value is overwritten before it is read.
[redundantInitialization]
root = __pa(sp->spt);
^
arch/x86/kvm/mmu/mmu.c:3758:14: note: root is initialized
hpa_t root = vcpu->arch.mmu->root_hpa;
^
arch/x86/kvm/mmu/mmu.c:3769:8: note: root is overwritten
root = __pa(sp->spt);
^
arch/x86/kvm/mmu/mmu.c:4670:15: warning: Clarify calculation precedence for
'&' and '?'. [clarifyCalculation]
const u8 x = BYTE_MASK(ACC_EXEC_MASK);
^
arch/x86/kvm/mmu/mmu.c:4671:15: warning: Clarify calculation precedence for
'&' and '?'. [clarifyCalculation]
const u8 w = BYTE_MASK(ACC_WRITE_MASK);
^
arch/x86/kvm/mmu/mmu.c:4672:15: warning: Clarify calculation precedence for
'&' and '?'. [clarifyCalculation]
const u8 u = BYTE_MASK(ACC_USER_MASK);
#
https://github.com/0day-ci/linux/commit/2c23bd2b96e30ae3814e3e56f01a6234131cb531
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 2c23bd2b96e30ae3814e3e56f01a6234131cb531
vim +1280 arch/x86/kvm/mmu/mmu.c
b8e8c8303ff28c arch/x86/kvm/mmu.c Paolo Bonzini 2019-11-04 1269
5d163b1c9d6e55 arch/x86/kvm/mmu.c Xiao Guangrong 2011-03-09 1270 static
struct kvm_memory_slot *
5d163b1c9d6e55 arch/x86/kvm/mmu.c Xiao Guangrong 2011-03-09 1271
gfn_to_memslot_dirty_bitmap(struct kvm_vcpu *vcpu, gfn_t gfn,
5d163b1c9d6e55 arch/x86/kvm/mmu.c Xiao Guangrong 2011-03-09 1272
bool no_dirty_log)
05da45583de9b3 arch/x86/kvm/mmu.c Marcelo Tosatti 2008-02-23 1273 {
05da45583de9b3 arch/x86/kvm/mmu.c Marcelo Tosatti 2008-02-23 1274
struct kvm_memory_slot *slot;
5d163b1c9d6e55 arch/x86/kvm/mmu.c Xiao Guangrong 2011-03-09 1275
54bf36aac52031 arch/x86/kvm/mmu.c Paolo Bonzini 2015-04-08 1276
slot = kvm_vcpu_gfn_to_memslot(vcpu, gfn);
91b0d268a59dd9 arch/x86/kvm/mmu/mmu.c Paolo Bonzini 2020-01-21 1277
if (!slot || slot->flags & KVM_MEMSLOT_INVALID)
91b0d268a59dd9 arch/x86/kvm/mmu/mmu.c Paolo Bonzini 2020-01-21 1278
return NULL;
2c23bd2b96e30a arch/x86/kvm/mmu/mmu.c Peter Xu2020-05-23 1279
if (no_dirty_log && kvm_slot_dirty_track_enabled(slot))
2c23bd2b96e30a arch/x86/kvm/mmu/mmu.c Peter Xu2020-05-23 @1280
return false;
5d163b1c9d6e55 arch/x86/kvm/mmu.c Xiao Guangrong 2011-03-09 1281
5d163b1c9d6e55 arch/x86/kvm/mmu.c Xiao Guangrong 2011-03-09 1282
return slot;
5d163b1c9d6e55 arch/x86/kvm/mmu.c Xiao Guangrong 2011-03-09 1283 }
5d163b1c9d6e55 arch/x86/kvm/mmu.c Xiao Guangrong 2011-03-09 1284
---
0-DAY C
[kbuild] drivers/soc/fsl/dpio/qbman-portal.c:702:26: warning: Local variable 'd' shadows outer argument [shadowArgument]
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Youri Querry
CC: Li Yang
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 9cb1fd0efd195590b828b9b865421ad345a4a145
commit: 3b2abda7d28c69f564c1157b9b9c21ef40092ee9 soc: fsl: dpio: Replace QMAN
array mode with ring mode enqueue
date: 3 months ago
:: branch date: 22 hours ago
:: commit date: 3 months ago
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build):
git checkout 3b2abda7d28c69f564c1157b9b9c21ef40092ee9
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
cppcheck warnings: (new ones prefixed by >>)
>> drivers/soc/fsl/dpio/qbman-portal.c:702:26: warning: Local variable 'd'
>> shadows outer argument [shadowArgument]
struct qbman_eq_desc *d = (struct qbman_eq_desc *)p;
^
drivers/soc/fsl/dpio/qbman-portal.c:652:39: note: Shadowed declaration
const struct qbman_eq_desc *d,
^
drivers/soc/fsl/dpio/qbman-portal.c:702:26: note: Shadow variable
struct qbman_eq_desc *d = (struct qbman_eq_desc *)p;
^
drivers/soc/fsl/dpio/qbman-portal.c:785:26: warning: Local variable 'd'
shadows outer argument [shadowArgument]
struct qbman_eq_desc *d = (struct qbman_eq_desc *)p;
^
drivers/soc/fsl/dpio/qbman-portal.c:736:34: note: Shadowed declaration
const struct qbman_eq_desc *d,
^
drivers/soc/fsl/dpio/qbman-portal.c:785:26: note: Shadow variable
struct qbman_eq_desc *d = (struct qbman_eq_desc *)p;
^
#
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=3b2abda7d28c69f564c1157b9b9c21ef40092ee9
git remote add linus
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout 3b2abda7d28c69f564c1157b9b9c21ef40092ee9
vim +/d +702 drivers/soc/fsl/dpio/qbman-portal.c
321eecb06bfba0 drivers/staging/fsl-mc/bus/dpio/qbman-portal.c Roy Pledge
2017-03-13 638
9d98809711ae0e drivers/soc/fsl/dpio/qbman-portal.cYouri Querry
2019-12-12 639 /**
b46fe745e4f610 drivers/soc/fsl/dpio/qbman-portal.cYouri Querry
2019-12-12 640 * qbman_swp_enqueue_multiple_direct() - Issue a multi enqueue
command
9d98809711ae0e drivers/soc/fsl/dpio/qbman-portal.cYouri Querry
2019-12-12 641 * using one enqueue descriptor
9d98809711ae0e drivers/soc/fsl/dpio/qbman-portal.cYouri Querry
2019-12-12 642 * @s: the software portal used for enqueue
9d98809711ae0e drivers/soc/fsl/dpio/qbman-portal.cYouri Querry
2019-12-12 643 * @d: the enqueue descriptor
9d98809711ae0e drivers/soc/fsl/dpio/qbman-portal.cYouri Querry
2019-12-12 644 * @fd: table pointer of frame descriptor table to be enqueued
3b2abda7d28c69 drivers/soc/fsl/dpio/qbman-portal.cYouri Querry
2019-12-12 645 * @flags: table pointer of QBMAN_ENQUEUE_FLAG_DCA flags, not
used if NULL
9d98809711ae0e drivers/soc/fsl/dpio/qbman-portal.cYouri Querry
2019-12-12 646 * @num_frames: number of fd to be enqueued
9d98809711ae0e drivers/soc/fsl/dpio/qbman-portal.cYouri Querry
2019-12-12 647 *
9d98809711ae0e drivers/soc/fsl/dpio/qbman-portal.cYouri Querry
2019-12-12 648 * Return the number of fd enqueued, or a negative error
number.
9d98809711ae0e drivers/soc/fsl/dpio/qbman-portal.cYouri Querry
2019-12-12 649 */
3b2abda7d28c69 drivers/soc/fsl/dpio/qbman-portal.cYouri Querry
2019-12-12 650 static
b46fe745e4f610 drivers/soc/fsl/dpio/qbman-portal.cYouri Querry
2019-12-12 651 int qbman_swp_enqueue_multiple_direct(struct qbman_swp *s,
9d98809711ae0e drivers/soc/fsl/dpio/qbman-portal.cYouri Querry
2019-12-12 652const struct qbman_eq_desc
*d,
9d98809711ae0e drivers/soc/fsl/dpio/qbman-portal.cYouri Querry
2019-12-12 653const struct dpaa2_fd *fd,
9d98809711ae0e drivers/soc/fsl/dpio/qbman-portal.cYouri Querry
2019-12-12 654uint32_t *flags,
9d98809711ae0e drivers/soc/fsl/dpio/qbman-portal.cYouri Querry
2019-12-12 655int num_frames)
9d98809711ae0e drivers/soc/fsl/dpio/qbman-portal.cYouri Querry
2019-12-12 656 {
3b2abda7d28c69 drivers/soc/fsl/dpio/qbman-portal.cYouri Querry
2019-12-12 657 uint32_t *p = NULL;
3b2abda7d28c69 drivers/soc/fsl/dpio/qbman-portal.cYouri Querry
2019-12-12 658 const uint32_t *cl = (uint32_t *)d;
3b2abda7d28c69 drivers/soc/fsl/dpio/qbman-portal.
[kbuild] Re: [PATCH v3 3/3] vfio-pci: Invalidate mmaps and block MMIO access on disabled memory
CC: kbuild-...@lists.01.org
In-Reply-To: <159017506369.18853.1730602309811263.st...@gimli.home>
References: <159017506369.18853.1730602309811263.st...@gimli.home>
TO: Alex Williamson
Hi Alex,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.7-rc7]
[cannot apply to vfio/next linux/master next-20200522]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Alex-Williamson/vfio-pci-Block-user-access-to-disabled-device-MMIO/20200523-031907
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
4286d192c803571e8ca43b0f1f8ea04d663a278a
:: branch date: 3 days ago
:: commit date: 3 days ago
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
cppcheck warnings: (new ones prefixed by >>)
>> drivers/vfio/pci/vfio_pci.c:820:8: warning: Local variable 'cmd' shadows
>> outer argument [shadowArgument]
u16 cmd;
^
drivers/vfio/pci/vfio_pci.c:748:20: note: Shadowed declaration
unsigned int cmd, unsigned long arg)
^
drivers/vfio/pci/vfio_pci.c:820:8: note: Shadow variable
u16 cmd;
^
>> drivers/vfio/vfio_iommu_type1.c:1226:12: warning: Local variable 'n' shadows
>> outer variable [shadowVariable]
size_t n = dma->iova + dma->size - iova;
^
drivers/vfio/vfio_iommu_type1.c:1183:18: note: Shadowed declaration
struct rb_node *n;
^
drivers/vfio/vfio_iommu_type1.c:1226:12: note: Shadow variable
size_t n = dma->iova + dma->size - iova;
^
#
https://github.com/0day-ci/linux/commit/3c9d9870c815814c4891775ab2950062e014a85c
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 3c9d9870c815814c4891775ab2950062e014a85c
vim +/cmd +820 drivers/vfio/pci/vfio_pci.c
3c9d9870c81581 Alex Williamson 2020-05-22 746
89e1f7d4c66d85 Alex Williamson 2012-07-31 747 static long
vfio_pci_ioctl(void *device_data,
89e1f7d4c66d85 Alex Williamson 2012-07-31 748
unsigned int cmd, unsigned long arg)
89e1f7d4c66d85 Alex Williamson 2012-07-31 749 {
89e1f7d4c66d85 Alex Williamson 2012-07-31 750 struct
vfio_pci_device *vdev = device_data;
89e1f7d4c66d85 Alex Williamson 2012-07-31 751 unsigned long
minsz;
89e1f7d4c66d85 Alex Williamson 2012-07-31 752
89e1f7d4c66d85 Alex Williamson 2012-07-31 753 if (cmd ==
VFIO_DEVICE_GET_INFO) {
89e1f7d4c66d85 Alex Williamson 2012-07-31 754 struct
vfio_device_info info;
89e1f7d4c66d85 Alex Williamson 2012-07-31 755
89e1f7d4c66d85 Alex Williamson 2012-07-31 756 minsz =
offsetofend(struct vfio_device_info, num_irqs);
89e1f7d4c66d85 Alex Williamson 2012-07-31 757
89e1f7d4c66d85 Alex Williamson 2012-07-31 758 if
(copy_from_user(, (void __user *)arg, minsz))
89e1f7d4c66d85 Alex Williamson 2012-07-31 759
return -EFAULT;
89e1f7d4c66d85 Alex Williamson 2012-07-31 760
89e1f7d4c66d85 Alex Williamson 2012-07-31 761 if
(info.argsz < minsz)
89e1f7d4c66d85 Alex Williamson 2012-07-31 762
return -EINVAL;
89e1f7d4c66d85 Alex Williamson 2012-07-31 763
89e1f7d4c66d85 Alex Williamson 2012-07-31 764
info.flags = VFIO_DEVICE_FLAGS_PCI;
89e1f7d4c66d85 Alex Williamson 2012-07-31 765
89e1f7d4c66d85 Alex Williamson 2012-07-31 766 if
(vdev->reset_works)
89e1f7d4c66d85 Alex Williamson 2012-07-31 767
info.flags |= VFIO_DEVICE_FLAGS_RESET;
89e1f7d4c66d85 Alex Williamson 2012-07-31 768
28541d41c9e04c Alex Williamson 2016-02-22 769
info.num_regions = VFIO_PCI_NUM_REGIONS + vdev->num_regions;
89e1f7d4c66d85 Alex Williamson 2012-07-31 770
info.num_irqs = VFIO_PCI_NUM_IRQS;
89e1f7d4c66d85 Alex Williamson 2012-07-31 771
8160c4e455820d Michael S. Tsirkin 2016-02-28 772 return
copy_to_user((void __user *)arg, , minsz) ?
8160c4e455820d Michael S. Tsirkin 2016-02-28 773
-EFAULT : 0;
89e1f7d4c66d85 Alex Williamson 2012-07-31 774
89e1f7d4c66d85
[kbuild] [linux-next:master 7517/12102] net/core/scm.c:295 __scm_install_fd() warn: ignoring unreachable code.
CC: kbuild-...@lists.01.org
TO: Christoph Hellwig
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: c11d28ab4a691736e30b49813fb801847bd44e83
commit: 2618d530dd8b7ac0fdcb83f4c95b88f7b0d37ce6 [7517/12102] net/scm: cleanup
scm_detach_fds
:: branch date: 3 days ago
:: commit date: 13 days ago
config: s390-randconfig-m001-20200524 (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
New smatch warnings:
net/core/scm.c:295 __scm_install_fd() warn: ignoring unreachable code.
Old smatch warnings:
net/core/scm.c:341 scm_detach_fds() warn: ignoring unreachable code.
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=2618d530dd8b7ac0fdcb83f4c95b88f7b0d37ce6
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout 2618d530dd8b7ac0fdcb83f4c95b88f7b0d37ce6
vim +295 net/core/scm.c
9718475e69084de Deepa Dinamani2019-02-02 279
2618d530dd8b7ac Christoph Hellwig 2020-05-11 280 static int
__scm_install_fd(struct file *file, int __user *ufd, int o_flags)
^1da177e4c3f415 Linus Torvalds2005-04-16 281 {
2618d530dd8b7ac Christoph Hellwig 2020-05-11 282 struct socket *sock;
2618d530dd8b7ac Christoph Hellwig 2020-05-11 283 int new_fd;
2618d530dd8b7ac Christoph Hellwig 2020-05-11 284 int error;
^1da177e4c3f415 Linus Torvalds2005-04-16 285
2618d530dd8b7ac Christoph Hellwig 2020-05-11 286 error =
security_file_receive(file);
2618d530dd8b7ac Christoph Hellwig 2020-05-11 287 if (error)
2618d530dd8b7ac Christoph Hellwig 2020-05-11 288 return error;
^1da177e4c3f415 Linus Torvalds2005-04-16 289
2618d530dd8b7ac Christoph Hellwig 2020-05-11 290 new_fd =
get_unused_fd_flags(o_flags);
2618d530dd8b7ac Christoph Hellwig 2020-05-11 291 if (new_fd < 0)
2618d530dd8b7ac Christoph Hellwig 2020-05-11 292 return new_fd;
^1da177e4c3f415 Linus Torvalds2005-04-16 293
2618d530dd8b7ac Christoph Hellwig 2020-05-11 294 error =
put_user(new_fd, ufd);
2618d530dd8b7ac Christoph Hellwig 2020-05-11 @295 if (error) {
^1da177e4c3f415 Linus Torvalds2005-04-16 296
put_unused_fd(new_fd);
2618d530dd8b7ac Christoph Hellwig 2020-05-11 297 return error;
^1da177e4c3f415 Linus Torvalds2005-04-16 298 }
2618d530dd8b7ac Christoph Hellwig 2020-05-11 299
^1da177e4c3f415 Linus Torvalds2005-04-16 300 /* Bump the usage count
and install the file. */
2618d530dd8b7ac Christoph Hellwig 2020-05-11 301 sock =
sock_from_file(file, );
d84295067fc7e95 Daniel Wagner 2013-01-21 302 if (sock) {
2a56a1fec290bf0 Tejun Heo 2015-12-07 303
sock_update_netprioidx(>sk->sk_cgrp_data);
2a56a1fec290bf0 Tejun Heo 2015-12-07 304
sock_update_classid(>sk->sk_cgrp_data);
d84295067fc7e95 Daniel Wagner 2013-01-21 305 }
2618d530dd8b7ac Christoph Hellwig 2020-05-11 306 fd_install(new_fd,
get_file(file));
2618d530dd8b7ac Christoph Hellwig 2020-05-11 307 return error;
^1da177e4c3f415 Linus Torvalds2005-04-16 308 }
^1da177e4c3f415 Linus Torvalds2005-04-16 309
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [djwong-xfs:repair-metadata-atomically 126/229] fs/xfs/xfs_qm.c:1399:6: warning: The if condition is the same as the previous if condition [duplicateCondition]
CC: kbuild-...@lists.01.org
CC: "Darrick J. Wong"
TO: "Darrick J. Wong"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git
repair-metadata-atomically
head: d334005df02786c9f288f2c7060603e9680946b5
commit: 9d81ac3b1eeab4e8fc2561d27fdff1f76f223b30 [126/229] xfs: implement live
quotacheck as part of quota repair
:: branch date: 2 days ago
:: commit date: 2 days ago
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build):
git checkout 9d81ac3b1eeab4e8fc2561d27fdff1f76f223b30
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
cppcheck warnings: (new ones prefixed by >>)
>> fs/xfs/xfs_qm.c:1399:6: warning: The if condition is the same as the
>> previous if condition [duplicateCondition]
if (error) {
^
fs/xfs/xfs_qm.c:1389:6: note: First condition
if (error)
^
fs/xfs/xfs_qm.c:1399:6: note: Second condition
if (error) {
^
fs/xfs/xfs_buf.h:278:38: warning: Clarify calculation precedence for '&' and
'?'. [clarifyCalculation]
bool wait = bp->b_flags & XBF_ASYNC ? false : true;
^
fs/xfs/xfs_qm.c:933:34: warning: Clarify calculation precedence for '&' and
'?'. [clarifyCalculation]
type = flags & XFS_QMOPT_UQUOTA ? XFS_DQ_USER :
^
fs/xfs/xfs_qm.c:934:29: warning: Clarify calculation precedence for '&' and
'?'. [clarifyCalculation]
(flags & XFS_QMOPT_PQUOTA ? XFS_DQ_PROJ : XFS_DQ_GROUP);
^
fs/xfs/xfs_qm.c:1623:6: warning: Either the condition 'qi!=NULL' is
redundant or there is possible null pointer dereference: qi.
[nullPointerRedundantCheck]
if (qi->qi_uquotaip) {
^
fs/xfs/xfs_qm.c:736:2: note: Assuming that condition 'qi!=NULL' is not
redundant
ASSERT(qi != NULL);
^
fs/xfs/xfs_qm.c:735:9: note: Assignment 'qi=mp->m_quotainfo', assigned value
is 0
qi = mp->m_quotainfo;
^
fs/xfs/xfs_qm.c:740:27: note: Calling function 'xfs_qm_destroy_quotainos',
1st argument 'qi' value is 0
xfs_qm_destroy_quotainos(qi);
^
fs/xfs/xfs_qm.c:1623:6: note: Null pointer dereference
if (qi->qi_uquotaip) {
^
fs/xfs/xfs_qm.c:1623:6: warning: Null pointer dereference: qi
[ctunullpointer]
if (qi->qi_uquotaip) {
^
fs/xfs/xfs_qm.c:736:2: note: Assuming that condition 'qi!=NULL' is not
redundant
^
fs/xfs/xfs_qm.c:735:9: note: Assignment 'qi=mp->m_quotainfo', assigned value
is 0
^
fs/xfs/xfs_qm.c:740:26: note: Calling function xfs_qm_destroy_quotainos, 1st
argument is null
xfs_qm_destroy_quotainos(qi);
^
fs/xfs/xfs_qm.c:1623:6: note: Dereferencing argument qi that is null
if (qi->qi_uquotaip) {
^
#
https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git/commit/?id=9d81ac3b1eeab4e8fc2561d27fdff1f76f223b30
git remote add djwong-xfs
https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git
git remote update djwong-xfs
git checkout 9d81ac3b1eeab4e8fc2561d27fdff1f76f223b30
vim +1399 fs/xfs/xfs_qm.c
9d81ac3b1eeab4 fs/xfs/xfs_qm.c Darrick J. Wong 2020-02-19 1336
^1da177e4c3f41 fs/xfs/quota/xfs_qm.c Linus Torvalds 2005-04-16 1337 /*
^1da177e4c3f41 fs/xfs/quota/xfs_qm.c Linus Torvalds 2005-04-16 1338 *
Walk thru all the filesystem inodes and construct a consistent view
^1da177e4c3f41 fs/xfs/quota/xfs_qm.c Linus Torvalds 2005-04-16 1339 *
of the disk quota world. If the quotacheck fails, disable quotas.
^1da177e4c3f41 fs/xfs/quota/xfs_qm.c Linus Torvalds 2005-04-16 1340 */
eb866bbf095ec6 fs/xfs/xfs_qm.c Jie Liu 2014-07-24 1341
STATIC int
^1da177e4c3f41 fs/xfs/quota/xfs_qm.c Linus Torvalds 2005-04-16 1342
xfs_qm_quotacheck(
9d81ac3b1eeab4 fs/xfs/xfs_qm.c Darrick J. Wong 2020-02-19 1343
struct xfs_mount*mp)
^1da177e4c3f41 fs/xfs/quota/xfs_qm.c Linus Torvalds 2005-04-16 1344 {
9d81ac3b1eeab4 fs/xfs/xfs_qm.c Darrick J. Wong 2020-02-19 1345
int error;
43ff2122e6492b fs/xfs/xfs_qm.c Christoph Hellwig 2012-04-23 1346
LIST_HEAD (buffer_list);
9d81ac3b1eeab4 fs/xfs/xfs_qm.c Darrick J. Wong 2020-02-19 1347
uintflags;
113a56835d938d fs/xfs/xfs_qm.c Chandra Seetharaman 2013-06-27 1348
struct xfs_inode*uip = mp->m_quotainfo->qi_uquotaip;
113a56835d938d fs/xfs/xfs_qm.c Chandra Seetharaman 2013-06-27 1349
struct xfs_inode*gip = mp->m_quotainfo->qi_gquotaip;
92f8ff73f18672 fs/xfs/xfs_qm.c Chandra Seetharaman 2013-07-11 13
[kbuild] Re: [PATCH 1/2] nl80211: FILS discovery/bcast probe resp support
CC: kbuild-...@lists.01.org
In-Reply-To: <2020051921.19347-2-alo...@codeaurora.org>
References: <2020051921.19347-2-alo...@codeaurora.org>
TO: Aloka Dixit
TO: johan...@sipsolutions.net
CC: linux-wirel...@vger.kernel.org
CC: Aloka Dixit
Hi Aloka,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on mac80211-next/master]
[also build test WARNING on next-20200522]
[cannot apply to mac80211/master v5.7-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Aloka-Dixit/FILS-discovery-and-bcast-probe-resp-support/20200523-062228
base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git
master
:: branch date: 2 days ago
:: commit date: 2 days ago
config: x86_64-defconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
New smatch warnings:
net/wireless/nl80211.c:4771 nl80211_parse_fd_bcastpresp() error: we previously
assumed 'tmpl' could be null (see line 4766)
Old smatch warnings:
net/wireless/nl80211.c:225 validate_beacon_head() warn: potential spectre issue
'elem->data' [r]
net/wireless/nl80211.c:244 validate_ie_attr() warn: potential spectre issue
'elem->data' [r]
net/wireless/nl80211.c:1262 nl80211_parse_connkeys() warn: ignoring unreachable
code.
net/wireless/nl80211.c:4482 nl80211_parse_tx_bitrate_mask() warn: potential
spectre issue 'rdev->wiphy.bands' [r] (local cap)
net/wireless/nl80211.c:4483 nl80211_parse_tx_bitrate_mask() warn: possible
spectre second half. 'sband'
net/wireless/nl80211.c:4492 nl80211_parse_tx_bitrate_mask() warn: potential
spectre issue 'mask->control' [w] (local cap)
net/wireless/nl80211.c:7984 nl80211_trigger_scan() warn: potential spectre
issue 'wiphy->bands' [r] (local cap)
net/wireless/nl80211.c:7987 nl80211_trigger_scan() warn: potential spectre
issue 'request->rates' [r] (local cap)
net/wireless/nl80211.c:8186 nl80211_parse_sched_scan_per_band_rssi() warn:
potential spectre issue 'match_sets->per_band_rssi_thold' [w] (local cap)
#
https://github.com/0day-ci/linux/commit/d7497e63c41decf82e86f11b0691e47e24b11122
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout d7497e63c41decf82e86f11b0691e47e24b11122
vim +/tmpl +4771 net/wireless/nl80211.c
5c5e52d1bb9625 John Crispin 2019-12-17 4737
d7497e63c41dec Aloka Dixit 2020-05-22 4738 static int
nl80211_parse_fd_bcastpresp(struct genl_info *info,
d7497e63c41dec Aloka Dixit 2020-05-22 4739
struct cfg80211_ap_settings *params)
d7497e63c41dec Aloka Dixit 2020-05-22 4740 {
d7497e63c41dec Aloka Dixit 2020-05-22 4741struct nlattr *tmpl;
d7497e63c41dec Aloka Dixit 2020-05-22 4742struct nlattr
*tb[NL80211_FD_BCASTPRESP_ATTR_MAX + 1];
d7497e63c41dec Aloka Dixit 2020-05-22 4743int ret;
d7497e63c41dec Aloka Dixit 2020-05-22 4744struct cfg80211_beacon_data
*beacon = >beacon;
d7497e63c41dec Aloka Dixit 2020-05-22 4745struct cfg80211_fd_bcastpresp
*cfg;
d7497e63c41dec Aloka Dixit 2020-05-22 4746
d7497e63c41dec Aloka Dixit 2020-05-22 4747if
(params->chandef.center_freq1 <= 5940 &&
d7497e63c41dec Aloka Dixit 2020-05-22 4748
params->chandef.center_freq1 >= 7105)
d7497e63c41dec Aloka Dixit 2020-05-22 4749return -EOPNOTSUPP;
d7497e63c41dec Aloka Dixit 2020-05-22 4750
d7497e63c41dec Aloka Dixit 2020-05-22 4751ret = nla_parse_nested(tb,
NL80211_FD_BCASTPRESP_ATTR_MAX,
d7497e63c41dec Aloka Dixit 2020-05-22 4752
info->attrs[NL80211_ATTR_FD_BCASTPRESP_CFG],
d7497e63c41dec Aloka Dixit 2020-05-22 4753
fd_bcastpresp_policy, NULL);
d7497e63c41dec Aloka Dixit 2020-05-22 4754if (ret)
d7497e63c41dec Aloka Dixit 2020-05-22 4755return ret;
d7497e63c41dec Aloka Dixit 2020-05-22 4756
d7497e63c41dec Aloka Dixit 2020-05-22 4757if
(!tb[NL80211_FD_BCASTPRESP_ATTR_TYPE] ||
d7497e63c41dec Aloka Dixit 2020-05-22 4758
!tb[NL80211_FD_BCASTPRESP_ATTR_INT])
d7497e63c41dec Aloka Dixit 2020-05-22 4759return -EINVAL;
d7497e63c41dec Aloka Dixit 2020-05-22 4760
d7497e63c41dec Aloka Dixit 2020-05-22 4761cfg = >fd_bcastpresp;
d7497e63c41dec Aloka Dixit 2020-05-22 4762cfg->type =
nla_get_u8(tb[NL80211_FD_BCASTPRESP_ATTR_TYPE]);
d7497e63c41dec Aloka Dixit 2020-05-22 4763cfg->interval =
nla_get_u32(tb[NL80211_FD_BCASTPRESP_ATTR_INT]);
d7497e63c41dec Aloka Dixit 2020-05-22 4764
d7497e63c41dec Aloka Dixit 2020-05-22 4765tmpl =
tb[NL80211_FD
[kbuild] Re: [PATCHv3 bpf-next 1/2] xdp: add a new helper for dev map multicast support
CC: kbuild-...@lists.01.org In-Reply-To: <20200523060537.264096-2-liuhang...@gmail.com> References: <20200523060537.264096-2-liuhang...@gmail.com> TO: Hangbin Liu TO: b...@vger.kernel.org CC: net...@vger.kernel.org CC: "Toke Høiland-Jørgensen" CC: Jiri Benc CC: Jesper Dangaard Brouer CC: Eelco Chaudron CC: a...@kernel.org CC: Daniel Borkmann CC: Lorenzo Bianconi CC: Hangbin Liu Hi Hangbin, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] [also build test WARNING on net-next/master next-20200522] [cannot apply to bpf/master net/master linus/master v5.7-rc7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Hangbin-Liu/xdp-add-dev-map-multicast-support/20200523-141019 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master :: branch date: 2 days ago :: commit date: 2 days ago config: s390-randconfig-s002-20200524 (attached as .config) compiler: s390-linux-gcc (GCC) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.1-240-gf0fe1cd9-dirty # save the attached .config to linux build tree make W=1 C=1 ARCH=s390 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) net/core/filter.c:400:33: sparse: sparse: subtraction of functions? Share your drugs net/core/filter.c:403:33: sparse: sparse: subtraction of functions? Share your drugs net/core/filter.c:406:33: sparse: sparse: subtraction of functions? Share your drugs net/core/filter.c:409:33: sparse: sparse: subtraction of functions? Share your drugs net/core/filter.c:412:33: sparse: sparse: subtraction of functions? Share your drugs net/core/filter.c:486:27: sparse: sparse: subtraction of functions? Share your drugs net/core/filter.c:489:27: sparse: sparse: subtraction of functions? Share your drugs net/core/filter.c:492:27: sparse: sparse: subtraction of functions? Share your drugs net/core/filter.c:1380:39: sparse: sparse: incorrect type in argument 1 (different address spaces) @@expected struct sock_filter const *filter @@ got struct sock_struct sock_filter const *filter @@ net/core/filter.c:1380:39: sparse:expected struct sock_filter const *filter net/core/filter.c:1380:39: sparse:got struct sock_filter [noderef] *filter net/core/filter.c:1458:39: sparse: sparse: incorrect type in argument 1 (different address spaces) @@expected struct sock_filter const *filter @@ got struct sock_struct sock_filter const *filter @@ net/core/filter.c:1458:39: sparse:expected struct sock_filter const *filter net/core/filter.c:1458:39: sparse:got struct sock_filter [noderef] *filter net/core/filter.c:7011:27: sparse: sparse: subtraction of functions? Share your drugs net/core/filter.c:7014:27: sparse: sparse: subtraction of functions? Share your drugs net/core/filter.c:7017:27: sparse: sparse: subtraction of functions? Share your drugs net/core/filter.c:215:32: sparse: sparse: cast to restricted __be16 net/core/filter.c:242:32: sparse: sparse: cast to restricted __be32 net/core/filter.c:1880:43: sparse: sparse: incorrect type in argument 2 (different base types) @@expected restricted __wsum [usertype] diff @@ got urestricted __wsum [usertype] diff @@ net/core/filter.c:1880:43: sparse:expected restricted __wsum [usertype] diff net/core/filter.c:1880:43: sparse:got unsigned long long [usertype] to net/core/filter.c:1883:36: sparse: sparse: incorrect type in argument 2 (different base types) @@expected restricted __be16 [usertype] old @@ got urestricted __be16 [usertype] old @@ net/core/filter.c:1883:36: sparse:expected restricted __be16 [usertype] old net/core/filter.c:1883:36: sparse:got unsigned long long [usertype] from net/core/filter.c:1883:42: sparse: sparse: incorrect type in argument 3 (different base types) @@expected restricted __be16 [usertype] new @@ got urestricted __be16 [usertype] new @@ net/core/filter.c:1883:42: sparse:expected restricted __be16 [usertype] new net/core/filter.c:1883:42: sparse:got unsigned long long [usertype] to net/core/filter.c:1886:36: sparse: sparse: incorrect type in argument 2 (different base types) @@expected restricted __be32 [usertype] from @@ got urestricted __be32 [usertype] from @@ net/core/filter.c:1886:36: sparse:expected restricted __be32 [usertype] from net/core/filter.c:1886:36: sparse:got unsigned long long [usertype] from net/core/filter.c:1886:42: sparse: sparse: incorrect type in
[kbuild] [djwong-xfs:repair-metadata-atomically 77/229] fs/xfs/scrub/rtsummary.c:75 xchk_setup_rtsummary() error: uninitialized symbol 'resblks'.
CC: kbuild-...@lists.01.org
CC: "Darrick J. Wong"
TO: "Darrick J. Wong"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git
repair-metadata-atomically
head: d334005df02786c9f288f2c7060603e9680946b5
commit: 0d44a170037d3e6825d8ca4b52f3cf6019a40850 [77/229] xfs: online repair of
realtime summaries
:: branch date: 33 hours ago
:: commit date: 33 hours ago
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
smatch warnings:
fs/xfs/scrub/rtsummary.c:75 xchk_setup_rtsummary() error: uninitialized symbol
'resblks'.
#
https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git/commit/?id=0d44a170037d3e6825d8ca4b52f3cf6019a40850
git remote add djwong-xfs
https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git
git remote update djwong-xfs
git checkout 0d44a170037d3e6825d8ca4b52f3cf6019a40850
vim +/resblks +75 fs/xfs/scrub/rtsummary.c
d11bb52d9fe16ea Darrick J. Wong 2020-03-16 54
d11bb52d9fe16ea Darrick J. Wong 2020-03-16 55 /* Set us up to check the
rtsummary file. */
7a9053f61cc608e Darrick J. Wong 2020-03-10 56 int
d11bb52d9fe16ea Darrick J. Wong 2020-03-16 57 xchk_setup_rtsummary(
d11bb52d9fe16ea Darrick J. Wong 2020-03-16 58 struct xfs_scrub
*sc,
d11bb52d9fe16ea Darrick J. Wong 2020-03-16 59 struct xfs_inode
*ip)
7a9053f61cc608e Darrick J. Wong 2020-03-10 60 {
d11bb52d9fe16ea Darrick J. Wong 2020-03-16 61 struct xfs_mount
*mp = sc->mp;
0d44a170037d3e6 Darrick J. Wong 2020-03-12 62 unsigned long long
resblks;
d11bb52d9fe16ea Darrick J. Wong 2020-03-16 63 int
error;
d11bb52d9fe16ea Darrick J. Wong 2020-03-16 64
0d44a170037d3e6 Darrick J. Wong 2020-03-12 65 /*
0d44a170037d3e6 Darrick J. Wong 2020-03-12 66 * If we're doing a
repair, we reserve 2x the summary blocks: once for
0d44a170037d3e6 Darrick J. Wong 2020-03-12 67 * the new summary
contents and again for the bmbt blocks and the
0d44a170037d3e6 Darrick J. Wong 2020-03-12 68 * remapping operation.
0d44a170037d3e6 Darrick J. Wong 2020-03-12 69 */
0d44a170037d3e6 Darrick J. Wong 2020-03-12 70 if (sc->sm->sm_flags &
XFS_SCRUB_IFLAG_REPAIR) {
0d44a170037d3e6 Darrick J. Wong 2020-03-12 71 resblks =
XFS_B_TO_FSB(sc->mp, sc->mp->m_rsumsize) * 2;
0d44a170037d3e6 Darrick J. Wong 2020-03-12 72 if (resblks >
UINT_MAX)
0d44a170037d3e6 Darrick J. Wong 2020-03-12 73 return
-EOPNOTSUPP;
0d44a170037d3e6 Darrick J. Wong 2020-03-12 74 }
0d44a170037d3e6 Darrick J. Wong 2020-03-12 @75 error =
xchk_trans_alloc(sc, resblks);
d11bb52d9fe16ea Darrick J. Wong 2020-03-16 76 if (error)
d11bb52d9fe16ea Darrick J. Wong 2020-03-16 77 return error;
d11bb52d9fe16ea Darrick J. Wong 2020-03-16 78
d11bb52d9fe16ea Darrick J. Wong 2020-03-16 79 /* Allocate a memory
buffer for the summary comparison. */
d11bb52d9fe16ea Darrick J. Wong 2020-03-16 80 sc->buf =
kmem_alloc_large(sc->mp->m_sb.sb_blocksize, KM_MAYFAIL);
d11bb52d9fe16ea Darrick J. Wong 2020-03-16 81 if (!sc->buf)
d11bb52d9fe16ea Darrick J. Wong 2020-03-16 82 return -ENOMEM;
7a9053f61cc608e Darrick J. Wong 2020-03-10 83
7a9053f61cc608e Darrick J. Wong 2020-03-10 84 /*
d11bb52d9fe16ea Darrick J. Wong 2020-03-16 85 * Locking order
requires us to take the rtbitmap first. We must be
d11bb52d9fe16ea Darrick J. Wong 2020-03-16 86 * careful to unlock it
ourselves when we are done with the rtbitmap
d11bb52d9fe16ea Darrick J. Wong 2020-03-16 87 * file since the scrub
infrastructure won't do that for us.
7a9053f61cc608e Darrick J. Wong 2020-03-10 88 */
d11bb52d9fe16ea Darrick J. Wong 2020-03-16 89 xfs_ilock(mp->m_rbmip,
XFS_ILOCK_SHARED | XFS_ILOCK_RTBITMAP);
d11bb52d9fe16ea Darrick J. Wong 2020-03-16 90
d11bb52d9fe16ea Darrick J. Wong 2020-03-16 91 /* ...and then we can
lock the rtsummary inode. */
7a9053f61cc608e Darrick J. Wong 2020-03-10 92 sc->ilock_flags =
XFS_ILOCK_EXCL | XFS_ILOCK_RTSUM;
d11bb52d9fe16ea Darrick J. Wong 2020-03-16 93 sc->ip =
sc->mp->m_rsumip;
7a9053f61cc608e Darrick J. Wong 2020-03-10 94 xfs_ilock(sc->ip,
sc->ilock_flags);
7a9053f61cc608e Darrick J. Wong 2020-03-10 95
d11bb52d9fe16ea Darrick J. Wong 2020-03-16 96 return 0;
d11bb52d9fe16ea Darrick J. Wong 2020-03-16 97 }
d11bb52d9fe16ea Darrick J. Wong 2020-03-16 98
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hype
[kbuild] [djwong-xfs:stale-exposure 45/47] fs/xfs/xfs_iomap.c:438 xfs_iomap_prealloc_size() warn: should 'plen << 1' be a 64 bit type?
CC: kbuild-...@lists.01.org
CC: "Darrick J. Wong"
TO: "Darrick J. Wong"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git
stale-exposure
head: 2d84e06a8db67be32cea287104a09084df78d4ee
commit: 3edd6be92db73576b2bd71d4c2b1a623245a2336 [45/47] xfs: measure all
contiguous previous extents for prealloc size
:: branch date: 30 hours ago
:: commit date: 30 hours ago
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
smatch warnings:
fs/xfs/xfs_iomap.c:438 xfs_iomap_prealloc_size() warn: should 'plen << 1' be a
64 bit type?
#
https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git/commit/?id=3edd6be92db73576b2bd71d4c2b1a623245a2336
git remote add djwong-xfs
https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git
git remote update djwong-xfs
git checkout 3edd6be92db73576b2bd71d4c2b1a623245a2336
vim +438 fs/xfs/xfs_iomap.c
76a4202a388690e Brian Foster 2013-03-18 353
055388a3188f566 Dave Chinner 2011-01-04 354 /*
51446f5ba44874d Christoph Hellwig 2016-09-19 355 * If we are doing a write
at the end of the file and there are no allocations
51446f5ba44874d Christoph Hellwig 2016-09-19 356 * past this one, then
extend the allocation out to the file system's write
51446f5ba44874d Christoph Hellwig 2016-09-19 357 * iosize.
51446f5ba44874d Christoph Hellwig 2016-09-19 358 *
055388a3188f566 Dave Chinner 2011-01-04 359 * If we don't have a user
specified preallocation size, dynamically increase
055388a3188f566 Dave Chinner 2011-01-04 360 * the preallocation size as
the size of the file grows. Cap the maximum size
055388a3188f566 Dave Chinner 2011-01-04 361 * at a single extent or
less if the filesystem is near full. The closer the
055388a3188f566 Dave Chinner 2011-01-04 362 * filesystem is to full,
the smaller the maximum prealocation.
51446f5ba44874d Christoph Hellwig 2016-09-19 363 *
51446f5ba44874d Christoph Hellwig 2016-09-19 364 * As an exception we don't
do any preallocation at all if the file is smaller
51446f5ba44874d Christoph Hellwig 2016-09-19 365 * than the minimum
preallocation and we are using the default dynamic
51446f5ba44874d Christoph Hellwig 2016-09-19 366 * preallocation scheme, as
it is likely this is the only write to the file that
51446f5ba44874d Christoph Hellwig 2016-09-19 367 * is going to be done.
51446f5ba44874d Christoph Hellwig 2016-09-19 368 *
51446f5ba44874d Christoph Hellwig 2016-09-19 369 * We clean up any extra
space left over when the file is closed in
51446f5ba44874d Christoph Hellwig 2016-09-19 370 * xfs_inactive().
055388a3188f566 Dave Chinner 2011-01-04 371 */
055388a3188f566 Dave Chinner 2011-01-04 372 STATIC xfs_fsblock_t
055388a3188f566 Dave Chinner 2011-01-04 373 xfs_iomap_prealloc_size(
a1e16c26660b301 Dave Chinner 2013-02-11 374 struct xfs_inode
*ip,
66ae56a53f0e341 Christoph Hellwig 2019-02-18 375 int
whichfork,
51446f5ba44874d Christoph Hellwig 2016-09-19 376 loff_t
offset,
51446f5ba44874d Christoph Hellwig 2016-09-19 377 loff_t
count,
b2b1712a640824e Christoph Hellwig 2017-11-03 378 struct xfs_iext_cursor
*icur)
055388a3188f566 Dave Chinner 2011-01-04 379 {
3edd6be92db7357 Darrick J. Wong 2020-05-20 380 struct xfs_iext_cursor
ncur = *icur;
3edd6be92db7357 Darrick J. Wong 2020-05-20 381 struct xfs_bmbt_irec
prev, got;
51446f5ba44874d Christoph Hellwig 2016-09-19 382 struct xfs_mount
*mp = ip->i_mount;
66ae56a53f0e341 Christoph Hellwig 2019-02-18 383 struct xfs_ifork
*ifp = XFS_IFORK_PTR(ip, whichfork);
51446f5ba44874d Christoph Hellwig 2016-09-19 384 xfs_fileoff_t
offset_fsb = XFS_B_TO_FSBT(mp, offset);
3c58b5f809eda8a Brian Foster 2013-03-18 385 int64_t
freesp;
76a4202a388690e Brian Foster 2013-03-18 386 xfs_fsblock_t
qblocks;
51446f5ba44874d Christoph Hellwig 2016-09-19 387 xfs_fsblock_t
alloc_blocks = 0;
3edd6be92db7357 Darrick J. Wong 2020-05-20 388 xfs_extlen_t
plen;
3edd6be92db7357 Darrick J. Wong 2020-05-20 389 int
shift = 0;
3edd6be92db7357 Darrick J. Wong 2020-05-20 390 int
qshift = 0;
51446f5ba44874d Christoph Hellwig 2016-09-19 391
51446f5ba44874d Christoph Hellwig 2016-09-19 392 if (offset + count <=
XFS_ISIZE(ip))
51446f5ba44874d Christoph Hellwig 2016-09-19 393 return 0;
51446f5ba44874d Christoph Hellwig 2016-09-19 394
3274d00801007cc Christoph Hellwig 2019-10-28 395 if (!(mp->m_flags &
XFS_MOUNT_ALLOCSIZE) &a
[kbuild] [linux-next:master 10770/12102] drivers/i2c/busses/i2c-pxa.c:1362 i2c_pxa_init_recovery() warn: passing zero to 'PTR_ERR'
CC: kbuild-...@lists.01.org
TO: Russell King
CC: Wolfram Sang
CC: Andrew Lunn
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: c11d28ab4a691736e30b49813fb801847bd44e83
commit: 7c9ec2c5251851f5a3888d1a7fbb2eaf700a538a [10770/12102] i2c: pxa:
implement generic i2c bus recovery
:: branch date: 2 days ago
:: commit date: 4 days ago
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
New smatch warnings:
drivers/i2c/busses/i2c-pxa.c:1362 i2c_pxa_init_recovery() warn: passing zero to
'PTR_ERR'
drivers/i2c/busses/i2c-pxa.c:1362 i2c_pxa_init_recovery() warn: passing zero to
'PTR_ERR'
drivers/i2c/busses/i2c-pxa.c:1376 i2c_pxa_init_recovery() error: unrecognized
%p extension 'e', treated as normal %p
Old smatch warnings:
drivers/i2c/busses/i2c-pxa.c:1397 i2c_pxa_init_recovery() error: unrecognized
%p extension 'e', treated as normal %p
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=7c9ec2c5251851f5a3888d1a7fbb2eaf700a538a
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout 7c9ec2c5251851f5a3888d1a7fbb2eaf700a538a
vim +/PTR_ERR +1362 drivers/i2c/busses/i2c-pxa.c
7c9ec2c5251851 Russell King 2020-05-13 1335
7c9ec2c5251851 Russell King 2020-05-13 1336 static int
i2c_pxa_init_recovery(struct pxa_i2c *i2c)
7c9ec2c5251851 Russell King 2020-05-13 1337 {
7c9ec2c5251851 Russell King 2020-05-13 1338struct i2c_bus_recovery_info
*bri = >recovery;
7c9ec2c5251851 Russell King 2020-05-13 1339struct device *dev =
i2c->adap.dev.parent;
7c9ec2c5251851 Russell King 2020-05-13 1340
7c9ec2c5251851 Russell King 2020-05-13 1341/*
7c9ec2c5251851 Russell King 2020-05-13 1342 * When slave mode is enabled,
we are not the only master on the bus.
7c9ec2c5251851 Russell King 2020-05-13 1343 * Bus recovery can only be
performed when we are the master, which
7c9ec2c5251851 Russell King 2020-05-13 1344 * we can't be certain of.
Therefore, when slave mode is enabled, do
7c9ec2c5251851 Russell King 2020-05-13 1345 * not configure bus recovery.
7c9ec2c5251851 Russell King 2020-05-13 1346 */
7c9ec2c5251851 Russell King 2020-05-13 1347if
(IS_ENABLED(CONFIG_I2C_PXA_SLAVE))
7c9ec2c5251851 Russell King 2020-05-13 1348return 0;
7c9ec2c5251851 Russell King 2020-05-13 1349
7c9ec2c5251851 Russell King 2020-05-13 1350i2c->pinctrl =
devm_pinctrl_get(dev);
7c9ec2c5251851 Russell King 2020-05-13 1351if (IS_ERR(i2c->pinctrl))
7c9ec2c5251851 Russell King 2020-05-13 1352return
PTR_ERR(i2c->pinctrl);
7c9ec2c5251851 Russell King 2020-05-13 1353
7c9ec2c5251851 Russell King 2020-05-13 1354if (!i2c->pinctrl)
7c9ec2c5251851 Russell King 2020-05-13 1355return 0;
7c9ec2c5251851 Russell King 2020-05-13 1356
7c9ec2c5251851 Russell King 2020-05-13 1357i2c->pinctrl_default =
pinctrl_lookup_state(i2c->pinctrl,
7c9ec2c5251851 Russell King 2020-05-13 1358
PINCTRL_STATE_DEFAULT);
7c9ec2c5251851 Russell King 2020-05-13 1359i2c->pinctrl_recovery =
pinctrl_lookup_state(i2c->pinctrl, "recovery");
7c9ec2c5251851 Russell King 2020-05-13 1360
7c9ec2c5251851 Russell King 2020-05-13 1361if
(IS_ERR(i2c->pinctrl_default) || IS_ERR(i2c->pinctrl_recovery)) {
7c9ec2c5251851 Russell King 2020-05-13 @1362dev_info(dev, "missing
pinmux recovery information: %ld %ld\n",
7c9ec2c5251851 Russell King 2020-05-13 1363
PTR_ERR(i2c->pinctrl_default),
7c9ec2c5251851 Russell King 2020-05-13 1364
PTR_ERR(i2c->pinctrl_recovery));
7c9ec2c5251851 Russell King 2020-05-13 1365return 0;
7c9ec2c5251851 Russell King 2020-05-13 1366}
7c9ec2c5251851 Russell King 2020-05-13 1367
7c9ec2c5251851 Russell King 2020-05-13 1368/*
7c9ec2c5251851 Russell King 2020-05-13 1369 * Claiming GPIOs can influence
the pinmux state, and may glitch the
7c9ec2c5251851 Russell King 2020-05-13 1370 * I2C bus. Do this carefully.
7c9ec2c5251851 Russell King 2020-05-13 1371 */
7c9ec2c5251851 Russell King 2020-05-13 1372bri->scl_gpiod =
devm_gpiod_get(dev, "scl", GPIOD_OUT_HIGH_OPEN_DRAIN);
7c9ec2c5251851 Russell King 2020-05-13 1373if (bri->scl_gpiod ==
ERR_PTR(-EPROBE_DEFER))
7c9ec2c5251851 Russell King 2020-05-13 1374return -EPROBE_DEFER;
7c9ec2c5251851 Russell King 2020-05-13 1375if (IS_ERR(bri->scl_gpiod)) {
7c9ec2c5251851 Russell King 2020-05-13 @1376dev_info(dev, "missing
scl gpio recovery information: %pe\n",
7c9ec2c5251851 Russell King 2020-05-13 1377
[kbuild] [djwong-xfs:repair-metadata-atomically 224/229] fs/xfs/xfs_ioctl.c:1866:1: sparse: int extern [addressable] [signed] [toplevel] xfs_ioc_swapext( ... )
CC: kbuild-...@lists.01.org
CC: "Darrick J. Wong"
TO: "Darrick J. Wong"
tree: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git
repair-metadata-atomically
head: d334005df02786c9f288f2c7060603e9680946b5
commit: 4dafcd0f4f188da560e3610a0b8dd95668ce9fba [224/229] xfs: remove old swap
extents implementation
:: branch date: 29 hours ago
:: commit date: 29 hours ago
config: s390-randconfig-s002-20200524 (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-240-gf0fe1cd9-dirty
git checkout 4dafcd0f4f188da560e3610a0b8dd95668ce9fba
# save the attached .config to linux build tree
make W=1 C=1 ARCH=s390 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
fs/xfs/xfs_ioctl.c:1866:1: sparse: sparse: symbol 'xfs_ioc_swapext'
redeclared with different type (incompatible argument 1 (different address
spaces)):
>> fs/xfs/xfs_ioctl.c:1866:1: sparse:int extern [addressable] [signed]
>> [toplevel] xfs_ioc_swapext( ... )
fs/xfs/xfs_ioctl.h:20:1: sparse: note: previously declared as:
>> fs/xfs/xfs_ioctl.h:20:1: sparse:int extern [addressable] [signed]
>> [toplevel] xfs_ioc_swapext( ... )
#
https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git/commit/?id=4dafcd0f4f188da560e3610a0b8dd95668ce9fba
git remote add djwong-xfs
https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git
git remote update djwong-xfs
git checkout 4dafcd0f4f188da560e3610a0b8dd95668ce9fba
vim +1866 fs/xfs/xfs_ioctl.c
36fd6e863cb7329 Darrick J. Wong 2017-10-17 1864
a133d952b44cef2 Dave Chinner2013-08-12 1865 int
a133d952b44cef2 Dave Chinner2013-08-12 @1866 xfs_ioc_swapext(
4dafcd0f4f188da Darrick J. Wong 2020-03-30 1867struct xfs_swapext
__user *arg)
a133d952b44cef2 Dave Chinner2013-08-12 1868 {
4dafcd0f4f188da Darrick J. Wong 2020-03-30 1869struct xfs_swapext
sx;
4dafcd0f4f188da Darrick J. Wong 2020-03-30 1870struct file_swap_range
fsr = { 0 };
4dafcd0f4f188da Darrick J. Wong 2020-03-30 1871struct fd
fd2, fd1;
a133d952b44cef2 Dave Chinner2013-08-12 1872int
error = 0;
a133d952b44cef2 Dave Chinner2013-08-12 1873
4dafcd0f4f188da Darrick J. Wong 2020-03-30 1874if (copy_from_user(,
arg, sizeof(struct xfs_swapext)))
4dafcd0f4f188da Darrick J. Wong 2020-03-30 1875return -EFAULT;
a133d952b44cef2 Dave Chinner2013-08-12 1876
4dafcd0f4f188da Darrick J. Wong 2020-03-30 1877fd2 =
fdget((int)sx.sx_fdtarget);
4dafcd0f4f188da Darrick J. Wong 2020-03-30 1878if (!fd2.file)
4dafcd0f4f188da Darrick J. Wong 2020-03-30 1879return -EINVAL;
a133d952b44cef2 Dave Chinner2013-08-12 1880
4dafcd0f4f188da Darrick J. Wong 2020-03-30 1881fd1 =
fdget((int)sx.sx_fdtmp);
4dafcd0f4f188da Darrick J. Wong 2020-03-30 1882if (!fd1.file) {
2451337dd043901 Dave Chinner2014-06-25 1883error = -EINVAL;
4dafcd0f4f188da Darrick J. Wong 2020-03-30 1884goto dest_fdput;
a133d952b44cef2 Dave Chinner2013-08-12 1885}
a133d952b44cef2 Dave Chinner2013-08-12 1886
4dafcd0f4f188da Darrick J. Wong 2020-03-30 1887fsr.file1_fd =
sx.sx_fdtmp;
4dafcd0f4f188da Darrick J. Wong 2020-03-30 1888fsr.length =
sx.sx_length;
4dafcd0f4f188da Darrick J. Wong 2020-03-30 1889fsr.flags =
FILE_SWAP_RANGE_NONATOMIC | FILE_SWAP_RANGE_FILE2_FRESH |
4dafcd0f4f188da Darrick J. Wong 2020-03-30 1890
FILE_SWAP_RANGE_FULL_FILES;
4dafcd0f4f188da Darrick J. Wong 2020-03-30 1891fsr.file2_ino =
sx.sx_stat.bs_ino;
4dafcd0f4f188da Darrick J. Wong 2020-03-30 1892fsr.file2_mtime =
sx.sx_stat.bs_mtime.tv_sec;
4dafcd0f4f188da Darrick J. Wong 2020-03-30 1893fsr.file2_ctime =
sx.sx_stat.bs_ctime.tv_sec;
4dafcd0f4f188da Darrick J. Wong 2020-03-30 1894fsr.file2_mtime_nsec =
sx.sx_stat.bs_mtime.tv_nsec;
4dafcd0f4f188da Darrick J. Wong 2020-03-30 1895fsr.file2_ctime_nsec =
sx.sx_stat.bs_ctime.tv_nsec;
a133d952b44cef2 Dave Chinner2013-08-12 1896
4dafcd0f4f188da Darrick J. Wong 2020-03-30 1897error =
vfs_swap_file_range(fd1.file, fd2.file, );
a133d952b44cef2 Dave Chinner2013-08-12 1898
7f1b62457b58f9b Jann Horn 2016-07-20 1899/*
4dafcd0f4f188da Darrick J. Wong 2020-03-30 1900 * The old
implementation returned EFAULT if the swap range was not
4dafcd0f4f188da Darrick J. Wong 2020-03-30 1901 * the entirety of both
files.
7f1b62457b58f9b Jann Horn 2016-07-20 1902 */
4dafcd0f4f188da Darrick J. Wong 2020-03-30 1903if (error == -EDOM
[kbuild] [linux-next:master 10833/12102] net/ipv6/mcast.c:549:5: sparse: int extern [addressable] [signed] [toplevel] ip6_mc_msfget( ... )
CC: kbuild-...@lists.01.org
TO: Al Viro
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: c11d28ab4a691736e30b49813fb801847bd44e83
commit: 931ca7ab7fe804d77bc6952f1512950c0d870f26 [10833/12102] ip*_mc_gsfget():
lift copyout of struct group_filter into callers
:: branch date: 2 days ago
:: commit date: 4 days ago
config: c6x-randconfig-s001-20200524 (attached as .config)
compiler: c6x-elf-gcc (GCC) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-240-gf0fe1cd9-dirty
git checkout 931ca7ab7fe804d77bc6952f1512950c0d870f26
# save the attached .config to linux build tree
make W=1 C=1 ARCH=c6x CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
net/ipv6/mcast.c:606:34: sparse: sparse: incorrect type in argument 1
(different address spaces) @@expected void [noderef] *to @@got
struct __kvoid [noderef] *to @@
net/ipv6/mcast.c:606:34: sparse:expected void [noderef] *to
net/ipv6/mcast.c:606:34: sparse:got struct __kernel_sockaddr_storage *p
net/ipv6/mcast.c:549:5: sparse: sparse: symbol 'ip6_mc_msfget' redeclared
with different type (incompatible argument 3 (different address spaces)):
>> net/ipv6/mcast.c:549:5: sparse:int extern [addressable] [signed]
>> [toplevel] ip6_mc_msfget( ... )
include/net/ipv6.h:1140:5: sparse: note: previously declared as:
>> include/net/ipv6.h:1140:5: sparse:int extern [addressable] [signed]
>> [toplevel] ip6_mc_msfget( ... )
net/ipv6/mcast.c:259:25: sparse: sparse: context imbalance in
'ip6_mc_find_dev_rcu' - different lock contexts for basic block
net/ipv6/mcast.c:453:9: sparse: sparse: context imbalance in 'ip6_mc_source'
- unexpected unlock
net/ipv6/mcast.c:542:9: sparse: sparse: context imbalance in
'ip6_mc_msfilter' - unexpected unlock
net/ipv6/mcast.c:589:21: sparse: sparse: context imbalance in
'ip6_mc_msfget' - unexpected unlock
net/ipv6/mcast.c:2700:25: sparse: sparse: context imbalance in
'igmp6_mc_get_next' - unexpected unlock
net/ipv6/mcast.c:2722:9: sparse: sparse: context imbalance in
'igmp6_mc_get_idx' - wrong count at exit
net/ipv6/mcast.c:2749:9: sparse: sparse: context imbalance in
'igmp6_mc_seq_stop' - unexpected unlock
net/ipv6/mcast.c:2821:31: sparse: sparse: context imbalance in
'igmp6_mcf_get_next' - unexpected unlock
net/ipv6/mcast.c:2853:9: sparse: sparse: context imbalance in
'igmp6_mcf_get_idx' - wrong count at exit
net/ipv6/mcast.c:2870:9: sparse: sparse: context imbalance in
'igmp6_mcf_seq_next' - wrong count at exit
net/ipv6/mcast.c:2883:17: sparse: sparse: context imbalance in
'igmp6_mcf_seq_stop' - unexpected unlock
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=931ca7ab7fe804d77bc6952f1512950c0d870f26
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout 931ca7ab7fe804d77bc6952f1512950c0d870f26
vim +549 net/ipv6/mcast.c
^1da177e4c3f41 Linus Torvalds2005-04-16 548
^1da177e4c3f41 Linus Torvalds2005-04-16 @549 int ip6_mc_msfget(struct sock
*sk, struct group_filter *gsf,
931ca7ab7fe804 Al Viro 2020-03-29 550struct sockaddr_storage
*p)
^1da177e4c3f41 Linus Torvalds2005-04-16 551 {
^1da177e4c3f41 Linus Torvalds2005-04-16 552int err, i, count,
copycount;
b71d1d426d263b Eric Dumazet 2011-04-22 553const struct in6_addr
*group;
^1da177e4c3f41 Linus Torvalds2005-04-16 554struct ipv6_mc_socklist
*pmc;
^1da177e4c3f41 Linus Torvalds2005-04-16 555struct inet6_dev *idev;
^1da177e4c3f41 Linus Torvalds2005-04-16 556struct ipv6_pinfo
*inet6 = inet6_sk(sk);
^1da177e4c3f41 Linus Torvalds2005-04-16 557struct ip6_sf_socklist
*psl;
3b1e0a655f8eba YOSHIFUJI Hideaki 2008-03-26 558struct net *net =
sock_net(sk);
^1da177e4c3f41 Linus Torvalds2005-04-16 559
^1da177e4c3f41 Linus Torvalds2005-04-16 560group = &((struct
sockaddr_in6 *)>gf_group)->sin6_addr;
^1da177e4c3f41 Linus Torvalds2005-04-16 561
^1da177e4c3f41 Linus Torvalds2005-04-16 562if
(!ipv6_addr_is_multicast(group))
^1da177e4c3f41 Linus Torvalds2005-04-16 563return -EINVAL;
^1da177e4c3f41 Linus Torvalds2005-04-16 564
96b52e61be1ad4 Eric Dumazet 2010-06-07 565rcu_read_lock();
96b52e61be1ad4 Eric Dumazet 2010-06-07 566idev =
ip6_mc_find_dev_rcu(net, group, gsf->gf_interface);
^1da177e4c3f41 Linus Torvalds2005-04-16 567
96b52e61be1ad4 Eric Dumazet 2010-06-07 568if (!idev) {
96b52e61be1ad4 Eric Dumazet 2010-06-07 569
rcu_read_unlock();
^1da177e4c3f41 Linus Torvalds20
[kbuild] [linux-next:master 3956/12102] net/core/neighbour.c:3460:5: sparse: int extern [addressable] [signed] [toplevel] neigh_proc_dointvec( ... )
CC: kbuild-...@lists.01.org
TO: Christoph Hellwig
CC: Al Viro
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: c11d28ab4a691736e30b49813fb801847bd44e83
commit: 32927393dc1ccd60fb2bdc05b9e8e88753761469 [3956/12102] sysctl: pass
kernel pointers to ->proc_handler
:: branch date: 2 days ago
:: commit date: 4 weeks ago
config: c6x-randconfig-s001-20200524 (attached as .config)
compiler: c6x-elf-gcc (GCC) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-240-gf0fe1cd9-dirty
git checkout 32927393dc1ccd60fb2bdc05b9e8e88753761469
# save the attached .config to linux build tree
make W=1 C=1 ARCH=c6x CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
net/core/neighbour.c:3460:5: sparse: sparse: symbol 'neigh_proc_dointvec'
redeclared with different type (incompatible argument 3 (different address
spaces)):
>> net/core/neighbour.c:3460:5: sparse:int extern [addressable] [signed]
>> [toplevel] neigh_proc_dointvec( ... )
include/net/neighbour.h:394:5: sparse: note: previously declared as:
>> include/net/neighbour.h:394:5: sparse:int extern [addressable] [signed]
>> [toplevel] neigh_proc_dointvec( ... )
net/core/neighbour.c:3470:5: sparse: sparse: symbol
'neigh_proc_dointvec_jiffies' redeclared with different type (incompatible
argument 3 (different address spaces)):
>> net/core/neighbour.c:3470:5: sparse:int extern [addressable] [signed]
>> [toplevel] neigh_proc_dointvec_jiffies( ... )
include/net/neighbour.h:396:5: sparse: note: previously declared as:
>> include/net/neighbour.h:396:5: sparse:int extern [addressable] [signed]
>> [toplevel] neigh_proc_dointvec_jiffies( ... )
net/core/neighbour.c:3490:5: sparse: sparse: symbol
'neigh_proc_dointvec_ms_jiffies' redeclared with different type (incompatible
argument 3 (different address spaces)):
>> net/core/neighbour.c:3490:5: sparse:int extern [addressable] [signed]
>> [toplevel] neigh_proc_dointvec_ms_jiffies( ... )
include/net/neighbour.h:399:5: sparse: note: previously declared as:
>> include/net/neighbour.h:399:5: sparse:int extern [addressable] [signed]
>> [toplevel] neigh_proc_dointvec_ms_jiffies( ... )
net/core/neighbour.c:348:12: sparse: sparse: context imbalance in
'__neigh_ifdown' - wrong count at exit
net/core/neighbour.c:803:9: sparse: sparse: context imbalance in
'pneigh_ifdown_and_unlock' - unexpected unlock
--
net/ipv6/ndisc.c:1850:55: sparse: sparse: incorrect type in argument 3
(different address spaces) @@expected void [noderef] *buffer @@
got n:1> *buffer @@
net/ipv6/ndisc.c:1850:55: sparse:expected void [noderef] *buffer
net/ipv6/ndisc.c:1850:55: sparse:got void *buffer
net/ipv6/ndisc.c:1854:51: sparse: sparse: incorrect type in argument 3
(different address spaces) @@expected void [noderef] *buffer @@
got n:1> *buffer @@
net/ipv6/ndisc.c:1854:51: sparse:expected void [noderef] *buffer
net/ipv6/ndisc.c:1854:51: sparse:got void *buffer
net/ipv6/ndisc.c:1859:54: sparse: sparse: incorrect type in argument 3
(different address spaces) @@expected void [noderef] *buffer @@
got n:1> *buffer @@
net/ipv6/ndisc.c:1859:54: sparse:expected void [noderef] *buffer
net/ipv6/ndisc.c:1859:54: sparse:got void *buffer
net/ipv6/ndisc.c:1838:5: sparse: sparse: symbol 'ndisc_ifinfo_sysctl_change'
redeclared with different type (incompatible argument 3 (different address
spaces)):
>> net/ipv6/ndisc.c:1838:5: sparse:int extern [addressable] [signed]
>> [toplevel] ndisc_ifinfo_sysctl_change( ... )
include/net/ndisc.h:496:5: sparse: note: previously declared as:
>> include/net/ndisc.h:496:5: sparse:int extern [addressable] [signed]
>> [toplevel] ndisc_ifinfo_sysctl_change( ... )
include/net/addrconf.h:478:36: sparse: sparse: restricted __be32 degrades to
integer
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=32927393dc1ccd60fb2bdc05b9e8e88753761469
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout 32927393dc1ccd60fb2bdc05b9e8e88753761469
vim +3460 net/core/neighbour.c
1f9248e5606afc6 Jiri Pirko2013-12-07 3459
32927393dc1ccd6 Christoph Hellwig 2020-04-24 @3460 int
neigh_proc_dointvec(struct ctl_table *ctl, int write, void *buffer,
32927393dc1ccd6 Christoph Hellwig 2020-04-24 3461 size_t
*lenp, loff_t *ppos)
cb5b09c17fe6005 Jiri Pirko2013-12-07 3462 {
1d4c8c29841b999 Jiri Pirko2013-12-07 3463 int ret =
proc_dointvec(ctl, write, buffer, lenp, ppos);
1d4c8c29841b999 Jiri Pir
[kbuild] drivers/media/v4l2-core/v4l2-compat-ioctl32.c:782 get_v4l2_buffer32_time32() warn: ignoring unreachable code.
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Arnd Bergmann
CC: Mauro Carvalho Chehab
CC: linux-me...@vger.kernel.org
CC: Hans Verkuil
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 98790bbac4db1697212ce9462ec35ca09c4a2810
commit: 342027c5de4494d14657b64ead536a5671768672 media: v4l2-core: fix compat
v4l2_buffer handling for time64 ABI
date: 5 months ago
:: branch date: 73 minutes ago
:: commit date: 5 months ago
config: s390-randconfig-m001-20200524 (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
New smatch warnings:
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:782 get_v4l2_buffer32_time32()
warn: ignoring unreachable code.
Old smatch warnings:
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:173 get_v4l2_window32() warn:
ignoring unreachable code.
arch/s390/include/asm/uaccess.h:143 __get_user_fn() error: uninitialized symbol
'rc'.
arch/s390/include/asm/uaccess.h:113 __put_user_fn() error: uninitialized symbol
'rc'.
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:682 get_v4l2_buffer32() warn:
ignoring unreachable code.
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:1162 get_v4l2_ext_controls32()
warn: ignoring unreachable code.
#
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=342027c5de4494d14657b64ead536a5671768672
git remote add linus
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout 342027c5de4494d14657b64ead536a5671768672
vim +782 drivers/media/v4l2-core/v4l2-compat-ioctl32.c
cf664a6458b254c drivers/media/video/compat_ioctl32.c Philippe De
Muyter 2006-01-09 738
342027c5de4494d drivers/media/v4l2-core/v4l2-compat-ioctl32.c Arnd Bergmann
2019-12-16 739 static int get_v4l2_buffer32_time32(struct v4l2_buffer_time32
__user *p64,
342027c5de4494d drivers/media/v4l2-core/v4l2-compat-ioctl32.c Arnd Bergmann
2019-12-16 740struct v4l2_buffer32_time32
__user *p32,
342027c5de4494d drivers/media/v4l2-core/v4l2-compat-ioctl32.c Arnd Bergmann
2019-12-16 741void __user *aux_buf, u32
aux_space)
342027c5de4494d drivers/media/v4l2-core/v4l2-compat-ioctl32.c Arnd Bergmann
2019-12-16 742 {
342027c5de4494d drivers/media/v4l2-core/v4l2-compat-ioctl32.c Arnd Bergmann
2019-12-16 743u32 type;
342027c5de4494d drivers/media/v4l2-core/v4l2-compat-ioctl32.c Arnd Bergmann
2019-12-16 744u32 length;
342027c5de4494d drivers/media/v4l2-core/v4l2-compat-ioctl32.c Arnd Bergmann
2019-12-16 745s32 request_fd;
342027c5de4494d drivers/media/v4l2-core/v4l2-compat-ioctl32.c Arnd Bergmann
2019-12-16 746enum v4l2_memory memory;
342027c5de4494d drivers/media/v4l2-core/v4l2-compat-ioctl32.c Arnd Bergmann
2019-12-16 747struct v4l2_plane32 __user *uplane32;
342027c5de4494d drivers/media/v4l2-core/v4l2-compat-ioctl32.c Arnd Bergmann
2019-12-16 748struct v4l2_plane __user *uplane;
342027c5de4494d drivers/media/v4l2-core/v4l2-compat-ioctl32.c Arnd Bergmann
2019-12-16 749compat_caddr_t p;
342027c5de4494d drivers/media/v4l2-core/v4l2-compat-ioctl32.c Arnd Bergmann
2019-12-16 750int ret;
342027c5de4494d drivers/media/v4l2-core/v4l2-compat-ioctl32.c Arnd Bergmann
2019-12-16 751
342027c5de4494d drivers/media/v4l2-core/v4l2-compat-ioctl32.c Arnd Bergmann
2019-12-16 752if (!access_ok(p32, sizeof(*p32)) ||
342027c5de4494d drivers/media/v4l2-core/v4l2-compat-ioctl32.c Arnd Bergmann
2019-12-16 753assign_in_user(>index, >index) ||
342027c5de4494d drivers/media/v4l2-core/v4l2-compat-ioctl32.c Arnd Bergmann
2019-12-16 754get_user(type, >type) ||
342027c5de4494d drivers/media/v4l2-core/v4l2-compat-ioctl32.c Arnd Bergmann
2019-12-16 755put_user(type, >type) ||
342027c5de4494d drivers/media/v4l2-core/v4l2-compat-ioctl32.c Arnd Bergmann
2019-12-16 756assign_in_user(>flags, >flags) ||
342027c5de4494d drivers/media/v4l2-core/v4l2-compat-ioctl32.c Arnd Bergmann
2019-12-16 757get_user(memory, >memory) ||
342027c5de4494d drivers/media/v4l2-core/v4l2-compat-ioctl32.c Arnd Bergmann
2019-12-16 758put_user(memory, >memory) ||
342027c5de4494d drivers/media/v4l2-core/v4l2-compat-ioctl32.c Arnd Bergmann
2019-12-16 759get_user(length, >length) ||
342027c5de4494d drivers/media/v4l2-core/v4l2-compat-ioctl32.c Arnd Bergmann
2019-12-16 760put_user(length, >length) ||
342027c5de4494d drivers/media/v4l2-core/v4l2-compat-ioctl32.c Arnd Bergmann
2019-12-16 761get_user(request_fd, >request_fd) ||
342027c5de4494d drivers/media/v4l
[kbuild] [jkirsher-next-queue:dev-queue 19/99] drivers/net/ethernet/intel/i40e/i40e_xsk.c:183:6: sparse: the previous one is here
CC: kbuild-...@lists.01.org
CC: Intel Wired LAN
TO: Jesper Dangaard Brouer
CC: Jeff Kirsher
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git
dev-queue
head: 5950d1e508b225372208a78339e6434adf129852
commit: b530c4dd1d0830c45139e65808038373cc54ebc8 [19/99] i40e: trivial fixup of
comments in i40e_xsk.c
:: branch date: 9 hours ago
:: commit date: 9 hours ago
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-193-gb8fad4bc-dirty
git checkout b530c4dd1d0830c45139e65808038373cc54ebc8
# save the attached .config to linux build tree
make W=1 C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
drivers/net/ethernet/intel/i40e/i40e_xsk.c:234:6: sparse: sparse: multiple
definitions for function 'i40e_alloc_rx_buffers_zc'
>> drivers/net/ethernet/intel/i40e/i40e_xsk.c:183:6: sparse: the previous one
>> is here
drivers/net/ethernet/intel/i40e/i40e_xsk.c:236:16: sparse: sparse: undefined
identifier '__i40e_alloc_rx_buffers_zc'
drivers/net/ethernet/intel/i40e/i40e_xsk.c:252:16: sparse: sparse: undefined
identifier '__i40e_alloc_rx_buffers_zc'
drivers/net/ethernet/intel/i40e/i40e_xsk.c:302:15: sparse: sparse: no member
'addr' in struct i40e_rx_buffer
drivers/net/ethernet/intel/i40e/i40e_xsk.c:302:30: sparse: sparse: no member
'addr' in struct i40e_rx_buffer
drivers/net/ethernet/intel/i40e/i40e_xsk.c:303:15: sparse: sparse: no member
'handle' in struct i40e_rx_buffer
drivers/net/ethernet/intel/i40e/i40e_xsk.c:303:32: sparse: sparse: no member
'handle' in struct i40e_rx_buffer
drivers/net/ethernet/intel/i40e/i40e_xsk.c:305:15: sparse: sparse: no member
'addr' in struct i40e_rx_buffer
drivers/net/ethernet/intel/i40e/i40e_xsk.c:320:19: sparse: sparse: no member
'zca' in struct i40e_ring
>> drivers/net/ethernet/intel/i40e/i40e_xsk.c:320:19: sparse: sparse: unknown
>> member
>> drivers/net/ethernet/intel/i40e/i40e_xsk.c:320:19: sparse: sparse: cast from
>> unknown type
drivers/net/ethernet/intel/i40e/i40e_xsk.c:322:33: sparse: sparse: no member
'chunk_mask' in struct xdp_umem
drivers/net/ethernet/intel/i40e/i40e_xsk.c:332:19: sparse: sparse: undefined
identifier 'xdp_umem_get_dma'
drivers/net/ethernet/intel/i40e/i40e_xsk.c:335:11: sparse: sparse: no member
'addr' in struct i40e_rx_buffer
drivers/net/ethernet/intel/i40e/i40e_xsk.c:335:20: sparse: sparse: undefined
identifier 'xdp_umem_get_data'
drivers/net/ethernet/intel/i40e/i40e_xsk.c:336:11: sparse: sparse: no member
'addr' in struct i40e_rx_buffer
drivers/net/ethernet/intel/i40e/i40e_xsk.c:338:11: sparse: sparse: no member
'handle' in struct i40e_rx_buffer
drivers/net/ethernet/intel/i40e/i40e_xsk.c:338:22: sparse: sparse: undefined
identifier 'xsk_umem_adjust_offset'
drivers/net/ethernet/intel/i40e/i40e_xsk.c:536:46: sparse: sparse: invalid
assignment: |=
#
https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git/commit/?id=b530c4dd1d0830c45139e65808038373cc54ebc8
git remote add jkirsher-next-queue
https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git
git remote update jkirsher-next-queue
git checkout b530c4dd1d0830c45139e65808038373cc54ebc8
vim +183 drivers/net/ethernet/intel/i40e/i40e_xsk.c
0a714186d3c0f7 Björn Töpel2018-08-28 182
3b4f0b66c2b3dc Björn Töpel2020-05-20 @183 bool
i40e_alloc_rx_buffers_zc(struct i40e_ring *rx_ring, u16 count)
0a714186d3c0f7 Björn Töpel2018-08-28 184 {
0a714186d3c0f7 Björn Töpel2018-08-28 185 u16 ntu =
rx_ring->next_to_use;
0a714186d3c0f7 Björn Töpel2018-08-28 186 union i40e_rx_desc
*rx_desc;
3b4f0b66c2b3dc Björn Töpel2020-05-20 187 struct xdp_buff **bi,
*xdp;
3b4f0b66c2b3dc Björn Töpel2020-05-20 188 dma_addr_t dma;
0a714186d3c0f7 Björn Töpel2018-08-28 189 bool ok = true;
0a714186d3c0f7 Björn Töpel2018-08-28 190
0a714186d3c0f7 Björn Töpel2018-08-28 191 rx_desc =
I40E_RX_DESC(rx_ring, ntu);
e1675f97367bed Björn Töpel2020-05-20 192 bi =
i40e_rx_bi(rx_ring, ntu);
0a714186d3c0f7 Björn Töpel2018-08-28 193 do {
3b4f0b66c2b3dc Björn Töpel2020-05-20 194 xdp =
xsk_buff_alloc(rx_ring->xsk_umem);
3b4f0b66c2b3dc Björn Töpel2020-05-20 195 if (!xdp) {
0a714186d3c0f7 Björn Töpel2018-08-28 196 ok =
false;
0a714186d3c0f7 Björn Töpel2018-08-28 197 goto
no_buffers;
0a714186d3c0f7 Björn Töpel2018-08-28 198 }
3b4f0b66c2b3dc Björn Töpel2020-05-20 199
[kbuild] Re: [PATCH] uio: disable lazy irq disable to avoid double fire
CC: kbuild-...@lists.01.org
In-Reply-To: <20200521144209.19413-1-thom...@gmail.com>
References: <20200521144209.19413-1-thom...@gmail.com>
TO: Thommy Jakobsson
TO: gre...@linuxfoundation.org
TO: linux-ker...@vger.kernel.org
CC: Thommy Jakobsson
Hi Thommy,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on linus/master linux/master v5.7-rc6 next-20200521]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Thommy-Jakobsson/uio-disable-lazy-irq-disable-to-avoid-double-fire/20200521-225755
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
c9d7e3da1f3c4cf5dddfc5d7ce4d76d013aba1cc
:: branch date: 2 days ago
:: commit date: 2 days ago
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/uio/uio_pdrv_genirq.c:185 uio_pdrv_genirq_probe() warn: passing devm_
allocated variable to kfree. 'priv'
#
https://github.com/0day-ci/linux/commit/c6460d7bd1fb8e3ff5aa0c252c37bbfcb9245367
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout c6460d7bd1fb8e3ff5aa0c252c37bbfcb9245367
vim +/priv +185 drivers/uio/uio_pdrv_genirq.c
eff1dd87fae244 Alexandru Ardelean 2020-03-06 109
c767db0ab4bc85 Magnus Damm2008-07-11 110 static int
uio_pdrv_genirq_probe(struct platform_device *pdev)
c767db0ab4bc85 Magnus Damm2008-07-11 111 {
08cb2e2148f763 Jingoo Han 2013-08-30 112 struct uio_info
*uioinfo = dev_get_platdata(>dev);
b0297622a9726b Daniel Mack2019-08-15 113 struct device_node
*node = pdev->dev.of_node;
c767db0ab4bc85 Magnus Damm2008-07-11 114 struct
uio_pdrv_genirq_platdata *priv;
c767db0ab4bc85 Magnus Damm2008-07-11 115 struct uio_mem *uiomem;
c767db0ab4bc85 Magnus Damm2008-07-11 116 int ret = -EINVAL;
c767db0ab4bc85 Magnus Damm2008-07-11 117 int i;
c767db0ab4bc85 Magnus Damm2008-07-11 118
b0297622a9726b Daniel Mack2019-08-15 119 if (node) {
b0297622a9726b Daniel Mack2019-08-15 120 const char
*name;
b0297622a9726b Daniel Mack2019-08-15 121
27760f86866331 Hans J. Koch 2011-07-07 122 /* alloc
uioinfo for one device */
e6789cd3dfb553 Michal Simek 2013-09-12 123 uioinfo =
devm_kzalloc(>dev, sizeof(*uioinfo),
e6789cd3dfb553 Michal Simek 2013-09-12 124
GFP_KERNEL);
27760f86866331 Hans J. Koch 2011-07-07 125 if (!uioinfo) {
27760f86866331 Hans J. Koch 2011-07-07 126
dev_err(>dev, "unable to kmalloc\n");
e6789cd3dfb553 Michal Simek 2013-09-12 127 return
-ENOMEM;
27760f86866331 Hans J. Koch 2011-07-07 128 }
b0297622a9726b Daniel Mack2019-08-15 129
b0297622a9726b Daniel Mack2019-08-15 130 if
(!of_property_read_string(node, "linux,uio-name", ))
b0297622a9726b Daniel Mack2019-08-15 131
uioinfo->name = devm_kstrdup(>dev, name, GFP_KERNEL);
b0297622a9726b Daniel Mack2019-08-15 132 else
b0297622a9726b Daniel Mack2019-08-15 133
uioinfo->name = devm_kasprintf(>dev, GFP_KERNEL,
b0297622a9726b Daniel Mack2019-08-15 134
"%pOFn", node);
b0297622a9726b Daniel Mack2019-08-15 135
27760f86866331 Hans J. Koch 2011-07-07 136
uioinfo->version = "devicetree";
27760f86866331 Hans J. Koch 2011-07-07 137 /* Multiple
IRQs are not supported */
27760f86866331 Hans J. Koch 2011-07-07 138 }
27760f86866331 Hans J. Koch 2011-07-07 139
c767db0ab4bc85 Magnus Damm2008-07-11 140 if (!uioinfo ||
!uioinfo->name || !uioinfo->version) {
c767db0ab4bc85 Magnus Damm2008-07-11 141
dev_err(>dev, "missing platform_data\n");
e6789cd3dfb553 Michal Simek 2013-09-12 142 return ret;
c767db0ab4bc85 Magnus Damm2008-07-11 143 }
c767db0ab4bc85 Magnus Damm2008-07-11 144
e543ae896626a5 Mike Frysinger 2008-10-29 145 if (uioinfo->handler ||
uioinfo->irqcontrol ||
e543ae8
[kbuild] Re: [RFC PATCH net-next 4/4] net: dp83869: Add RGMII internal delay configuration
CC: kbuild-...@lists.01.org
In-Reply-To: <20200521174834.3234-5-dmur...@ti.com>
References: <20200521174834.3234-5-dmur...@ti.com>
TO: Dan Murphy
Hi Dan,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on net-next/master]
[also build test WARNING on robh/for-next sparc-next/master net/master
linus/master v5.7-rc6 next-20200521]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Dan-Murphy/RGMII-Internal-delay-common-property/20200522-015509
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
de1b99ef2aa1e982c86b15853e013c6e3dbc1e7a
:: branch date: 2 days ago
:: commit date: 2 days ago
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
New smatch warnings:
drivers/net/phy/dp83869.c:221 dp83869_of_init() error: buffer overflow
'dp83869_internal_delay' 16 <= 16
Old smatch warnings:
drivers/net/phy/dp83869.c:231 dp83869_of_init() error: buffer overflow
'dp83869_internal_delay' 16 <= 16
#
https://github.com/0day-ci/linux/commit/c27cb3ace00f1b89679d6542f9ee2eb8faa76112
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout c27cb3ace00f1b89679d6542f9ee2eb8faa76112
vim +/dp83869_internal_delay +221 drivers/net/phy/dp83869.c
01db923e83779b Dan Murphy 2019-11-13 172
01db923e83779b Dan Murphy 2019-11-13 173 #ifdef CONFIG_OF_MDIO
01db923e83779b Dan Murphy 2019-11-13 174 static int dp83869_of_init(struct
phy_device *phydev)
01db923e83779b Dan Murphy 2019-11-13 175 {
01db923e83779b Dan Murphy 2019-11-13 176 struct dp83869_private *dp83869
= phydev->priv;
01db923e83779b Dan Murphy 2019-11-13 177 struct device *dev =
>mdio.dev;
01db923e83779b Dan Murphy 2019-11-13 178 struct device_node *of_node =
dev->of_node;
c27cb3ace00f1b Dan Murphy 2020-05-21 179 int delay_size =
ARRAY_SIZE(dp83869_internal_delay);
01db923e83779b Dan Murphy 2019-11-13 180 int ret;
01db923e83779b Dan Murphy 2019-11-13 181
01db923e83779b Dan Murphy 2019-11-13 182 if (!of_node)
01db923e83779b Dan Murphy 2019-11-13 183 return -ENODEV;
01db923e83779b Dan Murphy 2019-11-13 184
01db923e83779b Dan Murphy 2019-11-13 185 dp83869->io_impedance = -EINVAL;
01db923e83779b Dan Murphy 2019-11-13 186
01db923e83779b Dan Murphy 2019-11-13 187 /* Optional configuration */
01db923e83779b Dan Murphy 2019-11-13 188 ret =
of_property_read_u32(of_node, "ti,clk-output-sel",
01db923e83779b Dan Murphy 2019-11-13 189
>clk_output_sel);
01db923e83779b Dan Murphy 2019-11-13 190 if (ret ||
dp83869->clk_output_sel > DP83869_CLK_O_SEL_REF_CLK)
01db923e83779b Dan Murphy 2019-11-13 191 dp83869->clk_output_sel
= DP83869_CLK_O_SEL_REF_CLK;
01db923e83779b Dan Murphy 2019-11-13 192
01db923e83779b Dan Murphy 2019-11-13 193 ret =
of_property_read_u32(of_node, "ti,op-mode", >mode);
01db923e83779b Dan Murphy 2019-11-13 194 if (ret == 0) {
01db923e83779b Dan Murphy 2019-11-13 195 if (dp83869->mode <
DP83869_RGMII_COPPER_ETHERNET ||
01db923e83779b Dan Murphy 2019-11-13 196 dp83869->mode >
DP83869_SGMII_COPPER_ETHERNET)
01db923e83779b Dan Murphy 2019-11-13 197 return -EINVAL;
01db923e83779b Dan Murphy 2019-11-13 198 }
01db923e83779b Dan Murphy 2019-11-13 199
01db923e83779b Dan Murphy 2019-11-13 200 if
(of_property_read_bool(of_node, "ti,max-output-impedance"))
01db923e83779b Dan Murphy 2019-11-13 201 dp83869->io_impedance =
DP83869_IO_MUX_CFG_IO_IMPEDANCE_MAX;
01db923e83779b Dan Murphy 2019-11-13 202 else if
(of_property_read_bool(of_node, "ti,min-output-impedance"))
01db923e83779b Dan Murphy 2019-11-13 203 dp83869->io_impedance =
DP83869_IO_MUX_CFG_IO_IMPEDANCE_MIN;
01db923e83779b Dan Murphy 2019-11-13 204
01db923e83779b Dan Murphy 2019-11-13 205 if
(of_property_read_bool(of_node, "enet-phy-lane-swap"))
01db923e83779b Dan Murphy 2019-11-13 206 dp83869->port_mirroring
= DP83869_PORT_MIRRORING_EN;
01db923e83779b Dan Murphy 2019-11-13 207 else
01db923e83779b Dan Murphy 2019-11-13 208 dp83869->port_mirroring
= DP83869_PORT_MIRRORING_DIS;
01db923e83779b Dan Murphy 2019-11-13 209
01db923e83779b Dan Mur
[kbuild] [dhowells-fs:fscache-iter 41/61] fs/fscache/cookie.c:504 __fscache_invalidate() warn: inconsistent returns 'cookie->lock'.
CC: kbuild-...@lists.01.org
TO: David Howells
tree: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
fscache-iter
head: 59f33c90ef6c1a75d4af75e5f60d98c0d965b6a2
commit: 4d15b33ef7e1f76b879588e3104e5cc83299f229 [41/61] fscache, cachefiles:
Rewrite invalidation
:: branch date: 9 days ago
:: commit date: 9 days ago
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build):
git checkout 4d15b33ef7e1f76b879588e3104e5cc83299f229
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
New smatch warnings:
fs/fscache/cookie.c:504 __fscache_invalidate() warn: inconsistent returns
'cookie->lock'.
Old smatch warnings:
fs/fscache/cookie.c:416 fscache_attach_object() warn: argument 2 to %lx
specifier is cast from pointer
fs/fscache/cookie.c:416 fscache_attach_object() warn: argument 3 to %lx
specifier is cast from pointer
#
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/commit/?id=4d15b33ef7e1f76b879588e3104e5cc83299f229
git remote add dhowells-fs
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
git remote update dhowells-fs
git checkout 4d15b33ef7e1f76b879588e3104e5cc83299f229
vim +504 fs/fscache/cookie.c
ccc4fc3d11e914 David Howells 2009-04-03 473
ef778e7ae67cd4 David Howells 2012-12-20 474 /*
4d15b33ef7e1f7 David Howells 2020-02-06 475 * Invalidate an object.
ef778e7ae67cd4 David Howells 2012-12-20 476 */
4d15b33ef7e1f7 David Howells 2020-02-06 477 void __fscache_invalidate(struct
fscache_cookie *cookie,
4d15b33ef7e1f7 David Howells 2020-02-06 478 const void
*aux_data, loff_t new_size,
4d15b33ef7e1f7 David Howells 2020-02-06 479 unsigned int
flags)
ef778e7ae67cd4 David Howells 2012-12-20 480 {
4d15b33ef7e1f7 David Howells 2020-02-06 481struct fscache_object *object =
NULL;
4d15b33ef7e1f7 David Howells 2020-02-06 482
fc9bade4eccbd7 David Howells 2020-02-06 483_enter("{%s}",
cookie->type_name);
ef778e7ae67cd4 David Howells 2012-12-20 484
ef778e7ae67cd4 David Howells 2012-12-20 485
fscache_stat(_n_invalidates);
ef778e7ae67cd4 David Howells 2012-12-20 486
ef778e7ae67cd4 David Howells 2012-12-20 487/* Only permit invalidation of
data files. Invalidating an index will
ef778e7ae67cd4 David Howells 2012-12-20 488 * require the caller to
release all its attachments to the tree rooted
ef778e7ae67cd4 David Howells 2012-12-20 489 * there, and if it's doing
that, it may as well just retire the
ef778e7ae67cd4 David Howells 2012-12-20 490 * cookie.
ef778e7ae67cd4 David Howells 2012-12-20 491 */
c7444f2954ac78 David Howells 2020-05-02 492ASSERTCMP(cookie->type, !=,
FSCACHE_COOKIE_TYPE_INDEX);
ef778e7ae67cd4 David Howells 2012-12-20 493
13e34f199ebd59 David Howells 2020-02-06 494spin_lock(>lock);
4d15b33ef7e1f7 David Howells 2020-02-06 495fscache_update_aux(cookie,
aux_data, _size);
13e34f199ebd59 David Howells 2020-02-06 496cookie->zero_point = new_size;
4d15b33ef7e1f7 David Howells 2020-02-06 497
4d15b33ef7e1f7 David Howells 2020-02-06 498if
(!hlist_empty(>backing_objects)) {
4d15b33ef7e1f7 David Howells 2020-02-06 499object =
hlist_entry(cookie->backing_objects.first,
4d15b33ef7e1f7 David Howells 2020-02-06 500
struct fscache_object, cookie_link);
4d15b33ef7e1f7 David Howells 2020-02-06 501object->inval_counter++;
4d15b33ef7e1f7 David Howells 2020-02-06 502}
4d15b33ef7e1f7 David Howells 2020-02-06 503
4d15b33ef7e1f7 David Howells 2020-02-06 @504switch (cookie->stage) {
4d15b33ef7e1f7 David Howells 2020-02-06 505case
FSCACHE_COOKIE_STAGE_QUIESCENT:
4d15b33ef7e1f7 David Howells 2020-02-06 506case FSCACHE_COOKIE_STAGE_DEAD:
4d15b33ef7e1f7 David Howells 2020-02-06 507case
FSCACHE_COOKIE_STAGE_INITIALISING: /* Assume later checks will catch it */
4d15b33ef7e1f7 David Howells 2020-02-06 508case
FSCACHE_COOKIE_STAGE_INVALIDATING: /* is_still_valid will catch it */
4d15b33ef7e1f7 David Howells 2020-02-06 509
spin_unlock(>lock);
4d15b33ef7e1f7 David Howells 2020-02-06 510_leave(" [no %u]",
cookie->stage);
4d15b33ef7e1f7 David Howells 2020-02-06 511return;
4d15b33ef7e1f7 David Howells 2020-02-06 512
4d15b33ef7e1f7 David Howells 2020-02-06 513case
FSCACHE_COOKIE_STAGE_LOOKING_UP:
4d15b33ef7e1f7 David Howells 2020-02-06 514_leave(" [look %x]",
object->inval_counter);
4d15b33ef7e1f7 David Howells 2020-02-06 515return;
4d15b33ef7e1f7 David Howells 2020-02-06 516
4d15b33ef7e1f7 David Howells 2020-02-06 517case
FSCACHE_COOKIE_STAGE
[kbuild] [dhowells-fs:fscache-iter 21/61] fs/cachefiles/namei.c:300 cachefiles_walk_to_object() warn: signedness bug returning '(-105)'
CC: kbuild-...@lists.01.org
TO: David Howells
tree: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
fscache-iter
head: 59f33c90ef6c1a75d4af75e5f60d98c0d965b6a2
commit: 667b9011d562075c1d4e831862efa31f2f47fba0 [21/61] fscache: Replace the
object management state machine
:: branch date: 9 days ago
:: commit date: 9 days ago
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build):
git checkout 667b9011d562075c1d4e831862efa31f2f47fba0
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
New smatch warnings:
fs/cachefiles/namei.c:300 cachefiles_walk_to_object() warn: signedness bug
returning '(-105)'
fs/fscache/obj.c:27 fscache_do_alloc_object() warn: argument 2 to %lx specifier
is cast from pointer
fs/fscache/obj.c:165 fscache_lookup_object_chain() error: double unlocked
'cookie->lock' (orig line 131)
Old smatch warnings:
fs/fscache/obj.c:27 fscache_do_alloc_object() warn: argument 3 to %lx specifier
is cast from pointer
fs/fscache/obj.c:169 fscache_lookup_object_chain() error: double unlocked
'cookie->lock' (orig line 131)
#
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/commit/?id=667b9011d562075c1d4e831862efa31f2f47fba0
git remote add dhowells-fs
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
git remote update dhowells-fs
git checkout 667b9011d562075c1d4e831862efa31f2f47fba0
vim +300 fs/cachefiles/namei.c
667b9011d56207 David Howells2020-02-06 268
9ae326a69004de David Howells2009-04-03 269 /*
9ae326a69004de David Howells2009-04-03 270 * walk from the parent object
to the child object through the backing
9ae326a69004de David Howells2009-04-03 271 * filesystem, creating
directories as we go
9ae326a69004de David Howells2009-04-03 272 */
667b9011d56207 David Howells2020-02-06 273 bool
cachefiles_walk_to_object(struct cachefiles_object *parent,
9ae326a69004de David Howells2009-04-03 274
struct cachefiles_object *object,
5c65c4e759eafd David Howells2020-02-06 275
const char *key)
9ae326a69004de David Howells2009-04-03 276 {
9ae326a69004de David Howells2009-04-03 277 struct cachefiles_cache
*cache;
9ae326a69004de David Howells2009-04-03 278 struct dentry *dir,
*next = NULL;
a18feb55769b70 David Howells2018-04-04 279 struct inode *inode;
821404434f3324 David Howells2010-12-24 280 struct path path;
9ae326a69004de David Howells2009-04-03 281 unsigned long start;
9ae326a69004de David Howells2009-04-03 282 const char *name;
667b9011d56207 David Howells2020-02-06 283 bool marked = false,
negated = false;
9ae326a69004de David Howells2009-04-03 284 int ret, nlen;
9ae326a69004de David Howells2009-04-03 285
c61ea31dac0319 David Howells2010-05-11 286
_enter("OBJ%x{%p},OBJ%x,%s,",
c61ea31dac0319 David Howells2010-05-11 287
parent->fscache.debug_id, parent->dentry,
c61ea31dac0319 David Howells2010-05-11 288
object->fscache.debug_id, key);
9ae326a69004de David Howells2009-04-03 289
9ae326a69004de David Howells2009-04-03 290 cache =
container_of(parent->fscache.cache,
9ae326a69004de David Howells2009-04-03 291
struct cachefiles_cache, cache);
821404434f3324 David Howells2010-12-24 292 path.mnt = cache->mnt;
9ae326a69004de David Howells2009-04-03 293
9ae326a69004de David Howells2009-04-03 294 ASSERT(parent->dentry);
466b77bc954c23 David Howells2015-03-17 295
ASSERT(d_backing_inode(parent->dentry));
9ae326a69004de David Howells2009-04-03 296
e36cb0b89ce20b David Howells2015-01-29 297 if
(!(d_is_dir(parent->dentry))) {
9ae326a69004de David Howells2009-04-03 298 // TODO:
convert file to dir
9ae326a69004de David Howells2009-04-03 299 _leave("looking
up in none directory");
9ae326a69004de David Howells2009-04-03 @300 return -ENOBUFS;
9ae326a69004de David Howells2009-04-03 301 }
9ae326a69004de David Howells2009-04-03 302
9ae326a69004de David Howells2009-04-03 303 dir =
dget(parent->dentry);
9ae326a69004de David Howells2009-04-03 304
9ae326a69004de David Howells2009-04-03 305 advance:
9ae326a69004de David Howells2009-04-03 306 /* attempt to transit
the first directory component */
9ae326a69004de David Howells2009-04-03 307 name = key;
9ae326a69004de David Howells2009-04-03 308 nlen = strlen(key);
9ae326a6900
[kbuild] [linux-devel:devel-catchup-202005220530 3/3] drivers/soundwire/intel.c:809:33: sparse: sparse: unknown member
CC: kbuild-...@lists.01.org TO: "Pierre-Louis Bossart" tree: https://github.com/thesofproject/linux devel-catchup-202005220530 head: 2e9428fd0d1f29b48cdd226fd67bb8e2a1a10cbc commit: 99643a70e4da2e6cb09c6bc0558492cb48cb8d2c [3/3] Merge branch 'sound/upstream-20200521' into merge/sound-upstream-20200521 :: branch date: 23 hours ago :: commit date: 24 hours ago config: i386-allyesconfig (attached as .config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce: # apt-get install sparse # sparse version: v0.6.1-193-gb8fad4bc-dirty git checkout 99643a70e4da2e6cb09c6bc0558492cb48cb8d2c # save the attached .config to linux build tree make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) drivers/soundwire/intel.c:200:30: sparse: sparse: using member 'link_res' in incomplete struct sdw_intel drivers/soundwire/intel.c:201:30: sparse: sparse: using member 'link_res' in incomplete struct sdw_intel drivers/soundwire/intel.c:267:34: sparse: sparse: using member 'cdns' in incomplete struct sdw_intel drivers/soundwire/intel.c:272:12: sparse: sparse: using member 'debugfs' in incomplete struct sdw_intel drivers/soundwire/intel.c:274:57: sparse: sparse: using member 'debugfs' in incomplete struct sdw_intel drivers/soundwire/intel.c:277:35: sparse: sparse: using member 'cdns' in incomplete struct sdw_intel drivers/soundwire/intel.c:282:37: sparse: sparse: using member 'debugfs' in incomplete struct sdw_intel drivers/soundwire/intel.c:295:35: sparse: sparse: using member 'instance' in incomplete struct sdw_intel drivers/soundwire/intel.c:296:33: sparse: sparse: using member 'link_res' in incomplete struct sdw_intel drivers/soundwire/intel.c:297:29: sparse: sparse: using member 'link_res' in incomplete struct sdw_intel drivers/soundwire/intel.c:298:35: sparse: sparse: using member 'cdns' in incomplete struct sdw_intel drivers/soundwire/intel.c:306:9: sparse: sparse: using member 'link_res' in incomplete struct sdw_intel drivers/soundwire/intel.c:324:17: sparse: sparse: using member 'cdns' in incomplete struct sdw_intel drivers/soundwire/intel.c:328:17: sparse: sparse: using member 'cdns' in incomplete struct sdw_intel drivers/soundwire/intel.c:344:31: sparse: sparse: using member 'link_res' in incomplete struct sdw_intel drivers/soundwire/intel.c:346:31: sparse: sparse: using member 'link_res' in incomplete struct sdw_intel drivers/soundwire/intel.c:353:25: sparse: sparse: using member 'cdns' in incomplete struct sdw_intel drivers/soundwire/intel.c:361:25: sparse: sparse: using member 'cdns' in incomplete struct sdw_intel drivers/soundwire/intel.c:369:12: sparse: sparse: using member 'cdns' in incomplete struct sdw_intel drivers/soundwire/intel.c:371:25: sparse: sparse: using member 'link_res' in incomplete struct sdw_intel drivers/soundwire/intel.c:379:33: sparse: sparse: using member 'link_res' in incomplete struct sdw_intel drivers/soundwire/intel.c:380:35: sparse: sparse: using member 'instance' in incomplete struct sdw_intel drivers/soundwire/intel.c:409:35: sparse: sparse: using member 'instance' in incomplete struct sdw_intel drivers/soundwire/intel.c:410:33: sparse: sparse: using member 'link_res' in incomplete struct sdw_intel drivers/soundwire/intel.c:429:33: sparse: sparse: using member 'link_res' in incomplete struct sdw_intel drivers/soundwire/intel.c:430:35: sparse: sparse: using member 'instance' in incomplete struct sdw_intel drivers/soundwire/intel.c:434:9: sparse: sparse: using member 'link_res' in incomplete struct sdw_intel drivers/soundwire/intel.c:461:25: sparse: sparse: using member 'link_res' in incomplete struct sdw_intel drivers/soundwire/intel.c:468:33: sparse: sparse: using member 'link_res' in incomplete struct sdw_intel drivers/soundwire/intel.c:469:35: sparse: sparse: using member 'instance' in incomplete struct sdw_intel drivers/soundwire/intel.c:472:9: sparse: sparse: using member 'link_res' in incomplete struct sdw_intel drivers/soundwire/intel.c:489:25: sparse: sparse: using member 'link_res' in incomplete struct sdw_intel drivers/soundwire/intel.c:495:35: sparse: sparse: using member 'instance' in incomplete struct sdw_intel drivers/soundwire/intel.c:496:33: sparse: sparse: using member 'link_res' in incomplete struct sdw_intel drivers/soundwire/intel.c:497:29: sparse: sparse: using member 'link_res' in incomplete struct sdw_intel drivers/soundwire/intel.c:500:9: sparse: sparse: using member 'link_res' in incomplete struct sdw_intel drivers/soundwire/intel.c:505:17: sparse: sparse: using member 'cdns' in incomplete struct sdw_intel drivers/soundwire/intel.c:512:17: sparse: sparse: using member 'cdns' in incomplete
[kbuild] drivers/usb/host/fhci-tds.c:325 fhci_td_transaction_confirm() error: we previously assumed 'pkt' could be null (see line 319)
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Rasmus Villemoes
CC: Li Yang
CC: Timur Tabi
Hi Rasmus,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 4286d192c803571e8ca43b0f1f8ea04d663a278a
commit: 5a35435ef4e6e4bd2aabd6706b146b298a9cffe5 soc: fsl: qe: remove PPC32
dependency from CONFIG_QUICC_ENGINE
date: 6 months ago
:: branch date: 3 hours ago
:: commit date: 6 months ago
config: powerpc64-randconfig-m001-20200521 (attached as .config)
compiler: powerpc-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 5a35435ef4e6e4bd2aabd6706b146b298a9cffe5
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
ARCH=powerpc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/usb/host/fhci-tds.c:325 fhci_td_transaction_confirm() error: we
previously assumed 'pkt' could be null (see line 319)
#
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5a35435ef4e6e4bd2aabd6706b146b298a9cffe5
git remote add linus
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout 5a35435ef4e6e4bd2aabd6706b146b298a9cffe5
vim +/pkt +325 drivers/usb/host/fhci-tds.c
236dd4d18f293e Anton Vorontsov 2009-01-10 267
236dd4d18f293e Anton Vorontsov 2009-01-10 268 /*
236dd4d18f293e Anton Vorontsov 2009-01-10 269 * Collect the submitted
frames and inform the application about them
48e34d0f4f357b Justin P. Mattock 2010-12-30 270 * It is also preparing the
TDs for new frames. If the Tx interrupts
48e34d0f4f357b Justin P. Mattock 2010-12-30 271 * are disabled, the
application should call that routine to get
236dd4d18f293e Anton Vorontsov 2009-01-10 272 * confirmation about the
submitted frames. Otherwise, the routine is
25985edcedea63 Lucas De Marchi 2011-03-30 273 * called from the interrupt
service routine during the Tx interrupt.
236dd4d18f293e Anton Vorontsov 2009-01-10 274 * In that case the
application is informed by calling the application
236dd4d18f293e Anton Vorontsov 2009-01-10 275 * specific
'fhci_transaction_confirm' routine
236dd4d18f293e Anton Vorontsov 2009-01-10 276 */
236dd4d18f293e Anton Vorontsov 2009-01-10 277 static void
fhci_td_transaction_confirm(struct fhci_usb *usb)
236dd4d18f293e Anton Vorontsov 2009-01-10 278 {
236dd4d18f293e Anton Vorontsov 2009-01-10 279struct endpoint *ep =
usb->ep0;
236dd4d18f293e Anton Vorontsov 2009-01-10 280struct packet *pkt;
236dd4d18f293e Anton Vorontsov 2009-01-10 281struct usb_td __iomem
*td;
236dd4d18f293e Anton Vorontsov 2009-01-10 282u16 extra_data;
236dd4d18f293e Anton Vorontsov 2009-01-10 283u16 td_status;
236dd4d18f293e Anton Vorontsov 2009-01-10 284u16 td_length;
236dd4d18f293e Anton Vorontsov 2009-01-10 285u32 buf;
236dd4d18f293e Anton Vorontsov 2009-01-10 286
236dd4d18f293e Anton Vorontsov 2009-01-10 287/*
236dd4d18f293e Anton Vorontsov 2009-01-10 288 * collect transmitted
BDs from the chip. The routine clears all BDs
236dd4d18f293e Anton Vorontsov 2009-01-10 289 * with R bit = 0 and
the pointer to data buffer is not NULL, that is
236dd4d18f293e Anton Vorontsov 2009-01-10 290 * BDs which point to
the transmitted data buffer
236dd4d18f293e Anton Vorontsov 2009-01-10 291 */
236dd4d18f293e Anton Vorontsov 2009-01-10 292while (1) {
236dd4d18f293e Anton Vorontsov 2009-01-10 293td =
ep->conf_td;
236dd4d18f293e Anton Vorontsov 2009-01-10 294td_status =
in_be16(>status);
236dd4d18f293e Anton Vorontsov 2009-01-10 295td_length =
in_be16(>length);
236dd4d18f293e Anton Vorontsov 2009-01-10 296buf =
in_be32(>buf_ptr);
236dd4d18f293e Anton Vorontsov 2009-01-10 297extra_data =
in_be16(>extra);
236dd4d18f293e Anton Vorontsov 2009-01-10 298
236dd4d18f293e Anton Vorontsov 2009-01-10 299/* check if the
TD is empty */
236dd4d18f293e Anton Vorontsov 2009-01-10 300if
(!(!(td_status & TD_R) && ((td_status & ~TD_W) || buf)))
236dd4d18f293e Anton Vorontsov 2009-01-10 301break;
236dd4d18f293e Anton Vorontsov 2009-01-10 302/* check if it
is a dummy buffer */
236dd4d18f293e Anton Vorontsov 2009-01-10 303else if ((buf
== DUMMY_BD_BUFFER) && !(td_status & ~TD_W))
236dd4d18f293e Anton Vorontsov 2009-01-10 304
[kbuild] [dsahern-linux:nexthops/del-group-03 4/7] net/ipv4/fib_trie.c:1575 fib_table_lookup() error: uninitialized symbol 'nhsel'.
CC: kbuild-...@lists.01.org
TO: David Ahern
tree: https://github.com/dsahern/linux nexthops/del-group-03
head: b8c06bc47e0a04603de20861b8d5f7291ff0bc12
commit: 063512a047f24cd25298dbb37ae1247a407dbdde [4/7] ipv4: Refactor nhc
evaluation in fib_table_lookup
:: branch date: 19 hours ago
:: commit date: 20 hours ago
config: x86_64-defconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build):
git checkout 063512a047f24cd25298dbb37ae1247a407dbdde
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
New smatch warnings:
net/ipv4/fib_trie.c:1575 fib_table_lookup() error: uninitialized symbol 'nhsel'.
Old smatch warnings:
net/ipv4/fib_trie.c:1454 fib_table_lookup() warn: potential spectre issue
'n->tnode' [w] (local cap)
net/ipv4/fib_trie.c:1454 fib_table_lookup() warn: possible spectre second half.
'__u.__val'
net/ipv4/fib_trie.c:1515 fib_table_lookup() warn: potential spectre issue
'pn->tnode' [r]
#
https://github.com/dsahern/linux/commit/063512a047f24cd25298dbb37ae1247a407dbdde
git remote add dsahern-linux https://github.com/dsahern/linux
git remote update dsahern-linux
git checkout 063512a047f24cd25298dbb37ae1247a407dbdde
vim +/nhsel +1575 net/ipv4/fib_trie.c
19baf839ff4a8d Robert Olsson 2005-06-21 1420
9f9e636d4f89f7 Alexander Duyck 2014-12-31 1421 /* Step 1: Travel to
the longest prefix match in the trie */
9f9e636d4f89f7 Alexander Duyck 2014-12-31 1422 for (;;) {
88bae7149a5e98 Alexander Duyck 2015-03-06 1423 index =
get_cindex(key, n);
9f9e636d4f89f7 Alexander Duyck 2014-12-31 1424
9f9e636d4f89f7 Alexander Duyck 2014-12-31 1425 /* This bit of
code is a bit tricky but it combines multiple
9f9e636d4f89f7 Alexander Duyck 2014-12-31 1426* checks into
a single check. The prefix consists of the
9f9e636d4f89f7 Alexander Duyck 2014-12-31 1427* prefix plus
zeros for the "bits" in the prefix. The index
9f9e636d4f89f7 Alexander Duyck 2014-12-31 1428* is the
difference between the key and this value. From
9f9e636d4f89f7 Alexander Duyck 2014-12-31 1429* this we can
actually derive several pieces of data.
71e8b67d0fdd2f Alexander Duyck 2015-03-04 1430* if (index
>= (1ul << bits))
9f9e636d4f89f7 Alexander Duyck 2014-12-31 1431* we have
a mismatch in skip bits and failed
b3832117b4b613 Alexander Duyck 2015-01-22 1432* else
b3832117b4b613 Alexander Duyck 2015-01-22 1433* we know
the value is cindex
71e8b67d0fdd2f Alexander Duyck 2015-03-04 1434*
71e8b67d0fdd2f Alexander Duyck 2015-03-04 1435* This check
is safe even if bits == KEYLENGTH due to the
71e8b67d0fdd2f Alexander Duyck 2015-03-04 1436* fact that we
can only allocate a node with 32 bits if a
71e8b67d0fdd2f Alexander Duyck 2015-03-04 1437* long is
greater than 32 bits.
9f9e636d4f89f7 Alexander Duyck 2014-12-31 1438*/
71e8b67d0fdd2f Alexander Duyck 2015-03-04 1439 if (index >=
(1ul << n->bits))
9f9e636d4f89f7 Alexander Duyck 2014-12-31 1440 break;
19baf839ff4a8d Robert Olsson 2005-06-21 1441
9f9e636d4f89f7 Alexander Duyck 2014-12-31 1442 /* we have
found a leaf. Prefixes have already been compared */
9f9e636d4f89f7 Alexander Duyck 2014-12-31 1443 if (IS_LEAF(n))
a07f5f508a4d97 Stephen Hemminger 2008-01-22 1444 goto
found;
19baf839ff4a8d Robert Olsson 2005-06-21 1445
9f9e636d4f89f7 Alexander Duyck 2014-12-31 1446 /* only record
pn and cindex if we are going to be chopping
9f9e636d4f89f7 Alexander Duyck 2014-12-31 1447* bits later.
Otherwise we are just wasting cycles.
19baf839ff4a8d Robert Olsson 2005-06-21 1448*/
5405afd1a30620 Alexander Duyck 2014-12-31 1449 if (n->slen >
n->pos) {
9f9e636d4f89f7 Alexander Duyck 2014-12-31 1450 pn = n;
9f9e636d4f89f7 Alexander Duyck 2014-12-31 1451 cindex
= index;
9f9e636d4f89f7 Alexander Duyck 2014-12-31 1452 }
19baf839ff4a8d Robert Olsson 2005-06-21 1453
754baf8decce72 Alexander Duyck 2015-03-06 1454 n =
get_child_rcu(n, index);
9f9e636d4f89f7 Alexander Duyck 2014-12-31 1455 if
(unlikely(!n))
19baf839ff4a8d Robert Olsson 2005-06-21 1456 goto
backtrace;
19baf839ff4a8d Robert Olsson 2005-06-21 1457 }
19baf839ff4a8d Robert Olsson 2005-06-21 1458
9f9e636d4f89f7 Alexander Duyck 2014
[kbuild] drivers/power/supply/max17040_battery.c:205:7-32: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Matheus Castello
CC: Sebastian Reichel
CC: Krzysztof Kozlowski
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 051143e1602d90ea71887d92363edd539d411de5
commit: 2e17ed94de68953b17ed91b64f4bd176cdf38ad4 power: supply: max17040: Add
IRQ handler for low SOC alert
date: 5 months ago
:: branch date: 14 hours ago
:: commit date: 5 months ago
config: sh-randconfig-c003-20200521 (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 2e17ed94de68953b17ed91b64f4bd176cdf38ad4
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
Reported-by: Julia Lawall
coccinelle warnings: (new ones prefixed by >>)
>> drivers/power/supply/max17040_battery.c:205:7-32: ERROR: Threaded IRQ with
>> no primary handler requested without IRQF_ONESHOT
#
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2e17ed94de68953b17ed91b64f4bd176cdf38ad4
git remote add linus
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout 2e17ed94de68953b17ed91b64f4bd176cdf38ad4
vim +205 drivers/power/supply/max17040_battery.c
2e17ed94de6895 Matheus Castello 2019-12-05 197
2e17ed94de6895 Matheus Castello 2019-12-05 198 static int
max17040_enable_alert_irq(struct max17040_chip *chip)
2e17ed94de6895 Matheus Castello 2019-12-05 199 {
2e17ed94de6895 Matheus Castello 2019-12-05 200 struct i2c_client
*client = chip->client;
2e17ed94de6895 Matheus Castello 2019-12-05 201 unsigned int flags;
2e17ed94de6895 Matheus Castello 2019-12-05 202 int ret;
2e17ed94de6895 Matheus Castello 2019-12-05 203
2e17ed94de6895 Matheus Castello 2019-12-05 204 flags =
IRQF_TRIGGER_FALLING | IRQF_ONESHOT;
2e17ed94de6895 Matheus Castello 2019-12-05 @205 ret =
devm_request_threaded_irq(>dev, client->irq, NULL,
2e17ed94de6895 Matheus Castello 2019-12-05 206
max17040_thread_handler, flags,
2e17ed94de6895 Matheus Castello 2019-12-05 207
chip->battery->desc->name, chip);
2e17ed94de6895 Matheus Castello 2019-12-05 208
2e17ed94de6895 Matheus Castello 2019-12-05 209 return ret;
2e17ed94de6895 Matheus Castello 2019-12-05 210 }
2e17ed94de6895 Matheus Castello 2019-12-05 211
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] Re: [PATCH v5 1/5] iommu/arm-smmu: add NVIDIA implementation for dual ARM MMU-500 usage
CC: kbuild-...@lists.01.org
In-Reply-To: <20200521233107.11968-2-vdu...@nvidia.com>
References: <20200521233107.11968-2-vdu...@nvidia.com>
TO: Krishna Reddy
Hi Krishna,
I love your patch! Perhaps something to improve:
[auto build test WARNING on 365f8d504da50feaebf826d180113529c9383670]
url:
https://github.com/0day-ci/linux/commits/Krishna-Reddy/Nvidia-Arm-SMMUv2-Implementation/20200522-073239
base:365f8d504da50feaebf826d180113529c9383670
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-193-gb8fad4bc-dirty
# save the attached .config to linux build tree
make C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
:: branch date: 12 hours ago
:: commit date: 12 hours ago
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
>> drivers/iommu/arm-smmu-nvidia.c:151:33: sparse: sparse: cast removes address
>> space '' of expression
#
https://github.com/0day-ci/linux/commit/74ddf19a83203af9193b1921e43fdc6dc68c8379
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 74ddf19a83203af9193b1921e43fdc6dc68c8379
vim +151 drivers/iommu/arm-smmu-nvidia.c
74ddf19a83203a Krishna Reddy 2020-05-21 128
74ddf19a83203a Krishna Reddy 2020-05-21 129 struct arm_smmu_device
*nvidia_smmu_impl_init(struct arm_smmu_device *smmu)
74ddf19a83203a Krishna Reddy 2020-05-21 130 {
74ddf19a83203a Krishna Reddy 2020-05-21 131unsigned int i;
74ddf19a83203a Krishna Reddy 2020-05-21 132struct nvidia_smmu *nsmmu;
74ddf19a83203a Krishna Reddy 2020-05-21 133struct resource *res;
74ddf19a83203a Krishna Reddy 2020-05-21 134struct device *dev = smmu->dev;
74ddf19a83203a Krishna Reddy 2020-05-21 135struct platform_device *pdev =
to_platform_device(smmu->dev);
74ddf19a83203a Krishna Reddy 2020-05-21 136
74ddf19a83203a Krishna Reddy 2020-05-21 137nsmmu = devm_kzalloc(smmu->dev,
sizeof(*nsmmu), GFP_KERNEL);
74ddf19a83203a Krishna Reddy 2020-05-21 138if (!nsmmu)
74ddf19a83203a Krishna Reddy 2020-05-21 139return ERR_PTR(-ENOMEM);
74ddf19a83203a Krishna Reddy 2020-05-21 140
74ddf19a83203a Krishna Reddy 2020-05-21 141nsmmu->smmu = *smmu;
74ddf19a83203a Krishna Reddy 2020-05-21 142/* Instance 0 is ioremapped by
arm-smmu.c */
74ddf19a83203a Krishna Reddy 2020-05-21 143nsmmu->num_inst = 1;
74ddf19a83203a Krishna Reddy 2020-05-21 144
74ddf19a83203a Krishna Reddy 2020-05-21 145for (i = 1; i <
MAX_SMMU_INSTANCES; i++) {
74ddf19a83203a Krishna Reddy 2020-05-21 146res =
platform_get_resource(pdev, IORESOURCE_MEM, i);
74ddf19a83203a Krishna Reddy 2020-05-21 147if (!res)
74ddf19a83203a Krishna Reddy 2020-05-21 148break;
74ddf19a83203a Krishna Reddy 2020-05-21 149nsmmu->bases[i] =
devm_ioremap_resource(dev, res);
74ddf19a83203a Krishna Reddy 2020-05-21 150if
(IS_ERR(nsmmu->bases[i]))
74ddf19a83203a Krishna Reddy 2020-05-21 @151return (struct
arm_smmu_device *)nsmmu->bases[i];
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] drivers/pci/controller/dwc/pcie-tegra194.c:1898:23: warning: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. See condition at line 1895. [shiftTooManyBitsSigned]
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Vidya Sagar
CC: Lorenzo Pieralisi
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: b85051e755b0e9d6dd8f17ef1da083851b83287d
commit: c57247f940e8ea13a0ec33378304dc3cdc5da4a8 PCI: tegra: Add support for
PCIe endpoint mode in Tegra194
date: 7 weeks ago
:: branch date: 25 hours ago
:: commit date: 7 weeks ago
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build):
git checkout c57247f940e8ea13a0ec33378304dc3cdc5da4a8
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
cppcheck warnings: (new ones prefixed by >>)
>> drivers/pci/controller/dwc/pcie-tegra194.c:1898:23: warning: Shifting signed
>> 32-bit value by 31 bits is implementation-defined behaviour. See condition
>> at line 1895. [shiftTooManyBitsSigned]
appl_writel(pcie, (1 << irq), APPL_MSI_CTRL_1);
^
drivers/pci/controller/dwc/pcie-tegra194.c:1895:19: note: Assuming that
condition 'irq>31' is not redundant
if (unlikely(irq > 31))
^
drivers/pci/controller/dwc/pcie-tegra194.c:1898:23: note: Shift
appl_writel(pcie, (1 << irq), APPL_MSI_CTRL_1);
^
#
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c57247f940e8ea13a0ec33378304dc3cdc5da4a8
git remote add linus
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout c57247f940e8ea13a0ec33378304dc3cdc5da4a8
vim +1898 drivers/pci/controller/dwc/pcie-tegra194.c
c57247f940e8ea Vidya Sagar 2020-03-03 1892
c57247f940e8ea Vidya Sagar 2020-03-03 1893 static int
tegra_pcie_ep_raise_msi_irq(struct tegra_pcie_dw *pcie, u16 irq)
c57247f940e8ea Vidya Sagar 2020-03-03 1894 {
c57247f940e8ea Vidya Sagar 2020-03-03 @1895 if (unlikely(irq > 31))
c57247f940e8ea Vidya Sagar 2020-03-03 1896 return -EINVAL;
c57247f940e8ea Vidya Sagar 2020-03-03 1897
c57247f940e8ea Vidya Sagar 2020-03-03 @1898 appl_writel(pcie, (1 << irq),
APPL_MSI_CTRL_1);
c57247f940e8ea Vidya Sagar 2020-03-03 1899
c57247f940e8ea Vidya Sagar 2020-03-03 1900 return 0;
c57247f940e8ea Vidya Sagar 2020-03-03 1901 }
c57247f940e8ea Vidya Sagar 2020-03-03 1902
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
