[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2024-05-03 Thread Francisco Pina Martins
https://bugs.kde.org/show_bug.cgi?id=446468

Francisco Pina Martins  changed:

   What|Removed |Added

 CC||stu...@pinamartins.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2024-04-06 Thread gianluca . pettinello
https://bugs.kde.org/show_bug.cgi?id=446468

--- Comment #35 from gianluca.pettine...@gmail.com  ---
I still believe it is inconsistent because the selection behaves differently if
the folder icon is of a regular folder or a hidden folder.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2024-04-04 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=446468

--- Comment #34 from Nate Graham  ---
The color it changes to will depend on your color scheme and/or accent color.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2024-04-02 Thread Rafael Lima
https://bugs.kde.org/show_bug.cgi?id=446468

--- Comment #33 from Rafael Lima  ---
O Plasma 6.0.3 I am now getting black icons instead of white.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2024-03-30 Thread King
https://bugs.kde.org/show_bug.cgi?id=446468

King  changed:

   What|Removed |Added

 CC||rayfinkle2008-...@yahoo.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2024-03-26 Thread Canoe
https://bugs.kde.org/show_bug.cgi?id=446468

Canoe  changed:

   What|Removed |Added

 CC||brokenca...@gmail.com

--- Comment #32 from Canoe  ---
Still an issue in Plasma 6.0.2.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2024-03-01 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=446468

Nate Graham  changed:

   What|Removed |Added

 CC||onurmerc...@proton.me

--- Comment #31 from Nate Graham  ---
*** Bug 482186 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2023-11-10 Thread gianluca . pettinello
https://bugs.kde.org/show_bug.cgi?id=446468

--- Comment #30 from gianluca.pettine...@gmail.com  ---
Hello all,
Will the new ocean breeze theme have the same white select folder? Btw if a
folder is hidden it does not get white. So it is an inconsistent behavior.
Thanks for an update
Gianluca

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2023-08-12 Thread Oliver Beard
https://bugs.kde.org/show_bug.cgi?id=446468

Oliver Beard  changed:

   What|Removed |Added

 CC||olib...@outlook.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2023-05-23 Thread Claudius
https://bugs.kde.org/show_bug.cgi?id=446468

--- Comment #29 from Claudius  ---
I had the Folder icon (default Breeze) turn completely black when I selected
the blue accent color from the palette in system settings. It looks a bit
broken then.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2023-05-23 Thread Claudius
https://bugs.kde.org/show_bug.cgi?id=446468

Claudius  changed:

   What|Removed |Added

 CC||claudius+kde@hausnetz.lette
   ||nbach.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2023-02-18 Thread popov895
https://bugs.kde.org/show_bug.cgi?id=446468

popov895  changed:

   What|Removed |Added

 CC|popov...@ukr.net|

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2023-02-17 Thread gianluca . pettinello
https://bugs.kde.org/show_bug.cgi?id=446468

--- Comment #28 from gianluca.pettine...@gmail.com  ---
Is there any update on this issue? If you could point me in the good code byte
I could spend some time trying to fix it. Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2023-01-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=446468

Nate Graham  changed:

   What|Removed |Added

 CC||nat...@upchur.ch

--- Comment #27 from Nate Graham  ---
*** Bug 463811 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2022-12-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=446468

Nate Graham  changed:

   What|Removed |Added

   Priority|HI  |NOR

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2022-12-09 Thread gianluca . pettinello
https://bugs.kde.org/show_bug.cgi?id=446468

--- Comment #26 from gianluca.pettine...@gmail.com  ---
I solved as suggested here by creating a local icon set slightly darker for the
folders, which by the way is even more awesome. After all why to have selection
and folder color the same?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2022-09-29 Thread medin
https://bugs.kde.org/show_bug.cgi?id=446468

--- Comment #25 from medin  ---
(In reply to Marco Martin from comment #23)
> personally i do like this look and behavior a lot, and i find much
> more pleasing than different options such added borders or shadows

The current solution is inconsistent because that white color is 
applied only to non hidden folders that have no thumbnails.

> It may be an actual thing that many people tend to not like coloring the
> folders with the highlight color in the first place

>From Windows to other Linux desktops, it seems that only KDE suffers from it,
so it's normal to be spotted people.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2022-09-28 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=446468

--- Comment #24 from Nate Graham  ---
Yeah that may be a good idea indeed. So we would have a
highlight/accent-color-respecting icon theme and a fixed-color icon theme.

Or maybe we could even simplify this to a checkbox in the KCM: "use
highlight/accent color for Folder backgrounds"

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2022-09-28 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=446468

Marco Martin  changed:

   What|Removed |Added

 CC||notm...@gmail.com

--- Comment #23 from Marco Martin  ---
to me different approaches like not having the highlight over the icon or
adding a shadow (which would have to be reimplemented separatedly over and over
again in dolphin, open dialogs and many other apps as item delegates are often
custom code, so consistency would suffer) look significantly worse.

whether the white folder is a thing good or bad, to me is largely a matter of
taste (personally i do like this look and behavior a lot, and i find much more
pleasing than different options such added borders or shadows)
And is indeed more readable than before.

It may be an actual thing that many people tend to not like coloring the
folders with the highlight color in the first place. The very same thing was
actually done once already in the early 5.x lifecycle, and was quickly reverted
due to backlash, most people being ok with it but those that weren't were VERY
vocal.

I'm wondering if this should be configurable. The only way we would have to
configure it would actually be a different icon theme with *only* the folder
icons which would have non themeable colors, that would fallback to normal
breeze for everything else.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2022-09-11 Thread gianluca . pettinello
https://bugs.kde.org/show_bug.cgi?id=446468

--- Comment #22 from gianluca.pettine...@gmail.com  ---
Any progress on this? Or can an expert point to the code where the code is
implemented?
Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2022-09-08 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=446468

Nate Graham  changed:

   What|Removed |Added

 Blocks||458885


Referenced Bugs:

https://bugs.kde.org/show_bug.cgi?id=458885
[Bug 458885] Meta-bug: problems caused by dynamic-color-scheme-aware Breeze
icons
-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2022-08-15 Thread gianluca . pettinello
https://bugs.kde.org/show_bug.cgi?id=446468

--- Comment #21 from gianluca.pettine...@gmail.com  ---
Another side effect of the bug is that when you are editing a line in dolphin,
all the other fields become white on white ie invisible.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2022-07-29 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=446468

Nate Graham  changed:

   What|Removed |Added

 CC||pos...@posteo.eu

--- Comment #20 from Nate Graham  ---
*** Bug 457197 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2022-04-12 Thread Bacteria
https://bugs.kde.org/show_bug.cgi?id=446468

Bacteria  changed:

   What|Removed |Added

 CC||dev.bacterios...@aleeas.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2022-04-11 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=446468

--- Comment #19 from Nate Graham  ---
If it's possible to do that, I'm all for it. However I think it would be very
technically challenging. This issue happens in the first place because we made
folder colors respect the color scheme. We don't currently have the ability to
say, "respect the color scheme when unselected, but apply this other appearance
when selected".

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2022-04-09 Thread James Graham
https://bugs.kde.org/show_bug.cgi?id=446468

James Graham  changed:

   What|Removed |Added

 CC||james.h.graham@protonmail.c
   ||om

--- Comment #18 from James Graham  ---
Created attachment 148067
  --> https://bugs.kde.org/attachment.cgi?id=148067=edit
Icons view with accent colour and folder darkening on selection

So I was looking at the icon view mode. When I use an accent colour (as apposed
to the default for the colour scheme) and select a folder, the folder iself is
darkened and only the text is highlighted would this not work well if made
universal for all modes and as default?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2022-04-09 Thread gianluca . pettinello
https://bugs.kde.org/show_bug.cgi?id=446468

--- Comment #17 from gianluca.pettine...@gmail.com  ---
(In reply to medin from comment #12)
> Created attachment 146158 [details]
> Dark shadow behind selected icons
Definitely the best solution

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2022-04-09 Thread gianluca . pettinello
https://bugs.kde.org/show_bug.cgi?id=446468

--- Comment #16 from gianluca.pettine...@gmail.com  ---
I think that the best solution is to dralw a dark shadow around the folder
icon. It is definitely more consistent with the desktop behaviour. Do you
agree?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2022-02-18 Thread Rafael Lima
https://bugs.kde.org/show_bug.cgi?id=446468

Rafael Lima  changed:

   What|Removed |Added

 CC||rafael.palma.l...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2022-02-14 Thread Matiee
https://bugs.kde.org/show_bug.cgi?id=446468

--- Comment #15 from Matiee  ---
So, here's what I understood:
#3daee9 is the default selection color in Breeze and Breeze Dark themes, so the
new accent color feature works by replacing this color with another one of
user's choice. Also, what's colored with the accent color becomes white upon
selection. And, because what's black also becomes white upon selection (which
includes not only text, but also the folder's decals), here's why the entire
folders icons become white (most definitely a bug).

For the ones seeking for a workaround:
- I've made a copy of all folder icons and used inkscape for just altering the
folder's standard blue shade, "#3daee9" to "#47b8f3" (the two colors are almost
indistinguishable to the eye);
- put the altered folder icons into "$HOME/.local/icons/breeze/places".

That's ugly, but simple and effective.

You can see what this looks like in the attachment here above; if you want you
can download it from https://www.pling.com/p/1709570

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2022-02-14 Thread Matiee
https://bugs.kde.org/show_bug.cgi?id=446468

--- Comment #14 from Matiee  ---
Created attachment 146747
  --> https://bugs.kde.org/attachment.cgi?id=146747=edit
Workaround for disabling folder colorization upon selection

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2022-02-13 Thread ariasuni
https://bugs.kde.org/show_bug.cgi?id=446468

ariasuni  changed:

   What|Removed |Added

 CC||pe...@hack-libre.org

--- Comment #13 from ariasuni  ---
Created attachment 146683
  --> https://bugs.kde.org/attachment.cgi?id=146683=edit
Example of only putting selection background behind name of file, but not icon

Is there a temporary workaround for that? I find this really ugly, and it’s not
a recolor because it changes the icon (e.g. folder-download) to a normal folder
icon, which «looks» particularly buggy to me.

Another possibility to fix this is to only color the file(/folder) name and not
the icon. It would be more coherent with the other views, and avoid other
contrast issues between selection color and other blue icons e.g. HTML file
icon; or with any other selection color and Breeze icons that.

I tried to mockup how it would look but it would need tweaking to accommodate
very short file name so that we can still see that they are selected.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2022-02-03 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=446468

Nate Graham  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=420241

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2022-02-02 Thread medin
https://bugs.kde.org/show_bug.cgi?id=446468

--- Comment #12 from medin  ---
Created attachment 146158
  --> https://bugs.kde.org/attachment.cgi?id=146158=edit
Dark shadow behind selected icons

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2022-02-02 Thread medin
https://bugs.kde.org/show_bug.cgi?id=446468

--- Comment #11 from medin  ---
In fact the problem is already solved on desktop by drawing dark shadow behind
icons, so why not apply same solution and add dark shadow behind the icons of
selected items.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2022-01-31 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=446468

kd3.mat...@reborn.com changed:

   What|Removed |Added

 CC||kd3.mat...@reborn.com

--- Comment #10 from kd3.mat...@reborn.com ---
(In reply to Nate Graham from comment #6)
> Unsure what to do about this one.
> 
> It turns white because *everything* using the highlight color turns white
> when its list item is highlighted. So if we didn't do this, the icon would
> be very difficult to distinguish from the selection background. Which it was
> before.
> 
> On the other hand, I agree that it looks rather ugly right now. So
> apparently people preferred the old state that was technically more buggy.

Well, calling it "more buggy" implies that it makes sense for the folder icons
to follow the selection/accent color... But it doesn't, because of the current
design of the icon itself, which is only distinguishable from the background by
its color.

Also, accent colors are very nice, but also "stronger" than the default blue
selection: I feel that imposing them to folders (which are by far the most
common icons on the screen) is "too much" and less easy on the eye.

At least in the absence of a real solution, I'd rather not change the folders'
color at all.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2022-01-29 Thread gianluca . pettinello
https://bugs.kde.org/show_bug.cgi?id=446468

--- Comment #9 from gianluca.pettine...@gmail.com  ---
In reply to Nate: maybe a good solution is to draw a white or black shadowed
border on the icon to not have it merged with the selection

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2022-01-29 Thread medin
https://bugs.kde.org/show_bug.cgi?id=446468

--- Comment #8 from medin  ---
Created attachment 146036
  --> https://bugs.kde.org/attachment.cgi?id=146036=edit
Change selection color

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2022-01-29 Thread medin
https://bugs.kde.org/show_bug.cgi?id=446468

--- Comment #7 from medin  ---
(In reply to Nate Graham from comment #6)
> Unsure what to do about this one.

I'm not a designer but from a user point of view there are 3 choices : 

First, for the user eyes the selection is primarily marked by the blue
highlighting color that includes the whole icon + FileName, so changing the
icon color for a selection has no great signification to selection process, but
letting it blue really blends badly the whole highlighting and icon colors.

Second which I consider to be more consistent is to include all other icons
whether they are hidden or containing previews, the only small annoyance that
can be seen is that selected hidden items will have the same icon color as non
hidden and if any preview has white color it will be difficult to see.

Third, From my point of view the real problem is the mistake of choosing the
same color for icons and highlighting selected items. A more solid solution
would require whole change of Plasma UI colors by changing selection color (see
attached image).

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 446468] Selected folder icon becomes white in selected list items

2022-01-28 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=446468

Nate Graham  changed:

   What|Removed |Added

Summary|Selected folder icon|Selected folder icon
   |becomes white in Compact or |becomes white in selected
   |Details view|list items

--- Comment #6 from Nate Graham  ---
Unsure what to do about this one.

It turns white because *everything* using the highlight color turns white when
its list item is highlighted. So if we didn't do this, the icon would be very
difficult to distinguish from the selection background. Which it was before.

On the other hand, I agree that it looks rather ugly right now. So apparently
people preferred the old state that was technically more buggy.

-- 
You are receiving this mail because:
You are watching all bug changes.