[Elisa] [Bug 470529] "cover.jpg" file not recognized for use as album art
https://bugs.kde.org/show_bug.cgi?id=470529 Nate Graham changed: What|Removed |Added Latest Commit||https://invent.kde.org/mult ||imedia/elisa/-/commit/a0983 ||ce9fa429603683f5c2dc1a892f9 ||e2894742 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #8 from Nate Graham --- Git commit a0983ce9fa429603683f5c2dc1a892f9e2894742 by Nate Graham, on behalf of Jack Hill. Committed on 27/06/2023 at 19:38. Pushed by ngraham into branch 'master'. Prioritise exact string match when searching for cover files Previously we would search for globs like "*cover*", which would rank "case cover back inner.jpg" higher than "cover.jpg". Now we set exact matches to "cover", "coverimage", "folder", and "albumart" to the highest priority. A +---autotests/data/cover_art/artist1/album3/abc_folder.jpg A +3-0autotests/data/cover_art/artist1/album3/abc_folder.jpg.license M +6-1autotests/filescannertest.cpp M +14 -0src/filescanner.cpp https://invent.kde.org/multimedia/elisa/-/commit/a0983ce9fa429603683f5c2dc1a892f9e2894742 -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 470529] "cover.jpg" file not recognized for use as album art
https://bugs.kde.org/show_bug.cgi?id=470529 --- Comment #7 from Jack Hill --- I think this behaviour is not what people expect, so I would call it a bug. I have submitted a merge request (which is linked in this bug report) so the issue should be fixed shortly. On 26 June 2023 21:07:56 BST, bugzilla_nore...@kde.org wrote: >https://bugs.kde.org/show_bug.cgi?id=470529 > >--- Comment #6 from paninomaninod...@gmail.com --- >(In reply to Jack Hill from comment #3) >> When you say that the file name was "Case Cover Back Inner", did this have a >> jpg or png file extension? >> >> If it was .jpg, then I think the problem is that Elisa scans images with the >> glob "*[Cc]over*.jpg". So if you had the files "Case Cover Back Inner.jpg" >> and "cover.jpg" then the first match would be "Case Cover Back Inner.jpg", >> and so Elisa would use that as the cover image. > >This explains a lot... >How would I know. > >So it's not a "bug", it's just that the way Elisa works internally is >"obscure"? > >-- >You are receiving this mail because: >You are on the CC list for the bug. -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 470529] "cover.jpg" file not recognized for use as album art
https://bugs.kde.org/show_bug.cgi?id=470529 --- Comment #6 from paninomaninod...@gmail.com --- (In reply to Jack Hill from comment #3) > When you say that the file name was "Case Cover Back Inner", did this have a > jpg or png file extension? > > If it was .jpg, then I think the problem is that Elisa scans images with the > glob "*[Cc]over*.jpg". So if you had the files "Case Cover Back Inner.jpg" > and "cover.jpg" then the first match would be "Case Cover Back Inner.jpg", > and so Elisa would use that as the cover image. This explains a lot... How would I know. So it's not a "bug", it's just that the way Elisa works internally is "obscure"? -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 470529] "cover.jpg" file not recognized for use as album art
https://bugs.kde.org/show_bug.cgi?id=470529 --- Comment #5 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/468 -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 470529] "cover.jpg" file not recognized for use as album art
https://bugs.kde.org/show_bug.cgi?id=470529 Bug Janitor Service changed: What|Removed |Added Status|NEEDSINFO |ASSIGNED Resolution|WAITINGFORINFO |--- Ever confirmed|0 |1 --- Comment #4 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/468 -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 470529] "cover.jpg" file not recognized for use as album art
https://bugs.kde.org/show_bug.cgi?id=470529 Jack Hill changed: What|Removed |Added CC||jackhill3...@gmail.com --- Comment #3 from Jack Hill --- When you say that the file name was "Case Cover Back Inner", did this have a jpg or png file extension? If it was .jpg, then I think the problem is that Elisa scans images with the glob "*[Cc]over*.jpg". So if you had the files "Case Cover Back Inner.jpg" and "cover.jpg" then the first match would be "Case Cover Back Inner.jpg", and so Elisa would use that as the cover image. -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 470529] "cover.jpg" file not recognized for use as album art
https://bugs.kde.org/show_bug.cgi?id=470529 --- Comment #2 from paninomaninod...@gmail.com --- (In reply to Nate Graham from comment #1) > Elisa does already do this. I guess that means something about it isn't > working for you. Can you attach a screenshot of the folder contents for the > album in question that shows the song files and also the cover art file? You're right, Elisa already does this, just not in the way I was expecting. Problem is, apparently Elisa does not accept jpg images to use as cover album. I discovery this when I accidentally put a png inside a folder and Elisa picked that png as cover... which lead to another problem. Once Elisa picks an image as cover album you can't change the image? When I removed the wrong png image and substituted it with another png image that I wanted to use, Elisa did nothing. The album was stuck with the wrong cover art. I insisted and restarted Elisa database rescaning everything, but Elisa still didn't updated the album art for on that folder. Finally today I got Elisa to change the album art to the one I wanted, that's why I'm back, but still... I don't understand how Elisa works. There were another images on that folder, scans related to the CD case. One of them was the original wrong image that Elisa picked when I made a copy, converted from jpg to png and renamed it "cover". The name of that image is "Case Cover Back Inner". Now, I named it to "Case Cover Back Inner 2" and made a copy of image I wanted to use and renamed it to "Case Cover Back Inner". This worked. Why? Why didn't Elisa used a image with that name before? I removed the new "Case Cover Back Inner" image to make use Elisa didn't had picked the other identical "cover.png" inside the folder, but this made the album art vanish. I put the new "Case Cover Back Inner" back inside the folder and the album art came back. It's not clear what pattern Elisa follows to select the album art that you manually puts inside the folders. Will Elisa refuse to use imagens simply name "cover" again if there are other imagens inside the folder? I hope this is a one off "bug" (is it a bug? No idea). -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 470529] "cover.jpg" file not recognized for use as album art
https://bugs.kde.org/show_bug.cgi?id=470529 Nate Graham changed: What|Removed |Added Summary|Search for "cover.jpg" |"cover.jpg" file not |files inside folders to use |recognized for use as album |as album art|art Status|REPORTED|NEEDSINFO Resolution|--- |WAITINGFORINFO CC||n...@kde.org Severity|wishlist|normal --- Comment #1 from Nate Graham --- Elisa does already do this. I guess that means something about it isn't working for you. Can you attach a screenshot of the folder contents for the album in question that shows the song files and also the cover art file? -- You are receiving this mail because: You are watching all bug changes.
