[Spectacle] [Bug 391299] Rectangular Region: Remember selected area by default
https://bugs.kde.org/show_bug.cgi?id=391299 Nate Graham changed: What|Removed |Added Version Fixed In||19.04.0 Latest Commit|https://commits.kde.org/spe |https://commits.kde.org/spe |ctacle/ce977bc0a3e6d16fcb0b |ctacle/4c2cedbe25d35223a96f |af0c18072d67149418e7|cc8bdb37bbb7aa5048e3 --- Comment #13 from Nate Graham --- Git commit 4c2cedbe25d35223a96fcc8bdb37bbb7aa5048e3 by Nate Graham, on behalf of David Redondo. Committed on 18/02/2019 at 20:05. Pushed by ngraham into branch 'master'. Change default behavior to remembering the selected region until Spectacle is closed Summary: Change the default to remembering the selected region until the next restart while still preserving the old behavior if a user had previously selected "remember region" which worked across restarts. FIXED-IN: 19.04.0 Reviewers: #spectacle, #vdg, ngraham Reviewed By: #spectacle, #vdg, ngraham Subscribers: #spectacle Tags: #spectacle Differential Revision: https://phabricator.kde.org/D19130 M +3-2src/SpectacleConfig.cpp https://commits.kde.org/spectacle/4c2cedbe25d35223a96fcc8bdb37bbb7aa5048e3 -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 391299] Rectangular Region: Remember selected area by default
https://bugs.kde.org/show_bug.cgi?id=391299 Nate Graham changed: What|Removed |Added Status|CONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/spe ||ctacle/ce977bc0a3e6d16fcb0b ||af0c18072d67149418e7 Resolution|--- |FIXED --- Comment #12 from Nate Graham --- Git commit ce977bc0a3e6d16fcb0baf0c18072d67149418e7 by Nate Graham, on behalf of David Redondo. Committed on 18/02/2019 at 19:03. Pushed by ngraham into branch 'master'. Add option to remember rectangular region until next restart Summary: This adds an option to rememeber the last rectangular region until the next restart. If the user previously had selected the old remember region checkbox the "remember across restarts will be selected" to preserve the old behavior. Also reorganised the settings page a bit. Something to think about is changing the "General" settings page to one specific to rectangular region as it contains only options for it. Old:{F6621352} New:{F6621355} Reviewers: #spectacle, #vdg, ngraham Reviewed By: #spectacle, #vdg, ngraham Subscribers: ngraham, #spectacle Tags: #spectacle Differential Revision: https://phabricator.kde.org/D19117 M +30 -9src/Gui/SettingsDialog/GeneralOptionsPage.cpp M +3-1src/Gui/SettingsDialog/GeneralOptionsPage.h M +12 -0src/SpectacleConfig.cpp M +3-0src/SpectacleConfig.h M +6-0src/SpectacleCore.cpp https://commits.kde.org/spectacle/ce977bc0a3e6d16fcb0baf0c18072d67149418e7 -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 391299] Rectangular Region: Remember selected area by default
https://bugs.kde.org/show_bug.cgi?id=391299 Vladimír Vondruš changed: What|Removed |Added CC||mo...@centrum.cz -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 391299] Rectangular Region: Remember selected area by default
https://bugs.kde.org/show_bug.cgi?id=391299 --- Comment #11 from Henrik Fehlauer --- > it displays *a* selection rectangle by default, > not that it remembers the last selection rectangle Your concern was about the initial selection rectangle as such, how the initial size is determined has nothing to do with this. >> KSnapshot, which remembered the region until restart of the app. > That I didn't know, and it's very relevant information. It's not as if I didn't mention this in Comment 1… >> Alternative proposal for a combobox or radiobuttons in the settings dialog > I like this idea. Let's do it. Glad to hear that. -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 391299] Rectangular Region: Remember selected area by default
https://bugs.kde.org/show_bug.cgi?id=391299 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |CONFIRMED --- Comment #10 from Nate Graham --- I haven't used the macOS Mojave developer preview yet, but what that video appears to show is that it displays *a* selection rectangle by default, not that it remembers the last selection rectangle you last used (I am making this guess because it's a pattern used in other macOS Software too: show a rect by default, but don't remember the last-used one). > - There were no complaints in KSnapshot, which remembered the region until > a restart of the app. That I didn't know, and it's very relevant information. If it's what our users expect based on prior behavior, the requests make a lot more sense now. > Alternative proposal for a combobox or radiobuttons in the settings dialog > (wording not final): > - Remember region until restart (default, like KSnaphot) > - Remember region across restarts > - Do not remember region I like this idea. Let's do it. -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 391299] Rectangular Region: Remember selected area by default
https://bugs.kde.org/show_bug.cgi?id=391299 --- Comment #9 from Henrik Fehlauer --- BTW, as far as I can tell from https://youtu.be/4fWzNFzGjXk?t=193, the new macOS screenshot interface seems to also display a rectangle by default, without having to drag the cursor around. (Please confirm whether that's the case, or it was simply due to the editing of that video.) -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 391299] Rectangular Region: Remember selected area by default
https://bugs.kde.org/show_bug.cgi?id=391299 --- Comment #8 from Henrik Fehlauer --- > The reason why I'm not in favor of turning this on by default is that it's > not expected behavior, nor is it obvious to average users that they can > simply replace the existing selection box by clicking and dragging > a new one. I disagree, and I think you are ignoring the following facts: - People are often asking for it (see duplicate, where people say creating new selections would not become too difficult when I asked). - There were no complaints in KSnapshot, which remembered the region until a restart of the app. > Another option would be to make the checkbox to turn off remembering > easily accessible in the overlay UI I now tried to fit this into the existing overlay UI, and I'm very unhappy in how that turned out: It added bloat, it looked quite out-of-place, felt unnatural and most of all at that stage (i.e. when you already restarted capturing) it is too late, we already forgot the previous size. Nobody will see and check the box when taking the first screenshot, but everybody will get frustrated once they realized they should have checked the box before taking the second screenshot. --- > I'm in favor of making the feature more discoverable > for the people who would benefit from it. Alternative proposal for a combobox or radiobuttons in the settings dialog (wording not final): - Remember region until restart (default, like KSnaphot) - Remember region across restarts - Do not remember region This would have the following advantages: - The novice users you are targetting only ever take a single screenshot, and would not be affected at all. - People taking multiple screenshots in the same session for comparison purposes would get what they expect. - Everybody else can get exactly what they want by changing the setting. -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 391299] Rectangular Region: Remember selected area by default
https://bugs.kde.org/show_bug.cgi?id=391299 Henrik Fehlauer changed: What|Removed |Added CC||musik...@hotmail.com --- Comment #7 from Henrik Fehlauer --- *** Bug 397072 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 391299] Rectangular Region: Remember selected area by default
https://bugs.kde.org/show_bug.cgi?id=391299 --- Comment #6 from Nate Graham --- The reason why I'm not in favor of turning this on by default is that it's not expected behavior, nor is it obvious to average users that they can simply replace the existing selection box by clicking and dragging a new one. A lot of people will assume they need to resize and move the existing one, which is a much slower, more frustrating workflow. In short, I believe it would degrade the UX for people who do not use the feature. Like I said, I'm in favor of making the feature more discoverable for the people who would benefit from it. -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 391299] Rectangular Region: Remember selected area by default
https://bugs.kde.org/show_bug.cgi?id=391299 --- Comment #5 from Henrik Fehlauer --- >> Personally, I'm not in favor > Could you detail what the problem is if we did make it the default? So far > your commment does not contain anything we could try to tackle to make any > perceived problem go away. Ping. You are avoiding to analyse the root issue ;) -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 391299] Rectangular Region: Remember selected area by default
https://bugs.kde.org/show_bug.cgi?id=391299 --- Comment #4 from Nate Graham --- > Another option would be to make the checkbox to turn off remembering easily > accessible in the overlay UI. Now *that* I would approve of! Putting settings closer to the features they touch if often a good idea, and I think it makes a lot of sense here. If we do this, we probably don't need to enable it by default because it will completely discoverable and obvious for the people with use cases that could benefit from it. -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 391299] Rectangular Region: Remember selected area by default
https://bugs.kde.org/show_bug.cgi?id=391299 --- Comment #3 from Henrik Fehlauer --- > Personally, I'm not in favor Could you detail what the problem is if we did make it the default? So far your commment does not contain anything we could try to tackle to make any perceived problem go away. > These are developer-centric workflows More examples: - Screenshots of videos, see comment 0 (VLC has an option, web browsers do not) - Documenting progress in games. - Creating tutorials of all kind. Another option would be to make the checkbox to turn off remembering easily accessible in the overlay UI. -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 391299] Rectangular Region: Remember selected area by default
https://bugs.kde.org/show_bug.cgi?id=391299 Nate Graham changed: What|Removed |Added CC||n...@kde.org --- Comment #2 from Nate Graham --- Personally, I'm not in favor of remembering the last-used region by default. The most common use case for this is capturing before-and-after screenshots for bugs and patches. These are developer-centric workflows that I don't believe it's wise to optimize around. For people like us who do have this use case, there's a nice option, and it will even be more discoverable once the configure button is visible on the main window in 18.04. -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 391299] Rectangular Region: Remember selected area by default
https://bugs.kde.org/show_bug.cgi?id=391299 Henrik Fehlauer changed: What|Removed |Added CC||rk...@lab12.net Summary|Last image size and |Rectangular Region: |position and Save button|Remember selected area by ||default --- Comment #1 from Henrik Fehlauer --- Thanks for your message. Note that it's very important to only have one distinct topic per Bug, otherwise handling gets really complicated. Please open a new bug for Wish 2, here we'll focus on Wish 1: > last image size and position as default would be fine. Reading this, I assume you mean the "Rectangular Region" tool (please specify such details in the future ;). Good news for you: There is already a setting which you can check, it makes the tool remember the previously set size and position of the capture rectangle. You can access the configure dialog by clicking on the small arrow on the save button, and in the upcoming 18.04 release this will become a distinct button in the UI. --- Nevertheless, given this comes up quite often I'd advocate to make remembering the region the default behaviour. Let's repurpose your bug for this. The only detail to watch out for is how easy it is to draw a completely new rectangle. We might have to look at the help text, or add an overlay button to clear the old region. Another way would be to behave like KSnapshot did: Remember the area for the session, and reset the area after an application restart. -- You are receiving this mail because: You are watching all bug changes.