[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Postix]

https://bugs.kde.org/show_bug.cgi?id=312834

Postix  changed:

   What|Removed |Added

 CC||nelson.honey...@gmail.com

--- Comment #63 from Postix  ---
*** Bug 297666 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Postix]

https://bugs.kde.org/show_bug.cgi?id=312834

Postix  changed:

   What|Removed |Added

 CC||pos...@posteo.eu

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=312834

Elvis Angelaccio  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/dol
   ||phin/92368c1e4df9ea09e50c64
   ||80c2f72b78416e3244
   Version Fixed In||19.03.80
 Status|CONFIRMED   |RESOLVED

--- Comment #62 from Elvis Angelaccio  ---
Git commit 92368c1e4df9ea09e50c6480c2f72b78416e3244 by Elvis Angelaccio, on
behalf of Angelo Oliveira Jr.
Committed on 16/02/2019 at 15:09.
Pushed by elvisangelaccio into branch 'master'.

Add option to choose which view to close

Summary:
This Diff make configurable which view will close when toggling off
the split view mode, if it's the active one or the inactive one.

A new checkbox was added to the Dolphin configuration window,
and defaults to the original behavior.
FIXED-IN: 19.03.80

Test Plan: {F6535432}

Reviewers: ngraham, #dolphin, elvisangelaccio

Reviewed By: ngraham, #dolphin

Subscribers: elvisangelaccio, cfeck, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D18040

M  +1-1src/dolphinmainwindow.cpp
M  +17   -7src/dolphintabpage.cpp
M  +4-0src/settings/dolphin_generalsettings.kcfg
M  +8-0src/settings/general/behaviorsettingspage.cpp
M  +1-0src/settings/general/behaviorsettingspage.h

https://commits.kde.org/dolphin/92368c1e4df9ea09e50c6480c2f72b78416e3244

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #61 from Nate Graham  ---
Thanks! I will review it today or tomorrow.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Nadir]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #60 from Nadir  ---
Patch posted. 


Close inactive split view when toggling off
https://phabricator.kde.org/D18040

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #59 from Nate Graham  ---
The patch will need to be based on master, since this is a new feature. you can
re-base it in your local checkout using `git pull --rebase origin/master`

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Nadir]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #58 from Nadir  ---

Just for information, will it need to port the patch to the last version of
Dolphin before proceeding?

The current patch is on Dolphin 18.08.1, would it be ok?

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #57 from Nate Graham  ---
(In reply to Nadir from comment #56)
> Hi,
> Thanks for your answer.
> No I never used phabricator. 
> 
> You seem to say that if a patch is submitted, it will be accepted. That is a
> good motivator to spend time on it.

I wouldn't say it's guaranteed, but I'd support you. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Nadir]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #56 from Nadir  ---
Hi,
Thanks for your answer.
No I never used phabricator. 

You seem to say that if a patch is submitted, it will be accepted. That is a
good motivator to spend time on it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #55 from Nate Graham  ---
Personally I find it quite acceptable to have this be configurable, and I hope
you submit a patch using http://phabricator.kde.org. I would be happy to help
you if you've never done it before.


P.S. in terms of the user interface, you could make a new section like so,
since there will be two split-view-related items:



  Split Views: [] Switch between views with tab key
   [] Close active view when toggling off

Miscellaneous: [] Show tooltips
   [] Show selection marker
   [] Rename inline

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Nadir]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #54 from Nadir  ---
I had the same need. It was so annoying to me every hour of every day. 

A patched version now exists :
https://forum.kde.org/viewtopic.php?f=223=151449

Patch done, based on Dolphin 18.08.1.

An executable version of Dolphin (that I myself use) available in Arch AUR : 

https://aur.archlinux.org/packages/dolphin-split-view-the-right-way/

Source code: 
https://github.com/boussou/dolphin-split-view-the-right-way


I hope one day the KDE team will accept to add the feature (giving choice to
users)

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Nadir]

https://bugs.kde.org/show_bug.cgi?id=312834

Nadir  changed:

   What|Removed |Added

 CC||nad4...@gmail.com

--- Comment #53 from Nadir  ---
I had the same need. It was so annoying to me every hour of every day. 

A patched version now exists :
https://forum.kde.org/viewtopic.php?f=223=151449

Patch done, based on Dolphin 18.08.1.

An executable version of Dolphin (that I myself use) available in Arch AUR : 

https://aur.archlinux.org/packages/dolphin-split-view-the-right-way/

Source code: 
https://github.com/boussou/dolphin-split-view-the-right-way


I hope one day the KDE team will accept to add the feature (giving choice to
users)

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Gastón Haro]

https://bugs.kde.org/show_bug.cgi?id=312834

Gastón Haro  changed:

   What|Removed |Added

 CC||harogas...@gmail.com

--- Comment #52 from Gastón Haro  ---
Just because the action is called "Close" and "buttons always act on the active
view" we choose to keep an awkward behavior like this only for the sake of
consistency.

Well, sometimes exceptions are very welcomed. So here is my proposal, we could
try being consistent with user friendliness instead. That could probably work
out pretty well.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Denis Prost]

https://bugs.kde.org/show_bug.cgi?id=312834

Denis Prost  changed:

   What|Removed |Added

 CC|denis.pr...@wanadoo.fr  |

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #51 from Nate Graham  ---
(In reply to Chris Holland from comment #49)
> I'd prefer a configuration checkbox to switch between behaviours. However:
> 
> > I'm against adding an option. An additional action/shortcut is the only
> > way to fix this, imho. If anyone can provide a clean patch with unit tests,
> > I'd be happy to review it.
> 
> So I guess that means we need a new "Action" like the Shift+F3 "Close Other".
> 
> Shift+F3 could also be a "toggle" action like F3. So users could simply swap
> the shortcuts and ignore the other shortcut. The toolbar button could be
> hidden by default. The Menu Item would be a duplicate however (when not in
> split view). Not sure if we can "hide" the second menu item without
> disabling the shortcut.
> 
> I've been using the patch posted above for a while now.
> https://github.com/Zren/dolphin/commit/
> 2b546cce997daf0c2dd9ac597123138685cec921

Would you like to submit this as a patch?

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #50 from andydecle...@gmail.com ---
I think I'd be happy if any one of the suggestions were implemented, but my
preference at this point is to have the close pane button always close the
right side, with an additional action to swap the panes. That should keep
everything simple, well defined, and predictable. 

I don't know if this reversed for RTL users.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Chris Holland]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #49 from Chris Holland  ---
I'd prefer a configuration checkbox to switch between behaviours. However:

> I'm against adding an option. An additional action/shortcut is the only
> way to fix this, imho. If anyone can provide a clean patch with unit tests,
> I'd be happy to review it.

So I guess that means we need a new "Action" like the Shift+F3 "Close Other".

Shift+F3 could also be a "toggle" action like F3. So users could simply swap
the shortcuts and ignore the other shortcut. The toolbar button could be hidden
by default. The Menu Item would be a duplicate however (when not in split
view). Not sure if we can "hide" the second menu item without disabling the
shortcut.

I've been using the patch posted above for a while now.
https://github.com/Zren/dolphin/commit/2b546cce997daf0c2dd9ac597123138685cec921

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[phanisvara das]

https://bugs.kde.org/show_bug.cgi?id=312834

phanisvara das  changed:

   What|Removed |Added

 CC|phan...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #48 from Nate Graham  ---
I have personally (and recently) fixed issues that were 14 years old.
Anything's possible. But, it becomes less possible when someone's seemingly
trying to sabotage the process by posting discouraging comments. If you want
this fixed, negativity makes it *less* likely, not more. See
https://community.kde.org/Get_Involved/Bug_Reporting#Bug_tracker_etiquette

You catch more flies with honey then vinegar, that's all I'm trying to say. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Ettore Atalan]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #47 from Ettore Atalan  ---
This issue was reported in 2013. You don't have to be a pessimist to realize
that nothing will happen here.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #46 from Nate Graham  ---
Ettore, this is a bug tracker, not a complaint box. I understand you're
frustrated, but dumping negativity won't get this issue fixed any faster. In
fact, it's likely to have the opposite effect since volunteer developers are
easily demoralized by criticism. If you want to have a positive impact, you
could contribute to our brainstorming regarding possible options.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Ettore Atalan]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #45 from Ettore Atalan  ---
My advice to you: Don't waste your time with KDE hardliners. Use another
desktop environment instead of KDE.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #44 from Christoph Feck  ---
Another idea: Split button has a drop-down indicator. Clicking it splits/closes
the view. Holding it shows (after a short delay) a menu where you can select
the view to close. This selection is remembered in settings.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=312834

Dr. Chapatin  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Mircea Kitsune]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #43 from Mircea Kitsune  ---
The "close split view" button seems to at least be consistent now: It will
always close the active view rather than having an unpredictable result. The
only question remains whether it makes more sense for it to close the inactive
view and keep the active one instead.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=312834

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[br_shadow]

https://bugs.kde.org/show_bug.cgi?id=312834

br_shadow  changed:

   What|Removed |Added

   Keywords|usability   |

--- Comment #42 from br_shadow  ---
It's counter-intuitive to close the active view when you press F3 again, it
should close the non-active view by default and put a option somewhere if you
want to reverse this (which in my opinion is not even necessary).

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=312834

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=312834

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

--- Comment #41 from Nate Graham  ---
Confusion over which pane will be closed definitely keeps me from using the
Split feature more often.

After five years, we have not managed to achieve consensus on what the toolbar
button should do, whether or not it should be configurable, or whether we
should add a second (hidden by default) button that has the other behavior.

Looking through the duplicates, some people want the active pane closed, while
other want the inactive pane closed. In such a circumstance, IMHO adding a user
preference is the way to go, but if that's not an option, let's consider
alternative ideas. Here are some:

- Add individual close buttons to each split view pane somewhere, so you can
click on that pane's own close button to make sure you're closing the one you
intend
- Make the "Close" button's text indicate which view it will close (e.g. "close
left pane"/ "Close right pane")
- Have the "Close" button close the opposite pane when middle-clicked on (and
adjust the tooltip to indicate this)
- Adjust the toolbar button's icon to make the pane that will be closed more
obvious (I only just now noticed that it changes depending on which pane is
focused)

Thoughts?

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=312834

Christoph Feck  changed:

   What|Removed |Added

 CC||tef...@gmail.com

--- Comment #40 from Christoph Feck  ---
*** Bug 396460 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #39 from andydecle...@gmail.com ---
So can we muster consensus on a new "Split/Expand" button and action?

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Thomas]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #38 from Thomas  ---
Fair enough, I don't care about the name. The current behavior of split
view close is annoying me because it is constantly interrupting my
workflow.

Elvis Angelaccio  schrieb am Do., 3. Aug. 2017,
15:57:

> https://bugs.kde.org/show_bug.cgi?id=312834
>
> --- Comment #37 from Elvis Angelaccio  ---
> (In reply to Oleg Solovyov from comment #36)
> > Maybe add "Close left", "Close right" buttons instead of one "Close"
> button?
>
> No, that would change the meaning of the current "Close" action, which is
> what
> we want to avoid. I'd use "Expand" or a similar name, since that's what
> would
> happen (the inactive view gets closed ==> the active one gets expanded).
>
> --
> You are receiving this mail because:
> You voted for the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #37 from Elvis Angelaccio  ---
(In reply to Oleg Solovyov from comment #36)
> Maybe add "Close left", "Close right" buttons instead of one "Close" button?

No, that would change the meaning of the current "Close" action, which is what
we want to avoid. I'd use "Expand" or a similar name, since that's what would
happen (the inactive view gets closed ==> the active one gets expanded).

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Oleg Solovyov]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #36 from Oleg Solovyov  ---
Maybe add "Close left", "Close right" buttons instead of one "Close" button?

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Thomas]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #35 from Thomas  ---
I really think, there is not a single person out there that truly thinks
the current behavior is good. Let's look at the workflow:

My typical split view workflow is adding the split view, because you want
to copy or compare files and then continue to work in one of the folders.
At this point the other folder becomes useless to you and that is the
reason why you want to close it.

The current behavior forces you to switch from the folder that you want to
keep, because it has the content you want to work with, into the folder
that you want to close. Then you close it and look back at the interesting
folder.

The proposed behavior is that you subconsciously recognize that the other
view is obsolete and close it without losing focus. You seemlessly continue
to work.

What are your workflows for split view? Do you support my point of view?

Thomas

Elvis Angelaccio  schrieb am Do., 3. Aug. 2017,
10:31:

> https://bugs.kde.org/show_bug.cgi?id=312834
>
> Elvis Angelaccio  changed:
>
>What|Removed |Added
>
> 
>  CC||elvis.angelac...@kde.org
>
> --- Comment #34 from Elvis Angelaccio  ---
> (In reply to fgf from comment #28)
> > I do not understand, why a behaviour that annoys and frustrates many
> people
> > is apparently ignored or even defended for no good reason.
> > The "arguments" put forward to defend the completely counter-intuitive
> > behaviour of closing the active view are not convincing.
>
> How can you tell that there are more people annoyed than people who are
> accustomed to the current behavior? I bet that if we change behavior, we
> are
> going to get tons of bug reports (see the already cited xkcd/1172).
>
> And why do you think that the arguments provided by Frank are not good or
> convincing?
>
> > I cannot help but
> > assume that the real reason is stubbornness on the side of the
> developers.
> > This change (either as an option, or an additional/alternative
> key-binding)
> > is simple and non-intrusive for those that are used to old behaviour or
> who
> > consider this for whatever reason as "logical".
>
> I'm against adding an option. An additional action/shortcut is the only
> way to
> fix this, imho. If anyone can provide a clean patch with unit tests, I'd be
> happy to review it.
>
> --
> You are receiving this mail because:
> You voted for the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=312834

Elvis Angelaccio  changed:

   What|Removed |Added

 CC||elvis.angelac...@kde.org

--- Comment #34 from Elvis Angelaccio  ---
(In reply to fgf from comment #28)
> I do not understand, why a behaviour that annoys and frustrates many people
> is apparently ignored or even defended for no good reason.  
> The "arguments" put forward to defend the completely counter-intuitive
> behaviour of closing the active view are not convincing. 

How can you tell that there are more people annoyed than people who are
accustomed to the current behavior? I bet that if we change behavior, we are
going to get tons of bug reports (see the already cited xkcd/1172).

And why do you think that the arguments provided by Frank are not good or
convincing?

> I cannot help but
> assume that the real reason is stubbornness on the side of the developers.
> This change (either as an option, or an additional/alternative key-binding)
> is simple and non-intrusive for those that are used to old behaviour or who
> consider this for whatever reason as "logical". 

I'm against adding an option. An additional action/shortcut is the only way to
fix this, imho. If anyone can provide a clean patch with unit tests, I'd be
happy to review it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=312834

Christoph Feck  changed:

   What|Removed |Added

 CC||sonichedgehog_hyperblast00@
   ||yahoo.com

--- Comment #33 from Christoph Feck  ---
*** Bug 382823 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Oleg Solovyov]

https://bugs.kde.org/show_bug.cgi?id=312834

Oleg Solovyov  changed:

   What|Removed |Added

 CC||mcpa...@mail.ru

--- Comment #32 from Oleg Solovyov  ---
Created attachment 106825
  --> https://bugs.kde.org/attachment.cgi?id=106825=edit
Improvement of attachment 104707

(In reply to Christoph Feck from comment #31)
> Created attachment 104707 [details]
> Change the meaning of the Close button

Your patch is causing crash after closing LEFT view and switching to another
tab (if exist).

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Chris Holland]

https://bugs.kde.org/show_bug.cgi?id=312834

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #31 from Christoph Feck  ---
Created attachment 104707
  --> https://bugs.kde.org/attachment.cgi?id=104707=edit
Change the meaning of the Close button

Yes, it is KDE, a community of volunteers. Adding more comments to a feature
request won't magically change code, especially when there was no consensus.

Here is a patch. It changes the meaning of the "Close Split View" toolbar
button from "Close Active Split View" to "Close Inactive Split View". I did not
search for descriptive texts, so these might be wrong now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Ettore Atalan]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #30 from Ettore Atalan  ---
(In reply to fgf from comment #28)
> I do not understand, why a behaviour that annoys and frustrates many people
> is apparently ignored or even defended for no good reason.

It's KDE ...

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Denis Prost]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #29 from Denis Prost  ---
I totally second this

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=312834

f...@gmx.net changed:

   What|Removed |Added

 CC||f...@gmx.net

--- Comment #28 from f...@gmx.net ---
I do not understand, why a behaviour that annoys and frustrates many people is
apparently ignored or even defended for no good reason. I can't count the
occasions where I closed the wrong view and had to navigate again to the
previous location. 

The "arguments" put forward to defend the completely counter-intuitive
behaviour of closing the active view are not convincing. I cannot help but
assume that the real reason is stubbornness on the side of the developers. This
change (either as an option, or an additional/alternative key-binding) is
simple and non-intrusive for those that are used to old behaviour or who
consider this for whatever reason as "logical". 

I again plead for the changes proposed in this thread. The current behaviour is
a BUG not a feature and should be fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #27 from andydecle...@gmail.com ---
Can someone with permissions please update the version from 2.1.97 to 16.04.2 ?
A lot of versions happen in three and a half years.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Christoph Feck via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=312834

Christoph Feck  changed:

   What|Removed |Added

 CC||prmur...@yahoo.com

--- Comment #26 from Christoph Feck  ---
*** Bug 361095 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Christoph Feck via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=312834

Christoph Feck  changed:

   What|Removed |Added

 CC||iattil...@gmail.com

--- Comment #25 from Christoph Feck  ---
*** Bug 360159 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[Ettore Atalan via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #22 from Ettore Atalan  ---
(In reply to andydecleyre from comment #20)
> Even if you don't change the default behavior, 
> even if you don't enable changing the behavior in the settings, 
> even if you don't add another keyboard shortcut for the more intuitive
> behavior (closing the pane _not_ being actively used),

You'd better use another file manager due to the lack of willingness to
consider user needs. It's more a KDE problem than a technical problem, anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=312834

andydecle...@gmail.com changed:

   What|Removed |Added

 CC||andydecle...@gmail.com

--- Comment #20 from andydecle...@gmail.com ---
Even if you don't change the default behavior, 
even if you don't enable changing the behavior in the settings, 
even if you don't add another keyboard shortcut for the more intuitive behavior
(closing the pane _not_ being actively used),

please just add another button in the Configure Toolbars dialog (that a user
would have to seek out or stumble upon) that opens a second pane but _doesn't_
activate it, and closes the _inactive_ pane if two are already open.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312834] closing split view closes the currently focused view instead of the inactive

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=312834

--- Comment #21 from andydecle...@gmail.com ---
OK, rereading this three year long discussion, I think I understand that the
reason my last comment's reiterations of previous suggestions have not been
acted on is:

"Currently, the action's name switches between 'Split' and 'Close'. What short,
meaningful name could a new action get to avoid confusion?"

So, let's brainstorm:

Split | Close Other
Split | Crop
Single | Dual
Split | Close [Left | Right]
Split | Maximize
Split | Fill
Split | Grow
Split | Widen
Split | Only
Split | Focus
Split | Focalize
Wane | Wax
Split | Expand
Split | Swell

I think "Split | Swell" is my favorite so far. The words are pleasantly
symmetrical. My next choices are probably Grow, Fill, Expand.

-- 
You are receiving this mail because:
You are watching all bug changes.