[dolphin] [Bug 373005] Dolphin crashes when dragging unused device somewhere

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=373005

Elvis Angelaccio  changed:

   What|Removed |Added

   Version Fixed In||17.04.3
  Latest Commit||https://commits.kde.org/dol
   ||phin/c85ca114553c198af79eed
   ||acdb6b40ac4cab20e0
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Elvis Angelaccio  ---
Git commit c85ca114553c198af79eedacdb6b40ac4cab20e0 by Elvis Angelaccio.
Committed on 11/06/2017 at 17:11.
Pushed by elvisangelaccio into branch 'Applications/17.04'.

Ignore drops-onto-items from invalid places items

If the QMimeData object created by PlacesItemModel doesn't have any url
set (e.g. when dragging unmounted devices), it is detected by the
resulting DropJob as "drop raw data" because the mimeData has one format set
(the internalMimeType() used for dragging between places items).

This results in a crash because the DropJob schedules a PasteJob, but in
the meantime the QDrag from Dolphin ends and deletes the mimeData object
that was passed to the paste job.

The fix is to prevent the DropJob in the first place. We can introduce a
new internal mimetype that we use to blacklist drops-onto-items (while
still allowing drops-between-items). This way PlacesItemModel can set
the blacklist flag if the mimeData is being created without urls.
FIXED-IN: 17.04.3

Test Plan:
Drag and drop an unmounted device to another place item or the DolphinView,
doesn't crash anymore.
Dropping the unmounted device between two places item still works.

Differential Revision: https://phabricator.kde.org/D5535

M  +1-1src/kitemviews/kitemlistcontroller.cpp
M  +5-0src/kitemviews/kitemmodelbase.cpp
M  +10   -0src/kitemviews/kitemmodelbase.h
M  +3-0src/panels/places/placesitemmodel.cpp

https://commits.kde.org/dolphin/c85ca114553c198af79eedacdb6b40ac4cab20e0

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 373005] Dolphin crashes when dragging unused device somewhere

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=373005

Elvis Angelaccio  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||elvis.angelac...@kde.org
 Status|UNCONFIRMED |CONFIRMED
URL||https://phabricator.kde.org
   ||/D5535

--- Comment #8 from Elvis Angelaccio  ---
https://phabricator.kde.org/D5535

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 373005] Dolphin crashes when dragging unused device somewhere

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=373005

Elvis Angelaccio  changed:

   What|Removed |Added

 CC||ouissalbenam...@gmail.com

--- Comment #7 from Elvis Angelaccio  ---
*** Bug 378954 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 373005] Dolphin crashes when dragging unused device somewhere

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=373005

Elvis Angelaccio  changed:

   What|Removed |Added

 CC||ru...@mail.ru

--- Comment #6 from Elvis Angelaccio  ---
*** Bug 378370 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 373005] Dolphin crashes when dragging unused device somewhere

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=373005

Elvis Angelaccio  changed:

   What|Removed |Added

 CC||jakeclau...@phonecoop.coop

--- Comment #5 from Elvis Angelaccio  ---
*** Bug 372242 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 373005] Dolphin crashes when dragging unused device somewhere

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=373005

Christoph Feck  changed:

   What|Removed |Added

 CC||fa...@kde.org

--- Comment #4 from Christoph Feck  ---
This could be a crash in QMimeData.

Application: Dolphin (dolphin), signal: Segmentation fault
Using host libthread_db library "/usr/lib/libthread_db.so.1".
[Current thread is 1 (Thread 0x7fac36846800 (LWP 2854))]

Thread 6 (Thread 0x7fac0d0d3700 (LWP 2859)):
#0  0x7fac297b40ca in g_main_context_check () from
/usr/lib/libglib-2.0.so.0
#1  0x7fac297b4724 in ?? () from /usr/lib/libglib-2.0.so.0
#2  0x7fac297b489c in g_main_context_iteration () from
/usr/lib/libglib-2.0.so.0
#3  0x7fac302d980b in QEventDispatcherGlib::processEvents
(this=0x7fac080008c0, flags=...) at kernel/qeventdispatcher_glib.cpp:425
#4  0x7fac30280b12 in QEventLoop::exec (this=this@entry=0x7fac0d0d2dc0,
flags=..., flags@entry=...) at kernel/qeventloop.cpp:210
#5  0x7fac300c049e in QThread::exec (this=) at
thread/qthread.cpp:507
#6  0x7fac300c5d5d in QThreadPrivate::start (arg=0x13f4c30) at
thread/qthread_unix.cpp:344
#7  0x7fac2b8ef454 in start_thread () from /usr/lib/libpthread.so.0
#8  0x7fac3618f7df in clone () from /usr/lib/libc.so.6

Thread 5 (Thread 0x7fac15995700 (LWP 2858)):
#0  0x7fac2b8f510f in pthread_cond_wait@@GLIBC_2.3.2 () from
/usr/lib/libpthread.so.0
#1  0x7fac16f51ec3 in ?? () from /usr/lib/xorg/modules/dri/swrast_dri.so
#2  0x7fac16f51d27 in ?? () from /usr/lib/xorg/modules/dri/swrast_dri.so
#3  0x7fac2b8ef454 in start_thread () from /usr/lib/libpthread.so.0
#4  0x7fac3618f7df in clone () from /usr/lib/libc.so.6

Thread 4 (Thread 0x7fac16196700 (LWP 2857)):
#0  0x7fac2b8f510f in pthread_cond_wait@@GLIBC_2.3.2 () from
/usr/lib/libpthread.so.0
#1  0x7fac16f51ec3 in ?? () from /usr/lib/xorg/modules/dri/swrast_dri.so
#2  0x7fac16f51d27 in ?? () from /usr/lib/xorg/modules/dri/swrast_dri.so
#3  0x7fac2b8ef454 in start_thread () from /usr/lib/libpthread.so.0
#4  0x7fac3618f7df in clone () from /usr/lib/libc.so.6

Thread 3 (Thread 0x7fac1cf51700 (LWP 2856)):
#0  0x7fac3618648d in poll () from /usr/lib/libc.so.6
#1  0x7fac297b4786 in ?? () from /usr/lib/libglib-2.0.so.0
#2  0x7fac297b489c in g_main_context_iteration () from
/usr/lib/libglib-2.0.so.0
#3  0x7fac302d980b in QEventDispatcherGlib::processEvents
(this=0x7fac18c0, flags=...) at kernel/qeventdispatcher_glib.cpp:425
#4  0x7fac30280b12 in QEventLoop::exec (this=this@entry=0x7fac1cf50d90,
flags=..., flags@entry=...) at kernel/qeventloop.cpp:210
#5  0x7fac300c049e in QThread::exec (this=this@entry=0x7fac3097fd40
<(anonymous namespace)::Q_QGS__q_manager::innerFunction()::holder>) at
thread/qthread.cpp:507
#6  0x7fac306fc275 in QDBusConnectionManager::run (this=0x7fac3097fd40
<(anonymous namespace)::Q_QGS__q_manager::innerFunction()::holder>) at
qdbusconnection.cpp:196
#7  0x7fac300c5d5d in QThreadPrivate::start (arg=0x7fac3097fd40 <(anonymous
namespace)::Q_QGS__q_manager::innerFunction()::holder>) at
thread/qthread_unix.cpp:344
#8  0x7fac2b8ef454 in start_thread () from /usr/lib/libpthread.so.0
#9  0x7fac3618f7df in clone () from /usr/lib/libc.so.6

Thread 2 (Thread 0x7fac1ed11700 (LWP 2855)):
#0  0x7fac3618648d in poll () from /usr/lib/libc.so.6
#1  0x7fac28eeb8e0 in ?? () from /usr/lib/libxcb.so.1
#2  0x7fac28eed679 in xcb_wait_for_event () from /usr/lib/libxcb.so.1
#3  0x7fac21065889 in QXcbEventReader::run (this=0x10411b0) at
qxcbconnection.cpp:1337
#4  0x7fac300c5d5d in QThreadPrivate::start (arg=0x10411b0) at
thread/qthread_unix.cpp:344
#5  0x7fac2b8ef454 in start_thread () from /usr/lib/libpthread.so.0
#6  0x7fac3618f7df in clone () from /usr/lib/libc.so.6

Thread 1 (Thread 0x7fac36846800 (LWP 2854)):
[KCrash Handler]
#6  0x7fac302a91a6 in QMimeDataPrivate::retrieveTypedData (this=0x152c830,
format=..., type=type@entry=QVariant::ByteArray) at kernel/qmimedata.cpp:112
#7  0x7fac302aa38d in QMimeData::data (this=, mimeType=...)
at kernel/qmimedata.cpp:560
#8  0x7fac349c9ea1 in KIO::isClipboardDataCut (mimeData=) at
/home/kishore/Downloads/kio/src/kio-5.28.0/src/widgets/paste.cpp:355
#9  0x7fac349f077e in KIO::PasteJobPrivate::slotStart (this=0x15613d0) at
/home/kishore/Downloads/kio/src/kio-5.28.0/src/widgets/pastejob.cpp:55
#10 0x7fac349f0b11 in KIO::PasteJob::qt_static_metacall (_o=, _c=, _id=, _a=) at
/home/kishore/Downloads/kio/src/build/src/widgets/moc_pastejob.cpp:95
#11 0x7fac302b06d9 in QObject::event (this=0x152c4d0, e=) at
kernel/qobject.cpp:1263
#12 0x7fac311f4fc4 in QApplicationPrivate::notify_helper (this=, receiver=0x152c4d0, e=0x156ca90) at kernel/qapplication.cpp:3799
#13 0x7fac311fcb70 in QApplication::notify (this=0x7fff3a447c70,

[dolphin] [Bug 373005] Dolphin crashes when dragging unused device somewhere

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=373005

kishor...@gmail.com changed:

   What|Removed |Added

 Attachment #102505|0   |1
is obsolete||

--- Comment #3 from kishor...@gmail.com ---
Created attachment 102508
  --> https://bugs.kde.org/attachment.cgi?id=102508=edit
Debug information from crash

The previous attachment was when I was missing some debug information. This
attachment contains a more complete trace, after I compiled the required
packages with debug symbols.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 373005] Dolphin crashes when dragging unused device somewhere

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=373005

--- Comment #2 from kishor...@gmail.com ---
(In reply to kishore96 from comment #1)
> Created attachment 102505 [details]
> Debug information from dolphin crash

Was able to reproduce with dolphin version 16.08.3 on Arch Linux.

PS: Sorry for messing up this thread. I'm a bit unfamiliar with the interface.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 373005] Dolphin crashes when dragging unused device somewhere

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=373005

--- Comment #1 from kishor...@gmail.com ---
Created attachment 102505
  --> https://bugs.kde.org/attachment.cgi?id=102505=edit
Debug information from dolphin crash

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 373005] Dolphin crashes when dragging unused device somewhere

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=373005

kishor...@gmail.com changed:

   What|Removed |Added

 CC||kishor...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.