[konsole] [Bug 443117] "Mark taskbar entry" does not work for Konsole notifications
https://bugs.kde.org/show_bug.cgi?id=443117 ninj...@gmail.com changed: What|Removed |Added Version Fixed In||v22.04.0 CC||ninj...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 443117] "Mark taskbar entry" does not work for Konsole notifications
https://bugs.kde.org/show_bug.cgi?id=443117 Kurt Hindenburg changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/util ||ities/konsole/commit/28bfbf ||1a9fa78f79a2d17301615da4c6b ||3afc9f3 Status|REPORTED|RESOLVED --- Comment #3 from Kurt Hindenburg --- Git commit 28bfbf1a9fa78f79a2d17301615da4c6b3afc9f3 by Kurt Hindenburg, on behalf of Luis Javier Merino Morán. Committed on 11/01/2022 at 15:57. Pushed by hindenburg into branch 'master'. Pass widget again to monitoring KNotifications 9f656939 introduced the possibility of showing a session in multiple views, something which is no longer supported. In doing so, it started passing QApplication::activeWindow(), instead of TEWidget (nowadays TerminalDisplay) to KNotification. 7592e894 split notifications for focused/unfocused terminals. Unfortunately, QApplication::activeWindow() returns nothing for unmapped windows, which results in issues when notifications are configured to mark the task bar entry or run a command with %w/%t substitutions (for window id and window title). M +12 -2src/session/Session.cpp M +1-1src/session/SessionController.cpp https://invent.kde.org/utilities/konsole/commit/28bfbf1a9fa78f79a2d17301615da4c6b3afc9f3 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 443117] "Mark taskbar entry" does not work for Konsole notifications
https://bugs.kde.org/show_bug.cgi?id=443117 --- Comment #2 from Kurt Hindenburg --- Git commit 0fe44c52310a6c276388cf30c81b6fc45a39da32 by Kurt Hindenburg, on behalf of Luis Javier Merino Morán. Committed on 11/01/2022 at 15:57. Pushed by hindenburg into branch 'master'. Pass widget again to KNotification on bell 67508680 refactored TerminalBell out from TerminalDisplay, and in the process stopped passing the TerminalDisplay widget to KNotification, which resulted in issues when notifications where configured to mark the task bar entry or run a command with %w/%t substitutions (for window id and window title). Many thanks to Nicole Kleinhoff and Jan Palus who identified the commit that introduced the regression. Related: bug 443411, bug 445520 M +3-2src/terminalDisplay/TerminalBell.cpp M +2-1src/terminalDisplay/TerminalBell.h M +1-1src/terminalDisplay/TerminalDisplay.cpp https://invent.kde.org/utilities/konsole/commit/0fe44c52310a6c276388cf30c81b6fc45a39da32 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 443117] "Mark taskbar entry" does not work for Konsole notifications
https://bugs.kde.org/show_bug.cgi?id=443117 --- Comment #1 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/utilities/konsole/-/merge_requests/573 -- You are receiving this mail because: You are watching all bug changes.
