[krita] [Bug 395981] Merge with Layer Below in Isolate Layer mode either switches off or keeps Isolate mode randomly
https://bugs.kde.org/show_bug.cgi?id=395981 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://commits.kde.org/kri |https://commits.kde.org/kri |ta/759ecacbacdf1a6f62880604 |ta/5215befc243d69de120506e6 |a51bdf52ea46f4ab|7bd63b08cb5052c3 Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #10 from Dmitry Kazakov --- Git commit 5215befc243d69de120506e67bd63b08cb5052c3 by Dmitry Kazakov. Committed on 03/04/2019 at 09:41. Pushed by dkazakov into branch 'master'. Fix activation of Isolate Mode when merging the layers down When merging layers down, a null layer is activated for a short period of time. It happens because the following: 1) When we remove the top layer, LayerBox adjusts the currently selected index to the lower node. And tries to activate it. 2) The activated node is passed further by the signals chain, and then in KisNodeManager::slotNonUiActivatedNode() we find out that this node has also been removed from the node graph. Therefore we pass 0 to the lower-level code. 3) Isolate mode code sees that there is no layer selected and stops the isolated mode. The patch fixes the issue by storing a separate flag, marking marking the presence of isolated mode. Even when there is no layer to isolate, we still save the sate and try to activate it when a valid node comes. The patch also disables automated switch-off of the isolated mode hen adding/removing. The mode will continue until the user switches it off manually (or something really weird happens) M +3-6libs/image/kis_image.cc M +19 -2libs/ui/kis_node_manager.cpp M +1-0libs/ui/kis_node_manager.h https://commits.kde.org/krita/5215befc243d69de120506e67bd63b08cb5052c3 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395981] Merge with Layer Below in Isolate Layer mode either switches off or keeps Isolate mode randomly
https://bugs.kde.org/show_bug.cgi?id=395981 Dmitry Kazakov changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #9 from Dmitry Kazakov --- Sorry, the patch was reverted. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395981] Merge with Layer Below in Isolate Layer mode either switches off or keeps Isolate mode randomly
https://bugs.kde.org/show_bug.cgi?id=395981 Dmitry Kazakov changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Latest Commit||https://commits.kde.org/kri ||ta/759ecacbacdf1a6f62880604 ||a51bdf52ea46f4ab --- Comment #8 from Dmitry Kazakov --- Git commit 759ecacbacdf1a6f62880604a51bdf52ea46f4ab by Dmitry Kazakov. Committed on 02/04/2019 at 16:42. Pushed by dkazakov into branch 'master'. Fix activation of Isolate Mode when merging the layers down When merging layers down, a null layer is activated for a short period of time. It happens because the following: 1) When we remove the top layer, LayerBox adjusts the currently selected index to the lower node. And tries to activate it. 2) The activated node is passed further by the signals chain, and then in KisNodeManager::slotNonUiActivatedNode() we find out that this node has also been removed from the node graph. Therefore we pass 0 to the lower-level code. 3) Isolate mode code sees that there is no layer selected and stops the isolated mode. The patch fixes the issue by storing a separate flag, marking marking the presence of isolated mode. Even when there is no layer to isolate, we still save the sate and try to activate it when a valid node comes. M +7-1libs/ui/kis_node_manager.cpp https://commits.kde.org/krita/759ecacbacdf1a6f62880604a51bdf52ea46f4ab -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395981] Merge with Layer Below in Isolate Layer mode either switches off or keeps Isolate mode randomly
https://bugs.kde.org/show_bug.cgi?id=395981 --- Comment #7 from Bollebib --- disabling isolate layer randomly is a bit inconsistant but its better then random crash! thnx -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395981] Merge with Layer Below in Isolate Layer mode either switches off or keeps Isolate mode randomly
https://bugs.kde.org/show_bug.cgi?id=395981 Dmitry Kazakov changed: What|Removed |Added Severity|crash |normal Summary|Merge with Layer Below |Merge with Layer Below in |crashes krita when Isolate |Isolate Layer mode either |Layer is active |switches off or keeps ||Isolate mode randomly -- You are receiving this mail because: You are watching all bug changes.
