[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093 Ismael Asensio changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/systemsettings/-/merge_r |ma/systemsettings/-/commit/ |equests/130 |1022d0b0d5945613104978e4cdc ||f58987f846143 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093 Ismael Asensio changed: What|Removed |Added Version Fixed In||5.24.90 Status|CONFIRMED |RESOLVED Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/systemsettings/commit/19 |ma/systemsettings/-/merge_r |f88c428de426a8a4db2b43f51f5 |equests/130 |58437bf279e | Resolution|--- |FIXED --- Comment #22 from Ismael Asensio --- > Cannot reproduce on Plasma 5.25 beta. I think this got fixed with https://invent.kde.org/plasma/systemsettings/-/merge_requests/130, but as I was trying to fix a different issue, I didn't remember to reference it to this bug. Thanks for reminding it! -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093 --- Comment #21 from Patrick Silva --- Cannot reproduce on Plasma 5.25 beta. Operating System: Arch Linux KDE Plasma Version: 5.24.90 KDE Frameworks Version: 5.94.0 Qt Version: 5.15.4 Graphics Platform: Wayland -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093
--- Comment #20 from EDeadLock ---
(In reply to Ismael Asensio from comment #16)
> (In reply to EDeadLock from comment #13)
>
> > @@ -485,7 +487,7 @@ void ModuleView::stateChanged()
> > updatePageIconHeader(d->mPageWidget->currentPage());
> >
> > KCModuleProxy *moduleProxy =
> > d->mPages.value(d->mPageWidget->currentPage());
> > -d->mCustomHeader->setVisible(!moduleProxy ||
> > !moduleProxy->realModule()->inherits("KCModuleQml"));
> > +d->mCustomHeader->setVisible(false);
>
> Hi there! You were right in this line causing the bug.
>
> The reason you couldn't find "Header3" is because it is generated in QML by
> modules that have already been ported to use that technology.
Does this mean we have to port/update the modules to use this technology so
that QML generates the correct headers?
There is code
> to treat the three different cases (QML modules, QWidget modules when in
> Sidebar View and QWidget modules when in Icon View), but that code wasn't
> always being run, causing the bug.
>
> The code in this class in general has been suffering from small incremental
> changes which made it a little too un-manageable, so fixing one thing could
> break a different one. I hope with a little refactor this is sorted out and
> not many new surprises arise.
Thank you Ismael for the explanation.
I was able to test latest master (06df6b61) and I see that one of the bad
headers is gone (Header1) but we still have Header2 present and the correct
header3 is not yet shown. Small step in the right direction, again, thank you
so much. I assume we have to port/update the modules to use the newer
technology so that we get the correct header shown as I asked above. Anyway I
can help with this? Please let me know what I can do to help, best!
--
You are receiving this mail because:
You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093 Nate Graham changed: What|Removed |Added Status|RESOLVED|REPORTED Ever confirmed|1 |0 Version Fixed In|5.24| Resolution|FIXED |--- --- Comment #19 from Nate Graham --- Not fully fixed yet; another MR is still needed. Should be done soon. -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093 Nate Graham changed: What|Removed |Added Latest Commit||https://invent.kde.org/plas ||ma/systemsettings/commit/19 ||f88c428de426a8a4db2b43f51f5 ||58437bf279e Version Fixed In||5.24 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #18 from Nate Graham --- Git commit 19f88c428de426a8a4db2b43f51f558437bf279e by Nate Graham, on behalf of Ismael Asensio. Committed on 01/02/2022 at 15:42. Pushed by ngraham into branch 'Plasma/5.24'. ModuleView: Improve code for header updates Clean-up and refactor around updatePageIconHeader() method and uses. By moving the header logic into this method, we reduce some duplicity present in different codepaths and make it less bug-prone, specially on IconView. FIXED-IN: 5.24 (cherry picked from commit c8a128c0f30dec32e807043590673b9ca70ce0db) M +39 -60 core/ModuleView.cpp M +1-1core/ModuleView.h https://invent.kde.org/plasma/systemsettings/commit/19f88c428de426a8a4db2b43f51f558437bf279e -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093 --- Comment #17 from Nate Graham --- Git commit f92b8fb2dc2e8f8de90502e279a3bf7e842a4bac by Nate Graham, on behalf of Ismael Asensio. Committed on 01/02/2022 at 15:42. Pushed by ngraham into branch 'master'. ModuleView: Improve code for header updates Clean-up and refactor around updatePageIconHeader() method and uses. By moving the header logic into this method, we reduce some duplicity present in different codepaths and make it less bug-prone, specially on IconView. M +39 -60 core/ModuleView.cpp M +1-1core/ModuleView.h https://invent.kde.org/plasma/systemsettings/commit/f92b8fb2dc2e8f8de90502e279a3bf7e842a4bac -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093
Ismael Asensio changed:
What|Removed |Added
CC||isma...@gmail.com
--- Comment #16 from Ismael Asensio ---
(In reply to EDeadLock from comment #13)
> @@ -485,7 +487,7 @@ void ModuleView::stateChanged()
> updatePageIconHeader(d->mPageWidget->currentPage());
>
> KCModuleProxy *moduleProxy =
> d->mPages.value(d->mPageWidget->currentPage());
> -d->mCustomHeader->setVisible(!moduleProxy ||
> !moduleProxy->realModule()->inherits("KCModuleQml"));
> +d->mCustomHeader->setVisible(false);
Hi there! You were right in this line causing the bug.
The reason you couldn't find "Header3" is because it is generated in QML by
modules that have already been ported to use that technology. There is code to
treat the three different cases (QML modules, QWidget modules when in Sidebar
View and QWidget modules when in Icon View), but that code wasn't always being
run, causing the bug.
The code in this class in general has been suffering from small incremental
changes which made it a little too un-manageable, so fixing one thing could
break a different one. I hope with a little refactor this is sorted out and not
many new surprises arise.
--
You are receiving this mail because:
You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #15 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/systemsettings/-/merge_requests/120 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093 --- Comment #14 from Michael --- Great to see this bug getting some love :) -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093
--- Comment #13 from EDeadLock ---
(In reply to Bharadwaj Raju from comment #9)
> (In reply to EDeadLock from comment #8)
> > I would love to help fix this issue but I dont know where to start. I
> > managed to set up the neon docker container. How can I enable logging on the
> > settings app or edit the code and test?
>
> Sorry for the late reply. Please check out
> https://community.kde.org/Get_Involved/development which will help you about
> compiling the code etc.
TL;DR;
I was able to remove the incorrect headers using the patch below, but I have
yet to figure out how display the correct Header
Yeah, no worries, I was able to figure out how to play with it. Your link and
the Docker container setup https://community.kde.org/Neon/Docker came in really
helpful in debugging this
I had done some troubleshooting by changing different parts of the code and
seeing how things behaved. It's not the best way to go about it but there is
really not much else I can do when I am unfamiliar with the code base.
In any case, I had done the troubleshooting late November and wanted to do
some more before I updated here, but I had not found the time to do more, so I
will just update what I have with my notes from then. I also added some details
from what I remember and also sat down and spent 2 hours investigating more
when I originally wanted to only spend 30mins :)
What I have found is that there are 3 Headers within the entire code base. 2 Of
those headers are "incorrect" and one is "correct". Pages that use the correct
headers have no issues.
I tweaked the code to make it so that all 3 headers are shown at the same time.
Well, I found how to make Header1 and Header2 to always be shown or hidden. I
havent found the code for Header3. See screenshot headers_shown.png and
headers_hidden.png to understand which headers are Header1, Header2, and
Header3. Header1 and Header2 are the incorrect headers while Header3 is the
correct one
The following diff removes the incorrect Headers Header1 and Header2. To make
them always visible just toggle them to true. This is how I made the
screenshots. Note that I am on an old commit 2dcc904bcc
diff --git a/core/ModuleView.cpp b/core/ModuleView.cpp
index 203b6021..9d10d22b 100644
--- a/core/ModuleView.cpp
+++ b/core/ModuleView.cpp
@@ -458,6 +458,8 @@ void ModuleView::activeModuleChanged(KPageWidgetItem
*current, KPageWidgetItem *
moduleShowDefaultsIndicators(d->mDefaultsIndicatorsVisible);
}
+current->setHeaderVisible(false);
+d->mCustomHeader->setVisible(false);
}
void ModuleView::stateChanged()
@@ -485,7 +487,7 @@ void ModuleView::stateChanged()
updatePageIconHeader(d->mPageWidget->currentPage());
KCModuleProxy *moduleProxy =
d->mPages.value(d->mPageWidget->currentPage());
-d->mCustomHeader->setVisible(!moduleProxy ||
!moduleProxy->realModule()->inherits("KCModuleQml"));
+d->mCustomHeader->setVisible(false);
d->mApplyAuthorize->setAuthAction(moduleAction);
d->mDefault->setEnabled(!defaulted);
Header1 is fixed by d->mCustomHeader->setVisible(false);
Header2 is fixed by current->setHeaderVisible(false);
I havent found how to make Header3 present in the broken pages. I guess that is
the next step. It seems that all the broken pages seem to be using Header1 and
Header2, which are wrong. The pages need to migrate to using Header3 type. It
also seems that correct pages use Header3 and stay away from using Header1 and
Header2. If anyone knows the trick to display Header3 then we can get started
in setting a proper patch
Thanks all :)
--
You are receiving this mail because:
You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093 --- Comment #12 from EDeadLock --- Created attachment 146010 --> https://bugs.kde.org/attachment.cgi?id=146010=edit headers_shown.png -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093 --- Comment #11 from EDeadLock --- Created attachment 146009 --> https://bugs.kde.org/attachment.cgi?id=146009=edit header_hidden.png -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093 --- Comment #10 from EDeadLock --- Created attachment 146008 --> https://bugs.kde.org/attachment.cgi?id=146008=edit Header Forced Hidden -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093 --- Comment #9 from Bharadwaj Raju --- (In reply to EDeadLock from comment #8) > I would love to help fix this issue but I dont know where to start. I > managed to set up the neon docker container. How can I enable logging on the > settings app or edit the code and test? Sorry for the late reply. Please check out https://community.kde.org/Get_Involved/development which will help you about compiling the code etc. -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093 Nate Graham changed: What|Removed |Added Version|5.23.90 |5.23.5 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093 Patrick Silva changed: What|Removed |Added Version|5.21.5 |5.23.90 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093 --- Comment #8 from EDeadLock --- I would like to add that this issue isnt random and that it also shows up in other settings items other than Workspace Behavior. The issue only appears the first time you "visit" a settings page (e.g. Screen Edges page). Each time you revisit the page (by clicking on a different page and then going back to the original page) issue doesnt show up. To get the page to show the issue again you have to either go back to the main settings page or exit and reopen the settings app altogether. Something else I noticed. After revisiting a page and making the issue go away. It doesn't really go away. Well, it does go away but it shows a different issue. This is better explained with the screenshots I provided. On the tittles there are supposed to be a line that covers the entire page. The padding is not the same as the working pages (You will notice the working page titles are slightly more centered). And I also think the font is slightly smaller? but I cant confirm that I would love to help fix this issue but I dont know where to start. I managed to set up the neon docker container. How can I enable logging on the settings app or edit the code and test? One thing that I can try to do is going back to earlier versions because I know this issue wasnt here at some point (i cant remember when though lol or maybe im imagining things) As mentioned earlier, this issue also shows up in other settings items and under specific pages. Here is a painstakingly long list: Workspace Behavior: * Screen Edges * Touch Screen * Activities Window Management: * Window Behavior * Task Switcher * KWin Scripts Search: * Krunner * Web Search Keywords Regional Settings: * Spell Check * Date & Time Applications: * File Associations * Locations Settings: (Side rant: "Settings" should reeally be renamed to something else like "Advanced Network Settings") * Connection Preferences * SSL Preferences * Cookies Input devices: * Keyboard * Touchpad Display and Monitor: * Compositor Power Management: (This one would be a good place to start debugging as all the pages here have the issue) * Energy Savings * Active Power Settings * Advanced Power Settings Removable Storage: * Removable Devices -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093 --- Comment #7 from EDeadLock --- Created attachment 143438 --> https://bugs.kde.org/attachment.cgi?id=143438=edit Normal page -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093 EDeadLock changed: What|Removed |Added CC||maicolgabr...@hotmail.com --- Comment #6 from EDeadLock --- Created attachment 143437 --> https://bugs.kde.org/attachment.cgi?id=143437=edit Revisited page still with issues -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093 Nate Graham changed: What|Removed |Added Version|5.22.90 |5.21.5 --- Comment #5 from Nate Graham --- derp -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093 --- Comment #4 from Bharadwaj Raju --- (In reply to Nate Graham from comment #3) > Bharadwaj, could this have been caused by your changes to speed up KCM > loading in sidebar mode? I noticed that when working on it, but the issue remained even when I reverted the changes. Plus, look at the date this was reported :) -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093 Nate Graham changed: What|Removed |Added CC||bharadwaj.raju777@protonmai ||l.com --- Comment #3 from Nate Graham --- Bharadwaj, could this have been caused by your changes to speed up KCM loading in sidebar mode? -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093 Nate Graham changed: What|Removed |Added CC||kde@callthecomputerdoctor.c ||om --- Comment #2 from Nate Graham --- *** Bug 442960 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093 Nate Graham changed: What|Removed |Added Priority|NOR |LO -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093 Patrick Silva changed: What|Removed |Added Version|5.20.90 |5.22.90 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093 Patrick Silva changed: What|Removed |Added CC||kde...@agilob.net --- Comment #1 from Patrick Silva --- *** Bug 436233 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093 Nate Graham changed: What|Removed |Added CC||n...@kde.org Ever confirmed|0 |1 Status|REPORTED|CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 432093] KCM title is displayed above the sidebar
https://bugs.kde.org/show_bug.cgi?id=432093 Patrick Silva changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are watching all bug changes.
