Re: Review Request: Show Version Fixed In if available, for reports marked as FIXED
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101200/#review2850 --- Ship it! Hi Dario, Thanks for the patches. Here, I think the strings should say fixed ... in version %1 rather than fixed ... in %1. Other than that, it looks fine. - George On April 23, 2011, 12:27 p.m., Darío Andrés Rodríguez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101200/ --- (Updated April 23, 2011, 12:27 p.m.) Review request for KDE Runtime and George Kiagiadakis. Summary --- Use the Version Fixed In bugzilla field if it is available Diffs - drkonqi/reportassistantpages_bugzilla_duplicates.cpp a8a7fd0 Diff: http://git.reviewboard.kde.org/r/101200/diff Testing --- The version fixed in is shown, however, due to some bugzilla limitation the version numbers lack the dots (ex. 4.7.0 is shown as 4 7 0). Thanks, Darío Andrés
Re: Review Request: PATCH: Prevent SlaveBase::openPasswordDialog from automatically storing password information
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101174/ --- (Updated April 23, 2011, 2:43 p.m.) Review request for kdelibs. Changes --- Updated API documentation Changed the name of the AuthInfo extra field property to skip-caching-on-query Summary --- The attached patch changes the current behavior of openPasswordDialog such that it will not automatically store the password if the user checked the Remember password checkbox. This prevents the problem of storing the password information before the ioslaves had a chance to test whether or not the credentials can be used to successfully authentication against the server. IOW, it avoid the storage of invalid or incorrect password information. Diffs (updated) - kio/kio/slavebase.h f8ee99a kio/kio/slavebase.cpp 6432edb Diff: http://git.reviewboard.kde.org/r/101174/diff Testing --- Thanks, Dawit
Re: Window switch notification for plasma applets
On 04/14/2011 12:40 PM, Aaron J. Seigo wrote: On Wednesday, April 13, 2011 20:31:01 Andriy Rysin wrote: well as per top-level windows. So the question is whether there's a way to tell active/focused applet and get notified on switch? ah, and getting the current view() for the Applet or even checking the PID (since the switcher could be running in another non-desktop shell, e.g. plasma-windowed) might be useful too. So I played with it briefly and I can get focusItem inside the applet (if I don't set focus policy to NoFocus) but the problem is that the code which maps layouts to windows/applications reside in keyboard daemon which knows nothing about keyboard applet etc. I could of course notify keyboard daemon from keyboard layout applet (e.g. via dbus) that it became active/inactive but that's quite ugly. More than that there might be other applets which don't want to steal focus from windows. One such example is virtual keyboard applet - when it's clicked we most probably don't want to switch active window (to desktop) and change layout. So it would be nice to have some more generic solution. I could put a workaround in keyboard daemon to exclude keyboard layout and virtual keyboard applets from stealing active window but I would need to know how to get focused/active applet from outside of applet. And any help here is appreciated. Thanks Andriy
Deploying new kdelibs classes
Aurélien, I am writing regarding http://agateau.wordpress.com/2011/04/21/kde-ux-2011/ One thing, about deploying the kmessagewidget (and similar things) in kdelibs. If it's part of kdelibs 4.7 or something, apps that support kdelibs 4.7 would have to fork it (unless distro backports given classes to previous kdelibs but this it very bad idea and technically and coordination-wise). How to solve that? I am thinking about releasing additions to kdelibs as separate libraries like kdelibs47.so etc. and then merging only in 5.0. Perhaps there's already solution I am not aware of. -- regards / pozdrawiam, Jaroslaw Staniek http://www.linkedin.com/in/jstaniek Kexi Calligra (kexi-project.org, identi.ca/kexi, calligra-suite.org) KDE Software Development Platform on MS Windows (windows.kde.org)
Re: Review Request: First part of fixes for password caching in KIO: SlaveBase::openPaswordDialog
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101174/ --- (Updated April 24, 2011, 12:10 a.m.) Review request for kdelibs and David Faure. Summary (updated) --- The is the first part of a two part patch set that changes the current behavior of openPasswordDialog such that it will not automatically store the password even when the user checks the Remember password checkbox. The reason behind this change is to make sure incorrect or invalid password information is not stored in the wallet. And that can only be achieved if the ioslaves first have to verify the password information is valid by using it to gain access to the password protected server. Diffs - kio/kio/slavebase.h f8ee99a kio/kio/slavebase.cpp 6432edb Diff: http://git.reviewboard.kde.org/r/101174/diff Testing --- Thanks, Dawit
Re: Review Request: Second Part of fixes for password caching in KIO: KPasswdServer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101210/ --- (Updated April 24, 2011, 12:11 a.m.) Review request for kdelibs and David Faure. Summary --- The attached patch is the other half of the patch proposed in https://git.reviewboard.kde.org/r/101174/. It changes KPasswdServer to do the following: #1. If the extra field skip-caching-on-query is specified, then the queryAuthInfo* functions will not automatically store the password because the user checked the Remember password checkbox. This is essential for the changes made to SlaveBase::openPasswordDialog in #2. A call to addAuthInfo will now save the specified password information in the wallet. It is bit surprising that addAuthInfo seems to only update and/or store the information in memory. This again ensures that calling SlaveBase::cacheAuthentication information will actually result in the password information being saved into the wallet. Diffs - kpasswdserver/kpasswdserver.cpp 7330742 Diff: http://git.reviewboard.kde.org/r/101210/diff Testing --- Thanks, Dawit
