Re: Review Request 116122: Do not add trailing slash on http DELETE requests
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/#review52381 --- I'm a bit lost with your latest patch uploaded... Speaking about the third patch in this review (Diff r3) it seems it works as expected. That is if a server redirects a collection DELETE operation to a new Location with trailing slash added, redirection is correctly followed. From my part it is a ship for this one (Diff r3). - Andrea Iacovitti On March 7, 2014, 6:05 a.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/ --- (Updated March 7, 2014, 6:05 a.m.) Review request for kdelibs, Andrea Iacovitti and David Faure. Bugs: 331295 http://bugs.kde.org/show_bug.cgi?id=331295 Repository: kdelibs Description --- This patch fixes a prior commit, http://commits.kde.org/kdelibs/58294ac, which attempted to workaround webdav servers that do not accept delete requests on directories unless there is a trailing slash. It ensures that the fix is only applicable to webdav and the addition of the trailing slash is communicated to the client application. Diffs - kioslave/http/http.cpp 9eba5d1 Diff: https://git.reviewboard.kde.org/r/116122/diff/ Testing --- For HTTP delete: http://greenbytes.de/tech/tc/httpredirects/t301methods.html For WebDAV delete: http://boonfaya.com/sites/webdavapps.com/#targets Thanks, Dawit Alemayehu
Re: Review Request 116122: Do not add trailing slash on http DELETE requests
On March 8, 2014, 12:40 p.m., Andrea Iacovitti wrote: I'm a bit lost with your latest patch uploaded... Speaking about the third patch in this review (Diff r3) it seems it works as expected. That is if a server redirects a collection DELETE operation to a new Location with trailing slash added, redirection is correctly followed. From my part it is a ship for this one (Diff r3). Sorry I posted the wrong patch!! Will post the correct one. It is the same as Diff r3 except it adds a trailing slash to the directory URL before sending it to the http ioslave. - Dawit --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/#review52381 --- On March 7, 2014, 6:05 a.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/ --- (Updated March 7, 2014, 6:05 a.m.) Review request for kdelibs, Andrea Iacovitti and David Faure. Bugs: 331295 http://bugs.kde.org/show_bug.cgi?id=331295 Repository: kdelibs Description --- This patch fixes a prior commit, http://commits.kde.org/kdelibs/58294ac, which attempted to workaround webdav servers that do not accept delete requests on directories unless there is a trailing slash. It ensures that the fix is only applicable to webdav and the addition of the trailing slash is communicated to the client application. Diffs - kioslave/http/http.cpp 9eba5d1 Diff: https://git.reviewboard.kde.org/r/116122/diff/ Testing --- For HTTP delete: http://greenbytes.de/tech/tc/httpredirects/t301methods.html For WebDAV delete: http://boonfaya.com/sites/webdavapps.com/#targets Thanks, Dawit Alemayehu
Re: Review Request 116122: Do not add trailing slash on http DELETE requests
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/ --- (Updated March 8, 2014, 5:08 p.m.) Review request for kdelibs, Andrea Iacovitti and David Faure. Changes --- Uploaded the correct and final patch. Bugs: 331295 http://bugs.kde.org/show_bug.cgi?id=331295 Repository: kdelibs Description --- This patch fixes a prior commit, http://commits.kde.org/kdelibs/58294ac, which attempted to workaround webdav servers that do not accept delete requests on directories unless there is a trailing slash. It ensures that the fix is only applicable to webdav and the addition of the trailing slash is communicated to the client application. Diffs (updated) - kio/kio/deletejob.cpp b0268ef kioslave/http/http.cpp b4d64d4 Diff: https://git.reviewboard.kde.org/r/116122/diff/ Testing --- For HTTP delete: http://greenbytes.de/tech/tc/httpredirects/t301methods.html For WebDAV delete: http://boonfaya.com/sites/webdavapps.com/#targets Thanks, Dawit Alemayehu
Re: Review Request 116122: Do not add trailing slash on http DELETE requests
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/#review52410 --- Ship it! Ah, yes. That is the fix. - Andrea Iacovitti On March 8, 2014, 5:08 p.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/ --- (Updated March 8, 2014, 5:08 p.m.) Review request for kdelibs, Andrea Iacovitti and David Faure. Bugs: 331295 http://bugs.kde.org/show_bug.cgi?id=331295 Repository: kdelibs Description --- This patch fixes a prior commit, http://commits.kde.org/kdelibs/58294ac, which attempted to workaround webdav servers that do not accept delete requests on directories unless there is a trailing slash. It ensures that the fix is only applicable to webdav and the addition of the trailing slash is communicated to the client application. Diffs - kio/kio/deletejob.cpp b0268ef kioslave/http/http.cpp b4d64d4 Diff: https://git.reviewboard.kde.org/r/116122/diff/ Testing --- For HTTP delete: http://greenbytes.de/tech/tc/httpredirects/t301methods.html For WebDAV delete: http://boonfaya.com/sites/webdavapps.com/#targets Thanks, Dawit Alemayehu
Re: Review Request 116122: Do not add trailing slash on http DELETE requests
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/#review52413 --- This review has been submitted with commit e90577d4903d2c1b7a35e4a18efe3544132fbb57 by Dawit Alemayehu to branch KDE/4.12. - Commit Hook On March 8, 2014, 5:08 p.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/ --- (Updated March 8, 2014, 5:08 p.m.) Review request for kdelibs, Andrea Iacovitti and David Faure. Bugs: 331295 http://bugs.kde.org/show_bug.cgi?id=331295 Repository: kdelibs Description --- This patch fixes a prior commit, http://commits.kde.org/kdelibs/58294ac, which attempted to workaround webdav servers that do not accept delete requests on directories unless there is a trailing slash. It ensures that the fix is only applicable to webdav and the addition of the trailing slash is communicated to the client application. Diffs - kio/kio/deletejob.cpp b0268ef kioslave/http/http.cpp b4d64d4 Diff: https://git.reviewboard.kde.org/r/116122/diff/ Testing --- For HTTP delete: http://greenbytes.de/tech/tc/httpredirects/t301methods.html For WebDAV delete: http://boonfaya.com/sites/webdavapps.com/#targets Thanks, Dawit Alemayehu
Re: Review Request 116122: Do not add trailing slash on http DELETE requests
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/ --- (Updated March 8, 2014, 9:42 p.m.) Status -- This change has been marked as submitted. Review request for kdelibs, Andrea Iacovitti and David Faure. Bugs: 331295 http://bugs.kde.org/show_bug.cgi?id=331295 Repository: kdelibs Description --- This patch fixes a prior commit, http://commits.kde.org/kdelibs/58294ac, which attempted to workaround webdav servers that do not accept delete requests on directories unless there is a trailing slash. It ensures that the fix is only applicable to webdav and the addition of the trailing slash is communicated to the client application. Diffs - kio/kio/deletejob.cpp b0268ef kioslave/http/http.cpp b4d64d4 Diff: https://git.reviewboard.kde.org/r/116122/diff/ Testing --- For HTTP delete: http://greenbytes.de/tech/tc/httpredirects/t301methods.html For WebDAV delete: http://boonfaya.com/sites/webdavapps.com/#targets Thanks, Dawit Alemayehu
Re: Review Request 116604: Allow directories with . as output for meinproc
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116604/#review52419 --- This review has been submitted with commit 4406199290ab5192c178929fbc56a272e2fa8d7b by Luigi Toscano to branch master. - Commit Hook On March 5, 2014, 1:06 a.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116604/ --- (Updated March 5, 2014, 1:06 a.m.) Review request for Documentation, KDE Frameworks, kdelibs, and Aleix Pol Gonzalez. Bugs: 246755 https://bugs.kde.org/show_bug.cgi?id=246755 Repository: kdoctools Description --- The outputFile parameter is not used by the stylesheets, so don't pass it. If a directory starts with ., it is interpreted in a wrong way by libxslt with an error like: --- XPath error : Invalid expression /home/kde-devel/.cache5/khelpcenter/help/__home__kde- devel__kde__share__doc__HTML__en__kioslave__file__index.docbook ^ runtime error Evaluating user parameter outputFile failed --- This is an old issue, it was solved on windows by not compiling that code, but I suspect that the issue has been in UNIX systems too for a long time. Another way to solve the bug is quoting the value of the parameter with '...', replacing: params.append(qstrdup(parser.value(QStringLiteral(output)).toLocal8Bit().constData())); with something like QString quotedOutput = ' + parser.value(QStringLiteral(output)) + '; params.append(qstrdup(quotedOutput.toLocal8Bit().constData())); but anyway in this case the name of output file is not used, or I can't find any occurrence in the stylesheets. The stylesheet is applied and the name of the file is used only after to write the generated XML (see tranform() function). A similar patch can be applied to kdelibs/kdoctools too (same codepath). Diffs - src/meinproc.cpp 95adcea Diff: https://git.reviewboard.kde.org/r/116604/diff/ Testing --- Run meinproc5 (and 4) with -o /something/with/a/.dotdir/myfile.txt (the directory must exist), no error anymore and the file is generated. Thanks, Luigi Toscano
Re: Review Request 116604: Allow directories with . as output for meinproc
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116604/ --- (Updated March 8, 2014, 11:55 p.m.) Status -- This change has been marked as submitted. Review request for Documentation, KDE Frameworks, kdelibs, and Aleix Pol Gonzalez. Bugs: 246755 https://bugs.kde.org/show_bug.cgi?id=246755 Repository: kdoctools Description --- The outputFile parameter is not used by the stylesheets, so don't pass it. If a directory starts with ., it is interpreted in a wrong way by libxslt with an error like: --- XPath error : Invalid expression /home/kde-devel/.cache5/khelpcenter/help/__home__kde- devel__kde__share__doc__HTML__en__kioslave__file__index.docbook ^ runtime error Evaluating user parameter outputFile failed --- This is an old issue, it was solved on windows by not compiling that code, but I suspect that the issue has been in UNIX systems too for a long time. Another way to solve the bug is quoting the value of the parameter with '...', replacing: params.append(qstrdup(parser.value(QStringLiteral(output)).toLocal8Bit().constData())); with something like QString quotedOutput = ' + parser.value(QStringLiteral(output)) + '; params.append(qstrdup(quotedOutput.toLocal8Bit().constData())); but anyway in this case the name of output file is not used, or I can't find any occurrence in the stylesheets. The stylesheet is applied and the name of the file is used only after to write the generated XML (see tranform() function). A similar patch can be applied to kdelibs/kdoctools too (same codepath). Diffs - src/meinproc.cpp 95adcea Diff: https://git.reviewboard.kde.org/r/116604/diff/ Testing --- Run meinproc5 (and 4) with -o /something/with/a/.dotdir/myfile.txt (the directory must exist), no error anymore and the file is generated. Thanks, Luigi Toscano
