Re: Qt5 version of qimageblitz

2016-03-08 Thread Boudewijn Rempt

On Wed, 9 Mar 2016, Albert Astals Cid wrote:


I guess for that we need to decide if it should be a framework first or not.


Isn't kolourpaint the only user of qimageblitz at the moment? Krita used to use 
it, years and years ago, but that's no longer the case. If Kolourpaint is the 
only user, I'd actually suggest just taking the code into kolourpaint and 
dropping the library entirely.

--
Boudewijn Rempt | http://www.krita.org, http://www.valdyas.org


Re: Qt5 version of qimageblitz

2016-03-08 Thread Albert Astals Cid
El Tuesday 08 March 2016, a les 17:55:30, Ben Cooksley va escriure:
> On Tue, Mar 8, 2016 at 8:11 AM, Martin Koller  wrote:
> > On Sunday 06 March 2016 08:38:14 Boudhayan Gupta wrote:
> >> On 6 March 2016 at 01:26, Martin Koller  wrote:
> >> > Who is in charge of the old SVN repos ?
> >> > Who is in charge of qimageblitz ?
> >> 
> >> I asked around on IRC and it seems QIB is "community maintained" and
> >> as such doesn't have a maintainer.
> >> 
> >> You should just be able to file a sysadmin ticket to get it migrated
> >> from SVN to Git.
> > 
> > I started to create a sysadmin ticket, but I don't know
> > - "Initial maintainer identity user names, separated by ;"
> 
> Not sure how this can be clearer
> Username in this case is the same as the one in kde-common/accounts.
> 
> > - "Intended location on projects.kde.org, "
> 
> This is the location in the legacy tree.

I guess for that we need to decide if it should be a framework first or not.

Cheers,
  Albert

> 
> Cheers,
> Ben
> 
> > --
> > Best regards/Schöne Grüße
> > 
> > Martin
> > A: Because it breaks the logical sequence of discussion
> > Q: Why is top posting bad?
> > 
> > ()  ascii ribbon campaign - against html e-mail
> > /\- against proprietary attachments
> > 
> > Geschenkideen, Accessoires, Seifen, Kulinarisches: www.lillehus.at



Re: Product versions on bugs.kde.org

2016-03-08 Thread Nicolás Alvarez
2016-03-07 8:10 GMT-03:00 Jonathan Riddell :
> On Mon, Mar 07, 2016 at 09:25:40AM +0100, Kevin Funk wrote:
>> Is there a way to batch-modify those versions? Obviously noone wants to go
>> through the Bugzilla UI, adding versions one-by-one for each(!) framework.
>> /me found [1].
>>
>> PS: It's not just the case for frameworks, same applies to KDE Applications,
>> etc.
>>
>> Cheers,
>> Kevin
>>
>> [1] 
>> http://blog.asymptotic.co.uk/software-development-log/batch-modifying-bugzilla-milestones/
>>
>> --
>> Kevin Funk | kf...@kde.org | http://kfunk.org
>
>
> There's no API for this, I've no idea why not.

Just to confirm: There is indeed no API for this, not even in the new
Bugzilla 5.x which we don't have yet.

-- 
Nicolás


Re: Product versions on bugs.kde.org

2016-03-08 Thread Alexander Potashev
2016-03-09 1:09 GMT+03:00 Kevin Funk :
> Added all versions from 5.5.0 to 5.19.0.
>
> I've used this little gem here to "hammer" BKO:
>   http://paste.ubuntu.com/15330672/

This was a wrong thing to do because e.g. bluez-qt did not have
releases 5.5.0 through 5.10.0.

-- 
Alexander Potashev


Re: Product versions on bugs.kde.org

2016-03-08 Thread Kevin Funk
On Monday, March 7, 2016 1:23:01 PM CET Kevin Funk wrote:
> On Monday, March 7, 2016 11:10:13 AM CET Jonathan Riddell wrote:
> > On Mon, Mar 07, 2016 at 09:25:40AM +0100, Kevin Funk wrote:
> > > Is there a way to batch-modify those versions? Obviously noone wants to
> > > go
> > > through the Bugzilla UI, adding versions one-by-one for each(!)
> > > framework.
> > > /me found [1].
> > > 
> > > PS: It's not just the case for frameworks, same applies to KDE
> > > Applications, etc.
> > > 
> > > Cheers,
> > > Kevin
> > > 
> > > [1]
> > > http://blog.asymptotic.co.uk/software-development-log/batch-modifying-bu
> > > g
> > > zilla-milestones/
> > 
> > There's no API for this, I've no idea why not.
> > 
> > For Plasma I wrote a shell script which takes your browser cookie and
> > takes
> > a load of Product names and uses curl to do the calls to add the versions.
> > 
> > https://projects.kde.org/projects/playground/sdk/releaseme/repository/revi
> > si ons/master/entry/plasma/plasma-add-bugzilla-versions
> 
> Heh, nice one!
> 
> I'll try this out on Frameworks when I find the time.

Added all versions from 5.5.0 to 5.19.0.

I've used this little gem here to "hammer" BKO:
  http://paste.ubuntu.com/15330672/

@dfaure: Do you want me to commit that somewhere (obviously with just a single 
"version" instead of many), so you can simply invoke that script when 
releasing a new KF5 version?

Cheers,
Kevin

> Thanks!
> Kevin
> 
> > kde:releaseme
> > 
> > Jonathan


-- 
Kevin Funk | kf...@kde.org | http://kfunk.org

signature.asc
Description: This is a digitally signed message part.


Re: Review Request 127102: Use fixed width for digital clock applet

2016-03-08 Thread Daniel Faust

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127102/
---

(Updated März 8, 2016, 6:53 nachm.)


Review request for kde-workspace and Plasma.


Changes
---

Fix width calculation if zero is the widest character


Bugs: 347724
https://bugs.kde.org/show_bug.cgi?id=347724


Repository: plasma-workspace


Description
---

Currently the width of the date label is not fixed but changes depending on the 
text. This causes the entire applet to change its width (if the time is the 
widest displayed item). This in turn can cause all other applets in the same 
panel to move whenever the displayed time changes.

This patch uses FontMetrics to iterate over all possible time strings (with 
different width) and chooses the widest of them as reference for the fixed 
width of the time label.

This way the width of the applet stays the same (unless the date is displayed 
and changes). The text remains centered though, which means that it can still 
move within the applet when the time changes.


Diffs (updated)
-

  applets/digital-clock/package/contents/ui/DigitalClock.qml 95bb071 

Diff: https://git.reviewboard.kde.org/r/127102/diff/


Testing
---

Works with horizontal and vertical panel.
Also displaying different combinations of "seconds", "date" and "timezone" 
works.


Thanks,

Daniel Faust



Re: Review Request 127264: Set CMP0064 to OLD to suppress CMake warnings

2016-03-08 Thread Rohan Garg


> On March 3, 2016, 10:24 p.m., Aleix Pol Gonzalez wrote:
> > cmake/modules/KDE4Macros.cmake, line 1003
> > 
> >
> > Without the conditionals, the code would work just as well.
> 
> Rohan Garg wrote:
> Unless you have a CMake so old that said policy doesn't exist. For eg. on 
> Debian stable :)
> 
> Luigi Toscano wrote:
> (which is still 3.0.2, so way more than the minimum required version for 
> Frameworks (2.8.12))
> 
> Rohan Garg wrote:
> Except we're talking about kdelibs here, from the KDE 4 era.
> 
> Luigi Toscano wrote:
> Even better (for your patch)! 2.8.9 is the current minimum, so not old at 
> all for kdelibs4.
> 
> Rohan Garg wrote:
> Maybe I'm doing a terrible job of explaining it. The CMP0064 policy was 
> introduced in v3.4 , which is not available in Debian stable. Does that clear 
> things up? Or am I missing something?
> 
> Luigi Toscano wrote:
> I'm supporting your patch. My comment is in fact to point out that 
> version of cmake is not so old.

Ahh ok :)


- Rohan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127264/#review93107
---


On March 3, 2016, 6:28 p.m., Rohan Garg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127264/
> ---
> 
> (Updated March 3, 2016, 6:28 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> This follows the same idea from 826a5ff3278f492a99ac6827614e1d0ca40a45e8
> 
> 
> Diffs
> -
> 
>   cmake/modules/KDE4Macros.cmake 5bb2ffa 
> 
> Diff: https://git.reviewboard.kde.org/r/127264/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>



Re: Review Request 127264: Set CMP0064 to OLD to suppress CMake warnings

2016-03-08 Thread Luigi Toscano


> On March 3, 2016, 5:54 p.m., Aleix Pol Gonzalez wrote:
> > cmake/modules/KDE4Macros.cmake, line 1003
> > 
> >
> > Without the conditionals, the code would work just as well.
> 
> Rohan Garg wrote:
> Unless you have a CMake so old that said policy doesn't exist. For eg. on 
> Debian stable :)
> 
> Luigi Toscano wrote:
> (which is still 3.0.2, so way more than the minimum required version for 
> Frameworks (2.8.12))
> 
> Rohan Garg wrote:
> Except we're talking about kdelibs here, from the KDE 4 era.
> 
> Luigi Toscano wrote:
> Even better (for your patch)! 2.8.9 is the current minimum, so not old at 
> all for kdelibs4.
> 
> Rohan Garg wrote:
> Maybe I'm doing a terrible job of explaining it. The CMP0064 policy was 
> introduced in v3.4 , which is not available in Debian stable. Does that clear 
> things up? Or am I missing something?

I'm supporting your patch. My comment is in fact to point out that version of 
cmake is not so old.


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127264/#review93107
---


On March 3, 2016, 1:58 p.m., Rohan Garg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127264/
> ---
> 
> (Updated March 3, 2016, 1:58 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> This follows the same idea from 826a5ff3278f492a99ac6827614e1d0ca40a45e8
> 
> 
> Diffs
> -
> 
>   cmake/modules/KDE4Macros.cmake 5bb2ffa 
> 
> Diff: https://git.reviewboard.kde.org/r/127264/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>



Re: Review Request 127264: Set CMP0064 to OLD to suppress CMake warnings

2016-03-08 Thread Rohan Garg


> On March 3, 2016, 10:24 p.m., Aleix Pol Gonzalez wrote:
> > cmake/modules/KDE4Macros.cmake, line 1003
> > 
> >
> > Without the conditionals, the code would work just as well.
> 
> Rohan Garg wrote:
> Unless you have a CMake so old that said policy doesn't exist. For eg. on 
> Debian stable :)
> 
> Luigi Toscano wrote:
> (which is still 3.0.2, so way more than the minimum required version for 
> Frameworks (2.8.12))
> 
> Rohan Garg wrote:
> Except we're talking about kdelibs here, from the KDE 4 era.
> 
> Luigi Toscano wrote:
> Even better (for your patch)! 2.8.9 is the current minimum, so not old at 
> all for kdelibs4.

Maybe I'm doing a terrible job of explaining it. The CMP0064 policy was 
introduced in v3.4 , which is not available in Debian stable. Does that clear 
things up? Or am I missing something?


- Rohan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127264/#review93107
---


On March 3, 2016, 6:28 p.m., Rohan Garg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127264/
> ---
> 
> (Updated March 3, 2016, 6:28 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> This follows the same idea from 826a5ff3278f492a99ac6827614e1d0ca40a45e8
> 
> 
> Diffs
> -
> 
>   cmake/modules/KDE4Macros.cmake 5bb2ffa 
> 
> Diff: https://git.reviewboard.kde.org/r/127264/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>



Re: Review Request 127264: Set CMP0064 to OLD to suppress CMake warnings

2016-03-08 Thread Luigi Toscano


> On March 3, 2016, 5:54 p.m., Aleix Pol Gonzalez wrote:
> > cmake/modules/KDE4Macros.cmake, line 1003
> > 
> >
> > Without the conditionals, the code would work just as well.
> 
> Rohan Garg wrote:
> Unless you have a CMake so old that said policy doesn't exist. For eg. on 
> Debian stable :)
> 
> Luigi Toscano wrote:
> (which is still 3.0.2, so way more than the minimum required version for 
> Frameworks (2.8.12))
> 
> Rohan Garg wrote:
> Except we're talking about kdelibs here, from the KDE 4 era.

Even better (for your patch)! 2.8.9 is the current minimum, so not old at all 
for kdelibs4.


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127264/#review93107
---


On March 3, 2016, 1:58 p.m., Rohan Garg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127264/
> ---
> 
> (Updated March 3, 2016, 1:58 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> This follows the same idea from 826a5ff3278f492a99ac6827614e1d0ca40a45e8
> 
> 
> Diffs
> -
> 
>   cmake/modules/KDE4Macros.cmake 5bb2ffa 
> 
> Diff: https://git.reviewboard.kde.org/r/127264/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>



Re: Review Request 127264: Set CMP0064 to OLD to suppress CMake warnings

2016-03-08 Thread Rohan Garg


> On March 3, 2016, 10:24 p.m., Aleix Pol Gonzalez wrote:
> > cmake/modules/KDE4Macros.cmake, line 1003
> > 
> >
> > Without the conditionals, the code would work just as well.
> 
> Rohan Garg wrote:
> Unless you have a CMake so old that said policy doesn't exist. For eg. on 
> Debian stable :)
> 
> Luigi Toscano wrote:
> (which is still 3.0.2, so way more than the minimum required version for 
> Frameworks (2.8.12))

Except we're talking about kdelibs here, from the KDE 4 era.


- Rohan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127264/#review93107
---


On March 3, 2016, 6:28 p.m., Rohan Garg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127264/
> ---
> 
> (Updated March 3, 2016, 6:28 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> This follows the same idea from 826a5ff3278f492a99ac6827614e1d0ca40a45e8
> 
> 
> Diffs
> -
> 
>   cmake/modules/KDE4Macros.cmake 5bb2ffa 
> 
> Diff: https://git.reviewboard.kde.org/r/127264/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>



Re: Review Request 127264: Set CMP0064 to OLD to suppress CMake warnings

2016-03-08 Thread Luigi Toscano


> On March 3, 2016, 5:54 p.m., Aleix Pol Gonzalez wrote:
> > cmake/modules/KDE4Macros.cmake, line 1003
> > 
> >
> > Without the conditionals, the code would work just as well.
> 
> Rohan Garg wrote:
> Unless you have a CMake so old that said policy doesn't exist. For eg. on 
> Debian stable :)

(which is still 3.0.2, so way more than the minimum required version for 
Frameworks (2.8.12))


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127264/#review93107
---


On March 3, 2016, 1:58 p.m., Rohan Garg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127264/
> ---
> 
> (Updated March 3, 2016, 1:58 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> This follows the same idea from 826a5ff3278f492a99ac6827614e1d0ca40a45e8
> 
> 
> Diffs
> -
> 
>   cmake/modules/KDE4Macros.cmake 5bb2ffa 
> 
> Diff: https://git.reviewboard.kde.org/r/127264/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>



Re: Review Request 127264: Set CMP0064 to OLD to suppress CMake warnings

2016-03-08 Thread Rohan Garg


> On March 3, 2016, 10:24 p.m., Aleix Pol Gonzalez wrote:
> > cmake/modules/KDE4Macros.cmake, line 1003
> > 
> >
> > Without the conditionals, the code would work just as well.

Unless you have a CMake so old that said policy doesn't exist. For eg. on 
Debian stable :)


- Rohan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127264/#review93107
---


On March 3, 2016, 6:28 p.m., Rohan Garg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127264/
> ---
> 
> (Updated March 3, 2016, 6:28 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> This follows the same idea from 826a5ff3278f492a99ac6827614e1d0ca40a45e8
> 
> 
> Diffs
> -
> 
>   cmake/modules/KDE4Macros.cmake 5bb2ffa 
> 
> Diff: https://git.reviewboard.kde.org/r/127264/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>