Re: KJournald in KDE-Review
Neat!
- clazy has some hints
- you could probably use
https://api.kde.org/ecm/module/ECMQtDeclareLoggingCategory.html for
loggincategory.cpp/h?
- for qml you should probably use Kirigami.Units.gridUnit*N instead of
hardcoding sizes
- the hardcoded colors also seem a bit of an odd choice
- they are done already but for future reference you might want to
prefer i18nc over i18n, in particular for single word string such as
`i18n("Url:")` (which btw is also incorrectly capitalized)
- talking about... TopMenuBar doesn't consistently use Title Capitalization
- may be of interest to shove the raw journal pointer into a
unique_ptr asap:
https://invent.kde.org/plasma/drkonqi/-/blob/master/src/coredump/memory.h
On Sun, Oct 9, 2022 at 7:18 PM Andreas Cord-Landwehr
wrote:
>
> Hi, after a few releases over the past year, I would like to get KJournald
> included in KDE application releases. This project is about providing both an
> QItemModel abstraction library for the C-style journald API and providing an
> efficient graphical browser for journald logs.
>
> Sysadmins moved the repository to KDE Review today, you can find the source
> code here:
>
> https://invent.kde.org/libraries/kjournald
>
> (flatpack packaging is also available for easy trying it out)
>
> Even though KJournald is currently contained in the "libraries" playground
> module, I would like to get it included in the "utilities" module after
> passing KDE Review. The reason is that at the moment I more focus on the
> application part and that is the most user-facing part. Having it in
> "utilities" thus will avoid confusion.
>
> Looking forward for your review comments!
>
> Best regards,
> Andreas
>
>
Re: KJournald in KDE-Review
El diumenge, 9 d’octubre de 2022, a les 19:18:15 (CEST), Andreas Cord-Landwehr va escriure: > Hi, after a few releases over the past year, I would like to get KJournald > included in KDE application releases. This project is about providing both > an QItemModel abstraction library for the C-style journald API and > providing an efficient graphical browser for journald logs. > > Sysadmins moved the repository to KDE Review today, you can find the source > code here: > > https://invent.kde.org/libraries/kjournald > > (flatpack packaging is also available for easy trying it out) > > Even though KJournald is currently contained in the "libraries" playground > module, I would like to get it included in the "utilities" module after > passing KDE Review. The reason is that at the moment I more focus on the > application part and that is the most user-facing part. Having it in > "utilities" thus will avoid confusion. > > Looking forward for your review comments! automoc complains a bit about some properties https://pst.klgrth.io/paste/kf9ta If you're planning to use those from QML maybe a Q_INVOKABLE is better? You need to use -DTRANSLATION_DOMAIN on your library (i understand it's supposed to be usable by third party apps) valgrind is reporting a massive memory leak, you need to free the char* returned by sd_journal_get_cursor Cheers, Albert > > Best regards, > Andreas
KDE Frameworks 5.99.0 released
09th October 2022. KDE today announces the release of KDE Frameworks 5.99.0. KDE Frameworks are 83 addon libraries to Qt which provide a wide variety of commonly needed functionality in mature, peer reviewed and well tested libraries with friendly licensing terms. For an introduction see https://kde.org/products/frameworks/ Breeze Icons Add text/javascript symlink Extra CMake Modules Correctly separate multiple interface compile definitions Also resurrect std::auto_ptr on MSVC when using Exiv2 API dox: document KAPPTEMPLATESDIR & KFILETEMPLATESDIR KCalendarCore Use dtStart as the default for dtRecurrence KCMUtils Fix missing kcmutils_proxy_model export in static builds (bug 459123) Launch KCMs that are not part of systemsettings in kcmshell5 (bug 458975) KConfig Only warn about a file being inaccessible if we know which file it is Fix size and position restoration on multimonitor setups (bug 458963) Warn when accessing an inaccessible config file Fix minValue/maxValue for KConfigCompilerSignallingItem KConfigWidgets add KHamburgerMenu::insertIntoMenuBefore() method KContacts Make QtQuick trully optional KCoreAddons Cache portal urls Add new bugReportUrl standard metadata property (bug 370195) Add support for static builds Fix moc configuration of K_PLUGIN_CLASS macro Use a non-deprecated notify signal for the KJob::percent property KDBusAddons Don't assume we have X11 on Windows with Qt 6 Remove obsolete KDBusConnectionPool from the Qt 6 build Fix static compilation on non-X11 systems KDeclarative KeySequenceItem: Restore the previous value when it fails Remove project() calls from subdirs KeySequenceItem: Allow detecting when the key sequence is cleared (bug 458799) KeySequenceItem: Use the helper's shortcut instead of duplicating them KeySequenceItem: Disable clear button when there's no key sequence (bug 458798) KeySequenceItem: Cancel sequence recording when pressing the button KeySequenceItem: Remove workaround, it was addressed upstream KeySequenceItem: Show a cancel button when recording (bug 458796) GridDelegate: show tooltip when `toolTip` is empty and title/caption is elided (bug 459052) AbstractKCM: make footer top padding optional [kquickaddons/configmodule] Make getters const KDESU Drop setgid in favor of disabling process tracability explicitly KDE GUI Addons KeySequenceRecorder: Do not emit gotKeySequence when cancelling recorder: Allow setting the initial value of currentKeySequence recorder: Fix workaround in KDeclarative recorder: Do not keep two sequences at the same time (bug 458795) recorder: Never request inhibition twice for the same surface or seat (bug 458795) KHolidays # Add Japanese substitute holiday in 2023 KI18n Add useful info to warning Really support :usagetip cue (bug 459283) Warn if the domain is empty Mark codeLanguage as const KCatalog: make setting LANGUAGE env var more robust (bug 444614) KIconThemes KIconEngine: Use QFileInfo::completeBaseName KIconEngine: Return actual icon name of loaded icon (bug 432293) Add dedicated kiconloader_p.h header for KIconLoaderPrivate KIdleTime Add native wayland plugin xsyncbasedpoller ctor initialize m_sync_event KImageFormats pcx: Do not support sequential devices (bug 459541) Fix maximum number of channels (testcase added) LibRaw_QIODevice::seek() avoid seek on a sequential device LibRaw_QIODevice::seek() bounding checks Camera RAW images plugin (bug 454208: on my Debian with KF5.96 and the pulgin installed, I see the preview of all my RAW files (ARW included) in Dolphin) Enables opening of XCF files with Width and/or Height greater than 32K Replace C cast with reinterpret_cast avif: adjust for libavif breaking change in YUV<->RGB conversion Fix image allocation with Qt 6 KIO DesktopExecParser: Fix parsing of TerminalApplication when it contains args (bug 459408) KPropertiesDialog: Split single command entry box into separate exec and args (bug 455252) Allow hiding permissions tab Port http to workerbase Worker template: fix install location kcms/webshortcuts: hide from System Settings' main navigation Kirigami Improve DefaultListItemBackground code MnemonicAttached: Make sure to return StyledText-compatible strings for richTextLabel CategorizedSettings: ensure space for long words and don't wrap in weird places (bug 458393) private/PrivateCardsGridView.qml: Anchor DelegateRycler to an existing item ActionsMenu: Properly cleanup the menu Restore going back/forward in ColumnView using back/forward mouse buttons (bug 436790) Improve settingscomponents/CategorizedSettings.qml code formatting do not evaluate strings directly, use string's length instead show the title background when the title is aligned to vertical center Use new CI templates for static builds Add RestoreMode to Binding objects Examples: use normal target installation
KJournald in KDE-Review
Hi, after a few releases over the past year, I would like to get KJournald included in KDE application releases. This project is about providing both an QItemModel abstraction library for the C-style journald API and providing an efficient graphical browser for journald logs. Sysadmins moved the repository to KDE Review today, you can find the source code here: https://invent.kde.org/libraries/kjournald (flatpack packaging is also available for easy trying it out) Even though KJournald is currently contained in the "libraries" playground module, I would like to get it included in the "utilities" module after passing KDE Review. The reason is that at the moment I more focus on the application part and that is the most user-facing part. Having it in "utilities" thus will avoid confusion. Looking forward for your review comments! Best regards, Andreas
