Re: Review Request: Fix Bug 152156 - KDE help center does not respect window placement policy

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104662/#review13522
---


This review has been submitted with commit 
1e6399ee4c4e5de0317dfcc069b292e051580f27 by Maarten De Meyer to branch master.

- Commit Hook


On April 18, 2012, 4:01 p.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104662/
> ---
> 
> (Updated April 18, 2012, 4:01 p.m.)
> 
> 
> Review request for KDE Runtime and Cornelius Schumacher.
> 
> 
> Description
> ---
> 
> Fix Bug 152156 - KDE help center does not respect window placement policy
> 
> khelpcenter does not open in the middle of the screen with the kwin centered 
> window placement policy.
> 
> 1) remove setGeometry on mainwindow
> 2) include defaultsize to setupGui (application looked strange when only 
> using size hinting)
> 
> Any suggestions on a better default?
> 
> 
> This addresses bug 152156.
> http://bugs.kde.org/show_bug.cgi?id=152156
> 
> 
> Diffs
> -
> 
>   khelpcenter/mainwindow.cpp dd22425 
> 
> Diff: http://git.reviewboard.kde.org/r/104662/diff/
> 
> 
> Testing
> ---
> 
> Compiled, run, changed size, run again, remove configuration, run again
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

Re: Review Request: Fix Bug 152156 - KDE help center does not respect window placement policy

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104662/#review13521
---


This review has been submitted with commit 
b546f13eee28428363c74eac49a70f01c2f2bae6 by Maarten De Meyer to branch KDE/4.8.

- Commit Hook


On April 18, 2012, 4:01 p.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104662/
> ---
> 
> (Updated April 18, 2012, 4:01 p.m.)
> 
> 
> Review request for KDE Runtime and Cornelius Schumacher.
> 
> 
> Description
> ---
> 
> Fix Bug 152156 - KDE help center does not respect window placement policy
> 
> khelpcenter does not open in the middle of the screen with the kwin centered 
> window placement policy.
> 
> 1) remove setGeometry on mainwindow
> 2) include defaultsize to setupGui (application looked strange when only 
> using size hinting)
> 
> Any suggestions on a better default?
> 
> 
> This addresses bug 152156.
> http://bugs.kde.org/show_bug.cgi?id=152156
> 
> 
> Diffs
> -
> 
>   khelpcenter/mainwindow.cpp dd22425 
> 
> Diff: http://git.reviewboard.kde.org/r/104662/diff/
> 
> 
> Testing
> ---
> 
> Compiled, run, changed size, run again, remove configuration, run again
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

Re: Review Request: Fix Bug 152156 - KDE help center does not respect window placement policy

[Maarten De Meyer]

> On April 18, 2012, 6 p.m., Parker Coates wrote:
> > khelpcenter/mainwindow.cpp, line 170
> > 
> >
> > I've seen a few applications use a certain fraction of the screen size 
> > as the default. See 
> > http://websvn.kde.org/trunk/KDE/kdegames/kpat/mainwindow.cpp?view=markup#l118
> >  . I'm not sure that's necessarily the best default, though.
> 
> Thomas Lübking wrote:
> what's wrong with the last size?
> (is kmainwindow, stores and likely restores size)
> 
> Parker Coates wrote:
> Yes, but what's the last size if the app has never run before? :) The 
> *default* size is used only if there isn't a previous size.

Indeed, default only matters on first run.

I do not have commit access, could somebody pleas submit?
Thanks


- Maarten


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104662/#review12635
---


On April 18, 2012, 4:01 p.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104662/
> ---
> 
> (Updated April 18, 2012, 4:01 p.m.)
> 
> 
> Review request for KDE Runtime and Cornelius Schumacher.
> 
> 
> Description
> ---
> 
> Fix Bug 152156 - KDE help center does not respect window placement policy
> 
> khelpcenter does not open in the middle of the screen with the kwin centered 
> window placement policy.
> 
> 1) remove setGeometry on mainwindow
> 2) include defaultsize to setupGui (application looked strange when only 
> using size hinting)
> 
> Any suggestions on a better default?
> 
> 
> This addresses bug 152156.
> http://bugs.kde.org/show_bug.cgi?id=152156
> 
> 
> Diffs
> -
> 
>   khelpcenter/mainwindow.cpp dd22425 
> 
> Diff: http://git.reviewboard.kde.org/r/104662/diff/
> 
> 
> Testing
> ---
> 
> Compiled, run, changed size, run again, remove configuration, run again
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

Re: Review Request: Fix Bug 152156 - KDE help center does not respect window placement policy

[Parker Coates]

> On April 18, 2012, 6 p.m., Parker Coates wrote:
> > khelpcenter/mainwindow.cpp, line 170
> > 
> >
> > I've seen a few applications use a certain fraction of the screen size 
> > as the default. See 
> > http://websvn.kde.org/trunk/KDE/kdegames/kpat/mainwindow.cpp?view=markup#l118
> >  . I'm not sure that's necessarily the best default, though.
> 
> Thomas Lübking wrote:
> what's wrong with the last size?
> (is kmainwindow, stores and likely restores size)

Yes, but what's the last size if the app has never run before? :) The *default* 
size is used only if there isn't a previous size.


- Parker


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104662/#review12635
---


On April 18, 2012, 4:01 p.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104662/
> ---
> 
> (Updated April 18, 2012, 4:01 p.m.)
> 
> 
> Review request for KDE Runtime and Cornelius Schumacher.
> 
> 
> Description
> ---
> 
> Fix Bug 152156 - KDE help center does not respect window placement policy
> 
> khelpcenter does not open in the middle of the screen with the kwin centered 
> window placement policy.
> 
> 1) remove setGeometry on mainwindow
> 2) include defaultsize to setupGui (application looked strange when only 
> using size hinting)
> 
> Any suggestions on a better default?
> 
> 
> This addresses bug 152156.
> http://bugs.kde.org/show_bug.cgi?id=152156
> 
> 
> Diffs
> -
> 
>   khelpcenter/mainwindow.cpp dd22425 
> 
> Diff: http://git.reviewboard.kde.org/r/104662/diff/
> 
> 
> Testing
> ---
> 
> Compiled, run, changed size, run again, remove configuration, run again
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

Re: Review Request: Fix Bug 152156 - KDE help center does not respect window placement policy

[Parker Coates]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104662/#review12635
---

Ship it!



khelpcenter/mainwindow.cpp


I've seen a few applications use a certain fraction of the screen size as 
the default. See 
http://websvn.kde.org/trunk/KDE/kdegames/kpat/mainwindow.cpp?view=markup#l118 . 
I'm not sure that's necessarily the best default, though.


- Parker Coates


On April 18, 2012, 4:01 p.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104662/
> ---
> 
> (Updated April 18, 2012, 4:01 p.m.)
> 
> 
> Review request for KDE Runtime and Cornelius Schumacher.
> 
> 
> Description
> ---
> 
> Fix Bug 152156 - KDE help center does not respect window placement policy
> 
> khelpcenter does not open in the middle of the screen with the kwin centered 
> window placement policy.
> 
> 1) remove setGeometry on mainwindow
> 2) include defaultsize to setupGui (application looked strange when only 
> using size hinting)
> 
> Any suggestions on a better default?
> 
> 
> This addresses bug 152156.
> http://bugs.kde.org/show_bug.cgi?id=152156
> 
> 
> Diffs
> -
> 
>   khelpcenter/mainwindow.cpp dd22425 
> 
> Diff: http://git.reviewboard.kde.org/r/104662/diff/
> 
> 
> Testing
> ---
> 
> Compiled, run, changed size, run again, remove configuration, run again
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

Re: Review Request: Fix Bug 152156 - KDE help center does not respect window placement policy

[Thomas Lübking]

> On April 18, 2012, 6 p.m., Parker Coates wrote:
> > khelpcenter/mainwindow.cpp, line 170
> > 
> >
> > I've seen a few applications use a certain fraction of the screen size 
> > as the default. See 
> > http://websvn.kde.org/trunk/KDE/kdegames/kpat/mainwindow.cpp?view=markup#l118
> >  . I'm not sure that's necessarily the best default, though.

what's wrong with the last size?
(is kmainwindow, stores and likely restores size)


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104662/#review12635
---


On April 18, 2012, 4:01 p.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104662/
> ---
> 
> (Updated April 18, 2012, 4:01 p.m.)
> 
> 
> Review request for KDE Runtime and Cornelius Schumacher.
> 
> 
> Description
> ---
> 
> Fix Bug 152156 - KDE help center does not respect window placement policy
> 
> khelpcenter does not open in the middle of the screen with the kwin centered 
> window placement policy.
> 
> 1) remove setGeometry on mainwindow
> 2) include defaultsize to setupGui (application looked strange when only 
> using size hinting)
> 
> Any suggestions on a better default?
> 
> 
> This addresses bug 152156.
> http://bugs.kde.org/show_bug.cgi?id=152156
> 
> 
> Diffs
> -
> 
>   khelpcenter/mainwindow.cpp dd22425 
> 
> Diff: http://git.reviewboard.kde.org/r/104662/diff/
> 
> 
> Testing
> ---
> 
> Compiled, run, changed size, run again, remove configuration, run again
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>