Re: Review Request 114298: prevent ksplashqml crash when a theme does not exist or cannot be loaded
On Dec. 5, 2013, 12:23 a.m., Pino Toscano wrote: ksplash/ksplashqml/SplashApp.cpp, lines 148-150 http://git.reviewboard.kde.org/r/114298/diff/1/?file=222537#file222537line148 What about just calling ::exit(2) to reach the stdlib function, avoiding the exitNow wrapper? So that's how one does that xD Thanks for the tip! - Harald --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114298/#review45154 --- On Dec. 4, 2013, 1:54 p.m., Harald Sitter wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114298/ --- (Updated Dec. 4, 2013, 1:54 p.m.) Review request for kde-workspace and Ivan Čukić. Repository: kde-workspace Description --- Do not crash when failing to load a theme, but instead exit. When failing to load the theme's qml file QDeclarativeView goes into error state, at which point we want to exit to prevent nullptr access problems. Diffs - ksplash/ksplashqml/SplashApp.cpp 7c528d056ee680f69a6d3d60d1dbeeae9d548846 Diff: http://git.reviewboard.kde.org/r/114298/diff/ Testing --- ksplashqml Foo --test - sigsev without patch - exits with patch Thanks, Harald Sitter
Re: Review Request 114298: prevent ksplashqml crash when a theme does not exist or cannot be loaded
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114298/#review45167 --- This review has been submitted with commit 3ab6ca57de19ed1559accd632b46e27b1a4fd0eb by Harald Sitter to branch KDE/4.11. - Commit Hook On Dec. 4, 2013, 1:54 p.m., Harald Sitter wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114298/ --- (Updated Dec. 4, 2013, 1:54 p.m.) Review request for kde-workspace and Ivan Čukić. Repository: kde-workspace Description --- Do not crash when failing to load a theme, but instead exit. When failing to load the theme's qml file QDeclarativeView goes into error state, at which point we want to exit to prevent nullptr access problems. Diffs - ksplash/ksplashqml/SplashApp.cpp 7c528d056ee680f69a6d3d60d1dbeeae9d548846 Diff: http://git.reviewboard.kde.org/r/114298/diff/ Testing --- ksplashqml Foo --test - sigsev without patch - exits with patch Thanks, Harald Sitter
Re: Review Request 114298: prevent ksplashqml crash when a theme does not exist or cannot be loaded
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114298/ --- (Updated Dec. 5, 2013, 10:14 a.m.) Status -- This change has been marked as submitted. Review request for kde-workspace and Ivan Čukić. Repository: kde-workspace Description --- Do not crash when failing to load a theme, but instead exit. When failing to load the theme's qml file QDeclarativeView goes into error state, at which point we want to exit to prevent nullptr access problems. Diffs - ksplash/ksplashqml/SplashApp.cpp 7c528d056ee680f69a6d3d60d1dbeeae9d548846 Diff: http://git.reviewboard.kde.org/r/114298/diff/ Testing --- ksplashqml Foo --test - sigsev without patch - exits with patch Thanks, Harald Sitter
Review Request 114298: prevent ksplashqml crash when a theme does not exist or cannot be loaded
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114298/ --- Review request for kde-workspace and Ivan Čukić. Repository: kde-workspace Description --- Do not crash when failing to load a theme, but instead exit. When failing to load the theme's qml file QDeclarativeView goes into error state, at which point we want to exit to prevent nullptr access problems. Diffs - ksplash/ksplashqml/SplashApp.cpp 7c528d056ee680f69a6d3d60d1dbeeae9d548846 Diff: http://git.reviewboard.kde.org/r/114298/diff/ Testing --- ksplashqml Foo --test - sigsev without patch - exits with patch Thanks, Harald Sitter
Re: Review Request 114298: prevent ksplashqml crash when a theme does not exist or cannot be loaded
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114298/#review45099
---
Ship it!
ksplash/ksplashqml/SplashApp.cpp
http://git.reviewboard.kde.org/r/114298/#comment32244
add {}
- Martin Klapetek
On Dec. 4, 2013, 1:54 p.m., Harald Sitter wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114298/
---
(Updated Dec. 4, 2013, 1:54 p.m.)
Review request for kde-workspace and Ivan Čukić.
Repository: kde-workspace
Description
---
Do not crash when failing to load a theme, but instead exit.
When failing to load the theme's qml file QDeclarativeView goes into error
state, at which point we want to exit to prevent nullptr access problems.
Diffs
-
ksplash/ksplashqml/SplashApp.cpp 7c528d056ee680f69a6d3d60d1dbeeae9d548846
Diff: http://git.reviewboard.kde.org/r/114298/diff/
Testing
---
ksplashqml Foo --test
- sigsev without patch
- exits with patch
Thanks,
Harald Sitter
Re: Review Request 114298: prevent ksplashqml crash when a theme does not exist or cannot be loaded
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114298/#review45154 --- ksplash/ksplashqml/SplashApp.cpp http://git.reviewboard.kde.org/r/114298/#comment32271 What about just calling ::exit(2) to reach the stdlib function, avoiding the exitNow wrapper? - Pino Toscano On Dec. 4, 2013, 1:54 p.m., Harald Sitter wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114298/ --- (Updated Dec. 4, 2013, 1:54 p.m.) Review request for kde-workspace and Ivan Čukić. Repository: kde-workspace Description --- Do not crash when failing to load a theme, but instead exit. When failing to load the theme's qml file QDeclarativeView goes into error state, at which point we want to exit to prevent nullptr access problems. Diffs - ksplash/ksplashqml/SplashApp.cpp 7c528d056ee680f69a6d3d60d1dbeeae9d548846 Diff: http://git.reviewboard.kde.org/r/114298/diff/ Testing --- ksplashqml Foo --test - sigsev without patch - exits with patch Thanks, Harald Sitter
