Re: Review Request 130239: Exclude kconf_update from catching by uac on Windows

[Ralf Habacker]

> On Sept. 26, 2017, 8:02 p.m., Albert Astals Cid wrote:
> > cmake/modules/Win32Macros.cmake
> > Lines 61 (patched)
> > 
> >
> > I don't think it makes sense adding a new public-ish macro in 4.14.lots
> 
> Ralf Habacker wrote:
> See revision 1 of this patch at 
> https://git.reviewboard.kde.org/r/130239/diff/1/
> 
> Albert Astals Cid wrote:
> I'm personally happier with that patch for almost dead 4.14 (it has 2 
> releases left), now you're going to need someone with a win32 build/knowledge 
> to approve since honestly i have no idea what this does.
> 
> Ralf Habacker wrote:
> > for almost dead 4.14 (it has 2 releases left),
> 
> Looking at the number of open KF5 related windows issues I guess kmymoney 
> and umbrello for Windows will depends on KDE4 at least a year. 
> 
> >i have no idea what this does.
> 
> From 
> https://stackoverflow.com/questions/20096706/how-does-windows-decide-whether-to-display-the-uac-prompt
> 
> kconf_update is "hitting a Windows Installer Detection Technology 
> compatibility heuristic. Windows will try to detect when an application is an 
> installer, and probably needs to be elevated."
> 
> BTW: The same issue happens also with KF5
> 
> Alexey Min wrote:
> This looks good and harmless actually. As I understood, it adds a .rc 
> (windows resource file) with embedded manifest resource, saying that no 
> elevation is needed for this .exe file.
> We at our work also had problems with this windows heuristic (we had a 
> helper program, containing "setup" in its name, so it magically required 
> administrator rights with no real need for this).
> So if this really works and helps for windows, why not.
> 
> Albert Astals Cid wrote:
> > Looking at the number of open KF5 related windows issues I guess 
> kmymoney and umbrello for Windows will depends on KDE4 at least a year. 
> 
> That has nothing to do with kdelibs 4.14.x not being released anymore 
> after KDE Applications 17.08.3, which is what i said
> 
> Luigi Toscano wrote:
> Also, most of the "KF5 issues" for umbrello (for example) are mostly 
> related to cross-compilation and co-installability (which should not care, 
> once you have the KF5 version you ignore the other), so not blocker for the 
> release:
> https://bugs.kde.org/showdependencytree.cgi?id=373932_resolved=0
> Some are related to icons (so probably something with Qt). Anyway, most 
> of the "issues" are not real issue for a pure KF5 release with an independent 
> installer.
> I bet on way less than one year. But again, it is out of scope for this.

> So if this really works and helps for windows, why not.

so please press ship it

> But again, it is out of scope for this

where could we discuss such issues ?


- Ralf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130239/#review103738
---


On Sept. 27, 2017, 11:19 a.m., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130239/
> ---
> 
> (Updated Sept. 27, 2017, 11:19 a.m.)
> 
> 
> Review request for kdelibs and Albert Astals Cid.
> 
> 
> Bugs: 384334
> http://bugs.kde.org/show_bug.cgi?id=384334
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> This patch fixes an issue that on the first start of KMyMoney (and on some 
> computers on every start for example reported by 
> https://forum.kde.org/viewtopic.php?f=69=141673=ba4dcaa26018f16e19d21c58c34ad4e9)
>  on running kconf_update the user account control pops up and forces the user 
> to allow or deny  this application.
> 
> Commit message
> 
>Add Windows manifest to  kconf_update.exe
> 
> This explicitly sets the execution level to 'asInvoker', preventing
> Windows' UAC heuristics from deciding that because its name mentions
> "update", it probably needs to escalate privileges.
> 
> FIXED-IN:4.14.36
> BUG:384334
> 
> 
> Diffs
> -
> 
>   kconf_update/CMakeLists.txt 6bf3bf1f923baf11aad63e10fe249d70ce1b4d33 
> 
> 
> Diff: https://git.reviewboard.kde.org/r/130239/diff/3/
> 
> 
> Testing
> ---
> 
> Compiled at 
> https://build.opensuse.org/package/show/windows%3Amingw%3Awin32/mingw32-kdelibs4
>  and tested with KMyMoney snapshot for Windows downloadable from 
> https://software.opensuse.org/package/mingw32-kmymoney-portable
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Latte Dock in review phase

[Adriaan de Groot]

On Friday, 6 October 2017 09:47:26 CEST Jonathan Riddell wrote:
> Looks good from a brief look around I did from a packagers point of
> view (so not looking at the code).

The licensing is a funky (not bad, just .. unusual) mix of LGPL v2+ and GPL 
v2+; for instance app/ contains 7 files licensed  LGPL v2+, the rest looks like 
GPL v2+.

The code doesn't compile with clang. extras.h contains a definition of 
make_unique() for old GLIBCXX. That doesn't seem consistent with the required 
C++ version, C++14. The check is also wrong for clang / libstc++ , since it 
probably doesn't define __GLIBCXX__ at all. That definition should probably 
just 
be removed.

visibilitymanager_p.h is missing  as an include -- probably g++ 
#includes it via some round-about path, but clang / libstdc++ doesn't.

[ade]

signature.asc
Description: This is a digitally signed message part.

Latte Dock in review phase

[Michail Vourlakos]

Hello everyone,

we decided to make Latte an active kde project and so now it is in review
phase. I believe the best place to be is extragear because we would like to
keep some independence for the first year concerning releases...

What is Latte Dock?

Latte is a project that is trying to provide a unified solution concering
docks and panels for the user. To achieve this it provides,
the Latte app, a Latte qml library, a Latte containment, a Latte plasmoid,
a Latte shell that uses plasma shell as base and 2 applets (a separator and
a specialized spacer)

for more infos concerning the capabilities of the Latte suite you can find
at:
https://psifidotos.blogspot.nl/2017/04/latte-dock-v06-fresh-air.html
https://psifidotos.blogspot.nl/2017/08/latte-dock-v07-tornado-is-coming.html

the project before entering the kde infrastructure could be found at:
https://github.com/psifidotos/Latte-Dock

in review you can find our 0.7.1 version which is our stable version and
the plan is that after we succeed in the review phase to release a 0.7.2
version only through kde infrastructure...

regards,
michail

Re: Latte Dock in review phase

[Jonathan Riddell]

Looks good from a brief look around I did from a packagers point of
view (so not looking at the code).

I'm unsure why it's both a plasmoid and a standalone binary, that
seems superfluous.  Maybe it's for use outwith Plasma.

docs/ directory seems unused

Green build in neon :)
https://build.neon.kde.org/job/xenial_unstable_kde-extras_latte-dock/

Jonathan


On 4 October 2017 at 22:00, Michail Vourlakos  wrote:
> Hello everyone,
>
> we decided to make Latte an active kde project and so now it is in review
> phase. I believe the best place to be is extragear because we would like to
> keep some independence for the first year concerning releases...
>
> What is Latte Dock?
>
> Latte is a project that is trying to provide a unified solution concering
> docks and panels for the user. To achieve this it provides,
> the Latte app, a Latte qml library, a Latte containment, a Latte plasmoid, a
> Latte shell that uses plasma shell as base and 2 applets (a separator and a
> specialized spacer)
>
> for more infos concerning the capabilities of the Latte suite you can find
> at:
> https://psifidotos.blogspot.nl/2017/04/latte-dock-v06-fresh-air.html
> https://psifidotos.blogspot.nl/2017/08/latte-dock-v07-tornado-is-coming.html
>
> the project before entering the kde infrastructure could be found at:
> https://github.com/psifidotos/Latte-Dock
>
> in review you can find our 0.7.1 version which is our stable version and the
> plan is that after we succeed in the review phase to release a 0.7.2 version
> only through kde infrastructure...
>
> regards,
> michail