D7367: Added Intel HEX file support for the Syntax highlighting database

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  I am happy beside one thing I missed: I think the file should be called 
intelhex.xml, given its for the intel hex format only (the name is already 
fine, did miss that the filename is only hex).
  Otherwise: very nice, thanks again for the contribution.

REVISION DETAIL
  https://phabricator.kde.org/D7367

To: martonmiklos, #framework_syntax_hightlighting, cullmann
Cc: dhaumann, cullmann, #frameworks, vkrause

D7443: Fix compilation on windows with editorconfig-c-core available

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I think this is more correct, just writing the unix libname was no good idea.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D7443

To: sars, cullmann, #kate
Cc: dhaumann, kwrite-devel, #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it

[Nathaniel Graham]

ngraham retitled this revision from "Populate UDS_CREATION_TIME on Linux if Qt 
version and kernel support it" to "Populate UDS_CREATION_TIME on Linux if Qt 
and kernel versions support it".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if Qt version and kernel support it

[Nathaniel Graham]

ngraham added a comment.


  Great, thanks guys. Thanks for bearing with me here. I'll see if I can test 
with the unreleased qtbase.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if Qt version and kernel support it

[Nathaniel Graham]

ngraham retitled this revision from "Populate UDS_CREATION_TIME on Linux if Qt 
version and Linux kernel support it (no effect if they don't) BUG: 286689" to 
"Populate UDS_CREATION_TIME on Linux if Qt version and kernel support it".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks

D7367: Added Intel HEX file support for the Syntax highlighting database

[Dominik Haumann]

dhaumann added a comment.


  @cullmann Since you seem to know this, please take care of this change 
request :-)

REVISION DETAIL
  https://phabricator.kde.org/D7367

To: martonmiklos, #framework_syntax_hightlighting
Cc: dhaumann, cullmann, #frameworks, vkrause

D7443: Fix compilation on windows with editorconfig-c-core available

[Dominik Haumann]

dhaumann added a comment.


  @cullmann Is this the right fix, or could this also be fixed in 
FindEditorConfig.cmake?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D7443

To: sars, cullmann, #kate
Cc: dhaumann, kwrite-devel, #frameworks

D7280: Add syntax highlighting for Metamath

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:2baf9eb98c4e: Add syntax highlighting for Metamath 
(authored by dhaumann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7280?vs=18373=18466

REVISION DETAIL
  https://phabricator.kde.org/D7280

AFFECTED FILES
  autotests/folding/test.mm.fold
  autotests/html/test.mm.html
  autotests/input/test.mm
  autotests/input/test.mm.syntax
  autotests/reference/test.mm.ref
  data/syntax/metamath.xml

To: aaronpuchert, #frameworks, dhaumann
Cc: dhaumann

D7280: Add syntax highlighting for Metamath

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Looks good to me. Will integrate this soon.
  
  By the way, you may want to apply for a KDE contributor account to commit 
your changes yourself, especially since you are providing patches already since 
April or so, see:
  https://community.kde.org/Infrastructure/Get_a_Developer_Account

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  metamath

REVISION DETAIL
  https://phabricator.kde.org/D7280

To: aaronpuchert, #frameworks, dhaumann
Cc: dhaumann

D7423: Populate UDS_CREATION_TIME on Linux if Qt version and Linux kernel support it (no effect if they don't) BUG: 286689

[David Faure]

dfaure added a comment.


  Ah, OK, I see.
  Well, still, you could test the patch by compiling qtbase dev (or by applying 
whichever Qt patch is necessary).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if Qt version and Linux kernel support it (no effect if they don't) BUG: 286689

[Luigi Toscano]

ltoscano added a comment.


  The title of the revision becomes the first line; all the rest (summary, 
test, reviewers) become the rest of the content, a blank separator line is 
added automatically. Please add the BUG: line in the summary, not in the title.
  Also, as the title becomes the first line, it would be nice to follow the 
usual git rules of length.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if Qt version and Linux kernel support it (no effect if they don't) BUG: 286689

[Nathaniel Graham]

ngraham added a comment.


  Noted! Thanks, Luigi. I'd like to add BUG: 286689 to the commit message on a 
separate line. Does the title of this revision become the commit message? If 
so, how do I add another line? The text field doesn't seem to support 
multi-line strings.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if Qt version and Linux kernel support it (no effect if they don't) BUG: 286689

[Nathaniel Graham]

ngraham retitled this revision from "Populate UDS_CREATION_TIME on Linux if Qt 
version and Linux kernel support it (no effect if they don't)" to "Populate 
UDS_CREATION_TIME on Linux if Qt version and Linux kernel support it (no effect 
if they don't) BUG: 286689".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if Qt version and Linux kernel support it (no effect if they don't)

[Nathaniel Graham]

ngraham retitled this revision from "Populate UDS_CREATION_TIME on Linux if QT 
version and Linux kernel support it (no effect if they don't)" to "Populate 
UDS_CREATION_TIME on Linux if Qt version and Linux kernel support it (no effect 
if they don't)".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if QT version and Linux kernel support it (no effect if they don't)

[Luigi Toscano]

ltoscano added a comment.


  I can't comment on the content of the patch, but about the commit message, in 
order to close a bug, use the syntax:
  
  BUG: nn
  
  while in order to add the commit as comment of a bug without closing it, use
  
  CCBUG: nn
  
  Both keyword should be in a separate line.
  
  Also, it's Qt, not QT.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if QT version and Linux kernel support it (no effect if they don't)

[Nathaniel Graham]

ngraham added a comment.


  This patch doesn't actually directly use statx(); it goes through QFile, 
which is used to populate the statbuf object. QT has gained support for using 
statx() in Linux where available in current git master 
, 
but that change hasn't landed in an actual released QT version yet.
  
  If you can point me to a way to test this, I'll be happy to.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if QT version and Linux kernel support it (no effect if they don't)

[David Faure]

dfaure added a comment.


  The commit log is inconsistent with the actual patch. It says "lack of a Qt 
version that supports this", but the patch doesn't use QFile at all, it uses 
statx. Either way, the patch can be tested, no?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: #frameworks

D7443: Fix compilation on windows with editorconfig-c-core available

[Kåre Särs]

sars created this revision.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  On Windows the library was found during config, but not during compilation 
without the variable EditorConfig_LIBRARIES.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D7443

AFFECTED FILES
  src/CMakeLists.txt

To: sars, cullmann, #kate
Cc: kwrite-devel, #frameworks

KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.7 - Build # 78 - Fixed!

[no-reply]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.7/78/
 Project:
Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.7
 Date of build:
Sun, 20 Aug 2017 19:15:23 +
 Build duration:
2 min 58 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 8 test(s)

build.log
Description: Binary data

KDE CI: Frameworks syntax-highlighting kf5-qt5 XenialQt5.7 - Build # 80 - Fixed!

[no-reply]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20XenialQt5.7/80/
 Project:
Frameworks syntax-highlighting kf5-qt5 XenialQt5.7
 Date of build:
Sun, 20 Aug 2017 19:15:23 +
 Build duration:
3 min 11 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)92%
(36/39)92%
(36/39)85%
(2111/2490)69%
(1559/2263)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)97%
(501/515)60%
(319/534)src.indexer100%
(1/1)100%
(1/1)72%
(60/83)77%
(75/98)src.lib90%
(27/30)90%
(27/30)82%
(1550/1892)71%
(1165/1631)

build.log
Description: Binary data

Re: GOAL: seriously accommodate >96 DPI users

[Nate Graham]

On 08/20/2017 12:26 PM, Felix Miata wrote:

Lydia Pintscher composed on 2017-08-20 15:17 (UTC+0200):


* Appeal to All our Senses: a visually impaired user should be able to
use all the software produced by KDE;


Put an end to the creation of "situational impairment" described on:
http://www.telegraph.co.uk/science/2016/10/23/internet-is-becoming-unreadable-because-of-a-trend-towards-light/
(second paragraph prior to last of article)


I agree with you on the subject of readability and text contrast, Felix. 
FYI I have an open phabricator patch to slightly improve text contrast 
and readability in the default Breeze text color scheme: 
https://phabricator.kde.org/D7424


Baby steps! :)

Nate

Re: GOAL: seriously accommodate >96 DPI users (was: Let's set some goals)

[Felix Miata]

Lydia Pintscher composed on 2017-08-20 15:17 (UTC+0200):

> * Appeal to All our Senses: a visually impaired user should be able to
> use all the software produced by KDE;

Put an end to the creation of "situational impairment" described on:
http://www.telegraph.co.uk/science/2016/10/23/internet-is-becoming-unreadable-because-of-a-trend-towards-light/
(second paragraph prior to last of article)

Example 1:
KDE (ostensibly justifiably) blames problem on upstream:

[a11y][u7y] kcmshell5 fonts - > Choose (Select Font) initial window size much
too small (DPI>96)
https://bugs.kde.org/show_bug.cgi?id=346122

Then upstream it lies fallow:
https://bugreports.qt.io/browse/QTBUG-45522

The font selection dialogs are hardly the only KDE dialogs that open too small
when DPI is >96. It's pretty standard that first action on dialog open in those
environments is (try to) make it bigger so that its content reasonably fits its
window size:
picker window always opens with the left pane so narrow that most entries are
indistinguishable from others <https://bugs.kde.org/show_bug.cgi?id=297217>
http://fm.no-ip.com/SS/KDE/narrowWindow143-201708201148.jpg (cuts off selects)

Example 2:
That screenshot also exhibits too small titlebar icons, resulting from the
multitude of similar systemsettings contexts obfuscating whatever location may
exist for control of those sizes. What is needed is for them to be
/*automatically*/ adjusted larger when display density is >96 DPI. OTOH, whether
due to theming or otherwise, /all/ configurability regarding icon sizing needs
to be consolidated under one umbrella category (e.g. Icons) rather than being
incorporated among components of "Workspace Theme", "Icons", "Application
Style", "Accessibility" and wherever any others may be ensconced.

Example 3:
https://phabricator.kde.org/
143 DPI screenshot including it:
http://fm.no-ip.com/SS/KDE/phabricator-20170820-2600-143.jpg

This is an example of how web sites generally, and kde.org in particular, usurps
needs and preferences of web users through sites' manner of styling. In the
screenshot you can see the mouse pointer pointing to the following CSS rule:

body {
font: 13px 'Segoe UI','Segoe UI Emoji','Segoe UI Symbol','Lato',
'Helvetica Neue',Helvetica,Arial,sans-serif;...

What that rule does is ensure:
1-the user is unlikely to enjoy seeing his personally optimal font family in use
anywhere on kde.org (as can be seen from fc-match in screenshot: Droid Sans).
2-the user is unlikely to be unable to read anything on the kde.org page until
applying defensive measure(s) against the offensive behavior that is the CSS
declaration of font sizes in px units. The 13px size employed on kde.org can be
seen to be 29.3% of the browser's preferred size (as can be seen in screenshot)
of 24px, 16^2 / 24^2 being the calculation of (physical) size (as opposed to
nominal size, which is the singular length of glyph height) to reach 29.3%.

If you'll open the URL displayed in the screenshot's right side Firefox window,
<http://fm.no-ip.com/Inet/grayurls.html>, you'll be able to see an example of
styling that accommodates users settings. Its CSS body text inherits the browser
defaults of both size and family, here, 24px and Droid Sans. FWIW, 24px happens
to equate to 12pt at the 143 DPI display density environment of the Plasma 5
screenshot host. 12pt is the size all virtually all web browsers have
historically shipped with as default, literally 12pt in some (e.g. Internet
Explorer), more often as 16px (e.g. Firefox and Safari), which in *real* world
sizing equates to 12pt @ 96 DPI.

<http://fm.no-ip.com/Auth/dpi-screen-window.html> as open there in the SeaMonkey
window, can be used, within constraints indicated thereon, to confirm your
browser's font size setting, and the /accuracy/ (which is not necessarily
indicative of suitability) of the DE host's display density configuration.
Simply use a ruler on one of its black blocks to check.

Similar technique can be employed with phabricator-20170820-2600-143.jpg. By
opening it in a viewer that permits it to be arbitrarily resized, you can adjust
its black blocks to measure their indicated width, thus closely emulating the
environment in which it was originated and see it as it was seen, at least WRT
proportions if not details.

There's much to be done to have KDE appeal to users:

1-whose eyesight is poorer than, or preferences different from, those of
software developers

2-who employ larger displays intending to enjoy larger screen objects rather
than fitting more screen objects
-- 
"The wise are known for their understanding, and pleasant
words are persuasive." Proverbs 16:21 (New Living Translation)

 Team OS/2 ** Reg. Linux User #211409 ** a11y rocks!

Felix Miata  ***  http://fm.no-ip.com/

D7439: Don't clear Qt's SSL CA certificate store

[Volker Krause]

vkrause created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  This breaks all subsequent SSL connections using QSslSocket or QNAM.
  
  Thiago said about this on #kde-devel: "in the old days, it used to be
  because Qt shipped with a very old database, we haven't done that in
  8 years".

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7439

AFFECTED FILES
  src/core/ksslcertificatemanager.cpp

To: vkrause, #frameworks

D7010: KSqueezedTextLabel: call updateGeometry() when text changes

[Henrik Fehlauer]

rkflx added a comment.


  Probably related to 
https://phabricator.kde.org/R32:3e530e780b596e9505b66e1ae7b1044d335adb07 (I 
guess Phabricator only adds "mentions" for shortlinks like Dxxx, but not full 
URLs?).

REVISION DETAIL
  https://phabricator.kde.org/D7010

To: brauch, cfeck, rkflx
Cc: dhaumann, aacid, #frameworks

Re: Let's set some goals

[Nate Graham]

I have two ideas:

- Improve bugzilla process for new users: https://phabricator.kde.org/T6832

- Aggressively focus on usability and productivity: 
https://phabricator.kde.org/T6831


Nate Graham



On 08/20/2017 07:17 AM, Lydia Pintscher wrote:

Hey folks :)

Since 2015 I and other people have been talking about Evolving KDE
(http://blog.lydiapintscher.de/2015/04/18/evolving-kde) - meaning
reflecting on where we are, where we want to go and how we will get
there. We have made great strides with defining our vision
(https://community.kde.org/KDE/Vision) and mission
(https://community.kde.org/KDE/Mission) since then. It has not been an
easy exercise but a necessary one because it gives us focus and
clarity about our purpose.

Our vision is: "A world in which everyone has control over their
digital life and enjoys freedom and privacy." We stand behind this. We
want to fill this vision with life now. Kévin Ottens, Mirko Boehm,
David Faure, Frederik Gladhorn, me and many others came together at
Akademy to discussed how to do that. How can we give the whole KDE
community the opportunity to express what they think we should all be
working on right now? How can we find all the creative ideas and
ambitions that are hidden in so many of our community members? And how
can we talk about them all together? I believe we have found a way.

Starting today all of KDE is invited to propose goals to work on for
the next 3 to 4 years. We will then discuss and refine them. Finally
we will have a vote for the goals we should pursue together. Goals can
be about anything you consider important - it doesn't have to be about
writing code. The top 3 proposals will get supported in various ways
for example with sponsorship of a sprint and presentation slots at
next year's Akademy. This way we will shine a spotlight on the most
important things we are working on and together support that work in
the best way we can. The plan is to do this every year and add one or
two goals to the mix every time.

The timeline looks as follows:
* Today until beginning of October: work on the proposals
* All of October: talk about the proposal
* First two weeks of November: vote on the proposals by everyone with
a KDE contributor account
* Middle of November: publish the results

To make it more concrete, here are some examples of potential goals
that could come out of this:
* Improving the Developer Story: a new contributor should be able to
create his first patch to any KDE application in 15 minutes or less;
* Big in Asia: users in Asia should be able to write in their writing
system in any of the software produced by KDE;
* Appeal to All our Senses: a visually impaired user should be able to
use all the software produced by KDE;
* Virtual Reality Painting: artists should be able to paint in 3D
straight from a VR world using software produced by KDE;
* Speaking Your Language: 90% of the computer users worldwide should
be able to use the software produced by KDE in a language in which
they are fluent.

Do you have an idea for a goal for KDE? Get a small group of people
together and propose it today by adding it here:
https://phabricator.kde.org/project/board/244/


Cheers
Lydia

Let's set some goals

[Lydia Pintscher]

Hey folks :)

Since 2015 I and other people have been talking about Evolving KDE
(http://blog.lydiapintscher.de/2015/04/18/evolving-kde) - meaning
reflecting on where we are, where we want to go and how we will get
there. We have made great strides with defining our vision
(https://community.kde.org/KDE/Vision) and mission
(https://community.kde.org/KDE/Mission) since then. It has not been an
easy exercise but a necessary one because it gives us focus and
clarity about our purpose.

Our vision is: "A world in which everyone has control over their
digital life and enjoys freedom and privacy." We stand behind this. We
want to fill this vision with life now. Kévin Ottens, Mirko Boehm,
David Faure, Frederik Gladhorn, me and many others came together at
Akademy to discussed how to do that. How can we give the whole KDE
community the opportunity to express what they think we should all be
working on right now? How can we find all the creative ideas and
ambitions that are hidden in so many of our community members? And how
can we talk about them all together? I believe we have found a way.

Starting today all of KDE is invited to propose goals to work on for
the next 3 to 4 years. We will then discuss and refine them. Finally
we will have a vote for the goals we should pursue together. Goals can
be about anything you consider important - it doesn't have to be about
writing code. The top 3 proposals will get supported in various ways
for example with sponsorship of a sprint and presentation slots at
next year's Akademy. This way we will shine a spotlight on the most
important things we are working on and together support that work in
the best way we can. The plan is to do this every year and add one or
two goals to the mix every time.

The timeline looks as follows:
* Today until beginning of October: work on the proposals
* All of October: talk about the proposal
* First two weeks of November: vote on the proposals by everyone with
a KDE contributor account
* Middle of November: publish the results

To make it more concrete, here are some examples of potential goals
that could come out of this:
* Improving the Developer Story: a new contributor should be able to
create his first patch to any KDE application in 15 minutes or less;
* Big in Asia: users in Asia should be able to write in their writing
system in any of the software produced by KDE;
* Appeal to All our Senses: a visually impaired user should be able to
use all the software produced by KDE;
* Virtual Reality Painting: artists should be able to paint in 3D
straight from a VR world using software produced by KDE;
* Speaking Your Language: 90% of the computer users worldwide should
be able to use the software produced by KDE in a language in which
they are fluent.

Do you have an idea for a goal for KDE? Get a small group of people
together and propose it today by adding it here:
https://phabricator.kde.org/project/board/244/


Cheers
Lydia

-- 
Lydia Pintscher - http://about.me/lydia.pintscher
KDE e.V. Board of Directors / KDE Community Working Group
http://kde.org - http://open-advice.org

Minutes GSoC meeting

[Elvis Angelaccio]

Present: me, chinmoy, shortstheory

Minutes in the attachment.

Cheers,
Elvis2017-08-20 09:01:22 eangMeeting!
2017-08-20 09:01:27 chinmoy[m]  yes
2017-08-20 09:02:11 eanglet's start then
2017-08-20 09:03:44 chinmoy[m]  Didn't do much this week due to college 
:(
2017-08-20 09:04:14 chinmoy[m]  Mostly fixed the issues in my diffs
2017-08-20 09:04:51 chinmoy[m]  And got my fd sharing code reveiwed
2017-08-20 09:05:38 chinmoy[m]  here I posted my code for review 
https://codereview.stackexchange.com/questions/173306/sharing-file-descriptor-between-an-under-privileged-and-a-privileged-process-us
2017-08-20 09:06:19 chinmoy[m]  eang have a look and tell me if you 
want to add something
2017-08-20 09:07:15 IrcsomeBot   yup
2017-08-20 09:09:26 eanggood idea, the more eyes on it, the better
2017-08-20 09:10:00 chinmoy[m]  that's what i thought
2017-08-20 09:11:20 eangchinmoy: have you seen 
https://phabricator.kde.org/T6561#106742 ?
2017-08-20 09:11:21 sKreamerTask 6561 "Polkit support in KIO" 
[Open,High] {Frameworks} https://phabricator.kde.org/T6561
2017-08-20 09:11:35 eangcan you confirm that PrivilegeExecution will be 
a no-op on windows?
2017-08-20 09:12:04 chinmoy[m]  it will be
2017-08-20 09:12:59 chinmoy[m]  execWithElevatedPrivilege will be 
called in windows as well but it will return false there
2017-08-20 09:13:27 eangok that's good
2017-08-20 09:17:43 eangchinmoy: I have a question, after I upgraded to 
KF5.37 and rebuilt your kio fork, kio_file dies
2017-08-20 09:17:58 eangQ_ASSERT(d->appConnection.inited()); in 
slavebase.cpp:283
2017-08-20 09:18:12 eanghave you ever seen this?
2017-08-20 09:18:38 chinmoy[m]  I have but not recently
2017-08-20 09:18:47 chinmoy[m]  I mean four weeks back
2017-08-20 09:20:53 chinmoy[m]  I will look into it.
2017-08-20 09:22:19 eangok thanks, weird error
2017-08-20 09:22:39 chinmoy[m]  I have prepared some unit tests: D7430. 
can you tell me if I am doing anything wrong?
2017-08-20 09:22:40 sKreamerDiff 7430 "Add unit test" [Needs 
Review] https://phabricator.kde.org/D7430
2017-08-20 09:26:46 eanglooks good to me, you can put it on for review
2017-08-20 09:33:31 chinmoy[m]  eang, I have nothing else to add.
2017-08-20 09:34:30 chinmoy[m]  anything you want to say
2017-08-20 09:34:44 eangso, August 21 - 29, 2017 => Students Submit 
Code and Evaluations
2017-08-20 09:35:05 eangremember that you need to update 
https://community.kde.org/GSoC/2017/StatusReports/chinmoyrp
2017-08-20 09:35:30 chinmoy[m]  sure.
2017-08-20 09:36:11 eangwhat's the status of the dolphin patch? will be 
ready before the 29th?
2017-08-20 09:36:27 eangwe have one more meeting before the deadline
2017-08-20 09:38:16 chinmoy[m]  I haven't had time to work on dolphin 
patch yet
2017-08-20 09:43:26 chinmoy[m]  judging from the work left It should 
take one day or two days at most to complete the dolphin patch.
2017-08-20 09:43:41 chinmoy[m]  only if we exclude mass rename
2017-08-20 09:45:50 eangok, so is one more meeting enough for you? we 
could also re-schedule to have two
2017-08-20 09:46:09 chinmoy[m]  one should do
2017-08-20 09:46:40 eangall right, so next meeting Saturday 26th
2017-08-20 09:46:47 chinmoy[m]  ok
2017-08-20 09:46:57 eangthat's all from my side
2017-08-20 09:47:10 eangmeeting over!
2017-08-20 09:47:17 chinmoy[m]  sure