KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 543 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/543/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 14 Apr 2020 05:41:33 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 55 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(276/412)67%
(276/412)57%
(35482/62791)40%
(17956/44369)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(60/60)100%
(60/60)96%
(10112/10582)46%
(4734/10192)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(105/119)88%
(105/119)60%
(8744/14659)51%
(4540/8849)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8342)43%
(2078/4826)src.gui100%
(5/5)100%
(5/5)81%
(332/412)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(711/1286)41%
(423/1036)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(646/1375)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
 

D24773: kio_trash: Add size, modification, access and create date for trash:/

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:570b48e656c7: kio_trash: Add size, modification, access 
and create date for trash:/ (authored by meven).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24773?vs=80016=80061#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24773?vs=80016=80061

REVISION DETAIL
  https://phabricator.kde.org/D24773

AFFECTED FILES
  src/core/kfileitem.cpp
  src/core/kfileitem.h
  src/core/udsentry.h
  src/ioslaves/trash/kio_trash.cpp
  src/ioslaves/trash/trashimpl.cpp
  src/ioslaves/trash/trashimpl.h
  src/ioslaves/trash/trashsizecache.cpp
  src/ioslaves/trash/trashsizecache.h

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D26650: Use KService to look for Filelight

[Nathaniel Graham]

ngraham added a comment.


  Ping @shubham

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26650

To: shubham, broulik, ngraham
Cc: sitter, meven, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D27220: add pix icon

[Nathaniel Graham]

ngraham added a comment.


  @camiloh, how do you feel about this?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27220

To: mbruchert, camiloh, #vdg
Cc: ngraham, IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
bruns

Re: Update on Status of Gitlab Migration

[Nate Graham]

On 4/13/20 6:59 PM, Ben Cooksley wrote:

Why do we need to mimic them?

If you Google "KDE Gitlab" then the first hit is invent.kde.org 
.


To flip it around: why do we need to do something different? I don't 
think it's about mimicking anyone else, but rather using the most 
intuitively obvious domain name rather than some arbitrarily different one.


No matter what, we're all going to be talking about "KDE GitLab" or 
"KDE's GitLab instance". The title of the relevant documentation page is 
"GitLab" (much as the Phabricator documentation page was named 
"Phabricator"). And when the migration is complete, we're all going to 
announce that "KDE is now using GitLab!" So the cat's out of the bag on 
using the word "GitLab" and avoiding some number of people looking for 
our stuff at gitlab.com and not finding it there. invent.kde.org doesn't 
avoid that at all.


Given that, which is more confusing: explaining to people that we have a 
GitLab instance at invent.kde.org, or explaining to people that we have 
a GitLab instance at gitlab.kde.org?


I know that over the next few years I'm going to be directing hundreds 
of people towards our infrastructure, and I would rather be able to say 
"please submit a pull request at gitlab.kde.org" rather than "please 
submit a pull request at KDE's GitLab instance at invent.kde.org."


I know this probably feels like annoyingly extreme bikeshedding, but, I 
dunno, names are important.


Nate

Re: Update on Status of Gitlab Migration

[Ben Cooksley]

On Tue, 14 Apr 2020, 11:45 am Aleix Pol,  wrote:

> On Mon, Apr 13, 2020 at 8:30 PM Ben Cooksley  wrote:
> >
> > On Tue, Apr 14, 2020 at 3:35 AM Nate Graham  wrote:
> > >
> > > On 4/13/20 4:44 AM, Albert Vaca Cintora wrote:
> > > > Regarding this: is the subdomain going to stay invent.kde.org once
> we
> > > > have officially moved? I find it's a bit confusing to use that
> instead
> > > > of gitlab.kde.org
> > >
> > > I agree. gitlab.kde.org would make more sense to me, mirroring
> > > phabricator.kde.org.
> > >
> >
> > There is no intention to change the name from invent.kde.org.
> >
> > We have a long precedent of not using the name of the software for the
> > name in DNS, and Gitlab is continuing with this, for example:
> > - bugs.kde.org is run by Bugzilla
> > - dot.kde.org is run by Drupal
> > - techbase.kde.org is run by Mediawiki
> > - conf.kde.org is run by Frab
> > - reimbursements.kde.org is run by travel-support-program
> > - websvn.kde.org is run by ViewVC
> > - build.kde.org and binary-factory.kde.org are both run by Jenkins
> > - stats.kde.org is run by Matomo (formerly Piwik)
> > - survey.kde.org is run by Limesurvey
> >
> > For essentially all of the above, calling it after the software
> > running it makes no sense, and given that in some cases we have
> > multiple instances would have made things more confusing
> > (jenkins1.kde.org and jenkins2.kde.org anyone?)
> >
> > Phabricator and Reviewboard were the only ones to not follow this
> > rule, and that was an error on our part.
> >
> > Given that there is a popular instance at Gitlab.com, referring to
> > ours as "KDE Invent" is more likely to ensure newcomers are not
> > confused (as they may not be aware that you can setup an instance of
> > Gitlab on your own systems)
> >
> > Regards,
> > Ben
>
> We also use git.kde.org and svn.kde.org.
>

The name git.kde.org will be retired as part of the move to Gitlab.

The SSH host keys for the two machines are different, so it would cause
more issues than it doesn't to keep the hostname active.

We've also never supported HTTP access to the master copy of the
repositories so there isn't anything to keep alive there either.


> It would too mimic what others are doing at gitlab.gnome.org and
> gitlab.freedesktop.org. So at the very least we'll want a redirect.
>

Why do we need to mimic them?

If you Google "KDE Gitlab" then the first hit is invent.kde.org.


> Aleix
>

Cheers,
Ben

>

Re: Update on Status of Gitlab Migration

[Ben Cooksley]

On Tue, 14 Apr 2020, 11:45 am Aleix Pol,  wrote:

> On Mon, Apr 13, 2020 at 8:30 PM Ben Cooksley  wrote:
> >
> > On Tue, Apr 14, 2020 at 3:35 AM Nate Graham  wrote:
> > >
> > > On 4/13/20 4:44 AM, Albert Vaca Cintora wrote:
> > > > Regarding this: is the subdomain going to stay invent.kde.org once
> we
> > > > have officially moved? I find it's a bit confusing to use that
> instead
> > > > of gitlab.kde.org
> > >
> > > I agree. gitlab.kde.org would make more sense to me, mirroring
> > > phabricator.kde.org.
> > >
> >
> > There is no intention to change the name from invent.kde.org.
> >
> > We have a long precedent of not using the name of the software for the
> > name in DNS, and Gitlab is continuing with this, for example:
> > - bugs.kde.org is run by Bugzilla
> > - dot.kde.org is run by Drupal
> > - techbase.kde.org is run by Mediawiki
> > - conf.kde.org is run by Frab
> > - reimbursements.kde.org is run by travel-support-program
> > - websvn.kde.org is run by ViewVC
> > - build.kde.org and binary-factory.kde.org are both run by Jenkins
> > - stats.kde.org is run by Matomo (formerly Piwik)
> > - survey.kde.org is run by Limesurvey
> >
> > For essentially all of the above, calling it after the software
> > running it makes no sense, and given that in some cases we have
> > multiple instances would have made things more confusing
> > (jenkins1.kde.org and jenkins2.kde.org anyone?)
> >
> > Phabricator and Reviewboard were the only ones to not follow this
> > rule, and that was an error on our part.
> >
> > Given that there is a popular instance at Gitlab.com, referring to
> > ours as "KDE Invent" is more likely to ensure newcomers are not
> > confused (as they may not be aware that you can setup an instance of
> > Gitlab on your own systems)
> >
> > Regards,
> > Ben
>
> We also use git.kde.org and svn.kde.org.
>

The name git.kde.org will be retired as part of the move to Gitlab.

The SSH host keys for the two machines are different, so it would cause
more issues than it doesn't to keep the hostname active.

We've also never supported HTTP access to the master copy of the
repositories so there isn't anything to keep alive there either.


> It would too mimic what others are doing at gitlab.gnome.org and
> gitlab.freedesktop.org. So at the very least we'll want a redirect.
>

Why do we need to mimic them?

If you Google "KDE Gitlab" then the first hit is invent.kde.org.


> Aleix
>

Cheers,
Ben

>

Re: Update on Status of Gitlab Migration

[Ben Cooksley]

On Tue, 14 Apr 2020, 11:45 am Aleix Pol,  wrote:

> On Mon, Apr 13, 2020 at 8:30 PM Ben Cooksley  wrote:
> >
> > On Tue, Apr 14, 2020 at 3:35 AM Nate Graham  wrote:
> > >
> > > On 4/13/20 4:44 AM, Albert Vaca Cintora wrote:
> > > > Regarding this: is the subdomain going to stay invent.kde.org once
> we
> > > > have officially moved? I find it's a bit confusing to use that
> instead
> > > > of gitlab.kde.org
> > >
> > > I agree. gitlab.kde.org would make more sense to me, mirroring
> > > phabricator.kde.org.
> > >
> >
> > There is no intention to change the name from invent.kde.org.
> >
> > We have a long precedent of not using the name of the software for the
> > name in DNS, and Gitlab is continuing with this, for example:
> > - bugs.kde.org is run by Bugzilla
> > - dot.kde.org is run by Drupal
> > - techbase.kde.org is run by Mediawiki
> > - conf.kde.org is run by Frab
> > - reimbursements.kde.org is run by travel-support-program
> > - websvn.kde.org is run by ViewVC
> > - build.kde.org and binary-factory.kde.org are both run by Jenkins
> > - stats.kde.org is run by Matomo (formerly Piwik)
> > - survey.kde.org is run by Limesurvey
> >
> > For essentially all of the above, calling it after the software
> > running it makes no sense, and given that in some cases we have
> > multiple instances would have made things more confusing
> > (jenkins1.kde.org and jenkins2.kde.org anyone?)
> >
> > Phabricator and Reviewboard were the only ones to not follow this
> > rule, and that was an error on our part.
> >
> > Given that there is a popular instance at Gitlab.com, referring to
> > ours as "KDE Invent" is more likely to ensure newcomers are not
> > confused (as they may not be aware that you can setup an instance of
> > Gitlab on your own systems)
> >
> > Regards,
> > Ben
>
> We also use git.kde.org and svn.kde.org.
>

The name git.kde.org will be retired as part of the move to Gitlab.

The SSH host keys for the two machines are different, so it would cause
more issues than it doesn't to keep the hostname active.

We've also never supported HTTP access to the master copy of the
repositories so there isn't anything to keep alive there either.


> It would too mimic what others are doing at gitlab.gnome.org and
> gitlab.freedesktop.org. So at the very least we'll want a redirect.
>

Why do we need to mimic them?

If you Google "KDE Gitlab" then the first hit is invent.kde.org.


> Aleix
>

Cheers,
Ben

>

Re: Update on Status of Gitlab Migration

[Aleix Pol]

On Mon, Apr 13, 2020 at 8:30 PM Ben Cooksley  wrote:
>
> On Tue, Apr 14, 2020 at 3:35 AM Nate Graham  wrote:
> >
> > On 4/13/20 4:44 AM, Albert Vaca Cintora wrote:
> > > Regarding this: is the subdomain going to stay invent.kde.org once we
> > > have officially moved? I find it's a bit confusing to use that instead
> > > of gitlab.kde.org
> >
> > I agree. gitlab.kde.org would make more sense to me, mirroring
> > phabricator.kde.org.
> >
>
> There is no intention to change the name from invent.kde.org.
>
> We have a long precedent of not using the name of the software for the
> name in DNS, and Gitlab is continuing with this, for example:
> - bugs.kde.org is run by Bugzilla
> - dot.kde.org is run by Drupal
> - techbase.kde.org is run by Mediawiki
> - conf.kde.org is run by Frab
> - reimbursements.kde.org is run by travel-support-program
> - websvn.kde.org is run by ViewVC
> - build.kde.org and binary-factory.kde.org are both run by Jenkins
> - stats.kde.org is run by Matomo (formerly Piwik)
> - survey.kde.org is run by Limesurvey
>
> For essentially all of the above, calling it after the software
> running it makes no sense, and given that in some cases we have
> multiple instances would have made things more confusing
> (jenkins1.kde.org and jenkins2.kde.org anyone?)
>
> Phabricator and Reviewboard were the only ones to not follow this
> rule, and that was an error on our part.
>
> Given that there is a popular instance at Gitlab.com, referring to
> ours as "KDE Invent" is more likely to ensure newcomers are not
> confused (as they may not be aware that you can setup an instance of
> Gitlab on your own systems)
>
> Regards,
> Ben

We also use git.kde.org and svn.kde.org.

It would too mimic what others are doing at gitlab.gnome.org and
gitlab.freedesktop.org. So at the very least we'll want a redirect.

Aleix

Re: Update on Status of Gitlab Migration

[Aleix Pol]

On Mon, Apr 13, 2020 at 8:30 PM Ben Cooksley  wrote:
>
> On Tue, Apr 14, 2020 at 3:35 AM Nate Graham  wrote:
> >
> > On 4/13/20 4:44 AM, Albert Vaca Cintora wrote:
> > > Regarding this: is the subdomain going to stay invent.kde.org once we
> > > have officially moved? I find it's a bit confusing to use that instead
> > > of gitlab.kde.org
> >
> > I agree. gitlab.kde.org would make more sense to me, mirroring
> > phabricator.kde.org.
> >
>
> There is no intention to change the name from invent.kde.org.
>
> We have a long precedent of not using the name of the software for the
> name in DNS, and Gitlab is continuing with this, for example:
> - bugs.kde.org is run by Bugzilla
> - dot.kde.org is run by Drupal
> - techbase.kde.org is run by Mediawiki
> - conf.kde.org is run by Frab
> - reimbursements.kde.org is run by travel-support-program
> - websvn.kde.org is run by ViewVC
> - build.kde.org and binary-factory.kde.org are both run by Jenkins
> - stats.kde.org is run by Matomo (formerly Piwik)
> - survey.kde.org is run by Limesurvey
>
> For essentially all of the above, calling it after the software
> running it makes no sense, and given that in some cases we have
> multiple instances would have made things more confusing
> (jenkins1.kde.org and jenkins2.kde.org anyone?)
>
> Phabricator and Reviewboard were the only ones to not follow this
> rule, and that was an error on our part.
>
> Given that there is a popular instance at Gitlab.com, referring to
> ours as "KDE Invent" is more likely to ensure newcomers are not
> confused (as they may not be aware that you can setup an instance of
> Gitlab on your own systems)
>
> Regards,
> Ben

We also use git.kde.org and svn.kde.org.

It would too mimic what others are doing at gitlab.gnome.org and
gitlab.freedesktop.org. So at the very least we'll want a redirect.

Aleix

Re: Update on Status of Gitlab Migration

[Aleix Pol]

On Mon, Apr 13, 2020 at 8:30 PM Ben Cooksley  wrote:
>
> On Tue, Apr 14, 2020 at 3:35 AM Nate Graham  wrote:
> >
> > On 4/13/20 4:44 AM, Albert Vaca Cintora wrote:
> > > Regarding this: is the subdomain going to stay invent.kde.org once we
> > > have officially moved? I find it's a bit confusing to use that instead
> > > of gitlab.kde.org
> >
> > I agree. gitlab.kde.org would make more sense to me, mirroring
> > phabricator.kde.org.
> >
>
> There is no intention to change the name from invent.kde.org.
>
> We have a long precedent of not using the name of the software for the
> name in DNS, and Gitlab is continuing with this, for example:
> - bugs.kde.org is run by Bugzilla
> - dot.kde.org is run by Drupal
> - techbase.kde.org is run by Mediawiki
> - conf.kde.org is run by Frab
> - reimbursements.kde.org is run by travel-support-program
> - websvn.kde.org is run by ViewVC
> - build.kde.org and binary-factory.kde.org are both run by Jenkins
> - stats.kde.org is run by Matomo (formerly Piwik)
> - survey.kde.org is run by Limesurvey
>
> For essentially all of the above, calling it after the software
> running it makes no sense, and given that in some cases we have
> multiple instances would have made things more confusing
> (jenkins1.kde.org and jenkins2.kde.org anyone?)
>
> Phabricator and Reviewboard were the only ones to not follow this
> rule, and that was an error on our part.
>
> Given that there is a popular instance at Gitlab.com, referring to
> ours as "KDE Invent" is more likely to ensure newcomers are not
> confused (as they may not be aware that you can setup an instance of
> Gitlab on your own systems)
>
> Regards,
> Ben

We also use git.kde.org and svn.kde.org.

It would too mimic what others are doing at gitlab.gnome.org and
gitlab.freedesktop.org. So at the very least we'll want a redirect.

Aleix

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.14 - Build # 26 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.14/26/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Mon, 13 Apr 2020 23:39:32 +
 Build duration:
3 min 5 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_dialogstatetest

D28088: Fix warnings

[Aleix Pol Gonzalez]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:298ce0ed7ff4: Fix warnings (authored by apol).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28088?vs=78630=80058

REVISION DETAIL
  https://phabricator.kde.org/D28088

AFFECTED FILES
  src/plasma/containmentactions.cpp
  src/plasma/private/storagethread.cpp
  src/scriptengines/qml/plasmoid/dropmenu.h

To: apol, #frameworks
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D26918: Improve KNotification API docs

[Carson Black]

cblack requested changes to this revision.
cblack added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> Mainpage.dox:13
> +In order to perform a notification, you need to create a description file, 
> which contains
> +default parameters of the notification. It needs to be installed to 
> knotifications5/appname.notifyrc
> +in a QStandardPaths::GenericDataLocation directory.

Use @c

> Mainpage.dox:15
> +in a QStandardPaths::GenericDataLocation directory.
> +On Android, this path is qrc:/knotifications5/.
> +

Ditto

> Mainpage.dox:19
> +component name to the KNotification object.
> +@warning Notifications won't be visible otherwise.
> +

Bad documentation style: warning block should be entirely self-contained in 
what it's conveying.

> Mainpage.dox:25
> + This file contains  mainly 3 parts
> +  
> +  \ref global "Global information"

Use markdown syntax, not inline HTML.

> Mainpage.dox:33
> +The global part looks like that
> +
> +[Global]

`@code` and `@endcode` or use markdown

> Mainpage.dox:46
> +This part consists of hints for the configuration widget
> + 
> +[Context/group]

Ditto

> Mainpage.dox:61
> +The definition of the events forms the most important part of the config file
> +
> +[Event/newmail]

Ditto

> Mainpage.dox:110
> +// DOXYGEN_SET_EXCLUDE_PATTERNS += *_p.h */private/* */examples/*
> +// DOXYGEN_SET_PROJECT_NAME = KNotifications
> +// vim:ts=4:sw=4:expandtab:filetype=doxygen

Use `docs/Doxyfile.local` for configuration overrides. Examples exclude is 
unnecessary because it's set as Doxygen's example path.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26918

To: nicolasfella, #frameworks, broulik, jucato, cblack
Cc: cblack, class, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D26918: Improve KNotification API docs

[Nicolas Fella]

nicolasfella added a comment.


  ping?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26918

To: nicolasfella, #frameworks, broulik, jucato
Cc: class, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28811: WIP: Use CSS grid to improve layout

[Carl Schwan]

ognarb created this revision.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
ognarb requested review of this revision.

REPOSITORY
  R264 KApiDox

BRANCH
  flex-grid

REVISION DETAIL
  https://phabricator.kde.org/D28811

AFFECTED FILES
  src/kapidox/data/htmlresource/css/kapidox.css
  src/kapidox/data/htmlresource/css/kapidox.scss
  src/kapidox/data/templates/base.html
  src/kapidox/data/templates/subgroup-sidebar.html

To: ognarb
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

D28808: [ExpandableListItem] make it touch-friendly

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, apol, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Use a MultiPointTouchHandler as the top-level item to handle touch input. We 
still need
  a MouseArea inside it to handle non-touch hover and right-click behaviors.
  
  FEATURE: 393749
  FIXED-IN: 5.70

TEST PLAN
  Click behavior is identical to how it was before, but now touch works too: 
F8234452: 20200413_150741-smaller-30.mp4 

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  make-ExpandableListItem-touchable (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28808

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/ExpandableListItem.qml

To: ngraham, #plasma, apol, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D25267: Improve XCF support

[Martin Tobias Holmedahl Sandsmark]

sandsmark added a comment.


  In D25267#647148 , @aacid wrote:
  
  > Seems like the windows build is broken :/
  >
  > 
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20WindowsMSVCQt5.14/16/console
  
  
  Seems like I forgot to use the custom rand_r (to avoid exactly that + get the 
same noise function as windows) a couple of places.
  
  Should just be to replace `rand_r` with `RandomTable::rand_r` where it is 
missing, okay if I just do that in master?

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D25267

To: sandsmark, aacid, cfeck, apol, vkrause
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

Re: Update on Status of Gitlab Migration

[Ömer Fadıl USTA]

keeping it as invent also give us opportunity to change if we need to move
our systems to someother ecosystem but keeping its name same. so my 2 cents
for going with invent name

On Mon, Apr 13, 2020, 21:31 Ben Cooksley  wrote:

> On Tue, Apr 14, 2020 at 3:35 AM Nate Graham  wrote:
> >
> > On 4/13/20 4:44 AM, Albert Vaca Cintora wrote:
> > > Regarding this: is the subdomain going to stay invent.kde.org once we
> > > have officially moved? I find it's a bit confusing to use that instead
> > > of gitlab.kde.org
> >
> > I agree. gitlab.kde.org would make more sense to me, mirroring
> > phabricator.kde.org.
> >
>
> There is no intention to change the name from invent.kde.org.
>
> We have a long precedent of not using the name of the software for the
> name in DNS, and Gitlab is continuing with this, for example:
> - bugs.kde.org is run by Bugzilla
> - dot.kde.org is run by Drupal
> - techbase.kde.org is run by Mediawiki
> - conf.kde.org is run by Frab
> - reimbursements.kde.org is run by travel-support-program
> - websvn.kde.org is run by ViewVC
> - build.kde.org and binary-factory.kde.org are both run by Jenkins
> - stats.kde.org is run by Matomo (formerly Piwik)
> - survey.kde.org is run by Limesurvey
>
> For essentially all of the above, calling it after the software
> running it makes no sense, and given that in some cases we have
> multiple instances would have made things more confusing
> (jenkins1.kde.org and jenkins2.kde.org anyone?)
>
> Phabricator and Reviewboard were the only ones to not follow this
> rule, and that was an error on our part.
>
> Given that there is a popular instance at Gitlab.com, referring to
> ours as "KDE Invent" is more likely to ensure newcomers are not
> confused (as they may not be aware that you can setup an instance of
> Gitlab on your own systems)
>
> Regards,
> Ben
>

D28800: Always create actioncollection

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R294:4b3fc2aedd86: Always create actioncollection (authored by 
nicolasfella).

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28800?vs=80034=80051

REVISION DETAIL
  https://phabricator.kde.org/D28800

AFFECTED FILES
  src/kbookmarkmenu.cpp

To: nicolasfella, #frameworks, dfaure, stefanocrocco
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28800: Always create actioncollection

[Nicolas Fella]

nicolasfella added a comment.


  In D28800#647508 , @dfaure wrote:
  
  > (but now konqueror creates another one, so the konqueror patch needs to 
changed to "if exactly 5.69" only, right?)
  
  
  makes sense

REPOSITORY
  R294 KBookmarks

BRANCH
  emptycoll

REVISION DETAIL
  https://phabricator.kde.org/D28800

To: nicolasfella, #frameworks, dfaure, stefanocrocco
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 51 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/51/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Mon, 13 Apr 2020 20:09:33 +
 Build duration:
5 min 0 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D28803: [KDirOperator] Use new "Show/Hide Hidden Files" standard shortcut

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:d3977bdeacbb: [KDirOperator] Use new Show/Hide 
Hidden Files standard shortcut (authored by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28803?vs=80040=80050

REVISION DETAIL
  https://phabricator.kde.org/D28803

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: ngraham, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28803: [KDirOperator] Use new "Show/Hide Hidden Files" standard shortcut

[Nathaniel Graham]

ngraham added a comment.


  Will do!

REPOSITORY
  R241 KIO

BRANCH
  use-standard-shortcut (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28803

To: ngraham, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28803: [KDirOperator] Use new "Show/Hide Hidden Files" standard shortcut

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Please land approx 20mn after D28802  to 
give CI time to update KConfig first ;)
  (or check when build.kde.org says it got rebuilt)

REPOSITORY
  R241 KIO

BRANCH
  use-standard-shortcut (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28803

To: ngraham, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28802: Add standard shortcut for "Show/Hide Hidden Files"

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:65cc12ab3ec8: Add standard shortcut for Show/Hide 
Hidden Files (authored by ngraham).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28802?vs=80039=80049

REVISION DETAIL
  https://phabricator.kde.org/D28802

AFFECTED FILES
  src/gui/kstandardshortcut.cpp
  src/gui/kstandardshortcut.h

To: ngraham, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28802: Add standard shortcut for "Show/Hide Hidden Files"

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

BRANCH
  add-show-hide-hidden-files-shortcut (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28802

To: ngraham, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28800: Always create actioncollection

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Thanks.
  
  (but now konqueror creates another one, so the konqueror patch needs to 
changed to "if exactly 5.69" only, right?)

REPOSITORY
  R294 KBookmarks

BRANCH
  emptycoll

REVISION DETAIL
  https://phabricator.kde.org/D28800

To: nicolasfella, #frameworks, dfaure, stefanocrocco
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28805: Tweak kcmcontrols docs

[Nicolas Fella]

nicolasfella edited the summary of this revision.
nicolasfella added a reviewer: Frameworks.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D28805

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28805: Tweak kcmcontrols docs

[Nicolas Fella]

nicolasfella added a reviewer: jucato.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D28805

To: nicolasfella, #frameworks, jucato
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28805: Tweak kcmcontrols docs

[Nicolas Fella]

nicolasfella created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REPOSITORY
  R296 KDeclarative

BRANCH
  tweakdocs

REVISION DETAIL
  https://phabricator.kde.org/D28805

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml
  src/qmlcontrols/kcmcontrols/qml/ScrollViewKCM.qml
  src/qmlcontrols/kcmcontrols/qml/SimpleKCM.qml

To: nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28802: Add standard shortcut for "Show/Hide Hidden Files"

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28802

To: ngraham, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28803: [KDirOperator] Use new "Show/Hide Hidden Files" standard shortcut

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: dfaure, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  CCBUG: 262551
  
  Depends on D28802 

TEST PLAN
  - Apply D28802  to KConfig
  - Apply patch, compile, launch an app
  - Open a file dialog
  - Hit Ctrl+H or Alt+. and see that hidden files are shown or hidden as 
appropriate

REPOSITORY
  R241 KIO

BRANCH
  use-standard-shortcut (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28803

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: ngraham, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Update on Status of Gitlab Migration

[Ben Cooksley]

On Tue, Apr 14, 2020 at 3:35 AM Nate Graham  wrote:
>
> On 4/13/20 4:44 AM, Albert Vaca Cintora wrote:
> > Regarding this: is the subdomain going to stay invent.kde.org once we
> > have officially moved? I find it's a bit confusing to use that instead
> > of gitlab.kde.org
>
> I agree. gitlab.kde.org would make more sense to me, mirroring
> phabricator.kde.org.
>

There is no intention to change the name from invent.kde.org.

We have a long precedent of not using the name of the software for the
name in DNS, and Gitlab is continuing with this, for example:
- bugs.kde.org is run by Bugzilla
- dot.kde.org is run by Drupal
- techbase.kde.org is run by Mediawiki
- conf.kde.org is run by Frab
- reimbursements.kde.org is run by travel-support-program
- websvn.kde.org is run by ViewVC
- build.kde.org and binary-factory.kde.org are both run by Jenkins
- stats.kde.org is run by Matomo (formerly Piwik)
- survey.kde.org is run by Limesurvey

For essentially all of the above, calling it after the software
running it makes no sense, and given that in some cases we have
multiple instances would have made things more confusing
(jenkins1.kde.org and jenkins2.kde.org anyone?)

Phabricator and Reviewboard were the only ones to not follow this
rule, and that was an error on our part.

Given that there is a popular instance at Gitlab.com, referring to
ours as "KDE Invent" is more likely to ensure newcomers are not
confused (as they may not be aware that you can setup an instance of
Gitlab on your own systems)

Regards,
Ben

D28802: Add standard shortcut for "Show/Hide Hidden Files"

[Nathaniel Graham]

ngraham added a dependent revision: D28803: [KDirOperator] Use new "Show/Hide 
Hidden Files" standard shortcut.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28802

To: ngraham, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28802: Add standard shortcut for "Show/Hide Hidden Files"

[Nathaniel Graham]

ngraham added a dependent revision: D28804: Use new "Show/Hide Hidden Files" 
standard shortcut.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28802

To: ngraham, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Update on Status of Gitlab Migration

[Ben Cooksley]

On Tue, Apr 14, 2020 at 3:35 AM Nate Graham  wrote:
>
> On 4/13/20 4:44 AM, Albert Vaca Cintora wrote:
> > Regarding this: is the subdomain going to stay invent.kde.org once we
> > have officially moved? I find it's a bit confusing to use that instead
> > of gitlab.kde.org
>
> I agree. gitlab.kde.org would make more sense to me, mirroring
> phabricator.kde.org.
>

There is no intention to change the name from invent.kde.org.

We have a long precedent of not using the name of the software for the
name in DNS, and Gitlab is continuing with this, for example:
- bugs.kde.org is run by Bugzilla
- dot.kde.org is run by Drupal
- techbase.kde.org is run by Mediawiki
- conf.kde.org is run by Frab
- reimbursements.kde.org is run by travel-support-program
- websvn.kde.org is run by ViewVC
- build.kde.org and binary-factory.kde.org are both run by Jenkins
- stats.kde.org is run by Matomo (formerly Piwik)
- survey.kde.org is run by Limesurvey

For essentially all of the above, calling it after the software
running it makes no sense, and given that in some cases we have
multiple instances would have made things more confusing
(jenkins1.kde.org and jenkins2.kde.org anyone?)

Phabricator and Reviewboard were the only ones to not follow this
rule, and that was an error on our part.

Given that there is a popular instance at Gitlab.com, referring to
ours as "KDE Invent" is more likely to ensure newcomers are not
confused (as they may not be aware that you can setup an instance of
Gitlab on your own systems)

Regards,
Ben

Re: Update on Status of Gitlab Migration

[Ben Cooksley]

On Tue, Apr 14, 2020 at 3:35 AM Nate Graham  wrote:
>
> On 4/13/20 4:44 AM, Albert Vaca Cintora wrote:
> > Regarding this: is the subdomain going to stay invent.kde.org once we
> > have officially moved? I find it's a bit confusing to use that instead
> > of gitlab.kde.org
>
> I agree. gitlab.kde.org would make more sense to me, mirroring
> phabricator.kde.org.
>

There is no intention to change the name from invent.kde.org.

We have a long precedent of not using the name of the software for the
name in DNS, and Gitlab is continuing with this, for example:
- bugs.kde.org is run by Bugzilla
- dot.kde.org is run by Drupal
- techbase.kde.org is run by Mediawiki
- conf.kde.org is run by Frab
- reimbursements.kde.org is run by travel-support-program
- websvn.kde.org is run by ViewVC
- build.kde.org and binary-factory.kde.org are both run by Jenkins
- stats.kde.org is run by Matomo (formerly Piwik)
- survey.kde.org is run by Limesurvey

For essentially all of the above, calling it after the software
running it makes no sense, and given that in some cases we have
multiple instances would have made things more confusing
(jenkins1.kde.org and jenkins2.kde.org anyone?)

Phabricator and Reviewboard were the only ones to not follow this
rule, and that was an error on our part.

Given that there is a popular instance at Gitlab.com, referring to
ours as "KDE Invent" is more likely to ensure newcomers are not
confused (as they may not be aware that you can setup an instance of
Gitlab on your own systems)

Regards,
Ben

D28802: Add standard shortcut for "Show/Hide Hidden Files"

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: dfaure, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Add a standard shortcut for this action so it can be synchronized between 
different apps
  and the file dialog; see https://bugs.kde.org/show_bug.cgi?id=262551.
  
  The action in Dolphin also has F8 bound to this, but the definition here only 
accept two
  default shortcuts, and F8 seems kind of random.
  
  CCBUG: 262551

TEST PLAN
  Apply  to KIO and C to Dolphin and test there

REPOSITORY
  R237 KConfig

BRANCH
  add-show-hide-hidden-files-shortcut (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28802

AFFECTED FILES
  src/gui/kstandardshortcut.cpp
  src/gui/kstandardshortcut.h

To: ngraham, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Update on Status of Gitlab Migration

[Nate Graham]

On 4/13/20 4:44 AM, Albert Vaca Cintora wrote:

Regarding this: is the subdomain going to stay invent.kde.org once we
have officially moved? I find it's a bit confusing to use that instead
of gitlab.kde.org


I agree. gitlab.kde.org would make more sense to me, mirroring 
phabricator.kde.org.


Nate

Re: Update on Status of Gitlab Migration

[Ilya Bizyaev]

Hi,



I agree with this point, and I also like Invent as a name :)



Cheers,

Ilya.



 Дата: Пн, 13 апр 2020 18:51:10 +0300 Carl Schwan  
написал(а) 


Hi, 
I prefer the name invent because I fear that using GitLab will confuse 
newcomers then you say that they can contribute to GitLab and that they won't 
find any KDE code in gitlab.com. 
 
Also, I quite like the invent name. 
 
Carl 
 
‐‐‐ Original Message ‐‐‐ 
Le lundi, avril 13, 2020 3:40 PM, David Hurka  
a écrit : 
 
> On 4/13/20 5:34 PM Nate Graham wrote: 
> 
 
> > On 4/13/20 4:44 AM, Albert Vaca Cintora wrote: 
> > 
 
> > > Regarding this: is the subdomain going to stay invent.kde.org once we 
> > > have officially moved? I find it's a bit confusing to use that instead 
> > > of gitlab.kde.org 
> > 
 
> > I agree. gitlab.kde.org would make more sense to me, mirroring 
> > phabricator.kde.org. 
> > Nate 
> 
 
> Yes, I thought the same. But we have used “Invent” often in our discussions, 
> so I think it’s too late to change.

D28800: Always create actioncollection

[Nicolas Fella]

nicolasfella added reviewers: Frameworks, dfaure, stefanocrocco.

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D28800

To: nicolasfella, #frameworks, dfaure, stefanocrocco
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28800: Always create actioncollection

[Nicolas Fella]

nicolasfella created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Otherwise subclasses that unconditionally use m_actionCollection will get 
crashes. Observed in D28789 

REPOSITORY
  R294 KBookmarks

BRANCH
  emptycoll

REVISION DETAIL
  https://phabricator.kde.org/D28800

AFFECTED FILES
  src/kbookmarkmenu.cpp

To: nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28793: [KBookMarksMenu] Set objectName for newBookmarkFolderAction

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R294:9075f6345cfa: [KBookMarksMenu] Set objectName for 
newBookmarkFolderAction (authored by ahmadsamir).

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28793?vs=80013=80027

REVISION DETAIL
  https://phabricator.kde.org/D28793

AFFECTED FILES
  src/kbookmarkmenu.cpp
  src/kbookmarkmenu.h

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D24773_1

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 49 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/49/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Mon, 13 Apr 2020 16:04:00 +
 Build duration:
5 min 46 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 54 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D28793: [KBookMarksMenu] Set objectName for newBookmarkFolderAction

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R294 KBookmarks

BRANCH
  l-new-folder-action (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28793

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28746: Show previews on encrypted filesystems

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ae0beded1fd9: Show previews on encrypted filesystems 
(authored by marcingu, committed by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28746?vs=80022=80024

REVISION DETAIL
  https://phabricator.kde.org/D28746

AFFECTED FILES
  src/widgets/previewjob.cpp

To: marcingu, ivan, #frameworks, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28746: Show previews on encrypted filesystems

[Nathaniel Graham]

ngraham added a comment.


  Excellent job. This is a real improvement. Keep the great patches coming! :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28746

To: marcingu, ivan, #frameworks, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28746: Show previews on encrypted filesystems

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28746

To: marcingu, ivan, #frameworks, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28746: Show previews on encrypted filesystems

[Ivan Čukić]

ivan accepted this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28746

To: marcingu, ivan, #frameworks, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28746: Show previews on encrypted filesystems

[Marcin Gurtowski]

marcingu marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28746

To: marcingu, ivan, #frameworks, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28746: Show previews on encrypted filesystems

[Marcin Gurtowski]

marcingu updated this revision to Diff 80022.
marcingu added a comment.


  Removing extra whitespaces

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28746?vs=79991=80022

REVISION DETAIL
  https://phabricator.kde.org/D28746

AFFECTED FILES
  src/widgets/previewjob.cpp

To: marcingu, ivan, #frameworks, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

Re: Update on Status of Gitlab Migration

[Carl Schwan]

Hi,
I prefer the name invent because I fear that using GitLab will confuse 
newcomers then you say that they can contribute to GitLab and that they won't 
find any KDE code in gitlab.com.

Also, I quite like the invent name.

Carl

‐‐‐ Original Message ‐‐‐
Le lundi, avril 13, 2020 3:40 PM, David Hurka  a écrit 
:

> On 4/13/20 5:34 PM Nate Graham wrote:
> 

> > On 4/13/20 4:44 AM, Albert Vaca Cintora wrote:
> > 

> > > Regarding this: is the subdomain going to stay invent.kde.org once we
> > > have officially moved? I find it's a bit confusing to use that instead
> > > of gitlab.kde.org
> > 

> > I agree. gitlab.kde.org would make more sense to me, mirroring
> > phabricator.kde.org.
> > Nate
> 

> Yes, I thought the same. But we have used “Invent” often in our discussions,
> so I think it’s too late to change.



publickey - carl@carlschwan.eu - 0x7F564CB5.asc
Description: application/pgp-keys


signature.asc
Description: OpenPGP digital signature

D28745: Skip caching thumbnails on encrypted filesystems

[Marcin Gurtowski]

marcingu marked an inline comment as done.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham
Cc: ngraham, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
rdieter, mikesomov

D28745: Skip caching thumbnails on encrypted filesystems

[Marcin Gurtowski]

marcingu updated this revision to Diff 80021.
marcingu added a comment.


  Removing extra whitespaces

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28745?vs=79986=80021

REVISION DETAIL
  https://phabricator.kde.org/D28745

AFFECTED FILES
  thumbnail/thumbnail.cpp

To: marcingu, ivan, broulik, #dolphin, ngraham
Cc: ngraham, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
rdieter, mikesomov

D28797: Removing extra whitespaces

[Marcin Gurtowski]

marcingu created this revision.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
marcingu requested review of this revision.

REVISION SUMMARY
  Removing extra whitespaces

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28797

AFFECTED FILES
  thumbnail/thumbnail.cpp

To: marcingu
Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, 
fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, rdieter, mikesomov

Re: Update on Status of Gitlab Migration

[David Hurka]

On 4/13/20 5:34 PM Nate Graham wrote:
> On 4/13/20 4:44 AM, Albert Vaca Cintora wrote:
> > Regarding this: is the subdomain going to stay invent.kde.org once we
> > have officially moved? I find it's a bit confusing to use that instead
> > of gitlab.kde.org
> 
> I agree. gitlab.kde.org would make more sense to me, mirroring
> phabricator.kde.org.
> 
> Nate

Yes, I thought the same. But we have used “Invent” often in our discussions, 
so I think it’s too late to change.

Re: Update on Status of Gitlab Migration

[Nate Graham]

On 4/13/20 4:44 AM, Albert Vaca Cintora wrote:

Regarding this: is the subdomain going to stay invent.kde.org once we
have officially moved? I find it's a bit confusing to use that instead
of gitlab.kde.org


I agree. gitlab.kde.org would make more sense to me, mirroring 
phabricator.kde.org.


Nate

Re: Update on Status of Gitlab Migration

[Albert Vaca Cintora]

On Sat, Apr 11, 2020 at 11:36 AM Ben Cooksley  wrote:
>
> Good morning Community,
>
> I'm pleased to report that this week we reached a major milestone,
> with all the necessary technical components now being in place on our
> side for our migration to Gitlab to take place.

Regarding this: is the subdomain going to stay invent.kde.org once we
have officially moved? I find it's a bit confusing to use that instead
of gitlab.kde.org

Albert

D28796: Update Logtalk language syntax support

[Paulo Moura]

pmoura created this revision.
pmoura added a reviewer: dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
pmoura requested review of this revision.

REVISION SUMMARY
  Adds support for new built-predicates and fixes escape sequences in quoted 
atoms

TEST PLAN
  Tested manually by overriding the file bundled with the latest Kate macOS 
binary and the syntax highlight source test file from the Logtalk distribution.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D28796

AFFECTED FILES
  data/syntax/logtalk.xml

To: pmoura, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28745: Skip caching thumbnails on encrypted filesystems

[Nathaniel Graham]

ngraham retitled this revision from "Skipping catching of thumbnails on 
encrypted filesystems" to "Skip caching thumbnails on encrypted filesystems".
ngraham edited the summary of this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham
Cc: ngraham, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
rdieter, mikesomov

D28745: Skipping catching of thumbnails on encrypted filesystems

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added inline comments.

INLINE COMMENTS

> thumbnail.cpp:724
>  // no cached version is available, a new thumbnail must be 
> created
> -
>  QSaveFile thumbnailfile(thumbPath.absoluteFilePath(thumbName));

There are extra spaces on this line

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham
Cc: ngraham, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
rdieter, mikesomov

D24773: kio_trash: Add size, modification, access and create date for trash:/

[Méven Car]

meven marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

[Méven Car]

meven updated this revision to Diff 80016.
meven marked 2 inline comments as done.
meven added a comment.


  Fix, typo, pass max_mtime by ref to lambda

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24773?vs=80008=80016

BRANCH
  arcpatch-D24773_1

REVISION DETAIL
  https://phabricator.kde.org/D24773

AFFECTED FILES
  src/core/kfileitem.cpp
  src/core/kfileitem.h
  src/core/udsentry.h
  src/ioslaves/trash/kio_trash.cpp
  src/ioslaves/trash/trashimpl.cpp
  src/ioslaves/trash/trashimpl.h
  src/ioslaves/trash/trashsizecache.cpp
  src/ioslaves/trash/trashsizecache.h

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> dfaure wrote in trashsizecache.cpp:131
> Interesting. One benefit of lambdas is that they can work on local variable; 
> I would have captured max_mtime by reference and modified it inside the 
> lambda.
> Written this way (which I guess more "pure functional programming" because no 
> side effects), it could be a static helper function ;)
> 
> Wait, this doesn't work, does it? It makes a copy of mtime right now, while 
> it's still 0.
> 
> I'm pretty sure you want to capture by [&] instead
> (and then, unless you insist on pure functions, I'd suggest just modifying it 
> here, and returning void). It removes the "max_mtime = " duplication ;)

It probably didn't work, thanks

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28769: Add Icelandic Krona

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D28769

To: sandsmark, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, #frameworks, LeGast00n, cblack, michaelh, 
bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

[Méven Car]

meven added a dependent revision: D28794: Allow to display to use 
UDS_RECURSIVE_SIZE in status bar UDS_RECURSIVE_SIZE.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28793: [KBookMarksMenu] Set objectName for newBookmarkFolderAction

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  This is needed if users of this class are expected to add the action
  manually to their program actionCollection. Also add a method that
  returns that action, just like the other three actions already have.

TEST PLAN
  make && ctest

REPOSITORY
  R294 KBookmarks

BRANCH
  l-new-folder-action (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28793

AFFECTED FILES
  src/kbookmarkmenu.cpp
  src/kbookmarkmenu.h

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 48 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/48/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Mon, 13 Apr 2020 13:51:38 +
 Build duration:
5 min 23 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D28787: Fix PC3 BusyIndicator binding loop

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:3743e9d67453: Fix PC3 BusyIndicator binding loop 
(authored by ngraham).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28787?vs=79980=80012

REVISION DETAIL
  https://phabricator.kde.org/D28787

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/BusyIndicator.qml

To: ngraham, #plasma, davidedmundson, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28746: Show previews on encrypted filesystems

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ngraham wrote in previewjob.cpp:718
> unrelated change

Now there are extra spaces on that line. :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28746

To: marcingu, ivan, #frameworks, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28774: [KFontRequester] Port from QFontDialog to KFontChooserDialog

[David Faure]

dfaure added a comment.


  I mean, the user can press cancel, that's when QColorDialog returns an 
invalid color.
  If there was a concept like an invalid font we could do the same here, but 
there's no such concept in QFont.
  So yep, no better way.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D28774

To: ahmadsamir, #frameworks, dfaure, cfeck
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> trashsizecache.cpp:131
> +qint64 max_mtime = 0;
> +const auto checMaxTime = [max_mtime] (const qint64 lastModTime) -> 
> qint64 {
> +return lastModTime > max_mtime ? lastModTime : max_mtime;

Typo: checkMaxTime with a 'k'?

> trashsizecache.cpp:131
> +qint64 max_mtime = 0;
> +const auto checMaxTime = [max_mtime] (const qint64 lastModTime) -> 
> qint64 {
> +return lastModTime > max_mtime ? lastModTime : max_mtime;

Interesting. One benefit of lambdas is that they can work on local variable; I 
would have captured max_mtime by reference and modified it inside the lambda.
Written this way (which I guess more "pure functional programming" because no 
side effects), it could be a static helper function ;)

Wait, this doesn't work, does it? It makes a copy of mtime right now, while 
it's still 0.

I'm pretty sure you want to capture by [&] instead
(and then, unless you insist on pure functions, I'd suggest just modifying it 
here, and returning void). It removes the "max_mtime = " duplication ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D25267: Improve XCF support

[Albert Astals Cid]

aacid added a comment.


  In D25267#647129 , @sandsmark 
wrote:
  
  > I messed up and it got linked to the wrong phabricator review... Here it is 
anyways:
  >
  > 
https://cgit.kde.org/kimageformats.git/commit/?id=c60e77c048d32ccf743cec695743b77b2b25dc87
  
  
  Seems like the windows build is broken :/
  
  
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20WindowsMSVCQt5.14/16/console

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D25267

To: sandsmark, aacid, cfeck, apol, vkrause
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

[Méven Car]

meven added a comment.


  > But I'm wondering how much effort we want to put into finding the latest 
mtime, this is starting to sound like a very expensive operation.
  
  I agree let's not got too deep down the rabbit hole.
  This is not a very common use case
  
  > When kio_trash takes care of the trashing, we should never end up in this 
code path (right?)
  
  AFAIK

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

[Méven Car]

meven updated this revision to Diff 80008.
meven marked 3 inline comments as done.
meven added a comment.


  Add lambdas to factorize code, comments update, move a couple of 
DiscSpaceUtil::sizeOfPath to where there are needed

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24773?vs=79943=80008

BRANCH
  arcpatch-D24773_1

REVISION DETAIL
  https://phabricator.kde.org/D24773

AFFECTED FILES
  src/core/kfileitem.cpp
  src/core/kfileitem.h
  src/core/udsentry.h
  src/ioslaves/trash/kio_trash.cpp
  src/ioslaves/trash/trashimpl.cpp
  src/ioslaves/trash/trashimpl.h
  src/ioslaves/trash/trashsizecache.cpp
  src/ioslaves/trash/trashsizecache.h

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D25267: Improve XCF support

[Martin Tobias Holmedahl Sandsmark]

sandsmark abandoned this revision.
sandsmark added a comment.


  I messed up and it got linked to the wrong phabricator review... Here it is 
anyways:
  
  
https://cgit.kde.org/kimageformats.git/commit/?id=c60e77c048d32ccf743cec695743b77b2b25dc87

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D25267

To: sandsmark, aacid, cfeck, apol, vkrause
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

KDE CI: Frameworks » kimageformats » kf5-qt5 WindowsMSVCQt5.14 - Build # 16 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20WindowsMSVCQt5.14/16/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Mon, 13 Apr 2020 13:06:09 +
 Build duration:
23 sec and counting
   CONSOLE OUTPUT
  [...truncated 262 lines...][Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[2020-04-13T13:06:27.295Z] [2020-04-13T13:06:27.295Z] C:\CI\Job Build>call "C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Auxiliary/Build/vcvars64.bat" [2020-04-13T13:06:27.295Z] **[2020-04-13T13:06:27.295Z] ** Visual Studio 2019 Developer Command Prompt v16.4.3[2020-04-13T13:06:27.295Z] ** Copyright (c) 2019 Microsoft Corporation[2020-04-13T13:06:27.295Z] **[2020-04-13T13:06:28.232Z] [vcvarsall.bat] Environment initialized for: 'x64'[2020-04-13T13:06:28.500Z] [1/60] Automatic MOC for target kimg_ras[2020-04-13T13:06:28.500Z] [2/60] Automatic MOC for target kimg_psd[2020-04-13T13:06:28.500Z] [3/60] Automatic MOC for target kimg_pcx[2020-04-13T13:06:28.500Z] [4/60] Automatic MOC for target kimg_kra[2020-04-13T13:06:28.500Z] [5/60] Automatic MOC for target kimg_tga[2020-04-13T13:06:28.500Z] [6/60] Automatic MOC for target kimg_hdr[2020-04-13T13:06:28.500Z] [7/60] Automatic MOC for target kimg_rgb[2020-04-13T13:06:28.500Z] [8/60] Automatic MOC for target kimg_pic[2020-04-13T13:06:28.500Z] [9/60] Automatic MOC for target kimg_ora[2020-04-13T13:06:28.500Z] [10/60] Automatic MOC for target readtest[2020-04-13T13:06:28.771Z] [11/60] Automatic MOC for target kimg_xcf[2020-04-13T13:06:29.346Z] [12/60] Building CXX object src\imageformats\CMakeFiles\kimg_psd.dir\kimg_psd_autogen\mocs_compilation.cpp.obj[2020-04-13T13:06:29.346Z] [13/60] Building CXX object src\imageformats\CMakeFiles\kimg_tga.dir\kimg_tga_autogen\mocs_compilation.cpp.obj[2020-04-13T13:06:29.346Z] [14/60] Building CXX object src\imageformats\CMakeFiles\kimg_pcx.dir\kimg_pcx_autogen\mocs_compilation.cpp.obj[2020-04-13T13:06:29.346Z] [15/60] Building CXX object src\imageformats\CMakeFiles\kimg_hdr.dir\kimg_hdr_autogen\mocs_compilation.cpp.obj[2020-04-13T13:06:29.346Z] [16/60] Building CXX object src\imageformats\CMakeFiles\kimg_ras.dir\kimg_ras_autogen\mocs_compilation.cpp.obj[2020-04-13T13:06:29.711Z] [17/60] Building CXX object src\imageformats\CMakeFiles\kimg_ora.dir\ora.cpp.obj[2020-04-13T13:06:29.711Z] [18/60] Building CXX object src\imageformats\CMakeFiles\kimg_ora.dir\kimg_ora_autogen\mocs_compilation.cpp.obj[2020-04-13T13:06:29.711Z] [19/60] Building CXX object src\imageformats\CMakeFiles\kimg_psd.dir\psd.cpp.obj[2020-04-13T13:06:29.711Z] [20/60] Building CXX object src\imageformats\CMakeFiles\kimg_pcx.dir\pcx.cpp.obj[2020-04-13T13:06:29.711Z] [21/60] Building CXX object src\imageformats\CMakeFiles\kimg_ras.dir\ras.cpp.obj[2020-04-13T13:06:29.711Z] ..\src\imageformats\ras.cpp(107): warning C4018: '>': signed/unsigned mismatch[2020-04-13T13:06:29.711Z] ..\src\imageformats\ras.cpp(132): warning C4018: '>': signed/unsigned mismatch[2020-04-13T13:06:29.711Z] ..\src\imageformats\ras.cpp(279): warning C4018: '>': signed/unsigned mismatch[2020-04-13T13:06:29.711Z] [22/60] Building CXX object src\imageformats\CMakeFiles\kimg_hdr.dir\hdr.cpp.obj[2020-04-13T13:06:29.711Z] [23/60] Building CXX object src\imageformats\CMakeFiles\kimg_tga.dir\tga.cpp.obj[2020-04-13T13:06:29.972Z] [24/60] Linking CXX shared module bin\imageformats\kimg_ora.dll[2020-04-13T13:06:29.972Z]Creating library lib\kimg_ora.lib and object lib\kimg_ora.exp[2020-04-13T13:06:29.972Z]Creating library lib\kimg_ora.lib and object lib\kimg_ora.exp[2020-04-13T13:06:29.972Z] [25/60] Linking CXX shared module bin\imageformats\kimg_psd.dll[2020-04-13T13:06:29.972Z]Creating library lib\kimg_psd.lib and object lib\kimg_psd.exp[2020-04-13T13:06:29.972Z]Creating library lib\kimg_psd.lib and object lib\kimg_psd.exp[2020-04-13T13:06:30.235Z] [26/60] Linking CXX shared module bin\imageformats\kimg_ras.dll[2020-04-13T13:06:30.235Z]Creating library lib\kimg_ras.lib and object lib\kimg_ras.exp[2020-04-13T13:06:30.235Z]Creating library lib\kimg_ras.lib and object lib\kimg_ras.exp[2020-04-13T13:06:30.235Z] [27/60] Linking CXX shared module bin\imageformats\kimg_hdr.dll[2020-04-13T13:06:30.235Z]Creating library lib\kimg_hdr.lib and object lib\kimg_hdr.exp[2020-04-13T13:06:30.235Z]Creating library lib\kimg_hdr.lib and object lib\kimg_hdr.exp[2020-04-13T13:06:30.235Z] [28/60] Linking CXX shared module bin\imageformats\kimg_pcx.dll[2020-04-13T13:06:30.235Z]Creating library lib\kimg_pcx.lib and object lib\kimg_pcx.exp[2020-04-13T13:06:30.235Z]Creating library lib\kimg_pcx.lib and object lib\kimg_pcx.exp[2020-04-13T13:06:30.235Z] [29/60] Building CXX object 

D28774: [KFontRequester] Port from QFontDialog to KFontChooserDialog

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in kfontrequester.cpp:188
> Plus we can't end up with a non-valid QFont, the dialog is filled from 
> QFontDataBase; so unless the user went and uninstalled the font while the 
> dialog was open, it should be OK. Also, font substitution will take care of a 
> font-gone-MIA (I am sure of that on Linux, and most likely other OS's have 
> similar solutions).
> 
> I was curious so I looked at QColorDialog::getColor() and it looks like they 
> changed it (or you meant getRgba?).

And yes, it's not obvious that m_selFont is modified, I had to go read the API 
docs KFontChooser multiple times... but I got used to it.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D28774

To: ahmadsamir, #frameworks, dfaure, cfeck
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27816: KI18N_WRAP_UI macro: set SKIP_AUTOUIC property on ui file and gen. header

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Ping?
  
  I have seen a few projects having CMAKE_AUTOUIC set to ON, due to copy-pasted 
cmake code, or having converted to ki18n only during development. So let's help 
them to avoid unneeded file generation while they are finding the cmake skills. 
And this would also assist bigger projects where some parts use ki18n, others 
might not. so being able to set the default globally by CMAKE_AUTOUIC to ON 
would be nice, and have those UI files being opted out where the macro is used.
  
  While the autouic-generated headers seem currently shadowed, because the 
include path ${target}_autogen/include is being passed only after the include 
path of the current build directory, where the k18n_wrap-ui files puts the 
generated headers, to the compiler, so final build executables are not having 
any issues, this still is a bit fragile. And eats disk space and grows 
dependency ruiles and build time minimally. So better be safe.
  
  BTW, qt5_wrap_ui sets SKIP_AUTOUIC as well on those files.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D27816

To: kossebau, #frameworks, ilic
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28774: [KFontRequester] Port from QFontDialog to KFontChooserDialog

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in kfontrequester.cpp:188
> It's really not obvious from the above that this modifies m_selFont.
> 
> But I see QFont has no isValid() so we can't adopt an API like 
> QColorDialog::getColor (plus KFontChooserDialog has been released now).
> 
> Oh well.

Plus we can't end up with a non-valid QFont, the dialog is filled from 
QFontDataBase; so unless the user went and uninstalled the font while the 
dialog was open, it should be OK. Also, font substitution will take care of a 
font-gone-MIA (I am sure of that on Linux, and most likely other OS's have 
similar solutions).

I was curious so I looked at QColorDialog::getColor() and it looks like they 
changed it (or you meant getRgba?).

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D28774

To: ahmadsamir, #frameworks, dfaure, cfeck
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28774: [KFontRequester] Port from QFontDialog to KFontChooserDialog

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:56090c8f380e: [KFontRequester] Port from QFontDialog to 
KFontChooserDialog (authored by ahmadsamir).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28774?vs=79932=80007

REVISION DETAIL
  https://phabricator.kde.org/D28774

AFFECTED FILES
  src/kfontrequester.cpp
  src/kfontrequester.h

To: ahmadsamir, #frameworks, dfaure, cfeck
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Update on Status of Gitlab Migration

[Albert Vaca Cintora]

On Sat, Apr 11, 2020 at 11:36 AM Ben Cooksley  wrote:
>
> Good morning Community,
>
> I'm pleased to report that this week we reached a major milestone,
> with all the necessary technical components now being in place on our
> side for our migration to Gitlab to take place.

Regarding this: is the subdomain going to stay invent.kde.org once we
have officially moved? I find it's a bit confusing to use that instead
of gitlab.kde.org

Albert

D28770: Avoid blocking the UI thread

[Martin Tobias Holmedahl Sandsmark]

sandsmark added inline comments.

INLINE COMMENTS

> broulik wrote in currency.cpp:57
> Can probably just use `QNetworkConfigurationManager::isOnline()`?

IIRC that's less reliable (e. g. if you don't use networkmanager or connman). 
the whole bearer thing is a bit messy, I guess that's why it's going away. but 
this is also not very good, it just checks for IPs while it should at the very 
least wait for a route to a gateway (I spent way to much time on this problem 
at work...).

tldr: we could probably just remove the whole thing, that's why I added the 
retry-timer.

> broulik wrote in currency.cpp:154
> Whenever you do networking in KDE, ensure it follows redirects:
> `setRedirectPolicy(QNetworkRequest::NoLessSafeRedirectPolicy)` I guess

I don't think that makes sense, but sure.

> ngraham wrote in currency.cpp:884
> why?

Because:
F8233868: image.png 

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D28770

To: sandsmark, ngraham, #frameworks, broulik
Cc: broulik, ngraham, kde-frameworks-devel, #frameworks, LeGast00n, cblack, 
michaelh, bruns

D28770: Avoid blocking the UI thread

[Martin Tobias Holmedahl Sandsmark]

sandsmark updated this revision to Diff 80004.
sandsmark marked 5 inline comments as done.
sandsmark added a comment.


  Fixed review comments

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28770?vs=79910=80004

REVISION DETAIL
  https://phabricator.kde.org/D28770

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/convertertest.cpp
  autotests/convertertest.h
  autotests/valuetest.cpp
  autotests/valuetest.h
  src/currency.cpp
  src/currency_p.h

To: sandsmark, ngraham, #frameworks, broulik
Cc: broulik, ngraham, kde-frameworks-devel, #frameworks, LeGast00n, cblack, 
michaelh, bruns

D28770: Avoid blocking the UI thread

[Martin Tobias Holmedahl Sandsmark]

sandsmark added a comment.


  In D28770#646989 , @broulik wrote:
  
  > I don't fully understand the need for a thread here.
  >  It merely blocks because the API is synchronous and thus we create a 
nested eventloop.
  >  I don't think the writing and parsing of the cache file is a real 
bottleneck here.
  
  
  I don't use any threading (unless I'm missing something)? I just rewrote it 
to remove the nested event loop and instead use the normal one, and switched 
from a mutex to a lockfile (I feel that is more appropriate for this usecase, 
QSaveFile is more for data integrity and not racing between applications in my 
head at least).

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D28770

To: sandsmark, ngraham, #frameworks, broulik
Cc: broulik, ngraham, kde-frameworks-devel, #frameworks, LeGast00n, cblack, 
michaelh, bruns

D28769: Add Icelandic Krona

[Martin Tobias Holmedahl Sandsmark]

sandsmark updated this revision to Diff 7.
sandsmark added a comment.


  Forgot to base it on master instead of my feature branch.

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28769?vs=79909=7

REVISION DETAIL
  https://phabricator.kde.org/D28769

AFFECTED FILES
  src/currency.cpp
  src/unit.h

To: sandsmark, #frameworks
Cc: ngraham, kde-frameworks-devel, #frameworks, LeGast00n, cblack, michaelh, 
bruns

D28535: [KIO-MTP] Fix null pointer dereference

[Alexander Saoutkin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:94e7b64325f9: [KIO-MTP] Fix null pointer dereference 
(authored by feverfew).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28535?vs=79252=79998

REVISION DETAIL
  https://phabricator.kde.org/D28535

AFFECTED FILES
  mtp/kiod_module/mtpdevice.cpp

To: feverfew, akrutzler, dfaure, elvisangelaccio
Cc: anthonyfieroni, kde-frameworks-devel, fvogt, kfm-devel, ngraham, azyx, 
nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D24773: kio_trash: Add size, modification, access and create date for trash:/

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> trashimpl.cpp:1098
> +
> +// Find lateest modification date
> +if (res.mtime > latestModifiedDate) {

typo: latest

> trashsizecache.cpp:144
> +if (trashFileInfo.exists() && 
> trashFileInfo.lastModified().toMSecsSinceEpoch() > max_mtime) {
> +max_mtime = 
> trashFileInfo.lastModified().toMSecsSinceEpoch();
> +}

This calls lastModified().toMSecsSinceEpoch() twice.

How about a lambda for (at least)

  if (lastModTime > max_mtime) {
   max_mtime = lastModTime;
  }

and then you can call that lambda with  lastModified().toMSecsSinceEpoch()?
I was thinking about suggesting such a lambda anyway since that logic exists 4 
times in this code.

In fact, checking that the trashinfo file exists is something that should be 
done in all code paths, no? So there's a lot more code that can be factored 
out, I would think.

> trashsizecache.cpp:168
>  if (!usableCache) {
> +// orphaned directories
>  const qulonglong size = 
> DiscSpaceUtil::sizeOfPath(file.absoluteFilePath());

orphaned sounds like "no .trashinfo file pointing to that dir".

But that's not the case here. It's just items that have been added to the trash 
without being added to the cache file (many implementations do that, the cache 
is optional).

So the directory is not listed in the cache, or is listed with a too old mtime 
i.e. it wasn't updated when adding another item into it.

> trashsizecache.cpp:171
>  sum += size;
> -add(fileId, size);
> +long mtime = 
> QFileInfo(file.absolutePath()).lastModified().toMSecsSinceEpoch() ;
> +if (mtime > max_mtime) {

Not technically correct, this is the mtime of the directory, while there could 
be much more recent items inside that directory.

But I'm wondering how much effort we want to put into finding the latest mtime, 
this is starting to sound like a very expensive operation.

So I'm actually find with this known bug, maybe with a comment about how this 
is a heuristic -- in a fallback for bad implementations.
When kio_trash takes care of the trashing, we should never end up in this code 
path (right?)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/9/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Mon, 13 Apr 2020 10:31:41 +
 Build duration:
2 min 5 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D28782: [Fstab] Do not emit deviceAdded twice on fstab/mtab changes

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:3adf5d472448: [Fstab] Do not emit deviceAdded twice on 
fstab/mtab changes (authored by bruns).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28782?vs=79955=79994

REVISION DETAIL
  https://phabricator.kde.org/D28782

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabmanager.cpp

To: bruns, #frameworks, afiestas, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/8/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Mon, 13 Apr 2020 10:29:41 +
 Build duration:
1 min 37 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D28779: [Fstab] Use new style connect API

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:62de28267684: [Fstab] Use new style connect API (authored 
by bruns).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28779?vs=79951=79993

REVISION DETAIL
  https://phabricator.kde.org/D28779

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabdevice.h
  src/solid/devices/backends/fstab/fstabmanager.cpp
  src/solid/devices/backends/fstab/fstabwatcher.cpp

To: bruns, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/7/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Mon, 13 Apr 2020 10:27:11 +
 Build duration:
2 min 10 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D28779: [Fstab] Use new style connect API

[Stefan Brüns]

bruns edited the summary of this revision.

REPOSITORY
  R245 Solid

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28779

To: bruns, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28778: [FstabWatcher] Use static QStringLiteral instead of macro

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:340e1ac7c38f: [FstabWatcher] Use static QStringLiteral 
instead of macro (authored by bruns).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28778?vs=79990=79992

REVISION DETAIL
  https://phabricator.kde.org/D28778

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabwatcher.cpp

To: bruns, #frameworks, apol
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28746: Show previews on encrypted filesystems

[Marcin Gurtowski]

marcingu marked 2 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28746

To: marcingu, ivan, #frameworks, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28746: Show previews on encrypted filesystems

[Marcin Gurtowski]

marcingu updated this revision to Diff 79991.
marcingu added a comment.


  Moving boolean variables to the front of logic statement.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28746?vs=79985=79991

REVISION DETAIL
  https://phabricator.kde.org/D28746

AFFECTED FILES
  src/widgets/previewjob.cpp

To: marcingu, ivan, #frameworks, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28778: [FstabWatcher] Use static QStringLiteral instead of macro

[Stefan Brüns]

bruns updated this revision to Diff 79990.
bruns added a comment.


  move statics into namespace

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28778?vs=79949=79990

REVISION DETAIL
  https://phabricator.kde.org/D28778

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabwatcher.cpp

To: bruns, #frameworks, apol
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns