Re: Review Request 128665: Nested tags for Baloo Widgets
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128665/ --- (Updated Feb. 19, 2017, 8:10 p.m.) Status -- This change has been marked as submitted. Review request for Baloo. Changes --- Submitted with commit 0a2c8177439770f5a69826abebda1a53d26078a5 by James D. Smith to branch master. Bugs: 334615 http://bugs.kde.org/show_bug.cgi?id=334615 Repository: baloo-widgets Description --- Info pane tags are shortened to their last element, with the full tag shown in each tag's tooltip. The tag selector box allows for creating and selecting nested tags. Diffs - src/kedittagsdialog.cpp 1778d53 src/kedittagsdialog_p.h 3c4de19 src/tagcheckbox.cpp 8273a7f Diff: https://git.reviewboard.kde.org/r/128665/diff/ Testing --- Compile, run File Attachments Edit Tags Dialog https://git.reviewboard.kde.org/media/uploaded/files/2016/09/07/b572b577-0931-40c5-a6d9-6dd655b0f1b6__baloonestedtagwidget.png Thanks, James Smith
Re: Review Request 128665: Nested tags for Baloo Widgets
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128665/ --- (Updated Feb. 15, 2017, 1:26 p.m.) Review request for Baloo. Changes --- Separate the tag and widget loading to allow rebuilding the tag widget when the lineedit is cleared. Fix an issue with an existing tag where the tag check box isn't selected when the linedit contains its entry. Fix an expansion bug also affecting existing tags. Remove the 64 char limitation. Bugs: 334615 http://bugs.kde.org/show_bug.cgi?id=334615 Repository: baloo-widgets Description --- Info pane tags are shortened to their last element, with the full tag shown in each tag's tooltip. The tag selector box allows for creating and selecting nested tags. Diffs (updated) - src/kedittagsdialog.cpp 1778d53 src/kedittagsdialog_p.h 3c4de19 src/tagcheckbox.cpp 8273a7f Diff: https://git.reviewboard.kde.org/r/128665/diff/ Testing --- Compile, run File Attachments Edit Tags Dialog https://git.reviewboard.kde.org/media/uploaded/files/2016/09/07/b572b577-0931-40c5-a6d9-6dd655b0f1b6__baloonestedtagwidget.png Thanks, James Smith
Re: Review Request 128665: Nested tags for Baloo Widgets
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128665/ --- (Updated Sept. 22, 2016, 6:41 p.m.) Review request for Baloo. Changes --- 1) Append copyright. 2) Use C++11 for loop. Bugs: 334615 http://bugs.kde.org/show_bug.cgi?id=334615 Repository: baloo-widgets Description --- Info pane tags are shortened to their last element, with the full tag shown in each tag's tooltip. The tag selector box allows for creating and selecting nested tags. Diffs (updated) - src/kedittagsdialog.cpp 1778d53 src/kedittagsdialog_p.h 3c4de19 src/tagcheckbox.cpp 8273a7f Diff: https://git.reviewboard.kde.org/r/128665/diff/ Testing --- Compile, run File Attachments Edit Tags Dialog https://git.reviewboard.kde.org/media/uploaded/files/2016/09/07/b572b577-0931-40c5-a6d9-6dd655b0f1b6__baloonestedtagwidget.png Thanks, James Smith
Re: Review Request 128665: Nested tags for Baloo Widgets
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128665/ --- (Updated Sept. 7, 2016, 9:02 p.m.) Review request for Baloo. Changes --- Add screenshot. Bugs: 334615 http://bugs.kde.org/show_bug.cgi?id=334615 Repository: baloo-widgets Description --- Info pane tags are shortened to their last element, with the full tag shown in each tag's tooltip. The tag selector box allows for creating and selecting nested tags. Diffs - src/kedittagsdialog.cpp 1778d53 src/kedittagsdialog_p.h 3c4de19 src/tagcheckbox.cpp 8273a7f Diff: https://git.reviewboard.kde.org/r/128665/diff/ Testing --- Compile, run File Attachments (updated) Edit Tags Dialog https://git.reviewboard.kde.org/media/uploaded/files/2016/09/07/b572b577-0931-40c5-a6d9-6dd655b0f1b6__baloonestedtagwidget.png Thanks, James Smith
Re: Review Request 128665: Nested tags for Baloo Widgets
> On Aug. 19, 2016, 8:52 a.m., Vishesh Handa wrote: > > Could you please attach some screenshots of the before and after? > > James Smith wrote: > I don't think it's really necessary, the existing indexed tag was erased > if a tag higher up was selected, or an expanded first-level indexed tag > became unexpanded when erasing an unsaved new tag beyond the last item of the > indexed tag. I cannot visaulize how this looks by just reading at the code. Please add images. Otherwise I need to compile this code and try it out manually. - Vishesh --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128665/#review98495 --- On Aug. 19, 2016, 12:05 a.m., James Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128665/ > --- > > (Updated Aug. 19, 2016, 12:05 a.m.) > > > Review request for Baloo. > > > Bugs: 334615 > http://bugs.kde.org/show_bug.cgi?id=334615 > > > Repository: baloo-widgets > > > Description > --- > > Info pane tags are shortened to their last element, with the full tag shown > in each tag's tooltip. The tag selector box allows for creating and selecting > nested tags. > > > Diffs > - > > src/kedittagsdialog.cpp 1778d53 > src/kedittagsdialog_p.h 3c4de19 > src/tagcheckbox.cpp 8273a7f > > Diff: https://git.reviewboard.kde.org/r/128665/diff/ > > > Testing > --- > > Compile, run > > > Thanks, > > James Smith > >
Re: Review Request 128665: Nested tags for Baloo Widgets
> On Aug. 19, 2016, 8:52 a.m., Vishesh Handa wrote: > > Could you please attach some screenshots of the before and after? I don't think it's really necessary, the existing indexed tag was erased if a tag higher up was selected, or an expanded first-level indexed tag became unexpanded when erasing an unsaved new tag beyond the last item of the indexed tag. - James --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128665/#review98495 --- On Aug. 19, 2016, 12:05 a.m., James Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128665/ > --- > > (Updated Aug. 19, 2016, 12:05 a.m.) > > > Review request for Baloo. > > > Bugs: 334615 > http://bugs.kde.org/show_bug.cgi?id=334615 > > > Repository: baloo-widgets > > > Description > --- > > Info pane tags are shortened to their last element, with the full tag shown > in each tag's tooltip. The tag selector box allows for creating and selecting > nested tags. > > > Diffs > - > > src/kedittagsdialog.cpp 1778d53 > src/kedittagsdialog_p.h 3c4de19 > src/tagcheckbox.cpp 8273a7f > > Diff: https://git.reviewboard.kde.org/r/128665/diff/ > > > Testing > --- > > Compile, run > > > Thanks, > > James Smith > >
Re: Review Request 128665: Nested tags for Baloo Widgets
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128665/#review98495 --- Could you please attach some screenshots of the before and after? - Vishesh Handa On Aug. 19, 2016, 12:05 a.m., James Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128665/ > --- > > (Updated Aug. 19, 2016, 12:05 a.m.) > > > Review request for Baloo. > > > Bugs: 334615 > http://bugs.kde.org/show_bug.cgi?id=334615 > > > Repository: baloo-widgets > > > Description > --- > > Info pane tags are shortened to their last element, with the full tag shown > in each tag's tooltip. The tag selector box allows for creating and selecting > nested tags. > > > Diffs > - > > src/kedittagsdialog.cpp 1778d53 > src/kedittagsdialog_p.h 3c4de19 > src/tagcheckbox.cpp 8273a7f > > Diff: https://git.reviewboard.kde.org/r/128665/diff/ > > > Testing > --- > > Compile, run > > > Thanks, > > James Smith > >
Re: Review Request 128665: Nested tags for Baloo Widgets
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128665/ --- (Updated Aug. 19, 2016, 12:05 a.m.) Review request for Baloo. Changes --- Fix some selection and expansion bugs. Bugs: 334615 http://bugs.kde.org/show_bug.cgi?id=334615 Repository: baloo-widgets Description --- Info pane tags are shortened to their last element, with the full tag shown in each tag's tooltip. The tag selector box allows for creating and selecting nested tags. Diffs (updated) - src/kedittagsdialog.cpp 1778d53 src/kedittagsdialog_p.h 3c4de19 src/tagcheckbox.cpp 8273a7f Diff: https://git.reviewboard.kde.org/r/128665/diff/ Testing --- Compile, run Thanks, James Smith
