Re: Review Request 124213: Add standard shortcut for new tab action

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124213/#review81896
---


+1 for Ctrl+T but not sure about Ctrl+Shift+N, never seen that used for that 
purpose, just incognito mode, or new window in applications like Konsole.


src/gui/kstandardshortcut.h (line 372)
https://git.reviewboard.kde.org/r/124213/#comment56244

Isn't Ctrl+Tab usually next tab?


- Kai Uwe Broulik


On Juni 30, 2015, 9:13 vorm., Simon Persson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124213/
 ---
 
 (Updated Juni 30, 2015, 9:13 vorm.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kconfig
 
 
 Description
 ---
 
 QKeySequence already has AddTab as a standard shortcut, but it was missing in 
 KStandardShortcut. Main problem with this is that users could not configure 
 the shortcut globally. This is of course only a first step, applications 
 would have to be updated to use this also.
 Since QKeySequence uses Ctrl+Shift+N and Ctrl+T for this action when running 
 on KDE, this patch just goes with that as the chosen default.
 Also fixes documentation error for tabNext and tabPrev that I happened to 
 notice.
 
 
 Diffs
 -
 
   src/gui/kstandardshortcut.h 5bb07fb 
   src/gui/kstandardshortcut.cpp 8400737 
 
 Diff: https://git.reviewboard.kde.org/r/124213/diff/
 
 
 Testing
 ---
 
 Compiles, test suite ok.
 
 
 Thanks,
 
 Simon Persson
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124212: kwindowsystem: Change source file layout

[Kai Uwe Broulik]

 On Juni 30, 2015, 8:30 vorm., Kai Uwe Broulik wrote:
  Doesn't build on OSX:
  
  [ 24%] Building CXX object 
  src/CMakeFiles/KF5WindowSystem.dir/platforms/osx/kkeyserver_mac.cpp.o
  [ 27%] Building CXX object 
  src/CMakeFiles/KF5WindowSystem.dir/KF5WindowSystem_automoc.cpp.o
  In file included from 
  /Users/broulik/Documents/kf5/kwindowsystem/src/kkeyserver.cpp:23:
  /Users/broulik/Documents/kf5/kwindowsystem/src/kkeyserver.h:34:10: fatal 
  error: 'kkeyserver_mac.h' file not found
  #include kkeyserver_mac.h
   ^
  1 error generated.
  make[2]: *** [src/CMakeFiles/KF5WindowSystem.dir/kkeyserver.cpp.o] Error 1
  make[2]: *** Waiting for unfinished jobs
  /Users/broulik/Documents/kf5/kwindowsystem/src/platforms/osx/kkeyserver_mac.cpp:64:13:
   warning: unused variable
'lastLayoutID' [-Wunused-variable]
  static long lastLayoutID = -1;
  ^
  1 warning generated.
  make[1]: *** [src/CMakeFiles/KF5WindowSystem.dir/all] Error 2
  make: *** [all] Error 2
 
 Martin Gräßlin wrote:
 did it build before?
 
 Kai Uwe Broulik wrote:
 yes
 
 Martin Gräßlin wrote:
 can you please test with:
 
 diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
 index adf1e34..0cbab72 100644
 --- a/src/CMakeLists.txt
 +++ b/src/CMakeLists.txt
 @@ -46,6 +46,7 @@ if (KWINDOWSYSTEM_HAVE_X11)
  endif ()
  
  if (APPLE)
 +   include_directories(${CMAKE_CURRENT_SOURCE_DIR}/platforms/osx)
 set(kwindowsystem_SRCS ${kwindowsystem_SRCS} 
 platforms/osx/kkeyserver_mac.cpp
  # kwindowsystem_mac.cpp
  # FIXME: adjust kwindowinfo_mac to inherit from KWindowInfoPrivate
 @@ -55,6 +56,7 @@ if (APPLE)
  endif ()
  
  if (WIN32)
 +   include_directories(${CMAKE_CURRENT_SOURCE_DIR}/platforms/windows)
 set(kwindowsystem_SRCS ${kwindowsystem_SRCS} 
 platforms/windows/kkeyserver_win.cpp
  # kwindowsystem_win.cpp
  # FIXME: adjust kwindowinfo_win to inherit from KWindowInfoPrivate

That fixes the build.

I now just get a warning about:
/Users/broulik/Documents/kf5/kwindowsystem/src/platforms/osx/kkeyserver_mac.cpp:64:13:
 warning: unused variable
  'lastLayoutID' [-Wunused-variable]
static long lastLayoutID = -1;
^
1 warning generated.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124212/#review81880
---


On Juni 30, 2015, 6:19 vorm., Martin Gräßlin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124212/
 ---
 
 (Updated Juni 30, 2015, 6:19 vorm.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kwindowsystem
 
 
 Description
 ---
 
 In the src directory we introduce a platforms directory with a specific
 * osx
 * wayland
 * windows
 * xcb
 
 sub directory. The platform specific source and header files are moved
 into those directories.
 
 This is a preparation step to move the platform specific behavior into
 plugins which get loaded at runtime. Such a change is required to
 support more platforms in future for which kwindowsystem cannot provide
 support directly. An example is proper Wayland support on the Plasma
 platform. It needs to provide its own implementationn which has to
 differ from the generic Wayland implementation.
 
 
 Diffs
 -
 
   src/kxutils_p.h  
   src/netwm.h  
   src/netwm.cpp  
   src/netwm_p.h  
   src/platforms/CMakeLists.txt PRE-CREATION 
   src/platforms/osx/CMakeLists.txt PRE-CREATION 
   src/platforms/wayland/CMakeLists.txt PRE-CREATION 
   src/platforms/windows/CMakeLists.txt PRE-CREATION 
   src/platforms/xcb/CMakeLists.txt PRE-CREATION 
   src/kxutils.cpp  
   src/kxmessages.h  
   src/kxmessages.cpp  
   src/kxerrorhandler_p.h  
   src/kxerrorhandler.cpp  
   src/kwindowsystem_win.cpp  
   src/kwindowsystem_x11.cpp  
   src/kselectionowner.cpp  
   src/kselectionowner.h  
   src/kmanagerselection.h  
   src/kkeyserver_x11.cpp  
   src/kkeyserver_win.cpp  
   src/kkeyserver_x11.h  
   src/kkeyserver_win.h  
   src/kkeyserver_mac.cpp  
   src/fixx11h.h  
   src/kkeyserver_mac.h  
   src/CMakeLists.txt ff2ce392ecd7969eb94543528c7a670ea0fcd870 
   autotests/CMakeLists.txt dda0af259b292ee5e526bb9166811fc1b376f388 
   src/kwindowsystem_wayland.cpp  
   src/kwindowsystem_p_x11.h  
   src/kwindowsystem_p_wayland.h  
   src/kwindowsystem_mac.cpp  
   src/kwindowsystem.cpp 789132e1b4883dd54218d29af9710dedfe6218e1 
   src/kwindowinfo_x11.cpp  
   src/kwindowinfo_p_x11.h  
   src/kwindowinfo_win.cpp  
   src/kwindowinfo_mac_p.h  
   src/kwindowinfo_mac.cpp  
   src/kselectionwatcher.cpp  
   src/kwindoweffects_x11.cpp

Re: Review Request 124014: Add QQC clone of KColorButton

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124014/#review82011
---

Ship it!


Ship It!

- Kai Uwe Broulik


On Juni 7, 2015, 7:30 vorm., David Edmundson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124014/
 ---
 
 (Updated Juni 7, 2015, 7:30 vorm.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kdeclarative
 
 
 Description
 ---
 
 Add QQC clone of KColorButton. 
 
 It's being used by SystemLoadViewer Plasmoid, Kai's clock review, and a mod 
 I'm doing for the notes plasmoid and it's something we'll want to have.
 
 High DPI support works perfectly as these are device independent pixels.
 
 
 Diffs
 -
 
   src/qmlcontrols/kquickcontrols/CMakeLists.txt 
 b7c08d7bcb46e53407d4b44fa593346f9d0a2137 
   src/qmlcontrols/kquickcontrols/ColorButton.qml PRE-CREATION 
   src/qmlcontrols/kquickcontrols/qmldir 
 31d8b145bf50491f94a14ba317b215fd6cc0ca32 
   tests/colorButtonTest.qml PRE-CREATION 
 
 Diff: https://git.reviewboard.kde.org/r/124014/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 David Edmundson
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123890: Don't show KDE Frameworks version in the About KDE dialog

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123890/#review80775
---



src/kaboutkdedialog_p.cpp (line 46)
https://git.reviewboard.kde.org/r/123890/#comment55377

I suppose you can also remove the HTML stuff since KTitleWidget now uses an 
increased font size anyway.


- Kai Uwe Broulik


On Mai 24, 2015, 4:26 vorm., Albert Astals Cid wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123890/
 ---
 
 (Updated Mai 24, 2015, 4:26 vorm.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kxmlgui
 
 
 Description
 ---
 
 Doesn't make sense, if you want to know which frameworks version you're using 
 you can use the application dialog version, this is about kde, and as such 
 it's about the community, the frameworks version there matters nothing
 
 
 Diffs
 -
 
   src/kaboutkdedialog_p.cpp 1c3539b 
 
 Diff: https://git.reviewboard.kde.org/r/123890/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Albert Astals Cid
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Minimum supported version of MSVC for frameworks

[Kai Uwe Broulik]

‎Hi,

My experience with MSVC 2013 was that you even need at least Update 4 for 
initializer lists to work properly, which was released quite recently iirc.

Cheers,
Kai Uwe

  Originalnachricht  
Von: Kevin Funk
Gesendet: Donnerstag, 13. August 2015 10:48
An: kde-frameworks-devel
Antwort an: kde-frameworks-devel@kde.org
Betreff: Minimum supported version of MSVC for frameworks

Heya,

I'm writing this to inform you that KF5 is not compilable under MSVC2012 as-is 
right now. This is the minimum required version as of [1].

Biggest issues are initializer-lists and non-static data member 
initialization, default + deleted functions (example patch against kdecoration 
here: [2]).

My question: 
- Do we even want to hold the requirement on MSVC2012?
- People want to use new features from C++11, and they do it
- Patches like [2] feel like going one step back again
- To me, it would make more sense to just lift our req. to MSVC2013
(with much better (despite still broken) C++11 support anyway)

Opinions? If you want, I can make sure KF5 builds on MSVC2013, at least, in 
irregular intervals.

Cheers

[1] 
https://community.kde.org/Frameworks/Policies#Frameworks_compiler_requirements_and_C.2B.2B11
[2] https://paste.kde.org/pspfos96w

-- 
Kevin Funk | kf...@kde.org | http://kfunk.org
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [Kde-hardware-devel] Review Request 124778: Suspend using UPower in case of ConsoleKit 1

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124778/
---

(Updated Aug. 17, 2015, 8:54 a.m.)


Status
--

This change has been marked as submitted.


Review request for Solid and Eric Koegel.


Changes
---

Submitted with commit 41d369f7c57b31f13cb120d09b3e9f71119d86f4 by Kai Uwe 
Broulik to branch Plasma/5.4.


Bugs: 351365
https://bugs.kde.org/show_bug.cgi?id=351365


Repository: powerdevil


Description
---

With the new ConsoleKit 2 support we always have a login1Interface available 
which means we try to suspend through it even if we're on ConsoleKit 1 which 
doesn't work.

We'll remove CK1 support in 5.5 but until then I don't want to unneccessarily 
break stuff.


Diffs
-

  daemon/backends/upower/powerdevilupowerbackend.h 0a1b76b 
  daemon/backends/upower/powerdevilupowerbackend.cpp 651f777 

Diff: https://git.reviewboard.kde.org/r/124778/diff/


Testing
---

My machine still suspends using the Login1 suspend job and it was reported this 
patch fixes the bug


Thanks,

Kai Uwe Broulik

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Where are kdeglobals defaults?

[Kai Uwe Broulik]

Hi all,

I tried to find out why the default colorscheme was still Oxygen, which 
unfortunately slipped into the Applications 15.08 promo screenshots, and found 
that all the colors KCM does is KConfig::sharedConfig(Kdeglobals); 
setReadDefaults(true); read(); setReadDefalts(false) but I just cannot figure 
out where the defaults for eg. colorScheme are actually stored.

Hints welcome,
Kai Uwe

 Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe 

Review Request 124872: Default to Breeze colors

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124872/
---

Review request for KDE Frameworks, Plasma and KDE Usability.


Repository: kconfigwidgets


Description
---

This makes KColorScheme return Breeze colors by default.


Diffs
-

  src/kcolorscheme.cpp f1ec1e3 

Diff: https://git.reviewboard.kde.org/r/124872/diff/


Testing
---

Seems to look right, typos reserved :)

Only thing missing now is the window decoration which is set in the WM section 
of kdeglobals by the breeze.colors but KWin defaults to highlight colors, so it 
stays blue.


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124872: Default to Breeze colors

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124872/
---

(Updated Aug. 21, 2015, 9:23 nachm.)


Review request for KDE Frameworks, Plasma and KDE Usability.


Repository: kconfigwidgets


Description (updated)
---

This makes KColorScheme return Breeze colors by default, ie. choosing Default 
in Colors KCM is no longer Oxygen.


Diffs
-

  src/kcolorscheme.cpp f1ec1e3 

Diff: https://git.reviewboard.kde.org/r/124872/diff/


Testing
---

Seems to look right, typos reserved :)

Only thing missing now is the window decoration which is set in the WM section 
of kdeglobals by the breeze.colors but KWin defaults to highlight colors, so it 
stays blue.


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Where are kdeglobals defaults?

[Kai Uwe Broulik]

‎Yup, thanks! :) And I desperately grep'd all of Frameworks for clues about 
colorScheme

  Originalnachricht  
Von: Albert Astals Cid
Gesendet: Freitag, 21. August 2015 23:05
An: kde-devel@kde.org
Cc: Kai Uwe Broulik
Betreff: Re: Where are kdeglobals defaults?

El Divendres, 21 d'agost de 2015, a les 21:13:51, Kai Uwe Broulik va escriure:
 Hi all,
 
 I tried to find out why the default colorscheme was still Oxygen, which
 unfortunately slipped into the Applications 15.08 promo screenshots, and
 found that all the colors KCM does is KConfig::sharedConfig(Kdeglobals);
 setReadDefaults(true); read(); setReadDefalts(false) but I just cannot
 figure out where the defaults for eg. colorScheme are actually stored.

My 5 minutes investigation, may be wrong:

* The kdeglobals are at 
http://lxr.kde.org/source//frameworks/kcmutils/src/kdeglobals.kcfg

But you can see there that there are not many/any colors defined.

So we go to the code and see 
m_config-setReadDefaults(true);
icon = createSchemePreviewIcon(m_config);

and createSchemePreviewIcon does
KColorScheme windowScheme(QPalette::Active, KColorScheme::Window, config);

the KColorScheme constructor does
d = new KColorSchemePrivate(config, state, Colors:Window, 
defaultWindowColors);

and the KColorSchemePrivate one does
_brushes.bg[0] = cfg.readEntry(BackgroundNormal, 
SET_DEFAULT(NormalBackground));

So to my understanding the default colors are at default*Colors in 
kcolorscheme.cpp

Hope this is correct :D

Cheers,
Albert

 
 Hints welcome,
 Kai Uwe
 
  Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
  


 Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe 

Re: [Kde-hardware-devel] Review Request 124730: [solid-device-automounter] Port to KF5

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124730/
---

(Updated Aug. 20, 2015, 6:32 nachm.)


Review request for Plasma, Solid and Torrie Fischer.


Changes
---

Address issues


Bugs: 351003
https://bugs.kde.org/show_bug.cgi?id=351003


Repository: plasma-desktop


Description
---

This is a straight port of the solid-device-automounter from kde-runtime that 
was somehow lost to plasma-desktop. I didn't do git graft magic (can this be 
done later? ie. import kde-runtime folder here to there and then apply a diff 
on top?).


Diffs (updated)
-

  CMakeLists.txt 4717780 
  solid-device-automounter/CMakeLists.txt PRE-CREATION 
  solid-device-automounter/COPYING PRE-CREATION 
  solid-device-automounter/SETTINGS PRE-CREATION 
  solid-device-automounter/kcm/CMakeLists.txt PRE-CREATION 
  solid-device-automounter/kcm/DeviceAutomounterKCM.h PRE-CREATION 
  solid-device-automounter/kcm/DeviceAutomounterKCM.cpp PRE-CREATION 
  solid-device-automounter/kcm/DeviceAutomounterKCM.ui PRE-CREATION 
  solid-device-automounter/kcm/DeviceModel.h PRE-CREATION 
  solid-device-automounter/kcm/DeviceModel.cpp PRE-CREATION 
  solid-device-automounter/kcm/LayoutSettings.kcfg PRE-CREATION 
  solid-device-automounter/kcm/LayoutSettings.kcfgc PRE-CREATION 
  solid-device-automounter/kcm/Messages.sh PRE-CREATION 
  solid-device-automounter/kcm/device_automounter_kcm.desktop PRE-CREATION 
  solid-device-automounter/kded/CMakeLists.txt PRE-CREATION 
  solid-device-automounter/kded/DeviceAutomounter.h PRE-CREATION 
  solid-device-automounter/kded/DeviceAutomounter.cpp PRE-CREATION 
  solid-device-automounter/kded/device_automounter.desktop PRE-CREATION 
  solid-device-automounter/lib/AutomounterSettings.h PRE-CREATION 
  solid-device-automounter/lib/AutomounterSettings.cpp PRE-CREATION 
  solid-device-automounter/lib/AutomounterSettingsBase.kcfg PRE-CREATION 
  solid-device-automounter/lib/AutomounterSettingsBase.kcfgc PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124730/diff/


Testing
---

Seems to work, translations are probably broken.
Told it to auto mount all the things, did that. Told it to mount just one thing 
automatically, did that. Somehow the list of non-attached devices grows even 
when I re-attach the same device.


Thanks,

Kai Uwe Broulik

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: Review Request 124746: [KDesktopFile] add readMimeType

[Kai Uwe Broulik]

 On Aug. 18, 2015, 9:47 nachm., David Faure wrote:
  I'm still very surprised by the use case. How are you getting the full path 
  to an application .desktop file without using the KService framework? It 
  sounds like parsing all application desktop files by hand, which sounds 
  horrible ;-)   ... 
  
  
  (and yes readMimeTypes() would be a better name if we end up deciding in 
  favour of this; the desktop field is an historic misnaming, no point in 
  propagating that to C++ developers)

It's for the icon widget (Review 124472) so I can check whether the app 
actually accepts the mime type I'm going to drop onto it. I already have the 
KDesktopFile anyway since its absolute path is stored in the applet's config 
fwict.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124746/#review84020
---


On Aug. 15, 2015, 5:38 nachm., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124746/
 ---
 
 (Updated Aug. 15, 2015, 5:38 nachm.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kconfig
 
 
 Description
 ---
 
 This allows to get the MimeType field of a desktop file to determin whether 
 eg. the given application would accept a given mime type.
 
 I'm not too happy about the name because readMimeType suggests it's a 
 single item but then it's consisteht with the key name.
 
 
 Diffs
 -
 
   src/core/kdesktopfile.cpp 254b59a 
   autotests/kdesktopfiletest.cpp 1a9c1c3 
   src/core/kdesktopfile.h 2190051 
 
 Diff: https://git.reviewboard.kde.org/r/124746/diff/
 
 
 Testing
 ---
 
 Test passes
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [Kde-hardware-devel] Review Request 124730: [solid-device-automounter] Port to KF5

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124730/
---

(Updated Aug. 16, 2015, 6:43 nachm.)


Review request for Plasma, Solid and Torrie Fischer.


Bugs: 351003
https://bugs.kde.org/show_bug.cgi?id=351003


Repository: plasma-desktop


Description
---

This is a straight port of the solid-device-automounter from kde-runtime that 
was somehow lost to plasma-desktop. I didn't do git graft magic (can this be 
done later? ie. import kde-runtime folder here to there and then apply a diff 
on top?).


Diffs
-

  CMakeLists.txt 4717780 
  solid-device-automounter/CMakeLists.txt PRE-CREATION 
  solid-device-automounter/COPYING PRE-CREATION 
  solid-device-automounter/SETTINGS PRE-CREATION 
  solid-device-automounter/kcm/CMakeLists.txt PRE-CREATION 
  solid-device-automounter/kcm/DeviceAutomounterKCM.h PRE-CREATION 
  solid-device-automounter/kcm/DeviceAutomounterKCM.cpp PRE-CREATION 
  solid-device-automounter/kcm/DeviceAutomounterKCM.ui PRE-CREATION 
  solid-device-automounter/kcm/DeviceModel.h PRE-CREATION 
  solid-device-automounter/kcm/DeviceModel.cpp PRE-CREATION 
  solid-device-automounter/kcm/LayoutSettings.kcfg PRE-CREATION 
  solid-device-automounter/kcm/LayoutSettings.kcfgc PRE-CREATION 
  solid-device-automounter/kcm/Messages.sh PRE-CREATION 
  solid-device-automounter/kcm/device_automounter_kcm.desktop PRE-CREATION 
  solid-device-automounter/kded/CMakeLists.txt PRE-CREATION 
  solid-device-automounter/kded/DeviceAutomounter.h PRE-CREATION 
  solid-device-automounter/kded/DeviceAutomounter.cpp PRE-CREATION 
  solid-device-automounter/kded/device_automounter.desktop PRE-CREATION 
  solid-device-automounter/lib/AutomounterSettings.h PRE-CREATION 
  solid-device-automounter/lib/AutomounterSettings.cpp PRE-CREATION 
  solid-device-automounter/lib/AutomounterSettingsBase.kcfg PRE-CREATION 
  solid-device-automounter/lib/AutomounterSettingsBase.kcfgc PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124730/diff/


Testing
---

Seems to work, translations are probably broken.
Told it to auto mount all the things, did that. Told it to mount just one thing 
automatically, did that. Somehow the list of non-attached devices grows even 
when I re-attach the same device.


Thanks,

Kai Uwe Broulik

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124902/#review84264
---



src/kglobalaccel.cpp (line 97)
https://git.reviewboard.kde.org/r/124902/#comment58351

No non trivial global static in a lib?


- Kai Uwe Broulik


On Aug. 24, 2015, 11:35 vorm., Martin Gräßlin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124902/
 ---
 
 (Updated Aug. 24, 2015, 11:35 vorm.)
 
 
 Review request for KDE Frameworks and Kevin Funk.
 
 
 Repository: kglobalaccel
 
 
 Description
 ---
 
 There are usages of KGlobalAccel in e.g. KActionCollection of xmlgui
 framework which do not require a running kglobalaccel5. But due to the
 way KGlobalAccel inits, it always started the runtime part.
 
 This change ensures that kglobalaccel5 is only started once it's actually
 needed, by e.g. registering a global shortcut. If an application does
 not use global shortcuts the API should no longer trigger a start of the
 runtime part.
 
 
 Diffs
 -
 
   src/kglobalaccel_p.h a84f4038dac650ddb0fc1828e67e0851153b4456 
   src/kglobalaccel.cpp 3508c870c70a21e76263b7574c20b408cc09a837 
 
 Diff: https://git.reviewboard.kde.org/r/124902/diff/
 
 
 Testing
 ---
 
 export $(dbus-launch)
 qdbusviewer 
 kate 
 
 - kglobalaccel5 gets started
 
 with the change:
 kglobalaccel5 no longer gets started, when starting an application using 
 global shortcuts, it still gets started
 
 
 Thanks,
 
 Martin Gräßlin
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [Kde-hardware-devel] Review Request 124730: [solid-device-automounter] Port to KF5

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124730/
---

(Updated Aug. 20, 2015, 7:44 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Solid and Torrie Fischer.


Changes
---

Submitted with commit e8a571f09557e9cb597b466c1f61bdb4b68a6913 by Kai Uwe 
Broulik to branch master.


Bugs: 351003
https://bugs.kde.org/show_bug.cgi?id=351003


Repository: plasma-desktop


Description
---

This is a straight port of the solid-device-automounter from kde-runtime that 
was somehow lost to plasma-desktop. I didn't do git graft magic (can this be 
done later? ie. import kde-runtime folder here to there and then apply a diff 
on top?).


Diffs
-

  CMakeLists.txt 4717780 
  solid-device-automounter/CMakeLists.txt PRE-CREATION 
  solid-device-automounter/COPYING PRE-CREATION 
  solid-device-automounter/SETTINGS PRE-CREATION 
  solid-device-automounter/kcm/CMakeLists.txt PRE-CREATION 
  solid-device-automounter/kcm/DeviceAutomounterKCM.h PRE-CREATION 
  solid-device-automounter/kcm/DeviceAutomounterKCM.cpp PRE-CREATION 
  solid-device-automounter/kcm/DeviceAutomounterKCM.ui PRE-CREATION 
  solid-device-automounter/kcm/DeviceModel.h PRE-CREATION 
  solid-device-automounter/kcm/DeviceModel.cpp PRE-CREATION 
  solid-device-automounter/kcm/LayoutSettings.kcfg PRE-CREATION 
  solid-device-automounter/kcm/LayoutSettings.kcfgc PRE-CREATION 
  solid-device-automounter/kcm/Messages.sh PRE-CREATION 
  solid-device-automounter/kcm/device_automounter_kcm.desktop PRE-CREATION 
  solid-device-automounter/kded/CMakeLists.txt PRE-CREATION 
  solid-device-automounter/kded/DeviceAutomounter.h PRE-CREATION 
  solid-device-automounter/kded/DeviceAutomounter.cpp PRE-CREATION 
  solid-device-automounter/kded/device_automounter.desktop PRE-CREATION 
  solid-device-automounter/lib/AutomounterSettings.h PRE-CREATION 
  solid-device-automounter/lib/AutomounterSettings.cpp PRE-CREATION 
  solid-device-automounter/lib/AutomounterSettingsBase.kcfg PRE-CREATION 
  solid-device-automounter/lib/AutomounterSettingsBase.kcfgc PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124730/diff/


Testing
---

Seems to work, translations are probably broken.
Told it to auto mount all the things, did that. Told it to mount just one thing 
automatically, did that. Somehow the list of non-attached devices grows even 
when I re-attach the same device.


Thanks,

Kai Uwe Broulik

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

[Kai Uwe Broulik]

 On Juli 31, 2015, 7:38 nachm., Aleix Pol Gonzalez wrote:
  Is it done yet? What's the status?

I don't know, someone marked it as submitted but it cearly isn't.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123263/#review83263
---


On Juli 31, 2015, 7:15 nachm., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123263/
 ---
 
 (Updated Juli 31, 2015, 7:15 nachm.)
 
 
 Review request for kdeconnect, Solid, Albert Vaca Cintora, and Emmanuel 
 Pescosta.
 
 
 Repository: solid
 
 
 Description
 ---
 
 This adds a KDE Connect backend to Solid enabling us to show phone battery 
 status in the device notifier, and have the phone appear in the device 
 notifier like an external storage.
 
 It is pretty synchronous at the moment. Any ideas how I could improve that? I 
 guess when someone wants to get devices, it creates a new device interface 
 and calls allDevices() or devicesFromQuery() immediately afterwards, so I 
 cannot just do that stuff async and defer population? Or call deviceAdded for 
 each of the initial ones once I have them?
 
 It requires adjustment in the kdeconnect KIO slave so it can handle addresses 
 like kdeconnect://org/kde/kdeconnect/123456 or 
 kdeconnect:udi=/org/kde/kdeconnect/123456 (like mtp kio does) because all 
 Dolphin or the device notifier have is the UDI. It also needs a new device 
 action that matches Portable Media Player with the kdeconnect protocol, 
 similar to mtp.
 
 By adjusting the predicate in Dolphin's Places sidebar (and probably the file 
 dialog) to query for the kdeconnect protocol, we can have its places 
 automatically updated without having KDE Connect manually mess with 
 KFilePlaces.
 
 
 Diffs
 -
 
   src/solid/devices/CMakeLists.txt 9271ae1 
   src/solid/devices/backends/kdeconnect/CMakeLists.txt PRE-CREATION 
   src/solid/devices/backends/kdeconnect/kdeconnectbattery.h PRE-CREATION 
   src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp PRE-CREATION 
   src/solid/devices/backends/kdeconnect/kdeconnectdevice.h PRE-CREATION 
   src/solid/devices/backends/kdeconnect/kdeconnectdevice.cpp PRE-CREATION 
   src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.h 
 PRE-CREATION 
   src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.cpp 
 PRE-CREATION 
   src/solid/devices/backends/kdeconnect/kdeconnectmanager.h PRE-CREATION 
   src/solid/devices/backends/kdeconnect/kdeconnectmanager.cpp PRE-CREATION 
   src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.h 
 PRE-CREATION 
   src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.cpp 
 PRE-CREATION 
   src/solid/devices/managerbase.cpp eee4de5 
 
 Diff: https://git.reviewboard.kde.org/r/123263/diff/
 
 
 Testing
 ---
 
 With some crash fixes already pushed to plasma-workspace it works pretty well.
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123263/
---

(Updated jul. 31, 2015, 9:15 p.m.)


Status
--

This change has been marked as submitted.


Review request for kdeconnect, Solid, Albert Vaca Cintora, and Emmanuel 
Pescosta.


Repository: solid


Description
---

This adds a KDE Connect backend to Solid enabling us to show phone battery 
status in the device notifier, and have the phone appear in the device notifier 
like an external storage.

It is pretty synchronous at the moment. Any ideas how I could improve that? I 
guess when someone wants to get devices, it creates a new device interface and 
calls allDevices() or devicesFromQuery() immediately afterwards, so I cannot 
just do that stuff async and defer population? Or call deviceAdded for each of 
the initial ones once I have them?

It requires adjustment in the kdeconnect KIO slave so it can handle addresses 
like kdeconnect://org/kde/kdeconnect/123456 or 
kdeconnect:udi=/org/kde/kdeconnect/123456 (like mtp kio does) because all 
Dolphin or the device notifier have is the UDI. It also needs a new device 
action that matches Portable Media Player with the kdeconnect protocol, 
similar to mtp.

By adjusting the predicate in Dolphin's Places sidebar (and probably the file 
dialog) to query for the kdeconnect protocol, we can have its places 
automatically updated without having KDE Connect manually mess with KFilePlaces.


Diffs
-

  src/solid/devices/CMakeLists.txt 9271ae1 
  src/solid/devices/backends/kdeconnect/CMakeLists.txt PRE-CREATION 
  src/solid/devices/backends/kdeconnect/kdeconnectbattery.h PRE-CREATION 
  src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp PRE-CREATION 
  src/solid/devices/backends/kdeconnect/kdeconnectdevice.h PRE-CREATION 
  src/solid/devices/backends/kdeconnect/kdeconnectdevice.cpp PRE-CREATION 
  src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.h 
PRE-CREATION 
  src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.cpp 
PRE-CREATION 
  src/solid/devices/backends/kdeconnect/kdeconnectmanager.h PRE-CREATION 
  src/solid/devices/backends/kdeconnect/kdeconnectmanager.cpp PRE-CREATION 
  src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.h 
PRE-CREATION 
  src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.cpp 
PRE-CREATION 
  src/solid/devices/managerbase.cpp eee4de5 

Diff: https://git.reviewboard.kde.org/r/123263/diff/


Testing
---

With some crash fixes already pushed to plasma-workspace it works pretty well.


Thanks,

Kai Uwe Broulik

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Review Request 124746: [KDesktopFile] add readMimeType

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124746/
---

Review request for KDE Frameworks.


Repository: kconfig


Description
---

This allows to get the MimeType field of a desktop file to determin whether eg. 
the given application would accept a given mime type.

I'm not too happy about the name because readMimeType suggests it's a single 
item but then it's consisteht with the key name.


Diffs
-

  src/core/kdesktopfile.cpp 254b59a 
  autotests/kdesktopfiletest.cpp 1a9c1c3 
  src/core/kdesktopfile.h 2190051 

Diff: https://git.reviewboard.kde.org/r/124746/diff/


Testing
---

Test passes


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124397: Add today button to calendar

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124397/#review82653
---


Please include a screenshot for UI changes.

Also please wait until Review 122488 is merged to save me another rebase 
headache.


src/declarativeimports/calendar/qml/MonthView.qml (line 155)
https://git.reviewboard.kde.org/r/124397/#comment57009

Should be go-jump-today I suppose



src/declarativeimports/calendar/qml/MonthView.qml (line 156)
https://git.reviewboard.kde.org/r/124397/#comment57008

ToolButton is square by default



src/declarativeimports/calendar/qml/MonthView.qml (lines 161 - 164)
https://git.reviewboard.kde.org/r/124397/#comment57007

ToolButton has a tooltip property, no need for a custom tooltip


- Kai Uwe Broulik


On Juli 19, 2015, 4:38 nachm., Bernhard Friedreich wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124397/
 ---
 
 (Updated Juli 19, 2015, 4:38 nachm.)
 
 
 Review request for KDE Frameworks and Plasma.
 
 
 Bugs: 348362
 http://bugs.kde.org/show_bug.cgi?id=348362
 
 
 Repository: plasma-framework
 
 
 Description
 ---
 
 Add button Select Today to calendar title bar, aligned to the right
 Removed commented out code to jump to a specific date, this will likely
 be replaced by RR 122488
 
 BUG: 348362
 
 
 Diffs
 -
 
   src/declarativeimports/calendar/qml/MonthView.qml 
 601755f4e9f99618914099e35616e71c332ec7c4 
 
 Diff: https://git.reviewboard.kde.org/r/124397/diff/
 
 
 Testing
 ---
 
 plasmoidviewer with digitalclock plasmoid
 added digitalclock plasmoid to desktop
 
 clicked digital clock plasmoid to view calendar
 Select Today button is shown
 clicked different day
 clicked button - jumps to today
 moved to another month - clicked button -- jumps to today
 
 
 Thanks,
 
 Bernhard Friedreich
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124397: Add today button to calendar

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124397/#review82663
---


+1 from my side

Looking really nice, I wonder why I didn't think of this earlier :)

- Kai Uwe Broulik


On Juli 19, 2015, 5:06 nachm., Bernhard Friedreich wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124397/
 ---
 
 (Updated Juli 19, 2015, 5:06 nachm.)
 
 
 Review request for KDE Frameworks and Plasma.
 
 
 Bugs: 348362
 http://bugs.kde.org/show_bug.cgi?id=348362
 
 
 Repository: plasma-framework
 
 
 Description
 ---
 
 Add button Select Today to calendar title bar, aligned to the right
 Removed commented out code to jump to a specific date, this will likely
 be replaced by RR 122488
 
 BUG: 348362
 
 
 Diffs
 -
 
   src/declarativeimports/calendar/qml/MonthView.qml 
 601755f4e9f99618914099e35616e71c332ec7c4 
 
 Diff: https://git.reviewboard.kde.org/r/124397/diff/
 
 
 Testing
 ---
 
 plasmoidviewer with digitalclock plasmoid
 added digitalclock plasmoid to desktop
 
 clicked digital clock plasmoid to view calendar
 Select Today button is shown
 clicked different day
 clicked button - jumps to today
 moved to another month - clicked button -- jumps to today
 
 
 File Attachments
 
 
 Plasmoidviewer Digital Clock showing Calendar with Today ToolButton
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/edbebbc8-7e06-4edb-98c8-0df5f7f98b27__calendar_today_button.png
 
 
 Thanks,
 
 Bernhard Friedreich
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125790: Recognize image/vnd.adobe.photoshop

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125790/
---

Review request for KDE Frameworks.


Repository: kimageformats


Description
---

This is the mimetype I get for .psd files


Diffs
-

  src/imageformats/psd.desktop 494b746 
  src/imageformats/psd.json 859eede 

Diff: https://git.reviewboard.kde.org/r/125790/diff/


Testing
---

I still don't get any thumbnails for PSD files, though.


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125788: [kio thumbnailer] Recognize image/webp

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125788/
---

Review request for KDE Frameworks.


Repository: kio-extras


Description
---

When I download a .webp file the system claims it to be image/webp, not 
image/x-webp which we already support.


Diffs
-

  thumbnail/imagethumbnail.desktop e64341b 

Diff: https://git.reviewboard.kde.org/r/125788/diff/


Testing
---

I now get thumbnails for .webp files


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125788: [kio thumbnailer] Recognize image/webp

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125788/
---

(Updated Oct. 25, 2015, 12:02 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit b77547ad90467a7f0a37469e9a58417c4ea63b8a by Kai Uwe 
Broulik to branch Applications/15.08.


Repository: kio-extras


Description
---

When I download a .webp file the system claims it to be image/webp, not 
image/x-webp which we already support.


Diffs
-

  thumbnail/imagethumbnail.desktop e64341b 

Diff: https://git.reviewboard.kde.org/r/125788/diff/


Testing
---

I now get thumbnails for .webp files


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125976: add an update() method

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125976/#review88197
---

Ship it!


Not sure if we can use the Package::JobError::Foo syntax in frameworks.


src/kpackage/package.h (line 95)
<https://git.reviewboard.kde.org/r/125976/#comment60485>

NewerVersionAlreadyInstalledError



src/kpackage/package.h (line 96)
<https://git.reviewboard.kde.org/r/125976/#comment60486>

    +Error


- Kai Uwe Broulik


On Nov. 9, 2015, 2:51 nachm., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125976/
> ---
> 
> (Updated Nov. 9, 2015, 2:51 nachm.)
> 
> 
> Review request for KDE Frameworks, Plasma and Kai Uwe Broulik.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> new job based update() function that compared to install()
> if a package with the same pluginId is already installed,
> removes the old one before installing the new one, if
> and only if the version of the new one is more recent
> 
> 
> Diffs
> -
> 
>   autotests/plasmoidpackagetest.h f730dce 
>   autotests/plasmoidpackagetest.cpp 567 
>   src/kpackage/CMakeLists.txt 3696f37 
>   src/kpackage/package.h 4ada8da 
>   src/kpackage/package.cpp 539b21a 
>   src/kpackage/packagestructure.h 9427b42 
>   src/kpackage/packagestructure.cpp 0070514 
>   src/kpackage/private/packagejob.cpp 0d2241b 
>   src/kpackage/private/packagejob_p.h 267429f 
>   src/kpackage/private/packagejobthread.cpp ca523b3 
>   src/kpackage/private/packagejobthread_p.h bf8a266 
>   src/kpackage/private/versionparser.cpp PRE-CREATION 
>   src/kpackagetool/CMakeLists.txt 78e0fb0 
> 
> Diff: https://git.reviewboard.kde.org/r/125976/diff/
> 
> 
> Testing
> ---
> 
> covered by autotests
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125790: Recognize image/vnd.adobe.photoshop

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125790/
---

(Updated Nov. 7, 2015, 12:19 nachm.)


Review request for KDE Frameworks.


Changes
---

Use only vnd.adobe.photoshop as suggested


Repository: kimageformats


Description
---

This is the mimetype I get for .psd files


Diffs (updated)
-

  src/imageformats/psd.desktop 494b746 
  src/imageformats/psd.json 859eede 

Diff: https://git.reviewboard.kde.org/r/125790/diff/


Testing
---

I still don't get any thumbnails for PSD files, though.


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125790: Recognize image/vnd.adobe.photoshop

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125790/
---

(Updated Nov. 3, 2015, 7:51 nachm.)


Review request for KDE Frameworks.


Changes
---

Address issue
Still no PSD thumbs for me


Repository: kimageformats


Description
---

This is the mimetype I get for .psd files


Diffs (updated)
-

  src/imageformats/psd.json 859eede 
  src/imageformats/psd.desktop 494b746 

Diff: https://git.reviewboard.kde.org/r/125790/diff/


Testing
---

I still don't get any thumbnails for PSD files, though.


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

AW: Install UdevQt headers in Solid

[Kai Uwe Broulik]

+1

but I guess we should review and cleanup that stuff whilst at it, however I 
don't really have time to make this stuff Frameworks ready

Gesendet von meinem BlackBerry 10-Smartphone.
  Originalnachricht  
Von: David Rosca
Gesendet: Donnerstag, 5. November 2015 14:27
An: kde-frameworks-devel@kde.org; kde-hardware-de...@kde.org
Antwort an: kde-frameworks-devel@kde.org
Betreff: Install UdevQt headers in Solid

Hi,

I was working on udev device notifier in kcm_keyboard [1] and ended up
with using libudev directly.

We are using libudev in various places, either directly or through
Solid's UdevQt. But in the case of UdevQt, all projects using it have
its own copy [2]. I think it would be better if Solid installs the
udevqt headers instead.

The headers are:

src/solid/devices/backends/shared/udevqt.h
src/solid/devices/backends/shared/udevqtclient.h
src/solid/devices/backends/shared/udevqtdevice.h

Would it be a problem that the headers only gets installed on Linux?
That means the project using it would need to use it only in
Linux-specific code.

Thanks,
David

[1] https://git.reviewboard.kde.org/r/125465/
[2] http://lxr.kde.org/ident?_i=udev
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [Kde-hardware-devel] Install UdevQt headers in Solid

[Kai Uwe Broulik]

+1

but I guess we should review and cleanup that stuff whilst at it, however I 
don't really have time to make this stuff Frameworks ready

Gesendet von meinem BlackBerry 10-Smartphone.
  Originalnachricht  
Von: David Rosca
Gesendet: Donnerstag, 5. November 2015 14:27
An: kde-frameworks-de...@kde.org; kde-hardware-devel@kde.org
Antwort an: kde-frameworks-de...@kde.org
Betreff: Install UdevQt headers in Solid

Hi,

I was working on udev device notifier in kcm_keyboard [1] and ended up
with using libudev directly.

We are using libudev in various places, either directly or through
Solid's UdevQt. But in the case of UdevQt, all projects using it have
its own copy [2]. I think it would be better if Solid installs the
udevqt headers instead.

The headers are:

src/solid/devices/backends/shared/udevqt.h
src/solid/devices/backends/shared/udevqtclient.h
src/solid/devices/backends/shared/udevqtdevice.h

Would it be a problem that the headers only gets installed on Linux?
That means the project using it would need to use it only in
Linux-specific code.

Thanks,
David

[1] https://git.reviewboard.kde.org/r/125465/
[2] http://lxr.kde.org/ident?_i=udev
___
Kde-frameworks-devel mailing list
kde-frameworks-de...@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: Review Request 124963: New widget: KNewPasswordWidget

[Kai Uwe Broulik]

> On Okt. 11, 2015, 9:16 nachm., David Faure wrote:
> > src/knewpasswordwidget.cpp, line 101
> > 
> >
> > qBound(pwstrength, 0, 100) :-)

qBound(0, pwstrength, 100) actually


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124963/#review86678
---


On Okt. 10, 2015, 3:50 nachm., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124963/
> ---
> 
> (Updated Okt. 10, 2015, 3:50 nachm.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> This widget is a stripped-down version of KNewPasswordDialog, without any 
> dialog-specific stuff.
> 
> ### Why a new widget?
> 
> This widget is meant to be easily embedded in any custom password dialog, 
> including KNewPasswordDialog. It's the least common denominator of features 
> that any password dialog should offer to the user.
> 
> ### Features
> 
> * Password visibility action (same as RR 124698). The password verification 
> field is hidden if the user shows the password.
> * Background warning colour. The password verification field gets a coloured 
> background whenever the password and its verification don't match. (feature 
> borrowed from Keepass)
> * Password status signal. This allows the upper level dialogs to update their 
> stuff (enable/disable OK button, show warnings for low password strength, 
> etc.)
> * Password strength bar can be hidden.
> * Unit test.
> 
> ### Use cases
> At least the following:
> 
> * Ark (new archive dialog)
> * KNewPasswordDialog refactoring (my next RR if this one gets accepted)
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt ac708ef33e3be89db85d43911f96e536c52f741d 
>   autotests/knewpasswordwidgettest.h PRE-CREATION 
>   autotests/knewpasswordwidgettest.cpp PRE-CREATION 
>   src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
>   src/knewpasswordwidget.h PRE-CREATION 
>   src/knewpasswordwidget.cpp PRE-CREATION 
>   src/knewpasswordwidget.ui PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124963/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> knewpasswordwidget1.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/28/5796469c-28b7-4151-b9cb-6a327631db75__knewpasswordwidget1.png
> knewpasswordwidget2.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/28/b3bfc9ac-ab8e-404c-8091-b5ad9e3e054f__knewpasswordwidget2.png
> knewpasswordwidget3.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/28/dfaeea4e-65da-4961-b266-986a21f54ca7__knewpasswordwidget3.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124307: Remove Theme tree debug entry

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124307/#review82273
---


+1

- Kai Uwe Broulik


On Juli 9, 2015, 2:55 nachm., Aleix Pol Gonzalez wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124307/
 ---
 
 (Updated Juli 9, 2015, 2:55 nachm.)
 
 
 Review request for KDE Frameworks, Antonio Larrosa Jimenez and Christoph Feck.
 
 
 Repository: kiconthemes
 
 
 Description
 ---
 
 Every time we launch a KDE Application, we see this warning: 
 `kf5.kiconthemes: Theme tree: (Breeze)`
 
 This patch removes it, we're not outputting this for each plugin we have 
 loaded (styles, qpt, etc.) and it doesn't seem very useful to me, so I'd just 
 drop it.
 
 
 Diffs
 -
 
   src/kiconloader.cpp c725115 
 
 Diff: https://git.reviewboard.kde.org/r/124307/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Aleix Pol Gonzalez
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124281/#review82269
---



src/knotificationmanager.cpp (lines 28 - 29)
https://git.reviewboard.kde.org/r/124281/#comment56648

Unused


- Kai Uwe Broulik


On Juli 9, 2015, 1:10 nachm., Martin Klapetek wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124281/
 ---
 
 (Updated Juli 9, 2015, 1:10 nachm.)
 
 
 Review request for KDE Frameworks and Martin Gräßlin.
 
 
 Repository: knotifications
 
 
 Description
 ---
 
 This patch reduces the dependencies of KNotifications framework and 
 effectively makes it a tier 2 framework.
 
 KService is used only for locating additional notification plugins and to my 
 knowledge,
 there are none such plugins currently existing, at least not in all around 
 KDE plus
 the class for the plugins wasn't exported until about two months ago, so this 
 should
 be safe without a legacy support.
 
 KIconThemes is used only to get KIconLoader::Small icon pixmap for 
 notifications
 using KPassivePopup. After some playing around it turns out that it puts the 
 icon into
 the KPassivePopup title and makes it as big as the text. So I've made the 
 icon size to
 be the same as the text height. So this keeps things visually the same + 
 still DPI aware,
 though I believe the KPassivePopup should receive a complete visual overhaul 
 anyway.
 
 Additionally, KCodecs dependency has again one single usage for decoding html 
 entities
 to QChars within QXmlStreamReader parser, so eventually could also be 
 removed/replaced
 with QTextDocument::toPlainText() which seems to do the same job as 
 QXmlStreamReader+KCodecs.
 
 
 Diffs
 -
 
   CMakeLists.txt 2d5437b 
   metainfo.yaml 7fc15f7 
   src/CMakeLists.txt 1cebece 
   src/knotificationmanager.cpp 8d4f953 
   src/knotificationplugin.cpp 7315c17 
   src/notifybypopup.cpp e377051 
   tests/kpassivepopuptest.h bc0dedc 
   tests/kpassivepopuptest.cpp 2486fd8 
 
 Diff: https://git.reviewboard.kde.org/r/124281/diff/
 
 
 Testing
 ---
 
 Everything still compiles + I added a test for KPassivePopup with an icon.
 
 
 Thanks,
 
 Martin Klapetek
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [Kde-hardware-devel] Review Request 124318: Load DPMSAction only on xcb platform

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124318/#review82314
---

Ship it!


Thanks!

- Kai Uwe Broulik


On Juli 10, 2015, 9:21 vorm., Martin Gräßlin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124318/
 ---
 
 (Updated Juli 10, 2015, 9:21 vorm.)
 
 
 Review request for Plasma and Solid.
 
 
 Repository: powerdevil
 
 
 Description
 ---
 
 The DPMS action is implemented in a very x11 specific way calling into
 xcb in the ctor and before supported can be checked. This causes a crash
 on platforms != xcb.
 
 In order to better support other platforms the action is marked as
 xcb specific in the desktop file and the loading of Actions is adjusted
 to only load Actions supported on the current platform.
 
 
 Diffs
 -
 
   daemon/actions/dpms/powerdevildpmsaction.desktop 
 78c5d90fe62559f70431dd4bd6e195b765e0f477 
   daemon/powerdevilactionpool.cpp 0f0e69f0afe447935e6d17872f029c7c4ac33875 
 
 Diff: https://git.reviewboard.kde.org/r/124318/diff/
 
 
 Testing
 ---
 
 No longer crashes in a Plasma/Wayland session.
 
 
 Thanks,
 
 Martin Gräßlin
 


___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123475/#review82337
---

Ship it!


Thanks! Both XRandrBrightness and the helper still work for me.

- Kai Uwe Broulik


On Juli 10, 2015, 1:23 nachm., Martin Gräßlin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123475/
 ---
 
 (Updated Juli 10, 2015, 1:23 nachm.)
 
 
 Review request for Solid and Kai Uwe Broulik.
 
 
 Repository: powerdevil
 
 
 Description
 ---
 
 KJob::exec is dangerous and caused freezes on my system. Thus this change
 to remodel the interaction in an async way.
 
 
 Diffs
 -
 
   daemon/backends/upower/powerdevilupowerbackend.h 
 1c4dd592f0a3cb07b9821c7f82c89517d599635a 
   daemon/backends/upower/powerdevilupowerbackend.cpp 
 87b9cc7b7db1b6a6f5b31263cd3832715c497328 
 
 Diff: https://git.reviewboard.kde.org/r/123475/diff/
 
 
 Testing
 ---
 
 kded5 no longer freezes. But I'm not sure whether the init gets finished: is 
 there a way to easily verify whether the module loaded completely?
 
 
 Thanks,
 
 Martin Gräßlin
 


___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: Review Request 124941: Reparse notification config only when actually needed

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124941/#review84428
---



src/knotificationmanager.cpp (line 3)
https://git.reviewboard.kde.org/r/124941/#comment58447

It's 2015 now



src/knotificationmanager.cpp (line 175)
https://git.reviewboard.kde.org/r/124941/#comment58448

Given you already check whether the entry exists before adding it, a 
removeOne should be sufficient


- Kai Uwe Broulik


On Aug. 26, 2015, 9:05 nachm., Martin Klapetek wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124941/
 ---
 
 (Updated Aug. 26, 2015, 9:05 nachm.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: knotifications
 
 
 Description
 ---
 
 Till now every KNotification::notify() call would reparse the whole cache of 
 configs. With this patch it watches for KNotifyConfig changes and reparses 
 only those configs that had actually changed.
 
 
 Diffs
 -
 
   src/knotificationmanager.cpp 4c648a9 
   src/knotificationmanager_p.h 95e13d1 
   src/knotifyconfig.h fae17cb 
   src/knotifyconfig.cpp 6a46a00 
 
 Diff: https://git.reviewboard.kde.org/r/124941/diff/
 
 
 Testing
 ---
 
 Works as expected.
 
 
 Thanks,
 
 Martin Klapetek
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [Kde-hardware-devel] Review Request 125026: Wayland implementation for DPMS

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125026/#review84747
---


Nice!

Just a few style nitpicks below, haven't tested it yet.


daemon/actions/dpms/abstractdpmshelper.h (lines 18 - 19)
<https://git.reviewboard.kde.org/r/125026/#comment58648>

Add space, same in other files



daemon/actions/dpms/abstractdpmshelper.h (line 27)
<https://git.reviewboard.kde.org/r/125026/#comment58649>

why = default not here?



daemon/actions/dpms/powerdevildpmsaction.cpp (line 45)
<https://git.reviewboard.kde.org/r/125026/#comment58650>

Why this?



daemon/actions/dpms/waylanddpmshelper.h (lines 41 - 42)
<https://git.reviewboard.kde.org/r/125026/#comment58651>

    Add space


- Kai Uwe Broulik


On Sept. 2, 2015, 7:12 vorm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125026/
> ---
> 
> (Updated Sept. 2, 2015, 7:12 vorm.)
> 
> 
> Review request for Plasma, Solid and Kai Uwe Broulik.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> ---
> 
> An AbstractDpmsHelper is introduced with a concrete subclass called
> XcbDpmsHelper. The PowerDevilDpmsAction holds a helper and delegates
> to it. The XcbDpmsHelper implements the X11 specific tasks. This will
> allow to add a Wayland implementation as well.
> 
> [dpms] Add a Wayland implementation
> 
> The Wayland implementation uses the DpmsManager provided by KWayland.
> On a timeout it turns the screens off and it supports the trigger
> modes. The fade helper is not supported (yet) as it is an X11 only
> implementation.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 457f74a318588690c3b9890a5bfdb0a4ea887042 
>   daemon/actions/dpms/CMakeLists.txt 61d7b5684f85c29081dc863abbffa42898089d2a 
>   daemon/actions/dpms/abstractdpmshelper.h PRE-CREATION 
>   daemon/actions/dpms/abstractdpmshelper.cpp PRE-CREATION 
>   daemon/actions/dpms/powerdevildpmsaction.cpp 
> ac824787d5907e78ce0f3ede0e822ffbc778cb3c 
>   daemon/actions/dpms/powerdevildpmsaction.desktop 
> 85ec8619bab9da70fddee4d8815ebdb8899000cd 
>   daemon/actions/dpms/powerdevildpmsaction.h 
> d8b92784abc3717487050928c04c6022480cbd49 
>   daemon/actions/dpms/waylanddpmshelper.h PRE-CREATION 
>   daemon/actions/dpms/waylanddpmshelper.cpp PRE-CREATION 
>   daemon/actions/dpms/xcbdpmshelper.h PRE-CREATION 
>   daemon/actions/dpms/xcbdpmshelper.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125026/diff/
> 
> 
> Testing
> ---
> 
> How I tested:
> * run kwin_wayland on a DRM device
> * started kded5
> * configured powerdevil to suspend after one minute
> * waited
> * watched screen go off
> * enabled again, looked at debug output to verify it was triggered by 
> powerdevil.
>  
> It's currently only tested with Qt 5.4. At least for idle integration I had 
> the problem that things somehow stopped working with 5.5. So this needs 
> additional testing.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: Review Request 124746: [KDesktopFile] add readMimeType

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124746/
---

(Updated Sept. 6, 2015, 3:30 nachm.)


Review request for KDE Frameworks.


Changes
---

- Renamed to readMimeTypes
- Add since 5.15


Repository: kconfig


Description
---

This allows to get the MimeType field of a desktop file to determin whether eg. 
the given application would accept a given mime type.

I'm not too happy about the name because "readMimeType" suggests it's a single 
item but then it's consisteht with the key name.


Diffs (updated)
-

  src/core/kdesktopfile.h 2190051 
  src/core/kdesktopfile.cpp 254b59a 
  autotests/kdesktopfiletest.cpp 1a9c1c3 

Diff: https://git.reviewboard.kde.org/r/124746/diff/


Testing
---

Test passes


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124746: [KDesktopFile] add readMimeType

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124746/
---

(Updated Sept. 7, 2015, 6:45 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit f7a2eef8ac3758cce61717a74987219da6f5d94e by Kai Uwe 
Broulik to branch master.


Repository: kconfig


Description
---

This allows to get the MimeType field of a desktop file to determin whether eg. 
the given application would accept a given mime type.

I'm not too happy about the name because "readMimeType" suggests it's a single 
item but then it's consisteht with the key name.


Diffs
-

  src/core/kdesktopfile.h 2190051 
  src/core/kdesktopfile.cpp 254b59a 
  autotests/kdesktopfiletest.cpp 1a9c1c3 

Diff: https://git.reviewboard.kde.org/r/124746/diff/


Testing
---

Test passes


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [Kde-hardware-devel] Review Request 125248: Display name of process which blocks umount / eject

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125248/#review85488
---


I really like that!

The device notifier UI itself is questionable with the popup telling us "the 
device xyz failed to unmount" rather than just highlighting the device and 
showing the message in the list directly but this is of course outside the 
scope of this patch.

+1 for adding this into Solid


dataengines/devicenotifications/ksolidnotify.h (line 63)
<https://git.reviewboard.kde.org/r/125248/#comment59084>

We usually don't add "get" to getters



dataengines/devicenotifications/ksolidnotify.cpp (line 123)
<https://git.reviewboard.kde.org/r/125248/#comment59090>

busyApps



dataengines/devicenotifications/ksolidnotify.cpp (line 126)
<https://git.reviewboard.kde.org/r/125248/#comment59085>

Use initializer list

{"-m", devicePath}

QStringLiteral could be used too I guess



dataengines/devicenotifications/ksolidnotify.cpp (line 127)
<https://git.reviewboard.kde.org/r/125248/#comment59086>

Please don't use waitForFinished as this can easily freeze the entire 
shell. Make it async.



dataengines/devicenotifications/ksolidnotify.cpp (line 129)
<https://git.reviewboard.kde.org/r/125248/#comment59087>

const &



dataengines/devicenotifications/ksolidnotify.cpp (line 131)
<https://git.reviewboard.kde.org/r/125248/#comment59088>

Q_FOREACH (

Also, we usually use camelCase instead of underscodes



dataengines/devicenotifications/ksolidnotify.cpp (line 133)
<https://git.reviewboard.kde.org/r/125248/#comment59089>

if (!pid) {
continue;
}

?



dataengines/devicenotifications/ksolidnotify.cpp (line 157)
<https://git.reviewboard.kde.org/r/125248/#comment59091>

Could use plural handling:

i18np("Could not … are opened in \"%1\".", "Could not … are opened in the 
following: %1")


- Kai Uwe Broulik


On Sept. 16, 2015, 7:23 vorm., Igor Poboiko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125248/
> ---
> 
> (Updated Sept. 16, 2015, 7:23 vorm.)
> 
> 
> Review request for Plasma and Solid.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> An attempt to implement feature from [bug 
> 96107](https://bugs.kde.org/show_bug.cgi?id=96107) (see summary).
> 
> On umount/eject error it runs "lsof" executable, gets PIDs of blocking 
> processes and obtains names of processes via KSysGuard::Process machinery. 
> Finally it appends obtained information to error message which is shown in 
> tooltip of Device Notifier applet.
> 
> 
> Diffs
> -
> 
>   dataengines/devicenotifications/CMakeLists.txt 3f7fd83 
>   dataengines/devicenotifications/ksolidnotify.h a471d50 
>   dataengines/devicenotifications/ksolidnotify.cpp 35d49d6 
> 
> Diff: https://git.reviewboard.kde.org/r/125248/diff/
> 
> 
> Testing
> ---
> 
> Tested unmount on busy device with several processes blocking it. Did not 
> test eject, since I have no optical disc drive :(
> 
> 
> File Attachments
> 
> 
> Applet with error message
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/15/3b1b64fc-abff-4633-9dca-621388edf086__snapshot11.png
> 
> 
> Thanks,
> 
> Igor Poboiko
> 
>

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 125248: Display name of process which blocks umount / eject

[Kai Uwe Broulik]

> On Sept. 16, 2015, 10:11 vorm., Kai Uwe Broulik wrote:
> > I really like that!
> > 
> > The device notifier UI itself is questionable with the popup telling us 
> > "the device xyz failed to unmount" rather than just highlighting the device 
> > and showing the message in the list directly but this is of course outside 
> > the scope of this patch.
> > 
> > +1 for adding this into Solid

Bonus points for querying KService for the pretty application name :) 

See 
https://quickgit.kde.org/?p=plasma-workspace.git=blob=dataengines%2Fpowermanagement%2Fpowermanagementengine.cpp
 starting on lines 648


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125248/#review85488
---


On Sept. 16, 2015, 7:23 vorm., Igor Poboiko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125248/
> ---
> 
> (Updated Sept. 16, 2015, 7:23 vorm.)
> 
> 
> Review request for Plasma and Solid.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> An attempt to implement feature from [bug 
> 96107](https://bugs.kde.org/show_bug.cgi?id=96107) (see summary).
> 
> On umount/eject error it runs "lsof" executable, gets PIDs of blocking 
> processes and obtains names of processes via KSysGuard::Process machinery. 
> Finally it appends obtained information to error message which is shown in 
> tooltip of Device Notifier applet.
> 
> 
> Diffs
> -
> 
>   dataengines/devicenotifications/CMakeLists.txt 3f7fd83 
>   dataengines/devicenotifications/ksolidnotify.h a471d50 
>   dataengines/devicenotifications/ksolidnotify.cpp 35d49d6 
> 
> Diff: https://git.reviewboard.kde.org/r/125248/diff/
> 
> 
> Testing
> ---
> 
> Tested unmount on busy device with several processes blocking it. Did not 
> test eject, since I have no optical disc drive :(
> 
> 
> File Attachments
> 
> 
> Applet with error message
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/15/3b1b64fc-abff-4633-9dca-621388edf086__snapshot11.png
> 
> 
> Thanks,
> 
> Igor Poboiko
> 
>

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

AW: folder icons where should they be set

[Kai Uwe Broulik]

Hi,

Aren't these XDG standard dirs you can even configure? Just show the folder at 
XDG images with a pictures folder icon and so on. 

If you use different folders without telling the system, it's your own fault ;)

Cheers, 
Kai Uwe‎

Re: Review Request 125268: Fix signal-slot connections in KNewFileMenuPrivate::confirmCreatingHiddenDir(QString)

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125268/#review85514
---


if you're at it you might as well use the new connect syntax, so we could spot 
things like these easier in the future.

- Kai Uwe Broulik


On Sept. 16, 2015, 8:22 nachm., Frank Reininghaus wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125268/
> ---
> 
> (Updated Sept. 16, 2015, 8:22 nachm.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 352770
> https://bugs.kde.org/show_bug.cgi?id=352770
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Currently, the buttons in the dialog that is shown when trying to create a 
> hidden directory (e.g., by pressing F10 in Dolphin and then entering a name 
> that starts with a dot) do not work. This is because the slots are connected 
> to the 'accepted' and 'rejected' signals of the QDialog. Actually, these 
> signals are emitted by the QDialogButtonBox.
> 
> 
> Diffs
> -
> 
>   src/filewidgets/knewfilemenu.cpp 2e8f9c6 
> 
> Diff: https://git.reviewboard.kde.org/r/125268/diff/
> 
> 
> Testing
> ---
> 
> Both buttons in the dialog work now: it is possible to create hidden 
> directories, and it is also possible to choose a new name.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124872: Default to Breeze colors

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124872/
---

(Updated Oct. 5, 2015, 2 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Plasma and KDE Usability.


Changes
---

Submitted with commit 0d6cc21a5685846be4af9491e10d47bd7ee12a65 by Kai Uwe 
Broulik to branch master.


Bugs: 351530
https://bugs.kde.org/show_bug.cgi?id=351530


Repository: kconfigwidgets


Description
---

This makes KColorScheme return Breeze colors by default, ie. choosing "Default" 
in Colors KCM is no longer Oxygen.


Diffs
-

  src/kcolorscheme.cpp f1ec1e3 

Diff: https://git.reviewboard.kde.org/r/124872/diff/


Testing
---

Seems to look right, typos reserved :)

Only thing missing now is the window decoration which is set in the WM section 
of kdeglobals by the breeze.colors but KWin defaults to highlight colors, so it 
stays blue.


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [OS X/Wayland] using WIds created by a different process to create KMessageBox'es and other widgets/windows

[Kai Uwe Broulik]

‎> On OS X (and MS Windows?), 

And Wayland, so it affects Linux, too.



___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [Kde-hardware-devel] Review Request 126146: [XRandRBrightness] Don't call for xrandr if it's not available

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126146/#review89281
---


Ping

- Kai Uwe Broulik


On Nov. 23, 2015, 4 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126146/
> ---
> 
> (Updated Nov. 23, 2015, 4 nachm.)
> 
> 
> Review request for Solid and Thomas Lübking.
> 
> 
> Bugs: 352462
> https://bugs.kde.org/show_bug.cgi?id=352462
> 
> 
> Repository: powerdevil
> 
> 
> Description
> ---
> 
> Check whether the extension is there before calling into it.
> 
> Also cache calls to QX11Info::connection() if we're at it.
> 
> 
> Diffs
> -
> 
>   daemon/backends/upower/xrandrbrightness.cpp 0abcefe 
> 
> Diff: https://git.reviewboard.kde.org/r/126146/diff/
> 
> 
> Testing
> ---
> 
> Still works, didn't test without xrandr.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 126146: [XRandRBrightness] Don't call for xrandr if it's not available

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126146/
---

(Updated Dec. 13, 2015, 8:44 p.m.)


Status
--

This change has been marked as submitted.


Review request for Solid and Thomas Lübking.


Changes
---

Submitted with commit dde0ecce02259a26655737e6674950e2e303bc6f by Kai Uwe 
Broulik to branch Plasma/5.5.


Bugs: 352462
https://bugs.kde.org/show_bug.cgi?id=352462


Repository: powerdevil


Description
---

Check whether the extension is there before calling into it.

Also cache calls to QX11Info::connection() if we're at it.


Diffs
-

  daemon/backends/upower/xrandrbrightness.cpp 0abcefe 

Diff: https://git.reviewboard.kde.org/r/126146/diff/


Testing
---

Still works, didn't test without xrandr.


Thanks,

Kai Uwe Broulik

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126320/#review89424
---


+1

Thank you! This fixes Plasma startup for me and I wasted hours /o\
Do we need a respin of KF5 for this? It's pretty serious if Plasma just doesn't 
start for no apparent reason.

- Kai Uwe Broulik


On Dez. 11, 2015, 6:48 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126320/
> ---
> 
> (Updated Dez. 11, 2015, 6:48 nachm.)
> 
> 
> Review request for KDE Frameworks, Plasma and Alex Richardson.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> plasma-scriptengine.desktop defines the property "X-Plasma-ComponentTypes"
> as Type=QStringList. When reading it using KPluginMetaData::value(..) it
> expects a QString back. This used to work but regressed in kcoreaddons in
> commit cfd18cf09b559a050fd6a2680ad4e71eeb950383. Now I'm not sure if calling
> KPluginMetaData::value(..) on a property that is known to be a stringlist
> should actually return a QString (Alex?), but making it read the property
> as a stringlist works and is correct and also fixes Plasma startup for me.
> 
> 
> Diffs
> -
> 
>   src/plasma/scripting/scriptengine.cpp 1b132de 
> 
> Diff: https://git.reviewboard.kde.org/r/126320/diff/
> 
> 
> Testing
> ---
> 
> Plasma would get stuck on startup, now I can run Plasma again.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126381/#review89693
---



backends/kwayland/waylandconfig.cpp (line 58)
<https://git.reviewboard.kde.org/r/126381/#comment61443>

[=] captures the this pointer and this->m_syncLoop is still the same 
syncLoop


- Kai Uwe Broulik


On Dez. 17, 2015, 6:53 nachm., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126381/
> ---
> 
> (Updated Dez. 17, 2015, 6:53 nachm.)
> 
> 
> Review request for Plasma, Solid, Daniel Vrátil, and Martin Gräßlin.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> This adds a kwayland backend to libkscreen.
> 
> This backend uses KWayland's OutputManagement protocol for enlisting and
> configuring devices.
> 
> Enlisting outputs
> 
> KScreen's outputs are created from KWayland::Client::OutputDevice objects,
> they copy the data into kscreen's Outputs, and update these objects. A list
> of outputs is requested from the client Registry object.
> 
> Configuring outputs
> 
> The backend asks the global OutputManagement interface for an 
> OutputConfiguration
> object, then sets the changes per outputdevice on this object, and asks the
> compositor to apply() this configuration.
> 
> For this to work, the compositor should support the Wayland 
> org_kde_kwin_outputdevice
> and org_kde_kwin_outputmanagement protocols, for example through
> KWayland::Server classes OutputDevice, OutputManagmenent and 
> OuputConfiguration.
> 
> General working
> 
> WaylandBackend creates a global static internal config, available through
> WaylandBackend::internalConfig(). WaylandConfig binds to the wl_registry
> callbacks and catches org_kde_kwin_outputdevice creation and destruction.
> It passes org_kde_kwin_outputdevice creation and removal on to
> WB::internalConfig() to handle its internal data representation as 
> WaylandOutput.
> WaylandOutput binds to org_kde_kwin_outputdevice's callback, and gets notified
> of geometry and modes, including changes. WaylandOutput administrates the
> internal representation of these objects, and invokes the global notifier,
> which then runs the pointers it holds through the updateK* methods in
> Wayland{Screen,Output,...}.
> 
> KScreen:{Screen,Output,Edid,Mode} objects are created from the internal
> representation as requested (usually triggered by the creation of a
> KScreen::Config object through KScreen::Config::current()). As with other
> backends, the objects which are handed out to the lib's user are expected
> to be deleted by the user, the backend only takes ownership of its internal
> data representation objects.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt efac5ce 
>   autotests/CMakeLists.txt 07b7bbc 
>   autotests/configs/default.json 3ac3e19 
>   autotests/testconfigserializer.cpp 1af3069 
>   autotests/testkwaylandbackend.cpp PRE-CREATION 
>   autotests/testkwaylandconfig.cpp PRE-CREATION 
>   backends/CMakeLists.txt ff5d751 
>   backends/kwayland/CMakeLists.txt PRE-CREATION 
>   backends/kwayland/README.md PRE-CREATION 
>   backends/kwayland/waylandbackend.h PRE-CREATION 
>   backends/kwayland/waylandbackend.cpp PRE-CREATION 
>   backends/kwayland/waylandconfig.h PRE-CREATION 
>   backends/kwayland/waylandconfig.cpp PRE-CREATION 
>   backends/kwayland/waylandoutput.h PRE-CREATION 
>   backends/kwayland/waylandoutput.cpp PRE-CREATION 
>   backends/kwayland/waylandscreen.h PRE-CREATION 
>   backends/kwayland/waylandscreen.cpp PRE-CREATION 
>   src/backendmanager.cpp 89ae31e 
>   src/config.cpp e8b8a8f 
>   src/screen.h 4cd1e82 
>   tests/CMakeLists.txt d5e41d5 
>   tests/kwayland/CMakeLists.txt PRE-CREATION 
>   tests/kwayland/main.cpp PRE-CREATION 
>   tests/kwayland/waylandconfigreader.h PRE-CREATION 
>   tests/kwayland/waylandconfigreader.cpp PRE-CREATION 
>   tests/kwayland/waylandtestserver.h PRE-CREATION 
>   tests/kwayland/waylandtestserver.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126381/diff/
> 
> 
> Testing
> ---
> 
> The patch contains a test server, which is used for the autotests.
> 
> The test server uses KWayland's server classes and is set up from the json 
> config data we use for the other tests. That means that the backends runs 
> against a real server to test everything.
> 
> I also tested the kscreen UI, which also works as expected.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: Review Request 108442: [High-dpi issues] Fix KIconButton initial icon size and its occurence in KPropertiesDialog

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/108442/
---

(Updated Dez. 15, 2015, 9:52 nachm.)


Status
--

This change has been discarded.


Review request for kdelibs.


Repository: kdelibs


Description
---

The KIconButton and the other occurences assume that the icon size for desktop 
icons is always 48x48. This assumption is wrong.
This patch makes KPropertiesDialog use the proper IconSize.

There are other places that need fixing too (eg. Dolphin's Place edit dialog or 
KMenuEdit) which I will fix later as well.

So, with KDE Frameworks at the horizon and kdelibs frozen, does this mean, when 
I am re-writing the KIconDialog to be more userfriendly, use an UI file, 
introduce new strings, etc this cannot go into master but only frameworks 
branch?


Diffs
-

  kio/kfile/kicondialog.cpp 73a7449 
  kio/kfile/kpropertiesdialog.cpp b4cd8ee 

Diff: https://git.reviewboard.kde.org/r/108442/diff/


Testing
---

Yup, you won't notice any difference with default settings but with higher icon 
size and font scales perfectly and looks good. See screenshot.


File Attachments


KPropertiesDialog with Retina settings
  https://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/iconbutton.png


Thanks,

Kai Uwe Broulik

Re: Review Request 110266: Cleanp Places Panel context menu

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110266/
---

(Updated Dez. 15, 2015, 9:52 nachm.)


Status
--

This change has been discarded.


Review request for kdelibs, KDE Usability, Aaron J. Seigo, and Frank 
Reininghaus.


Repository: kdelibs


Description
---

This is a follow-up review request for Review 109015 which does the same for 
Dolphin.

This patch cleans up the places panel context menu by:
 - Removing the term "Entry" and the entry name in every single item. To still 
have easy context, I added a menu title instead.
 - General actions such as "Show all" and "Add Entry" are removed from item 
context menus (they're not related to the item)

See screenshot for direct comparison of old and new.

You can still add an entry, even if the list is full, by scrolling to the 
bottom of the list where there is always an empty spot to click on. To me it 
sounds logical to add an entry at the end anyway. (Dolphin doesn't directly 
have this problem since you can always click the group titles (Devices, Places, 
Search For, …) which are not considered an item and thus spawn the general 
context menu)

For Frameworks 5 it would of course be great to merge Dolphin's places panel 
duplication back into kdelibs to provide a unified user experience and reduce 
maintenance cost. (Or write a new one based on QML, :P)


Diffs
-

  kfile/kfileplacesmodel.cpp a73274c 
  kfile/kfileplacesview.cpp 117a9ed 

Diff: https://git.reviewboard.kde.org/r/110266/diff/


Testing
---

Tested in the Open File dialog of Kolourpaint. Looks nice, works.


File Attachments


Comparison (left old, right new)
  
https://git.reviewboard.kde.org/media/uploaded/files/2013/05/02/kdelibsplaces.png


Thanks,

Kai Uwe Broulik

Re: Review Request 102149: Improve Calculate/Stop buttons when folder Size is being calculated

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/102149/
---

(Updated Dez. 15, 2015, 9:54 nachm.)


Status
--

This change has been discarded.


Review request for kdelibs.


Repository: kdelibs


Description
---

This patch improves the Calculate and Stop buttons in folder properties.
Instead of having two buttons that are enabled/disabled accordingly, we only 
have one that toggles (technically there are still two buttons but it looks as 
if there was one)

I removed that "Calculating..." label when there is already a size shown, 
instead the stop button says "Stop Calculating" and somehow serves as 
"indicator".
Also, I added a line-break after the "Calculating..." so the label doesn't 
change its size making the other elements moving around.

I don't know if the additional icons (view-refresh and process-cancel) add too 
much clutter to the visual interface since this features is not sooo 
important/frequently used(?) that the buttons need an icon.


Diffs
-

  kio/kfile/kpropertiesdialog.cpp ba56f18 

Diff: https://git.reviewboard.kde.org/r/102149/diff/


Testing
---

Compiles and the buttons toggle (and react) fine.


Screenshots
---

Screenshot of the dialog while it is calculating
  https://git.reviewboard.kde.org/r/102149/s/213/


Thanks,

Kai Uwe Broulik

Re: Review Request 108433: [High-dpi issues] Fix color kcm list when using big fonts

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/108433/
---

(Updated Dez. 15, 2015, 9:50 nachm.)


Status
--

This change has been discarded.


Review request for kde-workspace.


Repository: kde-workspace


Description
---

This makes the row height of color list depend on the height of the "Varies" 
button.

The KColorButtons on the other pages also need fixing but this should be done 
in KColorButton in kdelibs rather than hacking in the "Varies" thing there as 
well.

(Not sure if I need to delete that PushButton afterwards)


Diffs
-

  kcontrol/colors/colorscm.cpp b9b911f 

Diff: https://git.reviewboard.kde.org/r/108433/diff/


Testing
---

Yup, see screenshots.


File Attachments


After with normal fonts
  
https://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/colornormalsize.png
Before with huge fonts
  
https://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/colorbigsizebefore.png
After with huge fonts
  
https://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/colorbigsizeafter.png


Thanks,

Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 106863: Silence "Profile foo could not activate bar which is a non-existent action" message

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/106863/
---

(Updated Dez. 15, 2015, 9:46 nachm.)


Status
--

This change has been discarded.


Review request for Solid.


Repository: kde-workspace


Description
---

That message usually appears when starting before the Desktop is up, causing an 
ugly 1990's passivepopup dialog on the screen, and its contents are not really 
novice-user-resolvable.
On my machine it always claims "The profile Battery tried to activate 
DPMSControl which is a non-existent action.", which is when I compile 
powerdevil myself that DPMS stuff is not compiled (DPMS build requirements not 
met here) and so the action floats around in the config but cannot be triggered 
anyways. (Imho this is a really infamous message, have seen it quite often on 
other machines *duck*). All the other actions seem to be installed anyways, so 
this missing action poses no threat. I guess a kWarning would be sufficient for 
this.


Diffs
-

  powerdevil/daemon/actions/CMakeLists.txt db9ca47 
  powerdevil/daemon/actions/dpms/powerdevildpmsaction.cpp 55689b5 
  powerdevil/daemon/powerdevilactionpool.cpp a9950f1 

Diff: https://git.reviewboard.kde.org/r/106863/diff/


Testing
---

Compiles.
The previous passivepopup does not appear anymore. Did not test whether the 
kwarning is triggered, though. (Dunno how to get powerdevil debug console 
output)


Thanks,

Kai Uwe Broulik

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

[Kai Uwe Broulik]

  Hi,Mark, I think you completely misunderstood what move to kde/workspace means. This is not a repository, nobody wants to move that stuff into plasma-workspace. It just has semantic relevance, ie. no frameworks ABI and compiler restrictions, different release schedule, but it will still be its own repository with a minimal set of dependencies. Cheers,Kai Uwe
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [Kde-hardware-devel] Review Request 126145: Wait 5s before enforcing inhibition

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126145/
---

(Updated Dec. 14, 2015, 9:04 p.m.)


Status
--

This change has been marked as submitted.


Review request for Solid.


Changes
---

Submitted with commit eca79138c15575f6f523a8680919b407f84da2e2 by Kai Uwe 
Broulik to branch master.


Bugs: 352235
https://bugs.kde.org/show_bug.cgi?id=352235


Repository: powerdevil


Description
---

Whenever Chrome plays sound it posts an inhibition. This is great, except that 
it does that also when playing a short sound, such as when receiving a message. 
This patch makes PowerDevil wait 5 seconds before actually enforcing the 
inhibition. In any case I don't want to have the system wake up for any such 
sort inhibitions.

Also cleanup, the add inhibition and add inhibition with explicit dbus service 
methods were virtually identical.


Diffs
-

  daemon/powerdevilpolicyagent.h 256bf4c 
  daemon/powerdevilpolicyagent.cpp ec85189 

Diff: https://git.reviewboard.kde.org/r/126145/diff/


Testing
---

Started a video, stopped it right away. -> No inhibition shown in battery 
monitor
Started a video, waited longer -> Inhibition appeared
stopped video again -> inhibition disappeared right away
Started playback in VLC while Chrome was playing -> got two inhibitions shortly 
thereafter
Closed VLC -> Only Chrome's inhibition left

Asked for someone to send me a message, received it -> No inhibition was 
enforced because the sound was too short


Thanks,

Kai Uwe Broulik

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 126145: Wait 5s before enforcing inhibition

[Kai Uwe Broulik]

> On Dez. 14, 2015, 9:06 nachm., Martin Klapetek wrote:
> > ...why not stable branch?

I fear it might break things, it's also a behavioral change, though I've been 
running it for weeks without a problem.
I can merge it to 5.5 once 5.5.1 is tagged.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126145/#review89497
---


On Dez. 14, 2015, 9:04 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126145/
> ---
> 
> (Updated Dez. 14, 2015, 9:04 nachm.)
> 
> 
> Review request for Solid.
> 
> 
> Bugs: 352235
> https://bugs.kde.org/show_bug.cgi?id=352235
> 
> 
> Repository: powerdevil
> 
> 
> Description
> ---
> 
> Whenever Chrome plays sound it posts an inhibition. This is great, except 
> that it does that also when playing a short sound, such as when receiving a 
> message. This patch makes PowerDevil wait 5 seconds before actually enforcing 
> the inhibition. In any case I don't want to have the system wake up for any 
> such sort inhibitions.
> 
> Also cleanup, the add inhibition and add inhibition with explicit dbus 
> service methods were virtually identical.
> 
> 
> Diffs
> -
> 
>   daemon/powerdevilpolicyagent.h 256bf4c 
>   daemon/powerdevilpolicyagent.cpp ec85189 
> 
> Diff: https://git.reviewboard.kde.org/r/126145/diff/
> 
> 
> Testing
> ---
> 
> Started a video, stopped it right away. -> No inhibition shown in battery 
> monitor
> Started a video, waited longer -> Inhibition appeared
> stopped video again -> inhibition disappeared right away
> Started playback in VLC while Chrome was playing -> got two inhibitions 
> shortly thereafter
> Closed VLC -> Only Chrome's inhibition left
> 
> Asked for someone to send me a message, received it -> No inhibition was 
> enforced because the sound was too short
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: Review Request 126167: Expose QMimeType comment

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126167/
---

(Updated Dec. 14, 2015, 9:13 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Aleix Pol Gonzalez.


Changes
---

Submitted with commit aa412c02657828f68f2ac4a3a303853f255525a5 by Kai Uwe 
Broulik to branch master.


Repository: kdeclarative


Description
---

This allows to show the pretty name ("text file") rather than text/plain


Diffs
-

  src/qmlcontrols/kquickcontrolsaddons/mimedatabase.cpp 73b1d15 

Diff: https://git.reviewboard.kde.org/r/126167/diff/


Testing
---

Works


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126627: Replace screensaver inhibition by direct dbus calls

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126627/#review90590
---


Makes me sad :( +1 nonetheless


app/mainwindow.cpp (line 732)
<https://git.reviewboard.kde.org/r/126627/#comment61928>

Full screen presentation going on / in progress? also perhaps add a hint to 
the translators



app/mainwindow.cpp (line 735)
<https://git.reviewboard.kde.org/r/126627/#comment61930>

Is this check neccessary?



app/mainwindow.cpp (line 747)
<https://git.reviewboard.kde.org/r/126627/#comment61929>

.value();



app/mainwindow.cpp (line 760)
<https://git.reviewboard.kde.org/r/126627/#comment61931>

setArguments({mScreenSaverInhibitionCookie})


- Kai Uwe Broulik


On Jan. 4, 2016, 8:07 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126627/
> ---
> 
> (Updated Jan. 4, 2016, 8:07 nachm.)
> 
> 
> Review request for Gwenview, KDE Base Apps and Kai Uwe Broulik.
> 
> 
> Bugs: 334525
> http://bugs.kde.org/show_bug.cgi?id=334525
> 
> 
> Repository: gwenview
> 
> 
> Description
> ---
> 
> This is a better approach to fix bug 334525 than
> https://git.reviewboard.kde.org/r/125910/ which forces
> a default reason (which is user visible).
> 
> With this new patch Gwenview will set a proper reason
> why is it inhibitting the screensaver ("Full Screen Presentation")
> and will use the DBus directly rather than the obsolete
> KNotificationRestrictions API.
> 
> 
> Diffs
> -
> 
>   app/mainwindow.cpp 7b30c4e 
> 
> Diff: https://git.reviewboard.kde.org/r/126627/diff/
> 
> 
> Testing
> ---
> 
> PowerDevil correctly shows that Gwenview is inhibitting
> the PM because "Full Screen Presentation".
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

Re: Review Request 126595: [KFileMetaData] Allow querying for a file's origin URL

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126595/
---

(Updated Jan. 4, 2016, 1:54 nachm.)


Review request for KDE Frameworks and Vishesh Handa.


Changes
---

* Move new enum value to the end


Repository: kfilemetadata


Description
---

This attribute is set, for example by Chrome and newer versions of wget, and 
indicates the original URL this file was downloaded from.

https://wiki.freedesktop.org/www/CommonExtendedAttributes/


Diffs (updated)
-

  src/properties.h 64ba0be 
  src/propertyinfo.cpp 0b298b6 
  src/usermetadata.h ab58e16 
  src/usermetadata.cpp 51c87f8 

Diff: https://git.reviewboard.kde.org/r/126595/diff/


Testing
---

Works.


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Plugin install question

[Kai Uwe Broulik]

Hi,

Try passing the argument -DKDE_INSTALL_USE_QT_SYS_PATHS=ON to cmake. Something 
's weird on Kubuntu in this regard, took me ages to figure out.

Cheers, 
Kai Uwe




>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 126595: [KFileMetaData] Allow querying for a file's origin URL

[Kai Uwe Broulik]

> On Jan. 2, 2016, 9:59 vorm., David Edmundson wrote:
> > src/properties.h, line 215
> > <https://git.reviewboard.kde.org/r/126595/diff/2/?file=428207#file428207line215>
> >
> > adding an enum value in the middle breaks API

where can I place it? the last entry of course must stay last.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126595/#review90435
---


On Jan. 2, 2016, 1:32 vorm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126595/
> ---
> 
> (Updated Jan. 2, 2016, 1:32 vorm.)
> 
> 
> Review request for KDE Frameworks and Vishesh Handa.
> 
> 
> Repository: kfilemetadata
> 
> 
> Description
> ---
> 
> This attribute is set, for example by Chrome and newer versions of wget, and 
> indicates the original URL this file was downloaded from.
> 
> https://wiki.freedesktop.org/www/CommonExtendedAttributes/
> 
> 
> Diffs
> -
> 
>   src/properties.h 64ba0be 
>   src/propertyinfo.cpp 0b298b6 
>   src/usermetadata.h ab58e16 
>   src/usermetadata.cpp 51c87f8 
> 
> Diff: https://git.reviewboard.kde.org/r/126595/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126149: [Icon widget] Bring back properties dialog

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/#review90298
---


I completely screwed up my Kate desktop files :( Would it help if I set 
NoDisplay or Hidden on the desktop file copy so it's there for the icon widget 
but not shown in the Open With dialogs and so on? Or, if I copied the desktop 
file elsewhere (eg. not into the local share applications)?

Also, I should probably delete the desktop file again if the widget is removed 
:)

- Kai Uwe Broulik


On Dez. 21, 2015, 11:31 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126149/
> ---
> 
> (Updated Dez. 21, 2015, 11:31 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 349177
> https://bugs.kde.org/show_bug.cgi?id=349177
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This brings back the KPropertiesDialog to modify an icon's appearance. This 
> has been requested at multiple occasions. This has been adapted from the 
> Plasma 4 icon code.
> 
> 
> Diffs
> -
> 
>   applets/icon/package/contents/ui/main.qml 9286b94 
>   applets/icon/plugin/icon_p.h dd7963c 
>   applets/icon/plugin/icon_p.cpp e086870 
> 
> Diff: https://git.reviewboard.kde.org/r/126149/diff/
> 
> 
> Testing
> ---
> 
> Dropped a file from my home onto the desktop -> dialog from the actual file, 
> allowing to rename it. The applet reflected the changes.
> 
> Dropped an application from kickoff to the desktop -> dialog from a copy of 
> the desktop file, allowing to change its icon and description. The applet 
> reflected the changes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126595: [KFileMetaData] Allow querying for a file's origin URL

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126595/
---

(Updated Jan. 2, 2016, 1:32 vorm.)


Review request for KDE Frameworks and Vishesh Handa.


Changes
---

Add PropertyInfo stuff


Repository: kfilemetadata


Description
---

This attribute is set, for example by Chrome and newer versions of wget, and 
indicates the original URL this file was downloaded from.

https://wiki.freedesktop.org/www/CommonExtendedAttributes/


Diffs (updated)
-

  src/properties.h 64ba0be 
  src/propertyinfo.cpp 0b298b6 
  src/usermetadata.h ab58e16 
  src/usermetadata.cpp 51c87f8 

Diff: https://git.reviewboard.kde.org/r/126595/diff/


Testing
---

Works.


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126595: [KFileMetaData] Allow querying for a file's origin URL

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126595/
---

Review request for KDE Frameworks and Vishesh Handa.


Repository: kfilemetadata


Description
---

This attribute is set, for example by Chrome and newer versions of wget, and 
indicates the original URL this file was downloaded from.

https://wiki.freedesktop.org/www/CommonExtendedAttributes/


Diffs
-

  src/usermetadata.h ab58e16 
  src/usermetadata.cpp 51c87f8 

Diff: https://git.reviewboard.kde.org/r/126595/diff/


Testing
---

Works.


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

[Kai Uwe Broulik]

001>

We need to handle the case of "activate but then the object goes away", we 
will have a spurious inhibition in that case. PowerDevil tracks when an 
application closes but it obviously cannot detect this case.



src/inhibition.cpp (line 274)
<https://git.reviewboard.kde.org/r/126650/#comment62002>

perhaps an error signal and have the status enum only reflect 
active/inactive


- Kai Uwe Broulik


On Jan. 6, 2016, 7:17 vorm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126650/
> ---
> 
> (Updated Jan. 6, 2016, 7:17 vorm.)
> 
> 
> Review request for KDE Frameworks and Kai Uwe Broulik.
> 
> 
> Repository: kidletime
> 
> 
> Description
> ---
> 
> This is a work-in-progress, but I'm putting it up for a feedback now
> as most people are gone for the day when I wake up :)
> 
> ---
> 
> After some discussion in https://git.reviewboard.kde.org/r/126627/
> and then with Kai Uwe Broulik, I've added a PM/ScreenSaver inhibition
> capabilities to KIdleItem.
> 
> We decided with Kai that we want simple stuff, encapsulated away for
> the client as much as possible. So the Inhibition class has a static
> "constructors" which make the usage as easy as follows:
> 
> KIdleTime::Inhibition::createInhibition(KIdleTime::Inhibition::InhibitScreen, 
> QStringLiteral("Playing Movie"), mainWindow);
> 
> That call would return an Inhibition* object which has methods to set
> the inhibition type and reason and to activate/deactivate the inhibition.
> The static method above would activate() on the Inhibition right away;
> this allows a simple fire-and-forget usage. The Inhibition object can
> be parented to any other object; the inhibition will be deactivated when
> the Inhibition object is destroyed. The user can also keep the pointer
> around and call deactivate() whenever actually needed.
> 
> The inhibition itself first looks for Solid and if present, it uses the
> Solid interface. If not present, it goes for the FDO interfaces.
> 
> It comes with an autotest.
> 
> 
> Diffs
> -
> 
>   autotests/qtest_dbus.h PRE-CREATION 
>   src/CMakeLists.txt 23e5e29 
>   autotests/inhibition_test.cpp PRE-CREATION 
>   autotests/CMakeLists.txt PRE-CREATION 
>   autotests/fakePMServer.h PRE-CREATION 
>   src/inhibition.cpp PRE-CREATION 
>   src/inhibition.h PRE-CREATION 
>   autotests/fakePMServer.cpp PRE-CREATION 
>   CMakeLists.txt ed5dc0c 
> 
> Diff: https://git.reviewboard.kde.org/r/126650/diff/
> 
> 
> Testing
> ---
> 
> Everything works as expected, plus there's an autotest.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126568: [KNotifyConfigWidget] Allow selecting a specific event

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126568/
---

(Updated Dez. 29, 2015, 10:58 nachm.)


Review request for KDE Frameworks, Martin Klapetek and Olivier Goffart.


Changes
---

Add @since


Repository: knotifyconfig


Description
---

This allows to programmatically select an event with a given Event ID (naming 
isn't really consistent here, sometimes it's event ID, sometimes event name).

In notifications we show a configure button that opens up the config dialog for 
that app; with this patch I can highlight the specific app that was just 
opened, so the user can disable/reconfigure exactly that one.


Diffs (updated)
-

  src/knotifyconfigelement.h 6c6ed50 
  src/knotifyconfigelement.cpp e306bd6 
  src/knotifyconfigwidget.h 9c1bbfa 
  src/knotifyconfigwidget.cpp 4653529 
  src/knotifyeventlist.h 9d9804c 
  src/knotifyeventlist.cpp 6046d2d 

Diff: https://git.reviewboard.kde.org/r/126568/diff/


Testing
---

Works


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126516: Add StatusNotifier flag

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126516/
---

(Updated Dez. 29, 2015, 11:09 nachm.)


Status
--

This change has been discarded.


Review request for KDE Frameworks.


Repository: kcrash


Description
---

This adds a StatusNotifier flag that starts DrKonqi with the --passive argument 
introduced in Review 126515


Diffs
-

  src/kcrash.cpp 7d3b8a2 
  src/kcrash.h e2b59f2 

Diff: https://git.reviewboard.kde.org/r/126516/diff/


Testing
---

Works.


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126568: [KNotifyConfigWidget] Allow selecting a specific event

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126568/
---

Review request for KDE Frameworks, Martin Klapetek and Olivier Goffart.


Repository: knotifyconfig


Description
---

This allows to programmatically select an event with a given Event ID (naming 
isn't really consistent here, sometimes it's event ID, sometimes event name).

In notifications we show a configure button that opens up the config dialog for 
that app; with this patch I can highlight the specific app that was just 
opened, so the user can disable/reconfigure exactly that one.


Diffs
-

  src/knotifyconfigelement.h 6c6ed50 
  src/knotifyconfigelement.cpp e306bd6 
  src/knotifyconfigwidget.h 9c1bbfa 
  src/knotifyconfigwidget.cpp 4653529 
  src/knotifyeventlist.h 9d9804c 
  src/knotifyeventlist.cpp 6046d2d 

Diff: https://git.reviewboard.kde.org/r/126568/diff/


Testing
---

Works


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

[Kai Uwe Broulik]

> On Dez. 29, 2015, 11:56 nachm., Ken Vermette wrote:
> > In regards to the message displayed (as mentioned in your G+ post) how 
> > about:
> > 
> > "Sorry for the inconvenience. Please report the error to help improve this 
> > software."

I'm quite indifferent on the wording: 
http://wstaw.org/m/2015/12/30/canadiankonqi.jpg

Btw, perhaps we could give the DrKonqi dialog a slightly cuter look with a sad 
Konqi in there, or so, similar to our about dialog. The current heart monitor 
icon we currently have at the right is a bit dated.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/#review90316
-----------


On Dez. 29, 2015, 9:19 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126515/
> ---
> 
> (Updated Dez. 29, 2015, 9:19 nachm.)
> 
> 
> Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This adds a new "--passive" option to DrKonqi where it will only show a 
> StatusNotifierItem rather than bringing up the crash dialog right away.
> 
> This can be useful for auto-restarting shell services (like plasmashell, 
> krunner, kded) to improve the perceived quality of the product.
> 
> On Windows RT, for example, the guidelines even explicitly say "rather just 
> dump the user on the home screen than telling him something went wrong, so he 
> can just quickly start the app again instead of being annoyed by an error 
> message". On iOS you also just get dropped on the home screen. Windows 
> desktop shows a "Searching for a solution" dialog which was *the* major 
> annoyance when something crashed, rather than the actual crash.
> 
> Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt eaeaad4 
>   drkonqi/main.cpp 7cbaae7 
>   drkonqi/statusnotifier.h PRE-CREATION 
>   drkonqi/statusnotifier.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126515/diff/
> 
> 
> Testing
> ---
> 
> I crashed plasmashell, it restarted so fast that you didn't even have a black 
> screen inbetween, just the panel restarting. Afterwards I got a SNI which 
> opened DrKonqi when tapped.
> 
> The SNI disappears after 1 minute because if you didn't bother to look after 
> it by then, you probably forgot what you did to cause the crash anyway :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

[Kai Uwe Broulik]

> On Dez. 29, 2015, 11:56 nachm., Ken Vermette wrote:
> > In regards to the message displayed (as mentioned in your G+ post) how 
> > about:
> > 
> > "Sorry for the inconvenience. Please report the error to help improve this 
> > software."
> 
> Kai Uwe Broulik wrote:
> I'm quite indifferent on the wording: 
> http://wstaw.org/m/2015/12/30/canadiankonqi.jpg
> 
> Btw, perhaps we could give the DrKonqi dialog a slightly cuter look with 
> a sad Konqi in there, or so, similar to our about dialog. The current heart 
> monitor icon we currently have at the right is a bit dated.

You know, like this: http://wstaw.org/m/2015/12/30/konqikonq.jpg except with a 
less cheerful dragon :)


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/#review90316
---------------


On Dez. 29, 2015, 9:19 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126515/
> ---
> 
> (Updated Dez. 29, 2015, 9:19 nachm.)
> 
> 
> Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This adds a new "--passive" option to DrKonqi where it will only show a 
> StatusNotifierItem rather than bringing up the crash dialog right away.
> 
> This can be useful for auto-restarting shell services (like plasmashell, 
> krunner, kded) to improve the perceived quality of the product.
> 
> On Windows RT, for example, the guidelines even explicitly say "rather just 
> dump the user on the home screen than telling him something went wrong, so he 
> can just quickly start the app again instead of being annoyed by an error 
> message". On iOS you also just get dropped on the home screen. Windows 
> desktop shows a "Searching for a solution" dialog which was *the* major 
> annoyance when something crashed, rather than the actual crash.
> 
> Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt eaeaad4 
>   drkonqi/main.cpp 7cbaae7 
>   drkonqi/statusnotifier.h PRE-CREATION 
>   drkonqi/statusnotifier.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126515/diff/
> 
> 
> Testing
> ---
> 
> I crashed plasmashell, it restarted so fast that you didn't even have a black 
> screen inbetween, just the panel restarting. Afterwards I got a SNI which 
> opened DrKonqi when tapped.
> 
> The SNI disappears after 1 minute because if you didn't bother to look after 
> it by then, you probably forgot what you did to cause the crash anyway :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126459: Add a hint to skip notifications grouping

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126459/#review90310
---



src/knotification.h (line 251)
<https://git.reviewboard.kde.org/r/126459/#comment61799>

This must be 0x10!

0x10 = 0b1 (one bit set)

0x22 = 0b10110 (multiple bits)

You unintentionally set a bunch of other flags with it, you probably didn't 
notice that you set the PersistentFlag as the Plasma delete notification sets 
it anyway. :)


- Kai Uwe Broulik


On Dez. 29, 2015, 8:07 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126459/
> ---
> 
> (Updated Dez. 29, 2015, 8:07 nachm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> Plasma currently groups notifications that have the same
> notification title or if they are on a "blacklist" (like
> media player apps that popup a notification for each song
> change), but sometimes the grouping needs to be skipped.
> This is for example when user removes two widgets from his
> desktop and the "Undo" notification appears, these cannot
> be grouped.
> 
> This is currently handled rather by a hack in the notifications
> server, so introducing this new flag should allow for a clean
> and proper solution.
> 
> 
> Diffs
> -
> 
>   src/knotification.h 3a4acd5 
>   src/notifybypopup.cpp e824d39 
> 
> Diff: https://git.reviewboard.kde.org/r/126459/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/
---

(Updated Dez. 29, 2015, 9:19 nachm.)


Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.


Changes
---

* Add context menu actions to SNI: Report Bug (to make it a bit more explicit 
in addition to just clicking it); Restart Application (in case you missed the 
notification you can still restart the app as long as the SNI is there)
* Add contexts to i18n
* Re-order code to be a bit clearer
* Use custom notification event; the Catastrophe one draws a lot of attention 
to it with its sound


Repository: plasma-workspace


Description
---

This adds a new "--passive" option to DrKonqi where it will only show a 
StatusNotifierItem rather than bringing up the crash dialog right away.

This can be useful for auto-restarting shell services (like plasmashell, 
krunner, kded) to improve the perceived quality of the product.

On Windows RT, for example, the guidelines even explicitly say "rather just 
dump the user on the home screen than telling him something went wrong, so he 
can just quickly start the app again instead of being annoyed by an error 
message". On iOS you also just get dropped on the home screen. Windows desktop 
shows a "Searching for a solution" dialog which was *the* major annoyance when 
something crashed, rather than the actual crash.

Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc


Diffs (updated)
-

  drkonqi/CMakeLists.txt eaeaad4 
  drkonqi/main.cpp 7cbaae7 
  drkonqi/statusnotifier.h PRE-CREATION 
  drkonqi/statusnotifier.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126515/diff/


Testing
---

I crashed plasmashell, it restarted so fast that you didn't even have a black 
screen inbetween, just the panel restarting. Afterwards I got a SNI which 
opened DrKonqi when tapped.

The SNI disappears after 1 minute because if you didn't bother to look after it 
by then, you probably forgot what you did to cause the crash anyway :)


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126459: Add a hint to skip notifications grouping

[Kai Uwe Broulik]

> On Dez. 29, 2015, 9:50 nachm., Kai Uwe Broulik wrote:
> > src/knotification.h, line 251
> > <https://git.reviewboard.kde.org/r/126459/diff/1/?file=425181#file425181line251>
> >
> > This must be 0x10!
> > 
> > 0x10 = 0b1 (one bit set)
> > 
> > 0x22 = 0b10110 (multiple bits)
> > 
> > You unintentionally set a bunch of other flags with it, you probably 
> > didn't notice that you set the PersistentFlag as the Plasma delete 
> > notification sets it anyway. :)

Err, 0x16 = 0b10110
You probably meant 16 in decimal, which is 10 in hex. You get the idea.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126459/#review90310
---


On Dez. 29, 2015, 8:07 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126459/
> ---
> 
> (Updated Dez. 29, 2015, 8:07 nachm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> Plasma currently groups notifications that have the same
> notification title or if they are on a "blacklist" (like
> media player apps that popup a notification for each song
> change), but sometimes the grouping needs to be skipped.
> This is for example when user removes two widgets from his
> desktop and the "Undo" notification appears, these cannot
> be grouped.
> 
> This is currently handled rather by a hack in the notifications
> server, so introducing this new flag should allow for a clean
> and proper solution.
> 
> 
> Diffs
> -
> 
>   src/knotification.h 3a4acd5 
>   src/notifybypopup.cpp e824d39 
> 
> Diff: https://git.reviewboard.kde.org/r/126459/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126568: [KNotifyConfigWidget] Allow selecting a specific event

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126568/
---

(Updated Dec. 30, 2015, 4:58 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Martin Klapetek and Olivier Goffart.


Changes
---

Submitted with commit ab4684e67689fe71e11aafad1af63fc966443b75 by Kai Uwe 
Broulik to branch master.


Repository: knotifyconfig


Description
---

This allows to programmatically select an event with a given Event ID (naming 
isn't really consistent here, sometimes it's event ID, sometimes event name).

In notifications we show a configure button that opens up the config dialog for 
that app; with this patch I can highlight the specific app that was just 
opened, so the user can disable/reconfigure exactly that one.


Diffs
-

  src/knotifyconfigelement.h 6c6ed50 
  src/knotifyconfigelement.cpp e306bd6 
  src/knotifyconfigwidget.h 9c1bbfa 
  src/knotifyconfigwidget.cpp 4653529 
  src/knotifyeventlist.h 9d9804c 
  src/knotifyeventlist.cpp 6046d2d 

Diff: https://git.reviewboard.kde.org/r/126568/diff/


Testing
---

Works


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126681: Duplicate the file descriptor while opening

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126681/#review90814
---


I think we should do a re-spin of KF 5.18?

- Kai Uwe Broulik


On Jan. 8, 2016, 9:41 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126681/
> ---
> 
> (Updated Jan. 8, 2016, 9:41 nachm.)
> 
> 
> Review request for KDE Frameworks and Christoph Cullmann.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> Closing the fd results in kwallet being in a blocked state
> with all requests to it being timed out.
> 
> This fixes the issue.
> 
> Thanks to Christoph Cullmann spotting the issue.
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/main.cpp a48de08 
> 
> Diff: https://git.reviewboard.kde.org/r/126681/diff/
> 
> 
> Testing
> ---
> 
> KWallet no longer times out after login.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126681: Duplicate the file descriptor while opening

[Kai Uwe Broulik]

> On Jan. 9, 2016, 1:28 nachm., Kai Uwe Broulik wrote:
> > I think we should do a re-spin of KF 5.18?
> 
> Luigi Toscano wrote:
> I think it was already done: 
> https://mail.kde.org/pipermail/release-team/2016-January/009263.html

ok, I was just wondering because it wasn't mentioned in the changelog :)


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126681/#review90814
---


On Jan. 8, 2016, 9:41 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126681/
> ---
> 
> (Updated Jan. 8, 2016, 9:41 nachm.)
> 
> 
> Review request for KDE Frameworks and Christoph Cullmann.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> Closing the fd results in kwallet being in a blocked state
> with all requests to it being timed out.
> 
> This fixes the issue.
> 
> Thanks to Christoph Cullmann spotting the issue.
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/main.cpp a48de08 
> 
> Diff: https://git.reviewboard.kde.org/r/126681/diff/
> 
> 
> Testing
> ---
> 
> KWallet no longer times out after login.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125158: add logic to use icons for default xdg user dirs

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125158/#review90416
---


Would be cool if we could have something like this for KIO::iconNameForUrl as 
well

- Kai Uwe Broulik


On Okt. 22, 2015, 7:26 vorm., Harald Sitter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125158/
> ---
> 
> (Updated Okt. 22, 2015, 7:26 vorm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 352498
> https://bugs.kde.org/show_bug.cgi?id=352498
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> this acts as an additional fallback to mimetype iconing and .directory
> overrides. xdg user dirs are relocatable and can change depending on user
> locale as well as user configuration and additionally are used in a range
> of different desktop environments making this a very runtime sort of
> decision.
> 
> BUG: 352498
> 
> 
> Diffs
> -
> 
>   autotests/kfileitemtest.h 615324f2b45fdc90a7841bdd0c8aa7f47cdf57a2 
>   autotests/kfileitemtest.cpp 5f728a411401fe3009924b66970d9ae6f12c60f2 
>   src/core/kfileitem.cpp 966d8626708a8f2672f1777c873f4e27e13023d6 
> 
> Diff: https://git.reviewboard.kde.org/r/125158/diff/
> 
> 
> Testing
> ---
> 
> maked
> autotested
> installed
> dolphin and file open dialogs now show icons
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

[Kai Uwe Broulik]

> On Dez. 30, 2015, 2:52 nachm., Kai Uwe Broulik wrote:
> > kdeui/notifications/knotificationrestrictions.cpp, line 50
> > <https://git.reviewboard.kde.org/r/125910/diff/2/?file=414354#file414354line50>
> >
> > Note that this string can be shown to the user (we do this in Battery 
> > Monitor), so it should be a translatable proper string.
> 
> Martin Klapetek wrote:
> Is there a value for "no reason" that will not print any reason?

No. This would defy the whole point of having to specify a reason. :)

"A human-readable and possibly translated string explaining the reason why 
idleness is inhibited (such as 'Playing a movie')." Unfortunately the spec does 
not say whether/that this field is optional. 

PowerDevil doesn't care about the reason, Battery Monitor won't show a reason 
(just generic "$app currently blocks PM") if none is given, I don't know why 
the fuck Gnome blocks the application if no reason is given.

-1 for specifying a default. I'd rather have Gwenview (which from what I can 
tell is the only app that doesn't set a reason) set one (and the Gnome thing 
fixed...)


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125910/#review90341
---


On Dez. 29, 2015, 8:54 nachm., Johannes Stefan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125910/
> ---
> 
> (Updated Dez. 29, 2015, 8:54 nachm.)
> 
> 
> Review request for kdelibs and Martin Klapetek.
> 
> 
> Bugs: 334525
> http://bugs.kde.org/show_bug.cgi?id=334525
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Setting default reason for going into fullscreen mode
> 
> 
> Diffs
> -
> 
>   kdeui/notifications/knotificationrestrictions.cpp 818edea 
> 
> Diff: https://git.reviewboard.kde.org/r/125910/diff/
> 
> 
> Testing
> ---
> 
> Compiled an tested - DBus Log as expected:
> 
> # begin DBUS-log #
> method call sender=:1.223 -> dest=org.freedesktop.ScreenSaver serial=56 
> path=/ScreenSaver; interface=org.freedesktop.ScreenSaver; member=Inhibit
>string "Gwenview"
>string "no_reason_specified"
> method call sender=:1.6 -> dest=:1.3 serial=588 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=Inhibit
>string "Gwenview"
>uint32 0
>string "no_reason_specified"
>uint32 8
> signal sender=:1.3 -> dest=(null destination) serial=351 
> path=/org/gnome/SessionManager; interface=org.freedesktop.DBus.Properties; 
> member=PropertiesChanged
>string "org.gnome.SessionManager"
>array [
>   dict entry(
>  string "InhibitedActions"
>  variant uint32 8
>   )
>]
>array [
>]
> signal sender=:1.3 -> dest=(null destination) serial=352 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=InhibitorAdded
>object path "/org/gnome/SessionManager/Inhibitor29"
> method return sender=:1.3 -> dest=:1.6 reply_serial=588
>uint32 1169992534
> method call sender=:1.4 -> dest=:1.21 serial=56 
> path=/org/gnome/Mutter/IdleMonitor/Core; 
> interface=org.gnome.Mutter.IdleMonitor; member=RemoveWatch
>uint32 35
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=589 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=AddMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.223'"
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=590 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; 
> member=GetNameOwner
>string ":1.223"
> method return sender=:1.6 -> dest=:1.223 reply_serial=56
>uint32 1169992534
> method call sender=:1.6 -> dest=:1.21 serial=592 
> path=/org/gnome/Mutter/DisplayConfig; 
> interface=org.freedesktop.DBus.Properties; member=Set
>string "org.gnome.Mutter.DisplayConfig"
>string "PowerSaveMode"
>variant   int32 0
> method call sender=:1.21 -> dest=:1.3 serial=1073 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=IsInhibited
>uint32 16
> method call sender=:1.21 -> dest=org.freedesktop.DBus serial=1074 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=RemoveMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.4'"
> method return sender=:1.21 -> dest=:1.4 reply_serial=56
> method return sender=:1.3 -> dest=:1.21 reply_serial=1073
>boolean false
> # end of DBUS-log #
> 
> 
> Thanks,
> 
> Johannes Stefan
> 
>

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/
---

(Updated Jan. 4, 2016, 6:20 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.


Changes
---

Submitted with commit 555ff08dc1efaeb7d1f699856347f5e0e9aff1d0 by Kai Uwe 
Broulik to branch master.


Repository: plasma-workspace


Description
---

This adds a new "--passive" option to DrKonqi where it will only show a 
StatusNotifierItem rather than bringing up the crash dialog right away.

This can be useful for auto-restarting shell services (like plasmashell, 
krunner, kded) to improve the perceived quality of the product.

On Windows RT, for example, the guidelines even explicitly say "rather just 
dump the user on the home screen than telling him something went wrong, so he 
can just quickly start the app again instead of being annoyed by an error 
message". On iOS you also just get dropped on the home screen. Windows desktop 
shows a "Searching for a solution" dialog which was *the* major annoyance when 
something crashed, rather than the actual crash.

Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc


Diffs
-

  drkonqi/CMakeLists.txt eaeaad4 
  drkonqi/main.cpp 7cbaae7 
  drkonqi/statusnotifier.h PRE-CREATION 
  drkonqi/statusnotifier.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126515/diff/


Testing
---

I crashed plasmashell, it restarted so fast that you didn't even have a black 
screen inbetween, just the panel restarting. Afterwards I got a SNI which 
opened DrKonqi when tapped.

The SNI disappears after 1 minute because if you didn't bother to look after it 
by then, you probably forgot what you did to cause the crash anyway :)


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125619: Refactor KNewPasswordDialog class

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125619/#review89853
---


btw I would suggest using a message widget for the error message which looks 
quite out of place otherwise.

- Kai Uwe Broulik


On Nov. 19, 2015, 11:04 vorm., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125619/
> ---
> 
> (Updated Nov. 19, 2015, 11:04 vorm.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Follow-up of the KNewPasswordWidget review.
> By introducing a KNewPasswordWidget in the .ui file, we can:
> 
> - remove the code that has been moved to KNewPasswordWidget
> - enable the KNewPasswordWidget additional features
> 
> The only feature that is currently not available is the ability to remove the 
> strength bar. Do we want to allow developers to show a KNewPasswordDialog 
> without a strenght bar?
> 
> 
> Diffs
> -
> 
>   src/knewpassworddialog.h 1ac7b2151f1e88681a15ce21465449cedb871f1e 
>   src/knewpassworddialog.cpp 9b79524f03937dbd2da04ddca6bccc29825b044b 
>   src/knewpassworddialog.ui 55a1f62cf4ba6d6c87b2c47742ba3bcd531ebfe8 
> 
> Diff: https://git.reviewboard.kde.org/r/125619/diff/
> 
> 
> Testing
> ---
> 
> Trying to insert a password which is too short or too weak or empty, works as 
> expected.
> 
> 
> File Attachments
> 
> 
> knewpassworddialog1.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/13/62bf21f6-1dcf-46c3-8b1d-146500b5f629__knewpassworddialog1.png
> knewpassworddialog2.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/13/b2e2666f-ce19-4df3-b6ba-25c13fc370ae__knewpassworddialog2.png
> knewpassworddialog3.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/13/b9536088-0cc4-470b-a211-6db4ca79aa2f__knewpassworddialog3.png
> knewpassworddialog4.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/13/4f826716-9ed2-4ecb-8cbe-4fb50abf1086__knewpassworddialog4.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126149: [Icon widget] Bring back properties dialog

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/
---

(Updated Dez. 21, 2015, 11:31 nachm.)


Review request for KDE Frameworks and Plasma.


Bugs: 349177
https://bugs.kde.org/show_bug.cgi?id=349177


Repository: plasma-workspace


Description
---

This brings back the KPropertiesDialog to modify an icon's appearance. This has 
been requested at multiple occasions. This has been adapted from the Plasma 4 
icon code.


Diffs
-

  applets/icon/package/contents/ui/main.qml 9286b94 
  applets/icon/plugin/icon_p.h dd7963c 
  applets/icon/plugin/icon_p.cpp e086870 

Diff: https://git.reviewboard.kde.org/r/126149/diff/


Testing
---

Dropped a file from my home onto the desktop -> dialog from the actual file, 
allowing to rename it. The applet reflected the changes.

Dropped an application from kickoff to the desktop -> dialog from a copy of the 
desktop file, allowing to change its icon and description. The applet reflected 
the changes.


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126516: Add StatusNotifier flag

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126516/
---

Review request for KDE Frameworks.


Repository: kcrash


Description
---

This adds a StatusNotifier flag that starts DrKonqi with the --passive argument 
introduced in Review 126515


Diffs
-

  src/kcrash.cpp 7d3b8a2 
  src/kcrash.h e2b59f2 

Diff: https://git.reviewboard.kde.org/r/126516/diff/


Testing
---

Works.


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/
---

Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.


Repository: plasma-workspace


Description
---

This adds a new "--passive" option to DrKonqi where it will only show a 
StatusNotifierItem rather than bringing up the crash dialog right away.

This can be useful for auto-restarting shell services (like plasmashell, 
krunner, kded) to improve the perceived quality of the product.

On Windows RT, for example, the guidelines even explicitly say "rather just 
dump the user on the home screen than telling him something went wrong, so he 
can just quickly start the app again instead of being annoyed by an error 
message". On iOS you also just get dropped on the home screen. Windows desktop 
shows a "Searching for a solution" dialog which was *the* major annoyance when 
something crashed, rather than the actual crash.

Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc


Diffs
-

  drkonqi/statusnotifier.cpp PRE-CREATION 
  drkonqi/statusnotifier.h PRE-CREATION 
  drkonqi/CMakeLists.txt eaeaad4 
  drkonqi/main.cpp 7cbaae7 

Diff: https://git.reviewboard.kde.org/r/126515/diff/


Testing
---

I crashed plasmashell, it restarted so fast that you didn't even have a black 
screen inbetween, just the panel restarting. Afterwards I got a SNI which 
opened DrKonqi when tapped.

The SNI disappears after 1 minute because if you didn't bother to look after it 
by then, you probably forgot what you did to cause the crash anyway :)


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/#review90100
---


Usability: I envisioned this to be used for auto-restarting shell services and 
not to be used by applications.
Another interesting thought could be enabling this by default for all 
applications but for regular applications trigger a desktop notification (with 
report bug / restart app) together with the tray icon.

Mockup: http://wstaw.org/m/2015/12/25/drkonqipassive.png

- Kai Uwe Broulik


On Dez. 25, 2015, 4:24 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126515/
> ---
> 
> (Updated Dez. 25, 2015, 4:24 nachm.)
> 
> 
> Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This adds a new "--passive" option to DrKonqi where it will only show a 
> StatusNotifierItem rather than bringing up the crash dialog right away.
> 
> This can be useful for auto-restarting shell services (like plasmashell, 
> krunner, kded) to improve the perceived quality of the product.
> 
> On Windows RT, for example, the guidelines even explicitly say "rather just 
> dump the user on the home screen than telling him something went wrong, so he 
> can just quickly start the app again instead of being annoyed by an error 
> message". On iOS you also just get dropped on the home screen. Windows 
> desktop shows a "Searching for a solution" dialog which was *the* major 
> annoyance when something crashed, rather than the actual crash.
> 
> Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc
> 
> 
> Diffs
> -
> 
>   drkonqi/statusnotifier.cpp PRE-CREATION 
>   drkonqi/statusnotifier.h PRE-CREATION 
>   drkonqi/CMakeLists.txt eaeaad4 
>   drkonqi/main.cpp 7cbaae7 
> 
> Diff: https://git.reviewboard.kde.org/r/126515/diff/
> 
> 
> Testing
> ---
> 
> I crashed plasmashell, it restarted so fast that you didn't even have a black 
> screen inbetween, just the panel restarting. Afterwards I got a SNI which 
> opened DrKonqi when tapped.
> 
> The SNI disappears after 1 minute because if you didn't bother to look after 
> it by then, you probably forgot what you did to cause the crash anyway :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

[Kai Uwe Broulik]

> On Dez. 25, 2015, 5:31 nachm., David Edmundson wrote:
> > code looks fine.
> > 
> > Though please do the TODOs before merging as historically we have a have a 
> > habbit of them not getting done
> > Also your StatusNotifierItem leaks  - but it proably wants to be the 
> > lifespan of the application anyway.

The sad face icon is used wrongly *everywhere* so I guess we can use it here, 
too.

About the context menu, I thought I could add a couple of shortcuts there but I 
guess just having a "Quit" option (unfortunately you cannot tell 
KStatusNotifierItem *not* to ask before quitting) is sufficient.

I was thinking off adding the app icon as overlay but that probably wouldn't 
work well, at least not with the black KDE logo.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/#review90104
-----------


On Dez. 25, 2015, 4:24 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126515/
> ---
> 
> (Updated Dez. 25, 2015, 4:24 nachm.)
> 
> 
> Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This adds a new "--passive" option to DrKonqi where it will only show a 
> StatusNotifierItem rather than bringing up the crash dialog right away.
> 
> This can be useful for auto-restarting shell services (like plasmashell, 
> krunner, kded) to improve the perceived quality of the product.
> 
> On Windows RT, for example, the guidelines even explicitly say "rather just 
> dump the user on the home screen than telling him something went wrong, so he 
> can just quickly start the app again instead of being annoyed by an error 
> message". On iOS you also just get dropped on the home screen. Windows 
> desktop shows a "Searching for a solution" dialog which was *the* major 
> annoyance when something crashed, rather than the actual crash.
> 
> Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc
> 
> 
> Diffs
> -
> 
>   drkonqi/statusnotifier.cpp PRE-CREATION 
>   drkonqi/statusnotifier.h PRE-CREATION 
>   drkonqi/CMakeLists.txt eaeaad4 
>   drkonqi/main.cpp 7cbaae7 
> 
> Diff: https://git.reviewboard.kde.org/r/126515/diff/
> 
> 
> Testing
> ---
> 
> I crashed plasmashell, it restarted so fast that you didn't even have a black 
> screen inbetween, just the panel restarting. Afterwards I got a SNI which 
> opened DrKonqi when tapped.
> 
> The SNI disappears after 1 minute because if you didn't bother to look after 
> it by then, you probably forgot what you did to cause the crash anyway :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126417: don't rely on char* to QString implicit conversion

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126417/#review89713
---


i'm wondering whether those are still needed

- Kai Uwe Broulik


On Dez. 18, 2015, 2:20 nachm., Patrick Spendrin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126417/
> ---
> 
> (Updated Dez. 18, 2015, 2:20 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> my Qt won't cast char* to QString, so explicitly use QStringLiteral here.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/appletquickitem.cpp 
> 614b793fa724e7be0fb2dd8151374303fcc6ec18 
> 
> Diff: https://git.reviewboard.kde.org/r/126417/diff/
> 
> 
> Testing
> ---
> 
> Windows.
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126381/#review89770
---


Sorry for being picky :)


backends/kwayland/waylandconfig.cpp (line 203)
<https://git.reviewboard.kde.org/r/126381/#comment61527>

The () can be omitted



backends/kwayland/waylandconfig.cpp (line 222)
<https://git.reviewboard.kde.org/r/126381/#comment61528>

Out of curiosity, why do you always check explicitly for nullptr and false?



backends/kwayland/waylandconfig.cpp (lines 250 - 251)
<https://git.reviewboard.kde.org/r/126381/#comment61529>

Btw if you made outputs const you could use a range-for, range-for is only 
evil on Qt containers if not const. :)



backends/kwayland/waylandconfig.cpp (line 259)
<https://git.reviewboard.kde.org/r/126381/#comment61530>

Q_FOREACH should be able to iterate QMap, if not, use iterators:
for (auto it = m_outputMap.constBegin(), end = m_outputMap.constEnd(); it 
!= end; ++it) {



backends/kwayland/waylandconfig.cpp (line 281)
<https://git.reviewboard.kde.org/r/126381/#comment61531>

newConfig



backends/kwayland/waylandconfig.cpp (line 325)
<https://git.reviewboard.kde.org/r/126381/#comment61532>

You could theoretically create one lambda and connect both signals to it, 
since these are identical.



backends/kwayland/waylandoutput.h (line 33)
<https://git.reviewboard.kde.org/r/126381/#comment61536>

You can forward-declare enum classes :)



backends/kwayland/waylandoutput.h (lines 54 - 55)
<https://git.reviewboard.kde.org/r/126381/#comment61537>

Asterisks to variable name, same below



backends/kwayland/waylandoutput.h (line 74)
<https://git.reviewboard.kde.org/r/126381/#comment61534>

nullptr



backends/kwayland/waylandoutput.h (line 82)
<https://git.reviewboard.kde.org/r/126381/#comment61535>

static?



backends/kwayland/waylandoutput.cpp (lines 105 - 106)
<https://git.reviewboard.kde.org/r/126381/#comment61538>

The outputs are destroyed when they get disconnected, so you don't connect 
multiple times, right?



backends/kwayland/waylandoutput.cpp (line 128)
<https://git.reviewboard.kde.org/r/126381/#comment61540>

QLatin1Char('-') ?



backends/kwayland/waylandoutput.cpp (line 158)
<https://git.reviewboard.kde.org/r/126381/#comment61539>

modeList.insert(modeid, mode);



backends/kwayland/waylandoutput.cpp (lines 184 - 185)
<https://git.reviewboard.kde.org/r/126381/#comment61541>

could just use output->name()



backends/kwayland/waylandscreen.cpp (line 30)
<https://git.reviewboard.kde.org/r/126381/#comment61542>

Not neccessary



backends/kwayland/waylandscreen.cpp (line 61)
<https://git.reviewboard.kde.org/r/126381/#comment61543>

:) I'll remind you when I buy my 64K SuperMegaUltraHD monitor



src/screen.h (line 48)
<https://git.reviewboard.kde.org/r/126381/#comment61544>

That sounds wrong



tests/kwayland/waylandconfigreader.h (lines 40 - 44)
<https://git.reviewboard.kde.org/r/126381/#comment61545>

Asterisk and Ampersand to variable name



tests/kwayland/waylandconfigreader.cpp (line 33)
<https://git.reviewboard.kde.org/r/126381/#comment61546>

QVector


- Kai Uwe Broulik


On Dez. 18, 2015, 3:16 nachm., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126381/
> ---
> 
> (Updated Dez. 18, 2015, 3:16 nachm.)
> 
> 
> Review request for Plasma, Solid, Daniel Vrátil, and Martin Gräßlin.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> This adds a kwayland backend to libkscreen.
> 
> This backend uses KWayland's OutputManagement protocol for enlisting and
> configuring devices.
> 
> Enlisting outputs
> 
> KScreen's outputs are created from KWayland::Client::OutputDevice objects,
> they copy the data into kscreen's Outputs, and update these objects. A list
> of outputs is requested from the client Registry object.
> 
> Configuring outputs
> 
> The backend asks the global OutputManagement interface for an 
> OutputConfiguration
> object, then sets the changes per outputdevice on this object, and asks the
> compositor to apply() this configuration.
> 
> For this to work, the compositor should support the Wayland 
> org_kde_kwin_outputdevice
> and org_kde_kwin_outputmanagement protocols, for example through
> KWayland::Server classes OutputDevice, OutputManagmenent and 
> OuputConfiguration.
> 
> General working
> 
> WaylandBackend creates a global static internal config, av

Re: Review Request 126516: Add StatusNotifier flag

[Kai Uwe Broulik]

> On Dez. 27, 2015, 6:18 nachm., David Edmundson wrote:
> > Ship It!

I'll put this on hold until we decided whether we want DrKonqi vs SNI (what 
this review is about) or Desktop Notification vs SNI (my second approach, in 
which case the flag should probably be named diferently (PassiveNotification or 
something like that) as we'll get an SNI either way)


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126516/#review90164
---


On Dez. 25, 2015, 4:24 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126516/
> ---
> 
> (Updated Dez. 25, 2015, 4:24 nachm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcrash
> 
> 
> Description
> ---
> 
> This adds a StatusNotifier flag that starts DrKonqi with the --passive 
> argument introduced in Review 126515
> 
> 
> Diffs
> -
> 
>   src/kcrash.cpp 7d3b8a2 
>   src/kcrash.h e2b59f2 
> 
> Diff: https://git.reviewboard.kde.org/r/126516/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

[Kai Uwe Broulik]

> On Dez. 27, 2015, 6:24 nachm., David Edmundson wrote:
> > drkonqi/main.cpp, line 159
> > <https://git.reviewboard.kde.org/r/126515/diff/2/?file=426276#file426276line159>
> >
> > and -> or surely?
> > 
> > both in code and comments.

The and is correct:

- I never want to show the dialog or a notification when we're passive.
- I want to show the DrKonqi dialog instead of the KPassivePopup fallback in 
case no FDO notification service is available


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/#review90166
-----------


On Dez. 27, 2015, 4:11 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126515/
> ---
> 
> (Updated Dez. 27, 2015, 4:11 nachm.)
> 
> 
> Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This adds a new "--passive" option to DrKonqi where it will only show a 
> StatusNotifierItem rather than bringing up the crash dialog right away.
> 
> This can be useful for auto-restarting shell services (like plasmashell, 
> krunner, kded) to improve the perceived quality of the product.
> 
> On Windows RT, for example, the guidelines even explicitly say "rather just 
> dump the user on the home screen than telling him something went wrong, so he 
> can just quickly start the app again instead of being annoyed by an error 
> message". On iOS you also just get dropped on the home screen. Windows 
> desktop shows a "Searching for a solution" dialog which was *the* major 
> annoyance when something crashed, rather than the actual crash.
> 
> Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt eaeaad4 
>   drkonqi/main.cpp 7cbaae7 
>   drkonqi/statusnotifier.h PRE-CREATION 
>   drkonqi/statusnotifier.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126515/diff/
> 
> 
> Testing
> ---
> 
> I crashed plasmashell, it restarted so fast that you didn't even have a black 
> screen inbetween, just the panel restarting. Afterwards I got a SNI which 
> opened DrKonqi when tapped.
> 
> The SNI disappears after 1 minute because if you didn't bother to look after 
> it by then, you probably forgot what you did to cause the crash anyway :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126516: Add StatusNotifier flag

[Kai Uwe Broulik]

> On Dez. 27, 2015, 6:18 nachm., David Edmundson wrote:
> > Ship It!
> 
> Kai Uwe Broulik wrote:
> I'll put this on hold until we decided whether we want DrKonqi vs SNI 
> (what this review is about) or Desktop Notification vs SNI (my second 
> approach, in which case the flag should probably be named diferently 
> (PassiveNotification or something like that) as we'll get an SNI either way)

So, should I rename it? StatusNotifier doesn't really fit anymore.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126516/#review90164
---


On Dez. 25, 2015, 4:24 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126516/
> ---
> 
> (Updated Dez. 25, 2015, 4:24 nachm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcrash
> 
> 
> Description
> ---
> 
> This adds a StatusNotifier flag that starts DrKonqi with the --passive 
> argument introduced in Review 126515
> 
> 
> Diffs
> -
> 
>   src/kcrash.cpp 7d3b8a2 
>   src/kcrash.h e2b59f2 
> 
> Diff: https://git.reviewboard.kde.org/r/126516/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

[Kai Uwe Broulik]

> On Dez. 27, 2015, 9:21 vorm., Heiko Tietze wrote:
> > Perfect use of the message panel. However, the red close icon does not work 
> > (well) with colored backgrounds.

Do we even need the close button to begin with? It's not like it appearing is 
really under your direct control anyway.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126523/#review90137
---


On Dez. 26, 2015, 10:18 vorm., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126523/
> ---
> 
> (Updated Dez. 26, 2015, 10:18 vorm.)
> 
> 
> Review request for KDE Frameworks, KDE Usability, Kai Uwe Broulik, and 
> Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Currently a KNewPasswordDialog makes use of a KTitleWidget to display 
> messages to the user about the password status (e.g. "password too short", 
> etc.). This looks out of place, and so does the associated icon (see 
> screenshots in RR 125619: https://git.reviewboard.kde.org/r/125619/ )
> 
> This patch replaces the KTitleWidget with a KMessageWidget. I also 
> "downgraded" some of the previous "error" red icons to a 
> `KMessageWidget::Warning` type (the orange one in the screenshots), because 
> those kind of messages may be displayed before the user even started typing 
> something as password.
> 
> 
> Diffs
> -
> 
>   src/knewpassworddialog.cpp 1d7ca33ac010a2a1d0971a152d0bef23f78c414d 
>   src/knewpassworddialog.ui 2b492d2a2984296105959d366a1d5306c80af54f 
> 
> Diff: https://git.reviewboard.kde.org/r/126523/diff/
> 
> 
> Testing
> ---
> 
> The KMessageWidgets behaves exactly like the KTitleWidget before: initially 
> is hidden, then is displayed as soon as the user interacts with the password 
> fields.
> 
> 
> File Attachments
> 
> 
> pwd-dialog-1.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/f4870422-d064-4da9-b216-056fe5bec665__pwd-dialog-1.png
> pwd-dialog-2.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/3d8b6c2c-6717-4608-b61c-18ef9b224706__pwd-dialog-2.png
> pwd-dialog-3.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/3a71ff56-f540-405a-9f3e-868e8d652687__pwd-dialog-3.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

[Kai Uwe Broulik]

> On Dez. 27, 2015, 6:24 nachm., David Edmundson wrote:
> > drkonqi/main.cpp, line 159
> > <https://git.reviewboard.kde.org/r/126515/diff/2/?file=426276#file426276line159>
> >
> > and -> or surely?
> > 
> > both in code and comments.
> 
> Kai Uwe Broulik wrote:
> The and is correct:
> 
> - I never want to show the dialog or a notification when we're passive.
> - I want to show the DrKonqi dialog instead of the KPassivePopup fallback 
> in case no FDO notification service is available
> 
> David Edmundson wrote:
> Ah, I see. 
> We've changed the --passive meaning so that this is no longer opt-in.
> 
> (you did say that in the updated description, but I didn't parse it 
> properly)
> 
> So in matrix form:
> 
> passive|notifications running|action
> ---||---
> Yes | Yes | Show SNI and notification
> Yes | No  | Show SNI and notification
> No  | Yes | Show SNI
> No  | No  | Dialog directly
> 
> ?

The "passive" is still opt in but I shifted the meaning a bit.

Passive now means "don't bother the user" or "don't draw attention", ie. don't 
show a notification or dialog whatsoever, only SNI. Sorry, I only wrote into 
the change summary.

passive | notifications running | action
Yes | Yes.. | Show SNI
Yes | No... | Show SNI
No. | Yes.. | Show SNI and Notification
No. | No... | Show DrKonqi dialog directly


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/#review90166
---


On Dez. 27, 2015, 4:11 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126515/
> ---
> 
> (Updated Dez. 27, 2015, 4:11 nachm.)
> 
> 
> Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This adds a new "--passive" option to DrKonqi where it will only show a 
> StatusNotifierItem rather than bringing up the crash dialog right away.
> 
> This can be useful for auto-restarting shell services (like plasmashell, 
> krunner, kded) to improve the perceived quality of the product.
> 
> On Windows RT, for example, the guidelines even explicitly say "rather just 
> dump the user on the home screen than telling him something went wrong, so he 
> can just quickly start the app again instead of being annoyed by an error 
> message". On iOS you also just get dropped on the home screen. Windows 
> desktop shows a "Searching for a solution" dialog which was *the* major 
> annoyance when something crashed, rather than the actual crash.
> 
> Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt eaeaad4 
>   drkonqi/main.cpp 7cbaae7 
>   drkonqi/statusnotifier.h PRE-CREATION 
>   drkonqi/statusnotifier.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126515/diff/
> 
> 
> Testing
> ---
> 
> I crashed plasmashell, it restarted so fast that you didn't even have a black 
> screen inbetween, just the panel restarting. Afterwards I got a SNI which 
> opened DrKonqi when tapped.
> 
> The SNI disappears after 1 minute because if you didn't bother to look after 
> it by then, you probably forgot what you did to cause the crash anyway :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

[Kai Uwe Broulik]

> On Dez. 25, 2015, 4:37 nachm., Kai Uwe Broulik wrote:
> > Usability: I envisioned this to be used for auto-restarting shell services 
> > and not to be used by applications.
> > Another interesting thought could be enabling this by default for all 
> > applications but for regular applications trigger a desktop notification 
> > (with report bug / restart app) together with the tray icon.
> > 
> > Mockup: http://wstaw.org/m/2015/12/25/drkonqipassive.png
> 
> Heiko Tietze wrote:
> If I understand right the auto-restart notification does not have any 
> restart button (which wouldn't make sense) but just the report bug 
> interaction. When the user is presented with either restart or report in case 
> of regular apps, and the notification disapears when the button is clicked, 
> he or she would likely rather restart than going through the debug dialog 
> (that usually lacks on debug info). Simple solution is to show the SNI with 
> restart option only. And even more simple is to leave the crash handling to 
> the app.

There will be no auto-restart notification, just an SNI. For auto-restarting 
services there's no need to point out to the user something bad just happened, 
not that prominent, at least.

For regular apps I should just show the notification and no SNI? Okay.

Unfortunately we really suck at crash recovery, ie. the "Restart App" button 
will most likely just restart the app with an empty document or something like 
that rather than continuing where we left off (somewhat related to our broken 
session restore I guess). I personally have never used the restart button in 
DrKonqi.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/#review90100
-----------


On Dez. 25, 2015, 4:24 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126515/
> ---
> 
> (Updated Dez. 25, 2015, 4:24 nachm.)
> 
> 
> Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This adds a new "--passive" option to DrKonqi where it will only show a 
> StatusNotifierItem rather than bringing up the crash dialog right away.
> 
> This can be useful for auto-restarting shell services (like plasmashell, 
> krunner, kded) to improve the perceived quality of the product.
> 
> On Windows RT, for example, the guidelines even explicitly say "rather just 
> dump the user on the home screen than telling him something went wrong, so he 
> can just quickly start the app again instead of being annoyed by an error 
> message". On iOS you also just get dropped on the home screen. Windows 
> desktop shows a "Searching for a solution" dialog which was *the* major 
> annoyance when something crashed, rather than the actual crash.
> 
> Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc
> 
> 
> Diffs
> -
> 
>   drkonqi/statusnotifier.cpp PRE-CREATION 
>   drkonqi/statusnotifier.h PRE-CREATION 
>   drkonqi/CMakeLists.txt eaeaad4 
>   drkonqi/main.cpp 7cbaae7 
> 
> Diff: https://git.reviewboard.kde.org/r/126515/diff/
> 
> 
> Testing
> ---
> 
> I crashed plasmashell, it restarted so fast that you didn't even have a black 
> screen inbetween, just the panel restarting. Afterwards I got a SNI which 
> opened DrKonqi when tapped.
> 
> The SNI disappears after 1 minute because if you didn't bother to look after 
> it by then, you probably forgot what you did to cause the crash anyway :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

[Kai Uwe Broulik]

> On Dez. 27, 2015, 6:24 nachm., David Edmundson wrote:
> > drkonqi/main.cpp, line 159
> > <https://git.reviewboard.kde.org/r/126515/diff/2/?file=426276#file426276line159>
> >
> > and -> or surely?
> > 
> > both in code and comments.
> 
> Kai Uwe Broulik wrote:
> The and is correct:
> 
> - I never want to show the dialog or a notification when we're passive.
> - I want to show the DrKonqi dialog instead of the KPassivePopup fallback 
> in case no FDO notification service is available
> 
> David Edmundson wrote:
> Ah, I see. 
> We've changed the --passive meaning so that this is no longer opt-in.
> 
> (you did say that in the updated description, but I didn't parse it 
> properly)
> 
> So in matrix form:
> 
> passive|notifications running|action
> ---||---
> Yes | Yes | Show SNI and notification
> Yes | No  | Show SNI and notification
> No  | Yes | Show SNI
> No  | No  | Dialog directly
> 
> ?
> 
> Kai Uwe Broulik wrote:
> The "passive" is still opt in but I shifted the meaning a bit.
> 
> Passive now means "don't bother the user" or "don't draw attention", ie. 
> don't show a notification or dialog whatsoever, only SNI. Sorry, I only wrote 
> into the change summary.
> 
> passive | notifications running | action
> Yes | Yes.. | Show SNI
> Yes | No... | Show SNI
> No. | Yes.. | Show SNI and Notification
> No. | No... | Show DrKonqi dialog directly
> 
> David Edmundson wrote:
> If we go with this, we can effectively just swap the drop the passive 
> flag addition in frameworks and re-use the AutoRestart flag?
> and assume !AutoRestart == Passive
> 
> It's how you're describing the usage in your blog post.
> 
> (would involve Plasma using the existing autorestart rather than doing 
> it's own thing, but I like the idea of that)

+1 to that


- Kai Uwe


-----------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/#review90166
---


On Dez. 27, 2015, 4:11 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126515/
> ---
> 
> (Updated Dez. 27, 2015, 4:11 nachm.)
> 
> 
> Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This adds a new "--passive" option to DrKonqi where it will only show a 
> StatusNotifierItem rather than bringing up the crash dialog right away.
> 
> This can be useful for auto-restarting shell services (like plasmashell, 
> krunner, kded) to improve the perceived quality of the product.
> 
> On Windows RT, for example, the guidelines even explicitly say "rather just 
> dump the user on the home screen than telling him something went wrong, so he 
> can just quickly start the app again instead of being annoyed by an error 
> message". On iOS you also just get dropped on the home screen. Windows 
> desktop shows a "Searching for a solution" dialog which was *the* major 
> annoyance when something crashed, rather than the actual crash.
> 
> Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt eaeaad4 
>   drkonqi/main.cpp 7cbaae7 
>   drkonqi/statusnotifier.h PRE-CREATION 
>   drkonqi/statusnotifier.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126515/diff/
> 
> 
> Testing
> ---
> 
> I crashed plasmashell, it restarted so fast that you didn't even have a black 
> screen inbetween, just the panel restarting. Afterwards I got a SNI which 
> opened DrKonqi when tapped.
> 
> The SNI disappears after 1 minute because if you didn't bother to look after 
> it by then, you probably forgot what you did to cause the crash anyway :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/
---

(Updated Dez. 27, 2015, 4:11 nachm.)


Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.


Changes
---

Variant 2: Use a desktop notification for "regular" crashes.

When the passive argument is not set (the default), a desktop notification will 
be spawned instead of the full-blown DrKonqi dialog [1]. In the notification a 
user can either choose to restart the app (after which the SNI stays in systray 
for the remaining minute in case he wants to report a bug nonetheless) or 
report a bug straight away (same as clicking the SNI, the SNI goes away and 
DrKonqi appears).

In case no notification service is running (eg. plasma crashed or non 
xdg-compliant desktop environment) regular DrKonqi appears directly. This also 
happens when Plasma crashes three times in a row where it'll refrain from 
restarting (see Review 126517) - you won't have a systray anymore then, so full 
DrKonqi pops up as well.

(There's an unused include and member variable in statusnotifier.h, I removed 
it locally)

[1] http://wstaw.org/m/2015/12/25/drkonqipassive.png


Repository: plasma-workspace


Description
---

This adds a new "--passive" option to DrKonqi where it will only show a 
StatusNotifierItem rather than bringing up the crash dialog right away.

This can be useful for auto-restarting shell services (like plasmashell, 
krunner, kded) to improve the perceived quality of the product.

On Windows RT, for example, the guidelines even explicitly say "rather just 
dump the user on the home screen than telling him something went wrong, so he 
can just quickly start the app again instead of being annoyed by an error 
message". On iOS you also just get dropped on the home screen. Windows desktop 
shows a "Searching for a solution" dialog which was *the* major annoyance when 
something crashed, rather than the actual crash.

Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc


Diffs (updated)
-

  drkonqi/CMakeLists.txt eaeaad4 
  drkonqi/main.cpp 7cbaae7 
  drkonqi/statusnotifier.h PRE-CREATION 
  drkonqi/statusnotifier.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126515/diff/


Testing
---

I crashed plasmashell, it restarted so fast that you didn't even have a black 
screen inbetween, just the panel restarting. Afterwards I got a SNI which 
opened DrKonqi when tapped.

The SNI disappears after 1 minute because if you didn't bother to look after it 
by then, you probably forgot what you did to cause the crash anyway :)


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

[Kai Uwe Broulik]

> On Dez. 27, 2015, 6:24 nachm., David Edmundson wrote:
> > drkonqi/main.cpp, line 159
> > <https://git.reviewboard.kde.org/r/126515/diff/2/?file=426276#file426276line159>
> >
> > and -> or surely?
> > 
> > both in code and comments.
> 
> Kai Uwe Broulik wrote:
> The and is correct:
> 
> - I never want to show the dialog or a notification when we're passive.
> - I want to show the DrKonqi dialog instead of the KPassivePopup fallback 
> in case no FDO notification service is available
> 
> David Edmundson wrote:
> Ah, I see. 
> We've changed the --passive meaning so that this is no longer opt-in.
> 
> (you did say that in the updated description, but I didn't parse it 
> properly)
> 
> So in matrix form:
> 
> passive|notifications running|action
> ---||---
> Yes | Yes | Show SNI and notification
> Yes | No  | Show SNI and notification
> No  | Yes | Show SNI
> No  | No  | Dialog directly
> 
> ?
> 
> Kai Uwe Broulik wrote:
> The "passive" is still opt in but I shifted the meaning a bit.
> 
> Passive now means "don't bother the user" or "don't draw attention", ie. 
> don't show a notification or dialog whatsoever, only SNI. Sorry, I only wrote 
> into the change summary.
> 
> passive | notifications running | action
> Yes | Yes.. | Show SNI
> Yes | No... | Show SNI
> No. | Yes.. | Show SNI and Notification
> No. | No... | Show DrKonqi dialog directly
> 
> David Edmundson wrote:
> If we go with this, we can effectively just swap the drop the passive 
> flag addition in frameworks and re-use the AutoRestart flag?
> and assume !AutoRestart == Passive
>     
> It's how you're describing the usage in your blog post.
> 
> (would involve Plasma using the existing autorestart rather than doing 
> it's own thing, but I like the idea of that)
> 
> Kai Uwe Broulik wrote:
> +1 to that
> 
> Marco Martin wrote:
> hmm, shouldn't be passive when autorestart is enabled AutoRestart == 
> Passive? when nothing is coming back you want the dialog, when the 
> application/shell comes back is when you can ignore it no?

Yes, AutoRestart == Passive
One thing I found is KCrash doesn't bother bringing up DrKonqi on the last 
restart attempt so you end up with a black screen, if we use KCrash's auto 
restart functionality.


- Kai Uwe


---------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/#review90166
---


On Dez. 27, 2015, 4:11 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126515/
> ---
> 
> (Updated Dez. 27, 2015, 4:11 nachm.)
> 
> 
> Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This adds a new "--passive" option to DrKonqi where it will only show a 
> StatusNotifierItem rather than bringing up the crash dialog right away.
> 
> This can be useful for auto-restarting shell services (like plasmashell, 
> krunner, kded) to improve the perceived quality of the product.
> 
> On Windows RT, for example, the guidelines even explicitly say "rather just 
> dump the user on the home screen than telling him something went wrong, so he 
> can just quickly start the app again instead of being annoyed by an error 
> message". On iOS you also just get dropped on the home screen. Windows 
> desktop shows a "Searching for a solution" dialog which was *the* major 
> annoyance when something crashed, rather than the actual crash.
> 
> Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt eaeaad4 
>   drkonqi/main.cpp 7cbaae7 
>   drkonqi/statusnotifier.h PRE-CREATION 
>   drkonqi/statusnotifier.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126515/diff/
> 
> 
> Testing
> ---
> 
> I crashed plasmashell, it restarted so fast that you didn't even have a black 
> screen inbetween, just the panel restarting. Afterwards I got a SNI which 
> opened DrKonqi when tapped.
> 
> The SNI disappears after 1 minute because if you didn't bother to look after 
> it by then, you probably forgot what you did to cause the crash anyway :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/
---

(Updated Dez. 28, 2015, 11:14 nachm.)


Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.


Changes
---

* Drop dedicated "passive" option and instead use the "restarted" parameter 
passed in by KCrash
* Use KIdleTime to ensure the user doesn't miss the SNI if the app crashed 
while he was away: think of an hour-long video encoding process, you will have 
no idea why it's not there anymore when it crashed over night, suggested on my 
blog

Works fine for applications but Plasma crashes aren't as good anymore with 
KCrash auto restart. When Plasma crashes a second time I don't get a SNI 
anymore, sometimes it doesn't even restart. Looks like KCrash doing strange 
things or giving up prematurely.


Repository: plasma-workspace


Description
---

This adds a new "--passive" option to DrKonqi where it will only show a 
StatusNotifierItem rather than bringing up the crash dialog right away.

This can be useful for auto-restarting shell services (like plasmashell, 
krunner, kded) to improve the perceived quality of the product.

On Windows RT, for example, the guidelines even explicitly say "rather just 
dump the user on the home screen than telling him something went wrong, so he 
can just quickly start the app again instead of being annoyed by an error 
message". On iOS you also just get dropped on the home screen. Windows desktop 
shows a "Searching for a solution" dialog which was *the* major annoyance when 
something crashed, rather than the actual crash.

Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc


Diffs (updated)
-

  drkonqi/CMakeLists.txt eaeaad4 
  drkonqi/main.cpp 7cbaae7 
  drkonqi/statusnotifier.h PRE-CREATION 
  drkonqi/statusnotifier.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126515/diff/


Testing
---

I crashed plasmashell, it restarted so fast that you didn't even have a black 
screen inbetween, just the panel restarting. Afterwards I got a SNI which 
opened DrKonqi when tapped.

The SNI disappears after 1 minute because if you didn't bother to look after it 
by then, you probably forgot what you did to cause the crash anyway :)


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/
---

(Updated Dez. 28, 2015, 11:34 nachm.)


Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.


Changes
---

* Fix KIdleTime resumingFromIdle

I also removed the default "Quit" option and replaced it with a custom "Hide" 
option, or else you get a "Do you really want to quit drkonqi?" message


Repository: plasma-workspace


Description
---

This adds a new "--passive" option to DrKonqi where it will only show a 
StatusNotifierItem rather than bringing up the crash dialog right away.

This can be useful for auto-restarting shell services (like plasmashell, 
krunner, kded) to improve the perceived quality of the product.

On Windows RT, for example, the guidelines even explicitly say "rather just 
dump the user on the home screen than telling him something went wrong, so he 
can just quickly start the app again instead of being annoyed by an error 
message". On iOS you also just get dropped on the home screen. Windows desktop 
shows a "Searching for a solution" dialog which was *the* major annoyance when 
something crashed, rather than the actual crash.

Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc


Diffs (updated)
-

  drkonqi/CMakeLists.txt eaeaad4 
  drkonqi/main.cpp 7cbaae7 
  drkonqi/statusnotifier.h PRE-CREATION 
  drkonqi/statusnotifier.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126515/diff/


Testing
---

I crashed plasmashell, it restarted so fast that you didn't even have a black 
screen inbetween, just the panel restarting. Afterwards I got a SNI which 
opened DrKonqi when tapped.

The SNI disappears after 1 minute because if you didn't bother to look after it 
by then, you probably forgot what you did to cause the crash anyway :)


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

[Kai Uwe Broulik]

> On Dez. 20, 2015, 10:38 vorm., Daniel Vrátil wrote:
> > tests/kwayland/waylandconfigreader.cpp, line 110
> > 
> >
> > No need for .toList(), Q_FOREACH can iterate over values of a map.
> 
> Sebastian Kügler wrote:
> Nope: 
> 
> /home/sebas/kf5/qt5/qtbase/src/corelib/global/qglobal.h: In instantiation 
> of ‘class QForeachContainer’:
> 
> /home/sebas/kf5/src/libkscreen/tests/kwayland/waylandconfigreader.cpp:110:5:  
>  required from here
> /home/sebas/kf5/qt5/qtbase/src/corelib/global/qglobal.h:893:32: error: no 
> type named ‘const_iterator’ in ‘const class QVariant’
> 
> (Qt 5.5.1)

Because we're not iterating over the QVariantMap but the value of "modes" and 
this returns a QVariant with a QList inside. In this case it's fine.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126381/#review89764
---


On Dez. 21, 2015, 12:59 nachm., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126381/
> ---
> 
> (Updated Dez. 21, 2015, 12:59 nachm.)
> 
> 
> Review request for Plasma, Solid, Daniel Vrátil, and Martin Gräßlin.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> This adds a kwayland backend to libkscreen.
> 
> This backend uses KWayland's OutputManagement protocol for enlisting and
> configuring devices.
> 
> Enlisting outputs
> 
> KScreen's outputs are created from KWayland::Client::OutputDevice objects,
> they copy the data into kscreen's Outputs, and update these objects. A list
> of outputs is requested from the client Registry object.
> 
> Configuring outputs
> 
> The backend asks the global OutputManagement interface for an 
> OutputConfiguration
> object, then sets the changes per outputdevice on this object, and asks the
> compositor to apply() this configuration.
> 
> For this to work, the compositor should support the Wayland 
> org_kde_kwin_outputdevice
> and org_kde_kwin_outputmanagement protocols, for example through
> KWayland::Server classes OutputDevice, OutputManagmenent and 
> OuputConfiguration.
> 
> General working
> 
> WaylandBackend creates a global static internal config, available through
> WaylandBackend::internalConfig(). WaylandConfig binds to the wl_registry
> callbacks and catches org_kde_kwin_outputdevice creation and destruction.
> It passes org_kde_kwin_outputdevice creation and removal on to
> WB::internalConfig() to handle its internal data representation as 
> WaylandOutput.
> WaylandOutput binds to org_kde_kwin_outputdevice's callback, and gets notified
> of geometry and modes, including changes. WaylandOutput administrates the
> internal representation of these objects, and invokes the global notifier,
> which then runs the pointers it holds through the updateK* methods in
> Wayland{Screen,Output,...}.
> 
> KScreen:{Screen,Output,Edid,Mode} objects are created from the internal
> representation as requested (usually triggered by the creation of a
> KScreen::Config object through KScreen::Config::current()). As with other
> backends, the objects which are handed out to the lib's user are expected
> to be deleted by the user, the backend only takes ownership of its internal
> data representation objects.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt efac5ce 
>   autotests/CMakeLists.txt 07b7bbc 
>   autotests/configs/default.json 3ac3e19 
>   autotests/testconfigserializer.cpp 1af3069 
>   autotests/testkwaylandbackend.cpp PRE-CREATION 
>   autotests/testkwaylandconfig.cpp PRE-CREATION 
>   backends/CMakeLists.txt ff5d751 
>   backends/kwayland/CMakeLists.txt PRE-CREATION 
>   backends/kwayland/README.md PRE-CREATION 
>   backends/kwayland/waylandbackend.h PRE-CREATION 
>   backends/kwayland/waylandbackend.cpp PRE-CREATION 
>   backends/kwayland/waylandconfig.h PRE-CREATION 
>   backends/kwayland/waylandconfig.cpp PRE-CREATION 
>   backends/kwayland/waylandoutput.h PRE-CREATION 
>   backends/kwayland/waylandoutput.cpp PRE-CREATION 
>   backends/kwayland/waylandscreen.h PRE-CREATION 
>   backends/kwayland/waylandscreen.cpp PRE-CREATION 
>   src/backendmanager.cpp 89ae31e 
>   src/config.cpp e8b8a8f 
>   src/screen.h 4cd1e82 
>   tests/CMakeLists.txt d5e41d5 
>   tests/kwayland/CMakeLists.txt PRE-CREATION 
>   tests/kwayland/main.cpp PRE-CREATION 
>   tests/kwayland/waylandconfigreader.h PRE-CREATION 
>   tests/kwayland/waylandconfigreader.cpp PRE-CREATION 
>   tests/kwayland/waylandtestserver.h PRE-CREATION 
>   tests/kwayland/waylandtestserver.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126381/diff/
> 
> 
> Testing
> ---
> 
> The patch contains a test server, 

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126381/#review89768
---



autotests/testconfigserializer.cpp (line 161)
<https://git.reviewboard.kde.org/r/126381/#comment61512>

Why this change?


- Kai Uwe Broulik


On Dez. 18, 2015, 3:16 nachm., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126381/
> ---
> 
> (Updated Dez. 18, 2015, 3:16 nachm.)
> 
> 
> Review request for Plasma, Solid, Daniel Vrátil, and Martin Gräßlin.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> This adds a kwayland backend to libkscreen.
> 
> This backend uses KWayland's OutputManagement protocol for enlisting and
> configuring devices.
> 
> Enlisting outputs
> 
> KScreen's outputs are created from KWayland::Client::OutputDevice objects,
> they copy the data into kscreen's Outputs, and update these objects. A list
> of outputs is requested from the client Registry object.
> 
> Configuring outputs
> 
> The backend asks the global OutputManagement interface for an 
> OutputConfiguration
> object, then sets the changes per outputdevice on this object, and asks the
> compositor to apply() this configuration.
> 
> For this to work, the compositor should support the Wayland 
> org_kde_kwin_outputdevice
> and org_kde_kwin_outputmanagement protocols, for example through
> KWayland::Server classes OutputDevice, OutputManagmenent and 
> OuputConfiguration.
> 
> General working
> 
> WaylandBackend creates a global static internal config, available through
> WaylandBackend::internalConfig(). WaylandConfig binds to the wl_registry
> callbacks and catches org_kde_kwin_outputdevice creation and destruction.
> It passes org_kde_kwin_outputdevice creation and removal on to
> WB::internalConfig() to handle its internal data representation as 
> WaylandOutput.
> WaylandOutput binds to org_kde_kwin_outputdevice's callback, and gets notified
> of geometry and modes, including changes. WaylandOutput administrates the
> internal representation of these objects, and invokes the global notifier,
> which then runs the pointers it holds through the updateK* methods in
> Wayland{Screen,Output,...}.
> 
> KScreen:{Screen,Output,Edid,Mode} objects are created from the internal
> representation as requested (usually triggered by the creation of a
> KScreen::Config object through KScreen::Config::current()). As with other
> backends, the objects which are handed out to the lib's user are expected
> to be deleted by the user, the backend only takes ownership of its internal
> data representation objects.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt efac5ce 
>   autotests/CMakeLists.txt 07b7bbc 
>   autotests/configs/default.json 3ac3e19 
>   autotests/testconfigserializer.cpp 1af3069 
>   autotests/testkwaylandbackend.cpp PRE-CREATION 
>   autotests/testkwaylandconfig.cpp PRE-CREATION 
>   backends/CMakeLists.txt ff5d751 
>   backends/kwayland/CMakeLists.txt PRE-CREATION 
>   backends/kwayland/README.md PRE-CREATION 
>   backends/kwayland/waylandbackend.h PRE-CREATION 
>   backends/kwayland/waylandbackend.cpp PRE-CREATION 
>   backends/kwayland/waylandconfig.h PRE-CREATION 
>   backends/kwayland/waylandconfig.cpp PRE-CREATION 
>   backends/kwayland/waylandoutput.h PRE-CREATION 
>   backends/kwayland/waylandoutput.cpp PRE-CREATION 
>   backends/kwayland/waylandscreen.h PRE-CREATION 
>   backends/kwayland/waylandscreen.cpp PRE-CREATION 
>   src/backendmanager.cpp 89ae31e 
>   src/config.cpp e8b8a8f 
>   src/screen.h 4cd1e82 
>   tests/CMakeLists.txt d5e41d5 
>   tests/kwayland/CMakeLists.txt PRE-CREATION 
>   tests/kwayland/main.cpp PRE-CREATION 
>   tests/kwayland/waylandconfigreader.h PRE-CREATION 
>   tests/kwayland/waylandconfigreader.cpp PRE-CREATION 
>   tests/kwayland/waylandtestserver.h PRE-CREATION 
>   tests/kwayland/waylandtestserver.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126381/diff/
> 
> 
> Testing
> ---
> 
> The patch contains a test server, which is used for the autotests.
> 
> The test server uses KWayland's server classes and is set up from the json 
> config data we use for the other tests. That means that the backends runs 
> against a real server to test everything.
> 
> I also tested the kscreen UI, which also works as expected.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126381/#review89769
---



backends/kwayland/waylandbackend.h (line 54)
<https://git.reviewboard.kde.org/r/126381/#comment61513>

const KScreen::ConfigPtr 



backends/kwayland/waylandbackend.cpp (lines 51 - 53)
<https://git.reviewboard.kde.org/r/126381/#comment61514>

= default



backends/kwayland/waylandbackend.cpp (line 57)
<https://git.reviewboard.kde.org/r/126381/#comment61515>

Why is this QStringLiteral whereas the other is QLatin1Literal?



backends/kwayland/waylandbackend.cpp (line 79)
<https://git.reviewboard.kde.org/r/126381/#comment61516>

const KScreen::ConfigPtr 



backends/kwayland/waylandconfig.h (line 68)
<https://git.reviewboard.kde.org/r/126381/#comment61517>

nullptr



backends/kwayland/waylandconfig.cpp (line 57)
<https://git.reviewboard.kde.org/r/126381/#comment61518>

QTimer::singleShot(1000, this, [this] { ... })



backends/kwayland/waylandconfig.cpp (line 79)
<https://git.reviewboard.kde.org/r/126381/#comment61519>

Remove



backends/kwayland/waylandconfig.cpp (line 87)
<https://git.reviewboard.kde.org/r/126381/#comment61520>

connect(m_connection, ..., this, [this] { ... });



backends/kwayland/waylandconfig.cpp (lines 115 - 117)
<https://git.reviewboard.kde.org/r/126381/#comment61521>

qDeleteAll (I think this requires Qt 5.6 to work though)



backends/kwayland/waylandconfig.cpp (line 177)
<https://git.reviewboard.kde.org/r/126381/#comment61522>

postfix



backends/kwayland/waylandconfig.cpp (line 180)
<https://git.reviewboard.kde.org/r/126381/#comment61523>

if (m_outputMap.contains(new_id))

The contains method in QMap/QHash looks for a key, no need to create a 
temporary list



backends/kwayland/waylandconfig.cpp (line 188)
<https://git.reviewboard.kde.org/r/126381/#comment61524>

waylandOutput



backends/kwayland/waylandconfig.cpp (lines 234 - 235)
<https://git.reviewboard.kde.org/r/126381/#comment61525>

m_outputMap.take(kscreen_id)



backends/kwayland/waylandconfig.cpp (line 252)
<https://git.reviewboard.kde.org/r/126381/#comment61526>

if (!m_outputMap.contains(output->id())


- Kai Uwe Broulik


On Dez. 18, 2015, 3:16 nachm., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126381/
> ---
> 
> (Updated Dez. 18, 2015, 3:16 nachm.)
> 
> 
> Review request for Plasma, Solid, Daniel Vrátil, and Martin Gräßlin.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> This adds a kwayland backend to libkscreen.
> 
> This backend uses KWayland's OutputManagement protocol for enlisting and
> configuring devices.
> 
> Enlisting outputs
> 
> KScreen's outputs are created from KWayland::Client::OutputDevice objects,
> they copy the data into kscreen's Outputs, and update these objects. A list
> of outputs is requested from the client Registry object.
> 
> Configuring outputs
> 
> The backend asks the global OutputManagement interface for an 
> OutputConfiguration
> object, then sets the changes per outputdevice on this object, and asks the
> compositor to apply() this configuration.
> 
> For this to work, the compositor should support the Wayland 
> org_kde_kwin_outputdevice
> and org_kde_kwin_outputmanagement protocols, for example through
> KWayland::Server classes OutputDevice, OutputManagmenent and 
> OuputConfiguration.
> 
> General working
> 
> WaylandBackend creates a global static internal config, available through
> WaylandBackend::internalConfig(). WaylandConfig binds to the wl_registry
> callbacks and catches org_kde_kwin_outputdevice creation and destruction.
> It passes org_kde_kwin_outputdevice creation and removal on to
> WB::internalConfig() to handle its internal data representation as 
> WaylandOutput.
> WaylandOutput binds to org_kde_kwin_outputdevice's callback, and gets notified
> of geometry and modes, including changes. WaylandOutput administrates the
> internal representation of these objects, and invokes the global notifier,
> which then runs the pointers it holds through the updateK* methods in
> Wayland{Screen,Output,...}.
> 
> KScreen:{Screen,Output,Edid,Mode} objects are created from the internal
> representation as requested (usually triggered by the creation of a
> KScreen::Config object through KScreen::Config::current()). As with other
> backends, the objects which are handed out to the lib's user are