Re: Review Request 128968: Convert checkxml5 into a qt executable for cross plattform support.

[Luigi Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128968/#review99396
---


Ship it!




Inviala!

- Luigi Toscano


On Set. 21, 2016, 11:35 a.m., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128968/
> ---
> 
> (Updated Set. 21, 2016, 11:35 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Convert checkxml5 into a qt executable for cross plattform support.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 8674faaba6346156907aa5fbbea1ee2b38865eda 
>   checkXML5.in.cmake d7a57c78ec768a4eb9d3c669b8fe3bbef2991c93 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
>   src/checkXML5.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128968/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 128968: Convert checkxml5 into a qt executable for cross plattform support.

[Luigi Toscano]

> On Set. 21, 2016, 12:38 p.m., Luigi Toscano wrote:
> > Would it make more sense to change meinproc5 to work like checkXML5 if 
> > invoked with that name (hardlink, copy, etc, a-la busybox)?
> 
> Ralf Habacker wrote:
> Sorry, I do not know the reasons why this tool has been created and has 
> not been integrated into meinproc5. You should ask the original author.
> 
> Luigi Toscano wrote:
> The original author (Laurent Montel, 
> https://websvn.kde.org/?view=revision=505145) don't remember much, 
> and I guess it's not relevant here. My question was: from a multiplatform 
> prospective, would this solution have any drawback? Where "this solution" is: 
> have a checkXML5(.exe) executable which is an hardlink (or a copy, I guess, 
> on Windows) to meinproc5, but exposing the behavior of the wrapper script?
> 
> Ralf Habacker wrote:
> Pro's:
> - no additional source/cmake target/binary to maintain 
> 
> Neg's:
> - increase the complexibility of meinproc5 caused by the need to support 
> of additional 'checkXML5' use case
> - more efforts required to maintain the related man pages caused by the 
> dualism  e.g. 'Do I need to update "meinproc5" or "checkXML5" man page 
> - duplicated executable on windows caused by pysical copy (hardlinks are 
> not supported by cmake as far as I know)
> 
> Seeing this I would stay with the checkXML5 executable introduced with 
> this request.

I see; then fine by me. Even if I maybe mark checkXML as deprecated at some 
point to not forget to remove it for Frameworks 6. But this is the far future 
of >=4 years from now anyway :)


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128968/#review99350
---


On Set. 21, 2016, 11:35 a.m., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128968/
> ---
> 
> (Updated Set. 21, 2016, 11:35 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Convert checkxml5 into a qt executable for cross plattform support.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 8674faaba6346156907aa5fbbea1ee2b38865eda 
>   checkXML5.in.cmake d7a57c78ec768a4eb9d3c669b8fe3bbef2991c93 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
>   src/checkXML5.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128968/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

[plasma-desktop] doc/kcontrol/emoticons: Proofread/update emoticons kcm docbook

[Burkhard Lück]

Git commit 40a1af32e109902a7fe07fdbd59b38ed2105ee27 by Burkhard Lück.
Committed on 21/09/2016 at 19:03.
Pushed by lueck into branch 'master'.

Proofread/update emoticons kcm docbook

proofread
fix kde4 path
kde-look.org -> store.kde.org
update screenshot
REVIEW:128977

M  +---doc/kcontrol/emoticons/emoticons.png
M  +16   -13   doc/kcontrol/emoticons/index.docbook

http://commits.kde.org/plasma-desktop/40a1af32e109902a7fe07fdbd59b38ed2105ee27

diff --git a/doc/kcontrol/emoticons/emoticons.png 
b/doc/kcontrol/emoticons/emoticons.png
index b46c8c4..99bfd24 100644
Binary files a/doc/kcontrol/emoticons/emoticons.png and 
b/doc/kcontrol/emoticons/emoticons.png differ
diff --git a/doc/kcontrol/emoticons/index.docbook 
b/doc/kcontrol/emoticons/index.docbook
index 327a803..a3b361d 100644
--- a/doc/kcontrol/emoticons/index.docbook
+++ b/doc/kcontrol/emoticons/index.docbook
@@ -12,8 +12,8 @@
 
 
 
-2015-04-08
-Plasma 5.3
+2016-09-21
+Plasma 5.8
 
 
 KDE
@@ -62,7 +62,7 @@ An emoticon consists in two parts: an icon (typically a 
.png
 
 
-The emoticons themes will be saved locally in your home in $KDEHOME/share/emoticons.
+The emoticons themes will be saved locally in your home in $(qtpaths --paths GenericDataLocation)/emoticons.
 
 
 
@@ -86,24 +86,26 @@ When this option is not checked (default), each emoticon 
string will be replaced
 
 
 
-New Theme...
+Install from File
 
 
-You can create your own new theme from scratch. Clicking on this button brings 
a dialog asking for the name of the new theme. You can then use the 
Add... button on the right to create new emoticons and 
their associated text.
+This action allows you to install a theme you downloaded yourself. A theme 
file is an archive file, usually a .tar.gz or a 
.zip file or any other archive files. A dialog asks you 
for the location of this local archive file and after you entered or dragged 
the URL and clicked OK, the theme is installed and will 
appear in the themes list.
 
 
 
-Get New Icon Themes...
+
+Get New Theme
 
 
-You need to be connected to the Internet to use this action. A dialog displays 
a list of emoticons themes from http://www.kde-look.org;>http://www.kde-look.org and you can 
install one by clicking the Install button on the right 
side of the theme description in the list.
+You need to be connected to the Internet to use this action. A dialog displays 
a list of emoticons themes from https://store.kde.org/;>https://store.kde.org/ and you can install 
one by clicking the Install button on the right side of 
the theme description in the list.
 
 
 
-Install Theme File...
+
+New Theme
 
 
-This action allows you to install a theme you downloaded yourself. A theme 
file is an archive file, usually a .tar.gz or a 
.zip file or any other archive files. A dialog asks you 
for the location of this local archive file and after you entered or dragged 
the URL and clicked OK, the theme is installed and will 
appear in the themes list.
+You can create your own new theme from scratch. Clicking on this button brings 
a dialog asking for the name of the new theme. You can then use the 
Add... button on the right to create new emoticons and 
their associated text.
 
 
 
@@ -134,17 +136,18 @@ This button allows you to add an emoticon to the selected 
theme. The dialog asks
 
 
 
-Edit...
+Remove
 
 
-The Edit... button allows you to change either the icon 
or the text of the selected emoticon. You need to click the 
OK button to validate this action.
+This will remove the selected emoticon from the selected theme. You need to 
click the Yes button to validate this action.
 
 
 
-Remove
+
+Edit...
 
 
-This will remove the selected emoticon from the selected theme. You need to 
click the Yes button to validate this action.
+The Edit... button allows you to change either the icon 
or the text of the selected emoticon. You need to click the 
OK button to validate this action.
 
 
 

Re: Review Request 128977: Proofread/update emoticons kcm docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128977/
---

(Updated Sept. 21, 2016, 7:03 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation and Plasma.


Changes
---

Submitted with commit 40a1af32e109902a7fe07fdbd59b38ed2105ee27 by Burkhard Lück 
to branch master.


Repository: plasma-desktop


Description
---

proofread
fix kde4 path
kde-look.org -> store.kde.org
update screenshot


Diffs
-

  doc/kcontrol/emoticons/emoticons.png b46c8c4 
  doc/kcontrol/emoticons/index.docbook 327a803 

Diff: https://git.reviewboard.kde.org/r/128977/diff/


Testing
---

passes checkXML5


File Attachments


emoticons.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/16b1128d-3014-4f35-9274-a406bc1d8ab3__emoticons.png


Thanks,

Burkhard Lück

Re: Review Request 128978: Proofread/update kcmstyle (Widget Style) kcm docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128978/
---

(Updated Sept. 21, 2016, 6:45 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation and Plasma.


Changes
---

Submitted with commit c94a2cb6b0dedb9a67a66b15e7c02b0451e9b6b9 by Burkhard Lück 
to branch master.


Repository: plasma-desktop


Description
---

proofread
remove obsolete option


Diffs
-

  doc/kcontrol/kcmstyle/index.docbook 82cd571 

Diff: https://git.reviewboard.kde.org/r/128978/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

[plasma-desktop] doc/kcontrol/kcmstyle: Proofread/update kcmstyle (Widget Style) kcm docbook

[Burkhard Lück]

Git commit c94a2cb6b0dedb9a67a66b15e7c02b0451e9b6b9 by Burkhard Lück.
Committed on 21/09/2016 at 18:44.
Pushed by lueck into branch 'master'.

Proofread/update kcmstyle (Widget Style) kcm docbook

proofread
remove obsolete option
REVIEW:128978

M  +3-8doc/kcontrol/kcmstyle/index.docbook

http://commits.kde.org/plasma-desktop/c94a2cb6b0dedb9a67a66b15e7c02b0451e9b6b9

diff --git a/doc/kcontrol/kcmstyle/index.docbook 
b/doc/kcontrol/kcmstyle/index.docbook
index 82cd571..dd1ea02 100644
--- a/doc/kcontrol/kcmstyle/index.docbook
+++ b/doc/kcontrol/kcmstyle/index.docbook
@@ -14,13 +14,14 @@
 
 
 
-2015-07-07
-Plasma 5.3
+2016-09-21
+Plasma 5.8
 
 
 KDE
 System Settings
 style
+widgets
 
 
 
@@ -70,12 +71,6 @@ a dialog to select further settings.
 Fine Tuning tab
 
 
- 
-Graphical effects
-
- applications will run internal animations with the selected 
display resolution and CPU usage.
- 
- 
 
  
 Show icons on buttons

[plasma-desktop] doc/kcontrol/colors: Update color kcm docbook to 5.8

[Burkhard Lück]

Git commit 450724b0b50d396dcc5ebd08d6e918c51402bafd by Burkhard Lück.
Committed on 21/09/2016 at 18:40.
Pushed by lueck into branch 'master'.

Update color kcm docbook to 5.8

Adapt docbook to changed kcm in 5.8
REVIEW:128965

M  +55   -81   doc/kcontrol/colors/index.docbook

http://commits.kde.org/plasma-desktop/450724b0b50d396dcc5ebd08d6e918c51402bafd

diff --git a/doc/kcontrol/colors/index.docbook 
b/doc/kcontrol/colors/index.docbook
index 75548b5..cd392e3 100644
--- a/doc/kcontrol/colors/index.docbook
+++ b/doc/kcontrol/colors/index.docbook
@@ -14,8 +14,8 @@
 
 
 
-2015-04-10
-Plasma 5.3
+2016-09-20
+Plasma 5.8
 
 
 KDE
@@ -28,66 +28,50 @@
 
 Colors
 
-
-  Introduction
-
-  The Color Selection module is comprised of several sections:
-
-  
-  
-The Scheme tab,
-used to manage schemes.
-  
-  
-The Options tab,
-used to change the options of the current scheme.
-  
-  
-The Colors tab,
-used to change the colors of the current scheme.
-  
-  
-The state effects tabs
-(Inactive, Disabled), used to 
-change the state effects of the current scheme.
-  
-  
-
-  Note: This documentation will sometimes refer to the
-  current scheme, or the active scheme.
-  The current scheme is the set of colors and color scheme options
-  that was most recently applied,  what you would get if you choose
-  Cancel. The active scheme is the set of
-  colors as has been most recently edited by you,  what you would get if
-  you choose Apply.
-
-
 
   Scheme Management
 
-  The Scheme tab lets you manage the color schemes
-  on your machine. Only one scheme is active at once, but you may save schemes,
-  allowing you to quickly change the scheme later. When you have created a
-  scheme you like, you can save it with Save Scheme
+  This module lets you manage the color schemes on your machine.
+  It shows a list of color schemes shipped with  and a preview at the 
top.
+  Only one scheme is active at once, but you may edit schemes.
   You can remove schemes using Remove Scheme.
   Note that system schemes cannot be removed; trying to do so will display an
   error.
 
-  Plasma ships with several schemes. If you have an Internet connection,
+  If you have an Internet connection,
   you can also browse and retrieve user-created schemes using Get
   New Schemes
 
-  
-Importing Schemes
+  You can also install schemes from a file that you have downloaded or 
otherwise
+  obtained, as well as import  4 schemes named like *.colors.
+  
 
-You can also import schemes that you have downloaded or otherwise
-obtained, as well as import  4 schemes named like 
*.colors.
-
+  If Apply colors to non-Qt applications
+  is checked, Plasma will attempt to export its color scheme so that
+  non-Qt applications will use the same colors. Most applications will
+  honor the exported scheme to varying degrees, though some may have bugs
+  or otherwise not honor the exported scheme.
+  
 
-  
+  Note: This documentation will sometimes refer to the
+  current scheme, or the active scheme.
+  The current scheme is the set of colors and color scheme options
+  that was most recently applied,  what you would get if you choose
+  Cancel. The active scheme is the set of
+  colors as has been most recently edited by you,  what you would get if
+  you choose Apply.
 
 
-
+
+  Edit or Create Schemes
+  To edit or create new schemes select a scheme from the list and press 
the
+  Edit Scheme button to open a dialog with three tabs 
+  Options, Colors and 
Disabled.
+  When you have created a scheme you like, you can upload it, reset it or save 
it
+  under a different name or overwrite the active scheme.
+  
+
+
   Color Scheme Options
 
   The Options tab allows you to change some
@@ -116,12 +100,6 @@
   color to paint the column whose information is being used to sort the
   items in the list.
 
-Apply colors to non-Qt applications
-   If checked, Plasma will attempt to export its color scheme so 
that
-  non-Qt applications will use the same colors. Most applications will
-  honor the exported scheme to varying degrees, though some may have bugs
-  or otherwise not honor the exported scheme.
-
 Contrast
This slider controls the contrast of shaded elements, such as
   frame borders and the 3D effects used by most styles. A lower
@@ -130,18 +108,17 @@
 
   
 
-
+
 
-
+
   Colors
 
   The Colors tab allows you to change the colors in
   the active color scheme.
 
   Creating or changing a scheme is a simple matter of clicking on the
-  swatch in the color list and selecting a new color. You can check your
-  changes at any time by pressing Apply. It is suggested
-  that you save your scheme (via the Scheme tab) when you
+  swatch in the color list and selecting a new color. It is suggested
+  that you save your scheme when you
   are done.
 
   The Common Colors set, which is displayed
@@ -162,7 +139,7 @@
   all, and can only be changed (if 

Re: Review Request 128973: Update icon lcm docbook

[Marco Martin]

> On Sept. 21, 2016, 2:58 p.m., Marco Martin wrote:
> > doc/kcontrol/icons/index.docbook, line 33
> > 
> >
> > uppercase Plasma, Dolphin etc?
> 
> Burkhard Lück wrote:
> frameworks/kdoctools
> 
> general.entities:400:Plasma">
> 
> general.entities:136: "Dolphin">
> 
> these entities expang in the html to uppercase

ah, ok, thanks!


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128973/#review99368
---


On Sept. 21, 2016, 12:32 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128973/
> ---
> 
> (Updated Sept. 21, 2016, 12:32 p.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> kde -> plasma
> konqueror -> dolphin
> remove kdeartwork
> remove obsolete para already commented since 4.5
> update old screenshots
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/icons/delete-theme.png 8421b7e 
>   doc/kcontrol/icons/effects.png b992dff 
>   doc/kcontrol/icons/index.docbook 27a6c9e 
>   doc/kcontrol/icons/size.png 599c162 
> 
> Diff: https://git.reviewboard.kde.org/r/128973/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> File Attachments
> 
> 
> size.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/83dc0115-520c-4f95-8720-25511309c810__size.png
> effects.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/e1ec13b3-0a9f-4418-ac74-269146240886__effects.png
> delete-theme.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/38753dee-193f-46a5-b06e-b61a7733ba7b__delete-theme.png
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128973: Update icon lcm docbook

[Burkhard Lück]

> On Sept. 21, 2016, 2:58 nachm., Marco Martin wrote:
> > doc/kcontrol/icons/index.docbook, line 33
> > 
> >
> > uppercase Plasma, Dolphin etc?

frameworks/kdoctools

general.entities:400:Plasma">

general.entities:136:Dolphin">

these entities expang in the html to uppercase


> On Sept. 21, 2016, 2:58 nachm., Marco Martin wrote:
> > doc/kcontrol/icons/index.docbook, line 65
> > 
> >
> > uppercase (and subsequent ones too)

see obove


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128973/#review99368
---


On Sept. 21, 2016, 12:32 nachm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128973/
> ---
> 
> (Updated Sept. 21, 2016, 12:32 nachm.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> kde -> plasma
> konqueror -> dolphin
> remove kdeartwork
> remove obsolete para already commented since 4.5
> update old screenshots
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/icons/delete-theme.png 8421b7e 
>   doc/kcontrol/icons/effects.png b992dff 
>   doc/kcontrol/icons/index.docbook 27a6c9e 
>   doc/kcontrol/icons/size.png 599c162 
> 
> Diff: https://git.reviewboard.kde.org/r/128973/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> File Attachments
> 
> 
> size.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/83dc0115-520c-4f95-8720-25511309c810__size.png
> effects.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/e1ec13b3-0a9f-4418-ac74-269146240886__effects.png
> delete-theme.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/38753dee-193f-46a5-b06e-b61a7733ba7b__delete-theme.png
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128974: Proofread/update cursortheme kcm docbook

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128974/#review99367
---


Ship it!




Ship It!

- Marco Martin


On Sept. 21, 2016, 12:42 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128974/
> ---
> 
> (Updated Sept. 21, 2016, 12:42 p.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Proofread/update cursortheme kcm docbook
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/cursortheme/index.docbook 51ca419 
> 
> Diff: https://git.reviewboard.kde.org/r/128974/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128973: Update icon lcm docbook

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128973/#review99368
---


Fix it, then Ship it!





doc/kcontrol/icons/index.docbook (line 33)


uppercase Plasma, Dolphin etc?



doc/kcontrol/icons/index.docbook (line 65)


uppercase (and subsequent ones too)


- Marco Martin


On Sept. 21, 2016, 12:32 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128973/
> ---
> 
> (Updated Sept. 21, 2016, 12:32 p.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> kde -> plasma
> konqueror -> dolphin
> remove kdeartwork
> remove obsolete para already commented since 4.5
> update old screenshots
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/icons/delete-theme.png 8421b7e 
>   doc/kcontrol/icons/effects.png b992dff 
>   doc/kcontrol/icons/index.docbook 27a6c9e 
>   doc/kcontrol/icons/size.png 599c162 
> 
> Diff: https://git.reviewboard.kde.org/r/128973/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> File Attachments
> 
> 
> size.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/83dc0115-520c-4f95-8720-25511309c810__size.png
> effects.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/e1ec13b3-0a9f-4418-ac74-269146240886__effects.png
> delete-theme.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/38753dee-193f-46a5-b06e-b61a7733ba7b__delete-theme.png
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128977: Proofread/update emoticons kcm docbook

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128977/#review99366
---


Ship it!




Ship It!

- Marco Martin


On Sept. 21, 2016, 1:16 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128977/
> ---
> 
> (Updated Sept. 21, 2016, 1:16 p.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> proofread
> fix kde4 path
> kde-look.org -> store.kde.org
> update screenshot
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/emoticons/emoticons.png b46c8c4 
>   doc/kcontrol/emoticons/index.docbook 327a803 
> 
> Diff: https://git.reviewboard.kde.org/r/128977/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> File Attachments
> 
> 
> emoticons.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/16b1128d-3014-4f35-9274-a406bc1d8ab3__emoticons.png
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128978: Proofread/update kcmstyle (Widget Style) kcm docbook

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128978/#review99365
---


Ship it!




Ship It!

- Marco Martin


On Sept. 21, 2016, 1:31 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128978/
> ---
> 
> (Updated Sept. 21, 2016, 1:31 p.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> proofread
> remove obsolete option
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/kcmstyle/index.docbook 82cd571 
> 
> Diff: https://git.reviewboard.kde.org/r/128978/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128968: Convert checkxml5 into a qt executable for cross plattform support.

[Luigi Toscano]

> On Sept. 21, 2016, 12:38 p.m., Luigi Toscano wrote:
> > Would it make more sense to change meinproc5 to work like checkXML5 if 
> > invoked with that name (hardlink, copy, etc, a-la busybox)?
> 
> Ralf Habacker wrote:
> Sorry, I do not know the reasons why this tool has been created and has 
> not been integrated into meinproc5. You should ask the original author.

The original author (Laurent Montel, 
https://websvn.kde.org/?view=revision=505145) don't remember much, and 
I guess it's not relevant here. My question was: from a multiplatform 
prospective, would this solution have any drawback? Where "this solution" is: 
have a checkXML5(.exe) executable which is an hardlink (or a copy, I guess, on 
Windows) to meinproc5, but exposing the behavior of the wrapper script?


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128968/#review99350
---


On Sept. 21, 2016, 11:35 a.m., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128968/
> ---
> 
> (Updated Sept. 21, 2016, 11:35 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Convert checkxml5 into a qt executable for cross plattform support.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 8674faaba6346156907aa5fbbea1ee2b38865eda 
>   checkXML5.in.cmake d7a57c78ec768a4eb9d3c669b8fe3bbef2991c93 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
>   src/checkXML5.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128968/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 128968: Convert checkxml5 into a qt executable for cross plattform support.

[Ralf Habacker]

> On Sept. 21, 2016, 12:38 nachm., Luigi Toscano wrote:
> > Would it make more sense to change meinproc5 to work like checkXML5 if 
> > invoked with that name (hardlink, copy, etc, a-la busybox)?

Sorry, I do not know the reasons why this tool has been created and has not 
been integrated into meinproc5. You should ask the original author.


- Ralf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128968/#review99350
---


On Sept. 21, 2016, 11:35 vorm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128968/
> ---
> 
> (Updated Sept. 21, 2016, 11:35 vorm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Convert checkxml5 into a qt executable for cross plattform support.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 8674faaba6346156907aa5fbbea1ee2b38865eda 
>   checkXML5.in.cmake d7a57c78ec768a4eb9d3c669b8fe3bbef2991c93 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
>   src/checkXML5.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128968/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Review Request 128978: Proofread/update kcmstyle (Widget Style) kcm docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128978/
---

Review request for Documentation and Plasma.


Repository: plasma-desktop


Description
---

proofread
remove obsolete option


Diffs
-

  doc/kcontrol/kcmstyle/index.docbook 82cd571 

Diff: https://git.reviewboard.kde.org/r/128978/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

Re: Review Request 128969: Add cross compiling support for docbookl10nhelper.

[Ralf Habacker]

> On Sept. 21, 2016, 1:52 nachm., Luigi Toscano wrote:
> > src/CMakeLists.txt, line 173
> > 
> >
> > docbookl10nhelper is not meant to be installed
> 
> Ralf Habacker wrote:
> To cross compile kdoctools for windows on e.g. linux native running tools 
> like meinproc5, docbookl10nhelper and checkXML5 are required. On 
> bootstrapping cross compile these native tools are created and packaged 
> together in a packages named mingwXX-cross-kf5-tools like similar cross 
> helper tools for example mingw32-cross-gcc.
> 
> Luigi Toscano wrote:
> Uhm, but normally we don't need it - can't this installation be done 
> under some condition, so that the default is not changed?

Sonnet for example installs similar tools 'parsetrigrams' and  'gentrigrams' 
also unconditional. On opensuse they are packaged as part of the development 
package. see 
https://build.opensuse.org/package/view_file/KDE:Frameworks5/sonnet/sonnet.spec?expand=1
 line 134,135.

If this is an absolute nogo there would be still the choice to use a specific 
configure time switch like INSTALL_ALL or similar ?


- Ralf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128969/#review99351
---


On Sept. 21, 2016, 11:43 vorm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128969/
> ---
> 
> (Updated Sept. 21, 2016, 11:43 vorm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Add cross compiling support for docbookl10nhelper.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
> 
> Diff: https://git.reviewboard.kde.org/r/128969/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Review Request 128977: Proofread/update emoticons kcm docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128977/
---

Review request for Documentation and Plasma.


Repository: plasma-desktop


Description
---

proofread
fix kde4 path
kde-look.org -> store.kde.org
update screenshot


Diffs
-

  doc/kcontrol/emoticons/emoticons.png b46c8c4 
  doc/kcontrol/emoticons/index.docbook 327a803 

Diff: https://git.reviewboard.kde.org/r/128977/diff/


Testing
---

passes checkXML5


File Attachments


emoticons.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/16b1128d-3014-4f35-9274-a406bc1d8ab3__emoticons.png


Thanks,

Burkhard Lück

Re: Review Request 128969: Add cross compiling support for docbookl10nhelper.

[Luigi Toscano]

> On Sept. 21, 2016, 1:52 p.m., Luigi Toscano wrote:
> > src/CMakeLists.txt, line 173
> > 
> >
> > docbookl10nhelper is not meant to be installed
> 
> Ralf Habacker wrote:
> To cross compile kdoctools for windows on e.g. linux native running tools 
> like meinproc5, docbookl10nhelper and checkXML5 are required. On 
> bootstrapping cross compile these native tools are created and packaged 
> together in a packages named mingwXX-cross-kf5-tools like similar cross 
> helper tools for example mingw32-cross-gcc.

Uhm, but normally we don't need it - can't this installation be done under some 
condition, so that the default is not changed?


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128969/#review99351
---


On Sept. 21, 2016, 11:43 a.m., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128969/
> ---
> 
> (Updated Sept. 21, 2016, 11:43 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Add cross compiling support for docbookl10nhelper.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
> 
> Diff: https://git.reviewboard.kde.org/r/128969/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 128969: Add cross compiling support for docbookl10nhelper.

[Ralf Habacker]

> On Sept. 21, 2016, 1:52 nachm., Luigi Toscano wrote:
> > src/CMakeLists.txt, line 173
> > 
> >
> > docbookl10nhelper is not meant to be installed

To cross compile kdoctools for windows on e.g. linux native running tools like 
meinproc5, docbookl10nhelper and checkXML5 are required. On bootstrapping cross 
compile these native tools are created and packaged together in a packages 
named mingwXX-cross-kf5-tools like similar cross helper tools for example 
mingw32-cross-gcc.


- Ralf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128969/#review99351
---


On Sept. 21, 2016, 11:43 vorm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128969/
> ---
> 
> (Updated Sept. 21, 2016, 11:43 vorm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Add cross compiling support for docbookl10nhelper.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
> 
> Diff: https://git.reviewboard.kde.org/r/128969/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Review Request 128974: Proofread/update cursortheme kcm docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128974/
---

Review request for Documentation and Plasma.


Repository: plasma-desktop


Description
---

Proofread/update cursortheme kcm docbook


Diffs
-

  doc/kcontrol/cursortheme/index.docbook 51ca419 

Diff: https://git.reviewboard.kde.org/r/128974/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

Review Request 128973: Update icon lcm docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128973/
---

Review request for Documentation and Plasma.


Repository: plasma-desktop


Description
---

kde -> plasma
konqueror -> dolphin
remove kdeartwork
remove obsolete para already commented since 4.5
update old screenshots


Diffs
-

  doc/kcontrol/icons/delete-theme.png 8421b7e 
  doc/kcontrol/icons/effects.png b992dff 
  doc/kcontrol/icons/index.docbook 27a6c9e 
  doc/kcontrol/icons/size.png 599c162 

Diff: https://git.reviewboard.kde.org/r/128973/diff/


Testing
---

passes checkXML5


File Attachments


size.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/83dc0115-520c-4f95-8720-25511309c810__size.png
effects.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/e1ec13b3-0a9f-4418-ac74-269146240886__effects.png
delete-theme.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/38753dee-193f-46a5-b06e-b61a7733ba7b__delete-theme.png


Thanks,

Burkhard Lück

Re: Review Request 128970: Add cross compile support for meinproc5.

[Luigi Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128970/#review99352
---




src/CMakeLists.txt 


So, I inherited kdoctools with this code commented - do you have an idea 
why it was like this, and why your patch would solve the (old) issues, or if 
they are not relevant anymore? My cross-compilation knowledge is limited.


- Luigi Toscano


On Sept. 21, 2016, 11:44 a.m., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128970/
> ---
> 
> (Updated Sept. 21, 2016, 11:44 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Add cross compile support for meinproc5.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
> 
> Diff: https://git.reviewboard.kde.org/r/128970/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 128969: Add cross compiling support for docbookl10nhelper.

[Luigi Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128969/#review99351
---




src/CMakeLists.txt (line 173)


docbookl10nhelper is not meant to be installed


- Luigi Toscano


On Sept. 21, 2016, 11:43 a.m., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128969/
> ---
> 
> (Updated Sept. 21, 2016, 11:43 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Add cross compiling support for docbookl10nhelper.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
> 
> Diff: https://git.reviewboard.kde.org/r/128969/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 128968: Convert checkxml5 into a qt executable for cross plattform support.

[Luigi Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128968/#review99350
---



Would it make more sense to change meinproc5 to work like checkXML5 if invoked 
with that name (hardlink, copy, etc, a-la busybox)?

- Luigi Toscano


On Sept. 21, 2016, 11:35 a.m., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128968/
> ---
> 
> (Updated Sept. 21, 2016, 11:35 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Convert checkxml5 into a qt executable for cross plattform support.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 8674faaba6346156907aa5fbbea1ee2b38865eda 
>   checkXML5.in.cmake d7a57c78ec768a4eb9d3c669b8fe3bbef2991c93 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
>   src/checkXML5.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128968/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 128948: Update shortcuts kcm docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128948/
---

(Updated Sept. 21, 2016, 10:11 a.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation and Plasma.


Changes
---

Submitted with commit 6c3de2f1ffaf681533e4c624c11581702ce601ff by Burkhard Lück 
to branch master.


Repository: plasma-desktop


Description
---

adapt to changes in 5.8


Diffs
-

  doc/kcontrol/keys/index.docbook 27eab50 

Diff: https://git.reviewboard.kde.org/r/128948/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

[plasma-desktop] doc/kcontrol/keys: Update shortcuts kcm docbook

[Burkhard Lück]

Git commit 6c3de2f1ffaf681533e4c624c11581702ce601ff by Burkhard Lück.
Committed on 21/09/2016 at 10:11.
Pushed by lueck into branch 'master'.

Update shortcuts kcm docbook

adapt to changes in 5.8
Resort para in section key-bindings-global
REVIEW:128948

M  +21   -80   doc/kcontrol/keys/index.docbook
A  +---doc/kcontrol/keys/list-add.png
A  +---doc/kcontrol/keys/remove.png

http://commits.kde.org/plasma-desktop/6c3de2f1ffaf681533e4c624c11581702ce601ff

diff --git a/doc/kcontrol/keys/index.docbook b/doc/kcontrol/keys/index.docbook
index 27eab50..0ea336a 100644
--- a/doc/kcontrol/keys/index.docbook
+++ b/doc/kcontrol/keys/index.docbook
@@ -14,11 +14,11 @@
 
 
 
-2015-04-08
-Plasma 5.3
+2016-09-17
+Plasma 5.8
 
 
-KDE
+Plasma
 KControl
 key bindings
 bindings
@@ -32,7 +32,7 @@
  
 Introduction 
 
-While most of the functionality offered by  can be accessed
+While most of the functionality offered by  can be accessed
 using a simple point and click interface, many people
 prefer using the keyboard for some tasks.  Pressing something like
  F is often
@@ -41,7 +41,7 @@ opening the Edit menu and selecting
 Find.
 
  As different people have different preferences about keyboard
-shortcuts,  offers full customization of key
+shortcuts,  offers full customization of key
 bindings. A key binding or shortcut is a combination of an
 action with a key or a combination of keys.
 
@@ -56,7 +56,7 @@ Actually, in a certain way standard or application shortcuts 
are
 difference is:
 
 
-Standard keyboard shortcuts refer to actions
+Standard shortcuts refer to actions
 that are often available in applications, such as Save, Print, Copy
  
 Global shortcuts are shortcuts for
@@ -72,29 +72,35 @@ for which you have to customize key bindings using the 
application's
 key bindings dialog.
 
 
-Standard Keyboard Shortcuts page
+Standard Shortcuts page
 At the top of this dialog you see an input box, where you can
 search interactively for shortcut names ( Copy) or combination of keys 
 ( Ctrl+C) by typing them literally 
here.
 Below the search box you can see a list of key bindings,  
associations between actions 
-( Copy) shown in the Actions column and keys or 
combination of keys 
+( Copy) shown in the Action column and keys or 
combination of keys 
 ( C ) shown in 
the 
 Shortcut or Alternate column.
 
-
 
 
 
 Global Shortcuts page
-At the top of this page is a drop down box which allows you
-to select a KDE component like KWin, Plasma Desktop 
+At the left of this page is a list box which allows you
+to select a Component like KWin, Plasma Desktop 
 The defined shortcuts for the selected component are displayed in the 
-Action and Global column in the list 
view. 
-Click the File drop down box at the right to 
import/export a 
-Scheme, set all shortcuts to none and remove a component.
-This page has the same search box as the Standard Keyboard 
+Action and Global column in the list 
view.
+This page has the same search box as the Standard 
 Shortcuts tab.
+Use 
+or 
+to add or remove a component.
+
+Click the File drop down box at the right to 
import/export a 
+Scheme, set all shortcuts to none.
+Global shortcuts can now be configured to jump to specific tasks within 
an application.
 
+By default you can open the application menu by just pressing the 
Meta key.
+
 
 
 
@@ -131,71 +137,6 @@ allows to edit the second shortcut for the 
action.
 
 
 
-
-
 
 
 
diff --git a/doc/kcontrol/keys/list-add.png b/doc/kcontrol/keys/list-add.png
new file mode 100644
index 000..e06ff25
Binary files /dev/null and b/doc/kcontrol/keys/list-add.png differ
diff --git a/doc/kcontrol/keys/remove.png b/doc/kcontrol/keys/remove.png
new file mode 100644
index 000..762f0b2
Binary files /dev/null and b/doc/kcontrol/keys/remove.png differ

Review Request 128970: Add cross compile support for meinproc5.

[Ralf Habacker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128970/
---

Review request for Documentation, KDE Frameworks and Luigi Toscano.


Repository: kdoctools


Description
---

Add cross compile support for meinproc5.


Diffs
-

  src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 

Diff: https://git.reviewboard.kde.org/r/128970/diff/


Testing
---

compiled at 
https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools


Thanks,

Ralf Habacker

Review Request 128969: Add cross compiling support for docbookl10nhelper.

[Ralf Habacker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128969/
---

Review request for Documentation, KDE Frameworks and Luigi Toscano.


Repository: kdoctools


Description
---

Add cross compiling support for docbookl10nhelper.


Diffs
-

  src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 

Diff: https://git.reviewboard.kde.org/r/128969/diff/


Testing
---

compiled at 
https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools


Thanks,

Ralf Habacker

Review Request 128968: Convert checkxml5 into a qt executable for cross plattform support.

[Ralf Habacker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128968/
---

Review request for Documentation, KDE Frameworks and Luigi Toscano.


Repository: kdoctools


Description
---

Convert checkxml5 into a qt executable for cross plattform support.


Diffs
-

  CMakeLists.txt 8674faaba6346156907aa5fbbea1ee2b38865eda 
  checkXML5.in.cmake d7a57c78ec768a4eb9d3c669b8fe3bbef2991c93 
  src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
  src/checkXML5.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128968/diff/


Testing
---

compiled at 
https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools


Thanks,

Ralf Habacker

Re: Review Request 128948: Update shortcuts kcm docbook

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128948/#review99346
---


Ship it!




Ship It!

- Marco Martin


On Sept. 20, 2016, 5:26 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128948/
> ---
> 
> (Updated Sept. 20, 2016, 5:26 p.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> adapt to changes in 5.8
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/keys/index.docbook 27eab50 
> 
> Diff: https://git.reviewboard.kde.org/r/128948/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128965: Update color kcm docbook to 5.8

[Olivier Churlaud]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128965/#review99344
---


Ship it!




Ship It!

- Olivier Churlaud


On Sept. 21, 2016, 5:42 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128965/
> ---
> 
> (Updated Sept. 21, 2016, 5:42 a.m.)
> 
> 
> Review request for Documentation, Plasma and Olivier Churlaud.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Adapt docbook to changed kcm in 5.8
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/colors/index.docbook 75548b5 
> 
> Diff: https://git.reviewboard.kde.org/r/128965/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>