D23415: Improve comprehensibility and consistency of window placement mode names

[Nathaniel Graham]

ngraham added a comment.


  In fact, the HIG already says that:
  
  > https://hig.kde.org/style/writing/labels.html#guidelines
  >  Don’t shorten your labels to the point of losing meaning. A three-word 
label that provides clear information is better than a one-word label that is 
ambiguous or vague. Try to find the fewest possible words to satisfactorily 
convey the meaning of your label.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23415

To: ngraham, #kwin, #vdg, ndavis, filipf, zzag
Cc: hein, hpereiradacosta, GB_2, alexde, davidedmundson, romangg, cfeck, 
filipf, zzag, ndavis, kwin, kde-doc-english, LeGast00n, The-Feren-OS-Dev, 
sbergeron, jraleigh, gennad, fbampaloukas, mkulinski, ragreen, jackyalcine, 
Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, skadinna, himcesjf, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D23415: Improve comprehensibility and consistency of window placement mode names

[Eike Hein]

hein added a comment.


  "Smart" is a non-label to me and pretty lazy; it's like someone did a lame 
attempt at branding an option as cool instead of just putting some effort into 
finding a succinct description of what it aims for.
  
  The strings suggested by the patch seem like a nice improvement in clarity 
and making the system learnable and controllable. For as long as we pride 
ourselves on being "powerful when needed", that's what we should aim for - a 
system doing magic things you can't reason about isn't empowering.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23415

To: ngraham, #kwin, #vdg, ndavis, filipf, zzag
Cc: hein, hpereiradacosta, GB_2, alexde, davidedmundson, romangg, cfeck, 
filipf, zzag, ndavis, kwin, kde-doc-english, LeGast00n, The-Feren-OS-Dev, 
sbergeron, jraleigh, gennad, fbampaloukas, mkulinski, ragreen, jackyalcine, 
Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, skadinna, himcesjf, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D23415: Improve comprehensibility and consistency of window placement mode names

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  for what its worth: to me smart means: there has been some thought put in 
this placement policy and it should be the best one for you. If you don't like 
it, you might want to try the alternatives. When I read "smart" as an option, 
immediately I think "that's what I want", and select it, if not already 
selected. In other words, it is another (better) way of saying "default", 
without having to go through the actual description of what it means. 
  I'm all for keeping it like this.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23415

To: ngraham, #kwin, #vdg, ndavis, filipf, zzag
Cc: hpereiradacosta, GB_2, alexde, davidedmundson, romangg, cfeck, filipf, 
zzag, ndavis, kwin, kde-doc-english, LeGast00n, The-Feren-OS-Dev, sbergeron, 
jraleigh, gennad, fbampaloukas, mkulinski, ragreen, jackyalcine, Pitel, 
iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, skadinna, himcesjf, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D22616: Remove phonon KCM

[Nathaniel Graham]

ngraham added a task: T9091: Merge PulseAudio and Phonon KCM.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22616

To: nicolasfella, sitter
Cc: ngraham, kde-doc-english, pino, plasma-devel, sitter, LeGast00n, 
The-Feren-OS-Dev, jraleigh, gennad, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D23415: Improve comprehensibility and consistency of window placement mode names

[Björn Feber]

GB_2 added a comment.


  In D23415#521275 , @alexde wrote:
  
  > I am not sure if I am allowed to intervene in this discussion, but "smart" 
is a really "dumb" description as it says nothing about what it actually does.
  >  As a user I am left to do four things to find out, what it means:
  >
  > 1. Activate the option, observe the result and maybe compare it to other 
options
  > 2. Search on the web
  > 3. Ask someone who may know it
  > 4. Browse the code
  >
  >   That's all not necessary if it just has a meaningful name that does not 
need further explanations. :)
  
  
  Fully agree, this is what a user experiences and the reason why it should be 
changed.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23415

To: ngraham, #kwin, #vdg, ndavis, filipf, zzag
Cc: GB_2, alexde, davidedmundson, romangg, cfeck, filipf, zzag, ndavis, kwin, 
kde-doc-english, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, gennad, 
fbampaloukas, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, 
ZrenBot, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D23415: Improve comprehensibility and consistency of window placement mode names

[Alex Debus]

alexde added a comment.


  I am not sure if I am allowed to intervene in this discussion, but "smart" is 
a really "dumb" description as it says nothing about what it actually does.
  As a user I am left to do four things to find out, what it means:
  
  1. Activate the option, observe the result and maybe compare it to other 
options
  2. Search on the web
  3. Ask someone who may know it
  4. Browse the code
  
  That's all not necessary if it just has a meaningful name that do need 
further explanations. :)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23415

To: ngraham, #kwin, #vdg, ndavis, filipf, zzag
Cc: alexde, davidedmundson, romangg, cfeck, filipf, zzag, ndavis, kwin, 
kde-doc-english, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, gennad, 
fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, 
bwowk, ZrenBot, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D22444: Add Reset Zoom Level action inside View menu

[Nathaniel Graham]

ngraham marked 3 inline comments as done.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22444

To: ngraham, elvisangelaccio, shubham, #dolphin
Cc: broulik, cfeck, kfm-devel, kde-doc-english, aprcela, vmarinescu, fprice, 
gennad, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, 
navarromorales, firef, andrebarros, skadinna, emmanuelp, mikesomov

D22444: Add Reset Zoom Level action inside View menu

[Nathaniel Graham]

ngraham updated this revision to Diff 64868.
ngraham added a comment.


  - Rebase
  - Address review comments

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22444?vs=63767=64868

BRANCH
  arcpatch-D22444

REVISION DETAIL
  https://phabricator.kde.org/D22444

AFFECTED FILES
  doc/index.docbook
  src/dolphinmainwindow.cpp
  src/dolphinui.rc
  src/views/dolphinview.cpp
  src/views/dolphinview.h
  src/views/dolphinviewactionhandler.cpp
  src/views/dolphinviewactionhandler.h

To: ngraham, elvisangelaccio, shubham, #dolphin
Cc: broulik, cfeck, kfm-devel, kde-doc-english, aprcela, vmarinescu, fprice, 
gennad, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, 
navarromorales, firef, andrebarros, skadinna, emmanuelp, mikesomov

D22444: Add Reset Zoom Level action inside View menu

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> dolphinui.rc:2
>  
> -
> +
>  

Careful, this clashes with the recent toolbar shuffling

> dolphinview.cpp:1351
> +default:mode = ViewModeSettings::IconsMode;
> +Q_ASSERT(false);
> +break;

`Q_UNREACHABLE();` Why bother having a `default` case, though?

> dolphinview.cpp:1355
> +const ViewModeSettings settings(mode);
> +QSize iconSize = QSize(settings.iconSize(), settings.iconSize());
> +setZoomLevel(ZoomLevelInfo::zoomLevelForIconSize(iconSize));

`const`

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22444

To: ngraham, elvisangelaccio, shubham, #dolphin
Cc: broulik, cfeck, kfm-devel, kde-doc-english, aprcela, vmarinescu, fprice, 
gennad, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, 
navarromorales, firef, andrebarros, skadinna, emmanuelp, mikesomov

D22444: Add Reset Zoom Level action inside View menu

[Nathaniel Graham]

ngraham added a comment.


  @elvisangelaccio Ping.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22444

To: ngraham, elvisangelaccio, shubham, #dolphin
Cc: cfeck, kfm-devel, kde-doc-english, aprcela, vmarinescu, fprice, gennad, 
MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, 
navarromorales, firef, andrebarros, skadinna, emmanuelp, mikesomov

D23415: Improve comprehensibility and consistency of window placement mode names

[Nathaniel Graham]

ngraham added a comment.


  In D23415#521038 , @zzag wrote:
  
  > My problem is that VDG goes way overboard with user-visible strings. For 
example, we didn't receive any complaints about "Desktop Effects" string. Linux 
community settled on using that term so why do we have change it? Just to show 
"hey we are different!"? Same with the smart placement. I know that it received 
some complaints about the underlying algorithm, but not the name.
  
  
  Martin F once gave me a very valuable piece of advice: stay within your area 
of expertise. This was in response to me going overboard with proposed 
technical changes to KWin, and it was a valid criticism. I'm not a domain 
expert in KWin's internals, and accordingly, I no longer propose implementation 
details for KWin; I leave that up to you and other #KWin 
 people. You're the experts. Once you 
and @davidedmundson agree on whether or not I should rename just the enums, 
I'll do whatever you two collectively decide.
  
  What I am asking is for you to show me and the VDG the same courtesy when it 
comes to UI stuff. Trust that we're the domain experts for that, the way we 
trust that you're the domain experts for the technical implementation. VDG's 
initiatives have been //extraordinarily// well received among our userbase. I 
can't tell you how many times in the past year I have read or been told 
personally, "KDE is so much more polished and user-friendly then it was the 
last time I tried it". So I do not share your perception that VDG is an 
out-of-control freight train. it's true what we don't always get everything 
right, and you shouldn't let us run roughshod especially when the proposed 
implementation is wrong. But please do give us the benefit of the doubt. KDE's 
users are happy with the VDG.
  
  Every other KDE project pays the VDG this courtesy--except KWin. Only in KWin 
do patches like this become agonizing fights that make everybody feel 
disrespected and exhausted. Other KDE projects look at something 20 years old 
as automatically suspect because it's likely missed out on two decades of 
improved technology and user interface polishing. Only in KWin is this inverted 
and the 20-year old thing is to be defended, with any change considered high 
risk. I can understand that attitude when you're talking about working code 
whose reliability is paramount, but this is a user-facing string that 
practically nobody has even read, and of the ones who did, none of them figured 
what it meant just by reading it because its name conveys no meaning. Speaking 
personally, this conservative attitude makes contributing to KWin intensely 
frustrating. I feel like I'm back in the corporate world, where every change is 
scary and must be justified to a committee, and any mistake gets punished. 
That's not how the FOSS world should be. And in general, it isn't that way for 
other KDE projects--just KWin.
  
  > Another my problem with you VDG, which is unrelated to the change itself, 
is that you act a bit aggressively in code reviews. It's totally fine to have 
some discussion in order to change mind of code reviewers in your favor, but if 
you get "no" many times and the reason why maybe it's time to stop arguing. 
Currently I see VDG as a moving train that crashes everything in front of it.
  
  I see 3 VDG people (@ngraham, @filipf, and @ndavis) and one KWin person 
(@romangg) saying yes on renaming "Smart", and 2 KWin people (@zzag and 
@davidedmundson) saying no. This doesn't seem like it's a settled matter to me. 
And I believe I have responded to all the outstanding arguments against 
renaming "Smart":
  
  - "It's been this way for 20 years and nobody has complained" **->** "it's 
been a bad string for 20 years, and things that are bad should be improved, 
regardless of how long they've been bad for"
  - "It indicates "unless you want something special, you want this one", which 
the new string doesn't do." **->** "this is indicated by the fast that it's the 
default option"
  
  So from my perspective, I'm still waiting for rebuttals, and if there are 
none, then that means there are no remaining legitimate objections. I 
understand that having these kind of back-and-forth arguments is exhausting, 
especially once it's gone on for days and we're all feeling defensive. But how 
else are we supposed to debate something controversial? If there is a better 
way, I'm all ears. But until then, if you're out of rebuttals, maybe that means 
that renaming "Smart" isn't such a bad idea after all.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23415

To: ngraham, #kwin, #vdg, ndavis, filipf, zzag
Cc: davidedmundson, romangg, cfeck, filipf, zzag, ndavis, kwin, 
kde-doc-english, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, gennad, 
fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, 
bwowk, ZrenBot, ngraham, alexeymin, 

[spectacle] doc: Update docs to the latest version in git

[Yuri Chornoivan]

Git commit 76e180e9be83b4bb20922ad148ab83e72e7fad8f by Yuri Chornoivan.
Committed on 28/08/2019 at 15:28.
Pushed by yurchor into branch 'master'.

Update docs to the latest version in git

M  +---doc/ApplicationPreferences.png
M  +---doc/MainWindow.png
M  +---doc/SaveOptions.png
M  +12   -4doc/index.docbook

https://commits.kde.org/spectacle/76e180e9be83b4bb20922ad148ab83e72e7fad8f

diff --git a/doc/ApplicationPreferences.png b/doc/ApplicationPreferences.png
index 80ff57a..fd199e8 100644
Binary files a/doc/ApplicationPreferences.png and 
b/doc/ApplicationPreferences.png differ
diff --git a/doc/MainWindow.png b/doc/MainWindow.png
index 3ccb6fe..a0aca72 100644
Binary files a/doc/MainWindow.png and b/doc/MainWindow.png differ
diff --git a/doc/SaveOptions.png b/doc/SaveOptions.png
index 76a975e..1066572 100644
Binary files a/doc/SaveOptions.png and b/doc/SaveOptions.png differ
diff --git a/doc/index.docbook b/doc/index.docbook
index 3e51f45..48b3c6a 100644
--- a/doc/index.docbook
+++ b/doc/index.docbook
@@ -29,7 +29,7 @@
 
 
 
-2019-08-22
+2019-08-28
 Applications 19.12
 
 
@@ -113,7 +113,7 @@
 
 To save a screenshot to the default location, click on the arrow 
portion of the Save As... button and press the 
Save  (S) button. The new save mode 
will be remembered for next time. The default save location and filename can be 
configured, as described later.
 
-To quickly save the image and quit , click on the 
checkbox beside Quit after Save or Copy, then click the 
arrow portion of the Save As... button and press the 
Save (S) item. This saves the image 
as a PNG file in your default Pictures folder, and exits the application 
immediately. As above, this new save mode will be remembered.
+To quickly save the image and quit , click on the 
checkbox beside Quit after manual Save or Copy, then click 
the arrow portion of the Save As... button and press the 
Save (S) item. This saves the image 
as a PNG file in your default Pictures 
folder, and exits the application immediately. As above, this new save mode 
will be remembered.
 
 
 Taking A Screenshot
@@ -121,6 +121,8 @@
 When you open , it immediately takes a screenshot 
of the whole screen as a convenience and shows a preview of it in the main 
window. You can save this screenshot using the buttons on the bottom of the 
window, or take a new one using the controls to the right of the preview.
 
 To discard the current screenshot and take another 
screenshot, press the Take a New Screenshot (N) button.
+
+After capturing a screenshot,  will show you an 
info panel with a link to the screenshot file and propose you to 
Open Containing Folder of this file.
 
 You may configure certain options on the right hand side of 
the application window before taking a new screenshot. These options allow you 
to select the area of the screen that is to be captured, set a delay before 
capturing the image, and configure whether the mouse cursor and/or the window 
decorations should be captured along with the screenshot.
 
@@ -272,7 +274,7 @@
 
 After taking a screenshot
 
-Allows copying image to clipboard. The default 
action is Do nothing, , do not copy the image to 
clipboard.
+Allows copying image to clipboard or autosave 
the image to the default location. The default location can be configured using 
the Save configuration page.
 
 
 
@@ -303,7 +305,7 @@
 
 
 
-
+
 Save
 When you use the Save function, 
 saves the image with a default filename, in your Pictures folder 
(which is inside your home folder). The default filename includes the date and 
time when the image was taken.
 
@@ -361,6 +363,12 @@
 
 
 
+
+Shortcuts
+
+This configuration page can be used to change the default 
shortcuts of . It is possible to configure shortcuts for starting 
 and capturing different parts of your desktop.
+
+
 
 
 

D23415: Improve comprehensibility and consistency of window placement mode names

[Vlad Zagorodniy]

zzag added a comment.


  In D23415#520175 , @ngraham wrote:
  
  > But that doesn't make sense to me. The reason to rename it in the code as 
well is to preserve internal consistency with the user-displayed strings. If we 
only rename the enums and not the serialized values, we're not actually doing 
that, so what's the point?
  
  
  Yes and no. My point is that enums and user visible strings should be very 
close, so one could have a look at the header file of Placement and see what 
method implements "Minimal overlapping". We can leave written config values as 
they are. Not great, not terrible. Just change "-ing" to "-ed" in a few places 
that's all what I ask.
  
  > This string is buried in the Advanced tab of an infrequently-used KCM. Bad 
strings should be improved, even if they've been bad for 20 years. Otherwise 
they'll be bad for another 20 years. I really don't understand why this is 
controversial. No other KDE project seems imposes so high a bar on simple 
string changes.
  
  My problem is that VDG goes way overboard with "user-visible strings". For 
example, we didn't receive any complaints about "Desktop Effects" string. Linux 
community settled on using that term so why do we have change it? Just to show 
"hey we are different!"? Same with the smart placement. I know that it received 
some complaints about the underlying algorithm, but not the name. I'd be happy 
to accept patches from VDG that fix inconsistency in KWin's kcms, e.g. missing 
"...", inconsistent feature names(top-left corner and zero-cornered), etc. If 
you want to rename a feature, please discuss that with us first by creating a 
task or posting to kwin mailing list rather than going the hard way (uploading 
a patch and having very heated discussion).
  
  Another my problem with you VDG, which is unrelated to the change itself, is 
that you act a bit aggressively in code reviews. It's totally fine to have some 
discussion in order to change mind of code reviewers in your favor, but if you 
get "no" many times and the reason why maybe it's time to stop arguing. 
Currently I see VDG as a moving train that crashes everything in front of it.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23415

To: ngraham, #kwin, #vdg, ndavis, filipf, zzag
Cc: davidedmundson, romangg, cfeck, filipf, zzag, ndavis, kwin, 
kde-doc-english, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, gennad, 
fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, 
bwowk, ZrenBot, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

[plasma-desktop] /: Remove phonon KCM

[Nicolas Fella]

Git commit 973306c7bb7df2f9be19c1417484361511a87c67 by Nicolas Fella.
Committed on 28/08/2019 at 10:05.
Pushed by nicolasfella into branch 'master'.

Remove phonon KCM

Summary:
Most of the Phonon KCM settings have been moved to plasma-pa. The remaining 
settings server very specific use cases that are mostl likely not worth 
exposing them front and center.

@sitter said he has a version of the settings to be integtated into phonon so 
the remaining three users can still access them

See T9091

Test Plan: builds

Reviewers: sitter

Reviewed By: sitter

Subscribers: kde-doc-english, ngraham, pino, plasma-devel, sitter

Tags: #plasma, #documentation

Differential Revision: https://phabricator.kde.org/D22616

M  +1-5CMakeLists.txt
M  +0-1doc/kcontrol/CMakeLists.txt
D  +0-2doc/kcontrol/phonon/CMakeLists.txt
D  +0-93   doc/kcontrol/phonon/index.docbook
M  +0-1kcms/CMakeLists.txt
D  +0-27   kcms/phonon/CMakeLists.txt
D  +0-18   kcms/phonon/Messages.sh
D  +0-227  kcms/phonon/backendselection.cpp
D  +0-73   kcms/phonon/backendselection.h
D  +0-232  kcms/phonon/backendselection.ui
D  +0-993  kcms/phonon/devicepreference.cpp
D  +0-95   kcms/phonon/devicepreference.h
D  +0-219  kcms/phonon/devicepreference.ui
D  +0-160  kcms/phonon/kcm_phonon.desktop
D  +---kcms/phonon/listview-background.png
D  +0-84   kcms/phonon/main.cpp
D  +0-48   kcms/phonon/main.h
D  +0-1plasma-desktop.categories

https://commits.kde.org/plasma-desktop/973306c7bb7df2f9be19c1417484361511a87c67

diff --git a/CMakeLists.txt b/CMakeLists.txt
index ebb2a906..2123faba 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -192,9 +192,5 @@ if(X11_Xkb_FOUND AND XCB_XKB_FOUND)
 add_subdirectory(kaccess)
 endif()
 install(FILES org.kde.plasmashell.metainfo.xml DESTINATION 
${KDE_INSTALL_METAINFODIR})
-if (${ECM_VERSION} STRGREATER "5.58.0")
-install(FILES plasma-desktop.categories  DESTINATION  
${KDE_INSTALL_LOGGINGCATEGORIESDIR})
-else()
-install(FILES plasma-desktop.categories  DESTINATION 
${KDE_INSTALL_CONFDIR})
-endif()
+
 feature_summary(WHAT ALL INCLUDE_QUIET_PACKAGES 
FATAL_ON_MISSING_REQUIRED_PACKAGES)
diff --git a/doc/kcontrol/CMakeLists.txt b/doc/kcontrol/CMakeLists.txt
index 793a0c6d..7fbbc9d6 100644
--- a/doc/kcontrol/CMakeLists.txt
+++ b/doc/kcontrol/CMakeLists.txt
@@ -27,6 +27,5 @@ ecm_optional_add_subdirectory(spellchecking)
 ecm_optional_add_subdirectory(componentchooser)
 ecm_optional_add_subdirectory(kded)
 ecm_optional_add_subdirectory(solid-device-automounter)
-ecm_optional_add_subdirectory(phonon)
 ecm_optional_add_subdirectory(workspaceoptions)
 
diff --git a/doc/kcontrol/phonon/CMakeLists.txt 
b/doc/kcontrol/phonon/CMakeLists.txt
deleted file mode 100644
index 5ada3afc..
--- a/doc/kcontrol/phonon/CMakeLists.txt
+++ /dev/null
@@ -1,2 +0,0 @@
-### install files ###
-kdoctools_create_handbook(index.docbook INSTALL_DESTINATION 
${KDE_INSTALL_DOCBUNDLEDIR}/en SUBDIR kcontrol/phonon)
diff --git a/doc/kcontrol/phonon/index.docbook 
b/doc/kcontrol/phonon/index.docbook
deleted file mode 100644
index b6215d96..
--- a/doc/kcontrol/phonon/index.docbook
+++ /dev/null
@@ -1,93 +0,0 @@
-
-
-  
-]>
-
-Audio and Video Settings
-
-
-MatthiasKretz
-
-
-
-2013-12-05
- 4.12
-
-
-KDE
-Systemsettings
-hardware
-multimedia
-sound
-video
-backend
-
-
-
-
-This  module allows you to configure the sound and video device
-preference and the backends used by Phonon.
-
-
-
-Device Preference tab
-
-On the left you are presented a tree list with various categories of playback 
and recording. 
-For each category you may choose what device you wish to use.
-The Audio Playback and Audio 
Recording
-items define the default ordering of devices which can be overridden by 
-each sub items.
-Clicking the Apply Device List To button shows a 
dialog 
-which enables you to copy the selected setting from one category to many 
others.
-Highlight a category and the available devices for this category are 
displayed in the 
-list on the right. The order in this list determines the preference of the 
output and capture 
-devices. If for some reason the first device cannot be used Phonon will try to 
use the second, 
-Use the Prefer and Defer 
buttons to change the order 
-and the Test button to play a test sound on the 
selected device.
-
-
-
-Audio Hardware Setup tab
-
-The various drop down boxes in this tab allow full control over all cards that 
are attached 
-to the system.
-
-
-Hardware
-Select the Sound Card and an available 
-Profile to be used.
-
-
-Device Configuration
-Select the Sound Device and a 
Connector.
-
-
-Speaker Placement and Testing or 
Input Levels
-
-For a playback device: The buttons on this pane allow you to test each 
speaker separately.
-
-For a recording device: A slider shows the Input 
Levels 
-of the selected Connector.
-
-
-
-
-
-
-
-
-
-Backend tab
-
-On the left side of this module a list of Phonon 

D22616: Remove phonon KCM

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:973306c7bb7d: Remove phonon KCM (authored by 
nicolasfella).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22616?vs=64811=64813

REVISION DETAIL
  https://phabricator.kde.org/D22616

AFFECTED FILES
  CMakeLists.txt
  doc/kcontrol/CMakeLists.txt
  doc/kcontrol/phonon/CMakeLists.txt
  doc/kcontrol/phonon/index.docbook
  kcms/CMakeLists.txt
  kcms/phonon/CMakeLists.txt
  kcms/phonon/Messages.sh
  kcms/phonon/backendselection.cpp
  kcms/phonon/backendselection.h
  kcms/phonon/backendselection.ui
  kcms/phonon/devicepreference.cpp
  kcms/phonon/devicepreference.h
  kcms/phonon/devicepreference.ui
  kcms/phonon/kcm_phonon.desktop
  kcms/phonon/listview-background.png
  kcms/phonon/main.cpp
  kcms/phonon/main.h
  plasma-desktop.categories

To: nicolasfella, sitter
Cc: kde-doc-english, ngraham, pino, plasma-devel, sitter, LeGast00n, 
The-Feren-OS-Dev, jraleigh, gennad, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22616: Remove phonon KCM

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  Good to land. Phonon 4.11 replaces this KCM with a new phononsettings 
application, which is a simple port of the KCM to a standalone application.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D22616

REVISION DETAIL
  https://phabricator.kde.org/D22616

To: nicolasfella, sitter
Cc: kde-doc-english, ngraham, pino, plasma-devel, sitter, LeGast00n, 
The-Feren-OS-Dev, jraleigh, gennad, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22616: Remove phonon KCM

[Nicolas Fella]

nicolasfella updated this revision to Diff 64811.
nicolasfella added a comment.
Herald added a project: Documentation.
Herald added a subscriber: kde-doc-english.


  - Remove unused stuff

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22616?vs=62207=64811

BRANCH
  arcpatch-D22616

REVISION DETAIL
  https://phabricator.kde.org/D22616

AFFECTED FILES
  CMakeLists.txt
  doc/kcontrol/CMakeLists.txt
  doc/kcontrol/phonon/CMakeLists.txt
  doc/kcontrol/phonon/index.docbook
  kcms/CMakeLists.txt
  kcms/phonon/CMakeLists.txt
  kcms/phonon/Messages.sh
  kcms/phonon/backendselection.cpp
  kcms/phonon/backendselection.h
  kcms/phonon/backendselection.ui
  kcms/phonon/devicepreference.cpp
  kcms/phonon/devicepreference.h
  kcms/phonon/devicepreference.ui
  kcms/phonon/kcm_phonon.desktop
  kcms/phonon/listview-background.png
  kcms/phonon/main.cpp
  kcms/phonon/main.h
  plasma-desktop.categories

To: nicolasfella, sitter
Cc: kde-doc-english, ngraham, pino, plasma-devel, sitter, LeGast00n, 
The-Feren-OS-Dev, jraleigh, gennad, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart