KF5 Update Meeting 2013-w47 Reminder
Hello all, I forgot (again) to send it yesterday, so just a quick reminder: The next KF5 Update Meeting will happen *today* at *4pm* Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone
On Nov. 12, 2013, 6:11 p.m., Aleix Pol Gonzalez wrote: CMakeLists.txt, line 18 http://git.reviewboard.kde.org/r/113506/diff/5/?file=211419#file211419line18 I don't think we want that, superbuild shouldn't be used after the splitting but the kde build script. We will need it anyway and it will have all the needed information anyway. Aurélien Gâteau wrote: I did this to make it as simple as possible to use superbuild: no need to run cmake again, just use the already available targets. When superbuild is removed it can go away with it so I don't think it is a problem. Aleix Pol Gonzalez wrote: I have 2 kdelibs build directories: one with monolithic and one with superbuild, I don't feel like this is a problem to me. Aurélien Gâteau wrote: Sure it is not, but you made a conscious effort to set it up. Furthermore, not requiring a separate build dir makes like easier for build.kde.org maintainers: they just need to add another target to the make call. Aleix Pol Gonzalez wrote: Well, I'd say that we probably want to have a separate install for both in bko. I have no idea of how hard this is to set up in jenkins, if the goal is to make it possible for build.kde.org to test it, I won't oppose. Having separate install dirs on build.k.o would be ideal, but IIRC it was not easy to get done. I could be wrong though. Anyway, regardless of build.k.o, I think it is worth making it as easy as possible to start a standalone build. Having separate build and install directories is a good practice and should be encouraged but requires more work so people are less likely to set this up, which means they won't proactively check they did not break anything. That is why I want it to be done this way. - Aurélien --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113506/#review43533 --- On Nov. 13, 2013, 2:07 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113506/ --- (Updated Nov. 13, 2013, 2:07 p.m.) Review request for Build System, KDE Frameworks, Alexander Neundorf, and Stephen Kelly. Repository: kdelibs Description --- This patch rework superbuild to integrate it more closely with kdelibs build system: one no longer needs to run cmake path/to/kdelibs/superbuild separately. Instead targets are created for all frameworks declared in superbuild/CMakeLists.txt. For example to build and install ki18n standalone, one can run `make sb_ki18n`. It also adds a special sb_all target, which builds and install all standalone frameworks. Diffs - CMakeLists.txt 879fed4 superbuild/CMakeLists.txt cbe9630 superbuild/README 7a4e52e superbuild/SuperBuild.cmake 33ed151 Diff: http://git.reviewboard.kde.org/r/113506/diff/ Testing --- kdelibs still builds standalone, all sb_* targets work as expected. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113935: Clean up FindOpenEXR.cmake and move to tier1/kguiaddons/cmake
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113935/ --- Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly. Repository: kdelibs Description --- Clean up FindOpenEXR.cmake and move to tier1/kguiaddons/cmake Only kguiaddons uses it for now; it can be moved to ECM later if there is another user. This replaces https://git.reviewboard.kde.org/r/113834/ and https://git.reviewboard.kde.org/r/113828/ Diffs - tier1/kguiaddons/CMakeLists.txt 227718a tier1/kguiaddons/cmake/FindOpenEXR.cmake PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/CMakeLists.txt 6637a16 tier4/kde4support/cmake/modules/CMakeLists.txt 2911e70 tier4/kde4support/cmake/modules/FindOpenEXR.cmake 93b05dd Diff: http://git.reviewboard.kde.org/r/113935/diff/ Testing --- OpenEXR is found, both on an existing build of kdelibs-frameworks and on a clean run of CMake. Still builds and links properly. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113834: Use FindOpenEXR.cmake from ECM
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113834/ --- (Updated Nov. 19, 2013, 10:30 a.m.) Status -- This change has been discarded. Review request for KDE Frameworks. Repository: kdelibs Description --- Use FindOpenEXR.cmake from ECM That version sets the package DESCRIPTION and URL, so we should not. Diffs - tier1/kguiaddons/src/plugins/imageformats/CMakeLists.txt 6f02b71 tier4/kde4support/cmake/modules/CMakeLists.txt 6e7443c tier4/kde4support/cmake/modules/FindOpenEXR.cmake 93b05dd Diff: http://git.reviewboard.kde.org/r/113834/diff/ Testing --- Builds. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone
On Nov. 12, 2013, 5:11 p.m., Aleix Pol Gonzalez wrote: CMakeLists.txt, line 18 http://git.reviewboard.kde.org/r/113506/diff/5/?file=211419#file211419line18 I don't think we want that, superbuild shouldn't be used after the splitting but the kde build script. We will need it anyway and it will have all the needed information anyway. Aurélien Gâteau wrote: I did this to make it as simple as possible to use superbuild: no need to run cmake again, just use the already available targets. When superbuild is removed it can go away with it so I don't think it is a problem. Aleix Pol Gonzalez wrote: I have 2 kdelibs build directories: one with monolithic and one with superbuild, I don't feel like this is a problem to me. Aurélien Gâteau wrote: Sure it is not, but you made a conscious effort to set it up. Furthermore, not requiring a separate build dir makes like easier for build.kde.org maintainers: they just need to add another target to the make call. Aleix Pol Gonzalez wrote: Well, I'd say that we probably want to have a separate install for both in bko. I have no idea of how hard this is to set up in jenkins, if the goal is to make it possible for build.kde.org to test it, I won't oppose. Aurélien Gâteau wrote: Having separate install dirs on build.k.o would be ideal, but IIRC it was not easy to get done. I could be wrong though. Anyway, regardless of build.k.o, I think it is worth making it as easy as possible to start a standalone build. Having separate build and install directories is a good practice and should be encouraged but requires more work so people are less likely to set this up, which means they won't proactively check they did not break anything. That is why I want it to be done this way. Unfortunately the way build.kde.org has been constructed means having a separate build is a little difficult. The only way I can see would be to change kdelibs_frameworks_qt5 to be a Multi-Configuration Job, and then use separate variations to build the normal and superbuild variants. However, the deployment of one of these would ultimately have to be suppressed - as both would be targeting the same final install location. We would be able to simulate make install without issue however. - Ben --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113506/#review43533 --- On Nov. 13, 2013, 1:07 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113506/ --- (Updated Nov. 13, 2013, 1:07 p.m.) Review request for Build System, KDE Frameworks, Alexander Neundorf, and Stephen Kelly. Repository: kdelibs Description --- This patch rework superbuild to integrate it more closely with kdelibs build system: one no longer needs to run cmake path/to/kdelibs/superbuild separately. Instead targets are created for all frameworks declared in superbuild/CMakeLists.txt. For example to build and install ki18n standalone, one can run `make sb_ki18n`. It also adds a special sb_all target, which builds and install all standalone frameworks. Diffs - CMakeLists.txt 879fed4 superbuild/CMakeLists.txt cbe9630 superbuild/README 7a4e52e superbuild/SuperBuild.cmake 33ed151 Diff: http://git.reviewboard.kde.org/r/113506/diff/ Testing --- kdelibs still builds standalone, all sb_* targets work as expected. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113935: Clean up FindOpenEXR.cmake and move to tier1/kguiaddons/cmake
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113935/#review43932 --- tier1/kguiaddons/cmake/FindOpenEXR.cmake http://git.reviewboard.kde.org/r/113935/#comment31548 Please use ExactCase instead. As this is used internally only, no need to set the uppercase versions for compatibility. tier1/kguiaddons/cmake/FindOpenEXR.cmake http://git.reviewboard.kde.org/r/113935/#comment31549 The API is the _DIRS variable. Keep setting the _DIR variable as-is, but add it to a _DIRS variable afterward. - Stephen Kelly On Nov. 19, 2013, 10:29 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113935/ --- (Updated Nov. 19, 2013, 10:29 a.m.) Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly. Repository: kdelibs Description --- Clean up FindOpenEXR.cmake and move to tier1/kguiaddons/cmake Only kguiaddons uses it for now; it can be moved to ECM later if there is another user. This replaces https://git.reviewboard.kde.org/r/113834/ and https://git.reviewboard.kde.org/r/113828/ Diffs - tier1/kguiaddons/CMakeLists.txt 227718a tier1/kguiaddons/cmake/FindOpenEXR.cmake PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/CMakeLists.txt 6637a16 tier4/kde4support/cmake/modules/CMakeLists.txt 2911e70 tier4/kde4support/cmake/modules/FindOpenEXR.cmake 93b05dd Diff: http://git.reviewboard.kde.org/r/113935/diff/ Testing --- OpenEXR is found, both on an existing build of kdelibs-frameworks and on a clean run of CMake. Still builds and links properly. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: error: KF5::KDBusAddons-NOTFOUND
On Monday, November 18, 2013 19:00:33 Sebastian Kügler wrote: On Monday, November 18, 2013 17:53:07 Aleix Pol wrote: On Mon, Nov 18, 2013 at 5:43 PM, Sebastian Kügler se...@kde.org wrote: It seems subject broke over the weekend. kactivities fails to compile: c++: error: KF5::KDBusAddons-NOTFOUND: No such file or directory kactivities uses: find_package (KF5 CONFIG REQUIRED KDBusAddons) so it's pretty bare-bones. Could someone have a look or suggest a fix? There's no warning or error in cmake configuration time? You can trigger it with make rebuild_cache There's no warning, it even suggests that KDBusAddons has been found. So this doesn't only affect KDBusAddons, but also KConfigCore (and in another repository, KDE4Support), they're all broken for me, I can't build anything against them. c++: error: KF5::KConfigCore-NOTFOUND: No such file or directory c++: error: KF5::KDBusAddons-NOTFOUND: No such file or directory Note that also the QDBusVariant include fails, so the include directories are also not set correctly through the find_package(...) calls. This is all on a clean build/install, I've updated cmake to latest master, no dice, to the release branch, also no dice. Any ideas? I think the changes have been introduced last Saturday with Steveire's cmake cleanups in kdelibs. Here's how the build fails: Linking CXX shared library activitymanager_plugin_activitytemplates.so c++: error: KF5::KConfigCore-NOTFOUND: No such file or directory c++: error: KF5::KDBusAddons-NOTFOUND: No such file or directory make[2]: *** [src/service/plugins/activitytemplates/activitymanager_plugin_activitytemplates.so] Error 1 make[1]: *** [src/service/plugins/activitytemplates/CMakeFiles/activitymanager_plugin_activitytemplates.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs [ 32%] Building CXX object src/service/plugins/sqlite/CMakeFiles/activitymanager_plugin_sqlite.dir/ResourceScoreCache.cpp.o In file included from /home/sebas/kf5/src/kactivities/src/service/plugins/sqlite/../../Plugin.h:38:0, from /home/sebas/kf5/src/kactivities/src/service/plugins/sqlite/StatsPlugin.h:28, from /home/sebas/kf5/src/kactivities/src/service/plugins/sqlite/StatsPlugin.cpp:22: /home/sebas/kf5/src/kactivities/src/service/plugins/sqlite/../../Module.h:27:24: fatal error: QDBusVariant: No such file or directory compilation terminated. make[2]: *** [src/service/plugins/sqlite/CMakeFiles/activitymanager_plugin_sqlite.dir/StatsPlugin.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs In file included from /home/sebas/kf5/src/kactivities/src/service/plugins/sqlite/../../Plugin.h:38:0, from /home/sebas/kf5/src/kactivities/src/service/plugins/sqlite/StatsPlugin.h:28, from /home/sebas/kf5/src/kactivities/src/service/plugins/sqlite/ResourceScoreCache.cpp:29: /home/sebas/kf5/src/kactivities/src/service/plugins/sqlite/../../Module.h:27:24: fatal error: QDBusVariant: No such file or directory compilation terminated. make[2]: *** [src/service/plugins/sqlite/CMakeFiles/activitymanager_plugin_sqlite.dir/ResourceScoreCache.cpp.o] Error 1 make[1]: *** [src/service/plugins/sqlite/CMakeFiles/activitymanager_plugin_sqlite.dir/all] Error 2 Linking CXX shared library activitymanager_plugin_slc.so c++: error: KF5::KConfigCore-NOTFOUND: No such file or directory c++: error: KF5::KDBusAddons-NOTFOUND: No such file or directory make[2]: *** [src/service/plugins/slc/activitymanager_plugin_slc.so] Error 1 make[1]: *** [src/service/plugins/slc/CMakeFiles/activitymanager_plugin_slc.dir/all] Error 2 Ideas how to solve this would be highly appreciated. I'm out of ideas. :/ Thanks, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113937: Remove dependency from kio on kinit
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113937/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Turn http_cache_cleaner into a plain executable kinit depends on kio, so kio should not use kdeinit. Diffs - superbuild/CMakeLists.txt 7368ad3 tier3/kio/CMakeLists.txt 7a3529e tier3/kio/src/ioslaves/http/CMakeLists.txt 0d96020 tier3/kio/src/ioslaves/http/http_cache_cleaner.cpp cd1815c Diff: http://git.reviewboard.kde.org/r/113937/diff/ Testing --- Still builds, http_cache_cleaner runs as before. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: error: KF5::KDBusAddons-NOTFOUND
I can't reproduce the problem. Sebastian Kügler wrote: Ideas how to solve this would be highly appreciated. I'm out of ideas. :/ Try to construct a trivial testcase using one of the targets. If that fails, post it. If it passes, bisect the difference to kactivities. Thanks, Steve. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113935: Clean up FindOpenEXR.cmake and move to tier1/kguiaddons/cmake
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113935/ --- (Updated Nov. 19, 2013, 1:41 p.m.) Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly. Changes --- Use ExactCase and set a _DIRS variable. Repository: kdelibs Description --- Clean up FindOpenEXR.cmake and move to tier1/kguiaddons/cmake Only kguiaddons uses it for now; it can be moved to ECM later if there is another user. This replaces https://git.reviewboard.kde.org/r/113834/ and https://git.reviewboard.kde.org/r/113828/ Diffs (updated) - tier1/kguiaddons/CMakeLists.txt 227718a383ba8598fcfb24549f9dd2a6a3547a8a tier1/kguiaddons/cmake/FindOpenEXR.cmake PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/CMakeLists.txt 6637a16711d21c2a180914ad2530e3ac85b14a22 tier4/kde4support/cmake/modules/CMakeLists.txt 2911e70f3dd253ab552bfd228a25b3ae38452218 tier4/kde4support/cmake/modules/FindOpenEXR.cmake 93b05dd999c12605973c1a0a2020a72aece88b65 Diff: http://git.reviewboard.kde.org/r/113935/diff/ Testing --- OpenEXR is found, both on an existing build of kdelibs-frameworks and on a clean run of CMake. Still builds and links properly. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113935: Clean up FindOpenEXR.cmake and move to tier1/kguiaddons/cmake
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113935/#review43939 --- tier1/kguiaddons/cmake/FindOpenEXR.cmake http://git.reviewboard.kde.org/r/113935/#comment31556 Unfortunately you have to set the FOUND_VAR explicitly. http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/6103/focus=6143 - Stephen Kelly On Nov. 19, 2013, 1:41 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113935/ --- (Updated Nov. 19, 2013, 1:41 p.m.) Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly. Repository: kdelibs Description --- Clean up FindOpenEXR.cmake and move to tier1/kguiaddons/cmake Only kguiaddons uses it for now; it can be moved to ECM later if there is another user. This replaces https://git.reviewboard.kde.org/r/113834/ and https://git.reviewboard.kde.org/r/113828/ Diffs - tier1/kguiaddons/CMakeLists.txt 227718a383ba8598fcfb24549f9dd2a6a3547a8a tier1/kguiaddons/cmake/FindOpenEXR.cmake PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/CMakeLists.txt 6637a16711d21c2a180914ad2530e3ac85b14a22 tier4/kde4support/cmake/modules/CMakeLists.txt 2911e70f3dd253ab552bfd228a25b3ae38452218 tier4/kde4support/cmake/modules/FindOpenEXR.cmake 93b05dd999c12605973c1a0a2020a72aece88b65 Diff: http://git.reviewboard.kde.org/r/113935/diff/ Testing --- OpenEXR is found, both on an existing build of kdelibs-frameworks and on a clean run of CMake. Still builds and links properly. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113935: Clean up FindOpenEXR.cmake and move to tier1/kguiaddons/cmake
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113935/ --- (Updated Nov. 19, 2013, 2:17 p.m.) Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly. Changes --- Set OpenEXR_Found properly. Repository: kdelibs Description --- Clean up FindOpenEXR.cmake and move to tier1/kguiaddons/cmake Only kguiaddons uses it for now; it can be moved to ECM later if there is another user. This replaces https://git.reviewboard.kde.org/r/113834/ and https://git.reviewboard.kde.org/r/113828/ Diffs (updated) - tier1/kguiaddons/cmake/FindOpenEXR.cmake PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/CMakeLists.txt 6637a16711d21c2a180914ad2530e3ac85b14a22 tier4/kde4support/cmake/modules/CMakeLists.txt 2911e70f3dd253ab552bfd228a25b3ae38452218 tier4/kde4support/cmake/modules/FindOpenEXR.cmake 93b05dd999c12605973c1a0a2020a72aece88b65 tier1/kguiaddons/CMakeLists.txt 227718a383ba8598fcfb24549f9dd2a6a3547a8a Diff: http://git.reviewboard.kde.org/r/113935/diff/ Testing --- OpenEXR is found, both on an existing build of kdelibs-frameworks and on a clean run of CMake. Still builds and links properly. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113935: Clean up FindOpenEXR.cmake and move to tier1/kguiaddons/cmake
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113935/#review43942 --- tier1/kguiaddons/cmake/FindOpenEXR.cmake http://git.reviewboard.kde.org/r/113935/#comment31558 Instead of this, please use what cmake --help-module FindPackageHandleStandardArgs calls mode 2. - Stephen Kelly On Nov. 19, 2013, 2:17 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113935/ --- (Updated Nov. 19, 2013, 2:17 p.m.) Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly. Repository: kdelibs Description --- Clean up FindOpenEXR.cmake and move to tier1/kguiaddons/cmake Only kguiaddons uses it for now; it can be moved to ECM later if there is another user. This replaces https://git.reviewboard.kde.org/r/113834/ and https://git.reviewboard.kde.org/r/113828/ Diffs - tier1/kguiaddons/cmake/FindOpenEXR.cmake PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/CMakeLists.txt 6637a16711d21c2a180914ad2530e3ac85b14a22 tier4/kde4support/cmake/modules/CMakeLists.txt 2911e70f3dd253ab552bfd228a25b3ae38452218 tier4/kde4support/cmake/modules/FindOpenEXR.cmake 93b05dd999c12605973c1a0a2020a72aece88b65 tier1/kguiaddons/CMakeLists.txt 227718a383ba8598fcfb24549f9dd2a6a3547a8a Diff: http://git.reviewboard.kde.org/r/113935/diff/ Testing --- OpenEXR is found, both on an existing build of kdelibs-frameworks and on a clean run of CMake. Still builds and links properly. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113935: Clean up FindOpenEXR.cmake and move to tier1/kguiaddons/cmake
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113935/ --- (Updated Nov. 19, 2013, 3:27 p.m.) Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly. Changes --- Use mode 2 form of find_package_handle_standard_args. Also throw in a version check, in case we start depending on a particular version. Repository: kdelibs Description --- Clean up FindOpenEXR.cmake and move to tier1/kguiaddons/cmake Only kguiaddons uses it for now; it can be moved to ECM later if there is another user. This replaces https://git.reviewboard.kde.org/r/113834/ and https://git.reviewboard.kde.org/r/113828/ Diffs (updated) - tier1/kguiaddons/CMakeLists.txt 227718a383ba8598fcfb24549f9dd2a6a3547a8a tier1/kguiaddons/cmake/FindOpenEXR.cmake PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/CMakeLists.txt 6637a16711d21c2a180914ad2530e3ac85b14a22 tier4/kde4support/cmake/modules/CMakeLists.txt 2911e70f3dd253ab552bfd228a25b3ae38452218 tier4/kde4support/cmake/modules/FindOpenEXR.cmake 93b05dd999c12605973c1a0a2020a72aece88b65 Diff: http://git.reviewboard.kde.org/r/113935/diff/ Testing --- OpenEXR is found, both on an existing build of kdelibs-frameworks and on a clean run of CMake. Still builds and links properly. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113935: Clean up FindOpenEXR.cmake and move to tier1/kguiaddons/cmake
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113935/#review43945 --- Ship it! Ship It! - Stephen Kelly On Nov. 19, 2013, 3:27 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113935/ --- (Updated Nov. 19, 2013, 3:27 p.m.) Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly. Repository: kdelibs Description --- Clean up FindOpenEXR.cmake and move to tier1/kguiaddons/cmake Only kguiaddons uses it for now; it can be moved to ECM later if there is another user. This replaces https://git.reviewboard.kde.org/r/113834/ and https://git.reviewboard.kde.org/r/113828/ Diffs - tier1/kguiaddons/CMakeLists.txt 227718a383ba8598fcfb24549f9dd2a6a3547a8a tier1/kguiaddons/cmake/FindOpenEXR.cmake PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/CMakeLists.txt 6637a16711d21c2a180914ad2530e3ac85b14a22 tier4/kde4support/cmake/modules/CMakeLists.txt 2911e70f3dd253ab552bfd228a25b3ae38452218 tier4/kde4support/cmake/modules/FindOpenEXR.cmake 93b05dd999c12605973c1a0a2020a72aece88b65 Diff: http://git.reviewboard.kde.org/r/113935/diff/ Testing --- OpenEXR is found, both on an existing build of kdelibs-frameworks and on a clean run of CMake. Still builds and links properly. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: error: KF5::KDBusAddons-NOTFOUND
On Tuesday, November 19, 2013 15:42:47 Sebastian Kügler wrote: On Tuesday, November 19, 2013 12:48:53 Stephen Kelly wrote: Try to construct a trivial testcase using one of the targets. If that fails, post it. If it passes, bisect the difference to kactivities. I've attached a bare example, that also fails here, with error from $subject. I've found the problem leading to this. When I run cmake / make / make install from the top-level kdelibs directory, the -relwithdebinfo.cmake Target files are not installed. When I re-run make install from, for example within tier2/ki18n, the KI18nTargets-relwithdebinfo.cmake gets installed, and is subsequently found. Same for KDBusAddons, and all other frameworks, as far as I can tell. When re-running make install, I get this file (for example) installed, which is what I seemed to be missing. /home/sebas/kf5/install/lib64/cmake/KI18n/KI18nTargets-relwithdebinfo.cmake Any idea how this can happen? -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113935: Clean up FindOpenEXR.cmake and move to tier1/kguiaddons/cmake
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113935/#review43947 --- This review has been submitted with commit 00f89cb65f9cc7174d1645fb9c7661fc3d6ec68c by Alex Merry to branch frameworks. - Commit Hook On Nov. 19, 2013, 3:27 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113935/ --- (Updated Nov. 19, 2013, 3:27 p.m.) Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly. Repository: kdelibs Description --- Clean up FindOpenEXR.cmake and move to tier1/kguiaddons/cmake Only kguiaddons uses it for now; it can be moved to ECM later if there is another user. This replaces https://git.reviewboard.kde.org/r/113834/ and https://git.reviewboard.kde.org/r/113828/ Diffs - tier1/kguiaddons/CMakeLists.txt 227718a383ba8598fcfb24549f9dd2a6a3547a8a tier1/kguiaddons/cmake/FindOpenEXR.cmake PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/CMakeLists.txt 6637a16711d21c2a180914ad2530e3ac85b14a22 tier4/kde4support/cmake/modules/CMakeLists.txt 2911e70f3dd253ab552bfd228a25b3ae38452218 tier4/kde4support/cmake/modules/FindOpenEXR.cmake 93b05dd999c12605973c1a0a2020a72aece88b65 Diff: http://git.reviewboard.kde.org/r/113935/diff/ Testing --- OpenEXR is found, both on an existing build of kdelibs-frameworks and on a clean run of CMake. Still builds and links properly. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113935: Clean up FindOpenEXR.cmake and move to tier1/kguiaddons/cmake
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113935/ --- (Updated Nov. 19, 2013, 3:45 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly. Repository: kdelibs Description --- Clean up FindOpenEXR.cmake and move to tier1/kguiaddons/cmake Only kguiaddons uses it for now; it can be moved to ECM later if there is another user. This replaces https://git.reviewboard.kde.org/r/113834/ and https://git.reviewboard.kde.org/r/113828/ Diffs - tier1/kguiaddons/CMakeLists.txt 227718a383ba8598fcfb24549f9dd2a6a3547a8a tier1/kguiaddons/cmake/FindOpenEXR.cmake PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/CMakeLists.txt 6637a16711d21c2a180914ad2530e3ac85b14a22 tier4/kde4support/cmake/modules/CMakeLists.txt 2911e70f3dd253ab552bfd228a25b3ae38452218 tier4/kde4support/cmake/modules/FindOpenEXR.cmake 93b05dd999c12605973c1a0a2020a72aece88b65 Diff: http://git.reviewboard.kde.org/r/113935/diff/ Testing --- OpenEXR is found, both on an existing build of kdelibs-frameworks and on a clean run of CMake. Still builds and links properly. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KF5 Update Meeting Minutes 2013-w47
Hello everyone, This is the minutes of the Week 47 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, apol, jpwhiting, mgraesslin, randomguy3, sebas, teo and myself. Announcement: * We're not yet ready for the splitting so it's postponed by a week; * Please get open tasks done; * agateau fixed kauth-policy-gen which was breaking kde-workspace; * he's working on fixing kio standalone build (reviews posted); * he's blocked on desktoptojson, he got an ugly suggestion on cmake-user but kde-buildsystem didn't get back to him; * he consider merging his superbuild changes which are still pending; * dfaure has been chasing a bug in Qt which affects KIO; * jpwhiting moved kspeech to staging and will look into finding its final place; * mgraesslin merged kcolorschememanager; * he also included the netwm port to xcb; * he would need a prompt review on http://pastebin.kde.org/pjyjpm9on ; * he also waits on a crasher fix https://git.reviewboard.kde.org/r/113877/ ; * randomguy3 got kmediaplayer ready (it is in staging, soon tier3); * he's also working on KDBusService; * Riddell is done for the coinstallability; * he completed the list for the new runtime organization; * he needs feedback on all that; * sebas is working on plasma applets in the panel (calendar, clock, systray); * he's also trying to get his build back on track; * teo is still working on ksmserver, it starts and run kwin successfully now; * he's also fixing the commandline parsing; * afiestas is working on powerdevil to restore its functionalities; * he also plans to look in kded bugs; * apol has been looking into making porting away from kde4support easier; * he also worked a bit on the standalone builds effort; * he almost removed all plasma-framework dependencies on kde4support; * ervin reviewed a bit, mostly got busy with the pim sprint. If you got questions, feel free to ask. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: error: KF5::KDBusAddons-NOTFOUND
On Tue, Nov 19, 2013 at 4:32 PM, Sebastian Kügler se...@kde.org wrote: On Tuesday, November 19, 2013 15:42:47 Sebastian Kügler wrote: On Tuesday, November 19, 2013 12:48:53 Stephen Kelly wrote: Try to construct a trivial testcase using one of the targets. If that fails, post it. If it passes, bisect the difference to kactivities. I've attached a bare example, that also fails here, with error from $subject. I've found the problem leading to this. When I run cmake / make / make install from the top-level kdelibs directory, the -relwithdebinfo.cmake Target files are not installed. When I re-run make install from, for example within tier2/ki18n, the KI18nTargets-relwithdebinfo.cmake gets installed, and is subsequently found. Same for KDBusAddons, and all other frameworks, as far as I can tell. When re-running make install, I get this file (for example) installed, which is what I seemed to be missing. /home/sebas/kf5/install/lib64/cmake/KI18n/KI18nTargets-relwithdebinfo.cmake Any idea how this can happen? -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel Maybe you have different CMAKE_BUILD_TYPE in kdelibs and other build directories? Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113830: Allow unique apps to access command-line arguments of later invocations
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113830/ --- (Updated Nov. 19, 2013, 4:10 p.m.) Review request for KDE Frameworks and David Faure. Changes --- Fix typo in apidocs. Repository: kdelibs Description --- Allow unique apps to access command-line arguments of later invocations Diffs (updated) - tier1/kdbusaddons/autotests/kdbusservicetest.cpp 5eecb5e834bddc177539f5eedb51a77a276d7899 tier1/kdbusaddons/src/CMakeLists.txt 0509015afd2d24d34f85a7d6fd786092820814bf tier1/kdbusaddons/src/kdbusservice.h bf79e227209510246d0ec5ff1d5277e6083c4a1a tier1/kdbusaddons/src/kdbusservice.cpp b773c80b30c6ee39d6d8b4d8c962b83dbd87f7d4 tier1/kdbusaddons/src/org.freedesktop.Application.xml 16934e24ca99da68222be9f728239b1fb0786f72 tier1/kdbusaddons/src/org.kde.KDBusService.xml PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113830/diff/ Testing --- Builds, test passes. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113883: Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview5
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113883/ --- (Updated Nov. 19, 2013, 4:12 p.m.) Review request for KDE Frameworks. Summary (updated) - Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview5 Repository: kdelibs Description --- Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview Diffs - staging/kmediaplayer/src/kfileaudiopreview/Messages.sh 71c7067 staging/kmediaplayer/src/kfileaudiopreview/kfileaudiopreview.cpp 04efb24 staging/kmediaplayer/src/kfileaudiopreview/mediacontrols_p.h bb36ab1 Diff: http://git.reviewboard.kde.org/r/113883/diff/ Testing --- Builds. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: error: KF5::KDBusAddons-NOTFOUND
On Tuesday, November 19, 2013 17:01:32 Aleix Pol wrote:
Maybe you have different CMAKE_BUILD_TYPE in kdelibs and other build
directories?
I'm using the same command for them all:
cmake -DCMAKE_INSTALL_PREFIX=$KF5 -DCMAKE_PREFIX_PATH=$KF5 -
DCMAKE_SYSTEM_PREFIX_PATH=/usr:/usr/local:${KF5} -
DCMAKE_MODULE_PATH=$KF5/share/cmake/modules .. $srcFolder make -j${CPUS}
make install
Maybe while splitting cmake files, some arguments are lost in the individual
tiers?
--
sebas
http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF5 Update Meeting Minutes 2013-w47
On 19 November 2013 16:53, Kevin Ottens er...@kde.org wrote: Announcement: * We're not yet ready for the splitting so it's postponed by a week; * Please get open tasks done; At the PIM Sprint Alex passed the byte formatting TODO on to me which I've started coding, I'll try push a review in a couple of days: * New class KFormat will be added to KCoreAddons * Will use tr() rather than i18n(), which is proving the hard part * Will ignore any user settings, only formats as requested via api * Will have static methods for formatByteSize(), formatDecimalDuration(), formatSpelloutDuration() and formatRelativeDate() I'm still figuring out the tr() part and loading of catalogues and the rest, especially for static methods. As this doesn't involve moving any code (the old methods stay in KLocale in kde4support), and nothing else in Frameworks calls these methods, then in theory this shouldn't block the split from happening, but I'll try get it in before then. Cheers! John. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113949: Workaround for dependency issues when generating .json from .desktop files
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113949/ --- Review request for KDE Frameworks and Sebastian Kügler. Repository: kdelibs Description --- There is currently no way to declare a target as a dependency of the automoc target, so it is not possible to ensure .json files are generated from .desktop files before moc is run. To work around this, generate .json files at configure time. This is a workaround because it means changes to .desktop files won't be applied to .json files when building, one will need to re-run cmake. This changes adds a test to ensure the CMake macro works well. It is declared as an external project because it needs desktoptojson to be installed to work correctly. Diffs - tier3/kservice/KServiceMacros.cmake d5b30ce tier3/kservice/src/desktoptojson/CMakeLists.txt 9dc8635 tier3/kservice/tests/kservicetojsontest/CMakeLists.txt PRE-CREATION tier3/kservice/tests/kservicetojsontest/README PRE-CREATION tier3/kservice/tests/kservicetojsontest/dummy-service.desktop PRE-CREATION tier3/kservice/tests/kservicetojsontest/dummyplugin.h PRE-CREATION tier3/kservice/tests/kservicetojsontest/dummyplugin.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113949/diff/ Testing --- kdelibs still builds, repositories such as kde-runtime and kde-workspace build as well. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
cmake-2.12.1 + kde*-4.12
I have cmake-2.12.1 installed and use to build frameworks. When I use it to build kde*-4.12 I get lots of warnings of the type: -- Configuring done CMake Warning (dev) in kdecore/CMakeLists.txt: Policy CMP0022 is not set: INTERFACE_LINK_LIBRARIES defines the link interface. Run cmake --help-policy CMP0022 for policy details. Use the cmake_policy command to set the policy and suppress this warning. Target kdecore has an INTERFACE_LINK_LIBRARIES property which differs from its LINK_INTERFACE_LIBRARIES properties. INTERFACE_LINK_LIBRARIES: Qt4::QtCore;- lpthread;Qt4::QtNetwork;Qt4::QtDBus;Qt4::QtXml;/usr/lib/libz.so;/usr/lib/libbz2.so;/usr/lib/liblzma.so;resolv;- lpthread;/usr/lib/libfam.so;Qt4::QtDBus;Qt4::QtCore;-lpthread LINK_INTERFACE_LIBRARIES: Qt4::QtDBus;Qt4::QtCore;-lpthread This warning is for project developers. Use -Wno-dev to suppress it. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
