Re: Review Request 114336: Install all includes in a KF5 dir
Le lundi 9 décembre 2013 21:56:52 Stephen Kelly a écrit :
Aurélien Gâteau wrote:
target_include_directories(${library} INTERFACE
$INSTALL_INTERFACE:
${CMAKE_INSTALL_PREFIX}/${${library}_INCLUDE_INSTALL_DIR}
)
Note that this makes the resulting package non-relocatable. If using CMake
3.0.0, you can specify a relative path here. With 2.8.12, you should use
$INSTALL_PREFIX instead of ${CMAKE_INSTALL_PREFIX} so that the relative
path stays relative.
Good to know, I must admit I cargo-culted the if(IS_ABSOLUTE) snippet from
existing code (for example tier1/kwidgetaddons/src/CMakeLists.txt uses it).
Since we are tied to CMake 2.8.12, the macro would be:
macro ecm_library_set_include_prefix(library include_prefix)
set(${library}_INCLUDE_INSTALL_DIR ${INCLUDE_INSTALL_DIR}/${include_prefix})
if(IS_ABSOLUTE ${INCLUDE_INSTALL_DIR})
target_include_directories(${library} INTERFACE
$INSTALL_INTERFACE:${${library}_INCLUDE_INSTALL_DIR}
)
else()
target_include_directories(${library} INTERFACE
$INSTALL_INTERFACE:
$INSTALL_PREFIX/${${library}_INCLUDE_INSTALL_DIR}
)
endif()
endmacro()
Is this correct? Also, do you think adding such a macro to ECM is a good idea?
Aurélien
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Installing headers in include/KF5, how to?
Le lundi 9 décembre 2013 21:59:58 Stephen Kelly a écrit :
Aurélien Gâteau wrote:
+set(INCLUDE_INSTALL_DIR ${INCLUDE_INSTALL_DIR}/KF5)
Don't you instead want to install to ${INCLUDE_INSTALL_DIR}/KF5/$Name ?
Not for all frameworks. For frameworks where all headers are prefixed with
'k', we agreed on installing headers in include/KF5, wheras for framewors
without 'k' prefixes, headers should go in include/KF5/$Name
What does _set_fancy do? Should it be removed? INCLUDE_INSTALL_DIR is set by
_set_fancy in ecm.
I don't really understand the intricacies of cache handling in _set_fancy(),
so I don't know. You know CMake better than me, you tell me :)
Aurélien
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114336: Install all includes in a KF5 dir
Aurélien Gâteau wrote:
Le lundi 9 décembre 2013 21:56:52 Stephen Kelly a écrit :
Aurélien Gâteau wrote:
target_include_directories(${library} INTERFACE
$INSTALL_INTERFACE:
${CMAKE_INSTALL_PREFIX}/${${library}_INCLUDE_INSTALL_DIR}
)
Note that this makes the resulting package non-relocatable. If using
CMake 3.0.0, you can specify a relative path here. With 2.8.12, you
should use $INSTALL_PREFIX instead of ${CMAKE_INSTALL_PREFIX} so that
the relative path stays relative.
Good to know, I must admit I cargo-culted the if(IS_ABSOLUTE) snippet from
existing code (for example tier1/kwidgetaddons/src/CMakeLists.txt uses
it).
:/
Ill-advised code propagates from cargo-culting. It is a bad idea. If you
don't understand, ask. ECM also has another problem I was trying to help mck
see on IRC. He started with what he thought was the solution and didn't
understand the problem at hand. I filed
http://public.kitware.com/Bug/view.php?id=14634
and I agree with Kent. I'm not sure it remains an issue after the split, but
it might be.
Since we are tied to CMake 2.8.12, the macro would be:
macro ecm_library_set_include_prefix(library include_prefix)
set(${library}_INCLUDE_INSTALL_DIR
${INCLUDE_INSTALL_DIR}/${include_prefix})
if(IS_ABSOLUTE ${INCLUDE_INSTALL_DIR})
target_include_directories(${library} INTERFACE
$INSTALL_INTERFACE:${${library}_INCLUDE_INSTALL_DIR}
)
else()
target_include_directories(${library} INTERFACE
$INSTALL_INTERFACE:
$INSTALL_PREFIX/${${library}_INCLUDE_INSTALL_DIR}
)
endif()
endmacro()
Is this correct?
What about the name? You specify that when invoking the macro?
The target_include_directories parts of your macro (ie most of it) are
obsoleted by
diff --git a/kde-modules/KDEInstallDirs.cmake b/kde-
modules/KDEInstallDirs.cmake
index d94adcf..126185b 100644
--- a/kde-modules/KDEInstallDirs.cmake
+++ b/kde-modules/KDEInstallDirs.cmake
@@ -174,7 +174,7 @@ _set_fancy(DBUS_SYSTEM_SERVICES_INSTALL_DIR
${SHARE_INSTALL_PREFIX}/dbus-1/syst
set(INSTALL_TARGETS_DEFAULT_ARGS RUNTIME DESTINATION ${BIN_INSTALL_DIR}
LIBRARY DESTINATION ${LIB_INSTALL_DIR}
ARCHIVE DESTINATION ${LIB_INSTALL_DIR}
COMPONENT Devel
- INCLUDES DESTINATION
${INCLUDE_INSTALL_DIR}
+ INCLUDES DESTINATION
${INCLUDE_INSTALL_DIR}/KF5/$TARGET_PROPERTY:NAME
)
when CMake 3.0.0 is depended on.
Thanks,
Steve.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 114377: Refresh apidox README
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114377/ --- Review request for KDE Frameworks, Adriaan de Groot and Allen Winter. Repository: kdelibs Description --- This patch refreshes apidox README, turning it into a Markdown file. It also updates `doxygen.sh --help` output: some options were documented in the README but not in the script itself, so I centralized all of this in the script. Diffs - tier4/apidox/README.md PRE-CREATION tier4/apidox/common/README.Doxygen 3c46a51 tier4/apidox/src/doxygen.sh 659180f Diff: http://git.reviewboard.kde.org/r/114377/diff/ Testing --- `doxygen.sh --help` is now more comprehensive :) Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Installing headers in include/KF5, how to?
Aurélien Gâteau wrote:
Le lundi 9 décembre 2013 21:59:58 Stephen Kelly a écrit :
Aurélien Gâteau wrote:
+set(INCLUDE_INSTALL_DIR ${INCLUDE_INSTALL_DIR}/KF5)
Don't you instead want to install to ${INCLUDE_INSTALL_DIR}/KF5/$Name ?
Not for all frameworks. For frameworks where all headers are prefixed with
'k', we agreed on installing headers in include/KF5, wheras for framewors
without 'k' prefixes, headers should go in include/KF5/$Name
In that case, the INCLUDES DESTINATION line in ECM should possibly be
removed, or a 'smart' macro wrapping install(TARGETS) should be added
instead of the (still overly-generically-named)
INSTALL_TARGETS_DEFAULT_ARGS.
What does _set_fancy do? Should it be removed? INCLUDE_INSTALL_DIR is set
by _set_fancy in ecm.
I don't really understand the intricacies of cache handling in
_set_fancy(), so I don't know. You know CMake better than me, you tell me
:)
I think it should be removed. It was added a long time ago for Volker, and
as far as I know, is not needed anymore. Alex doesn't want to remove it.
Thanks,
Steve.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114336: Install all includes in a KF5 dir
Le mardi 10 décembre 2013 10:02:18 Stephen Kelly a écrit :
Aurélien Gâteau wrote:
Le lundi 9 décembre 2013 21:56:52 Stephen Kelly a écrit :
Aurélien Gâteau wrote:
target_include_directories(${library} INTERFACE
$INSTALL_INTERFACE:
${CMAKE_INSTALL_PREFIX}/${${library}_INCLUDE_INSTALL_DIR}
)
Note that this makes the resulting package non-relocatable. If using
CMake 3.0.0, you can specify a relative path here. With 2.8.12, you
should use $INSTALL_PREFIX instead of ${CMAKE_INSTALL_PREFIX} so that
the relative path stays relative.
Good to know, I must admit I cargo-culted the if(IS_ABSOLUTE) snippet from
existing code (for example tier1/kwidgetaddons/src/CMakeLists.txt uses
it).
:
:/
Ill-advised code propagates from cargo-culting. It is a bad idea. If you
don't understand, ask.
That's sort of what I am doing now :)
Since we are tied to CMake 2.8.12, the macro would be:
macro ecm_library_set_include_prefix(library include_prefix)
set(${library}_INCLUDE_INSTALL_DIR
${INCLUDE_INSTALL_DIR}/${include_prefix})
if(IS_ABSOLUTE ${INCLUDE_INSTALL_DIR})
target_include_directories(${library} INTERFACE
$INSTALL_INTERFACE:${${library}_INCLUDE_INSTALL_DIR}
)
else()
target_include_directories(${library} INTERFACE
$INSTALL_INTERFACE:
$INSTALL_PREFIX/${${library}_INCLUDE_INSTALL_DIR}
)
endif()
endmacro()
Is this correct?
What about the name? You specify that when invoking the macro?
For a 'K'-prefixed framework, one would use it like this:
ecm_library_set_include_prefix(KFoo KF5)
and then install headers with:
install(FILES Foo.h DESTINATION ${KFoo_INCLUDE_INSTALL_DIR})
For a non-prefixed framework, one would use it like this:
ecm_library_set_include_prefix(Bar KF5)
and then install headers with:
install(FILES Bar.h DESTINATION ${Bar_INCLUDE_INSTALL_DIR}/Bar)
ecm_library_set_include_prefix() is not called with KF5/Bar because in the
case of a non-prefixed framework, we want users to include headers with
#include Bar/Bar.h
So INSTALL_INTERFACE must contain include/KF5, not include/KF5/Bar.
The target_include_directories parts of your macro (ie most of it) are
obsoleted by
diff --git a/kde-modules/KDEInstallDirs.cmake b/kde-
modules/KDEInstallDirs.cmake
index d94adcf..126185b 100644
--- a/kde-modules/KDEInstallDirs.cmake
+++ b/kde-modules/KDEInstallDirs.cmake
@@ -174,7 +174,7 @@ _set_fancy(DBUS_SYSTEM_SERVICES_INSTALL_DIR
${SHARE_INSTALL_PREFIX}/dbus-1/syst
set(INSTALL_TARGETS_DEFAULT_ARGS RUNTIME DESTINATION ${BIN_INSTALL_DIR}
LIBRARY DESTINATION ${LIB_INSTALL_DIR}
ARCHIVE DESTINATION ${LIB_INSTALL_DIR}
COMPONENT Devel
- INCLUDES DESTINATION
${INCLUDE_INSTALL_DIR}
+ INCLUDES DESTINATION
${INCLUDE_INSTALL_DIR}/KF5/$TARGET_PROPERTY:NAME
)
when CMake 3.0.0 is depended on.
Sounds good, we will be able to simplify the macro at this point then.
Aurélien
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Missing FindCarbon.cmake
Le lundi 9 décembre 2013 21:46:19 Nicolás Alvarez a écrit : I'm trying to build KF5 on OS X. KIdleTime, KWindowSystem and KWallet depend on the Carbon library; they have a find_package(Carbon). However, they all fail to find FindCarbon.cmake. It's currently present in kde4support and in the ecm 'attic' directory. Should it be installed by ecm, or copied into the frameworks that need it? On another note, Carbon is deprecated, so if any Mac guy could port things to Cocoa... :) I guess there is little chance that upstream will ever ship a CarbonConfig.cmake :). It is part of the host support, so I think it should be installed by ECM, and proposed for inclusion into CMake itself. Aurélien ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114336: Install all includes in a KF5 dir
Aurélien Gâteau wrote: when CMake 3.0.0 is depended on. Sounds good, we will be able to simplify the macro at this point then. The two threads on this is causing confusion. Thanks, Steve. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KF5 Update Meeting 2013-w50 Reminder
Hi there ! Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel today (Tuesday) at 4pm Barcelona (CET / UTC+1) time. If you want me to do any announcement today in the meeting just when the meeting starts either send it as a reply here, or contact me in any way. See you there. Cheers ! ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114336: Install all includes in a KF5 dir
Le mardi 10 décembre 2013 11:07:17 Stephen Kelly a écrit : Aurélien Gâteau wrote: when CMake 3.0.0 is depended on. Sounds good, we will be able to simplify the macro at this point then. The two threads on this is causing confusion. Agreed, let's continue in the newer thread. Aurélien ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Was Installing headers in include/KF5, how to?
Le mardi 10 décembre 2013 10:09:59 Stephen Kelly a écrit :
Aurélien Gâteau wrote:
Le lundi 9 décembre 2013 21:59:58 Stephen Kelly a écrit :
Aurélien Gâteau wrote:
+set(INCLUDE_INSTALL_DIR ${INCLUDE_INSTALL_DIR}/KF5)
Don't you instead want to install to ${INCLUDE_INSTALL_DIR}/KF5/$Name ?
Not for all frameworks. For frameworks where all headers are prefixed with
'k', we agreed on installing headers in include/KF5, wheras for framewors
without 'k' prefixes, headers should go in include/KF5/$Name
In that case, the INCLUDES DESTINATION line in ECM should possibly be
removed, or a 'smart' macro wrapping install(TARGETS) should be added
instead of the (still overly-generically-named)
INSTALL_TARGETS_DEFAULT_ARGS.
I just noticed something while looking at KDEInstallDirs.cmake: it defines
PLUGIN_INSTALL_DIR as ${QT_PLUGIN_INSTALL_DIR}/kf5.
With this in mind, I think we should just apply
https://git.reviewboard.kde.org/r/114336/
and be done with it.
What does _set_fancy do? Should it be removed? INCLUDE_INSTALL_DIR is set
by _set_fancy in ecm.
I don't really understand the intricacies of cache handling in
_set_fancy(), so I don't know. You know CMake better than me, you tell me
:)
I think it should be removed. It was added a long time ago for Volker, and
as far as I know, is not needed anymore. Alex doesn't want to remove it.
I am all for less magic, and I trust you to remove it if you say it is not
needed anymore. However, whether _set_fancy() goes or stays is not going to
help with getting framework header files installed in the right dir.
Aurélien
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112463: Port SMB kioslave to KF5/Qt5
Bump.. Ok to push it? On Fri, Dec 6, 2013 at 12:44 AM, Mark Gaiser mark...@gmail.com wrote: This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/ Review request for KDE Runtime and KDE Frameworks. By Mark Gaiser. *Updated Dec. 5, 2013, 11:44 p.m.* Changes Updated with suggestions from Kevin. Replaced KDE::utime (deprecated warning) by just utime(QFile::enc..., ...) *Repository: * kde-runtime Description This is the initial port! I added two TODO lines in the diff for parts where i'm not sure if I've ported them correctly. Also, i needed a change in FindSamba.cmake to even get the samba detection working. That reviewrequest is waiting here: https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use samba 3.x Once i know that this is actually working then i will comment some qDebug lines. Testing It compiles and gets loaded just fine. I tried testing this on an actual samba share, but i kept getting a 111 error (connection refused) from kio_smb so i'm hoping that is a local issue here. If someone else could try this out and verify that it's either working or broken. Diffs (updated) - kioslave/CMakeLists.txt (fc594e4) - kioslave/smb/CMakeLists.txt (a3a2265) - kioslave/smb/kio_smb.h (c2229ab) - kioslave/smb/kio_smb.cpp (2c2523a) - kioslave/smb/kio_smb_auth.cpp (4d236b4) - kioslave/smb/kio_smb_browse.cpp (5253be9) - kioslave/smb/kio_smb_dir.cpp (ba80c86) - kioslave/smb/kio_smb_file.cpp (206526a) - kioslave/smb/kio_smb_internal.h (4b946c1) - kioslave/smb/kio_smb_internal.cpp (e943844) - kioslave/smb/kio_smb_mount.cpp (a5a7e8e) - kioslave/smb/kio_smb_win.h (f1dcb6f) - kioslave/smb/kio_smb_win.cpp (14dd797) View Diff http://git.reviewboard.kde.org/r/112463/diff/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114377: Refresh apidox README
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114377/#review45453 --- Can this wait until after the split? If we keep accumulating new patches, it'll never happen. - Alex Merry On Dec. 10, 2013, 9:10 a.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114377/ --- (Updated Dec. 10, 2013, 9:10 a.m.) Review request for KDE Frameworks, Adriaan de Groot and Allen Winter. Repository: kdelibs Description --- This patch refreshes apidox README, turning it into a Markdown file. It also updates `doxygen.sh --help` output: some options were documented in the README but not in the script itself, so I centralized all of this in the script. Diffs - tier4/apidox/README.md PRE-CREATION tier4/apidox/common/README.Doxygen 3c46a51 tier4/apidox/src/doxygen.sh 659180f Diff: http://git.reviewboard.kde.org/r/114377/diff/ Testing --- `doxygen.sh --help` is now more comprehensive :) Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114377: Refresh apidox README
On Dec. 10, 2013, 1:51 p.m., Alex Merry wrote: Can this wait until after the split? If we keep accumulating new patches, it'll never happen. It definitely can wait, just wanted Adriaan and Allen to be aware I started working on apidox. Discarding it for now. - Aurélien --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114377/#review45453 --- On Dec. 10, 2013, 10:10 a.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114377/ --- (Updated Dec. 10, 2013, 10:10 a.m.) Review request for KDE Frameworks, Adriaan de Groot and Allen Winter. Repository: kdelibs Description --- This patch refreshes apidox README, turning it into a Markdown file. It also updates `doxygen.sh --help` output: some options were documented in the README but not in the script itself, so I centralized all of this in the script. Diffs - tier4/apidox/README.md PRE-CREATION tier4/apidox/common/README.Doxygen 3c46a51 tier4/apidox/src/doxygen.sh 659180f Diff: http://git.reviewboard.kde.org/r/114377/diff/ Testing --- `doxygen.sh --help` is now more comprehensive :) Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114377: Refresh apidox README
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114377/ --- (Updated Dec. 10, 2013, 1:56 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks, Adriaan de Groot and Allen Winter. Repository: kdelibs Description --- This patch refreshes apidox README, turning it into a Markdown file. It also updates `doxygen.sh --help` output: some options were documented in the README but not in the script itself, so I centralized all of this in the script. Diffs - tier4/apidox/README.md PRE-CREATION tier4/apidox/common/README.Doxygen 3c46a51 tier4/apidox/src/doxygen.sh 659180f Diff: http://git.reviewboard.kde.org/r/114377/diff/ Testing --- `doxygen.sh --help` is now more comprehensive :) Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114377: Refresh apidox README
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114377/#review45457 --- Ship it! you have my Ship It on this. and appreciation. thanks for giving a little bit of love to apidox - Allen Winter On Dec. 10, 2013, 12:56 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114377/ --- (Updated Dec. 10, 2013, 12:56 p.m.) Review request for KDE Frameworks, Adriaan de Groot and Allen Winter. Repository: kdelibs Description --- This patch refreshes apidox README, turning it into a Markdown file. It also updates `doxygen.sh --help` output: some options were documented in the README but not in the script itself, so I centralized all of this in the script. Diffs - tier4/apidox/README.md PRE-CREATION tier4/apidox/common/README.Doxygen 3c46a51 tier4/apidox/src/doxygen.sh 659180f Diff: http://git.reviewboard.kde.org/r/114377/diff/ Testing --- `doxygen.sh --help` is now more comprehensive :) Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114377: Refresh apidox README
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114377/#review45458 --- This review has been submitted with commit 3c9112c46a87d40a5847911ee62b4eac9d47dbde by Aurélien Gâteau to branch frameworks. - Commit Hook On Dec. 10, 2013, 12:56 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114377/ --- (Updated Dec. 10, 2013, 12:56 p.m.) Review request for KDE Frameworks, Adriaan de Groot and Allen Winter. Repository: kdelibs Description --- This patch refreshes apidox README, turning it into a Markdown file. It also updates `doxygen.sh --help` output: some options were documented in the README but not in the script itself, so I centralized all of this in the script. Diffs - tier4/apidox/README.md PRE-CREATION tier4/apidox/common/README.Doxygen 3c46a51 tier4/apidox/src/doxygen.sh 659180f Diff: http://git.reviewboard.kde.org/r/114377/diff/ Testing --- `doxygen.sh --help` is now more comprehensive :) Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114377: Refresh apidox README
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114377/ --- (Updated Dec. 10, 2013, 2:15 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Adriaan de Groot and Allen Winter. Repository: kdelibs Description --- This patch refreshes apidox README, turning it into a Markdown file. It also updates `doxygen.sh --help` output: some options were documented in the README but not in the script itself, so I centralized all of this in the script. Diffs - tier4/apidox/README.md PRE-CREATION tier4/apidox/common/README.Doxygen 3c46a51 tier4/apidox/src/doxygen.sh 659180f Diff: http://git.reviewboard.kde.org/r/114377/diff/ Testing --- `doxygen.sh --help` is now more comprehensive :) Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114356: Move KGlobalAccel from XmlGui into an own tier1 framework
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114356/#review45465 --- tier1/kglobalaccel/KF5GlobalAccelConfig.cmake.in http://git.reviewboard.kde.org/r/114356/#comment32420 Shouldn't that file be called KGlobalAccelConfig.cmake.in? We're not prefixing the rest of modules with KF5, right? - Aleix Pol Gonzalez On Dec. 10, 2013, 6:41 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114356/ --- (Updated Dec. 10, 2013, 6:41 a.m.) Review request for KDE Frameworks and Martin Klapetek. Repository: kdelibs Description --- New framework needs DBus, Widgets and (optionally) X11Extras as dependencies. @MartinK: how should we organize the renaming? I'm still using the old naming scheme. So should I adjust or should we use your scripts after pulling this one in? Diffs - tier1/CMakeLists.txt 450ca57 tier1/kglobalaccel/CMakeLists.txt PRE-CREATION tier1/kglobalaccel/KF5GlobalAccelConfig.cmake.in PRE-CREATION tier1/kglobalaccel/autotests/CMakeLists.txt PRE-CREATION tier1/kglobalaccel/autotests/kglobalshortcuttest.h PRE-CREATION tier1/kglobalaccel/autotests/kglobalshortcuttest.cpp PRE-CREATION tier1/kglobalaccel/src/CMakeLists.txt PRE-CREATION tier1/kglobalaccel/src/config-kglobalaccel.h.cmake PRE-CREATION tier1/kglobalaccel/src/kglobalaccel.h PRE-CREATION tier1/kglobalaccel/src/kglobalaccel.cpp PRE-CREATION tier1/kglobalaccel/src/kglobalaccel_p.h PRE-CREATION tier1/kglobalaccel/src/kglobalshortcutinfo.h PRE-CREATION tier1/kglobalaccel/src/kglobalshortcutinfo.cpp PRE-CREATION tier1/kglobalaccel/src/kglobalshortcutinfo_dbus.cpp PRE-CREATION tier1/kglobalaccel/src/kglobalshortcutinfo_p.h PRE-CREATION tier1/kglobalaccel/src/org.kde.KGlobalAccel.xml PRE-CREATION tier1/kglobalaccel/src/org.kde.kglobalaccel.Component.xml PRE-CREATION tier3/xmlgui/CMakeLists.txt 75593fb tier3/xmlgui/autotests/CMakeLists.txt 6546ac7 tier3/xmlgui/autotests/kglobalshortcuttest.h d8e0024 tier3/xmlgui/autotests/kglobalshortcuttest.cpp 453920b tier3/xmlgui/src/CMakeLists.txt 31621e2 tier3/xmlgui/src/kactioncollection.cpp 0266069 tier3/xmlgui/src/kglobalaccel.h 57482ad tier3/xmlgui/src/kglobalaccel.cpp 77ce993 tier3/xmlgui/src/kglobalaccel_p.h 50f271f tier3/xmlgui/src/kglobalshortcutinfo.h 0920f01 tier3/xmlgui/src/kglobalshortcutinfo.cpp d2ca948 tier3/xmlgui/src/kglobalshortcutinfo_dbus.cpp f49bd9d tier3/xmlgui/src/kglobalshortcutinfo_p.h dd2dd2d tier3/xmlgui/src/kkeysequencewidget.cpp 2148ce0 tier3/xmlgui/src/kshortcutseditor.cpp 3e917d2 tier3/xmlgui/src/kshortcutseditoritem.cpp e7257a6 tier3/xmlgui/src/kxmlguifactory.cpp 510d2ea tier3/xmlgui/src/org.kde.KGlobalAccel.xml 8746551 tier3/xmlgui/src/org.kde.kglobalaccel.Component.xml ec21201 tier4/kde4support/CMakeLists.txt cb73b46 tier4/kde4support/src/CMakeLists.txt 39298b9 tier4/khtml/CMakeLists.txt c937f38 tier4/khtml/src/CMakeLists.txt 00243fb Diff: http://git.reviewboard.kde.org/r/114356/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114356: Move KGlobalAccel from XmlGui into an own tier1 framework
On Dec. 10, 2013, 3:37 p.m., Aleix Pol Gonzalez wrote: tier1/kglobalaccel/KF5GlobalAccelConfig.cmake.in, line 1 http://git.reviewboard.kde.org/r/114356/diff/3/?file=223532#file223532line1 Shouldn't that file be called KGlobalAccelConfig.cmake.in? We're not prefixing the rest of modules with KF5, right? No, it's correct. The package names are also changed - prefixed with KF5; KArchive -- KF5Archive. - Martin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114356/#review45465 --- On Dec. 10, 2013, 6:41 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114356/ --- (Updated Dec. 10, 2013, 6:41 a.m.) Review request for KDE Frameworks and Martin Klapetek. Repository: kdelibs Description --- New framework needs DBus, Widgets and (optionally) X11Extras as dependencies. @MartinK: how should we organize the renaming? I'm still using the old naming scheme. So should I adjust or should we use your scripts after pulling this one in? Diffs - tier1/CMakeLists.txt 450ca57 tier1/kglobalaccel/CMakeLists.txt PRE-CREATION tier1/kglobalaccel/KF5GlobalAccelConfig.cmake.in PRE-CREATION tier1/kglobalaccel/autotests/CMakeLists.txt PRE-CREATION tier1/kglobalaccel/autotests/kglobalshortcuttest.h PRE-CREATION tier1/kglobalaccel/autotests/kglobalshortcuttest.cpp PRE-CREATION tier1/kglobalaccel/src/CMakeLists.txt PRE-CREATION tier1/kglobalaccel/src/config-kglobalaccel.h.cmake PRE-CREATION tier1/kglobalaccel/src/kglobalaccel.h PRE-CREATION tier1/kglobalaccel/src/kglobalaccel.cpp PRE-CREATION tier1/kglobalaccel/src/kglobalaccel_p.h PRE-CREATION tier1/kglobalaccel/src/kglobalshortcutinfo.h PRE-CREATION tier1/kglobalaccel/src/kglobalshortcutinfo.cpp PRE-CREATION tier1/kglobalaccel/src/kglobalshortcutinfo_dbus.cpp PRE-CREATION tier1/kglobalaccel/src/kglobalshortcutinfo_p.h PRE-CREATION tier1/kglobalaccel/src/org.kde.KGlobalAccel.xml PRE-CREATION tier1/kglobalaccel/src/org.kde.kglobalaccel.Component.xml PRE-CREATION tier3/xmlgui/CMakeLists.txt 75593fb tier3/xmlgui/autotests/CMakeLists.txt 6546ac7 tier3/xmlgui/autotests/kglobalshortcuttest.h d8e0024 tier3/xmlgui/autotests/kglobalshortcuttest.cpp 453920b tier3/xmlgui/src/CMakeLists.txt 31621e2 tier3/xmlgui/src/kactioncollection.cpp 0266069 tier3/xmlgui/src/kglobalaccel.h 57482ad tier3/xmlgui/src/kglobalaccel.cpp 77ce993 tier3/xmlgui/src/kglobalaccel_p.h 50f271f tier3/xmlgui/src/kglobalshortcutinfo.h 0920f01 tier3/xmlgui/src/kglobalshortcutinfo.cpp d2ca948 tier3/xmlgui/src/kglobalshortcutinfo_dbus.cpp f49bd9d tier3/xmlgui/src/kglobalshortcutinfo_p.h dd2dd2d tier3/xmlgui/src/kkeysequencewidget.cpp 2148ce0 tier3/xmlgui/src/kshortcutseditor.cpp 3e917d2 tier3/xmlgui/src/kshortcutseditoritem.cpp e7257a6 tier3/xmlgui/src/kxmlguifactory.cpp 510d2ea tier3/xmlgui/src/org.kde.KGlobalAccel.xml 8746551 tier3/xmlgui/src/org.kde.kglobalaccel.Component.xml ec21201 tier4/kde4support/CMakeLists.txt cb73b46 tier4/kde4support/src/CMakeLists.txt 39298b9 tier4/khtml/CMakeLists.txt c937f38 tier4/khtml/src/CMakeLists.txt 00243fb Diff: http://git.reviewboard.kde.org/r/114356/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KF5 Update Meeting Minutes 2013-w50
These are the minutes of Week 50 KF5 meeting. As usual it has been held on #kde-devel at 4pm (CET / UTC+1) time. Present on the meeting: dMaggot, Sho_, markg85, d_ed, vHanda, teo- mck182, apol, agateau, mgrasslin, sebas, afiestas Announcements: -By popular demand Tuesday meeting is now KF5 only. -There is going to be a breakage before splitting, summary of the change: findings are now KF5Foo instead of KFoo (KF5Archive instead of KArchive) Linking is now KF5::Foo instead of KF5::KFoo (KF5::Archive instead of KF5::KArchive) Topics discussed: *mck182: Finished renaming of tier1/tier3 -It has been discussed how to proceed with the renaming, agateau will write some scripts to port most of the code using KF5 right now. *apol: Jhon Layt has gone AWOL and he has the KLocale API for KF5 on time formatting and byte size formatting working, no patches are known though. *agateau: Waiting for a final decision on the include prefix (http://mail.kde.org/pipermail/kde-frameworks-devel/2013-December/008523.html ) *agateau: Work on dependency diagrams (http://agateau.com/2013/12/05/kf5-diagrams/) *agateau: Working on integrating the diagrams with apidox *mgrasslin: Moved KGlobalAccel from XmlGui to tier1 *mgrasslin: Now looking in a KWindowSystem issue *sebas: Fixed a crash in Plasma Framework *afiestas: Fixed issues that appeared from the KStandardDir to QStandardPath porting Cheers. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112463: Port SMB kioslave to KF5/Qt5
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/#review45466
---
kioslave/smb/CMakeLists.txt
http://git.reviewboard.kde.org/r/112463/#comment32421
this should be:
add_library(kio_smb MODULE {kio_smb_PART_SRCS})
kioslave/smb/CMakeLists.txt
http://git.reviewboard.kde.org/r/112463/#comment32422
also add_library.
kioslave/smb/kio_smb.h
http://git.reviewboard.kde.org/r/112463/#comment32423
do you need klocale? it's deprecated.
kioslave/smb/kio_smb_auth.cpp
http://git.reviewboard.kde.org/r/112463/#comment32424
A
xD
Maybe we can just remove this one?
kioslave/smb/kio_smb_internal.h
http://git.reviewboard.kde.org/r/112463/#comment32426
it might be a good moment to remove this comment-
kioslave/smb/kio_smb_internal.cpp
http://git.reviewboard.kde.org/r/112463/#comment32427
Does it really need QDir::separator()? It seems to me like everything
should be '/'.
- Aleix Pol Gonzalez
On Dec. 5, 2013, 11:44 p.m., Mark Gaiser wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/
---
(Updated Dec. 5, 2013, 11:44 p.m.)
Review request for KDE Runtime and KDE Frameworks.
Repository: kde-runtime
Description
---
This is the initial port! I added two TODO lines in the diff for parts where
i'm not sure if I've ported them correctly.
Also, i needed a change in FindSamba.cmake to even get the samba detection
working. That reviewrequest is waiting here:
https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use
samba 3.x
Once i know that this is actually working then i will comment some qDebug
lines.
Diffs
-
kioslave/CMakeLists.txt fc594e4
kioslave/smb/CMakeLists.txt a3a2265
kioslave/smb/kio_smb.h c2229ab
kioslave/smb/kio_smb.cpp 2c2523a
kioslave/smb/kio_smb_auth.cpp 4d236b4
kioslave/smb/kio_smb_browse.cpp 5253be9
kioslave/smb/kio_smb_dir.cpp ba80c86
kioslave/smb/kio_smb_file.cpp 206526a
kioslave/smb/kio_smb_internal.h 4b946c1
kioslave/smb/kio_smb_internal.cpp e943844
kioslave/smb/kio_smb_mount.cpp a5a7e8e
kioslave/smb/kio_smb_win.h f1dcb6f
kioslave/smb/kio_smb_win.cpp 14dd797
Diff: http://git.reviewboard.kde.org/r/112463/diff/
Testing
---
It compiles and gets loaded just fine. I tried testing this on an actual
samba share, but i kept getting a 111 error (connection refused) from kio_smb
so i'm hoping that is a local issue here. If someone else could try this out
and verify that it's either working or broken.
Thanks,
Mark Gaiser
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112463: Port SMB kioslave to KF5/Qt5
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/ --- (Updated Dec. 10, 2013, 6:51 p.m.) Review request for KDE Runtime and KDE Frameworks. Changes --- Updated according to feedback. Repository: kde-runtime Description --- This is the initial port! I added two TODO lines in the diff for parts where i'm not sure if I've ported them correctly. Also, i needed a change in FindSamba.cmake to even get the samba detection working. That reviewrequest is waiting here: https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use samba 3.x Once i know that this is actually working then i will comment some qDebug lines. Diffs (updated) - kioslave/CMakeLists.txt fc594e4 kioslave/smb/CMakeLists.txt a3a2265 kioslave/smb/kio_smb.h c2229ab kioslave/smb/kio_smb.cpp 2c2523a kioslave/smb/kio_smb_auth.cpp 4d236b4 kioslave/smb/kio_smb_browse.cpp 5253be9 kioslave/smb/kio_smb_dir.cpp ba80c86 kioslave/smb/kio_smb_file.cpp 206526a kioslave/smb/kio_smb_internal.h 4b946c1 kioslave/smb/kio_smb_internal.cpp e943844 kioslave/smb/kio_smb_mount.cpp a5a7e8e kioslave/smb/kio_smb_win.h f1dcb6f kioslave/smb/kio_smb_win.cpp 14dd797 Diff: http://git.reviewboard.kde.org/r/112463/diff/ Testing --- It compiles and gets loaded just fine. I tried testing this on an actual samba share, but i kept getting a 111 error (connection refused) from kio_smb so i'm hoping that is a local issue here. If someone else could try this out and verify that it's either working or broken. Thanks, Mark Gaiser ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF5 Update Meeting Minutes 2013-w50
On 10/12/13 15:50, Àlex Fiestas wrote: *apol: Jhon Layt has gone AWOL and he has the KLocale API for KF5 on time formatting and byte size formatting working, no patches are known though. Does he in this sentence refer to apol or jlayt? ie: am I supposed to read this as apol simply stating that jlayt has gone missing, or has apol fixed up John's patches but not put them anywhere for viewing? If the former, I've volunteered to fix up John's patch (most of the comments on it were mine anyway) and submit them in his stead. Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Using KCompressionDevice with QSaveFile
Hi David,
On Wednesday 04 December 2013 14:42:19 David Faure wrote:
On Monday 02 December 2013 22:31:43 Dominik Haumann wrote:
Hi,
porting KSaveFile to QSaveFile, I stumbled into the following:
// This method has been made private so that it cannot be called,
// in order to prevent mistakes.
void QSaveFile::close()
{
qFatal(QSaveFile::close called);
}
In Kate, we use a QSaveFile saveFile(...); and then use
KCompressionDevice compDevice(saveFile, ...);
to write compressed data through compDevice into saveFile.
However, KCompressionDevice at some point always seems to call close(),
which hits the qFatal().
Should I derive from QSaveFile and overwrite close() to call commit() ?
Am I missing something here?
I just added a unittest in kdelibs-frameworks's kfiltertest, and it works
for me.
Can you check 1) that it works for you, 2) what your code does differently
from the unittest ? And then change the unittest to show the problem, so I
can look into it.
Thanks!
First of all, thanks a lot for adding the unit test and looking into this.
It turns out that it also runs correctly for me (not really a surprise, right?)
;)
However, here it comes: Changing
-KCompressionDevice device(file, false, KCompressionDevice::GZip);
+KCompressionDevice device(file, false, KCompressionDevice::None);
will run into this issue.
In that case, the unit test does the following:
QWARN : KFilterTest::test_saveFile() QSaveFile::open: File
(tier1/karchive/autotests/test_saveFile.gz) already open
QFATAL : KFilterTest::test_saveFile() QSaveFile::close called
FAIL! : KFilterTest::test_saveFile() Received a fatal error.
First, we get the warning that the file is already open.
Then, the assert.
It seems that the behavior for None is different. Interestingly, KSaveFile
also
behaved like this (KFilterDev did not change after all I guess). And this case
was
caught with an if in Kate Part's file saving code.
So yes, we can work around it again, just before.
But: I do not really get why KCompressionDevice works completely different
depending
on the compression type. This makes using KCompressionDevice pretty ugly
(im_h_o),
since you have to manually check for None and take a different code path.
Greetings,
Dominik
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114187: KFormat - Add new KFormat class
On Dec. 4, 2013, 7:32 p.m., Kevin Ottens wrote: Any chance for an update addressing the comments raised? Kevin Ottens wrote: John, please update ASAP, it's one of the patch we're waiting for to split. Alex Merry wrote: If John is unavailable, I can take over this. Tried to contact him via several channels with no luck. Please take over this, we need to crack this one NOW. - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114187/#review45135 --- On Nov. 28, 2013, 8 p.m., John Layt wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114187/ --- (Updated Nov. 28, 2013, 8 p.m.) Review request for KDE Frameworks, Albert Astals Cid, David Faure, and Kevin Ottens. Repository: kdelibs Description --- KFormat - Add new KFormat class KLocale offers a number of extra formatting options not yet available in Qt. The KFormat class adds these options to KCoreAddons: * formatByteSize() * formatDuration() * formatDecimalDuration() * formatSpelloutDuration() * formatRelativeDate() * formatRelativeDateTime() The KFormat class can be initialised with any QLocale to use in the date and number formatting, or the default locale can be easily accessed via KFormat(): QString result = KFormat().formatDuration(1000); There's a few things that need looking at here. The main one is the translation stuff because I had to convert from using ki18n to tr and it may have lost something in the process. In particular it looks like we'll actually need an en_US translation done to get the plurals right? If we can't make tr() work for these we'll have to move the class into k18n. The second is to look at the formatting options provided and decide if they are actually useful to have. The third is to confirm that the design is OK, I did think about making these simple static methods with an extra parm for QLocale, but I think this approach offers more future flexibility, and writing KFormat().formatDuration() is just as convenient as KFormat::formatDuration(). Diffs - tier1/kcoreaddons/autotests/CMakeLists.txt c8043576181e7d06663195d017be930d0bdcbde9 tier1/kcoreaddons/autotests/kformattest.h PRE-CREATION tier1/kcoreaddons/autotests/kformattest.cpp PRE-CREATION tier1/kcoreaddons/src/lib/CMakeLists.txt 638525f7b719bcd0bc1dfdf94debd51296521334 tier1/kcoreaddons/src/lib/util/kformat.h PRE-CREATION tier1/kcoreaddons/src/lib/util/kformat.cpp PRE-CREATION tier1/kcoreaddons/src/lib/util/kformatprivate.cpp PRE-CREATION tier1/kcoreaddons/src/lib/util/kformatprivate_p.h PRE-CREATION Diff: http://git.reviewboard.kde.org/r/114187/diff/ Testing --- Autotests copied from KLocale tests and improved. Thanks, John Layt ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114389: Add KF5 prefix to Plasma and PlasmaQuick libs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114389/#review45508 --- Ship it! Ship It! - Kevin Ottens On Dec. 10, 2013, 4:51 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114389/ --- (Updated Dec. 10, 2013, 4:51 p.m.) Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Follows the lib renaming of frameworks Puts KF5 in the lib name -- libKF5Plasma libKF5PlasmaQuick as well as the packages -- KF5Plasma and KF5PlasmaQuick. Diffs - PlasmaConfig.cmake.in 6331882 PlasmaMacros.cmake examples/dataengines/customDataContainers/CMakeLists.txt 7029f93 examples/dataengines/simpleEngine/CMakeLists.txt ee6edd4 examples/dataengines/sourcesOnRequest/CMakeLists.txt d4557f5 src/declarativeimports/core/CMakeLists.txt 89fa122 src/declarativeimports/core/tests/CMakeLists.txt 0a90003 src/declarativeimports/krunnermodel/CMakeLists.txt cd64357 src/declarativeimports/plasmacomponents/CMakeLists.txt 012f652 src/declarativeimports/plasmaextracomponents/CMakeLists.txt c06d81e src/declarativeimports/qtextracomponents/CMakeLists.txt aa44ae9 src/plasma/CMakeLists.txt 3ab0596 src/plasma/autotests/CMakeLists.txt 77c9f6c src/plasma/tests/kplugins/CMakeLists.txt ebdba66 src/plasmapkg/CMakeLists.txt 7eb41d8 src/plasmaquick/CMakeLists.txt c361df2 src/plasmaquick/PlasmaQuickConfig.cmake.in 5b258a2 src/plasmaquick/autotests/CMakeLists.txt 1fc3adf src/scriptengines/qml/CMakeLists.txt 3d7bd41 src/shell/CMakeLists.txt faa51e2 Diff: http://git.reviewboard.kde.org/r/114389/diff/ Testing --- None atm, the rest of plasma-framework needs updating to the renamed frameworks first, there is a script in making which should do that, so I'll hold on that. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114182: Add Kf5 prefix for libs, eg. libKf5Foo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114182/#review45512 --- This review has been submitted with commit 067f1650b81302ca4f784538fc6209d826338ad8 by Martin Klapetek to branch lib_prefix. - Commit Hook On Dec. 5, 2013, 5:58 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114182/ --- (Updated Dec. 5, 2013, 5:58 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- This is just one framework - KConfig - if this is the proper way to do this, I'll update this review with all frameworks updated to this. Diffs - tier1/itemviews/tests/CMakeLists.txt 4ddf5d8 tier1/itemviews/src/CMakeLists.txt bad773c tier1/itemviews/autotests/CMakeLists.txt 0219900 tier1/itemviews/KF5ItemViewsConfig.cmake.in PRE-CREATION tier1/itemviews/ItemViewsConfig.cmake.in 1956453 tier1/itemviews/CMakeLists.txt 1bdadac tier1/itemmodels/src/CMakeLists.txt 86b48cf tier1/itemmodels/autotests/proxymodeltestapp/CMakeLists.txt 525c9f3 tier1/itemmodels/autotests/CMakeLists.txt 03daf70 tier1/itemmodels/KF5ItemModelsConfig.cmake.in PRE-CREATION tier1/itemmodels/ItemModelsConfig.cmake.in 4ac98f3 tier1/itemmodels/CMakeLists.txt d0be692 tier1/karchive/CMakeLists.txt f0d12ac tier1/karchive/KArchiveConfig.cmake.in 40fa614 tier1/karchive/KF5ArchiveConfig.cmake.in PRE-CREATION tier1/karchive/autotests/CMakeLists.txt a2cfabe tier1/karchive/examples/helloworld/CMakeLists.txt 2e90094 tier1/karchive/examples/tarlocalfiles/CMakeLists.txt b855caf tier1/karchive/src/CMakeLists.txt 767140a tier1/karchive/tests/CMakeLists.txt d804cd2 tier1/kcodecs/CMakeLists.txt a8217d0 tier1/kcodecs/KCodecsConfig.cmake.in ea632ce tier1/kcodecs/KF5CodecsConfig.cmake.in PRE-CREATION tier1/kcodecs/autotests/CMakeLists.txt bf393f8 tier1/kcodecs/src/CMakeLists.txt 152bc8e tier1/kconfig/CMakeLists.txt af91aa2 tier1/kconfig/KConfigConfig.cmake.in 5d9d7eb tier1/kconfig/KConfigMacros.cmake ec354a9 tier1/kconfig/KF5ConfigConfig.cmake.in PRE-CREATION tier1/kconfig/KF5ConfigMacros.cmake PRE-CREATION tier1/kconfig/autotests/CMakeLists.txt cc2626b tier1/kconfig/autotests/kconfig_compiler/CMakeLists.txt 184ab17 tier1/kconfig/src/core/CMakeLists.txt c8a4842 tier1/kconfig/src/gui/CMakeLists.txt b677d03 tier1/kconfig/src/kconf_update/CMakeLists.txt 69668bc tier1/kconfig/src/kconfig_compiler/CMakeLists.txt 19d86d4 tier1/kcoreaddons/CMakeLists.txt 5d2b4a8 tier1/kcoreaddons/KCoreAddonsConfig.cmake.in a53be5f tier1/kcoreaddons/KF5CoreAddonsConfig.cmake.in PRE-CREATION tier1/kcoreaddons/autotests/CMakeLists.txt c804357 tier1/kcoreaddons/src/lib/CMakeLists.txt 638525f tier1/kcoreaddons/tests/CMakeLists.txt c79d0ba tier1/kdbusaddons/CMakeLists.txt 78cc443 tier1/kdbusaddons/KDBusAddonsConfig.cmake.in 27a6060 tier1/kdbusaddons/KF5DBusAddonsConfig.cmake.in PRE-CREATION tier1/kdbusaddons/autotests/CMakeLists.txt 92c9151 tier1/kdbusaddons/src/CMakeLists.txt 71dc290 tier1/kdbusaddons/tests/CMakeLists.txt 684fee3 tier1/kguiaddons/CMakeLists.txt b3f378d tier1/kguiaddons/KF5GuiAddonsConfig.cmake.in PRE-CREATION tier1/kguiaddons/KGuiAddonsConfig.cmake.in 83e4c91 tier1/kguiaddons/autotests/CMakeLists.txt 2e4a6bb tier1/kguiaddons/src/CMakeLists.txt ca94f4b tier1/kguiaddons/tests/CMakeLists.txt 754b460 tier1/kidletime/CMakeLists.txt 61ba25b tier1/kidletime/KF5IdleTimeConfig.cmake.in PRE-CREATION tier1/kidletime/KIdleTimeConfig.cmake.in ace9e8a tier1/kidletime/examples/CMakeLists.txt c88a6c3 tier1/kidletime/src/CMakeLists.txt 44a1f3f tier1/kjs/CMakeLists.txt ab27a14 tier1/kjs/KF5JSConfig.cmake.in PRE-CREATION tier1/kjs/KJSConfig.cmake.in 8c4ff9e tier1/kjs/autotests/CMakeLists.txt 206c17a tier1/kjs/src/kjs/CMakeLists.txt b63d92f tier1/kjs/src/kjs/api/CMakeLists.txt dadf39c tier1/kjs/tests/CMakeLists.txt 9388a70 tier1/kplotting/CMakeLists.txt f8e53ff tier1/kplotting/KF5PlottingConfig.cmake.in PRE-CREATION tier1/kplotting/KPlottingConfig.cmake.in 42d4fae tier1/kplotting/autotests/CMakeLists.txt cc03ea4 tier1/kplotting/examples/CMakeLists.txt 7c8ab7e tier1/kplotting/src/CMakeLists.txt 59e7d09 tier1/kwidgetsaddons/CMakeLists.txt 570630b tier1/kwidgetsaddons/KF5WidgetsAddonsConfig.cmake.in PRE-CREATION tier1/kwidgetsaddons/KWidgetsAddonsConfig.cmake.in 98dbc46 tier1/kwidgetsaddons/autotests/CMakeLists.txt 1f6b69f tier1/kwidgetsaddons/src/CMakeLists.txt 0333f3a
Re: Review Request 114333: Add KF5 prefix for tier2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114333/#review45515 --- This review has been submitted with commit a9483bff68d44f033407facaae7723049597d78a by Martin Klapetek to branch lib_prefix. - Commit Hook On Dec. 6, 2013, 2:01 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114333/ --- (Updated Dec. 6, 2013, 2:01 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Adds KF5 prefix to all tier2 frameworks Diffs - tier2/dnssd/CMakeLists.txt 542de05 tier2/dnssd/KDNSSDConfig.cmake.in 8678ccf tier2/dnssd/src/CMakeLists.txt ec20b9d tier2/kauth/CMakeLists.txt b01da0c tier2/kauth/KAuthConfig.cmake.in 3bc86e3 tier2/kauth/autotests/CMakeLists.txt e973789 tier2/kauth/cmake/KAuthMacros.cmake 4cdf3ab tier2/kauth/src/CMakeLists.txt c9ad99f tier2/kauth/src/ConfigureChecks.cmake a2441d9 tier2/kcompletion/CMakeLists.txt 040f8d6 tier2/kcompletion/KCompletionConfig.cmake.in 528e9a9 tier2/kcompletion/KF5CompletionConfig.cmake.in PRE-CREATION tier2/kcompletion/autotests/CMakeLists.txt 884db91 tier2/kcompletion/src/CMakeLists.txt 2f0a068 tier2/kcompletion/tests/CMakeLists.txt 1aeb870 tier2/kcrash/CMakeLists.txt 3267d8d tier2/kcrash/KCrashConfig.cmake.in 417209a tier2/kcrash/KF5CrashConfig.cmake.in PRE-CREATION tier2/kcrash/src/CMakeLists.txt 5e91142 tier2/kdoctools/CMakeLists.txt 88e0e1a tier2/kdoctools/KDocToolsConfig.cmake.in 9eb8706 tier2/kdoctools/KDocToolsMacros.cmake 191a2c5 tier2/kdoctools/KF5DocToolsConfig.cmake.in PRE-CREATION tier2/kdoctools/KF5DocToolsMacros.cmake PRE-CREATION tier2/kdoctools/src/CMakeLists.txt 3f77da0 tier2/ki18n/CMakeLists.txt ff8ec84 tier2/ki18n/KF5I18nConfig.cmake.in PRE-CREATION tier2/ki18n/KI18nConfig.cmake.in e307f56 tier2/ki18n/autotests/CMakeLists.txt 1abb03a tier2/ki18n/cmake/KF5I18NMacros.cmake PRE-CREATION tier2/ki18n/cmake/KI18NMacros.cmake d82514e tier2/ki18n/cmake/kf5i18nuic.cmake PRE-CREATION tier2/ki18n/cmake/ki18nuic.cmake efcd0ae tier2/ki18n/src/CMakeLists.txt 6534937 tier2/kjobwidgets/CMakeLists.txt 6759617 tier2/kjobwidgets/KF5JobWidgetsConfig.cmake.in PRE-CREATION tier2/kjobwidgets/KJobWidgetsConfig.cmake.in 8ca5e9d tier2/kjobwidgets/autotests/CMakeLists.txt d290a7b tier2/kjobwidgets/src/CMakeLists.txt 032df16 tier2/kjobwidgets/tests/CMakeLists.txt b453512 tier2/knotifications/CMakeLists.txt 4f71b2e tier2/knotifications/KF5NotificationsConfig.cmake.in PRE-CREATION tier2/knotifications/KNotificationsConfig.cmake.in 0054854 tier2/knotifications/autotests/CMakeLists.txt cf59af5 tier2/knotifications/src/CMakeLists.txt 3011a3d tier2/knotifications/tests/CMakeLists.txt 01c566a tier2/kwallet/CMakeLists.txt 0cf9a55 tier2/kwallet/KF5WalletConfig.cmake.in PRE-CREATION tier2/kwallet/KWalletConfig.cmake.in ca11594 tier2/kwallet/autotests/CMakeLists.txt ef707c1 tier2/kwallet/src/CMakeLists.txt 206dd69 tier2/kwallet/tests/CMakeLists.txt ea1562a Diff: http://git.reviewboard.kde.org/r/114333/diff/ Testing --- Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114333: Add KF5 prefix for tier2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114333/ --- (Updated Dec. 10, 2013, 10:18 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Adds KF5 prefix to all tier2 frameworks Diffs - tier2/dnssd/CMakeLists.txt 542de05 tier2/dnssd/KDNSSDConfig.cmake.in 8678ccf tier2/dnssd/src/CMakeLists.txt ec20b9d tier2/kauth/CMakeLists.txt b01da0c tier2/kauth/KAuthConfig.cmake.in 3bc86e3 tier2/kauth/autotests/CMakeLists.txt e973789 tier2/kauth/cmake/KAuthMacros.cmake 4cdf3ab tier2/kauth/src/CMakeLists.txt c9ad99f tier2/kauth/src/ConfigureChecks.cmake a2441d9 tier2/kcompletion/CMakeLists.txt 040f8d6 tier2/kcompletion/KCompletionConfig.cmake.in 528e9a9 tier2/kcompletion/KF5CompletionConfig.cmake.in PRE-CREATION tier2/kcompletion/autotests/CMakeLists.txt 884db91 tier2/kcompletion/src/CMakeLists.txt 2f0a068 tier2/kcompletion/tests/CMakeLists.txt 1aeb870 tier2/kcrash/CMakeLists.txt 3267d8d tier2/kcrash/KCrashConfig.cmake.in 417209a tier2/kcrash/KF5CrashConfig.cmake.in PRE-CREATION tier2/kcrash/src/CMakeLists.txt 5e91142 tier2/kdoctools/CMakeLists.txt 88e0e1a tier2/kdoctools/KDocToolsConfig.cmake.in 9eb8706 tier2/kdoctools/KDocToolsMacros.cmake 191a2c5 tier2/kdoctools/KF5DocToolsConfig.cmake.in PRE-CREATION tier2/kdoctools/KF5DocToolsMacros.cmake PRE-CREATION tier2/kdoctools/src/CMakeLists.txt 3f77da0 tier2/ki18n/CMakeLists.txt ff8ec84 tier2/ki18n/KF5I18nConfig.cmake.in PRE-CREATION tier2/ki18n/KI18nConfig.cmake.in e307f56 tier2/ki18n/autotests/CMakeLists.txt 1abb03a tier2/ki18n/cmake/KF5I18NMacros.cmake PRE-CREATION tier2/ki18n/cmake/KI18NMacros.cmake d82514e tier2/ki18n/cmake/kf5i18nuic.cmake PRE-CREATION tier2/ki18n/cmake/ki18nuic.cmake efcd0ae tier2/ki18n/src/CMakeLists.txt 6534937 tier2/kjobwidgets/CMakeLists.txt 6759617 tier2/kjobwidgets/KF5JobWidgetsConfig.cmake.in PRE-CREATION tier2/kjobwidgets/KJobWidgetsConfig.cmake.in 8ca5e9d tier2/kjobwidgets/autotests/CMakeLists.txt d290a7b tier2/kjobwidgets/src/CMakeLists.txt 032df16 tier2/kjobwidgets/tests/CMakeLists.txt b453512 tier2/knotifications/CMakeLists.txt 4f71b2e tier2/knotifications/KF5NotificationsConfig.cmake.in PRE-CREATION tier2/knotifications/KNotificationsConfig.cmake.in 0054854 tier2/knotifications/autotests/CMakeLists.txt cf59af5 tier2/knotifications/src/CMakeLists.txt 3011a3d tier2/knotifications/tests/CMakeLists.txt 01c566a tier2/kwallet/CMakeLists.txt 0cf9a55 tier2/kwallet/KF5WalletConfig.cmake.in PRE-CREATION tier2/kwallet/KWalletConfig.cmake.in ca11594 tier2/kwallet/autotests/CMakeLists.txt ef707c1 tier2/kwallet/src/CMakeLists.txt 206dd69 tier2/kwallet/tests/CMakeLists.txt ea1562a Diff: http://git.reviewboard.kde.org/r/114333/diff/ Testing --- Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114208: Rest of frameworks adapted to tier1 renamings
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114208/ --- (Updated Dec. 10, 2013, 10:18 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- That's how it looks after all frameworks in tier1 were renamed. Next step is to rename everything in tier2. Diffs - tier2/dnssd/CMakeLists.txt 542de05 tier2/dnssd/src/CMakeLists.txt ec20b9d tier2/kauth/CMakeLists.txt b01da0c tier2/kauth/autotests/CMakeLists.txt e973789 tier2/kauth/src/CMakeLists.txt c9ad99f tier2/kcompletion/CMakeLists.txt 040f8d6 tier2/kcompletion/src/CMakeLists.txt 2f0a068 tier2/kcompletion/tests/CMakeLists.txt 1aeb870 tier2/kcrash/CMakeLists.txt 3267d8d tier2/kcrash/src/CMakeLists.txt 5e91142 tier2/kdoctools/CMakeLists.txt 88e0e1a tier2/kdoctools/src/CMakeLists.txt 3f77da0 tier2/ki18n/CMakeLists.txt ff8ec84 tier2/ki18n/src/CMakeLists.txt 6534937 tier2/kjobwidgets/CMakeLists.txt 6759617 tier2/kjobwidgets/src/CMakeLists.txt 032df16 tier2/knotifications/CMakeLists.txt 4f71b2e tier2/knotifications/src/CMakeLists.txt 3011a3d tier2/knotifications/tests/CMakeLists.txt 01c566a tier2/kwallet/CMakeLists.txt 0cf9a55 tier2/kwallet/src/CMakeLists.txt 206dd69 tier3/kbookmarks/CMakeLists.txt 5866b2f tier3/kcmutils/CMakeLists.txt 3d2cde6 tier3/kcmutils/src/CMakeLists.txt 6bb862c tier3/kconfigwidgets/CMakeLists.txt 56c9edc tier3/kconfigwidgets/src/CMakeLists.txt b8bd464 tier3/kconfigwidgets/tests/CMakeLists.txt 7d7d6d6 tier3/kdeclarative/CMakeLists.txt 67eb43d tier3/kdeclarative/src/CMakeLists.txt ac5e9f9 tier3/kded/CMakeLists.txt e4fec6d tier3/kded/src/CMakeLists.txt 8ad585d tier3/kdesu/CMakeLists.txt 50f98eb tier3/kdesu/src/CMakeLists.txt a96ae54 tier3/kdewebkit/CMakeLists.txt 2588cd8 tier3/kdewebkit/src/CMakeLists.txt a31aca9 tier3/kdewidgets/CMakeLists.txt ca2ae13 tier3/kdewidgets/src/CMakeLists.txt e7e9a9f tier3/kemoticons/CMakeLists.txt d0eb51b tier3/kemoticons/src/core/CMakeLists.txt dc64aa0 tier3/kiconthemes/CMakeLists.txt d1191d1 tier3/kiconthemes/autotests/CMakeLists.txt 2ee90c9 tier3/kiconthemes/src/CMakeLists.txt f900c6c tier3/kiconthemes/tests/CMakeLists.txt 77a543c tier3/kinit/CMakeLists.txt 7943efb tier3/kinit/src/kdeinit/CMakeLists.txt 2a048a8 tier3/kinit/src/klauncher/CMakeLists.txt 6f79e3a tier3/kio/CMakeLists.txt 8d33523 tier3/kio/src/core/CMakeLists.txt fdde6f7 tier3/kio/src/ioslaves/help/CMakeLists.txt bfab595 tier3/kio/src/ioslaves/http/CMakeLists.txt 0b57bf2 tier3/kio/src/ioslaves/http/kcookiejar/CMakeLists.txt b28428c tier3/kio/src/ioslaves/http/tests/CMakeLists.txt 357b854 tier3/kio/src/ioslaves/telnet/CMakeLists.txt d3b05e5 tier3/kio/src/kntlm/CMakeLists.txt 670f93c tier3/kio/src/kpac/CMakeLists.txt ed839cc tier3/kio/src/kssld/CMakeLists.txt fd66012 tier3/kio/src/widgets/CMakeLists.txt 5f4e31f tier3/kio/tests/CMakeLists.txt d55831d tier3/kjsembed/CMakeLists.txt f80510f tier3/kjsembed/src/kjsembed/CMakeLists.txt f883f19 tier3/kmediaplayer/CMakeLists.txt 54949a1 tier3/knewstuff/CMakeLists.txt faaa976 tier3/knewstuff/src/CMakeLists.txt b7c94a8 tier3/knotifyconfig/CMakeLists.txt 16c147c tier3/kparts/CMakeLists.txt d4c5ad0 tier3/kparts/tests/CMakeLists.txt 9ed2dc8 tier3/kprintutils/CMakeLists.txt cbacbb6 tier3/kpty/CMakeLists.txt fc28e03 tier3/kpty/src/CMakeLists.txt add6aa4 tier3/kross/CMakeLists.txt 64b3634 tier3/kross/autotests/CMakeLists.txt 83a7b61 tier3/kross/src/core/CMakeLists.txt 28b52be tier3/kross/src/ui/CMakeLists.txt 0e9ae27 tier3/kservice/CMakeLists.txt a329529 tier3/kservice/src/CMakeLists.txt cc0c1a4 tier3/kservice/src/desktoptojson/CMakeLists.txt afe21f2 tier3/kservice/src/kbuildsycoca/CMakeLists.txt 3a82b79 tier3/ktextwidgets/CMakeLists.txt 0014315 tier3/ktextwidgets/src/CMakeLists.txt 043ec0a tier3/kunitconversion/src/CMakeLists.txt b8b8e2f tier3/xmlgui/CMakeLists.txt 75593fb tier3/xmlgui/src/CMakeLists.txt 31621e2 tier3/xmlgui/src/ksendbugmail/CMakeLists.txt cae2a6b tier3/xmlgui/tests/CMakeLists.txt b756358 tier4/frameworkintegration/CMakeLists.txt 02b3563 tier4/frameworkintegration/autotests/CMakeLists.txt f126859 tier4/frameworkintegration/src/integrationplugin/CMakeLists.txt f6cb5c4 tier4/frameworkintegration/src/platformtheme/CMakeLists.txt 5d95c8a tier4/kde4support/CMakeLists.txt 279ae08 tier4/kde4support/autotests/CMakeLists.txt c993def tier4/kde4support/src/CMakeLists.txt 81fd2a5 tier4/kde4support/src/kioslave/metainfo/CMakeLists.txt 8115600 tier4/kde4support/src/kssl/kcm/CMakeLists.txt f0629e9 tier4/kde4support/tests/CMakeLists.txt 050b7ff
Re: Review Request 114182: Add Kf5 prefix for libs, eg. libKf5Foo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114182/ --- (Updated Dec. 10, 2013, 10:18 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- This is just one framework - KConfig - if this is the proper way to do this, I'll update this review with all frameworks updated to this. Diffs - tier1/itemviews/tests/CMakeLists.txt 4ddf5d8 tier1/itemviews/src/CMakeLists.txt bad773c tier1/itemviews/autotests/CMakeLists.txt 0219900 tier1/itemviews/KF5ItemViewsConfig.cmake.in PRE-CREATION tier1/itemviews/ItemViewsConfig.cmake.in 1956453 tier1/itemviews/CMakeLists.txt 1bdadac tier1/itemmodels/src/CMakeLists.txt 86b48cf tier1/itemmodels/autotests/proxymodeltestapp/CMakeLists.txt 525c9f3 tier1/itemmodels/autotests/CMakeLists.txt 03daf70 tier1/itemmodels/KF5ItemModelsConfig.cmake.in PRE-CREATION tier1/itemmodels/ItemModelsConfig.cmake.in 4ac98f3 tier1/itemmodels/CMakeLists.txt d0be692 tier1/karchive/CMakeLists.txt f0d12ac tier1/karchive/KArchiveConfig.cmake.in 40fa614 tier1/karchive/KF5ArchiveConfig.cmake.in PRE-CREATION tier1/karchive/autotests/CMakeLists.txt a2cfabe tier1/karchive/examples/helloworld/CMakeLists.txt 2e90094 tier1/karchive/examples/tarlocalfiles/CMakeLists.txt b855caf tier1/karchive/src/CMakeLists.txt 767140a tier1/karchive/tests/CMakeLists.txt d804cd2 tier1/kcodecs/CMakeLists.txt a8217d0 tier1/kcodecs/KCodecsConfig.cmake.in ea632ce tier1/kcodecs/KF5CodecsConfig.cmake.in PRE-CREATION tier1/kcodecs/autotests/CMakeLists.txt bf393f8 tier1/kcodecs/src/CMakeLists.txt 152bc8e tier1/kconfig/CMakeLists.txt af91aa2 tier1/kconfig/KConfigConfig.cmake.in 5d9d7eb tier1/kconfig/KConfigMacros.cmake ec354a9 tier1/kconfig/KF5ConfigConfig.cmake.in PRE-CREATION tier1/kconfig/KF5ConfigMacros.cmake PRE-CREATION tier1/kconfig/autotests/CMakeLists.txt cc2626b tier1/kconfig/autotests/kconfig_compiler/CMakeLists.txt 184ab17 tier1/kconfig/src/core/CMakeLists.txt c8a4842 tier1/kconfig/src/gui/CMakeLists.txt b677d03 tier1/kconfig/src/kconf_update/CMakeLists.txt 69668bc tier1/kconfig/src/kconfig_compiler/CMakeLists.txt 19d86d4 tier1/kcoreaddons/CMakeLists.txt 5d2b4a8 tier1/kcoreaddons/KCoreAddonsConfig.cmake.in a53be5f tier1/kcoreaddons/KF5CoreAddonsConfig.cmake.in PRE-CREATION tier1/kcoreaddons/autotests/CMakeLists.txt c804357 tier1/kcoreaddons/src/lib/CMakeLists.txt 638525f tier1/kcoreaddons/tests/CMakeLists.txt c79d0ba tier1/kdbusaddons/CMakeLists.txt 78cc443 tier1/kdbusaddons/KDBusAddonsConfig.cmake.in 27a6060 tier1/kdbusaddons/KF5DBusAddonsConfig.cmake.in PRE-CREATION tier1/kdbusaddons/autotests/CMakeLists.txt 92c9151 tier1/kdbusaddons/src/CMakeLists.txt 71dc290 tier1/kdbusaddons/tests/CMakeLists.txt 684fee3 tier1/kguiaddons/CMakeLists.txt b3f378d tier1/kguiaddons/KF5GuiAddonsConfig.cmake.in PRE-CREATION tier1/kguiaddons/KGuiAddonsConfig.cmake.in 83e4c91 tier1/kguiaddons/autotests/CMakeLists.txt 2e4a6bb tier1/kguiaddons/src/CMakeLists.txt ca94f4b tier1/kguiaddons/tests/CMakeLists.txt 754b460 tier1/kidletime/CMakeLists.txt 61ba25b tier1/kidletime/KF5IdleTimeConfig.cmake.in PRE-CREATION tier1/kidletime/KIdleTimeConfig.cmake.in ace9e8a tier1/kidletime/examples/CMakeLists.txt c88a6c3 tier1/kidletime/src/CMakeLists.txt 44a1f3f tier1/kjs/CMakeLists.txt ab27a14 tier1/kjs/KF5JSConfig.cmake.in PRE-CREATION tier1/kjs/KJSConfig.cmake.in 8c4ff9e tier1/kjs/autotests/CMakeLists.txt 206c17a tier1/kjs/src/kjs/CMakeLists.txt b63d92f tier1/kjs/src/kjs/api/CMakeLists.txt dadf39c tier1/kjs/tests/CMakeLists.txt 9388a70 tier1/kplotting/CMakeLists.txt f8e53ff tier1/kplotting/KF5PlottingConfig.cmake.in PRE-CREATION tier1/kplotting/KPlottingConfig.cmake.in 42d4fae tier1/kplotting/autotests/CMakeLists.txt cc03ea4 tier1/kplotting/examples/CMakeLists.txt 7c8ab7e tier1/kplotting/src/CMakeLists.txt 59e7d09 tier1/kwidgetsaddons/CMakeLists.txt 570630b tier1/kwidgetsaddons/KF5WidgetsAddonsConfig.cmake.in PRE-CREATION tier1/kwidgetsaddons/KWidgetsAddonsConfig.cmake.in 98dbc46 tier1/kwidgetsaddons/autotests/CMakeLists.txt 1f6b69f tier1/kwidgetsaddons/src/CMakeLists.txt 0333f3a tier1/kwidgetsaddons/tests/CMakeLists.txt 129504b tier1/kwindowsystem/CMakeLists.txt cebdf49 tier1/kwindowsystem/KF5WindowSystemConfig.cmake.in PRE-CREATION tier1/kwindowsystem/KWindowSystemConfig.cmake.in 49308aa tier1/kwindowsystem/autotests/CMakeLists.txt 92d4868 tier1/kwindowsystem/src/CMakeLists.txt f6e27ee tier1/kwindowsystem/tests/CMakeLists.txt f2ae072 tier1/solid/CMakeLists.txt 6676410 tier1/solid/KF5SolidConfig.cmake.in PRE-CREATION
Review Request 114394: KFormat - Add new KFormat class (take 2)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114394/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository: kdelibs Description --- Replacement for https://git.reviewboard.kde.org/r/114187/; done as two commits. The first is John's original patch, with him listed as the commit author. The second is my modifications. Hopefully this will be flexible enough for translators. See the if this does not fit the grammar of your language comments for possible problem points. Added Albert, as I would appreciate the view of someone knowledgable about i18n. - KLocale offers a number of extra formatting options not yet available in Qt. The KFormat class adds these options to KCoreAddons: * formatByteSize() * formatDuration() * formatDecimalDuration() * formatSpelloutDuration() * formatRelativeDate() * formatRelativeDateTime() The KFormat class can be initialised with any QLocale to use in the date and number formatting, or the default locale can be easily accessed via KFormat(): QString result = KFormat().formatDuration(1000); Diffs - tier1/kcoreaddons/autotests/CMakeLists.txt c8043576181e7d06663195d017be930d0bdcbde9 tier1/kcoreaddons/autotests/kformattest.h PRE-CREATION tier1/kcoreaddons/autotests/kformattest.cpp PRE-CREATION tier1/kcoreaddons/src/lib/CMakeLists.txt 638525f7b719bcd0bc1dfdf94debd51296521334 tier1/kcoreaddons/src/lib/util/kformat.h PRE-CREATION tier1/kcoreaddons/src/lib/util/kformat.cpp PRE-CREATION tier1/kcoreaddons/src/lib/util/kformatprivate.cpp PRE-CREATION tier1/kcoreaddons/src/lib/util/kformatprivate_p.h PRE-CREATION Diff: http://git.reviewboard.kde.org/r/114394/diff/ Testing --- Autotests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Using KCompressionDevice with QSaveFile
On Tuesday 10 December 2013 23:31:33 David Faure wrote: On Tuesday 10 December 2013 21:48:09 Dominik Haumann wrote: However, here it comes: Changing -KCompressionDevice device(file, false, KCompressionDevice::GZip); +KCompressionDevice device(file, false, KCompressionDevice::None); will run into this issue. Great. A unittest patch to make it fail was exactly what I needed :) Very good. In that case, the unit test does the following: QWARN : KFilterTest::test_saveFile() QSaveFile::open: File (tier1/karchive/autotests/test_saveFile.gz) already open QFATAL : KFilterTest::test_saveFile() QSaveFile::close called FAIL! : KFilterTest::test_saveFile() Received a fatal error. Yep. It seems that the behavior for None is different. Interestingly, KSaveFile also behaved like this (KFilterDev did not change after all I guess). I'm surprised, because KCompressionDevice::None didn't exist before, it was all new code in KF5. KFilterDev had very different code in KDE4, and no support for no compression itself (deviceFromFile would simply return a QFile instead of a KFilterDev, in that case). I did not look too closely into the KDE4 way, but we needed some kind of if there, too (according to Christoph). Well, nevermind ;) Anyhow, it's fixed now, I rewrote the new none filter. Thanks! I will try on the weekend. And this case was caught with an if in Kate Part's file saving code. So yes, we can work around it again, just before. But: I do not really get why KCompressionDevice works completely different depending on the compression type. This makes using KCompressionDevice pretty ugly (im_h_o), since you have to manually check for None and take a different code path. No need to convince me, I'm fully convinced :-) ;) Best, Dominik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112463: Port SMB kioslave to KF5/Qt5
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review45520 --- Ship it! - Aleix Pol Gonzalez On Dec. 10, 2013, 6:51 p.m., Mark Gaiser wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/ --- (Updated Dec. 10, 2013, 6:51 p.m.) Review request for KDE Runtime and KDE Frameworks. Repository: kde-runtime Description --- This is the initial port! I added two TODO lines in the diff for parts where i'm not sure if I've ported them correctly. Also, i needed a change in FindSamba.cmake to even get the samba detection working. That reviewrequest is waiting here: https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use samba 3.x Once i know that this is actually working then i will comment some qDebug lines. Diffs - kioslave/CMakeLists.txt fc594e4 kioslave/smb/CMakeLists.txt a3a2265 kioslave/smb/kio_smb.h c2229ab kioslave/smb/kio_smb.cpp 2c2523a kioslave/smb/kio_smb_auth.cpp 4d236b4 kioslave/smb/kio_smb_browse.cpp 5253be9 kioslave/smb/kio_smb_dir.cpp ba80c86 kioslave/smb/kio_smb_file.cpp 206526a kioslave/smb/kio_smb_internal.h 4b946c1 kioslave/smb/kio_smb_internal.cpp e943844 kioslave/smb/kio_smb_mount.cpp a5a7e8e kioslave/smb/kio_smb_win.h f1dcb6f kioslave/smb/kio_smb_win.cpp 14dd797 Diff: http://git.reviewboard.kde.org/r/112463/diff/ Testing --- It compiles and gets loaded just fine. I tried testing this on an actual samba share, but i kept getting a 111 error (connection refused) from kio_smb so i'm hoping that is a local issue here. If someone else could try this out and verify that it's either working or broken. Thanks, Mark Gaiser ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112463: Port SMB kioslave to KF5/Qt5
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review45522 --- This review has been submitted with commit 728309ac2a80cab8feba4ef28f33725c59411bcf by Mark Gaiser to branch frameworks. - Commit Hook On Dec. 10, 2013, 6:51 p.m., Mark Gaiser wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/ --- (Updated Dec. 10, 2013, 6:51 p.m.) Review request for KDE Runtime and KDE Frameworks. Repository: kde-runtime Description --- This is the initial port! I added two TODO lines in the diff for parts where i'm not sure if I've ported them correctly. Also, i needed a change in FindSamba.cmake to even get the samba detection working. That reviewrequest is waiting here: https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use samba 3.x Once i know that this is actually working then i will comment some qDebug lines. Diffs - kioslave/CMakeLists.txt fc594e4 kioslave/smb/CMakeLists.txt a3a2265 kioslave/smb/kio_smb.h c2229ab kioslave/smb/kio_smb.cpp 2c2523a kioslave/smb/kio_smb_auth.cpp 4d236b4 kioslave/smb/kio_smb_browse.cpp 5253be9 kioslave/smb/kio_smb_dir.cpp ba80c86 kioslave/smb/kio_smb_file.cpp 206526a kioslave/smb/kio_smb_internal.h 4b946c1 kioslave/smb/kio_smb_internal.cpp e943844 kioslave/smb/kio_smb_mount.cpp a5a7e8e kioslave/smb/kio_smb_win.h f1dcb6f kioslave/smb/kio_smb_win.cpp 14dd797 Diff: http://git.reviewboard.kde.org/r/112463/diff/ Testing --- It compiles and gets loaded just fine. I tried testing this on an actual samba share, but i kept getting a 111 error (connection refused) from kio_smb so i'm hoping that is a local issue here. If someone else could try this out and verify that it's either working or broken. Thanks, Mark Gaiser ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
