Re: Review Request 115225: Add runtime platform support to KWindowInfo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115225/ --- (Updated Jan. 23, 2014, 9:09 a.m.) Review request for KDE Frameworks and kdewin. Changes --- I gave a try to a templated approach to not have the virtual methods in the Private. Repository: kwindowsystem Description --- Add runtime platform support to KWindowInfo Main idea of this change is to only pick the X11 implementation in case that the application is running on the X11 platform. So far it was a compile time switch which meant that if compiled with X11 support but not running on the X11 platform it would have caused runtime errors. To make this possible a KWindowInfoPrivate class with a dummy implementation is provided. This is used as d-ptr for KWindowInfo. Thus there is one generic implementation and the implementation of KWindowInfo is no longer ifdefed for the supported platforms. The platform specific code can inherit from KWindowInfoPrivate and overwrite the dummy method implementation. KWindowInfoPrivate provides a factory method where the platform specific implementation can be hooked into. There we can have both compile time and runtime checking. If there is no platfom specific implementation available the dummy implementation is used. NOTE: THIS CHANGE BREAKS THE WINDOWS AND MAC BACKEND! Windows and Mac is excluded from build. At the moment they get the dummy implementation. Unfortunately I don't have the possibility to compile the changes and thus don't dare to touch the code. Fixes from the teams are highly appreciated. Diffs (updated) - src/CMakeLists.txt e32a1150a2c190f23ad456ca8218b012c5d71507 src/kwindowinfo.h 171f441ff329a5356ccf560341272199e20c837a src/kwindowinfo.cpp PRE-CREATION src/kwindowinfo_p.h PRE-CREATION src/kwindowinfo_p_x11.h PRE-CREATION src/kwindowinfo_x11.cpp 865d8bed085e987f97f479ea8aa0e6de8567586f Diff: https://git.reviewboard.kde.org/r/115225/diff/ Testing --- Unit test from https://git.reviewboard.kde.org/r/115190/ is still working. Now you can guess why I wrote that test ;-) Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115248: Add runtime detection to KXMessages
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115248/ --- Review request for KDE Frameworks. Repository: kwindowsystem Description --- Add runtime detection to KXMessages KXMessages should only be used if we are on platformX11. A compile time check is not enough. Diffs - src/kxmessages.cpp b409ef2114c18190188ba5503d2f357bd9336e76 Diff: https://git.reviewboard.kde.org/r/115248/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115249: Add runtime detection to KUserTimestamp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115249/ --- Review request for KDE Frameworks. Repository: kwindowsystem Description --- Add runtime detection to KUserTimestamp KUserTimestamp methods should only be used if we are on platformX11. A compile time check is not enough. Diffs - src/kusertimestamp.cpp de8ca61e7e9dd0ae9492ccf61883560d80501e2b Diff: https://git.reviewboard.kde.org/r/115249/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/#review48092 --- Ship it! Oh, OK, didn't know this was broken on MSVC. Worth a Qt fix or at least bugreport? - David Faure On Jan. 22, 2014, 5:51 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/ --- (Updated Jan. 22, 2014, 5:51 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Only set QT_STRICT_ITERATORS when not compiling with MSVC On MSVC linker errors will happen when this flag is set. Diffs - kde-modules/KDEFrameworkCompilerSettings.cmake d71c407f9c0b504ebb1c0cf662e69545f7a46371 Diff: https://git.reviewboard.kde.org/r/115234/diff/ Testing --- E.g. KConfigWidgets didn't compile before, compiles now Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115236: Get closer to compiling KIO on windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115236/#review48093 --- Has this been compile-tested on Linux? - David Faure On Jan. 22, 2014, 9:12 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115236/ --- (Updated Jan. 22, 2014, 9:12 p.m.) Review request for KDE Frameworks. Repository: kio Description --- 3 Commits to get closer to compiling on windows: 1. Include qplatformdefs.h where possible unistd.h and others are not available on e.g. Windows, qplatformdefs.h includes the equivalent for each platform 2. add include(CheckLibraryExists) to CMakeLists.txt On Linux this is apparently pulled in by some other file whereas it is missing on Windows 3. Make KIO::MetaData completely inline to prevent linker errors on MSVC Diffs - src/ioslaves/ftp/ftp.h ad94979829a5d0e71ec57177b51f67e115c5445e src/ioslaves/ftp/ftp.cpp 9ea642587bd754f0b4295fcb7d4db1b427f4326e src/ioslaves/help/kio_help.h 0eab4ce1b393b48e552ca94d877f4c069450cee0 src/ioslaves/http/http.cpp 4f97b335c0e206f0a2ff8cfd515d0fae79614ad2 src/ioslaves/http/http_cache_cleaner.cpp ffa8ab9580acf554b27027617cdac06b3f7755bf src/widgets/kdirmodel.cpp ce6e4c9aaddada5715b5aeef36ad163c77d3c635 src/widgets/kpropertiesdialog.cpp 8ddd37f0326e37109ce239a46bfa67d2f4c35411 src/widgets/krun.cpp 92dcfd8da04b9f3d80b632a37758017c088093ab src/widgets/kurlcompletion.cpp ed77fd3213db0524b5a934c94eb7645d98bd27c7 tests/kioslavetest.cpp dc56240dc166dfa93ec099db5cdd262cc06249d4 tests/kruntest.cpp 68720ddf788e6b44468baf18dd04937094741274 CMakeLists.txt 9894ad5e1696fe31d8a3f065d29747cde0474d2c autotests/fileundomanagertest.cpp 4ddee49eed254be6379a1302af2dd17aae28c15c autotests/kurlcompletiontest.cpp 10048e2e15059596e446b03cedb0b302bf038cd5 src/core/chmodjob.cpp b60cb9bf3d3b1a71a795ee5db7c72253dbdf0ad2 src/core/kacl.h 3c9c88d0408c855d02eaacb34d14f45c55343eb2 src/core/kacl.cpp 201b30a02ef93a137b9a8507cabaece6926d8739 src/core/kfileitem.h 553dbf8ccf96983803d0224cf8dc9d72f0107b6a src/core/kfileitem.cpp fdc0fc0279713887dc18ce1da8d3b00d422f6a9b src/core/kprotocolmanager.cpp a8746a4f9a78e6a01eaed6a70e99146ff40129d2 src/core/krecentdocument.cpp ad0a97e7c1af85a94bb7483124b5035f0fca38a6 src/core/metadata.h cd62e3b009c21485537ddd5449a6c347748c3caf src/core/metadata.cpp ad05032dff58314a305256993fcc7fe7b94751bc src/core/slave.h 43b5cd8e8aa11da55d6f8a8d9fdf4eb3d0780d11 src/core/slave.cpp ef9b3c7a57b4f4384343c4d4296ec88add857eb6 src/core/slavebase.cpp a7ac4d5a6a87c256da9a3947b7223649927eba39 src/core/slaveinterface.h d75eb6b02374375a73e1aaa57d5c2979a3bc365f src/core/slaveinterface.cpp faa4bd7dc1b5a733f0060f60626e8a0313bfea8a src/core/slaveinterface_p.h 0ed4980a06f8aa8b3fc8c0717e4a88991483e98a src/filewidgets/kfileplaceeditdialog.cpp a7c433c8baecca8082f8d80077deab68e4b0cec2 src/filewidgets/knewfilemenu.cpp dfc086b6e98b965739c062d7291bbd9139633beb src/ioslaves/file/file.h 453298159791a78d877c4d81d2be73db073db3f2 src/ioslaves/file/file.cpp e3ede0daa8054fc33d12acb9966a707f9484cd98 src/ioslaves/file/file_win.cpp 53e0f8f133bd5c4cbbd07afa945854efffc7297c Diff: https://git.reviewboard.kde.org/r/115236/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115165: Use a proper temporary file for the doxygen config
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115165/#review48094 --- Ship it! Looks good to me. Just a nitpick, feel free to commit when it is fixed. src/kapidox/__init__.py https://git.reviewboard.kde.org/r/115165/#comment34040 nitpick: add a space before doxyfile_path. Issue was already there, but since you are touching this line, let's fix it. - Aurélien Gâteau On Jan. 21, 2014, 2:52 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115165/ --- (Updated Jan. 21, 2014, 2:52 p.m.) Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapidox Description --- Use a proper temporary file for the doxygen config Diffs - src/kapidox/__init__.py 554bd2412dfa8c279a78c969de765d36b51236ba Diff: https://git.reviewboard.kde.org/r/115165/diff/ Testing --- Ran kgenapidox on threadweaver with both python2 and python3. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115166: Add a CMakeLists.txt which wraps python setup.py
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115166/ --- (Updated Jan. 23, 2014, 10:44 a.m.) Status -- This change has been discarded. Review request for Build System, KDE Frameworks and Alex Merry. Repository: kapidox Description --- To fix build failures with kdesrc-build, add a CMakeLists.txt which wraps python setup.py. Diffs - README.md 660e9c3 CMakeLists.txt PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115166/diff/ Testing --- Built and installed with the classic CMake commands. The kapidox tools work fine as long as the installation prefix is either the system one, or defined in $PYTHONPATH. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115166: Add a CMakeLists.txt which wraps python setup.py
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115166/#review48095 --- This review has been submitted with commit 1729071b1bd7060aaa1d1b0fe33ad384f25087b9 by Aurélien Gâteau to branch master. - Commit Hook On Jan. 23, 2014, 9:44 a.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115166/ --- (Updated Jan. 23, 2014, 9:44 a.m.) Review request for Build System, KDE Frameworks and Alex Merry. Repository: kapidox Description --- To fix build failures with kdesrc-build, add a CMakeLists.txt which wraps python setup.py. Diffs - README.md 660e9c3 CMakeLists.txt PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115166/diff/ Testing --- Built and installed with the classic CMake commands. The kapidox tools work fine as long as the installation prefix is either the system one, or defined in $PYTHONPATH. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115166: Add a CMakeLists.txt which wraps python setup.py
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115166/ --- (Updated Jan. 23, 2014, 9:47 a.m.) Status -- This change has been marked as submitted. Review request for Build System, KDE Frameworks and Alex Merry. Repository: kapidox Description --- To fix build failures with kdesrc-build, add a CMakeLists.txt which wraps python setup.py. Diffs - README.md 660e9c3 CMakeLists.txt PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115166/diff/ Testing --- Built and installed with the classic CMake commands. The kapidox tools work fine as long as the installation prefix is either the system one, or defined in $PYTHONPATH. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115251/ --- Review request for KDE Frameworks. Repository: kwindowsystem Description --- Add better runtime detection for X11 usage in KStartupInfo Compile time checks for X11 is no longer sufficient. This adds a runtime check to all the code paths which look dangerous if executed on a non-X11 platform. Diffs - src/kstartupinfo.cpp 5dbf47cb666fbed17c943491efe93e17f27d581e Diff: https://git.reviewboard.kde.org/r/115251/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115253: Rename kf5dot-* tools to depdiag-*
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115253/ --- Review request for KDE Frameworks and Alex Merry. Repository: kapidox Description --- This new name should be less cryptic. Diffs - README.md c1fe269 setup.py c87944c src/depdiag-generate PRE-CREATION src/depdiag-generate-all PRE-CREATION src/depdiag-prepare PRE-CREATION src/kapidox/depdiag/block.py PRE-CREATION src/kapidox/depdiag/framework.py PRE-CREATION src/kapidox/depdiag/frameworkdb.py PRE-CREATION src/kapidox/kf5dot/__init__.py e69de29 src/kapidox/kf5dot/block.py 045fbf5 src/kapidox/kf5dot/framework.py 21f4cf6 src/kapidox/kf5dot/frameworkdb.py 63f7e27 src/kf5dot-generate 8d44e20 src/kf5dot-generate-all 244ed12 src/kf5dot-prepare 3d133d9 Diff: https://git.reviewboard.kde.org/r/115253/diff/ Testing --- Regenerated dependency diagrams. Works fine. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115253: Rename kf5dot-* tools to depdiagram-*
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115253/ --- (Updated Jan. 23, 2014, 11:55 a.m.) Review request for KDE Frameworks and Aurélien Gâteau. Changes --- turns out depdiag- can be interpreted as dependency diagnose. depdiagram- is less ambiguous. Summary (updated) - Rename kf5dot-* tools to depdiagram-* Repository: kapidox Description --- This new name should be less cryptic. Diffs (updated) - README.md c1fe269 setup.py c87944c src/depdiagram-generate PRE-CREATION src/depdiagram-generate-all PRE-CREATION src/depdiagram-prepare PRE-CREATION src/kapidox/depdiagram/block.py PRE-CREATION src/kapidox/depdiagram/framework.py PRE-CREATION src/kapidox/depdiagram/frameworkdb.py PRE-CREATION src/kapidox/kf5dot/__init__.py e69de29 src/kapidox/kf5dot/block.py 045fbf5 src/kapidox/kf5dot/framework.py 21f4cf6 src/kapidox/kf5dot/frameworkdb.py 63f7e27 src/kf5dot-generate 8d44e20 src/kf5dot-generate-all 244ed12 src/kf5dot-prepare 3d133d9 Diff: https://git.reviewboard.kde.org/r/115253/diff/ Testing --- Regenerated dependency diagrams. Works fine. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115253: Rename kf5dot-* tools to depdiagram-*
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115253/ --- (Updated Jan. 23, 2014, 11:55 a.m.) Review request for KDE Frameworks and Alex Merry. Repository: kapidox Description --- This new name should be less cryptic. Diffs - README.md c1fe269 setup.py c87944c src/depdiagram-generate PRE-CREATION src/depdiagram-generate-all PRE-CREATION src/depdiagram-prepare PRE-CREATION src/kapidox/depdiagram/block.py PRE-CREATION src/kapidox/depdiagram/framework.py PRE-CREATION src/kapidox/depdiagram/frameworkdb.py PRE-CREATION src/kapidox/kf5dot/__init__.py e69de29 src/kapidox/kf5dot/block.py 045fbf5 src/kapidox/kf5dot/framework.py 21f4cf6 src/kapidox/kf5dot/frameworkdb.py 63f7e27 src/kf5dot-generate 8d44e20 src/kf5dot-generate-all 244ed12 src/kf5dot-prepare 3d133d9 Diff: https://git.reviewboard.kde.org/r/115253/diff/ Testing --- Regenerated dependency diagrams. Works fine. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC
On Jan. 23, 2014, 9:28 a.m., David Faure wrote: Oh, OK, didn't know this was broken on MSVC. Worth a Qt fix or at least bugreport? Thiago reported it: see http://lists.kde.org/?l=kde-buildsystemm=139042097719628w=2 and https://codereview.qt-project.org/#change,76311 - Luigi --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/#review48092 --- On Jan. 22, 2014, 5:51 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/ --- (Updated Jan. 22, 2014, 5:51 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Only set QT_STRICT_ITERATORS when not compiling with MSVC On MSVC linker errors will happen when this flag is set. Diffs - kde-modules/KDEFrameworkCompilerSettings.cmake d71c407f9c0b504ebb1c0cf662e69545f7a46371 Diff: https://git.reviewboard.kde.org/r/115234/diff/ Testing --- E.g. KConfigWidgets didn't compile before, compiles now Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115255: Add x11 platform detection to kkeyserver_x11
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115255/ --- Review request for KDE Frameworks. Repository: kwindowsystem Description --- Add x11 platform detection to kkeyserver_x11 Just because it's only compiled for X11 doesn't mean it's running on X11. So before we go into code paths which call into X11 we should verify. That's better than: QX11Info::display() returns 0. I'm probably going to crash now. Not adjusted are obvious X11 methods which take an XLib or xcb data type. If one calls those from non-x11 unconditionally it's an application bug and the application deserves to crash :-P Diffs - src/kkeyserver_x11.cpp fd0ca5b25f09808e211198ce0f7aa56aa21e05f4 Diff: https://git.reviewboard.kde.org/r/115255/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Tier status of attica kwallet
On 01/23/2014 08:21 AM, Valentin Rusu wrote: On Thursday, January 23, 2014 04:24:37 AM Michael Palimaka wrote: Hi, attica seems to have been absorbed as a framework, but does not appear to have been assigned a tier. Based on its dependencies, it looks like it would fit in tier 1? kwallet is in tier 2, but since b60582640d99e0ef603bf4e02df974793fb5ad27 it includes kwalletd which depends on higher tier frameworks - does it still belong in tier 2? kwallet-framework is still tier2, as there are no higher dependencies, AFAIK. Sure, the framework itself is still tier 2...but the repo also includes kwalletd which definitely is not tier 2, and there does not appear to be any option to control building them independently. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115218: rename dbus interface file on install for kwallet
On Jan. 22, 2014, 9:27 p.m., Valentin Rusu wrote: src/api/KWallet/CMakeLists.txt, line 100 https://git.reviewboard.kde.org/r/115218/diff/1/?file=235142#file235142line100 The interface will be strictly the same. New features will be added to secret service. That's why I didn't consider changing it's name. And, btw, changing it's name will make users think that changes have been (or will be) done to this API. Hrvoje Senjan wrote: @Valentin, interface name is now org.kde.kwalletd5, as per your last change in api/KWallet/kwallet.cpp runtime/kwalletd/kwalletd.cpp. Yes you changed the interface which you say is unnecessary. My patch is just a change of filename to allow co-installability with kdelibs4 but the dbus interface name isn't changed. - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115218/#review48079 --- On Jan. 22, 2014, 11:23 a.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115218/ --- (Updated Jan. 22, 2014, 11:23 a.m.) Review request for KDE Frameworks and Valentin Rusu. Repository: kwallet-framework Description --- Rename kwallet dbus interface file on install so it does not clash with equivalent file from kdelibs4. The dbus interface remains the same to keep compatibility with kdelibs4 kwallet. However you seem to have renamed the interface in places in the code in runtime/, will it be incompatible with the version from kdelibs4? Diffs - src/api/KWallet/CMakeLists.txt d0d5a3d Diff: https://git.reviewboard.kde.org/r/115218/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115186: rename dbus interface file for kjobviewer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115186/#review48108 --- FWIW the diff works fine here. - Michael Palimaka On Jan. 21, 2014, 5:02 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115186/ --- (Updated Jan. 21, 2014, 5:02 p.m.) Review request for KDE Frameworks. Repository: kjobwidgets Description --- This dbus interface file also gets installed in kdelibs4 which overlaps it in kf5, some distros can not handle this. So rename the file on install. The dbus interface remains the same. This is the same technique used for kglobalaccel. Diffs - src/CMakeLists.txt 7527a0a Diff: https://git.reviewboard.kde.org/r/115186/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115212: Fix windows build + 1 compiler warning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115212/#review48110 --- Ship it! OK, good to go :-) - Alex Merry On Jan. 22, 2014, 6:01 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115212/ --- (Updated Jan. 22, 2014, 6:01 p.m.) Review request for KDE Frameworks. Repository: kxmlgui Description --- 3 separate commits: 1. Fix windows build with QT_NO_CAST_FROM_ASCII 2. m_collator already returs bool, remove check for 0 3. Don't use uname() and getpwuid() directly Added new functions that also do the right thing on Windows Diffs - src/kbugreport.cpp 56f088106becbccca5e9731abc04118a19e36ba9 src/CMakeLists.txt 4516a9ee3da774788c76f30f15181fa0049a9d86 src/ksendbugmail/CMakeLists.txt 12b4926ecddeb023315f6074ab57cfe6cdee65ff src/ksendbugmail/main.cpp 8f85f315f0746bb774175114b1e284e899957fd3 src/ksendbugmail/smtp.cpp 90b6b98467b0c220cfef18bc35cf3c07df9a8cf3 src/kshortcutseditoritem.cpp 086f833fc505f69a3b0dbe6fceffdb94ecd60330 src/systeminformation_p.h PRE-CREATION src/kkeysequencewidget.cpp cc9016b776c16984b83a36a2742526ede624bf5e Diff: https://git.reviewboard.kde.org/r/115212/diff/ Testing --- now it compiles on windows and Linux is still fine Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115165: Use a proper temporary file for the doxygen config
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115165/ --- (Updated Jan. 23, 2014, 12:59 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapidox Description --- Use a proper temporary file for the doxygen config Diffs - src/kapidox/__init__.py 554bd2412dfa8c279a78c969de765d36b51236ba Diff: https://git.reviewboard.kde.org/r/115165/diff/ Testing --- Ran kgenapidox on threadweaver with both python2 and python3. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Authors, maintainers and licenses in apidox
On 22/01/14 17:46, Jonathan Riddell wrote:
On Wed, Jan 22, 2014 at 12:27:29PM +, Alex Merry wrote:
I would be tempted to ditch the current LICENSE files (all three of
them), and add (summary) license info to README.md, as
The COPYING{.LIB,.DOC} files can't go away as there must be a full
copy of the licence text included with any code under that licence.
Else it's too easy to claim you weren't sure what the full licence
was. Many distributions would have trouble distributing it without
the full copy of the licences.
I absolutely agree that COPYING (GPL) and COPYING.LIB (LGPL) (and I
guess COPYING.DOC is the GNU fdl text?) files have to stay. I even said
as much in part of the email that you didn't quote :-)
The LICENSE files are in repos that don't have a GNU license, but are
instead BSD. They essentially say this code is BSD or whatever, and
include a copy of the license text that already is (or should be) at the
top of the relevant files.
Likewise, the COPYING-CMAKE-FILES contains text that is supposed to be
at the top of the relevant cmake files (the BSD license text doesn't
make sense without the attached copyright notices).
Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115259: Simplify the project directories that are searched for images etc
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115259/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapidox Description --- Simplify the project directories that are searched for images etc Files will be found under docs/ or under docs/api/ (except Doxygen.local, which must be under docs/api/) Diffs - README.md c1fe269a424366ec50ba18a31b71c28d96df2869 src/kapidox/__init__.py e6ffda63f96780c2ae71717054c097be6fec04bb Diff: https://git.reviewboard.kde.org/r/115259/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
QFileDialog not usable with frameworkintegration
Hi, as described in https://git.reviewboard.kde.org/r/115238/ there is a bug QFileDialog frameworkintegration. As opposed to written in the review request the dialog is not usable at the moment if someone wants to select a non-existing file because it crashes. 1. $ ./qfiledialogtest --acceptMode save --selectFile /tmp/moo.png 2. (Note that the selectFile has no effect) 3. Manually select a file 4. Edit the Name text box and write some non-existing name 5. Press ok 6. qfiledialogtest(4329)/(default) QFileInfo::absolutePath: QFileInfo::absolutePath: Constructed with empty filename qfiledialogtest(4329)/(default) qt_assert: ASSERT: d in file ../../include/QtCore/../../src/corelib/tools/qscopedpointer.h, line 120 Aborted Best regards Gregor ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Build failed in Jenkins: kde4support_master_qt5 #31
On Wed, Jan 22, 2014 at 3:28 AM, KDE CI System n...@kde.org wrote: In file included from http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k3socketaddress.cpp:45:0: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/netsupp.h:168:8: error: redefinition of ‘struct addrinfo’ In file included from http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/netsupp.h:30:0, from http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k3socketaddress.cpp:45: /usr/include/netdb.h:567:8: error: previous definition of ‘struct addrinfo’ make[2]: *** [src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3socketaddress.cpp.o] Error 1 http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/kcmdlineargs.cpp:654:66: note: #pragma message: KDE5 TODO: Remove this method once it is in Qt5 http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/kcmdlineargs.cpp: In static member function ‘static void KCmdLineArgsStatic::parseAllArgs()’: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/kcmdlineargs.cpp:890:60: note: #pragma message: KDE5 TODO: use kcoreaddons version number http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/kcmdlineargs.cpp: In static member function ‘static void KCmdLineArgs::enable_i18n()’: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/kcmdlineargs.cpp:1058:55: note: #pragma message: KDE5 NOTE: What about this method ? In file included from http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/netsupp.cpp:45:0: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/netsupp.h:168:8: error: redefinition of ‘struct addrinfo’ In file included from http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/netsupp.cpp:36:0: /usr/include/netdb.h:567:8: error: previous definition of ‘struct addrinfo’ make[2]: *** [src/CMakeFiles/KF5KDE4Support.dir/kdecore/netsupp.cpp.o] Error 1 http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/kurl.cpp: In member function ‘void KUrl::setPath(const QString)’: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/kurl.cpp:1644:72: note: #pragma message: KDE5 TODO: Remove tildeExpand feature for local paths make[1]: *** [src/CMakeFiles/KF5KDE4Support.dir/all] Error 2 make: *** [all] Error 2 I came across this build error and spent some time trying to fix it. While I didn't find a proper fix, I'm sharing my findings since I see it is still red in Jenkins and I have no more time to spend on this: The addrinfo struct defined in netsupp.h wouldn't be defined if the addrinfo struct from /usr/include/netdb.h was properly detected, but it is not properly detected because when CMake tries to find it through try_compile, the compilation has the -std=iso9899:1990 flag, which is set in ECM (KDECompilerSettings.cmake). I removed that flag and reinstalled ECM, then tried building KDE4Support again and it works. Questions that are left unanswered are what changed that caused this error and, of course, how to fix it properly. David E. Narvaez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115259: Simplify the project directories that are searched for images etc
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115259/ --- (Updated Jan. 23, 2014, 2:10 p.m.) Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapidox Description (updated) --- Simplify the project directories that are searched for images etc Files will be found under various docs/ subdirs (and docs/api is not considered any more). Diffs (updated) - README.md c1fe269a424366ec50ba18a31b71c28d96df2869 src/kapidox/__init__.py e6ffda63f96780c2ae71717054c097be6fec04bb Diff: https://git.reviewboard.kde.org/r/115259/diff/ Testing (updated) --- Ran kgenapidox on kbookmarks with python2 and python3. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC
On Jan. 23, 2014, 10:28 a.m., David Faure wrote: Oh, OK, didn't know this was broken on MSVC. Worth a Qt fix or at least bugreport? Luigi Toscano wrote: Thiago reported it: see http://lists.kde.org/?l=kde-buildsystemm=139042097719628w=2 and https://codereview.qt-project.org/#change,76311 Should I add a check for the Qt version? Obviously this will only work if Qt is searched for first - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/#review48092 --- On Jan. 22, 2014, 6:51 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/ --- (Updated Jan. 22, 2014, 6:51 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Only set QT_STRICT_ITERATORS when not compiling with MSVC On MSVC linker errors will happen when this flag is set. Diffs - kde-modules/KDEFrameworkCompilerSettings.cmake d71c407f9c0b504ebb1c0cf662e69545f7a46371 Diff: https://git.reviewboard.kde.org/r/115234/diff/ Testing --- E.g. KConfigWidgets didn't compile before, compiles now Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115236: Get closer to compiling KIO on windows
On Jan. 23, 2014, 10:35 a.m., David Faure wrote: Has this been compile-tested on Linux? Yeah, I check that all these windows changes work on linux, too. Don't want to break my primarily used platform ;) - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115236/#review48093 --- On Jan. 22, 2014, 10:12 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115236/ --- (Updated Jan. 22, 2014, 10:12 p.m.) Review request for KDE Frameworks. Repository: kio Description --- 3 Commits to get closer to compiling on windows: 1. Include qplatformdefs.h where possible unistd.h and others are not available on e.g. Windows, qplatformdefs.h includes the equivalent for each platform 2. add include(CheckLibraryExists) to CMakeLists.txt On Linux this is apparently pulled in by some other file whereas it is missing on Windows 3. Make KIO::MetaData completely inline to prevent linker errors on MSVC Diffs - src/ioslaves/ftp/ftp.h ad94979829a5d0e71ec57177b51f67e115c5445e src/ioslaves/ftp/ftp.cpp 9ea642587bd754f0b4295fcb7d4db1b427f4326e src/ioslaves/help/kio_help.h 0eab4ce1b393b48e552ca94d877f4c069450cee0 src/ioslaves/http/http.cpp 4f97b335c0e206f0a2ff8cfd515d0fae79614ad2 src/ioslaves/http/http_cache_cleaner.cpp ffa8ab9580acf554b27027617cdac06b3f7755bf src/widgets/kdirmodel.cpp ce6e4c9aaddada5715b5aeef36ad163c77d3c635 src/widgets/kpropertiesdialog.cpp 8ddd37f0326e37109ce239a46bfa67d2f4c35411 src/widgets/krun.cpp 92dcfd8da04b9f3d80b632a37758017c088093ab src/widgets/kurlcompletion.cpp ed77fd3213db0524b5a934c94eb7645d98bd27c7 tests/kioslavetest.cpp dc56240dc166dfa93ec099db5cdd262cc06249d4 tests/kruntest.cpp 68720ddf788e6b44468baf18dd04937094741274 CMakeLists.txt 9894ad5e1696fe31d8a3f065d29747cde0474d2c autotests/fileundomanagertest.cpp 4ddee49eed254be6379a1302af2dd17aae28c15c autotests/kurlcompletiontest.cpp 10048e2e15059596e446b03cedb0b302bf038cd5 src/core/chmodjob.cpp b60cb9bf3d3b1a71a795ee5db7c72253dbdf0ad2 src/core/kacl.h 3c9c88d0408c855d02eaacb34d14f45c55343eb2 src/core/kacl.cpp 201b30a02ef93a137b9a8507cabaece6926d8739 src/core/kfileitem.h 553dbf8ccf96983803d0224cf8dc9d72f0107b6a src/core/kfileitem.cpp fdc0fc0279713887dc18ce1da8d3b00d422f6a9b src/core/kprotocolmanager.cpp a8746a4f9a78e6a01eaed6a70e99146ff40129d2 src/core/krecentdocument.cpp ad0a97e7c1af85a94bb7483124b5035f0fca38a6 src/core/metadata.h cd62e3b009c21485537ddd5449a6c347748c3caf src/core/metadata.cpp ad05032dff58314a305256993fcc7fe7b94751bc src/core/slave.h 43b5cd8e8aa11da55d6f8a8d9fdf4eb3d0780d11 src/core/slave.cpp ef9b3c7a57b4f4384343c4d4296ec88add857eb6 src/core/slavebase.cpp a7ac4d5a6a87c256da9a3947b7223649927eba39 src/core/slaveinterface.h d75eb6b02374375a73e1aaa57d5c2979a3bc365f src/core/slaveinterface.cpp faa4bd7dc1b5a733f0060f60626e8a0313bfea8a src/core/slaveinterface_p.h 0ed4980a06f8aa8b3fc8c0717e4a88991483e98a src/filewidgets/kfileplaceeditdialog.cpp a7c433c8baecca8082f8d80077deab68e4b0cec2 src/filewidgets/knewfilemenu.cpp dfc086b6e98b965739c062d7291bbd9139633beb src/ioslaves/file/file.h 453298159791a78d877c4d81d2be73db073db3f2 src/ioslaves/file/file.cpp e3ede0daa8054fc33d12acb9966a707f9484cd98 src/ioslaves/file/file_win.cpp 53e0f8f133bd5c4cbbd07afa945854efffc7297c Diff: https://git.reviewboard.kde.org/r/115236/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115212: Fix windows build + 1 compiler warning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115212/#review48118 --- This review has been submitted with commit acbd665a79eba3ff33801366483a515a2442db43 by Alex Richardson to branch master. - Commit Hook On Jan. 22, 2014, 6:01 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115212/ --- (Updated Jan. 22, 2014, 6:01 p.m.) Review request for KDE Frameworks. Repository: kxmlgui Description --- 3 separate commits: 1. Fix windows build with QT_NO_CAST_FROM_ASCII 2. m_collator already returs bool, remove check for 0 3. Don't use uname() and getpwuid() directly Added new functions that also do the right thing on Windows Diffs - src/kbugreport.cpp 56f088106becbccca5e9731abc04118a19e36ba9 src/CMakeLists.txt 4516a9ee3da774788c76f30f15181fa0049a9d86 src/ksendbugmail/CMakeLists.txt 12b4926ecddeb023315f6074ab57cfe6cdee65ff src/ksendbugmail/main.cpp 8f85f315f0746bb774175114b1e284e899957fd3 src/ksendbugmail/smtp.cpp 90b6b98467b0c220cfef18bc35cf3c07df9a8cf3 src/kshortcutseditoritem.cpp 086f833fc505f69a3b0dbe6fceffdb94ecd60330 src/systeminformation_p.h PRE-CREATION src/kkeysequencewidget.cpp cc9016b776c16984b83a36a2742526ede624bf5e Diff: https://git.reviewboard.kde.org/r/115212/diff/ Testing --- now it compiles on windows and Linux is still fine Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115212: Fix windows build + 1 compiler warning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115212/#review48120 --- This review has been submitted with commit 27598328e3a4d046bb35fa328764cf1ec48c3e63 by Alex Richardson to branch master. - Commit Hook On Jan. 22, 2014, 6:01 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115212/ --- (Updated Jan. 22, 2014, 6:01 p.m.) Review request for KDE Frameworks. Repository: kxmlgui Description --- 3 separate commits: 1. Fix windows build with QT_NO_CAST_FROM_ASCII 2. m_collator already returs bool, remove check for 0 3. Don't use uname() and getpwuid() directly Added new functions that also do the right thing on Windows Diffs - src/kbugreport.cpp 56f088106becbccca5e9731abc04118a19e36ba9 src/CMakeLists.txt 4516a9ee3da774788c76f30f15181fa0049a9d86 src/ksendbugmail/CMakeLists.txt 12b4926ecddeb023315f6074ab57cfe6cdee65ff src/ksendbugmail/main.cpp 8f85f315f0746bb774175114b1e284e899957fd3 src/ksendbugmail/smtp.cpp 90b6b98467b0c220cfef18bc35cf3c07df9a8cf3 src/kshortcutseditoritem.cpp 086f833fc505f69a3b0dbe6fceffdb94ecd60330 src/systeminformation_p.h PRE-CREATION src/kkeysequencewidget.cpp cc9016b776c16984b83a36a2742526ede624bf5e Diff: https://git.reviewboard.kde.org/r/115212/diff/ Testing --- now it compiles on windows and Linux is still fine Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115212: Fix windows build + 1 compiler warning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115212/#review48119 --- This review has been submitted with commit f9f05e61581dbd742d068cd875c579162f02d9b8 by Alex Richardson to branch master. - Commit Hook On Jan. 22, 2014, 6:01 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115212/ --- (Updated Jan. 22, 2014, 6:01 p.m.) Review request for KDE Frameworks. Repository: kxmlgui Description --- 3 separate commits: 1. Fix windows build with QT_NO_CAST_FROM_ASCII 2. m_collator already returs bool, remove check for 0 3. Don't use uname() and getpwuid() directly Added new functions that also do the right thing on Windows Diffs - src/kbugreport.cpp 56f088106becbccca5e9731abc04118a19e36ba9 src/CMakeLists.txt 4516a9ee3da774788c76f30f15181fa0049a9d86 src/ksendbugmail/CMakeLists.txt 12b4926ecddeb023315f6074ab57cfe6cdee65ff src/ksendbugmail/main.cpp 8f85f315f0746bb774175114b1e284e899957fd3 src/ksendbugmail/smtp.cpp 90b6b98467b0c220cfef18bc35cf3c07df9a8cf3 src/kshortcutseditoritem.cpp 086f833fc505f69a3b0dbe6fceffdb94ecd60330 src/systeminformation_p.h PRE-CREATION src/kkeysequencewidget.cpp cc9016b776c16984b83a36a2742526ede624bf5e Diff: https://git.reviewboard.kde.org/r/115212/diff/ Testing --- now it compiles on windows and Linux is still fine Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115212: Fix windows build + 1 compiler warning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115212/ --- (Updated Jan. 23, 2014, 2:22 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kxmlgui Description --- 3 separate commits: 1. Fix windows build with QT_NO_CAST_FROM_ASCII 2. m_collator already returs bool, remove check for 0 3. Don't use uname() and getpwuid() directly Added new functions that also do the right thing on Windows Diffs - src/kbugreport.cpp 56f088106becbccca5e9731abc04118a19e36ba9 src/CMakeLists.txt 4516a9ee3da774788c76f30f15181fa0049a9d86 src/ksendbugmail/CMakeLists.txt 12b4926ecddeb023315f6074ab57cfe6cdee65ff src/ksendbugmail/main.cpp 8f85f315f0746bb774175114b1e284e899957fd3 src/ksendbugmail/smtp.cpp 90b6b98467b0c220cfef18bc35cf3c07df9a8cf3 src/kshortcutseditoritem.cpp 086f833fc505f69a3b0dbe6fceffdb94ecd60330 src/systeminformation_p.h PRE-CREATION src/kkeysequencewidget.cpp cc9016b776c16984b83a36a2742526ede624bf5e Diff: https://git.reviewboard.kde.org/r/115212/diff/ Testing --- now it compiles on windows and Linux is still fine Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kde4support_master_qt5 #32
See http://build.kde.org/job/kde4support_master_qt5/32/changes Changes: [agateau] Move api doc images to docs/pics -- [...truncated 629 lines...] Generating moc_kmessageboxmessagehandler.cpp Generating moc_knumvalidator.cpp Generating moc_kpassivepopupmessagehandler.cpp Generating moc_krestrictedline.cpp Generating moc_ksplashscreen.cpp Generating moc_kstatusbar.cpp Generating moc_kstringvalidator.cpp Generating moc_ktabbar.cpp Generating moc_ktextbrowser.cpp Generating moc_kundostack.cpp Generating moc_kvbox.cpp Generating moc_kdatatool.cpp Generating moc_kfileitemactionplugin.cpp Generating moc_kfilewriteplugin.cpp Generating moc_kscan.cpp Generating moc_metainfojob.cpp Generating moc_netaccess.cpp Generating moc_passworddialog.cpp Generating moc_factory.cpp [ 24%] Built target KF5KDE4Support_automoc Scanning dependencies of target KF5KDE4Support [ 24%] [ 24%] [ 24%] [ 25%] [ 25%] [ 25%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k4aboutdata.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kcomponentdata.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kdebug.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kdeversion.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kdebugdbusiface.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kkernel_mac.cpp.o [ 25%] [ 25%] [ 26%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kkernel_win.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/klibloader.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/ktemporaryfile.cpp.o [ 26%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/ktempdir.cpp.o http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k4aboutdata.cpp: In member function ‘void K4AboutData::translateInternalProgramName() const’: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k4aboutdata.cpp:723:92: note: #pragma message: KDE5 FIXME: This code must be replaced by something with KLocalizedString http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k4aboutdata.cpp: In member function ‘QListK4AboutPerson K4AboutData::translators() const’: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k4aboutdata.cpp:832:52: note: #pragma message: KDE5 TODO: What about this code ? [ 26%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kmd5.cpp.o [ 27%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kmimetype.cpp.o [ 27%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kmimetyperepository.cpp.o [ 27%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/ksavefile.cpp.o [ 27%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/ksocketfactory.cpp.o http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/klibloader.cpp: In member function ‘KPluginFactory* KLibLoader::factory(const QString, QLibrary::LoadHints)’: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/klibloader.cpp:136:40: warning: ‘KPluginFactory* KLibrary::factory(const char*)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/klibrary.h:58) [-Wdeprecated-declarations] [ 28%] [ 28%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3socks.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3sockssocketdevice.cpp.o [ 28%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3socketdevice.cpp.o [ 29%] [ 29%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3clientsocketbase.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3bufferedsocket.cpp.o [ 29%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3resolver.cpp.o [ 29%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3resolvermanager.cpp.o [ 29%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3resolverworkerbase.cpp.o [ 30%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3resolverstandardworkers.cpp.o [ 30%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3reverseresolver.cpp.o In file included from http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k3socketdevice.h:29:0, from http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k3sockssocketdevice.h:23, from http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k3sockssocketdevice.cpp:20: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k3socketbase.h:700:20: warning: ‘virtual qint64 KNetwork::KActiveSocketBase::readData(char*, qint64)’ was hidden [-Woverloaded-virtual] In file included from http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k3sockssocketdevice.h:23:0, from
Re: Review Request 115225: Add runtime platform support to KWindowInfo
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115225/#review48124
---
Wouldn't this be easier using methods with the subclass as a template parameter
instead of the enum. I.e:
class KWindowSystemPrivate {
//
template class Impl
inline unsigned long state() const
{
// use a different name to prevent infinite recursion in case this is
called with KWindowSystemPrivate as a template parameter
return static_castImpl*(this)-stateImpl();
}
//
};
class KWindowSystemPrivateDummy : public KWindowSystemPrivate {
//
inline unsigned long stateImpl() const {
return 0;
}
//...
};
class KWindowSystemPrivateX11 : public KWindowSystemPrivate {
//
inline unsigned long stateImpl() const {
return m_info-state();
}
//...
}
Then there is no more need for #define X11 static_castconst
KWindowInfoPrivateX11*(this) anymore.
DELEGATE would look like this then:
#define DELEGATE(name, args) \
switch (d-platform()) { \
case KWindowInfoPrivate::XcbPlatform: \
return d-nameKWindowInfoPrivateX11( args ); \
default: \
return d-nameKWindowInfoPrivateDummy( args ); \
}
This should also work, however I am just typing it from my head without having
it compiled.
- Alexander Richardson
On Jan. 23, 2014, 9:09 a.m., Martin Gräßlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115225/
---
(Updated Jan. 23, 2014, 9:09 a.m.)
Review request for KDE Frameworks and kdewin.
Repository: kwindowsystem
Description
---
Add runtime platform support to KWindowInfo
Main idea of this change is to only pick the X11 implementation in case
that the application is running on the X11 platform. So far it was a
compile time switch which meant that if compiled with X11 support but
not running on the X11 platform it would have caused runtime errors.
To make this possible a KWindowInfoPrivate class with a dummy
implementation is provided. This is used as d-ptr for KWindowInfo.
Thus there is one generic implementation and the implementation of
KWindowInfo is no longer ifdefed for the supported platforms.
The platform specific code can inherit from KWindowInfoPrivate and
overwrite the dummy method implementation. KWindowInfoPrivate provides
a factory method where the platform specific implementation can be
hooked into. There we can have both compile time and runtime checking.
If there is no platfom specific implementation available the dummy
implementation is used.
NOTE: THIS CHANGE BREAKS THE WINDOWS AND MAC BACKEND!
Windows and Mac is excluded from build. At the moment they get the
dummy implementation. Unfortunately I don't have the possibility to
compile the changes and thus don't dare to touch the code. Fixes from
the teams are highly appreciated.
Diffs
-
src/CMakeLists.txt e32a1150a2c190f23ad456ca8218b012c5d71507
src/kwindowinfo.h 171f441ff329a5356ccf560341272199e20c837a
src/kwindowinfo.cpp PRE-CREATION
src/kwindowinfo_p.h PRE-CREATION
src/kwindowinfo_p_x11.h PRE-CREATION
src/kwindowinfo_x11.cpp 865d8bed085e987f97f479ea8aa0e6de8567586f
Diff: https://git.reviewboard.kde.org/r/115225/diff/
Testing
---
Unit test from https://git.reviewboard.kde.org/r/115190/ is still working.
Now you can guess why I wrote that test ;-)
Thanks,
Martin Gräßlin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115259: Simplify the project directories that are searched for images etc
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115259/#review48126 --- This review has been submitted with commit 716b4cbc2d274b5bf59c36c1611559e5a8c77c11 by Alex Merry to branch master. - Commit Hook On Jan. 23, 2014, 2:10 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115259/ --- (Updated Jan. 23, 2014, 2:10 p.m.) Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapidox Description --- Simplify the project directories that are searched for images etc Files will be found under various docs/ subdirs (and docs/api is not considered any more). Diffs - README.md c1fe269a424366ec50ba18a31b71c28d96df2869 src/kapidox/__init__.py e6ffda63f96780c2ae71717054c097be6fec04bb Diff: https://git.reviewboard.kde.org/r/115259/diff/ Testing --- Ran kgenapidox on kbookmarks with python2 and python3. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115236: Get closer to compiling KIO on windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115236/#review48127 --- This review has been submitted with commit f875a9b073734d22a6e44a3cb2663a1a1ec65600 by Alex Richardson to branch master. - Commit Hook On Jan. 22, 2014, 9:12 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115236/ --- (Updated Jan. 22, 2014, 9:12 p.m.) Review request for KDE Frameworks. Repository: kio Description --- 3 Commits to get closer to compiling on windows: 1. Include qplatformdefs.h where possible unistd.h and others are not available on e.g. Windows, qplatformdefs.h includes the equivalent for each platform 2. add include(CheckLibraryExists) to CMakeLists.txt On Linux this is apparently pulled in by some other file whereas it is missing on Windows 3. Make KIO::MetaData completely inline to prevent linker errors on MSVC Diffs - src/ioslaves/ftp/ftp.h ad94979829a5d0e71ec57177b51f67e115c5445e src/ioslaves/ftp/ftp.cpp 9ea642587bd754f0b4295fcb7d4db1b427f4326e src/ioslaves/help/kio_help.h 0eab4ce1b393b48e552ca94d877f4c069450cee0 src/ioslaves/http/http.cpp 4f97b335c0e206f0a2ff8cfd515d0fae79614ad2 src/ioslaves/http/http_cache_cleaner.cpp ffa8ab9580acf554b27027617cdac06b3f7755bf src/widgets/kdirmodel.cpp ce6e4c9aaddada5715b5aeef36ad163c77d3c635 src/widgets/kpropertiesdialog.cpp 8ddd37f0326e37109ce239a46bfa67d2f4c35411 src/widgets/krun.cpp 92dcfd8da04b9f3d80b632a37758017c088093ab src/widgets/kurlcompletion.cpp ed77fd3213db0524b5a934c94eb7645d98bd27c7 tests/kioslavetest.cpp dc56240dc166dfa93ec099db5cdd262cc06249d4 tests/kruntest.cpp 68720ddf788e6b44468baf18dd04937094741274 CMakeLists.txt 9894ad5e1696fe31d8a3f065d29747cde0474d2c autotests/fileundomanagertest.cpp 4ddee49eed254be6379a1302af2dd17aae28c15c autotests/kurlcompletiontest.cpp 10048e2e15059596e446b03cedb0b302bf038cd5 src/core/chmodjob.cpp b60cb9bf3d3b1a71a795ee5db7c72253dbdf0ad2 src/core/kacl.h 3c9c88d0408c855d02eaacb34d14f45c55343eb2 src/core/kacl.cpp 201b30a02ef93a137b9a8507cabaece6926d8739 src/core/kfileitem.h 553dbf8ccf96983803d0224cf8dc9d72f0107b6a src/core/kfileitem.cpp fdc0fc0279713887dc18ce1da8d3b00d422f6a9b src/core/kprotocolmanager.cpp a8746a4f9a78e6a01eaed6a70e99146ff40129d2 src/core/krecentdocument.cpp ad0a97e7c1af85a94bb7483124b5035f0fca38a6 src/core/metadata.h cd62e3b009c21485537ddd5449a6c347748c3caf src/core/metadata.cpp ad05032dff58314a305256993fcc7fe7b94751bc src/core/slave.h 43b5cd8e8aa11da55d6f8a8d9fdf4eb3d0780d11 src/core/slave.cpp ef9b3c7a57b4f4384343c4d4296ec88add857eb6 src/core/slavebase.cpp a7ac4d5a6a87c256da9a3947b7223649927eba39 src/core/slaveinterface.h d75eb6b02374375a73e1aaa57d5c2979a3bc365f src/core/slaveinterface.cpp faa4bd7dc1b5a733f0060f60626e8a0313bfea8a src/core/slaveinterface_p.h 0ed4980a06f8aa8b3fc8c0717e4a88991483e98a src/filewidgets/kfileplaceeditdialog.cpp a7c433c8baecca8082f8d80077deab68e4b0cec2 src/filewidgets/knewfilemenu.cpp dfc086b6e98b965739c062d7291bbd9139633beb src/ioslaves/file/file.h 453298159791a78d877c4d81d2be73db073db3f2 src/ioslaves/file/file.cpp e3ede0daa8054fc33d12acb9966a707f9484cd98 src/ioslaves/file/file_win.cpp 53e0f8f133bd5c4cbbd07afa945854efffc7297c Diff: https://git.reviewboard.kde.org/r/115236/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115236: Get closer to compiling KIO on windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115236/ --- (Updated Jan. 23, 2014, 2:59 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kio Description --- 3 Commits to get closer to compiling on windows: 1. Include qplatformdefs.h where possible unistd.h and others are not available on e.g. Windows, qplatformdefs.h includes the equivalent for each platform 2. add include(CheckLibraryExists) to CMakeLists.txt On Linux this is apparently pulled in by some other file whereas it is missing on Windows 3. Make KIO::MetaData completely inline to prevent linker errors on MSVC Diffs - src/ioslaves/ftp/ftp.h ad94979829a5d0e71ec57177b51f67e115c5445e src/ioslaves/ftp/ftp.cpp 9ea642587bd754f0b4295fcb7d4db1b427f4326e src/ioslaves/help/kio_help.h 0eab4ce1b393b48e552ca94d877f4c069450cee0 src/ioslaves/http/http.cpp 4f97b335c0e206f0a2ff8cfd515d0fae79614ad2 src/ioslaves/http/http_cache_cleaner.cpp ffa8ab9580acf554b27027617cdac06b3f7755bf src/widgets/kdirmodel.cpp ce6e4c9aaddada5715b5aeef36ad163c77d3c635 src/widgets/kpropertiesdialog.cpp 8ddd37f0326e37109ce239a46bfa67d2f4c35411 src/widgets/krun.cpp 92dcfd8da04b9f3d80b632a37758017c088093ab src/widgets/kurlcompletion.cpp ed77fd3213db0524b5a934c94eb7645d98bd27c7 tests/kioslavetest.cpp dc56240dc166dfa93ec099db5cdd262cc06249d4 tests/kruntest.cpp 68720ddf788e6b44468baf18dd04937094741274 CMakeLists.txt 9894ad5e1696fe31d8a3f065d29747cde0474d2c autotests/fileundomanagertest.cpp 4ddee49eed254be6379a1302af2dd17aae28c15c autotests/kurlcompletiontest.cpp 10048e2e15059596e446b03cedb0b302bf038cd5 src/core/chmodjob.cpp b60cb9bf3d3b1a71a795ee5db7c72253dbdf0ad2 src/core/kacl.h 3c9c88d0408c855d02eaacb34d14f45c55343eb2 src/core/kacl.cpp 201b30a02ef93a137b9a8507cabaece6926d8739 src/core/kfileitem.h 553dbf8ccf96983803d0224cf8dc9d72f0107b6a src/core/kfileitem.cpp fdc0fc0279713887dc18ce1da8d3b00d422f6a9b src/core/kprotocolmanager.cpp a8746a4f9a78e6a01eaed6a70e99146ff40129d2 src/core/krecentdocument.cpp ad0a97e7c1af85a94bb7483124b5035f0fca38a6 src/core/metadata.h cd62e3b009c21485537ddd5449a6c347748c3caf src/core/metadata.cpp ad05032dff58314a305256993fcc7fe7b94751bc src/core/slave.h 43b5cd8e8aa11da55d6f8a8d9fdf4eb3d0780d11 src/core/slave.cpp ef9b3c7a57b4f4384343c4d4296ec88add857eb6 src/core/slavebase.cpp a7ac4d5a6a87c256da9a3947b7223649927eba39 src/core/slaveinterface.h d75eb6b02374375a73e1aaa57d5c2979a3bc365f src/core/slaveinterface.cpp faa4bd7dc1b5a733f0060f60626e8a0313bfea8a src/core/slaveinterface_p.h 0ed4980a06f8aa8b3fc8c0717e4a88991483e98a src/filewidgets/kfileplaceeditdialog.cpp a7c433c8baecca8082f8d80077deab68e4b0cec2 src/filewidgets/knewfilemenu.cpp dfc086b6e98b965739c062d7291bbd9139633beb src/ioslaves/file/file.h 453298159791a78d877c4d81d2be73db073db3f2 src/ioslaves/file/file.cpp e3ede0daa8054fc33d12acb9966a707f9484cd98 src/ioslaves/file/file_win.cpp 53e0f8f133bd5c4cbbd07afa945854efffc7297c Diff: https://git.reviewboard.kde.org/r/115236/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115236: Get closer to compiling KIO on windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115236/#review48129 --- This review has been submitted with commit 76f474c43b80c5bc7c79403def8ee0443c3ea1e5 by Alex Richardson to branch master. - Commit Hook On Jan. 22, 2014, 9:12 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115236/ --- (Updated Jan. 22, 2014, 9:12 p.m.) Review request for KDE Frameworks. Repository: kio Description --- 3 Commits to get closer to compiling on windows: 1. Include qplatformdefs.h where possible unistd.h and others are not available on e.g. Windows, qplatformdefs.h includes the equivalent for each platform 2. add include(CheckLibraryExists) to CMakeLists.txt On Linux this is apparently pulled in by some other file whereas it is missing on Windows 3. Make KIO::MetaData completely inline to prevent linker errors on MSVC Diffs - src/ioslaves/ftp/ftp.h ad94979829a5d0e71ec57177b51f67e115c5445e src/ioslaves/ftp/ftp.cpp 9ea642587bd754f0b4295fcb7d4db1b427f4326e src/ioslaves/help/kio_help.h 0eab4ce1b393b48e552ca94d877f4c069450cee0 src/ioslaves/http/http.cpp 4f97b335c0e206f0a2ff8cfd515d0fae79614ad2 src/ioslaves/http/http_cache_cleaner.cpp ffa8ab9580acf554b27027617cdac06b3f7755bf src/widgets/kdirmodel.cpp ce6e4c9aaddada5715b5aeef36ad163c77d3c635 src/widgets/kpropertiesdialog.cpp 8ddd37f0326e37109ce239a46bfa67d2f4c35411 src/widgets/krun.cpp 92dcfd8da04b9f3d80b632a37758017c088093ab src/widgets/kurlcompletion.cpp ed77fd3213db0524b5a934c94eb7645d98bd27c7 tests/kioslavetest.cpp dc56240dc166dfa93ec099db5cdd262cc06249d4 tests/kruntest.cpp 68720ddf788e6b44468baf18dd04937094741274 CMakeLists.txt 9894ad5e1696fe31d8a3f065d29747cde0474d2c autotests/fileundomanagertest.cpp 4ddee49eed254be6379a1302af2dd17aae28c15c autotests/kurlcompletiontest.cpp 10048e2e15059596e446b03cedb0b302bf038cd5 src/core/chmodjob.cpp b60cb9bf3d3b1a71a795ee5db7c72253dbdf0ad2 src/core/kacl.h 3c9c88d0408c855d02eaacb34d14f45c55343eb2 src/core/kacl.cpp 201b30a02ef93a137b9a8507cabaece6926d8739 src/core/kfileitem.h 553dbf8ccf96983803d0224cf8dc9d72f0107b6a src/core/kfileitem.cpp fdc0fc0279713887dc18ce1da8d3b00d422f6a9b src/core/kprotocolmanager.cpp a8746a4f9a78e6a01eaed6a70e99146ff40129d2 src/core/krecentdocument.cpp ad0a97e7c1af85a94bb7483124b5035f0fca38a6 src/core/metadata.h cd62e3b009c21485537ddd5449a6c347748c3caf src/core/metadata.cpp ad05032dff58314a305256993fcc7fe7b94751bc src/core/slave.h 43b5cd8e8aa11da55d6f8a8d9fdf4eb3d0780d11 src/core/slave.cpp ef9b3c7a57b4f4384343c4d4296ec88add857eb6 src/core/slavebase.cpp a7ac4d5a6a87c256da9a3947b7223649927eba39 src/core/slaveinterface.h d75eb6b02374375a73e1aaa57d5c2979a3bc365f src/core/slaveinterface.cpp faa4bd7dc1b5a733f0060f60626e8a0313bfea8a src/core/slaveinterface_p.h 0ed4980a06f8aa8b3fc8c0717e4a88991483e98a src/filewidgets/kfileplaceeditdialog.cpp a7c433c8baecca8082f8d80077deab68e4b0cec2 src/filewidgets/knewfilemenu.cpp dfc086b6e98b965739c062d7291bbd9139633beb src/ioslaves/file/file.h 453298159791a78d877c4d81d2be73db073db3f2 src/ioslaves/file/file.cpp e3ede0daa8054fc33d12acb9966a707f9484cd98 src/ioslaves/file/file_win.cpp 53e0f8f133bd5c4cbbd07afa945854efffc7297c Diff: https://git.reviewboard.kde.org/r/115236/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC
On Jan. 23, 2014, 9:28 a.m., David Faure wrote: Oh, OK, didn't know this was broken on MSVC. Worth a Qt fix or at least bugreport? Luigi Toscano wrote: Thiago reported it: see http://lists.kde.org/?l=kde-buildsystemm=139042097719628w=2 and https://codereview.qt-project.org/#change,76311 Alexander Richardson wrote: Should I add a check for the Qt version? Obviously this will only work if Qt is searched for first Can you put a link to the change request in the comment, and a TODO to revisit this when we depend on Qt 5.3? We unfortunately can't check the Qt version in this file, as we can't guarantee it's been found. But it is likely we'll bump the required Qt version for all the frameworks at once. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/#review48092 --- On Jan. 22, 2014, 5:51 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/ --- (Updated Jan. 22, 2014, 5:51 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Only set QT_STRICT_ITERATORS when not compiling with MSVC On MSVC linker errors will happen when this flag is set. Diffs - kde-modules/KDEFrameworkCompilerSettings.cmake d71c407f9c0b504ebb1c0cf662e69545f7a46371 Diff: https://git.reviewboard.kde.org/r/115234/diff/ Testing --- E.g. KConfigWidgets didn't compile before, compiles now Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115225: Add runtime platform support to KWindowInfo
On Jan. 23, 2014, 3:47 p.m., Alexander Richardson wrote:
Wouldn't this be easier using methods with the subclass as a template
parameter instead of the enum. I.e:
class KWindowSystemPrivate {
//
template class Impl
inline unsigned long state() const
{
// use a different name to prevent infinite recursion in case this is
called with KWindowSystemPrivate as a template parameter
return static_castImpl*(this)-stateImpl();
}
//
};
class KWindowSystemPrivateDummy : public KWindowSystemPrivate {
//
inline unsigned long stateImpl() const {
return 0;
}
//...
};
class KWindowSystemPrivateX11 : public KWindowSystemPrivate {
//
inline unsigned long stateImpl() const {
return m_info-state();
}
//...
}
Then there is no more need for #define X11 static_castconst
KWindowInfoPrivateX11*(this) anymore.
DELEGATE would look like this then:
#define DELEGATE(name, args) \
switch (d-platform()) { \
case KWindowInfoPrivate::XcbPlatform: \
return d-nameKWindowInfoPrivateX11( args ); \
default: \
return d-nameKWindowInfoPrivateDummy( args ); \
}
This should also work, however I am just typing it from my head without
having it compiled.
return static_castImpl*(this)-stateImpl();
This obviously has to be static_castconst Impl*(this)
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115225/#review48124
---
On Jan. 23, 2014, 9:09 a.m., Martin Gräßlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115225/
---
(Updated Jan. 23, 2014, 9:09 a.m.)
Review request for KDE Frameworks and kdewin.
Repository: kwindowsystem
Description
---
Add runtime platform support to KWindowInfo
Main idea of this change is to only pick the X11 implementation in case
that the application is running on the X11 platform. So far it was a
compile time switch which meant that if compiled with X11 support but
not running on the X11 platform it would have caused runtime errors.
To make this possible a KWindowInfoPrivate class with a dummy
implementation is provided. This is used as d-ptr for KWindowInfo.
Thus there is one generic implementation and the implementation of
KWindowInfo is no longer ifdefed for the supported platforms.
The platform specific code can inherit from KWindowInfoPrivate and
overwrite the dummy method implementation. KWindowInfoPrivate provides
a factory method where the platform specific implementation can be
hooked into. There we can have both compile time and runtime checking.
If there is no platfom specific implementation available the dummy
implementation is used.
NOTE: THIS CHANGE BREAKS THE WINDOWS AND MAC BACKEND!
Windows and Mac is excluded from build. At the moment they get the
dummy implementation. Unfortunately I don't have the possibility to
compile the changes and thus don't dare to touch the code. Fixes from
the teams are highly appreciated.
Diffs
-
src/CMakeLists.txt e32a1150a2c190f23ad456ca8218b012c5d71507
src/kwindowinfo.h 171f441ff329a5356ccf560341272199e20c837a
src/kwindowinfo.cpp PRE-CREATION
src/kwindowinfo_p.h PRE-CREATION
src/kwindowinfo_p_x11.h PRE-CREATION
src/kwindowinfo_x11.cpp 865d8bed085e987f97f479ea8aa0e6de8567586f
Diff: https://git.reviewboard.kde.org/r/115225/diff/
Testing
---
Unit test from https://git.reviewboard.kde.org/r/115190/ is still working.
Now you can guess why I wrote that test ;-)
Thanks,
Martin Gräßlin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115259: Simplify the project directories that are searched for images etc
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115259/ --- (Updated Jan. 23, 2014, 2:57 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapidox Description --- Simplify the project directories that are searched for images etc Files will be found under various docs/ subdirs (and docs/api is not considered any more). Diffs - README.md c1fe269a424366ec50ba18a31b71c28d96df2869 src/kapidox/__init__.py e6ffda63f96780c2ae71717054c097be6fec04bb Diff: https://git.reviewboard.kde.org/r/115259/diff/ Testing --- Ran kgenapidox on kbookmarks with python2 and python3. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/ --- (Updated Jan. 23, 2014, 3:10 p.m.) Status -- This change has been marked as submitted. Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Only set QT_STRICT_ITERATORS when not compiling with MSVC On MSVC linker errors will happen when this flag is set. Diffs - kde-modules/KDEFrameworkCompilerSettings.cmake d71c407f9c0b504ebb1c0cf662e69545f7a46371 Diff: https://git.reviewboard.kde.org/r/115234/diff/ Testing --- E.g. KConfigWidgets didn't compile before, compiles now Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/#review48133 --- This review has been submitted with commit 506bd64a3b30fbb5c1940a796f82e281053db4bd by Alex Richardson to branch master. - Commit Hook On Jan. 22, 2014, 5:51 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/ --- (Updated Jan. 22, 2014, 5:51 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Only set QT_STRICT_ITERATORS when not compiling with MSVC On MSVC linker errors will happen when this flag is set. Diffs - kde-modules/KDEFrameworkCompilerSettings.cmake d71c407f9c0b504ebb1c0cf662e69545f7a46371 Diff: https://git.reviewboard.kde.org/r/115234/diff/ Testing --- E.g. KConfigWidgets didn't compile before, compiles now Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs
On Jan. 21, 2014, 11:43 p.m., Alex Merry wrote: src/kcompletion.h, line 501 https://git.reviewboard.kde.org/r/115206/diff/1/?file=235092#file235092line501 One sentence: This signal is emitted by makeCompletion() when a match is found. David Gil Oliva wrote: Since more methods emit this signal, I have rephrased it further. makeCompletion() doesn't emit empty strings, but previousMatch() and nextMatch() do emit empty strings when there is no match. In the next days I will update the patch. /** * This signal is emitted by makeCompletion() when a match is found. * @param item the match. In previousMatch() and nextMatch() it can * be a QString() if none is found. */ How about /** * This signal is emitted when a match is found. * * In particular, makeCompletion(), previousMatch() and nextMatch() all * emit this signal; makeCompletion() will only emit it when a match is * found, but the other methods will always emit it (and so may emit it * with an empty string). * * @param item the matching item, or QString() if there were no more * matching items. */ And a similar thing for matches(). - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/#review47958 --- On Jan. 21, 2014, 11:12 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/ --- (Updated Jan. 21, 2014, 11:12 p.m.) Review request for KDE Frameworks. Repository: kcompletion Description --- Correct spelling, grammar and style of kcompletion.h docs Diffs - src/kcompletion.h 46b63a4 Diff: https://git.reviewboard.kde.org/r/115206/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115253: Rename kf5dot-* tools to depdiagram-*
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115253/#review48138 --- Ship it! Ship It! - Alex Merry On Jan. 23, 2014, 10:55 a.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115253/ --- (Updated Jan. 23, 2014, 10:55 a.m.) Review request for KDE Frameworks and Alex Merry. Repository: kapidox Description --- This new name should be less cryptic. Diffs - README.md c1fe269 setup.py c87944c src/depdiagram-generate PRE-CREATION src/depdiagram-generate-all PRE-CREATION src/depdiagram-prepare PRE-CREATION src/kapidox/depdiagram/block.py PRE-CREATION src/kapidox/depdiagram/framework.py PRE-CREATION src/kapidox/depdiagram/frameworkdb.py PRE-CREATION src/kapidox/kf5dot/__init__.py e69de29 src/kapidox/kf5dot/block.py 045fbf5 src/kapidox/kf5dot/framework.py 21f4cf6 src/kapidox/kf5dot/frameworkdb.py 63f7e27 src/kf5dot-generate 8d44e20 src/kf5dot-generate-all 244ed12 src/kf5dot-prepare 3d133d9 Diff: https://git.reviewboard.kde.org/r/115253/diff/ Testing --- Regenerated dependency diagrams. Works fine. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115251/#review48141
---
Ship it!
The rest of the code is fine, +1 from me.
src/kstartupinfo.cpp
https://git.reviewboard.kde.org/r/115251/#comment34047
Mayube will be better do a return early here?
if (!X11Info::isPlatformX!!) {return} so we can avoid an extra indentation
on all that code?
- Àlex Fiestas
On Jan. 23, 2014, 10:06 a.m., Martin Gräßlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115251/
---
(Updated Jan. 23, 2014, 10:06 a.m.)
Review request for KDE Frameworks.
Repository: kwindowsystem
Description
---
Add better runtime detection for X11 usage in KStartupInfo
Compile time checks for X11 is no longer sufficient. This adds a
runtime check to all the code paths which look dangerous if executed
on a non-X11 platform.
Diffs
-
src/kstartupinfo.cpp 5dbf47cb666fbed17c943491efe93e17f27d581e
Diff: https://git.reviewboard.kde.org/r/115251/diff/
Testing
---
Thanks,
Martin Gräßlin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115249: Add runtime detection to KUserTimestamp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115249/#review48140 --- Ship it! +1 - Àlex Fiestas On Jan. 23, 2014, 9:05 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115249/ --- (Updated Jan. 23, 2014, 9:05 a.m.) Review request for KDE Frameworks. Repository: kwindowsystem Description --- Add runtime detection to KUserTimestamp KUserTimestamp methods should only be used if we are on platformX11. A compile time check is not enough. Diffs - src/kusertimestamp.cpp de8ca61e7e9dd0ae9492ccf61883560d80501e2b Diff: https://git.reviewboard.kde.org/r/115249/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115262: Split Mainpage.dox up
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115262/ --- Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- This matches up with the new kapidox scripts. This module was more complex than the others, hence the RR. Split Mainpage.dox up The front page content goes in README.md. Other pages are now in separate files under docs/. It would be nice to convert some or all of the documentation pages to markdown, so they can be easily read without running them through doxygen first. Also includes the commit: Remove the lines about the following classes from apidox group defs doxygen actually puts the class list *above* the description, not below it. Diffs - Mainpage.dox 515d78af3e2babe155314b995f17955e6cacf65f README.md 82de5a260065959520f1558334d362d6ad16e167 docs/apidocs-groups.dox PRE-CREATION docs/coding-guidelines.dox PRE-CREATION docs/design.dox PRE-CREATION docs/howto.dox PRE-CREATION docs/porting.dox PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115262/diff/ Testing --- All the old pages are still accessible from the main page when generating the documentation. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115264: Split up Mainpage.dox
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115264/ --- Review request for KDE Frameworks and Mirko Boehm. Repository: threadweaver Description --- Split up Mainpage.dox Front page content and usage in README.md, other pages in separate files in docs/. Diffs - Mainpage.dox ed4e7b9bf1669c73d676a8895deb15cbca61e95f README.md 204436362878ed0d62f56866555a6649343a39c1 docs/use-cases.md PRE-CREATION docs/whymultithreading.md PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115264/diff/ Testing --- Generated apidocs; other pages (use cases and why multithreading) are still accessible from main page. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115237: Relocate KDE4_CREATE_HANDBOOK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115237/ --- (Updated Jan. 23, 2014, 4:22 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Luigi Toscano. Repository: kde4support Description --- Moving it from KDocTools, as discussed in Review Request 115077. Defined as a forward to the new command KDOCTOOLS_CREATE_HANDBOOK. Notice that the description of the command changed to document the actual name of the target created. Diffs - cmake/modules/KDE4Macros.cmake a3894ae Diff: https://git.reviewboard.kde.org/r/115237/diff/ Testing --- Tried using this on a Kig build for frameworks. The warning message is displayed and the doc-handbook target is created for folder doc. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115237: Relocate KDE4_CREATE_HANDBOOK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115237/#review48142 --- This review has been submitted with commit c4b6190709eaaf7d5c1100d74ba0f73a1033b990 by David E. Narvaez to branch master. - Commit Hook On Jan. 22, 2014, 9:28 p.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115237/ --- (Updated Jan. 22, 2014, 9:28 p.m.) Review request for KDE Frameworks and Luigi Toscano. Repository: kde4support Description --- Moving it from KDocTools, as discussed in Review Request 115077. Defined as a forward to the new command KDOCTOOLS_CREATE_HANDBOOK. Notice that the description of the command changed to document the actual name of the target created. Diffs - cmake/modules/KDE4Macros.cmake a3894ae Diff: https://git.reviewboard.kde.org/r/115237/diff/ Testing --- Tried using this on a Kig build for frameworks. The warning message is displayed and the doc-handbook target is created for folder doc. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: QFileDialog not usable with frameworkintegration
On Thu, Jan 23, 2014 at 11:49 AM, codeminis...@publicstatic.de wrote: Hi, as described in https://git.reviewboard.kde.org/r/115238/ there is a bug QFileDialog frameworkintegration. As opposed to written in the review request the dialog is not usable at the moment if someone wants to select a non-existing file because it crashes. 1. $ ./qfiledialogtest --acceptMode save --selectFile /tmp/moo.png 2. (Note that the selectFile has no effect) 3. Manually select a file 4. Edit the Name text box and write some non-existing name 5. Press ok 6. qfiledialogtest(4329)/(default) QFileInfo::absolutePath: QFileInfo::absolutePath: Constructed with empty filename qfiledialogtest(4329)/(default) qt_assert: ASSERT: d in file ../../include/QtCore/../../src/corelib/tools/qscopedpointer.h, line 120 Aborted Best regards Gregor ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel I'm looking into this. Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kde4support_master_qt5 #33
See http://build.kde.org/job/kde4support_master_qt5/33/changes Changes: [david.narvaez] Relocate KDE4_CREATE_HANDBOOK -- [...truncated 603 lines...] Generating moc_kfilemetadatawidget.cpp Generating moc_kfilemetainfowidget.cpp Generating moc_kfileshare_p.cpp Generating moc_kfiletreeview_p.cpp Generating moc_kmetaprops.cpp Generating moc_k3bufferedsocket.cpp Generating moc_k3clientsocketbase.cpp Generating moc_k3resolver.cpp Generating moc_k3reverseresolver.cpp Generating moc_k3serversocket.cpp Generating moc_k3socketbase.cpp Generating moc_k3streamsocket.cpp Generating moc_klibloader.cpp Generating moc_k4style.cpp Generating moc_k4timezonewidget.cpp Generating moc_karrowbutton.cpp Generating moc_kcolorvalueselector.cpp Generating moc_kdatetimewidget.cpp Generating moc_kdatewidget.cpp Generating moc_kdeuiwidgetsproxystyle_p.cpp Generating moc_kdialogbuttonbox.cpp Generating moc_keditlistbox.cpp Generating moc_kfontdialog.cpp Generating moc_khbox.cpp Generating moc_khuesaturationselect.cpp Generating moc_kmenubar.cpp Generating moc_kmessageboxmessagehandler.cpp Generating moc_knumvalidator.cpp Generating moc_kpassivepopupmessagehandler.cpp Generating moc_krestrictedline.cpp Generating moc_ksplashscreen.cpp Generating moc_kstatusbar.cpp Generating moc_kstringvalidator.cpp Generating moc_ktabbar.cpp Generating moc_ktextbrowser.cpp Generating moc_kundostack.cpp Generating moc_kvbox.cpp Generating moc_kdatatool.cpp Generating moc_kfileitemactionplugin.cpp Generating moc_kfilewriteplugin.cpp Generating moc_kscan.cpp Generating moc_metainfojob.cpp Generating moc_netaccess.cpp Generating moc_passworddialog.cpp Generating moc_factory.cpp [ 24%] Built target KF5KDE4Support_automoc Scanning dependencies of target KF5KDE4Support [ 24%] [ 24%] [ 24%] [ 24%] [ 25%] [ 25%] [ 25%] [ 26%] [ 26%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k4aboutdata.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kcomponentdata.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kdebug.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kdebugdbusiface.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kdeversion.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kkernel_win.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kkernel_mac.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/klibloader.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/ktemporaryfile.cpp.o [ 26%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/ktempdir.cpp.o http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k4aboutdata.cpp: In member function ‘void K4AboutData::translateInternalProgramName() const’: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k4aboutdata.cpp:723:92: note: #pragma message: KDE5 FIXME: This code must be replaced by something with KLocalizedString http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k4aboutdata.cpp: In member function ‘QListK4AboutPerson K4AboutData::translators() const’: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k4aboutdata.cpp:832:52: note: #pragma message: KDE5 TODO: What about this code ? [ 26%] [ 27%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kmd5.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kmimetype.cpp.o [ 27%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kmimetyperepository.cpp.o [ 27%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/ksavefile.cpp.o http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/klibloader.cpp: In member function ‘KPluginFactory* KLibLoader::factory(const QString, QLibrary::LoadHints)’: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/klibloader.cpp:136:40: warning: ‘KPluginFactory* KLibrary::factory(const char*)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/klibrary.h:58) [-Wdeprecated-declarations] [ 27%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/ksocketfactory.cpp.o [ 28%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3socks.cpp.o [ 28%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3sockssocketdevice.cpp.o [ 28%] [ 28%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3socketdevice.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3bufferedsocket.cpp.o [ 29%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3clientsocketbase.cpp.o [ 29%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3resolver.cpp.o [ 29%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3resolvermanager.cpp.o In file included from http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k3socketdevice.h:29:0,
Re: Review Request 115239: Relocate KDE4_CREATE_HANDBOOK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115239/ --- (Updated Jan. 23, 2014, 4:23 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- Moved to KDE4Support as discussed in Review Request 115077 Diffs - KF5DocToolsMacros.cmake 5bb0f72 Diff: https://git.reviewboard.kde.org/r/115239/diff/ Testing --- Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115262: Split Mainpage.dox up
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115262/#review48144 --- README.md https://git.reviewboard.kde.org/r/115262/#comment34048 In the threadweaver diff, you did escaped the #, I am not sure if that is wanted here too. - Michael Palimaka On Jan. 23, 2014, 4:09 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115262/ --- (Updated Jan. 23, 2014, 4:09 p.m.) Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- This matches up with the new kapidox scripts. This module was more complex than the others, hence the RR. Split Mainpage.dox up The front page content goes in README.md. Other pages are now in separate files under docs/. It would be nice to convert some or all of the documentation pages to markdown, so they can be easily read without running them through doxygen first. Also includes the commit: Remove the lines about the following classes from apidox group defs doxygen actually puts the class list *above* the description, not below it. Diffs - Mainpage.dox 515d78af3e2babe155314b995f17955e6cacf65f README.md 82de5a260065959520f1558334d362d6ad16e167 docs/apidocs-groups.dox PRE-CREATION docs/coding-guidelines.dox PRE-CREATION docs/design.dox PRE-CREATION docs/howto.dox PRE-CREATION docs/porting.dox PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115262/diff/ Testing --- All the old pages are still accessible from the main page when generating the documentation. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115266: Split up Mainpage.dox
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115266/ --- Review request for KDE Frameworks, Àlex Fiestas and Kevin Ottens. Repository: solid Description --- I'm not sure what should happen to the song, really. Split up Mainpage.dox The examples do not appear to exist any more; README.md gets some usage info and link to the song, which goes in docs/song.md. Unfortunately, the song still needs br tags due to a lack of markdown line-break support in doxygen (https://bugzilla.gnome.org/show_bug.cgi?id=679710). Diffs - Mainpage.dox 79993535605efff7b1807f11f36b830bf566 README.md 215b7dda8fa0c4aa68e29ee633c6ab5a6465de94 docs/song.md PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115266/diff/ Testing --- Generated dox. Home page and song page look right. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build became unstable: ktexteditor_master_qt5 #130
See http://build.kde.org/job/ktexteditor_master_qt5/130/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115262: Split Mainpage.dox up
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115262/#review48146 --- Ship it! Dominik our doxygen guy thinks its ok ;) - Christoph Cullmann On Jan. 23, 2014, 4:09 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115262/ --- (Updated Jan. 23, 2014, 4:09 p.m.) Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- This matches up with the new kapidox scripts. This module was more complex than the others, hence the RR. Split Mainpage.dox up The front page content goes in README.md. Other pages are now in separate files under docs/. It would be nice to convert some or all of the documentation pages to markdown, so they can be easily read without running them through doxygen first. Also includes the commit: Remove the lines about the following classes from apidox group defs doxygen actually puts the class list *above* the description, not below it. Diffs - Mainpage.dox 515d78af3e2babe155314b995f17955e6cacf65f README.md 82de5a260065959520f1558334d362d6ad16e167 docs/apidocs-groups.dox PRE-CREATION docs/coding-guidelines.dox PRE-CREATION docs/design.dox PRE-CREATION docs/howto.dox PRE-CREATION docs/porting.dox PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115262/diff/ Testing --- All the old pages are still accessible from the main page when generating the documentation. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115262: Split Mainpage.dox up
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115262/ --- (Updated Jan. 23, 2014, 4:58 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- This matches up with the new kapidox scripts. This module was more complex than the others, hence the RR. Split Mainpage.dox up The front page content goes in README.md. Other pages are now in separate files under docs/. It would be nice to convert some or all of the documentation pages to markdown, so they can be easily read without running them through doxygen first. Also includes the commit: Remove the lines about the following classes from apidox group defs doxygen actually puts the class list *above* the description, not below it. Diffs - Mainpage.dox 515d78af3e2babe155314b995f17955e6cacf65f README.md 82de5a260065959520f1558334d362d6ad16e167 docs/apidocs-groups.dox PRE-CREATION docs/coding-guidelines.dox PRE-CREATION docs/design.dox PRE-CREATION docs/howto.dox PRE-CREATION docs/porting.dox PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115262/diff/ Testing --- All the old pages are still accessible from the main page when generating the documentation. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115262: Split Mainpage.dox up
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115262/#review48147 --- This review has been submitted with commit 1eea8d3525d28448e85de534a3c68f459af3dce6 by Alex Merry to branch master. - Commit Hook On Jan. 23, 2014, 4:09 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115262/ --- (Updated Jan. 23, 2014, 4:09 p.m.) Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- This matches up with the new kapidox scripts. This module was more complex than the others, hence the RR. Split Mainpage.dox up The front page content goes in README.md. Other pages are now in separate files under docs/. It would be nice to convert some or all of the documentation pages to markdown, so they can be easily read without running them through doxygen first. Also includes the commit: Remove the lines about the following classes from apidox group defs doxygen actually puts the class list *above* the description, not below it. Diffs - Mainpage.dox 515d78af3e2babe155314b995f17955e6cacf65f README.md 82de5a260065959520f1558334d362d6ad16e167 docs/apidocs-groups.dox PRE-CREATION docs/coding-guidelines.dox PRE-CREATION docs/design.dox PRE-CREATION docs/howto.dox PRE-CREATION docs/porting.dox PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115262/diff/ Testing --- All the old pages are still accessible from the main page when generating the documentation. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115253: Rename kf5dot-* tools to depdiagram-*
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115253/#review48148 --- This review has been submitted with commit f13b43f1cb945c8c7428f7ab721e2c3836c256fa by Aurélien Gâteau to branch master. - Commit Hook On Jan. 23, 2014, 10:55 a.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115253/ --- (Updated Jan. 23, 2014, 10:55 a.m.) Review request for KDE Frameworks and Alex Merry. Repository: kapidox Description --- This new name should be less cryptic. Diffs - README.md c1fe269 setup.py c87944c src/depdiagram-generate PRE-CREATION src/depdiagram-generate-all PRE-CREATION src/depdiagram-prepare PRE-CREATION src/kapidox/depdiagram/block.py PRE-CREATION src/kapidox/depdiagram/framework.py PRE-CREATION src/kapidox/depdiagram/frameworkdb.py PRE-CREATION src/kapidox/kf5dot/__init__.py e69de29 src/kapidox/kf5dot/block.py 045fbf5 src/kapidox/kf5dot/framework.py 21f4cf6 src/kapidox/kf5dot/frameworkdb.py 63f7e27 src/kf5dot-generate 8d44e20 src/kf5dot-generate-all 244ed12 src/kf5dot-prepare 3d133d9 Diff: https://git.reviewboard.kde.org/r/115253/diff/ Testing --- Regenerated dependency diagrams. Works fine. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115253: Rename kf5dot-* tools to depdiagram-*
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115253/ --- (Updated Jan. 23, 2014, 5:01 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Alex Merry. Repository: kapidox Description --- This new name should be less cryptic. Diffs - README.md c1fe269 setup.py c87944c src/depdiagram-generate PRE-CREATION src/depdiagram-generate-all PRE-CREATION src/depdiagram-prepare PRE-CREATION src/kapidox/depdiagram/block.py PRE-CREATION src/kapidox/depdiagram/framework.py PRE-CREATION src/kapidox/depdiagram/frameworkdb.py PRE-CREATION src/kapidox/kf5dot/__init__.py e69de29 src/kapidox/kf5dot/block.py 045fbf5 src/kapidox/kf5dot/framework.py 21f4cf6 src/kapidox/kf5dot/frameworkdb.py 63f7e27 src/kf5dot-generate 8d44e20 src/kf5dot-generate-all 244ed12 src/kf5dot-prepare 3d133d9 Diff: https://git.reviewboard.kde.org/r/115253/diff/ Testing --- Regenerated dependency diagrams. Works fine. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to stable : ktexteditor_master_qt5 #131
See http://build.kde.org/job/ktexteditor_master_qt5/131/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: QFileDialog not usable with frameworkintegration
On Thu, Jan 23, 2014 at 5:16 PM, Aleix Pol aleix...@kde.org wrote: On Thu, Jan 23, 2014 at 11:49 AM, codeminis...@publicstatic.de wrote: Hi, as described in https://git.reviewboard.kde.org/r/115238/ there is a bug QFileDialog frameworkintegration. As opposed to written in the review request the dialog is not usable at the moment if someone wants to select a non-existing file because it crashes. 1. $ ./qfiledialogtest --acceptMode save --selectFile /tmp/moo.png 2. (Note that the selectFile has no effect) 3. Manually select a file 4. Edit the Name text box and write some non-existing name 5. Press ok 6. qfiledialogtest(4329)/(default) QFileInfo::absolutePath: QFileInfo::absolutePath: Constructed with empty filename qfiledialogtest(4329)/(default) qt_assert: ASSERT: d in file ../../include/QtCore/../../src/corelib/tools/qscopedpointer.h, line 120 Aborted Best regards Gregor ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel I'm looking into this. Aleix The described issues should be fixed with this and following commits: http://commits.kde.org/frameworkintegration/cfa3cada6aec542711080f1fa40ba21287587d42 Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115268: Replace the KDE_ENABLE_EXCEPTIONS variable with a pair of functions
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115268/
---
Review request for Build System, Extra Cmake Modules and KDE Frameworks.
Repository: extra-cmake-modules
Description
---
Replace the KDE_ENABLE_EXCEPTIONS variable with a pair of functions
kde_enable_exceptions() essentially does what
set(CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS} ${KDE_ENABLE_EXCEPTIONS})
used to do. kde_target_enable_exceptions does it on a per-target basis.
Diffs
-
kde-modules/KDECompilerSettings.cmake
7891136124ced0273ff05bbe521d93acc22a00f7
Diff: https://git.reviewboard.kde.org/r/115268/diff/
Testing
---
Both macros tested with ThreadWeaver (compilation and tests).
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115269: Improve dependency specifications
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115269/ --- Review request for KDE Frameworks. Repository: kdnssd-framework Description --- KConfig is only required when DNSSD is found, and QtDBus is only required when either Avahi or DNSSD is found, so don't require them unconditionally. Diffs - CMakeLists.txt defb7bbb70a6b7567e5d7d0e6b8097f57ad07a15 src/CMakeLists.txt ef84ffa5ae5cfdfd2547c458e446cf4c9a2c7420 Diff: https://git.reviewboard.kde.org/r/115269/diff/ Testing --- Still builds against Avahi, DNSSD, and neither backends. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Build failed in Jenkins: kde4support_master_qt5 #32
Hi, I think the problem is the -std=iso9899:1990 in our KDECompilerSettings.cmake, that causes at least this error on my machine locally. (openSUSE 13.1, gcc 4.8.1) Without that, the configure checks work correct and we have the right HAVE_* stuff set. Is there some known issue with that compiler or did build.kde.org change? That line wasn't touched since some months. Greetings Christoph - Ursprüngliche Mail - See http://build.kde.org/job/kde4support_master_qt5/32/changes Changes: [agateau] Move api doc images to docs/pics -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW: http://www.AbsInt.com Geschäftsführung: Dr.-Ing. Christian Ferdinand Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Build failed in Jenkins: kde4support_master_qt5 #32
On Fri, Jan 24, 2014 at 8:36 AM, Christoph Cullmann cullm...@absint.com wrote: Hi, I think the problem is the -std=iso9899:1990 in our KDECompilerSettings.cmake, that causes at least this error on my machine locally. (openSUSE 13.1, gcc 4.8.1) Without that, the configure checks work correct and we have the right HAVE_* stuff set. Is there some known issue with that compiler or did build.kde.org change? That line wasn't touched since some months. There has been no changes in regards to the compiler, etc. on build.kde.org in the past few weeks. The only thing that could have changed would be the version of CMake - as we follow the 'next' branch, so this could be a CMake regression. Greetings Christoph Thanks, Ben - Ursprüngliche Mail - See http://build.kde.org/job/kde4support_master_qt5/32/changes Changes: [agateau] Move api doc images to docs/pics -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW: http://www.AbsInt.com Geschäftsführung: Dr.-Ing. Christian Ferdinand Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115218: rename dbus interface file on install for kwallet
On Jan. 22, 2014, 9:27 p.m., Valentin Rusu wrote: src/api/KWallet/CMakeLists.txt, line 100 https://git.reviewboard.kde.org/r/115218/diff/1/?file=235142#file235142line100 The interface will be strictly the same. New features will be added to secret service. That's why I didn't consider changing it's name. And, btw, changing it's name will make users think that changes have been (or will be) done to this API. Hrvoje Senjan wrote: @Valentin, interface name is now org.kde.kwalletd5, as per your last change in api/KWallet/kwallet.cpp runtime/kwalletd/kwalletd.cpp. Jonathan Riddell wrote: Yes you changed the interface which you say is unnecessary. My patch is just a change of filename to allow co-installability with kdelibs4 but the dbus interface name isn't changed. Considering that, with KDE4: kwalletd | --- exposes org.kde.kwalletd | - implements interface org.kde.KWallet.xml With KF5: kwalletd5 (binary, must have different name to coinstall in same bin directory) | --- exposes org.kde.kwalletd5 (dbus object name, must have different name to be able to be launched on the same dbus session) | - implements interface org.kde.KWallet.xml the same as KDE4, installation directory is the same, but if replaced there's no conflict (or am I wrong?) I think that there is no need to do a second copy of og.kde.KWallet.xml What do you think about this? - Valentin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115218/#review48079 --- On Jan. 22, 2014, 11:23 a.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115218/ --- (Updated Jan. 22, 2014, 11:23 a.m.) Review request for KDE Frameworks and Valentin Rusu. Repository: kwallet-framework Description --- Rename kwallet dbus interface file on install so it does not clash with equivalent file from kdelibs4. The dbus interface remains the same to keep compatibility with kdelibs4 kwallet. However you seem to have renamed the interface in places in the code in runtime/, will it be incompatible with the version from kdelibs4? Diffs - src/api/KWallet/CMakeLists.txt d0d5a3d Diff: https://git.reviewboard.kde.org/r/115218/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Tier status of attica kwallet
On Wednesday, January 22, 2014 10:48:00 PM Kevin Ottens wrote: On Wednesday 22 January 2014 22:21:47 Valentin Rusu wrote: On Thursday, January 23, 2014 04:24:37 AM Michael Palimaka wrote: Hi, attica seems to have been absorbed as a framework, but does not appear to have been assigned a tier. Based on its dependencies, it looks like it would fit in tier 1? kwallet is in tier 2, but since b60582640d99e0ef603bf4e02df974793fb5ad27 it includes kwalletd which depends on higher tier frameworks - does it still belong in tier 2? kwallet-framework is still tier2, as there are no higher dependencies, AFAIK. If it depends on anything else which is not in Qt or tier 1, it automatically becomes tier 3. It can't depend on anything which is tier 2. OK, then it's tier3 :-) Regards. -- Valentin Rusu irc: valir signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Tier status of attica kwallet
On Thursday, January 23, 2014 11:18:02 PM Michael Palimaka wrote: On 01/23/2014 08:21 AM, Valentin Rusu wrote: On Thursday, January 23, 2014 04:24:37 AM Michael Palimaka wrote: Sure, the framework itself is still tier 2...but the repo also includes kwalletd which definitely is not tier 2, and there does not appear to be any option to control building them independently. I'll add that option asap. -- Valentin Rusu irc: valir signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115218: rename dbus interface file on install for kwallet
On Jan. 22, 2014, 9:27 p.m., Valentin Rusu wrote: src/api/KWallet/CMakeLists.txt, line 100 https://git.reviewboard.kde.org/r/115218/diff/1/?file=235142#file235142line100 The interface will be strictly the same. New features will be added to secret service. That's why I didn't consider changing it's name. And, btw, changing it's name will make users think that changes have been (or will be) done to this API. Hrvoje Senjan wrote: @Valentin, interface name is now org.kde.kwalletd5, as per your last change in api/KWallet/kwallet.cpp runtime/kwalletd/kwalletd.cpp. Jonathan Riddell wrote: Yes you changed the interface which you say is unnecessary. My patch is just a change of filename to allow co-installability with kdelibs4 but the dbus interface name isn't changed. Valentin Rusu wrote: Considering that, with KDE4: kwalletd | --- exposes org.kde.kwalletd | - implements interface org.kde.KWallet.xml With KF5: kwalletd5 (binary, must have different name to coinstall in same bin directory) | --- exposes org.kde.kwalletd5 (dbus object name, must have different name to be able to be launched on the same dbus session) | - implements interface org.kde.KWallet.xml the same as KDE4, installation directory is the same, but if replaced there's no conflict (or am I wrong?) I think that there is no need to do a second copy of og.kde.KWallet.xml What do you think about this? exposes org.kde.kwalletd5 (dbus object name, must have different name to be able to be launched on the same dbus session) ApplicationName still has kwalletd, so two daemons (kwalletd kwalletd5) atm cannot be started. i guess that was just omission in your change? ;-) but if replaced there's no conflict how do you mean? we cannot ship 2 packages providing the same filename and not make the conflict. that is the point of this request =) (yes, it could be confusing, but so far we found this to be the 'best' approach - if interface is left to be named same as gen 4.x. maybe to add a comment above the install() section?) - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115218/#review48079 --- On Jan. 22, 2014, 11:23 a.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115218/ --- (Updated Jan. 22, 2014, 11:23 a.m.) Review request for KDE Frameworks and Valentin Rusu. Repository: kwallet-framework Description --- Rename kwallet dbus interface file on install so it does not clash with equivalent file from kdelibs4. The dbus interface remains the same to keep compatibility with kdelibs4 kwallet. However you seem to have renamed the interface in places in the code in runtime/, will it be incompatible with the version from kdelibs4? Diffs - src/api/KWallet/CMakeLists.txt d0d5a3d Diff: https://git.reviewboard.kde.org/r/115218/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Tier status of attica kwallet
On 23/01/14 21:50, Valentin Rusu wrote: On Thursday, January 23, 2014 11:18:02 PM Michael Palimaka wrote: On 01/23/2014 08:21 AM, Valentin Rusu wrote: On Thursday, January 23, 2014 04:24:37 AM Michael Palimaka wrote: Sure, the framework itself is still tier 2...but the repo also includes kwalletd which definitely is not tier 2, and there does not appear to be any option to control building them independently. I'll add that option asap. Is that useful? Would anyone have any use for the library without the daemon? Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Build failed in Jenkins: kde4support_master_qt5 #32
On Fri, Jan 24, 2014 at 8:36 AM, Christoph Cullmann cullm...@absint.com wrote: Hi, I think the problem is the -std=iso9899:1990 in our KDECompilerSettings.cmake, that causes at least this error on my machine locally. (openSUSE 13.1, gcc 4.8.1) Without that, the configure checks work correct and we have the right HAVE_* stuff set. Is there some known issue with that compiler or did build.kde.org change? That line wasn't touched since some months. There has been no changes in regards to the compiler, etc. on build.kde.org in the past few weeks. The only thing that could have changed would be the version of CMake - as we follow the 'next' branch, so this could be a CMake regression. That would make sense, too. kjs has similar issues here (like an other guy reported already on frameworks-devel) Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW: http://www.AbsInt.com Geschäftsführung: Dr.-Ing. Christian Ferdinand Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KIO::convertSize(.,.) vs. KFormat::formatByteSize(...)
Hi,
I see a few overlappings between methods in KFormat (KCoreAddons) and KIO
(KIOCore), mainly this pair:
namespace KIO
{
typedef qulonglong filesize_t;
KIOCORE_EXPORT QString convertSize(KIO::filesize_t size);
}
[[Takes the binary unit dialect to use from a config file given by
QStandardPaths::GenericDataLocation, QLatin1String(locale/) +
QString::fromLatin1(l10n/%1/entry.desktop).arg(countryString), from the
group KCM Locale. Returns a number with the biggest unit where the exponent
is not 0.]]
and
class KCOREADDONS_EXPORT KFormat Q_DECL_FINAL
{
QString formatByteSize(double size,
int precision = 1,
KFormat::BinaryUnitDialect dialect =
KFormat::DefaultBinaryDialect,
KFormat::BinarySizeUnits units =
KFormat::DefaultBinaryUnits) const;
};
Questions:
Q1) What config files can be expected from KF5 modules?
So can KIO::convertSize(...) (which is already KDE4 code) expect such config
files to exist? Only in a Plasma workspace platform, or? How is platform
integration done in the KDE frameworks? E.g. in Unity, GNOME Shell, Win, etc.
I would expect that any matching config data is picked, if there is, otherwise
a hardcoded default. http://community.kde.org/Frameworks/Policies does not
mention that yet, but I guess that has been discussed before?
Q2) Should KIO::convertSize(...) not use KFormat::formatByteSize(...) behind
the scenes? (At least if it is turned into a deprecated method in the future?)
KIOCore currently already depends on KCoreAddons (due to KJob). Would be
strange if programs built on KF5 display file sizes differently, due to
different respected settings in the both methods.
Q3) Is double as type of parameter size for KFormat::formatByteSize(...)
really a good choice?
I would expect the type to be rather qulonglong, like it is with
KIO::convertSize(...). I have looked at many files with Okteta, but so for not
seen a file with a fraction byte ;)
There are a few more toString-formatting methods next to
KIO::convertSize(...), somehow I think those might be rather part of KFormat
API as well. But first I would like to see those 3 questions resolved.
Cheers
Friedrich
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Splitting kde-workspace and kde-runtime proposal
I don't clearly understand why KUriFilter-Plugins should go to plasma- workspace. I noticed KUriFilter is defined in kio and its plugins are used e.g. in kparts (browserextension). Shouldn't these go to kio? 2014/1/22 Kevin Ottens er...@kde.org On Tuesday 21 January 2014 12:05:26 Antonis Tsiapaliokas wrote: 1) Create two different groups named plasma-workspace and plasma-desktop like frameworks 2) Split out every component into individual repos 3) Assign repos to the related group. Advantages: 1) Easy to assign maintainer to individual component. 2) If we split only some repos, we can not mark it as part of workspace but this way we can do it. 3) More, may be? That's my humble suggestion. :) Again, this is a proposal so please! send any feedback you might have. Thanks! I think that splitting each individual component to its own repo might be a bit confusing. Because if we don't have two groups (plasma-desktop and plasma- workspace), then we will not be able to provide something as a standard solution. So each person will consider Plasma Desktop as something entirely different. Note however that it's not a proper argument for splitting repos or not since nowadays our infrastructure has the concept of grouping independently of the repos. So we could split in their own repo and still have a way to make a plasma-desktop and a plasma-workspace group. OTOH Sebas argument is much more compelling. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com -- Andrea Diamantini WEB: http://www.adjam.org rekonq project WEB: http://rekonq.kde.org IRC: rekonq@freenode ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KIO::convertSize(.,.) vs. KFormat::formatByteSize(...)
On Thu, January 23, 2014 23:43:36 Friedrich W. H. Kossebau wrote: Hi, I see a few overlappings between methods in KFormat (KCoreAddons) and KIO (KIOCore), mainly this pair: Questions: Q2) Should KIO::convertSize(...) not use KFormat::formatByteSize(...) behind the scenes? (At least if it is turned into a deprecated method in the future?) KIOCore currently already depends on KCoreAddons (due to KJob). Would be strange if programs built on KF5 display file sizes differently, due to different respected settings in the both methods. I would tend to agree we should use KFormat if we can but that one is not up to me. Q3) Is double as type of parameter size for KFormat::formatByteSize(...) really a good choice? I would expect the type to be rather qulonglong, like it is with KIO::convertSize(...). I have looked at many files with Okteta, but so for not seen a file with a fraction byte ;) I think you're right. I forget why this was a double (I worked on this code but I believe the API pre-dated my involvement). How would this go about being changed? Are we still doing BIC Mondays ;) or should I just do a review request? Regards, - Michael Pyne signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Build failed in Jenkins: kde4support_master_qt5 #32
On Fri, Jan 24, 2014 at 1:28 PM, šumski hrvoje.sen...@gmail.com wrote: On Friday 24 of January 2014 09:53:00 Ben Cooksley wrote: There has been no changes in regards to the compiler, etc. on build.kde.org in the past few weeks. The only thing that could have changed would be the version of CMake - as we follow the 'next' branch, so this could be a CMake regression. Hi Ben, Christoph, actually, this seems like a regression within one of frameworks, or e-c-m. Last build of kde4support went fine on openSUSE's OBS[1] few hours ago, however, after updating and rebuilding all frameworks in their dependency chain - build fails. Used CMake version there is 2.8.12.1. Just for the record, the CI system uses cmake version 2.8.12.20140118-g3117b6 at the moment. Cheers, Hrvoje Regards, Ben [1] https://build.opensuse.org/package/show/KDE:Unstable:Frameworks/kde4support ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Tier status of attica kwallet
On Thursday 23 January 2014 22:47:45 Valentin Rusu wrote: On Wednesday, January 22, 2014 10:48:00 PM Kevin Ottens wrote: On Wednesday 22 January 2014 22:21:47 Valentin Rusu wrote: On Thursday, January 23, 2014 04:24:37 AM Michael Palimaka wrote: Hi, attica seems to have been absorbed as a framework, but does not appear to have been assigned a tier. Based on its dependencies, it looks like it would fit in tier 1? kwallet is in tier 2, but since b60582640d99e0ef603bf4e02df974793fb5ad27 it includes kwalletd which depends on higher tier frameworks - does it still belong in tier 2? kwallet-framework is still tier2, as there are no higher dependencies, AFAIK. If it depends on anything else which is not in Qt or tier 1, it automatically becomes tier 3. It can't depend on anything which is tier 2. OK, then it's tier3 :-) Please make sure http://community.kde.org/Frameworks/List is up to date then. Cheers. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
