Re: Review Request 122755: Add testcases for KIO::del()

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122755/#review76790
---

Ship it!


Looks good to me, can you push yourself?


autotests/deletejobtest.cpp


Would it be better to use the unicode escaping? This can look weird in some 
set ups?


- Aleix Pol Gonzalez


On Feb. 28, 2015, 10:21 p.m., Martin Blumenstingl wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122755/
> ---
> 
> (Updated Feb. 28, 2015, 10:21 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> This adds some automated testcases for KIO::del().
> 
> My own code was buggy but I didn't notice this until I wrote those tests.
> Maybe you want to have them upstream to make sure noone breaks KIO::del.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt f613c1a 
>   autotests/deletejobtest.h PRE-CREATION 
>   autotests/deletejobtest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122755/diff/
> 
> 
> Testing
> ---
> 
> Tests are passing
> 
> 
> Thanks,
> 
> Martin Blumenstingl
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120649: Encode the URIs which end up in DTD files

[Luigi Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120649/
---

(Updated Feb. 28, 2015, 10:05 p.m.)


Status
--

This change has been marked as submitted.


Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and 
kdewin.


Repository: kdelibs4support


Description
---

The URI need to be encoded, because some valid characters for
filenames are not valid according RFC 2396.
Easy way to trigger the issue: when the path contains spaces,
as it happens on MacOSX builds.

The function is duplicated from the matching functions in kdoctools
because:
- this module will go away in the not far future;
- the function is not generic enough to be used outside (yet)

See also https://git.reviewboard.kde.org/r/120648/ for the twin review on 
kdoctools.


Diffs
-

  cmake/uriencode.cmake PRE-CREATION 
  src/CMakeLists.txt 4a1d80d 

Diff: https://git.reviewboard.kde.org/r/120649/diff/


Testing
---

It compiles, but I can't properly test Mac and Windows scenarios


Thanks,

Luigi Toscano

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120648: Encode the URIs which end up in DTD files

[Luigi Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/
---

(Updated Feb. 28, 2015, 10:02 p.m.)


Status
--

This change has been marked as submitted.


Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and 
kdewin.


Repository: kdoctools


Description
---

The URI need to be encoded, because some valid characters for
filenames are not valid according RFC 2396.
Easy way to trigger the issue: when the path contains spaces,
as it happens on MacOSX builds.

See also https://git.reviewboard.kde.org/r/120649/ for the twin review on 
kdelibs4support.


Diffs
-

  cmake/uriencode.cmake PRE-CREATION 
  src/CMakeLists.txt 341ecf4 

Diff: https://git.reviewboard.kde.org/r/120648/diff/


Testing
---

It compiles, but I can't properly test Mac and Windows scenarios


Thanks,

Luigi Toscano

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120648: Encode the URIs which end up in DTD files

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review76782
---

Ship it!


Ship It!

- Jeremy Whiting


On Oct. 19, 2014, 6:12 p.m., Luigi Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120648/
> ---
> 
> (Updated Oct. 19, 2014, 6:12 p.m.)
> 
> 
> Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, 
> and kdewin.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> The URI need to be encoded, because some valid characters for
> filenames are not valid according RFC 2396.
> Easy way to trigger the issue: when the path contains spaces,
> as it happens on MacOSX builds.
> 
> See also https://git.reviewboard.kde.org/r/120649/ for the twin review on 
> kdelibs4support.
> 
> 
> Diffs
> -
> 
>   cmake/uriencode.cmake PRE-CREATION 
>   src/CMakeLists.txt 341ecf4 
> 
> Diff: https://git.reviewboard.kde.org/r/120648/diff/
> 
> 
> Testing
> ---
> 
> It compiles, but I can't properly test Mac and Windows scenarios
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120649: Encode the URIs which end up in DTD files

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120649/#review76781
---

Ship it!


Ship It!

- Jeremy Whiting


On Oct. 19, 2014, 6:13 p.m., Luigi Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120649/
> ---
> 
> (Updated Oct. 19, 2014, 6:13 p.m.)
> 
> 
> Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, 
> and kdewin.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> ---
> 
> The URI need to be encoded, because some valid characters for
> filenames are not valid according RFC 2396.
> Easy way to trigger the issue: when the path contains spaces,
> as it happens on MacOSX builds.
> 
> The function is duplicated from the matching functions in kdoctools
> because:
> - this module will go away in the not far future;
> - the function is not generic enough to be used outside (yet)
> 
> See also https://git.reviewboard.kde.org/r/120648/ for the twin review on 
> kdoctools.
> 
> 
> Diffs
> -
> 
>   cmake/uriencode.cmake PRE-CREATION 
>   src/CMakeLists.txt 4a1d80d 
> 
> Diff: https://git.reviewboard.kde.org/r/120649/diff/
> 
> 
> Testing
> ---
> 
> It compiles, but I can't properly test Mac and Windows scenarios
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122755: Add testcases for KIO::del()

[Martin Blumenstingl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122755/
---

(Updated Feb. 28, 2015, 9:21 p.m.)


Review request for KDE Frameworks.


Changes
---

Fixed issues noted by Emmanuel.


Repository: kio


Description
---

This adds some automated testcases for KIO::del().

My own code was buggy but I didn't notice this until I wrote those tests.
Maybe you want to have them upstream to make sure noone breaks KIO::del.


Diffs (updated)
-

  autotests/CMakeLists.txt f613c1a 
  autotests/deletejobtest.h PRE-CREATION 
  autotests/deletejobtest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/122755/diff/


Testing
---

Tests are passing


Thanks,

Martin Blumenstingl

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122764: Adding missing licenses

[Maximiliano Curia]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122764/
---

(Updated Feb. 28, 2015, 7:38 p.m.)


Review request for KDE Frameworks.


Repository: kcoreaddons


Description (updated)
---

cmake/FindFAM.cmake needs to be distributed with a copy of
COPYING-CMAKE-SCRIPTS

And a number of files (I count 42 right now) are under the LGPL-2 (without the
or any later version option), and thus it's recommended to distribute the
complete license.

This patch was done after the rejection of the Debian ftpmasters of kcoreaddons 
(https://lists.debian.org/debian-qt-kde/2015/02/msg00239.html).


Diffs
-

  COPYING-CMAKE-SCRIPTS PRE-CREATION 
  COPYING.LGPL-2 PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/122764/diff/


Testing
---


Thanks,

Maximiliano Curia

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122764: Adding missing licenses

[Maximiliano Curia]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122764/
---

Review request for KDE Frameworks.


Repository: kcoreaddons


Description
---

cmake/FindFAM.cmake needs to be distributed with a copy of
COPYING-CMAKE-SCRIPTS

And a number of files (I count 42 right now) are under the LGPL-2 (without the
or any later version option), and thus it's recommended to distribute the
complete license.


Diffs
-

  COPYING-CMAKE-SCRIPTS PRE-CREATION 
  COPYING.LGPL-2 PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/122764/diff/


Testing
---


Thanks,

Maximiliano Curia

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122755: Add testcases for KIO::del()

[Emmanuel Pescosta]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122755/#review76769
---


Thanks for the test! :)

Maybe you can add some negative test cases (like read-only files - have a look 
at pastetest.cpp) as well and check if KIO sets the correct error codes?
That would be really awesome!

(Another test case which can be added to this test is in 
https://bugs.kde.org/show_bug.cgi?id=340950)

Please note that I'm not a KIO developer, so better wait for an ack from a KIO 
dev before you implement my suggestions. ;)


autotests/deldirtest.h


Maybe name it DeleteJobTest instead of DelDirTest? (because deleting of 
files and folders gets tested, so DelDir isn't correct)



autotests/deldirtest.h


can be a const method



autotests/deldirtest.cpp


I would add a "number of files" parameter to createEmptyTestFiles instead 
of using a global definintion or constant.



autotests/deldirtest.cpp


KJob::NoError instead of 0?


- Emmanuel Pescosta


On Feb. 28, 2015, 4:28 p.m., Martin Blumenstingl wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122755/
> ---
> 
> (Updated Feb. 28, 2015, 4:28 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> This adds some automated testcases for KIO::del().
> 
> My own code was buggy but I didn't notice this until I wrote those tests.
> Maybe you want to have them upstream to make sure noone breaks KIO::del.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt f613c1a 
>   autotests/deldirtest.h PRE-CREATION 
>   autotests/deldirtest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122755/diff/
> 
> 
> Testing
> ---
> 
> Tests are passing
> 
> 
> Thanks,
> 
> Martin Blumenstingl
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122755: Add testcases for KIO::del()

[Martin Blumenstingl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122755/
---

Review request for KDE Frameworks.


Repository: kio


Description
---

This adds some automated testcases for KIO::del().

My own code was buggy but I didn't notice this until I wrote those tests.
Maybe you want to have them upstream to make sure noone breaks KIO::del.


Diffs
-

  autotests/CMakeLists.txt f613c1a 
  autotests/deldirtest.h PRE-CREATION 
  autotests/deldirtest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/122755/diff/


Testing
---

Tests are passing


Thanks,

Martin Blumenstingl

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122754: Remove use of KI18N_MODULE_DIR.

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122754/
---

(Updated Feb. 28, 2015, 1:52 p.m.)


Review request for KDE Frameworks and Chusslove Illich.


Changes
---

More testing.


Repository: ki18n


Description
---

This variable (and the corresponding if/else in KF5I18NMacros) is
unnecessary, as the scripts needed by KF5I18NMacros.cmake are always in
the same directory as KF5I18NMacros.cmake.

We keep the variable, albeit set in a simpler way, in case anything else
is using it (by the CMake naming convention, a variable with no leading
underscore is public).


Diffs
-

  KF5I18nConfig.cmake.in 64dc5009e4821f9e1bb3631c596b56e66c578c3c 
  cmake/KF5I18NMacros.cmake a55f472bdfdebd2e353064f102c1f1372fdf0918 

Diff: https://git.reviewboard.kde.org/r/122754/diff/


Testing (updated)
---

Built, run `make test`. Built and installed ktexteditor (uses ki18n_wrap_ui).


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122754: Remove use of KI18N_MODULE_DIR.

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122754/
---

Review request for KDE Frameworks and Chusslove Illich.


Repository: ki18n


Description
---

This variable (and the corresponding if/else in KF5I18NMacros) is
unnecessary, as the scripts needed by KF5I18NMacros.cmake are always in
the same directory as KF5I18NMacros.cmake.

We keep the variable, albeit set in a simpler way, in case anything else
is using it (by the CMake naming convention, a variable with no leading
underscore is public).


Diffs
-

  KF5I18nConfig.cmake.in 64dc5009e4821f9e1bb3631c596b56e66c578c3c 
  cmake/KF5I18NMacros.cmake a55f472bdfdebd2e353064f102c1f1372fdf0918 

Diff: https://git.reviewboard.kde.org/r/122754/diff/


Testing
---

Built, run `make test`.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121317: Add JSON metadata to the kded modules

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121317/#review76764
---

Ship it!


Ship It!

- Sebastian Kügler


On Feb. 27, 2015, 11:35 p.m., Alex Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121317/
> ---
> 
> (Updated Feb. 27, 2015, 11:35 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Sebastian Kügler.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Add JSON metadata to the kded modules
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/kcookiejar/CMakeLists.txt 
> 40b4bfddf9e1b0de3edacac3806755b1d24f840a 
>   src/ioslaves/http/kcookiejar/kcookieserver.cpp 
> c441496dff316d4e94a4cccdfd46615cd76a7238 
>   src/kpac/CMakeLists.txt d844c4e250f55f99151e20e843ba22dc4c366f1f 
>   src/kpac/proxyscout.cpp 375f77503272e700929433c44086f4e213502c6e 
>   src/kpasswdserver/CMakeLists.txt 014a44eefdc88e8d0f41f026dee23bdf33e1ef4a 
>   src/kpasswdserver/kpasswdserver.cpp 
> 7bd34cc1286acb48e2e0060d97b7fad4cd0a4388 
> 
> Diff: https://git.reviewboard.kde.org/r/121317/diff/
> 
> 
> Testing
> ---
> 
> the converted modules can be loaded
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121317: Add JSON metadata to the kded modules

[Sebastian Kügler]

> On Dec. 1, 2014, 4:59 p.m., Aleix Pol Gonzalez wrote:
> > Have you checked if the "Background Services" kded still works after this?
> 
> Aleix Pol Gonzalez wrote:
> Sorry, I meant KCM.
> 
> Alex Richardson wrote:
> `grep -irn "background" /kf5-install/share/kservices5/kded` does not give 
> any results for me, where can I find that kded module?
> 
> Aleix Pol Gonzalez wrote:
> It's called "kcmkded", installed by plasma-desktop.

This should not matter for this review, as this patch only adds metadata, but 
doesn't switch over the querying yet.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121317/#review71202
---


On Feb. 27, 2015, 11:35 p.m., Alex Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121317/
> ---
> 
> (Updated Feb. 27, 2015, 11:35 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Sebastian Kügler.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Add JSON metadata to the kded modules
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/kcookiejar/CMakeLists.txt 
> 40b4bfddf9e1b0de3edacac3806755b1d24f840a 
>   src/ioslaves/http/kcookiejar/kcookieserver.cpp 
> c441496dff316d4e94a4cccdfd46615cd76a7238 
>   src/kpac/CMakeLists.txt d844c4e250f55f99151e20e843ba22dc4c366f1f 
>   src/kpac/proxyscout.cpp 375f77503272e700929433c44086f4e213502c6e 
>   src/kpasswdserver/CMakeLists.txt 014a44eefdc88e8d0f41f026dee23bdf33e1ef4a 
>   src/kpasswdserver/kpasswdserver.cpp 
> 7bd34cc1286acb48e2e0060d97b7fad4cd0a4388 
> 
> Diff: https://git.reviewboard.kde.org/r/121317/diff/
> 
> 
> Testing
> ---
> 
> the converted modules can be loaded
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122751: Let ecm_configure_package_config_file manage path variables.

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122751/
---

(Updated Feb. 28, 2015, 12:55 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, KDE Frameworks, Luigi Toscano, and Jeremy 
Whiting.


Repository: kdoctools


Description
---

This means that absolute data directory paths are handled correctly.


Diffs
-

  CMakeLists.txt 1b8d41415ce1043a6118a844d35ea99839693560 
  KF5DocToolsConfig.cmake.in eff3d70ae2dcd8711e340306a7fbd1f2d6ca3ece 

Diff: https://git.reviewboard.kde.org/r/122751/diff/


Testing
---

Ran cmake with and without absolute KDE_INSTALL_DATADIR path set. Checked 
generated KF5DocToolsConfig.cmake by eye.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122751: Let ecm_configure_package_config_file manage path variables.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122751/#review76758
---

Ship it!


Ship It!

- Jeremy Whiting


On Feb. 28, 2015, 3:23 a.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122751/
> ---
> 
> (Updated Feb. 28, 2015, 3:23 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks, Luigi Toscano, and Jeremy 
> Whiting.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> This means that absolute data directory paths are handled correctly.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 1b8d41415ce1043a6118a844d35ea99839693560 
>   KF5DocToolsConfig.cmake.in eff3d70ae2dcd8711e340306a7fbd1f2d6ca3ece 
> 
> Diff: https://git.reviewboard.kde.org/r/122751/diff/
> 
> 
> Testing
> ---
> 
> Ran cmake with and without absolute KDE_INSTALL_DATADIR path set. Checked 
> generated KF5DocToolsConfig.cmake by eye.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122751: Let ecm_configure_package_config_file manage path variables.

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122751/
---

Review request for Documentation, KDE Frameworks, Luigi Toscano, and Jeremy 
Whiting.


Repository: kdoctools


Description
---

This means that absolute data directory paths are handled correctly.


Diffs
-

  CMakeLists.txt 1b8d41415ce1043a6118a844d35ea99839693560 
  KF5DocToolsConfig.cmake.in eff3d70ae2dcd8711e340306a7fbd1f2d6ca3ece 

Diff: https://git.reviewboard.kde.org/r/122751/diff/


Testing
---

Ran cmake with and without absolute KDE_INSTALL_DATADIR path set. Checked 
generated KF5DocToolsConfig.cmake by eye.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122606: Fix startup of kssld5 dbus service

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122606/#review76754
---


I'm not acquainted with the codebase, but I can confirm that the patch solves 
the described problem for me.

- Heiko Becker


On Feb. 17, 2015, 2:34 nachm., Bartosz Sławianowski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122606/
> ---
> 
> (Updated Feb. 17, 2015, 2:34 nachm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> KSslCertificateManager is trying to connect to org.kde.kssld5 directly which 
> doesn't work because it lacks it's own .service dbus file needed for 
> start-on-demand.
> 
> This patch makes it connect correctly to org.kde.kiod5 (which then loads 
> kssld5 module and makes service available) instead.
> 
> 
> Diffs
> -
> 
>   src/core/ksslcertificatemanager.cpp a47ca68 
> 
> Diff: https://git.reviewboard.kde.org/r/122606/diff/
> 
> 
> Testing
> ---
> 
> KIO git with patch, tested with Konversation which used to spam SSL errors 
> before applying patch.
> 
> 
> Thanks,
> 
> Bartosz Sławianowski
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel