Re: Review Request 122875: Fix KIconEngine::paint to handle different devicePixelRatios
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122875/ --- (Updated March 11, 2015, 2:41 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Christoph Feck. Changes --- Submitted with commit 841f23a712dfc6be7fee16f8a6451ec4a084c45c by David Edmundson to branch master. Repository: kiconthemes Description --- This now matches the behaviour of QPixmapIconEngine::paint Diffs - src/kiconengine.cpp 6dff533 Diff: https://git.reviewboard.kde.org/r/122875/diff/ Testing --- Opened configure toolbars in konversation with QT_DEVICE_PIXEL_RATIO=2 QStyledItemDelegate calls QIcon::paint which ends up going through this code with our QPA. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: New framework: BluezQt
I'm forwarding the reply here too: The name KF5BluezQt seems inelegant, is has both a prefix and a suffix, how about just KF5Bluez? That would work, but only for cmake files, otherwise I would have to change namespace from BluezQt to just Bluez, which is obviously not a right thing. The headers get installed into /usr/include/BluezQt/, I guess that should be /usr/include/KF5/BluezQt/ ? It requires extra-cmake-modules 1.8 but seems to compile fine with 1.7. Fixed Do you expect this to be moved into KDE Frameworks? That gets tagged on April 4th. Or do you expect it to be moved into kde/workspace for release with Plasma? That gets tagged in April 9th. If it goes into Frameworks it must remain API and ABI compatible while in Plasma you only need to bump the soversion if it changes. Is it ready for that? Originally, I wanted to move it to frameworks. But if i think about it again, I plan to extend the library with new features which may break the ABI. So, I would like to move it to kde/workspace once reviewed. Thanks, David ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
New framework: BluezQt
Hi all, BluezQt is a wrapper library for Bluez 5 DBus API. It will be used in Bluedevil as a replacement for libbluedevil. It is currently in playground (playground/libs/bluez-qt). It should be a Tier 1 framework (only depends on Qt libs). The code should follow all framework policies and the build is green, so I'd like to submit BluezQt for review. Thanks, David ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
New framework: ModemManagerQt
Hi all, I would like to ask you if you could review ModemManagerQt library (currently as libmm-qt). I want to make it as framework before KF5 5.9.0 gets released and make Plasma 5.3 depend on it, otherwise we would have to release it again together with Plasma and wait three more months. The only missing part there are unit-tests, but I'm working on them, I already added one yesterday and will keep adding new ones. The API is very similar to NetworkManagerQt, so everything mentioned during NMQT review should be already fixed there. You can find it here under frameworks branch: https://projects.kde.org/projects/kde/workspace/libmm-qt Thanks a lot. Regards, Jan -- Jan Grulich Red Hat Czech, s.r.o jgrul...@redhat.com ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122876: Delay notifications a bit on Plasma startup
On March 12, 2015, 8:48 a.m., Martin Gräßlin wrote: timer looks wrong to me, too. Not because it's ugly, but because Plasma notifications will not go above the splash screen. The fallback might be ugly, but as I have seen: it goes above the splash screen. Thus I suggest that we implement missing pieces to figure out whether we are in startup and only show if startup is done. I'm all for it, but note that splash screen is terminated once Plasma starts, there should never be a case of Plasma running and being fully covered by the splash screen. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122876/#review77324 --- On March 9, 2015, 8:03 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122876/ --- (Updated March 9, 2015, 8:03 p.m.) Review request for KDE Frameworks and Eike Hein. Bugs: 344903 https://bugs.kde.org/show_bug.cgi?id=344903 Repository: knotifications Description --- Currently when something is started right after login and spawns a notification, an ugly popup (KPassivePopup fallback) will appear over the splash screen as the org.freedesktop.Notifications service is not ready yet. This patch delays the notifications by max 25 seconds if and only if KDE_FULL_SESSION is set and there's no Plasma (org.kde.plasmashell) running. If the org.freedesktop.Notifications does not appear within those 25 seconds, the notifications will be put on screen using KPassivePopup. Ideally this should also check if ksmserver is in the starting phase, but I haven't found a way to check for that. Suggestions welcome. Diffs - src/notifybypopup.h 416c533 src/notifybypopup.cpp 316ff2b Diff: https://git.reviewboard.kde.org/r/122876/diff/ Testing --- Plasma not running, emitted KNotification, nothing, started Plasma, notifications appeared when Plasma loaded. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122918: revert 2ee76f0 to fix QtQuickControls
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122918/ --- Review request for KDE Frameworks and Frederik Gladhorn. Bugs: 345002 https://bugs.kde.org/show_bug.cgi?id=345002 Repository: frameworkintegration Description --- Not sure it's the right approach, but right now, the FileDialog QtQuickControls will be broken in the kde interqation if set as modal, see https://bugs.kde.org/show_bug.cgi?id=345002 the commit 2ee76f0 makes show() not do anything in that case, and the FileDialog QML bindings seems to assume to call only show() Diffs - src/platformtheme/kdeplatformfiledialoghelper.cpp 9ffb1d9 Diff: https://git.reviewboard.kde.org/r/122918/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122887: Load and wrap the QML-only version of kcms if possible
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122887/ --- (Updated March 12, 2015, 2:58 p.m.) Review request for KDE Frameworks and Plasma. Repository: kcmutils Description --- This makes KCMLoader try to load the qobject-only, qml based kcms as well, if it succeeds it wraps them in the KCModuleQML KCModule subclass and returns it as loaded module (the class itself is not exported, so no new symbols). This makes systemsettings, kcmshell and any config dialog that loads kcms transparently load those config modules not based upon KCModule Diffs (updated) - CMakeLists.txt cb4ae5d src/CMakeLists.txt f7b869f src/kcmoduleloader.cpp 5ccf236 src/kcmoduleqml.cpp PRE-CREATION src/kcmoduleqml_p.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122887/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122886: QML-only KCM base
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 12, 2015, 2:55 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is a QObject-based fork of KCmodule, with the api slightly adaped to be more declarative friendly. it loads a qml file that then will be able to access its instance as kcm or as the KCM attached property, like what happens in plasmoids (for how attached proeprties work, unfortunately only properties of the base class will be accessible). They will be loaded in systemsettings by review 122887 Diffs (updated) - src/quickaddons/CMakeLists.txt 3c7a34b src/quickaddons/configmodule.h PRE-CREATION src/quickaddons/configmodule.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122886/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122887: Load and wrap the QML-only version of kcms if possible
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122887/ --- (Updated March 12, 2015, 7:01 p.m.) Review request for KDE Frameworks and Plasma. Repository: kcmutils Description --- This makes KCMLoader try to load the qobject-only, qml based kcms as well, if it succeeds it wraps them in the KCModuleQML KCModule subclass and returns it as loaded module (the class itself is not exported, so no new symbols). This makes systemsettings, kcmshell and any config dialog that loads kcms transparently load those config modules not based upon KCModule Diffs (updated) - CMakeLists.txt cb4ae5d src/CMakeLists.txt f7b869f src/kcmoduleloader.cpp 5ccf236 src/kcmoduleqml.cpp PRE-CREATION src/kcmoduleqml_p.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122887/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122886: QML-only KCM base
On March 10, 2015, 11:30 a.m., Marco Martin wrote: src/quickaddons/configmodule.h, line 43 https://git.reviewboard.kde.org/r/122886/diff/1/?file=354024#file354024line43 I don't particularly like the KDeclarative namespace here since the library is called QuickAddons, but unfortunately that name is terrible, since makes people think this arrives from Qt (should have been called KQuickAddons, all old classes in it namespaced etc, that library is a disaster :/)) I'm almost tempted to re-export everything under KQuickAddons both library and namespace, deprecating completely QuickAddons (ConfigModule class would be only in kquickaddons, not the old one) - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/#review77247 --- On March 12, 2015, 2:55 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 12, 2015, 2:55 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is a QObject-based fork of KCmodule, with the api slightly adaped to be more declarative friendly. it loads a qml file that then will be able to access its instance as kcm or as the KCM attached property, like what happens in plasmoids (for how attached proeprties work, unfortunately only properties of the base class will be accessible). They will be loaded in systemsettings by review 122887 Diffs - src/quickaddons/CMakeLists.txt 3c7a34b src/quickaddons/configmodule.h PRE-CREATION src/quickaddons/configmodule.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122886/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122893: Populate KIconDialog on showEvent
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- (Updated March 12, 2015, 7:57 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 1e9af6c54470e890597739f8f2189b0743a00b6f by Kai Uwe Broulik to branch master. Repository: kiconthemes Description --- Populate the dialog on showEvent, this way you can use the regular QDialog show() and exec() methods and use, for instance, Qt::WindowModal rather than having showDialog() or openDialog() mess with modality. showDialog() could probably be deprecated then. I don't know whether this is binary compatible. you can safely reimplement a virtual function defined in one of the base classes only if it is safe that the programs linked with the prior version call the implementation in the base class rather than the derived one Diffs - src/kicondialog.h ee4edca src/kicondialog.cpp 7a6c1f1 Diff: https://git.reviewboard.kde.org/r/122893/diff/ Testing --- Just calling show() on the KIconDialog works as expected, the icon button in kfileproperties thingie dialog still works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122893: Populate KIconDialog on showEvent
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- (Updated März 12, 2015, 7:10 nachm.) Review request for KDE Frameworks. Changes --- Remove spontaneous check. I think I misunderstood what it was all about. Repository: kiconthemes Description --- Populate the dialog on showEvent, this way you can use the regular QDialog show() and exec() methods and use, for instance, Qt::WindowModal rather than having showDialog() or openDialog() mess with modality. showDialog() could probably be deprecated then. I don't know whether this is binary compatible. you can safely reimplement a virtual function defined in one of the base classes only if it is safe that the programs linked with the prior version call the implementation in the base class rather than the derived one Diffs (updated) - src/kicondialog.h ee4edca src/kicondialog.cpp 7a6c1f1 Diff: https://git.reviewboard.kde.org/r/122893/diff/ Testing --- Just calling show() on the KIconDialog works as expected, the icon button in kfileproperties thingie dialog still works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122893: Populate KIconDialog on showEvent
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/#review77394 --- Ship it! Ship It! - Christoph Feck On March 12, 2015, 7:10 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- (Updated March 12, 2015, 7:10 p.m.) Review request for KDE Frameworks. Repository: kiconthemes Description --- Populate the dialog on showEvent, this way you can use the regular QDialog show() and exec() methods and use, for instance, Qt::WindowModal rather than having showDialog() or openDialog() mess with modality. showDialog() could probably be deprecated then. I don't know whether this is binary compatible. you can safely reimplement a virtual function defined in one of the base classes only if it is safe that the programs linked with the prior version call the implementation in the base class rather than the derived one Diffs - src/kicondialog.h ee4edca src/kicondialog.cpp 7a6c1f1 Diff: https://git.reviewboard.kde.org/r/122893/diff/ Testing --- Just calling show() on the KIconDialog works as expected, the icon button in kfileproperties thingie dialog still works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KDeclarative doesn't build with Qt 5.2 due to QOpenGLContext::isOpenGLES() from plotter
Hi, kdeclarative doesn't build on Qt 5.2 since commit 25c37a8a599f66e65be44ef99fd1fc8ca55dd477 [1] which introduced a hard dep on QOpenGLContext::isOpenGLES(), which is 5.3+ only. That commit was merged almost two months ago. Seems that I should configure some breakage notifications from the Zuul CI. Is KDeclarative supposed to support Qt 5.2? Cheers, Jan [1] http://quickgit.kde.org/?p=kdeclarative.gita=commitdiffh=25c37a8a599f66e65be44ef99fd1fc8ca55dd477 [2] http://doc.qt.io/qt-5/qopenglcontext.html#isOpenGLES -- Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kitemmodels_stable_qt5 #22
See http://build.kde.org/job/kitemmodels_stable_qt5/22/changes
Changes:
[steveire] KSPM: Fix setting selection state after source reset.
[steveire] Remove needless metatype registration.
[steveire] Remove .data() accessor from QPointer use.
[steveire] KDPM: Handle moves reported by the source model.
[steveire] Make the disconnections and connections to the source more typo-safe.
[steveire] Fix disconnection from 'previous' source models.
[steveire] KSPM: Connect properly to the source model if it is changed.
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/kitemmodels_stable_qt5/ws/
Running Prebuild steps
[kitemmodels_stable_qt5] $ /bin/sh -xe /tmp/hudson5465112237909364856.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
From git://anongit.kde.org/kitemmodels
41b8a5f..d65b14a master - origin/master
Branch jenkins set up to track remote branch master from origin.
== Cleaning Source Tree
HEAD is now at 41b8a5f KSPM: Fix behavior when a selection is made while
resetting.
Removing build/
Removing dotdata/
Removing local-inst/
Success build forhudson.tasks.Shell@3f8f0033
git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/kitemmodels # timeout=10
Fetching upstream changes from git://anongit.kde.org/kitemmodels
git --version # timeout=10
git -c core.askpass=true fetch --tags --progress
git://anongit.kde.org/kitemmodels +refs/heads/*:refs/remotes/origin/*
git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision d65b14a091c65ae5affa56eb05678e4bb667a847
(refs/heads/jenkins)
git config core.sparsecheckout # timeout=10
git checkout -f d65b14a091c65ae5affa56eb05678e4bb667a847
git rev-list 41b8a5fc848fd049813c99373d3131b683367e8c # timeout=10
git tag -a -f -m Jenkins Build #22 jenkins-kitemmodels_stable_qt5-22 #
timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck
results]
[kitemmodels_stable_qt5] $ /bin/sh -xe /tmp/hudson3983382069853336063.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: kitemmodels - Branch master
== Build Dependencies:
qt5 - Branch 5.3.2
dogtail - Branch master
extra-cmake-modules - Branch master
cmake - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
== Configuring Build
-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for __GLIBC__
-- Looking for __GLIBC__ - found
-- Performing Test _OFFT_IS_64BIT
-- Performing Test _OFFT_IS_64BIT - Success
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
CMake Warning (dev) at
/srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/qt5/inst/lib/cmake/Qt5Core/Qt5CoreMacros.cmake:224
(configure_file):
configure_file called with unknown argument(s):
COPY_ONLY
Call Stack (most recent call first):
autotests/proxymodeltestsuite/CMakeLists.txt:18 (qt5_add_resources)
This warning is for project developers. Use -Wno-dev to suppress it.
--
-- The following OPTIONAL packages have been found:
* Qt5Network (required version = 5.3.2)
* Qt5Qml (required version = 5.3.2)
* Qt5Quick (required version = 5.3.2)
* Qt5QuickWidgets (required version = 5.2.0)
-- The following REQUIRED packages have been found:
* ECM (required version = 1.8.0)
* Qt5Core (required version = 5.2.0)
* Qt5Test
* Qt5Gui (required version = 5.3.2)
* Qt5Widgets
* Qt5 (required version = 5.2.0)
-- Configuring done
-- Generating done
CMake Warning:
Manually-specified variables were not used by the project:
KDE4_BUILD_TESTS
LIB_SUFFIX
Re: [plasma-devel] Re: [Kde-hardware-devel] solid bugzilla product marked obsolete
On Thu, Mar 12, 2015 at 12:39:30AM +0100, David Edmundson wrote: On Thu, Mar 12, 2015 at 12:37 AM, Lamarque Souza lamar...@kde.org wrote: Hi all,A Following the obsolete action, could someone mark Network Management product as obsolete too? It is related to old Plasma NM 0.9.0.x series, which is now unmaintained. I've removed open for bugs option on that product. Ah you beat me to it :) Jonathan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : kitemmodels_master_qt5 #78
See http://build.kde.org/job/kitemmodels_master_qt5/78/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122926: Add setError method to JobViewV2 interface
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122926/ --- Review request for KDE Frameworks. Repository: kjobwidgets Description --- Currently, there is no way to retrieve value of KJob::error(). This patch adds a setError method to JobViewV2 interface that fixes the issue. This is needed to correctly handle job errors in notifications plasmoid. If this gets accepted, I will create a review request for plasma-workspace (changes in kuiserver, dataengine and notifications plasmoid). Diffs - src/kuiserverjobtracker.cpp 191359b src/org.kde.JobViewV2.xml cacb5e8 Diff: https://git.reviewboard.kde.org/r/122926/diff/ Testing --- Works fine with patched plasma-workspace Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kitemmodels_master_qt5 #77
See http://build.kde.org/job/kitemmodels_master_qt5/77/changes
Changes:
[steveire] KSPM: Fix setting selection state after source reset.
[steveire] Remove needless metatype registration.
[steveire] Remove .data() accessor from QPointer use.
[steveire] KDPM: Handle moves reported by the source model.
[steveire] Make the disconnections and connections to the source more typo-safe.
[steveire] Fix disconnection from 'previous' source models.
[steveire] KSPM: Connect properly to the source model if it is changed.
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/kitemmodels_master_qt5/ws/
Running Prebuild steps
[kitemmodels_master_qt5] $ /bin/sh -xe /tmp/hudson5639993512500149826.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
From git://anongit.kde.org/kitemmodels
f2b3de9..d65b14a master - origin/master
Branch jenkins set up to track remote branch master from origin.
== Cleaning Source Tree
HEAD is now at f2b3de9 Include Qt headers with a module prefix.
Removing build/
Removing dotdata/
Removing local-inst/
Success build forhudson.tasks.Shell@5b24ded7
git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/kitemmodels # timeout=10
Fetching upstream changes from git://anongit.kde.org/kitemmodels
git --version # timeout=10
git -c core.askpass=true fetch --tags --progress
git://anongit.kde.org/kitemmodels +refs/heads/*:refs/remotes/origin/*
git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision d65b14a091c65ae5affa56eb05678e4bb667a847
(refs/heads/jenkins)
git config core.sparsecheckout # timeout=10
git checkout -f d65b14a091c65ae5affa56eb05678e4bb667a847
git rev-list 41b8a5fc848fd049813c99373d3131b683367e8c # timeout=10
git tag -a -f -m Jenkins Build #77 jenkins-kitemmodels_master_qt5-77 #
timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck
results]
[kitemmodels_master_qt5] $ /bin/sh -xe /tmp/hudson5986859976443055827.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: kitemmodels - Branch master
== Build Dependencies:
qt5 - Branch 5.4.1
dogtail - Branch master
extra-cmake-modules - Branch master
cmake - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
== Configuring Build
-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for __GLIBC__
-- Looking for __GLIBC__ - found
-- Performing Test _OFFT_IS_64BIT
-- Performing Test _OFFT_IS_64BIT - Success
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
--
-- The following OPTIONAL packages have been found:
* Qt5Network (required version = 5.4.1)
* Qt5Qml (required version = 5.4.1)
* Qt5Quick (required version = 5.4.1)
* Qt5QuickWidgets (required version = 5.2.0)
-- The following REQUIRED packages have been found:
* ECM (required version = 1.8.0)
* Qt5Core (required version = 5.2.0)
* Qt5Test
* Qt5Gui (required version = 5.4.1)
* Qt5Widgets
* Qt5 (required version = 5.2.0)
-- Configuring done
-- Generating done
CMake Warning:
Manually-specified variables were not used by the project:
KDE4_BUILD_TESTS
LIB_SUFFIX
SIP_DEFAULT_SIP_DIR
-- Build files have been written to:
http://build.kde.org/job/kitemmodels_master_qt5/ws/build
== Commencing the Build
Scanning dependencies of target proxymodeltestsuite_automoc
Scanning dependencies of target KF5ItemModels_automoc
Scanning dependencies of target kdescendantsproxymodel_smoketest_automoc
Scanning dependencies of target testmodelqueuedconnections_automoc
Scanning
Re: solid bugzilla product marked obsolete
Network Management product is already closed for new bugs and the description points to plasma-nm product. Jonathan On Wed, Mar 11, 2015 at 08:37:50PM -0300, Lamarque Souza wrote: Hi all,A Following the obsolete action, could someone mark Network Management product as obsolete too? It is related to old Plasma NM 0.9.0.x series, which is now unmaintained. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : kitemmodels_stable_qt5 #23
See http://build.kde.org/job/kitemmodels_stable_qt5/23/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KDeclarative doesn't build with Qt 5.2 due to QOpenGLContext::isOpenGLES() from plotter
El Dijous, 12 de març de 2015, a les 14:03:09, Jan Kundrát va escriure: Hi, kdeclarative doesn't build on Qt 5.2 since commit 25c37a8a599f66e65be44ef99fd1fc8ca55dd477 [1] which introduced a hard dep on QOpenGLContext::isOpenGLES(), which is 5.3+ only. That commit was merged almost two months ago. Seems that I should configure some breakage notifications from the Zuul CI. Is KDeclarative supposed to support Qt 5.2? CMakeLists.txt says yes :D I guess we can either increase that to 5.3 or wrap the isOpenGLES with an ifdef and assume it's false for 5.3 Marco? Cheers, Albert Cheers, Jan [1] http://quickgit.kde.org/?p=kdeclarative.gita=commitdiffh=25c37a8a599f66e65 be44ef99fd1fc8ca55dd477 [2] http://doc.qt.io/qt-5/qopenglcontext.html#isOpenGLES ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122913: Added an event() version that takes no icon and will use a default one
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122913/#review77350 --- Small nitpick. src/knotification.cpp https://git.reviewboard.kde.org/r/122913/#comment53119 Those should be QStringLiteral, as you are constructing a QString. - Aleix Pol Gonzalez On March 12, 2015, 4:37 a.m., Albert Vaca Cintora wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122913/ --- (Updated March 12, 2015, 4:37 a.m.) Review request for KDE Frameworks and Martin Klapetek. Repository: knotifications Description --- Added an event() version that takes no icon and will use a default one depending on the notification type Diffs - src/knotification.h f2dcd74e26a4feefe53dc0e536b0178d5ce287e1 src/knotification.cpp 293de09bae8d16b77df81ee2fe447c3246a476b5 Diff: https://git.reviewboard.kde.org/r/122913/diff/ Testing --- Thanks, Albert Vaca Cintora ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122682: Respect KZip::extraField setting also when writing central header entries
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122682/ --- (Updated March 12, 2015, 11:30 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 9175940dc2e85f53621923a0fff253ec6f68e498 by Friedrich W. H. Kossebau to branch master. Repository: karchive Description --- Currently KZip when writing the central headers ignores the setting `extraField` and writes the extra fields in any case. Not perfect. At least confuses when debugging Zip files to see that extra data present, even if explicitely not asked for. There is no hint why that is done, both in the code or could I find anything in Goo^Wthe usual search indexes services, so I assume it was just a mistake. No unit tests this time, as I had no idea how to check that the extraFields are not written without doing errorprone seeking in the resulting file. So I just rely on the current unit tests not failing and having read the code changes 4x. Diffs - src/kzip.cpp 73121f3 Diff: https://git.reviewboard.kde.org/r/122682/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: New framework: ModemManagerQt
El Dijous, 12 de març de 2015, a les 09:56:06, Jan Grulich va escriure: Hi all, I would like to ask you if you could review ModemManagerQt library (currently as libmm-qt). I want to make it as framework before KF5 5.9.0 gets released and make Plasma 5.3 depend on it, otherwise we would have to release it again together with Plasma and wait three more months. The only missing part there are unit-tests, but I'm working on them, I already added one yesterday and will keep adding new ones. The API is very similar to NetworkManagerQt, so everything mentioned during NMQT review should be already fixed there. You can find it here under frameworks branch: https://projects.kde.org/projects/kde/workspace/libmm-qt Kill the framework branch? Move macros.h and mmdebug.h to _p.h? Can listBearers and findBearer be const? In InterfaceType i'd say you can let the enums be there even if the MM_CHECK_VERSION doesn't match, makes sure in case some others are added later they always have the same int value Make BearerStruct, IpConfig and NetworkTimeZonea and the structs in generictypes.h classes with dptr in case you ever need more fields in them? Add const to params of ip4ConfigChanged, ip6ConfigChanged and networkTimeZoneChanged? Cheers, Albert Thanks a lot. Regards, Jan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122893: Populate KIconDialog on showEvent
On March 12, 2015, 7:15 p.m., Christoph Feck wrote: Ship It! Thinking again, the way you use the eventFilter (for the KIconDialog object), it still will not work with derived classes not recompiled. You need to create a separate (child) object which has the eventFilter method, and watch the KIconDialog events this way. - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/#review77394 --- On March 12, 2015, 7:57 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- (Updated March 12, 2015, 7:57 p.m.) Review request for KDE Frameworks. Repository: kiconthemes Description --- Populate the dialog on showEvent, this way you can use the regular QDialog show() and exec() methods and use, for instance, Qt::WindowModal rather than having showDialog() or openDialog() mess with modality. showDialog() could probably be deprecated then. I don't know whether this is binary compatible. you can safely reimplement a virtual function defined in one of the base classes only if it is safe that the programs linked with the prior version call the implementation in the base class rather than the derived one Diffs - src/kicondialog.h ee4edca src/kicondialog.cpp 7a6c1f1 Diff: https://git.reviewboard.kde.org/r/122893/diff/ Testing --- Just calling show() on the KIconDialog works as expected, the icon button in kfileproperties thingie dialog still works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122890: Make KMessageWidget animation non pixelated with high DPR
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122890/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kwidgetsaddons Description --- KMessageWidget saves the contents into a pixmap buffer during animations. This buffer needs to be the size of the widget in device pixels, not user pixels otherwise it will appear blocky. Diffs - src/kmessagewidget.cpp bc7ba32 Diff: https://git.reviewboard.kde.org/r/122890/diff/ Testing --- Temporarily changed the timeline animation to be something slow and ran with QT_DEVICE_PIXEL_RAITO=4 on my machine. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
