Re: Review Request 125928: Ship the "new file templates" in the kiofilewidgets library using a .qrc

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125928/
---

(Updated Nov. 3, 2015, 9:45 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Christoph Cullmann, Frank Reininghaus, Rex 
Dieter, and Harald Sitter.


Changes
---

Submitted with commit 6ec29b03e4433c93bf5c2e5da977d019440020a9 by David Faure 
to branch master.


Bugs: 353642
https://bugs.kde.org/show_bug.cgi?id=353642


Repository: kio


Description
---

This solves the conflict with kde-baseapps 15.08.x, and simplifies deployment
on Win/Mac.

BUG: 353642
Change-Id: Id4f9e364ceeea6b1b93910aa100ff22ce3fd76a7


Diffs
-

  src/new_file_templates/templates.qrc PRE-CREATION 
  autotests/knewfilemenutest.cpp 968e16e9e8c5d0680c1e6e00af1403f3f5d9976f 
  src/CMakeLists.txt 27b0f2b0e86a0087d343226e8db056109b3cd5ab 
  src/filewidgets/CMakeLists.txt 6ec254971055d1d1ecf5cf7a6d4637b82a52c27d 
  src/filewidgets/knewfilemenu.cpp 577206dfa9c89c4db4750f1880547bfb9b6214e7 
  src/new_file_templates/CMakeLists.txt 
0684b1871b35757ebe59c71cff01104bc388bb0f 

Diff: https://git.reviewboard.kde.org/r/125928/diff/


Testing
---

Unittest (./knewfilemenutest)


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125877: Fix kdeplatformtheme_unittest after last commit

[Marco Martin]

> On Oct. 29, 2015, 8:26 p.m., Aleix Pol Gonzalez wrote:
> > autotests/kdeplatformtheme_unittest.cpp, line 237
> > 
> >
> > What does `qApp->wheelScrollLines()` return now?
> 
> David Rosca wrote:
> It returned the value I have set in mouse kcm, because the test 
> KdePlatformTheme is not installed to qApp (and WheelScrollLines is now set as 
> themeHint instead of directly calling qApp->setWheelScrollLines)
> 
> Aleix Pol Gonzalez wrote:
> So the behavior on all applications that used qApp->wheelScrollLines() 
> changed now?
> 
> David Rosca wrote:
> No, it just can't be set with QApplication::setWheelScrollLines (from 
> KdePlatformTheme constructor) because QApplication is querying QPlatformTheme 
> for the value. 
> 
> That is with Qt 5.5, older version didn't have the WheelScrollLines hint.

if QApplication is querying QPlatformTheme for wheelScrollLines(), why do you 
have to use themeHint directly?


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125877/#review87695
---


On Oct. 29, 2015, 8:22 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125877/
> ---
> 
> (Updated Oct. 29, 2015, 8:22 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> see summary
> 
> 
> Diffs
> -
> 
>   autotests/kdeplatformtheme_unittest.cpp f660ffd 
> 
> Diff: https://git.reviewboard.kde.org/r/125877/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125877: Fix kdeplatformtheme_unittest after last commit

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125877/#review87900
---


Ping

- David Rosca


On Oct. 29, 2015, 8:22 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125877/
> ---
> 
> (Updated Oct. 29, 2015, 8:22 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> see summary
> 
> 
> Diffs
> -
> 
>   autotests/kdeplatformtheme_unittest.cpp f660ffd 
> 
> Diff: https://git.reviewboard.kde.org/r/125877/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125928: Ship the "new file templates" in the kiofilewidgets library using a .qrc

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125928/
---

Review request for KDE Frameworks, Christoph Cullmann, Frank Reininghaus, Rex 
Dieter, and Harald Sitter.


Bugs: 353642
https://bugs.kde.org/show_bug.cgi?id=353642


Repository: kio


Description
---

This solves the conflict with kde-baseapps 15.08.x, and simplifies deployment
on Win/Mac.

BUG: 353642
Change-Id: Id4f9e364ceeea6b1b93910aa100ff22ce3fd76a7


Diffs
-

  src/new_file_templates/templates.qrc PRE-CREATION 
  autotests/knewfilemenutest.cpp 968e16e9e8c5d0680c1e6e00af1403f3f5d9976f 
  src/CMakeLists.txt 27b0f2b0e86a0087d343226e8db056109b3cd5ab 
  src/filewidgets/CMakeLists.txt 6ec254971055d1d1ecf5cf7a6d4637b82a52c27d 
  src/filewidgets/knewfilemenu.cpp 577206dfa9c89c4db4750f1880547bfb9b6214e7 
  src/new_file_templates/CMakeLists.txt 
0684b1871b35757ebe59c71cff01104bc388bb0f 

Diff: https://git.reviewboard.kde.org/r/125928/diff/


Testing
---

Unittest (./knewfilemenutest)


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125928: Ship the "new file templates" in the kiofilewidgets library using a .qrc

[Emmanuel Pescosta]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125928/#review87903
---


+1 otherwise :)


src/filewidgets/knewfilemenu.cpp (lines 581 - 582)


You can hand over the srcFile directly to storedPut, storedPut has an 
overload which takes a QIODevice


- Emmanuel Pescosta


On Nov. 3, 2015, 9:24 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125928/
> ---
> 
> (Updated Nov. 3, 2015, 9:24 a.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Cullmann, Frank Reininghaus, Rex 
> Dieter, and Harald Sitter.
> 
> 
> Bugs: 353642
> https://bugs.kde.org/show_bug.cgi?id=353642
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> This solves the conflict with kde-baseapps 15.08.x, and simplifies deployment
> on Win/Mac.
> 
> BUG: 353642
> Change-Id: Id4f9e364ceeea6b1b93910aa100ff22ce3fd76a7
> 
> 
> Diffs
> -
> 
>   src/new_file_templates/templates.qrc PRE-CREATION 
>   autotests/knewfilemenutest.cpp 968e16e9e8c5d0680c1e6e00af1403f3f5d9976f 
>   src/CMakeLists.txt 27b0f2b0e86a0087d343226e8db056109b3cd5ab 
>   src/filewidgets/CMakeLists.txt 6ec254971055d1d1ecf5cf7a6d4637b82a52c27d 
>   src/filewidgets/knewfilemenu.cpp 577206dfa9c89c4db4750f1880547bfb9b6214e7 
>   src/new_file_templates/CMakeLists.txt 
> 0684b1871b35757ebe59c71cff01104bc388bb0f 
> 
> Diff: https://git.reviewboard.kde.org/r/125928/diff/
> 
> 
> Testing
> ---
> 
> Unittest (./knewfilemenutest)
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 116 - Still Unstable!

[Marco Martin]

On Tuesday 03 November 2015, Albert Astals Cid wrote:
> El Monday 02 November 2015, a les 14:56:15, Marco Martin va escriure:
> > On Monday 02 November 2015, David Faure wrote:
> > > On Monday 02 November 2015 12:44:12 no-re...@kde.org wrote:
> > > > https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLA
> > > > TFO R
> > > > M=Linux,compiler=gcc/31/ Name: (root) Failed: 1 test(s), Passed: 10
> > > > test(s), Skipped: 0 test(s), Total: 11 test(s)Failed:
> > > > TestSuite.dialognativetest
> > > 
> > > Is anyone looking into fixing that, before making more commits to
> > > plasma-framework?
> > 
> > hmm, is the oxygen icon theme not installed anymore in kci?
> 
> oxygen is not a dependency of frameworksintegration so i guess no.
> 
> How does oxygen being installed influence the wheelScrollLines though?

ah, nevermind, i was looking at the messages right after it 
KdePlatformTheme_UnitTest::testPlatformIconEngine() Icon theme "oxygen" not 
found. that indeed has nothing to do with it.

how can it expect qApp->wheelScrollLines() to be 1234 and then 122? it's like 
that since ages so it used to pass, but that test doesn't look to make any 
sense?

-- 
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125877: Fix kdeplatformtheme_unittest after last commit

[David Rosca]

> On Oct. 29, 2015, 8:26 p.m., Aleix Pol Gonzalez wrote:
> > autotests/kdeplatformtheme_unittest.cpp, line 237
> > 
> >
> > What does `qApp->wheelScrollLines()` return now?
> 
> David Rosca wrote:
> It returned the value I have set in mouse kcm, because the test 
> KdePlatformTheme is not installed to qApp (and WheelScrollLines is now set as 
> themeHint instead of directly calling qApp->setWheelScrollLines)
> 
> Aleix Pol Gonzalez wrote:
> So the behavior on all applications that used qApp->wheelScrollLines() 
> changed now?
> 
> David Rosca wrote:
> No, it just can't be set with QApplication::setWheelScrollLines (from 
> KdePlatformTheme constructor) because QApplication is querying QPlatformTheme 
> for the value. 
> 
> That is with Qt 5.5, older version didn't have the WheelScrollLines hint.
> 
> Marco Martin wrote:
> if QApplication is querying QPlatformTheme for wheelScrollLines(), why do 
> you have to use themeHint directly?

Because that's what this autotest is doing (see how the other themeHints are 
tested above). It just tests if the KdePlatformTheme correctly gets the value 
from config.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125877/#review87695
---


On Oct. 29, 2015, 8:22 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125877/
> ---
> 
> (Updated Oct. 29, 2015, 8:22 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> see summary
> 
> 
> Diffs
> -
> 
>   autotests/kdeplatformtheme_unittest.cpp f660ffd 
> 
> Diff: https://git.reviewboard.kde.org/r/125877/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125928: Ship the "new file templates" in the kiofilewidgets library using a .qrc

[Harald Sitter]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125928/#review87905
---

Ship it!


LGTM

- Harald Sitter


On Nov. 3, 2015, 8:24 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125928/
> ---
> 
> (Updated Nov. 3, 2015, 8:24 a.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Cullmann, Frank Reininghaus, Rex 
> Dieter, and Harald Sitter.
> 
> 
> Bugs: 353642
> https://bugs.kde.org/show_bug.cgi?id=353642
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> This solves the conflict with kde-baseapps 15.08.x, and simplifies deployment
> on Win/Mac.
> 
> BUG: 353642
> Change-Id: Id4f9e364ceeea6b1b93910aa100ff22ce3fd76a7
> 
> 
> Diffs
> -
> 
>   src/new_file_templates/templates.qrc PRE-CREATION 
>   autotests/knewfilemenutest.cpp 968e16e9e8c5d0680c1e6e00af1403f3f5d9976f 
>   src/CMakeLists.txt 27b0f2b0e86a0087d343226e8db056109b3cd5ab 
>   src/filewidgets/CMakeLists.txt 6ec254971055d1d1ecf5cf7a6d4637b82a52c27d 
>   src/filewidgets/knewfilemenu.cpp 577206dfa9c89c4db4750f1880547bfb9b6214e7 
>   src/new_file_templates/CMakeLists.txt 
> 0684b1871b35757ebe59c71cff01104bc388bb0f 
> 
> Diff: https://git.reviewboard.kde.org/r/125928/diff/
> 
> 
> Testing
> ---
> 
> Unittest (./knewfilemenutest)
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

[Luigi Toscano]

> On Oct. 30, 2015, 8:29 a.m., David Faure wrote:
> > src/ioslaves/trash/trash.json, line 6
> > 
> >
> > That doesn't look very English to me ;)
> > 
> > The original is:
> > 
> > ExtraNames=Original Path,Deletion Date
> > 
> > But this shows a problem: missing support for translating this field. 
> > We didn't realize there was a translatable field in these files. Please add 
> > support for translations, like was done for other json files (talk to e.g. 
> > Luigi Toscano).
> 
> Christoph Cullmann wrote:
> Hmm, then we have a problem: We can no longer convert the stuff and 
> remove the .protocol files, or?
> 
> Christoph Cullmann wrote:
> Ok, did read up a bit, ExtraNames seems to be the only translated thing 
> (at least if I read KProtocolInfo docs the right way).
> Can do the same trick as desktop2json does for that. Seems not that hard.
> But then we need CMake stuff for it, or? To convert on the fly to have 
> translations using the .protocol files like we have ATM in the .desktop files 
> for the plugin stuff.
> 
> David Faure wrote:
> I don't think you're looking in the right direction. AFAIK there is 
> support for translating json files directly in l10n (json -> po -> json) 
> these days. As I said, please ask Luigi or maybe Albert.
> 
> Christoph Cullmann wrote:
> Ok ;=)
> 
> Christoph Cullmann wrote:
> CC Luigi here, too.
> I looked again at what we have btw. in the other frameworks and I nowhere 
> really found any json -> po and back way, but that doesn't mean its not there 
> ;=)
> 
> David Faure wrote:
> I'm pretty sure this is all done in the l10n module, not in the other 
> frameworks.
> 
> Christoph Cullmann wrote:
> Any idea who else to ping? With that patch at least the shipped IO slaves 
> work perfect on Win/Lin without any hacks, I would really like to get that 
> in. Some .protocol -> json -> ... translation stuff should be easy to do, but 
> for translating the list inside JSON I am a bit lost ;=)

Generically, the i18n (or l10n, never rememeber) group. This specific code 
(translation of json) was done by Burkhard Lueck. Now, I was out for vacation 
and business, so give some time. It's too late anyway from the next framework 
version, so there is one month.


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87721
---


On Nov. 1, 2015, 7:13 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Nov. 1, 2015, 7:13 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David 
> Faure, and Luigi Toscano.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125924: KJob::kill(Quiet) should also exit the event loop

[Aleix Pol Gonzalez]

> On Nov. 3, 2015, 1:40 p.m., Milian Wolff wrote:
> > src/lib/jobs/kjob.h, line 644
> > 
> >
> > move this into KJobPrivate, no?

I don't think I can. I tried and I wasn't able to call the QPrivateSignal from 
there.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125924/#review87922
---


On Nov. 2, 2015, 8:31 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125924/
> ---
> 
> (Updated Nov. 2, 2015, 8:31 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> To that end, this patch unifies both duplicated codes so it keeps consistent.
> 
> 
> Diffs
> -
> 
>   src/lib/jobs/kjob.h cfb6909 
>   src/lib/jobs/kjob.cpp ff5a171 
> 
> Diff: https://git.reviewboard.kde.org/r/125924/diff/
> 
> 
> Testing
> ---
> 
> Tests still pass, addresses issue in KIO: 
> https://git.reviewboard.kde.org/r/125164/
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125924: KJob::kill(Quiet) should also exit the event loop

[Milian Wolff]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125924/#review87922
---

Ship it!


lgtm, esp. if the tests pass


src/lib/jobs/kjob.h (line 644)


move this into KJobPrivate, no?


- Milian Wolff


On Nov. 2, 2015, 7:31 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125924/
> ---
> 
> (Updated Nov. 2, 2015, 7:31 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> To that end, this patch unifies both duplicated codes so it keeps consistent.
> 
> 
> Diffs
> -
> 
>   src/lib/jobs/kjob.h cfb6909 
>   src/lib/jobs/kjob.cpp ff5a171 
> 
> Diff: https://git.reviewboard.kde.org/r/125924/diff/
> 
> 
> Testing
> ---
> 
> Tests still pass, addresses issue in KIO: 
> https://git.reviewboard.kde.org/r/125164/
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125790: Recognize image/vnd.adobe.photoshop

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125790/#review87921
---



src/imageformats/psd.json (lines 2 - 3)


MimeTypes and Keys need to have the same number of entries. So you want

"Keys": [ "psd", "psd" ],


- Alex Merry


On Oct. 25, 2015, 12:15 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125790/
> ---
> 
> (Updated Oct. 25, 2015, 12:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> ---
> 
> This is the mimetype I get for .psd files
> 
> 
> Diffs
> -
> 
>   src/imageformats/psd.desktop 494b746 
>   src/imageformats/psd.json 859eede 
> 
> Diff: https://git.reviewboard.kde.org/r/125790/diff/
> 
> 
> Testing
> ---
> 
> I still don't get any thumbnails for PSD files, though.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Failure while executing KTar::open while using KCompressionDevice as the device

[Luiz Romário Santana Rios]

2015-11-02 23:03 GMT-03:00 Aleix Pol :
> On Tue, Nov 3, 2015 at 3:00 AM, Luiz Romário Santana Rios
>  wrote:
>> 2015-11-02 22:41 GMT-03:00 Aleix Pol :
>>> On Mon, Nov 2, 2015 at 6:53 PM, Luiz Romário Santana Rios
>>>  wrote:
 Hello,

 I'm trying to decompress a XZ archive downloaded using
 QNetworkAccessManager, so, according to the documents, I have to pass
 the QNetworkReply pointer to a KCompressionDevice and, then, use it as
 Ktar's device like this:

 https://gist.github.com/anonymous/b8fb686367f518a7dbb5

 The problem is that KTar::open() fails and returns false. The file I'm
 trying to extract has the following structure more or less:
 /root
 /root/dir
 /root/dir/file1
 /root/dir/file2
 ...

 So, as far as I've seen, the code runs normally when entering /root
 and /root/dir, but, pretty high in the stack, at
 KXzFilter::uncompress(), the call to lzma_code returns
 LZMA_FORMAT_ERROR while trying to uncompress file1 (or file2, I'm not
 sure). Here's the call stack:

 https://gist.github.com/anonymous/9ea380cfe48daadb5971

 Is this a bug? If it's a bug, how can I proceed to fix it?

 Thanks for the attention.
>>>
>>> Hi,
>>> A good first step would be coming up with a unit test like the ones
>>> you can find in karchive/autotests. If we have a reproducible test
>>> case it will be much faster to fix (for you and for us).
>>>
>>> Regards,
>>> Aleix
>>
>> I'll do that, but how do I host a local file so that it can be
>> "downloaded" from QNAM?
>>
>> --
>> Luiz Romário Santana Rios
>
> Using file:/// url scheme you can asynchronously read local files.
>
> Aleix

I created a pretty simple archive:
/root
/root/dir
/root/dir/file1: contents of file1
/root/dir/file2: contents of file2
/root/dir/file3: contents of file3

And then set up a simple test case:
Header: https://paste.kde.org/p8jkzlcgg/u5oiqj
Implementation: https://paste.kde.org/pt1yeawj1/t8sg8j

Then this happens:
[...]
QWARN : KCompressionDeviceTest::testXzNetworkReplyDevice()
QIODevice::seek: Cannot call seek on a sequential device
QWARN : KCompressionDeviceTest::testXzNetworkReplyDevice()
QIODevice::seek: Cannot call seek on a sequential device
QWARN : KCompressionDeviceTest::testXzNetworkReplyDevice()
QIODevice::seek: Cannot call seek on a sequential device
QWARN : KCompressionDeviceTest::testXzNetworkReplyDevice()
QIODevice::seek: Cannot call seek on a sequential device
QWARN : KCompressionDeviceTest::testXzNetworkReplyDevice()
QIODevice::seek: Cannot call seek on a sequential device
QSYSTEM: KCompressionDeviceTest::testXzNetworkReplyDevice() Maximum
amount of warnings exceeded. Use -maxwarnings to override.

Then the test freezes. I have to interrupt it so that it finishes. What's wrong?

-- 
Luiz Romário Santana Rios


kcompressiondevice_test.tar.xz
Description: application/xz
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125904: Save proxy url with correct scheme.

[Xuetian Weng]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125904/
---

(Updated Nov. 3, 2015, 3:48 p.m.)


Review request for KDE Frameworks and Eike Hein.


Repository: kio


Description
---

Currently, if user type a ip address/domain name in socks 5 proxy field, the 
saved proxy url in configuration file will start with http:// instead of 
socks:// . Same applies to ftp proxy.

The reason is that KUrlFilter append http scheme to url without scheme. This 
patch uses setDefaultUrlScheme to make sure the correct scheme is used.

Also make necessary change to make sure that loading url configuration will 
hide url scheme correctly.


Diffs (updated)
-

  src/kcms/kio/kproxydlg.cpp c8fd0cd 

Diff: https://git.reviewboard.kde.org/r/125904/diff/


Testing
---

Save socks proxy and ftp proxy will result in "ftp://; and "socks://".


Thanks,

Xuetian Weng

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125852: Depend on boost even if KACTIVITIES_LIBRARY_ONLY is enabled

[Heiko Becker]

> On Nov. 3, 2015, 5:21 nachm., Ivan Čukić wrote:
> > The current master (the library) should build without boost now.

Indeed. Thanks for the fix.


- Heiko


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125852/#review87947
---


On Okt. 28, 2015, 9:48 nachm., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125852/
> ---
> 
> (Updated Okt. 28, 2015, 9:48 nachm.)
> 
> 
> Review request for KDE Frameworks and Ivan Čukić.
> 
> 
> Bugs: 354521
> http://bugs.kde.org/show_bug.cgi?id=354521
> 
> 
> Repository: kactivities
> 
> 
> Description
> ---
> 
> This "fixes" the build with said cmake param when boost isn't available.
> The boost dependency was introduced with 
> 9274281f68b9fc387848a4b49b36934b6b216b3c.
> 
> BUG:354521
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 8a31b209ddc12577f969f3935443169cac2caeb2 
> 
> Diff: https://git.reviewboard.kde.org/r/125852/diff/
> 
> 
> Testing
> ---
> 
> Builds with KACTIVITIES_LIBRARY_ONLY=TRUE and FALSE.
> 
> Not sure if this is an acceptable way to fix the issue, or if the option 
> should be made to work without boost (or the option should possibly get 
> removed).
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125852: Depend on boost even if KACTIVITIES_LIBRARY_ONLY is enabled

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125852/
---

(Updated Nov. 3, 2015, 5:48 nachm.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and Ivan Čukić.


Bugs: 354521
http://bugs.kde.org/show_bug.cgi?id=354521


Repository: kactivities


Description
---

This "fixes" the build with said cmake param when boost isn't available.
The boost dependency was introduced with 
9274281f68b9fc387848a4b49b36934b6b216b3c.

BUG:354521


Diffs
-

  src/CMakeLists.txt 8a31b209ddc12577f969f3935443169cac2caeb2 

Diff: https://git.reviewboard.kde.org/r/125852/diff/


Testing
---

Builds with KACTIVITIES_LIBRARY_ONLY=TRUE and FALSE.

Not sure if this is an acceptable way to fix the issue, or if the option should 
be made to work without boost (or the option should possibly get removed).


Thanks,

Heiko Becker

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125924: KJob::kill(Quiet) should also exit the event loop

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125924/#review87944
---

Ship it!


Ship It!

- David Faure


On Nov. 2, 2015, 7:31 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125924/
> ---
> 
> (Updated Nov. 2, 2015, 7:31 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> To that end, this patch unifies both duplicated codes so it keeps consistent.
> 
> 
> Diffs
> -
> 
>   src/lib/jobs/kjob.h cfb6909 
>   src/lib/jobs/kjob.cpp ff5a171 
> 
> Diff: https://git.reviewboard.kde.org/r/125924/diff/
> 
> 
> Testing
> ---
> 
> Tests still pass, addresses issue in KIO: 
> https://git.reviewboard.kde.org/r/125164/
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125905: Make kactivitymanagerd a QApplication

[Ivan Čukić]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125905/#review87946
---

Ship it!


Ship It!

- Ivan Čukić


On Nov. 1, 2015, 1:33 a.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125905/
> ---
> 
> (Updated Nov. 1, 2015, 1:33 a.m.)
> 
> 
> Review request for KDE Frameworks, Martin Gräßlin and Ivan Čukić.
> 
> 
> Repository: kactivities
> 
> 
> Description
> ---
> 
> KWindowSystem is QWidget based so needs QApplication or asserts in some 
> situations (when run on unity7 for example)
> 
> 
> Diffs
> -
> 
>   src/service/Application.h 387d4d7 
>   src/service/Application.cpp ec74daa 
> 
> Diff: https://git.reviewboard.kde.org/r/125905/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125852: Depend on boost even if KACTIVITIES_LIBRARY_ONLY is enabled

[Ivan Čukić]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125852/#review87947
---


The current master (the library) should build without boost now.

- Ivan Čukić


On Oct. 28, 2015, 9:48 p.m., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125852/
> ---
> 
> (Updated Oct. 28, 2015, 9:48 p.m.)
> 
> 
> Review request for KDE Frameworks and Ivan Čukić.
> 
> 
> Bugs: 354521
> http://bugs.kde.org/show_bug.cgi?id=354521
> 
> 
> Repository: kactivities
> 
> 
> Description
> ---
> 
> This "fixes" the build with said cmake param when boost isn't available.
> The boost dependency was introduced with 
> 9274281f68b9fc387848a4b49b36934b6b216b3c.
> 
> BUG:354521
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 8a31b209ddc12577f969f3935443169cac2caeb2 
> 
> Diff: https://git.reviewboard.kde.org/r/125852/diff/
> 
> 
> Testing
> ---
> 
> Builds with KACTIVITIES_LIBRARY_ONLY=TRUE and FALSE.
> 
> Not sure if this is an acceptable way to fix the issue, or if the option 
> should be made to work without boost (or the option should possibly get 
> removed).
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125905: Make kactivitymanagerd a QApplication

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125905/
---

(Updated Nov. 3, 2015, 7:12 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Martin Gräßlin and Ivan Čukić.


Changes
---

Submitted with commit 8316370e021ff14c54dea4632ec7548253d731b4 by Albert Astals 
Cid to branch master.


Repository: kactivities


Description
---

KWindowSystem is QWidget based so needs QApplication or asserts in some 
situations (when run on unity7 for example)


Diffs
-

  src/service/Application.h 387d4d7 
  src/service/Application.cpp ec74daa 

Diff: https://git.reviewboard.kde.org/r/125905/diff/


Testing
---


Thanks,

Albert Astals Cid

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125938: Don't try to store a QDateTime in mmap'ed memory

[Albert Astals Cid]

> On nov. 3, 2015, 10:21 p.m., Alex Merry wrote:
> > src/kdeui/kpixmapcache.cpp, line 132
> > 
> >
> > Why time_t here, and quint32 further down? If anything, I'd expect it 
> > to be the other way around - this is the one that's important to be fixed.

Because this is exactly how the code of kdelibs4 was and i have decided to not 
get creative with a code that works, last time someone got creative with this 
code broke it :D


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125938/#review87970
---


On nov. 3, 2015, 8:53 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125938/
> ---
> 
> (Updated nov. 3, 2015, 8:53 p.m.)
> 
> 
> Review request for KDE Frameworks and Michael Pyne.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> ---
> 
> Need to use POD types.
> 
> 
> Diffs
> -
> 
>   src/kdeui/kpixmapcache.cpp c16384d 
> 
> Diff: https://git.reviewboard.kde.org/r/125938/diff/
> 
> 
> Testing
> ---
> 
> kigo doesn't crash on startup anymore.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 148 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/148/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 03 Nov 2015 22:19:49 +
Build duration: 13 min

CHANGE SET
Revision 27cc932453dadb16ecfe731339acee842fc2c244 by montel: (Use 
QStringLiteral)
  change: edit tests/kionetrctest.cpp
  change: edit src/filewidgets/kurlnavigatorplacesselector.cpp
  change: edit src/core/filesystemfreespacejob.cpp
  change: edit src/widgets/accessmanagerreply_p.cpp
  change: edit src/core/davjob.cpp
  change: edit src/widgets/kpropertiesdialog.cpp
  change: edit src/core/listjob.cpp
  change: edit src/core/ksslcertificatemanager.cpp
  change: edit autotests/mkpathjobtest.cpp
  change: edit src/core/kdirnotify.cpp
  change: edit src/core/desktopexecparser.cpp
  change: edit src/core/ktcpsocket.cpp
  change: edit src/core/global.cpp
  change: edit src/kpac/downloader.cpp
  change: edit src/filewidgets/kurlnavigatortogglebutton.cpp
  change: edit src/filewidgets/krecentdirs.cpp
  change: edit tests/kruntest.cpp
  change: edit tests/kioslavetest.cpp
  change: edit src/kcms/webshortcuts/main.cpp
  change: edit src/widgets/executablefileopendialog.cpp
  change: edit src/kcms/kio/useragentselectordlg.cpp
  change: edit src/core/statjob.cpp
  change: edit src/filewidgets/knewfilemenu.cpp
  change: edit src/kcms/kio/smbrodlg.cpp
  change: edit src/widgets/fileundomanager.cpp
  change: edit tests/listjobtest.cpp
  change: edit tests/ksycocaupdatetest.cpp
  change: edit src/core/slaveinterface.cpp
  change: edit autotests/kprotocolinfotest.cpp
  change: edit src/core/slave.cpp
  change: edit src/filewidgets/kurlnavigator.cpp
  change: edit src/filewidgets/kfileplacesview.cpp
  change: edit autotests/kfileplacesmodeltest.cpp
  change: edit autotests/kmountpointtest.cpp
  change: edit src/kcms/kio/kcookiespolicyselectiondlg.cpp
  change: edit autotests/knewfilemenutest.cpp
  change: edit src/ioslaves/help/xslt_help.cpp
  change: edit src/core/emptytrashjob.cpp
  change: edit tests/kurlrequestertest_gui.cpp
  change: edit src/widgets/ksslcertificatebox.cpp
  change: edit autotests/kacltest.cpp
  change: edit src/ioslaves/http/parsinghelpers.cpp
  change: edit src/filewidgets/kdiroperator.cpp
  change: edit src/core/sessiondata.cpp
  change: edit src/widgets/joburlcache.cpp
  change: edit src/filewidgets/kfileplaceeditdialog.cpp
  change: edit src/core/kcoredirlister.cpp
  change: edit src/filewidgets/kfilebookmarkhandler.cpp
  change: edit src/widgets/kopenwithdialog.cpp
  change: edit src/widgets/dropjob.cpp
  change: edit src/core/kfileitem.cpp
  change: edit src/core/slaveconfig.cpp
  change: edit src/filewidgets/kimagefilepreview.cpp
  change: edit autotests/clipboardupdatertest.cpp
  change: edit src/filewidgets/kfileplacesitem.cpp
  change: edit src/core/simplejob.cpp
  change: edit autotests/dropjobtest.cpp
  change: edit src/urifilters/ikws/searchprovider.cpp
  change: edit src/ioslaves/trash/kinterprocesslock.cpp
  change: edit src/filewidgets/kfilewidget.cpp
  change: edit tests/getalltest.cpp
  change: edit src/widgets/kautomount.cpp
  change: edit src/ioslaves/trash/trashsizecache.cpp
  change: edit src/core/dataprotocol.cpp
  change: edit src/core/dataslave.cpp
  change: edit src/core/kprotocolmanager.cpp
  change: edit src/ioslaves/ftp/ftp.cpp
  change: edit src/filewidgets/kfilefiltercombo.cpp
  change: edit src/core/slavebase.cpp
  change: edit src/widgets/kacleditwidget.cpp
  change: edit autotests/kurlcompletiontest.cpp
  change: edit src/urifilters/ikws/kurisearchfilter.cpp
  change: edit src/core/ksambashare.cpp
  change: edit src/widgets/kurlrequester.cpp
  change: edit src/core/job_error.cpp
  change: edit tests/previewtest.cpp
  change: edit src/widgets/kurlcombobox.cpp
  change: edit tests/kfilewidgettest_gui.cpp
  change: edit src/widgets/kdesktopfileactions.cpp
  change: edit src/urifilters/ikws/searchproviderdlg.cpp
  change: edit src/kssld/kssld.cpp
  change: edit src/widgets/renamedialog.cpp
  change: edit src/ioslaves/http/kcookiejar/kcookiejar.cpp
  change: edit autotests/http/httpobjecttest.cpp
  change: edit src/kioexec/main.cpp
  change: edit tests/kurlnavigatortest_gui.cpp
  change: edit src/ioslaves/http/http.cpp
  change: edit src/urifilters/shorturi/kshorturifilter.cpp
  change: edit src/ioslaves/trash/kio_trash.cpp
  change: edit src/ioslaves/http/kcookiejar/kcookiewin.cpp
  change: edit src/ioslaves/http/httpauthentication.cpp
  change: edit autotests/jobtest.cpp
  change: edit src/core/copyjob.cpp
  change: edit src/kpac/proxyscout.cpp
  change: edit src/widgets/kfileitemactions.cpp
  change: edit tests/kopenwithtest.cpp
  change: edit src/filewidgets/kurlnavigatorprotocolcombo.cpp
  change: edit src/core/knfsshare.cpp
  change: edit src/ioslaves/http/kcookiejar/kcookieserver.cpp
  change: edit src/ioslaves/http/http_cache_cleaner.cpp
  change: edit autotests/ktcpsockettest.cpp
  change: edit 

Re: Review Request 125924: KJob::kill(Quiet) should also exit the event loop

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125924/
---

(Updated Nov. 3, 2015, 10:44 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 17a1ff06f234de4e763494101254542ff49a8659 by Aleix Pol to 
branch master.


Repository: kcoreaddons


Description
---

To that end, this patch unifies both duplicated codes so it keeps consistent.


Diffs
-

  src/lib/jobs/kjob.h cfb6909 
  src/lib/jobs/kjob.cpp ff5a171 

Diff: https://git.reviewboard.kde.org/r/125924/diff/


Testing
---

Tests still pass, addresses issue in KIO: 
https://git.reviewboard.kde.org/r/125164/


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125164: Finish killed KIO jobs

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125164/
---

(Updated Nov. 3, 2015, 11:44 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks.


Repository: kio


Description
---

Scheduler::jobFinished cleans up the job but doesn't report it as such.


Diffs
-

  src/core/simplejob.cpp 3380cbe 
  autotests/jobtest.h 7641131 
  autotests/jobtest.cpp 7da92d5 

Diff: https://git.reviewboard.kde.org/r/125164/diff/


Testing
---

Added a test and made it pass.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87966
---


How does this work without modifying KProtocolInfoPrivate::KProtocolInfoPrivate?

- Albert Astals Cid


On nov. 1, 2015, 6:13 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated nov. 1, 2015, 6:13 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David 
> Faure, and Luigi Toscano.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125938: Don't try to store a QDateTime in mmap'ed memory

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125938/#review87974
---

Ship it!


I'm happy for this to go in - you may want to wait for mpyne to give it a 
once-over, though.

- Alex Merry


On Nov. 3, 2015, 8:53 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125938/
> ---
> 
> (Updated Nov. 3, 2015, 8:53 p.m.)
> 
> 
> Review request for KDE Frameworks and Michael Pyne.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> ---
> 
> Need to use POD types.
> 
> 
> Diffs
> -
> 
>   src/kdeui/kpixmapcache.cpp c16384d 
> 
> Diff: https://git.reviewboard.kde.org/r/125938/diff/
> 
> 
> Testing
> ---
> 
> kigo doesn't crash on startup anymore.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125790: Recognize image/vnd.adobe.photoshop

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125790/
---

(Updated Nov. 3, 2015, 7:51 nachm.)


Review request for KDE Frameworks.


Changes
---

Address issue
Still no PSD thumbs for me


Repository: kimageformats


Description
---

This is the mimetype I get for .psd files


Diffs (updated)
-

  src/imageformats/psd.json 859eede 
  src/imageformats/psd.desktop 494b746 

Diff: https://git.reviewboard.kde.org/r/125790/diff/


Testing
---

I still don't get any thumbnails for PSD files, though.


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124714: Add support to qmake's options to api.kde.org

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124714/#review87955
---


Sorry I've let this sit for so long - Real Life(TM) got in the way.

Rather than adding variables for each of these, I'd rather have some way to add 
free text to this field. Also, have you checked that an extra line break 
doesn't get added when the fields are not set?

Finally, have you explored ways to make these *not* be required? I don't know 
QMake's build system very well, but it seems to me that at least some of these 
might be able to go in the .pri file (and it might be possible to protect 
client projects from the need to set QT_NO_KEYWORDS).

- Alex Merry


On Aug. 12, 2015, 1:13 p.m., Lamarque Souza wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124714/
> ---
> 
> (Updated Aug. 12, 2015, 1:13 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> NetworkManagerQt requires some options to be added to .pro file to compile:
> 
> QT += NetworkManagerQt dbus network
> CONFIG += link_pkgconfig
> PKGCONFIG += libnm # from NetworkManager package
> DEFINES += QT_NO_KEYWORDS # libnm declares a variable named signals
> 
> kapidox already supports the first option (QT), but not the others. This 
> patch adds support to adding the other three options.
> 
> 
> Diffs
> -
> 
>   src/kapidox/data/templates/fwinfo.html a20c1d1 
> 
> Diff: https://git.reviewboard.kde.org/r/124714/diff/
> 
> 
> Testing
> ---
> 
> I added the lines below to networkmanager-qt/metainfo.html and kapidox 
> created the correct output:
> 
> qmakepro:
>  - config: link_pkgconfig
>  - defines: QT_NO_KEYWORDS
>  - pkgconfig: libnm
> 
> 
> Thanks,
> 
> Lamarque Souza
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125938: Don't try to store a QDateTime in mmap'ed memory

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125938/
---

Review request for KDE Frameworks and Michael Pyne.


Repository: kdelibs4support


Description
---

Need to use POD types.


Diffs
-

  src/kdeui/kpixmapcache.cpp c16384d 

Diff: https://git.reviewboard.kde.org/r/125938/diff/


Testing
---

kigo doesn't crash on startup anymore.


Thanks,

Albert Astals Cid

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125941: Add KCompressionDevice tests to KArchive

[Romário Rios]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125941/
---

Review request for KDE Frameworks and Aleix Pol Gonzalez.


Repository: karchive


Description
---

I recently noticed that using KTar with KCompressionDevice and QNetworkReply 
did not work, so I'm adding some tests to confirm that


Diffs
-

  autotests/CMakeLists.txt 1b2e819 
  autotests/kcompressiondevicetest.h PRE-CREATION 
  autotests/kcompressiondevicetest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125941/diff/


Testing
---

The tests run and show that KCompressionDevice isn't working as expected


Thanks,

Romário Rios

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125941: Add KCompressionDevice tests to KArchive

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125941/#review87980
---



autotests/kcompressiondevicetest.cpp (line 29)


Can't KArchive do that already?



autotests/kcompressiondevicetest.cpp (line 69)


Use QTemporaryDir.



autotests/kcompressiondevicetest.cpp (line 79)


You should compare to the file size, otherwise this all will have to be 
changed every time these files are modified.


Good first step!

- Aleix Pol Gonzalez


On Nov. 4, 2015, 3:08 a.m., Romário Rios wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125941/
> ---
> 
> (Updated Nov. 4, 2015, 3:08 a.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> I recently noticed that using KTar with KCompressionDevice and QNetworkReply 
> did not work, so I'm adding some tests to confirm that
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 1b2e819 
>   autotests/kcompressiondevicetest.h PRE-CREATION 
>   autotests/kcompressiondevicetest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125941/diff/
> 
> 
> Testing
> ---
> 
> The tests run and show that KCompressionDevice isn't working as expected
> 
> 
> Thanks,
> 
> Romário Rios
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125815: RFC: Attempt to provide an alternative when khelpcenter is not available

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125815/#review87979
---


Bump? Anyone with docs.kde.org knowledge around?

- Aleix Pol Gonzalez


On Oct. 26, 2015, 7:04 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125815/
> ---
> 
> (Updated Oct. 26, 2015, 7:04 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Cullmann and Luigi Toscano.
> 
> 
> Repository: kguiaddons
> 
> 
> Description
> ---
> 
> Tries to reach out to docs.kde.org when khelpcenter is not available.
> 
> 
> Diffs
> -
> 
>   src/util/urlhandler.cpp 5b46be2 
> 
> Diff: https://git.reviewboard.kde.org/r/125815/diff/
> 
> 
> Testing
> ---
> 
> I tried it with a couple of applications. For the main documentation just 
> works.
> 
> Needs figuring out for more complex cases, I'm unsure if applications are 
> opening the documentation in specific pages. In fact, I couldn't find the 
> documentation for docs.kde.org url scheme, and I just made up the `path` 
> part, although it seems to work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 156 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/156/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 03 Nov 2015 23:01:24 +
Build duration: 9 min 22 sec

CHANGE SET
Revision 57454f9080206f62aa3e67104b79539f1ad3822f by Albert Astals Cid: (Fix 
wrong QStringLiteral use)
  change: edit autotests/http/httpheaderdispositiontest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 
47 test(s)Failed: TestSuite.kiocore-threadtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 20/20 (100%)FILES 252/330 (76%)CLASSES 252/330 (76%)LINE 24747/49973 
(50%)CONDITIONAL 13378/20673 (65%)

By packages
  
autotests
FILES 60/60 (100%)CLASSES 60/60 (100%)LINE 6984/7201 
(97%)CONDITIONAL 3821/7023 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 475/476 
(100%)CONDITIONAL 166/272 (61%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 182/199 (91%)CONDITIONAL 
60/90 (67%)
src.core
FILES 94/116 (81%)CLASSES 94/116 (81%)LINE 7407/14022 
(53%)CONDITIONAL 3875/5391 (72%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2283/7589 
(30%)CONDITIONAL 912/1407 (65%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 430/843 (51%)CONDITIONAL 
313/459 (68%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 750/3800 
(20%)CONDITIONAL 547/678 (81%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 642/804 (80%)CONDITIONAL 
602/758 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 684/1182 (58%)CONDITIONAL 
358/495 (72%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 690/768 (90%)CONDITIONAL 
433/820 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/26 (54%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 302/388 (78%)CONDITIONAL 
86/108 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 384/600 (64%)CONDITIONAL 
280/408 (69%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 280/285 (98%)CONDITIONAL 
146/254 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 32/35 (91%)CONDITIONAL 
42/52 (81%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 248/743 (33%)CONDITIONAL 
147/194 (76%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 20/27 (74%)CONDITIONAL 
14/18 (78%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 226/256 (88%)CONDITIONAL 
292/358 (82%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2679/10636 
(25%)CONDITIONAL 1276/1872 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 149 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/149/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 03 Nov 2015 23:01:24 +
Build duration: 7 min 1 sec

CHANGE SET
Revision 57454f9080206f62aa3e67104b79539f1ad3822f by Albert Astals Cid: (Fix 
wrong QStringLiteral use)
  change: edit autotests/http/httpheaderdispositiontest.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 
47 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 20/20 (100%)FILES 253/331 (76%)CLASSES 253/331 (76%)LINE 24786/50010 
(50%)CONDITIONAL 13392/20695 (65%)

By packages
  
autotests
FILES 61/61 (100%)CLASSES 61/61 (100%)LINE 7021/7238 
(97%)CONDITIONAL 3833/7041 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 475/476 
(100%)CONDITIONAL 166/272 (61%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 182/199 (91%)CONDITIONAL 
60/90 (67%)
src.core
FILES 94/116 (81%)CLASSES 94/116 (81%)LINE 7404/14022 
(53%)CONDITIONAL 3875/5391 (72%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2283/7589 
(30%)CONDITIONAL 911/1407 (65%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 430/843 (51%)CONDITIONAL 
313/459 (68%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 750/3800 
(20%)CONDITIONAL 547/678 (81%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 642/804 (80%)CONDITIONAL 
602/758 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 684/1182 (58%)CONDITIONAL 
358/495 (72%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 690/768 (90%)CONDITIONAL 
433/820 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/26 (54%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 302/388 (78%)CONDITIONAL 
86/108 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 389/600 (65%)CONDITIONAL 
285/412 (69%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 280/285 (98%)CONDITIONAL 
144/254 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 32/35 (91%)CONDITIONAL 
42/52 (81%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 248/743 (33%)CONDITIONAL 
147/194 (76%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 20/27 (74%)CONDITIONAL 
14/18 (78%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 226/256 (88%)CONDITIONAL 
292/358 (82%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2679/10636 
(25%)CONDITIONAL 1276/1872 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 149 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/149/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 03 Nov 2015 23:01:24 +
Build duration: 7 min 1 sec

CHANGE SET
Revision 57454f9080206f62aa3e67104b79539f1ad3822f by Albert Astals Cid: (Fix 
wrong QStringLiteral use)
  change: edit autotests/http/httpheaderdispositiontest.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 
47 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 20/20 (100%)FILES 253/331 (76%)CLASSES 253/331 (76%)LINE 24786/50010 
(50%)CONDITIONAL 13392/20695 (65%)

By packages
  
autotests
FILES 61/61 (100%)CLASSES 61/61 (100%)LINE 7021/7238 
(97%)CONDITIONAL 3833/7041 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 475/476 
(100%)CONDITIONAL 166/272 (61%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 182/199 (91%)CONDITIONAL 
60/90 (67%)
src.core
FILES 94/116 (81%)CLASSES 94/116 (81%)LINE 7404/14022 
(53%)CONDITIONAL 3875/5391 (72%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2283/7589 
(30%)CONDITIONAL 911/1407 (65%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 430/843 (51%)CONDITIONAL 
313/459 (68%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 750/3800 
(20%)CONDITIONAL 547/678 (81%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 642/804 (80%)CONDITIONAL 
602/758 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 684/1182 (58%)CONDITIONAL 
358/495 (72%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 690/768 (90%)CONDITIONAL 
433/820 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/26 (54%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 302/388 (78%)CONDITIONAL 
86/108 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 389/600 (65%)CONDITIONAL 
285/412 (69%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 280/285 (98%)CONDITIONAL 
144/254 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 32/35 (91%)CONDITIONAL 
42/52 (81%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 248/743 (33%)CONDITIONAL 
147/194 (76%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 20/27 (74%)CONDITIONAL 
14/18 (78%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 226/256 (88%)CONDITIONAL 
292/358 (82%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2679/10636 
(25%)CONDITIONAL 1276/1872 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 155 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/155/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 03 Nov 2015 22:19:49 +
Build duration: 6 min 45 sec

CHANGE SET
Revision 27cc932453dadb16ecfe731339acee842fc2c244 by montel: (Use 
QStringLiteral)
  change: edit src/ioslaves/trash/tests/testtrash.cpp
  change: edit src/filewidgets/krecentdirs.cpp
  change: edit src/core/kssl/ksslsettings.cpp
  change: edit src/core/slaveconfig.cpp
  change: edit autotests/http/httpobjecttest.cpp
  change: edit src/widgets/kdirmodel.cpp
  change: edit src/widgets/kbuildsycocaprogressdialog.cpp
  change: edit tests/kionetrctest.cpp
  change: edit src/urifilters/fixhost/fixhosturifilter.cpp
  change: edit src/widgets/renamedialog.cpp
  change: edit src/filewidgets/kfileplacesview.cpp
  change: edit src/filewidgets/kfilefiltercombo.cpp
  change: edit tests/kruntest.cpp
  change: edit src/widgets/kautomount.cpp
  change: edit src/widgets/ksslinfodialog.cpp
  change: edit src/core/transferjob.cpp
  change: edit src/widgets/kacleditwidget.cpp
  change: edit autotests/jobtest.cpp
  change: edit src/core/mkdirjob.cpp
  change: edit src/widgets/kurifiltersearchprovideractions.cpp
  change: edit src/core/desktopexecparser.cpp
  change: edit src/ioslaves/http/kcookiejar/kcookiewin.cpp
  change: edit src/widgets/previewjob.cpp
  change: edit src/core/kpasswdserverloop.cpp
  change: edit autotests/kprotocolinfotest.cpp
  change: edit src/ioslaves/file/file_unix.cpp
  change: edit src/kcms/kio/kcookiesmain.cpp
  change: edit autotests/kcookiejar/kcookiejartest.cpp
  change: edit src/filewidgets/kencodingfiledialog.cpp
  change: edit autotests/kfileitemtest.cpp
  change: edit src/core/sessiondata.cpp
  change: edit autotests/ktcpsockettest.cpp
  change: edit src/widgets/joburlcache.cpp
  change: edit src/filewidgets/kurlnavigatorprotocolcombo.cpp
  change: edit src/filewidgets/kdiroperator.cpp
  change: edit src/kcms/kio/kcookiespolicies.cpp
  change: edit src/widgets/accessmanagerreply_p.cpp
  change: edit src/core/slaveinterface.cpp
  change: edit src/filewidgets/kurlnavigatorplacesselector.cpp
  change: edit src/ioslaves/http/parsinghelpers.cpp
  change: edit src/filewidgets/kfilemetapreview.cpp
  change: edit src/widgets/jobuidelegate.cpp
  change: edit autotests/kdirlistertest.cpp
  change: edit src/core/statjob.cpp
  change: edit autotests/kdirmodeltest.cpp
  change: edit src/widgets/kopenwithdialog.cpp
  change: edit src/ioslaves/file/file.cpp
  change: edit src/filewidgets/kfilewidget.cpp
  change: edit src/urifilters/ikws/kuriikwsfiltereng.cpp
  change: edit tests/ksycocaupdatetest.cpp
  change: edit src/core/kprotocolinfo.cpp
  change: edit src/filewidgets/kfilecopytomenu.cpp
  change: edit src/core/knfsshare.cpp
  change: edit src/widgets/kdesktopfileactions.cpp
  change: edit src/kpac/discovery.cpp
  change: edit src/ioslaves/ftp/ftp.cpp
  change: edit src/ioslaves/http/http.cpp
  change: edit src/kcms/kio/kcookiesmanagement.cpp
  change: edit src/core/kfileitem.cpp
  change: edit src/urifilters/ikws/kurisearchfilter.cpp
  change: edit src/core/multigetjob.cpp
  change: edit tests/kurlrequestertest_gui.cpp
  change: edit src/core/global.cpp
  change: edit src/core/slavebase.cpp
  change: edit src/ioslaves/trash/trashsizecache.cpp
  change: edit src/widgets/kurifilter.cpp
  change: edit src/filewidgets/kimagefilepreview.cpp
  change: edit src/core/kdirnotify.cpp
  change: edit tests/kdirmodeltest_gui.cpp
  change: edit src/widgets/kurlcombobox.cpp
  change: edit src/ioslaves/trash/ktrash.cpp
  change: edit src/filewidgets/kfileplacesitem.cpp
  change: edit src/kcms/kio/cache.cpp
  change: edit src/filewidgets/knewfilemenu.cpp
  change: edit autotests/udsentry_benchmark.cpp
  change: edit src/kcms/kio/netpref.cpp
  change: edit src/filewidgets/kurlnavigatorbutton.cpp
  change: edit src/widgets/kurlcompletion.cpp
  change: edit src/core/kssld_interface.h
  change: edit autotests/kurlrequestertest.cpp
  change: edit src/core/kpasswdserverclient.cpp
  change: edit src/kcms/webshortcuts/main.cpp
  change: edit src/ioslaves/telnet/ktelnetservice.cpp
  change: edit src/ioslaves/trash/kinterprocesslock.cpp
  change: edit autotests/clipboardupdatertest.cpp
  change: edit autotests/knewfilemenutest.cpp
  change: edit src/kcms/kio/useragentinfo.cpp
  change: edit src/widgets/sslui.cpp
  change: edit src/core/filecopyjob.cpp
  change: edit tests/kioslavetest.cpp
  change: edit src/kiod/kiod_main.cpp
  change: edit tests/kencodingfiledialogtest_gui.cpp
  change: edit autotests/accessmanagertest.cpp
  change: edit autotests/globaltest.cpp
  change: edit src/widgets/kurlrequester.cpp
  change: edit src/core/mimetypejob.cpp
  change: edit autotests/mkpathjobtest.cpp
  change: edit src/widgets/kfileitemactions.cpp
  change: edit src/core/emptytrashjob.cpp
  change: edit src/kcms/kio/smbrodlg.cpp
  change: edit src/core/listjob.cpp
  change: edit 

Re: Review Request 125936: Update KProtocolManager after configuration change.

[Andreas Cord-Landwehr]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125936/
---

(Updated Nov. 4, 2015, 6:28 a.m.)


Review request for KDE Frameworks and David Faure.


Repository: kio


Description
---

Fixes missing update of Settings->Cache KCM that happens if opening
KCM, changing values (e.g., "No Cache"), closing Cache KCM, opening Cache
KCM again.

Reason is that storing and loading of UI values is performed
asymmetrically in two different KSharedConfig objects. Now force second
KSharedData to sync once settings are saved.


Diffs
-

  src/kcms/kio/cache.cpp 8f2f4e8 

Diff: https://git.reviewboard.kde.org/r/125936/diff/


Testing
---

manual testing


Thanks,

Andreas Cord-Landwehr

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

[Christoph Cullmann]

> On Nov. 3, 2015, 9:47 p.m., Albert Astals Cid wrote:
> > How does this work without modifying 
> > KProtocolInfoPrivate::KProtocolInfoPrivate?

You mean the JSON stuff? That was implemented in 
https://git.reviewboard.kde.org/r/125830/
For the http slave, that already works nicely, but we missed that "ExtraNames" 
as used by other slaves need i18n care.


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87966
---


On Nov. 1, 2015, 6:13 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Nov. 1, 2015, 6:13 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David 
> Faure, and Luigi Toscano.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

[Christoph Cullmann]

> On Oct. 30, 2015, 7:29 a.m., David Faure wrote:
> > src/ioslaves/trash/trash.json, line 6
> > 
> >
> > That doesn't look very English to me ;)
> > 
> > The original is:
> > 
> > ExtraNames=Original Path,Deletion Date
> > 
> > But this shows a problem: missing support for translating this field. 
> > We didn't realize there was a translatable field in these files. Please add 
> > support for translations, like was done for other json files (talk to e.g. 
> > Luigi Toscano).
> 
> Christoph Cullmann wrote:
> Hmm, then we have a problem: We can no longer convert the stuff and 
> remove the .protocol files, or?
> 
> Christoph Cullmann wrote:
> Ok, did read up a bit, ExtraNames seems to be the only translated thing 
> (at least if I read KProtocolInfo docs the right way).
> Can do the same trick as desktop2json does for that. Seems not that hard.
> But then we need CMake stuff for it, or? To convert on the fly to have 
> translations using the .protocol files like we have ATM in the .desktop files 
> for the plugin stuff.
> 
> David Faure wrote:
> I don't think you're looking in the right direction. AFAIK there is 
> support for translating json files directly in l10n (json -> po -> json) 
> these days. As I said, please ask Luigi or maybe Albert.
> 
> Christoph Cullmann wrote:
> Ok ;=)
> 
> Christoph Cullmann wrote:
> CC Luigi here, too.
> I looked again at what we have btw. in the other frameworks and I nowhere 
> really found any json -> po and back way, but that doesn't mean its not there 
> ;=)
> 
> David Faure wrote:
> I'm pretty sure this is all done in the l10n module, not in the other 
> frameworks.

Any idea who else to ping? With that patch at least the shipped IO slaves work 
perfect on Win/Lin without any hacks, I would really like to get that in. Some 
.protocol -> json -> ... translation stuff should be easy to do, but for 
translating the list inside JSON I am a bit lost ;=)


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87721
---


On Nov. 1, 2015, 6:13 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Nov. 1, 2015, 6:13 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David 
> Faure, and Luigi Toscano.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KPixmapCache in kdelibs4support uses QDateTime in mmap'ed struct

[Alex Merry]

On 2015-11-03 00:56, Michael Pyne wrote:

On Tue, November 3, 2015 00:40:58 Albert Astals Cid wrote:
Someone went a bit too far in the "port away from time_t to QDateTime" 
and

changed the timestamp member of the KPixmapCacheIndexHeader struct.

According to mpyne and thiago this is a big no-no.


The reason it's a big no-no is because KPixmapCacheIndexHeader is meant 
to be
held and used from mmap()'d shared memory, which generally requires the 
use of

plain old data (POD) types only, to avoid inadvertent constructor or
destructor calls once the memory is freed.

QDateTime will (and is) leak applications to crash so I'd +1 the
recommendation to change back to time_t (or at least some kind of 
integral
type), and the type is internal-only so there's no API concern. Just 
don't
forget to bump the defined KPIXMAPCACHE_VERSION so that old caches are 
flushed

;).


Also, in practice, I believe time_t is everywhere we care about - we 
just have to take a little care about what API calls we use.


Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel