date:20151116


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126078/
---

(Updated Nov. 16, 2015, 4:42 p.m.)


Review request for KDE Software on Mac OS X and KDE Frameworks.


Changes
---

This patch addresses most issues. I'm still getting the 1 timeout twice in 
the KIdleTime example, but otherwise it appears to behave as intended.

`simulateUserActivity` does *not* reset HIDIdleTime on recent OS X versions (if 
it ever did). I'm simulating that now via a software reset (idle time offset); 
please check if I'm resetting it properly.
Since that method uses a deprecated function, I've included a code snippet to 
show how to simulate user activity by rocking the mouse cursor back and forth 
over a tiny amount. That doesn't reset HIDIdleTime either, but might suffice 
for other applications of `simulateUserActivity` (if there are any such) .

TODO : cleanup


Repository: kidletime


Description
---

I noticed that the KIdleTime example doesn't work properly on OS X, and that 
the plugin for OS X still uses the deprecated Carbon-based algorithm that I 
already patched for KDE4.

This patch is a work-in-progress (hence the qDebugs) update to use IOKit, 
IORegistry and CoreServices to do idle-time calculation as it should be done, 
and allow simulated user activity through a "less deprecated" function.


Diffs (updated)
-

  src/plugins/osx/macpoller.cpp ad9c10f 
  src/plugins/osx/macpoller.h ef51ea5 
  src/plugins/osx/CMakeLists.txt e1b50b8 

Diff: https://git.reviewboard.kde.org/r/126078/diff/


Testing
---

On OS X 10.9 with Qt 5.5.1 and frameworks 5.16.0 .

The example now works: when I set a QTimer with interval==0, the expected wait 
for user input (`resumingFromIdle` signal) works. However, I am getting a 
`stopCatchingIdleEvents` signal which means the application waits forever, 
without ever getting to compare idle time to the list of timeouts.
I haven't been able to figure out where that signal comes from, nor why this 
doesn't happen on Linux.

Surely I'm missing something, but what?


Thanks,

René J.V. Bertin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125817: Add plugin system for Calendar events

2015-11-16 Thread Martin Klapetek

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125817/
---

(Updated Nov. 16, 2015, 4:55 p.m.)

Status
--

This change has been marked as submitted.

Review request for KDE Frameworks, Plasma and Daniel Vrátil.

Changes
---

Submitted with commit fe0384f0d4152e622b203385bd968657a3650d2c by Martin
Klapetek to branch master.

Repository: plasma-framework

Description
---

This adds a simple plugin interface that can be subclassed
and provide events integration with Plasma Calendar applet.

It's asynchronous and I've kept it deliberately simple.
For now the Calendar tells the plugins which date range
is being displayed, the plugins load the data and then
emit the dataReady() signal containing the events.

The events are stored in a multihash for quick access
by the Calendar's agenda part but also for overall
easy-to-use (eg. in teh model data()).

The event data is stored in EventData class, which has
a pretty self-explanatory members, except perhaps the
"isMinor" one. The intention with this is to support
namedays, where in some countries the calendars have
different name every day. This is just a minor holiday
and as such should not mark the calendar grid, otherwise
the whole grid would be in a different color.

Putting the interface here might raise the question of
depending on plasma-framework, but plugins provided by
KDE can go to plasma-workspace and other 3rd party ones
would just have to live with it. I don't think it will
be a problem but if it turns out it is, we can rethink
the placement.

Diffs
-

src/declarativeimports/calendar/CMakeLists.txt 40ead91
src/declarativeimports/calendar/calendarplugin.cpp bafe80c
src/declarativeimports/calendar/daysmodel.h a5bdac9
src/declarativeimports/calendar/daysmodel.cpp 2d059a8
src/declarativeimports/calendar/eventdatadecorator.h PRE-CREATION
src/declarativeimports/calendar/eventdatadecorator.cpp PRE-CREATION
src/declarativeimports/calendar/plasmacalendarintegration/CMakeLists.txt
PRE-CREATION

src/declarativeimports/calendar/plasmacalendarintegration/PlasmaCalendarIntegrationConfig.cmake.in
PRE-CREATION

src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.h
PRE-CREATION

src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.cpp
PRE-CREATION
src/declarativeimports/calendar/plasmacalendarintegration/eventdata_p.cpp
PRE-CREATION

src/declarativeimports/calendar/plasmacalendarintegration/plasmacalendarintegration_export.h
PRE-CREATION

Diff: https://git.reviewboard.kde.org/r/125817/diff/

Testing
---

I have a simple KHolidays based plugin written (patch should be up later today)
and patches in the Calendar applet.

Everything works as expected:
* the days are marked as containing an event
* the agenda part displays details of that event (name)

Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126084: Small KDeclarative cleanup

2015-11-16 Thread Sebastian Kügler


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126084/#review88420
---

Ship it!


Ship It!

- Sebastian Kügler


On Nov. 16, 2015, 11:53 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126084/
> ---
> 
> (Updated Nov. 16, 2015, 11:53 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> * Remove unread attribute.
> * Remove unneeded include.
> * Remove unneeded constructor.
> 
> 
> Diffs
> -
> 
>   src/kdeclarative/kdeclarative.cpp be795b2 
>   src/kdeclarative/private/kdeclarative_p.h 5bb0241 
>   src/kdeclarative/qmlobjectsharedengine.cpp 9a05e26 
> 
> Diff: https://git.reviewboard.kde.org/r/126084/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126086: kauth-policy-gen should not be an app bundle on OS X


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126086/
---

Review request for KDE Software on Mac OS X and KDE Frameworks.


Repository: kauth


Description
---

kauth-policy-gen should not be built as an app bundle on OS X.
This can be achieved by using `ecm_mark_nongui-executable` and apparently there 
are advantages and no contra-indications to doing that on all platforms.


Diffs
-

  src/CMakeLists.txt 1b6930d 

Diff: https://git.reviewboard.kde.org/r/126086/diff/


Testing
---

On OS X 10.9 with Qt 5.5.1 and Frameworks 5.16.0


Thanks,

René J.V. Bertin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125619: Refactor KNewPasswordDialog class

2015-11-16 Thread Heiko Tietze


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125619/#review88425
---

Ship it!


Ship It!

- Heiko Tietze


On Okt. 13, 2015, 1:33 nachm., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125619/
> ---
> 
> (Updated Okt. 13, 2015, 1:33 nachm.)
> 
> 
> Review request for KDE Frameworks, KDE Usability, Christoph Feck, and David 
> Faure.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Follow-up of the KNewPasswordWidget review.
> By introducing a KNewPasswordWidget in the .ui file, we can:
> 
> - remove the code that has been moved to KNewPasswordWidget
> - enable the KNewPasswordWidget additional features
> 
> The only feature that is currently not available is the ability to remove the 
> strength bar. Do we want to allow developers to show a KNewPasswordDialog 
> without a strenght bar?
> 
> 
> Diffs
> -
> 
>   src/knewpassworddialog.h 1ac7b2151f1e88681a15ce21465449cedb871f1e 
>   src/knewpassworddialog.cpp bd7459acf3c72bc6dc0711da6086213d5111d5c3 
>   src/knewpassworddialog.ui 55a1f62cf4ba6d6c87b2c47742ba3bcd531ebfe8 
> 
> Diff: https://git.reviewboard.kde.org/r/125619/diff/
> 
> 
> Testing
> ---
> 
> Trying to insert a password which is too short or too weak or empty, works as 
> expected.
> 
> 
> File Attachments
> 
> 
> knewpassworddialog1.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/13/62bf21f6-1dcf-46c3-8b1d-146500b5f629__knewpassworddialog1.png
> knewpassworddialog2.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/13/b2e2666f-ce19-4df3-b6ba-25c13fc370ae__knewpassworddialog2.png
> knewpassworddialog3.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/13/b9536088-0cc4-470b-a211-6db4ca79aa2f__knewpassworddialog3.png
> knewpassworddialog4.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/13/4f826716-9ed2-4ecb-8cbe-4fb50abf1086__knewpassworddialog4.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126078/#review88418
---


Here's a debugging trace after hitting a breakpoint set on the qFatal() 
statement I put into `MacPoller::stopCatchingIdleEvents` . One can see 
`KIdleTime::stopCatchingResumeEvent` being called in frame 1, but I cannot 
identify the calling frame. It doesn't appear to be 
`KIdleTimePrivate::_k_resumingFromIdle()` (a breakpoint in there isn't hit).


```C++
Process 88123 launched: 
'/Applications/MacPorts/KF5/examples/kidletime_example.app/Contents/MacOS/kidletime_example'
 (x86_64)
starting the idletime poll QTimer with interval 0 and m_minTimeout -1 ; start 
of catch
Your idle time is 595
Welcome!! Move your mouse or do something to start...
Great! Now stay idle for 5 seconds to get a nice message. From 10seconds on, 
you can move your mouse to get back here.
If you will stay idle for too long, I will simulate your activityafter 25 
seconds, and make everything start back
Appended timeout 5000 ; min.== -1
Appended timeout 1 ; min.== -1
Appended timeout 25000 ; min.== -1
stopping the idletime poll QTimer; end of catch, idle= 2
Process 88123 stopped
* thread #1: tid = 0x37451f, 0x000104fb4359 
KF5IdleTimeOsxPlugin.so`MacPoller::stopCatchingIdleEvents(this=) + 
297 at macpoller.cpp:372, queue = 'com.apple.main-thread', stop reason = 
breakpoint 1.1
frame #0: 0x000104fb4359 
KF5IdleTimeOsxPlugin.so`MacPoller::stopCatchingIdleEvents(this=) + 
297 at macpoller.cpp:372
   369  if (m_idleTimer) {
   370  qDebug() << "stopping the idletime poll QTimer; end of catch, 
idle=" << poll(false);
   371  // stopCatchingIdleEvents is called after each resumingFromIdle 
signal??!
-> 372  qFatal(__FUNCTION__);
   373  m_idleTimer->stop();
   374  }
   375  #endif
(lldb) bt
* thread #1: tid = 0x37451f, 0x000104fb4359 
KF5IdleTimeOsxPlugin.so`MacPoller::stopCatchingIdleEvents(this=) + 
297 at macpoller.cpp:372, queue = 'com.apple.main-thread', stop reason = 
breakpoint 1.1
  * frame #0: 0x000104fb4359 
KF5IdleTimeOsxPlugin.so`MacPoller::stopCatchingIdleEvents(this=) + 
297 at macpoller.cpp:372
frame #1: 0x0001b2c1 
libKF5IdleTime.5.dylib`KIdleTime::qt_static_metacall(QObject*, 
QMetaObject::Call, int, void**) [inlined] KIdleTime::stopCatchingResumeEvent() 
+ 43 at kidletime.cpp:113
frame #2: 0x0001b296 
libKF5IdleTime.5.dylib`KIdleTime::qt_static_metacall(_o=, 
_c=, _id=, _a=) + 582 at 
moc_kidletime.cpp:113
frame #3: 0x000101141252 
QtCore`QMetaObject::activate(sender=0x0001041161f0, 
signalOffset=, local_signal_index=, 
argv=) + 2978 at qobject.cpp:3713
frame #4: 0x000101141252 
QtCore`QMetaObject::activate(sender=0x0001041071c0, 
signalOffset=, local_signal_index=, 
argv=) + 2978 at qobject.cpp:3713
frame #5: 0x000101139740 QtCore`QObject::event(this=0x0001041071c0, 
e=) + 48 at qobject.cpp:1220
frame #6: 0x00010004854b 
QtWidgets`QApplicationPrivate::notify_helper(this=, 
receiver=0x0001041071c0, e=0x7fff5fbfd4e0) + 251 at 
qapplication.cpp:3716
frame #7: 0x00010004b904 
QtWidgets`QApplication::notify(this=, receiver=, 
e=) + 8212 at qapplication.cpp:3681
frame #8: 0x000101110703 
QtCore`QCoreApplication::notifyInternal(this=, 
receiver=, event=) + 115 at qcoreapplication.cpp:970
frame #9: 0x000101163d16 
QtCore`QTimerInfoList::activateTimers(this=0x000104059b10) + 1270 at 
qcoreapplication.h:224
frame #10: 0x000104ca5502 
libqcocoa.dylib`QCocoaEventDispatcherPrivate::activateTimersSourceCallback(info=0x000104059a90)
 + 18 at qcocoaeventdispatcher.mm:121
frame #11: 0x7fff90e4e5b1 
CoreFoundation`__CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
frame #12: 0x7fff90e3fc62 CoreFoundation`__CFRunLoopDoSources0 + 242
frame #13: 0x7fff90e3f3ef CoreFoundation`__CFRunLoopRun + 831
frame #14: 0x7fff90e3ee75 CoreFoundation`CFRunLoopRunSpecific + 309
frame #15: 0x7fff93440a0d HIToolbox`RunCurrentEventLoopInMode + 226
frame #16: 0x7fff934407b7 HIToolbox`ReceiveNextEventCommon + 479
frame #17: 0x7fff934405bc 
HIToolbox`_BlockUntilNextEventMatchingListInModeWithFilter + 65
frame #18: 0x7fff8ac9c24e AppKit`_DPSNextEvent + 1434
frame #19: 0x7fff8ac9b89b AppKit`-[NSApplication 
nextEventMatchingMask:untilDate:inMode:dequeue:] + 122
frame #20: 0x7fff8ac8f99c AppKit`-[NSApplication run] + 553
frame #21: 0x000104ca611d 
libqcocoa.dylib`QCocoaEventDispatcher::processEvents(this=0x000104056170, 
flags=) + 2189 at qcocoaeventdispatcher.mm:418
frame #22: 0x00010110de2d 
QtCore`QEventLoop::exec(QFlags) [inlined] 
QEventLoop::processEvents(QFlags) + 381 at 
qeventloop.cpp:128
frame #23: 0x00010110de14

Re: Review Request 125619: Refactor KNewPasswordDialog class

2015-11-16 Thread Elvis Angelaccio


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125619/#review88424
---


Ping?

- Elvis Angelaccio


On Oct. 13, 2015, 1:33 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125619/
> ---
> 
> (Updated Oct. 13, 2015, 1:33 p.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability, Christoph Feck, and David 
> Faure.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Follow-up of the KNewPasswordWidget review.
> By introducing a KNewPasswordWidget in the .ui file, we can:
> 
> - remove the code that has been moved to KNewPasswordWidget
> - enable the KNewPasswordWidget additional features
> 
> The only feature that is currently not available is the ability to remove the 
> strength bar. Do we want to allow developers to show a KNewPasswordDialog 
> without a strenght bar?
> 
> 
> Diffs
> -
> 
>   src/knewpassworddialog.h 1ac7b2151f1e88681a15ce21465449cedb871f1e 
>   src/knewpassworddialog.cpp bd7459acf3c72bc6dc0711da6086213d5111d5c3 
>   src/knewpassworddialog.ui 55a1f62cf4ba6d6c87b2c47742ba3bcd531ebfe8 
> 
> Diff: https://git.reviewboard.kde.org/r/125619/diff/
> 
> 
> Testing
> ---
> 
> Trying to insert a password which is too short or too weak or empty, works as 
> expected.
> 
> 
> File Attachments
> 
> 
> knewpassworddialog1.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/13/62bf21f6-1dcf-46c3-8b1d-146500b5f629__knewpassworddialog1.png
> knewpassworddialog2.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/13/b2e2666f-ce19-4df3-b6ba-25c13fc370ae__knewpassworddialog2.png
> knewpassworddialog3.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/13/b9536088-0cc4-470b-a211-6db4ca79aa2f__knewpassworddialog3.png
> knewpassworddialog4.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/13/4f826716-9ed2-4ecb-8cbe-4fb50abf1086__knewpassworddialog4.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126087: Move the i18n context from KDeclarative


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126087/
---

Review request for KDE Frameworks, Chusslove Illich and Marco Martin.


Repository: ki18n


Description
---

The only way to use `i18n*()` so far in QML is by depending on all 
KDeclarative. This patch moves the necessary bits there so it can be adopted by 
an application or framework just by offering the needed bits within KI18n.
This is done by offering an object with methods that map to the `i18n*()` C++ 
counter-parts.


Diffs
-

  src/CMakeLists.txt 818595e 
  src/klocalizedcontext.h PRE-CREATION 
  src/klocalizedcontext.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126087/diff/


Testing
---

Ported KDeclarative, everything still seems to work.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126088: Port KDeclarative to use KI18n directly, rather than adding its own bindings


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126088/
---

Review request for KDE Frameworks.


Repository: kdeclarative


Description
---

`i18n*()` bindings were moved upstream to ki18n so they can be used by a wider 
audience.


Diffs
-

  src/kdeclarative/CMakeLists.txt ce12546 
  src/kdeclarative/kdeclarative.cpp 820250d 
  src/kdeclarative/private/kdeclarative_p.h 0e48ca3 
  src/kdeclarative/private/rootcontext.cpp d88b566 
  src/kdeclarative/private/rootcontext_p.h 94df09f 

Diff: https://git.reviewboard.kde.org/r/126088/diff/


Testing
---

Tests still pass, apps still work, plasma still works as well.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126086: kauth-policy-gen should not be an app bundle on OS X


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126086/#review88426
---



src/CMakeLists.txt (line 1)


Move it in the upper CMakeLists.txt file together with 
`include(ECMGenerateHeaders)`.


Otherwise looks good to me. +1

- Aleix Pol Gonzalez


On Nov. 16, 2015, 1:47 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126086/
> ---
> 
> (Updated Nov. 16, 2015, 1:47 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDE Frameworks.
> 
> 
> Repository: kauth
> 
> 
> Description
> ---
> 
> kauth-policy-gen should not be built as an app bundle on OS X.
> This can be achieved by using `ecm_mark_nongui-executable` and apparently 
> there are advantages and no contra-indications to doing that on all platforms.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 1b6930d 
> 
> Diff: https://git.reviewboard.kde.org/r/126086/diff/
> 
> 
> Testing
> ---
> 
> On OS X 10.9 with Qt 5.5.1 and Frameworks 5.16.0
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126085: Fix filename suggestion changing to something random when changing save-as mimetype.

2015-11-16 Thread David Edmundson


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126085/
---

Review request for KDE Frameworks.


Repository: kio


Description
---

When updating save-as mimetype update suggested default name before updating 
show list

Otherwise KDirOperator will signal that we have gone from having an
existing item selected to having no item selected and will then select
the first file that matches the new mime filter criteria.


Diffs
-

  src/filewidgets/kfilewidget.cpp 918a49941ce1610d1b2bb7764b07fc4f81238313 

Diff: https://git.reviewboard.kde.org/r/126085/diff/


Testing
---

Assume directory with file a.png

open b.jpg in gwenview
-> save as
select "png" as the type, after patch filename still says b.png (as opposed to 
jump to a.png)

---

Tested above in a directory where b.png already existed

---

Tested selecting another file before changing file type


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

On Monday November 16 2015 12:29:49 René J.V. Bertin wrote:

> If that's the intended behaviour, why does the KIdleTime example work on 
> Linux, without "restarting" `catchNextResumeEvent`??

Sorry for the rapid fire of growing messages - that comes with asking questions 
through RRs ...

I realised stopCatchingIdleEvents() shouldn't stop the timer, only unset the 
state variable that indicates resume signals are desired.

Now, I have to figure out an elegant way to stop sending identical 
timeOutReached signals (until the next timeout level is reached)!

R.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

2015-11-16 Thread Boudhayan Gupta


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126091/
---

Review request for KDE Frameworks, Plasma and David Edmundson.


Repository: khotkeys


Description
---

After moving KSnapshot to Extragear I've modified it to install its own 
khotkeys file (which it does correctly). Spectacle already installs its own 
KHotkeys file, so there's no reason anymore for KHotkeys to include its own 
PrintScreen hotkey file.

I'll push out a special release of KSnapshot for distributions to use once the 
Plasma 5.5 version of KHotkeys is pushed out, so printscreen functionality 
won't be broken on the desktop (assuming, that is, distros push out the updates 
together).


Diffs
-

  data/CMakeLists.txt f3bcb57 
  data/printscreen.khotkeys e583311 

Diff: https://git.reviewboard.kde.org/r/126091/diff/


Testing
---

Doesn't install the printscreen.khotkeys file anymore


Thanks,

Boudhayan Gupta

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 142 - Failure!


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/142/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 16 Nov 2015 16:55:44 +
Build duration: 1 min 42 sec

CHANGE SET
Revision fe0384f0d4152e622b203385bd968657a3650d2c by Martin Klapetek: 
([calendar] Add plugin system for Calendar events)
  change: add src/declarativeimports/calendar/eventdatadecorator.cpp
  change: add 
src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.cpp
  change: add 
src/declarativeimports/calendar/plasmacalendarintegration/CMakeLists.txt
  change: add src/declarativeimports/calendar/eventdatadecorator.h
  change: edit src/declarativeimports/calendar/daysmodel.h
  change: add 
src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.h
  change: add 
src/declarativeimports/calendar/plasmacalendarintegration/plasmacalendarintegration_export.h
  change: edit src/declarativeimports/calendar/CMakeLists.txt
  change: add 
src/declarativeimports/calendar/plasmacalendarintegration/eventdata_p.cpp
  change: edit src/declarativeimports/calendar/daysmodel.cpp
  change: edit src/declarativeimports/calendar/calendarplugin.cpp
  change: add 
src/declarativeimports/calendar/plasmacalendarintegration/PlasmaCalendarIntegrationConfig.cmake.in
Revision d0d0a27bac0ff9ee84320dff1ff8b42d9696dccf by Martin Klapetek: 
([calendar] Move the plugins handling to a separate class)
  change: edit src/declarativeimports/calendar/qml/MonthView.qml
  change: add src/declarativeimports/calendar/eventpluginsmanager.h
  change: edit src/declarativeimports/calendar/calendarplugin.cpp
  change: edit src/declarativeimports/calendar/daysmodel.h
  change: edit src/declarativeimports/calendar/CMakeLists.txt
  change: edit src/declarativeimports/calendar/daysmodel.cpp
  change: add src/declarativeimports/calendar/eventpluginsmanager.cpp
Revision 8349a786af99a7adf5add84d911982bc579f3e78 by Martin Klapetek: (Allow 
adding config categories dynamically)
  change: edit src/plasmaquick/configmodel.h
  change: edit src/plasmaquick/configmodel.cpp
Revision b65195ee65b0073c28fef5caa9cf07030ba5683e by Martin Klapetek: 
([calendar] qmlRegisterUncreatableType needs a bit more arguments)
  change: edit src/declarativeimports/calendar/calendarplugin.cpp
Revision f9d7fc87d5646b6b8503cbf759f7c7ed086b157e by Martin Klapetek: 
([calendar] Fix binding loops)
  change: edit src/declarativeimports/calendar/qml/DayDelegate.qml
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 142 - Failure!


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/142/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 16 Nov 2015 16:55:44 +
Build duration: 3 min 32 sec

CHANGE SET
Revision fe0384f0d4152e622b203385bd968657a3650d2c by Martin Klapetek: 
([calendar] Add plugin system for Calendar events)
  change: add 
src/declarativeimports/calendar/plasmacalendarintegration/plasmacalendarintegration_export.h
  change: edit src/declarativeimports/calendar/daysmodel.cpp
  change: add 
src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.cpp
  change: edit src/declarativeimports/calendar/daysmodel.h
  change: add 
src/declarativeimports/calendar/plasmacalendarintegration/PlasmaCalendarIntegrationConfig.cmake.in
  change: edit src/declarativeimports/calendar/CMakeLists.txt
  change: add 
src/declarativeimports/calendar/plasmacalendarintegration/eventdata_p.cpp
  change: add 
src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.h
  change: edit src/declarativeimports/calendar/calendarplugin.cpp
  change: add src/declarativeimports/calendar/eventdatadecorator.h
  change: add 
src/declarativeimports/calendar/plasmacalendarintegration/CMakeLists.txt
  change: add src/declarativeimports/calendar/eventdatadecorator.cpp
Revision d0d0a27bac0ff9ee84320dff1ff8b42d9696dccf by Martin Klapetek: 
([calendar] Move the plugins handling to a separate class)
  change: add src/declarativeimports/calendar/eventpluginsmanager.cpp
  change: edit src/declarativeimports/calendar/CMakeLists.txt
  change: edit src/declarativeimports/calendar/qml/MonthView.qml
  change: edit src/declarativeimports/calendar/daysmodel.h
  change: edit src/declarativeimports/calendar/daysmodel.cpp
  change: add src/declarativeimports/calendar/eventpluginsmanager.h
  change: edit src/declarativeimports/calendar/calendarplugin.cpp
Revision 8349a786af99a7adf5add84d911982bc579f3e78 by Martin Klapetek: (Allow 
adding config categories dynamically)
  change: edit src/plasmaquick/configmodel.cpp
  change: edit src/plasmaquick/configmodel.h
Revision b65195ee65b0073c28fef5caa9cf07030ba5683e by Martin Klapetek: 
([calendar] qmlRegisterUncreatableType needs a bit more arguments)
  change: edit src/declarativeimports/calendar/calendarplugin.cpp
Revision f9d7fc87d5646b6b8503cbf759f7c7ed086b157e by Martin Klapetek: 
([calendar] Fix binding loops)
  change: edit src/declarativeimports/calendar/qml/DayDelegate.qml
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

2015-11-16 Thread Hrvoje Senjan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126091/#review88438
---


>assuming, that is, distros push out the updates together

don't assume this ;-) at least send a mail to kde-distro-packagers about the 
sideeffects if those 3 are pushed asynchronously

- Hrvoje Senjan


On Nov. 16, 2015, 6:06 p.m., Boudhayan Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126091/
> ---
> 
> (Updated Nov. 16, 2015, 6:06 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Edmundson.
> 
> 
> Repository: khotkeys
> 
> 
> Description
> ---
> 
> After moving KSnapshot to Extragear I've modified it to install its own 
> khotkeys file (which it does correctly). Spectacle already installs its own 
> KHotkeys file, so there's no reason anymore for KHotkeys to include its own 
> PrintScreen hotkey file.
> 
> I'll push out a special release of KSnapshot for distributions to use once 
> the Plasma 5.5 version of KHotkeys is pushed out, so printscreen 
> functionality won't be broken on the desktop (assuming, that is, distros push 
> out the updates together).
> 
> 
> Diffs
> -
> 
>   data/CMakeLists.txt f3bcb57 
>   data/printscreen.khotkeys e583311 
> 
> Diff: https://git.reviewboard.kde.org/r/126091/diff/
> 
> 
> Testing
> ---
> 
> Doesn't install the printscreen.khotkeys file anymore
> 
> 
> Thanks,
> 
> Boudhayan Gupta
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 143 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/143/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 16 Nov 2015 17:23:19 +
Build duration: 3 min 5 sec

CHANGE SET
Revision c507c744ca0fe44689c63f06548531a5a2c1d425 by Martin Klapetek: 
([calendar] Fix build)
  change: edit src/declarativeimports/calendar/eventpluginsmanager.h


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 63/104 (61%)CLASSES 63/104 (61%)LINE 3925/10060 
(39%)CONDITIONAL 1923/3046 (63%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 550/565 
(97%)CONDITIONAL 344/618 (56%)
src.declarativeimports.core
FILES 7/20 (35%)CLASSES 7/20 (35%)LINE 356/2010 
(18%)CONDITIONAL 148/228 (65%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1591/3645 
(44%)CONDITIONAL 776/1192 (65%)
src.plasma.private
FILES 18/26 (69%)CLASSES 18/26 (69%)LINE 945/1746 
(54%)CONDITIONAL 395/600 (66%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/194 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 4/11 (36%)CLASSES 4/11 (36%)LINE 483/1787 
(27%)CONDITIONAL 260/408 (64%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 143 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/143/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 16 Nov 2015 17:23:19 +
Build duration: 3 min 5 sec

CHANGE SET
Revision c507c744ca0fe44689c63f06548531a5a2c1d425 by Martin Klapetek: 
([calendar] Fix build)
  change: edit src/declarativeimports/calendar/eventpluginsmanager.h


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 63/104 (61%)CLASSES 63/104 (61%)LINE 3925/10060 
(39%)CONDITIONAL 1923/3046 (63%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 550/565 
(97%)CONDITIONAL 344/618 (56%)
src.declarativeimports.core
FILES 7/20 (35%)CLASSES 7/20 (35%)LINE 356/2010 
(18%)CONDITIONAL 148/228 (65%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1591/3645 
(44%)CONDITIONAL 776/1192 (65%)
src.plasma.private
FILES 18/26 (69%)CLASSES 18/26 (69%)LINE 945/1746 
(54%)CONDITIONAL 395/600 (66%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/194 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 4/11 (36%)CLASSES 4/11 (36%)LINE 483/1787 
(27%)CONDITIONAL 260/408 (64%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

2015-11-16 Thread Boudhayan Gupta



> On Nov. 16, 2015, 10:46 p.m., Hrvoje Senjan wrote:
> > >assuming, that is, distros push out the updates together
> > 
> > don't assume this ;-) at least send a mail to kde-distro-packagers about 
> > the sideeffects if those 3 are pushed asynchronously

'course, I'll post there as well as add a big fat notice to the 
kde-apps-announce posting that announces this special release of KSnapshot.

So ship it?


- Boudhayan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126091/#review88438
---


On Nov. 16, 2015, 10:36 p.m., Boudhayan Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126091/
> ---
> 
> (Updated Nov. 16, 2015, 10:36 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Edmundson.
> 
> 
> Repository: khotkeys
> 
> 
> Description
> ---
> 
> After moving KSnapshot to Extragear I've modified it to install its own 
> khotkeys file (which it does correctly). Spectacle already installs its own 
> KHotkeys file, so there's no reason anymore for KHotkeys to include its own 
> PrintScreen hotkey file.
> 
> I'll push out a special release of KSnapshot for distributions to use once 
> the Plasma 5.5 version of KHotkeys is pushed out, so printscreen 
> functionality won't be broken on the desktop (assuming, that is, distros push 
> out the updates together).
> 
> 
> Diffs
> -
> 
>   data/CMakeLists.txt f3bcb57 
>   data/printscreen.khotkeys e583311 
> 
> Diff: https://git.reviewboard.kde.org/r/126091/diff/
> 
> 
> Testing
> ---
> 
> Doesn't install the printscreen.khotkeys file anymore
> 
> 
> Thanks,
> 
> Boudhayan Gupta
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 143 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/143/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 16 Nov 2015 17:23:19 +
Build duration: 2 min 33 sec

CHANGE SET
Revision c507c744ca0fe44689c63f06548531a5a2c1d425 by Martin Klapetek: 
([calendar] Fix build)
  change: edit src/declarativeimports/calendar/eventpluginsmanager.h


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 60/100 (60%)CLASSES 60/100 (60%)LINE 3488/9601 
(36%)CONDITIONAL 1637/2642 (62%)

By packages
  
autotests
FILES 18/18 (100%)CLASSES 18/18 (100%)LINE 503/518 
(97%)CONDITIONAL 328/586 (56%)
src.declarativeimports.core
FILES 7/20 (35%)CLASSES 7/20 (35%)LINE 268/1793 
(15%)CONDITIONAL 66/112 (59%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1584/3645 
(43%)CONDITIONAL 769/1186 (65%)
src.plasma.private
FILES 17/24 (71%)CLASSES 17/24 (71%)LINE 898/1675 
(54%)CONDITIONAL 374/570 (66%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/194 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 4/11 (36%)CLASSES 4/11 (36%)LINE 235/1663 
(14%)CONDITIONAL 100/188 (53%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 143 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/143/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 16 Nov 2015 17:23:19 +
Build duration: 2 min 33 sec

CHANGE SET
Revision c507c744ca0fe44689c63f06548531a5a2c1d425 by Martin Klapetek: 
([calendar] Fix build)
  change: edit src/declarativeimports/calendar/eventpluginsmanager.h


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 60/100 (60%)CLASSES 60/100 (60%)LINE 3488/9601 
(36%)CONDITIONAL 1637/2642 (62%)

By packages
  
autotests
FILES 18/18 (100%)CLASSES 18/18 (100%)LINE 503/518 
(97%)CONDITIONAL 328/586 (56%)
src.declarativeimports.core
FILES 7/20 (35%)CLASSES 7/20 (35%)LINE 268/1793 
(15%)CONDITIONAL 66/112 (59%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1584/3645 
(43%)CONDITIONAL 769/1186 (65%)
src.plasma.private
FILES 17/24 (71%)CLASSES 17/24 (71%)LINE 898/1675 
(54%)CONDITIONAL 374/570 (66%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/194 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 4/11 (36%)CLASSES 4/11 (36%)LINE 235/1663 
(14%)CONDITIONAL 100/188 (53%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126078/
---

(Updated Nov. 16, 2015, 11:03 p.m.)


Review request for KDE Software on Mac OS X and KDE Frameworks.


Changes
---

Code cleaned up.

In reaction to my message on the kde-frameworks ML ("KIdleTime : provide a 
settable resolution for the polling backends?"), I've added a prototype 
implementation of a mechanism to set the poller timer resolution. That 
resolution is directly relevant for my implementation, which is why I didn't 
present it in a separate RR.


Repository: kidletime


Description
---

I noticed that the KIdleTime example doesn't work properly on OS X, and that 
the plugin for OS X still uses the deprecated Carbon-based algorithm that I 
already patched for KDE4.

This patch is a work-in-progress (hence the qDebugs) update to use IOKit, 
IORegistry and CoreServices to do idle-time calculation as it should be done, 
and allow simulated user activity through a "less deprecated" function.


Diffs (updated)
-

  src/plugins/osx/CMakeLists.txt e1b50b8 
  src/plugins/osx/macpoller.h ef51ea5 
  src/plugins/osx/macpoller.cpp ad9c10f 

Diff: https://git.reviewboard.kde.org/r/126078/diff/


Testing
---

On OS X 10.9 with Qt 5.5.1 and frameworks 5.16.0 .

The example now works: when I set a QTimer with interval==0, the expected wait 
for user input (`resumingFromIdle` signal) works. However, I am getting a 
`stopCatchingIdleEvents` signal which means the application waits forever, 
without ever getting to compare idle time to the list of timeouts.
I haven't been able to figure out where that signal comes from, nor why this 
doesn't happen on Linux.

Surely I'm missing something, but what?


Thanks,

René J.V. Bertin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

KIdleTime : provide a settable resolution for the polling backends?

Hi,

Working on modernising the OS X plugin for KIdleTime, I realised that there is 
no mechanism foreseen to set the frequency at which the current system idle 
time should be sampled on those platforms that need to use a polling approach 
(OS X, MS Windows and apparently also XScreenSaver).

The frequency with which idle time is polled (sampled) determines the delay 
with which the resumingFromIdle signal can be sent, but also the precision of 
the timeoutReached signals.

At the moment I'm using a QTimer interval of 0 to poll idle time, meaning the 
timer fires and idletime is fired about as fast as possible when there are no 
events to process. That is fine for a system that wants to react as fast as 
possible to the end of an idle period, but probably overkill in many other 
situations. It strikes me that the required resolution is something that only 
the calling code can know, though there are probably several values that are 
reasonable defaults (10x per second seems a bit much, 4x maybe just too low).

Thoughts?

R.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126078/
---

(Updated Nov. 16, 2015, 11:15 p.m.)


Review request for KDE Software on Mac OS X and KDE Frameworks.


Repository: kidletime


Description
---

I noticed that the KIdleTime example doesn't work properly on OS X, and that 
the plugin for OS X still uses the deprecated Carbon-based algorithm that I 
already patched for KDE4.

This patch is a work-in-progress (hence the qDebugs) update to use IOKit, 
IORegistry and CoreServices to do idle-time calculation as it should be done, 
and allow simulated user activity through a "less deprecated" function.


Diffs (updated)
-

  src/plugins/osx/CMakeLists.txt e1b50b8 
  src/plugins/osx/macpoller.h ef51ea5 
  src/plugins/osx/macpoller.cpp ad9c10f 

Diff: https://git.reviewboard.kde.org/r/126078/diff/


Testing
---

On OS X 10.9 with Qt 5.5.1 and frameworks 5.16.0 .

The example now works: when I set a QTimer with interval==0, the expected wait 
for user input (`resumingFromIdle` signal) works. However, I am getting a 
`stopCatchingIdleEvents` signal which means the application waits forever, 
without ever getting to compare idle time to the list of timeouts.
I haven't been able to figure out where that signal comes from, nor why this 
doesn't happen on Linux.

Surely I'm missing something, but what?


Thanks,

René J.V. Bertin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126086: kauth-policy-gen should not be an app bundle on OS X


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126086/
---

(Updated Nov. 16, 2015, 10:15 p.m.)


Review request for KDE Software on Mac OS X and KDE Frameworks.


Repository: kauth


Description
---

kauth-policy-gen should not be built as an app bundle on OS X.
This can be achieved by using `ecm_mark_nongui-executable` and apparently there 
are advantages and no contra-indications to doing that on all platforms.


Diffs (updated)
-

  CMakeLists.txt dd6aac1 
  src/CMakeLists.txt 1b6930d 

Diff: https://git.reviewboard.kde.org/r/126086/diff/


Testing
---

On OS X 10.9 with Qt 5.5.1 and Frameworks 5.16.0


Thanks,

René J.V. Bertin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KIdleTime : provide a settable resolution for the polling backends?

Aleix Pol wrote:

> I guess it's because it shouldn't poll necessarily, but get a
> notification whenever the OS considers appropriate. Polling is
> considered a bad practice in general.

I'd agree, but not all OSes provide other mechanisms, in which case polling is 
the only remaining option.
Reason the more to allow the polling load to be tuned to requirements if you 
ask 
me.

R.

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KIdleTime : provide a settable resolution for the polling backends?

2015-11-16 Thread Aleix Pol

On Mon, Nov 16, 2015 at 10:31 PM, René J.V.  wrote:
> Hi,
>
> Working on modernising the OS X plugin for KIdleTime, I realised that there 
> is no mechanism foreseen to set the frequency at which the current system 
> idle time should be sampled on those platforms that need to use a polling 
> approach (OS X, MS Windows and apparently also XScreenSaver).
>
> The frequency with which idle time is polled (sampled) determines the delay 
> with which the resumingFromIdle signal can be sent, but also the precision of 
> the timeoutReached signals.
>
> At the moment I'm using a QTimer interval of 0 to poll idle time, meaning the 
> timer fires and idletime is fired about as fast as possible when there are no 
> events to process. That is fine for a system that wants to react as fast as 
> possible to the end of an idle period, but probably overkill in many other 
> situations. It strikes me that the required resolution is something that only 
> the calling code can know, though there are probably several values that are 
> reasonable defaults (10x per second seems a bit much, 4x maybe just too low).
>
> Thoughts?
>
> R.

I guess it's because it shouldn't poll necessarily, but get a
notification whenever the OS considers appropriate. Polling is
considered a bad practice in general.

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126084: Small KDeclarative cleanup


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126084/
---

Review request for KDE Frameworks.


Repository: kdeclarative


Description
---

* Remove unread attribute.
* Remove unneeded include.
* Remove unneeded constructor.


Diffs
-

  src/kdeclarative/kdeclarative.cpp be795b2 
  src/kdeclarative/private/kdeclarative_p.h 5bb0241 
  src/kdeclarative/qmlobjectsharedengine.cpp 9a05e26 

Diff: https://git.reviewboard.kde.org/r/126084/diff/


Testing
---

Builds, tests pass.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126069: [OS X] better integration of the cross-platform wallet runtime


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126069/
---

(Updated Nov. 16, 2015, 12:59 p.m.)


Review request for KDE Software on Mac OS X and KDE Frameworks.


Changes
---

Made the CMake file changes platform non-specific.
Including `ECMMarkNonGuiExecutable` one level up should make 
`ecm_mark_nongui_executable` available downstream, right?


Repository: kwallet


Description
---

Pending an overdue update to my OS X Keychain backend, this patch provides 
better integration of the runtime:

- kwallet-query and kwalletd5 are built as regular executables, not app 
bundles, making them easier to find via the shell and KService
- kwalletd5 is modified to run as an agent, meaning it doesn't show up in the 
Dock or App Switcher.


Diffs (updated)
-

  src/runtime/CMakeLists.txt f3f2798 
  src/runtime/kwallet-query/src/CMakeLists.txt 9ab9d9d 
  src/runtime/kwalletd/CMakeLists.txt ba9e7ba 
  src/runtime/kwalletd/main.cpp dd959b6 

Diff: https://git.reviewboard.kde.org/r/126069/diff/


Testing
---

On OS X 10.9 with Qt 5.5.0, in the 5.15.0 frameworks release version.


Thanks,

René J.V. Bertin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [OS X] should kauth-policy-gen be an app bundle?