date:20160628

Re: Review Request 127833: KWallet: More Coverity fixes, and include Qt headers for endianness check.

2016-06-28 Thread Michael Pyne



> On May 23, 2016, 11:20 a.m., David Faure wrote:
> > Please note that:
> > * the Q_BYTE_ORDER change was reverted, since it made the wallet storage 
> > incompatible with previous releases. This needs further analysis in order 
> > to improve the code while retaining compat.
> > * kwallet is definitely usable with a home install, I'm doing that right 
> > now. I do have the distro KF5 packages installed though, so maybe the 
> > polkit stuff got installed at the right place into the system as well. 
> > Anyhow it means it should be fixable with a one-time copy operation as root.
> 
> Michael Pyne wrote:
> That reminds me, I made an autotest for the Blowfish cipher that would 
> hopefully catch such errors in the future. I've committed the autotests now 
> (they pass, hopefully they don't break CI!).
> 
> With that autotest I think that Allen Winter's last Q_BYTE_ORDER change 
> had actually been correct (to enable the relevant code sections when 
> Q_BYTE_ORDER == Q_LITTLE_ENDIAN), but his first commit (to #include 
> qglobal.h) would have generated incorrect Wallets which would then not match 
> with KWallet when it was fixed.
> 
> Either way someone's systems are being broken here, because the current 
> code unilaterally enables bit-shuffling always no matter if the CPU is 
> big-endian or little-endian. But I don't have a big-endian machine to test on 
> to make sure a fix would (or would not) work.
> 
> Pino Toscano wrote:
> This indeed shows that the current situation (kwallet 5.23) is broken on 
> big endian platforms; looking at the failures we got when it was uploaded to 
> Debian few days ago, 
> https://buildd.debian.org/status/logs.php?pkg=kwallet-kf5=5.23.0-1=sid,
>  we've got failures (related to this) on mips, powerpc, and hppa (s390x is 
> not built yet, but it will fail there too) -- all of them are big endian.
> 
> I can help in testing patches fixing the `blowfishtest` unit test on 
> those platforms.
> 
> > the current code unilaterally enables bit-shuffling always no matter if 
> the CPU is big-endian or little-endian.
> 
> A simple fix could then be use QtGlobal again, but invert the byte order 
> conditions like:
> -#if Q_BYTE_ORDER == Q_BIG_ENDIAN
> +#if Q_BYTE_ORDER == Q_LITTLE_ENDIAN
> this would preserve the compatibility with little endian platforms, 
> although breaking wallets on big endian machines.

If you can test a patch, I'd recommend Allen Winter's last fix attempt before 
the whole thing was reverted, at commit 
87e774825b779ba846315a8b2ffe6479dd9f9814. This should implement your suggestion 
already, it was only reverted since there continued to be complaints of 
brokenness.

It is my feeling that his patch was correct, and that the problems noted were 
by users who had recreated a wallet during the 34-hour window where the cipher 
was broken for all (due to commit b3a95ba0540e01a9bb10db53fc449cc49ce9a9e8 
activating Q_BYTE_ORDER checks in reverse). If wallets generated in this window 
are broken then they would always be treated as corrupt by correct code. But 
note that the current autotest only checks the cipher for compliance against 
Blowfish's own test vectors, not whether wallets generated using it can be 
reopened later.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127833/#review95717
---


On May 8, 2016, 12:10 a.m., Michael Pyne wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127833/
> ---
> 
> (Updated May 8, 2016, 12:10 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> This is a collection of minor fixes:
> 
> An uninit variable usage was noted by Coverity (CID 1289177) for a CBC crypto 
> function, though it only happens for encryption lengths that would not be hit 
> in practice. I troubleshot this in December but forgot to make a RR, but IIRC 
> the lengths that would cause problems are 7 bytes or less -- but it's still 
> better to fix.
> 
> The other Coverity fix is to avoid a needless dup(2) of an opened socket 
> since it's immediately turned into a FILE* object anyways (CID 1353007). This 
> avoids a minor resource leak of a file descriptor.
> 
> Finally, some of the ciphers use Qt checks for endianness, and need to 
> actually include the header that does this instead of relying on other parts 
> of the code incidentally pulling in the needed #includes.
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/backend/cbc.cc 4c13466 
>   src/runtime/kwalletd/main.cpp 90c60d8 
> 
> Diff: https://git.reviewboard.kde.org/r/127833/diff/
> 
> 
> Testing
> ---
> 
> Everything still

Re: Review Request 128250: Silence CMake policy CMP0063 warning also for tests

2016-06-28 Thread Heiko Becker


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128250/
---

(Updated June 28, 2016, 10:45 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and KDEPIM.


Changes
---

Submitted with commit 1c1b2130235f0019d31f490bb95549a91d3ef342 by Heiko Becker 
to branch master.


Repository: kpeople


Description
---

Despite NO_POLICY_SCOPE being added to the inclusion of
KDEFrameworkCompilerSettings warnings still appeared because
ECMAddTests was included before it.


Diffs
-

  CMakeLists.txt e7554a9d6b2292fe27eadd86ea7a62d589db185e 

Diff: https://git.reviewboard.kde.org/r/128250/diff/


Testing
---

Warnings disappeared, still builds.


Thanks,

Heiko Becker

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128252: Silence CMake policy CMP0063 warning

2016-06-28 Thread Heiko Becker


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128252/
---

(Updated June 28, 2016, 10:43 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Ivan Čukić.


Changes
---

Submitted with commit 62ce194fe00ce0a7c04027db78a91a6dab72a11c by Heiko Becker 
to branch master.


Repository: kactivities-stats


Description
---

...by adding the NO_POLICY_SCOPE flag as recommended by ECM's
documentation.


Diffs
-

  CMakeLists.txt b11cb46a753f9abbce48aa290fe105e4184842f5 

Diff: https://git.reviewboard.kde.org/r/128252/diff/


Testing
---

Warning disappears, it still builds.


Thanks,

Heiko Becker

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128251: Silence CMake policy CMP0063 warning

2016-06-28 Thread Heiko Becker


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128251/
---

(Updated June 29, 2016, 12:42 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Ivan Čukić.


Changes
---

Submitted with commit 93fd546cb9f6455bc47bdc11df12dbab67284c0f by Heiko Becker 
to branch master.


Repository: kactivities


Description
---

...by adding the NO_POLICY_SCOPE flag as recommended by ECM's
documentation.


Diffs
-

  CMakeLists.txt 4b0d924aaa064e914e443155b11e29b0fd11fd5c 

Diff: https://git.reviewboard.kde.org/r/128251/diff/


Testing
---

Warning disappears, it still builds.


Thanks,

Heiko Becker

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128312: Fix notify by taskbar

2016-06-28 Thread Martin Tobias Holmedahl Sandsmark


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128312/
---

Review request for KDE Frameworks and Martin Klapetek.


Repository: knotifications


Description
---

For whatever reasons, the current implementation of notify by taskbar doesn't 
work locally. It also isn't implemented at all on e. g. OS X.

QApplication has a proper replacement that works on all platforms, so this 
simply switches to using that, and re-enables the notifybytaskbar on OS X.


Diffs
-

  src/knotificationmanager.cpp 6f790b5 
  src/notifybytaskbar.cpp 036d20a 

Diff: https://git.reviewboard.kde.org/r/128312/diff/


Testing
---

Noticed notifications in the taskbar where there earlier were none.


Thanks,

Martin Tobias Holmedahl Sandsmark

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128309: add helper function to create "Details" button

2016-06-28 Thread Kai Uwe Broulik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128309/#review96935
---



Can we perhaps make this API a bit more high-level by adding a dedicated 
DetailsButton class? You're basically just creating a button with a label 
"Details >>" but the functionality for changing it to << on expanding and what 
not is still up to the user?


src/kmessagebox.cpp (line 1159)


While at it, avoid word-puzzle


- Kai Uwe Broulik


On Juni 28, 2016, 6:16 nachm., Rolf Eike Beer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128309/
> ---
> 
> (Updated Juni 28, 2016, 6:16 nachm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Otherwise an application that wishes to use the details member e.g. of 
> createKMessageBox() has to duplicate the setup code, including the 
> translation setup.
> 
> 
> Diffs
> -
> 
>   src/kmessagebox.h 3826a46 
>   src/kmessagebox.cpp 194ffae 
> 
> Diff: https://git.reviewboard.kde.org/r/128309/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rolf Eike Beer
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128307: [KDeclarative] [KCMShell Proxy] Use KToolInvocation::kdeinitExec instead of QProcess::startDetached

2016-06-28 Thread David Edmundson


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128307/#review96933
---



The reason doesn't make too much sense - with Qt 5.6 or higher we're disabling 
high DPI with the setAttribute rather than qunsetenv

- David Edmundson


On June 28, 2016, 4:22 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128307/
> ---
> 
> (Updated June 28, 2016, 4:22 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This prevents kcmshell5 from inheriting the application's environment, namely 
> Plasma disabling Qt's high dpi scaling.
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt f12474d 
>   src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp 809de44 
> 
> Diff: https://git.reviewboard.kde.org/r/128307/diff/
> 
> 
> Testing
> ---
> 
> I now get properly scaled config dialogs for power management and user 
> settings
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128309: add helper function to create "Details" button

2016-06-28 Thread Rolf Eike Beer


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128309/
---

Review request for KDE Frameworks.


Repository: kwidgetsaddons


Description
---

Otherwise an application that wishes to use the details member e.g. of 
createKMessageBox() has to duplicate the setup code, including the translation 
setup.


Diffs
-

  src/kmessagebox.h 3826a46 
  src/kmessagebox.cpp 194ffae 

Diff: https://git.reviewboard.kde.org/r/128309/diff/


Testing
---


Thanks,

Rolf Eike Beer

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128308: fix the mkspecs install directory when cross-compiling using Qt5

2016-06-28 Thread Rolf Eike Beer


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128308/
---

Review request for KDE Frameworks.


Repository: qca


Description
---

mkspecs should go in the host install prefix, not the target one.


Diffs
-

  cmake/modules/QcaMacro.cmake 88ab0d0 

Diff: https://git.reviewboard.kde.org/r/128308/diff/


Testing
---

Puts the mkspec file in the correct directory when cross-compiling now.


Thanks,

Rolf Eike Beer

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128300: Set Tooltip window type on ToolTipDialog through KWindowSystem API

2016-06-28 Thread Martin Gräßlin



> On June 28, 2016, 1:47 p.m., David Edmundson wrote:
> > src/declarativeimports/core/tooltipdialog.cpp, line 122
> > 
> >
> > we already have setFlags(Qt::Tooltip)
> > 
> > why is this not enough?
> 
> Martin Gräßlin wrote:
> This depends on https://phabricator.kde.org/D2031
> 
> Wayland doesn't have a window type "Tooltip". Thus Qt doesn't do anything 
> with the flag. It's just being ignored. We need to manually do this by 
> creating a PlasmaShellSurface, like with all other custom window types we 
> have but Wayland doesn't. Like OSD, Notification, Panel, Dock. By using 
> KWindowSystem it's just the easiest way.
> 
> Anthony Fieroni wrote:
> How pure Qt apps will show tooltip in Wayland?

> How pure Qt apps will show tooltip in Wayland?

They can show tooltips just fine. Just the compositor (KWin) doesn't know it's 
a tooltip window and cannot apply special magic for the tooltip window.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128300/#review96911
---


On June 28, 2016, 1:43 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128300/
> ---
> 
> (Updated June 28, 2016, 1:43 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> In order to have support for tooltip window type in Wayland, the
> window type NET::Tooltip is also set through KWindowSystem API once
> the platform surface is created.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/tooltipdialog.cpp 
> 18aa520bf15e1a03eb6a4816e49ab35e2350f8da 
> 
> Diff: https://git.reviewboard.kde.org/r/128300/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128307: [KDeclarative] [KCMShell Proxy] Use KToolInvocation::kdeinitExec instead of QProcess::startDetached

2016-06-28 Thread Kai Uwe Broulik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128307/
---

Review request for KDE Frameworks.


Repository: kdeclarative


Description
---

This prevents kcmshell5 from inheriting the application's environment, namely 
Plasma disabling Qt's high dpi scaling.


Diffs
-

  src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt f12474d 
  src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp 809de44 

Diff: https://git.reviewboard.kde.org/r/128307/diff/


Testing
---

I now get properly scaled config dialogs for power management and user settings


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128300: Set Tooltip window type on ToolTipDialog through KWindowSystem API

2016-06-28 Thread Anthony Fieroni



> On Юни 28, 2016, 2:47 след обяд, David Edmundson wrote:
> > src/declarativeimports/core/tooltipdialog.cpp, line 122
> > 
> >
> > we already have setFlags(Qt::Tooltip)
> > 
> > why is this not enough?
> 
> Martin Gräßlin wrote:
> This depends on https://phabricator.kde.org/D2031
> 
> Wayland doesn't have a window type "Tooltip". Thus Qt doesn't do anything 
> with the flag. It's just being ignored. We need to manually do this by 
> creating a PlasmaShellSurface, like with all other custom window types we 
> have but Wayland doesn't. Like OSD, Notification, Panel, Dock. By using 
> KWindowSystem it's just the easiest way.

How pure Qt apps will show tooltip in Wayland?


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128300/#review96911
---


On Юни 28, 2016, 2:43 след обяд, Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128300/
> ---
> 
> (Updated Юни 28, 2016, 2:43 след обяд)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> In order to have support for tooltip window type in Wayland, the
> window type NET::Tooltip is also set through KWindowSystem API once
> the platform surface is created.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/tooltipdialog.cpp 
> 18aa520bf15e1a03eb6a4816e49ab35e2350f8da 
> 
> Diff: https://git.reviewboard.kde.org/r/128300/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128283: Add checksums tab to the properties dialog

2016-06-28 Thread Elvis Angelaccio


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128283/
---

(Updated June 28, 2016, 2:40 p.m.)


Review request for KDE Frameworks, KDE Usability and David Faure.


Changes
---

Automatically show a checksum once it's been computed.


Repository: kio


Description
---

This patch adds a Checksums tab in the properties dialog, where the user can 
retrieve and verify the most popular checksum algorithms (md5, sha1 and 
sha256). 

To simplify the implementation, the checksums are computed as soon as the user 
opens the dialog. This can take a while if the file is huge (in particular with 
sha256), but the computation happens in another thread and in practice this 
should not be a performance problem.

The tab is available only for readable local files (no simlinks) and only when 
there is a single selection.

Please note that some of the labels in the screenshots are clipped due to a bug 
in breeze: https://bugs.kde.org/show_bug.cgi?id=364426


Diffs (updated)
-

  src/widgets/CMakeLists.txt f906577 
  src/widgets/checksumswidget.ui PRE-CREATION 
  src/widgets/kpropertiesdialog.cpp d0a2faa 
  src/widgets/kpropertiesdialog_p.h c01554e 

Diff: https://git.reviewboard.kde.org/r/128283/diff/


Testing
---

* Check whether the computed values match the values from md5sum, sha1sum, 
sha256sum.
* Check whether the line edits get a green background if the computed and 
expected values match.
* Check whether the line edits get a red background if the computed and 
expected values differ.


File Attachments


MD5 ready to be shared
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/26/b882fad9-85b0-4250-9743-3549339e6718__Spectacle.l10844.png
Default dialog
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/27/ad06e136-7ce3-4876-a594-98fbc64f5538__Spectacle.M13222.png
Mismatch
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/27/99838e45-d9c5-4a14-b26a-9440f0249c4b__Spectacle.V13222.png
Match
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/27/519fa28f-7c7d-4bb4-bd24-622d18d7f2e2__Spectacle.v13222.png
Invalid checksum
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/27/a243c830-2dc0-4cbd-95e9-8f1684bc86a4__Spectacle.J13336.png


Thanks,

Elvis Angelaccio

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128283: Add checksums tab to the properties dialog

2016-06-28 Thread Thomas Pfeiffer



> On June 26, 2016, 12:13 p.m., Luigi Toscano wrote:
> > When the verify operation is executed, shouldn't the computed checksum be 
> > (immediately) shown in the corresponding text box?

Makes sense, since it's then already calculated anyway.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128283/#review96871
---


On June 27, 2016, 3:46 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128283/
> ---
> 
> (Updated June 27, 2016, 3:46 p.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> This patch adds a Checksums tab in the properties dialog, where the user can 
> retrieve and verify the most popular checksum algorithms (md5, sha1 and 
> sha256). 
> 
> To simplify the implementation, the checksums are computed as soon as the 
> user opens the dialog. This can take a while if the file is huge (in 
> particular with sha256), but the computation happens in another thread and in 
> practice this should not be a performance problem.
> 
> The tab is available only for readable local files (no simlinks) and only 
> when there is a single selection.
> 
> Please note that some of the labels in the screenshots are clipped due to a 
> bug in breeze: https://bugs.kde.org/show_bug.cgi?id=364426
> 
> 
> Diffs
> -
> 
>   src/widgets/CMakeLists.txt f906577 
>   src/widgets/checksumswidget.ui PRE-CREATION 
>   src/widgets/kpropertiesdialog.cpp d0a2faa 
>   src/widgets/kpropertiesdialog_p.h c01554e 
> 
> Diff: https://git.reviewboard.kde.org/r/128283/diff/
> 
> 
> Testing
> ---
> 
> * Check whether the computed values match the values from md5sum, sha1sum, 
> sha256sum.
> * Check whether the line edits get a green background if the computed and 
> expected values match.
> * Check whether the line edits get a red background if the computed and 
> expected values differ.
> 
> 
> File Attachments
> 
> 
> MD5 ready to be shared
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/26/b882fad9-85b0-4250-9743-3549339e6718__Spectacle.l10844.png
> Default dialog
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/27/ad06e136-7ce3-4876-a594-98fbc64f5538__Spectacle.M13222.png
> Mismatch
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/27/99838e45-d9c5-4a14-b26a-9440f0249c4b__Spectacle.V13222.png
> Match
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/27/519fa28f-7c7d-4bb4-bd24-622d18d7f2e2__Spectacle.v13222.png
> Invalid checksum
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/27/a243c830-2dc0-4cbd-95e9-8f1684bc86a4__Spectacle.J13336.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128283: Add checksums tab to the properties dialog

2016-06-28 Thread Elvis Angelaccio



> On June 27, 2016, 12:16 p.m., Thomas Pfeiffer wrote:
> > Thank you for implementing the suggestion!
> > There are still some issues with it:
> > 1. HIG says "Avoid using color as a primary method of communication". A 
> > red-green blind person would have no tell success apart from failure here. 
> > Please write "Checksums match" or "Checksums do not match" below.
> > 2. A test I just did with a "regular" user showed that she did not know 
> > what to do with the verification box. I'd suggest writing above it "Copy 
> > and paste a checksum provided for example on the website you downloaded the 
> > file from in the field below."
> > 3.  It would be great if you could insert an expander which shows further 
> > instructions if the checksums don't match, e.g. "This may be due to a 
> > faulty download. Try re-downloading the file. If the verification still 
> > fails, contact the source of the file."
> > 4.  What happens if you type the checksum in manually? At witch point does 
> > it start verifying?
> 
> Elvis Angelaccio wrote:
> > What happens if you type the checksum in manually? At witch point does 
> it start verifying?
> 
> It starts as soon as the input is a valid MD5, SHA1 or SHA256 checksum 
> (which means 32, 40 or 64 hexadecimal digits). If it's not valid, the box 
> becomes red and a tooltip explains what's wrong. I'm assuming that most of 
> the times the user is going to copy-paste the whole checksum.
> 
> > It would be great if you could insert an expander which shows further 
> instructions if the checksums don't match, e.g. "This may be due to a faulty 
> download. Try re-downloading the file. If the verification still fails, 
> contact the source of the file."
> 
> An expander should be doable (using KCollapsibleGroupBox), but if we're 
> going to add a label "Checksums do not match", why not just adding another 
> label below? (with the expanded error message). There is more than enough 
> space in the dialog.
> 
> Thomas Pfeiffer wrote:
> It might look a bit "cleaner" with an expander, but you are right, we 
> have the space and it's not like people have to see the whole thing that 
> often, so it's fine.
> I think we might have made checksum checking actually usable for normal 
> people :) 
> (if they know where to find it, that is)

Thanks! What do you think of the Luigi's proposal? (showing the computed 
checksum in place of the corresponding "Calculate" button)


- Elvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128283/#review96893
---


On June 27, 2016, 3:46 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128283/
> ---
> 
> (Updated June 27, 2016, 3:46 p.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> This patch adds a Checksums tab in the properties dialog, where the user can 
> retrieve and verify the most popular checksum algorithms (md5, sha1 and 
> sha256). 
> 
> To simplify the implementation, the checksums are computed as soon as the 
> user opens the dialog. This can take a while if the file is huge (in 
> particular with sha256), but the computation happens in another thread and in 
> practice this should not be a performance problem.
> 
> The tab is available only for readable local files (no simlinks) and only 
> when there is a single selection.
> 
> Please note that some of the labels in the screenshots are clipped due to a 
> bug in breeze: https://bugs.kde.org/show_bug.cgi?id=364426
> 
> 
> Diffs
> -
> 
>   src/widgets/CMakeLists.txt f906577 
>   src/widgets/checksumswidget.ui PRE-CREATION 
>   src/widgets/kpropertiesdialog.cpp d0a2faa 
>   src/widgets/kpropertiesdialog_p.h c01554e 
> 
> Diff: https://git.reviewboard.kde.org/r/128283/diff/
> 
> 
> Testing
> ---
> 
> * Check whether the computed values match the values from md5sum, sha1sum, 
> sha256sum.
> * Check whether the line edits get a green background if the computed and 
> expected values match.
> * Check whether the line edits get a red background if the computed and 
> expected values differ.
> 
> 
> File Attachments
> 
> 
> MD5 ready to be shared
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/26/b882fad9-85b0-4250-9743-3549339e6718__Spectacle.l10844.png
> Default dialog
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/27/ad06e136-7ce3-4876-a594-98fbc64f5538__Spectacle.M13222.png
> Mismatch
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/27/99838e45-d9c5-4a14-b26a-9440f0249c4b__Spectacle.V13222.png
> Match
>   
>

Jenkins-kde-ci: networkmanager-qt master stable-kf5-qt5 » Linux,gcc - Build # 19 - Still Unstable!

2016-06-28 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/networkmanager-qt%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/19/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 28 Jun 2016 12:58:21 +
Build duration: 3 min 25 sec

CHANGE SET
Revision 555b144a330f62c00813226d41be5f1ddfd32b03 by jgrulich: (Do not set peap 
label based on peap version)
  change: edit src/settings/security8021xsetting.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 
24 test(s)Failed: TestSuite.managertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/6 (100%)FILES 158/290 (54%)CLASSES 158/290 (54%)LINE 5552/10548 
(53%)CONDITIONAL 1678/4927 (34%)

By packages
  
autotests
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 196/220 (89%)CONDITIONAL 
114/260 (44%)
autotests.settings
FILES 42/42 (100%)CLASSES 42/42 (100%)LINE 1134/1142 
(99%)CONDITIONAL 312/568 (55%)
src
FILES 25/91 (27%)CLASSES 25/91 (27%)LINE 851/3294 
(26%)CONDITIONAL 375/1909 (20%)
src.dbus
FILES 14/66 (21%)CLASSES 14/66 (21%)LINE 159/744 
(21%)CONDITIONAL 4/74 (5%)
src.fakenetwork
FILES 6/8 (75%)CLASSES 6/8 (75%)LINE 472/712 (66%)CONDITIONAL 
45/124 (36%)
src.settings
FILES 65/77 (84%)CLASSES 65/77 (84%)LINE 2740/4436 
(62%)CONDITIONAL 828/1992 (42%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: networkmanager-qt master kf5-qt5 » Linux,gcc - Build # 20 - Still Unstable!

2016-06-28 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/networkmanager-qt%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/20/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 28 Jun 2016 12:58:21 +
Build duration: 2 min 33 sec

CHANGE SET
Revision 555b144a330f62c00813226d41be5f1ddfd32b03 by jgrulich: (Do not set peap 
label based on peap version)
  change: edit src/settings/security8021xsetting.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 
24 test(s)Failed: TestSuite.managertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/6 (100%)FILES 158/290 (54%)CLASSES 158/290 (54%)LINE 5552/10548 
(53%)CONDITIONAL 1678/4927 (34%)

By packages
  
autotests
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 196/220 (89%)CONDITIONAL 
114/260 (44%)
autotests.settings
FILES 42/42 (100%)CLASSES 42/42 (100%)LINE 1134/1142 
(99%)CONDITIONAL 312/568 (55%)
src
FILES 25/91 (27%)CLASSES 25/91 (27%)LINE 851/3294 
(26%)CONDITIONAL 375/1909 (20%)
src.dbus
FILES 14/66 (21%)CLASSES 14/66 (21%)LINE 159/744 
(21%)CONDITIONAL 4/74 (5%)
src.fakenetwork
FILES 6/8 (75%)CLASSES 6/8 (75%)LINE 472/712 (66%)CONDITIONAL 
45/124 (36%)
src.settings
FILES 65/77 (84%)CLASSES 65/77 (84%)LINE 2740/4436 
(62%)CONDITIONAL 828/1992 (42%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128300: Set Tooltip window type on ToolTipDialog through KWindowSystem API

2016-06-28 Thread Martin Gräßlin



> On June 28, 2016, 1:47 p.m., David Edmundson wrote:
> > src/declarativeimports/core/tooltipdialog.cpp, line 122
> > 
> >
> > we already have setFlags(Qt::Tooltip)
> > 
> > why is this not enough?

This depends on https://phabricator.kde.org/D2031

Wayland doesn't have a window type "Tooltip". Thus Qt doesn't do anything with 
the flag. It's just being ignored. We need to manually do this by creating a 
PlasmaShellSurface, like with all other custom window types we have but Wayland 
doesn't. Like OSD, Notification, Panel, Dock. By using KWindowSystem it's just 
the easiest way.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128300/#review96911
---


On June 28, 2016, 1:43 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128300/
> ---
> 
> (Updated June 28, 2016, 1:43 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> In order to have support for tooltip window type in Wayland, the
> window type NET::Tooltip is also set through KWindowSystem API once
> the platform surface is created.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/tooltipdialog.cpp 
> 18aa520bf15e1a03eb6a4816e49ab35e2350f8da 
> 
> Diff: https://git.reviewboard.kde.org/r/128300/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128300: Set Tooltip window type on ToolTipDialog through KWindowSystem API

2016-06-28 Thread David Edmundson


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128300/#review96911
---




src/declarativeimports/core/tooltipdialog.cpp (line 122)


we already have setFlags(Qt::Tooltip)

why is this not enough?


- David Edmundson


On June 28, 2016, 11:43 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128300/
> ---
> 
> (Updated June 28, 2016, 11:43 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> In order to have support for tooltip window type in Wayland, the
> window type NET::Tooltip is also set through KWindowSystem API once
> the platform surface is created.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/tooltipdialog.cpp 
> 18aa520bf15e1a03eb6a4816e49ab35e2350f8da 
> 
> Diff: https://git.reviewboard.kde.org/r/128300/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128300: Set Tooltip window type on ToolTipDialog through KWindowSystem API

2016-06-28 Thread Martin Gräßlin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128300/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

In order to have support for tooltip window type in Wayland, the
window type NET::Tooltip is also set through KWindowSystem API once
the platform surface is created.


Diffs
-

  src/declarativeimports/core/tooltipdialog.cpp 
18aa520bf15e1a03eb6a4816e49ab35e2350f8da 

Diff: https://git.reviewboard.kde.org/r/128300/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 118 - Still Unstable!

2016-06-28 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/118/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 28 Jun 2016 10:43:57 +
Build duration: 13 min

CHANGE SET
Revision 16d28d36a283106eb8e9a3dd608b5614f2ad1ebd by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit src/urifilters/ikws/searchproviders/soundcloud.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/340 (76%)CLASSES 260/340 (76%)LINE 26786/50739 
(53%)CONDITIONAL 14955/37493 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7549/7862 
(96%)CONDITIONAL 4197/8168 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7681/14041 
(55%)CONDITIONAL 4156/8907 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2271/7565 
(30%)CONDITIONAL 914/4407 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3781 
(47%)CONDITIONAL 1259/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 684/760 (90%)CONDITIONAL 
435/916 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
327/408 (80%)
src.widgets
FILES 29/64 (45%)CLASSES 29/64 (45%)LINE 2675/10685 
(25%)CONDITIONAL 1336/6844 (20%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 118 - Still Unstable!

2016-06-28 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/118/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 28 Jun 2016 10:43:57 +
Build duration: 4 min 39 sec

CHANGE SET
Revision 16d28d36a283106eb8e9a3dd608b5614f2ad1ebd by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit src/urifilters/ikws/searchproviders/soundcloud.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/340 (76%)CLASSES 260/340 (76%)LINE 26741/50720 
(53%)CONDITIONAL 14927/37469 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7530/7843 
(96%)CONDITIONAL 4185/8144 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7655/14041 
(55%)CONDITIONAL 4141/8907 (46%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2268/7565 
(30%)CONDITIONAL 914/4407 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3781 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 684/760 (90%)CONDITIONAL 
435/916 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 382/594 (64%)CONDITIONAL 
284/580 (49%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
327/408 (80%)
src.widgets
FILES 29/64 (45%)CLASSES 29/64 (45%)LINE 2673/10685 
(25%)CONDITIONAL 1332/6844 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 117 - Still Unstable!

2016-06-28 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/117/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 28 Jun 2016 10:27:33 +
Build duration: 11 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/340 (76%)CLASSES 260/340 (76%)LINE 26764/50720 
(53%)CONDITIONAL 14933/37469 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7530/7843 
(96%)CONDITIONAL 4183/8144 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7676/14041 
(55%)CONDITIONAL 4148/8907 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2268/7565 
(30%)CONDITIONAL 914/4407 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3781 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 723/1155 (63%)CONDITIONAL 
384/753 (51%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 684/760 (90%)CONDITIONAL 
435/916 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 382/594 (64%)CONDITIONAL 
284/580 (49%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
327/408 (80%)
src.widgets
FILES 29/64 (45%)CLASSES 29/64 (45%)LINE 2673/10685 
(25%)CONDITIONAL 1333/6844 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 117 - Still Unstable!

2016-06-28 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/117/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 28 Jun 2016 10:27:23 +
Build duration: 6 min 55 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/340 (76%)CLASSES 260/340 (76%)LINE 26767/50739 
(53%)CONDITIONAL 14944/37493 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7546/7862 
(96%)CONDITIONAL 4196/8168 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7665/14041 
(55%)CONDITIONAL 4145/8907 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2271/7565 
(30%)CONDITIONAL 914/4407 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3781 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 684/760 (90%)CONDITIONAL 
435/916 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
327/408 (80%)
src.widgets
FILES 29/64 (45%)CLASSES 29/64 (45%)LINE 2675/10685 
(25%)CONDITIONAL 1336/6844 (20%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128283: Add checksums tab to the properties dialog

2016-06-28 Thread Thomas Pfeiffer



> On June 27, 2016, 12:16 p.m., Thomas Pfeiffer wrote:
> > Thank you for implementing the suggestion!
> > There are still some issues with it:
> > 1. HIG says "Avoid using color as a primary method of communication". A 
> > red-green blind person would have no tell success apart from failure here. 
> > Please write "Checksums match" or "Checksums do not match" below.
> > 2. A test I just did with a "regular" user showed that she did not know 
> > what to do with the verification box. I'd suggest writing above it "Copy 
> > and paste a checksum provided for example on the website you downloaded the 
> > file from in the field below."
> > 3.  It would be great if you could insert an expander which shows further 
> > instructions if the checksums don't match, e.g. "This may be due to a 
> > faulty download. Try re-downloading the file. If the verification still 
> > fails, contact the source of the file."
> > 4.  What happens if you type the checksum in manually? At witch point does 
> > it start verifying?
> 
> Elvis Angelaccio wrote:
> > What happens if you type the checksum in manually? At witch point does 
> it start verifying?
> 
> It starts as soon as the input is a valid MD5, SHA1 or SHA256 checksum 
> (which means 32, 40 or 64 hexadecimal digits). If it's not valid, the box 
> becomes red and a tooltip explains what's wrong. I'm assuming that most of 
> the times the user is going to copy-paste the whole checksum.
> 
> > It would be great if you could insert an expander which shows further 
> instructions if the checksums don't match, e.g. "This may be due to a faulty 
> download. Try re-downloading the file. If the verification still fails, 
> contact the source of the file."
> 
> An expander should be doable (using KCollapsibleGroupBox), but if we're 
> going to add a label "Checksums do not match", why not just adding another 
> label below? (with the expanded error message). There is more than enough 
> space in the dialog.

It might look a bit "cleaner" with an expander, but you are right, we have the 
space and it's not like people have to see the whole thing that often, so it's 
fine.
I think we might have made checksum checking actually usable for normal people 
:) 
(if they know where to find it, that is)


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128283/#review96893
---


On June 27, 2016, 3:46 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128283/
> ---
> 
> (Updated June 27, 2016, 3:46 p.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> This patch adds a Checksums tab in the properties dialog, where the user can 
> retrieve and verify the most popular checksum algorithms (md5, sha1 and 
> sha256). 
> 
> To simplify the implementation, the checksums are computed as soon as the 
> user opens the dialog. This can take a while if the file is huge (in 
> particular with sha256), but the computation happens in another thread and in 
> practice this should not be a performance problem.
> 
> The tab is available only for readable local files (no simlinks) and only 
> when there is a single selection.
> 
> Please note that some of the labels in the screenshots are clipped due to a 
> bug in breeze: https://bugs.kde.org/show_bug.cgi?id=364426
> 
> 
> Diffs
> -
> 
>   src/widgets/CMakeLists.txt f906577 
>   src/widgets/checksumswidget.ui PRE-CREATION 
>   src/widgets/kpropertiesdialog.cpp d0a2faa 
>   src/widgets/kpropertiesdialog_p.h c01554e 
> 
> Diff: https://git.reviewboard.kde.org/r/128283/diff/
> 
> 
> Testing
> ---
> 
> * Check whether the computed values match the values from md5sum, sha1sum, 
> sha256sum.
> * Check whether the line edits get a green background if the computed and 
> expected values match.
> * Check whether the line edits get a red background if the computed and 
> expected values differ.
> 
> 
> File Attachments
> 
> 
> MD5 ready to be shared
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/26/b882fad9-85b0-4250-9743-3549339e6718__Spectacle.l10844.png
> Default dialog
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/27/ad06e136-7ce3-4876-a594-98fbc64f5538__Spectacle.M13222.png
> Mismatch
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/27/99838e45-d9c5-4a14-b26a-9440f0249c4b__Spectacle.V13222.png
> Match
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/27/519fa28f-7c7d-4bb4-bd24-622d18d7f2e2__Spectacle.v13222.png
> Invalid checksum
>   
>

Re: Review Request 127926: KNotifyConfigWidget: add disableAllSounds() method

2016-06-28 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127926/
---

(Updated June 28, 2016, 2:04 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, David Edmundson and Olivier Goffart.


Changes
---

Submitted with commit 9d5440c14cf9e8107f2cb270ad69cec98ab9303c by David Faure 
to branch master.


Bugs: 157272
https://bugs.kde.org/show_bug.cgi?id=157272


Repository: knotifyconfig


Description
---

This saves a lot of clicking compared to selecting each event
in the list and unchecking the "Play sound" checkbox, something
I have to do any time I set up a new computer (for me or around the office).

CCBUG: 157272


Diffs
-

  src/knotifyconfigwidget.h bf122bd9e30982f0fa0d022d04aeadee4fb181dc 
  src/knotifyconfigwidget.cpp 06125ea9da565cbc14c8afa1155c723605b42da6 
  src/knotifyeventlist.h b6bd43ed40f9b2a18d41300760a6c01dca52907d 
  src/knotifyeventlist.cpp 6913148869a7be6b267668e44888f1a432b2396b 

Diff: https://git.reviewboard.kde.org/r/127926/diff/


Testing
---

I'm calling this method from a button in the KCM: 
http://www.davidfaure.fr/2016/kcmnotify.diff

My initial idea was a "disable all sounds for all event sources" button, but 
the underlying classes don't make this easy to support (I'd have to literally 
set every item as current in the combo, leading to a strange user-visible 
automation happening). Disabling all sounds for the current event source (app) 
is already quite a time saver.
Plus this way the change isn't saved yet, it can still be cancelled by pressing 
Cancel, like any other change -except- selecting another app.


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Is it able to make kservice's weightedOffers public access?

2016-06-28 Thread Leslie Zhai


Hi KDE developers,

It might needs to use static KServiceTypeTrader::weightedOffers(const 
QString ) to get KServiceOfferList offers, for example, 
https://github.com/isoft-linux/plasma-workspace/blob/Chinese-word-segmentation/runners/services/servicerunner.cpp#L93



KService::List services;
const KServiceOfferList offers = 
KServiceTypeTrader::weightedOffers("Application");


KServiceOfferList::const_iterator itOff = offers.begin();
for (; itOff != offers.end(); ++itOff) {
services.append((*itOff).service());
}


but kservice's weightedOffers is private access, so is it able to make 
it public without bad effect?



diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index f4d09d5..74a8c50 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -124,6 +124,7 @@ ecm_generate_headers(KService_HEADERS
   KServiceTypeProfile
   KServiceTypeTrader
   KPluginInfo
+  KServiceOffer

   RELATIVE services REQUIRED_HEADERS KService_HEADERS
 )
diff --git a/src/services/kservicetypetrader.h 
b/src/services/kservicetypetrader.h

index 56994d8..1642ef4 100644
--- a/src/services/kservicetypetrader.h
+++ b/src/services/kservicetypetrader.h
@@ -203,6 +203,8 @@ public:
 static void applyConstraints(KService::List ,
  const QString );

+static KServiceOfferList weightedOffers(const QString );
+
 private:
 /**
  * @internal
@@ -213,8 +215,6 @@ private:
 KServiceTypeTrader(const KServiceTypeTrader );
 KServiceTypeTrader =(const KServiceTypeTrader );

-static KServiceOfferList weightedOffers(const QString );
-
 KServiceTypeTraderPrivate *const d;

 friend class KServiceTypeTraderSingleton;

--
Regards,
Leslie Zhai



___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127833: KWallet: More Coverity fixes, and include Qt headers for endianness check.

Re: Review Request 128250: Silence CMake policy CMP0063 warning also for tests

Re: Review Request 128252: Silence CMake policy CMP0063 warning

Re: Review Request 128251: Silence CMake policy CMP0063 warning

Review Request 128312: Fix notify by taskbar

Re: Review Request 128309: add helper function to create "Details" button

Re: Review Request 128307: [KDeclarative] [KCMShell Proxy] Use KToolInvocation::kdeinitExec instead of QProcess::startDetached

Review Request 128309: add helper function to create "Details" button

Review Request 128308: fix the mkspecs install directory when cross-compiling using Qt5

Re: Review Request 128300: Set Tooltip window type on ToolTipDialog through KWindowSystem API

Review Request 128307: [KDeclarative] [KCMShell Proxy] Use KToolInvocation::kdeinitExec instead of QProcess::startDetached

Re: Review Request 128300: Set Tooltip window type on ToolTipDialog through KWindowSystem API

Re: Review Request 128283: Add checksums tab to the properties dialog

Re: Review Request 128283: Add checksums tab to the properties dialog

Re: Review Request 128283: Add checksums tab to the properties dialog

Jenkins-kde-ci: networkmanager-qt master stable-kf5-qt5 » Linux,gcc - Build # 19 - Still Unstable!

Jenkins-kde-ci: networkmanager-qt master kf5-qt5 » Linux,gcc - Build # 20 - Still Unstable!

Re: Review Request 128300: Set Tooltip window type on ToolTipDialog through KWindowSystem API

Re: Review Request 128300: Set Tooltip window type on ToolTipDialog through KWindowSystem API

Review Request 128300: Set Tooltip window type on ToolTipDialog through KWindowSystem API

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 118 - Still Unstable!

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 118 - Still Unstable!

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 117 - Still Unstable!

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 117 - Still Unstable!

Re: Review Request 128283: Add checksums tab to the properties dialog

Re: Review Request 127926: KNotifyConfigWidget: add disableAllSounds() method

Is it able to make kservice's weightedOffers public access?

27 matches

Site Navigation

Mail list logo

Footer information