Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

2016-12-02 Thread Anthony Fieroni 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127216/
---

(Updated Dec. 3, 2016, 8:50 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Martin Gräßlin and Martin Klapetek.


Changes
---

Submitted with commit 6198841710fb128987c308bd3ef3ff8cbd294ce0 by Anthony 
Fieroni to branch master.


Bugs: 356523
https://bugs.kde.org/show_bug.cgi?id=356523


Repository: knotifications


Description
---

Store position of widget before hide it


Diffs
-

  src/kstatusnotifieritem.cpp 3eb39b2 
  src/kstatusnotifieritemprivate_p.h 8fdfd4c 

Diff: https://git.reviewboard.kde.org/r/127216/diff/


Testing
---

Tested on pixel ratio = 1 with Amarok, Kmail, Akregator, Kalarm, Ktimer
Close with 'X' - restore in correct pos
Hide by click at icon in systray - restore correct pos


Thanks,

Anthony Fieroni

[Differential] [Commented On] D2075: Fix bug in kfiledialog.cpp that causes crashing when native widgets are used.

2016-12-02 Thread jonathans (Jonathan Schultz) 
jonathans added a comment.


  Agreed that would be more robust. In writing the patch I was seeking 
consistency with those functions that already did the test, so those would also 
need to be updated. Are there any situations where the two tests would yield a 
different result, ie d->native is true and d->w is non-null?

REPOSITORY
  R239  KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D2075

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jonathans, #frameworks, dfaure, kfunk
Cc: kfunk, aacid

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

2016-12-02 Thread Albert Astals Cid 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127216/#review101225
---



Honestly i don't see anything wrong with the patch but i didn't see anything 
wrong with the old code either, i.e. i don't know much about this.

But you say you've been using it and looks good and there doesn't seem to be 
anyone willing to give you a ship it.

I'd say you just ship it yourself and then take full responsability in looking 
thoguh new bugs in case you break something and fix it immediately or revert 
the change.

- Albert Astals Cid


On Nov. 13, 2016, 5:17 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127216/
> ---
> 
> (Updated Nov. 13, 2016, 5:17 a.m.)
> 
> 
> Review request for KDE Frameworks, Martin Gräßlin and Martin Klapetek.
> 
> 
> Bugs: 356523
> https://bugs.kde.org/show_bug.cgi?id=356523
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> Store position of widget before hide it
> 
> 
> Diffs
> -
> 
>   src/kstatusnotifieritem.cpp 3eb39b2 
>   src/kstatusnotifieritemprivate_p.h 8fdfd4c 
> 
> Diff: https://git.reviewboard.kde.org/r/127216/diff/
> 
> 
> Testing
> ---
> 
> Tested on pixel ratio = 1 with Amarok, Kmail, Akregator, Kalarm, Ktimer
> Close with 'X' - restore in correct pos
> Hide by click at icon in systray - restore correct pos
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

2016-12-02 Thread Albert Astals Cid 


> On Dec. 1, 2016, 9:43 p.m., Albert Astals Cid wrote:
> > src/kstatusnotifieritem.cpp, line 972
> > 
> >
> > maybe move this to the else?
> 
> Anthony Fieroni wrote:
> NET::WMFrameExtents is not needed anymore.
> 
> Anthony Fieroni wrote:
> info is used on 977 and 984 is two 'else' braches :)

Right, i missed one.


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127216/#review101203
---


On Nov. 13, 2016, 5:17 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127216/
> ---
> 
> (Updated Nov. 13, 2016, 5:17 a.m.)
> 
> 
> Review request for KDE Frameworks, Martin Gräßlin and Martin Klapetek.
> 
> 
> Bugs: 356523
> https://bugs.kde.org/show_bug.cgi?id=356523
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> Store position of widget before hide it
> 
> 
> Diffs
> -
> 
>   src/kstatusnotifieritem.cpp 3eb39b2 
>   src/kstatusnotifieritemprivate_p.h 8fdfd4c 
> 
> Diff: https://git.reviewboard.kde.org/r/127216/diff/
> 
> 
> Testing
> ---
> 
> Tested on pixel ratio = 1 with Amarok, Kmail, Akregator, Kalarm, Ktimer
> Close with 'X' - restore in correct pos
> Hide by click at icon in systray - restore correct pos
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: [KUnitConversion] Question about overloading operators

2016-12-02 Thread Albert Astals Cid 
El dimecres, 23 de novembre de 2016, a les 9:00:10 CET, Ander Pijoan va 
escriure:
> So would it be to hamrfull to add at least this four operators? At the
> moment just allowing same Unit values. You mentioned that using Q_ASSERT is
> not a good idea, maybe there is another way of ensuring they have the same
> unit.
> 
> Value operator +(const Value ) {
> Q_ASSERT( this->unit() == other.unit() );
> return Value( this->number() + other.number() , this->unit() );
> }
> 
> Value operator -(const Value ) {
> Q_ASSERT( this->unit() == other.unit() );
> return Value( this->number() - other.number() , this->unit() );
> }
> 
> Value operator *(const double v) {
> return Value( this->number() * v , this->unit() );
> }
> 
> Value operator /(const double v) {
> return Value( this->number() / v , this->unit() );
> }
> 
> I think, this four operators could be really usefull and are pretty simple.

As said i would really appreciate if you would try to use 
KUnitConversion::Converter instead of asserting.

Anyhow i'm not the maintainer so i can't block.

Anyhow2 you should propose a patch in reviewboard if you want to get proper 
patch discussion.

Cheers,
  Albert

> 
> 2016-11-21 22:59 GMT+01:00 Albert Astals Cid :
> > El dilluns, 21 de novembre de 2016, a les 18:00:18 CET, Christoph Feck va
> > 
> > escriure:
> > > On 21.11.2016 08:27, Ander Pijoan wrote:
> > > > Value operator +(const Value )
> > > > {
> > > > 
> > > >   Q_ASSERT( unit() == other.unit() );
> > > >   return Value(  number() + other.number() , unit()  );
> > > > 
> > > > }
> > > 
> > > So when adding "3 m" and "40 cm" you want to have an assert (that isn't
> > > compiled into code unless you are in debug builds)?
> > > 
> > > Also, for multiplication, you would need to add all relationships
> > > between units, so that "40 mph" * "30 min" would result in "20 miles".
> > > 
> > > This is especially problematic for temporary units, e.g. "40 kg" * "20
> > > m/s" * "30 Hz" should have a "Newton" unit result, but just multiplying
> > > mass and speed has no unit assigned in KUnitConversion.
> > 
> > We have a InvalidUnit, you can always default to that for stuff "you don't
> > know".
> > 
> > Cheers,
> > 
> >   Albert

Jenkins-kde-ci: kconfig master kf5-qt5 » Linux,gcc - Build # 103 - Fixed!

2016-12-02 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/103/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 02 Dec 2016 18:45:53 +
Build duration: 4 min 54 sec

CHANGE SET
Revision 71f16741a0288d8587876dcc7dbb33ba8f00546a by Martin Gräßlin: 
([autotest] Fix stupidity)
  change: edit autotests/kconfig_compiler/test8c.cpp.ref
  change: edit autotests/kconfig_compiler/test8c.h.ref


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 36 test(s), Skipped: 0 test(s), Total: 
36 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/6 (100%)FILES 79/85 (93%)CLASSES 79/85 (93%)LINE 6741/8527 
(79%)CONDITIONAL 3966/6975 (57%)

By packages
  
autotests
FILES 23/23 (100%)CLASSES 23/23 (100%)LINE 2001/2011 
(100%)CONDITIONAL 1172/2286 (51%)
autotests.kconfig_compiler
FILES 25/26 (96%)CLASSES 25/26 (96%)LINE 279/303 
(92%)CONDITIONAL 117/248 (47%)
src.core
FILES 21/24 (88%)CLASSES 21/24 (88%)LINE 2253/3350 
(67%)CONDITIONAL 1285/2428 (53%)
src.gui
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 431/703 (61%)CONDITIONAL 
167/319 (52%)
src.kconf_update
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 420/588 (71%)CONDITIONAL 
268/469 (57%)
src.kconfig_compiler
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 1357/1572 
(86%)CONDITIONAL 957/1225 (78%)

Jenkins-kde-ci: kconfig master kf5-qt5 » Linux,gcc - Build # 103 - Fixed!

2016-12-02 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/103/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 02 Dec 2016 18:45:53 +
Build duration: 4 min 54 sec

CHANGE SET
Revision 71f16741a0288d8587876dcc7dbb33ba8f00546a by Martin Gräßlin: 
([autotest] Fix stupidity)
  change: edit autotests/kconfig_compiler/test8c.cpp.ref
  change: edit autotests/kconfig_compiler/test8c.h.ref


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 36 test(s), Skipped: 0 test(s), Total: 
36 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/6 (100%)FILES 79/85 (93%)CLASSES 79/85 (93%)LINE 6741/8527 
(79%)CONDITIONAL 3966/6975 (57%)

By packages
  
autotests
FILES 23/23 (100%)CLASSES 23/23 (100%)LINE 2001/2011 
(100%)CONDITIONAL 1172/2286 (51%)
autotests.kconfig_compiler
FILES 25/26 (96%)CLASSES 25/26 (96%)LINE 279/303 
(92%)CONDITIONAL 117/248 (47%)
src.core
FILES 21/24 (88%)CLASSES 21/24 (88%)LINE 2253/3350 
(67%)CONDITIONAL 1285/2428 (53%)
src.gui
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 431/703 (61%)CONDITIONAL 
167/319 (52%)
src.kconf_update
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 420/588 (71%)CONDITIONAL 
268/469 (57%)
src.kconfig_compiler
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 1357/1572 
(86%)CONDITIONAL 957/1225 (78%)

Jenkins-kde-ci: kconfig master stable-kf5-qt5 » Linux,gcc - Build # 98 - Fixed!

2016-12-02 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/98/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 02 Dec 2016 18:45:53 +
Build duration: 1 min 25 sec

CHANGE SET
Revision 71f16741a0288d8587876dcc7dbb33ba8f00546a by Martin Gräßlin: 
([autotest] Fix stupidity)
  change: edit autotests/kconfig_compiler/test8c.h.ref
  change: edit autotests/kconfig_compiler/test8c.cpp.ref


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 36 test(s), Skipped: 0 test(s), Total: 
36 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/6 (100%)FILES 79/85 (93%)CLASSES 79/85 (93%)LINE 6741/8527 
(79%)CONDITIONAL 3968/6975 (57%)

By packages
  
autotests
FILES 23/23 (100%)CLASSES 23/23 (100%)LINE 2001/2011 
(100%)CONDITIONAL 1172/2286 (51%)
autotests.kconfig_compiler
FILES 25/26 (96%)CLASSES 25/26 (96%)LINE 279/303 
(92%)CONDITIONAL 117/248 (47%)
src.core
FILES 21/24 (88%)CLASSES 21/24 (88%)LINE 2253/3350 
(67%)CONDITIONAL 1287/2428 (53%)
src.gui
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 431/703 (61%)CONDITIONAL 
167/319 (52%)
src.kconf_update
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 420/588 (71%)CONDITIONAL 
268/469 (57%)
src.kconfig_compiler
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 1357/1572 
(86%)CONDITIONAL 957/1225 (78%)

Jenkins-kde-ci: kconfig master stable-kf5-qt5 » Linux,gcc - Build # 98 - Fixed!

2016-12-02 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/98/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 02 Dec 2016 18:45:53 +
Build duration: 1 min 25 sec

CHANGE SET
Revision 71f16741a0288d8587876dcc7dbb33ba8f00546a by Martin Gräßlin: 
([autotest] Fix stupidity)
  change: edit autotests/kconfig_compiler/test8c.h.ref
  change: edit autotests/kconfig_compiler/test8c.cpp.ref


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 36 test(s), Skipped: 0 test(s), Total: 
36 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/6 (100%)FILES 79/85 (93%)CLASSES 79/85 (93%)LINE 6741/8527 
(79%)CONDITIONAL 3968/6975 (57%)

By packages
  
autotests
FILES 23/23 (100%)CLASSES 23/23 (100%)LINE 2001/2011 
(100%)CONDITIONAL 1172/2286 (51%)
autotests.kconfig_compiler
FILES 25/26 (96%)CLASSES 25/26 (96%)LINE 279/303 
(92%)CONDITIONAL 117/248 (47%)
src.core
FILES 21/24 (88%)CLASSES 21/24 (88%)LINE 2253/3350 
(67%)CONDITIONAL 1287/2428 (53%)
src.gui
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 431/703 (61%)CONDITIONAL 
167/319 (52%)
src.kconf_update
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 420/588 (71%)CONDITIONAL 
268/469 (57%)
src.kconfig_compiler
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 1357/1572 
(86%)CONDITIONAL 957/1225 (78%)

Jenkins-kde-ci: kconfig master kf5-qt5 » Linux,gcc - Build # 102 - Still Unstable!

2016-12-02 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/102/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 02 Dec 2016 18:37:13 +
Build duration: 1 min 28 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 
36 test(s)Failed: TestSuite.kconfigcompiler-basic-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/6 (100%)FILES 79/85 (93%)CLASSES 79/85 (93%)LINE 6755/8527 
(79%)CONDITIONAL 3977/6975 (57%)

By packages
  
autotests
FILES 23/23 (100%)CLASSES 23/23 (100%)LINE 2001/2011 
(100%)CONDITIONAL 1172/2286 (51%)
autotests.kconfig_compiler
FILES 25/26 (96%)CLASSES 25/26 (96%)LINE 293/303 
(97%)CONDITIONAL 126/248 (51%)
src.core
FILES 21/24 (88%)CLASSES 21/24 (88%)LINE 2253/3350 
(67%)CONDITIONAL 1287/2428 (53%)
src.gui
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 431/703 (61%)CONDITIONAL 
167/319 (52%)
src.kconf_update
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 420/588 (71%)CONDITIONAL 
268/469 (57%)
src.kconfig_compiler
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 1357/1572 
(86%)CONDITIONAL 957/1225 (78%)

[Differential] [Closed] D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg

2016-12-02 Thread Martin Gräßlin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:cd4e6504dfbd: Generate an instance with 
KSharedConfig::Ptr for singleton and arg (authored by graesslin).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3386?vs=8228=8702

REVISION DETAIL
  https://phabricator.kde.org/D3386

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test8c.cpp.ref
  autotests/kconfig_compiler/test8c.h.ref
  autotests/kconfig_compiler/test8c.kcfg
  autotests/kconfig_compiler/test8c.kcfgc
  autotests/kconfig_compiler/test8main.cpp
  src/kconfig_compiler/kconfig_compiler.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #frameworks, dfaure, mdawson
Cc: ltoscano, aacid, apol

Jenkins-kde-ci: kconfig master kf5-qt5 » Linux,gcc - Build # 101 - Unstable!

2016-12-02 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/101/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 02 Dec 2016 18:05:07 +
Build duration: 2 min 11 sec

CHANGE SET
Revision cd4e6504dfbdface00037625f0cedda511e6d839 by Martin Gräßlin: (Generate 
an instance with KSharedConfig::Ptr for singleton and arg)
  change: add autotests/kconfig_compiler/test8c.kcfgc
  change: add autotests/kconfig_compiler/test8c.cpp.ref
  change: edit autotests/kconfig_compiler/kconfigcompiler_test.cpp
  change: edit autotests/kconfig_compiler/CMakeLists.txt
  change: edit src/kconfig_compiler/kconfig_compiler.cpp
  change: edit autotests/kconfig_compiler/test8main.cpp
  change: add autotests/kconfig_compiler/test8c.kcfg
  change: add autotests/kconfig_compiler/test8c.h.ref


JUNIT RESULTS

Name: (root) Failed: 24 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 
36 test(s)Failed: TestSuite.kconfigcompiler-basic-testFailed: 
TestSuite.kconfigcompiler-signals-testFailed: 
TestSuite.kconfiggui-kconfigguitestFailed: 
TestSuite.kconfiggui-kconfigloadertestFailed: 
TestSuite.kconfiggui-kconfigskeletontestFailed: 
TestSuite.kconfiggui-kstandardshortcuttestFailed: TestSuite.test1Failed: 
TestSuite.test10Failed: TestSuite.test11Failed: TestSuite.test2Failed: 
TestSuite.test3Failed: TestSuite.test3aFailed: TestSuite.test4Failed: 
TestSuite.test5Failed: TestSuite.test6Failed: TestSuite.test7Failed: 
TestSuite.test8Failed: TestSuite.test9Failed: TestSuite.test_dpointerFailed: 
TestSuite.test_qdebugcategoryFailed: TestSuite.test_signalFailed: 
TestSuite.test_translation_kdeFailed: 
TestSuite.test_translation_kde_domainFailed: TestSuite.test_translation_qt

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/6 (100%)FILES 47/55 (85%)CLASSES 47/55 (85%)LINE 5430/8039 
(68%)CONDITIONAL 3449/6463 (53%)

By packages
  
autotests
FILES 15/15 (100%)CLASSES 15/15 (100%)LINE 1755/1763 
(100%)CONDITIONAL 1010/1960 (52%)
autotests.kconfig_compiler
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 60/66 (91%)CONDITIONAL 
42/62 (68%)
src.core
FILES 21/24 (88%)CLASSES 21/24 (88%)LINE 1825/3347 
(55%)CONDITIONAL 1165/2428 (48%)
src.gui
FILES 4/9 (44%)CLASSES 4/9 (44%)LINE 13/703 (2%)CONDITIONAL 
7/319 (2%)
src.kconf_update
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 420/588 (71%)CONDITIONAL 
268/469 (57%)
src.kconfig_compiler
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 1357/1572 
(86%)CONDITIONAL 957/1225 (78%)

Jenkins-kde-ci: kconfig master stable-kf5-qt5 » Linux,gcc - Build # 97 - Unstable!

2016-12-02 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/97/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 02 Dec 2016 18:05:07 +
Build duration: 2 min 13 sec

CHANGE SET
Revision cd4e6504dfbdface00037625f0cedda511e6d839 by Martin Gräßlin: (Generate 
an instance with KSharedConfig::Ptr for singleton and arg)
  change: add autotests/kconfig_compiler/test8c.kcfgc
  change: add autotests/kconfig_compiler/test8c.cpp.ref
  change: edit autotests/kconfig_compiler/kconfigcompiler_test.cpp
  change: add autotests/kconfig_compiler/test8c.kcfg
  change: add autotests/kconfig_compiler/test8c.h.ref
  change: edit autotests/kconfig_compiler/test8main.cpp
  change: edit src/kconfig_compiler/kconfig_compiler.cpp
  change: edit autotests/kconfig_compiler/CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 
36 test(s)Failed: TestSuite.kconfigcompiler-basic-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/6 (100%)FILES 79/85 (93%)CLASSES 79/85 (93%)LINE 6755/8527 
(79%)CONDITIONAL 3977/6975 (57%)

By packages
  
autotests
FILES 23/23 (100%)CLASSES 23/23 (100%)LINE 2001/2011 
(100%)CONDITIONAL 1172/2286 (51%)
autotests.kconfig_compiler
FILES 25/26 (96%)CLASSES 25/26 (96%)LINE 293/303 
(97%)CONDITIONAL 126/248 (51%)
src.core
FILES 21/24 (88%)CLASSES 21/24 (88%)LINE 2253/3350 
(67%)CONDITIONAL 1287/2428 (53%)
src.gui
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 431/703 (61%)CONDITIONAL 
167/319 (52%)
src.kconf_update
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 420/588 (71%)CONDITIONAL 
268/469 (57%)
src.kconfig_compiler
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 1357/1572 
(86%)CONDITIONAL 957/1225 (78%)

Re: Shipping prison with next frameworks version

2016-12-02 Thread Heiko Becker 
Hi,

sorry for writing this mail shortly before the tagging of the next
Frameworks release, but I got sidetracked by other things.

On 09/30/16 09:42, David Faure wrote:
> On dimanche 18 septembre 2016 20:03:00 CEST Sune Vuorela wrote:
>> Other than asking sysadmin to move prison from kdesupport to
>> kdeframeworks, are there other bits I'm supposed to do?
>>
>> I *think* I have followed the checklists.
> 
> I see no .yaml file in g...@git.kde.org:prison branch master.

I've added one with
https://commits.kde.org/prison/1b72429bdd256711b1f430367408abe9ddee8186,
added a README.md and a .reviewboard file and adjusted the directory
structure according to Frameworks policies.

> I still see kdesupport/prison rather than frameworks/prison in 
> kde_projects.xml
> 
> It's also missing on https://build.kde.org/view/Frameworks%20kf5-qt5/

I filed a sysadmin ticket for this: https://phabricator.kde.org/T4801

> No autotests ?

I guess one would need something to read back the generated barcodes for
meaningful autotests.

As far as I can see and after looking at
https://community.kde.org/Frameworks/CreationGuidelines and
https://community.kde.org/Frameworks/Policies everything else is ready
for becoming a framework.

Note that I'm not the maintainer. I'm just tired of packaging snapshots
after rather silly version increments because it's already treated like
a framework.

Best regards,
Heiko

Re: Review Request 126226: kdetemplate_add_app_templates installs previews

2016-12-02 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126226/
---

(Updated Dec. 2, 2016, 12:13 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and Marco Martin.


Repository: extra-cmake-modules


Description
---

kapptemplate can't deal with templats without previews, so make sure we install 
the preview image.

Without this patch, the installed templates show up broken in kapptemplate. 
With it, they work as expected.

I'm assuming here that the preview has the baseName + .png, otherwise we'd have 
to read Icon field from the .kdevtemplate file, but that seems way too much 
hassle. The error message resulting from a wrong file name will show the 
expected filename, so it doesn't exactly hide the error.


Diffs
-

  kde-modules/KDETemplateMacro.cmake 796c3f1 

Diff: https://git.reviewboard.kde.org/r/126226/diff/


Testing
---

Installed templates/ from plasma-framework, this patch makes them work in 
kapptemplate.


Thanks,

Sebastian Kügler

[Differential] [Updated] D3568: Find the correct path to the cmake command

2016-12-02 Thread ltoscano (Luigi Toscano) 
ltoscano set the repository for this revision to R240 Extra CMake Modules.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  find-cmake-binary

REVISION DETAIL
  https://phabricator.kde.org/D3568

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: obogdan, kfunk, #frameworks, apol
Cc: kfunk

[Differential] [Commented On] D3568: Find the correct path to the cmake command

2016-12-02 Thread obogdan (Ovidiu-Florin BOGDAN) 
obogdan added a comment.


  Should I wait for more people to review this?

BRANCH
  find-cmake-binary

REVISION DETAIL
  https://phabricator.kde.org/D3568

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: obogdan, kfunk, #frameworks, apol
Cc: kfunk

[Differential] [Accepted] D3568: Find the correct path to the cmake command

2016-12-02 Thread apol (Aleix Pol Gonzalez) 
apol accepted this revision.
apol added a reviewer: apol.

BRANCH
  find-cmake-binary

REVISION DETAIL
  https://phabricator.kde.org/D3568

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: obogdan, kfunk, #frameworks, apol
Cc: kfunk

[Differential] [Requested Changes To] D2075: Fix bug in kfiledialog.cpp that causes crashing when native widgets are used.

2016-12-02 Thread kfunk (Kevin Funk) 
kfunk requested changes to this revision.
kfunk added a reviewer: kfunk.
kfunk added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kfiledialog.cpp:607
> +if (d->native) {
> +return;
> +}

Should we rather check for `!d->w` here and below? Would make more sense IMO.

REPOSITORY
  R239  KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D2075

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jonathans, #frameworks, dfaure, kfunk
Cc: kfunk, aacid

Re: Review Request 129598: fix build, needs QtDBus

2016-12-02 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129598/
---

(Updated Dec. 2, 2016, 11:09 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 04389b36653b2d0df8a3ac2fc62bafa1b86e by Sebastian 
Kügler to branch master.


Repository: frameworkintegration


Description
---

The new appstream kpackage handler needs to link Qt DBus, but the find package 
call is missing.


Diffs
-

  CMakeLists.txt e97e698 

Diff: https://git.reviewboard.kde.org/r/129598/diff/


Testing
---

Builds and works on my machine


Thanks,

Sebastian Kügler

[Differential] [Updated] D3568: Find the correct path to the cmake command

2016-12-02 Thread kfunk (Kevin Funk) 
kfunk edited reviewers, added: Frameworks; removed: Framework: Syntax 
Hightlighting.

BRANCH
  find-cmake-binary

REVISION DETAIL
  https://phabricator.kde.org/D3568

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: obogdan, kfunk, #frameworks
Cc: kfunk

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

2016-12-02 Thread Anthony Fieroni 


> On Dec. 1, 2016, 11:43 p.m., Albert Astals Cid wrote:
> > src/kstatusnotifieritem.cpp, line 972
> > 
> >
> > maybe move this to the else?
> 
> Anthony Fieroni wrote:
> NET::WMFrameExtents is not needed anymore.

info is used on 977 and 984 is two 'else' braches :)


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127216/#review101203
---


On Nov. 13, 2016, 7:17 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127216/
> ---
> 
> (Updated Nov. 13, 2016, 7:17 a.m.)
> 
> 
> Review request for KDE Frameworks, Martin Gräßlin and Martin Klapetek.
> 
> 
> Bugs: 356523
> https://bugs.kde.org/show_bug.cgi?id=356523
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> Store position of widget before hide it
> 
> 
> Diffs
> -
> 
>   src/kstatusnotifieritem.cpp 3eb39b2 
>   src/kstatusnotifieritemprivate_p.h 8fdfd4c 
> 
> Diff: https://git.reviewboard.kde.org/r/127216/diff/
> 
> 
> Testing
> ---
> 
> Tested on pixel ratio = 1 with Amarok, Kmail, Akregator, Kalarm, Ktimer
> Close with 'X' - restore in correct pos
> Hide by click at icon in systray - restore correct pos
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

2016-12-02 Thread Anthony Fieroni 


> On Dec. 1, 2016, 11:43 p.m., Albert Astals Cid wrote:
> > src/kstatusnotifieritem.cpp, line 972
> > 
> >
> > maybe move this to the else?

NET::WMFrameExtents is not needed anymore.


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127216/#review101203
---


On Nov. 13, 2016, 7:17 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127216/
> ---
> 
> (Updated Nov. 13, 2016, 7:17 a.m.)
> 
> 
> Review request for KDE Frameworks, Martin Gräßlin and Martin Klapetek.
> 
> 
> Bugs: 356523
> https://bugs.kde.org/show_bug.cgi?id=356523
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> Store position of widget before hide it
> 
> 
> Diffs
> -
> 
>   src/kstatusnotifieritem.cpp 3eb39b2 
>   src/kstatusnotifieritemprivate_p.h 8fdfd4c 
> 
> Diff: https://git.reviewboard.kde.org/r/127216/diff/
> 
> 
> Testing
> ---
> 
> Tested on pixel ratio = 1 with Amarok, Kmail, Akregator, Kalarm, Ktimer
> Close with 'X' - restore in correct pos
> Hide by click at icon in systray - restore correct pos
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>