[Differential] [Request, 204 lines] D4264: redesign android-file-transfer icon

[Alexey Varfolomeev]

varlesh created this revision.
varlesh added reviewers: andreask, Breeze.
varlesh set the repository for this revision to R266 Breeze Icons.
varlesh added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Compare:
  F2163528: Снимок экрана от 2017-01-24 11-38-39.png 

  SVG:
  F2163529: android-file-transfer.svg 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4264

AFFECTED FILES
  icons/apps/48/android-file-transfer.svg

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, andreask, #breeze
Cc: #frameworks

[Differential] [Updated, 286 lines] D4253: redesign gwenview icon

[Alexey Varfolomeev]

varlesh updated this revision to Diff 10479.
varlesh added a comment.


  version 2, diff updated

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4253?vs=10458=10479

REVISION DETAIL
  https://phabricator.kde.org/D4253

AFFECTED FILES
  icons/apps/48/gwenview.svg

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, #breeze, andreask
Cc: andreaska, #frameworks

[Differential] [Updated] D4262: redesign android-studio icon

[Alexey Varfolomeev]

varlesh updated the summary for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4262

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, andreask, #breeze
Cc: #frameworks

[Differential] [Request, 730 lines] D4262: redesign android-studio icon

[Alexey Varfolomeev]

varlesh created this revision.
varlesh added reviewers: andreask, Breeze.
varlesh set the repository for this revision to R266 Breeze Icons.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  - fix wrong size icon
  - fix colors & gradients
  - redesign style
  
  Compare:
  F2163505: Снимок экрана от 2017-01-24 11-04-36.png 

  SVG:
  F2163506: android-studio.svg 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4262

AFFECTED FILES
  icons/apps/48/android-studio.svg

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, andreask, #breeze
Cc: #frameworks

[Differential] [Request, 36 lines] D4261: redesign atom icon

[Alexey Varfolomeev]

varlesh created this revision.
varlesh added reviewers: andreask, Breeze.
varlesh set the repository for this revision to R266 Breeze Icons.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Compare:
  F2163472: Снимок экрана от 2017-01-24 10-10-28.png 

  SVG:
  F2163473: atom.svg 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4261

AFFECTED FILES
  icons/apps/48/atom.svg

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, andreask, #breeze
Cc: #frameworks

[Differential] [Request, 259 lines] D4259: fix alienarena icon

[Alexey Varfolomeev]

varlesh created this revision.
varlesh added reviewers: andreask, Breeze.
varlesh set the repository for this revision to R266 Breeze Icons.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  - reverse gradient
  - change objects
  - clear code
  - add shadow
  - pixel align
  
  Compare:
  F2163381: Снимок экрана от 2017-01-24 09-26-40.png 

  SVG:
  F2163382: alienarena.svg 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4259

AFFECTED FILES
  icons/apps/48/alienarena.svg

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, andreask, #breeze
Cc: #frameworks

[Differential] [Request, 167 lines] D4258: redesign gimp icon

[Alexey Varfolomeev]

varlesh created this revision.
varlesh added reviewers: andreask, Breeze.
varlesh set the repository for this revision to R266 Breeze Icons.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Papirus icon not a Breeze style.
  Compare:
  F2163367: Снимок экрана от 2017-01-24 09-12-36.png 

  SVG:
  F2163369: gimp.svg 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4258

AFFECTED FILES
  icons/apps/48/gimp.svg

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, andreask, #breeze
Cc: #frameworks

[Differential] [Commented On] D4253: redesign gwenview icon

[Alexey Varfolomeev]

varlesh added a comment.


  For compare:
  F2163339: Снимок экрана от 2017-01-24 08-33-37.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4253

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, #breeze, andreask
Cc: andreaska, #frameworks

[Differential] [Commented On] D4253: redesign gwenview icon

[Alexey Varfolomeev]

varlesh added a comment.


  Ok, but maybe this?
  New:
  F2163321: Снимок экрана от 2017-01-24 08-26-22.png 

  SVG:
  F2163329: gwenview.svg 
  Oxygen:
  F2163324: gwenview.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4253

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, #breeze, andreask
Cc: andreaska, #frameworks

[Differential] [Commented On] D4234: Change algorithm for autobrace.

[Sven Brauch]

brauch added a comment.


  Let's discuss an alternative suggestion maybe: how about it just keeps track 
of the parenthesis balancing and removes them if doing so would make it 
unbalanced? It could stop counting at the next folding region, and exclude 
spellchecked parts.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4234

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: cactus, #ktexteditor
Cc: brauch, cullmann, kwrite-devel, #frameworks

[Differential] [Commented On] D4253: redesign gwenview icon

[Andreas Kainz]

andreaska added a comment.


  first of all, thanks for starting the discussion I think also that the 
gwenview icon could get an update, but I miss something in the update in 
addition the dark eye background look to hard.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4253

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, #breeze, andreask
Cc: andreaska, #frameworks

Re: Review Request 129315: Don't install plasmoid desktop files as services

[Aleix Pol Gonzalez]

> On Jan. 23, 2017, 8:10 p.m., Albert Astals Cid wrote:
> > Any reason this has not been committed?

Yes, IIRC the KService usage in KRunner was reintroduced. We need to retest the 
patch now.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129315/#review102223
---


On Nov. 3, 2016, 2:06 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129315/
> ---
> 
> (Updated Nov. 3, 2016, 2:06 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> It shouldn't have an impact anymore.
> 
> 
> Diffs
> -
> 
>   KF5PlasmaMacros.cmake 5827854 
> 
> Diff: https://git.reviewboard.kde.org/r/129315/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

[Differential] [Accepted] D4257: [PlasmaComponents Menu] Add maximumWidth property

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4257

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, hpereiradacosta, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Accepted] D4252: fix brackets icon

[Andreas Kainz]

andreaska accepted this revision.
andreaska added a reviewer: andreaska.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4252

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, #breeze, andreaska
Cc: guoyunhe, #frameworks

[Differential] [Commented On] D4252: fix brackets icon

[Andreas Kainz]

andreaska added a comment.


  I submitt the icon thanks

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4252

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, #breeze, andreaska
Cc: guoyunhe, #frameworks

[Differential] [Accepted] D4251: Redesign aptana icon

[Andreas Kainz]

andreaska accepted this revision.
andreaska added a reviewer: andreaska.
andreaska added a comment.
This revision is now accepted and ready to land.


  submitted

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4251

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, #breeze, andreaska
Cc: andreaska, #frameworks

[Differential] [Request, 62 lines] D4257: [PlasmaComponents Menu] Add maximumWidth property

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hpereiradacosta.
broulik set the repository for this revision to R242 Plasma Framework (Library).
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  This allows to limit the maximum width of a menu. It can be useful for 
instance in task manager where long file names for recent documents will result 
in gigantic menus.
  
  The property has a RESET method (which is called if you assign "undefined") 
which will set it back to QWIDGETSIZE_MAX to remove the size restriction.

TEST PLAN
  Comes with a manual test. The menu itself is still placed as though it 
occupied the full width. :(
  
  F2163013: Screenshot_20170123_230412.png 

  
  Hugo, any idea what's up with Breeze theme not eliding the menu items? This 
is with both device pixel ratio 1 (plasmashell) and 2 (in the screenshot). I 
recall there being some Qt recently having been fixed but I'm not sure, might 
as well be a Breeze bug, though it also happens with Fusion.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4257

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qmenu.cpp
  src/declarativeimports/plasmacomponents/qmenu.h
  tests/components/menu.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hpereiradacosta
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 398 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/398/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 23 Jan 2017 21:18:14 +
Build duration: 15 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 
53 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 274/343 (80%)CLASSES 274/343 (80%)LINE 29547/51606 
(57%)CONDITIONAL 16222/38743 (42%)

By packages
  
autotests
FILES 67/67 (100%)CLASSES 67/67 (100%)LINE 7918/8245 
(96%)CONDITIONAL 4428/8664 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 7892/14179 
(56%)CONDITIONAL 4337/9259 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3449/7559 
(46%)CONDITIONAL 1281/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 
330/749 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1755/3780 
(46%)CONDITIONAL 1252/3460 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.trash
FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 715/1139 
(63%)CONDITIONAL 411/833 (49%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3631/11016 
(33%)CONDITIONAL 1746/7096 (25%)

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 398 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/398/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 23 Jan 2017 21:18:14 +
Build duration: 15 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 
53 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 274/343 (80%)CLASSES 274/343 (80%)LINE 29547/51606 
(57%)CONDITIONAL 16222/38743 (42%)

By packages
  
autotests
FILES 67/67 (100%)CLASSES 67/67 (100%)LINE 7918/8245 
(96%)CONDITIONAL 4428/8664 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 7892/14179 
(56%)CONDITIONAL 4337/9259 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3449/7559 
(46%)CONDITIONAL 1281/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 
330/749 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1755/3780 
(46%)CONDITIONAL 1252/3460 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.trash
FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 715/1139 
(63%)CONDITIONAL 411/833 (49%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3631/11016 
(33%)CONDITIONAL 1746/7096 (25%)

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 229 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/229/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 23 Jan 2017 20:04:47 +
Build duration: 4 min 15 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 
40 test(s)Failed: TestSuite.kdatetimetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/7 (57%)FILES 160/268 (60%)CLASSES 160/268 (60%)LINE 21684/42749 
(51%)CONDITIONAL 14659/36439 (40%)

By packages
  
autotests
FILES 64/64 (100%)CLASSES 64/64 (100%)LINE 11530/11783 
(98%)CONDITIONAL 8481/16824 (50%)
src.kdecore
FILES 74/93 (80%)CLASSES 74/93 (80%)LINE 9199/16821 
(55%)CONDITIONAL 5715/11771 (49%)
src.kdeui
FILES 18/70 (26%)CLASSES 18/70 (26%)LINE 939/9816 
(10%)CONDITIONAL 460/5673 (8%)
src.kio
FILES 4/27 (15%)CLASSES 4/27 (15%)LINE 16/2396 (1%)CONDITIONAL 
3/1226 (0%)
src.kparts
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/26 (0%)CONDITIONAL 0/14 
(0%)
src.kssl
FILES 0/8 (0%)CLASSES 0/8 (0%)LINE 0/1708 (0%)CONDITIONAL 0/836 
(0%)
src.solid
FILES 0/5 (0%)CLASSES 0/5 (0%)LINE 0/199 (0%)CONDITIONAL 0/95 
(0%)

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 225 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/225/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 23 Jan 2017 19:52:22 +
Build duration: 6 min 27 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5488/8008 
(69%)CONDITIONAL 2976/6178 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1464/1554 
(94%)CONDITIONAL 895/1792 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1765/3045 
(58%)CONDITIONAL 763/1892 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2043/2796 
(73%)CONDITIONAL 1233/2066 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 221 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/221/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 23 Jan 2017 19:35:40 +
Build duration: 1 min 41 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5489/8008 
(69%)CONDITIONAL 2974/6178 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1464/1554 
(94%)CONDITIONAL 892/1792 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1766/3045 
(58%)CONDITIONAL 764/1892 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2043/2796 
(73%)CONDITIONAL 1233/2066 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 221 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/221/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 23 Jan 2017 19:35:40 +
Build duration: 1 min 41 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5489/8008 
(69%)CONDITIONAL 2974/6178 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1464/1554 
(94%)CONDITIONAL 892/1792 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1766/3045 
(58%)CONDITIONAL 764/1892 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2043/2796 
(73%)CONDITIONAL 1233/2066 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: threadweaver master stable-kf5-qt5 » Linux,gcc - Build # 121 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/121/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 23 Jan 2017 19:08:54 +
Build duration: 8 min 15 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 8 
test(s)Failed: TestSuite.ThreadWeaverJobTests

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 55/69 (80%)CLASSES 55/69 (80%)LINE 1482/1896 
(78%)CONDITIONAL 1155/2618 (44%)

By packages
  
autotests
FILES 11/11 (100%)CLASSES 11/11 (100%)LINE 413/413 
(100%)CONDITIONAL 493/962 (51%)
src
FILES 44/58 (76%)CLASSES 44/58 (76%)LINE 1069/1483 
(72%)CONDITIONAL 662/1656 (40%)

Re: Review Request 129083: [KIconLoader] Take into account devicePixelRatio for overlays

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129083/#review102224
---



Patch doesn't apply anymore

- Albert Astals Cid


On Oct. 6, 2016, 8 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129083/
> ---
> 
> (Updated Oct. 6, 2016, 8 p.m.)
> 
> 
> Review request for Dolphin, KDE Frameworks and David Edmundson.
> 
> 
> Bugs: 369640
> https://bugs.kde.org/show_bug.cgi?id=369640
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> ---
> 
> Keeps them from being painted outside view and scales them with the image 
> they're supposed to be painted on.
> 
> 
> Diffs
> -
> 
>   src/kiconloader.cpp 5315ea4 
> 
> Diff: https://git.reviewboard.kde.org/r/129083/diff/
> 
> 
> Testing
> ---
> 
> Ran dolphin with device pixel ratio 2, got my symolic link icon again.
> Ran it with device pixel ratio 1, looked as it did before.
> 
> (couldn't figure out why the VCS icons don't show up though)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

Re: Review Request 129315: Don't install plasmoid desktop files as services

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129315/#review102223
---



Any reason this has not been committed?

- Albert Astals Cid


On Nov. 3, 2016, 1:06 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129315/
> ---
> 
> (Updated Nov. 3, 2016, 1:06 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> It shouldn't have an impact anymore.
> 
> 
> Diffs
> -
> 
>   KF5PlasmaMacros.cmake 5827854 
> 
> Diff: https://git.reviewboard.kde.org/r/129315/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

[Differential] [Updated] D4253: redesign gwenview icon

[Martin Klapetek]

mck182 added a reviewer: andreask.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4253

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, #breeze, andreask
Cc: #frameworks

Re: Review Request 129724: [frameworks] Enable -Wsuggest-override for g++ >= 5.0.0

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129724/
---

(Updated Jan. 23, 2017, 7:04 p.m.)


Status
--

This change has been marked as submitted.


Review request for Build System, KDE Frameworks and Stephen Kelly.


Changes
---

Submitted with commit faeb56f8137d738d1dfbc1fcfbbacd1e8caeb6f0 by Albert Astals 
Cid to branch master.


Repository: extra-cmake-modules


Description
---

Gives a nice warning about something that should be marked as override but isn't


Diffs
-

  kde-modules/KDEFrameworkCompilerSettings.cmake 038ddc3 

Diff: https://git.reviewboard.kde.org/r/129724/diff/


Testing
---


Thanks,

Albert Astals Cid

Re: Review Request 129859: Add benchmark for KTextToHTML::convertToHtml

[Milian Wolff]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129859/
---

(Updated Jan. 23, 2017, 7:03 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, David Faure, Daniel Vrátil, and Laurent 
Montel.


Repository: kcoreaddons


Description
---

On my machine, the initial output is as follows for RelWithDebInfo:

PASS   : KTextToHTMLTest::benchHtmlConvert(plain)
RESULT : KTextToHTMLTest::benchHtmlConvert():"plain":
 4.0 msecs per iteration (total: 65, iterations: 16)
PASS   : KTextToHTMLTest::benchHtmlConvert(preserve-spaces)
RESULT : KTextToHTMLTest::benchHtmlConvert():"preserve-spaces":
 3.4 msecs per iteration (total: 55, iterations: 16)
PASS   : KTextToHTMLTest::benchHtmlConvert(highlight-text)
RESULT : KTextToHTMLTest::benchHtmlConvert():"highlight-text":
 4.2 msecs per iteration (total: 68, iterations: 16)
PASS   : KTextToHTMLTest::benchHtmlConvert(replace-smileys)
RESULT : KTextToHTMLTest::benchHtmlConvert():"replace-smileys":
 4.1 msecs per iteration (total: 66, iterations: 16)
PASS   : KTextToHTMLTest::benchHtmlConvert(preserve-spaces+highlight-text)
RESULT : KTextToHTMLTest::benchHtmlConvert():"preserve-spaces+highlight-text":
 3.6 msecs per iteration (total: 58, iterations: 16)
PASS   : 
KTextToHTMLTest::benchHtmlConvert(preserve-spaces+highlight-text+replace-smileys)
RESULT : 
KTextToHTMLTest::benchHtmlConvert():"preserve-spaces+highlight-text+replace-smileys":
 3.5 msecs per iteration (total: 57, iterations: 16)

Replace heap-allocated list of chars with QStringLiteral

The main bottleneck in the benchmark for KTextToHTML was actually
constructing the temporary list of word-boundaries. Instead of
doing that all the time, use a QStringLiteral-constructed static
QString.

This improves the benchmarks by more than ~4x on my machine,
all compiled in RelWithDebInfo:

PASS   : KTextToHTMLTest::benchHtmlConvert(plain)
RESULT : KTextToHTMLTest::benchHtmlConvert():"plain":
 0.75 msecs per iteration (total: 96, iterations: 128)
PASS   : KTextToHTMLTest::benchHtmlConvert(preserve-spaces)
RESULT : KTextToHTMLTest::benchHtmlConvert():"preserve-spaces":
 0.71 msecs per iteration (total: 91, iterations: 128)
PASS   : KTextToHTMLTest::benchHtmlConvert(highlight-text)
RESULT : KTextToHTMLTest::benchHtmlConvert():"highlight-text":
 0.89 msecs per iteration (total: 57, iterations: 64)
PASS   : KTextToHTMLTest::benchHtmlConvert(replace-smileys)
RESULT : KTextToHTMLTest::benchHtmlConvert():"replace-smileys":
 0.75 msecs per iteration (total: 96, iterations: 128)
PASS   : KTextToHTMLTest::benchHtmlConvert(preserve-spaces+highlight-text)
RESULT : KTextToHTMLTest::benchHtmlConvert():"preserve-spaces+highlight-text":
 0.79 msecs per iteration (total: 51, iterations: 64)
PASS   : 
KTextToHTMLTest::benchHtmlConvert(preserve-spaces+highlight-text+replace-smileys)
RESULT : 
KTextToHTMLTest::benchHtmlConvert():"preserve-spaces+highlight-text+replace-smileys":
 0.79 msecs per iteration (total: 51, iterations: 64)

Remove temporary string allocations

Instead of calling .mid() to compare to a QLatin1String,
call .midRef() as that won't allocate.

Improves the performance of the unit test by ~2x on my
machine when compiling in RelWithDebInfo:

PASS   : KTextToHTMLTest::benchHtmlConvert(plain)
RESULT : KTextToHTMLTest::benchHtmlConvert():"plain":
 0.40 msecs per iteration (total: 52, iterations: 128)
PASS   : KTextToHTMLTest::benchHtmlConvert(preserve-spaces)
RESULT : KTextToHTMLTest::benchHtmlConvert():"preserve-spaces":
 0.36 msecs per iteration (total: 93, iterations: 256)
PASS   : KTextToHTMLTest::benchHtmlConvert(highlight-text)
RESULT : KTextToHTMLTest::benchHtmlConvert():"highlight-text":
 0.51 msecs per iteration (total: 66, iterations: 128)
PASS   : KTextToHTMLTest::benchHtmlConvert(replace-smileys)
RESULT : KTextToHTMLTest::benchHtmlConvert():"replace-smileys":
 0.41 msecs per iteration (total: 53, iterations: 128)
PASS   : KTextToHTMLTest::benchHtmlConvert(preserve-spaces+highlight-text)
RESULT : KTextToHTMLTest::benchHtmlConvert():"preserve-spaces+highlight-text":
 0.44 msecs per iteration (total: 57, iterations: 128)
PASS   : 
KTextToHTMLTest::benchHtmlConvert(preserve-spaces+highlight-text+replace-smileys)
RESULT : 
KTextToHTMLTest::benchHtmlConvert():"preserve-spaces+highlight-text+replace-smileys":
 0.46 msecs per iteration (total: 59, iterations: 128)

Mark some methods as const


Diffs
-

  autotests/ktexttohtmltest.h 3aaa5810d84ecb05b68b8a20b94bd281cfe3a6ba 
  autotests/ktexttohtmltest.cpp fa8bbf261acd7b77ac502f14ca7820d3aeed7b55 
  src/lib/text/ktexttohtml.cpp 9b15cb27c7b9998971e2efbc198c3f840bf34959 
  src/lib/text/ktexttohtml_p.h 5e343485b26eb03ce2805f3a9f178a395f9b46a3 

Diff: https://git.reviewboard.kde.org/r/129859/diff/

[Differential] [Closed] D4203: Fix appstream name/summary ends with '.' warning

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R290:3b0ee7dcf3fd: Fix appstream name/summary ends with '.' 
warning (authored by apol).

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4203?vs=10358=10464

REVISION DETAIL
  https://phabricator.kde.org/D4203

AFFECTED FILES
  src/kpackagetool/kpackagetool.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, davidedmundson, mart
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated, 285 lines] D4254: add new test for scalable exposure

[Harald Sitter]

sitter updated this revision to Diff 10460.
sitter added a comment.


  warning--
  qdebug the limited testing of the test

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4254?vs=10459=10460

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4254

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/scalabletest.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter
Cc: #frameworks

[Differential] [Request, 286 lines] D4254: add new test for scalable exposure

[Harald Sitter]

sitter created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  the icon themes use SVG but do not want the same icon to be used for
  small resolutions as to not have high-detail icons at super small sizes so
  they become a mush of colors.
  on the other hand however they are SVG and thus scalable and so higher
  icon resolutions are not specifically made but rather expected to scale up.
  
  the scaling up portion of the equation requires icon files to actually
  be available in a directory marked scalable. this is easy to get wrong and
  thus prevent higher resolutions from being available when doing a strict
  lookup as for example done by appstream.
  
  e.g. if apps/64 is marked scalable but doesn't container a 'klipper' icon,
  if one then proceeds to strictly lookup a 192x192 version of 'klipper' one
  would come back empty handed.
  
  to prevent this sort of issue from appearing in the future there are now
  two preliminary autotests to ensure icons are available in a scalable
  directory.
  
  - test_scalable asserts that all "fixed" icons (i.e. icons in a fixed size 
directory) are in fact also available as scalable (currently disregards size 
constraints involved)
  - test_scalableDuplicates asserts that each scalable icon only appears in one 
scalable directory. specifically if more than one scalable variant is available 
the icon theme spec does not specify that the closest match is used, but among 
scalable versions all are considered equal so the first wins. this is a problem 
if apps/48/klipper.svg and apps/32/klipper.svg exist and both are marked 
scalable but they have different visuals. in one application the 32 version 
might get used and in another the 48 version is used. this tests prevents this 
by enforcing the equality by means of not allowing multiple scalable variants 
(again, not taking size constraints into consideration)

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4254

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/scalabletest.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter
Cc: #frameworks

[Differential] [Request, 269 lines] D4253: redesign gwenview icon

[Alexey Varfolomeev]

varlesh created this revision.
varlesh added a reviewer: Breeze.
varlesh set the repository for this revision to R266 Breeze Icons.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  - colorize
  - add shadows
  - pixelated align
  - change form
  - clear code
  
  Compare:
  F2162670: Снимок экрана от 2017-01-23 19-35-53.png 

  Zoomed:
  F2162672: Снимок экрана от 2017-01-23 19-37-02.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4253

AFFECTED FILES
  icons/apps/48/gwenview.svg

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, #breeze
Cc: #frameworks

[Differential] [Commented On] D4201: Make it possible to lower KCrash to tier 1

[Aleix Pol Gonzalez]

apol added a comment.


  Please disregard the last message, I didn't mean to send that, I wrote it 
some days ago.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D4201

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, dfaure
Cc: shumski, anthonyfieroni, graesslin

[Differential] [Commented On] D4201: Make it possible to lower KCrash to tier 1

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> dfaure wrote in kcrash.cpp:437
> You can't use QVector here. We're crashing, likely due to corrupted memory, 
> the whole point of this code is to NOT do any memory allocation. You should 
> revert to const char*[], or use something that always allocates on the stack 
> (e.g. QVarLengthArray, if preallocated to be big enough).

Yes... that makes sense.

But then possibly worse than that is the use of QMap.

Will rethink the approach.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D4201

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, dfaure
Cc: shumski, anthonyfieroni, graesslin

[Differential] [Changed Subscribers] D4214: Make sure we display enabled ListItem on hover

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> apol wrote in ListItem.qml:97
> Yes, I meant to put `itemMouse.pressed`. I wonder why QML doesn't complain...
> 
> It's barely a behavioral change, in fact it's what it was supposed to happen 
> in the first place: give feedback on hover when the item is clickable.
> Note that at the moment we're dimming the opacity for the invisible 
> background we have.

when the item contains the mouse the prefix shouldn't be "pressed"
I'm fine with using the highlight item and just dropping the opacity change

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4214

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma
Cc: mart, davidedmundson, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D4203: Fix appstream name/summary ends with '.' warning

[Marco Martin]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R290 KPackage

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4203

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, davidedmundson, mart
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D4252: fix brackets icon

[Yunhe Guo]

guoyunhe added a comment.


  Like this

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4252

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, #breeze
Cc: guoyunhe, #frameworks

[Differential] [Updated] D4252: fix brackets icon

[Alexey Varfolomeev]

varlesh updated the summary for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4252

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, #breeze
Cc: #frameworks

[Differential] [Request, 1,206 lines] D4252: fix brackets icon

[Alexey Varfolomeev]

varlesh created this revision.
varlesh added a reviewer: Breeze.
varlesh set the repository for this revision to R266 Breeze Icons.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  F2162612: brackets.svg 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4252

AFFECTED FILES
  icons/apps/48/brackets.svg

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, #breeze
Cc: #frameworks

[Differential] [Closed] D4227: Don't block when running the post-install command

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:3178240748c6: Don't block when running the post-install 
command (authored by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D4227?vs=10396=10455#toc

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4227?vs=10396=10455

REVISION DETAIL
  https://phabricator.kde.org/D4227

AFFECTED FILES
  src/core/installation.cpp
  src/core/installation.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, leinir, whiting, mart
Cc: broulik

[Differential] [Updated] D4227: Don't block when running the post-install command

[Aleix Pol Gonzalez]

apol marked an inline comment as done.
apol added inline comments.

INLINE COMMENTS

> broulik wrote in installation.cpp:351
> I had to look multiple times to find what "f" is, can you make the name a bit 
> more descriptive.

Good point. Will address this as I commit it.

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4227

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, leinir, whiting, mart
Cc: broulik

[Differential] [Updated] D4251: Redesign aptana icon

[Alexey Varfolomeev]

varlesh updated the summary for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4251

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, #breeze
Cc: #frameworks

[Differential] [Updated] D4251: Redesign aptana icon

[Alexey Varfolomeev]

varlesh added a reviewer: Breeze.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4251

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, #breeze
Cc: #frameworks

[Differential] [Updated] D4251: Redesign aptana icon

[Alexey Varfolomeev]

varlesh updated the summary for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4251

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh
Cc: #frameworks

[Differential] [Request, 203 lines] D4251: Redesign aptana icon

[Alexey Varfolomeev]

varlesh created this revision.
varlesh set the repository for this revision to R266 Breeze Icons.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4251

AFFECTED FILES
  icons/apps/48/aptana.svg

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh
Cc: #frameworks

[Differential] [Changed Subscribers] D4227: Don't block when running the post-install command

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> installation.cpp:351
> +QProcess* p = runPostInstallationCommand(installedFiles.size() == 1 
> ? installedFiles.first() : targetPath);
> +connect(p, static_cast(::finished), 
> this, f);
> +} else {

I had to look multiple times to find what "f" is, can you make the name a bit 
more descriptive.

> installation.cpp:592
> +}
> +sender()->deleteLater();
> +});

You could just capture the QProcess* into the lambda

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4227

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, leinir, whiting, mart
Cc: broulik

[Differential] [Accepted] D4227: Don't block when running the post-install command

[Marco Martin]

mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> apol wrote in installation.h:137
> According to our BIC documentation: 
> https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B
> 
> We can "remove private non-virtual functions if they are not called by any 
> inline functions (and have never been)."

ha, i assumed also removing a private function was not ok..
ship it then

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4227

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, leinir, whiting, mart

[Differential] [Updated] D4227: Don't block when running the post-install command

[Aleix Pol Gonzalez]

apol marked an inline comment as done.
apol added inline comments.

INLINE COMMENTS

> mart wrote in installation.h:137
> BIC
> even if the api of this file is beyond terrible, unfortunately it's exported, 
> so no binary incompatible changes should occur

According to our BIC documentation: 
https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B

We can "remove private non-virtual functions if they are not called by any 
inline functions (and have never been)."

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D4227

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, leinir, whiting, mart

[Differential] [Requested Changes To] D4227: Don't block when running the post-install command

[Marco Martin]

mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> installation.h:137
>  QStringList installDownloadedFileAndUncompress(const 
> KNSCore::EntryInternal  , const QString , const QString 
> installdir);
> -void runPostInstallationCommand(const QString );
> +QProcess* runPostInstallationCommand(const QString );
>  

BIC
even if the api of this file is beyond terrible, unfortunately it's exported, 
so no binary incompatible changes should occur

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D4227

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, leinir, whiting, mart

[Differential] [Closed] D4226: [KNS] Take into account the distribution type

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:d283d9f951fb: [KNS] Take into account the distribution 
type (authored by apol).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4226?vs=10394=10449

REVISION DETAIL
  https://phabricator.kde.org/D4226

AFFECTED FILES
  src/ui/itemsviewdelegate.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, whiting, leinir

[Differential] [Accepted] D4226: [KNS] Take into account the distribution type

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  Yup, this is fairly clearly what this is really supposed to be doing...

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4226

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, whiting, leinir

[Differential] [Commented On] D4190: Update file type on save only if path changes

[Mikko Perttunen]

mperttunen added a comment.


  Good point, I missed that. I'll post a new revision once I have the chance.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4190

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mperttunen, #ktexteditor
Cc: cullmann, kwrite-devel, #frameworks