D5056: [KCModuleProxy] Remove dead code

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  I don't know anything about this code, but if it's dead, it's dead.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D5056

To: broulik, dfaure
Cc: ltoscano, #frameworks

Re: Test failures with networkmanager-qt

[Jan Grulich]

Hi,

I didn't say you shouldn't investigate the cause. Could you please run the 
test with "-v2 -vs" parameters? 

Jan

On úterý 28. března 2017 11:43:06 CEST Hartmut Goebel wrote:
> Am 28.03.2017 um 08:10 schrieb Jan Grulich:
> > I can't think of any reason why the test fails for you. Looking to the git
> > log the only relevant change is fixed uninitialized state variable in
> > ActiveConnection, which may affect ActiveConnection::stateChanged()
> > signal.
> 
> So you suggest to not try to find the cause but simply ignore this failure?
> 
> Which versions are you referring to in "the only relevant change". Guix
> is currently lacking behind and still has 5.28, which we updated from
> 5.27 (which passed tests).
> 
> Between 5.27 and 5.28 here is one change that might be relevant: "Fix
> unit tests" [1].
> 
> [1]
>  5286bd401f40634ce6b>

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 625 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/625/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 29 Mar 2017 02:27:24 +
Build duration: 8 min 6 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 67 test(s), Skipped: 0 test(s), Total: 
67 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 23/27 (85%)FILES 296/330 (90%)CLASSES 296/330 (90%)LINE 33536/49430 
(68%)CONDITIONAL 17043/32953 (52%)

By packages
  
autotests.src
FILES 49/49 (100%)CLASSES 49/49 (100%)LINE 4276/4589 
(93%)CONDITIONAL 2023/4108 (49%)
autotests.src.vimode
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 5525/5569 
(99%)CONDITIONAL 897/1658 (54%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1618/1771 
(91%)CONDITIONAL 1256/1630 (77%)
src.completion
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1754/3102 
(57%)CONDITIONAL 1206/2798 (43%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 184/464 (40%)CONDITIONAL 
79/354 (22%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/875 (0%)CONDITIONAL 0/258 
(0%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1873/3225 
(58%)CONDITIONAL 1573/3238 (49%)
src.export
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 106/125 (85%)CONDITIONAL 
106/152 (70%)
src.include.ktexteditor
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 205/244 
(84%)CONDITIONAL 144/228 (63%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 172/325 (53%)CONDITIONAL 
40/89 (45%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 165/427 (39%)CONDITIONAL 
99/265 (37%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/885 (0%)CONDITIONAL 0/294 
(0%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 912/1217 
(75%)CONDITIONAL 620/932 (67%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 
7/697 (1%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 700/1055 
(66%)CONDITIONAL 295/556 (53%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 1029/1404 
(73%)CONDITIONAL 576/913 (63%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 375/1336 (28%)CONDITIONAL 
207/820 (25%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 123/373 (33%)CONDITIONAL 
60/203 (30%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1620/2077 
(78%)CONDITIONAL 1037/1708 (61%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 671/772 (87%)CONDITIONAL 
321/448 (72%)
src.utils
FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2621/3927 
(67%)CONDITIONAL 1368/2728 (50%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/668 (0%)CONDITIONAL 0/170 
(0%)
src.view
FILES 17/19 (89%)CLASSES 17/19 (89%)LINE 3554/6333 
(56%)CONDITIONAL 1625/3813 (43%)
src.vimode
FILES 34/34 (100%)CLASSES 34/34 (100%)LINE 1876/2340 
(80%)CONDITIONAL 1028/1751 (59%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/134 (0%)CONDITIONAL 0/90 
(0%)
src.vimode.emulatedcommandbar
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 903/915 
(99%)CONDITIONAL 616/682 (90%)
src.vimode.modes
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3253/3740 
(87%)CONDITIONAL 1860/2370 (78%)

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 625 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/625/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 29 Mar 2017 02:27:24 +
Build duration: 8 min 6 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 67 test(s), Skipped: 0 test(s), Total: 
67 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 23/27 (85%)FILES 296/330 (90%)CLASSES 296/330 (90%)LINE 33536/49430 
(68%)CONDITIONAL 17043/32953 (52%)

By packages
  
autotests.src
FILES 49/49 (100%)CLASSES 49/49 (100%)LINE 4276/4589 
(93%)CONDITIONAL 2023/4108 (49%)
autotests.src.vimode
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 5525/5569 
(99%)CONDITIONAL 897/1658 (54%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1618/1771 
(91%)CONDITIONAL 1256/1630 (77%)
src.completion
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1754/3102 
(57%)CONDITIONAL 1206/2798 (43%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 184/464 (40%)CONDITIONAL 
79/354 (22%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/875 (0%)CONDITIONAL 0/258 
(0%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1873/3225 
(58%)CONDITIONAL 1573/3238 (49%)
src.export
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 106/125 (85%)CONDITIONAL 
106/152 (70%)
src.include.ktexteditor
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 205/244 
(84%)CONDITIONAL 144/228 (63%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 172/325 (53%)CONDITIONAL 
40/89 (45%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 165/427 (39%)CONDITIONAL 
99/265 (37%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/885 (0%)CONDITIONAL 0/294 
(0%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 912/1217 
(75%)CONDITIONAL 620/932 (67%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 
7/697 (1%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 700/1055 
(66%)CONDITIONAL 295/556 (53%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 1029/1404 
(73%)CONDITIONAL 576/913 (63%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 375/1336 (28%)CONDITIONAL 
207/820 (25%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 123/373 (33%)CONDITIONAL 
60/203 (30%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1620/2077 
(78%)CONDITIONAL 1037/1708 (61%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 671/772 (87%)CONDITIONAL 
321/448 (72%)
src.utils
FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2621/3927 
(67%)CONDITIONAL 1368/2728 (50%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/668 (0%)CONDITIONAL 0/170 
(0%)
src.view
FILES 17/19 (89%)CLASSES 17/19 (89%)LINE 3554/6333 
(56%)CONDITIONAL 1625/3813 (43%)
src.vimode
FILES 34/34 (100%)CLASSES 34/34 (100%)LINE 1876/2340 
(80%)CONDITIONAL 1028/1751 (59%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/134 (0%)CONDITIONAL 0/90 
(0%)
src.vimode.emulatedcommandbar
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 903/915 
(99%)CONDITIONAL 616/682 (90%)
src.vimode.modes
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3253/3740 
(87%)CONDITIONAL 1860/2370 (78%)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 489 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/489/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 29 Mar 2017 01:58:10 +
Build duration: 20 min

CHANGE SET
Revision a097bf50e6b88a8dcabfc16320c6d86f2de3733f by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit src/kcms/kio/smb.desktop
  change: edit src/kcms/kio/useragent.desktop
  change: edit src/kcms/kio/uasproviders/chrome570oncurrent.desktop
  change: edit src/kcms/kio/uasproviders/firefox520oncurrent.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 
53 test(s)Failed: TestSuite.kiocore-threadtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 22/22 (100%)FILES 274/343 (80%)CLASSES 274/343 (80%)LINE 29976/51984 
(58%)CONDITIONAL 16413/39029 (42%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7933/8253 
(96%)CONDITIONAL 4431/8672 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8134/14183 
(57%)CONDITIONAL 4452/9267 (48%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3465/7561 
(46%)CONDITIONAL 1294/4381 (30%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 
330/749 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1759/3780 
(47%)CONDITIONAL 1266/3460 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.remote
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 70/258 (27%)CONDITIONAL 
14/200 (7%)
src.ioslaves.trash
FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 737/1173 
(63%)CONDITIONAL 420/851 (49%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 707/785 (90%)CONDITIONAL 
461/970 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3670/11067 
(33%)CONDITIONAL 1755/7114 (25%)

D5233: Fix build with Qt 5.9

[Aleix Pol Gonzalez]

apol created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  kactivities-stats/tests/model/modeltest.cpp:455: undefined reference to `bool 
QTest::qCompare(int const&, unsigned int const&, char 
const*, char const*, char const*, int)'

REPOSITORY
  R159 KActivities Statistics

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5233

AFFECTED FILES
  tests/model/modeltest.cpp

To: apol, #frameworks, ivan

D5231: Fix build with Qt branch 5.9

[Aleix Pol Gonzalez]

apol created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  kitemmodels/autotests/proxymodeltestsuite/modeltest.cpp:464: undefined 
reference to `bool QTest::qCompare(int const&, unsigned int 
const&, char const*, char const*, char const*, int)'

REPOSITORY
  R275 KItemModels

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5231

AFFECTED FILES
  autotests/proxymodeltestsuite/modeltest.cpp

To: apol, #frameworks

D4847: KAuth integration in document saving

[Martin Kostolný]

martinkostolny marked 3 inline comments as done.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4847

To: martinkostolny, dhaumann, #ktexteditor
Cc: apol, dfaure, anthonyfieroni, cullmann, ltoscano, dhaumann, graesslin, 
davidedmundson, palant, kwrite-devel, #frameworks, head7, kfunk, sars

D4847: KAuth integration in document saving

[Martin Kostolný]

martinkostolny updated this revision to Diff 12941.
martinkostolny added a comment.


  Updating diff with refinements based on David's insights, thanks David!
  
  Regarding static slot, it was quite convenient to call it statically in unit 
test mode and it works. So I left it there like this. I have no problems making 
the slot non-static if necessary.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4847?vs=12309&id=12941

REVISION DETAIL
  https://phabricator.kde.org/D4847

AFFECTED FILES
  autotests/src/katetextbuffertest.cpp
  autotests/src/katetextbuffertest.h
  src/CMakeLists.txt
  src/buffer/katesecuretextbuffer.cpp
  src/buffer/katesecuretextbuffer_p.h
  src/buffer/katetextbuffer.cpp
  src/buffer/katetextbuffer.h
  src/buffer/org.kde.ktexteditor.katetextbuffer.actions

To: martinkostolny, dhaumann, #ktexteditor
Cc: apol, dfaure, anthonyfieroni, cullmann, ltoscano, dhaumann, graesslin, 
davidedmundson, palant, kwrite-devel, #frameworks, head7, kfunk, sars

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

[Elvis Angelaccio]

> On March 22, 2017, 10:08 a.m., Elvis Angelaccio wrote:
> > src/ioslaves/file/kauth/file.actions, lines 1-5
> > 
> >
> > I don't see the advantage of using a single kauth action. This way you 
> > are generating only one "generic" polkit action that you can either enable 
> > or disable. Instead if we used one polkit action per operation (del, rmdir, 
> > etc.) we could allow a more fine-grained control. For example, a sysadmin 
> > could decide that the users can create files in write protected locations, 
> > but they cannot delete existing files.
> 
> Chinmoy Ranjan Pradhan wrote:
> Some operation may use more than one polkit action like Delete. If we use 
> one polkit action per operation then we will have to provide credentials for 
> every polkit action that operation might use. Though we can add necessary 
> code for this but it will only complicate the matter.
> 
> > we could allow a more fine-grained control
> 
> Does this involve editing the policy file directly or just writing a 
> config file? In later case we can provide control over execution of actions 
> within the ioslave. 'execWithRoot' can perform a check prior to execution of 
> the polkit action.
> 
> Elvis Angelaccio wrote:
> > Some operation may use more than one polkit action like Delete. If we 
> use one polkit action per operation then we will have to provide credentials 
> for every polkit action that operation might use.
> 
> But only if the actions are different, right? Otherwise we should be fine 
> within the 5 minutes threshold after the first authentication. Can you show 
> some concrete examples where this issue would happen?
> 
> > Does this involve editing the policy file directly or just writing a 
> config file?
> 
> Have a look at polkit rules. For example, one could write a rule that 
> says "org.kde.kio.file.copy is allowed, org.kde.kio.file.del is not." and it 
> would be very cool if we could actually support this.
> 
> Chinmoy Ranjan Pradhan wrote:
> >But only if the actions are different, right? Otherwise we should be 
> fine within the 5 minutes threshold after the first authentication. Can you 
> show some concrete examples where this issue would happen?
> 
> Delteing a non-empty directory
> In this operation 'del' and 'rmdir' actions are used. In this case we 
> will have to authenticate for both the actions. And after the first 
> authentication, doing a similar operation will show the warning dialog twice.
> 
> Copy operation can also be considered.
> This operation will consist of six actions which are file_open, sendfile, 
> read, write, file_close, chown. Although all the actions will not be used at 
> once usage of atleast two can be expected. Here also we will have to 
> authenticate ouself atleast twice just for copying a single file which is 
> very annoying.
> 
> >it would be very cool if we could actually support this.
> 
> Indeed its very cool and useful,but still, we will have all these 
> problems.
> 
> One possible solution can be using the **annotate** tag. Polkit doc 
> mentions its **used for annotating an action with a key/value pair**. If the 
> _value_ is **org.freedesktop.policykit.imply** then **the subject if 
> authorized for an action with this annotation is also authorized for any 
> action specified by the annotation**.
> So what I did is added this line ``` key="org.freedesktop.policykit.imply">org.kde.kio.file.rmdir``` 
> after the defaults tag of _del_ action. After this when I tried deleting a 
> non-empty folder I only got one auth dialog. One more thing I noticed is, 
> with this line in place, when I deleted a single file deleting an empty 
> folder afterwards only showed one warning even though the action was 
> different and was executing for this first time.
> 
> I'm still not sure about this so I might be completely wrong as well. If 
> you have any knowledge of this please let me know if I got everything or 
> anything right. And if what I have mentioned is indeed correct then we will 
> have to add the support for _annotate_ tag to kauth policy generator.
> 
> Elvis Angelaccio wrote:
> The *imply* annotation sounds very promising, might be exactly what we 
> are looking for. Unfortunately I don't know more details about it, at the 
> moment.
> 
> Another solution (possibly simpler) could be a middle ground between 
> "only one generic action" and "one action per operation". For example, we 
> could have a `org.kde.kio.file.delete` action that handles everything about 
> deletion: single file, empty folder, non-empty folder, etc.
> 
> Chinmoy Ranjan Pradhan wrote:
> Merging actions sounds good. I have updated the patch as per your 
> suggestion. We can merge some other action as well, like,
> file_open, sendfile, read, write, file_close --> to _copy_
> 

Jenkins-kde-ci: kapidox master stable-kf5-qt5 » Linux,gcc - Build # 174 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kapidox%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/174/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 28 Mar 2017 20:50:47 +
Build duration: 27 sec

CHANGE SET
Revision f654e484c09deb78585a0db4cd5dbb5485628267 by olivier: ([Meta] Change 
maintainer in setup.py)
  change: edit setup.py

Jenkins-kde-ci: kapidox master kf5-qt5 » Linux,gcc - Build # 173 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kapidox%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/173/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 28 Mar 2017 20:50:47 +
Build duration: 31 sec

CHANGE SET
Revision f654e484c09deb78585a0db4cd5dbb5485628267 by olivier: ([Meta] Change 
maintainer in setup.py)
  change: edit setup.py

Re: Scrap Baloo Thread Feedback

[Martin Klapetek]

On Tue, Mar 28, 2017 at 5:21 AM, Matthieu Gallien <
gallien.matth...@gmail.com> wrote:

> Hello all,
>
> Sorry to exhume this old thread, but
>
> Is there a common agreement on the best path forward for Baloo versus
> the current situation ?
>
> I have an interest in having a global KDE solution where I would help
> (as time allows). Still, I will only work after an agreement has been
> reached.
>

Hey,

thanks for stepping up! I'd say that if nobody gives you
any sort of approval, just go ahead and figure out the
best plan for Baloo and then present it here, saying that
you would like Baloo to move in this direction, detail out
your proposal and if nobody objects, go ahead and do it.
KDE is about doers, after all :) Also, if you're still a student,
you may want to consider doing this as a GSoC.

Cheers
--
Martin Klapetek

D5218: explicitly set NO_CMAKE_FIND_ROOT_PATH

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5218

To: sitter, mdawson, apol
Cc: #frameworks

D5215: [ModelContextMenu] Use Instantiator insteadof Repeater-and-reparent-hack

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5215

To: broulik, #plasma, apol
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Re: Test failures with networkmanager-qt

[Hartmut Goebel]

Am 28.03.2017 um 11:43 schrieb Hartmut Goebel:
> Which versions are you referring to in "the only relevant change". Guix
> is currently lacking behind and still has 5.28, which we updated from
> 5.27 (which passed tests).

Update: The error occurs even with 5.32.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel  | h.goe...@crazy-compilers.com   |
| www.crazy-compilers.com | compilers which you thought are impossible |

D5167: Move .po and .ts files look-up to build-time

[Aleix Pol Gonzalez]

apol added a comment.


  Now it seems to work properly with scripts:
  
$ LANGUAGE=pl kgeography 
KTranscript: Loaded property map: 
/home/apol/devel/kde5/share/locale/pl/LC_SCRIPTS/kgeography/general.pmapc
KTranscript: Loaded module: 
/home/apol/devel/kde5/share/locale/pl/LC_SCRIPTS/kgeography/kgeography.js
  
  F3394527: Spectacle.h29248.png 

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D5167

To: apol, #frameworks, sitter, ltoscano, ilic
Cc: aacid

D5167: Move .po and .ts files look-up to build-time

[Aleix Pol Gonzalez]

apol updated this revision to Diff 12931.
apol added a comment.


  Fix

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5167?vs=12930&id=12931

BRANCH
  fetchbuildtime

REVISION DETAIL
  https://phabricator.kde.org/D5167

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  cmake/KF5I18NMacros.cmake
  cmake/build-pofiles.cmake
  cmake/build-tsfiles.cmake

To: apol, #frameworks, sitter, ltoscano, ilic
Cc: aacid

D5167: Move .po and .ts files look-up to build-time

[Aleix Pol Gonzalez]

apol updated this revision to Diff 12930.
apol added a comment.


  Fix several issues
  
  Properly test projects with ts and pmap files
  Make sure we install the files in the correct place
  Make sure we don't fail if the project calls KI18N_INSTALL twice

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5167?vs=12867&id=12930

BRANCH
  fetchbuildtime

REVISION DETAIL
  https://phabricator.kde.org/D5167

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  cmake/KF5I18NMacros.cmake
  cmake/build-pofiles.cmake
  cmake/build-tsfiles.cmake

To: apol, #frameworks, sitter, ltoscano, ilic
Cc: aacid

D5174: Add support for wl_shell_surface::set_popup and popup_done

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:6c89a61d2d17: Add support for wl_shell_surface::set_popup 
and popup_done (authored by graesslin).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5174?vs=12795&id=12924

REVISION DETAIL
  https://phabricator.kde.org/D5174

AFFECTED FILES
  autotests/client/test_wayland_shell.cpp
  src/client/shell.cpp
  src/client/shell.h
  src/server/shell_interface.cpp
  src/server/shell_interface.h

To: graesslin, #plasma_on_wayland, #frameworks, #kwin, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
eliasp, sebas, apol

Re: Scrap Baloo Thread Feedback

[Matthieu Gallien]

Hello all,

Sorry to exhume this old thread, but

2016-12-29 13:47 GMT+01:00 Dominik Haumann :
> Hi all,
>
> CC: plasma-devel, due to stability issues
>
> On Fri, Oct 7, 2016 at 5:56 PM, Christoph Cullmann  
> wrote:
>> Hi,
>>
> [...]
>> Actually, the bugs.kde.org page tells you the facts: The bug number
>> was constant increasing since > 1 year. The thread lists some other facts
>> what is wrong ATM and should be fixed.
>
> Btw, the bug count is increasing again, just as before. So it seems
> problems remain.
>
> [...]
>
>>> Right now, random requirements such as NFS and 32bit systems are
>>> coming up. Are these really that important?
>
> Yes, it is, see below.
>
>>> I specifically designed
>>> Baloo to not care about both network mounts and 32-bit systems. Yes,
>>> Baloo has bugs and it won't handle more than 32bit-inodes. These
>>> things, as all others, can be fixed. It's really a question of what is
>>> important. Lets not target the outliers. Many of these decisions were
>>> deliberately taken.
>> That are no random requirements, sorry, you could call it random 
>> restrictions, too.
>> That is not that productive, or?
>>
>> 1) 32-bit systems are still there and if that is a design decision to NOT 
>> support them,
>> that is ok, but then bad for Plasma, no official support for 32-bit systems, 
>> baloo is IMHO
>> the only framework with such requirements. And I see not that we have hinted 
>> any distro
>> that they shall not compile it for 32-bit.
>>
>> 2) No NFS: Ok, fair game, but then, it should check that and disable itself 
>> completely if $HOME
>> where the db is stored is a NFS, can live with that, too, but not with the 
>> current "we random
>> crash" behavior. => That is a user experience we don't want, or?
>
> The reason why I am writing this mail is exactly this point:
>
> At the university where I was previously working, $HOME is mounted via
> NFS. After an upgrade from KDE4 to Plasma 5.8, the desktop crashes
> very often. And the very reason is baloo.
>
> The problem, however, is that even the sysadmins do not know that
> baloo is the reason for all the crashes. In other words: Hundreds of
> users probably get the impression of an unstable Plasma 5.8 - or even
> worse - it boils down to "KDE sucks" or "I don't have these issues
> with Ubuntu".
>
> This is a perfect example of extremely negative impact - the Plasma
> devs can work as hard as they want, the desktop in this context will
> *never* be stable unless baloo is deactivated.
>
> That said: Baloo needs to disable itself for everything that touches
> NFS, or maybe even disable itself after it crashes several times.
>
> There were many more issues listed and discussed, but as far as I can
> see, we did not make real advances besides some prototype based on
> tracker (just a test), and some minor fixes in baloo that do not
> address the hard problems.
>
> Sorry that this reads like a rant. This is not the intention. Instead,
> the goal is to underline the still severe issues in order to get
> closer to a stable desktop for our users.
>
> Greetings
> Dominik
>
>
>
>> 3) > 32-bit inodes: That is normal and should work, but even if it should 
>> not: Atm you get inconsistent
>> and then later assertion fails or crashs.
>>
>> => I can live with all restrictions but the current handling of them, that 
>> always ends in "crash" is
>> IMHO not that acceptable. But that is "my" opinion, that might vary in the 
>> eyes of others.
>>
>>>
>>> How about requirements such as resource consumption, ease of
>>> integration, search speed are taken into consideration? Come on guys.
>>> We're engineers over here.
>> What is the argument here? If you take a look at bugs.kde.org, you see that 
>> people are complaining about all
>> of that with baloo. I see no evidence nowhere that e.g. baloo is "superior" 
>> to what GNOME uses
>> or any other solution (perhaps beside nepomuk, ok...).
>>
>> I fixed in a few days more bugs than were fixed in 1 year and triaged more 
>> than ever, still a lot is to be done.
>> (and I did really not do a lot, just remove things like 'self destruct if 
>> index > 5GB' or 'crash for ever on
>> db corruption')
>>
>> A graph tells more than words:
>>
>> https://bugs.kde.org/reports.cgi?product=frameworks-baloo&output=show_chart&datasets=CONFIRMED&datasets=ASSIGNED&datasets=REOPENED&datasets=UNCONFIRMED&datasets=RESOLVED&banner=1
>>
>> Given the current open bugs, one will need to:
>>
>> 1) review all extractors, they have still close to zero error handling and 
>> will just crash or OOM you on bad files
>> 2) review + fix the complete data base handling to handle errors and perhaps 
>> swap the DB
>> 3) fix the indexer to have some resource limits to avoid OOM and Co. if e..g 
>> extractors fail
>> ...
>>
>> Therefore there was my proposal, given we lack manpower, to implement baloo 
>> API on top of e.g. tracker to avoid all this
>> and let tracker handle that.
>>
>> To check if that is at all feasible, I did some quick an

Re: Test failures with networkmanager-qt

[Hartmut Goebel]

Am 28.03.2017 um 08:10 schrieb Jan Grulich:
> I can't think of any reason why the test fails for you. Looking to the git 
> log 
> the only relevant change is fixed uninitialized state variable in 
> ActiveConnection, which may affect ActiveConnection::stateChanged() signal. 

So you suggest to not try to find the cause but simply ignore this failure?

Which versions are you referring to in "the only relevant change". Guix
is currently lacking behind and still has 5.28, which we updated from
5.27 (which passed tests).

Between 5.27 and 5.28 here is one change that might be relevant: "Fix
unit tests" [1].

[1]


-- 
Regards
Hartmut Goebel

| Hartmut Goebel  | h.goe...@crazy-compilers.com   |
| www.crazy-compilers.com | compilers which you thought are impossible |

D5056: [KCModuleProxy] Remove dead code

[Kai Uwe Broulik]

broulik added a comment.


  Ping

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D5056

To: broulik, dfaure
Cc: ltoscano, #frameworks

D5034: Add support for x-gvfs style options in fstab

[Kai Uwe Broulik]

broulik added a comment.


  If no-one objects I'll push this after the next frameworks release

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D5034

To: broulik, #plasma, dfaure, dhaumann
Cc: dhaumann, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 278 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/278/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 28 Mar 2017 13:01:43 +
Build duration: 5 min 57 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.ksycocathreadtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 76/85 (89%)CLASSES 76/85 (89%)LINE 5493/8028 
(68%)CONDITIONAL 3007/6264 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1465/1571 
(93%)CONDITIONAL 907/1820 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 30/31 (97%)CLASSES 30/31 (97%)LINE 1766/3046 
(58%)CONDITIONAL 769/1904 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2046/2798 
(73%)CONDITIONAL 1246/2112 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

D5217: explicitly set NO_CMAKE_FIND_ROOT_PATH

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:3e9993625cf3: explicitly set NO_CMAKE_FIND_ROOT_PATH 
(authored by sitter).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5217?vs=12913&id=12915

REVISION DETAIL
  https://phabricator.kde.org/D5217

AFFECTED FILES
  KF5CoreAddonsConfig.cmake.in

To: sitter, apol, mpyne
Cc: #frameworks

D5218: explicitly set NO_CMAKE_FIND_ROOT_PATH

[Harald Sitter]

sitter created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  When using a toolchain file one often would want to set a
  CMAKE_FIND_ROOT_PATH to "re-root" lookups into a staging area to prevent
  native host artifcats from being found. This in particular is usually the
  case for lib/include/package finders as one would want the target
  systems build artifacts rather than the hosts.
  find_file() unfortunately draws its re-rooting rule from
  CMAKE_FIND_ROOT_PATH_MODE_INCLUDE, which as mentioned would usually be
  set not to look in the actual host paths to avoid picking up wrong includes
  which would also prevent find_file to work here.
  
  In the case of the coreaddonstooling it makes sense to look in the host
  though. For one the lookup only runs when CROSS_COMPILING is set (which
  usually is the case for toolchains), AND one explicitly has to specify a
  HOST_TOOLING path. So in a way by specifying that one is already opting
  out of whatever rooting rules one has set elsewhere as setting that var
  is a clear indication that we have *specific* host tooling and we want
  to use that rather than anything else.
  As a result NO_CMAKE_FIND_ROOT_PATH is the way to go when looking for stuff
  under a KF5_HOST_TOOLING conditional.

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5218

AFFECTED FILES
  KF5ConfigConfig.cmake.in

To: sitter, mdawson, apol
Cc: #frameworks

D5217: explicitly set NO_CMAKE_FIND_ROOT_PATH

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5217

To: sitter, apol, mpyne
Cc: #frameworks

D5217: explicitly set NO_CMAKE_FIND_ROOT_PATH

[Harald Sitter]

sitter created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  When using a toolchain file one often would want to set a
  CMAKE_FIND_ROOT_PATH to "re-root" lookups into a staging area to prevent
  native host artifcats from being found. This in particular is usually the
  case for lib/include/package finders as one would want the target
  systems build artifacts rather than the hosts.
  find_file() unfortunately draws its re-rooting rule from
  CMAKE_FIND_ROOT_PATH_MODE_INCLUDE, which as mentioned would usually be
  set not to look in the actual host paths to avoid picking up wrong includes
  which would also prevent find_file to work here.
  
  In the case of the coreaddonstooling it makes sense to look in the host
  though. For one the lookup only runs when CROSS_COMPILING is set (which
  usually is the case for toolchains), AND one explicitly has to specify a
  HOST_TOOLING path. So in a way by specifying that one is already opting
  out of whatever rooting rules one has set elsewhere as setting that var
  is a clear indication that we have *specific* host tooling and we want
  to use that rather than anything else.
  As a result NO_CMAKE_FIND_ROOT_PATH is the way to go when looking for stuff
  under a KF5_HOST_TOOLING conditional.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5217

AFFECTED FILES
  KF5CoreAddonsConfig.cmake.in

To: sitter, apol, mpyne
Cc: #frameworks

D5215: [ModelContextMenu] Use Instantiator insteadof Repeater-and-reparent-hack

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

TEST PLAN
  Clicking the "add widgets" button multiple times in widget explorer no longer 
crashes/confuses it because the Repeater destroys its items when model is 
assigned a new JS Array as is done in widget explorer.
  
  Also the category selection in widget explorer still works.
  
  There's no addMenuItemAt method and the old code also didn't care about the 
order of items so it shouldn't be worse than before.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5215

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/ModelContextMenu.qml

To: broulik, #plasma
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5200: [Calendar] Shrink and elide week names like is done with day delegate

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:5ae0651045c2: [Calendar] Shrink and elide week names like 
is done with day delegate (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5200?vs=12874&id=12908

REVISION DETAIL
  https://phabricator.kde.org/D5200

AFFECTED FILES
  src/declarativeimports/calendar/qml/DaysCalendar.qml

To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5214: [Icon Item] Make "smooth" property actually do something

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:611a4b592055: [Icon Item] Make "smooth" property actually 
do something (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5214?vs=12905&id=12907

REVISION DETAIL
  https://phabricator.kde.org/D5214

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp

To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5212: support building against a qt without a11y enabled

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:9dac68ab5b64: support building against a qt without a11y 
enabled (authored by sitter).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5212?vs=12902&id=12906

REVISION DETAIL
  https://phabricator.kde.org/D5212

AFFECTED FILES
  src/kcollapsiblegroupbox.cpp

To: sitter, cfeck
Cc: #frameworks

D5174: Add support for wl_shell_surface::set_popup and popup_done

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  popup-done

REVISION DETAIL
  https://phabricator.kde.org/D5174

To: graesslin, #plasma_on_wayland, #frameworks, #kwin, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
eliasp, sebas, apol

D5200: [Calendar] Shrink and elide week names like is done with day delegate

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5200

To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5214: [Icon Item] Make "smooth" property actually do something

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5214

To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5208: Allow loading i18n catalogs from arbitrary locations

[Chusslove Illich]

ilic added inline comments.

INLINE COMMENTS

> klocalizedstring.h:558
>  
> +static void addDomainLocaleDir(const QByteArray &domain, const QString 
> &path);
> +

Misses docstring. It should be made clear that this method is for "special 
purposes" (e.g. plugins and whatnot), and that normal programs should not force 
locale directories but rely on standard data directory lookup hierarchy.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D5208

To: davidedmundson, #frameworks, ilic
Cc: ilic

D5208: Allow loading i18n catalogs from arbitrary locations

[Chusslove Illich]

ilic requested changes to this revision.
ilic added a comment.
This revision now requires changes to proceed.


  I think it's fine to add this capability, especially given that Gettext 
(which Ki18n is an extension of) not only has it, but uses it exclusively (it 
does not search through any environment-derived directories).
  
  However, there are a few questions of semantics.
  
  So far it was always possible for a user to override the locale directory 
through environment variables, e.g. to test translation without building the 
full program. Should we still enable this, i.e. provide environment overriding 
also in case program sets the locale directory? But I guess we can postpone 
this question, since as you mention in KDE 4 Plasma the locale directory was 
being forced by the program anyway by other means.
  
  On the other side, if the locale directory for the domain is set, should (as 
in currently proposed implementation) environment-derived directories still be 
looked through if catalog is not found in the set directory?
  
  I think better name for the method is setDomainLocaleDir, because if it is 
called again for the same domain, it will override the previous setting and not 
add another directory for it.

INLINE COMMENTS

> klocalizedstringtest.cpp:59
>  if (m_hasFrench) {
> -m_hasFrench = compileCatalogs(dataDir);
> +m_hasFrench = compileCatalogs({QFINDTESTDATA("po/fr/ki18n-test.po"), 
> QFINDTESTDATA("po/fr/ki18n-test-qt.po")}, dataDir);
>  }

I think we're not allowed to use initializer lists yet, due to MSVC11 support.

> klocalizedstringtest.cpp:523
> +compileCatalogs({QFINDTESTDATA("po/fr/ki18n-test2.po")}, dir.path());
> +KLocalizedString::setApplicationDomain("ki18n-test2");
> +KLocalizedString::addDomainLocaleDir("ki18n-test2", dir.path() + 
> "/locale");

setApplicationDomain should not be called twice, use i18nd method instead, like 
i18nd("ki18n-test2", "Cheese").

> kcatalog.cpp:124
> +{
> +QMutexLocker lock(&catalogStaticData->mutex);
> +const QString customLocaleDir = 
> catalogStaticData->customCatalogDirs[domain];

Only read access is needed here, user QHash::value instead of QHash::operator[].

> kcatalog.cpp:126
> +const QString customLocaleDir = 
> catalogStaticData->customCatalogDirs[domain];
> +if (!customLocaleDir.isEmpty() && !QFileInfo::exists(customLocaleDir 
> + relpath)) {
> +return customLocaleDir;

Maybe I'm seeing something wrongly here, but... customLocaleDir + relpath may 
miss path separator? Really !QFileInfo::exists and not QFileInfo::exists?

> kcatalog.cpp:151
> +{
> +QMutexLocker lock(&catalogStaticData->mutex);
> +if (catalogStaticData->customCatalogDirs.contains(domain_)) {

Also only read access needed.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D5208

To: davidedmundson, #frameworks, ilic
Cc: ilic

D5212: support building against a qt without a11y enabled

[Christoph Feck]

cfeck accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5212

To: sitter, cfeck
Cc: #frameworks

D5214: [Icon Item] Make "smooth" property actually do something

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  We had m_smooth but never actually used it in the texture node.
  With Plasma SVG icons this shouldn't be used but when passing custom pixmaps 
or raster graphics (e.g. custom icon in Kicker, thumbnails in Folder View)

TEST PLAN
  Created an icon item with `smooth: true`, it looked more blurry than 
pixelated after that.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5214

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp

To: broulik, #plasma
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5212: support building against a qt without a11y enabled

[Harald Sitter]

sitter created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5212

AFFECTED FILES
  src/kcollapsiblegroupbox.cpp

To: sitter, cfeck
Cc: #frameworks

D5202: [Default Tooltip] Fix icon size

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:7487e208b696: [Default Tooltip] Fix icon size (authored 
by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5202?vs=12878&id=12900

REVISION DETAIL
  https://phabricator.kde.org/D5202

AFFECTED FILES
  src/declarativeimports/core/private/DefaultToolTip.qml

To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D4911: add Baloo DBus signals for moved or removed files

[Matthieu Gallien]

mgallien added a reviewer: dfaure.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D4911

To: mgallien, vhanda, dfaure
Cc: cullmann, apol, #frameworks

D4911: add Baloo DBus signals for moved or removed files

[Matthieu Gallien]

mgallien reclaimed this revision.
mgallien added a comment.


  Reopening since I am still convinced that getting signals from Baloo is a lot 
more sane than adding workaround in each users of Baloo.
  
  My point is that for a music player like the one I am working on (Elisa), I 
have to do the following:
  
  - ask Baloo for an initial list of files (using Baloo APIs) ;
  - add file system watches for all those files (needed for removed files or 
directory and moved files or directories) ;
  - listen to some DBus signals from Baloo (needed to understand new files have 
been detected by Baloo in directories I am watching or not). May be used to 
detect changes to already known files ;
  - hope that my code is good enough to not miss any changes.
  
  One of the worst thing in this schema is that Baloo is slower than file 
system watches. Changes will not be detected in the order they happen. Changes 
detected through Baloo will happen after changes detected by watches. User 
Experience may suffer from that (needs more test to see if this is real).
  
  As I already said, if the cost of getting exact changes is too high, just a 
signal saying something changed is good enough if we get notified of *all* 
changes.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D4911

To: mgallien, vhanda
Cc: cullmann, apol, #frameworks

D5202: [Default Tooltip] Fix icon size

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5202

To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5209: Load translations from KPackage files if bundled

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5209

To: davidedmundson, #plasma, mart
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 624 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/624/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 28 Mar 2017 07:05:22 +
Build duration: 5 min 29 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 19 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 
67 test(s)Failed: TestSuite.bug205447Failed: TestSuite.bug286887Failed: 
TestSuite.bug313759Failed: TestSuite.bug317111Failed: 
TestSuite.commands_testFailed: TestSuite.completion_testFailed: 
TestSuite.katefoldingtestFailed: TestSuite.katesyntaxtestFailed: 
TestSuite.kateview_testFailed: TestSuite.modificationsystem_testFailed: 
TestSuite.movingrange_testFailed: TestSuite.revision_testFailed: 
TestSuite.scripting_testFailed: TestSuite.templatehandler_testFailed: 
TestSuite.vimode_completionFailed: TestSuite.vimode_emulatedcommandbarFailed: 
TestSuite.vimode_keysFailed: TestSuite.vimode_modesFailed: TestSuite.vimode_view

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 20/26 (77%)FILES 218/290 (75%)CLASSES 218/290 (75%)LINE 18103/42167 
(43%)CONDITIONAL 9194/29827 (31%)

By packages
  
autotests.src
FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 2564/2896 
(89%)CONDITIONAL 1230/2640 (47%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1518/1771 
(86%)CONDITIONAL 1157/1630 (71%)
src.completion
FILES 15/16 (94%)CLASSES 15/16 (94%)LINE 749/3102 
(24%)CONDITIONAL 276/2798 (10%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 40/464 (9%)CONDITIONAL 
12/354 (3%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/875 (0%)CONDITIONAL 0/258 
(0%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1609/3225 
(50%)CONDITIONAL 1281/3238 (40%)
src.export
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/125 (0%)CONDITIONAL 0/152 
(0%)
src.include.ktexteditor
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 190/243 
(78%)CONDITIONAL 117/228 (51%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 76/325 (23%)CONDITIONAL 
15/89 (17%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 165/427 (39%)CONDITIONAL 
99/265 (37%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/885 (0%)CONDITIONAL 0/294 
(0%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 857/1217 
(70%)CONDITIONAL 557/932 (60%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 
4/697 (1%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 637/1055 
(60%)CONDITIONAL 269/556 (48%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 910/1404 
(65%)CONDITIONAL 524/913 (57%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 153/1336 (11%)CONDITIONAL 
52/820 (6%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 123/373 (33%)CONDITIONAL 
60/203 (30%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1588/2077 
(76%)CONDITIONAL 1004/1708 (59%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 624/772 (81%)CONDITIONAL 
292/448 (65%)
src.utils
FILES 29/36 (81%)CLASSES 29/36 (81%)LINE 2045/3927 
(52%)CONDITIONAL 845/2728 (31%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/668 (0%)CONDITIONAL 0/170 
(0%)
src.view
FILES 17/19 (89%)CLASSES 17/19 (89%)LINE 2963/6333 
(47%)CONDITIONAL 1171/3813 (31%)
src.vimode
FILES 23/34 (68%)CLASSES 23/34 (68%)LINE 762/2340 
(33%)CONDITIONAL 189/1751 (11%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/134 (0%)CONDITIONAL 0/90 
(0%)
src.vimode.emulatedcommandbar
FILES 0/12 (0%)CLASSES 0/12 (0%)LINE 0/915 (0%)CONDITIONAL 
0/682 (0%)
src.vimode.modes
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 509/3740 
(14%)CONDITIONAL 40/2370 (2%)