D6128: Bug 360656 - CMake: OR/AND not highlighted after expr in ()

[jonathan poelen]

jpoelen added a reviewer: Framework: Syntax Hightlighting.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D6128

To: jpoelen, #framework_syntax_hightlighting
Cc: #frameworks

D6128: Bug 360656 - CMake: OR/AND not highlighted after expr in ()

[jonathan poelen]

jpoelen updated this revision to Diff 15240.
jpoelen added a comment.


  - cmake test: add an expression with nested parenthesis

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6128?vs=15239=15240

BRANCH
  upstream

REVISION DETAIL
  https://phabricator.kde.org/D6128

AFFECTED FILES
  autotests/folding/highlight.cmake.fold
  autotests/html/highlight.cmake.html
  autotests/input/highlight.cmake
  autotests/reference/highlight.cmake.ref
  data/syntax/cmake.xml

To: jpoelen
Cc: #frameworks

D6128: Bug 360656 - CMake: OR/AND not highlighted after expr in ()

[jonathan poelen]

jpoelen updated this revision to Diff 15239.
jpoelen added a comment.


  Previous diff on bad branch

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6128?vs=15238=15239

BRANCH
  upstream

REVISION DETAIL
  https://phabricator.kde.org/D6128

AFFECTED FILES
  autotests/html/highlight.cmake.html
  autotests/reference/highlight.cmake.ref
  data/syntax/cmake.xml

To: jpoelen
Cc: #frameworks

D6128: Bug 360656 - CMake: OR/AND not highlighted after expr in ()

[jonathan poelen]

jpoelen updated this revision to Diff 15238.
jpoelen edited the summary of this revision.
jpoelen added a comment.


  - Update test reference data

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6128?vs=15237=15238

BRANCH
  upstream

REVISION DETAIL
  https://phabricator.kde.org/D6128

AFFECTED FILES
  CMakeLists.txt
  KF5SyntaxHighlightingConfig.cmake.in
  autotests/html/highlight.cmake.html
  autotests/html/highlight.dox.html
  autotests/html/test.c.html
  autotests/reference/highlight.cmake.ref
  autotests/reference/highlight.dox.ref
  autotests/reference/test.c.ref
  data/syntax/cmake.xml
  data/syntax/doxygen.xml
  data/syntax/haskell.xml
  src/lib/CMakeLists.txt

To: jpoelen
Cc: #frameworks

D6128: Bug 360656 - CMake: OR/AND not highlighted after expr in ()

[jonathan poelen]

jpoelen retitled this revision from "CMake: OR/AND not highlighted after expr 
in () If you type in "if((A AND B) OR C)", "OR" is not highlighted." to "Bug 
360656 - CMake: OR/AND not highlighted after expr in ()".
jpoelen edited the summary of this revision.
jpoelen edited the test plan for this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D6128

To: jpoelen
Cc: #frameworks

D6128: CMake: OR/AND not highlighted after expr in () If you type in "if((A AND B) OR C)", "OR" is not highlighted.

[jonathan poelen]

jpoelen created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  upstream

REVISION DETAIL
  https://phabricator.kde.org/D6128

AFFECTED FILES
  data/syntax/cmake.xml

To: jpoelen
Cc: #frameworks

D6126: Support fractional scaling in generating the sidebar preview

[Aleix Pol Gonzalez]

apol added a comment.


  +1 would it make sense to add a clazy check that identifies uses of this 
method? Or deprecating the method altogether?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D6126

To: davidedmundson, #plasma
Cc: apol, plasma-devel, kwrite-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart, lukas

D6042: Don't use the path as is if it's a data: url

[Aleix Pol Gonzalez]

apol abandoned this revision.
apol added a comment.


  dfaure fixed it separately in commit 
https://phabricator.kde.org/R241:aafa5b7bbc89301c478f8089d6738a4c5896bcac

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D6042

To: apol, #frameworks

D6126: Support fractional scaling in generating the sidebar preview

[David Edmundson]

davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, kwrite-devel, 
plasma-devel.

REVISION SUMMARY
  QPaintDevice::devicePixelRatio was replaced by devicePixelRatioF when Qt
  supported fractional scaling as the type changed but needed to keep API. 
  Every other call to devicePixelRatio was already a qreal.
  
  The sidebar was already scaled up to the fractional size, but the pixmap
  was generated at the integer version. End result is that it wasn't quite as
  crisp as it could be.

TEST PLAN
  QT_SCALE_FACTOR=1.4 kate
  Opened bug fix and used minimap as before
  My extra assert in QPaintDevice::devicePixelRatio was never fired

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6126

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, kwrite-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6086: Left-click mini-map to jump to clicked area

[Kåre Särs]

sars added a comment.


  I think I fixed it. 
  The comment about the dragging was only partially correct. The press must be 
inside the slider for dragging, so when the initial press is outside or not 
translated from the mini-map coordinates, the dragging does not start.
  
  My solution is to first move to the desired place then forward the translated 
click to the QScrollBar.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D6086

To: sars, #ktexteditor, #kate, dhaumann, kfunk
Cc: kfunk, broulik, kwrite-devel, #frameworks

D6122: Add since tags.

[Christoph Feck]

cfeck added a comment.


  The patch is simple, but it is always a good idea to ask for a review.
  
  Since this frameworks is new as of 5.28, should we really mark each class 
this way? We did not do this for other "new" frameworks, such as prison or 
kwayland.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D6122

To: tfry, #frameworks
Cc: cfeck

D6086: Left-click mini-map to jump to clicked area

[Dominik Haumann]

dhaumann added a comment.


  Hi, I'm sorry I am a bit late to the game: I once also tried to implement 
this, but the result was a messy patch that did not always get the location 
right. So I would not be surprised if there are corner cases that do not work.
  In any case, either we stabilize this until the next tag (afaik, the last tag 
was 5 days ago?), or we need to revert.
  
  But also: Cool that you are working on this!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D6086

To: sars, #ktexteditor, #kate, dhaumann, kfunk
Cc: kfunk, broulik, kwrite-devel, #frameworks

D6122: Add since tags.

[Thomas Friedrichsmeier]

tfry created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  I hate having to look up when interesting new classes were added.
  Patch is straight-forward (I think), but:
  
  - should @since be added on all memebers, when it's already on the class?
  - would simple patches such as this be ok to commit without review?

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6122

AFFECTED FILES
  src/lib/abstracthighlighter.h
  src/lib/definition.h
  src/lib/definitiondownloader.h
  src/lib/foldingregion.h
  src/lib/format.h
  src/lib/repository.h
  src/lib/state.h
  src/lib/syntaxhighlighter.h
  src/lib/theme.h

To: tfry, #frameworks

D6121: Angular modifiers in HTML attributes added

[Alexander Zhigalin]

zhigalin added reviewers: Kate, KTextEditor.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D6121

To: zhigalin, #kate, #ktexteditor
Cc: #frameworks

D6121: Angular modifiers in HTML attributes added

[Alexander Zhigalin]

zhigalin created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Angular uses special characters in HTML atributes
  This disables the error highlighting for []()*# in HTML tag attributes

TEST PLAN

  Title:
  


  Link:
  


REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6121

AFFECTED FILES
  data/syntax/html.xml

To: zhigalin
Cc: #frameworks

RFC: Packaging of KF5 API dox QCH files and their devel helper files

[Friedrich W. H. Kossebau]

Hi packagers,

(cc: to kde-frameworks-devel only for heads-up)

with ECM/KF5 5.35.0 now snapshot and being prepared for release, a new feature 
has already been pushed to the master branches of ECM and almost all the non-
deprecated KF5 modules, which might need some more fine-tuning in the few 
weeks until it then ships with next release of ECM/KF5, 5.36.0, and after that 
will be harder to improve.

And your, the packagers/distributors', input here is very much needed!
Because this might need new packaging patterns.


NEW BUILD ARTIFACTS INSTALLED: A QCH FILE...

The new feature is the option to create and install documentation of the 
public API in QCH format ("Qt compressed help", for e.g. Qt Assistant, Qt 
Creator & KDevelop) during the build of all the KDE Frameworks modules with 
public API.
By passing -DBUILD_QCH=ON to cmake, and with the tools doxygen & 
qhelpgenerator around (and perl needed as well currently by doxygen), 
additionally a QCH file will be generated and installed.
The advantage to do it at build time, as opposed to run it over a pure 
checkout of the sources, is that also all generated source files are visible 
to the documentation generator (as well as build options), so the 
documentation can be more complete. And it matches the exact version of the 
installed headers and library automatically.

Example:
KCoreAddons built with cmake -DBUILD_QCH=ON
-> installs file KF5CoreAddons.qch to ${KDE_INSTALL_QTQCHDIR}


... A DOXYGEN TAG FILE, ...

Just, things are slightly more complex. Because for libraries whose API makes 
use of classes etc. from other libraries (like when subclassing from their 
classes or using their types for own method arguments), the documentation only 
gets really useful if it includes information about the things from the other 
libraries or at least has cross-links to it. The Qt help system supports such 
cross-linking across documentation for different libraries, using a qthelp:// 
url scheme.
Doxygen supports those cross-linking as well when generating the QCH files, as 
well as picking up documentation for inherited things. For that it needs a 
separate metadata file about a given QCH file, so called "tag file", which 
contains all the info needed to create qthelp:// links into a given QCH file 
for its documented classes etc. as well as getting documentation for inherited 
class methods etc.
For the different QCH files of the Qt modules those are installed in a subdir 
next to the QCH files (see "qmake-qt5 -query QT_INSTALL_DOCS"). E.g. on 
openSUSE the files are located in this pattern, by example of qtcore:
/usr/share/doc/packages/qt5/qtcore.qch
/usr/share/doc/packages/qt5/qtcore/qtcore.tags

So to allow the same cross-linking also for the KF5 QCH files, for each QCH 
file also a doxygen tag file is created and installed.

Example:
KCoreAddons built with cmake -DBUILD_QCH=ON
-> installs file KF5CoreAddons.qch to ${KDE_INSTALL_QTQCHDIR}
-> installs file KF5CoreAddons.tags to ${KDE_INSTALL_QTQCHDIR}


... & MORE CMAKE CONFIG

Just, when we want doxygen to create a QCH file with cross-linking to another 
QCH file, how do we know where the respective tag file is exactly, so we can 
tell it to doxygen? And how do we know some other info bits needed to generate 
proper qthelp:// urls (like correct org domain and path)?

For the use with KF5 libraries, there are two different cases interesting: 
linking to Qt QCH files, and linking to KF5 QCH files.

For location of Qt QCH files, we can get some info from "qmake-qt5 -query 
QT_INSTALL_DOCS" and then look at the known subpath. The other data needed for 
qthelp:// urls can be guessed to follow given patterns.

For KF5 QCH files, as we have more control about the buildsystem, the solution 
is to simply store all the details in the CMake config files installed for a 
given library. The current approach simply follow the modern cmake way for 
definition of the linking of code libraries, where one only needs to list the 
target names of the libraries in target_link_libraries() and things like 
include paths are automatically pulled in:
for each QCH library a cmake target is provided in the additionally installed 
CMake config files, which has all the needed information set as properties. So 
when defining the generation of a QCH file with the new ECM macro 
ecm_add_qch(), the QCH libraries to link to can be simply noted by their 
target name, in the parameter group LINK_QCHS, and everything else is handled 
automatically.
And to make things more simple for now, the additionally installed CMake 
config files are included automatically by the normal CMake config files. So 
currently no separate "find_package(KF5MyLib_QCH)" or similar is needed, but 
the QCH target is automatically available (unless build was done without QCH).

While there are no such QCH targets available for the Qt QCH files with the 
existing Qt CMake config files, the ECM macro simply generates them on the 
fly, so for linking to some qtxyz.qch 

KDE CI: Frameworks khtml kf5-qt5 XenialQt5.7 - Build # 10 - Fixed!

[no-reply]

BUILD SUCCESS
 Build URL
https://build-sandbox.kde.org/job/Frameworks%20khtml%20kf5-qt5%20XenialQt5.7/10/
 Project:
Frameworks khtml kf5-qt5 XenialQt5.7
 Date of build:
Tue, 06 Jun 2017 15:09:55 +
 Build duration:
5 min 9 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report83%
(19/23)49%
(308/627)49%
(308/627)3%
(3032/94742)2%
(2835/151354)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault33%
(2/6)33%
(2/6)0%
(2/479)1%
(4/567)autotests100%
(4/4)100%
(4/4)93%
(53/57)48%
(27/56)src65%
(20/31)65%
(20/31)11%
(931/8826)4%
(811/18518)src.css48%
(12/25)48%
(12/25)0%
(32/9368)0%
(32/15687)src.dom73%
(29/40)73%
(29/40)1%
(61/7091)1%
(66/4876)src.ecma48%
(24/50)48%
(24/50)0%
(27/8351)0%
(47/19677)src.editing71%
(5/7)71%
(5/7)1%
(20/2100)0%
(11/4033)src.html42%
(21/50)42%
(21/50)0%
(21/10763)0%
(42/16107)src.imload13%
(4/31)13%
(4/31)3%
(24/854)2%
(14/643)src.imload.decoders100%
(8/8)100%
(8/8)3%
(19/616)1%
(10/684)src.misc48%
(13/27)48%
(13/27)23%
(837/3716)14%
(710/5258)src.platform0%
(0/1)0%
(0/1)0%
(0/2)100%
(0/0)src.platform.graphics0%
(0/16)0%
(0/16)0%
(0/534)0%
(0/308)src.platform.graphics.qt0%
(0/7)0%
(0/7)0%
(0/248)0%
(0/172)src.platform.text0%
(0/1)0%
(0/1)0%
(0/7)0%
(0/4)src.rendering49%
(48/97)49%
(48/97)0%
(64/23896)0%
(95/32659)src.svg49%
(72/147)49%
(72/147)13%
(746/5897)6%
(816/14527)src.svg.graphics50%
(7/14)50%
(7/14)2%
(7/283)4%
(14/342)src.svg.graphics.qt100%

KDE CI: Frameworks khtml kf5-qt5 XenialQt5.7 - Build # 9 - Failure!

[no-reply]

BUILD FAILURE
 Build URL
https://build-sandbox.kde.org/job/Frameworks%20khtml%20kf5-qt5%20XenialQt5.7/9/
 Project:
Frameworks khtml kf5-qt5 XenialQt5.7
 Date of build:
Tue, 06 Jun 2017 15:05:15 +
 Build duration:
3 min 50 sec and counting
   CONSOLE OUTPUT
  [...truncated 395.50 KB...][ 83%] Building CXX object src/CMakeFiles/KF5KHtml.dir/svg/SVGMissingGlyphElement.cpp.o[ 83%] Building CXX object src/CMakeFiles/KF5KHtml.dir/svg/SVGFontElement.cpp.o[ 83%] Building CXX object src/CMakeFiles/KF5KHtml.dir/svg/SVGFontData.cpp.o[ 84%] Building CXX object src/CMakeFiles/KF5KHtml.dir/svg/graphics/SVGResource.cpp.o[ 84%] Building CXX object src/CMakeFiles/KF5KHtml.dir/svg/graphics/SVGPaintServer.cpp.o[ 84%] Building CXX object src/CMakeFiles/KF5KHtml.dir/svg/graphics/qt/SVGPaintServerQt.cpp.o[ 84%] Building CXX object src/CMakeFiles/KF5KHtml.dir/svg/graphics/SVGPaintServerSolid.cpp.o[ 84%] Building CXX object src/CMakeFiles/KF5KHtml.dir/svg/graphics/qt/SVGPaintServerSolidQt.cpp.o[ 85%] Building CXX object src/CMakeFiles/KF5KHtml.dir/svg/graphics/SVGResourceClipper.cpp.o[ 85%] Building CXX object src/CMakeFiles/KF5KHtml.dir/svg/graphics/qt/SVGResourceClipperQt.cpp.o[ 85%] Building CXX object src/CMakeFiles/KF5KHtml.dir/svg/graphics/SVGPaintServerGradient.cpp.o[ 85%] Building CXX object src/CMakeFiles/KF5KHtml.dir/svg/graphics/SVGPaintServerLinearGradient.cpp.o[ 86%] Building CXX object src/CMakeFiles/KF5KHtml.dir/svg/graphics/SVGPaintServerRadialGradient.cpp.o[ 86%] Building CXX object src/CMakeFiles/KF5KHtml.dir/svg/graphics/qt/SVGPaintServerGradientQt.cpp.o[ 86%] Building CXX object src/CMakeFiles/KF5KHtml.dir/svg/graphics/qt/SVGPaintServerLinearGradientQt.cpp.o[ 86%] Building CXX object src/CMakeFiles/KF5KHtml.dir/svg/graphics/qt/SVGPaintServerRadialGradientQt.cpp.o[ 87%] Building CXX object src/CMakeFiles/KF5KHtml.dir/rendering/RenderSVGRoot.cpp.o[ 87%] Building CXX object src/CMakeFiles/KF5KHtml.dir/rendering/RenderPath.cpp.o[ 87%] Building CXX object src/CMakeFiles/KF5KHtml.dir/rendering/SVGRenderStyleDefs.cpp.o[ 87%] Building CXX object src/CMakeFiles/KF5KHtml.dir/rendering/SVGRenderStyle.cpp.o[ 87%] Building CXX object src/CMakeFiles/KF5KHtml.dir/rendering/RenderSVGGradientStop.cpp.o[ 88%] Building CXX object src/CMakeFiles/KF5KHtml.dir/rendering/RenderSVGContainer.cpp.o[ 88%] Building CXX object src/CMakeFiles/KF5KHtml.dir/rendering/SVGRenderSupport.cpp.o[ 88%] Building CXX object src/CMakeFiles/KF5KHtml.dir/rendering/RenderSVGHiddenContainer.cpp.o[ 88%] Building CXX object src/CMakeFiles/KF5KHtml.dir/rendering/RenderSVGTransformableContainer.cpp.o[ 89%] Building CXX object src/CMakeFiles/KF5KHtml.dir/rendering/SVGInlineFlowBox.cpp.o[ 89%] Building CXX object src/CMakeFiles/KF5KHtml.dir/rendering/SVGRootInlineBox.cpp.o[ 89%] Building CXX object src/CMakeFiles/KF5KHtml.dir/rendering/RenderSVGTextPath.cpp.o[ 89%] Building CXX object src/CMakeFiles/KF5KHtml.dir/rendering/SVGInlineTextBox.cpp.o[ 89%] Building CXX object src/CMakeFiles/KF5KHtml.dir/rendering/SVGCharacterLayoutInfo.cpp.o[ 90%] Building CXX object src/CMakeFiles/KF5KHtml.dir/rendering/RenderSVGInline.cpp.o[ 90%] Building CXX object src/CMakeFiles/KF5KHtml.dir/rendering/RenderSVGText.cpp.o[ 90%] Building CXX object src/CMakeFiles/KF5KHtml.dir/rendering/RenderSVGBlock.cpp.o[ 90%] Building CXX object src/CMakeFiles/KF5KHtml.dir/rendering/RenderSVGInlineText.cpp.o[ 91%] Building CXX object src/CMakeFiles/KF5KHtml.dir/rendering/RenderSVGTSpan.cpp.o[ 91%] Building CXX object src/CMakeFiles/KF5KHtml.dir/kcookiejar_interface.cpp.o[ 91%] Building CXX object src/CMakeFiles/KF5KHtml.dir/qrc_khtml.cpp.o[ 91%] Building CXX object src/CMakeFiles/KF5KHtml.dir/KF5KHtml_automoc.cpp.o[ 92%] Linking CXX shared library libKF5KHtml.so[ 92%] Built target KF5KHtml[ 93%] Generating qrc_testkhtml.cppScanning dependencies of target khtmlpartScanning dependencies of target kencodingdetectortestScanning dependencies of target khtmlimagepartScanning dependencies of target parttest[ 93%] Building CXX object src/CMakeFiles/khtmlpart.dir/khtmlpart_automoc.cpp.o[ 94%] Building CXX object src/CMakeFiles/khtmlpart.dir/khtml_factory.cpp.o[ 94%] Building CXX object autotests/CMakeFiles/kencodingdetectortest.dir/__/src/misc/kencodingdetector.cpp.o[ 95%] Building CXX object src/CMakeFiles/khtmlimagepart.dir/khtmlimage_init.cpp.oScanning dependencies of target testkhtml[ 95%] Building CXX object autotests/CMakeFiles/parttest.dir/khtmlparttest.cpp.oScanning dependencies of target testkhtml_static[ 95%] Building CXX object tests/CMakeFiles/testkhtml.dir/testkhtml.cpp.o[ 95%] Building CXX object tests/CMakeFiles/testkhtml_static.dir/testkhtml.cpp.oScanning dependencies of target khtmltest[ 95%] Building CXX object tests/CMakeFiles/khtmltest.dir/testkhtmlnew.cpp.o[ 95%] Building CXX object tests/CMakeFiles/khtmltest.dir/qrc_testkhtml.cpp.o[ 95%] Building CXX object tests/CMakeFiles/khtmltest.dir/khtmltest_automoc.cpp.o[ 96%] Building CXX object 

D6086: Left-click mini-map to jump to clicked area

[Kevin Funk]

kfunk added a comment.


  There are a couple of problems with the new behavior -- though I can't tell 
precisely when they're caused. And not sure they're new or not either.
  
  Things I'm seeing while mini map is enabled, only in some documents though:
  
  - When the slider is position at the bottom: clicking repeatedly on the same 
position causes flickering in the view port of the editor
  - Sometimes the scroll bar preview is shown while dragging the slider -- we 
should probably disable it while dragging altogether
  - Sometimes the slider is 'jumpy', when e.g. moving the slider from bottom to 
top. The jump distance is the size of the "slider" height.
  - Sometimes just fails to drag completely, or stops moving the slider in the 
middle of the drag move.
  
  Might wanna have another look?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D6086

To: sars, #ktexteditor, #kate, dhaumann, kfunk
Cc: kfunk, broulik, kwrite-devel, #frameworks

KDE CI: Frameworks kpackage kf5-qt5 XenialQt5.7 - Build # 8 - Fixed!

[no-reply]

BUILD SUCCESS
 Build URL
https://build-sandbox.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20XenialQt5.7/8/
 Project:
Frameworks kpackage kf5-qt5 XenialQt5.7
 Date of build:
Tue, 06 Jun 2017 13:36:17 +
 Build duration:
55 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 10 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)96%
(22/23)96%
(22/23)72%
(1484/2050)50%
(1014/2026)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(10/10)100%
(10/10)100%
(500/502)52%
(277/532)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)73%
(538/739)62%
(524/840)src.kpackage.private100%
(6/6)100%
(6/6)79%
(290/367)53%
(113/212)src.kpackagetool100%
(2/2)100%
(2/2)33%
(142/424)22%
(93/430)

build.log
Description: Binary data

KDE CI: Frameworks kpackage kf5-qt5 XenialQt5.7 - Build # 7 - Failure!

[no-reply]

BUILD FAILURE
 Build URL
https://build-sandbox.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20XenialQt5.7/7/
 Project:
Frameworks kpackage kf5-qt5 XenialQt5.7
 Date of build:
Tue, 06 Jun 2017 13:33:52 +
 Build duration:
37 sec and counting
   CONSOLE OUTPUT
  [...truncated 84.14 KB...]Scanning dependencies of target querytestScanning dependencies of target fallbackpackagetest[ 15%] Built target packagestructuretest_automocScanning dependencies of target mockhandlerScanning dependencies of target plasmoidpackagetest[ 17%] Building CXX object autotests/CMakeFiles/fallbackpackagetest.dir/fallbackpackagetest.cpp.o[ 19%] Building CXX object autotests/CMakeFiles/querytest.dir/plasmoidstructure.cpp.oGenerating moc_packagejobthread_p.cppGenerating moc_kpackagetool.cpp[ 21%] Building CXX object autotests/CMakeFiles/fallbackpackagetest.dir/plasmoidstructure.cpp.o[ 23%] Building CXX object autotests/mockdepresolver/CMakeFiles/mockhandler.dir/main.cpp.o[ 26%] Building CXX object autotests/CMakeFiles/plasmoidpackagetest.dir/plasmoidstructure.cpp.oScanning dependencies of target packagestructuretest[ 26%] Built target kpackagetool5_automocIn file included from /home/jenkins/workspace/Frameworks kpackage kf5-qt5 XenialQt5.7/autotests/plasmoidstructure.cpp:20:0:/home/jenkins/workspace/Frameworks kpackage kf5-qt5 XenialQt5.7/autotests/plasmoidstructure.h:23:39: fatal error: kpackage/packagestructure.h: No such file or directoryIn file included from /home/jenkins/workspace/Frameworks kpackage kf5-qt5 XenialQt5.7/autotests/plasmoidstructure.cpp:20:0:/home/jenkins/workspace/Frameworks kpackage kf5-qt5 XenialQt5.7/autotests/plasmoidstructure.h:23:39: fatal error: kpackage/packagestructure.h: No such file or directoryIn file included from /home/jenkins/workspace/Frameworks kpackage kf5-qt5 XenialQt5.7/autotests/fallbackpackagetest.cpp:21:0:/home/jenkins/workspace/Frameworks kpackage kf5-qt5 XenialQt5.7/autotests/fallbackpackagetest.h:23:25: fatal error: QtTest/QtTest: No such file or directorycompilation terminated.compilation terminated.compilation terminated.In file included from /home/jenkins/workspace/Frameworks kpackage kf5-qt5 XenialQt5.7/autotests/plasmoidstructure.cpp:20:0:/home/jenkins/workspace/Frameworks kpackage kf5-qt5 XenialQt5.7/autotests/plasmoidstructure.h:23:39: fatal error: kpackage/packagestructure.h: No such file or directorycompilation terminated.autotests/CMakeFiles/fallbackpackagetest.dir/build.make:62: recipe for target 'autotests/CMakeFiles/fallbackpackagetest.dir/plasmoidstructure.cpp.o' failedmake[2]: *** [autotests/CMakeFiles/fallbackpackagetest.dir/plasmoidstructure.cpp.o] Error 1make[2]: *** Waiting for unfinished jobsautotests/CMakeFiles/querytest.dir/build.make:62: recipe for target 'autotests/CMakeFiles/querytest.dir/plasmoidstructure.cpp.o' failedmake[2]: *** [autotests/CMakeFiles/querytest.dir/plasmoidstructure.cpp.o] Error 1CMakeFiles/Makefile2:359: recipe for target 'autotests/CMakeFiles/querytest.dir/all' failedautotests/CMakeFiles/fallbackpackagetest.dir/build.make:86: recipe for target 'autotests/CMakeFiles/fallbackpackagetest.dir/fallbackpackagetest.cpp.o' failedmake[2]: *** [autotests/CMakeFiles/fallbackpackagetest.dir/fallbackpackagetest.cpp.o] Error 1autotests/CMakeFiles/plasmoidpackagetest.dir/build.make:62: recipe for target 'autotests/CMakeFiles/plasmoidpackagetest.dir/plasmoidstructure.cpp.o' failedmake[2]: *** [autotests/CMakeFiles/plasmoidpackagetest.dir/plasmoidstructure.cpp.o] Error 1make[1]: *** [autotests/CMakeFiles/querytest.dir/all] Error 2make[1]: *** Waiting for unfinished jobsCMakeFiles/Makefile2:396: recipe for target 'autotests/CMakeFiles/plasmoidpackagetest.dir/all' failedmake[1]: *** [autotests/CMakeFiles/plasmoidpackagetest.dir/all] Error 2[ 30%] Building CXX object autotests/CMakeFiles/packagestructuretest.dir/plasmoidstructure.cpp.o[ 30%] Building CXX object autotests/CMakeFiles/fallbackpackagetest.dir/__/src/kpackage/private/packages.cpp.o[ 32%] Building CXX object autotests/CMakeFiles/packagestructuretest.dir/packagestructuretest.cpp.o[ 34%] Building CXX object autotests/mockdepresolver/CMakeFiles/mockhandler.dir/mockhandler_automoc.cpp.oIn file included from /home/jenkins/workspace/Frameworks kpackage kf5-qt5 XenialQt5.7/autotests/plasmoidstructure.cpp:20:0:/home/jenkins/workspace/Frameworks kpackage kf5-qt5 XenialQt5.7/autotests/plasmoidstructure.h:23:39: fatal error: kpackage/packagestructure.h: No such file or directoryIn file included from /home/jenkins/workspace/Frameworks kpackage kf5-qt5 XenialQt5.7/src/kpackage/private/packages.cpp:20:0:/home/jenkins/workspace/Frameworks kpackage kf5-qt5 XenialQt5.7/src/kpackage/private/packages_p.h:23:39: fatal error: kpackage/packagestructure.h: No such file or directorycompilation terminated.compilation terminated.autotests/CMakeFiles/fallbackpackagetest.dir/build.make:110: recipe for target 

D6041: Port a bunch of classes away from Plasma::Package

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:563011436d5f: Port a bunch of classes away from 
Plasma::Package (authored by apol).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6041?vs=15015=15220

REVISION DETAIL
  https://phabricator.kde.org/D6041

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/packageurlinterceptortest.cpp
  autotests/packageurlinterceptortest.h
  src/plasma/package.cpp
  src/plasma/package.h
  src/plasma/pluginloader.cpp
  src/plasma/pluginloader.h
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/appletquickitem.h
  src/plasmaquick/configview.cpp
  src/plasmaquick/containmentview.cpp
  src/plasmaquick/packageurlinterceptor.cpp
  src/plasmaquick/packageurlinterceptor.h
  src/plasmaquick/private/appletquickitem_p.h
  src/plasmaquick/view.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp
  src/scriptengines/qml/plasmoid/wallpaperinterface.h

To: apol, #frameworks, #plasma, mart
Cc: davidedmundson, mart, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D6104: Use the right scope for the installpath variable

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:75031fb7a53a: Use the right scope for the installpath 
variable (authored by apol).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6104?vs=15181=15219

REVISION DETAIL
  https://phabricator.kde.org/D6104

AFFECTED FILES
  src/core/installation.cpp

To: apol, #frameworks, whiting, leinir

D6067: Make it possible to use QXmlStreamReader to read a KNS registry file

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:00aa6b29644b: Make it possible to use QXmlStreamReader to 
read a KNS registry file (authored by apol).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6067?vs=15176=15218

REVISION DETAIL
  https://phabricator.kde.org/D6067

AFFECTED FILES
  autotests/knewstuffentrytest.cpp
  src/core/cache.cpp
  src/core/entryinternal.cpp
  src/core/entryinternal.h

To: apol, #frameworks, leinir
Cc: leinir, dfaure

D6067: Make it possible to use QXmlStreamReader to read a KNS registry file

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  In https://phabricator.kde.org/D6067#114528, @apol wrote:
  
  > In https://phabricator.kde.org/D6067#114498, @leinir wrote:
  >
  > > On a similar note to handling comments, how does it now handle 
unknown/garbage tags? While it won't affect the cache code, it would 
potentially affect other things (ocs is not guaranteed to be perfectly formed, 
and it's one of the ways the framework's retained backwards compatibility). 
From what i can tell, this would assert when an unknown tag is encountered, 
right?
  >
  >
  > This is for .knsregistry files, not OCS. These files are generated by the 
very same class here.
  
  
  You are quite right, i forgot the attica content's not parsed using knscore's 
functions, just the staticxml provider... because i'm a silly person :) 
Obviously just fine, then, go for it!

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6067

To: apol, #frameworks, leinir
Cc: leinir, dfaure

Re: extra-cmake-modules in kdesupport?

[Harald Sitter]

On Sat, Jun 3, 2017 at 11:32 AM, David Faure  wrote:
> On mardi 30 mai 2017 16:18:42 CEST Aleix Pol wrote:
>> On Tue, May 30, 2017 at 4:10 PM, Luigi Toscano 
> wrote:
>> > On Tuesday, 30 May 2017 16:06:56 CEST Harald Sitter wrote:
>> >> Is there a reason ECM's project is placed in kdesupport rather than
>> >> frameworks?
>> >>
>> >> https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects/kdesupport/
>> >> ext ra-cmake-modules
>> >>
>> >> Seems a bit fishy at best and practically means that if ECM ever were
>> >> to get translations it wouldn't inherit the translation settings
>> >> applying to frameworks/*
>> >> https://cgit.kde.org/sysadmin/repo-metadata.git/tree/config/i18n_defaults
>> >> .js on
>> >>
>> >> Can we fix this or is this actually intentional?
>> >
>> > I think that we can fix that only if we define a tier 0 for Frameworks.
>> > Otherwise tier 1 frameworks wouldn't be able to depend on it, by
>> > definition.
>> That was actually the reason, as far as I remember. The plan was to
>> move things up to cmake at some point, which never happened because
>> we'd obviously have to require new versions of cmake all the time.
>>
>> Tier 0 works for me, I agree it's what it is anyway, they're even
>> released together.
>
> The initial reason was that ECM was supposed to have a separate release cycle.
> Then that changed, I just release both together.
>
> At this point I agree that it would make a lot of sense for ECM to be under
> frameworks rather than kdesupport. If someone takes care of making it happen
> (not today, I'm preparing a release), I'll adjust the release scripts
> accordingly.

Does anyone actually know what needs doing/adjustments to introduce tier 0?

HS

D6115: Update introspections (NM 1.8.0)

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R282:ffb40b433368: Update introspections (NM 1.8.0) (authored 
by jgrulich).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D6115?vs=15209=15211#toc

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6115?vs=15209=15211

REVISION DETAIL
  https://phabricator.kde.org/D6115

AFFECTED FILES
  src/dbus/activeconnectioninterface.h
  src/dbus/introspection/org.freedesktop.NetworkManager.Connection.Active.xml
  src/dbus/introspection/org.freedesktop.NetworkManager.xml

To: jgrulich
Cc: #frameworks

D6116: Add new stateChanged() signal to active connection

[Jan Grulich]

jgrulich created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  There is a new additional StateChanged() signal coming from NetworkManager 
with additional reason property so
  with that we can now check what was the reason for the changed state. Use 
this new signal when NM 1.8.0 is present
  and emit also the old one for backward compatibility.
  
  There is just one minor problem, with two stateChanged() signals you will 
need to specify to which signal you want
  to connect to when using Qt5 syntax for signals/slots and without that you 
won't compile current code, i.e. of plasma-nm

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6116

AFFECTED FILES
  src/activeconnection.cpp
  src/activeconnection.h
  src/activeconnection_p.h
  src/fakenetwork/activeconnection.h
  src/fakenetwork/fakenetwork.cpp
  src/vpnconnection.h

To: jgrulich
Cc: #frameworks

D6116: Add new stateChanged() signal to active connection

[Jan Grulich]

jgrulich added a reviewer: lvsouza.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D6116

To: jgrulich, lvsouza
Cc: #frameworks

D6115: Update introspections (NM 1.8.0)

[Jan Grulich]

jgrulich abandoned this revision.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D6115

To: jgrulich
Cc: #frameworks

D6115: Update introspections (NM 1.8.0)

[Jan Grulich]

jgrulich created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Add new stateChanged() signal to active connection
  
  There is a new additional StateChanged() signal coming from NetworkManager 
with additional reason property so
  with that we can now check what was the reason for the changed state. Use 
this new signal when NM 1.8.0 is present
  and emit also the old one for backward compatibility.
  
  There is just one minor problem, with two stateChanged() signals you will 
need to specify to which signal you want
  to connect to when using Qt5 syntax for signals/slots and without that you 
won't compile current code, i.e. of plasma-nm

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6115

AFFECTED FILES
  src/activeconnection.cpp
  src/activeconnection.h
  src/activeconnection_p.h
  src/dbus/activeconnectioninterface.h
  src/dbus/introspection/org.freedesktop.NetworkManager.Connection.Active.xml
  src/dbus/introspection/org.freedesktop.NetworkManager.xml
  src/fakenetwork/activeconnection.h
  src/fakenetwork/fakenetwork.cpp
  src/vpnconnection.h

To: jgrulich
Cc: #frameworks

D6067: Make it possible to use QXmlStreamReader to read a KNS registry file

[Aleix Pol Gonzalez]

apol added a comment.


  In https://phabricator.kde.org/D6067#114498, @leinir wrote:
  
  > On a similar note to handling comments, how does it now handle 
unknown/garbage tags? While it won't affect the cache code, it would 
potentially affect other things (ocs is not guaranteed to be perfectly formed, 
and it's one of the ways the framework's retained backwards compatibility). 
From what i can tell, this would assert when an unknown tag is encountered, 
right?
  
  
  This is for .knsregistry files, not OCS. These files are generated by the 
very same class here.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6067

To: apol, #frameworks
Cc: leinir, dfaure

Re: Review Request 122551: New feature: Open all recent files

[Thomas Murach]

> On Feb. 13, 2015, 12:06 a.m., Kevin Funk wrote:
> > You're aware that Kate (and any other decent editor) has session management 
> > which probably solves your issue? It saves the session when you close it, 
> > and re-opens all the files that had been opened.
> 
> Thomas Murach wrote:
> Sure, I use sessions quite frequently. To me the need to re-open many/all 
> recently opened files occurs _within_ sessions. One session (in my case) 
> corresponds to one project / code base containing usually many files, so I 
> don't have all of them open. Then if I think I'm done fixing a bug or 
> similar, I close files I won't need again in the next days, and the situation 
> described above has started.
> 
> Thomas Murach wrote:
> Hi, so, what's the status?
> 
> Thomas Murach wrote:
> Wow, this little discussion was dormant for quite a while now - let's 
> finish it. Personally I still think I'd like to have such a feature, every 
> once in a while I miss it. Accepting the patch is of course up to you, and I 
> won't insist on having it included.
> In case it is accepted: I haven't tested it since then, so one should 
> have another look.

Next use case: recently my X session crashed, so that (in this case) Kile (TeX 
editor) lost it's session information and started with a blank new file instead 
of the previous list of open files. So now I had to go and open all files one 
by one, instead of simply clicking "open all recent files".


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122551/#review75958
---


On Feb. 23, 2015, 11:52 p.m., Thomas Murach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122551/
> ---
> 
> (Updated Feb. 23, 2015, 11:52 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> I've always been looking for a feature (mostly in Kate et al.) to open all 
> recently opened files at once. Every once in a while I think I'm done with 
> some source code editing, realise that I'm not, and then have to click 
> through all files one by one. With this patch opening all files at once gets 
> possible. So much for the background. Still there are some open questions:
> 
> 1) Is such a feature wanted at all?
> 2) Is the code quality/style ok?
> 3) Last but not least: This patch will work nicely with kate, presumably also 
> with okular and some others, but I guess it will not work as expected with 
> Kaffeine, for example, as new files which are to be opened will not get 
> appended to a playlist but instead each file will get opened for an instance 
> and then be replaced by the next opened file. Possible solutions: In 
> principle it would be possible to add another signal passing a list of URLs 
> to applications, which then have to define a suitable slot. Alternatively 
> this patch could just not be applied and the feature I'm trying to introduce 
> could be added to kate only... (I don't prefer that option ;) )
> 
> So, what are your opinions, comments, ideas? Thanks in advance!
> 
> PS I hope the reviewer group "kdeframeworks" is the right one...
> 
> 
> Diffs
> -
> 
>   src/krecentfilesaction.h 06965d4 
>   src/krecentfilesaction.cpp 40fdf93 
>   src/krecentfilesaction_p.h 2c690a7 
> 
> Diff: https://git.reviewboard.kde.org/r/122551/diff/
> 
> 
> Testing
> ---
> 
> I don't run KF5 on a daily basis, but in a Docker session the patch works 
> nicely with Kate.
> 
> 
> Thanks,
> 
> Thomas Murach
> 
>

D6067: Make it possible to use QXmlStreamReader to read a KNS registry file

[Dan Leinir Turthra Jensen]

leinir added a comment.


  On a similar note to handling comments, how does it now handle 
unknown/garbage tags? While it won't affect the cache code, it would 
potentially affect other things (ocs is not guaranteed to be perfectly formed, 
and it's one of the ways the framework's retained backwards compatibility). 
From what i can tell, this would assert when an unknown tag is encountered, 
right?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6067

To: apol, #frameworks
Cc: leinir, dfaure

D6008: Give a parent to KMoreToolsMenuFactory menus

[Elvis Angelaccio]

elvisangelaccio updated this revision to Diff 15197.
elvisangelaccio added a comment.


  - Bumped @since

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6008?vs=14932=15197

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6008

AFFECTED FILES
  src/kmoretools/kmoretoolsmenufactory.cpp
  src/kmoretools/kmoretoolsmenufactory.h

To: elvisangelaccio, mart
Cc: #frameworks

D6104: Use the right scope for the installpath variable

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  Personally less fond of auto than you are... But, that is just me, and this 
is a framework, and it's fine :) A massive reduction in allocations is a very 
good thing, go for it :)

REPOSITORY
  R304 KNewStuff

BRANCH
  installedFiles2

REVISION DETAIL
  https://phabricator.kde.org/D6104

To: apol, #frameworks, whiting, leinir

D6102: KUrlRequester: Set NOTIFY signal to textChanged() for text property.

[Kevin Funk]

kfunk added a comment.


  +1 from my side -- Please wait for another +1 from another person.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D6102

To: arrowdodger, #frameworks
Cc: kfunk