D7367: Added Intel HEX file support for the Syntax highlighting database

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  I am happy beside one thing I missed: I think the file should be called 
intelhex.xml, given its for the intel hex format only (the name is already 
fine, did miss that the filename is only hex).
  Otherwise: very nice, thanks again for the contribution.

REVISION DETAIL
  https://phabricator.kde.org/D7367

To: martonmiklos, #framework_syntax_hightlighting, cullmann
Cc: dhaumann, cullmann, #frameworks, vkrause

D7443: Fix compilation on windows with editorconfig-c-core available

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I think this is more correct, just writing the unix libname was no good idea.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D7443

To: sars, cullmann, #kate
Cc: dhaumann, kwrite-devel, #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it

[Nathaniel Graham]

ngraham retitled this revision from "Populate UDS_CREATION_TIME on Linux if Qt 
version and kernel support it" to "Populate UDS_CREATION_TIME on Linux if Qt 
and kernel versions support it".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if Qt version and kernel support it

[Nathaniel Graham]

ngraham added a comment.


  Great, thanks guys. Thanks for bearing with me here. I'll see if I can test 
with the unreleased qtbase.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if Qt version and kernel support it

[Nathaniel Graham]

ngraham retitled this revision from "Populate UDS_CREATION_TIME on Linux if Qt 
version and Linux kernel support it (no effect if they don't) BUG: 286689" to 
"Populate UDS_CREATION_TIME on Linux if Qt version and kernel support it".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks

D7367: Added Intel HEX file support for the Syntax highlighting database

[Dominik Haumann]

dhaumann added a comment.


  @cullmann Since you seem to know this, please take care of this change 
request :-)

REVISION DETAIL
  https://phabricator.kde.org/D7367

To: martonmiklos, #framework_syntax_hightlighting
Cc: dhaumann, cullmann, #frameworks, vkrause

D7443: Fix compilation on windows with editorconfig-c-core available

[Dominik Haumann]

dhaumann added a comment.


  @cullmann Is this the right fix, or could this also be fixed in 
FindEditorConfig.cmake?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D7443

To: sars, cullmann, #kate
Cc: dhaumann, kwrite-devel, #frameworks

D7280: Add syntax highlighting for Metamath

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:2baf9eb98c4e: Add syntax highlighting for Metamath 
(authored by dhaumann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7280?vs=18373=18466

REVISION DETAIL
  https://phabricator.kde.org/D7280

AFFECTED FILES
  autotests/folding/test.mm.fold
  autotests/html/test.mm.html
  autotests/input/test.mm
  autotests/input/test.mm.syntax
  autotests/reference/test.mm.ref
  data/syntax/metamath.xml

To: aaronpuchert, #frameworks, dhaumann
Cc: dhaumann

D7280: Add syntax highlighting for Metamath

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Looks good to me. Will integrate this soon.
  
  By the way, you may want to apply for a KDE contributor account to commit 
your changes yourself, especially since you are providing patches already since 
April or so, see:
  https://community.kde.org/Infrastructure/Get_a_Developer_Account

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  metamath

REVISION DETAIL
  https://phabricator.kde.org/D7280

To: aaronpuchert, #frameworks, dhaumann
Cc: dhaumann

D7423: Populate UDS_CREATION_TIME on Linux if Qt version and Linux kernel support it (no effect if they don't) BUG: 286689

[David Faure]

dfaure added a comment.


  Ah, OK, I see.
  Well, still, you could test the patch by compiling qtbase dev (or by applying 
whichever Qt patch is necessary).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if Qt version and Linux kernel support it (no effect if they don't) BUG: 286689

[Luigi Toscano]

ltoscano added a comment.


  The title of the revision becomes the first line; all the rest (summary, 
test, reviewers) become the rest of the content, a blank separator line is 
added automatically. Please add the BUG: line in the summary, not in the title.
  Also, as the title becomes the first line, it would be nice to follow the 
usual git rules of length.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if Qt version and Linux kernel support it (no effect if they don't) BUG: 286689

[Nathaniel Graham]

ngraham added a comment.


  Noted! Thanks, Luigi. I'd like to add BUG: 286689 to the commit message on a 
separate line. Does the title of this revision become the commit message? If 
so, how do I add another line? The text field doesn't seem to support 
multi-line strings.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if Qt version and Linux kernel support it (no effect if they don't) BUG: 286689

[Nathaniel Graham]

ngraham retitled this revision from "Populate UDS_CREATION_TIME on Linux if Qt 
version and Linux kernel support it (no effect if they don't)" to "Populate 
UDS_CREATION_TIME on Linux if Qt version and Linux kernel support it (no effect 
if they don't) BUG: 286689".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if Qt version and Linux kernel support it (no effect if they don't)

[Nathaniel Graham]

ngraham retitled this revision from "Populate UDS_CREATION_TIME on Linux if QT 
version and Linux kernel support it (no effect if they don't)" to "Populate 
UDS_CREATION_TIME on Linux if Qt version and Linux kernel support it (no effect 
if they don't)".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if QT version and Linux kernel support it (no effect if they don't)

[Luigi Toscano]

ltoscano added a comment.


  I can't comment on the content of the patch, but about the commit message, in 
order to close a bug, use the syntax:
  
  BUG: nn
  
  while in order to add the commit as comment of a bug without closing it, use
  
  CCBUG: nn
  
  Both keyword should be in a separate line.
  
  Also, it's Qt, not QT.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if QT version and Linux kernel support it (no effect if they don't)

[Nathaniel Graham]

ngraham added a comment.


  This patch doesn't actually directly use statx(); it goes through QFile, 
which is used to populate the statbuf object. QT has gained support for using 
statx() in Linux where available in current git master 
, 
but that change hasn't landed in an actual released QT version yet.
  
  If you can point me to a way to test this, I'll be happy to.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if QT version and Linux kernel support it (no effect if they don't)

[David Faure]

dfaure added a comment.


  The commit log is inconsistent with the actual patch. It says "lack of a Qt 
version that supports this", but the patch doesn't use QFile at all, it uses 
statx. Either way, the patch can be tested, no?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: #frameworks

D7443: Fix compilation on windows with editorconfig-c-core available

[Kåre Särs]

sars created this revision.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  On Windows the library was found during config, but not during compilation 
without the variable EditorConfig_LIBRARIES.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D7443

AFFECTED FILES
  src/CMakeLists.txt

To: sars, cullmann, #kate
Cc: kwrite-devel, #frameworks

KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.7 - Build # 78 - Fixed!

[no-reply]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.7/78/
 Project:
Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.7
 Date of build:
Sun, 20 Aug 2017 19:15:23 +
 Build duration:
2 min 58 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 8 test(s)

build.log
Description: Binary data

KDE CI: Frameworks syntax-highlighting kf5-qt5 XenialQt5.7 - Build # 80 - Fixed!

[no-reply]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20XenialQt5.7/80/
 Project:
Frameworks syntax-highlighting kf5-qt5 XenialQt5.7
 Date of build:
Sun, 20 Aug 2017 19:15:23 +
 Build duration:
3 min 11 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)92%
(36/39)92%
(36/39)85%
(2111/2490)69%
(1559/2263)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)97%
(501/515)60%
(319/534)src.indexer100%
(1/1)100%
(1/1)72%
(60/83)77%
(75/98)src.lib90%
(27/30)90%
(27/30)82%
(1550/1892)71%
(1165/1631)

build.log
Description: Binary data

D7439: Don't clear Qt's SSL CA certificate store

[Volker Krause]

vkrause created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  This breaks all subsequent SSL connections using QSslSocket or QNAM.
  
  Thiago said about this on #kde-devel: "in the old days, it used to be
  because Qt shipped with a very old database, we haven't done that in
  8 years".

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7439

AFFECTED FILES
  src/core/ksslcertificatemanager.cpp

To: vkrause, #frameworks

D7010: KSqueezedTextLabel: call updateGeometry() when text changes

[Henrik Fehlauer]

rkflx added a comment.


  Probably related to 
https://phabricator.kde.org/R32:3e530e780b596e9505b66e1ae7b1044d335adb07 (I 
guess Phabricator only adds "mentions" for shortlinks like Dxxx, but not full 
URLs?).

REVISION DETAIL
  https://phabricator.kde.org/D7010

To: brauch, cfeck, rkflx
Cc: dhaumann, aacid, #frameworks

Minutes GSoC meeting

[Elvis Angelaccio]

Present: me, chinmoy, shortstheory

Minutes in the attachment.

Cheers,
Elvis2017-08-20 09:01:22 eangMeeting!
2017-08-20 09:01:27 chinmoy[m]  yes
2017-08-20 09:02:11 eanglet's start then
2017-08-20 09:03:44 chinmoy[m]  Didn't do much this week due to college 
:(
2017-08-20 09:04:14 chinmoy[m]  Mostly fixed the issues in my diffs
2017-08-20 09:04:51 chinmoy[m]  And got my fd sharing code reveiwed
2017-08-20 09:05:38 chinmoy[m]  here I posted my code for review 
https://codereview.stackexchange.com/questions/173306/sharing-file-descriptor-between-an-under-privileged-and-a-privileged-process-us
2017-08-20 09:06:19 chinmoy[m]  eang have a look and tell me if you 
want to add something
2017-08-20 09:07:15 IrcsomeBot   yup
2017-08-20 09:09:26 eanggood idea, the more eyes on it, the better
2017-08-20 09:10:00 chinmoy[m]  that's what i thought
2017-08-20 09:11:20 eangchinmoy: have you seen 
https://phabricator.kde.org/T6561#106742 ?
2017-08-20 09:11:21 sKreamerTask 6561 "Polkit support in KIO" 
[Open,High] {Frameworks} https://phabricator.kde.org/T6561
2017-08-20 09:11:35 eangcan you confirm that PrivilegeExecution will be 
a no-op on windows?
2017-08-20 09:12:04 chinmoy[m]  it will be
2017-08-20 09:12:59 chinmoy[m]  execWithElevatedPrivilege will be 
called in windows as well but it will return false there
2017-08-20 09:13:27 eangok that's good
2017-08-20 09:17:43 eangchinmoy: I have a question, after I upgraded to 
KF5.37 and rebuilt your kio fork, kio_file dies
2017-08-20 09:17:58 eangQ_ASSERT(d->appConnection.inited()); in 
slavebase.cpp:283
2017-08-20 09:18:12 eanghave you ever seen this?
2017-08-20 09:18:38 chinmoy[m]  I have but not recently
2017-08-20 09:18:47 chinmoy[m]  I mean four weeks back
2017-08-20 09:20:53 chinmoy[m]  I will look into it.
2017-08-20 09:22:19 eangok thanks, weird error
2017-08-20 09:22:39 chinmoy[m]  I have prepared some unit tests: D7430. 
can you tell me if I am doing anything wrong?
2017-08-20 09:22:40 sKreamerDiff 7430 "Add unit test" [Needs 
Review] https://phabricator.kde.org/D7430
2017-08-20 09:26:46 eanglooks good to me, you can put it on for review
2017-08-20 09:33:31 chinmoy[m]  eang, I have nothing else to add.
2017-08-20 09:34:30 chinmoy[m]  anything you want to say
2017-08-20 09:34:44 eangso, August 21 - 29, 2017 => Students Submit 
Code and Evaluations
2017-08-20 09:35:05 eangremember that you need to update 
https://community.kde.org/GSoC/2017/StatusReports/chinmoyrp
2017-08-20 09:35:30 chinmoy[m]  sure.
2017-08-20 09:36:11 eangwhat's the status of the dolphin patch? will be 
ready before the 29th?
2017-08-20 09:36:27 eangwe have one more meeting before the deadline
2017-08-20 09:38:16 chinmoy[m]  I haven't had time to work on dolphin 
patch yet
2017-08-20 09:43:26 chinmoy[m]  judging from the work left It should 
take one day or two days at most to complete the dolphin patch.
2017-08-20 09:43:41 chinmoy[m]  only if we exclude mass rename
2017-08-20 09:45:50 eangok, so is one more meeting enough for you? we 
could also re-schedule to have two
2017-08-20 09:46:09 chinmoy[m]  one should do
2017-08-20 09:46:40 eangall right, so next meeting Saturday 26th
2017-08-20 09:46:47 chinmoy[m]  ok
2017-08-20 09:46:57 eangthat's all from my side
2017-08-20 09:47:10 eangmeeting over!
2017-08-20 09:47:17 chinmoy[m]  sure