D9027: Make it compile with QT_NO_CAST_FROM_ASCII

[Laurent Montel]

mlaurent updated this revision to Diff 23069.
mlaurent marked 5 inline comments as done.
mlaurent added a comment.


  - Fix comment found by david

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9027?vs=23062=23069

BRANCH
  make_it_compile_with_QT_NO_CAST_FROM_ASCII

REVISION DETAIL
  https://phabricator.kde.org/D9027

AFFECTED FILES
  CMakeLists.txt
  src/knotificationmanager.cpp
  src/knotifyconfig.cpp
  src/kstatusnotifieritem.cpp
  src/notifybyaudio.cpp
  src/notifybyexecute.cpp
  src/notifybyflatpak.cpp
  src/notifybylogfile.cpp
  src/notifybypopup.cpp
  src/notifybytts.cpp
  tests/knotificationdbustest.cpp

To: mlaurent, dfaure
Cc: #frameworks

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 69 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/69/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
 Date of build:
Tue, 28 Nov 2017 07:28:50 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_stat_unittestFailed: TestSuite.kshelltest

KDE CI: Frameworks kconfigwidgets kf5-qt5 FreeBSDQt5.7 - Build # 39 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kconfigwidgets%20kf5-qt5%20FreeBSDQt5.7/39/
 Project:
Frameworks kconfigwidgets kf5-qt5 FreeBSDQt5.7
 Date of build:
Tue, 28 Nov 2017 07:28:50 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 152 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/152/
 Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
 Date of build:
Tue, 28 Nov 2017 07:28:50 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

D9027: Make it compile with QT_NO_CAST_FROM_ASCII

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> knotificationmanager.cpp:87
>  if (!runtimeDir.isEmpty()) {
> -inSandbox = QFileInfo::exists(QFile::encodeName(runtimeDir) + 
> QLatin1String("/flatpak-info"));
> +inSandbox = 
> QFileInfo::exists(QString::fromUtf8(QFile::encodeName(QString::fromUtf8(runtimeDir)))
>  + QLatin1String("/flatpak-info"));
>  }

Ouch that's a lot of conversions.

Remove it all, and fix the `encodeName` to `decodeName` as it should have been.

> kstatusnotifieritem.cpp:48
>  
> -static const char s_statusNotifierWatcherServiceName[] = 
> "org.kde.StatusNotifierWatcher";
> +static const QString s_statusNotifierWatcherServiceName = 
> QStringLiteral("org.kde.StatusNotifierWatcher");
>  static const int s_legacyTrayIconSize = 24;

static QStrings create startup code. Leave it as a char[], do the conversions 
at runtime.

> notifybyflatpak.cpp:40
>  
> -static const char portalDbusServiceName[] = "org.freedesktop.portal.Desktop";
> -static const char portalDbusInterfaceName[] = 
> "org.freedesktop.portal.Notification";
> -static const char portalDbusPath[] = "/org/freedesktop/portal/desktop";
> +static const QString portalDbusServiceName = 
> QStringLiteral("org.freedesktop.portal.Desktop");
> +static const QString portalDbusInterfaceName = 
> QStringLiteral("org.freedesktop.portal.Notification");

same

> notifybypopup.cpp:61
>  
> -static const char dbusServiceName[] = "org.freedesktop.Notifications";
> -static const char dbusInterfaceName[] = "org.freedesktop.Notifications";
> -static const char dbusPath[] = "/org/freedesktop/Notifications";
> +static const QString dbusServiceName = 
> QStringLiteral("org.freedesktop.Notifications");
> +static const QString dbusInterfaceName = 
> QStringLiteral("org.freedesktop.Notifications");

same

> knotificationdbustest.cpp:29
>  
> -static const char dbusServiceName[] = "org.freedesktop.Notifications";
> -static const char dbusInterfaceName[] = "org.freedesktop.Notifications";
> -static const char dbusPath[] = "/org/freedesktop/Notifications";
> +static const QString dbusServiceName = 
> QStringLiteral("org.freedesktop.Notifications");
> +static const QString dbusInterfaceName = 
> QStringLiteral("org.freedesktop.Notifications");

same

Alternatively, if they are used only once, maybe just move each QStringLiteral 
to where it's used.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D9027

To: mlaurent, dfaure
Cc: #frameworks

D9018: Don't cause circular linking on Windows

[Alexey Min]

alexeymin added a comment.


  So it resulted in something like aspell.dll reuiring aspell.dll?
  What is the fastest way to test this?

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D9018

To: leinir, #frameworks
Cc: alexeymin, apol, #frameworks

D9027: Make it compile with QT_NO_CAST_FROM_ASCII

[Laurent Montel]

mlaurent created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

TEST PLAN
  compile execute autotest

REPOSITORY
  R289 KNotifications

BRANCH
  make_it_compile_with_QT_NO_CAST_FROM_ASCII

REVISION DETAIL
  https://phabricator.kde.org/D9027

AFFECTED FILES
  CMakeLists.txt
  src/knotificationmanager.cpp
  src/knotifyconfig.cpp
  src/kstatusnotifieritem.cpp
  src/notifybyaudio.cpp
  src/notifybyexecute.cpp
  src/notifybyflatpak.cpp
  src/notifybylogfile.cpp
  src/notifybypopup.cpp
  src/notifybytts.cpp
  tests/knotificationdbustest.cpp

To: mlaurent
Cc: #frameworks

D9027: Make it compile with QT_NO_CAST_FROM_ASCII

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D9027

To: mlaurent, dfaure
Cc: #frameworks

KDE CI: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.9 - Build # 49 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20WindowsMSVCQt5.9/49/
 Project:
Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Tue, 28 Nov 2017 04:06:34 +
 Build duration:
56 min and counting
   JUnit Tests
  Name: (root) Failed: 8 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.kateindenttest_testCppstyleFailed: TestSuite.kateindenttest_testCstyleFailed: TestSuite.kateindenttest_testRubyFailed: TestSuite.katetextbuffertestFailed: TestSuite.kateview_testFailed: TestSuite.messagetestFailed: TestSuite.movingrange_testFailed: TestSuite.vimode_keys

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 3 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/3/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 28 Nov 2017 04:06:34 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 63 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.katefoldingtestFailed: TestSuite.katesyntaxtestFailed: TestSuite.movingrange_testFailed: TestSuite.vimode_view
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)89%
(299/337)89%
(299/337)68%
(33689/49224)52%
(17514/33916)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(49/49)100%
(49/49)93%
(4279/4624)49%
(2108/4316)autotests.src.vimode88%
(14/16)88%
(14/16)96%
(5297/5530)51%
(866/1698)src.buffer88%
(15/17)88%
(15/17)91%
(1704/1881)77%
(1326/1724)src.completion100%
(16/16)100%
(16/16)57%
(1778/3116)43%
(1242/2897)src.completion.expandingtree100%
(5/5)100%
(5/5)40%
(186/461)22%
(79/362)src.dialogs0%
(0/4)0%
(0/4)0%
(0/827)0%
(0/240)src.document100%
(4/4)100%
(4/4)59%
(1880/3193)48%
(1681/3485)src.export100%
(4/4)100%
(4/4)86%
(107/125)69%
(118/170)src.include.ktexteditor100%
(14/14)100%
(14/14)92%
(227/248)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(170/420)37%
(103/275)src.part0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/296)src.render100%
(9/9)100%
(9/9)76%
(922/1219)65%
(617/944)src.schema22%
(2/9)22%
(2/9)1%
(21/1501)1%
(6/729)src.script100%
(17/17)100%
(17/17)70%
(739/1057)59%
(307/519)src.search100%
(7/7)100%
(7/7)73%
(1099/1501)63%
(609/965)src.spellcheck75%
   

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 3 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/3/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
 Date of build:
Tue, 28 Nov 2017 04:06:34 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 63 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.katefoldingtestFailed: TestSuite.katesyntaxtestFailed: TestSuite.movingrange_testFailed: TestSuite.vimode_view
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)89%
(299/337)89%
(299/337)68%
(33701/49230)52%
(17514/33918)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(49/49)100%
(49/49)93%
(4290/4627)49%
(2110/4316)autotests.src.vimode88%
(14/16)88%
(14/16)96%
(5297/5530)51%
(866/1698)src.buffer88%
(15/17)88%
(15/17)91%
(1704/1881)77%
(1326/1724)src.completion100%
(16/16)100%
(16/16)57%
(1778/3116)43%
(1242/2897)src.completion.expandingtree100%
(5/5)100%
(5/5)40%
(186/461)22%
(79/362)src.dialogs0%
(0/4)0%
(0/4)0%
(0/827)0%
(0/240)src.document100%
(4/4)100%
(4/4)59%
(1880/3193)48%
(1681/3485)src.export100%
(4/4)100%
(4/4)86%
(107/125)69%
(118/170)src.include.ktexteditor100%
(14/14)100%
(14/14)92%
(227/248)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(170/420)37%
(103/275)src.part0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/296)src.render100%
(9/9)100%
(9/9)76%
(922/1219)65%
(617/944)src.schema22%
(2/9)22%
(2/9)1%
(21/1501)1%
(6/729)src.script100%
(17/17)100%
(17/17)70%
(739/1057)59%
(307/519)src.search100%
(7/7)100%
(7/7)73%
(1099/1501)63%
(609/965)src.spellcheck75%
 

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 102 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/102/
 Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
 Date of build:
Tue, 28 Nov 2017 04:06:34 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.katesyntaxtest

KDE CI: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.9 - Build # 39 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20WindowsMSVCQt5.9/39/
 Project:
Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Tue, 28 Nov 2017 04:06:14 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.kmoretoolstest

KDE CI: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.9 - Build # 119 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.9/119/
 Project:
Frameworks kirigami kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Tue, 28 Nov 2017 04:06:00 +
 Build duration:
3 min 35 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

KDE CI: Frameworks knewstuff kf5-qt5 FreeBSDQt5.7 - Build # 78 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20FreeBSDQt5.7/78/
 Project:
Frameworks knewstuff kf5-qt5 FreeBSDQt5.7
 Date of build:
Tue, 28 Nov 2017 04:06:14 +
 Build duration:
2 min 13 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 6 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/6/
 Project:
Frameworks kirigami kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 28 Nov 2017 04:06:00 +
 Build duration:
1 min 24 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/4)0%
(0/12)0%
(0/12)0%
(0/639)0%
(0/439)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsexamples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)examples.galleryapp0%
(0/1)0%
(0/1)0%
(0/10)0%
(0/4)src0%
(0/5)0%
(0/5)0%
(0/315)0%
(0/301)src.libkirigami0%
(0/5)0%
(0/5)0%
(0/306)0%
(0/134)

D8007: popplerextractor: don't try to guess the title if there isn't one.

[Anthony Fieroni]

anthonyfieroni added a comment.


  About me it's a good feature after all. It should be simplified e.g. only 
when title is empty and parse only header of first page.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D8007

To: flameeyes, #frameworks, mgallien
Cc: anthonyfieroni, mgallien, vhanda, ngraham, #frameworks

KDE CI: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9 - Build # 26 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.9/26/
 Project:
Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Tue, 28 Nov 2017 02:00:50 +
 Build duration:
7 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 22 test(s)Failed: TestSuite.kdelibs4configmigratortestFailed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.krandomtest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 9 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/9/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 28 Nov 2017 02:00:50 +
 Build duration:
6 min 21 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kshelltest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 7 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/7/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
 Date of build:
Tue, 28 Nov 2017 02:00:50 +
 Build duration:
5 min 56 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kshelltest

D9018: Don't cause circular linking on Windows

[Aleix Pol Gonzalez]

apol added a comment.


  +1

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D9018

To: leinir, #frameworks
Cc: apol, #frameworks

KDE CI: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.9 - Build # 38 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20WindowsMSVCQt5.9/38/
 Project:
Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Mon, 27 Nov 2017 21:43:18 +
 Build duration:
1 hr 3 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.kmoretoolstest

D9012: Revert "Detach before setting the d pointer"

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:bcb7dd628811: Revert Detach before setting the d 
pointer (authored by kossebau).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9012?vs=22979=23055

REVISION DETAIL
  https://phabricator.kde.org/D9012

AFFECTED FILES
  src/core/entryinternal.cpp

To: kossebau, whiting, leinir, apol
Cc: #frameworks

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 10 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/10/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 27 Nov 2017 21:01:38 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report62%
(21/34)65%
(275/425)65%
(275/425)51%
(29442/58242)36%
(17120/47438)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(66/68)97%
(66/68)91%
(7838/8639)48%
(4859/10032)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src.core82%
(97/118)82%
(97/118)55%
(7814/14088)48%
(4600/9580)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(29/37)78%
(29/37)49%
(3745/7681)32%
(1534/4839)src.gui0%
(0/2)0%
(0/2)0%
(0/105)0%
(0/74)src.ioslaves.file100%
(2/2)100%
(2/2)53%
(434/819)44%
(324/736)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)39%
(1705/4337)32%
(1261/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1332)55%
(656/1184)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%
(725/1385)46%
(449/968)src.ioslaves.trash.tests67%
(2/3)67%
(2/3)88%
(709/802)47%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 10 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/10/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 27 Nov 2017 21:01:38 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report65%
(22/34)65%
(278/425)65%
(278/425)51%
(29967/58265)37%
(17505/47514)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(66/68)97%
(66/68)92%
(7963/8640)49%
(4951/10032)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src.core83%
(98/118)83%
(98/118)57%
(8054/14105)49%
(4742/9584)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(29/37)78%
(29/37)49%
(3744/7681)32%
(1533/4839)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(2/2)100%
(2/2)53%
(434/819)44%
(324/736)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1332)55%
(656/1184)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%
(725/1385)46%
(449/968)src.ioslaves.trash.tests67%
(2/3)67%
(2/3)88%
(709/802)47%

D8007: popplerextractor: don't try to guess the title if there isn't one.

[Matthieu Gallien]

mgallien added a comment.


  @vhanda Thanks a lot to have took time to answer. I really appreciate your 
help.
  I took a long time to understand that fixing or modifying the extractors is 
not enough to get modified data when querying Baloo. I would like to fix that 
in the future.
  
  Do you have any idea how to do that while still preserving the performance of 
Baloo and a good experience for the users ?
  
  With regard to this diff, I hope that testing a lot of PDF could help 
deciding on it. I am still a bit on the side of having the same behavior in 
Okular and KFileMetaData.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D8007

To: flameeyes, #frameworks, mgallien
Cc: mgallien, vhanda, ngraham, #frameworks

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 150 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/150/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
 Date of build:
Mon, 27 Nov 2017 21:01:38 +
 Build duration:
4 min 59 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest

KDE CI: Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9 - Build # 18 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20WindowsMSVCQt5.9/18/
 Project:
Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Mon, 27 Nov 2017 20:36:23 +
 Build duration:
11 min and counting
   CONSOLE OUTPUT
  [...truncated 241.37 KB...][ 79%] Built target propertyinfotestScanning dependencies of target externalextractortest[ 80%] Building CXX object autotests/CMakeFiles/externalextractortest.dir/__/src/externalextractor.cpp.obj[ 82%] Building CXX object autotests/CMakeFiles/externalextractortest.dir/externalextractortest.cpp.obj[ 82%] Building CXX object autotests/CMakeFiles/externalextractortest.dir/kfilemetadata_debug.cpp.obj[ 83%] Building CXX object autotests/CMakeFiles/externalextractortest.dir/externalextractortest_autogen/mocs_compilation.cpp.objexternalextractortest.cppmocs_compilation.cppkfilemetadata_debug.cppexternalextractor.cpp[ 84%] Linking CXX executable ..\bin\externalextractortest.exe[ 84%] Built target externalextractortestScanning dependencies of target externalwritertest[ 86%] Building CXX object autotests/CMakeFiles/externalwritertest.dir/externalwritertest.cpp.obj[ 86%] Building CXX object autotests/CMakeFiles/externalwritertest.dir/__/src/externalwriter.cpp.obj[ 87%] Building CXX object autotests/CMakeFiles/externalwritertest.dir/kfilemetadata_debug.cpp.obj[ 88%] Building CXX object autotests/CMakeFiles/externalwritertest.dir/externalwritertest_autogen/mocs_compilation.cpp.objexternalwritertest.cppmocs_compilation.cppkfilemetadata_debug.cppexternalwriter.cpp[ 89%] Linking CXX executable ..\bin\externalwritertest.exe[ 89%] Built target externalwritertestScanning dependencies of target extractorcollectiontest[ 90%] Building CXX object autotests/CMakeFiles/extractorcollectiontest.dir/extractorcollectiontest.cpp.obj[ 91%] Building CXX object autotests/CMakeFiles/extractorcollectiontest.dir/extractorcollectiontest_autogen/mocs_compilation.cpp.objextractorcollectiontest.cppmocs_compilation.cpp[ 92%] Linking CXX executable ..\bin\extractorcollectiontest.exe[ 92%] Built target extractorcollectiontestScanning dependencies of target usermetadatawritertest[ 93%] Building CXX object autotests/CMakeFiles/usermetadatawritertest.dir/usermetadatawritertest.cpp.obj[ 95%] Building CXX object autotests/CMakeFiles/usermetadatawritertest.dir/__/src/usermetadata.cpp.obj[ 95%] Building CXX object autotests/CMakeFiles/usermetadatawritertest.dir/usermetadatawritertest_autogen/mocs_compilation.cpp.objusermetadatawritertest.cppC:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9\autotests\usermetadatawritertest.cpp(24): fatal error C1083: Cannot open include file: 'fileref.h': No such file or directoryjom: C:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9\build\autotests\CMakeFiles\usermetadatawritertest.dir\build.make [autotests\CMakeFiles\usermetadatawritertest.dir\usermetadatawritertest.cpp.obj] Error 2usermetadata.cppmocs_compilation.cppc:\ci\workspace\frameworks kfilemetadata kf5-qt5 windowsmsvcqt5.9\src\xattr_p.h(144): warning C4267: 'argument': conversion from 'size_t' to 'DWORD', possible loss of dataC:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9\src\usermetadata.cpp(34): warning C4273: 'KFileMetaData::UserMetaData::UserMetaData': inconsistent dll linkagec:\ci\workspace\frameworks kfilemetadata kf5-qt5 windowsmsvcqt5.9\src\usermetadata.h(32): note: see previous definition of '{ctor}'C:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9\src\usermetadata.cpp(40): warning C4273: 'KFileMetaData::UserMetaData::UserMetaData': inconsistent dll linkagec:\ci\workspace\frameworks kfilemetadata kf5-qt5 windowsmsvcqt5.9\src\usermetadata.h(33): note: see previous definition of '{ctor}'C:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9\src\usermetadata.cpp(45): warning C4273: 'KFileMetaData::UserMetaData::~UserMetaData': inconsistent dll linkagec:\ci\workspace\frameworks kfilemetadata kf5-qt5 windowsmsvcqt5.9\src\usermetadata.h(34): note: see previous definition of '{dtor}'C:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9\src\usermetadata.cpp(50): warning C4273: 'KFileMetaData::UserMetaData::operator =': inconsistent dll linkagec:\ci\workspace\frameworks kfilemetadata kf5-qt5 windowsmsvcqt5.9\src\usermetadata.h(39): note: see previous definition of '='C:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9\src\usermetadata.cpp(56): warning C4273: 'KFileMetaData::UserMetaData::filePath': inconsistent dll linkagec:\ci\workspace\frameworks kfilemetadata kf5-qt5 windowsmsvcqt5.9\src\usermetadata.h(41): note: see previous definition of 'filePath'C:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9\src\usermetadata.cpp(61): warning C4273: 'KFileMetaData::UserMetaData::setTags': inconsistent dll linkagec:\ci\workspace\frameworks kfilemetadata kf5-qt5 windowsmsvcqt5.9\src\usermetadata.h(44): note: see 

D9004: Input validation of SubJobs

[Anthony Fieroni]

anthonyfieroni accepted this revision.
anthonyfieroni added inline comments.

INLINE COMMENTS

> kcompositejob.cpp:98
>  {
> +Q_D(KCompositeJob);
>  // Did job have an error ?

This is not needed anymore.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D9004

To: jtamate, #frameworks, dfaure, anthonyfieroni
Cc: anthonyfieroni

D9004: Input validation of SubJobs

[Jaime Torres Amate]

jtamate updated this revision to Diff 23049.
jtamate added a comment.


  - Input validation of SubJobs and disconnect signals
  
I can't reproduce the bug. Probably the job already deleted (the crash in 
the bug) and the signals not disconnected where the problem. It doesn't crash 
for me even without the kio patch.

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9004?vs=23046=23049

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9004

AFFECTED FILES
  src/lib/jobs/kcompositejob.cpp

To: jtamate, #frameworks, dfaure, anthonyfieroni
Cc: anthonyfieroni

D9004: Input validation of SubJobs

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kcompositejob.cpp:104
>  setErrorText(job->errorText());
> -emitResult();
> +// Finish this KCompositeJob only if it has no subjobs
> +if (d->subjobs.isEmpty()) {

David mean to finish job on first error, i.e. to not change this behavior. Can 
you verify that without empty check here and in KIO bug is fixed?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D9004

To: jtamate, #frameworks, dfaure, anthonyfieroni
Cc: anthonyfieroni

D9004: Input validation of SubJobs

[Jaime Torres Amate]

jtamate updated this revision to Diff 23046.
jtamate added a comment.


  - Addressed comments by dfaure and anthonyfieroni

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9004?vs=22948=23046

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9004

AFFECTED FILES
  src/lib/jobs/kcompositejob.cpp

To: jtamate, #frameworks, dfaure, anthonyfieroni
Cc: anthonyfieroni

D9012: Revert "Detach before setting the d pointer"

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  unbreakEntryInternalDataSyncing

REVISION DETAIL
  https://phabricator.kde.org/D9012

To: kossebau, whiting, leinir, apol
Cc: #frameworks

D9012: Revert "Detach before setting the d pointer"

[Friedrich W . H . Kossebau]

kossebau added a comment.


  In https://phabricator.kde.org/D9012#172387, @leinir wrote:
  
  > Quicker is better here, i think... Perhaps it is worth adding the 
documentation we discussed as well in this review? Thinking about making it 
easier to track the history and whatnot of what happened and why...
  
  
  Myself I have no time left to invest into this. And would be happy to see at 
least the regression finally fixed, before slipping in yet another release in 
some days. Remember, this breaks core functionality of knewstuff across 
multiple applications (everywhere at least where files are uncompressed after 
the download). Rendering KNewStuff completely useless in those apps, and also 
making the apps themselves look bad and broken.
  
  I would propose to have those improve the API documentation who introduced 
the regression. As they know best why they missed the bit about things being 
explicitly-shared by design.
  
  Actually I am already a bit annoyed that I have to push for fixing a 
regression I did not introduce myself.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D9012

To: kossebau, whiting, leinir, apol
Cc: #frameworks

D9019: [Calendar] Adjust the calendar toolbar anchors

[David Edmundson]

davidedmundson added a comment.


  > but I did not contribute for a long time
  
  Good to have you back!

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  upstreaming

REVISION DETAIL
  https://phabricator.kde.org/D9019

To: akulichalexandr, #plasma, broulik
Cc: davidedmundson, broulik, plasma-devel, #plasma, #frameworks, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9019: [Calendar] Adjust the calendar toolbar anchors

[Alexandr Akulich]

akulichalexandr added a comment.


  In https://phabricator.kde.org/D9019#172612, @broulik wrote:
  
  > Thanks! It's the little things that make it feel polished :)
  >
  > Do you have commit access?
  
  
  Yes, I have the access, but I did not contribute for a long time and still 
have to get used to Phabricator.
  Thank you for the review, I'll push the commit once I'll figure out how to do 
it properly nowadays. :-)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  upstreaming

REVISION DETAIL
  https://phabricator.kde.org/D9019

To: akulichalexandr, #plasma, broulik
Cc: broulik, plasma-devel, #plasma, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.9 - Build # 118 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.9/118/
 Project:
Frameworks kirigami kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Mon, 27 Nov 2017 15:14:08 +
 Build duration:
2 hr 5 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

D9019: [Calendar] Adjust the calendar toolbar anchors

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Thanks! It's the little things that make it feel polished :)
  
  Do you have commit access?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  upstreaming

REVISION DETAIL
  https://phabricator.kde.org/D9019

To: akulichalexandr, #plasma, broulik
Cc: broulik, plasma-devel, #plasma, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8858: Fix testWaylandFullscreenShell.

[Christophe Giboudeaux]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:7cd465a3bad3: Fix testWaylandFullscreenShell. (authored 
by cgiboudeaux).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D8858?vs=22546=23037#toc

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8858?vs=22546=23037

REVISION DETAIL
  https://phabricator.kde.org/D8858

AFFECTED FILES
  autotests/client/CMakeLists.txt

To: cgiboudeaux, graesslin
Cc: plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D8367: Hidding place groups implementation in KFilePlacesModel

[Franck Arrecot]

franckarrecot marked 15 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8367

To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent
Cc: mwolff, ngraham, mlaurent, #frameworks

D9019: [Calendar] Adjust the calendar toolbar anchors

[Alexandr Akulich]

akulichalexandr edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9019

To: akulichalexandr, #plasma
Cc: plasma-devel, #plasma, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8998: Add FindSeccomp to find-modules

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  Mostly good. Last question : is the version important ? If yes, please add an 
additional way to get the version if Seccomp_VERSION is empty. (you can parse 
seccomp.h to find it, look at the other Find*.cmake modules for examples)

INLINE COMMENTS

> FindSeccomp.cmake:3
> +# FindSeccomp
> +# -
> +#

nitpick : missing 2 dashes

> FindSeccomp.cmake:51
> +
> +find_package(PkgConfig)
> +pkg_check_modules(PKG_Libseccomp QUIET libseccomp)

Also add the QUIET keyword here

> FindSeccomp.cmake:54
> +
> +set(Seccomp_DEFINITIONS ${PKG_Libseccomp_CFLAGS_OTHER})
> +set(Seccomp_VERSION ${PKG_Libseccomp_VERSION})

This doesn't look useful. Looking at my pkgconfig file, the cflags just adds 
the include dir.

If neither baloo or kscreenlocker use it, just remove this line and #85.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8998

To: davidk, graesslin
Cc: cgiboudeaux, #frameworks, #build_system

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.7 - Build # 2 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.7/2/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 27 Nov 2017 16:24:22 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.kwayland-testWaylandSurfaceFailed: TestSuite.kwayland-testXdgForeign
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report57%
(4/7)88%
(207/234)88%
(207/234)80%
(21399/26891)49%
(10491/21373)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client95%
(35/37)95%
(35/37)91%
(9838/10850)46%
(6759/14723)autotests.server100%
(5/5)100%
(5/5)99%
(359/362)49%
(220/446)src.client95%
(63/66)95%
(63/66)82%
(5085/6209)64%
(1648/2563)src.server97%
(104/107)97%
(104/107)84%
(6117/7320)63%
(1864/2962)src.tools0%
(0/2)0%
(0/2)0%
(0/779)0%
(0/346)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/16)tests0%
(0/14)0%
(0/14)0%
(0/1251)0%
(0/317)

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 2 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/2/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 27 Nov 2017 16:24:22 +
 Build duration:
9 min 45 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.kwayland-testWaylandSurfaceFailed: TestSuite.kwayland-testXdgForeign
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report57%
(4/7)88%
(207/234)88%
(207/234)80%
(21400/26891)49%
(10492/21373)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client95%
(35/37)95%
(35/37)91%
(9838/10850)46%
(6759/14723)autotests.server100%
(5/5)100%
(5/5)99%
(359/362)49%
(220/446)src.client95%
(63/66)95%
(63/66)82%
(5085/6209)64%
(1648/2563)src.server97%
(104/107)97%
(104/107)84%
(6118/7320)63%
(1865/2962)src.tools0%
(0/2)0%
(0/2)0%
(0/779)0%
(0/346)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/16)tests0%
(0/14)0%
(0/14)0%
(0/1251)0%
(0/317)

D8858: Fix testWaylandFullscreenShell.

[Martin Flöser]

graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8858

To: cgiboudeaux, graesslin
Cc: plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.7 - Build # 61 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.7/61/
 Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.7
 Date of build:
Mon, 27 Nov 2017 16:24:23 +
 Build duration:
8 min 17 sec and counting
   JUnit Tests
  Name: (root) Failed: 15 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 35 test(s)Failed: TestSuite.kwayland-testCompositorFailed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testDataSourceFailed: TestSuite.kwayland-testRegionFailed: TestSuite.kwayland-testShmPoolFailed: TestSuite.kwayland-testSubCompositorFailed: TestSuite.kwayland-testSubSurfaceFailed: TestSuite.kwayland-testWaylandConnectionThreadFailed: TestSuite.kwayland-testWaylandRegistryFailed: TestSuite.kwayland-testWaylandServerDisplayFailed: TestSuite.kwayland-testWaylandShellFailed: TestSuite.kwayland-testWaylandSurfaceFailed: TestSuite.kwayland-testXdgForeignFailed: TestSuite.kwayland-testXdgShellV5Failed: TestSuite.kwayland-testXdgShellV6

D8367: Hidding place groups implementation in KFilePlacesModel

[Franck Arrecot]

franckarrecot marked 2 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8367

To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent
Cc: mwolff, ngraham, mlaurent, #frameworks

D9019: [Calendar] Adjust the calendar toolbar anchors

[Alexandr Akulich]

akulichalexandr retitled this revision from "Plasma: Adjust the calendar 
toolbar layout" to "[Calendar] Adjust the calendar toolbar anchors".
akulichalexandr edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9019

To: akulichalexandr, #plasma
Cc: plasma-devel, #plasma, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9019: [Calendar] Adjust the calendar toolbar anchors

[Alexandr Akulich]

akulichalexandr edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9019

To: akulichalexandr, #plasma
Cc: plasma-devel, #plasma, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9019: Plasma: Adjust the calendar toolbar layout

[Alexandr Akulich]

akulichalexandr updated this revision to Diff 23032.
akulichalexandr added a comment.


  Updating https://phabricator.kde.org/D9019: Plasma: Adjust the calendar 
toolbar layout
  
  The new diff is created via Arcanist

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9019?vs=23031=23032

BRANCH
  upstreaming

REVISION DETAIL
  https://phabricator.kde.org/D9019

AFFECTED FILES
  src/declarativeimports/calendar/qml/DaysCalendar.qml

To: akulichalexandr, #plasma
Cc: plasma-devel, #plasma, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9019: Plasma: Adjust the calendar toolbar layout

[Alexandr Akulich]

akulichalexandr created this revision.
akulichalexandr added a reviewer: Plasma.
akulichalexandr added a project: Plasma.
Restricted Application added subscribers: Frameworks, plasma-devel.
Restricted Application added a project: Frameworks.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9019

AFFECTED FILES
  src/declarativeimports/calendar/qml/DaysCalendar.qml

To: akulichalexandr, #plasma
Cc: plasma-devel, #plasma, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9019: Plasma: Adjust the calendar toolbar layout

[Alexandr Akulich]

akulichalexandr added a task: T7499: Fix plasma calendar applet layout.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9019

To: akulichalexandr, #plasma
Cc: plasma-devel, #plasma, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9018: Don't cause circular linking on Windows

[Dan Leinir Turthra Jensen]

leinir added a reviewer: Frameworks.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D9018

To: leinir, #frameworks
Cc: #frameworks

KDE CI: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.9 - Build # 117 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.9/117/
 Project:
Frameworks kirigami kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Mon, 27 Nov 2017 12:50:56 +
 Build duration:
2 hr 23 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

D8007: popplerextractor: don't try to guess the title if there isn't one.

[Vishesh Handa]

vhanda added a comment.


  To give some history - Strigi used to do this guessing, and when I 
implemented KFileMetaData, I decided to do the same. I don't have an opinion on 
whether it is a good idea or not.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D8007

To: flameeyes, #frameworks, mgallien
Cc: mgallien, vhanda, ngraham, #frameworks

D9015: Refactoring the hidding/showing animation use within KFilePlacesView

[Franck Arrecot]

franckarrecot updated this revision to Diff 23026.
franckarrecot added a comment.


  update

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9015?vs=23000=23026

REVISION DETAIL
  https://phabricator.kde.org/D9015

AFFECTED FILES
  src/filewidgets/kfileplacesview.cpp
  src/filewidgets/kfileplacesview.h

To: franckarrecot, ervin, renatoo, mlaurent, ngraham
Cc: #frameworks

D8366: Factoring out lists of url data within KFilePlacesModelTest

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:3e537c4dd935: Factoring out lists of url data within 
KFilePlacesModelTest (authored by franckarrecot, committed by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8366?vs=23023=23027

REVISION DETAIL
  https://phabricator.kde.org/D8366

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp

To: franckarrecot, renatoo, ervin, mlaurent
Cc: anthonyfieroni, ervin, ngraham, mlaurent, #frameworks

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 149 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/149/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
 Date of build:
Mon, 27 Nov 2017 14:31:29 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 9 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/9/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 27 Nov 2017 14:35:34 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report65%
(22/34)65%
(278/425)65%
(278/425)51%
(29962/58265)37%
(17511/47514)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(66/68)97%
(66/68)92%
(7961/8640)49%
(4949/10032)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src.core83%
(98/118)83%
(98/118)57%
(8055/14105)50%
(4746/9584)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(29/37)78%
(29/37)49%
(3745/7681)32%
(1534/4839)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(2/2)100%
(2/2)53%
(434/819)44%
(324/736)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1376/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1332)55%
(656/1184)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%
(725/1385)46%
(449/968)src.ioslaves.trash.tests67%
(2/3)67%
(2/3)88%
(709/802)47%

D8007: popplerextractor: don't try to guess the title if there isn't one.

[Vishesh Handa]

vhanda added a comment.


  > @vhanda do you know if there is something to do to update Baloo database 
when metadata returned by KFileMetaData are changed even if the file itself did 
not change ?
  
  I'm starting to forget the code base and what all I implemented. But I don't 
think such a thing was implemented.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D8007

To: flameeyes, #frameworks, mgallien
Cc: mgallien, vhanda, ngraham, #frameworks

D9018: Don't cause circular linking on Windows

[Dan Leinir Turthra Jensen]

leinir created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  When building plugins, don't arbitrarily rename the output files (as this 
will occasionally result in circular dependencies).
  
  In this review from three and a half years ago 
, the Sonnet plugins were moved into 
a subdirectory, which was great. They were, however, also renamed at the same 
time, which resulted in some (and specifically the aspell plugin) being named 
the same as the library they should be linked against. End result: Spell 
checking has not worked on Windows for three and a half years.

TEST PLAN
  With these properties set, the plugins fail to load on Windows due to 
circular dependencies
  
  Without them (that is, with this patch), the plugins load

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D9018

AFFECTED FILES
  src/plugins/aspell/CMakeLists.txt
  src/plugins/enchant/CMakeLists.txt
  src/plugins/hspell/CMakeLists.txt
  src/plugins/hunspell/CMakeLists.txt
  src/plugins/nsspellchecker/CMakeLists.txt
  src/plugins/voikko/CMakeLists.txt

To: leinir
Cc: #frameworks

D8367: Hidding place groups implementation in KFilePlacesModel

[Nathaniel Graham]

ngraham added a comment.


  Can you mark the Not Done comments as Done if they're done now?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8367

To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent
Cc: mwolff, ngraham, mlaurent, #frameworks

D8862: Extend KFilePlacesModel API

[Laurent Montel]

mlaurent added inline comments.

INLINE COMMENTS

> kfileplacesmodel.cpp:77
> +if (day > 0) {
> +date += QString("-%1").arg(day, 2, 10, QChar('0'));
> +}

QStringLiteral("-%1").arg(...)

> kfileplacesmodel.cpp:96
> +timelineUrl = QUrl(timelinePrefix + timelineDateString(year, 
> month) +
> +  '/' + timelineDateString(year, month, day));
> +} else if (path.endsWith(QLatin1String("/thismonth"))) {

QLatin1Char('/') +

> kfileplacesmodel.cpp:142
> +} else {
> +qWarning() << "Invalid search url:" << url;
> +searchUrl = url;

too bad it doesn't provide debug category here in this lib.
(I will add it today or tomorrow)

but don't care about it

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8862

To: renatoo, dfaure, mwolff
Cc: mlaurent, mwolff, dfaure, ngraham, #frameworks

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 9 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/9/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 27 Nov 2017 14:27:47 +
 Build duration:
8 min 31 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report62%
(21/34)65%
(275/425)65%
(275/425)51%
(29435/58242)36%
(17114/47438)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(66/68)97%
(66/68)91%
(7838/8639)48%
(4859/10032)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src.core82%
(97/118)82%
(97/118)55%
(7813/14088)48%
(4598/9580)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(29/37)78%
(29/37)49%
(3744/7681)32%
(1533/4839)src.gui0%
(0/2)0%
(0/2)0%
(0/105)0%
(0/74)src.ioslaves.file100%
(2/2)100%
(2/2)53%
(434/819)44%
(324/736)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)39%
(1705/4337)32%
(1261/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1332)55%
(656/1184)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%
(725/1385)46%
(449/968)src.ioslaves.trash.tests67%
(2/3)67%
(2/3)88%
(709/802)47%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 8 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/8/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 27 Nov 2017 14:19:43 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report65%
(22/34)65%
(278/425)65%
(278/425)51%
(29954/58257)37%
(17507/47514)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(66/68)97%
(66/68)92%
(7955/8632)49%
(4946/10032)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src.core83%
(98/118)83%
(98/118)57%
(8054/14105)50%
(4745/9584)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(29/37)78%
(29/37)49%
(3744/7681)32%
(1533/4839)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(2/2)100%
(2/2)53%
(434/819)44%
(324/736)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1377/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1332)55%
(656/1184)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%
(725/1385)46%
(449/968)src.ioslaves.trash.tests67%
(2/3)67%
(2/3)88%
(709/802)47%
(515/1089)src.kcms.kio0%
 

D9017: Avoid run kfileplacesmodeltest and kfileplacesviewtest in parallel

[Renato Oliveira Filho]

renatoo created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Both tests modify the bookmark file and that can cause test failure

TEST PLAN
  run all kio unit test

REPOSITORY
  R241 KIO

BRANCH
  serialize-unit-test

REVISION DETAIL
  https://phabricator.kde.org/D9017

AFFECTED FILES
  autotests/CMakeLists.txt

To: renatoo
Cc: #frameworks

D9017: Avoid run kfileplacesmodeltest and kfileplacesviewtest in parallel

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  serialize-unit-test

REVISION DETAIL
  https://phabricator.kde.org/D9017

To: renatoo, dfaure
Cc: #frameworks

D8367: Hidding place groups implementation in KFilePlacesModel

[Franck Arrecot]

franckarrecot updated this revision to Diff 23024.
franckarrecot added a comment.


  update - should be landable now

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8367?vs=22998=23024

REVISION DETAIL
  https://phabricator.kde.org/D8367

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/tests/placesitemmodeltest.cpp

To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent
Cc: mwolff, ngraham, mlaurent, #frameworks

D8450: User can now hide an entire places group from KFilePlacesView

[Franck Arrecot]

franckarrecot updated this revision to Diff 23025.
franckarrecot marked an inline comment as done.
franckarrecot added a comment.


  update, have to wait to be pushed, since it contains i18n translation, next 
week: 
  in the first two weeks after the first saturday of the month

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8450?vs=22999=23025

REVISION DETAIL
  https://phabricator.kde.org/D8450

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/filewidgets/kfileplacesview.cpp

To: franckarrecot, ngraham, renatoo, ervin, mwolff, mlaurent
Cc: mwolff, #frameworks

D8366: Factoring out lists of url data within KFilePlacesModelTest

[Franck Arrecot]

franckarrecot updated this revision to Diff 23023.
franckarrecot added a comment.


  update

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8366?vs=22900=23023

REVISION DETAIL
  https://phabricator.kde.org/D8366

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp

To: franckarrecot, renatoo, ervin, mlaurent
Cc: anthonyfieroni, ervin, ngraham, mlaurent, #frameworks

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 8 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/8/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 27 Nov 2017 14:14:22 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report62%
(21/34)65%
(275/425)65%
(275/425)50%
(29404/58232)36%
(17106/47438)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(66/68)97%
(66/68)91%
(7830/8631)48%
(4858/10032)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src.core82%
(97/118)82%
(97/118)55%
(7785/14086)48%
(4589/9580)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(29/37)78%
(29/37)49%
(3744/7681)32%
(1533/4839)src.gui0%
(0/2)0%
(0/2)0%
(0/105)0%
(0/74)src.ioslaves.file100%
(2/2)100%
(2/2)53%
(434/819)44%
(324/736)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)39%
(1705/4337)32%
(1261/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1332)55%
(656/1184)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%
(725/1385)46%
(449/968)src.ioslaves.trash.tests67%
(2/3)67%
(2/3)88%
(709/802)47%
(515/1089)src.kcms.kio0%

D8366: Factoring out lists of url data within KFilePlacesModelTest

[Franck Arrecot]

franckarrecot added a comment.


  this one is landable now that its dependencies are pushed.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8366

To: franckarrecot, renatoo, ervin, mlaurent
Cc: anthonyfieroni, ervin, ngraham, mlaurent, #frameworks

D8947: Expose KFilePlacesModel 'iconName' role

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:7be5649a0d9c: Expose KFilePlacesModel 
iconName  role (authored by Renato Araujo Oliveira Filho 
renato.ara...@kdab.com).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8947?vs=23013=23019

REVISION DETAIL
  https://phabricator.kde.org/D8947

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.h

To: renatoo, dfaure
Cc: ngraham, kossebau, #frameworks

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 7 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/7/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 27 Nov 2017 14:00:55 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report65%
(22/34)65%
(278/425)65%
(278/425)51%
(29961/58257)37%
(17503/47514)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(66/68)97%
(66/68)92%
(7953/8632)49%
(4943/10032)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src.core83%
(98/118)83%
(98/118)57%
(8062/14105)49%
(4744/9584)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(29/37)78%
(29/37)49%
(3745/7681)32%
(1534/4839)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(2/2)100%
(2/2)53%
(434/819)44%
(324/736)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1376/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1332)55%
(656/1184)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%
(725/1385)46%
(449/968)src.ioslaves.trash.tests67%
(2/3)67%
(2/3)88%
(709/802)47%
(515/1089)src.kcms.kio0%
 

D9017: Avoid run kfileplacesmodeltest and kfileplacesviewtest in parallel

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:700c7d3af43b: Avoid run kfileplacesmodeltest and 
kfileplacesviewtest in parallel (authored by Renato Araujo Oliveira Filho 
renato.ara...@kdab.com).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9017?vs=23021=23022

REVISION DETAIL
  https://phabricator.kde.org/D9017

AFFECTED FILES
  autotests/CMakeLists.txt

To: renatoo, dfaure
Cc: #frameworks

D8862: Extend KFilePlacesModel API

[Laurent Montel]

mlaurent added a comment.


  oh it was abandoned ! ok :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8862

To: renatoo, dfaure, mwolff
Cc: mlaurent, mwolff, dfaure, ngraham, #frameworks

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 7 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/7/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 27 Nov 2017 14:01:17 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report62%
(21/34)65%
(275/425)65%
(275/425)50%
(29390/58232)36%
(17101/47438)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(66/68)97%
(66/68)91%
(7830/8631)48%
(4856/10032)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src.core82%
(97/118)82%
(97/118)55%
(7776/14086)48%
(4588/9580)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(29/37)78%
(29/37)49%
(3744/7681)32%
(1533/4839)src.gui0%
(0/2)0%
(0/2)0%
(0/105)0%
(0/74)src.ioslaves.file100%
(2/2)100%
(2/2)53%
(434/819)44%
(324/736)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)39%
(1705/4337)32%
(1261/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1332)55%
(656/1184)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%
(725/1385)46%
(449/968)src.ioslaves.trash.tests67%
(2/3)67%
(2/3)88%
(709/802)47%
(515/1089)src.kcms.kio0%

D8945: Return a valid bookmark object for any entry in KFilePlacesModel

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:531d7759578e: Return a valid bookmark object for any 
entry in KFilePlacesModel (authored by Renato Araujo Oliveira Filho 
renato.ara...@kdab.com).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8945?vs=23011=23017

REVISION DETAIL
  https://phabricator.kde.org/D8945

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: renatoo, dfaure
Cc: ngraham, #frameworks

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 6 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/6/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 27 Nov 2017 13:41:46 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report62%
(21/34)65%
(275/425)65%
(275/425)50%
(29257/58074)36%
(16988/47156)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(66/68)97%
(66/68)91%
(7721/8522)49%
(4764/9784)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src.core82%
(97/118)82%
(97/118)55%
(7786/14086)48%
(4592/9580)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(29/37)78%
(29/37)49%
(3710/7632)31%
(1508/4805)src.gui0%
(0/2)0%
(0/2)0%
(0/105)0%
(0/74)src.ioslaves.file100%
(2/2)100%
(2/2)53%
(434/819)44%
(324/736)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)39%
(1705/4337)32%
(1261/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1332)55%
(656/1184)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%
(725/1385)46%
(449/968)src.ioslaves.trash.tests67%
(2/3)67%
(2/3)88%
(709/802)47%
(515/1089)src.kcms.kio0%
 

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 6 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/6/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 27 Nov 2017 13:41:46 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report65%
(22/34)65%
(278/425)65%
(278/425)51%
(29824/58099)37%
(17385/47232)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(66/68)97%
(66/68)92%
(7846/8523)50%
(4853/9784)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src.core83%
(98/118)83%
(98/118)57%
(8063/14105)50%
(4746/9584)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(29/37)78%
(29/37)49%
(3709/7632)31%
(1507/4805)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(2/2)100%
(2/2)53%
(434/819)44%
(324/736)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1332)55%
(656/1184)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%
(725/1385)46%
(449/968)src.ioslaves.trash.tests67%
(2/3)67%
(2/3)88%
(709/802)47%
(515/1089)src.kcms.kio0%
  

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 147 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/147/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
 Date of build:
Mon, 27 Nov 2017 13:46:16 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 54 test(s)

D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:c8bd7ad4b296: Created an auxiliary function 
KFilePlacesModel::movePlace (authored by Renato Araujo Oliveira 
Filho renato.ara...@kdab.com).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8948?vs=23014=23020

REVISION DETAIL
  https://phabricator.kde.org/D8948

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: renatoo, dfaure
Cc: #frameworks

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 146 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/146/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
 Date of build:
Mon, 27 Nov 2017 13:43:24 +
 Build duration:
2 min 38 sec and counting
   CONSOLE OUTPUT
  [...truncated 167.05 KB...][  2%] Generating kpasswdserver_interface.cpp, kpasswdserver_interface.h[  2%] Built target docs-kcontrol5-trash-index-cache-bz2Got unknown type `(ysa{s(siv)})'You should add  to the XML descriptionGot unknown type `(ysa{s(siv)})'You should add  to the XML description[  3%] Generating klauncher_interface.cpp, klauncher_interface.hScanning dependencies of target protocoltojson_autogen[  3%] Automatic MOC for target KF5KIOCore[  3%] Automatic MOC for target protocoltojson[  3%] Built target docs-kcontrol5-useragent-index-cache-bz2Generating MOC compilation mocs_compilation.cpp[  3%] Built target docs-kcontrol5-proxy-index-cache-bz2[  3%] Built target protocoltojson_autogenScanning dependencies of target kded_kcookiejar_autogenScanning dependencies of target KF5KIONTLM_autogenScanning dependencies of target kcookiejar5_autogen[  3%] Generating org.kde.KCookieServer.xml[  3%] Generating org.kde.KCookieServer.xml[  4%] Automatic MOC for target KF5KIONTLM[  4%] Generating kcookieserveradaptor.cpp, kcookieserveradaptor.h[  4%] Built target docs-kcontrol5-smb-index-cache-bz2Cannot process input: '/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/build/src/ioslaves/http/kcookiejar/org.kde.KCookieServer.xml'. Stop.gmake[2]: *** [src/ioslaves/http/kcookiejar/CMakeFiles/kded_kcookiejar_autogen.dir/build.make:68: src/ioslaves/http/kcookiejar/kcookieserveradaptor.cpp] Error 1gmake[1]: *** [CMakeFiles/Makefile2:2102: src/ioslaves/http/kcookiejar/CMakeFiles/kded_kcookiejar_autogen.dir/all] Error 2gmake[1]: *** Waiting for unfinished jobsGenerating MOC compilation mocs_compilation.cpp[  4%] Built target KF5KIONTLM_autogenScanning dependencies of target ktelnetservice5_autogen[  5%] Generating kcookieserverinterface.cpp, kcookieserverinterface.h[  6%] Automatic MOC for target ktelnetservice5Generating MOC compilation mocs_compilation.cpp[  6%] Automatic MOC for target kcookiejar5Generating MOC compilation mocs_compilation.cpp[  6%] Built target ktelnetservice5_autogen[  6%] Built target kcookiejar5_autogen[  6%] Built target docs-kcontrol5-webshortcuts-index-cache-bz2Generating MOC source include/moc_chmodjob.cppGenerating MOC source include/moc_connection_p.cppGenerating MOC source include/moc_copyjob.cppGenerating MOC source include/moc_deletejob.cppGenerating MOC source include/moc_directorysizejob.cppGenerating MOC source include/moc_emptytrashjob.cppGenerating MOC source include/moc_filecopyjob.cppGenerating MOC source include/moc_filejob.cppGenerating MOC source include/moc_filesystemfreespacejob.cppGenerating MOC source include/moc_forwardingslavebase.cppGenerating MOC source include/hostinfo.mocGenerating MOC source include/moc_job_base.cppGenerating MOC source include/moc_job_p.cppGenerating MOC source include/moc_kcoredirlister.cppGenerating MOC source include/moc_kcoredirlister_p.cppGenerating MOC source include/moc_klocalsocket.cppGenerating MOC source include/moc_knfsshare.cppGenerating MOC source include/moc_kpasswdserverloop_p.cppGenerating MOC source include/kprotocolmanager.mocGenerating MOC source include/moc_ksambashare.cppGenerating MOC source include/moc_kssld_interface.cppGenerating MOC source include/moc_ktcpsocket.cppGenerating MOC source include/moc_listjob.cppGenerating MOC source include/moc_mimetypejob.cppGenerating MOC source include/moc_mkdirjob.cppGenerating MOC source include/moc_mkpathjob.cppGenerating MOC source include/moc_multigetjob.cppGenerating MOC source include/moc_restorejob.cppGenerating MOC source include/moc_scheduler.cppGenerating MOC source include/moc_scheduler_p.cppGenerating MOC source include/moc_simplejob.cppGenerating MOC source include/moc_slaveinterface.cppGenerating MOC source include/moc_specialjob.cppGenerating MOC source include/moc_statjob.cppGenerating MOC source include/storedtransferjob.mocGenerating MOC source include/moc_storedtransferjob.cppGenerating MOC source include/moc_transferjob.cppGenerating MOC source EWIEGA46WW/moc_connectionbackend_p.cppGenerating MOC source EWIEGA46WW/moc_connectionserver.cppGenerating MOC source EWIEGA46WW/moc_dataprotocol_p.cppGenerating MOC source EWIEGA46WW/moc_dataslave_p.cppGenerating MOC source EWIEGA46WW/moc_davjob.cppGenerating MOC source EWIEGA46WW/moc_faviconscache_p.cppGenerating MOC source EWIEGA46WW/moc_idleslave.cppGenerating MOC source EWIEGA46WW/moc_kdirnotify.cppGenerating MOC source EWIEGA46WW/moc_sessiondata_p.cppGenerating MOC source EWIEGA46WW/moc_slave.cppGenerating MOC source EWIEGA46WW/moc_slaveconfig.cppGenerating MOC source EWIEGA46WW/moc_usernotificationhandler_p.cppGenerating MOC compilation mocs_compilation.cpp[  6%] Built target 

D8946: Avoid unnecessary 'dataChanged' signal

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:62c5d76f17a1: Avoid unnecessary dataChanged 
signal (authored by Renato Araujo Oliveira Filho 
renato.ara...@kdab.com).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8946?vs=23012=23018

REVISION DETAIL
  https://phabricator.kde.org/D8946

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: renatoo, dfaure
Cc: ngraham, #frameworks

D8944: Create a 'KFilePlacesModel::refresh' function

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:4186286c16b1: Create a 
KFilePlacesModel::refresh function (authored by Renato Araujo 
Oliveira Filho renato.ara...@kdab.com).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8944?vs=23010=23016

REVISION DETAIL
  https://phabricator.kde.org/D8944

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: renatoo, dfaure
Cc: ngraham, #frameworks

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 5 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/5/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 27 Nov 2017 13:24:16 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report62%
(21/34)65%
(275/425)65%
(275/425)50%
(29238/58060)36%
(16980/47144)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(66/68)97%
(66/68)91%
(7711/8512)49%
(4759/9772)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src.core82%
(97/118)82%
(97/118)55%
(7786/14086)48%
(4594/9580)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(29/37)78%
(29/37)49%
(3706/7629)31%
(1507/4805)src.gui0%
(0/2)0%
(0/2)0%
(0/105)0%
(0/74)src.ioslaves.file100%
(2/2)100%
(2/2)53%
(434/819)44%
(324/736)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)39%
(1705/4337)32%
(1261/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1332)55%
(656/1184)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%
(725/1385)46%
(449/968)src.ioslaves.trash.tests67%
(2/3)67%
(2/3)88%
(709/802)47%
(515/1089)src.kcms.kio0%
 

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 5 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/5/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 27 Nov 2017 13:24:16 +
 Build duration:
5 min 41 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report65%
(22/34)65%
(278/425)65%
(278/425)51%
(29802/58086)37%
(17366/47220)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(66/68)97%
(66/68)92%
(7836/8513)50%
(4844/9772)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src.core83%
(98/118)83%
(98/118)57%
(8064/14105)50%
(4748/9584)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(29/37)78%
(29/37)49%
(3706/7629)31%
(1507/4805)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(2/2)100%
(2/2)53%
(434/819)44%
(324/736)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1332)55%
(656/1184)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%
(715/1385)45%
(437/968)src.ioslaves.trash.tests67%
(2/3)67%
(2/3)88%
(709/802)47%
(515/1089)src.kcms.kio0%

D8943: Create 'KFilePlacesModel::convertedUrl' static function

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:66682d0df7e6: Create 
KFilePlacesModel::convertedUrl static function (authored by Renato 
Araujo Oliveira Filho renato.ara...@kdab.com).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8943?vs=23009=23015

REVISION DETAIL
  https://phabricator.kde.org/D8943

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/filewidgets/kfileplacesview.cpp

To: renatoo, dfaure
Cc: ngraham, #frameworks

D8947: Expose KFilePlacesModel 'iconName' role

[Renato Oliveira Filho]

renatoo updated this revision to Diff 23013.
renatoo added a comment.


  Updated parent branch

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8947?vs=22966=23013

REVISION DETAIL
  https://phabricator.kde.org/D8947

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.h

To: renatoo, dfaure
Cc: ngraham, kossebau, #frameworks

D8945: Return a valid bookmark object for any entry in KFilePlacesModel

[Renato Oliveira Filho]

renatoo updated this revision to Diff 23011.
renatoo added a comment.


  Updated parent branch

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8945?vs=22964=23011

REVISION DETAIL
  https://phabricator.kde.org/D8945

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: renatoo, dfaure
Cc: ngraham, #frameworks

D8946: Avoid unnecessary 'dataChanged' signal

[Renato Oliveira Filho]

renatoo updated this revision to Diff 23012.
renatoo added a comment.


  Updated parent branch

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8946?vs=22965=23012

REVISION DETAIL
  https://phabricator.kde.org/D8946

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: renatoo, dfaure
Cc: ngraham, #frameworks

D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'

[Renato Oliveira Filho]

renatoo updated this revision to Diff 23014.
renatoo added a comment.


  Updated parent branch

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8948?vs=22967=23014

REVISION DETAIL
  https://phabricator.kde.org/D8948

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: renatoo, dfaure
Cc: #frameworks

D8944: Create a 'KFilePlacesModel::refresh' function

[Renato Oliveira Filho]

renatoo updated this revision to Diff 23010.
renatoo added a comment.


  Updated parent branch

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8944?vs=22963=23010

REVISION DETAIL
  https://phabricator.kde.org/D8944

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: renatoo, dfaure
Cc: ngraham, #frameworks

D8943: Create 'KFilePlacesModel::convertedUrl' static function

[Renato Oliveira Filho]

renatoo updated this revision to Diff 23009.
renatoo added a comment.


  Updated parent branch

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8943?vs=22962=23009

REVISION DETAIL
  https://phabricator.kde.org/D8943

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/filewidgets/kfileplacesview.cpp

To: renatoo, dfaure
Cc: ngraham, #frameworks

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 150 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/150/
 Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
 Date of build:
Mon, 27 Nov 2017 12:50:56 +
 Build duration:
1 min 36 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 5 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/5/
 Project:
Frameworks kirigami kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 27 Nov 2017 12:50:56 +
 Build duration:
1 min 45 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/4)0%
(0/12)0%
(0/12)0%
(0/639)0%
(0/439)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsexamples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)examples.galleryapp0%
(0/1)0%
(0/1)0%
(0/10)0%
(0/4)src0%
(0/5)0%
(0/5)0%
(0/315)0%
(0/301)src.libkirigami0%
(0/5)0%
(0/5)0%
(0/306)0%
(0/134)

D8450: User can now hide an entire places group from KFilePlacesView

[Franck Arrecot]

franckarrecot marked an inline comment as done.
franckarrecot added inline comments.

INLINE COMMENTS

> ervin wrote in kfileplacesview.cpp:863-866
> Cool, I'll wait for that extra review to appear before accepting that one. So 
> that we don't forget it. :-)

Was that the thing you had in mind ?

https://phabricator.kde.org/D9015

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8450

To: franckarrecot, ngraham, renatoo, ervin, mwolff, mlaurent
Cc: mwolff, #frameworks

D8367: Hidding place groups implementation in KFilePlacesModel

[Franck Arrecot]

franckarrecot added a dependent revision: D9015: Refactoring the 
hidding/showing animation use within KFilePlacesView.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8367

To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent
Cc: mwolff, ngraham, mlaurent, #frameworks

D9015: Refactoring the hidding/showing animation use within KFilePlacesView

[Franck Arrecot]

franckarrecot created this revision.
franckarrecot added reviewers: ervin, renatoo, mlaurent, ngraham.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Depends on https://phabricator.kde.org/D8367
  Depends on https://phabricator.kde.org/D8450

TEST PLAN
  manual testing on the context menu

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9015

AFFECTED FILES
  src/filewidgets/kfileplacesview.cpp
  src/filewidgets/kfileplacesview.h

To: franckarrecot, ervin, renatoo, mlaurent, ngraham
Cc: #frameworks

D8450: User can now hide an entire places group from KFilePlacesView

[Franck Arrecot]

franckarrecot added a dependent revision: D9015: Refactoring the 
hidding/showing animation use within KFilePlacesView.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8450

To: franckarrecot, ngraham, renatoo, ervin, mwolff, mlaurent
Cc: mwolff, #frameworks