KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/14/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 05 Dec 2017 02:09:06 +
 Build duration:
6 min 50 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 74 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/74/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
 Date of build:
Tue, 05 Dec 2017 02:09:06 +
 Build duration:
6 min 26 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 12 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/12/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
 Date of build:
Tue, 05 Dec 2017 02:09:06 +
 Build duration:
4 min 32 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest

D9118: ki18n cmake macros: Mark UIC-generated .h files to skip AUTOMOC by default

[Michael Pyne]

This revision was automatically updated to reflect the committed changes.
Closed by commit R249:6e3b70843566: cmake: Mark UIC-generated .h files to skip 
AUTOMOC by default. (authored by mpyne).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D9118?vs=23312=23478#toc

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9118?vs=23312=23478

REVISION DETAIL
  https://phabricator.kde.org/D9118

AFFECTED FILES
  cmake/KF5I18NMacros.cmake

To: mpyne, #frameworks, #build_system, #localization, kfunk
Cc: aacid

D9190: TransferJob: workaround for when the readChannelFinished has already been emitted

[Albert Astals Cid]

aacid added reviewers: dfaure, apol, albertvaka.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9190

To: aacid, dfaure, apol, albertvaka
Cc: #frameworks

D9190: TransferJob: workaround for when the readChannelFinished has already been emitted

[Albert Astals Cid]

aacid created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  This fixes a regression by the removal of the busy loop call from 
https://phabricator.kde.org/R241:bcdbe62660a9ca91b0d15f3a9a06a758ec8fdcda
  
  BUG: 386246

TEST PLAN
  New test passes with the new code, didn't pass before
  Sending very small files with kde connect works again

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9190

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/transferjob.cpp

To: aacid
Cc: #frameworks

D9189: Do not crash when completion object gets destroyed underneath us

[Milian Wolff]

mwolff added a subscriber: dfaure.
mwolff added a comment.


  This makes KMail's Open With feature work again, but I wonder - is anyone 
capable of running valgrind? Or figure out where the deletion comes from?  
@dfaure?

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D9189

To: mwolff
Cc: dfaure, #frameworks

D9189: Do not crash when completion object gets destroyed underneath us

[Milian Wolff]

mwolff edited the summary of this revision.

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D9189

To: mwolff
Cc: dfaure, #frameworks

D9189: Do not crash when completion object gets destroyed underneath us

[Milian Wolff]

mwolff created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  For some reason the 'Open With' dialog opened by KMail triggers the
  following crash for me:
  
  #0  0x68ea4220 in ?? ()
   #1  0x7549bd60 in QObject::connect(QObject const*, char const*, 
QObject const*, char const*, Qt::ConnectionType) () from 
/usr/lib/libQt5Core.so.5
   #2  0x771287f4 in KLineEdit::setCompletionObject 
(this=0x68ee8c00, comp=0x68ea1320, handle=)
  
at 
/home/milian/projects/kf5/src/frameworks/kcompletion/src/klineedit.cpp:1514
  
  #3  0x77113d35 in KComboBox::setLineEdit (this=0x68ea3ba0, 
edit=0x68ee8c00) at 
/home/milian/projects/kf5/src/frameworks/kcompletion/src/kcombobox.cpp:325
   #4  0x7784ef63 in KOpenWithDialogPrivate::init (this=0x7fff70240440,
  
_text="Select the program you want to use to open the 
fileDebuggingProfilingWindows-2017-WK50.pdf", _value="")
at 
/home/milian/projects/kf5/src/frameworks/kio/src/widgets/kopenwithdialog.cpp:601
  
  #5  0x7784f93c in KOpenWithDialog::KOpenWithDialog 
(this=0x7fffba50, _urls=QList = {...}, _text=..., _value="", 
parent=)
  
at 
/home/milian/projects/kf5/src/frameworks/kio/src/widgets/kopenwithdialog.cpp:531
  
  #6  0x77862b51 in KRun::displayOpenWithDialog (lst=QList = 
{...}, window=0x5599a690, tempFiles=tempFiles@entry=true, 
suggestedFileName="",
  
asn= "") at 
/home/milian/projects/kf5/src/frameworks/kio/src/widgets/krun.cpp:267
  
  Guard against it by using a QPointer to check whether the completion
  object gets destroyed before we want to use it again.
  
  Sadly WebEngine in KMail prevents me from using Valgrind, so I have
  not yet figured out where exactly the deletion is coming from. That
  said, this fix should make this working again with minimal impact.

REPOSITORY
  R284 KCompletion

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9189

AFFECTED FILES
  src/kcombobox.cpp

To: mwolff
Cc: #frameworks

D9188: Highlighting Indexer: Check for empty context names and regexps

[Dominik Haumann]

dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Warn about empty contexts of the form context="".
  Warn about empty RegExps String="".
  And fix the issues found by this.

TEST PLAN
  make test

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  CheckContextNames (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9188

AFFECTED FILES
  data/syntax/asp.xml
  data/syntax/makefile.xml
  data/syntax/template-toolkit.xml
  src/indexer/katehighlightingindexer.cpp

To: dhaumann, vkrause
Cc: #frameworks

D9186: Remove unused contexts and itemDatas

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  RemoveUnusedContextsAndItemDatas (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9186

To: dhaumann, vkrause
Cc: #frameworks

D9186: Remove unused contexts and itemDatas

[Dominik Haumann]

dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Some contexts are commented out since they are used in commented
  out rules. Besides that, contexts that are not referenced at all
  (i.e. also not in other comments), are simply removed entirely.
  
  In addition, searching for lineEmptyContext was missing in the
  highlighting indexer - this is added now.

TEST PLAN
  make && make test

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  RemoveUnusedContextsAndItemDatas (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9186

AFFECTED FILES
  data/syntax/abc.xml
  data/syntax/ample.xml
  data/syntax/ansys.xml
  data/syntax/asterisk.xml
  data/syntax/boo.xml
  data/syntax/cg.xml
  data/syntax/cisco.xml
  data/syntax/dosbat.xml
  data/syntax/elixir.xml
  data/syntax/fasm.xml
  data/syntax/ferite.xml
  data/syntax/fgl-4gl.xml
  data/syntax/fgl-per.xml
  data/syntax/ftl.xml
  data/syntax/haml.xml
  data/syntax/ilerpg.xml
  data/syntax/isocpp.xml
  data/syntax/jam.xml
  data/syntax/julia.xml
  data/syntax/kotlin.xml
  data/syntax/latex.xml
  data/syntax/metafont.xml
  data/syntax/modula-2.xml
  data/syntax/nesc.xml
  data/syntax/perl.xml
  data/syntax/povray.xml
  data/syntax/protobuf.xml
  data/syntax/pug.xml
  data/syntax/ruby.xml
  data/syntax/sisu.xml
  data/syntax/stata.xml
  data/syntax/systemverilog.xml
  data/syntax/tcsh.xml
  data/syntax/varnishtest.xml
  data/syntax/varnishtest4.xml
  data/syntax/verilog.xml
  data/syntax/xharbour.xml
  data/syntax/xmldebug.xml
  src/indexer/katehighlightingindexer.cpp

To: dhaumann, vkrause
Cc: #frameworks

D9124: make packageurlinterceptor as noop as possible

[David Edmundson]

davidedmundson reopened this revision.
davidedmundson added a comment.


  Was pushed in a branch, not master. Reopening on phab

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9124

To: mart, #plasma
Cc: davidedmundson, ngraham, apol, plasma-devel, #frameworks, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D9169: port to Package::fileUrl

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:84104aa463b1: port to Package::fileUrl (authored by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9169?vs=23430=23464

REVISION DETAIL
  https://phabricator.kde.org/D9169

AFFECTED FILES
  autotests/configmodeltest.cpp
  examples/shell/customcorona.cpp
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/configmodel.cpp
  src/plasmaquick/configview.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9124: make packageurlinterceptor as noop as possible

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:d0cbef14cbdd: make packageurlinterceptor as noop as 
possible (authored by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9124?vs=23397=23463

REVISION DETAIL
  https://phabricator.kde.org/D9124

AFFECTED FILES
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/packageurlinterceptor.cpp

To: mart, #plasma
Cc: ngraham, apol, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D9182: return nullptr -> return {} for QFlags

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Code change looks good to me. Think I missed that in my clean-up commits to 
@kfunk 's initial commit as I only compiled the library parts of KDE 
Frameworks, not the plugin modules.
  
  No maintainer of this module though, so just a +1 for now.
  
  Commit message could perhaps be extended to quickly note why the nullptr has 
been there at all, so future commit history readers get a clue, which they do 
not from a "irritating" attribution :)

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D9182

To: mkoller, kfunk, kossebau
Cc: #frameworks

D9182: return nullptr -> return {} for QFlags

[Martin Koller]

mkoller created this revision.
mkoller added reviewers: kfunk, kossebau.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Change the irritating nullptr return value to {} for the 
QImageIOPlugin::Capabilities QFlags

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D9182

AFFECTED FILES
  src/imageformats/eps.cpp
  src/imageformats/exr.cpp
  src/imageformats/kra.cpp
  src/imageformats/ora.cpp
  src/imageformats/pcx.cpp
  src/imageformats/pic.cpp
  src/imageformats/psd.cpp
  src/imageformats/ras.cpp
  src/imageformats/rgb.cpp
  src/imageformats/tga.cpp
  src/imageformats/xcf.cpp

To: mkoller, kfunk, kossebau
Cc: #frameworks

D8728: Install mimetype definitions for kcfg/kcfgc/ui.rc/knotify & qrc files

[Friedrich W . H . Kossebau]

kossebau added a subscriber: ltoscano.
kossebau added a comment.


  In https://phabricator.kde.org/D8728#174635, @dfaure wrote:
  
  > I agree that those are really KF5 specific and developer-oriented, so 
rather unlikely to be e.g. sent by email to other people.
  
  
  Okay, so for now not looking into pushing them upstream (too bad we gave up 
on "turning every user into a developer" ;) )
  
  > I'm unsure about mimetypes for special files by name, that seems too 
specialized. Mimetypes are for *types* of files, not for each specific file ;)
  >  I mean, Messages.sh is a shell script, that's its type. Its specific 
purpose is something else, of course, but still you would use a viewer or 
editor for shell scripts to open it (which is the main reason for mimetypes: 
app associations).
  
  But isn't Messages.sh a sub-type to shell-script, as it needs to match some 
further requirements, as defined by scripty expectations? And while there might 
be no specific viewer/editor/etc as handler assigned, it still a type of its 
own as handled by humans (outside of scripty server). So IMHO it is helpful to 
also have these files displayed annotated as such in filemanagers/dialogs, 
ideally both by icon and type tooltip. With such annotated presentation to 
humans for me being another raison d’être for mimetypes :)
  So IMHO "Messages,sh" & Co match things already in shared-mime-info like 
"AUTHORS", "COPYING", "CREDITS", "LICENSE", where there also usually is no 
specific handler, still it is helpful when browsing files to have these special 
files annotated.
  But given @ltoscano's plan to overhaul string extraction, I currently will 
not invest more into the scripty-specific file types, would rather first see to 
find someone who could find some Qt developer to pursue 
https://bugreports.qt.io/browse/QTBUG-64435 given this is another set of modern 
Qt file types which are badly presented when browsing files in file managers or 
IDEs. Any hint who could be motivated there?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D8728

To: kossebau, #frameworks, dfaure
Cc: ltoscano, ngraham

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.7 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.7/4/
 Project:
Frameworks kpackage kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 04 Dec 2017 17:51:36 +
 Build duration:
5 min 30 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)96%
(23/24)96%
(23/24)72%
(1546/2136)51%
(1209/2367)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(10/10)100%
(10/10)100%
(500/502)52%
(303/588)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)73%
(539/738)63%
(626/995)src.kpackage.private100%
(6/6)100%
(6/6)79%
(288/363)53%
(120/226)src.kpackagetool100%
(3/3)100%
(3/3)40%
(205/515)28%
(153/546)

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/4/
 Project:
Frameworks kpackage kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 04 Dec 2017 17:51:36 +
 Build duration:
1 min 21 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)96%
(23/24)96%
(23/24)72%
(1546/2136)51%
(1209/2367)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(10/10)100%
(10/10)100%
(500/502)52%
(303/588)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)73%
(539/738)63%
(626/995)src.kpackage.private100%
(6/6)100%
(6/6)79%
(288/363)53%
(120/226)src.kpackagetool100%
(3/3)100%
(3/3)40%
(205/515)28%
(153/546)

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.7 - Build # 41 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/41/
 Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.7
 Date of build:
Mon, 04 Dec 2017 17:51:36 +
 Build duration:
51 sec and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.plasma-packagestructuretestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/18/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 04 Dec 2017 17:36:11 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(56/159)35%
(56/159)27%
(3565/13242)19%
(1970/10429)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)54%
(609/1130)28%
(419/1474)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)12%
(251/2151)7%
(98/1450)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1443/3488)28%
(821/2909)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(675/1617)28%
(319/1123)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick50%
(6/12)50%
(6/12)28%
(556/1995)18%
(308/1695)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
 

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 164 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/164/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
 Date of build:
Mon, 04 Dec 2017 17:36:11 +
 Build duration:
8 min 47 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 22 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/22/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 04 Dec 2017 17:36:11 +
 Build duration:
7 min 24 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(56/159)35%
(56/159)27%
(3562/13237)19%
(1968/10429)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)54%
(607/1129)28%
(419/1474)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)12%
(250/2147)7%
(97/1446)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1443/3488)28%
(821/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(675/1617)28%
(318/1123)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick50%
(6/12)50%
(6/12)28%
(556/1995)18%
(308/1695)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
 

Re: Failing KTextEditor unit tests

[Ben Cooksley]

On Tue, Dec 5, 2017 at 5:32 AM, Dominik Haumann  wrote:
> Hi frameworks-devs,

Hi Dominik,

>
> since some time we have several unit tests that fail in the
> KTextEditor framework:
> https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/11/testReport/
>
> It sesms all these issues are related to changes in the font, could that be?
> It even seems that asking for a fixed font that used to work does not
> work anymore:
>
> QFont fixedWidthFont("Monospace");
> fixedWidthFont.setStyleHint(QFont::TypeWriter);
> Q_ASSERT_X(QFontInfo(fixedWidthFont).fixedPitch(), "we hit this assert!");
>
> Is there anything we can do to get this working again?
> Or do we need to fix the unit tests (which do work on my local machine!) ?

This is probably because the CI images only have the Cantarell font
installed in them at the moment (no idea what triggers that one
specifically to be installed).
If someone has a list of common font packages for SUSE then I can add
those to the image relatively easy, which will probably fix those
tests.

>
> Greetings
> Dominik

Cheers,
Ben

D9119: Initialize scale factor to the last scale factor set on any instance

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:f75816a33a32: Initialize scale factor to the last scale 
factor set on any instance (authored by hein).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9119?vs=23388=23451

REVISION DETAIL
  https://phabricator.kde.org/D9119

AFFECTED FILES
  src/plasma/private/svg_p.h
  src/plasma/svg.cpp

To: hein, #plasma, davidedmundson, broulik, mart
Cc: graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9119: Initialize scale factor to the last scale factor set on any instance

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9119

To: hein, #plasma, davidedmundson, broulik, mart
Cc: graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9166: Remove double lookups

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R301:e87e2dd27dd9: Remove double lookups (authored by 
mlaurent).

REPOSITORY
  R301 KEmoticons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9166?vs=23419=23448

REVISION DETAIL
  https://phabricator.kde.org/D9166

AFFECTED FILES
  src/core/kemoticons.cpp

To: mlaurent, dfaure
Cc: #frameworks

Re: kcrash, fork, and stdout/stderr

[Thiago Macieira]

On Monday, 4 December 2017 00:26:55 PST David Faure wrote:
> > Or do you fork a child at that point? fork from inside a signal handler is
> > an incredibly bad idea, don't do it.
> 
> Well, I guess that's why it's the fallback from the main strategy which is
> "ask kdeinit to restart that application" (even if it doesn't provide a
> kdeinit module). But kdeinit might not be running, outside plasma workspace.
> 
> This has always been like that, it goes back to 2006 (Luboš), it was
> discussed with you
> https://marc.info/?l=kde-core-devel=113699766611213=2 ("There's still a
> fallback to use fork() in case using kdeinit fails for any reason.")

Well, I've learnt a lot in the last 11 years.

forking inside a signal handler is a bad idea because it may deadlock. If the 
crash happens while glibc holds some mutexes relating to pthread_atfork, then 
you'll have a problem.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center

D9126: [RTL] - align properly the selected text for RTL

[Michail Vourlakos]

mvourlakos added a comment.


  In https://phabricator.kde.org/D9126#175594, @broulik wrote:
  
  > (I'd be fine with this one liner going in but I'm wondering why it would be 
needed in the first place)
  
  
  are we ok for landing this?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  rtl

REVISION DETAIL
  https://phabricator.kde.org/D9126

To: mvourlakos, #plasma, davidedmundson
Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9167: Improve string handling

[Dominik Haumann]

dhaumann added a comment.


  Looks already pretty just. I just stumbled over two issues which maybe should 
be clarified - see comments.

INLINE COMMENTS

> kiconeffect.cpp:163
> +
> +if (state == Colorize || effectGroupState == ToMonochrome) {
> +cached += QLatin1Char(':') + d->color[group][state].name();

This should be:
 if (effectGroupState == Colorize || effectGroupState == ToMonochrome) {

or do I miss something?

> kiconeffect.cpp:165
> +cached += QLatin1Char(':') + d->color[group][state].name();
> +} else if (effectGroupState == ToMonochrome) {
> +cached += QLatin1Char(':') + d->color2[group][state].name();

Previously, this was not an else if(), but just an if().

Are you sure this works as intended?

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D9167

To: apol, #frameworks
Cc: dhaumann

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/12/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 04 Dec 2017 16:28:35 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 64 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.katefoldingtestFailed: TestSuite.movingrange_testFailed: TestSuite.vimode_view
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)89%
(299/337)89%
(299/337)68%
(33683/49222)52%
(17507/33916)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(49/49)100%
(49/49)92%
(4276/4624)49%
(2102/4316)autotests.src.vimode88%
(14/16)88%
(14/16)96%
(5297/5530)51%
(866/1698)src.buffer88%
(15/17)88%
(15/17)91%
(1704/1881)77%
(1326/1724)src.completion100%
(16/16)100%
(16/16)57%
(1777/3116)43%
(1241/2897)src.completion.expandingtree100%
(5/5)100%
(5/5)40%
(186/461)22%
(79/362)src.dialogs0%
(0/4)0%
(0/4)0%
(0/827)0%
(0/240)src.document100%
(4/4)100%
(4/4)59%
(1880/3193)48%
(1681/3485)src.export100%
(4/4)100%
(4/4)86%
(107/125)69%
(118/170)src.include.ktexteditor100%
(14/14)100%
(14/14)92%
(227/248)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(170/420)37%
(103/275)src.part0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/296)src.render100%
(9/9)100%
(9/9)76%
(922/1219)65%
(617/944)src.schema22%
(2/9)22%
(2/9)1%
(21/1501)1%
(6/729)src.script100%
(17/17)100%
(17/17)70%
(739/1057)59%
(307/519)src.search100%
(7/7)100%
(7/7)73%
(1099/1501)63%
(609/965)src.spellcheck75%
(6/8)75%

D9164: Fix typo in namespace

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:792c9cb03888: Fix typo in namespace (authored by 
dhaumann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9164?vs=23416=23443

REVISION DETAIL
  https://phabricator.kde.org/D9164

AFFECTED FILES
  org_kde_ksyntaxhighlighting.categories

To: dhaumann, vkrause
Cc: #frameworks

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/13/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 04 Dec 2017 16:28:35 +
 Build duration:
7 min 14 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 64 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.katefoldingtestFailed: TestSuite.movingrange_testFailed: TestSuite.vimode_view
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)89%
(299/337)89%
(299/337)68%
(33690/49227)52%
(17506/33918)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(49/49)100%
(49/49)93%
(4287/4627)49%
(2104/4316)autotests.src.vimode88%
(14/16)88%
(14/16)96%
(5297/5530)51%
(866/1698)src.buffer88%
(15/17)88%
(15/17)91%
(1704/1881)77%
(1326/1724)src.completion100%
(16/16)100%
(16/16)57%
(1777/3116)43%
(1241/2897)src.completion.expandingtree100%
(5/5)100%
(5/5)40%
(186/461)22%
(79/362)src.dialogs0%
(0/4)0%
(0/4)0%
(0/827)0%
(0/240)src.document100%
(4/4)100%
(4/4)59%
(1880/3193)48%
(1681/3485)src.export100%
(4/4)100%
(4/4)86%
(107/125)69%
(118/170)src.include.ktexteditor100%
(14/14)100%
(14/14)92%
(227/248)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(170/420)37%
(103/275)src.part0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/296)src.render100%
(9/9)100%
(9/9)76%
(922/1219)65%
(617/944)src.schema22%
(2/9)22%
(2/9)1%
(21/1501)1%
(6/729)src.script100%
(17/17)100%
(17/17)70%
(739/1057)59%
(307/519)src.search100%
(7/7)100%
(7/7)73%
(1099/1501)63%
(609/965)src.spellcheck75%
(6/8)75%

Failing KTextEditor unit tests

[Dominik Haumann]

Hi frameworks-devs,

since some time we have several unit tests that fail in the
KTextEditor framework:
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/11/testReport/

It sesms all these issues are related to changes in the font, could that be?
It even seems that asking for a fixed font that used to work does not
work anymore:

QFont fixedWidthFont("Monospace");
fixedWidthFont.setStyleHint(QFont::TypeWriter);
Q_ASSERT_X(QFontInfo(fixedWidthFont).fixedPitch(), "we hit this assert!");

Is there anything we can do to get this working again?
Or do we need to fix the unit tests (which do work on my local machine!) ?

Greetings
Dominik

D9175: Migrate some more QRegExps to QRegularExpression

[Dominik Haumann]

dhaumann created this revision.
dhaumann added reviewers: cullmann, kfunk, mwolff.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Please make a careful review. Many of these code
  changes are most likely not touched by our unit tests, so
  introducing regressions may happen quickly.

REPOSITORY
  R39 KTextEditor

BRANCH
  QRegExpCleanup2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9175

AFFECTED FILES
  src/search/kateplaintextsearch.cpp
  src/search/kateregexpsearch.h
  src/search/katesearchbar.cpp
  src/utils/codecompletionmodelcontrollerinterface.cpp
  src/utils/katebookmarks.cpp
  src/utils/katecommandrangeexpressionparser.cpp
  src/utils/katesedcmd.cpp
  src/variableeditor/variablelistview.cpp
  src/view/kateview.cpp

To: dhaumann, cullmann, kfunk, mwolff
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D9169: port to Package::fileUrl

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  I like your test plan :D

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/packegeFileUrl

REVISION DETAIL
  https://phabricator.kde.org/D9169

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9169: port to Package::fileUrl

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  makes things work when packages are in resources
  Depends from: https://phabricator.kde.org/D9124

TEST PLAN
  plasmahell correctly starts again

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/packegeFileUrl

REVISION DETAIL
  https://phabricator.kde.org/D9169

AFFECTED FILES
  autotests/configmodeltest.cpp
  examples/shell/customcorona.cpp
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/configmodel.cpp
  src/plasmaquick/configview.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp

To: mart, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9164: Fix typo in namespace

[Volker Krause]

vkrause accepted this revision.
vkrause added a comment.
This revision is now accepted and ready to land.


  This must match what we use for our debug category name for kdebugsettings to 
work, so this shouldn't have any negative side-effects.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  FixNamespace (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9164

To: dhaumann, vkrause
Cc: #frameworks

D9165: Lazy-instanciate and lazy-load KNotification plugins.

[Eike Hein]

hein added a comment.


  Comment added: 
https://commits.kde.org/knotifications/9472dc7b9c63d10e5b707d1e3e3c3a24111fbe9d

INLINE COMMENTS

> davidedmundson wrote in knotificationmanager.cpp:136
> QLatin1String * 5

- 6 :P

> davidedmundson wrote in knotificationmanager.cpp:156
> No reason we can't add that field now and for compatibility instantiate if 
> that field is not set.

Good point, will do.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D9165

To: hein, #plasma, #frameworks, davidedmundson
Cc: #frameworks, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9165: Lazy-instanciate and lazy-load KNotification plugins.

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:1e048a10f861: Lazy-instanciate and lazy-load 
KNotification plugins. (authored by hein).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9165?vs=23426=23427

REVISION DETAIL
  https://phabricator.kde.org/D9165

AFFECTED FILES
  src/knotificationmanager.cpp
  src/knotificationmanager_p.h
  src/knotificationplugin.desktop

To: hein, #plasma, #frameworks, davidedmundson
Cc: #frameworks, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9165: Lazy-instanciate and lazy-load KNotification plugins.

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added inline comments.

INLINE COMMENTS

> knotificationmanager.cpp:160
> +[, ](const KPluginMetaData ) {
> +if (pluginFound) {
> +return false;

please add a comment explaining this.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9165

To: hein, #plasma, #frameworks, davidedmundson
Cc: #frameworks, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9165: Lazy-instanciate and lazy-load KNotification plugins.

[Eike Hein]

hein updated this revision to Diff 23426.
hein added a comment.


  Add and utilize a X-KDE-KNotification-OptionName field in
  KNotificationPlugin to try and avoid more instanciations.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9165?vs=23417=23426

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9165

AFFECTED FILES
  src/knotificationmanager.cpp
  src/knotificationmanager_p.h
  src/knotificationplugin.desktop

To: hein, #plasma, #frameworks, davidedmundson
Cc: #frameworks, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9155: Add used property to service file defintion

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R297:9f2bd7afb9cc: Add used property to service file defintion 
(authored by davidedmundson).

REPOSITORY
  R297 KDED

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9155?vs=23398=23425

REVISION DETAIL
  https://phabricator.kde.org/D9155

AFFECTED FILES
  src/kdedmodule.desktop

To: davidedmundson, apol
Cc: #frameworks

D9165: Lazy-instanciate and lazy-load KNotification plugins.

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  One minor comment, then good to go.

INLINE COMMENTS

> knotificationmanager.cpp:136
> +addPlugin(plugin);
> +} else if (action == QStringLiteral("Taskbar")) {
> +plugin = new NotifyByTaskbar(this);

QLatin1String * 5

> knotificationmanager.cpp:156
> +} else {
> +// TODO KF6: We need to instantiate all plugins to be able to call
> +// KNotificationPlugin::optionName. It would much much nicer if we

No reason we can't add that field now and for compatibility instantiate if that 
field is not set.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9165

To: hein, #plasma, #frameworks, davidedmundson
Cc: #frameworks, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9168: Migrate some QRegExps to QRegularExpression

[Dominik Haumann]

dhaumann created this revision.
dhaumann added reviewers: cullmann, kfunk, mwolff.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Please make a careful review. Many of these code
  changes are most likely not touched by our unit tests, so
  introducing regressions may happen quickly.

TEST PLAN
  make && make test

REPOSITORY
  R39 KTextEditor

BRANCH
  QRegExpCleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9168

AFFECTED FILES
  autotests/src/scripting_test.cpp
  src/completion/katewordcompletion.cpp
  src/document/katedocument.cpp
  src/mode/katemodeconfigpage.cpp
  src/mode/katemodemanager.cpp
  src/printing/printpainter.cpp
  src/utils/katecmds.cpp

To: dhaumann, cullmann, kfunk, mwolff
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/11/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 04 Dec 2017 13:23:47 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 64 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.katefoldingtestFailed: TestSuite.movingrange_testFailed: TestSuite.vimode_view
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)89%
(299/337)89%
(299/337)68%
(33683/49222)52%
(17508/33916)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(49/49)100%
(49/49)92%
(4276/4624)49%
(2102/4316)autotests.src.vimode88%
(14/16)88%
(14/16)96%
(5297/5530)51%
(866/1698)src.buffer88%
(15/17)88%
(15/17)91%
(1704/1881)77%
(1326/1724)src.completion100%
(16/16)100%
(16/16)57%
(1777/3116)43%
(1241/2897)src.completion.expandingtree100%
(5/5)100%
(5/5)40%
(186/461)22%
(79/362)src.dialogs0%
(0/4)0%
(0/4)0%
(0/827)0%
(0/240)src.document100%
(4/4)100%
(4/4)59%
(1880/3193)48%
(1681/3485)src.export100%
(4/4)100%
(4/4)86%
(107/125)69%
(118/170)src.include.ktexteditor100%
(14/14)100%
(14/14)92%
(227/248)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(170/420)37%
(103/275)src.part0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/296)src.render100%
(9/9)100%
(9/9)76%
(922/1219)65%
(617/944)src.schema22%
(2/9)22%
(2/9)1%
(21/1501)1%
(6/729)src.script100%
(17/17)100%
(17/17)70%
(739/1057)59%
(307/519)src.search100%
(7/7)100%
(7/7)73%
(1099/1501)63%
(609/965)src.spellcheck75%
(6/8)75%

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/10/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 04 Dec 2017 12:48:44 +
 Build duration:
35 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 64 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.katefoldingtestFailed: TestSuite.movingrange_testFailed: TestSuite.vimode_view
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)89%
(299/337)89%
(299/337)68%
(33685/49224)52%
(17507/33916)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(49/49)100%
(49/49)92%
(4276/4624)49%
(2102/4316)autotests.src.vimode88%
(14/16)88%
(14/16)96%
(5297/5530)51%
(866/1698)src.buffer88%
(15/17)88%
(15/17)91%
(1704/1881)77%
(1326/1724)src.completion100%
(16/16)100%
(16/16)57%
(1777/3116)43%
(1241/2897)src.completion.expandingtree100%
(5/5)100%
(5/5)40%
(186/461)22%
(79/362)src.dialogs0%
(0/4)0%
(0/4)0%
(0/827)0%
(0/240)src.document100%
(4/4)100%
(4/4)59%
(1880/3193)48%
(1681/3485)src.export100%
(4/4)100%
(4/4)86%
(107/125)69%
(118/170)src.include.ktexteditor100%
(14/14)100%
(14/14)92%
(227/248)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(170/420)37%
(103/275)src.part0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/296)src.render100%
(9/9)100%
(9/9)76%
(922/1219)65%
(617/944)src.schema22%
(2/9)22%
(2/9)1%
(21/1501)1%
(6/729)src.script100%
(17/17)100%
(17/17)70%
(739/1057)59%
(307/519)src.search100%
(7/7)100%
(7/7)73%
(1099/1501)63%
(609/965)src.spellcheck75%
(6/8)75%

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/12/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 04 Dec 2017 13:15:45 +
 Build duration:
7 min 14 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 64 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.katefoldingtestFailed: TestSuite.movingrange_testFailed: TestSuite.vimode_view
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)89%
(299/337)89%
(299/337)68%
(33690/49227)52%
(17506/33918)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(49/49)100%
(49/49)93%
(4287/4627)49%
(2104/4316)autotests.src.vimode88%
(14/16)88%
(14/16)96%
(5297/5530)51%
(866/1698)src.buffer88%
(15/17)88%
(15/17)91%
(1704/1881)77%
(1326/1724)src.completion100%
(16/16)100%
(16/16)57%
(1777/3116)43%
(1241/2897)src.completion.expandingtree100%
(5/5)100%
(5/5)40%
(186/461)22%
(79/362)src.dialogs0%
(0/4)0%
(0/4)0%
(0/827)0%
(0/240)src.document100%
(4/4)100%
(4/4)59%
(1880/3193)48%
(1681/3485)src.export100%
(4/4)100%
(4/4)86%
(107/125)69%
(118/170)src.include.ktexteditor100%
(14/14)100%
(14/14)92%
(227/248)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(170/420)37%
(103/275)src.part0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/296)src.render100%
(9/9)100%
(9/9)76%
(922/1219)65%
(617/944)src.schema22%
(2/9)22%
(2/9)1%
(21/1501)1%
(6/729)src.script100%
(17/17)100%
(17/17)70%
(739/1057)59%
(307/519)src.search100%
(7/7)100%
(7/7)73%
(1099/1501)63%
(609/965)src.spellcheck75%
(6/8)75%

D9167: Improve string handling

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  Instead of using implicit casts, use the ones we need as suggested for KF5.

TEST PLAN
  Builds, tests pass

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9167

AFFECTED FILES
  CMakeLists.txt
  autotests/kiconengine_unittest.cpp
  autotests/kiconloader_benchmark.cpp
  autotests/kiconloader_rcctest.cpp
  autotests/kiconloader_resourcethemetest.cpp
  autotests/kiconloader_unittest.cpp
  src/kicondialog.cpp
  src/kiconeffect.cpp
  src/kiconloader.cpp
  src/kicontheme.cpp
  src/tools/kiconfinder/kiconfinder.cpp

To: apol, #frameworks

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 109 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/109/
 Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
 Date of build:
Mon, 04 Dec 2017 12:40:49 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 66 test(s)

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/11/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 04 Dec 2017 12:40:49 +
 Build duration:
9 min 15 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 64 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.katefoldingtestFailed: TestSuite.movingrange_testFailed: TestSuite.vimode_view
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)89%
(299/337)89%
(299/337)68%
(33698/49230)52%
(17508/33918)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(49/49)100%
(49/49)93%
(4287/4627)49%
(2104/4316)autotests.src.vimode88%
(14/16)88%
(14/16)96%
(5297/5530)51%
(866/1698)src.buffer88%
(15/17)88%
(15/17)91%
(1704/1881)77%
(1326/1724)src.completion100%
(16/16)100%
(16/16)57%
(1778/3116)43%
(1242/2897)src.completion.expandingtree100%
(5/5)100%
(5/5)40%
(186/461)22%
(79/362)src.dialogs0%
(0/4)0%
(0/4)0%
(0/827)0%
(0/240)src.document100%
(4/4)100%
(4/4)59%
(1880/3193)48%
(1681/3485)src.export100%
(4/4)100%
(4/4)86%
(107/125)69%
(118/170)src.include.ktexteditor100%
(14/14)100%
(14/14)92%
(227/248)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(170/420)37%
(103/275)src.part0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/296)src.render100%
(9/9)100%
(9/9)76%
(922/1219)65%
(617/944)src.schema22%
(2/9)22%
(2/9)1%
(21/1501)1%
(6/729)src.script100%
(17/17)100%
(17/17)70%
(739/1057)59%
(307/519)src.search100%
(7/7)100%
(7/7)73%
(1099/1501)63%
(609/965)src.spellcheck75%
(6/8)75%

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/9/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 04 Dec 2017 12:15:31 +
 Build duration:
33 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 63 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.katefoldingtestFailed: TestSuite.katesyntaxtestFailed: TestSuite.movingrange_testFailed: TestSuite.vimode_view
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)89%
(299/337)89%
(299/337)68%
(33688/49224)52%
(17513/33916)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(49/49)100%
(49/49)93%
(4279/4624)49%
(2108/4316)autotests.src.vimode88%
(14/16)88%
(14/16)96%
(5297/5530)51%
(866/1698)src.buffer88%
(15/17)88%
(15/17)91%
(1704/1881)77%
(1326/1724)src.completion100%
(16/16)100%
(16/16)57%
(1777/3116)43%
(1241/2897)src.completion.expandingtree100%
(5/5)100%
(5/5)40%
(186/461)22%
(79/362)src.dialogs0%
(0/4)0%
(0/4)0%
(0/827)0%
(0/240)src.document100%
(4/4)100%
(4/4)59%
(1880/3193)48%
(1681/3485)src.export100%
(4/4)100%
(4/4)86%
(107/125)69%
(118/170)src.include.ktexteditor100%
(14/14)100%
(14/14)92%
(227/248)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(170/420)37%
(103/275)src.part0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/296)src.render100%
(9/9)100%
(9/9)76%
(922/1219)65%
(617/944)src.schema22%
(2/9)22%
(2/9)1%
(21/1501)1%
(6/729)src.script100%
(17/17)100%
(17/17)70%
(739/1057)59%
(307/519)src.search100%
(7/7)100%
(7/7)73%
(1099/1501)63%
(609/965)src.spellcheck75%
  

D9166: Remove double lookups

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  I expect this map to be very small, and creating a null KEmoticonsTheme 
allocates a d pointer, so I'm not 100% sure this is faster.
  
  But OK, I'm allergic to double lookups and people tend to reuse constructs 
they saw, so I still prefer the code after the change than before ;)

REPOSITORY
  R301 KEmoticons

BRANCH
  remove_double_loop

REVISION DETAIL
  https://phabricator.kde.org/D9166

To: mlaurent, dfaure
Cc: #frameworks

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/10/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 04 Dec 2017 12:06:40 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 63 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.katefoldingtestFailed: TestSuite.katesyntaxtestFailed: TestSuite.movingrange_testFailed: TestSuite.vimode_view
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)89%
(299/337)89%
(299/337)68%
(33695/49229)52%
(17512/33918)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(49/49)100%
(49/49)93%
(4290/4627)49%
(2110/4316)autotests.src.vimode88%
(14/16)88%
(14/16)96%
(5297/5530)51%
(866/1698)src.buffer88%
(15/17)88%
(15/17)91%
(1704/1881)77%
(1326/1724)src.completion100%
(16/16)100%
(16/16)57%
(1777/3116)43%
(1241/2897)src.completion.expandingtree100%
(5/5)100%
(5/5)40%
(186/461)22%
(79/362)src.dialogs0%
(0/4)0%
(0/4)0%
(0/827)0%
(0/240)src.document100%
(4/4)100%
(4/4)59%
(1880/3193)48%
(1681/3485)src.export100%
(4/4)100%
(4/4)86%
(107/125)69%
(118/170)src.include.ktexteditor100%
(14/14)100%
(14/14)92%
(227/248)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(170/420)37%
(103/275)src.part0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/296)src.render100%
(9/9)100%
(9/9)76%
(922/1219)65%
(617/944)src.schema22%
(2/9)22%
(2/9)1%
(21/1501)1%
(6/729)src.script100%
(17/17)100%
(17/17)70%
(739/1057)59%
(307/519)src.search100%
(7/7)100%
(7/7)73%
(1099/1501)63%
(609/965)src.spellcheck75%
   

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 108 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/108/
 Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
 Date of build:
Mon, 04 Dec 2017 11:42:39 +
 Build duration:
34 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.katesyntaxtest

D9166: Remove double lookups

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R301 KEmoticons

REVISION DETAIL
  https://phabricator.kde.org/D9166

To: mlaurent, dfaure
Cc: #frameworks

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/8/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 04 Dec 2017 11:42:39 +
 Build duration:
32 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 63 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.katefoldingtestFailed: TestSuite.katesyntaxtestFailed: TestSuite.movingrange_testFailed: TestSuite.vimode_view
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)89%
(299/337)89%
(299/337)68%
(33688/49224)52%
(17513/33916)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(49/49)100%
(49/49)93%
(4279/4624)49%
(2108/4316)autotests.src.vimode88%
(14/16)88%
(14/16)96%
(5297/5530)51%
(866/1698)src.buffer88%
(15/17)88%
(15/17)91%
(1704/1881)77%
(1326/1724)src.completion100%
(16/16)100%
(16/16)57%
(1777/3116)43%
(1241/2897)src.completion.expandingtree100%
(5/5)100%
(5/5)40%
(186/461)22%
(79/362)src.dialogs0%
(0/4)0%
(0/4)0%
(0/827)0%
(0/240)src.document100%
(4/4)100%
(4/4)59%
(1880/3193)48%
(1681/3485)src.export100%
(4/4)100%
(4/4)86%
(107/125)69%
(118/170)src.include.ktexteditor100%
(14/14)100%
(14/14)92%
(227/248)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(170/420)37%
(103/275)src.part0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/296)src.render100%
(9/9)100%
(9/9)76%
(922/1219)65%
(617/944)src.schema22%
(2/9)22%
(2/9)1%
(21/1501)1%
(6/729)src.script100%
(17/17)100%
(17/17)70%
(739/1057)59%
(307/519)src.search100%
(7/7)100%
(7/7)73%
(1099/1501)63%
(609/965)src.spellcheck75%
  

D9166: Remove double lookups

[Laurent Montel]

mlaurent created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REPOSITORY
  R301 KEmoticons

BRANCH
  remove_double_loop

REVISION DETAIL
  https://phabricator.kde.org/D9166

AFFECTED FILES
  src/core/kemoticons.cpp

To: mlaurent
Cc: #frameworks

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/9/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 04 Dec 2017 11:42:39 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 63 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.katefoldingtestFailed: TestSuite.katesyntaxtestFailed: TestSuite.movingrange_testFailed: TestSuite.vimode_view
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)89%
(299/337)89%
(299/337)68%
(33701/49230)52%
(17514/33918)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(49/49)100%
(49/49)93%
(4290/4627)49%
(2110/4316)autotests.src.vimode88%
(14/16)88%
(14/16)96%
(5297/5530)51%
(866/1698)src.buffer88%
(15/17)88%
(15/17)91%
(1704/1881)77%
(1326/1724)src.completion100%
(16/16)100%
(16/16)57%
(1778/3116)43%
(1242/2897)src.completion.expandingtree100%
(5/5)100%
(5/5)40%
(186/461)22%
(79/362)src.dialogs0%
(0/4)0%
(0/4)0%
(0/827)0%
(0/240)src.document100%
(4/4)100%
(4/4)59%
(1880/3193)48%
(1681/3485)src.export100%
(4/4)100%
(4/4)86%
(107/125)69%
(118/170)src.include.ktexteditor100%
(14/14)100%
(14/14)92%
(227/248)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(170/420)37%
(103/275)src.part0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/296)src.render100%
(9/9)100%
(9/9)76%
(922/1219)65%
(617/944)src.schema22%
(2/9)22%
(2/9)1%
(21/1501)1%
(6/729)src.script100%
(17/17)100%
(17/17)70%
(739/1057)59%
(307/519)src.search100%
(7/7)100%
(7/7)73%
(1099/1501)63%
(609/965)src.spellcheck75%

D9165: Lazy-instanciate and lazy-load KNotification plugins.

[Eike Hein]

hein added a subscriber: Frameworks.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D9165

To: hein, #plasma, #frameworks, davidedmundson
Cc: #frameworks, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9156: Fix a memory leak in KuitStaticData

[Jaime Torres Amate]

This revision was automatically updated to reflect the committed changes.
Closed by commit R249:170317278f6b: Fix a memory leak in KuitStaticData 
(authored by jtamate).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9156?vs=23400=23418

REVISION DETAIL
  https://phabricator.kde.org/D9156

AFFECTED FILES
  src/kuitmarkup.cpp

To: jtamate, #frameworks, dfaure

D9165: Lazy-instanciate and lazy-load KNotification plugins.

[Eike Hein]

hein created this revision.
hein added reviewers: Plasma, Frameworks, davidedmundson.
Restricted Application added projects: Plasma, Frameworks.

REVISION SUMMARY
  KNotificationManager always instanciates all of its built-in plugins
  as well as any externally supplied icons as soon as the first
  notification is sent, even if a particular plugin is not actually
  needed by the notification.
  
  This means e.g. always instanciating a text-to-speech engine even if
  a notification event doesn't have TTS on (as basically none do by
  default), or for that matter loading Phonon even when sounds are off.
  
  This patch implements a lazy-loading approach instead. With the
  patch applied, e.g. Konversation with default config will only ever
  instanciate the Taskbar plugin, as its notification events only
  enable this action by default.
  
  The patch also speeds up time from login screen to desktop, by way
  of the NetworkManager kded plugin not causing those costly
  instanciations with its very early notification events anymore.
  
  As a bonus, the patch also fixes a bug: The old code never properly
  supported runtime installation of new plugins. If a plugin were to
  be installed at runtime and enabled by the user in the config UI,
  it likely never would have been instanciated if a preceding
  notification had already caused the one and only instanciation pass
  by that time.

TEST PLAN
  Tests pass.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9165

AFFECTED FILES
  src/knotificationmanager.cpp
  src/knotificationmanager_p.h

To: hein, #plasma, #frameworks, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9164: Fix typo in namespace

[Dominik Haumann]

dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  There is an obvious typo in the namespace.
  I do not know, though, where this string is used.
  So what do we really fix here? :-)

TEST PLAN
  none

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  FixNamespace (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9164

AFFECTED FILES
  org_kde_ksyntaxhighlighting.categories

To: dhaumann, vkrause
Cc: #frameworks

D9157: Add API documentation about Search Paths

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:c59eedfa9087: Add API documentation about Search Paths 
(authored by dhaumann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9157?vs=23401=23415

REVISION DETAIL
  https://phabricator.kde.org/D9157

AFFECTED FILES
  src/lib/repository.h

To: dhaumann, vkrause, cullmann
Cc: #frameworks

D9123: reuse KPackage instance between PluginLoader and Applet

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> applet.cpp:98
>  :  QObject(0),
> -   d(new AppletPrivate(KPluginMetaData(), args.count() > 1 ? 
> args[1].toInt() : 0, this))
> +   d(new AppletPrivate(KPluginMetaData(), args.count() > 2 ? 
> args[2].toInt() : 0, this))
>  {

If anyone uses the old argument list syntax (where the first argument was a 
string or a kpluginmetadata)  this will break.

Can we be sure that the PluginLoader was the only user? 
It was a somewhat undocumented thing right?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9123

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9126: [RTL] - align properly the selected text for RTL

[Michail Vourlakos]

mvourlakos added a comment.


  without that line there is the following problem:
  
  if in the combobox list there are also LTR items then when these items are 
selected they are aligned to the left and
  when the RTL items are selected they are aligned to the right.
  
  By adding that line the LTR items in an RTL environment are aligned correctly 
to the right.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  rtl

REVISION DETAIL
  https://phabricator.kde.org/D9126

To: mvourlakos, #plasma, davidedmundson
Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8689: Fix the result of KDesktopFile::sortOrder()

[Alexander Volkov]

volkov added a comment.


  Well, at first I was planning to use this method in my project, but since 
it's not used in KDE
  and besides the SortOrder key is deprecated, I guess that 
KDesktopFile::sortOrder() should be
  marked as deprecated.
  The question is whether to fix it first?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8689

To: volkov, #frameworks
Cc: dfaure, #frameworks

D9126: [RTL] - align properly the selected text for RTL

[Kai Uwe Broulik]

broulik added a comment.


  I don't understand. Isn't this the default and doesn't it automatically 
mirror it (`effectiveHorizontalAlignment`)? (I'd be fine with this one liner 
going in but I'm wondering why it would be needed in the first place)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  rtl

REVISION DETAIL
  https://phabricator.kde.org/D9126

To: mvourlakos, #plasma, davidedmundson
Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9141: Setup QQmlEngine only once in QmlObject

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> mart wrote in qmlobject.h:72
> what about a different ctor which does that, but without exposing that enum?

What signature should I use for the constructor?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D9141

To: broulik, #plasma, mart
Cc: davidedmundson, hein, mart, plasma-devel, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D9157: Add API documentation about Search Paths

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  SearchPathsDocs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9157

To: dhaumann, vkrause, cullmann
Cc: #frameworks

D9118: ki18n cmake macros: Mark UIC-generated .h files to skip AUTOMOC by default

[Kevin Funk]

kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.


  This shouldn't create any troubles with earlier CMake versions.
  
  Also note that we set the same properties unconditionally in newer Qt5 CMake 
macros: https://codereview.qt-project.org/#/c/207327

INLINE COMMENTS

> KF5I18NMacros.cmake:56
>)
> +  set_property(SOURCE ${_header} PROPERTY SKIP_AUTOMOC ON)
>list(APPEND ${_sources} ${_header})

`set_source_files_properties(${_header} ...)` is probably the more canonical 
way to do this.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D9118

To: mpyne, #frameworks, #build_system, #localization, kfunk
Cc: aacid

D9162: KI18n: fix a number of double lookups

[David Faure]

dfaure closed this revision.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D9162

To: dfaure, ilic
Cc: #frameworks

D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

[Kevin Funk]

kfunk added a comment.


  In https://phabricator.kde.org/D3987#174960, @mkoller wrote:
  
  > I just found out that this change introduced wrong replacements.
  
  
  It did not, the changes are correct, though they're probably not what 
everyone expects.
  
  Please read through the comments in this Diff, this issue has been discussed 
in length already.
  
  tl;dr: Proposed resolution of this "problem": I'd replace `return nullptr` in 
your cases with `return {}` or just leave it as-is.
  
  > The changes in frameworks/kimageformats/src/imageformats like the following 
are incorrect, since the return type is not a pointer but an enum flags type, 
so it should still be 0, not nullptr.
  > 
  > @@ -337,10 +337,10 @@ QImageIOPlugin::Capabilities 
EPSPlugin::capabilities(QIODevice *device, const QB
  > 
  >   return Capabilities(CanRead | CanWrite);
  >   }
  >   if (!format.isEmpty()) {
  > 
  > - return 0; +return nullptr; } if (!device->isOpen()) {
  > - return 0; +return nullptr; }
  > 
  >   Capabilities cap;

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D3987

To: kfunk, #frameworks, dfaure, kossebau
Cc: mkoller, skelly, kossebau, dfaure, graesslin

D8367: Hidding place groups implementation in KFilePlacesModel

[Franck Arrecot]

franckarrecot updated this revision to Diff 23409.
franckarrecot added a comment.


  rebase to master

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8367?vs=23024=23409

REVISION DETAIL
  https://phabricator.kde.org/D8367

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/tests/placesitemmodeltest.cpp

To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent
Cc: mwolff, ngraham, mlaurent, #frameworks

D9015: Refactoring the hidding/showing animation use within KFilePlacesView

[Franck Arrecot]

franckarrecot updated this revision to Diff 23411.
franckarrecot added a comment.


  rebase to master

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9015?vs=23072=23411

REVISION DETAIL
  https://phabricator.kde.org/D9015

AFFECTED FILES
  src/filewidgets/kfileplacesview.cpp

To: franckarrecot, ervin, renatoo, mlaurent, ngraham
Cc: #frameworks

D8450: User can now hide an entire places group from KFilePlacesView

[Franck Arrecot]

franckarrecot updated this revision to Diff 23410.
franckarrecot added a comment.


  rebase to master

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8450?vs=23025=23410

REVISION DETAIL
  https://phabricator.kde.org/D8450

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/filewidgets/kfileplacesview.cpp

To: franckarrecot, ngraham, renatoo, ervin, mwolff, mlaurent
Cc: mwolff, #frameworks

D9162: KI18n: fix a number of double lookups

[Chusslove Illich]

ilic accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9162

To: dfaure, ilic
Cc: #frameworks

D9162: KI18n: fix a number of double lookups

[David Faure]

dfaure created this revision.
dfaure added a reviewer: ilic.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  contains()+value() is slower than just value()

TEST PLAN
  Unittests still pass

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9162

AFFECTED FILES
  src/kuitmarkup.cpp

To: dfaure, ilic
Cc: #frameworks

D9156: Fix a memory leak in KuitStaticData

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9156

To: jtamate, #frameworks, dfaure

Re: kcrash, fork, and stdout/stderr

[David Faure]

On lundi 4 décembre 2017 05:43:14 CET Thiago Macieira wrote:
> > Yes, no kdeinit involved. Here's the setup:
> > 
> > $ bin/kcrashtest testAutoRestartDirectly
> > 
> >   starts test_crasher (with QProcess, using waitForFinished())
> >   
> >   which crashes :)
> >   KCrash catches that, and since the Autorestart flag is set,
> >   
> >  sets the env var KCRASH_AUTO_RESTARTED,
> >  and starts test_crasher again (it checks that env var, so no
> > 
> > infinite loop)
> > 
> > The first test_crasher then exits (after waitpid(), but that's just
> > waiting
> > for the child to start, right?).
> 
> Sorry, more details here. Can you provide the strace for clone, pipe, pipe2,
> dup, dup2, dup3, execve, waitpid, waitid, wait4?
> 
> QProcess starts a process.
> 
> Does that process start something else? Or is QProcess's direct child that
> crashes?

It's exactly as I described. It's QProcess's direct child which crashes
(and which has a segv handler enabled, KCrash).

> The crash handler is in-process, correct? Then you execve in place?

fork+execve

https://lxr.kde.org/source/frameworks/kcrash/src/kcrash.cpp#0733

> Or do you fork a child at that point? fork from inside a signal handler is
> an incredibly bad idea, don't do it.

Well, I guess that's why it's the fallback from the main strategy which is 
"ask kdeinit to restart that application" (even if it doesn't provide a 
kdeinit module). But kdeinit might not be running, outside plasma workspace.

This has always been like that, it goes back to 2006 (Luboš), it was discussed 
with you https://marc.info/?l=kde-core-devel=113699766611213=2
("There's still a fallback to use fork() in case using kdeinit fails for 
any reason.")

> That makes QProcess not create a pipe and instead pass its own stderr to the
> child. Then it's SEP.

Yep, so from my POV the problem is fixed.

Thanks for the additional input!

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5