D10621: Highlighting Indexer: list of suggestions

[jonathan poelen]

jpoelen added a project: Framework: Syntax Highlighting.
jpoelen added a subscriber: Framework: Syntax Highlighting.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10621

To: jpoelen, dhaumann
Cc: #framework_syntax_highlighting, dhaumann, #frameworks, michaelh, 
genethomas, cullmann, vkrause

D10621: Highlighting Indexer: list of suggestions

[jonathan poelen]

jpoelen created this revision.
jpoelen added a reviewer: dhaumann.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
jpoelen requested review of this revision.

REVISION SUMMARY
  Proposes mergers of rules and the replacement of:
  
  - RegExp by StringDetect, AnyChar, RangeDetect, etc.
  - StringDetect by DetectChar or Detect2Chars.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  suggest

REVISION DETAIL
  https://phabricator.kde.org/D10621

AFFECTED FILES
  src/indexer/katehighlightingindexer.cpp

To: jpoelen, dhaumann
Cc: dhaumann, #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 119 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/119/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 17 Feb 2018 23:54:34 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 139 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/139/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 17 Feb 2018 23:08:19 +
 Build duration:
1 hr 1 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/443)67%
(295/443)53%
(31521/59569)38%
(18507/48842)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8565/9113)48%
(5229/10793)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8346/14337)50%
(4868/9704)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3874/7840)33%
(1634/4928)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(512/974)41%
(413/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 118 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/118/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 17 Feb 2018 22:28:39 +
 Build duration:
1 hr 25 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest

D10414: Add move semantics support to KIO::UDSEntry.

[Ben Cooksley]

bcooksley added a comment.


  Looks like QT_LSTAT doesn't exist on Windows - see 
https://git.reviewboard.kde.org/r/127727/

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10414

To: markg, dfaure
Cc: bcooksley, apol, #frameworks, michaelh

D10617: Fix "ambiguous shortcut" issue introduced with D10314

[Nathaniel Graham]

ngraham added a comment.


  The shortcut won't affect other apps since the file dialog its its own 
context. Even if the host app uses F12 for something, the file dialog will grab 
the key first, so there's no "ambiguous shortcut" issue.
  
  That said, I'm not wedded to F12 by any stretch of the imagination, and I 
think removing it entirely wouldn't be the worst thing in the world either.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10617

To: ngraham, #frameworks, #dolphin, markg, elvisangelaccio
Cc: michaelh

D10414: Add move semantics support to KIO::UDSEntry.

[Mark Gaiser]

markg added a comment.


  Right, it didn't fix it... 
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/195/console
  Could someone with a windows setup (compiler and kio) compile kio and tell me 
what is wrong here?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10414

To: markg, dfaure
Cc: apol, #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 137 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/137/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Sat, 17 Feb 2018 23:08:19 +
 Build duration:
8 min 59 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/443)67%
(295/443)53%
(31515/59567)38%
(18505/48918)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8565/9113)48%
(5229/10793)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8336/14336)50%
(4867/9708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3874/7840)33%
(1634/4928)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/974)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 195 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/195/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Sat, 17 Feb 2018 23:08:20 +
 Build duration:
8 min 34 sec and counting
   CONSOLE OUTPUT
  [...truncated 580.69 KB...][ 46%] Built target kmountpointtestScanning dependencies of target listdirtest[ 46%] Building CXX object autotests/CMakeFiles/listdirtest.dir/listdirtest.cpp.obj[ 46%] Building CXX object autotests/CMakeFiles/listdirtest.dir/listdirtest_autogen/mocs_compilation.cpp.objlistdirtest.cppmocs_compilation.cpp[ 46%] Linking CXX executable ..\bin\listdirtest.exe[ 46%] Built target listdirtestScanning dependencies of target globaltest[ 46%] Building CXX object autotests/CMakeFiles/globaltest.dir/globaltest.cpp.obj[ 46%] Building CXX object autotests/CMakeFiles/globaltest.dir/globaltest_autogen/mocs_compilation.cpp.objglobaltest.cppmocs_compilation.cpp[ 46%] Linking CXX executable ..\bin\globaltest.exe[ 46%] Built target globaltestScanning dependencies of target jobremotetest[ 46%] Building CXX object autotests/CMakeFiles/jobremotetest.dir/jobremotetest.cpp.obj[ 46%] Building CXX object autotests/CMakeFiles/jobremotetest.dir/jobremotetest_autogen/mocs_compilation.cpp.objjobremotetest.cppmocs_compilation.cpp[ 46%] Linking CXX executable ..\bin\jobremotetest.exe[ 46%] Built target jobremotetestScanning dependencies of target upurltest[ 46%] Building CXX object autotests/CMakeFiles/upurltest.dir/upurltest.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/upurltest.dir/upurltest_autogen/mocs_compilation.cpp.objupurltest.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\upurltest.exe[ 47%] Built target upurltestScanning dependencies of target dataprotocoltest[ 47%] Building CXX object autotests/CMakeFiles/dataprotocoltest.dir/dataprotocoltest.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/dataprotocoltest.dir/dataprotocoltest_autogen/mocs_compilation.cpp.objdataprotocoltest.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\dataprotocoltest.exe[ 47%] Built target dataprotocoltestScanning dependencies of target udsentry_benchmark[ 47%] Building CXX object autotests/CMakeFiles/udsentry_benchmark.dir/udsentry_benchmark.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/udsentry_benchmark.dir/udsentry_benchmark_autogen/mocs_compilation.cpp.objudsentry_benchmark.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\udsentry_benchmark.exe[ 47%] Built target udsentry_benchmarkScanning dependencies of target jobtest[ 47%] Building CXX object autotests/CMakeFiles/jobtest.dir/jobtest.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/jobtest.dir/jobtest_autogen/mocs_compilation.cpp.objjobtest.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\jobtest.exe[ 47%] Built target jobtestScanning dependencies of target kprotocolinfotest[ 47%] Building CXX object autotests/CMakeFiles/kprotocolinfotest.dir/kprotocolinfotest.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/kprotocolinfotest.dir/kprotocolinfotest_autogen/mocs_compilation.cpp.objkprotocolinfotest.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\kprotocolinfotest.exe[ 47%] Built target kprotocolinfotestScanning dependencies of target ktcpsockettest[ 47%] Building CXX object autotests/CMakeFiles/ktcpsockettest.dir/ktcpsockettest.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/ktcpsockettest.dir/ktcpsockettest_autogen/mocs_compilation.cpp.objktcpsockettest.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\ktcpsockettest.exe[ 47%] Built target ktcpsockettestScanning dependencies of target mkpathjobtest[ 47%] Building CXX object autotests/CMakeFiles/mkpathjobtest.dir/mkpathjobtest_autogen/mocs_compilation.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/mkpathjobtest.dir/mkpathjobtest.cpp.objmkpathjobtest.cppmocs_compilation.cpp[ 48%] Linking CXX executable ..\bin\mkpathjobtest.exe[ 48%] Built target mkpathjobtestScanning dependencies of target threadtest[ 48%] Building CXX object autotests/CMakeFiles/threadtest.dir/threadtest_autogen/mocs_compilation.cpp.obj[ 48%] Building CXX object autotests/CMakeFiles/threadtest.dir/threadtest.cpp.objthreadtest.cppmocs_compilation.cppC:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\autotests\threadtest.cpp(53): warning C4551: function call missing argument list[ 48%] Linking CXX executable ..\bin\threadtest.exe[ 48%] Built target threadtestScanning dependencies of target udsentrytest[ 48%] Building CXX object autotests/CMakeFiles/udsentrytest.dir/udsentrytest.cpp.obj[ 48%] Building CXX object autotests/CMakeFiles/udsentrytest.dir/udsentrytest_autogen/mocs_compilation.cpp.objudsentrytest.cppmocs_compilation.cppC:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\autotests\udsentrytest.cpp(241): error C3861: 'QT_LSTAT': identifier not foundjom: C:\CI\workspace\Frameworks kio kf5-qt5 

D10414: Add move semantics support to KIO::UDSEntry.

[Mark Gaiser]

markg added a comment.


  Right, this one is my fault: 
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/193/
  Weird that QT_LSTAT is no problem on linux without including qplatformdefs.h, 
on windows it apparently is.
  I pushed the fix: 
https://cgit.kde.org/kio.git/commit/?id=11051f3709cdc651a68990a9c17a69c33d5812db

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10414

To: markg, dfaure
Cc: apol, #frameworks, michaelh

D10617: Fix "ambiguous shortcut" issue introduced with D10314

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Would be nice to get more feedback before choosing a shortcut that affects 
many applications.
  
  I don't think that F12 is a good choice. The F keys are few and some of them 
are already taken (Help, Rename, Reload, Fullscreen - and yes, it's bad that 
dolphin uses F11 for another thing).
  We should try not to use them for "global" shortcuts, but instead let each 
application choose what they want to do with them.
  
  Do we really need a shortcut for the inline preview in the first place? If we 
do, let's find something else...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10617

To: ngraham, #frameworks, #dolphin, markg, elvisangelaccio
Cc: michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

[Michael Pyne]

mpyne added a comment.


  OK then, I think @kossebau is right in that this is a dependency issue in the 
`lookandfeel` part of plasma-desktop.  The `kcm_lookandfeel` target declares 
the JSON dependency (with the CMake macro) in time for CMake to care about it 
and ensure the generated build system picks up the dependency for automoc to 
run.  The `lookandfeel` command line tool target does not add the dependency on 
the JSON file and there's no other reason for CMake to know that the JSON file 
must be generated before `lookandfeel`'s AUTOMOC can complete.
  
  ie. CMake perceives this order as legal:
  
  1. AUTOMOC for `lookandfeel`
  2. moc runs on kcm.cpp
  3. JSON generation for AUTOMOC for `kcm_lookandfeel`
  4. kcm_lookandfeel.json is generated
  5. AUTOMOC for `kcm_lookandfeel`
  6. moc runs on kcm.cpp
  7. build continues
  
  2 and 6 are identical here and it seems that CMake is smart enough to only do 
this once in the whole build, but CMake only has the dependency on the JSON for 
the moc at step 6, not step 2, so CMake doesn't know that it also needs to 
delay `lookandfeel`'s AUTOMOC phase until after JSON generation.
  
  That all said, if D10607  works (and that 
diff is precisely how I'd suggest handling the issue), then I think we can then 
abandon this revision.  Let me know if you disagree.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10450

To: tcberner, #freebsd, mpyne, bshah, dfaure, rakuco
Cc: bcooksley, rikmills, rakuco, kfunk, adridg, kossebau, #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 194 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/194/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Sat, 17 Feb 2018 22:36:29 +
 Build duration:
9 min 23 sec and counting
   CONSOLE OUTPUT
  [...truncated 579.17 KB...][ 46%] Built target kmountpointtestScanning dependencies of target listdirtest[ 46%] Building CXX object autotests/CMakeFiles/listdirtest.dir/listdirtest.cpp.obj[ 46%] Building CXX object autotests/CMakeFiles/listdirtest.dir/listdirtest_autogen/mocs_compilation.cpp.objlistdirtest.cppmocs_compilation.cpp[ 46%] Linking CXX executable ..\bin\listdirtest.exe[ 46%] Built target listdirtestScanning dependencies of target globaltest[ 46%] Building CXX object autotests/CMakeFiles/globaltest.dir/globaltest.cpp.obj[ 46%] Building CXX object autotests/CMakeFiles/globaltest.dir/globaltest_autogen/mocs_compilation.cpp.objglobaltest.cppmocs_compilation.cpp[ 46%] Linking CXX executable ..\bin\globaltest.exe[ 46%] Built target globaltestScanning dependencies of target jobremotetest[ 46%] Building CXX object autotests/CMakeFiles/jobremotetest.dir/jobremotetest.cpp.obj[ 46%] Building CXX object autotests/CMakeFiles/jobremotetest.dir/jobremotetest_autogen/mocs_compilation.cpp.objjobremotetest.cppmocs_compilation.cpp[ 46%] Linking CXX executable ..\bin\jobremotetest.exe[ 46%] Built target jobremotetestScanning dependencies of target upurltest[ 47%] Building CXX object autotests/CMakeFiles/upurltest.dir/upurltest.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/upurltest.dir/upurltest_autogen/mocs_compilation.cpp.objupurltest.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\upurltest.exe[ 47%] Built target upurltestScanning dependencies of target dataprotocoltest[ 47%] Building CXX object autotests/CMakeFiles/dataprotocoltest.dir/dataprotocoltest.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/dataprotocoltest.dir/dataprotocoltest_autogen/mocs_compilation.cpp.objdataprotocoltest.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\dataprotocoltest.exe[ 47%] Built target dataprotocoltestScanning dependencies of target udsentry_benchmark[ 47%] Building CXX object autotests/CMakeFiles/udsentry_benchmark.dir/udsentry_benchmark.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/udsentry_benchmark.dir/udsentry_benchmark_autogen/mocs_compilation.cpp.objudsentry_benchmark.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\udsentry_benchmark.exe[ 47%] Built target udsentry_benchmarkScanning dependencies of target jobtest[ 47%] Building CXX object autotests/CMakeFiles/jobtest.dir/jobtest.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/jobtest.dir/jobtest_autogen/mocs_compilation.cpp.objjobtest.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\jobtest.exe[ 47%] Built target jobtestScanning dependencies of target kprotocolinfotest[ 47%] Building CXX object autotests/CMakeFiles/kprotocolinfotest.dir/kprotocolinfotest.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/kprotocolinfotest.dir/kprotocolinfotest_autogen/mocs_compilation.cpp.objkprotocolinfotest.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\kprotocolinfotest.exe[ 47%] Built target kprotocolinfotestScanning dependencies of target ktcpsockettest[ 47%] Building CXX object autotests/CMakeFiles/ktcpsockettest.dir/ktcpsockettest.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/ktcpsockettest.dir/ktcpsockettest_autogen/mocs_compilation.cpp.objktcpsockettest.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\ktcpsockettest.exe[ 47%] Built target ktcpsockettestScanning dependencies of target mkpathjobtest[ 47%] Building CXX object autotests/CMakeFiles/mkpathjobtest.dir/mkpathjobtest.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/mkpathjobtest.dir/mkpathjobtest_autogen/mocs_compilation.cpp.objmkpathjobtest.cppmocs_compilation.cpp[ 48%] Linking CXX executable ..\bin\mkpathjobtest.exe[ 48%] Built target mkpathjobtestScanning dependencies of target threadtest[ 48%] Building CXX object autotests/CMakeFiles/threadtest.dir/threadtest_autogen/mocs_compilation.cpp.obj[ 48%] Building CXX object autotests/CMakeFiles/threadtest.dir/threadtest.cpp.objthreadtest.cppmocs_compilation.cppC:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\autotests\threadtest.cpp(53): warning C4551: function call missing argument list[ 48%] Linking CXX executable ..\bin\threadtest.exe[ 48%] Built target threadtestScanning dependencies of target udsentrytest[ 48%] Building CXX object autotests/CMakeFiles/udsentrytest.dir/udsentrytest.cpp.obj[ 48%] Building CXX object autotests/CMakeFiles/udsentrytest.dir/udsentrytest_autogen/mocs_compilation.cpp.objudsentrytest.cppmocs_compilation.cppC:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\autotests\udsentrytest.cpp(240): error C3861: 'QT_LSTAT': identifier not foundjom: C:\CI\workspace\Frameworks kio kf5-qt5 

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 138 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/138/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 17 Feb 2018 22:33:28 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/443)67%
(295/443)53%
(31515/59569)38%
(18500/48842)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8565/9113)48%
(5228/10793)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8336/14337)50%
(4863/9704)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3874/7840)33%
(1634/4928)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/974)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 136 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/136/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Sat, 17 Feb 2018 22:35:21 +
 Build duration:
8 min 14 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/443)67%
(295/443)53%
(31511/59567)38%
(18496/48918)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8565/9113)48%
(5228/10793)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8337/14336)50%
(4867/9708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3874/7840)33%
(1634/4928)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/974)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 193 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/193/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Sat, 17 Feb 2018 22:19:44 +
 Build duration:
15 min and counting
   CONSOLE OUTPUT
  [...truncated 581.71 KB...][ 46%] Built target kmountpointtestScanning dependencies of target listdirtest[ 46%] Building CXX object autotests/CMakeFiles/listdirtest.dir/listdirtest.cpp.obj[ 46%] Building CXX object autotests/CMakeFiles/listdirtest.dir/listdirtest_autogen/mocs_compilation.cpp.objlistdirtest.cppmocs_compilation.cpp[ 46%] Linking CXX executable ..\bin\listdirtest.exe[ 46%] Built target listdirtestScanning dependencies of target globaltest[ 46%] Building CXX object autotests/CMakeFiles/globaltest.dir/globaltest.cpp.obj[ 46%] Building CXX object autotests/CMakeFiles/globaltest.dir/globaltest_autogen/mocs_compilation.cpp.objglobaltest.cppmocs_compilation.cpp[ 46%] Linking CXX executable ..\bin\globaltest.exe[ 46%] Built target globaltestScanning dependencies of target jobremotetest[ 46%] Building CXX object autotests/CMakeFiles/jobremotetest.dir/jobremotetest.cpp.obj[ 46%] Building CXX object autotests/CMakeFiles/jobremotetest.dir/jobremotetest_autogen/mocs_compilation.cpp.objjobremotetest.cppmocs_compilation.cpp[ 46%] Linking CXX executable ..\bin\jobremotetest.exe[ 46%] Built target jobremotetestScanning dependencies of target upurltest[ 47%] Building CXX object autotests/CMakeFiles/upurltest.dir/upurltest.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/upurltest.dir/upurltest_autogen/mocs_compilation.cpp.objupurltest.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\upurltest.exe[ 47%] Built target upurltestScanning dependencies of target dataprotocoltest[ 47%] Building CXX object autotests/CMakeFiles/dataprotocoltest.dir/dataprotocoltest_autogen/mocs_compilation.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/dataprotocoltest.dir/dataprotocoltest.cpp.objdataprotocoltest.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\dataprotocoltest.exe[ 47%] Built target dataprotocoltestScanning dependencies of target udsentry_benchmark[ 47%] Building CXX object autotests/CMakeFiles/udsentry_benchmark.dir/udsentry_benchmark_autogen/mocs_compilation.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/udsentry_benchmark.dir/udsentry_benchmark.cpp.objudsentry_benchmark.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\udsentry_benchmark.exe[ 47%] Built target udsentry_benchmarkScanning dependencies of target jobtest[ 47%] Building CXX object autotests/CMakeFiles/jobtest.dir/jobtest.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/jobtest.dir/jobtest_autogen/mocs_compilation.cpp.objjobtest.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\jobtest.exe[ 47%] Built target jobtestScanning dependencies of target kprotocolinfotest[ 47%] Building CXX object autotests/CMakeFiles/kprotocolinfotest.dir/kprotocolinfotest.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/kprotocolinfotest.dir/kprotocolinfotest_autogen/mocs_compilation.cpp.objkprotocolinfotest.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\kprotocolinfotest.exe[ 47%] Built target kprotocolinfotestScanning dependencies of target ktcpsockettest[ 47%] Building CXX object autotests/CMakeFiles/ktcpsockettest.dir/ktcpsockettest.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/ktcpsockettest.dir/ktcpsockettest_autogen/mocs_compilation.cpp.objktcpsockettest.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\ktcpsockettest.exe[ 47%] Built target ktcpsockettestScanning dependencies of target mkpathjobtest[ 47%] Building CXX object autotests/CMakeFiles/mkpathjobtest.dir/mkpathjobtest.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/mkpathjobtest.dir/mkpathjobtest_autogen/mocs_compilation.cpp.objmkpathjobtest.cppmocs_compilation.cpp[ 48%] Linking CXX executable ..\bin\mkpathjobtest.exe[ 48%] Built target mkpathjobtestScanning dependencies of target threadtest[ 48%] Building CXX object autotests/CMakeFiles/threadtest.dir/threadtest.cpp.obj[ 48%] Building CXX object autotests/CMakeFiles/threadtest.dir/threadtest_autogen/mocs_compilation.cpp.objthreadtest.cppmocs_compilation.cppC:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\autotests\threadtest.cpp(53): warning C4551: function call missing argument list[ 48%] Linking CXX executable ..\bin\threadtest.exe[ 48%] Built target threadtestScanning dependencies of target udsentrytest[ 48%] Building CXX object autotests/CMakeFiles/udsentrytest.dir/udsentrytest.cpp.obj[ 48%] Building CXX object autotests/CMakeFiles/udsentrytest.dir/udsentrytest_autogen/mocs_compilation.cpp.objudsentrytest.cppmocs_compilation.cppC:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\autotests\udsentrytest.cpp(240): error C3861: 'QT_LSTAT': identifier not foundjom: C:\CI\workspace\Frameworks kio kf5-qt5 

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 135 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/135/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Sat, 17 Feb 2018 22:19:44 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/443)67%
(296/443)53%
(31737/59584)38%
(18616/48918)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8565/9113)48%
(5230/10793)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8336/14336)50%
(4868/9708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3881/7841)33%
(1636/4928)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/974)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

D10450: Generate a custom target in kcoreaddons_desktop_to_json

[Raphael Kubo da Costa]

rakuco added a comment.


  > This isn't just a problem on KDE Neon though, is it? I thought FreeBSD is 
also affected?
  
  To be clear, FreeBSD is affected by not having any fix in the tree (i.e. the 
json file not being present when moc is invoked), whereas Neon fails with 
D10485  applied.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10450

To: tcberner, #freebsd, mpyne, bshah, dfaure, rakuco
Cc: bcooksley, rikmills, rakuco, kfunk, adridg, kossebau, #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 137 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/137/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 17 Feb 2018 22:19:44 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/443)67%
(295/443)53%
(31516/59569)38%
(18503/48842)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8565/9113)48%
(5228/10793)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8337/14337)50%
(4866/9704)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3874/7840)33%
(1634/4928)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/974)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.7 - Build # 75 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.7/75/
 Project:
Frameworks kirigami kf5-qt5 SUSEQt5.7
 Date of build:
Sat, 17 Feb 2018 22:24:56 +
 Build duration:
4 min 42 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/4)0%
(0/14)0%
(0/14)0%
(0/879)0%
(0/579)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsexamples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)examples.galleryapp0%
(0/1)0%
(0/1)0%
(0/10)0%
(0/4)src0%
(0/7)0%
(0/7)0%
(0/533)0%
(0/428)src.libkirigami0%
(0/5)0%
(0/5)0%
(0/328)0%
(0/147)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 117 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/117/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 17 Feb 2018 22:19:44 +
 Build duration:
8 min 13 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.7 - Build # 74 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.7/74/
 Project:
Frameworks kirigami kf5-qt5 SUSEQt5.7
 Date of build:
Thu, 15 Feb 2018 19:06:30 +
 Build duration:
2 days 3 hr and counting
   CONSOLE OUTPUT
  [...truncated 109.86 KB...]-- /home/jenkins/workspace/Frameworks kirigami kf5-qt5 SUSEQt5.7/build/breeze-icons/src/breeze-icons/icons/actions/16/go-previous.svg-- /home/jenkins/workspace/Frameworks kirigami kf5-qt5 SUSEQt5.7/build/breeze-icons/src/breeze-icons/icons/actions/16/go-next.svg-- /home/jenkins/workspace/Frameworks kirigami kf5-qt5 SUSEQt5.7/build/breeze-icons/src/breeze-icons/icons/actions/32/overflow-menu.svg-- The following OPTIONAL packages have been found: * Qt5Test (required version >= 5.7.0) * Git-- The following REQUIRED packages have been found: * Qt5Network (required version >= 5.7.1) * Qt5Qml (required version >= 5.7.1) * Qt5Quick * Qt5Gui * Qt5Widgets (required version >= 5.7.1) * Qt5Svg * Qt5QuickControls2 * Qt5 (required version >= 5.7.0) * ECM (required version >= 5.43.0), Extra CMake Modules.,  * Qt5Core-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following RUNTIME packages have not been found: * QtGraphicalEffects-QMLModule, QML module 'QtGraphicalEffects' is a runtime dependency.-- Configuring doneCMake Warning (dev) in examples/galleryapp/CMakeLists.txt:  Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED files.  Run "cmake --help-policy CMP0071" for policy details.  Use the cmake_policy  command to set the policy and suppress this warning.  For compatibility, CMake is excluding the GENERATED source file(s):"/home/jenkins/workspace/Frameworks kirigami kf5-qt5 SUSEQt5.7/build/examples/galleryapp/qrc_resources.cpp"  from processing by AUTOMOC.  If any of the files should be processed, set  CMP0071 to NEW.  If any of the files should not be processed, explicitly  exclude them by setting the source file property SKIP_AUTOMOC:set_property(SOURCE file.h PROPERTY SKIP_AUTOMOC ON)This warning is for project developers.  Use -Wno-dev to suppress it.CMake Warning (dev) in examples/applicationitemapp/CMakeLists.txt:  Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED files.  Run "cmake --help-policy CMP0071" for policy details.  Use the cmake_policy  command to set the policy and suppress this warning.  For compatibility, CMake is excluding the GENERATED source file(s):"/home/jenkins/workspace/Frameworks kirigami kf5-qt5 SUSEQt5.7/build/examples/applicationitemapp/qrc_resources.cpp"  from processing by AUTOMOC.  If any of the files should be processed, set  CMP0071 to NEW.  If any of the files should not be processed, explicitly  exclude them by setting the source file property SKIP_AUTOMOC:set_property(SOURCE file.h PROPERTY SKIP_AUTOMOC ON)This warning is for project developers.  Use -Wno-dev to suppress it.-- Generating done-- Build files have been written to: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 SUSEQt5.7/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks kirigami kf5-qt5 SUSEQt5.7] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kirigami --branchGroup kf5-qt5 --platform SUSEQt5.7 --usingInstall /home/jenkins//install-prefix/Scanning dependencies of target KF5Kirigami2_autogenScanning dependencies of target copy[  3%] Automatic MOC for target KF5Kirigami2[  3%] Built target copyScanning dependencies of target kirigami2gallery_autogen[  6%] Automatic MOC for target kirigami2gallery[  6%] Built target kirigami2gallery_autogenScanning dependencies of target applicationitemapp_autogen[ 10%] Automatic MOC for target applicationitemapp[ 10%] Built target applicationitemapp_autogen[ 13%] Generating qrc_resources.cppScanning dependencies of target kirigami2gallery[ 13%] Built target KF5Kirigami2_autogen[ 17%] Building CXX object examples/galleryapp/CMakeFiles/kirigami2gallery.dir/main.cpp.omake[1]: *** [CMakeFiles/Makefile2:404: examples/galleryapp/CMakeFiles/kirigami2gallery.dir/all] Terminatedmake: *** [Makefile:163: all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks kirigami kf5-qt5 SUSEQt5.7] Running shell script+ python3 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext

D10450: Generate a custom target in kcoreaddons_desktop_to_json

[Ben Cooksley]

bcooksley added a comment.


  For the record, the FreeBSD builds on the CI system hit this fairly regularly.
  As shown by 
https://build.kde.org/view/Plasma/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10450

To: tcberner, #freebsd, mpyne, bshah, dfaure, rakuco
Cc: bcooksley, rikmills, rakuco, kfunk, adridg, kossebau, #frameworks, michaelh

D10414: Add move semantics support to KIO::UDSEntry.

[Mark Gaiser]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:d8414425acc5: Add move semantics support to 
KIO::UDSEntry. (authored by markg).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10414?vs=27431=27432

REVISION DETAIL
  https://phabricator.kde.org/D10414

AFFECTED FILES
  autotests/udsentrytest.cpp
  autotests/udsentrytest.h
  src/core/udsentry.cpp
  src/core/udsentry.h

To: markg, dfaure
Cc: apol, #frameworks, michaelh

D10414: Add move semantics support to KIO::UDSEntry.

[Mark Gaiser]

markg marked 3 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10414

To: markg, dfaure
Cc: apol, #frameworks, michaelh

D10414: Add move semantics support to KIO::UDSEntry.

[Mark Gaiser]

markg updated this revision to Diff 27431.
markg added a comment.


  Add @since lines where for the move assignment operator and constructor.
  Typo fix.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10414?vs=27028=27431

BRANCH
  udsentry_move

REVISION DETAIL
  https://phabricator.kde.org/D10414

AFFECTED FILES
  autotests/udsentrytest.cpp
  autotests/udsentrytest.h
  src/core/udsentry.cpp
  src/core/udsentry.h

To: markg, dfaure
Cc: apol, #frameworks, michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

[Michael Pyne]

mpyne added a comment.


  In D10450#208453 , @kossebau wrote:
  
  > So just to make sure we are all on the same page: for what I have 
understood meanwhile is what is missing but needed here is a dependency rule 
between
  >  a) the generated JSON file (`kcm_lookandfeel.json`)
  >  b) the generated moc file (`kcm.moc`) created by moc for the source file 
which references that JSON file in the related QObject subclass declaration and 
also has the include statement (`kcm.cpp`)
  >
  > And this is what
  >
  >   set_property(TARGET ${target} APPEND PROPERTY AUTOGEN_TARGET_DEPENDS 
${json})
  >
  >
  > should ensure at least by what the docs claim IIUC, but somehow does not.
  
  
  OK, I see what you're talking about.
  
  > And adding
  > 
  >   add_dependencies(${target} ${_json_target})
  > 
  > 
  > would also not ensure that straight dependency between the creation of the 
JSON file and the time when moc is run, no?
  
  No, you're right, it would only ensure that automoc and JSON creation both 
happen before the rest of the normal target build occurs.
  
  The custom target has a separate annoyance, using `add_custom_target` instead 
of `add_custom_command` makes it so that the entire JSON generation process 
seems to happen each time make or ninja is run, rather than only when needed 
from the dependencies changing, though I think this is due to the 
`add_dependencies` call rather than any issue specific to the CMake target 
itself.
  
  This isn't just a problem on KDE Neon though, is it?  I thought FreeBSD is 
also affected?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10450

To: tcberner, #freebsd, mpyne, bshah, dfaure, rakuco
Cc: rikmills, rakuco, kfunk, adridg, kossebau, #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 134 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/134/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Sat, 17 Feb 2018 21:37:54 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/443)67%
(295/443)53%
(31483/59556)38%
(18492/48884)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8548/9096)48%
(5212/10759)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8321/14342)50%
(4867/9708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3874/7840)33%
(1634/4928)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/974)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 136 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/136/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 17 Feb 2018 21:37:54 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/443)67%
(295/443)53%
(31481/59557)38%
(18476/48808)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8548/9096)48%
(5216/10759)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8329/14342)50%
(4863/9704)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3874/7840)33%
(1634/4928)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/974)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 116 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/116/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 17 Feb 2018 21:37:54 +
 Build duration:
8 min 45 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirmodeltest

D10617: Fix "ambiguous shortcut" issue introduced with D10314

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:c2a80e71b39d: Fix ambiguous shortcut issue 
introduced with D10314 (authored by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10617?vs=27428=27430

REVISION DETAIL
  https://phabricator.kde.org/D10617

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kfilewidget.cpp

To: ngraham, #frameworks, #dolphin, markg, elvisangelaccio
Cc: michaelh

D10616: Add Ctrl+H to the list of shortcuts for "show/hide hidden files"

[Nathaniel Graham]

ngraham added a comment.


  The file dialog uses two different methods of setting shortcuts. Most are set 
in `kdiroperator.cpp`, but only few are set in `kfilewidget.cpp` I suspect 
legacy code, and it seems sensible to use the more standard, consistent style 
whenever possible.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10616

To: ngraham, #frameworks, #dolphin, elvisangelaccio, markg
Cc: markg, michaelh

D9862: Don't create 2 msgbox (one of them crashes) when can't change rights.

[Jaime Torres Amate]

jtamate edited the summary of this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D9862

To: jtamate, #frameworks, dfaure
Cc: michaelh

D10616: Add Ctrl+H to the list of shortcuts for "show/hide hidden files"

[Mark Gaiser]

markg accepted this revision.
markg added a comment.
This revision is now accepted and ready to land.


  Fine by me.
  I do wonder why it used to be in an if statement though. It would have added 
a nullptr if the "if (showHidden)" check failed (which would fail when it's a 
nullptr).

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10616

To: ngraham, #frameworks, #dolphin, elvisangelaccio, markg
Cc: markg, michaelh

D9862: Don't create 2 msgbox (one of them crashes) when can't change rights.

[Jaime Torres Amate]

jtamate added a reviewer: dfaure.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D9862

To: jtamate, #frameworks, dfaure
Cc: michaelh

D9862: Don't create 2 msgbox (one of them crashes) when can't change rights.

[Jaime Torres Amate]

jtamate updated this revision to Diff 27429.
jtamate added a comment.


  I still can trigger the crash without the patch with KF5 5.42 (opensuse)
  
  Improved the patch it a little bit, including a QASSERT to know where the 
double finish originates.

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9862?vs=25276=27429

BRANCH
  skip (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9862

AFFECTED FILES
  src/lib/jobs/kjob.cpp

To: jtamate, #frameworks
Cc: michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

[Friedrich W . H . Kossebau]

kossebau added a comment.


  In D10450#208413 , @mpyne wrote:
  
  > Yes, I think I agree with @rakuco.  Especially since the fix for D10485 
 ended up being reverted.
  
  
  Would be happy if anyone on KDE neon could explore why it fails there (only 
reported for it so far AFAIK) so it had to be reverted. D10607 
 meanwhile up as a less 
fragile-with-automoc variant.
  
  > I still think a separate fix is needed for kcm_lookandfeel, but the issue 
is that the `kcoreaddons_desktop_to_json` macro generates a JSON file which is 
intended for use in a compiled file, and there's no easy way to connect that 
dependency within *this* macro since the dependent source file is never 
actually passed into the macro.
  
  So just to make sure we are all on the same page: for what I have understood 
meanwhile is what is missing but needed here is a dependency rule between
  a) the generated JSON file (`kcm_lookandfeel.json`)
  b) the generated moc file (`kcm.moc`) created by moc for the source file 
which references that JSON file in the related QObject subclass declaration and 
also has the include statement (`kcm.cpp`)
  
  And this is what
  
set_property(TARGET ${target} APPEND PROPERTY AUTOGEN_TARGET_DEPENDS 
${json})
  
  should ensure at least by what the docs claim IIUC, but somehow does not.
  
  > Alternately we could try to do what the kcoreaddons_add_plugin macro does 
and let the calling code pass in the sources to be made dependent upon the JSON.
  
  All the other source files should not have any influence here, only the cpp 
file referencing the JSON file.
  
  And adding
  
add_dependencies(${target} ${_json_target})
  
  would also not ensure that straight dependency between the creation of the 
JSON file and the time when moc is run, no?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10450

To: tcberner, #freebsd, mpyne, bshah, dfaure, rakuco
Cc: rikmills, rakuco, kfunk, adridg, kossebau, #frameworks, michaelh

D10617: Fix "ambiguous shortcut" issue introduced with D10314

[Mark Gaiser]

markg accepted this revision.
markg added a comment.
This revision is now accepted and ready to land.


  Looks good to me.

REPOSITORY
  R241 KIO

BRANCH
  solve-file-dialog-ambiguous-shortcut-issue (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10617

To: ngraham, #frameworks, #dolphin, markg, elvisangelaccio
Cc: michaelh

D10617: Fix "ambiguous shortcut" issue introduced with D10314

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10617

To: ngraham, #frameworks, #dolphin, markg, elvisangelaccio
Cc: michaelh

D10617: Fix "ambiguous shortcut" issue introduced with D10314

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Frameworks, Dolphin, markg, elvisangelaccio.
Restricted Application added a project: Frameworks.
ngraham requested review of this revision.

REVISION SUMMARY
  My patch D10314  was insufficiently 
tested (sorry about that!) and introduced an "Ambiguous Shortcut" warning, 
because "show/hide inline preview" was already bound to F11.
  
  This patch solves that issue by changing the shortcut to F12. F11 was never 
appropriate for it, since F11 was used for something different in Dolphin 
anyway. DOlphin doesn't currently have a shortcut for "show hide inline 
previews", so there's nothing to be consistent with. I used F12 in the file 
dialogs since it's unused there and in Dolphin, too, so we could add it there 
if we really wanted to.

TEST PLAN
  Tested with Kate. F11 toggles the aside preview, and F12 toggles the inline 
preview, like they should. No more conflicts

REPOSITORY
  R241 KIO

BRANCH
  solve-file-dialog-ambiguous-shortcut-issue (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10617

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kfilewidget.cpp

To: ngraham, #frameworks, #dolphin, markg, elvisangelaccio
Cc: michaelh

D10616: Add Ctrl+H to the list of shortcuts for "show/hide hidden files"

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Frameworks, Dolphin, elvisangelaccio.
Restricted Application added a project: Frameworks.
ngraham requested review of this revision.

REVISION SUMMARY
  CCBUG: 390527
  
  Like D10558: Also use standard keyboard shortcut for "show/hide hidden files" 
, but for the file dialogs too, to maintain 
consistency.

TEST PLAN
  Tested with Open and Save dialogs in Kate. New and old shortcuts all worked 
and correctly triggered showing and hiding hidden files

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10616

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kfilewidget.cpp

To: ngraham, #frameworks, #dolphin, elvisangelaccio
Cc: michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

[Michael Pyne]

mpyne added a comment.


  What about this?  I can't change the diff since I didn't create the RR, but 
this seems to cause the required dependency rules to be added and works for me 
to build plasma-desktop.  The only real addition is the `add_dependencies` 
call.  I tried this without the `add_custom_target` dance but CMake complained 
about the JSON file not being present so it looks like it needs to be a real 
CMake target to work.
  
diff --git a/KF5CoreAddonsMacros.cmake b/KF5CoreAddonsMacros.cmake
index f22817d..c15ab98 100644
--- a/KF5CoreAddonsMacros.cmake
+++ b/KF5CoreAddonsMacros.cmake
@@ -58,13 +58,19 @@ function(kcoreaddons_desktop_to_json target desktop)
   endforeach()
 endif()
 
+# Create a virtual target for the generated JSON file and force
+# the passed in target and its auto-generated sources to depend upon it
+string(RANDOM _target_name_suffix)
+set(_json_target "desktop_to_json_${_target_name_suffix}")
+add_custom_target(${_json_target})
 add_custom_command(
-OUTPUT ${json}
+TARGET ${_json_target}
 COMMAND ${command}
 WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
 DEPENDS ${desktop}
 )
-set_property(TARGET ${target} APPEND PROPERTY AUTOGEN_TARGET_DEPENDS 
${json})
+add_dependencies(${target} ${_json_target})
+set_property(TARGET ${target} APPEND PROPERTY AUTOGEN_TARGET_DEPENDS 
${_json_target})
 endfunction()
 
 function(_desktop_to_json_cmake28 desktop json compat)
  
  A resulting Make-based build directory seems to contain the right rules:
  
CMakeFiles/Makefile2
6522:kcms/lookandfeel/CMakeFiles/kcm_lookandfeel.dir/all: 
kcms/lookandfeel/CMakeFiles/desktop_to_json_ChFVC.dir/all
6597:kcms/lookandfeel/CMakeFiles/kcm_lookandfeel_autogen.dir/all: 
kcms/lookandfeel/CMakeFiles/desktop_to_json_ChFVC.dir/all

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10450

To: tcberner, #freebsd, mpyne, bshah, dfaure, rakuco
Cc: rikmills, rakuco, kfunk, adridg, kossebau, #frameworks, michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

[Michael Pyne]

mpyne added a comment.


  Yes, I think I agree with @rakuco.  Especially since the fix for D10485 
 ended up being reverted.  I still think a 
separate fix is needed for kcm_lookandfeel, but the issue is that the 
`kcoreaddons_desktop_to_json` macro generates a JSON file which is intended for 
use in a compiled file, and there's no easy way to connect that dependency 
within *this* macro since the dependent source file is never actually passed 
into the macro.
  
  I do think it makes more sense to have the custom command here be a custom 
target but that wouldn't help fix the dependency link-up.
  
  Would it be possible in CMake to alter the macro to somehow make the JSON a 
dependency of *all* the source files of the provided target instead of just the 
auto-generated files?  That would seem to get the right ordering without too 
much fuss.  `add_custom_command` has a second signature that looks useful 
(offers to make the command happen in "PRE BUILD", however it only works for 
MSVC.
  
  Alternately we could try to do what the kcoreaddons_add_plugin macro does and 
let the calling code pass in the sources to be made dependent upon the JSON.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10450

To: tcberner, #freebsd, mpyne, bshah, dfaure, rakuco
Cc: rikmills, rakuco, kfunk, adridg, kossebau, #frameworks, michaelh

D9829: Don't create 2 msgbox (one of them crashes) when can't change rights

[Anthony Fieroni]

anthonyfieroni added a comment.


  What is state of this?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9829

To: jtamate, #frameworks, anthonyfieroni, dfaure
Cc: ngraham, michaelh

D9675: Don't show context menu menu if right-clicking outside

[Elvis Angelaccio]

elvisangelaccio added a comment.


  +1 works for me.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D9675

To: broulik, #frameworks, dfaure
Cc: elvisangelaccio, wbauer, michaelh

D9675: Don't show context menu menu if right-clicking outside

[Elvis Angelaccio]

elvisangelaccio added a reviewer: dfaure.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D9675

To: broulik, #frameworks, dfaure
Cc: wbauer, michaelh

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 33 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/33/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.7
 Date of build:
Sat, 17 Feb 2018 17:38:18 +
 Build duration:
5 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 32 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/32/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 17 Feb 2018 17:38:18 +
 Build duration:
3 min 15 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

D10578: balooctl monitor: Wait for dbus interface

[Michael Heidelbach]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:94da1850ec6c: balooctl monitor: Wait for dbus interface 
(authored by michaelh).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10578?vs=27416=27417

REVISION DETAIL
  https://phabricator.kde.org/D10578

AFFECTED FILES
  src/tools/balooctl/monitorcommand.cpp
  src/tools/balooctl/monitorcommand.h

To: michaelh, dfaure, alexeymin
Cc: cfeck, alexeymin, #frameworks, ashaposhnikov, michaelh, spoorun, 
nicolasfella

D10340: Clean up old, unreachable code

[Elvis Angelaccio]

elvisangelaccio added a reviewer: dfaure.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D10340

To: heikobecker, #frameworks, dfaure
Cc: michaelh

D10340: Clean up old, unreachable code

[Elvis Angelaccio]

elvisangelaccio added a comment.


  +1

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D10340

To: heikobecker, #frameworks, dfaure
Cc: elvisangelaccio, michaelh

D10578: balooctl monitor: Wait for dbus interface

[Michael Heidelbach]

michaelh marked 11 inline comments as done.

REPOSITORY
  R293 Baloo

BRANCH
  wait-for-dbus (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10578

To: michaelh, dfaure, alexeymin
Cc: cfeck, alexeymin, #frameworks, ashaposhnikov, michaelh, spoorun, 
nicolasfella

D10578: balooctl monitor: Wait for dbus interface

[Michael Heidelbach]

michaelh updated this revision to Diff 27416.
michaelh added a comment.


  - balooctl monitor: Adhere to KDE coding-style

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10578?vs=27394=27416

BRANCH
  wait-for-dbus (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10578

AFFECTED FILES
  src/tools/balooctl/monitorcommand.cpp
  src/tools/balooctl/monitorcommand.h

To: michaelh, dfaure, alexeymin
Cc: cfeck, alexeymin, #frameworks, ashaposhnikov, michaelh, spoorun, 
nicolasfella

D10578: balooctl monitor: Wait for dbus interface

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> michaelh wrote in monitorcommand.cpp:45
> You're right. I just looked at the example in Qt's coding style rules. In 
> fact it is operators BOL, commas EOL.
> I'm ok with putting the commas at EOL (it's the rule, after all). Since to me 
> it is more readable this way I'd like to wait for a second opinion or your 
> objection.

I have only seen commas at the beginning of a line for constructor 
initializers, because adding a new one would affect two lines, instead of 
inserting a single new line. It just looks better in diffs.

Otherwise, yes, commas at the end, please.

REPOSITORY
  R293 Baloo

BRANCH
  wait-for-dbus (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10578

To: michaelh, dfaure, alexeymin
Cc: cfeck, alexeymin, #frameworks, ashaposhnikov, michaelh, spoorun, 
nicolasfella

D10603: Make DMTX dependency optional

[Volker Krause]

vkrause created this revision.
vkrause added reviewers: Frameworks, svuorela.
Restricted Application added a project: Frameworks.
vkrause requested review of this revision.

REVISION SUMMARY
  This simplifies deployment on Android, a platform that libdmtx doesn't
  seem to support out of the box.

REPOSITORY
  R280 Prison

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10603

AFFECTED FILES
  CMakeLists.txt
  src/lib/CMakeLists.txt
  src/lib/config-prison.h.in
  src/lib/prison.cpp

To: vkrause, #frameworks, svuorela
Cc: michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

[Raphael Kubo da Costa]

rakuco added a comment.


  Per my previous comment, I still don't see how changing this to a target 
would solve anything.
  
  For one, the CMake implementation 

 allows both files and targets to be specified there.
  
  Additionally, this would just add a different kind of dependency to 
`kcm_lookandfeel`, but not change `lookandfeel`'s dependencies -- the problem 
persists if target B depends on a source file that target A depends on, but 
only target A depends on the generation of a file that this source file depends 
on.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10450

To: tcberner, #freebsd, mpyne, bshah, dfaure, rakuco
Cc: rikmills, rakuco, kfunk, adridg, kossebau, #frameworks, michaelh

D10602: Remove obsolete policy settings

[Volker Krause]

vkrause created this revision.
vkrause added a reviewer: Build System.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added a subscriber: Frameworks.
vkrause requested review of this revision.

REVISION SUMMARY
  Those affect policy propagation and search path order for relative
  includes in CMake code, none of which is needed here. This silences
  a ton of warnings with CMake 3.10.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10602

AFFECTED FILES
  toolchain/Android.cmake

To: vkrause, #build_system
Cc: #frameworks, michaelh

D10601: Extend search path for NDK dependencies

[Volker Krause]

vkrause created this revision.
vkrause added a reviewer: Build System.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added a subscriber: Frameworks.
vkrause requested review of this revision.

REVISION SUMMARY
  This allows e.g. KArchive to find zlib correctly.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10601

AFFECTED FILES
  toolchain/Android.cmake

To: vkrause, #build_system
Cc: #frameworks, michaelh

D10600: Set ANDROID in the Android toolchain file

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:132b95190a31: Set ANDROID in the Android toolchain file 
(authored by vkrause).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10600?vs=27393=27397

REVISION DETAIL
  https://phabricator.kde.org/D10600

AFFECTED FILES
  toolchain/Android.cmake

To: vkrause, #build_system, apol
Cc: #frameworks, michaelh

D10599: Fix include path for x86 targets

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:16844390dab7: Fix include path for x86 targets (authored 
by vkrause).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10599?vs=27392=27396

REVISION DETAIL
  https://phabricator.kde.org/D10599

AFFECTED FILES
  toolchain/Android.cmake

To: vkrause, #build_system, apol
Cc: apol, dfaure, #frameworks, michaelh

D10578: balooctl monitor: Wait for dbus interface

[Michael Heidelbach]

michaelh added a comment.


  In D10578#208132 , @alexeymin 
wrote:
  
  > There is also https://techbase.kde.org/Policies/Frameworks_Coding_Style.
  
  
  ... and it refers to Qt.
  
  > I've never seen commas at the start of the line.
  
  It's part of the npm coding-style. I found it strange too at first. Probably 
it makes more sense in javascript. Again i don't insist on (... thanks for your 
accepting this diff ...) it.

REPOSITORY
  R293 Baloo

BRANCH
  wait-for-dbus (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10578

To: michaelh, dfaure, alexeymin
Cc: alexeymin, #frameworks, ashaposhnikov, michaelh, spoorun, nicolasfella

D10578: balooctl monitor: Wait for dbus interface

[Alexey Min]

alexeymin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  wait-for-dbus (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10578

To: michaelh, dfaure, alexeymin
Cc: alexeymin, #frameworks, ashaposhnikov, michaelh, spoorun, nicolasfella

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

[René J . V . Bertin]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R245:cbe5085a646e: Mac/IOKit backend: support for drives, 
discs and volumes (authored by rjvbb).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D7401?vs=25846=27395#toc

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7401?vs=25846=27395

REVISION DETAIL
  https://phabricator.kde.org/D7401

AFFECTED FILES
  src/solid/devices/CMakeLists.txt
  src/solid/devices/backends/iokit/CMakeLists.txt
  src/solid/devices/backends/iokit/cfhelper.cpp
  src/solid/devices/backends/iokit/dadictionary.cpp
  src/solid/devices/backends/iokit/dadictionary_p.h
  src/solid/devices/backends/iokit/iokitbattery.cpp
  src/solid/devices/backends/iokit/iokitbattery.h
  src/solid/devices/backends/iokit/iokitblock.cpp
  src/solid/devices/backends/iokit/iokitblock.h
  src/solid/devices/backends/iokit/iokitdevice.cpp
  src/solid/devices/backends/iokit/iokitdevice.h
  src/solid/devices/backends/iokit/iokitdeviceinterface.cpp
  src/solid/devices/backends/iokit/iokitdeviceinterface.h
  src/solid/devices/backends/iokit/iokitgenericinterface.cpp
  src/solid/devices/backends/iokit/iokitmanager.cpp
  src/solid/devices/backends/iokit/iokitopticaldisc.cpp
  src/solid/devices/backends/iokit/iokitopticaldisc.h
  src/solid/devices/backends/iokit/iokitopticaldrive.cpp
  src/solid/devices/backends/iokit/iokitopticaldrive.h
  src/solid/devices/backends/iokit/iokitprocessor.cpp
  src/solid/devices/backends/iokit/iokitprocessor.h
  src/solid/devices/backends/iokit/iokitstorage.cpp
  src/solid/devices/backends/iokit/iokitstorage.h
  src/solid/devices/backends/iokit/iokitstorageaccess.cpp
  src/solid/devices/backends/iokit/iokitstorageaccess.h
  src/solid/devices/backends/iokit/iokitvolume.cpp
  src/solid/devices/backends/iokit/iokitvolume.h

To: rjvbb, #frameworks, kfunk
Cc: ngraham, kfunk, anthonyfieroni, cgilles, kde-mac, michaelh

D10578: balooctl monitor: Wait for dbus interface

[Alexey Min]

alexeymin added a comment.


  There is also https://techbase.kde.org/Policies/Frameworks_Coding_Style. 
Guess I was wrong about `#include`s order, but honestly I've never seen commas 
at the start of the line.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10578

To: michaelh, dfaure
Cc: alexeymin, #frameworks, ashaposhnikov, michaelh, spoorun, nicolasfella

D10599: Fix include path for x86 targets

[Volker Krause]

vkrause added a comment.


  Interesting, @dfaure, does setting a different ABI/compiler via the command 
line actually work for you? Here the command-line parameters are not propagated 
to compiler runs for configure checks, so they run with the defaults from the 
toolchain file, which fails at best and ends up with a bizarre ABI mix at 
worst. I need to edit the corresponding fields in the toolchain file to make 
this work, no idea how to fix that properly yet.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10599

To: vkrause, #build_system, apol
Cc: apol, dfaure, #frameworks, michaelh

D10578: balooctl monitor: Wait for dbus interface

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> alexeymin wrote in monitorcommand.cpp:45
> Strange formatting of commas in above 3 lines. It looks OK in constructor, 
> where member initialization may be added later, but here, when the parameter 
> count is fixed, no need to start new line with a comma. I'd suggest to keep 
> as it was before

You're right. I just looked at the example in Qt's coding style rules. In fact 
it is operators BOL, commas EOL.
I'm ok with putting the commas at EOL (it's the rule, after all). Since to me 
it is more readable this way I'd like to wait for a second opinion or your 
objection.

> alexeymin wrote in monitorcommand.cpp:54
> `delete m_dbusInterface;` after this line, because below you are creating a 
> new object? Each every 50 ms? Memory leaks here

Yeah, massively. Thanks for pointing that out.

> alexeymin wrote in monitorcommand.h:28
> Why dod you move local includes up? Usually they are below globals

Not in baloo's code it seems. So it's for consistency.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10578

To: michaelh, dfaure
Cc: alexeymin, #frameworks, ashaposhnikov, michaelh, spoorun, nicolasfella

D10578: balooctl monitor: Wait for dbus interface

[Michael Heidelbach]

michaelh updated this revision to Diff 27394.
michaelh marked an inline comment as done.
michaelh added a comment.


  - balooctl monitor: Fix memory leak
  - balooctl monitor: Whitespace cleanup

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10578?vs=27360=27394

BRANCH
  wait-for-dbus (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10578

AFFECTED FILES
  src/tools/balooctl/monitorcommand.cpp
  src/tools/balooctl/monitorcommand.h

To: michaelh, dfaure
Cc: alexeymin, #frameworks, ashaposhnikov, michaelh, spoorun, nicolasfella

D10600: Set ANDROID in the Android toolchain file

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10600

To: vkrause, #build_system, apol
Cc: #frameworks, michaelh

D10599: Fix include path for x86 targets

[Aleix Pol Gonzalez]

apol added subscribers: dfaure, apol.
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM.
  @dfaure was looking into this as well earlier this week, he may have feedback.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10599

To: vkrause, #build_system, apol
Cc: apol, dfaure, #frameworks, michaelh

D10600: Set ANDROID in the Android toolchain file

[Volker Krause]

vkrause created this revision.
vkrause added a reviewer: Build System.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added a subscriber: Frameworks.
vkrause requested review of this revision.

REVISION SUMMARY
  This allows easy platforms checks in CMake files, and is the same the
  CMake files shipped by the Android SDK use.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10600

AFFECTED FILES
  toolchain/Android.cmake

To: vkrause, #build_system
Cc: #frameworks, michaelh

D10599: Fix include path for x86 targets

[Volker Krause]

vkrause created this revision.
vkrause added a reviewer: Build System.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added a subscriber: Frameworks.
vkrause requested review of this revision.

REVISION SUMMARY
  ANDROID_TOOLCHAIN is "x86" there, while the include path we want is
  "i686-linux-android". ANDROID_COMPILER_PREFIX has that value in all
  cases (for ARM both are the same, so nothing changes there).

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10599

AFFECTED FILES
  toolchain/Android.cmake

To: vkrause, #build_system
Cc: #frameworks, michaelh

D10578: balooctl monitor: Wait for dbus interface

[Alexey Min]

alexeymin added a comment.


  Looks almost fine, just fix these:

INLINE COMMENTS

> monitorcommand.cpp:45
> +, QDBusConnection::sessionBus()
> +, this
> +);

Strange formatting of commas in above 3 lines. It looks OK in constructor, 
where member initialization may be added later, but here, when the parameter 
count is fixed, no need to start new line with a comma. I'd suggest to keep as 
it was before

> monitorcommand.cpp:54
> +QThread::msleep(50);
> +m_dbusInterface->disconnect();
> +m_dbusInterface = new 
> org::kde::baloo::fileindexer(QStringLiteral("org.kde.baloo")

`delete m_dbusInterface;` after this line, because below you are creating a new 
object? Each every 50 ms? Memory leaks here

> monitorcommand.cpp:58
> +, QDBusConnection::sessionBus()
> +, this
> +);

Again, strange formatting of commas

> monitorcommand.cpp:65
> +connect(m_dbusInterface, 
> ::kde::baloo::fileindexer::startedIndexingFile
> +, this, ::startedIndexingFile);
> +connect(m_dbusInterface, 
> ::kde::baloo::fileindexer::finishedIndexingFile

Strange formatting of commas

> monitorcommand.cpp:67
> +connect(m_dbusInterface, 
> ::kde::baloo::fileindexer::finishedIndexingFile
> +, this, ::finishedIndexingFile);
> +

Strange formatting of commas

> monitorcommand.cpp:72
> +connect(balooWatcher, ::serviceUnregistered
> +, [this, diedMessage]() {
> +m_out << diedMessage << endl;

Strange formatting of commas

> monitorcommand.h:28
> +#include "command.h"
> +#include "fileindexerinterface.h"
>  #include 

Why dod you move local includes up? Usually they are below globals

> monitorcommand.h:60
>  QString m_currentFile;
> +
>  };

extra empty string?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10578

To: michaelh, dfaure
Cc: alexeymin, #frameworks, ashaposhnikov, michaelh, spoorun, nicolasfella

D10450: Generate a custom target in kcoreaddons_desktop_to_json

[Tobias C . Berner]

tcberner added a comment.


  I think as @adridg points out that it should be a target, this should go in 
-- and the @kossebau already committed the proper workaround in D10485 
, right?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10450

To: tcberner, #freebsd, mpyne, bshah, dfaure, rakuco
Cc: rikmills, rakuco, kfunk, adridg, kossebau, #frameworks, michaelh