D10694: epubextractor: Handle multiple subjects better

2018-03-08 Thread Michael Heidelbach 
michaelh added a comment.


  This is bad! I have learned baloo itself doesn't handle stringlists. Which in 
my view would be the natural way to handle token-like items like tags, keywords 
and subject(s). Until this is changed in baloo I'm putting this diff on hold 
and fro the time being work around these long subject-strings within 
baloo-widgets.
  
  @mgallien: Did I understand you correctly, the refactoring helped you to 
understand it better? That would be an incentive for me to do more refactoring.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10694

To: michaelh, mgallien, dfaure
Cc: #frameworks, ashaposhnikov, michaelh, spoorun, navarromorales, isidorov, 
nicolasfella, firef, andrebarros, alexeymin, emmanuelp

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 91 - Still Unstable!

2018-03-08 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/91/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 08 Mar 2018 22:04:56 +
 Build duration:
22 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3560/13344)19%
(1979/10565)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(254/2235)7%
(102/1492)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/2009)17%
(306/1771)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 66 - Still Unstable!

2018-03-08 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/66/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 08 Mar 2018 22:04:56 +
 Build duration:
8 min 11 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-dialogstatetestFailed: TestSuite.plasma-packagestructuretest

D11130: Disable deprecation warning from kpackage_install_package for now

2018-03-08 Thread Friedrich W . H . Kossebau 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:dd0fcc3b7322: Disable deprecation warning from 
kpackage_install_package for now (authored by kossebau).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11130?vs=28938=29046

REVISION DETAIL
  https://phabricator.kde.org/D11130

AFFECTED FILES
  KF5PlasmaMacros.cmake

To: kossebau, mart, apol
Cc: #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10694: epubextractor: Handle multiple subjects better

2018-03-08 Thread Matthieu Gallien 
mgallien added a comment.


  Sorry for being so late.
  
  In D10694#215663 , @michaelh wrote:
  
  > @mgallien : taglibextractor.cpp is very hard to read. Hopefully it is no 
longer.

INLINE COMMENTS

> michaelh wrote in epubextractor.cpp:94
> Did you mean something like this?:
> 
>   const auto& values = fetchMetadata(ePubDoc, EPUB_SUBJECT);
>   for (auto& value : values) {
>   result->add(Property::Subject, value);
>}
> 
> It fails the test (of course). It it unclear to me how to handle 
> `result.properties().value(Property::Subject)` and there is no example in the 
> tests. They all compare against `QVariant::Type::String`. Do you have an 
> example from elisa?

Elisa code is not properly handling this case. When writing it, I had not 
understood that. Thanks to your diff, I have now properly read the code and I 
should go modify Elisa code.

In general, you can use canConvert() from QVariant. This should allow 
to handle both cases.
You can probably always convert to a string list QVariant::toStringList. It 
should be enough for properties with one string or a list of strings.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10694

To: michaelh, mgallien, dfaure
Cc: #frameworks, ashaposhnikov, michaelh, spoorun, navarromorales, isidorov, 
nicolasfella, firef, andrebarros, alexeymin, emmanuelp

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 5 - Still Unstable!

2018-03-08 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/5/
 Project:
Frameworks kpackage kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 08 Mar 2018 21:25:10 +
 Build duration:
2 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)96%
(27/28)96%
(27/28)73%
(1619/2214)51%
(1276/2499)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(12/12)100%
(12/12)100%
(546/548)51%
(329/642)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(560/757)64%
(659/1037)src.kpackage.private100%
(8/8)100%
(8/8)79%
(294/370)52%
(128/246)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/521)27%
(153/562)

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 28 - Still Unstable!

2018-03-08 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/28/
 Project:
Frameworks kpackage kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 08 Mar 2018 21:25:10 +
 Build duration:
1 min 26 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)96%
(27/28)96%
(27/28)73%
(1619/2214)51%
(1276/2499)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(12/12)100%
(12/12)100%
(546/548)51%
(329/642)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(560/757)64%
(659/1037)src.kpackage.private100%
(8/8)100%
(8/8)79%
(294/370)52%
(128/246)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/521)27%
(153/562)

D11153: Use correct item URL for Create New context menu

2018-03-08 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11153

To: prukgaber, #frameworks, dfaure
Cc: hein, #frameworks, michaelh

D11129: Mark kpackage_install_package undeprecated for plasma_install_package

2018-03-08 Thread Friedrich W . H . Kossebau 
This revision was automatically updated to reflect the committed changes.
Closed by commit R290:8c7f78206b95: Mark kpackage_install_package undeprecated 
for plasma_install_package (authored by kossebau).

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11129?vs=28937=29043

REVISION DETAIL
  https://phabricator.kde.org/D11129

AFFECTED FILES
  KF5PackageMacros.cmake

To: kossebau, mart, apol
Cc: #frameworks, michaelh

D11155: handle zip files embedded within zip files

2018-03-08 Thread David Faure 
dfaure added inline comments.

INLINE COMMENTS

> kzip.cpp:347
>   * @param dev device that is read from
>   * @return true if a local or central header token could be reached, false 
> on error

can you document the new boolean param as well?

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D11155

To: sandsmark, dfaure, #frameworks
Cc: #frameworks, michaelh

D11156: add autotest for zips within zips

2018-03-08 Thread David Faure 
dfaure added inline comments.

INLINE COMMENTS

> karchivetest.cpp:1156
> +
> +QVERIFY(zip.open(QIODevice::ReadOnly));
> +}

A check for a file listing would avoid that just "return true" in open() is 
enough for the test to pass :-)

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D11156

To: sandsmark, dfaure, #frameworks
Cc: #frameworks, michaelh

D10365: New icon for Elisa music player

2018-03-08 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:26866bfffa86: New icon for Elisa music player (authored 
by paullesur, committed by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10365?vs=26705=29040

REVISION DETAIL
  https://phabricator.kde.org/D10365

AFFECTED FILES
  icons-dark/apps/22/elisa.svg
  icons-dark/apps/48/elisa.svg
  icons/apps/22/elisa.svg
  icons/apps/48/elisa.svg

To: paullesur, #breeze, #vdg, #elisa, andreaska, mgallien, ngraham
Cc: mmustac, mgallien, januz, astippich, andreask, andreaska, ltoscano, 
ngraham, #frameworks, nhuisman, ursjoss, jussiv, paullesur, michaelh, ognarb, 
kmf

D10365: New icon for Elisa music player

2018-03-08 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.


  I'm ok with it. Landing now.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur, #breeze, #vdg, #elisa, andreaska, mgallien, ngraham
Cc: mmustac, mgallien, januz, astippich, andreask, andreaska, ltoscano, 
ngraham, #frameworks, nhuisman, ursjoss, jussiv, paullesur, michaelh, ognarb, 
kmf

D10365: New icon for Elisa music player

2018-03-08 Thread Matthieu Gallien 
mgallien added a comment.


  I believe there was no objections to this choice of icon. Can we ensure this 
gets landed soon ? I would prefer to be able to have the new icon as soon as 
possible.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur, #breeze, #vdg, #elisa, andreaska, mgallien
Cc: mmustac, mgallien, januz, astippich, andreask, andreaska, ltoscano, 
ngraham, #frameworks, nhuisman, ursjoss, jussiv, paullesur, michaelh, ognarb, 
kmf

D11149: Create a constructor for KLocalizedStringPrivate

2018-03-08 Thread Jaime Torres Amate 
This revision was automatically updated to reflect the committed changes.
Closed by commit R249:a02e99069e15: Create a constructor for 
KLocalizedStringPrivate (authored by jtamate).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11149?vs=28990=29029

REVISION DETAIL
  https://phabricator.kde.org/D11149

AFFECTED FILES
  src/klocalizedstring.cpp

To: jtamate, #frameworks, ilic
Cc: ilic, michaelh

D11132: Avoid an asan runtime error

2018-03-08 Thread Jaime Torres Amate 
This revision was automatically updated to reflect the committed changes.
Closed by commit R302:af5397635c4f: Avoid an asan runtime error (authored by 
jtamate).

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11132?vs=29002=29026

REVISION DETAIL
  https://phabricator.kde.org/D11132

AFFECTED FILES
  src/kiconeffect.cpp

To: jtamate, #frameworks, mwolff
Cc: mwolff, apol, anthonyfieroni, michaelh

D11130: Disable deprecation warning from kpackage_install_package for now

2018-03-08 Thread Marco Martin 
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  allowdeprecatedwarningdisabling

REVISION DETAIL
  https://phabricator.kde.org/D11130

To: kossebau, mart, apol
Cc: #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11129: Mark kpackage_install_package undeprecated for plasma_install_package

2018-03-08 Thread Marco Martin 
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R290 KPackage

BRANCH
  allowdeprecatedwarningdisabling

REVISION DETAIL
  https://phabricator.kde.org/D11129

To: kossebau, mart, apol
Cc: #frameworks, michaelh

D11129: Mark kpackage_install_package undeprecated for plasma_install_package

2018-03-08 Thread Friedrich W . H . Kossebau 
kossebau added inline comments.

INLINE COMMENTS

> apol wrote in KF5PackageMacros.cmake:27
> How about if(KF5Plasma_FIND_VERSION VERSION_LESS 5.43.0)?
> 
> This way it's only shown on projects that are actually depending on the new 
> version. And if they are well then that's fine to have the warning.

This won't have any effect, given this will be always true for people which use 
this version as it is coming with all the other KF5 modules, no?

The problem is this:
as applet developer you have no choice but to use `plasma_install_package`. And 
you have no control about what it is doing, e.g. that it is using this other 
macro which spits out the warning.  So the package-system developers internal 
reminder to complete this task gets written out to all the other developers, 
who just innocently use this macro.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D11129

To: kossebau, mart, apol
Cc: #frameworks, michaelh

D11129: Mark kpackage_install_package undeprecated for plasma_install_package

2018-03-08 Thread Aleix Pol Gonzalez 
apol added inline comments.

INLINE COMMENTS

> KF5PackageMacros.cmake:27
> +   # allow plasma_install_package to disable the warning until it is ported 
> away from this
> +   if (NOT ARGV4 STREQUAL NO_DEPRECATED_WARNING)
> +  message(AUTHOR_WARNING "Deprecated: use 
> kpackage_install_bundled_package")

How about if(KF5Plasma_FIND_VERSION VERSION_LESS 5.43.0)?

This way it's only shown on projects that are actually depending on the new 
version. And if they are well then that's fine to have the warning.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D11129

To: kossebau, mart, apol
Cc: #frameworks, michaelh

D10776: Make it possible to generate po files in parallel

2018-03-08 Thread Aleix Pol Gonzalez 
apol marked an inline comment as done.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D10776

To: apol, #frameworks, sitter
Cc: michaelh

D10776: Make it possible to generate po files in parallel

2018-03-08 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 29024.
apol added a comment.


  Fix typo

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10776?vs=28846=29024

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10776

AFFECTED FILES
  cmake/build-pofiles.cmake
  cmake/build-tsfiles.cmake

To: apol, #frameworks, sitter
Cc: michaelh

D11132: Avoid an asan runtime error

2018-03-08 Thread Milian Wolff 
mwolff added a comment.


  still accepted, fell free to submit

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D11132

To: jtamate, #frameworks, mwolff
Cc: mwolff, apol, anthonyfieroni, michaelh

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 9 - Fixed!

2018-03-08 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/9/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 08 Mar 2018 15:34:48 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 39 test(s)

D6709: Add support for sharing file descriptor between KIO slave and KAuth helper

2018-03-08 Thread Chinmoy Ranjan Pradhan 
chinmoyr closed this revision.
chinmoyr added a comment.


  Bug fixed in D11011 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D6709

To: chinmoyr, thiago, #frameworks, dfaure
Cc: awilcox, dfaure, davidedmundson, elvisangelaccio, shortstheory, michaelh

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 42 - Still Unstable!

2018-03-08 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/42/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 08 Mar 2018 15:34:48 +
 Build duration:
9 min 20 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

D11153: Use correct item URL for Create New context menu

2018-03-08 Thread Eike Hein 
hein added reviewers: Frameworks, dfaure.
hein added a comment.


  Looks good to me. I'll let David have a look too and then it can go in.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11153

To: prukgaber, #frameworks, dfaure
Cc: hein, #frameworks, michaelh

D11037: balooctl: checkDb should also verify the last known url for the documentId.

2018-03-08 Thread James Smith 
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:3fbabac6add9: balooctl: checkDb should also verify the 
last known url for the documentId. (authored by smithjd).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11037?vs=28647=29016#toc

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11037?vs=28647=29016

REVISION DETAIL
  https://phabricator.kde.org/D11037

AFFECTED FILES
  src/engine/transaction.cpp

To: smithjd, #baloo, michaelh
Cc: michaelh, #frameworks, ashaposhnikov, spoorun, nicolasfella, alexeymin

D11156: add autotest for zips within zips

2018-03-08 Thread Martin Tobias Holmedahl Sandsmark 
sandsmark created this revision.
sandsmark added reviewers: dfaure, Frameworks.
Restricted Application added a project: Frameworks.
sandsmark requested review of this revision.

REVISION SUMMARY
  an epub in a zip file compressed by e. g. the golang standard zip library, or 
infozip in streaming mode.

TEST PLAN
  fails before my patch, passes afterwards

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D11156

AFFECTED FILES
  data/zip_within_zip.zip
  karchivetest.cpp
  karchivetest.h

To: sandsmark, dfaure, #frameworks
Cc: #frameworks, michaelh

D11155: handle zip files embedded within zip files

2018-03-08 Thread Martin Tobias Holmedahl Sandsmark 
sandsmark created this revision.
sandsmark added reviewers: dfaure, Frameworks.
Restricted Application added a project: Frameworks.
sandsmark requested review of this revision.

REVISION SUMMARY
  if we need to fetch the sizes from a PK78 header, there might be a PK34 
header before it if there is a zip file embedded (e. g. an epub within a zip).

TEST PLAN
  autotest in a separate commit

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D11155

AFFECTED FILES
  kzip.cpp

To: sandsmark, dfaure, #frameworks
Cc: #frameworks, michaelh

D10543: fix crashing with duplicate entries

2018-03-08 Thread Martin Tobias Holmedahl Sandsmark 
This revision was automatically updated to reflect the committed changes.
Closed by commit R243:6736aca49c2d: karchive, kzip: try to handle duplicate 
files in a bit nicer way (authored by sandsmark).

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10543?vs=27668=29009

REVISION DETAIL
  https://phabricator.kde.org/D10543

AFFECTED FILES
  src/karchive.cpp
  src/kzip.cpp

To: sandsmark, dfaure, #frameworks
Cc: apol, michaelh

D10551: autotest for crashing in KArchiveDirectory::addEntry

2018-03-08 Thread Martin Tobias Holmedahl Sandsmark 
This revision was automatically updated to reflect the committed changes.
sandsmark marked an inline comment as done.
Closed by commit R243:6959a256f777: autotests: add crashing test with duplicate 
names (authored by sandsmark).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10551?vs=28314=29008#toc

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10551?vs=28314=29008

REVISION DETAIL
  https://phabricator.kde.org/D10551

AFFECTED FILES
  autotests/data/out.epub
  autotests/karchivetest.cpp
  autotests/karchivetest.h

To: sandsmark, dfaure, apol
Cc: #frameworks, michaelh

D11153: Use correct item URL for Create New context menu

2018-03-08 Thread Pierre Rukgaber 
prukgaber created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
prukgaber requested review of this revision.

REVISION SUMMARY
  The activatedMenu function was not using the given items path, which resulted 
in new folders or files being created in the root directory of the filemanager 
plugin.
  BUG: 387387

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11153

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: prukgaber
Cc: #frameworks, michaelh

D11132: Avoid an asan runtime error

2018-03-08 Thread Jaime Torres Amate 
jtamate updated this revision to Diff 29002.
jtamate added a comment.


  Added the link.

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11132?vs=28991=29002

REVISION DETAIL
  https://phabricator.kde.org/D11132

AFFECTED FILES
  src/kiconeffect.cpp

To: jtamate, #frameworks, mwolff
Cc: mwolff, apol, anthonyfieroni, michaelh

D10591: forcefully activate popup windows when they open

2018-03-08 Thread Marco Martin 
mart abandoned this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10591

To: mart, #plasma
Cc: broulik, davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11132: Avoid an asan runtime error

2018-03-08 Thread Milian Wolff 
mwolff accepted this revision.
mwolff added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kiconeffect.cpp:44
> +KIconEffectPrivate()
> +   : effect{{}}
> +   , value{{}}

it may be a good idea to add a comment that links to 
http://en.cppreference.com/w/cpp/language/zero_initialization to clarify what's 
happening here

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D11132

To: jtamate, #frameworks, mwolff
Cc: mwolff, apol, anthonyfieroni, michaelh

D11149: Create a constructor for KLocalizedStringPrivate

2018-03-08 Thread Chusslove Illich 
ilic accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D11149

To: jtamate, #frameworks, ilic
Cc: ilic, michaelh

D11132: Avoid an asan runtime error

2018-03-08 Thread Jaime Torres Amate 
jtamate updated this revision to Diff 28991.
jtamate added a comment.


  with spaces after : and ,

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11132?vs=28946=28991

REVISION DETAIL
  https://phabricator.kde.org/D11132

AFFECTED FILES
  src/kiconeffect.cpp

To: jtamate, #frameworks
Cc: apol, anthonyfieroni, michaelh

D11149: Create a constructor for KLocalizedStringPrivate

2018-03-08 Thread Jaime Torres Amate 
jtamate updated this revision to Diff 28990.
jtamate added a comment.


  With spaces after : and ,

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11149?vs=28988=28990

REVISION DETAIL
  https://phabricator.kde.org/D11149

AFFECTED FILES
  src/klocalizedstring.cpp

To: jtamate, #frameworks
Cc: ilic, michaelh

D11149: Create a constructor for KLocalizedStringPrivate

2018-03-08 Thread Chusslove Illich 
ilic added inline comments.

INLINE COMMENTS

> klocalizedstring.cpp:202-204
> +   :format()
> +   ,numberSet(false)
> +   ,markupAware(false)

Should have space after colon/comma?

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D11149

To: jtamate, #frameworks
Cc: ilic, michaelh

D11149: Create a constructor for KLocalizedStringPrivate

2018-03-08 Thread Jaime Torres Amate 
jtamate created this revision.
jtamate added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
jtamate requested review of this revision.

REVISION SUMMARY
  The constructor avoids the following asan runtime errors
  kdesrc/frameworks/ki18n/src/klocalizedstring.cpp:179:7: runtime error: load 
of value 3200171710, which is not a valid value for type 'VisualFormat'
  kdesrc/frameworks/ki18n/src/klocalizedstring.cpp:179:7: runtime error: load 
of value 190, which is not a valid value for type 'bool'
  kdesrc/frameworks/ki18n/src/klocalizedstring.cpp:179:7: runtime error: load 
of value 190, which is not a valid value for type 'bool'
  kdesrc/frameworks/ki18n/src/klocalizedstring.cpp:179:7: runtime error: load 
of value 190, which is not a valid value for type 'bool'

TEST PLAN
  start konsole

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D11149

AFFECTED FILES
  src/klocalizedstring.cpp

To: jtamate, #frameworks
Cc: michaelh