KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 101 - Still Unstable!

2018-03-16 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/101/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 17 Mar 2018 04:06:13 +
 Build duration:
27 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3556/13406)19%
(1977/10571)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(607/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/453)0%
(0/241)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2243)7%
(102/1494)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3500)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1622)28%
(317/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(552/2011)17%
(305/1771)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1177)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

D10251: [RFC] Use mipmap filtering in window thumbnails

2018-03-16 Thread Nathaniel Graham 
ngraham edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10251

To: fredrik, #plasma, #vdg
Cc: broulik, ngraham, hein, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10937: Retouching of Screen Layout Selection OSD Icons

2018-03-16 Thread Nathaniel Graham 
ngraham added a comment.


  In D10937#227537 , @pstefan wrote:
  
  > In D10937#227525 , @ngraham 
wrote:
  >
  > > Those all look pretty great to me, honestly. A nice upgrade from the 
current icons.
  > >
  > > For the pink column, does it look bad if you raise the projection screen 
so that it's only a little bit higher than the laptop on the large icons? It 
seems like there's room to raise it a bit and still keep the blue window 
aligned between them. I think it's okay if they're not aligned on the smaller 
versions.
  >
  >
  > You mean like in the smaller icons or like so:
  
  
  Like in the smaller icons, but with the blue window aligned due to the extra 
space. If you tried that and it didn't work, no biggie.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze
Cc: emateli, abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, 
firef, alexeymin, skadinna, aaronhoneycutt, mbohlender

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 76 - Still Unstable!

2018-03-16 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/76/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 17 Mar 2018 04:06:14 +
 Build duration:
7 min 48 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 100 - Still Unstable!

2018-03-16 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/100/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 16 Mar 2018 22:27:26 +
 Build duration:
5 min 40 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3558/13406)19%
(1978/10571)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/453)0%
(0/241)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2243)7%
(102/1494)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3500)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1622)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(552/2011)17%
(305/1771)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1177)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 75 - Still Unstable!

2018-03-16 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/75/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 16 Mar 2018 22:27:26 +
 Build duration:
4 min 20 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

2018-03-16 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:a21bc11fe116: Fix text scaling with non-integer scale 
factors when PLASMA_USE_QT_SCALING=1 is… (authored by ngraham).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11244?vs=29408=29712

REVISION DETAIL
  https://phabricator.kde.org/D11244

AFFECTED FILES
  examples/applets/testtheme/contents/ui/FontGizmo.qml
  src/declarativeimports/plasmacomponents/qml/Label.qml
  src/declarativeimports/plasmacomponents/qml/private/DualStateButton.qml
  src/declarativeimports/plasmacomponents3/ComboBox.qml
  src/declarativeimports/plasmacomponents3/Label.qml
  src/declarativeimports/plasmacomponents3/TextArea.qml
  src/declarativeimports/plasmacomponents3/TextField.qml
  src/declarativeimports/plasmastyle/ComboBoxStyle.qml
  src/declarativeimports/plasmastyle/SpinBoxStyle.qml
  src/declarativeimports/plasmastyle/TextAreaStyle.qml
  src/declarativeimports/plasmastyle/TextFieldStyle.qml

To: ngraham, #plasma, davidedmundson
Cc: mart, broulik, #frameworks, michaelh, ngraham

D10937: Retouching of Screen Layout Selection OSD Icons

2018-03-16 Thread Phil Stefan 
pstefan added a comment.


  In D10937#227525 , @ngraham wrote:
  
  > Those all look pretty great to me, honestly. A nice upgrade from the 
current icons.
  >
  > For the pink column, does it look bad if you raise the projection screen so 
that it's only a little bit higher than the laptop on the large icons? It seems 
like there's room to raise it a bit and still keep the blue window aligned 
between them. I think it's okay if they're not aligned on the smaller versions.
  
  
  You mean like in the smaller icons or like so:
  F5756076: path1394.png ?
  
  In D10937#227527 , @emateli wrote:
  
  > Hi, while I do appreciate the icons I also have a question: Why the use of 
laptop and projector over of two simple generic screens. Wouldn't that be 
better for all use cases?
  
  
  Dunno, I didn't set out to change the metaphors used.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze
Cc: emateli, abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, 
firef, alexeymin, skadinna, aaronhoneycutt, mbohlender

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

2018-03-16 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  arcpatch-D11244

REVISION DETAIL
  https://phabricator.kde.org/D11244

To: ngraham, #plasma, davidedmundson
Cc: mart, broulik, #frameworks, michaelh, ngraham

D10937: Retouching of Screen Layout Selection OSD Icons

2018-03-16 Thread Emirald Mateli 
emateli added a comment.


  Hi, while I do appreciate the icons I also have a question: Why the use of 
laptop and projector over of two simple generic screens. Wouldn't that be 
better for all use cases?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze
Cc: emateli, abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, 
firef, alexeymin, skadinna, aaronhoneycutt, mbohlender

D10937: Retouching of Screen Layout Selection OSD Icons

2018-03-16 Thread Nathaniel Graham 
ngraham added a comment.


  Those all look pretty great to me, honestly. A nice upgrade from the current 
icons.
  
  For the pink column, does it look bad if you raise the projection screen so 
that it's only a little bit higher than the laptop on the large icons? It seems 
like there's room to raise it a bit and still keep the blue window aligned 
between them. I think it's okay if they're not aligned on the smaller versions.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze
Cc: abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, firef, 
alexeymin, skadinna, aaronhoneycutt, mbohlender

D10937: Retouching of Screen Layout Selection OSD Icons

2018-03-16 Thread Phil Stefan 
pstefan added a comment.


  An update:
  F5756024: thick_or_Thipng.png 
  
  Green column:
  I still haven't found a better metaphor.  With the slightly rotated window 
metaphors to its sides I can just leave out the window at smaller sizes, but I 
can't really think of something that fills the screen at larger sizes while 
still being expressive at smaller sized.
  
  Pink column:
  I tried to get rid of the skew, but at medium sizes I can't seem to manage to 
get something that 1. doesn't look like a potato and 2. is actually 
recognizable. The laptop isn't so much the issue as the second screen.
  
  Orange row:
  I am honestly not sure it can be done at this size. The first 4 icons are 
probably possible, but after that it gets extremely tricky. I haven't managed 
to find forms that are clear in their meaning and still recognizable. It's 
either super cluttered or just a blue rectangle and a red X :|
  
  I already had to get rid of the outer rim around the laptop in the 3rd row 
5th column onward. I am not a fan.
  
  As for the last row: I found that just scaling everything by a factor of 2 
works best. With a 1px line thickness things start to look "hollow" and 
incomplete.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze
Cc: abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, firef, 
alexeymin, skadinna, aaronhoneycutt, mbohlender

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

2018-03-16 Thread Nathaniel Graham 
ngraham added a comment.


  Friendly ping!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11244

To: ngraham, #plasma, davidedmundson
Cc: mart, broulik, #frameworks, michaelh, ngraham

KDE CI: Frameworks baloo kf5-qt5 FreeBSDQt5.9 - Build # 43 - Successful!

2018-03-16 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20FreeBSDQt5.9/43/
 Project:
Frameworks baloo kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 16 Mar 2018 20:54:12 +
 Build duration:
3 min 13 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 37 test(s)

D11287: Introduce baloodb CLI tool

2018-03-16 Thread Michael Heidelbach 
michaelh added a comment.


  Should there be a note in `--help` message like "This is an experimental 
tool. The command like interface is subject to change."?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11287

To: michaelh, #baloo, #frameworks
Cc: ngraham, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, 
alexeymin

D11287: Introduce baloodb CLI tool

2018-03-16 Thread Michael Heidelbach 
michaelh edited the test plan for this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11287

To: michaelh, #baloo, #frameworks
Cc: ngraham, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, 
alexeymin

D11287: Introduce baloodb CLI tool

2018-03-16 Thread Michael Heidelbach 
michaelh updated this revision to Diff 29694.
michaelh added a comment.


  - Rebase on master
  - Improve help message

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11287?vs=29525=29694

BRANCH
  sanitize-cmd (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11287

AFFECTED FILES
  src/tools/CMakeLists.txt
  src/tools/baloodb/CMakeLists.txt
  src/tools/baloodb/Messages.sh
  src/tools/baloodb/main.cpp

To: michaelh, #baloo, #frameworks
Cc: ngraham, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, 
alexeymin

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 18 - Fixed!

2018-03-16 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/18/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 16 Mar 2018 18:43:25 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 39 test(s)

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 50 - Fixed!

2018-03-16 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/50/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 16 Mar 2018 18:43:25 +
 Build duration:
9 min 20 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 39 test(s)

D11392: sanitizer: Move implementation into Baloo namespace

2018-03-16 Thread Michael Heidelbach 
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:5e471c3d39b3: sanitizer: Move implementation into Baloo 
namespace (authored by michaelh).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11392?vs=29689=29692

REVISION DETAIL
  https://phabricator.kde.org/D11392

AFFECTED FILES
  src/engine/databasesanitizer.cpp
  src/engine/databasesanitizer.h
  src/engine/transaction.h

To: michaelh, #baloo, #frameworks, kossebau
Cc: kossebau, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, 
ngraham, alexeymin

D11392: sanitizer: Move implementation into Baloo namespace

2018-03-16 Thread Michael Heidelbach 
michaelh edited the summary of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  namespace

REVISION DETAIL
  https://phabricator.kde.org/D11392

To: michaelh, #baloo, #frameworks, kossebau
Cc: kossebau, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, 
ngraham, alexeymin

D11392: sanitizer: Move implementation into Baloo namespace

2018-03-16 Thread Michael Heidelbach 
michaelh edited the summary of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  namespace

REVISION DETAIL
  https://phabricator.kde.org/D11392

To: michaelh, #baloo, #frameworks, kossebau
Cc: kossebau, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, 
ngraham, alexeymin

D11392: sanitizer: Move implementation into Baloo namespace

2018-03-16 Thread Friedrich W . H . Kossebau 
kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.


  Only looked at the diff, but nothing suspicious seen. If it builds and works, 
should be fine :)
  
  Perhaps mention in the commit message also that this moving into the 
namespace allows to remove DatabaseSanitizer::getDocuments() from the public 
API, so it gets more clear why this change was done and why there are also 
those changes in the patch. The reader of this commit in 2 years might be abit 
thankful :)

REPOSITORY
  R293 Baloo

BRANCH
  namespace

REVISION DETAIL
  https://phabricator.kde.org/D11392

To: michaelh, #baloo, #frameworks, kossebau
Cc: kossebau, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, 
ngraham, alexeymin

D11392: sanitizer: Move implementation into Baloo namespace

2018-03-16 Thread Michael Heidelbach 
michaelh created this revision.
michaelh added reviewers: Baloo, Frameworks.
Restricted Application added projects: Frameworks, Baloo.
michaelh requested review of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  namespace

REVISION DETAIL
  https://phabricator.kde.org/D11392

AFFECTED FILES
  src/engine/databasesanitizer.cpp
  src/engine/databasesanitizer.h
  src/engine/transaction.h

To: michaelh, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, ngraham, 
alexeymin

D11390: new icons for disconnected/disabled devices

2018-03-16 Thread Andrew Crouthamel 
acrouthamel added a comment.


  They look great!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11390

To: mart, #plasma, #vdg, andreask
Cc: acrouthamel, andreask, #frameworks, michaelh, ngraham

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 74 - Still Unstable!

2018-03-16 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/74/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 16 Mar 2018 15:16:29 +
 Build duration:
30 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D6313: Support Icon Scale from Icon naming specification 0.13

2018-03-16 Thread Andrew Crouthamel 
acrouthamel added a comment.


  Thanks for working on this again, it really helps. :)

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 99 - Still Unstable!

2018-03-16 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/99/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 16 Mar 2018 15:16:29 +
 Build duration:
3 min 45 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3559/13406)19%
(1978/10571)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/453)0%
(0/241)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(254/2243)7%
(102/1494)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3500)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1622)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(552/2011)17%
(305/1771)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1177)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

D10243: Improve visibility of disconnected Wi-Fi icons

2018-03-16 Thread Marco Martin 
mart added a comment.


  changes of this are included in D11390 , 
this should be closed

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: mart, abetts, plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D11390: new icons for disconnected/disabled devices

2018-03-16 Thread Marco Martin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:5163e3e9ff69: new icons for disconnected/disabled devices 
(authored by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11390?vs=29682=29687

REVISION DETAIL
  https://phabricator.kde.org/D11390

AFFECTED FILES
  src/desktoptheme/breeze/icons/network.svgz

To: mart, #plasma, #vdg, andreask
Cc: andreask, #frameworks, michaelh, ngraham

D11390: new icons for disconnected/disabled devices

2018-03-16 Thread Marco Martin 
mart added a comment.


  ah, if i push this, it will override D10243 
 which shouldn't be pushed anymore (it 
contains all the new darker icons)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/network

REVISION DETAIL
  https://phabricator.kde.org/D11390

To: mart, #plasma, #vdg, andreask
Cc: andreask, #frameworks, michaelh, ngraham

D11390: new icons for disconnected/disabled devices

2018-03-16 Thread Marco Martin 
mart added a comment.


  In D11390#227284 , @andreask wrote:
  
  > look good to me thanks
  
  
  should i go hunting in breeze icons as well to see if there are some to 
update to make it look the same?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/network

REVISION DETAIL
  https://phabricator.kde.org/D11390

To: mart, #plasma, #vdg, andreask
Cc: andreask, #frameworks, michaelh, ngraham

D11388: Provide androiddeployqt with all prefix paths

2018-03-16 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11388

To: vkrause, #build_system, apol
Cc: #frameworks, michaelh, ngraham

D10243: Improve visibility of disconnected Wi-Fi icons

2018-03-16 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.


  The icon changes themselves are done in D11390 
. Since this patch just touches the 
opacity, +1 from me.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: abetts, plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 49 - Still Unstable!

2018-03-16 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/49/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 16 Mar 2018 14:54:19 +
 Build duration:
5 min 42 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 17 - Unstable!

2018-03-16 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/17/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 16 Mar 2018 14:54:19 +
 Build duration:
3 min 41 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

D11285: Introduce sanitizer class

2018-03-16 Thread Michael Heidelbach 
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:9de78becc063: Introduce sanitizer class (authored by 
michaelh).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11285?vs=29683=29684

REVISION DETAIL
  https://phabricator.kde.org/D11285

AFFECTED FILES
  src/engine/CMakeLists.txt
  src/engine/Messages.sh
  src/engine/databasesanitizer.cpp
  src/engine/databasesanitizer.h
  src/engine/documenturldb.cpp
  src/engine/transaction.h

To: michaelh, #baloo, #frameworks, ngraham, mlaurent
Cc: mlaurent, ngraham, smithjd, ashaposhnikov, michaelh, astippich, spoorun, 
nicolasfella, alexeymin

D11285: Introduce sanitizer class

2018-03-16 Thread Laurent Montel 
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  +2 for me but I don't know baloo code :)

REPOSITORY
  R293 Baloo

BRANCH
  sanitize-class (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11285

To: michaelh, #baloo, #frameworks, ngraham, mlaurent
Cc: mlaurent, ngraham, smithjd, ashaposhnikov, michaelh, astippich, spoorun, 
nicolasfella, alexeymin

D11390: new icons for disconnected/disabled devices

2018-03-16 Thread Andreas Kainz 
andreask accepted this revision.
andreask added a comment.
This revision is now accepted and ready to land.


  look good to me thanks

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/network

REVISION DETAIL
  https://phabricator.kde.org/D11390

To: mart, #plasma, #vdg, andreask
Cc: andreask, #frameworks, michaelh, ngraham

D11390: new icons for disconnected/disabled devices

2018-03-16 Thread Nathaniel Graham 
ngraham edited the summary of this revision.
ngraham added a dependency: D10243: Improve visibility of disconnected Wi-Fi 
icons.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11390

To: mart, #plasma, #vdg
Cc: #frameworks, michaelh, ngraham

D10243: Improve visibility of disconnected Wi-Fi icons

2018-03-16 Thread Nathaniel Graham 
ngraham added a dependent revision: D11390: new icons for disconnected/disabled 
devices.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: abetts, plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D11285: Introduce sanitizer class

2018-03-16 Thread Michael Heidelbach 
michaelh marked 3 inline comments as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11285

To: michaelh, #baloo, #frameworks, ngraham, mlaurent
Cc: mlaurent, ngraham, smithjd, ashaposhnikov, michaelh, astippich, spoorun, 
nicolasfella, alexeymin

D11285: Introduce sanitizer class

2018-03-16 Thread Michael Heidelbach 
michaelh updated this revision to Diff 29683.
michaelh added a comment.


  - Turn FileInfo into a struct again

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11285?vs=29594=29683

BRANCH
  sanitize-class (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11285

AFFECTED FILES
  src/engine/CMakeLists.txt
  src/engine/Messages.sh
  src/engine/databasesanitizer.cpp
  src/engine/databasesanitizer.h
  src/engine/documenturldb.cpp
  src/engine/transaction.h

To: michaelh, #baloo, #frameworks, ngraham, mlaurent
Cc: mlaurent, ngraham, smithjd, ashaposhnikov, michaelh, astippich, spoorun, 
nicolasfella, alexeymin

D11390: new icons for disconnected/disabled devices

2018-03-16 Thread Marco Martin 
mart added a comment.


  F5755807: Spectacle.W12059.png 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11390

To: mart, #plasma, #vdg
Cc: #frameworks, michaelh, ngraham

D11390: new icons for disconnected/disabled devices

2018-03-16 Thread Marco Martin 
mart created this revision.
mart added reviewers: Plasma, VDG.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
mart requested review of this revision.

REVISION SUMMARY
  there were some icons which conveyed meaning solely by color
  which is discouraged by the hig
  https://community.kde.org/KDE_Visual_Design_Group/HIG/Color
  this makes use of the little x corner icons that are already
  used somewhere in breeze (like muted microphone)
  the exception is wireless off that has a bar, so a stronger
  this is disabled message than wireless-disconnected
  
  depends on the added opacity of D10243  
which should go in asap

TEST PLAN
  they all look readable at 100% zoom

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/network

REVISION DETAIL
  https://phabricator.kde.org/D11390

AFFECTED FILES
  src/desktoptheme/breeze/icons/network.svgz

To: mart, #plasma, #vdg
Cc: #frameworks, michaelh, ngraham

D11285: Introduce sanitizer class

2018-03-16 Thread Laurent Montel 
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> databasesanitizer.cpp:46
> +public:
> +FileInfo(const quint32 d = 0, const quint32 i = 0, 
> +const QString& u = QString(), const bool a = true)

you can replace this constructor by initialize directly variable

> bool accessible = true;
=

etc.

> it avoids to create this constructor
==

> databasesanitizer.cpp:99
> +QVector excludeIds;
> +for (const auto& deviceId : deviceIds) {
> +if (deviceId > 0) {

const auto & for a quint32
it's better to use directly quint32 without const'ref

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11285

To: michaelh, #baloo, #frameworks, ngraham, mlaurent
Cc: mlaurent, ngraham, smithjd, ashaposhnikov, michaelh, astippich, spoorun, 
nicolasfella, alexeymin

D11365: also test for value types in taglibextractortest and fix errors

2018-03-16 Thread Michael Heidelbach 
michaelh added a comment.


  Just in case you didn't use data-driven tests on purpose: 
https://doc.qt.io/qt-5/qttestlib-tutorial2-example.html

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D11365

To: astippich, #frameworks, #baloo
Cc: michaelh, #frameworks, ashaposhnikov, astippich, spoorun, nicolasfella, 
ngraham, alexeymin

D11388: Provide androiddeployqt with all prefix paths

2018-03-16 Thread Volker Krause 
vkrause created this revision.
vkrause added a reviewer: Build System.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added a subscriber: Frameworks.
vkrause requested review of this revision.

REVISION SUMMARY
  This is needed for a new feature in Qt 5.12, making androiddepolyqt's
  recursive dependency resolution avaiable for components installed in
  different prefixes too.
  
  This will allow us to drop our own partial ELF dependency parsing code
  eventually, as well as avoid having to do workarounds like linking against
  all indirect dependencies.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11388

AFFECTED FILES
  toolchain/Android.cmake
  toolchain/deployment-file.json.in

To: vkrause, #build_system
Cc: #frameworks, michaelh, ngraham

D6313: Support Icon Scale from Icon naming specification 0.13

2018-03-16 Thread Kai Uwe Broulik 
broulik updated this revision to Diff 29668.
broulik retitled this revision from "WIP: Support device pixel ratio in icon 
loader and engine" to "Support Icon Scale from Icon naming specification 0.13".
broulik edited the summary of this revision.
broulik edited the test plan for this revision.

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6313?vs=15690=29668

REVISION DETAIL
  https://phabricator.kde.org/D6313

AFFECTED FILES
  src/kiconengine.cpp
  src/kiconengine.h
  src/kiconloader.cpp
  src/kiconloader.h
  src/kicontheme.cpp
  src/kicontheme.h

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D6313: WIP: Support device pixel ratio in icon loader and engine

2018-03-16 Thread Kai Uwe Broulik 
broulik added a comment.


  Not really, I recently wanted to update this patch to include support for 
Icon Scale definition but ran into a dead-end of having to pass through the 
scale in 50 places... I think I'll give it a go once more but only special 
casing SVGs and leaving everything unchanged.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10251: [RFC] Use mipmap filtering in window thumbnails

2018-03-16 Thread Kai Uwe Broulik 
broulik added a comment.


  What's the state of this? Bug 391915 just cropped up

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10251

To: fredrik, #plasma, #vdg
Cc: broulik, ngraham, hein, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11360: provide sample rate in kHz

2018-03-16 Thread Alexander Stippich 
astippich updated this revision to Diff 29662.
astippich added a comment.


  - use qlatin1string for comparison and do not display trailing zeros

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11360?vs=29621=29662

BRANCH
  sample_rate

REVISION DETAIL
  https://phabricator.kde.org/D11360

AFFECTED FILES
  src/widgetfactory.cpp

To: astippich, #frameworks, #baloo
Cc: elvisangelaccio, ashaposhnikov, astippich, spoorun, nicolasfella, alexeymin