D11733: Allow opening items from the open/save dialogs

[Kai Uwe Broulik]

broulik added a comment.


  Shouldn't this be using the "Open With" menu? If I'm in the Open dialog for 
Kate and click "Open" for a text file, it will just open in a new Kate instance 
(rather than opening in the application the dialog belongs to as I would expect 
from naming)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11733

To: ngraham, #dolphin, #frameworks
Cc: broulik, michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 38 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/38/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 27 Mar 2018 06:03:40 +
 Build duration:
39 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31644/59709)38%
(18587/48946)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8594/9142)48%
(5247/10833)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)59%
(8404/14352)50%
(4899/9728)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3892/7882)33%
(1637/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(518/1007)41%
(414/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.9 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.9/18/
 Project:
Frameworks kservice kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 27 Mar 2018 06:06:05 +
 Build duration:
34 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.ksycocatest

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 30 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/30/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 27 Mar 2018 06:08:05 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report25%
(5/20)30%
(17/56)30%
(17/56)21%
(443/2108)21%
(264/1250)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)97%
(150/155)62%
(117/188)src100%
(8/8)100%
(8/8)68%
(205/303)47%
(111/237)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/142)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/188)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)63%
(30/48)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/122)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%
(0/0)src.widgets100%
(2/2)100%
(2/2)96%
(48/50)60%
(6/10)tests0%
   

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 188 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/188/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 27 Mar 2018 06:03:40 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31595/59707)38%
(18566/48950)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8594/9142)48%
(5249/10833)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8349/14350)50%
(4876/9724)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3892/7882)33%
(1637/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(518/1007)41%
(414/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/23/
 Project:
Frameworks kservice kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 27 Mar 2018 06:06:05 +
 Build duration:
9 min 36 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kplugininfotestFailed: TestSuite.kservicetestFailed: TestSuite.ksycocathreadtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)83%
(73/88)83%
(73/88)68%
(5508/8117)48%
(3182/6680)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)84%
(1307/1560)45%
(907/2007)src.kbuildsycoca100%
(1/1)100%
(1/1)92%
(54/59)68%
(15/22)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/334)0%
(0/278)src.plugin67%
(2/3)67%
(2/3)49%
(47/96)42%
(44/106)src.services97%
(29/30)97%
(29/30)61%
(1849/3036)41%
(818/1982)src.sycoca83%
(25/30)83%
(25/30)77%
(2143/2794)62%
(1365/2197)tests0%
(0/5)0%
(0/5)0%
(0/118)0%
(0/40)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(108/120)69%
(33/48)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 167 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/167/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 27 Mar 2018 06:03:40 +
 Build duration:
11 min and counting
   CONSOLE OUTPUT
  [...truncated 304.05 KB...]Scanning dependencies of target udsentry_benchmark_autogen[ 27%] Automatic MOC for target udsentry_benchmark[ 27%] Built target urlutiltest_autogenScanning dependencies of target udsentrytest_autogen[ 27%] Automatic MOC for target udsentrytest[ 27%] Built target deletejobtest_autogenScanning dependencies of target kacltest_autogen[ 27%] Automatic MOC for target kacltest[ 27%] Built target udsentrytest_autogenScanning dependencies of target mkpathjobtest_autogen[ 27%] Automatic MOC for target mkpathjobtest[ 27%] Built target udsentry_benchmark_autogenScanning dependencies of target threadtest_autogen[ 27%] Automatic MOC for target threadtest[ 27%] Built target kacltest_autogenScanning dependencies of target kprotocolinfotest_autogen[ 27%] Automatic MOC for target kprotocolinfotest[ 27%] Built target mkpathjobtest_autogenScanning dependencies of target globaltest_autogen[ 27%] Automatic MOC for target globaltest[ 27%] Built target threadtest_autogenScanning dependencies of target klocalsockettest_autogen[ 27%] Automatic MOC for target klocalsockettest[ 27%] Built target globaltest_autogenScanning dependencies of target jobremotetest_autogen[ 27%] Automatic MOC for target jobremotetest[ 27%] Built target kprotocolinfotest_autogenScanning dependencies of target dataprotocoltest_autogen[ 27%] Automatic MOC for target dataprotocoltest[ 27%] Built target jobremotetest_autogenScanning dependencies of target ktcpsockettest_autogen[ 27%] Automatic MOC for target ktcpsockettest[ 27%] Built target dataprotocoltest_autogenScanning dependencies of target privilegejobtest_autogen[ 27%] Automatic MOC for target privilegejobtest[ 27%] Built target klocalsockettest_autogenScanning dependencies of target jobtest_autogen[ 27%] Automatic MOC for target jobtest[ 27%] Built target privilegejobtest_autogenScanning dependencies of target listdirtest_autogen[ 27%] Automatic MOC for target listdirtest[ 27%] Built target ktcpsockettest_autogenScanning dependencies of target kfileitemtest_autogen[ 27%] Automatic MOC for target kfileitemtest[ 27%] Built target jobtest_autogenScanning dependencies of target httpobjecttest_autogen[ 27%] Automatic MOC for target httpobjecttest[ 27%] Built target kfileitemtest_autogenScanning dependencies of target httpauthenticationtest_autogen[ 27%] Built target listdirtest_autogen[ 27%] Automatic MOC for target httpauthenticationtestScanning dependencies of target kcookiejartest_autogen[ 27%] Automatic MOC for target kcookiejartest[ 27%] Built target httpauthenticationtest_autogenScanning dependencies of target kio_file[ 27%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file.cpp.o[ 27%] Built target kcookiejartest_autogenScanning dependencies of target file_helper[ 27%] Building CXX object src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/filehelper.cpp.o[ 27%] Built target httpobjecttest_autogenScanning dependencies of target kio_ghelp[ 28%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/kio_help.cpp.o[ 28%] Building CXX object src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/fdsender.cpp.oIn file included from /usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/kauth/fdsender.cpp:21:/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/kauth/../sharefd_p.h:54:33: warning: braces around scalar initializer [-Wbraced-scalar-init]sockaddr_un a{ AF_UNIX, {0}};^~~/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/kauth/../sharefd_p.h:54:36: warning: missing field 'sun_path' initializer [-Wmissing-field-initializers]sockaddr_un a{ AF_UNIX, {0}};   ^[ 28%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file_unix.cpp.o2 warnings generated.[ 29%] Building CXX object src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/file_helper_autogen/mocs_compilation.cpp.o[ 29%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/main_ghelp.cpp.o[ 29%] Linking CXX executable ../../../../bin/file_helper/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/file_unix.cpp:40:10: fatal error: 'sys/xattr.h' file not found#include  ^1 error generated.gmake[2]: *** [src/ioslaves/file/CMakeFiles/kio_file.dir/build.make:87: src/ioslaves/file/CMakeFiles/kio_file.dir/file_unix.cpp.o] Error 1gmake[1]: *** [CMakeFiles/Makefile2:1611: src/ioslaves/file/CMakeFiles/kio_file.dir/all] Error 2gmake[1]: *** Waiting for unfinished jobs[ 29%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/xslt_help.cpp.o[ 29%] Built target file_helper[ 29%] Buil

KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.9 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.9/7/
 Project:
Frameworks kimageformats kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 27 Mar 2018 06:01:30 +
 Build duration:
5 min 22 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-read-xcf
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)88%
(21/24)88%
(21/24)46%
(1663/3633)38%
(848/2230)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)72%
(273/379)51%
(129/252)src.imageformats94%
(17/18)94%
(17/18)44%
(1386/3120)37%
(717/1920)tests33%
(1/3)33%
(1/3)3%
(4/134)3%
(2/58)

KDE CI: Frameworks kimageformats kf5-qt5 FreeBSDQt5.9 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20FreeBSDQt5.9/12/
 Project:
Frameworks kimageformats kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 27 Mar 2018 06:01:30 +
 Build duration:
1 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kimageformats-read-xcf

KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.10 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.10/15/
 Project:
Frameworks kimageformats kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 27 Mar 2018 06:01:30 +
 Build duration:
1 min 55 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-read-tgaFailed: TestSuite.kimageformats-read-xcfFailed: TestSuite.kimageformats-write-tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)79%
(19/24)79%
(19/24)42%
(1532/3631)36%
(799/2230)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)75%
(283/379)59%
(149/252)src.imageformats83%
(15/18)83%
(15/18)40%
(1245/3118)34%
(648/1920)tests33%
(1/3)33%
(1/3)3%
(4/134)3%
(2/58)

D11569: Improve consistency of "Open With" UI by always showing top app inline

[Nathaniel Graham]

ngraham added a comment.


  I'll leave the string the way it is for now so this can go into Frameworks 
5.45, and change it after the string freeze.

REPOSITORY
  R241 KIO

BRANCH
  open-with-usability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11569

To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio
Cc: mmustac, davidedmundson, broulik, dfaure, elvisangelaccio, anthonyfieroni, 
abetts, michaelh, ngraham

D11733: Allow opening items from the open/save dialogs

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11733

To: ngraham, #dolphin, #frameworks
Cc: michaelh, ngraham

D11735: Make it possible to fully build the project when crosscompiling

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Frameworks, vkrause, dhaumann.
Restricted Application added a project: Frameworks.
apol requested review of this revision.

REVISION SUMMARY
  Use cmake ExternalProject to compile the native tool we need to successfully
  build this framework.
  Makes it much easier to automate builds of the project.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11735

AFFECTED FILES
  src/indexer/CMakeLists.txt

To: apol, #frameworks, vkrause, dhaumann
Cc: michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 37 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/37/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 27 Mar 2018 00:14:38 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31643/59709)38%
(18586/48946)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8594/9142)48%
(5249/10833)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)59%
(8402/14352)50%
(4893/9728)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3892/7882)33%
(1637/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(519/1007)41%
(415/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 187 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/187/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 27 Mar 2018 00:14:38 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31577/59707)38%
(18559/48950)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8594/9142)48%
(5247/10833)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8337/14350)50%
(4872/9724)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3891/7882)33%
(1636/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(518/1007)41%
(414/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 166 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/166/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 27 Mar 2018 00:14:38 +
 Build duration:
6 min 56 sec and counting
   CONSOLE OUTPUT
  [...truncated 299.21 KB...]Scanning dependencies of target http_jobtest_autogen[ 26%] Automatic MOC for target http_jobtest[ 26%] Built target http_jobtest_autogenScanning dependencies of target urlutiltest_autogen[ 27%] Automatic MOC for target urlutiltest[ 27%] Built target urlutiltest_autogenScanning dependencies of target deletejobtest_autogen[ 27%] Automatic MOC for target deletejobtest[ 27%] Built target deletejobtest_autogenScanning dependencies of target udsentry_benchmark_autogen[ 27%] Automatic MOC for target udsentry_benchmark[ 27%] Built target udsentry_benchmark_autogenScanning dependencies of target udsentrytest_autogen[ 27%] Automatic MOC for target udsentrytest[ 27%] Built target udsentrytest_autogenScanning dependencies of target kacltest_autogen[ 27%] Automatic MOC for target kacltest[ 27%] Built target kacltest_autogenScanning dependencies of target mkpathjobtest_autogen[ 27%] Automatic MOC for target mkpathjobtest[ 27%] Built target mkpathjobtest_autogenScanning dependencies of target threadtest_autogen[ 27%] Automatic MOC for target threadtest[ 27%] Built target threadtest_autogenScanning dependencies of target kprotocolinfotest_autogen[ 27%] Automatic MOC for target kprotocolinfotest[ 27%] Built target kprotocolinfotest_autogenScanning dependencies of target globaltest_autogen[ 27%] Automatic MOC for target globaltest[ 27%] Built target globaltest_autogenScanning dependencies of target klocalsockettest_autogen[ 27%] Automatic MOC for target klocalsockettest[ 27%] Built target klocalsockettest_autogenScanning dependencies of target jobremotetest_autogen[ 27%] Automatic MOC for target jobremotetest[ 27%] Built target jobremotetest_autogenScanning dependencies of target dataprotocoltest_autogen[ 27%] Automatic MOC for target dataprotocoltest[ 27%] Built target dataprotocoltest_autogenScanning dependencies of target ktcpsockettest_autogen[ 27%] Automatic MOC for target ktcpsockettest[ 27%] Built target ktcpsockettest_autogenScanning dependencies of target privilegejobtest_autogen[ 27%] Automatic MOC for target privilegejobtest[ 27%] Built target privilegejobtest_autogenScanning dependencies of target jobtest_autogen[ 27%] Automatic MOC for target jobtest[ 27%] Built target jobtest_autogenScanning dependencies of target listdirtest_autogen[ 27%] Automatic MOC for target listdirtest[ 27%] Built target listdirtest_autogenScanning dependencies of target kfileitemtest_autogen[ 27%] Automatic MOC for target kfileitemtest[ 27%] Built target kfileitemtest_autogenScanning dependencies of target httpobjecttest_autogen[ 27%] Automatic MOC for target httpobjecttest[ 27%] Built target httpobjecttest_autogenScanning dependencies of target httpauthenticationtest_autogen[ 27%] Automatic MOC for target httpauthenticationtest[ 27%] Built target httpauthenticationtest_autogenScanning dependencies of target kcookiejartest_autogen[ 27%] Automatic MOC for target kcookiejartest[ 27%] Built target kcookiejartest_autogenScanning dependencies of target kio_file[ 27%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file.cpp.o[ 27%] Built target KF5KIOWidgets_autogen[ 27%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file_unix.cpp.oScanning dependencies of target file_helper[ 27%] Building CXX object src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/filehelper.cpp.o/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/file_unix.cpp:40:10: fatal error: 'sys/xattr.h' file not found#include  ^1 error generated.gmake[2]: *** [src/ioslaves/file/CMakeFiles/kio_file.dir/build.make:87: src/ioslaves/file/CMakeFiles/kio_file.dir/file_unix.cpp.o] Error 1gmake[1]: *** [CMakeFiles/Makefile2:1611: src/ioslaves/file/CMakeFiles/kio_file.dir/all] Error 2gmake[1]: *** Waiting for unfinished jobs[ 27%] Building CXX object src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/fdsender.cpp.o[ 28%] Building CXX object src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/file_helper_autogen/mocs_compilation.cpp.oIn file included from /usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/kauth/fdsender.cpp:21:/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/kauth/../sharefd_p.h:54:33: warning: braces around scalar initializer [-Wbraced-scalar-init]sockaddr_un a{ AF_UNIX, {0}};^~~/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/kauth/../sharefd_p.h:54:36: warning: missing field 'sun_path' initializer [-Wmissing-field-initializers]sockaddr_un a{ AF_UNIX, {0}};   ^2 warnings generated.[ 28%] Linking CXX e

D11734: Have KIO build for Android

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
apol requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11734

AFFECTED FILES
  src/CMakeLists.txt
  src/core/kmountpoint.cpp
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/kauth/fdsender.cpp
  src/ioslaves/file/sharefd_p.h
  src/widgets/kurlcompletion.cpp
  src/widgets/previewjob.cpp

To: apol, #frameworks
Cc: michaelh, ngraham

D11605: Fix look-up of KF5::Auth

[Aleix Pol Gonzalez]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:96f58a28febd: Fix look-up of KF5::Auth (authored by apol).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11605?vs=30289&id=30675

REVISION DETAIL
  https://phabricator.kde.org/D11605

AFFECTED FILES
  CMakeLists.txt

To: apol, #frameworks
Cc: michaelh, ngraham

D11733: Allow opening items from the open/save dialogs

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Dolphin, Frameworks.
Restricted Application added a project: Frameworks.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch adds an Open menu item to the open/save dialogs' context menu.
  
  FEATURE: 392329

TEST PLAN
  I am not 100% on this feature. The bug report requested the feature for 
previewing files, but maybe the issue is discoverability of the inline and 
aside previews? This patch is offered as much for discussion as to implement 
the feature and close the bug, but it does work:
  
  - Right-click on a file > Open -> Opens the file in the default app for it
  - Right-click on a folder > Open -> Opens the folder
  - Right-click on the background > Open -> Opens the parent folder
  - One issue is that if the item opens in the very same app that invoked the 
open/save dialog, the resulting window can't actually be interacted with or 
closed because the dialog is modal.
  
  [image goes here]

REPOSITORY
  R241 KIO

BRANCH
  add-open-to-context-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11733

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h

To: ngraham, #dolphin, #frameworks
Cc: michaelh, ngraham

D11733: Allow opening items from the open/save dialogs

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11733

To: ngraham, #dolphin, #frameworks
Cc: michaelh, ngraham

D11732: Improve protocols documentation

[Roman Gilg]

romangg added a comment.


  Currently I'm reading through these protocols for my 5.13 color correction 
work and I was wondering about the output management related protocol 
documentation, which seems to me faulty in large areas. In fact it seems to me 
so wrong, that I'm asking myself if I just don't understand it fully. Since I 
haven't yet written Wayland protocols please take this into account when 
reviewing my changes.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11732

To: romangg, #frameworks
Cc: michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 186 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/186/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 26 Mar 2018 22:26:57 +
 Build duration:
29 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31577/59707)38%
(18559/48950)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8594/9142)48%
(5245/10833)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8337/14350)50%
(4872/9724)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3891/7882)33%
(1636/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(518/1007)41%
(414/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12

D11732: Improve protocols documentation

[Roman Gilg]

romangg created this revision.
romangg added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
romangg requested review of this revision.

REVISION SUMMARY
  Improves the outputmanagement and outputdevice protocol documentation.

REPOSITORY
  R127 KWayland

BRANCH
  improveOutputManagementDoc

REVISION DETAIL
  https://phabricator.kde.org/D11732

AFFECTED FILES
  src/client/protocols/output-management.xml
  src/client/protocols/outputdevice.xml

To: romangg, #frameworks
Cc: michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 36 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/36/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 26 Mar 2018 22:26:57 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31648/59709)38%
(18584/48946)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8594/9142)48%
(5248/10833)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)59%
(8403/14352)50%
(4895/9728)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3892/7882)33%
(1637/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(518/1007)41%
(414/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 165 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/165/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 26 Mar 2018 22:26:57 +
 Build duration:
4 min 6 sec and counting
   CONSOLE OUTPUT
  [...truncated 315.04 KB...][ 27%] Automatic MOC for target privilegejobtest[ 27%] Built target dataprotocoltest_autogenScanning dependencies of target listdirtest_autogen[ 27%] Automatic MOC for target jobtest[ 27%] Automatic MOC for target listdirtestScanning dependencies of target kfileitemtest_autogen[ 27%] Automatic MOC for target kfileitemtest[ 27%] Built target ktcpsockettest_autogen[ 27%] Built target privilegejobtest_autogenScanning dependencies of target httpobjecttest_autogenScanning dependencies of target httpauthenticationtest_autogen[ 27%] Automatic MOC for target httpobjecttest[ 27%] Built target jobtest_autogen[ 27%] Built target listdirtest_autogen[ 27%] Built target kfileitemtest_autogen[ 27%] Automatic MOC for target httpauthenticationtestScanning dependencies of target kcookiejartest_autogenScanning dependencies of target file_helperScanning dependencies of target kio_file[ 27%] Automatic MOC for target kcookiejartest[ 27%] Building CXX object src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/filehelper.cpp.o[ 27%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file.cpp.o[ 27%] Built target httpauthenticationtest_autogenScanning dependencies of target kio_ghelp[ 28%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/kio_help.cpp.o[ 28%] Built target kcookiejartest_autogen[ 28%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/main_ghelp.cpp.o[ 28%] Built target httpobjecttest_autogen[ 28%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/xslt_help.cpp.o[ 28%] Building CXX object src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/fdsender.cpp.oScanning dependencies of target kio_help[ 28%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file_unix.cpp.o[ 28%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/kio_help.cpp.oIn file included from /usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/kauth/fdsender.cpp:21:/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/kauth/../sharefd_p.h:54:33: warning: braces around scalar initializer [-Wbraced-scalar-init]sockaddr_un a{ AF_UNIX, {0}};^~~/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/kauth/../sharefd_p.h:54:36: warning: missing field 'sun_path' initializer [-Wmissing-field-initializers]sockaddr_un a{ AF_UNIX, {0}};   ^[ 29%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/fdreceiver.cpp.o2 warnings generated.[ 30%] Building CXX object src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/file_helper_autogen/mocs_compilation.cpp.o[ 30%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/kio_ghelp_autogen/mocs_compilation.cpp.o[ 30%] Linking CXX shared module ../../../bin/kf5/kio/ghelp.so[ 30%] Built target kio_ghelp[ 30%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/kio_file_autogen/mocs_compilation.cpp.o/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/file_unix.cpp:40:10: fatal error: 'sys/xattr.h' file not found#include  ^1 error generated.gmake[2]: *** [src/ioslaves/file/CMakeFiles/kio_file.dir/build.make:87: src/ioslaves/file/CMakeFiles/kio_file.dir/file_unix.cpp.o] Error 1gmake[2]: *** Waiting for unfinished jobs[ 31%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/main.cpp.oIn file included from /usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/fdreceiver.cpp:23:/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/sharefd_p.h:54:33: warning: braces around scalar initializer [-Wbraced-scalar-init]sockaddr_un a{ AF_UNIX, {0}};^~~/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/sharefd_p.h:54:36: warning: missing field 'sun_path' initializer [-Wmissing-field-initializers]sockaddr_un a{ AF_UNIX, {0}};   ^[ 31%] Linking CXX executable ../../../../bin/file_helper2 warnings generated.[ 31%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/xslt_help.cpp.o[ 31%] Built target file_helperScanning dependencies of target kio_http_cache_cleaner[ 31%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/kio_help_autogen/mocs_compilation.cpp.o[ 31%] Building CXX object src/ioslaves/http/CMakeFiles/kio_http_cache_cleaner.dir/http_cache_cleaner.cpp.oScanning dependencies of target kio_http[ 31%] Building CXX object src/ioslaves/http/CMakeFiles/kio_http.dir/http.cpp.ogmake[1]: *** [CMakeFiles/Makefile2:1611: 

D11705: Highlight selected items when showing parent folder from the open/save dialog

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:05fe10da0034: Highlight selected items when showing 
parent folder from the open/save dialog (authored by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11705?vs=30622&id=30668

REVISION DETAIL
  https://phabricator.kde.org/D11705

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: ngraham, #frameworks, broulik
Cc: broulik, michaelh, ngraham

D11685: Implement single click on line number to select line of text

[Randy Kron]

rkron edited the summary of this revision.
rkron edited the test plan for this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11685

To: rkron, #frameworks, #kate, #ktexteditor, ngraham
Cc: richardbowen, ngraham, #ktexteditor, #kate, #frameworks, michaelh, 
kevinapavew, demsking, cullmann, sars, dhaumann

D11569: Improve consistency of "Open With" UI by always showing top app inline

[Henrik Fehlauer]

rkflx added a comment.


  In D11569#234901 , @ngraham wrote:
  
  > I rather prefer Open With > Other Application... myself, and can change it 
back if folks prefer (I thought you wanted it this way, sorry!).
  
  
  That's what I reckoned, and even recommended above :)
  
  In D11569#232564 , @rkflx wrote:
  
  > Open With…
  >  Open With Gwenview, Open With…
  >  Open With Gwenview, Open With > Other Application…
  
  
  If you change it, make sure though to wait until the string freeze is over…

REPOSITORY
  R241 KIO

BRANCH
  open-with-usability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11569

To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio
Cc: mmustac, davidedmundson, broulik, dfaure, elvisangelaccio, anthonyfieroni, 
abetts, michaelh, ngraham

D11569: Improve consistency of "Open With" UI by always showing top app inline

[Nathaniel Graham]

ngraham added a comment.


  I rather prefer Open With > Other Application... myself, and can change it 
back if folks prefer (I thought you wanted it this way, sorry!).

REPOSITORY
  R241 KIO

BRANCH
  open-with-usability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11569

To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio
Cc: mmustac, davidedmundson, broulik, dfaure, elvisangelaccio, anthonyfieroni, 
abetts, michaelh, ngraham

D11569: Improve consistency of "Open With" UI by always showing top app inline

[Henrik Fehlauer]

rkflx accepted this revision.
rkflx added a comment.
This revision is now accepted and ready to land.


  You probably had your reasons for also changing back Open With > Other 
Application…, but I guess this way it's fine too. Accepting for now.
  
  If there are no further objections until Thursday (i.e. it's been a week 
under review in total), I think this can land (because the string freeze does 
not apply anymore).

REPOSITORY
  R241 KIO

BRANCH
  open-with-usability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11569

To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio
Cc: mmustac, davidedmundson, broulik, dfaure, elvisangelaccio, anthonyfieroni, 
abetts, michaelh, ngraham

D10803: handle more tags in taglibextractor

[Matthieu Gallien]

mgallien accepted this revision.
mgallien added a comment.
This revision is now accepted and ready to land.


  I am really sorry. I had missed that you had modified the diff to only 
include the safe set of changes. I should really apologize.
  Thanks for your work, it is very much appreciated.

REPOSITORY
  R286 KFileMetaData

BRANCH
  enhance_taglib

REVISION DETAIL
  https://phabricator.kde.org/D10803

To: astippich, mgallien, ngraham
Cc: vhanda, dfaure, michaelh, ngraham, #frameworks, ashaposhnikov, astippich, 
spoorun, nicolasfella, alexeymin

D11183: Sonnet: don't impose the default client

[René J . V . Bertin]

rjvbb set the repository for this revision to R246 Sonnet.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D11183

To: rjvbb, #frameworks, cullmann, dfaure, mlaurent, vkrause
Cc: mwolff, kde-frameworks-devel, michaelh, ngraham

D11183: Sonnet: don't impose the default client

[René J . V . Bertin]

rjvbb updated this revision to Diff 30657.
rjvbb marked an inline comment as done.
rjvbb added a comment.


  next iteration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11183?vs=30617&id=30657

REVISION DETAIL
  https://phabricator.kde.org/D11183

AFFECTED FILES
  src/core/loader.cpp

To: rjvbb, #frameworks, cullmann, dfaure, mlaurent, vkrause
Cc: mwolff, kde-frameworks-devel, michaelh, ngraham

D11183: Sonnet: don't impose the default client

[René J . V . Bertin]

rjvbb marked 4 inline comments as done.
rjvbb added a comment.


  > If I suggest something and Milian suggests something else then Milian is 
right :-)
  
  Unconditionally? :)

INLINE COMMENTS

> dfaure wrote in loader.cpp:114
> can this ever happen now that you set it if it was empty? If it can happen 
> (because defaultClient() can return empty) then the any_of block needs an if 
> (!backend.isEmpty()) around it.

Yes, defaultClient() just returns whatever is in Sonnet.ini, which can be an 
empty string.
We just do nothing if that's the case (instead of doing a useless any_of 
followed by a qWarning as happens right now)?

Note that the extra if does have to be inside the initial `if 
(backend.isEmpty())`, and not after it.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D11183

To: rjvbb, #frameworks, cullmann, dfaure, mlaurent, vkrause
Cc: mwolff, kde-frameworks-devel, michaelh, ngraham

D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> file_unix.cpp:416
>  
> -#ifdef Q_OS_LINUX
> +#ifdef HAVE_SYS_XATTR_H
>  static bool isNtfsHidden(const QString &filename)

should be #if, not #ifdef.

It's always defined, to either 0 or 1.

> file_unix.cpp:550
>  if (createUDSEntry(filename, QByteArray(ep->d_name), entry, 
> details)) {
> -#ifdef Q_OS_LINUX
> +#ifdef HAVE_SYS_XATTR_H
>  if (isNtfsHidden(filename)) {

same

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11716

To: rominf, #dolphin, kossebau, dfaure
Cc: #frameworks, michaelh, ngraham

D11183: Sonnet: don't impose the default client

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I suggested find_if because I didn't think about any_of, which is even better 
indeed :-)
  If I suggest something and Milian suggests something else then Milian is 
right :-)

INLINE COMMENTS

> loader.cpp:114
>  Client *item = itr.next();
>  if (!backend.isEmpty()) {
>  if (backend == item->name()) {

can this ever happen now that you set it if it was empty? If it can happen 
(because defaultClient() can return empty) then the any_of block needs an if 
(!backend.isEmpty()) around it.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D11183

To: rjvbb, #frameworks, cullmann, dfaure, mlaurent, vkrause
Cc: mwolff, kde-frameworks-devel, michaelh, ngraham

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 41 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/41/
 Project:
Frameworks kpackage kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 26 Mar 2018 15:52:51 +
 Build duration:
2 min 10 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testjsonmetadatapackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackagesdep-appstreamFailed: TestSuite.testpackagesdepinvalid-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)96%
(27/28)96%
(27/28)73%
(1624/2219)51%
(1277/2501)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(12/12)100%
(12/12)100%
(546/548)51%
(329/642)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(560/757)64%
(659/1037)src.kpackage.private100%
(8/8)100%
(8/8)79%
(294/370)52%
(128/246)src.kpackagetool100%
(3/3)100%
(3/3)40%
(210/526)27%
(154/564)

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/18/
 Project:
Frameworks kpackage kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 26 Mar 2018 15:52:51 +
 Build duration:
1 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testjsonmetadatapackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackagesdep-appstreamFailed: TestSuite.testpackagesdepinvalid-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)96%
(27/28)96%
(27/28)73%
(1624/2219)51%
(1277/2501)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(12/12)100%
(12/12)100%
(546/548)51%
(329/642)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(560/757)64%
(659/1037)src.kpackage.private100%
(8/8)100%
(8/8)79%
(294/370)52%
(128/246)src.kpackagetool100%
(3/3)100%
(3/3)40%
(210/526)27%
(154/564)

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/35/
 Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 26 Mar 2018 15:52:51 +
 Build duration:
1 min 12 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.plasma-packagestructuretestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testjsonmetadatapackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstreamFailed: TestSuite.testpackagesdep-appstreamFailed: TestSuite.testpackagesdepinvalid-appstream

D11705: Highlight selected items when showing parent folder from the open/save dialog

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11705

REVISION DETAIL
  https://phabricator.kde.org/D11705

To: ngraham, #frameworks, broulik
Cc: broulik, michaelh, ngraham

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 40 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/40/
 Project:
Frameworks kpackage kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 26 Mar 2018 14:08:45 +
 Build duration:
5 min 58 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testjsonmetadatapackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackagesdep-appstreamFailed: TestSuite.testpackagesdepinvalid-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)96%
(27/28)96%
(27/28)73%
(1624/2219)51%
(1277/2501)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(12/12)100%
(12/12)100%
(546/548)51%
(329/642)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(560/757)64%
(659/1037)src.kpackage.private100%
(8/8)100%
(8/8)79%
(294/370)52%
(128/246)src.kpackagetool100%
(3/3)100%
(3/3)40%
(210/526)27%
(154/564)

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/17/
 Project:
Frameworks kpackage kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 26 Mar 2018 14:08:45 +
 Build duration:
4 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testjsonmetadatapackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackagesdep-appstreamFailed: TestSuite.testpackagesdepinvalid-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)96%
(27/28)96%
(27/28)73%
(1624/2219)51%
(1277/2501)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(12/12)100%
(12/12)100%
(546/548)51%
(329/642)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(560/757)64%
(659/1037)src.kpackage.private100%
(8/8)100%
(8/8)79%
(294/370)52%
(128/246)src.kpackagetool100%
(3/3)100%
(3/3)40%
(210/526)27%
(154/564)

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 34 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/34/
 Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 26 Mar 2018 14:08:45 +
 Build duration:
1 min 10 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.plasma-packagestructuretestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testjsonmetadatapackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstreamFailed: TestSuite.testpackagesdep-appstreamFailed: TestSuite.testpackagesdepinvalid-appstream

D11717: regenerate qrc on every build

[Bhushan Shah]

This revision was automatically updated to reflect the committed changes.
Closed by commit R290:f3619363ed63: regenerate qrc on every build (authored by 
bshah).

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11717?vs=30628&id=30631

REVISION DETAIL
  https://phabricator.kde.org/D11717

AFFECTED FILES
  KF5PackageMacros.cmake
  qrc.cmake

To: bshah, mart, davidedmundson
Cc: #frameworks, michaelh, ngraham

D11717: regenerate qrc on every build

[David Edmundson]

davidedmundson accepted this revision.

REPOSITORY
  R290 KPackage

BRANCH
  regenerateqrc

REVISION DETAIL
  https://phabricator.kde.org/D11717

To: bshah, mart, davidedmundson
Cc: #frameworks, michaelh, ngraham

D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa

[Friedrich W . H . Kossebau]

kossebau added a comment.


  From quick pure code reading this looks fine to me. +1
  
  Have not tested though right now, so have to leave the ship-it to actual 
Dolphin/KIO maintainers.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11716

To: rominf, #dolphin, kossebau, dfaure
Cc: #frameworks, michaelh, ngraham

D11717: regenerate qrc on every build

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R290 KPackage

BRANCH
  regenerateqrc

REVISION DETAIL
  https://phabricator.kde.org/D11717

To: bshah, mart
Cc: #frameworks, michaelh, ngraham

D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa

[Roman Inflianskas]

rominf updated this revision to Diff 30629.
rominf added a comment.


  - Consider criticism

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11716?vs=30627&id=30629

BRANCH
  fix-ntfs-hidden-files-on-freebsd

REVISION DETAIL
  https://phabricator.kde.org/D11716

AFFECTED FILES
  src/ioslaves/file/CMakeLists.txt
  src/ioslaves/file/config-kioslave-file.h.cmake
  src/ioslaves/file/file_unix.cpp

To: rominf, #dolphin, kossebau, dfaure
Cc: #frameworks, michaelh, ngraham

D11717: regenerate qrc on every build

[Bhushan Shah]

bshah created this revision.
bshah added a reviewer: mart.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
bshah requested review of this revision.

REVISION SUMMARY
  this will ensure that file deletion and inclusion are taken care of when
  running build

TEST PLAN
  - kdeplasma-addons
  - clean build works
  - Add a file in comic applet
  - run make
  - ensure qrc file contains new file
  - install
  - run applet ensure new file is there
  - remove new qml file
  - install
  - ensure that file is removed from qrc and rcc

REPOSITORY
  R290 KPackage

BRANCH
  regenerateqrc

REVISION DETAIL
  https://phabricator.kde.org/D11717

AFFECTED FILES
  KF5PackageMacros.cmake
  qrc.cmake

To: bshah, mart
Cc: #frameworks, michaelh, ngraham

D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa

[Friedrich W . H . Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> config-kioslave-file.h.cmake:14
> +/* Defined if system has extended file attributes support. */
> +#cmakedefine01 HAVE_SYS_XATTR_H

While FindACL.cmake sets internally the cmake variable HAVE_SYS_XATTR_H, it is 
not part of the officially set variables (cmp. notes in header of that file)

So more future-proof will be to do an explicit

  check_include_files(sys/xattr.h HAVE_SYS_XATTR_H)

in src/ioslaves/file/CMakeLists.txt instead of reyling on an undocumented 
side-effect of `find_package(ACL)`.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11716

To: rominf, #dolphin, kossebau, dfaure
Cc: #frameworks, michaelh, ngraham

D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa

[Roman Inflianskas]

rominf updated this revision to Diff 30627.
rominf added a comment.


  - Add a trailing newline to the end of the file

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11716?vs=30626&id=30627

BRANCH
  fix-ntfs-hidden-files-on-freebsd

REVISION DETAIL
  https://phabricator.kde.org/D11716

AFFECTED FILES
  src/ioslaves/file/config-kioslave-file.h.cmake
  src/ioslaves/file/file_unix.cpp

To: rominf, #dolphin, kossebau, dfaure
Cc: #frameworks, michaelh, ngraham

D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa

[Roman Inflianskas]

rominf updated this revision to Diff 30626.
rominf added a comment.


  - Actualy fixing build

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11716?vs=30625&id=30626

BRANCH
  fix-ntfs-hidden-files-on-freebsd

REVISION DETAIL
  https://phabricator.kde.org/D11716

AFFECTED FILES
  src/ioslaves/file/config-kioslave-file.h.cmake
  src/ioslaves/file/file_unix.cpp

To: rominf, #dolphin, kossebau, dfaure
Cc: #frameworks, michaelh, ngraham

D11705: Highlight selected items when showing parent folder from the open/save dialog

[Nathaniel Graham]

ngraham added a comment.


  Also, we have a request to add an Open action to the menu 
(https://bugs.kde.org/show_bug.cgi?id=392329), which would take care of the use 
case of wanting to directly open the folder. I plan to submit a patch for that, 
too.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11705

To: ngraham, #frameworks
Cc: broulik, michaelh, ngraham

D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Thanks for coming up so quick with a fix :)
  
  You surely wanted to also wrap the include of the "sys/xattr.h" header in the 
new condition? Missing from the patch.

INLINE COMMENTS

> config-kioslave-file.h.cmake:15
> +#cmakedefine01 HAVE_SYS_XATTR_H
> \ No newline at end of file


Please add a trailing newline to the end of the file.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11716

To: rominf, #dolphin, kossebau, dfaure
Cc: #frameworks, michaelh, ngraham

D11204: Support NTFS hidden files

[Roman Inflianskas]

rominf added inline comments.

INLINE COMMENTS

> kossebau wrote in file_unix.cpp:40
> This unconditional include sadly breaks the build at least on FreeBSD (see 
> https://build.kde.org/view/Frameworks/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/164/console
>  ) and other systems where this header is not part of the libc (?) headers.
> 
> So this needs to get some condition checking before using it. Compare other 
> code doing that:
> https://lxr.kde.org/search?_filestring=&_string=xattr.h&_casesensitive=1
> 
> While the xattr.h is already checked for in KIO in the FindACL.cmake file, an 
> explicite check like
> 
>   check_include_files(sys/xattr.h HAVE_SYS_XATTR_H)
> 
> and passing HAVE_SYS_XATTR_H via config-kioslave-file.h.cmake into 
> file_unix.cpp and checking the condition additionally to or instead of 
> Q_OS_LINUX for the new code should solve this issue properly.

I'm sorry for breaking the build. Here is the fix: D11716 


REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11204

To: rominf, #dolphin, #frameworks, dfaure
Cc: kossebau, dfaure, markg, elvisangelaccio, ltoscano, anthonyfieroni, 
broulik, #frameworks, #dolphin, michaelh, ngraham

D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa

[Roman Inflianskas]

rominf created this revision.
rominf added reviewers: Dolphin, kossebau, dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
rominf requested review of this revision.

REVISION SUMMARY
  Support hidden NTFS files only on OS that support extended file attributes. 
For this purpose check if `sys/xattr.h` exist via CMake.

REPOSITORY
  R241 KIO

BRANCH
  fix-ntfs-hidden-files-on-freebsd

REVISION DETAIL
  https://phabricator.kde.org/D11716

AFFECTED FILES
  src/ioslaves/file/config-kioslave-file.h.cmake
  src/ioslaves/file/file_unix.cpp

To: rominf, #dolphin, kossebau, dfaure
Cc: #frameworks, michaelh, ngraham

D11705: Highlight selected items when showing parent folder from the open/save dialog

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11705

To: ngraham, #frameworks
Cc: broulik, michaelh, ngraham

D11705: Highlight selected items when showing parent folder from the open/save dialog

[Nathaniel Graham]

ngraham marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11705

To: ngraham, #frameworks
Cc: broulik, michaelh, ngraham

D11705: Highlight selected items when showing parent folder from the open/save dialog

[Nathaniel Graham]

ngraham added a comment.


  In D11705#234324 , @broulik wrote:
  
  > Good idea.
  >
  > How about folders? Perhaps we should use a different behavior for folders 
as you're imho more likely to want to open a folder in the file manager than 
look "where it is"
  
  
  I kind of like the consistency here; you always know what "Open Containing 
Folder" will do: open the containing folder, no matter what the selected item 
may be. Since it's pre-selected in the window that opens, it's really easy to 
open it if it's a folder and view the contents; just hit the [Return] key 
immediately.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11705

To: ngraham, #frameworks
Cc: broulik, michaelh, ngraham

D11705: Highlight selected items when showing parent folder from the open/save dialog

[Nathaniel Graham]

ngraham updated this revision to Diff 30622.
ngraham added a comment.


  Fix the case where nothing is selected (i.e. when the user right-clicks on 
the background)

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11705?vs=30582&id=30622

BRANCH
  arcpatch-D11705

REVISION DETAIL
  https://phabricator.kde.org/D11705

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: ngraham, #frameworks
Cc: broulik, michaelh, ngraham

D11183: Sonnet: don't impose the default client

[René J . V . Bertin]

rjvbb added a comment.


  > ah, then this should be simplified by using `std::any_of` instead
  
  I was asked to use std::find_if, and (spicey detail) referred to the KDevelop 
code for examples how to use it :)

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D11183

To: rjvbb, #frameworks, cullmann, dfaure, mlaurent, vkrause
Cc: mwolff, kde-frameworks-devel, michaelh, ngraham

D11183: Sonnet: don't impose the default client

[Milian Wolff]

mwolff added inline comments.

INLINE COMMENTS

> cullmann wrote in loader.cpp:103
> Isn't there a == lClients.constEnd() behind that does that?

ah, then this should be simplified by using `std::any_of` instead

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D11183

To: rjvbb, #frameworks, cullmann, dfaure, mlaurent, vkrause
Cc: mwolff, kde-frameworks-devel, michaelh, ngraham

D11204: Support NTFS hidden files

[Roman Inflianskas]

rominf marked 8 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11204

To: rominf, #dolphin, #frameworks, dfaure
Cc: kossebau, dfaure, markg, elvisangelaccio, ltoscano, anthonyfieroni, 
broulik, #frameworks, #dolphin, michaelh, ngraham

D11183: Sonnet: don't impose the default client

[Christoph Cullmann]

cullmann added inline comments.

INLINE COMMENTS

> mwolff wrote in loader.cpp:103
> nope, that's wrong. find_if returns an iterator - in this case a Client* 
> probably that gets converted to bool?

Isn't there a == lClients.constEnd() behind that does that?

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D11183

To: rjvbb, #frameworks, cullmann, dfaure, mlaurent, vkrause
Cc: mwolff, kde-frameworks-devel, michaelh, ngraham

D11183: Sonnet: don't impose the default client

[Milian Wolff]

mwolff added inline comments.

INLINE COMMENTS

> loader.cpp:103
> +// if it does it will be an element of lClients.
> +bool unknown = std::find_if(lClients.constBegin(), 
> lClients.constEnd(), [backend] (const Client *client) {
> +return client->name() == backend; }) == lClients.constEnd();

nope, that's wrong. find_if returns an iterator - in this case a Client* 
probably that gets converted to bool?

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D11183

To: rjvbb, #frameworks, cullmann, dfaure, mlaurent, vkrause
Cc: mwolff, kde-frameworks-devel, michaelh, ngraham

D11183: Sonnet: don't impose the default client

[René J . V . Bertin]

rjvbb marked an inline comment as done.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D11183

To: rjvbb, #frameworks, cullmann, dfaure, mlaurent, vkrause
Cc: kde-frameworks-devel, michaelh, ngraham

D11183: Sonnet: don't impose the default client

[René J . V . Bertin]

rjvbb set the repository for this revision to R246 Sonnet.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D11183

To: rjvbb, #frameworks, cullmann, dfaure, mlaurent, vkrause
Cc: kde-frameworks-devel, michaelh, ngraham

D11183: Sonnet: don't impose the default client

[René J . V . Bertin]

rjvbb updated this revision to Diff 30617.
rjvbb added a comment.


  Modified as requested.
  (Please double-check, it works AFAICT but it's the first time I use this 
construct.)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11183?vs=29244&id=30617

REVISION DETAIL
  https://phabricator.kde.org/D11183

AFFECTED FILES
  src/core/loader.cpp

To: rjvbb, #frameworks, cullmann, dfaure, mlaurent, vkrause
Cc: kde-frameworks-devel, michaelh, ngraham

D11204: Support NTFS hidden files

[Friedrich W . H . Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> file_unix.cpp:40
>  #include 
> +#include 
>  #include 

This unconditional include sadly breaks the build at least on FreeBSD (see 
https://build.kde.org/view/Frameworks/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/164/console
 ) and other systems where this header is not part of the libc (?) headers.

So this needs to get some condition checking before using it. Compare other 
code doing that:
https://lxr.kde.org/search?_filestring=&_string=xattr.h&_casesensitive=1

While the xattr.h is already checked for in KIO in the FindACL.cmake file, an 
explicite check like

  check_include_files(sys/xattr.h HAVE_SYS_XATTR_H)

and passing HAVE_SYS_XATTR_H via config-kioslave-file.h.cmake into 
file_unix.cpp and checking the condition additionally to or instead of 
Q_OS_LINUX for the new code should solve this issue properly.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11204

To: rominf, #dolphin, #frameworks, dfaure
Cc: kossebau, dfaure, markg, elvisangelaccio, ltoscano, anthonyfieroni, 
broulik, #frameworks, #dolphin, michaelh, ngraham

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 39 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/39/
 Project:
Frameworks kpackage kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 26 Mar 2018 09:09:08 +
 Build duration:
3 min 1 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testjsonmetadatapackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackagesdep-appstreamFailed: TestSuite.testpackagesdepinvalid-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)96%
(27/28)96%
(27/28)73%
(1624/2219)51%
(1277/2501)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(12/12)100%
(12/12)100%
(546/548)51%
(329/642)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(560/757)64%
(659/1037)src.kpackage.private100%
(8/8)100%
(8/8)79%
(294/370)52%
(128/246)src.kpackagetool100%
(3/3)100%
(3/3)40%
(210/526)27%
(154/564)

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/16/
 Project:
Frameworks kpackage kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 26 Mar 2018 09:09:08 +
 Build duration:
2 min 48 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testjsonmetadatapackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackagesdep-appstreamFailed: TestSuite.testpackagesdepinvalid-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)96%
(27/28)96%
(27/28)73%
(1624/2219)51%
(1277/2501)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(12/12)100%
(12/12)100%
(546/548)51%
(329/642)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(560/757)64%
(659/1037)src.kpackage.private100%
(8/8)100%
(8/8)79%
(294/370)52%
(128/246)src.kpackagetool100%
(3/3)100%
(3/3)40%
(210/526)27%
(154/564)

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 33 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/33/
 Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 26 Mar 2018 09:09:08 +
 Build duration:
2 min 12 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.plasma-packagestructuretestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testjsonmetadatapackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstreamFailed: TestSuite.testpackagesdep-appstreamFailed: TestSuite.testpackagesdepinvalid-appstream

D11709: Don't create dependency loop

[Bhushan Shah]

This revision was automatically updated to reflect the committed changes.
Closed by commit R290:0a26d53a0f86: Don't create dependency loop (authored 
by bshah).

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11709?vs=30610&id=30611

REVISION DETAIL
  https://phabricator.kde.org/D11709

AFFECTED FILES
  KF5PackageMacros.cmake

To: bshah, romangg, mart
Cc: #frameworks, michaelh, ngraham

D11709: Don't create dependency loop

[Marco Martin]

mart accepted this revision.

REPOSITORY
  R290 KPackage

BRANCH
  fix-kpackag

REVISION DETAIL
  https://phabricator.kde.org/D11709

To: bshah, romangg, mart
Cc: #frameworks, michaelh, ngraham

D11709: Don't create dependency loop

[Roman Gilg]

romangg accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R290 KPackage

BRANCH
  fix-kpackag

REVISION DETAIL
  https://phabricator.kde.org/D11709

To: bshah, romangg
Cc: #frameworks, michaelh, ngraham

D11709: Don't create dependency loop

[Bhushan Shah]

bshah created this revision.
bshah added a reviewer: romangg.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
bshah requested review of this revision.

REVISION SUMMARY
  The code tried to depend on the generated .rcc file which was generated
  by target itself.

TEST PLAN
  tested that plasma-pa now builds with clean dir

REPOSITORY
  R290 KPackage

BRANCH
  fix-kpackag

REVISION DETAIL
  https://phabricator.kde.org/D11709

AFFECTED FILES
  KF5PackageMacros.cmake

To: bshah, romangg
Cc: #frameworks, michaelh, ngraham

Re: Review Request 129025: Enable cross compilation support for packages depending on normally installed kdoctools tools.

[Ralf Habacker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129025/
---

(Updated March 26, 2018, 9:47 a.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, KDE Frameworks and Luigi Toscano.


Repository: kdoctools


Description
---

Enable cross compilation support for packages depending on normally installed 
kdoctools tools.


Diffs
-

  KF5DocToolsConfig.cmake.in 9224fd2788aee5db4340cd0ac8115c1a06ca8ebe 


Diff: https://git.reviewboard.kde.org/r/129025/diff/1/


Testing
---


Thanks,

Ralf Habacker

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/35/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 26 Mar 2018 07:06:52 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31648/59706)38%
(18577/48942)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8594/9142)48%
(5248/10833)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)59%
(8413/14352)50%
(4902/9728)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3892/7879)33%
(1637/4936)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(518/1007)41%
(414/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 185 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/185/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 26 Mar 2018 07:06:52 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31609/59705)38%
(18569/48946)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8594/9142)48%
(5246/10833)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8358/14351)50%
(4879/9724)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3892/7879)33%
(1637/4936)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(518/1007)41%
(414/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12

D11705: Highlight selected items when showing parent folder from the open/save dialog

[Kai Uwe Broulik]

broulik added a comment.


  Good idea.
  
  How about folders? Perhaps we should use a different behavior for folders as 
you're imho more likely to want to open a folder in the file manager than look 
"where it is"

INLINE COMMENTS

> kdiroperator.cpp:666
>  {
> -new KRun(currUrl, parent);
> +KIO::highlightInFileManager(parent->selectedItems().urlList());
>  }

When no folder is selected, this does nothing. It should open the current 
folder instead, or change labels accordingly. "Open With $filemanager" vs "Open 
Containing Folder"

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11705

To: ngraham, #frameworks
Cc: broulik, michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 164 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/164/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 26 Mar 2018 07:06:52 +
 Build duration:
4 min 10 sec and counting
   CONSOLE OUTPUT
  [...truncated 301.84 KB...][ 27%] Built target urlutiltest_autogen[ 27%] Built target deletejobtest_autogenScanning dependencies of target udsentrytest_autogenScanning dependencies of target kacltest_autogenScanning dependencies of target mkpathjobtest_autogen[ 27%] Automatic MOC for target udsentrytest[ 27%] Built target http_jobtest_autogen[ 27%] Automatic MOC for target kacltest[ 27%] Automatic MOC for target mkpathjobtest[ 27%] Built target udsentry_benchmark_autogenScanning dependencies of target threadtest_autogenScanning dependencies of target kprotocolinfotest_autogen[ 27%] Automatic MOC for target threadtest[ 27%] Built target udsentrytest_autogen[ 27%] Automatic MOC for target kprotocolinfotest[ 27%] Built target kacltest_autogenScanning dependencies of target globaltest_autogen[ 27%] Built target mkpathjobtest_autogenScanning dependencies of target klocalsockettest_autogenScanning dependencies of target jobremotetest_autogen[ 27%] Automatic MOC for target globaltest[ 27%] Automatic MOC for target klocalsockettest[ 27%] Automatic MOC for target jobremotetest[ 27%] Built target threadtest_autogen[ 27%] Built target kprotocolinfotest_autogen[ 27%] Built target globaltest_autogenScanning dependencies of target dataprotocoltest_autogenScanning dependencies of target ktcpsockettest_autogenScanning dependencies of target privilegejobtest_autogen[ 27%] Automatic MOC for target dataprotocoltest[ 27%] Built target jobremotetest_autogen[ 27%] Automatic MOC for target ktcpsockettest[ 27%] Automatic MOC for target privilegejobtestScanning dependencies of target jobtest_autogen[ 27%] Automatic MOC for target jobtest[ 27%] Built target dataprotocoltest_autogenScanning dependencies of target listdirtest_autogen[ 27%] Built target privilegejobtest_autogen[ 27%] Automatic MOC for target listdirtestScanning dependencies of target kfileitemtest_autogen[ 27%] Automatic MOC for target kfileitemtest[ 27%] Built target ktcpsockettest_autogen[ 27%] Built target jobtest_autogen[ 27%] Built target klocalsockettest_autogenScanning dependencies of target httpobjecttest_autogenScanning dependencies of target kcookiejartest_autogenScanning dependencies of target httpauthenticationtest_autogen[ 27%] Automatic MOC for target kcookiejartest[ 27%] Automatic MOC for target httpobjecttest[ 27%] Built target listdirtest_autogen[ 27%] Automatic MOC for target httpauthenticationtest[ 27%] Built target kfileitemtest_autogenScanning dependencies of target kio_fileScanning dependencies of target file_helper[ 27%] Building CXX object src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/filehelper.cpp.o[ 27%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file.cpp.o[ 27%] Built target httpauthenticationtest_autogen[ 27%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file_unix.cpp.o[ 27%] Built target kcookiejartest_autogenScanning dependencies of target kio_ghelp[ 28%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/kio_help.cpp.o[ 28%] Built target httpobjecttest_autogen[ 28%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/main_ghelp.cpp.o[ 28%] Building CXX object src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/fdsender.cpp.o/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/file_unix.cpp:40:10: fatal error: 'sys/xattr.h' file not found#include  ^1 error generated.gmake[2]: *** [src/ioslaves/file/CMakeFiles/kio_file.dir/build.make:87: src/ioslaves/file/CMakeFiles/kio_file.dir/file_unix.cpp.o] Error 1gmake[2]: *** Waiting for unfinished jobs[ 28%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/xslt_help.cpp.oIn file included from /usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/kauth/fdsender.cpp:21:/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/kauth/../sharefd_p.h:54:33: warning: braces around scalar initializer [-Wbraced-scalar-init]sockaddr_un a{ AF_UNIX, {0}};^~~/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/kauth/../sharefd_p.h:54:36: warning: missing field 'sun_path' initializer [-Wmissing-field-initializers]sockaddr_un a{ AF_UNIX, {0}};   ^2 warnings generated.[ 29%] Building CXX object src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/file_helper_autogen/mocs_compilation.cpp.ogmake[1]: *** [CMakeFiles/Makefile2:1611: src/ioslaves/file/CMakeFiles/kio_file.dir/all] Error 2gmake[1]: *** Waiting for unfinished jobs[ 29%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/kio_ghelp_autogen/mocs_compilation.cpp.o[ 29%]

D11204: Support NTFS hidden files

[Roman Inflianskas]

rominf closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11204

To: rominf, #dolphin, #frameworks, dfaure
Cc: dfaure, markg, elvisangelaccio, ltoscano, anthonyfieroni, broulik, 
#frameworks, #dolphin, michaelh, ngraham